diff options
author | Rob Herring <robh@kernel.org> | 2015-07-27 16:55:20 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2015-08-11 10:09:01 -0400 |
commit | 9bd09f345e62257958342f712efef644494274fb (patch) | |
tree | 8d1347a13be87f40319cd64598e930b4c32a2f93 /drivers/mfd/wm8994-irq.c | |
parent | 035faf4bd2776237940c95d08bfe8928fe0a80e1 (diff) |
mfd: Kill off set_irq_flags usage
set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:
IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN
For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/wm8994-irq.c')
-rw-r--r-- | drivers/mfd/wm8994-irq.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c index 55c380a67686..6f1427d32a93 100644 --- a/drivers/mfd/wm8994-irq.c +++ b/drivers/mfd/wm8994-irq.c | |||
@@ -172,14 +172,7 @@ static int wm8994_edge_irq_map(struct irq_domain *h, unsigned int virq, | |||
172 | irq_set_chip_data(virq, wm8994); | 172 | irq_set_chip_data(virq, wm8994); |
173 | irq_set_chip_and_handler(virq, &wm8994_edge_irq_chip, handle_edge_irq); | 173 | irq_set_chip_and_handler(virq, &wm8994_edge_irq_chip, handle_edge_irq); |
174 | irq_set_nested_thread(virq, 1); | 174 | irq_set_nested_thread(virq, 1); |
175 | |||
176 | /* ARM needs us to explicitly flag the IRQ as valid | ||
177 | * and will set them noprobe when we do so. */ | ||
178 | #ifdef CONFIG_ARM | ||
179 | set_irq_flags(virq, IRQF_VALID); | ||
180 | #else | ||
181 | irq_set_noprobe(virq); | 175 | irq_set_noprobe(virq); |
182 | #endif | ||
183 | 176 | ||
184 | return 0; | 177 | return 0; |
185 | } | 178 | } |