diff options
author | Rob Herring <robh@kernel.org> | 2015-07-27 16:55:20 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2015-08-11 10:09:01 -0400 |
commit | 9bd09f345e62257958342f712efef644494274fb (patch) | |
tree | 8d1347a13be87f40319cd64598e930b4c32a2f93 /drivers/mfd/htc-i2cpld.c | |
parent | 035faf4bd2776237940c95d08bfe8928fe0a80e1 (diff) |
mfd: Kill off set_irq_flags usage
set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:
IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN
For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/htc-i2cpld.c')
-rw-r--r-- | drivers/mfd/htc-i2cpld.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c index b54baad30164..1bd5b042c8b3 100644 --- a/drivers/mfd/htc-i2cpld.c +++ b/drivers/mfd/htc-i2cpld.c | |||
@@ -330,11 +330,7 @@ static int htcpld_setup_chip_irq( | |||
330 | irq_set_chip_and_handler(irq, &htcpld_muxed_chip, | 330 | irq_set_chip_and_handler(irq, &htcpld_muxed_chip, |
331 | handle_simple_irq); | 331 | handle_simple_irq); |
332 | irq_set_chip_data(irq, chip); | 332 | irq_set_chip_data(irq, chip); |
333 | #ifdef CONFIG_ARM | 333 | irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE); |
334 | set_irq_flags(irq, IRQF_VALID | IRQF_PROBE); | ||
335 | #else | ||
336 | irq_set_probe(irq); | ||
337 | #endif | ||
338 | } | 334 | } |
339 | 335 | ||
340 | return ret; | 336 | return ret; |