aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/dvb-frontends/s5h1420.c
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-04-28 17:34:40 -0400
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-04-30 12:59:54 -0400
commit12f4543f5d6811f864e6c4952eb27253c7466c02 (patch)
tree67c7536835efd2fc1d781921c15a2945956a04bb /drivers/media/dvb-frontends/s5h1420.c
parent451dfbe9f153a28da149729552b26043ae94af28 (diff)
[media] s5h1420: fix a buffer overflow when checking userspace params
The maximum size for a DiSEqC command is 6, according to the userspace API. However, the code allows to write up to 7 values: drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd() error: buffer overflow 'cmd->msg' 6 <= 7 Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/dvb-frontends/s5h1420.c')
-rw-r--r--drivers/media/dvb-frontends/s5h1420.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/dvb-frontends/s5h1420.c b/drivers/media/dvb-frontends/s5h1420.c
index 93eeaf7118fd..0b4f8fe6bf99 100644
--- a/drivers/media/dvb-frontends/s5h1420.c
+++ b/drivers/media/dvb-frontends/s5h1420.c
@@ -180,7 +180,7 @@ static int s5h1420_send_master_cmd (struct dvb_frontend* fe,
180 int result = 0; 180 int result = 0;
181 181
182 dprintk("enter %s\n", __func__); 182 dprintk("enter %s\n", __func__);
183 if (cmd->msg_len > 8) 183 if (cmd->msg_len > sizeof(cmd->msg))
184 return -EINVAL; 184 return -EINVAL;
185 185
186 /* setup for DISEQC */ 186 /* setup for DISEQC */