diff options
author | Shuah Khan <shuahkhan@gmail.com> | 2012-05-29 18:07:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-29 19:22:31 -0400 |
commit | 03c091e5b726ada6aaf9af1d0e973679099101e4 (patch) | |
tree | acbe5d242a76b2296d15804c4cc2766ca1295d4b /drivers/leds/ledtrig-backlight.c | |
parent | b00961824a33aadec4a825eaeccfbe3db8ec7032 (diff) |
leds: change existing triggers to use activated flag
Change existing triggers backlight, gpio, and heartbeat to use the new
->activated flag to set activate successful status in their activate
routines and check it in their deactivate routines to do cleanup.
Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Bryan Wu <bryan.wu@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/leds/ledtrig-backlight.c')
-rw-r--r-- | drivers/leds/ledtrig-backlight.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/ledtrig-backlight.c b/drivers/leds/ledtrig-backlight.c index 2b513a2ad7de..e2726867c5d4 100644 --- a/drivers/leds/ledtrig-backlight.c +++ b/drivers/leds/ledtrig-backlight.c | |||
@@ -120,6 +120,7 @@ static void bl_trig_activate(struct led_classdev *led) | |||
120 | ret = fb_register_client(&n->notifier); | 120 | ret = fb_register_client(&n->notifier); |
121 | if (ret) | 121 | if (ret) |
122 | dev_err(led->dev, "unable to register backlight trigger\n"); | 122 | dev_err(led->dev, "unable to register backlight trigger\n"); |
123 | led->activated = true; | ||
123 | 124 | ||
124 | return; | 125 | return; |
125 | 126 | ||
@@ -133,10 +134,11 @@ static void bl_trig_deactivate(struct led_classdev *led) | |||
133 | struct bl_trig_notifier *n = | 134 | struct bl_trig_notifier *n = |
134 | (struct bl_trig_notifier *) led->trigger_data; | 135 | (struct bl_trig_notifier *) led->trigger_data; |
135 | 136 | ||
136 | if (n) { | 137 | if (led->activated) { |
137 | device_remove_file(led->dev, &dev_attr_inverted); | 138 | device_remove_file(led->dev, &dev_attr_inverted); |
138 | fb_unregister_client(&n->notifier); | 139 | fb_unregister_client(&n->notifier); |
139 | kfree(n); | 140 | kfree(n); |
141 | led->activated = false; | ||
140 | } | 142 | } |
141 | } | 143 | } |
142 | 144 | ||