diff options
author | Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> | 2015-07-31 07:36:21 -0400 |
---|---|---|
committer | Jacek Anaszewski <j.anaszewski@samsung.com> | 2015-08-28 08:06:19 -0400 |
commit | e5b5a61fcb3743f1dacf9e20d28f48423cecf0c1 (patch) | |
tree | 957d8c7ed82f3796d1307b3bb300ad1c2507800f /drivers/leds/led-class.c | |
parent | 4fc5af86837d983d7b1dd4edad245454e1874fa0 (diff) |
leds/led-class: Add missing put_device()
Devices found by class_find_device must be freed with put_device().
Otherwise the reference count will not work properly.
Fixes: a96aa64cb572 ("leds/led-class: Handle LEDs with the same name")
Reported-by: Alan Tull <delicious.quinoa@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Diffstat (limited to 'drivers/leds/led-class.c')
-rw-r--r-- | drivers/leds/led-class.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index beabfbc6f7cd..ca51d58bed24 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c | |||
@@ -228,12 +228,15 @@ static int led_classdev_next_name(const char *init_name, char *name, | |||
228 | { | 228 | { |
229 | unsigned int i = 0; | 229 | unsigned int i = 0; |
230 | int ret = 0; | 230 | int ret = 0; |
231 | struct device *dev; | ||
231 | 232 | ||
232 | strlcpy(name, init_name, len); | 233 | strlcpy(name, init_name, len); |
233 | 234 | ||
234 | while (class_find_device(leds_class, NULL, name, match_name) && | 235 | while ((ret < len) && |
235 | (ret < len)) | 236 | (dev = class_find_device(leds_class, NULL, name, match_name))) { |
237 | put_device(dev); | ||
236 | ret = snprintf(name, len, "%s_%u", init_name, ++i); | 238 | ret = snprintf(name, len, "%s_%u", init_name, ++i); |
239 | } | ||
237 | 240 | ||
238 | if (ret >= len) | 241 | if (ret >= len) |
239 | return -ENOMEM; | 242 | return -ENOMEM; |