iommu: Introduce iommu_fwspec

Introduce a common structure to hold the per-device firmware data that
most IOMMU drivers need to keep track of. This enables us to configure
much of that data from common firmware code, and consolidate a lot of
the equivalent implementations, device look-up tables, etc. which are
currently strewn across IOMMU drivers.

This will also be enable us to address the outstanding "multiple IOMMUs
on the platform bus" problem by tweaking IOMMU API calls to prefer
dev->fwspec->ops before falling back to dev->bus->iommu_ops, and thus
gracefully handle those troublesome systems which we currently cannot.

As the first user, hook up the OF IOMMU configuration mechanism. The
driver-defined nature of DT cells means that we still need the drivers
to translate and add the IDs themselves, but future users such as the
much less free-form ACPI IORT will be much simpler and self-contained.

CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

1 files changed, 6 insertions, 2 deletions

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 19e1e8f2f871..5b82862f571f 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -167,7 +167,9 @@ static const struct iommu_ops
                 return NULL;
 
         ops = of_iommu_get_ops(iommu_spec.np);
-        if (!ops || !ops->of_xlate || ops->of_xlate(&pdev->dev, &iommu_spec))
+        if (!ops || !ops->of_xlate ||
+            iommu_fwspec_init(&pdev->dev, &iommu_spec.np->fwnode, ops) ||
+            ops->of_xlate(&pdev->dev, &iommu_spec))
                 ops = NULL;
 
         of_node_put(iommu_spec.np);
@@ -196,7 +198,9 @@ const struct iommu_ops *of_iommu_configure(struct device *dev,
                 np = iommu_spec.np;
                 ops = of_iommu_get_ops(np);
 
-                if (!ops || !ops->of_xlate || ops->of_xlate(dev, &iommu_spec))
+                if (!ops || !ops->of_xlate ||
+                    iommu_fwspec_init(dev, &np->fwnode, ops) ||
+                    ops->of_xlate(dev, &iommu_spec))
                         goto err_put_node;
 
                 of_node_put(np);