aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm
diff options
context:
space:
mode:
authorAnder Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>2017-01-20 09:28:45 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-02-01 02:33:11 -0500
commitd7c3d7e453b70e9e9e81d8409e5f8c004597ec05 (patch)
tree1484f50359a586c37e1e263a9818d30f5c54d62a /drivers/gpu/drm
parent181478cdb75eb4d9865064b15cb93418c72759f2 (diff)
drm/i915: Check for NULL atomic state in intel_crtc_disable_noatomic()
commit 6d1d427a4e24c403b4adf928d61994bdaa0ca03a upstream. In intel_crtc_disable_noatomic(), bail on a failure to allocate an atomic state to avoid a NULL pointer dereference. Fixes: 4a80655827af ("drm/i915: Pass atomic state to crtc enable/disable functions") Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1484922525-6131-4-git-send-email-ander.conselvan.de.oliveira@intel.com (cherry picked from commit 31bb2ef97ea9db343348f9b5ccaa9bb6f48fc655) Signed-off-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r--drivers/gpu/drm/i915/intel_display.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 944e067a9f28..8079e5b380cb 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6869,6 +6869,12 @@ static void intel_crtc_disable_noatomic(struct drm_crtc *crtc)
6869 } 6869 }
6870 6870
6871 state = drm_atomic_state_alloc(crtc->dev); 6871 state = drm_atomic_state_alloc(crtc->dev);
6872 if (!state) {
6873 DRM_DEBUG_KMS("failed to disable [CRTC:%d:%s], out of memory",
6874 crtc->base.id, crtc->name);
6875 return;
6876 }
6877
6872 state->acquire_ctx = crtc->dev->mode_config.acquire_ctx; 6878 state->acquire_ctx = crtc->dev->mode_config.acquire_ctx;
6873 6879
6874 /* Everything's already locked, -EDEADLK can't happen. */ 6880 /* Everything's already locked, -EDEADLK can't happen. */