diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2012-05-23 06:13:58 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2012-07-20 06:21:41 -0400 |
commit | 79158103bf20c9ff55204ceb78a5773f422b03be (patch) | |
tree | 520ff6549bc77a5e69ee0c7114def95af1516417 /drivers/gpu/drm/i915/intel_display.c | |
parent | a4f32fc3a37e982fffce8ec583643990ff288419 (diff) |
drm/i915: Make the lock for pageflips interruptible
As we take the struct_mutex lock to access the command-stream, there is
a possibility that we may need to wait for a GPU hang and so should make
the lock both interruptible and error-checking.
References: https://bugs.freedesktop.org/show_bug.cgi?id=50069
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 80fe02d2d733..c9b69e3b2c29 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -6486,7 +6486,9 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, | |||
6486 | intel_fb = to_intel_framebuffer(fb); | 6486 | intel_fb = to_intel_framebuffer(fb); |
6487 | obj = intel_fb->obj; | 6487 | obj = intel_fb->obj; |
6488 | 6488 | ||
6489 | mutex_lock(&dev->struct_mutex); | 6489 | ret = i915_mutex_lock_interruptible(dev); |
6490 | if (ret) | ||
6491 | goto cleanup; | ||
6490 | 6492 | ||
6491 | /* Reference the objects for the scheduled work. */ | 6493 | /* Reference the objects for the scheduled work. */ |
6492 | drm_gem_object_reference(&work->old_fb_obj->base); | 6494 | drm_gem_object_reference(&work->old_fb_obj->base); |
@@ -6521,6 +6523,7 @@ cleanup_pending: | |||
6521 | drm_gem_object_unreference(&obj->base); | 6523 | drm_gem_object_unreference(&obj->base); |
6522 | mutex_unlock(&dev->struct_mutex); | 6524 | mutex_unlock(&dev->struct_mutex); |
6523 | 6525 | ||
6526 | cleanup: | ||
6524 | spin_lock_irqsave(&dev->event_lock, flags); | 6527 | spin_lock_irqsave(&dev->event_lock, flags); |
6525 | intel_crtc->unpin_work = NULL; | 6528 | intel_crtc->unpin_work = NULL; |
6526 | spin_unlock_irqrestore(&dev->event_lock, flags); | 6529 | spin_unlock_irqrestore(&dev->event_lock, flags); |