diff options
author | Colin Ian King <colin.king@canonical.com> | 2015-04-14 12:51:29 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2015-04-20 21:14:38 -0400 |
commit | 1a92b2ba339221a4afee43adf125fcc9a41353f7 (patch) | |
tree | f85773bd08746f10b9ffbf429b5f6fad8640c6cc /drivers/crypto/mv_cesa.c | |
parent | 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085 (diff) |
crypto: mv_cesa - ensure backlog is initialised
backlog is not initialised so in the case where
cpg->eng_st != ENGINE_IDLE it is never initialised and
hence which could lead to an illegal memory dereference
in the statement:
backlog->complete(backlog, -EINPROGRESS);
Discovered with cppcheck static analsys:
[drivers/crypto/mv_cesa.c:616]:
(error) Uninitialized variable: backlog
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/mv_cesa.c')
-rw-r--r-- | drivers/crypto/mv_cesa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c index f91f15ddee92..e63efbd840b5 100644 --- a/drivers/crypto/mv_cesa.c +++ b/drivers/crypto/mv_cesa.c | |||
@@ -595,7 +595,7 @@ static int queue_manag(void *data) | |||
595 | cpg->eng_st = ENGINE_IDLE; | 595 | cpg->eng_st = ENGINE_IDLE; |
596 | do { | 596 | do { |
597 | struct crypto_async_request *async_req = NULL; | 597 | struct crypto_async_request *async_req = NULL; |
598 | struct crypto_async_request *backlog; | 598 | struct crypto_async_request *backlog = NULL; |
599 | 599 | ||
600 | __set_current_state(TASK_INTERRUPTIBLE); | 600 | __set_current_state(TASK_INTERRUPTIBLE); |
601 | 601 | ||