aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq
diff options
context:
space:
mode:
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>2016-08-16 16:14:55 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2016-08-16 16:14:55 -0400
commit58919e83c85c3a3c5fb34025dc0e95ddd998c478 (patch)
tree04aff6a76eccc25de1f205973bf72aaa1570f581 /drivers/cpufreq
parent694d0d0bb2030d2e36df73e2d23d5770511dbc8d (diff)
cpufreq / sched: Pass flags to cpufreq_update_util()
It is useful to know the reason why cpufreq_update_util() has just been called and that can be passed as flags to cpufreq_update_util() and to the ->func() callback in struct update_util_data. However, doing that in addition to passing the util and max arguments they already take would be clumsy, so avoid it. Instead, use the observation that the schedutil governor is part of the scheduler proper, so it can access scheduler data directly. This allows the util and max arguments of cpufreq_update_util() and the ->func() callback in struct update_util_data to be replaced with a flags one, but schedutil has to be modified to follow. Thus make the schedutil governor obtain the CFS utilization information from the scheduler and use the "RT" and "DL" flags instead of the special utilization value of ULONG_MAX to track updates from the RT and DL sched classes. Make it non-modular too to avoid having to export scheduler variables to modules at large. Next, update all of the other users of cpufreq_update_util() and the ->func() callback in struct update_util_data accordingly. Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/cpufreq')
-rw-r--r--drivers/cpufreq/Kconfig5
-rw-r--r--drivers/cpufreq/cpufreq_governor.c2
-rw-r--r--drivers/cpufreq/intel_pstate.c2
3 files changed, 3 insertions, 6 deletions
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 74919aa81dcb..4dc95250cf4e 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -194,7 +194,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
194 If in doubt, say N. 194 If in doubt, say N.
195 195
196config CPU_FREQ_GOV_SCHEDUTIL 196config CPU_FREQ_GOV_SCHEDUTIL
197 tristate "'schedutil' cpufreq policy governor" 197 bool "'schedutil' cpufreq policy governor"
198 depends on CPU_FREQ && SMP 198 depends on CPU_FREQ && SMP
199 select CPU_FREQ_GOV_ATTR_SET 199 select CPU_FREQ_GOV_ATTR_SET
200 select IRQ_WORK 200 select IRQ_WORK
@@ -208,9 +208,6 @@ config CPU_FREQ_GOV_SCHEDUTIL
208 frequency tipping point is at utilization/capacity equal to 80% in 208 frequency tipping point is at utilization/capacity equal to 80% in
209 both cases. 209 both cases.
210 210
211 To compile this driver as a module, choose M here: the module will
212 be called cpufreq_schedutil.
213
214 If in doubt, say N. 211 If in doubt, say N.
215 212
216comment "CPU frequency scaling drivers" 213comment "CPU frequency scaling drivers"
diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
index e415349ab31b..642dd0f183a8 100644
--- a/drivers/cpufreq/cpufreq_governor.c
+++ b/drivers/cpufreq/cpufreq_governor.c
@@ -260,7 +260,7 @@ static void dbs_irq_work(struct irq_work *irq_work)
260} 260}
261 261
262static void dbs_update_util_handler(struct update_util_data *data, u64 time, 262static void dbs_update_util_handler(struct update_util_data *data, u64 time,
263 unsigned long util, unsigned long max) 263 unsigned int flags)
264{ 264{
265 struct cpu_dbs_info *cdbs = container_of(data, struct cpu_dbs_info, update_util); 265 struct cpu_dbs_info *cdbs = container_of(data, struct cpu_dbs_info, update_util);
266 struct policy_dbs_info *policy_dbs = cdbs->policy_dbs; 266 struct policy_dbs_info *policy_dbs = cdbs->policy_dbs;
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index be9eade147f2..bdbe9369146b 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1329,7 +1329,7 @@ static inline void intel_pstate_adjust_busy_pstate(struct cpudata *cpu)
1329} 1329}
1330 1330
1331static void intel_pstate_update_util(struct update_util_data *data, u64 time, 1331static void intel_pstate_update_util(struct update_util_data *data, u64 time,
1332 unsigned long util, unsigned long max) 1332 unsigned int flags)
1333{ 1333{
1334 struct cpudata *cpu = container_of(data, struct cpudata, update_util); 1334 struct cpudata *cpu = container_of(data, struct cpudata, update_util);
1335 u64 delta_ns = time - cpu->sample.time; 1335 u64 delta_ns = time - cpu->sample.time;