diff options
author | Julia Lawall <julia.lawall@lip6.fr> | 2015-09-13 08:15:03 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-09-15 19:49:43 -0400 |
commit | 58d29e3ce903dcafacee9e355225d64922325cf0 (patch) | |
tree | 29d189338ff8e4e67e6de3da91a08f5ed90f1cbd /drivers/atm/he.c | |
parent | 982b527004826b40de1e821b123c70f05b41496c (diff) |
atm: he: drop null test before destroy functions
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@ expression x; @@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm/he.c')
-rw-r--r-- | drivers/atm/he.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/atm/he.c b/drivers/atm/he.c index a8da3a50e374..0f5cb37636bc 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c | |||
@@ -1578,9 +1578,7 @@ he_stop(struct he_dev *he_dev) | |||
1578 | 1578 | ||
1579 | kfree(he_dev->rbpl_virt); | 1579 | kfree(he_dev->rbpl_virt); |
1580 | kfree(he_dev->rbpl_table); | 1580 | kfree(he_dev->rbpl_table); |
1581 | 1581 | dma_pool_destroy(he_dev->rbpl_pool); | |
1582 | if (he_dev->rbpl_pool) | ||
1583 | dma_pool_destroy(he_dev->rbpl_pool); | ||
1584 | 1582 | ||
1585 | if (he_dev->rbrq_base) | 1583 | if (he_dev->rbrq_base) |
1586 | dma_free_coherent(&he_dev->pci_dev->dev, CONFIG_RBRQ_SIZE * sizeof(struct he_rbrq), | 1584 | dma_free_coherent(&he_dev->pci_dev->dev, CONFIG_RBRQ_SIZE * sizeof(struct he_rbrq), |
@@ -1594,8 +1592,7 @@ he_stop(struct he_dev *he_dev) | |||
1594 | dma_free_coherent(&he_dev->pci_dev->dev, CONFIG_TBRQ_SIZE * sizeof(struct he_tbrq), | 1592 | dma_free_coherent(&he_dev->pci_dev->dev, CONFIG_TBRQ_SIZE * sizeof(struct he_tbrq), |
1595 | he_dev->tpdrq_base, he_dev->tpdrq_phys); | 1593 | he_dev->tpdrq_base, he_dev->tpdrq_phys); |
1596 | 1594 | ||
1597 | if (he_dev->tpd_pool) | 1595 | dma_pool_destroy(he_dev->tpd_pool); |
1598 | dma_pool_destroy(he_dev->tpd_pool); | ||
1599 | 1596 | ||
1600 | if (he_dev->pci_dev) { | 1597 | if (he_dev->pci_dev) { |
1601 | pci_read_config_word(he_dev->pci_dev, PCI_COMMAND, &command); | 1598 | pci_read_config_word(he_dev->pci_dev, PCI_COMMAND, &command); |