diff options
author | Brian Gerst <brgerst@gmail.com> | 2016-08-13 12:38:16 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2016-08-24 06:27:40 -0400 |
commit | 4e047aa7f267c3449b6d323510d35864829aca70 (patch) | |
tree | 6bcf31af63f3314b519ffec55d07d404bd6d3363 /arch/x86/kernel | |
parent | 13e25bab7e51bdd4ba7df1ef2388961294bb565e (diff) |
sched/x86/32, kgdb: Don't use thread.ip in sleeping_thread_to_gdb_regs()
Match 64-bit and set gdb_regs[GDB_PC] to zero. thread.ip is always the
same point in the scheduler (except for newly forked processes), and will
be removed in a future patch.
Signed-off-by: Brian Gerst <brgerst@gmail.com>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1471106302-10159-2-git-send-email-brgerst@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/kernel')
-rw-r--r-- | arch/x86/kernel/kgdb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index 04cde527d728..fe649a5f509f 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c | |||
@@ -172,7 +172,6 @@ void sleeping_thread_to_gdb_regs(unsigned long *gdb_regs, struct task_struct *p) | |||
172 | gdb_regs[GDB_ES] = __KERNEL_DS; | 172 | gdb_regs[GDB_ES] = __KERNEL_DS; |
173 | gdb_regs[GDB_PS] = 0; | 173 | gdb_regs[GDB_PS] = 0; |
174 | gdb_regs[GDB_CS] = __KERNEL_CS; | 174 | gdb_regs[GDB_CS] = __KERNEL_CS; |
175 | gdb_regs[GDB_PC] = p->thread.ip; | ||
176 | gdb_regs[GDB_SS] = __KERNEL_DS; | 175 | gdb_regs[GDB_SS] = __KERNEL_DS; |
177 | gdb_regs[GDB_FS] = 0xFFFF; | 176 | gdb_regs[GDB_FS] = 0xFFFF; |
178 | gdb_regs[GDB_GS] = 0xFFFF; | 177 | gdb_regs[GDB_GS] = 0xFFFF; |
@@ -180,7 +179,6 @@ void sleeping_thread_to_gdb_regs(unsigned long *gdb_regs, struct task_struct *p) | |||
180 | gdb_regs32[GDB_PS] = *(unsigned long *)(p->thread.sp + 8); | 179 | gdb_regs32[GDB_PS] = *(unsigned long *)(p->thread.sp + 8); |
181 | gdb_regs32[GDB_CS] = __KERNEL_CS; | 180 | gdb_regs32[GDB_CS] = __KERNEL_CS; |
182 | gdb_regs32[GDB_SS] = __KERNEL_DS; | 181 | gdb_regs32[GDB_SS] = __KERNEL_DS; |
183 | gdb_regs[GDB_PC] = 0; | ||
184 | gdb_regs[GDB_R8] = 0; | 182 | gdb_regs[GDB_R8] = 0; |
185 | gdb_regs[GDB_R9] = 0; | 183 | gdb_regs[GDB_R9] = 0; |
186 | gdb_regs[GDB_R10] = 0; | 184 | gdb_regs[GDB_R10] = 0; |
@@ -190,6 +188,7 @@ void sleeping_thread_to_gdb_regs(unsigned long *gdb_regs, struct task_struct *p) | |||
190 | gdb_regs[GDB_R14] = 0; | 188 | gdb_regs[GDB_R14] = 0; |
191 | gdb_regs[GDB_R15] = 0; | 189 | gdb_regs[GDB_R15] = 0; |
192 | #endif | 190 | #endif |
191 | gdb_regs[GDB_PC] = 0; | ||
193 | gdb_regs[GDB_SP] = p->thread.sp; | 192 | gdb_regs[GDB_SP] = p->thread.sp; |
194 | } | 193 | } |
195 | 194 | ||