diff options
author | Chen Gang <chengang@emindsoft.com.cn> | 2016-08-02 17:03:42 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-08-02 19:35:02 -0400 |
commit | 949bed2f5764435715e3d6dd3ab6dd4dbd890a71 (patch) | |
tree | 8d0d2b5fe337c8ff04d3818a74495ce0daae99c9 | |
parent | bd804ba12525c13a096f64f305a169c654a706e7 (diff) |
include: mman: use bool instead of int for the return value of arch_validate_prot
For pure bool function's return value, bool is a little better more or
less than int.
Link: http://lkml.kernel.org/r/1469331815-2026-1-git-send-email-chengang@emindsoft.com.cn
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | arch/powerpc/include/asm/mman.h | 8 | ||||
-rw-r--r-- | include/linux/mman.h | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h index 2563c435a4b1..fc420cedecae 100644 --- a/arch/powerpc/include/asm/mman.h +++ b/arch/powerpc/include/asm/mman.h | |||
@@ -31,13 +31,13 @@ static inline pgprot_t arch_vm_get_page_prot(unsigned long vm_flags) | |||
31 | } | 31 | } |
32 | #define arch_vm_get_page_prot(vm_flags) arch_vm_get_page_prot(vm_flags) | 32 | #define arch_vm_get_page_prot(vm_flags) arch_vm_get_page_prot(vm_flags) |
33 | 33 | ||
34 | static inline int arch_validate_prot(unsigned long prot) | 34 | static inline bool arch_validate_prot(unsigned long prot) |
35 | { | 35 | { |
36 | if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO)) | 36 | if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO)) |
37 | return 0; | 37 | return false; |
38 | if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO)) | 38 | if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO)) |
39 | return 0; | 39 | return false; |
40 | return 1; | 40 | return true; |
41 | } | 41 | } |
42 | #define arch_validate_prot(prot) arch_validate_prot(prot) | 42 | #define arch_validate_prot(prot) arch_validate_prot(prot) |
43 | 43 | ||
diff --git a/include/linux/mman.h b/include/linux/mman.h index 33e17f6a327a..634c4c51fe3a 100644 --- a/include/linux/mman.h +++ b/include/linux/mman.h | |||
@@ -49,7 +49,7 @@ static inline void vm_unacct_memory(long pages) | |||
49 | * | 49 | * |
50 | * Returns true if the prot flags are valid | 50 | * Returns true if the prot flags are valid |
51 | */ | 51 | */ |
52 | static inline int arch_validate_prot(unsigned long prot) | 52 | static inline bool arch_validate_prot(unsigned long prot) |
53 | { | 53 | { |
54 | return (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM)) == 0; | 54 | return (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM)) == 0; |
55 | } | 55 | } |