diff options
author | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | 2015-11-06 19:32:14 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-11-06 20:50:42 -0500 |
commit | 09ef29e0f6ac9f08ba4cc501ab4a3c33be526343 (patch) | |
tree | 2b02f0596945e75e11e3c7262b4cf3b8616587c2 | |
parent | c35c7ac5da8ddfd7c6cd1acc29b052a15f437e24 (diff) |
nilfs2: fix gcc unused-but-set-variable warnings
Fix the following build warnings:
$ make W=1
[...]
CC [M] fs/nilfs2/btree.o
fs/nilfs2/btree.c: In function 'nilfs_btree_split':
fs/nilfs2/btree.c:923:8: warning: variable 'newptr' set but not used [-Wunused-but-set-variable]
__u64 newptr;
^
fs/nilfs2/btree.c:922:8: warning: variable 'newkey' set but not used [-Wunused-but-set-variable]
__u64 newkey;
^
CC [M] fs/nilfs2/dat.o
fs/nilfs2/dat.c: In function 'nilfs_dat_prepare_end':
fs/nilfs2/dat.c:158:8: warning: variable 'start' set but not used [-Wunused-but-set-variable]
__u64 start;
^
CC [M] fs/nilfs2/segment.o
fs/nilfs2/segment.c: In function 'nilfs_segctor_do_immediate_flush':
fs/nilfs2/segment.c:2433:6: warning: variable 'err' set but not used [-Wunused-but-set-variable]
int err;
^
CC [M] fs/nilfs2/sufile.o
fs/nilfs2/sufile.c: In function 'nilfs_sufile_alloc':
fs/nilfs2/sufile.c:320:27: warning: variable 'ncleansegs' set but not used [-Wunused-but-set-variable]
unsigned long nsegments, ncleansegs, nsus, cnt;
^
CC [M] fs/nilfs2/alloc.o
fs/nilfs2/alloc.c: In function 'nilfs_palloc_prepare_alloc_entry':
fs/nilfs2/alloc.c:478:38: warning: variable 'groups_per_desc_block' set but not used [-Wunused-but-set-variable]
unsigned long n, entries_per_group, groups_per_desc_block;
^
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | fs/nilfs2/alloc.c | 3 | ||||
-rw-r--r-- | fs/nilfs2/btree.c | 5 | ||||
-rw-r--r-- | fs/nilfs2/dat.c | 2 | ||||
-rw-r--r-- | fs/nilfs2/segment.c | 3 | ||||
-rw-r--r-- | fs/nilfs2/sufile.c | 3 |
5 files changed, 3 insertions, 13 deletions
diff --git a/fs/nilfs2/alloc.c b/fs/nilfs2/alloc.c index b335a32e9561..2ccbf5531554 100644 --- a/fs/nilfs2/alloc.c +++ b/fs/nilfs2/alloc.c | |||
@@ -514,7 +514,7 @@ int nilfs_palloc_prepare_alloc_entry(struct inode *inode, | |||
514 | void *desc_kaddr, *bitmap_kaddr; | 514 | void *desc_kaddr, *bitmap_kaddr; |
515 | unsigned long group, maxgroup, ngroups; | 515 | unsigned long group, maxgroup, ngroups; |
516 | unsigned long group_offset, maxgroup_offset; | 516 | unsigned long group_offset, maxgroup_offset; |
517 | unsigned long n, entries_per_group, groups_per_desc_block; | 517 | unsigned long n, entries_per_group; |
518 | unsigned long i, j; | 518 | unsigned long i, j; |
519 | spinlock_t *lock; | 519 | spinlock_t *lock; |
520 | int pos, ret; | 520 | int pos, ret; |
@@ -523,7 +523,6 @@ int nilfs_palloc_prepare_alloc_entry(struct inode *inode, | |||
523 | maxgroup = ngroups - 1; | 523 | maxgroup = ngroups - 1; |
524 | group = nilfs_palloc_group(inode, req->pr_entry_nr, &group_offset); | 524 | group = nilfs_palloc_group(inode, req->pr_entry_nr, &group_offset); |
525 | entries_per_group = nilfs_palloc_entries_per_group(inode); | 525 | entries_per_group = nilfs_palloc_entries_per_group(inode); |
526 | groups_per_desc_block = nilfs_palloc_groups_per_desc_block(inode); | ||
527 | 526 | ||
528 | for (i = 0; i < ngroups; i += n) { | 527 | for (i = 0; i < ngroups; i += n) { |
529 | if (group >= ngroups) { | 528 | if (group >= ngroups) { |
diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c index 919fd5bb14a8..f609a8532ec5 100644 --- a/fs/nilfs2/btree.c +++ b/fs/nilfs2/btree.c | |||
@@ -919,8 +919,6 @@ static void nilfs_btree_split(struct nilfs_bmap *btree, | |||
919 | int level, __u64 *keyp, __u64 *ptrp) | 919 | int level, __u64 *keyp, __u64 *ptrp) |
920 | { | 920 | { |
921 | struct nilfs_btree_node *node, *right; | 921 | struct nilfs_btree_node *node, *right; |
922 | __u64 newkey; | ||
923 | __u64 newptr; | ||
924 | int nchildren, n, move, ncblk; | 922 | int nchildren, n, move, ncblk; |
925 | 923 | ||
926 | node = nilfs_btree_get_nonroot_node(path, level); | 924 | node = nilfs_btree_get_nonroot_node(path, level); |
@@ -942,9 +940,6 @@ static void nilfs_btree_split(struct nilfs_bmap *btree, | |||
942 | if (!buffer_dirty(path[level].bp_sib_bh)) | 940 | if (!buffer_dirty(path[level].bp_sib_bh)) |
943 | mark_buffer_dirty(path[level].bp_sib_bh); | 941 | mark_buffer_dirty(path[level].bp_sib_bh); |
944 | 942 | ||
945 | newkey = nilfs_btree_node_get_key(right, 0); | ||
946 | newptr = path[level].bp_newreq.bpr_ptr; | ||
947 | |||
948 | if (move) { | 943 | if (move) { |
949 | path[level].bp_index -= nilfs_btree_node_get_nchildren(node); | 944 | path[level].bp_index -= nilfs_btree_node_get_nchildren(node); |
950 | nilfs_btree_node_insert(right, path[level].bp_index, | 945 | nilfs_btree_node_insert(right, path[level].bp_index, |
diff --git a/fs/nilfs2/dat.c b/fs/nilfs2/dat.c index 0d5fada91191..7dc23f100e57 100644 --- a/fs/nilfs2/dat.c +++ b/fs/nilfs2/dat.c | |||
@@ -155,7 +155,6 @@ void nilfs_dat_commit_start(struct inode *dat, struct nilfs_palloc_req *req, | |||
155 | int nilfs_dat_prepare_end(struct inode *dat, struct nilfs_palloc_req *req) | 155 | int nilfs_dat_prepare_end(struct inode *dat, struct nilfs_palloc_req *req) |
156 | { | 156 | { |
157 | struct nilfs_dat_entry *entry; | 157 | struct nilfs_dat_entry *entry; |
158 | __u64 start; | ||
159 | sector_t blocknr; | 158 | sector_t blocknr; |
160 | void *kaddr; | 159 | void *kaddr; |
161 | int ret; | 160 | int ret; |
@@ -169,7 +168,6 @@ int nilfs_dat_prepare_end(struct inode *dat, struct nilfs_palloc_req *req) | |||
169 | kaddr = kmap_atomic(req->pr_entry_bh->b_page); | 168 | kaddr = kmap_atomic(req->pr_entry_bh->b_page); |
170 | entry = nilfs_palloc_block_get_entry(dat, req->pr_entry_nr, | 169 | entry = nilfs_palloc_block_get_entry(dat, req->pr_entry_nr, |
171 | req->pr_entry_bh, kaddr); | 170 | req->pr_entry_bh, kaddr); |
172 | start = le64_to_cpu(entry->de_start); | ||
173 | blocknr = le64_to_cpu(entry->de_blocknr); | 171 | blocknr = le64_to_cpu(entry->de_blocknr); |
174 | kunmap_atomic(kaddr); | 172 | kunmap_atomic(kaddr); |
175 | 173 | ||
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 3fc47326fbe1..3b65adaae7e4 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c | |||
@@ -2492,7 +2492,6 @@ static void nilfs_segctor_thread_construct(struct nilfs_sc_info *sci, int mode) | |||
2492 | static void nilfs_segctor_do_immediate_flush(struct nilfs_sc_info *sci) | 2492 | static void nilfs_segctor_do_immediate_flush(struct nilfs_sc_info *sci) |
2493 | { | 2493 | { |
2494 | int mode = 0; | 2494 | int mode = 0; |
2495 | int err; | ||
2496 | 2495 | ||
2497 | spin_lock(&sci->sc_state_lock); | 2496 | spin_lock(&sci->sc_state_lock); |
2498 | mode = (sci->sc_flush_request & FLUSH_DAT_BIT) ? | 2497 | mode = (sci->sc_flush_request & FLUSH_DAT_BIT) ? |
@@ -2500,7 +2499,7 @@ static void nilfs_segctor_do_immediate_flush(struct nilfs_sc_info *sci) | |||
2500 | spin_unlock(&sci->sc_state_lock); | 2499 | spin_unlock(&sci->sc_state_lock); |
2501 | 2500 | ||
2502 | if (mode) { | 2501 | if (mode) { |
2503 | err = nilfs_segctor_do_construct(sci, mode); | 2502 | nilfs_segctor_do_construct(sci, mode); |
2504 | 2503 | ||
2505 | spin_lock(&sci->sc_state_lock); | 2504 | spin_lock(&sci->sc_state_lock); |
2506 | sci->sc_flush_request &= (mode == SC_FLUSH_FILE) ? | 2505 | sci->sc_flush_request &= (mode == SC_FLUSH_FILE) ? |
diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c index 7ff8f15207ab..52821ffc11f4 100644 --- a/fs/nilfs2/sufile.c +++ b/fs/nilfs2/sufile.c | |||
@@ -319,7 +319,7 @@ int nilfs_sufile_alloc(struct inode *sufile, __u64 *segnump) | |||
319 | size_t susz = NILFS_MDT(sufile)->mi_entry_size; | 319 | size_t susz = NILFS_MDT(sufile)->mi_entry_size; |
320 | __u64 segnum, maxsegnum, last_alloc; | 320 | __u64 segnum, maxsegnum, last_alloc; |
321 | void *kaddr; | 321 | void *kaddr; |
322 | unsigned long nsegments, ncleansegs, nsus, cnt; | 322 | unsigned long nsegments, nsus, cnt; |
323 | int ret, j; | 323 | int ret, j; |
324 | 324 | ||
325 | down_write(&NILFS_MDT(sufile)->mi_sem); | 325 | down_write(&NILFS_MDT(sufile)->mi_sem); |
@@ -329,7 +329,6 @@ int nilfs_sufile_alloc(struct inode *sufile, __u64 *segnump) | |||
329 | goto out_sem; | 329 | goto out_sem; |
330 | kaddr = kmap_atomic(header_bh->b_page); | 330 | kaddr = kmap_atomic(header_bh->b_page); |
331 | header = kaddr + bh_offset(header_bh); | 331 | header = kaddr + bh_offset(header_bh); |
332 | ncleansegs = le64_to_cpu(header->sh_ncleansegs); | ||
333 | last_alloc = le64_to_cpu(header->sh_last_alloc); | 332 | last_alloc = le64_to_cpu(header->sh_last_alloc); |
334 | kunmap_atomic(kaddr); | 333 | kunmap_atomic(kaddr); |
335 | 334 | ||