diff options
author | Grygorii Strashko <grygorii.strashko@ti.com> | 2016-12-04 22:57:44 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-15 07:42:57 -0500 |
commit | 05b7bdf1c3d8fe9c1bd92887a863a02c4cdcd207 (patch) | |
tree | 4540ed86477963b09edab40eaf806cc812742273 | |
parent | b8ba5faa7a6bdf1d8a86c1fc77651c566445402d (diff) |
ARM: omap2+: am437x: rollback to use omap3_gptimer_timer_init()
commit f86a2c875fd146d9b82c8fdd86d31084507bcf4c upstream.
The commit 55ee7017ee31 ("arm: omap2: board-generic: use
omap4_local_timer_init for AM437x") unintentionally changes the
clocksource devices for AM437x from OMAP GP Timer to SyncTimer32K.
Unfortunately, the SyncTimer32K is starving from frequency deviation
as mentioned in commit 5b5c01359152 ("ARM: OMAP2+: AM43x: Use gptimer
as clocksource") and, as reported by Franklin [1], even its monotonic
nature is under question (most probably there is a HW issue, but it's
still under investigation).
Taking into account above facts It's reasonable to rollback to the use
of omap3_gptimer_timer_init().
[1] http://www.spinics.net/lists/linux-omap/msg127425.html
Fixes: 55ee7017ee31 ("arm: omap2: board-generic: use
omap4_local_timer_init for AM437x")
Reported-by: Cooper Jr., Franklin <fcooper@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | arch/arm/mach-omap2/board-generic.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-omap2/timer.c | 9 |
2 files changed, 6 insertions, 5 deletions
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c index bab814d2f37d..60f5e838a3bc 100644 --- a/arch/arm/mach-omap2/board-generic.c +++ b/arch/arm/mach-omap2/board-generic.c | |||
@@ -306,7 +306,7 @@ DT_MACHINE_START(AM43_DT, "Generic AM43 (Flattened Device Tree)") | |||
306 | .init_late = am43xx_init_late, | 306 | .init_late = am43xx_init_late, |
307 | .init_irq = omap_gic_of_init, | 307 | .init_irq = omap_gic_of_init, |
308 | .init_machine = omap_generic_init, | 308 | .init_machine = omap_generic_init, |
309 | .init_time = omap4_local_timer_init, | 309 | .init_time = omap3_gptimer_timer_init, |
310 | .dt_compat = am43_boards_compat, | 310 | .dt_compat = am43_boards_compat, |
311 | .restart = omap44xx_restart, | 311 | .restart = omap44xx_restart, |
312 | MACHINE_END | 312 | MACHINE_END |
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index 5e2e2218a402..b2f2448bfa6d 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c | |||
@@ -510,18 +510,19 @@ void __init omap3_secure_sync32k_timer_init(void) | |||
510 | } | 510 | } |
511 | #endif /* CONFIG_ARCH_OMAP3 */ | 511 | #endif /* CONFIG_ARCH_OMAP3 */ |
512 | 512 | ||
513 | #if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_SOC_AM33XX) | 513 | #if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_SOC_AM33XX) || \ |
514 | defined(CONFIG_SOC_AM43XX) | ||
514 | void __init omap3_gptimer_timer_init(void) | 515 | void __init omap3_gptimer_timer_init(void) |
515 | { | 516 | { |
516 | __omap_sync32k_timer_init(2, "timer_sys_ck", NULL, | 517 | __omap_sync32k_timer_init(2, "timer_sys_ck", NULL, |
517 | 1, "timer_sys_ck", "ti,timer-alwon", true); | 518 | 1, "timer_sys_ck", "ti,timer-alwon", true); |
518 | 519 | if (of_have_populated_dt()) | |
519 | clocksource_probe(); | 520 | clocksource_probe(); |
520 | } | 521 | } |
521 | #endif | 522 | #endif |
522 | 523 | ||
523 | #if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || \ | 524 | #if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || \ |
524 | defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM43XX) | 525 | defined(CONFIG_SOC_DRA7XX) |
525 | static void __init omap4_sync32k_timer_init(void) | 526 | static void __init omap4_sync32k_timer_init(void) |
526 | { | 527 | { |
527 | __omap_sync32k_timer_init(1, "timer_32k_ck", "ti,timer-alwon", | 528 | __omap_sync32k_timer_init(1, "timer_32k_ck", "ti,timer-alwon", |