summaryrefslogtreecommitdiffstats
path: root/mm/compaction.c
diff options
context:
space:
mode:
Diffstat (limited to 'mm/compaction.c')
-rw-r--r--mm/compaction.c31
1 files changed, 7 insertions, 24 deletions
diff --git a/mm/compaction.c b/mm/compaction.c
index 56331f5124ba..3c60e3d5237e 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -822,22 +822,6 @@ static void compaction_free(struct page *page, unsigned long data)
822 cc->nr_freepages++; 822 cc->nr_freepages++;
823} 823}
824 824
825/*
826 * We cannot control nr_migratepages fully when migration is running as
827 * migrate_pages() has no knowledge of of compact_control. When migration is
828 * complete, we count the number of pages on the list by hand.
829 */
830static void update_nr_listpages(struct compact_control *cc)
831{
832 int nr_migratepages = 0;
833 struct page *page;
834
835 list_for_each_entry(page, &cc->migratepages, lru)
836 nr_migratepages++;
837
838 cc->nr_migratepages = nr_migratepages;
839}
840
841/* possible outcome of isolate_migratepages */ 825/* possible outcome of isolate_migratepages */
842typedef enum { 826typedef enum {
843 ISOLATE_ABORT, /* Abort compaction now */ 827 ISOLATE_ABORT, /* Abort compaction now */
@@ -1032,7 +1016,6 @@ static int compact_zone(struct zone *zone, struct compact_control *cc)
1032 migrate_prep_local(); 1016 migrate_prep_local();
1033 1017
1034 while ((ret = compact_finished(zone, cc)) == COMPACT_CONTINUE) { 1018 while ((ret = compact_finished(zone, cc)) == COMPACT_CONTINUE) {
1035 unsigned long nr_migrate, nr_remaining;
1036 int err; 1019 int err;
1037 1020
1038 switch (isolate_migratepages(zone, cc)) { 1021 switch (isolate_migratepages(zone, cc)) {
@@ -1047,20 +1030,20 @@ static int compact_zone(struct zone *zone, struct compact_control *cc)
1047 ; 1030 ;
1048 } 1031 }
1049 1032
1050 nr_migrate = cc->nr_migratepages; 1033 if (!cc->nr_migratepages)
1034 continue;
1035
1051 err = migrate_pages(&cc->migratepages, compaction_alloc, 1036 err = migrate_pages(&cc->migratepages, compaction_alloc,
1052 compaction_free, (unsigned long)cc, cc->mode, 1037 compaction_free, (unsigned long)cc, cc->mode,
1053 MR_COMPACTION); 1038 MR_COMPACTION);
1054 update_nr_listpages(cc);
1055 nr_remaining = cc->nr_migratepages;
1056 1039
1057 trace_mm_compaction_migratepages(nr_migrate - nr_remaining, 1040 trace_mm_compaction_migratepages(cc->nr_migratepages, err,
1058 nr_remaining); 1041 &cc->migratepages);
1059 1042
1060 /* Release isolated pages not migrated */ 1043 /* All pages were either migrated or will be released */
1044 cc->nr_migratepages = 0;
1061 if (err) { 1045 if (err) {
1062 putback_movable_pages(&cc->migratepages); 1046 putback_movable_pages(&cc->migratepages);
1063 cc->nr_migratepages = 0;
1064 /* 1047 /*
1065 * migrate_pages() may return -ENOMEM when scanners meet 1048 * migrate_pages() may return -ENOMEM when scanners meet
1066 * and we want compact_finished() to detect it 1049 * and we want compact_finished() to detect it