diff options
Diffstat (limited to 'fs')
103 files changed, 1731 insertions, 1944 deletions
diff --git a/fs/9p/cache.h b/fs/9p/cache.h index 40cc54ced5d9..2f9675491095 100644 --- a/fs/9p/cache.h +++ b/fs/9p/cache.h | |||
@@ -101,6 +101,18 @@ static inline void v9fs_fscache_wait_on_page_write(struct inode *inode, | |||
101 | 101 | ||
102 | #else /* CONFIG_9P_FSCACHE */ | 102 | #else /* CONFIG_9P_FSCACHE */ |
103 | 103 | ||
104 | static inline void v9fs_cache_inode_get_cookie(struct inode *inode) | ||
105 | { | ||
106 | } | ||
107 | |||
108 | static inline void v9fs_cache_inode_put_cookie(struct inode *inode) | ||
109 | { | ||
110 | } | ||
111 | |||
112 | static inline void v9fs_cache_inode_set_cookie(struct inode *inode, struct file *file) | ||
113 | { | ||
114 | } | ||
115 | |||
104 | static inline int v9fs_fscache_release_page(struct page *page, | 116 | static inline int v9fs_fscache_release_page(struct page *page, |
105 | gfp_t gfp) { | 117 | gfp_t gfp) { |
106 | return 1; | 118 | return 1; |
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index aa5ecf479a57..a0df3e73c2b1 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c | |||
@@ -105,10 +105,8 @@ int v9fs_file_open(struct inode *inode, struct file *file) | |||
105 | v9inode->writeback_fid = (void *) fid; | 105 | v9inode->writeback_fid = (void *) fid; |
106 | } | 106 | } |
107 | mutex_unlock(&v9inode->v_mutex); | 107 | mutex_unlock(&v9inode->v_mutex); |
108 | #ifdef CONFIG_9P_FSCACHE | ||
109 | if (v9ses->cache) | 108 | if (v9ses->cache) |
110 | v9fs_cache_inode_set_cookie(inode, file); | 109 | v9fs_cache_inode_set_cookie(inode, file); |
111 | #endif | ||
112 | return 0; | 110 | return 0; |
113 | out_error: | 111 | out_error: |
114 | p9_client_clunk(file->private_data); | 112 | p9_client_clunk(file->private_data); |
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 94de6d1482e2..4e65aa903345 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c | |||
@@ -448,9 +448,7 @@ void v9fs_evict_inode(struct inode *inode) | |||
448 | clear_inode(inode); | 448 | clear_inode(inode); |
449 | filemap_fdatawrite(inode->i_mapping); | 449 | filemap_fdatawrite(inode->i_mapping); |
450 | 450 | ||
451 | #ifdef CONFIG_9P_FSCACHE | ||
452 | v9fs_cache_inode_put_cookie(inode); | 451 | v9fs_cache_inode_put_cookie(inode); |
453 | #endif | ||
454 | /* clunk the fid stashed in writeback_fid */ | 452 | /* clunk the fid stashed in writeback_fid */ |
455 | if (v9inode->writeback_fid) { | 453 | if (v9inode->writeback_fid) { |
456 | p9_client_clunk(v9inode->writeback_fid); | 454 | p9_client_clunk(v9inode->writeback_fid); |
@@ -531,9 +529,7 @@ static struct inode *v9fs_qid_iget(struct super_block *sb, | |||
531 | goto error; | 529 | goto error; |
532 | 530 | ||
533 | v9fs_stat2inode(st, inode, sb); | 531 | v9fs_stat2inode(st, inode, sb); |
534 | #ifdef CONFIG_9P_FSCACHE | ||
535 | v9fs_cache_inode_get_cookie(inode); | 532 | v9fs_cache_inode_get_cookie(inode); |
536 | #endif | ||
537 | unlock_new_inode(inode); | 533 | unlock_new_inode(inode); |
538 | return inode; | 534 | return inode; |
539 | error: | 535 | error: |
@@ -905,10 +901,8 @@ v9fs_vfs_atomic_open(struct inode *dir, struct dentry *dentry, | |||
905 | goto error; | 901 | goto error; |
906 | 902 | ||
907 | file->private_data = fid; | 903 | file->private_data = fid; |
908 | #ifdef CONFIG_9P_FSCACHE | ||
909 | if (v9ses->cache) | 904 | if (v9ses->cache) |
910 | v9fs_cache_inode_set_cookie(dentry->d_inode, file); | 905 | v9fs_cache_inode_set_cookie(dentry->d_inode, file); |
911 | #endif | ||
912 | 906 | ||
913 | *opened |= FILE_CREATED; | 907 | *opened |= FILE_CREATED; |
914 | out: | 908 | out: |
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index a7c481402c46..4c10edec26a0 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c | |||
@@ -141,9 +141,7 @@ static struct inode *v9fs_qid_iget_dotl(struct super_block *sb, | |||
141 | goto error; | 141 | goto error; |
142 | 142 | ||
143 | v9fs_stat2inode_dotl(st, inode); | 143 | v9fs_stat2inode_dotl(st, inode); |
144 | #ifdef CONFIG_9P_FSCACHE | ||
145 | v9fs_cache_inode_get_cookie(inode); | 144 | v9fs_cache_inode_get_cookie(inode); |
146 | #endif | ||
147 | retval = v9fs_get_acl(inode, fid); | 145 | retval = v9fs_get_acl(inode, fid); |
148 | if (retval) | 146 | if (retval) |
149 | goto error; | 147 | goto error; |
@@ -355,10 +353,8 @@ v9fs_vfs_atomic_open_dotl(struct inode *dir, struct dentry *dentry, | |||
355 | if (err) | 353 | if (err) |
356 | goto err_clunk_old_fid; | 354 | goto err_clunk_old_fid; |
357 | file->private_data = ofid; | 355 | file->private_data = ofid; |
358 | #ifdef CONFIG_9P_FSCACHE | ||
359 | if (v9ses->cache) | 356 | if (v9ses->cache) |
360 | v9fs_cache_inode_set_cookie(inode, file); | 357 | v9fs_cache_inode_set_cookie(inode, file); |
361 | #endif | ||
362 | *opened |= FILE_CREATED; | 358 | *opened |= FILE_CREATED; |
363 | out: | 359 | out: |
364 | v9fs_put_acl(dacl, pacl); | 360 | v9fs_put_acl(dacl, pacl); |
diff --git a/fs/adfs/adfs.h b/fs/adfs/adfs.h index 585adafb0cc2..c770337c4b45 100644 --- a/fs/adfs/adfs.h +++ b/fs/adfs/adfs.h | |||
@@ -43,9 +43,12 @@ struct adfs_dir_ops; | |||
43 | * ADFS file system superblock data in memory | 43 | * ADFS file system superblock data in memory |
44 | */ | 44 | */ |
45 | struct adfs_sb_info { | 45 | struct adfs_sb_info { |
46 | struct adfs_discmap *s_map; /* bh list containing map */ | 46 | union { struct { |
47 | struct adfs_dir_ops *s_dir; /* directory operations */ | 47 | struct adfs_discmap *s_map; /* bh list containing map */ |
48 | 48 | struct adfs_dir_ops *s_dir; /* directory operations */ | |
49 | }; | ||
50 | struct rcu_head rcu; /* used only at shutdown time */ | ||
51 | }; | ||
49 | kuid_t s_uid; /* owner uid */ | 52 | kuid_t s_uid; /* owner uid */ |
50 | kgid_t s_gid; /* owner gid */ | 53 | kgid_t s_gid; /* owner gid */ |
51 | umode_t s_owner_mask; /* ADFS owner perm -> unix perm */ | 54 | umode_t s_owner_mask; /* ADFS owner perm -> unix perm */ |
diff --git a/fs/adfs/super.c b/fs/adfs/super.c index 0ff4bae2c2a2..7b3003cb6f1b 100644 --- a/fs/adfs/super.c +++ b/fs/adfs/super.c | |||
@@ -123,8 +123,7 @@ static void adfs_put_super(struct super_block *sb) | |||
123 | for (i = 0; i < asb->s_map_size; i++) | 123 | for (i = 0; i < asb->s_map_size; i++) |
124 | brelse(asb->s_map[i].dm_bh); | 124 | brelse(asb->s_map[i].dm_bh); |
125 | kfree(asb->s_map); | 125 | kfree(asb->s_map); |
126 | kfree(asb); | 126 | kfree_rcu(asb, rcu); |
127 | sb->s_fs_info = NULL; | ||
128 | } | 127 | } |
129 | 128 | ||
130 | static int adfs_show_options(struct seq_file *seq, struct dentry *root) | 129 | static int adfs_show_options(struct seq_file *seq, struct dentry *root) |
@@ -36,10 +36,10 @@ | |||
36 | #include <linux/eventfd.h> | 36 | #include <linux/eventfd.h> |
37 | #include <linux/blkdev.h> | 37 | #include <linux/blkdev.h> |
38 | #include <linux/compat.h> | 38 | #include <linux/compat.h> |
39 | #include <linux/anon_inodes.h> | ||
40 | #include <linux/migrate.h> | 39 | #include <linux/migrate.h> |
41 | #include <linux/ramfs.h> | 40 | #include <linux/ramfs.h> |
42 | #include <linux/percpu-refcount.h> | 41 | #include <linux/percpu-refcount.h> |
42 | #include <linux/mount.h> | ||
43 | 43 | ||
44 | #include <asm/kmap_types.h> | 44 | #include <asm/kmap_types.h> |
45 | #include <asm/uaccess.h> | 45 | #include <asm/uaccess.h> |
@@ -152,12 +152,67 @@ unsigned long aio_max_nr = 0x10000; /* system wide maximum number of aio request | |||
152 | static struct kmem_cache *kiocb_cachep; | 152 | static struct kmem_cache *kiocb_cachep; |
153 | static struct kmem_cache *kioctx_cachep; | 153 | static struct kmem_cache *kioctx_cachep; |
154 | 154 | ||
155 | static struct vfsmount *aio_mnt; | ||
156 | |||
157 | static const struct file_operations aio_ring_fops; | ||
158 | static const struct address_space_operations aio_ctx_aops; | ||
159 | |||
160 | static struct file *aio_private_file(struct kioctx *ctx, loff_t nr_pages) | ||
161 | { | ||
162 | struct qstr this = QSTR_INIT("[aio]", 5); | ||
163 | struct file *file; | ||
164 | struct path path; | ||
165 | struct inode *inode = alloc_anon_inode(aio_mnt->mnt_sb); | ||
166 | if (!inode) | ||
167 | return ERR_PTR(-ENOMEM); | ||
168 | |||
169 | inode->i_mapping->a_ops = &aio_ctx_aops; | ||
170 | inode->i_mapping->private_data = ctx; | ||
171 | inode->i_size = PAGE_SIZE * nr_pages; | ||
172 | |||
173 | path.dentry = d_alloc_pseudo(aio_mnt->mnt_sb, &this); | ||
174 | if (!path.dentry) { | ||
175 | iput(inode); | ||
176 | return ERR_PTR(-ENOMEM); | ||
177 | } | ||
178 | path.mnt = mntget(aio_mnt); | ||
179 | |||
180 | d_instantiate(path.dentry, inode); | ||
181 | file = alloc_file(&path, FMODE_READ | FMODE_WRITE, &aio_ring_fops); | ||
182 | if (IS_ERR(file)) { | ||
183 | path_put(&path); | ||
184 | return file; | ||
185 | } | ||
186 | |||
187 | file->f_flags = O_RDWR; | ||
188 | file->private_data = ctx; | ||
189 | return file; | ||
190 | } | ||
191 | |||
192 | static struct dentry *aio_mount(struct file_system_type *fs_type, | ||
193 | int flags, const char *dev_name, void *data) | ||
194 | { | ||
195 | static const struct dentry_operations ops = { | ||
196 | .d_dname = simple_dname, | ||
197 | }; | ||
198 | return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1); | ||
199 | } | ||
200 | |||
155 | /* aio_setup | 201 | /* aio_setup |
156 | * Creates the slab caches used by the aio routines, panic on | 202 | * Creates the slab caches used by the aio routines, panic on |
157 | * failure as this is done early during the boot sequence. | 203 | * failure as this is done early during the boot sequence. |
158 | */ | 204 | */ |
159 | static int __init aio_setup(void) | 205 | static int __init aio_setup(void) |
160 | { | 206 | { |
207 | static struct file_system_type aio_fs = { | ||
208 | .name = "aio", | ||
209 | .mount = aio_mount, | ||
210 | .kill_sb = kill_anon_super, | ||
211 | }; | ||
212 | aio_mnt = kern_mount(&aio_fs); | ||
213 | if (IS_ERR(aio_mnt)) | ||
214 | panic("Failed to create aio fs mount."); | ||
215 | |||
161 | kiocb_cachep = KMEM_CACHE(kiocb, SLAB_HWCACHE_ALIGN|SLAB_PANIC); | 216 | kiocb_cachep = KMEM_CACHE(kiocb, SLAB_HWCACHE_ALIGN|SLAB_PANIC); |
162 | kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC); | 217 | kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC); |
163 | 218 | ||
@@ -283,16 +338,12 @@ static int aio_setup_ring(struct kioctx *ctx) | |||
283 | if (nr_pages < 0) | 338 | if (nr_pages < 0) |
284 | return -EINVAL; | 339 | return -EINVAL; |
285 | 340 | ||
286 | file = anon_inode_getfile_private("[aio]", &aio_ring_fops, ctx, O_RDWR); | 341 | file = aio_private_file(ctx, nr_pages); |
287 | if (IS_ERR(file)) { | 342 | if (IS_ERR(file)) { |
288 | ctx->aio_ring_file = NULL; | 343 | ctx->aio_ring_file = NULL; |
289 | return -EAGAIN; | 344 | return -EAGAIN; |
290 | } | 345 | } |
291 | 346 | ||
292 | file->f_inode->i_mapping->a_ops = &aio_ctx_aops; | ||
293 | file->f_inode->i_mapping->private_data = ctx; | ||
294 | file->f_inode->i_size = PAGE_SIZE * (loff_t)nr_pages; | ||
295 | |||
296 | for (i = 0; i < nr_pages; i++) { | 347 | for (i = 0; i < nr_pages; i++) { |
297 | struct page *page; | 348 | struct page *page; |
298 | page = find_or_create_page(file->f_inode->i_mapping, | 349 | page = find_or_create_page(file->f_inode->i_mapping, |
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index 85c961849953..24084732b1d0 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c | |||
@@ -24,7 +24,6 @@ | |||
24 | 24 | ||
25 | static struct vfsmount *anon_inode_mnt __read_mostly; | 25 | static struct vfsmount *anon_inode_mnt __read_mostly; |
26 | static struct inode *anon_inode_inode; | 26 | static struct inode *anon_inode_inode; |
27 | static const struct file_operations anon_inode_fops; | ||
28 | 27 | ||
29 | /* | 28 | /* |
30 | * anon_inodefs_dname() is called from d_path(). | 29 | * anon_inodefs_dname() is called from d_path(). |
@@ -39,51 +38,6 @@ static const struct dentry_operations anon_inodefs_dentry_operations = { | |||
39 | .d_dname = anon_inodefs_dname, | 38 | .d_dname = anon_inodefs_dname, |
40 | }; | 39 | }; |
41 | 40 | ||
42 | /* | ||
43 | * nop .set_page_dirty method so that people can use .page_mkwrite on | ||
44 | * anon inodes. | ||
45 | */ | ||
46 | static int anon_set_page_dirty(struct page *page) | ||
47 | { | ||
48 | return 0; | ||
49 | }; | ||
50 | |||
51 | static const struct address_space_operations anon_aops = { | ||
52 | .set_page_dirty = anon_set_page_dirty, | ||
53 | }; | ||
54 | |||
55 | /* | ||
56 | * A single inode exists for all anon_inode files. Contrary to pipes, | ||
57 | * anon_inode inodes have no associated per-instance data, so we need | ||
58 | * only allocate one of them. | ||
59 | */ | ||
60 | static struct inode *anon_inode_mkinode(struct super_block *s) | ||
61 | { | ||
62 | struct inode *inode = new_inode_pseudo(s); | ||
63 | |||
64 | if (!inode) | ||
65 | return ERR_PTR(-ENOMEM); | ||
66 | |||
67 | inode->i_ino = get_next_ino(); | ||
68 | inode->i_fop = &anon_inode_fops; | ||
69 | |||
70 | inode->i_mapping->a_ops = &anon_aops; | ||
71 | |||
72 | /* | ||
73 | * Mark the inode dirty from the very beginning, | ||
74 | * that way it will never be moved to the dirty | ||
75 | * list because mark_inode_dirty() will think | ||
76 | * that it already _is_ on the dirty list. | ||
77 | */ | ||
78 | inode->i_state = I_DIRTY; | ||
79 | inode->i_mode = S_IRUSR | S_IWUSR; | ||
80 | inode->i_uid = current_fsuid(); | ||
81 | inode->i_gid = current_fsgid(); | ||
82 | inode->i_flags |= S_PRIVATE; | ||
83 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; | ||
84 | return inode; | ||
85 | } | ||
86 | |||
87 | static struct dentry *anon_inodefs_mount(struct file_system_type *fs_type, | 41 | static struct dentry *anon_inodefs_mount(struct file_system_type *fs_type, |
88 | int flags, const char *dev_name, void *data) | 42 | int flags, const char *dev_name, void *data) |
89 | { | 43 | { |
@@ -92,7 +46,7 @@ static struct dentry *anon_inodefs_mount(struct file_system_type *fs_type, | |||
92 | &anon_inodefs_dentry_operations, ANON_INODE_FS_MAGIC); | 46 | &anon_inodefs_dentry_operations, ANON_INODE_FS_MAGIC); |
93 | if (!IS_ERR(root)) { | 47 | if (!IS_ERR(root)) { |
94 | struct super_block *s = root->d_sb; | 48 | struct super_block *s = root->d_sb; |
95 | anon_inode_inode = anon_inode_mkinode(s); | 49 | anon_inode_inode = alloc_anon_inode(s); |
96 | if (IS_ERR(anon_inode_inode)) { | 50 | if (IS_ERR(anon_inode_inode)) { |
97 | dput(root); | 51 | dput(root); |
98 | deactivate_locked_super(s); | 52 | deactivate_locked_super(s); |
@@ -109,72 +63,6 @@ static struct file_system_type anon_inode_fs_type = { | |||
109 | }; | 63 | }; |
110 | 64 | ||
111 | /** | 65 | /** |
112 | * anon_inode_getfile_private - creates a new file instance by hooking it up to an | ||
113 | * anonymous inode, and a dentry that describe the "class" | ||
114 | * of the file | ||
115 | * | ||
116 | * @name: [in] name of the "class" of the new file | ||
117 | * @fops: [in] file operations for the new file | ||
118 | * @priv: [in] private data for the new file (will be file's private_data) | ||
119 | * @flags: [in] flags | ||
120 | * | ||
121 | * | ||
122 | * Similar to anon_inode_getfile, but each file holds a single inode. | ||
123 | * | ||
124 | */ | ||
125 | struct file *anon_inode_getfile_private(const char *name, | ||
126 | const struct file_operations *fops, | ||
127 | void *priv, int flags) | ||
128 | { | ||
129 | struct qstr this; | ||
130 | struct path path; | ||
131 | struct file *file; | ||
132 | struct inode *inode; | ||
133 | |||
134 | if (fops->owner && !try_module_get(fops->owner)) | ||
135 | return ERR_PTR(-ENOENT); | ||
136 | |||
137 | inode = anon_inode_mkinode(anon_inode_mnt->mnt_sb); | ||
138 | if (IS_ERR(inode)) { | ||
139 | file = ERR_PTR(-ENOMEM); | ||
140 | goto err_module; | ||
141 | } | ||
142 | |||
143 | /* | ||
144 | * Link the inode to a directory entry by creating a unique name | ||
145 | * using the inode sequence number. | ||
146 | */ | ||
147 | file = ERR_PTR(-ENOMEM); | ||
148 | this.name = name; | ||
149 | this.len = strlen(name); | ||
150 | this.hash = 0; | ||
151 | path.dentry = d_alloc_pseudo(anon_inode_mnt->mnt_sb, &this); | ||
152 | if (!path.dentry) | ||
153 | goto err_module; | ||
154 | |||
155 | path.mnt = mntget(anon_inode_mnt); | ||
156 | |||
157 | d_instantiate(path.dentry, inode); | ||
158 | |||
159 | file = alloc_file(&path, OPEN_FMODE(flags), fops); | ||
160 | if (IS_ERR(file)) | ||
161 | goto err_dput; | ||
162 | |||
163 | file->f_mapping = inode->i_mapping; | ||
164 | file->f_flags = flags & (O_ACCMODE | O_NONBLOCK); | ||
165 | file->private_data = priv; | ||
166 | |||
167 | return file; | ||
168 | |||
169 | err_dput: | ||
170 | path_put(&path); | ||
171 | err_module: | ||
172 | module_put(fops->owner); | ||
173 | return file; | ||
174 | } | ||
175 | EXPORT_SYMBOL_GPL(anon_inode_getfile_private); | ||
176 | |||
177 | /** | ||
178 | * anon_inode_getfile - creates a new file instance by hooking it up to an | 66 | * anon_inode_getfile - creates a new file instance by hooking it up to an |
179 | * anonymous inode, and a dentry that describe the "class" | 67 | * anonymous inode, and a dentry that describe the "class" |
180 | * of the file | 68 | * of the file |
@@ -167,7 +167,27 @@ void setattr_copy(struct inode *inode, const struct iattr *attr) | |||
167 | } | 167 | } |
168 | EXPORT_SYMBOL(setattr_copy); | 168 | EXPORT_SYMBOL(setattr_copy); |
169 | 169 | ||
170 | int notify_change(struct dentry * dentry, struct iattr * attr) | 170 | /** |
171 | * notify_change - modify attributes of a filesytem object | ||
172 | * @dentry: object affected | ||
173 | * @iattr: new attributes | ||
174 | * @delegated_inode: returns inode, if the inode is delegated | ||
175 | * | ||
176 | * The caller must hold the i_mutex on the affected object. | ||
177 | * | ||
178 | * If notify_change discovers a delegation in need of breaking, | ||
179 | * it will return -EWOULDBLOCK and return a reference to the inode in | ||
180 | * delegated_inode. The caller should then break the delegation and | ||
181 | * retry. Because breaking a delegation may take a long time, the | ||
182 | * caller should drop the i_mutex before doing so. | ||
183 | * | ||
184 | * Alternatively, a caller may pass NULL for delegated_inode. This may | ||
185 | * be appropriate for callers that expect the underlying filesystem not | ||
186 | * to be NFS exported. Also, passing NULL is fine for callers holding | ||
187 | * the file open for write, as there can be no conflicting delegation in | ||
188 | * that case. | ||
189 | */ | ||
190 | int notify_change(struct dentry * dentry, struct iattr * attr, struct inode **delegated_inode) | ||
171 | { | 191 | { |
172 | struct inode *inode = dentry->d_inode; | 192 | struct inode *inode = dentry->d_inode; |
173 | umode_t mode = inode->i_mode; | 193 | umode_t mode = inode->i_mode; |
@@ -243,6 +263,9 @@ int notify_change(struct dentry * dentry, struct iattr * attr) | |||
243 | error = security_inode_setattr(dentry, attr); | 263 | error = security_inode_setattr(dentry, attr); |
244 | if (error) | 264 | if (error) |
245 | return error; | 265 | return error; |
266 | error = try_break_deleg(inode, delegated_inode); | ||
267 | if (error) | ||
268 | return error; | ||
246 | 269 | ||
247 | if (inode->i_op->setattr) | 270 | if (inode->i_op->setattr) |
248 | error = inode->i_op->setattr(dentry, attr); | 271 | error = inode->i_op->setattr(dentry, attr); |
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 3f1128b37e46..4218e26df916 100644 --- a/fs/autofs4/autofs_i.h +++ b/fs/autofs4/autofs_i.h | |||
@@ -122,6 +122,7 @@ struct autofs_sb_info { | |||
122 | spinlock_t lookup_lock; | 122 | spinlock_t lookup_lock; |
123 | struct list_head active_list; | 123 | struct list_head active_list; |
124 | struct list_head expiring_list; | 124 | struct list_head expiring_list; |
125 | struct rcu_head rcu; | ||
125 | }; | 126 | }; |
126 | 127 | ||
127 | static inline struct autofs_sb_info *autofs4_sbi(struct super_block *sb) | 128 | static inline struct autofs_sb_info *autofs4_sbi(struct super_block *sb) |
@@ -271,7 +272,7 @@ void autofs4_clean_ino(struct autofs_info *); | |||
271 | 272 | ||
272 | static inline int autofs_prepare_pipe(struct file *pipe) | 273 | static inline int autofs_prepare_pipe(struct file *pipe) |
273 | { | 274 | { |
274 | if (!pipe->f_op || !pipe->f_op->write) | 275 | if (!pipe->f_op->write) |
275 | return -EINVAL; | 276 | return -EINVAL; |
276 | if (!S_ISFIFO(file_inode(pipe)->i_mode)) | 277 | if (!S_ISFIFO(file_inode(pipe)->i_mode)) |
277 | return -EINVAL; | 278 | return -EINVAL; |
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index 0f00da329e71..1818ce7f5a06 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c | |||
@@ -658,12 +658,6 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use | |||
658 | goto out; | 658 | goto out; |
659 | } | 659 | } |
660 | 660 | ||
661 | if (!fp->f_op) { | ||
662 | err = -ENOTTY; | ||
663 | fput(fp); | ||
664 | goto out; | ||
665 | } | ||
666 | |||
667 | sbi = autofs_dev_ioctl_sbi(fp); | 661 | sbi = autofs_dev_ioctl_sbi(fp); |
668 | if (!sbi || sbi->magic != AUTOFS_SBI_MAGIC) { | 662 | if (!sbi || sbi->magic != AUTOFS_SBI_MAGIC) { |
669 | err = -EINVAL; | 663 | err = -EINVAL; |
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index b104726e2d0a..3b9cc9b973c2 100644 --- a/fs/autofs4/inode.c +++ b/fs/autofs4/inode.c | |||
@@ -56,18 +56,13 @@ void autofs4_kill_sb(struct super_block *sb) | |||
56 | * just call kill_anon_super when we are called from | 56 | * just call kill_anon_super when we are called from |
57 | * deactivate_super. | 57 | * deactivate_super. |
58 | */ | 58 | */ |
59 | if (!sbi) | 59 | if (sbi) /* Free wait queues, close pipe */ |
60 | goto out_kill_sb; | 60 | autofs4_catatonic_mode(sbi); |
61 | |||
62 | /* Free wait queues, close pipe */ | ||
63 | autofs4_catatonic_mode(sbi); | ||
64 | |||
65 | sb->s_fs_info = NULL; | ||
66 | kfree(sbi); | ||
67 | 61 | ||
68 | out_kill_sb: | ||
69 | DPRINTK("shutting down"); | 62 | DPRINTK("shutting down"); |
70 | kill_litter_super(sb); | 63 | kill_litter_super(sb); |
64 | if (sbi) | ||
65 | kfree_rcu(sbi, rcu); | ||
71 | } | 66 | } |
72 | 67 | ||
73 | static int autofs4_show_options(struct seq_file *m, struct dentry *root) | 68 | static int autofs4_show_options(struct seq_file *m, struct dentry *root) |
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index e9c75e20db32..daa15d6ba450 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c | |||
@@ -42,7 +42,7 @@ static void befs_destroy_inode(struct inode *inode); | |||
42 | static int befs_init_inodecache(void); | 42 | static int befs_init_inodecache(void); |
43 | static void befs_destroy_inodecache(void); | 43 | static void befs_destroy_inodecache(void); |
44 | static void *befs_follow_link(struct dentry *, struct nameidata *); | 44 | static void *befs_follow_link(struct dentry *, struct nameidata *); |
45 | static void befs_put_link(struct dentry *, struct nameidata *, void *); | 45 | static void *befs_fast_follow_link(struct dentry *, struct nameidata *); |
46 | static int befs_utf2nls(struct super_block *sb, const char *in, int in_len, | 46 | static int befs_utf2nls(struct super_block *sb, const char *in, int in_len, |
47 | char **out, int *out_len); | 47 | char **out, int *out_len); |
48 | static int befs_nls2utf(struct super_block *sb, const char *in, int in_len, | 48 | static int befs_nls2utf(struct super_block *sb, const char *in, int in_len, |
@@ -79,10 +79,15 @@ static const struct address_space_operations befs_aops = { | |||
79 | .bmap = befs_bmap, | 79 | .bmap = befs_bmap, |
80 | }; | 80 | }; |
81 | 81 | ||
82 | static const struct inode_operations befs_fast_symlink_inode_operations = { | ||
83 | .readlink = generic_readlink, | ||
84 | .follow_link = befs_fast_follow_link, | ||
85 | }; | ||
86 | |||
82 | static const struct inode_operations befs_symlink_inode_operations = { | 87 | static const struct inode_operations befs_symlink_inode_operations = { |
83 | .readlink = generic_readlink, | 88 | .readlink = generic_readlink, |
84 | .follow_link = befs_follow_link, | 89 | .follow_link = befs_follow_link, |
85 | .put_link = befs_put_link, | 90 | .put_link = kfree_put_link, |
86 | }; | 91 | }; |
87 | 92 | ||
88 | /* | 93 | /* |
@@ -411,7 +416,10 @@ static struct inode *befs_iget(struct super_block *sb, unsigned long ino) | |||
411 | inode->i_op = &befs_dir_inode_operations; | 416 | inode->i_op = &befs_dir_inode_operations; |
412 | inode->i_fop = &befs_dir_operations; | 417 | inode->i_fop = &befs_dir_operations; |
413 | } else if (S_ISLNK(inode->i_mode)) { | 418 | } else if (S_ISLNK(inode->i_mode)) { |
414 | inode->i_op = &befs_symlink_inode_operations; | 419 | if (befs_ino->i_flags & BEFS_LONG_SYMLINK) |
420 | inode->i_op = &befs_symlink_inode_operations; | ||
421 | else | ||
422 | inode->i_op = &befs_fast_symlink_inode_operations; | ||
415 | } else { | 423 | } else { |
416 | befs_error(sb, "Inode %lu is not a regular file, " | 424 | befs_error(sb, "Inode %lu is not a regular file, " |
417 | "directory or symlink. THAT IS WRONG! BeFS has no " | 425 | "directory or symlink. THAT IS WRONG! BeFS has no " |
@@ -477,47 +485,40 @@ befs_destroy_inodecache(void) | |||
477 | static void * | 485 | static void * |
478 | befs_follow_link(struct dentry *dentry, struct nameidata *nd) | 486 | befs_follow_link(struct dentry *dentry, struct nameidata *nd) |
479 | { | 487 | { |
488 | struct super_block *sb = dentry->d_sb; | ||
480 | befs_inode_info *befs_ino = BEFS_I(dentry->d_inode); | 489 | befs_inode_info *befs_ino = BEFS_I(dentry->d_inode); |
490 | befs_data_stream *data = &befs_ino->i_data.ds; | ||
491 | befs_off_t len = data->size; | ||
481 | char *link; | 492 | char *link; |
482 | 493 | ||
483 | if (befs_ino->i_flags & BEFS_LONG_SYMLINK) { | 494 | if (len == 0) { |
484 | struct super_block *sb = dentry->d_sb; | 495 | befs_error(sb, "Long symlink with illegal length"); |
485 | befs_data_stream *data = &befs_ino->i_data.ds; | 496 | link = ERR_PTR(-EIO); |
486 | befs_off_t len = data->size; | 497 | } else { |
498 | befs_debug(sb, "Follow long symlink"); | ||
487 | 499 | ||
488 | if (len == 0) { | 500 | link = kmalloc(len, GFP_NOFS); |
489 | befs_error(sb, "Long symlink with illegal length"); | 501 | if (!link) { |
502 | link = ERR_PTR(-ENOMEM); | ||
503 | } else if (befs_read_lsymlink(sb, data, link, len) != len) { | ||
504 | kfree(link); | ||
505 | befs_error(sb, "Failed to read entire long symlink"); | ||
490 | link = ERR_PTR(-EIO); | 506 | link = ERR_PTR(-EIO); |
491 | } else { | 507 | } else { |
492 | befs_debug(sb, "Follow long symlink"); | 508 | link[len - 1] = '\0'; |
493 | |||
494 | link = kmalloc(len, GFP_NOFS); | ||
495 | if (!link) { | ||
496 | link = ERR_PTR(-ENOMEM); | ||
497 | } else if (befs_read_lsymlink(sb, data, link, len) != len) { | ||
498 | kfree(link); | ||
499 | befs_error(sb, "Failed to read entire long symlink"); | ||
500 | link = ERR_PTR(-EIO); | ||
501 | } else { | ||
502 | link[len - 1] = '\0'; | ||
503 | } | ||
504 | } | 509 | } |
505 | } else { | ||
506 | link = befs_ino->i_data.symlink; | ||
507 | } | 510 | } |
508 | |||
509 | nd_set_link(nd, link); | 511 | nd_set_link(nd, link); |
510 | return NULL; | 512 | return NULL; |
511 | } | 513 | } |
512 | 514 | ||
513 | static void befs_put_link(struct dentry *dentry, struct nameidata *nd, void *p) | 515 | |
516 | static void * | ||
517 | befs_fast_follow_link(struct dentry *dentry, struct nameidata *nd) | ||
514 | { | 518 | { |
515 | befs_inode_info *befs_ino = BEFS_I(dentry->d_inode); | 519 | befs_inode_info *befs_ino = BEFS_I(dentry->d_inode); |
516 | if (befs_ino->i_flags & BEFS_LONG_SYMLINK) { | 520 | nd_set_link(nd, befs_ino->i_data.symlink); |
517 | char *link = nd_get_link(nd); | 521 | return NULL; |
518 | if (!IS_ERR(link)) | ||
519 | kfree(link); | ||
520 | } | ||
521 | } | 522 | } |
522 | 523 | ||
523 | /* | 524 | /* |
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c index 89dec7f789a4..ca0ba15a7306 100644 --- a/fs/binfmt_aout.c +++ b/fs/binfmt_aout.c | |||
@@ -45,7 +45,6 @@ static int load_aout_library(struct file*); | |||
45 | */ | 45 | */ |
46 | static int aout_core_dump(struct coredump_params *cprm) | 46 | static int aout_core_dump(struct coredump_params *cprm) |
47 | { | 47 | { |
48 | struct file *file = cprm->file; | ||
49 | mm_segment_t fs; | 48 | mm_segment_t fs; |
50 | int has_dumped = 0; | 49 | int has_dumped = 0; |
51 | void __user *dump_start; | 50 | void __user *dump_start; |
@@ -85,10 +84,10 @@ static int aout_core_dump(struct coredump_params *cprm) | |||
85 | 84 | ||
86 | set_fs(KERNEL_DS); | 85 | set_fs(KERNEL_DS); |
87 | /* struct user */ | 86 | /* struct user */ |
88 | if (!dump_write(file, &dump, sizeof(dump))) | 87 | if (!dump_emit(cprm, &dump, sizeof(dump))) |
89 | goto end_coredump; | 88 | goto end_coredump; |
90 | /* Now dump all of the user data. Include malloced stuff as well */ | 89 | /* Now dump all of the user data. Include malloced stuff as well */ |
91 | if (!dump_seek(cprm->file, PAGE_SIZE - sizeof(dump))) | 90 | if (!dump_skip(cprm, PAGE_SIZE - sizeof(dump))) |
92 | goto end_coredump; | 91 | goto end_coredump; |
93 | /* now we start writing out the user space info */ | 92 | /* now we start writing out the user space info */ |
94 | set_fs(USER_DS); | 93 | set_fs(USER_DS); |
@@ -96,14 +95,14 @@ static int aout_core_dump(struct coredump_params *cprm) | |||
96 | if (dump.u_dsize != 0) { | 95 | if (dump.u_dsize != 0) { |
97 | dump_start = START_DATA(dump); | 96 | dump_start = START_DATA(dump); |
98 | dump_size = dump.u_dsize << PAGE_SHIFT; | 97 | dump_size = dump.u_dsize << PAGE_SHIFT; |
99 | if (!dump_write(file, dump_start, dump_size)) | 98 | if (!dump_emit(cprm, dump_start, dump_size)) |
100 | goto end_coredump; | 99 | goto end_coredump; |
101 | } | 100 | } |
102 | /* Now prepare to dump the stack area */ | 101 | /* Now prepare to dump the stack area */ |
103 | if (dump.u_ssize != 0) { | 102 | if (dump.u_ssize != 0) { |
104 | dump_start = START_STACK(dump); | 103 | dump_start = START_STACK(dump); |
105 | dump_size = dump.u_ssize << PAGE_SHIFT; | 104 | dump_size = dump.u_ssize << PAGE_SHIFT; |
106 | if (!dump_write(file, dump_start, dump_size)) | 105 | if (!dump_emit(cprm, dump_start, dump_size)) |
107 | goto end_coredump; | 106 | goto end_coredump; |
108 | } | 107 | } |
109 | end_coredump: | 108 | end_coredump: |
@@ -221,7 +220,7 @@ static int load_aout_binary(struct linux_binprm * bprm) | |||
221 | * Requires a mmap handler. This prevents people from using a.out | 220 | * Requires a mmap handler. This prevents people from using a.out |
222 | * as part of an exploit attack against /proc-related vulnerabilities. | 221 | * as part of an exploit attack against /proc-related vulnerabilities. |
223 | */ | 222 | */ |
224 | if (!bprm->file->f_op || !bprm->file->f_op->mmap) | 223 | if (!bprm->file->f_op->mmap) |
225 | return -ENOEXEC; | 224 | return -ENOEXEC; |
226 | 225 | ||
227 | fd_offset = N_TXTOFF(ex); | 226 | fd_offset = N_TXTOFF(ex); |
@@ -374,7 +373,7 @@ static int load_aout_library(struct file *file) | |||
374 | * Requires a mmap handler. This prevents people from using a.out | 373 | * Requires a mmap handler. This prevents people from using a.out |
375 | * as part of an exploit attack against /proc-related vulnerabilities. | 374 | * as part of an exploit attack against /proc-related vulnerabilities. |
376 | */ | 375 | */ |
377 | if (!file->f_op || !file->f_op->mmap) | 376 | if (!file->f_op->mmap) |
378 | goto out; | 377 | goto out; |
379 | 378 | ||
380 | if (N_FLAGS(ex)) | 379 | if (N_FLAGS(ex)) |
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 4c94a79991bb..571a42326908 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c | |||
@@ -406,7 +406,7 @@ static unsigned long load_elf_interp(struct elfhdr *interp_elf_ex, | |||
406 | goto out; | 406 | goto out; |
407 | if (!elf_check_arch(interp_elf_ex)) | 407 | if (!elf_check_arch(interp_elf_ex)) |
408 | goto out; | 408 | goto out; |
409 | if (!interpreter->f_op || !interpreter->f_op->mmap) | 409 | if (!interpreter->f_op->mmap) |
410 | goto out; | 410 | goto out; |
411 | 411 | ||
412 | /* | 412 | /* |
@@ -607,7 +607,7 @@ static int load_elf_binary(struct linux_binprm *bprm) | |||
607 | goto out; | 607 | goto out; |
608 | if (!elf_check_arch(&loc->elf_ex)) | 608 | if (!elf_check_arch(&loc->elf_ex)) |
609 | goto out; | 609 | goto out; |
610 | if (!bprm->file->f_op || !bprm->file->f_op->mmap) | 610 | if (!bprm->file->f_op->mmap) |
611 | goto out; | 611 | goto out; |
612 | 612 | ||
613 | /* Now read in all of the header information */ | 613 | /* Now read in all of the header information */ |
@@ -1028,7 +1028,7 @@ static int load_elf_library(struct file *file) | |||
1028 | 1028 | ||
1029 | /* First of all, some simple consistency checks */ | 1029 | /* First of all, some simple consistency checks */ |
1030 | if (elf_ex.e_type != ET_EXEC || elf_ex.e_phnum > 2 || | 1030 | if (elf_ex.e_type != ET_EXEC || elf_ex.e_phnum > 2 || |
1031 | !elf_check_arch(&elf_ex) || !file->f_op || !file->f_op->mmap) | 1031 | !elf_check_arch(&elf_ex) || !file->f_op->mmap) |
1032 | goto out; | 1032 | goto out; |
1033 | 1033 | ||
1034 | /* Now read in all of the header information */ | 1034 | /* Now read in all of the header information */ |
@@ -1225,35 +1225,17 @@ static int notesize(struct memelfnote *en) | |||
1225 | return sz; | 1225 | return sz; |
1226 | } | 1226 | } |
1227 | 1227 | ||
1228 | #define DUMP_WRITE(addr, nr, foffset) \ | 1228 | static int writenote(struct memelfnote *men, struct coredump_params *cprm) |
1229 | do { if (!dump_write(file, (addr), (nr))) return 0; *foffset += (nr); } while(0) | ||
1230 | |||
1231 | static int alignfile(struct file *file, loff_t *foffset) | ||
1232 | { | ||
1233 | static const char buf[4] = { 0, }; | ||
1234 | DUMP_WRITE(buf, roundup(*foffset, 4) - *foffset, foffset); | ||
1235 | return 1; | ||
1236 | } | ||
1237 | |||
1238 | static int writenote(struct memelfnote *men, struct file *file, | ||
1239 | loff_t *foffset) | ||
1240 | { | 1229 | { |
1241 | struct elf_note en; | 1230 | struct elf_note en; |
1242 | en.n_namesz = strlen(men->name) + 1; | 1231 | en.n_namesz = strlen(men->name) + 1; |
1243 | en.n_descsz = men->datasz; | 1232 | en.n_descsz = men->datasz; |
1244 | en.n_type = men->type; | 1233 | en.n_type = men->type; |
1245 | 1234 | ||
1246 | DUMP_WRITE(&en, sizeof(en), foffset); | 1235 | return dump_emit(cprm, &en, sizeof(en)) && |
1247 | DUMP_WRITE(men->name, en.n_namesz, foffset); | 1236 | dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) && |
1248 | if (!alignfile(file, foffset)) | 1237 | dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4); |
1249 | return 0; | ||
1250 | DUMP_WRITE(men->data, men->datasz, foffset); | ||
1251 | if (!alignfile(file, foffset)) | ||
1252 | return 0; | ||
1253 | |||
1254 | return 1; | ||
1255 | } | 1238 | } |
1256 | #undef DUMP_WRITE | ||
1257 | 1239 | ||
1258 | static void fill_elf_header(struct elfhdr *elf, int segs, | 1240 | static void fill_elf_header(struct elfhdr *elf, int segs, |
1259 | u16 machine, u32 flags) | 1241 | u16 machine, u32 flags) |
@@ -1392,7 +1374,7 @@ static void fill_auxv_note(struct memelfnote *note, struct mm_struct *mm) | |||
1392 | } | 1374 | } |
1393 | 1375 | ||
1394 | static void fill_siginfo_note(struct memelfnote *note, user_siginfo_t *csigdata, | 1376 | static void fill_siginfo_note(struct memelfnote *note, user_siginfo_t *csigdata, |
1395 | siginfo_t *siginfo) | 1377 | const siginfo_t *siginfo) |
1396 | { | 1378 | { |
1397 | mm_segment_t old_fs = get_fs(); | 1379 | mm_segment_t old_fs = get_fs(); |
1398 | set_fs(KERNEL_DS); | 1380 | set_fs(KERNEL_DS); |
@@ -1599,7 +1581,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, | |||
1599 | 1581 | ||
1600 | static int fill_note_info(struct elfhdr *elf, int phdrs, | 1582 | static int fill_note_info(struct elfhdr *elf, int phdrs, |
1601 | struct elf_note_info *info, | 1583 | struct elf_note_info *info, |
1602 | siginfo_t *siginfo, struct pt_regs *regs) | 1584 | const siginfo_t *siginfo, struct pt_regs *regs) |
1603 | { | 1585 | { |
1604 | struct task_struct *dump_task = current; | 1586 | struct task_struct *dump_task = current; |
1605 | const struct user_regset_view *view = task_user_regset_view(dump_task); | 1587 | const struct user_regset_view *view = task_user_regset_view(dump_task); |
@@ -1702,7 +1684,7 @@ static size_t get_note_info_size(struct elf_note_info *info) | |||
1702 | * process-wide notes are interleaved after the first thread-specific note. | 1684 | * process-wide notes are interleaved after the first thread-specific note. |
1703 | */ | 1685 | */ |
1704 | static int write_note_info(struct elf_note_info *info, | 1686 | static int write_note_info(struct elf_note_info *info, |
1705 | struct file *file, loff_t *foffset) | 1687 | struct coredump_params *cprm) |
1706 | { | 1688 | { |
1707 | bool first = 1; | 1689 | bool first = 1; |
1708 | struct elf_thread_core_info *t = info->thread; | 1690 | struct elf_thread_core_info *t = info->thread; |
@@ -1710,22 +1692,22 @@ static int write_note_info(struct elf_note_info *info, | |||
1710 | do { | 1692 | do { |
1711 | int i; | 1693 | int i; |
1712 | 1694 | ||
1713 | if (!writenote(&t->notes[0], file, foffset)) | 1695 | if (!writenote(&t->notes[0], cprm)) |
1714 | return 0; | 1696 | return 0; |
1715 | 1697 | ||
1716 | if (first && !writenote(&info->psinfo, file, foffset)) | 1698 | if (first && !writenote(&info->psinfo, cprm)) |
1717 | return 0; | 1699 | return 0; |
1718 | if (first && !writenote(&info->signote, file, foffset)) | 1700 | if (first && !writenote(&info->signote, cprm)) |
1719 | return 0; | 1701 | return 0; |
1720 | if (first && !writenote(&info->auxv, file, foffset)) | 1702 | if (first && !writenote(&info->auxv, cprm)) |
1721 | return 0; | 1703 | return 0; |
1722 | if (first && info->files.data && | 1704 | if (first && info->files.data && |
1723 | !writenote(&info->files, file, foffset)) | 1705 | !writenote(&info->files, cprm)) |
1724 | return 0; | 1706 | return 0; |
1725 | 1707 | ||
1726 | for (i = 1; i < info->thread_notes; ++i) | 1708 | for (i = 1; i < info->thread_notes; ++i) |
1727 | if (t->notes[i].data && | 1709 | if (t->notes[i].data && |
1728 | !writenote(&t->notes[i], file, foffset)) | 1710 | !writenote(&t->notes[i], cprm)) |
1729 | return 0; | 1711 | return 0; |
1730 | 1712 | ||
1731 | first = 0; | 1713 | first = 0; |
@@ -1848,34 +1830,31 @@ static int elf_note_info_init(struct elf_note_info *info) | |||
1848 | 1830 | ||
1849 | static int fill_note_info(struct elfhdr *elf, int phdrs, | 1831 | static int fill_note_info(struct elfhdr *elf, int phdrs, |
1850 | struct elf_note_info *info, | 1832 | struct elf_note_info *info, |
1851 | siginfo_t *siginfo, struct pt_regs *regs) | 1833 | const siginfo_t *siginfo, struct pt_regs *regs) |
1852 | { | 1834 | { |
1853 | struct list_head *t; | 1835 | struct list_head *t; |
1836 | struct core_thread *ct; | ||
1837 | struct elf_thread_status *ets; | ||
1854 | 1838 | ||
1855 | if (!elf_note_info_init(info)) | 1839 | if (!elf_note_info_init(info)) |
1856 | return 0; | 1840 | return 0; |
1857 | 1841 | ||
1858 | if (siginfo->si_signo) { | 1842 | for (ct = current->mm->core_state->dumper.next; |
1859 | struct core_thread *ct; | 1843 | ct; ct = ct->next) { |
1860 | struct elf_thread_status *ets; | 1844 | ets = kzalloc(sizeof(*ets), GFP_KERNEL); |
1861 | 1845 | if (!ets) | |
1862 | for (ct = current->mm->core_state->dumper.next; | 1846 | return 0; |
1863 | ct; ct = ct->next) { | ||
1864 | ets = kzalloc(sizeof(*ets), GFP_KERNEL); | ||
1865 | if (!ets) | ||
1866 | return 0; | ||
1867 | 1847 | ||
1868 | ets->thread = ct->task; | 1848 | ets->thread = ct->task; |
1869 | list_add(&ets->list, &info->thread_list); | 1849 | list_add(&ets->list, &info->thread_list); |
1870 | } | 1850 | } |
1871 | 1851 | ||
1872 | list_for_each(t, &info->thread_list) { | 1852 | list_for_each(t, &info->thread_list) { |
1873 | int sz; | 1853 | int sz; |
1874 | 1854 | ||
1875 | ets = list_entry(t, struct elf_thread_status, list); | 1855 | ets = list_entry(t, struct elf_thread_status, list); |
1876 | sz = elf_dump_thread_status(siginfo->si_signo, ets); | 1856 | sz = elf_dump_thread_status(siginfo->si_signo, ets); |
1877 | info->thread_status_size += sz; | 1857 | info->thread_status_size += sz; |
1878 | } | ||
1879 | } | 1858 | } |
1880 | /* now collect the dump for the current */ | 1859 | /* now collect the dump for the current */ |
1881 | memset(info->prstatus, 0, sizeof(*info->prstatus)); | 1860 | memset(info->prstatus, 0, sizeof(*info->prstatus)); |
@@ -1935,13 +1914,13 @@ static size_t get_note_info_size(struct elf_note_info *info) | |||
1935 | } | 1914 | } |
1936 | 1915 | ||
1937 | static int write_note_info(struct elf_note_info *info, | 1916 | static int write_note_info(struct elf_note_info *info, |
1938 | struct file *file, loff_t *foffset) | 1917 | struct coredump_params *cprm) |
1939 | { | 1918 | { |
1940 | int i; | 1919 | int i; |
1941 | struct list_head *t; | 1920 | struct list_head *t; |
1942 | 1921 | ||
1943 | for (i = 0; i < info->numnote; i++) | 1922 | for (i = 0; i < info->numnote; i++) |
1944 | if (!writenote(info->notes + i, file, foffset)) | 1923 | if (!writenote(info->notes + i, cprm)) |
1945 | return 0; | 1924 | return 0; |
1946 | 1925 | ||
1947 | /* write out the thread status notes section */ | 1926 | /* write out the thread status notes section */ |
@@ -1950,7 +1929,7 @@ static int write_note_info(struct elf_note_info *info, | |||
1950 | list_entry(t, struct elf_thread_status, list); | 1929 | list_entry(t, struct elf_thread_status, list); |
1951 | 1930 | ||
1952 | for (i = 0; i < tmp->num_notes; i++) | 1931 | for (i = 0; i < tmp->num_notes; i++) |
1953 | if (!writenote(&tmp->notes[i], file, foffset)) | 1932 | if (!writenote(&tmp->notes[i], cprm)) |
1954 | return 0; | 1933 | return 0; |
1955 | } | 1934 | } |
1956 | 1935 | ||
@@ -2046,10 +2025,9 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2046 | int has_dumped = 0; | 2025 | int has_dumped = 0; |
2047 | mm_segment_t fs; | 2026 | mm_segment_t fs; |
2048 | int segs; | 2027 | int segs; |
2049 | size_t size = 0; | ||
2050 | struct vm_area_struct *vma, *gate_vma; | 2028 | struct vm_area_struct *vma, *gate_vma; |
2051 | struct elfhdr *elf = NULL; | 2029 | struct elfhdr *elf = NULL; |
2052 | loff_t offset = 0, dataoff, foffset; | 2030 | loff_t offset = 0, dataoff; |
2053 | struct elf_note_info info = { }; | 2031 | struct elf_note_info info = { }; |
2054 | struct elf_phdr *phdr4note = NULL; | 2032 | struct elf_phdr *phdr4note = NULL; |
2055 | struct elf_shdr *shdr4extnum = NULL; | 2033 | struct elf_shdr *shdr4extnum = NULL; |
@@ -2105,7 +2083,6 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2105 | 2083 | ||
2106 | offset += sizeof(*elf); /* Elf header */ | 2084 | offset += sizeof(*elf); /* Elf header */ |
2107 | offset += segs * sizeof(struct elf_phdr); /* Program headers */ | 2085 | offset += segs * sizeof(struct elf_phdr); /* Program headers */ |
2108 | foffset = offset; | ||
2109 | 2086 | ||
2110 | /* Write notes phdr entry */ | 2087 | /* Write notes phdr entry */ |
2111 | { | 2088 | { |
@@ -2136,13 +2113,10 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2136 | 2113 | ||
2137 | offset = dataoff; | 2114 | offset = dataoff; |
2138 | 2115 | ||
2139 | size += sizeof(*elf); | 2116 | if (!dump_emit(cprm, elf, sizeof(*elf))) |
2140 | if (size > cprm->limit || !dump_write(cprm->file, elf, sizeof(*elf))) | ||
2141 | goto end_coredump; | 2117 | goto end_coredump; |
2142 | 2118 | ||
2143 | size += sizeof(*phdr4note); | 2119 | if (!dump_emit(cprm, phdr4note, sizeof(*phdr4note))) |
2144 | if (size > cprm->limit | ||
2145 | || !dump_write(cprm->file, phdr4note, sizeof(*phdr4note))) | ||
2146 | goto end_coredump; | 2120 | goto end_coredump; |
2147 | 2121 | ||
2148 | /* Write program headers for segments dump */ | 2122 | /* Write program headers for segments dump */ |
@@ -2164,24 +2138,22 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2164 | phdr.p_flags |= PF_X; | 2138 | phdr.p_flags |= PF_X; |
2165 | phdr.p_align = ELF_EXEC_PAGESIZE; | 2139 | phdr.p_align = ELF_EXEC_PAGESIZE; |
2166 | 2140 | ||
2167 | size += sizeof(phdr); | 2141 | if (!dump_emit(cprm, &phdr, sizeof(phdr))) |
2168 | if (size > cprm->limit | ||
2169 | || !dump_write(cprm->file, &phdr, sizeof(phdr))) | ||
2170 | goto end_coredump; | 2142 | goto end_coredump; |
2171 | } | 2143 | } |
2172 | 2144 | ||
2173 | if (!elf_core_write_extra_phdrs(cprm->file, offset, &size, cprm->limit)) | 2145 | if (!elf_core_write_extra_phdrs(cprm, offset)) |
2174 | goto end_coredump; | 2146 | goto end_coredump; |
2175 | 2147 | ||
2176 | /* write out the notes section */ | 2148 | /* write out the notes section */ |
2177 | if (!write_note_info(&info, cprm->file, &foffset)) | 2149 | if (!write_note_info(&info, cprm)) |
2178 | goto end_coredump; | 2150 | goto end_coredump; |
2179 | 2151 | ||
2180 | if (elf_coredump_extra_notes_write(cprm->file, &foffset)) | 2152 | if (elf_coredump_extra_notes_write(cprm)) |
2181 | goto end_coredump; | 2153 | goto end_coredump; |
2182 | 2154 | ||
2183 | /* Align to page */ | 2155 | /* Align to page */ |
2184 | if (!dump_seek(cprm->file, dataoff - foffset)) | 2156 | if (!dump_skip(cprm, dataoff - cprm->written)) |
2185 | goto end_coredump; | 2157 | goto end_coredump; |
2186 | 2158 | ||
2187 | for (vma = first_vma(current, gate_vma); vma != NULL; | 2159 | for (vma = first_vma(current, gate_vma); vma != NULL; |
@@ -2198,26 +2170,21 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2198 | page = get_dump_page(addr); | 2170 | page = get_dump_page(addr); |
2199 | if (page) { | 2171 | if (page) { |
2200 | void *kaddr = kmap(page); | 2172 | void *kaddr = kmap(page); |
2201 | stop = ((size += PAGE_SIZE) > cprm->limit) || | 2173 | stop = !dump_emit(cprm, kaddr, PAGE_SIZE); |
2202 | !dump_write(cprm->file, kaddr, | ||
2203 | PAGE_SIZE); | ||
2204 | kunmap(page); | 2174 | kunmap(page); |
2205 | page_cache_release(page); | 2175 | page_cache_release(page); |
2206 | } else | 2176 | } else |
2207 | stop = !dump_seek(cprm->file, PAGE_SIZE); | 2177 | stop = !dump_skip(cprm, PAGE_SIZE); |
2208 | if (stop) | 2178 | if (stop) |
2209 | goto end_coredump; | 2179 | goto end_coredump; |
2210 | } | 2180 | } |
2211 | } | 2181 | } |
2212 | 2182 | ||
2213 | if (!elf_core_write_extra_data(cprm->file, &size, cprm->limit)) | 2183 | if (!elf_core_write_extra_data(cprm)) |
2214 | goto end_coredump; | 2184 | goto end_coredump; |
2215 | 2185 | ||
2216 | if (e_phnum == PN_XNUM) { | 2186 | if (e_phnum == PN_XNUM) { |
2217 | size += sizeof(*shdr4extnum); | 2187 | if (!dump_emit(cprm, shdr4extnum, sizeof(*shdr4extnum))) |
2218 | if (size > cprm->limit | ||
2219 | || !dump_write(cprm->file, shdr4extnum, | ||
2220 | sizeof(*shdr4extnum))) | ||
2221 | goto end_coredump; | 2188 | goto end_coredump; |
2222 | } | 2189 | } |
2223 | 2190 | ||
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index c166f325a183..fe2a643ee005 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c | |||
@@ -111,7 +111,7 @@ static int is_elf_fdpic(struct elfhdr *hdr, struct file *file) | |||
111 | return 0; | 111 | return 0; |
112 | if (!elf_check_arch(hdr) || !elf_check_fdpic(hdr)) | 112 | if (!elf_check_arch(hdr) || !elf_check_fdpic(hdr)) |
113 | return 0; | 113 | return 0; |
114 | if (!file->f_op || !file->f_op->mmap) | 114 | if (!file->f_op->mmap) |
115 | return 0; | 115 | return 0; |
116 | return 1; | 116 | return 1; |
117 | } | 117 | } |
@@ -1267,35 +1267,17 @@ static int notesize(struct memelfnote *en) | |||
1267 | 1267 | ||
1268 | /* #define DEBUG */ | 1268 | /* #define DEBUG */ |
1269 | 1269 | ||
1270 | #define DUMP_WRITE(addr, nr, foffset) \ | 1270 | static int writenote(struct memelfnote *men, struct coredump_params *cprm) |
1271 | do { if (!dump_write(file, (addr), (nr))) return 0; *foffset += (nr); } while(0) | ||
1272 | |||
1273 | static int alignfile(struct file *file, loff_t *foffset) | ||
1274 | { | ||
1275 | static const char buf[4] = { 0, }; | ||
1276 | DUMP_WRITE(buf, roundup(*foffset, 4) - *foffset, foffset); | ||
1277 | return 1; | ||
1278 | } | ||
1279 | |||
1280 | static int writenote(struct memelfnote *men, struct file *file, | ||
1281 | loff_t *foffset) | ||
1282 | { | 1271 | { |
1283 | struct elf_note en; | 1272 | struct elf_note en; |
1284 | en.n_namesz = strlen(men->name) + 1; | 1273 | en.n_namesz = strlen(men->name) + 1; |
1285 | en.n_descsz = men->datasz; | 1274 | en.n_descsz = men->datasz; |
1286 | en.n_type = men->type; | 1275 | en.n_type = men->type; |
1287 | 1276 | ||
1288 | DUMP_WRITE(&en, sizeof(en), foffset); | 1277 | return dump_emit(cprm, &en, sizeof(en)) && |
1289 | DUMP_WRITE(men->name, en.n_namesz, foffset); | 1278 | dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) && |
1290 | if (!alignfile(file, foffset)) | 1279 | dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4); |
1291 | return 0; | ||
1292 | DUMP_WRITE(men->data, men->datasz, foffset); | ||
1293 | if (!alignfile(file, foffset)) | ||
1294 | return 0; | ||
1295 | |||
1296 | return 1; | ||
1297 | } | 1280 | } |
1298 | #undef DUMP_WRITE | ||
1299 | 1281 | ||
1300 | static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs) | 1282 | static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs) |
1301 | { | 1283 | { |
@@ -1500,66 +1482,40 @@ static void fill_extnum_info(struct elfhdr *elf, struct elf_shdr *shdr4extnum, | |||
1500 | /* | 1482 | /* |
1501 | * dump the segments for an MMU process | 1483 | * dump the segments for an MMU process |
1502 | */ | 1484 | */ |
1503 | #ifdef CONFIG_MMU | 1485 | static bool elf_fdpic_dump_segments(struct coredump_params *cprm) |
1504 | static int elf_fdpic_dump_segments(struct file *file, size_t *size, | ||
1505 | unsigned long *limit, unsigned long mm_flags) | ||
1506 | { | 1486 | { |
1507 | struct vm_area_struct *vma; | 1487 | struct vm_area_struct *vma; |
1508 | int err = 0; | ||
1509 | 1488 | ||
1510 | for (vma = current->mm->mmap; vma; vma = vma->vm_next) { | 1489 | for (vma = current->mm->mmap; vma; vma = vma->vm_next) { |
1511 | unsigned long addr; | 1490 | unsigned long addr; |
1512 | 1491 | ||
1513 | if (!maydump(vma, mm_flags)) | 1492 | if (!maydump(vma, cprm->mm_flags)) |
1514 | continue; | 1493 | continue; |
1515 | 1494 | ||
1495 | #ifdef CONFIG_MMU | ||
1516 | for (addr = vma->vm_start; addr < vma->vm_end; | 1496 | for (addr = vma->vm_start; addr < vma->vm_end; |
1517 | addr += PAGE_SIZE) { | 1497 | addr += PAGE_SIZE) { |
1498 | bool res; | ||
1518 | struct page *page = get_dump_page(addr); | 1499 | struct page *page = get_dump_page(addr); |
1519 | if (page) { | 1500 | if (page) { |
1520 | void *kaddr = kmap(page); | 1501 | void *kaddr = kmap(page); |
1521 | *size += PAGE_SIZE; | 1502 | res = dump_emit(cprm, kaddr, PAGE_SIZE); |
1522 | if (*size > *limit) | ||
1523 | err = -EFBIG; | ||
1524 | else if (!dump_write(file, kaddr, PAGE_SIZE)) | ||
1525 | err = -EIO; | ||
1526 | kunmap(page); | 1503 | kunmap(page); |
1527 | page_cache_release(page); | 1504 | page_cache_release(page); |
1528 | } else if (!dump_seek(file, PAGE_SIZE)) | 1505 | } else { |
1529 | err = -EFBIG; | 1506 | res = dump_skip(cprm, PAGE_SIZE); |
1530 | if (err) | 1507 | } |
1531 | goto out; | 1508 | if (!res) |
1509 | return false; | ||
1532 | } | 1510 | } |
1533 | } | 1511 | #else |
1534 | out: | 1512 | if (!dump_emit(cprm, (void *) vma->vm_start, |
1535 | return err; | ||
1536 | } | ||
1537 | #endif | ||
1538 | |||
1539 | /* | ||
1540 | * dump the segments for a NOMMU process | ||
1541 | */ | ||
1542 | #ifndef CONFIG_MMU | ||
1543 | static int elf_fdpic_dump_segments(struct file *file, size_t *size, | ||
1544 | unsigned long *limit, unsigned long mm_flags) | ||
1545 | { | ||
1546 | struct vm_area_struct *vma; | ||
1547 | |||
1548 | for (vma = current->mm->mmap; vma; vma = vma->vm_next) { | ||
1549 | if (!maydump(vma, mm_flags)) | ||
1550 | continue; | ||
1551 | |||
1552 | if ((*size += PAGE_SIZE) > *limit) | ||
1553 | return -EFBIG; | ||
1554 | |||
1555 | if (!dump_write(file, (void *) vma->vm_start, | ||
1556 | vma->vm_end - vma->vm_start)) | 1513 | vma->vm_end - vma->vm_start)) |
1557 | return -EIO; | 1514 | return false; |
1515 | #endif | ||
1558 | } | 1516 | } |
1559 | 1517 | return true; | |
1560 | return 0; | ||
1561 | } | 1518 | } |
1562 | #endif | ||
1563 | 1519 | ||
1564 | static size_t elf_core_vma_data_size(unsigned long mm_flags) | 1520 | static size_t elf_core_vma_data_size(unsigned long mm_flags) |
1565 | { | 1521 | { |
@@ -1585,11 +1541,10 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1585 | int has_dumped = 0; | 1541 | int has_dumped = 0; |
1586 | mm_segment_t fs; | 1542 | mm_segment_t fs; |
1587 | int segs; | 1543 | int segs; |
1588 | size_t size = 0; | ||
1589 | int i; | 1544 | int i; |
1590 | struct vm_area_struct *vma; | 1545 | struct vm_area_struct *vma; |
1591 | struct elfhdr *elf = NULL; | 1546 | struct elfhdr *elf = NULL; |
1592 | loff_t offset = 0, dataoff, foffset; | 1547 | loff_t offset = 0, dataoff; |
1593 | int numnote; | 1548 | int numnote; |
1594 | struct memelfnote *notes = NULL; | 1549 | struct memelfnote *notes = NULL; |
1595 | struct elf_prstatus *prstatus = NULL; /* NT_PRSTATUS */ | 1550 | struct elf_prstatus *prstatus = NULL; /* NT_PRSTATUS */ |
@@ -1606,6 +1561,8 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1606 | struct elf_shdr *shdr4extnum = NULL; | 1561 | struct elf_shdr *shdr4extnum = NULL; |
1607 | Elf_Half e_phnum; | 1562 | Elf_Half e_phnum; |
1608 | elf_addr_t e_shoff; | 1563 | elf_addr_t e_shoff; |
1564 | struct core_thread *ct; | ||
1565 | struct elf_thread_status *tmp; | ||
1609 | 1566 | ||
1610 | /* | 1567 | /* |
1611 | * We no longer stop all VM operations. | 1568 | * We no longer stop all VM operations. |
@@ -1641,28 +1598,23 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1641 | goto cleanup; | 1598 | goto cleanup; |
1642 | #endif | 1599 | #endif |
1643 | 1600 | ||
1644 | if (cprm->siginfo->si_signo) { | 1601 | for (ct = current->mm->core_state->dumper.next; |
1645 | struct core_thread *ct; | 1602 | ct; ct = ct->next) { |
1646 | struct elf_thread_status *tmp; | 1603 | tmp = kzalloc(sizeof(*tmp), GFP_KERNEL); |
1647 | 1604 | if (!tmp) | |
1648 | for (ct = current->mm->core_state->dumper.next; | 1605 | goto cleanup; |
1649 | ct; ct = ct->next) { | ||
1650 | tmp = kzalloc(sizeof(*tmp), GFP_KERNEL); | ||
1651 | if (!tmp) | ||
1652 | goto cleanup; | ||
1653 | 1606 | ||
1654 | tmp->thread = ct->task; | 1607 | tmp->thread = ct->task; |
1655 | list_add(&tmp->list, &thread_list); | 1608 | list_add(&tmp->list, &thread_list); |
1656 | } | 1609 | } |
1657 | 1610 | ||
1658 | list_for_each(t, &thread_list) { | 1611 | list_for_each(t, &thread_list) { |
1659 | struct elf_thread_status *tmp; | 1612 | struct elf_thread_status *tmp; |
1660 | int sz; | 1613 | int sz; |
1661 | 1614 | ||
1662 | tmp = list_entry(t, struct elf_thread_status, list); | 1615 | tmp = list_entry(t, struct elf_thread_status, list); |
1663 | sz = elf_dump_thread_status(cprm->siginfo->si_signo, tmp); | 1616 | sz = elf_dump_thread_status(cprm->siginfo->si_signo, tmp); |
1664 | thread_status_size += sz; | 1617 | thread_status_size += sz; |
1665 | } | ||
1666 | } | 1618 | } |
1667 | 1619 | ||
1668 | /* now collect the dump for the current */ | 1620 | /* now collect the dump for the current */ |
@@ -1720,7 +1672,6 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1720 | 1672 | ||
1721 | offset += sizeof(*elf); /* Elf header */ | 1673 | offset += sizeof(*elf); /* Elf header */ |
1722 | offset += segs * sizeof(struct elf_phdr); /* Program headers */ | 1674 | offset += segs * sizeof(struct elf_phdr); /* Program headers */ |
1723 | foffset = offset; | ||
1724 | 1675 | ||
1725 | /* Write notes phdr entry */ | 1676 | /* Write notes phdr entry */ |
1726 | { | 1677 | { |
@@ -1755,13 +1706,10 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1755 | 1706 | ||
1756 | offset = dataoff; | 1707 | offset = dataoff; |
1757 | 1708 | ||
1758 | size += sizeof(*elf); | 1709 | if (!dump_emit(cprm, elf, sizeof(*elf))) |
1759 | if (size > cprm->limit || !dump_write(cprm->file, elf, sizeof(*elf))) | ||
1760 | goto end_coredump; | 1710 | goto end_coredump; |
1761 | 1711 | ||
1762 | size += sizeof(*phdr4note); | 1712 | if (!dump_emit(cprm, phdr4note, sizeof(*phdr4note))) |
1763 | if (size > cprm->limit | ||
1764 | || !dump_write(cprm->file, phdr4note, sizeof(*phdr4note))) | ||
1765 | goto end_coredump; | 1713 | goto end_coredump; |
1766 | 1714 | ||
1767 | /* write program headers for segments dump */ | 1715 | /* write program headers for segments dump */ |
@@ -1785,18 +1733,16 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1785 | phdr.p_flags |= PF_X; | 1733 | phdr.p_flags |= PF_X; |
1786 | phdr.p_align = ELF_EXEC_PAGESIZE; | 1734 | phdr.p_align = ELF_EXEC_PAGESIZE; |
1787 | 1735 | ||
1788 | size += sizeof(phdr); | 1736 | if (!dump_emit(cprm, &phdr, sizeof(phdr))) |
1789 | if (size > cprm->limit | ||
1790 | || !dump_write(cprm->file, &phdr, sizeof(phdr))) | ||
1791 | goto end_coredump; | 1737 | goto end_coredump; |
1792 | } | 1738 | } |
1793 | 1739 | ||
1794 | if (!elf_core_write_extra_phdrs(cprm->file, offset, &size, cprm->limit)) | 1740 | if (!elf_core_write_extra_phdrs(cprm, offset)) |
1795 | goto end_coredump; | 1741 | goto end_coredump; |
1796 | 1742 | ||
1797 | /* write out the notes section */ | 1743 | /* write out the notes section */ |
1798 | for (i = 0; i < numnote; i++) | 1744 | for (i = 0; i < numnote; i++) |
1799 | if (!writenote(notes + i, cprm->file, &foffset)) | 1745 | if (!writenote(notes + i, cprm)) |
1800 | goto end_coredump; | 1746 | goto end_coredump; |
1801 | 1747 | ||
1802 | /* write out the thread status notes section */ | 1748 | /* write out the thread status notes section */ |
@@ -1805,25 +1751,21 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1805 | list_entry(t, struct elf_thread_status, list); | 1751 | list_entry(t, struct elf_thread_status, list); |
1806 | 1752 | ||
1807 | for (i = 0; i < tmp->num_notes; i++) | 1753 | for (i = 0; i < tmp->num_notes; i++) |
1808 | if (!writenote(&tmp->notes[i], cprm->file, &foffset)) | 1754 | if (!writenote(&tmp->notes[i], cprm)) |
1809 | goto end_coredump; | 1755 | goto end_coredump; |
1810 | } | 1756 | } |
1811 | 1757 | ||
1812 | if (!dump_seek(cprm->file, dataoff - foffset)) | 1758 | if (!dump_skip(cprm, dataoff - cprm->written)) |
1813 | goto end_coredump; | 1759 | goto end_coredump; |
1814 | 1760 | ||
1815 | if (elf_fdpic_dump_segments(cprm->file, &size, &cprm->limit, | 1761 | if (!elf_fdpic_dump_segments(cprm)) |
1816 | cprm->mm_flags) < 0) | ||
1817 | goto end_coredump; | 1762 | goto end_coredump; |
1818 | 1763 | ||
1819 | if (!elf_core_write_extra_data(cprm->file, &size, cprm->limit)) | 1764 | if (!elf_core_write_extra_data(cprm)) |
1820 | goto end_coredump; | 1765 | goto end_coredump; |
1821 | 1766 | ||
1822 | if (e_phnum == PN_XNUM) { | 1767 | if (e_phnum == PN_XNUM) { |
1823 | size += sizeof(*shdr4extnum); | 1768 | if (!dump_emit(cprm, shdr4extnum, sizeof(*shdr4extnum))) |
1824 | if (size > cprm->limit | ||
1825 | || !dump_write(cprm->file, shdr4extnum, | ||
1826 | sizeof(*shdr4extnum))) | ||
1827 | goto end_coredump; | 1769 | goto end_coredump; |
1828 | } | 1770 | } |
1829 | 1771 | ||
diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c index 037a3e2b045b..f37b08cea1f7 100644 --- a/fs/binfmt_em86.c +++ b/fs/binfmt_em86.c | |||
@@ -38,7 +38,7 @@ static int load_em86(struct linux_binprm *bprm) | |||
38 | /* First of all, some simple consistency checks */ | 38 | /* First of all, some simple consistency checks */ |
39 | if ((elf_ex.e_type != ET_EXEC && elf_ex.e_type != ET_DYN) || | 39 | if ((elf_ex.e_type != ET_EXEC && elf_ex.e_type != ET_DYN) || |
40 | (!((elf_ex.e_machine == EM_386) || (elf_ex.e_machine == EM_486))) || | 40 | (!((elf_ex.e_machine == EM_386) || (elf_ex.e_machine == EM_486))) || |
41 | (!bprm->file->f_op || !bprm->file->f_op->mmap)) { | 41 | !bprm->file->f_op->mmap) { |
42 | return -ENOEXEC; | 42 | return -ENOEXEC; |
43 | } | 43 | } |
44 | 44 | ||
diff --git a/fs/cachefiles/interface.c b/fs/cachefiles/interface.c index 00baf1419989..57e17fe6121a 100644 --- a/fs/cachefiles/interface.c +++ b/fs/cachefiles/interface.c | |||
@@ -449,14 +449,14 @@ static int cachefiles_attr_changed(struct fscache_object *_object) | |||
449 | _debug("discard tail %llx", oi_size); | 449 | _debug("discard tail %llx", oi_size); |
450 | newattrs.ia_valid = ATTR_SIZE; | 450 | newattrs.ia_valid = ATTR_SIZE; |
451 | newattrs.ia_size = oi_size & PAGE_MASK; | 451 | newattrs.ia_size = oi_size & PAGE_MASK; |
452 | ret = notify_change(object->backer, &newattrs); | 452 | ret = notify_change(object->backer, &newattrs, NULL); |
453 | if (ret < 0) | 453 | if (ret < 0) |
454 | goto truncate_failed; | 454 | goto truncate_failed; |
455 | } | 455 | } |
456 | 456 | ||
457 | newattrs.ia_valid = ATTR_SIZE; | 457 | newattrs.ia_valid = ATTR_SIZE; |
458 | newattrs.ia_size = ni_size; | 458 | newattrs.ia_size = ni_size; |
459 | ret = notify_change(object->backer, &newattrs); | 459 | ret = notify_change(object->backer, &newattrs, NULL); |
460 | 460 | ||
461 | truncate_failed: | 461 | truncate_failed: |
462 | mutex_unlock(&object->backer->d_inode->i_mutex); | 462 | mutex_unlock(&object->backer->d_inode->i_mutex); |
diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index f4a08d7fa2f7..ca65f39dc8dc 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c | |||
@@ -294,7 +294,7 @@ static int cachefiles_bury_object(struct cachefiles_cache *cache, | |||
294 | if (ret < 0) { | 294 | if (ret < 0) { |
295 | cachefiles_io_error(cache, "Unlink security error"); | 295 | cachefiles_io_error(cache, "Unlink security error"); |
296 | } else { | 296 | } else { |
297 | ret = vfs_unlink(dir->d_inode, rep); | 297 | ret = vfs_unlink(dir->d_inode, rep, NULL); |
298 | 298 | ||
299 | if (preemptive) | 299 | if (preemptive) |
300 | cachefiles_mark_object_buried(cache, rep); | 300 | cachefiles_mark_object_buried(cache, rep); |
@@ -396,7 +396,7 @@ try_again: | |||
396 | cachefiles_io_error(cache, "Rename security error %d", ret); | 396 | cachefiles_io_error(cache, "Rename security error %d", ret); |
397 | } else { | 397 | } else { |
398 | ret = vfs_rename(dir->d_inode, rep, | 398 | ret = vfs_rename(dir->d_inode, rep, |
399 | cache->graveyard->d_inode, grave); | 399 | cache->graveyard->d_inode, grave, NULL); |
400 | if (ret != 0 && ret != -ENOMEM) | 400 | if (ret != 0 && ret != -ENOMEM) |
401 | cachefiles_io_error(cache, | 401 | cachefiles_io_error(cache, |
402 | "Rename failed with error %d", ret); | 402 | "Rename failed with error %d", ret); |
diff --git a/fs/char_dev.c b/fs/char_dev.c index afc2bb691780..94b5f60076da 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c | |||
@@ -368,6 +368,7 @@ void cdev_put(struct cdev *p) | |||
368 | */ | 368 | */ |
369 | static int chrdev_open(struct inode *inode, struct file *filp) | 369 | static int chrdev_open(struct inode *inode, struct file *filp) |
370 | { | 370 | { |
371 | const struct file_operations *fops; | ||
371 | struct cdev *p; | 372 | struct cdev *p; |
372 | struct cdev *new = NULL; | 373 | struct cdev *new = NULL; |
373 | int ret = 0; | 374 | int ret = 0; |
@@ -400,10 +401,11 @@ static int chrdev_open(struct inode *inode, struct file *filp) | |||
400 | return ret; | 401 | return ret; |
401 | 402 | ||
402 | ret = -ENXIO; | 403 | ret = -ENXIO; |
403 | filp->f_op = fops_get(p->ops); | 404 | fops = fops_get(p->ops); |
404 | if (!filp->f_op) | 405 | if (!fops) |
405 | goto out_cdev_put; | 406 | goto out_cdev_put; |
406 | 407 | ||
408 | replace_fops(filp, fops); | ||
407 | if (filp->f_op->open) { | 409 | if (filp->f_op->open) { |
408 | ret = filp->f_op->open(inode, filp); | 410 | ret = filp->f_op->open(inode, filp); |
409 | if (ret) | 411 | if (ret) |
diff --git a/fs/cifs/cifs_fs_sb.h b/fs/cifs/cifs_fs_sb.h index 37e4a72a7d1c..9409fa10bd5c 100644 --- a/fs/cifs/cifs_fs_sb.h +++ b/fs/cifs/cifs_fs_sb.h | |||
@@ -65,5 +65,6 @@ struct cifs_sb_info { | |||
65 | char *mountdata; /* options received at mount time or via DFS refs */ | 65 | char *mountdata; /* options received at mount time or via DFS refs */ |
66 | struct backing_dev_info bdi; | 66 | struct backing_dev_info bdi; |
67 | struct delayed_work prune_tlinks; | 67 | struct delayed_work prune_tlinks; |
68 | struct rcu_head rcu; | ||
68 | }; | 69 | }; |
69 | #endif /* _CIFS_FS_SB_H */ | 70 | #endif /* _CIFS_FS_SB_H */ |
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 77fc5e181077..849f6132b327 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c | |||
@@ -862,7 +862,7 @@ const struct inode_operations cifs_file_inode_ops = { | |||
862 | const struct inode_operations cifs_symlink_inode_ops = { | 862 | const struct inode_operations cifs_symlink_inode_ops = { |
863 | .readlink = generic_readlink, | 863 | .readlink = generic_readlink, |
864 | .follow_link = cifs_follow_link, | 864 | .follow_link = cifs_follow_link, |
865 | .put_link = cifs_put_link, | 865 | .put_link = kfree_put_link, |
866 | .permission = cifs_permission, | 866 | .permission = cifs_permission, |
867 | /* BB add the following two eventually */ | 867 | /* BB add the following two eventually */ |
868 | /* revalidate: cifs_revalidate, | 868 | /* revalidate: cifs_revalidate, |
diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 6d0b07217ac9..26a754f49ba1 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h | |||
@@ -115,8 +115,6 @@ extern struct vfsmount *cifs_dfs_d_automount(struct path *path); | |||
115 | 115 | ||
116 | /* Functions related to symlinks */ | 116 | /* Functions related to symlinks */ |
117 | extern void *cifs_follow_link(struct dentry *direntry, struct nameidata *nd); | 117 | extern void *cifs_follow_link(struct dentry *direntry, struct nameidata *nd); |
118 | extern void cifs_put_link(struct dentry *direntry, | ||
119 | struct nameidata *nd, void *); | ||
120 | extern int cifs_readlink(struct dentry *direntry, char __user *buffer, | 118 | extern int cifs_readlink(struct dentry *direntry, char __user *buffer, |
121 | int buflen); | 119 | int buflen); |
122 | extern int cifs_symlink(struct inode *inode, struct dentry *direntry, | 120 | extern int cifs_symlink(struct inode *inode, struct dentry *direntry, |
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 62a55147400a..8813ff776ba3 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
@@ -3770,6 +3770,13 @@ CIFSTCon(const unsigned int xid, struct cifs_ses *ses, | |||
3770 | return rc; | 3770 | return rc; |
3771 | } | 3771 | } |
3772 | 3772 | ||
3773 | static void delayed_free(struct rcu_head *p) | ||
3774 | { | ||
3775 | struct cifs_sb_info *sbi = container_of(p, struct cifs_sb_info, rcu); | ||
3776 | unload_nls(sbi->local_nls); | ||
3777 | kfree(sbi); | ||
3778 | } | ||
3779 | |||
3773 | void | 3780 | void |
3774 | cifs_umount(struct cifs_sb_info *cifs_sb) | 3781 | cifs_umount(struct cifs_sb_info *cifs_sb) |
3775 | { | 3782 | { |
@@ -3794,8 +3801,7 @@ cifs_umount(struct cifs_sb_info *cifs_sb) | |||
3794 | 3801 | ||
3795 | bdi_destroy(&cifs_sb->bdi); | 3802 | bdi_destroy(&cifs_sb->bdi); |
3796 | kfree(cifs_sb->mountdata); | 3803 | kfree(cifs_sb->mountdata); |
3797 | unload_nls(cifs_sb->local_nls); | 3804 | call_rcu(&cifs_sb->rcu, delayed_free); |
3798 | kfree(cifs_sb); | ||
3799 | } | 3805 | } |
3800 | 3806 | ||
3801 | int | 3807 | int |
diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 7e36ceba0c7a..cc0234710ddb 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c | |||
@@ -621,10 +621,3 @@ symlink_exit: | |||
621 | free_xid(xid); | 621 | free_xid(xid); |
622 | return rc; | 622 | return rc; |
623 | } | 623 | } |
624 | |||
625 | void cifs_put_link(struct dentry *direntry, struct nameidata *nd, void *cookie) | ||
626 | { | ||
627 | char *p = nd_get_link(nd); | ||
628 | if (!IS_ERR(p)) | ||
629 | kfree(p); | ||
630 | } | ||
diff --git a/fs/coda/coda_linux.h b/fs/coda/coda_linux.h index cc0ea9fe5ecf..e7550cb9fb74 100644 --- a/fs/coda/coda_linux.h +++ b/fs/coda/coda_linux.h | |||
@@ -40,7 +40,7 @@ extern const struct file_operations coda_ioctl_operations; | |||
40 | int coda_open(struct inode *i, struct file *f); | 40 | int coda_open(struct inode *i, struct file *f); |
41 | int coda_release(struct inode *i, struct file *f); | 41 | int coda_release(struct inode *i, struct file *f); |
42 | int coda_permission(struct inode *inode, int mask); | 42 | int coda_permission(struct inode *inode, int mask); |
43 | int coda_revalidate_inode(struct dentry *); | 43 | int coda_revalidate_inode(struct inode *); |
44 | int coda_getattr(struct vfsmount *, struct dentry *, struct kstat *); | 44 | int coda_getattr(struct vfsmount *, struct dentry *, struct kstat *); |
45 | int coda_setattr(struct dentry *, struct iattr *); | 45 | int coda_setattr(struct dentry *, struct iattr *); |
46 | 46 | ||
diff --git a/fs/coda/dir.c b/fs/coda/dir.c index 190effc6a6fa..5efbb5ee0adc 100644 --- a/fs/coda/dir.c +++ b/fs/coda/dir.c | |||
@@ -387,9 +387,6 @@ static int coda_readdir(struct file *coda_file, struct dir_context *ctx) | |||
387 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); | 387 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); |
388 | host_file = cfi->cfi_container; | 388 | host_file = cfi->cfi_container; |
389 | 389 | ||
390 | if (!host_file->f_op) | ||
391 | return -ENOTDIR; | ||
392 | |||
393 | if (host_file->f_op->iterate) { | 390 | if (host_file->f_op->iterate) { |
394 | struct inode *host_inode = file_inode(host_file); | 391 | struct inode *host_inode = file_inode(host_file); |
395 | mutex_lock(&host_inode->i_mutex); | 392 | mutex_lock(&host_inode->i_mutex); |
@@ -566,13 +563,12 @@ static int coda_dentry_delete(const struct dentry * dentry) | |||
566 | * cache manager Venus issues a downcall to the kernel when this | 563 | * cache manager Venus issues a downcall to the kernel when this |
567 | * happens | 564 | * happens |
568 | */ | 565 | */ |
569 | int coda_revalidate_inode(struct dentry *dentry) | 566 | int coda_revalidate_inode(struct inode *inode) |
570 | { | 567 | { |
571 | struct coda_vattr attr; | 568 | struct coda_vattr attr; |
572 | int error; | 569 | int error; |
573 | int old_mode; | 570 | int old_mode; |
574 | ino_t old_ino; | 571 | ino_t old_ino; |
575 | struct inode *inode = dentry->d_inode; | ||
576 | struct coda_inode_info *cii = ITOC(inode); | 572 | struct coda_inode_info *cii = ITOC(inode); |
577 | 573 | ||
578 | if (!cii->c_flags) | 574 | if (!cii->c_flags) |
diff --git a/fs/coda/file.c b/fs/coda/file.c index 380b798f8443..9e83b7790212 100644 --- a/fs/coda/file.c +++ b/fs/coda/file.c | |||
@@ -36,7 +36,7 @@ coda_file_read(struct file *coda_file, char __user *buf, size_t count, loff_t *p | |||
36 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); | 36 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); |
37 | host_file = cfi->cfi_container; | 37 | host_file = cfi->cfi_container; |
38 | 38 | ||
39 | if (!host_file->f_op || !host_file->f_op->read) | 39 | if (!host_file->f_op->read) |
40 | return -EINVAL; | 40 | return -EINVAL; |
41 | 41 | ||
42 | return host_file->f_op->read(host_file, buf, count, ppos); | 42 | return host_file->f_op->read(host_file, buf, count, ppos); |
@@ -75,7 +75,7 @@ coda_file_write(struct file *coda_file, const char __user *buf, size_t count, lo | |||
75 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); | 75 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); |
76 | host_file = cfi->cfi_container; | 76 | host_file = cfi->cfi_container; |
77 | 77 | ||
78 | if (!host_file->f_op || !host_file->f_op->write) | 78 | if (!host_file->f_op->write) |
79 | return -EINVAL; | 79 | return -EINVAL; |
80 | 80 | ||
81 | host_inode = file_inode(host_file); | 81 | host_inode = file_inode(host_file); |
@@ -105,7 +105,7 @@ coda_file_mmap(struct file *coda_file, struct vm_area_struct *vma) | |||
105 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); | 105 | BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); |
106 | host_file = cfi->cfi_container; | 106 | host_file = cfi->cfi_container; |
107 | 107 | ||
108 | if (!host_file->f_op || !host_file->f_op->mmap) | 108 | if (!host_file->f_op->mmap) |
109 | return -ENODEV; | 109 | return -ENODEV; |
110 | 110 | ||
111 | coda_inode = file_inode(coda_file); | 111 | coda_inode = file_inode(coda_file); |
diff --git a/fs/coda/inode.c b/fs/coda/inode.c index 4dcc0d81a7aa..506de34a4ef3 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c | |||
@@ -257,7 +257,7 @@ static void coda_evict_inode(struct inode *inode) | |||
257 | 257 | ||
258 | int coda_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) | 258 | int coda_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) |
259 | { | 259 | { |
260 | int err = coda_revalidate_inode(dentry); | 260 | int err = coda_revalidate_inode(dentry->d_inode); |
261 | if (!err) | 261 | if (!err) |
262 | generic_fillattr(dentry->d_inode, stat); | 262 | generic_fillattr(dentry->d_inode, stat); |
263 | return err; | 263 | return err; |
diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 5d19acfa7c6c..dc52e13d58e0 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c | |||
@@ -1583,13 +1583,13 @@ asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, | |||
1583 | /*FALL THROUGH*/ | 1583 | /*FALL THROUGH*/ |
1584 | 1584 | ||
1585 | default: | 1585 | default: |
1586 | if (f.file->f_op && f.file->f_op->compat_ioctl) { | 1586 | if (f.file->f_op->compat_ioctl) { |
1587 | error = f.file->f_op->compat_ioctl(f.file, cmd, arg); | 1587 | error = f.file->f_op->compat_ioctl(f.file, cmd, arg); |
1588 | if (error != -ENOIOCTLCMD) | 1588 | if (error != -ENOIOCTLCMD) |
1589 | goto out_fput; | 1589 | goto out_fput; |
1590 | } | 1590 | } |
1591 | 1591 | ||
1592 | if (!f.file->f_op || !f.file->f_op->unlocked_ioctl) | 1592 | if (!f.file->f_op->unlocked_ioctl) |
1593 | goto do_ioctl; | 1593 | goto do_ioctl; |
1594 | break; | 1594 | break; |
1595 | } | 1595 | } |
diff --git a/fs/coredump.c b/fs/coredump.c index 9bdeca12ae0e..62406b6959b6 100644 --- a/fs/coredump.c +++ b/fs/coredump.c | |||
@@ -485,7 +485,7 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) | |||
485 | return err; | 485 | return err; |
486 | } | 486 | } |
487 | 487 | ||
488 | void do_coredump(siginfo_t *siginfo) | 488 | void do_coredump(const siginfo_t *siginfo) |
489 | { | 489 | { |
490 | struct core_state core_state; | 490 | struct core_state core_state; |
491 | struct core_name cn; | 491 | struct core_name cn; |
@@ -645,7 +645,7 @@ void do_coredump(siginfo_t *siginfo) | |||
645 | */ | 645 | */ |
646 | if (!uid_eq(inode->i_uid, current_fsuid())) | 646 | if (!uid_eq(inode->i_uid, current_fsuid())) |
647 | goto close_fail; | 647 | goto close_fail; |
648 | if (!cprm.file->f_op || !cprm.file->f_op->write) | 648 | if (!cprm.file->f_op->write) |
649 | goto close_fail; | 649 | goto close_fail; |
650 | if (do_truncate(cprm.file->f_path.dentry, 0, 0, cprm.file)) | 650 | if (do_truncate(cprm.file->f_path.dentry, 0, 0, cprm.file)) |
651 | goto close_fail; | 651 | goto close_fail; |
@@ -685,40 +685,55 @@ fail: | |||
685 | * do on a core-file: use only these functions to write out all the | 685 | * do on a core-file: use only these functions to write out all the |
686 | * necessary info. | 686 | * necessary info. |
687 | */ | 687 | */ |
688 | int dump_write(struct file *file, const void *addr, int nr) | 688 | int dump_emit(struct coredump_params *cprm, const void *addr, int nr) |
689 | { | 689 | { |
690 | return !dump_interrupted() && | 690 | struct file *file = cprm->file; |
691 | access_ok(VERIFY_READ, addr, nr) && | 691 | loff_t pos = file->f_pos; |
692 | file->f_op->write(file, addr, nr, &file->f_pos) == nr; | 692 | ssize_t n; |
693 | if (cprm->written + nr > cprm->limit) | ||
694 | return 0; | ||
695 | while (nr) { | ||
696 | if (dump_interrupted()) | ||
697 | return 0; | ||
698 | n = vfs_write(file, addr, nr, &pos); | ||
699 | if (n <= 0) | ||
700 | return 0; | ||
701 | file->f_pos = pos; | ||
702 | cprm->written += n; | ||
703 | nr -= n; | ||
704 | } | ||
705 | return 1; | ||
693 | } | 706 | } |
694 | EXPORT_SYMBOL(dump_write); | 707 | EXPORT_SYMBOL(dump_emit); |
695 | 708 | ||
696 | int dump_seek(struct file *file, loff_t off) | 709 | int dump_skip(struct coredump_params *cprm, size_t nr) |
697 | { | 710 | { |
698 | int ret = 1; | 711 | static char zeroes[PAGE_SIZE]; |
699 | 712 | struct file *file = cprm->file; | |
700 | if (file->f_op->llseek && file->f_op->llseek != no_llseek) { | 713 | if (file->f_op->llseek && file->f_op->llseek != no_llseek) { |
714 | if (cprm->written + nr > cprm->limit) | ||
715 | return 0; | ||
701 | if (dump_interrupted() || | 716 | if (dump_interrupted() || |
702 | file->f_op->llseek(file, off, SEEK_CUR) < 0) | 717 | file->f_op->llseek(file, nr, SEEK_CUR) < 0) |
703 | return 0; | 718 | return 0; |
719 | cprm->written += nr; | ||
720 | return 1; | ||
704 | } else { | 721 | } else { |
705 | char *buf = (char *)get_zeroed_page(GFP_KERNEL); | 722 | while (nr > PAGE_SIZE) { |
706 | 723 | if (!dump_emit(cprm, zeroes, PAGE_SIZE)) | |
707 | if (!buf) | 724 | return 0; |
708 | return 0; | 725 | nr -= PAGE_SIZE; |
709 | while (off > 0) { | ||
710 | unsigned long n = off; | ||
711 | |||
712 | if (n > PAGE_SIZE) | ||
713 | n = PAGE_SIZE; | ||
714 | if (!dump_write(file, buf, n)) { | ||
715 | ret = 0; | ||
716 | break; | ||
717 | } | ||
718 | off -= n; | ||
719 | } | 726 | } |
720 | free_page((unsigned long)buf); | 727 | return dump_emit(cprm, zeroes, nr); |
721 | } | 728 | } |
722 | return ret; | ||
723 | } | 729 | } |
724 | EXPORT_SYMBOL(dump_seek); | 730 | EXPORT_SYMBOL(dump_skip); |
731 | |||
732 | int dump_align(struct coredump_params *cprm, int align) | ||
733 | { | ||
734 | unsigned mod = cprm->written & (align - 1); | ||
735 | if (align & (align - 1)) | ||
736 | return -EINVAL; | ||
737 | return mod ? dump_skip(cprm, align - mod) : 0; | ||
738 | } | ||
739 | EXPORT_SYMBOL(dump_align); | ||
diff --git a/fs/dcache.c b/fs/dcache.c index ae6ebb88ceff..1f24cd684c51 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -343,6 +343,7 @@ static void dentry_unlink_inode(struct dentry * dentry) | |||
343 | __releases(dentry->d_inode->i_lock) | 343 | __releases(dentry->d_inode->i_lock) |
344 | { | 344 | { |
345 | struct inode *inode = dentry->d_inode; | 345 | struct inode *inode = dentry->d_inode; |
346 | __d_clear_type(dentry); | ||
346 | dentry->d_inode = NULL; | 347 | dentry->d_inode = NULL; |
347 | hlist_del_init(&dentry->d_alias); | 348 | hlist_del_init(&dentry->d_alias); |
348 | dentry_rcuwalk_barrier(dentry); | 349 | dentry_rcuwalk_barrier(dentry); |
@@ -483,27 +484,6 @@ static struct dentry *d_kill(struct dentry *dentry, struct dentry *parent) | |||
483 | return parent; | 484 | return parent; |
484 | } | 485 | } |
485 | 486 | ||
486 | /* | ||
487 | * Unhash a dentry without inserting an RCU walk barrier or checking that | ||
488 | * dentry->d_lock is locked. The caller must take care of that, if | ||
489 | * appropriate. | ||
490 | */ | ||
491 | static void __d_shrink(struct dentry *dentry) | ||
492 | { | ||
493 | if (!d_unhashed(dentry)) { | ||
494 | struct hlist_bl_head *b; | ||
495 | if (unlikely(dentry->d_flags & DCACHE_DISCONNECTED)) | ||
496 | b = &dentry->d_sb->s_anon; | ||
497 | else | ||
498 | b = d_hash(dentry->d_parent, dentry->d_name.hash); | ||
499 | |||
500 | hlist_bl_lock(b); | ||
501 | __hlist_bl_del(&dentry->d_hash); | ||
502 | dentry->d_hash.pprev = NULL; | ||
503 | hlist_bl_unlock(b); | ||
504 | } | ||
505 | } | ||
506 | |||
507 | /** | 487 | /** |
508 | * d_drop - drop a dentry | 488 | * d_drop - drop a dentry |
509 | * @dentry: dentry to drop | 489 | * @dentry: dentry to drop |
@@ -522,7 +502,21 @@ static void __d_shrink(struct dentry *dentry) | |||
522 | void __d_drop(struct dentry *dentry) | 502 | void __d_drop(struct dentry *dentry) |
523 | { | 503 | { |
524 | if (!d_unhashed(dentry)) { | 504 | if (!d_unhashed(dentry)) { |
525 | __d_shrink(dentry); | 505 | struct hlist_bl_head *b; |
506 | /* | ||
507 | * Hashed dentries are normally on the dentry hashtable, | ||
508 | * with the exception of those newly allocated by | ||
509 | * d_obtain_alias, which are always IS_ROOT: | ||
510 | */ | ||
511 | if (unlikely(IS_ROOT(dentry))) | ||
512 | b = &dentry->d_sb->s_anon; | ||
513 | else | ||
514 | b = d_hash(dentry->d_parent, dentry->d_name.hash); | ||
515 | |||
516 | hlist_bl_lock(b); | ||
517 | __hlist_bl_del(&dentry->d_hash); | ||
518 | dentry->d_hash.pprev = NULL; | ||
519 | hlist_bl_unlock(b); | ||
526 | dentry_rcuwalk_barrier(dentry); | 520 | dentry_rcuwalk_barrier(dentry); |
527 | } | 521 | } |
528 | } | 522 | } |
@@ -1076,116 +1070,6 @@ void shrink_dcache_sb(struct super_block *sb) | |||
1076 | EXPORT_SYMBOL(shrink_dcache_sb); | 1070 | EXPORT_SYMBOL(shrink_dcache_sb); |
1077 | 1071 | ||
1078 | /* | 1072 | /* |
1079 | * destroy a single subtree of dentries for unmount | ||
1080 | * - see the comments on shrink_dcache_for_umount() for a description of the | ||
1081 | * locking | ||
1082 | */ | ||
1083 | static void shrink_dcache_for_umount_subtree(struct dentry *dentry) | ||
1084 | { | ||
1085 | struct dentry *parent; | ||
1086 | |||
1087 | BUG_ON(!IS_ROOT(dentry)); | ||
1088 | |||
1089 | for (;;) { | ||
1090 | /* descend to the first leaf in the current subtree */ | ||
1091 | while (!list_empty(&dentry->d_subdirs)) | ||
1092 | dentry = list_entry(dentry->d_subdirs.next, | ||
1093 | struct dentry, d_u.d_child); | ||
1094 | |||
1095 | /* consume the dentries from this leaf up through its parents | ||
1096 | * until we find one with children or run out altogether */ | ||
1097 | do { | ||
1098 | struct inode *inode; | ||
1099 | |||
1100 | /* | ||
1101 | * inform the fs that this dentry is about to be | ||
1102 | * unhashed and destroyed. | ||
1103 | */ | ||
1104 | if ((dentry->d_flags & DCACHE_OP_PRUNE) && | ||
1105 | !d_unhashed(dentry)) | ||
1106 | dentry->d_op->d_prune(dentry); | ||
1107 | |||
1108 | dentry_lru_del(dentry); | ||
1109 | __d_shrink(dentry); | ||
1110 | |||
1111 | if (dentry->d_lockref.count != 0) { | ||
1112 | printk(KERN_ERR | ||
1113 | "BUG: Dentry %p{i=%lx,n=%s}" | ||
1114 | " still in use (%d)" | ||
1115 | " [unmount of %s %s]\n", | ||
1116 | dentry, | ||
1117 | dentry->d_inode ? | ||
1118 | dentry->d_inode->i_ino : 0UL, | ||
1119 | dentry->d_name.name, | ||
1120 | dentry->d_lockref.count, | ||
1121 | dentry->d_sb->s_type->name, | ||
1122 | dentry->d_sb->s_id); | ||
1123 | BUG(); | ||
1124 | } | ||
1125 | |||
1126 | if (IS_ROOT(dentry)) { | ||
1127 | parent = NULL; | ||
1128 | list_del(&dentry->d_u.d_child); | ||
1129 | } else { | ||
1130 | parent = dentry->d_parent; | ||
1131 | parent->d_lockref.count--; | ||
1132 | list_del(&dentry->d_u.d_child); | ||
1133 | } | ||
1134 | |||
1135 | inode = dentry->d_inode; | ||
1136 | if (inode) { | ||
1137 | dentry->d_inode = NULL; | ||
1138 | hlist_del_init(&dentry->d_alias); | ||
1139 | if (dentry->d_op && dentry->d_op->d_iput) | ||
1140 | dentry->d_op->d_iput(dentry, inode); | ||
1141 | else | ||
1142 | iput(inode); | ||
1143 | } | ||
1144 | |||
1145 | d_free(dentry); | ||
1146 | |||
1147 | /* finished when we fall off the top of the tree, | ||
1148 | * otherwise we ascend to the parent and move to the | ||
1149 | * next sibling if there is one */ | ||
1150 | if (!parent) | ||
1151 | return; | ||
1152 | dentry = parent; | ||
1153 | } while (list_empty(&dentry->d_subdirs)); | ||
1154 | |||
1155 | dentry = list_entry(dentry->d_subdirs.next, | ||
1156 | struct dentry, d_u.d_child); | ||
1157 | } | ||
1158 | } | ||
1159 | |||
1160 | /* | ||
1161 | * destroy the dentries attached to a superblock on unmounting | ||
1162 | * - we don't need to use dentry->d_lock because: | ||
1163 | * - the superblock is detached from all mountings and open files, so the | ||
1164 | * dentry trees will not be rearranged by the VFS | ||
1165 | * - s_umount is write-locked, so the memory pressure shrinker will ignore | ||
1166 | * any dentries belonging to this superblock that it comes across | ||
1167 | * - the filesystem itself is no longer permitted to rearrange the dentries | ||
1168 | * in this superblock | ||
1169 | */ | ||
1170 | void shrink_dcache_for_umount(struct super_block *sb) | ||
1171 | { | ||
1172 | struct dentry *dentry; | ||
1173 | |||
1174 | if (down_read_trylock(&sb->s_umount)) | ||
1175 | BUG(); | ||
1176 | |||
1177 | dentry = sb->s_root; | ||
1178 | sb->s_root = NULL; | ||
1179 | dentry->d_lockref.count--; | ||
1180 | shrink_dcache_for_umount_subtree(dentry); | ||
1181 | |||
1182 | while (!hlist_bl_empty(&sb->s_anon)) { | ||
1183 | dentry = hlist_bl_entry(hlist_bl_first(&sb->s_anon), struct dentry, d_hash); | ||
1184 | shrink_dcache_for_umount_subtree(dentry); | ||
1185 | } | ||
1186 | } | ||
1187 | |||
1188 | /* | ||
1189 | * This tries to ascend one level of parenthood, but | 1073 | * This tries to ascend one level of parenthood, but |
1190 | * we can race with renaming, so we need to re-check | 1074 | * we can race with renaming, so we need to re-check |
1191 | * the parenthood after dropping the lock and check | 1075 | * the parenthood after dropping the lock and check |
@@ -1478,6 +1362,91 @@ void shrink_dcache_parent(struct dentry *parent) | |||
1478 | } | 1362 | } |
1479 | EXPORT_SYMBOL(shrink_dcache_parent); | 1363 | EXPORT_SYMBOL(shrink_dcache_parent); |
1480 | 1364 | ||
1365 | static enum d_walk_ret umount_collect(void *_data, struct dentry *dentry) | ||
1366 | { | ||
1367 | struct select_data *data = _data; | ||
1368 | enum d_walk_ret ret = D_WALK_CONTINUE; | ||
1369 | |||
1370 | if (dentry->d_lockref.count) { | ||
1371 | dentry_lru_del(dentry); | ||
1372 | if (likely(!list_empty(&dentry->d_subdirs))) | ||
1373 | goto out; | ||
1374 | if (dentry == data->start && dentry->d_lockref.count == 1) | ||
1375 | goto out; | ||
1376 | printk(KERN_ERR | ||
1377 | "BUG: Dentry %p{i=%lx,n=%s}" | ||
1378 | " still in use (%d)" | ||
1379 | " [unmount of %s %s]\n", | ||
1380 | dentry, | ||
1381 | dentry->d_inode ? | ||
1382 | dentry->d_inode->i_ino : 0UL, | ||
1383 | dentry->d_name.name, | ||
1384 | dentry->d_lockref.count, | ||
1385 | dentry->d_sb->s_type->name, | ||
1386 | dentry->d_sb->s_id); | ||
1387 | BUG(); | ||
1388 | } else if (!(dentry->d_flags & DCACHE_SHRINK_LIST)) { | ||
1389 | /* | ||
1390 | * We can't use d_lru_shrink_move() because we | ||
1391 | * need to get the global LRU lock and do the | ||
1392 | * LRU accounting. | ||
1393 | */ | ||
1394 | if (dentry->d_flags & DCACHE_LRU_LIST) | ||
1395 | d_lru_del(dentry); | ||
1396 | d_shrink_add(dentry, &data->dispose); | ||
1397 | data->found++; | ||
1398 | ret = D_WALK_NORETRY; | ||
1399 | } | ||
1400 | out: | ||
1401 | if (data->found && need_resched()) | ||
1402 | ret = D_WALK_QUIT; | ||
1403 | return ret; | ||
1404 | } | ||
1405 | |||
1406 | /* | ||
1407 | * destroy the dentries attached to a superblock on unmounting | ||
1408 | */ | ||
1409 | void shrink_dcache_for_umount(struct super_block *sb) | ||
1410 | { | ||
1411 | struct dentry *dentry; | ||
1412 | |||
1413 | if (down_read_trylock(&sb->s_umount)) | ||
1414 | BUG(); | ||
1415 | |||
1416 | dentry = sb->s_root; | ||
1417 | sb->s_root = NULL; | ||
1418 | for (;;) { | ||
1419 | struct select_data data; | ||
1420 | |||
1421 | INIT_LIST_HEAD(&data.dispose); | ||
1422 | data.start = dentry; | ||
1423 | data.found = 0; | ||
1424 | |||
1425 | d_walk(dentry, &data, umount_collect, NULL); | ||
1426 | if (!data.found) | ||
1427 | break; | ||
1428 | |||
1429 | shrink_dentry_list(&data.dispose); | ||
1430 | cond_resched(); | ||
1431 | } | ||
1432 | d_drop(dentry); | ||
1433 | dput(dentry); | ||
1434 | |||
1435 | while (!hlist_bl_empty(&sb->s_anon)) { | ||
1436 | struct select_data data; | ||
1437 | dentry = hlist_bl_entry(hlist_bl_first(&sb->s_anon), struct dentry, d_hash); | ||
1438 | |||
1439 | INIT_LIST_HEAD(&data.dispose); | ||
1440 | data.start = NULL; | ||
1441 | data.found = 0; | ||
1442 | |||
1443 | d_walk(dentry, &data, umount_collect, NULL); | ||
1444 | if (data.found) | ||
1445 | shrink_dentry_list(&data.dispose); | ||
1446 | cond_resched(); | ||
1447 | } | ||
1448 | } | ||
1449 | |||
1481 | static enum d_walk_ret check_and_collect(void *_data, struct dentry *dentry) | 1450 | static enum d_walk_ret check_and_collect(void *_data, struct dentry *dentry) |
1482 | { | 1451 | { |
1483 | struct select_data *data = _data; | 1452 | struct select_data *data = _data; |
@@ -1638,12 +1607,17 @@ struct dentry *d_alloc(struct dentry * parent, const struct qstr *name) | |||
1638 | } | 1607 | } |
1639 | EXPORT_SYMBOL(d_alloc); | 1608 | EXPORT_SYMBOL(d_alloc); |
1640 | 1609 | ||
1610 | /** | ||
1611 | * d_alloc_pseudo - allocate a dentry (for lookup-less filesystems) | ||
1612 | * @sb: the superblock | ||
1613 | * @name: qstr of the name | ||
1614 | * | ||
1615 | * For a filesystem that just pins its dentries in memory and never | ||
1616 | * performs lookups at all, return an unhashed IS_ROOT dentry. | ||
1617 | */ | ||
1641 | struct dentry *d_alloc_pseudo(struct super_block *sb, const struct qstr *name) | 1618 | struct dentry *d_alloc_pseudo(struct super_block *sb, const struct qstr *name) |
1642 | { | 1619 | { |
1643 | struct dentry *dentry = __d_alloc(sb, name); | 1620 | return __d_alloc(sb, name); |
1644 | if (dentry) | ||
1645 | dentry->d_flags |= DCACHE_DISCONNECTED; | ||
1646 | return dentry; | ||
1647 | } | 1621 | } |
1648 | EXPORT_SYMBOL(d_alloc_pseudo); | 1622 | EXPORT_SYMBOL(d_alloc_pseudo); |
1649 | 1623 | ||
@@ -1685,14 +1659,42 @@ void d_set_d_op(struct dentry *dentry, const struct dentry_operations *op) | |||
1685 | } | 1659 | } |
1686 | EXPORT_SYMBOL(d_set_d_op); | 1660 | EXPORT_SYMBOL(d_set_d_op); |
1687 | 1661 | ||
1662 | static unsigned d_flags_for_inode(struct inode *inode) | ||
1663 | { | ||
1664 | unsigned add_flags = DCACHE_FILE_TYPE; | ||
1665 | |||
1666 | if (!inode) | ||
1667 | return DCACHE_MISS_TYPE; | ||
1668 | |||
1669 | if (S_ISDIR(inode->i_mode)) { | ||
1670 | add_flags = DCACHE_DIRECTORY_TYPE; | ||
1671 | if (unlikely(!(inode->i_opflags & IOP_LOOKUP))) { | ||
1672 | if (unlikely(!inode->i_op->lookup)) | ||
1673 | add_flags = DCACHE_AUTODIR_TYPE; | ||
1674 | else | ||
1675 | inode->i_opflags |= IOP_LOOKUP; | ||
1676 | } | ||
1677 | } else if (unlikely(!(inode->i_opflags & IOP_NOFOLLOW))) { | ||
1678 | if (unlikely(inode->i_op->follow_link)) | ||
1679 | add_flags = DCACHE_SYMLINK_TYPE; | ||
1680 | else | ||
1681 | inode->i_opflags |= IOP_NOFOLLOW; | ||
1682 | } | ||
1683 | |||
1684 | if (unlikely(IS_AUTOMOUNT(inode))) | ||
1685 | add_flags |= DCACHE_NEED_AUTOMOUNT; | ||
1686 | return add_flags; | ||
1687 | } | ||
1688 | |||
1688 | static void __d_instantiate(struct dentry *dentry, struct inode *inode) | 1689 | static void __d_instantiate(struct dentry *dentry, struct inode *inode) |
1689 | { | 1690 | { |
1691 | unsigned add_flags = d_flags_for_inode(inode); | ||
1692 | |||
1690 | spin_lock(&dentry->d_lock); | 1693 | spin_lock(&dentry->d_lock); |
1691 | if (inode) { | 1694 | dentry->d_flags &= ~DCACHE_ENTRY_TYPE; |
1692 | if (unlikely(IS_AUTOMOUNT(inode))) | 1695 | dentry->d_flags |= add_flags; |
1693 | dentry->d_flags |= DCACHE_NEED_AUTOMOUNT; | 1696 | if (inode) |
1694 | hlist_add_head(&dentry->d_alias, &inode->i_dentry); | 1697 | hlist_add_head(&dentry->d_alias, &inode->i_dentry); |
1695 | } | ||
1696 | dentry->d_inode = inode; | 1698 | dentry->d_inode = inode; |
1697 | dentry_rcuwalk_barrier(dentry); | 1699 | dentry_rcuwalk_barrier(dentry); |
1698 | spin_unlock(&dentry->d_lock); | 1700 | spin_unlock(&dentry->d_lock); |
@@ -1801,6 +1803,33 @@ struct dentry *d_instantiate_unique(struct dentry *entry, struct inode *inode) | |||
1801 | 1803 | ||
1802 | EXPORT_SYMBOL(d_instantiate_unique); | 1804 | EXPORT_SYMBOL(d_instantiate_unique); |
1803 | 1805 | ||
1806 | /** | ||
1807 | * d_instantiate_no_diralias - instantiate a non-aliased dentry | ||
1808 | * @entry: dentry to complete | ||
1809 | * @inode: inode to attach to this dentry | ||
1810 | * | ||
1811 | * Fill in inode information in the entry. If a directory alias is found, then | ||
1812 | * return an error (and drop inode). Together with d_materialise_unique() this | ||
1813 | * guarantees that a directory inode may never have more than one alias. | ||
1814 | */ | ||
1815 | int d_instantiate_no_diralias(struct dentry *entry, struct inode *inode) | ||
1816 | { | ||
1817 | BUG_ON(!hlist_unhashed(&entry->d_alias)); | ||
1818 | |||
1819 | spin_lock(&inode->i_lock); | ||
1820 | if (S_ISDIR(inode->i_mode) && !hlist_empty(&inode->i_dentry)) { | ||
1821 | spin_unlock(&inode->i_lock); | ||
1822 | iput(inode); | ||
1823 | return -EBUSY; | ||
1824 | } | ||
1825 | __d_instantiate(entry, inode); | ||
1826 | spin_unlock(&inode->i_lock); | ||
1827 | security_d_instantiate(entry, inode); | ||
1828 | |||
1829 | return 0; | ||
1830 | } | ||
1831 | EXPORT_SYMBOL(d_instantiate_no_diralias); | ||
1832 | |||
1804 | struct dentry *d_make_root(struct inode *root_inode) | 1833 | struct dentry *d_make_root(struct inode *root_inode) |
1805 | { | 1834 | { |
1806 | struct dentry *res = NULL; | 1835 | struct dentry *res = NULL; |
@@ -1870,6 +1899,7 @@ struct dentry *d_obtain_alias(struct inode *inode) | |||
1870 | static const struct qstr anonstring = QSTR_INIT("/", 1); | 1899 | static const struct qstr anonstring = QSTR_INIT("/", 1); |
1871 | struct dentry *tmp; | 1900 | struct dentry *tmp; |
1872 | struct dentry *res; | 1901 | struct dentry *res; |
1902 | unsigned add_flags; | ||
1873 | 1903 | ||
1874 | if (!inode) | 1904 | if (!inode) |
1875 | return ERR_PTR(-ESTALE); | 1905 | return ERR_PTR(-ESTALE); |
@@ -1895,9 +1925,11 @@ struct dentry *d_obtain_alias(struct inode *inode) | |||
1895 | } | 1925 | } |
1896 | 1926 | ||
1897 | /* attach a disconnected dentry */ | 1927 | /* attach a disconnected dentry */ |
1928 | add_flags = d_flags_for_inode(inode) | DCACHE_DISCONNECTED; | ||
1929 | |||
1898 | spin_lock(&tmp->d_lock); | 1930 | spin_lock(&tmp->d_lock); |
1899 | tmp->d_inode = inode; | 1931 | tmp->d_inode = inode; |
1900 | tmp->d_flags |= DCACHE_DISCONNECTED; | 1932 | tmp->d_flags |= add_flags; |
1901 | hlist_add_head(&tmp->d_alias, &inode->i_dentry); | 1933 | hlist_add_head(&tmp->d_alias, &inode->i_dentry); |
1902 | hlist_bl_lock(&tmp->d_sb->s_anon); | 1934 | hlist_bl_lock(&tmp->d_sb->s_anon); |
1903 | hlist_bl_add_head(&tmp->d_hash, &tmp->d_sb->s_anon); | 1935 | hlist_bl_add_head(&tmp->d_hash, &tmp->d_sb->s_anon); |
@@ -2725,7 +2757,6 @@ static void __d_materialise_dentry(struct dentry *dentry, struct dentry *anon) | |||
2725 | spin_unlock(&dentry->d_lock); | 2757 | spin_unlock(&dentry->d_lock); |
2726 | 2758 | ||
2727 | /* anon->d_lock still locked, returns locked */ | 2759 | /* anon->d_lock still locked, returns locked */ |
2728 | anon->d_flags &= ~DCACHE_DISCONNECTED; | ||
2729 | } | 2760 | } |
2730 | 2761 | ||
2731 | /** | 2762 | /** |
@@ -2885,23 +2916,28 @@ static int prepend_path(const struct path *path, | |||
2885 | struct vfsmount *vfsmnt = path->mnt; | 2916 | struct vfsmount *vfsmnt = path->mnt; |
2886 | struct mount *mnt = real_mount(vfsmnt); | 2917 | struct mount *mnt = real_mount(vfsmnt); |
2887 | int error = 0; | 2918 | int error = 0; |
2888 | unsigned seq = 0; | 2919 | unsigned seq, m_seq = 0; |
2889 | char *bptr; | 2920 | char *bptr; |
2890 | int blen; | 2921 | int blen; |
2891 | 2922 | ||
2892 | rcu_read_lock(); | 2923 | rcu_read_lock(); |
2924 | restart_mnt: | ||
2925 | read_seqbegin_or_lock(&mount_lock, &m_seq); | ||
2926 | seq = 0; | ||
2893 | restart: | 2927 | restart: |
2894 | bptr = *buffer; | 2928 | bptr = *buffer; |
2895 | blen = *buflen; | 2929 | blen = *buflen; |
2930 | error = 0; | ||
2896 | read_seqbegin_or_lock(&rename_lock, &seq); | 2931 | read_seqbegin_or_lock(&rename_lock, &seq); |
2897 | while (dentry != root->dentry || vfsmnt != root->mnt) { | 2932 | while (dentry != root->dentry || vfsmnt != root->mnt) { |
2898 | struct dentry * parent; | 2933 | struct dentry * parent; |
2899 | 2934 | ||
2900 | if (dentry == vfsmnt->mnt_root || IS_ROOT(dentry)) { | 2935 | if (dentry == vfsmnt->mnt_root || IS_ROOT(dentry)) { |
2936 | struct mount *parent = ACCESS_ONCE(mnt->mnt_parent); | ||
2901 | /* Global root? */ | 2937 | /* Global root? */ |
2902 | if (mnt_has_parent(mnt)) { | 2938 | if (mnt != parent) { |
2903 | dentry = mnt->mnt_mountpoint; | 2939 | dentry = ACCESS_ONCE(mnt->mnt_mountpoint); |
2904 | mnt = mnt->mnt_parent; | 2940 | mnt = parent; |
2905 | vfsmnt = &mnt->mnt; | 2941 | vfsmnt = &mnt->mnt; |
2906 | continue; | 2942 | continue; |
2907 | } | 2943 | } |
@@ -2935,6 +2971,11 @@ restart: | |||
2935 | goto restart; | 2971 | goto restart; |
2936 | } | 2972 | } |
2937 | done_seqretry(&rename_lock, seq); | 2973 | done_seqretry(&rename_lock, seq); |
2974 | if (need_seqretry(&mount_lock, m_seq)) { | ||
2975 | m_seq = 1; | ||
2976 | goto restart_mnt; | ||
2977 | } | ||
2978 | done_seqretry(&mount_lock, m_seq); | ||
2938 | 2979 | ||
2939 | if (error >= 0 && bptr == *buffer) { | 2980 | if (error >= 0 && bptr == *buffer) { |
2940 | if (--blen < 0) | 2981 | if (--blen < 0) |
@@ -2971,9 +3012,7 @@ char *__d_path(const struct path *path, | |||
2971 | int error; | 3012 | int error; |
2972 | 3013 | ||
2973 | prepend(&res, &buflen, "\0", 1); | 3014 | prepend(&res, &buflen, "\0", 1); |
2974 | br_read_lock(&vfsmount_lock); | ||
2975 | error = prepend_path(path, root, &res, &buflen); | 3015 | error = prepend_path(path, root, &res, &buflen); |
2976 | br_read_unlock(&vfsmount_lock); | ||
2977 | 3016 | ||
2978 | if (error < 0) | 3017 | if (error < 0) |
2979 | return ERR_PTR(error); | 3018 | return ERR_PTR(error); |
@@ -2990,9 +3029,7 @@ char *d_absolute_path(const struct path *path, | |||
2990 | int error; | 3029 | int error; |
2991 | 3030 | ||
2992 | prepend(&res, &buflen, "\0", 1); | 3031 | prepend(&res, &buflen, "\0", 1); |
2993 | br_read_lock(&vfsmount_lock); | ||
2994 | error = prepend_path(path, &root, &res, &buflen); | 3032 | error = prepend_path(path, &root, &res, &buflen); |
2995 | br_read_unlock(&vfsmount_lock); | ||
2996 | 3033 | ||
2997 | if (error > 1) | 3034 | if (error > 1) |
2998 | error = -EINVAL; | 3035 | error = -EINVAL; |
@@ -3067,9 +3104,7 @@ char *d_path(const struct path *path, char *buf, int buflen) | |||
3067 | 3104 | ||
3068 | rcu_read_lock(); | 3105 | rcu_read_lock(); |
3069 | get_fs_root_rcu(current->fs, &root); | 3106 | get_fs_root_rcu(current->fs, &root); |
3070 | br_read_lock(&vfsmount_lock); | ||
3071 | error = path_with_deleted(path, &root, &res, &buflen); | 3107 | error = path_with_deleted(path, &root, &res, &buflen); |
3072 | br_read_unlock(&vfsmount_lock); | ||
3073 | rcu_read_unlock(); | 3108 | rcu_read_unlock(); |
3074 | 3109 | ||
3075 | if (error < 0) | 3110 | if (error < 0) |
@@ -3224,7 +3259,6 @@ SYSCALL_DEFINE2(getcwd, char __user *, buf, unsigned long, size) | |||
3224 | get_fs_root_and_pwd_rcu(current->fs, &root, &pwd); | 3259 | get_fs_root_and_pwd_rcu(current->fs, &root, &pwd); |
3225 | 3260 | ||
3226 | error = -ENOENT; | 3261 | error = -ENOENT; |
3227 | br_read_lock(&vfsmount_lock); | ||
3228 | if (!d_unlinked(pwd.dentry)) { | 3262 | if (!d_unlinked(pwd.dentry)) { |
3229 | unsigned long len; | 3263 | unsigned long len; |
3230 | char *cwd = page + PATH_MAX; | 3264 | char *cwd = page + PATH_MAX; |
@@ -3232,7 +3266,6 @@ SYSCALL_DEFINE2(getcwd, char __user *, buf, unsigned long, size) | |||
3232 | 3266 | ||
3233 | prepend(&cwd, &buflen, "\0", 1); | 3267 | prepend(&cwd, &buflen, "\0", 1); |
3234 | error = prepend_path(&pwd, &root, &cwd, &buflen); | 3268 | error = prepend_path(&pwd, &root, &cwd, &buflen); |
3235 | br_read_unlock(&vfsmount_lock); | ||
3236 | rcu_read_unlock(); | 3269 | rcu_read_unlock(); |
3237 | 3270 | ||
3238 | if (error < 0) | 3271 | if (error < 0) |
@@ -3253,7 +3286,6 @@ SYSCALL_DEFINE2(getcwd, char __user *, buf, unsigned long, size) | |||
3253 | error = -EFAULT; | 3286 | error = -EFAULT; |
3254 | } | 3287 | } |
3255 | } else { | 3288 | } else { |
3256 | br_read_unlock(&vfsmount_lock); | ||
3257 | rcu_read_unlock(); | 3289 | rcu_read_unlock(); |
3258 | } | 3290 | } |
3259 | 3291 | ||
diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c index bf12ba5dd223..4000f6b3a750 100644 --- a/fs/ecryptfs/dentry.c +++ b/fs/ecryptfs/dentry.c | |||
@@ -44,15 +44,15 @@ | |||
44 | */ | 44 | */ |
45 | static int ecryptfs_d_revalidate(struct dentry *dentry, unsigned int flags) | 45 | static int ecryptfs_d_revalidate(struct dentry *dentry, unsigned int flags) |
46 | { | 46 | { |
47 | struct dentry *lower_dentry; | 47 | struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry); |
48 | int rc = 1; | 48 | int rc; |
49 | |||
50 | if (!(lower_dentry->d_flags & DCACHE_OP_REVALIDATE)) | ||
51 | return 1; | ||
49 | 52 | ||
50 | if (flags & LOOKUP_RCU) | 53 | if (flags & LOOKUP_RCU) |
51 | return -ECHILD; | 54 | return -ECHILD; |
52 | 55 | ||
53 | lower_dentry = ecryptfs_dentry_to_lower(dentry); | ||
54 | if (!lower_dentry->d_op || !lower_dentry->d_op->d_revalidate) | ||
55 | goto out; | ||
56 | rc = lower_dentry->d_op->d_revalidate(lower_dentry, flags); | 56 | rc = lower_dentry->d_op->d_revalidate(lower_dentry, flags); |
57 | if (dentry->d_inode) { | 57 | if (dentry->d_inode) { |
58 | struct inode *lower_inode = | 58 | struct inode *lower_inode = |
@@ -60,12 +60,17 @@ static int ecryptfs_d_revalidate(struct dentry *dentry, unsigned int flags) | |||
60 | 60 | ||
61 | fsstack_copy_attr_all(dentry->d_inode, lower_inode); | 61 | fsstack_copy_attr_all(dentry->d_inode, lower_inode); |
62 | } | 62 | } |
63 | out: | ||
64 | return rc; | 63 | return rc; |
65 | } | 64 | } |
66 | 65 | ||
67 | struct kmem_cache *ecryptfs_dentry_info_cache; | 66 | struct kmem_cache *ecryptfs_dentry_info_cache; |
68 | 67 | ||
68 | static void ecryptfs_dentry_free_rcu(struct rcu_head *head) | ||
69 | { | ||
70 | kmem_cache_free(ecryptfs_dentry_info_cache, | ||
71 | container_of(head, struct ecryptfs_dentry_info, rcu)); | ||
72 | } | ||
73 | |||
69 | /** | 74 | /** |
70 | * ecryptfs_d_release | 75 | * ecryptfs_d_release |
71 | * @dentry: The ecryptfs dentry | 76 | * @dentry: The ecryptfs dentry |
@@ -74,15 +79,11 @@ struct kmem_cache *ecryptfs_dentry_info_cache; | |||
74 | */ | 79 | */ |
75 | static void ecryptfs_d_release(struct dentry *dentry) | 80 | static void ecryptfs_d_release(struct dentry *dentry) |
76 | { | 81 | { |
77 | if (ecryptfs_dentry_to_private(dentry)) { | 82 | struct ecryptfs_dentry_info *p = dentry->d_fsdata; |
78 | if (ecryptfs_dentry_to_lower(dentry)) { | 83 | if (p) { |
79 | dput(ecryptfs_dentry_to_lower(dentry)); | 84 | path_put(&p->lower_path); |
80 | mntput(ecryptfs_dentry_to_lower_mnt(dentry)); | 85 | call_rcu(&p->rcu, ecryptfs_dentry_free_rcu); |
81 | } | ||
82 | kmem_cache_free(ecryptfs_dentry_info_cache, | ||
83 | ecryptfs_dentry_to_private(dentry)); | ||
84 | } | 86 | } |
85 | return; | ||
86 | } | 87 | } |
87 | 88 | ||
88 | const struct dentry_operations ecryptfs_dops = { | 89 | const struct dentry_operations ecryptfs_dops = { |
diff --git a/fs/ecryptfs/ecryptfs_kernel.h b/fs/ecryptfs/ecryptfs_kernel.h index df19d34a033b..90d1882b306f 100644 --- a/fs/ecryptfs/ecryptfs_kernel.h +++ b/fs/ecryptfs/ecryptfs_kernel.h | |||
@@ -261,7 +261,10 @@ struct ecryptfs_inode_info { | |||
261 | * vfsmount too. */ | 261 | * vfsmount too. */ |
262 | struct ecryptfs_dentry_info { | 262 | struct ecryptfs_dentry_info { |
263 | struct path lower_path; | 263 | struct path lower_path; |
264 | struct ecryptfs_crypt_stat *crypt_stat; | 264 | union { |
265 | struct ecryptfs_crypt_stat *crypt_stat; | ||
266 | struct rcu_head rcu; | ||
267 | }; | ||
265 | }; | 268 | }; |
266 | 269 | ||
267 | /** | 270 | /** |
@@ -512,13 +515,6 @@ ecryptfs_dentry_to_lower(struct dentry *dentry) | |||
512 | return ((struct ecryptfs_dentry_info *)dentry->d_fsdata)->lower_path.dentry; | 515 | return ((struct ecryptfs_dentry_info *)dentry->d_fsdata)->lower_path.dentry; |
513 | } | 516 | } |
514 | 517 | ||
515 | static inline void | ||
516 | ecryptfs_set_dentry_lower(struct dentry *dentry, struct dentry *lower_dentry) | ||
517 | { | ||
518 | ((struct ecryptfs_dentry_info *)dentry->d_fsdata)->lower_path.dentry = | ||
519 | lower_dentry; | ||
520 | } | ||
521 | |||
522 | static inline struct vfsmount * | 518 | static inline struct vfsmount * |
523 | ecryptfs_dentry_to_lower_mnt(struct dentry *dentry) | 519 | ecryptfs_dentry_to_lower_mnt(struct dentry *dentry) |
524 | { | 520 | { |
@@ -531,13 +527,6 @@ ecryptfs_dentry_to_lower_path(struct dentry *dentry) | |||
531 | return &((struct ecryptfs_dentry_info *)dentry->d_fsdata)->lower_path; | 527 | return &((struct ecryptfs_dentry_info *)dentry->d_fsdata)->lower_path; |
532 | } | 528 | } |
533 | 529 | ||
534 | static inline void | ||
535 | ecryptfs_set_dentry_lower_mnt(struct dentry *dentry, struct vfsmount *lower_mnt) | ||
536 | { | ||
537 | ((struct ecryptfs_dentry_info *)dentry->d_fsdata)->lower_path.mnt = | ||
538 | lower_mnt; | ||
539 | } | ||
540 | |||
541 | #define ecryptfs_printk(type, fmt, arg...) \ | 530 | #define ecryptfs_printk(type, fmt, arg...) \ |
542 | __ecryptfs_printk(type "%s: " fmt, __func__, ## arg); | 531 | __ecryptfs_printk(type "%s: " fmt, __func__, ## arg); |
543 | __printf(1, 2) | 532 | __printf(1, 2) |
diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 992cf95830b5..2229a74aeeed 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c | |||
@@ -271,7 +271,7 @@ static int ecryptfs_flush(struct file *file, fl_owner_t td) | |||
271 | { | 271 | { |
272 | struct file *lower_file = ecryptfs_file_to_lower(file); | 272 | struct file *lower_file = ecryptfs_file_to_lower(file); |
273 | 273 | ||
274 | if (lower_file->f_op && lower_file->f_op->flush) { | 274 | if (lower_file->f_op->flush) { |
275 | filemap_write_and_wait(file->f_mapping); | 275 | filemap_write_and_wait(file->f_mapping); |
276 | return lower_file->f_op->flush(lower_file, td); | 276 | return lower_file->f_op->flush(lower_file, td); |
277 | } | 277 | } |
@@ -305,7 +305,7 @@ static int ecryptfs_fasync(int fd, struct file *file, int flag) | |||
305 | struct file *lower_file = NULL; | 305 | struct file *lower_file = NULL; |
306 | 306 | ||
307 | lower_file = ecryptfs_file_to_lower(file); | 307 | lower_file = ecryptfs_file_to_lower(file); |
308 | if (lower_file->f_op && lower_file->f_op->fasync) | 308 | if (lower_file->f_op->fasync) |
309 | rc = lower_file->f_op->fasync(fd, lower_file, flag); | 309 | rc = lower_file->f_op->fasync(fd, lower_file, flag); |
310 | return rc; | 310 | return rc; |
311 | } | 311 | } |
@@ -318,7 +318,7 @@ ecryptfs_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
318 | 318 | ||
319 | if (ecryptfs_file_to_private(file)) | 319 | if (ecryptfs_file_to_private(file)) |
320 | lower_file = ecryptfs_file_to_lower(file); | 320 | lower_file = ecryptfs_file_to_lower(file); |
321 | if (lower_file && lower_file->f_op && lower_file->f_op->unlocked_ioctl) | 321 | if (lower_file->f_op->unlocked_ioctl) |
322 | rc = lower_file->f_op->unlocked_ioctl(lower_file, cmd, arg); | 322 | rc = lower_file->f_op->unlocked_ioctl(lower_file, cmd, arg); |
323 | return rc; | 323 | return rc; |
324 | } | 324 | } |
@@ -332,7 +332,7 @@ ecryptfs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
332 | 332 | ||
333 | if (ecryptfs_file_to_private(file)) | 333 | if (ecryptfs_file_to_private(file)) |
334 | lower_file = ecryptfs_file_to_lower(file); | 334 | lower_file = ecryptfs_file_to_lower(file); |
335 | if (lower_file && lower_file->f_op && lower_file->f_op->compat_ioctl) | 335 | if (lower_file->f_op && lower_file->f_op->compat_ioctl) |
336 | rc = lower_file->f_op->compat_ioctl(lower_file, cmd, arg); | 336 | rc = lower_file->f_op->compat_ioctl(lower_file, cmd, arg); |
337 | return rc; | 337 | return rc; |
338 | } | 338 | } |
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index 67e9b6339691..c36c44824471 100644 --- a/fs/ecryptfs/inode.c +++ b/fs/ecryptfs/inode.c | |||
@@ -153,7 +153,7 @@ static int ecryptfs_do_unlink(struct inode *dir, struct dentry *dentry, | |||
153 | 153 | ||
154 | dget(lower_dentry); | 154 | dget(lower_dentry); |
155 | lower_dir_dentry = lock_parent(lower_dentry); | 155 | lower_dir_dentry = lock_parent(lower_dentry); |
156 | rc = vfs_unlink(lower_dir_inode, lower_dentry); | 156 | rc = vfs_unlink(lower_dir_inode, lower_dentry, NULL); |
157 | if (rc) { | 157 | if (rc) { |
158 | printk(KERN_ERR "Error in vfs_unlink; rc = [%d]\n", rc); | 158 | printk(KERN_ERR "Error in vfs_unlink; rc = [%d]\n", rc); |
159 | goto out_unlock; | 159 | goto out_unlock; |
@@ -208,7 +208,7 @@ ecryptfs_do_create(struct inode *directory_inode, | |||
208 | inode = __ecryptfs_get_inode(lower_dentry->d_inode, | 208 | inode = __ecryptfs_get_inode(lower_dentry->d_inode, |
209 | directory_inode->i_sb); | 209 | directory_inode->i_sb); |
210 | if (IS_ERR(inode)) { | 210 | if (IS_ERR(inode)) { |
211 | vfs_unlink(lower_dir_dentry->d_inode, lower_dentry); | 211 | vfs_unlink(lower_dir_dentry->d_inode, lower_dentry, NULL); |
212 | goto out_lock; | 212 | goto out_lock; |
213 | } | 213 | } |
214 | fsstack_copy_attr_times(directory_inode, lower_dir_dentry->d_inode); | 214 | fsstack_copy_attr_times(directory_inode, lower_dir_dentry->d_inode); |
@@ -361,8 +361,8 @@ static int ecryptfs_lookup_interpose(struct dentry *dentry, | |||
361 | BUG_ON(!d_count(lower_dentry)); | 361 | BUG_ON(!d_count(lower_dentry)); |
362 | 362 | ||
363 | ecryptfs_set_dentry_private(dentry, dentry_info); | 363 | ecryptfs_set_dentry_private(dentry, dentry_info); |
364 | ecryptfs_set_dentry_lower(dentry, lower_dentry); | 364 | dentry_info->lower_path.mnt = lower_mnt; |
365 | ecryptfs_set_dentry_lower_mnt(dentry, lower_mnt); | 365 | dentry_info->lower_path.dentry = lower_dentry; |
366 | 366 | ||
367 | if (!lower_dentry->d_inode) { | 367 | if (!lower_dentry->d_inode) { |
368 | /* We want to add because we couldn't find in lower */ | 368 | /* We want to add because we couldn't find in lower */ |
@@ -475,7 +475,7 @@ static int ecryptfs_link(struct dentry *old_dentry, struct inode *dir, | |||
475 | dget(lower_new_dentry); | 475 | dget(lower_new_dentry); |
476 | lower_dir_dentry = lock_parent(lower_new_dentry); | 476 | lower_dir_dentry = lock_parent(lower_new_dentry); |
477 | rc = vfs_link(lower_old_dentry, lower_dir_dentry->d_inode, | 477 | rc = vfs_link(lower_old_dentry, lower_dir_dentry->d_inode, |
478 | lower_new_dentry); | 478 | lower_new_dentry, NULL); |
479 | if (rc || !lower_new_dentry->d_inode) | 479 | if (rc || !lower_new_dentry->d_inode) |
480 | goto out_lock; | 480 | goto out_lock; |
481 | rc = ecryptfs_interpose(lower_new_dentry, new_dentry, dir->i_sb); | 481 | rc = ecryptfs_interpose(lower_new_dentry, new_dentry, dir->i_sb); |
@@ -640,7 +640,8 @@ ecryptfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
640 | goto out_lock; | 640 | goto out_lock; |
641 | } | 641 | } |
642 | rc = vfs_rename(lower_old_dir_dentry->d_inode, lower_old_dentry, | 642 | rc = vfs_rename(lower_old_dir_dentry->d_inode, lower_old_dentry, |
643 | lower_new_dir_dentry->d_inode, lower_new_dentry); | 643 | lower_new_dir_dentry->d_inode, lower_new_dentry, |
644 | NULL); | ||
644 | if (rc) | 645 | if (rc) |
645 | goto out_lock; | 646 | goto out_lock; |
646 | if (target_inode) | 647 | if (target_inode) |
@@ -703,16 +704,6 @@ out: | |||
703 | return NULL; | 704 | return NULL; |
704 | } | 705 | } |
705 | 706 | ||
706 | static void | ||
707 | ecryptfs_put_link(struct dentry *dentry, struct nameidata *nd, void *ptr) | ||
708 | { | ||
709 | char *buf = nd_get_link(nd); | ||
710 | if (!IS_ERR(buf)) { | ||
711 | /* Free the char* */ | ||
712 | kfree(buf); | ||
713 | } | ||
714 | } | ||
715 | |||
716 | /** | 707 | /** |
717 | * upper_size_to_lower_size | 708 | * upper_size_to_lower_size |
718 | * @crypt_stat: Crypt_stat associated with file | 709 | * @crypt_stat: Crypt_stat associated with file |
@@ -891,7 +882,7 @@ int ecryptfs_truncate(struct dentry *dentry, loff_t new_length) | |||
891 | struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry); | 882 | struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry); |
892 | 883 | ||
893 | mutex_lock(&lower_dentry->d_inode->i_mutex); | 884 | mutex_lock(&lower_dentry->d_inode->i_mutex); |
894 | rc = notify_change(lower_dentry, &lower_ia); | 885 | rc = notify_change(lower_dentry, &lower_ia, NULL); |
895 | mutex_unlock(&lower_dentry->d_inode->i_mutex); | 886 | mutex_unlock(&lower_dentry->d_inode->i_mutex); |
896 | } | 887 | } |
897 | return rc; | 888 | return rc; |
@@ -992,7 +983,7 @@ static int ecryptfs_setattr(struct dentry *dentry, struct iattr *ia) | |||
992 | lower_ia.ia_valid &= ~ATTR_MODE; | 983 | lower_ia.ia_valid &= ~ATTR_MODE; |
993 | 984 | ||
994 | mutex_lock(&lower_dentry->d_inode->i_mutex); | 985 | mutex_lock(&lower_dentry->d_inode->i_mutex); |
995 | rc = notify_change(lower_dentry, &lower_ia); | 986 | rc = notify_change(lower_dentry, &lower_ia, NULL); |
996 | mutex_unlock(&lower_dentry->d_inode->i_mutex); | 987 | mutex_unlock(&lower_dentry->d_inode->i_mutex); |
997 | out: | 988 | out: |
998 | fsstack_copy_attr_all(inode, lower_inode); | 989 | fsstack_copy_attr_all(inode, lower_inode); |
@@ -1121,7 +1112,7 @@ out: | |||
1121 | const struct inode_operations ecryptfs_symlink_iops = { | 1112 | const struct inode_operations ecryptfs_symlink_iops = { |
1122 | .readlink = generic_readlink, | 1113 | .readlink = generic_readlink, |
1123 | .follow_link = ecryptfs_follow_link, | 1114 | .follow_link = ecryptfs_follow_link, |
1124 | .put_link = ecryptfs_put_link, | 1115 | .put_link = kfree_put_link, |
1125 | .permission = ecryptfs_permission, | 1116 | .permission = ecryptfs_permission, |
1126 | .setattr = ecryptfs_setattr, | 1117 | .setattr = ecryptfs_setattr, |
1127 | .getattr = ecryptfs_getattr_link, | 1118 | .getattr = ecryptfs_getattr_link, |
diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index eb1c5979ecaf..1b119d3bf924 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c | |||
@@ -585,8 +585,7 @@ static struct dentry *ecryptfs_mount(struct file_system_type *fs_type, int flags | |||
585 | 585 | ||
586 | /* ->kill_sb() will take care of root_info */ | 586 | /* ->kill_sb() will take care of root_info */ |
587 | ecryptfs_set_dentry_private(s->s_root, root_info); | 587 | ecryptfs_set_dentry_private(s->s_root, root_info); |
588 | ecryptfs_set_dentry_lower(s->s_root, path.dentry); | 588 | root_info->lower_path = path; |
589 | ecryptfs_set_dentry_lower_mnt(s->s_root, path.mnt); | ||
590 | 589 | ||
591 | s->s_flags |= MS_ACTIVE; | 590 | s->s_flags |= MS_ACTIVE; |
592 | return dget(s->s_root); | 591 | return dget(s->s_root); |
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 810c28fb8c3c..983e3960abff 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c | |||
@@ -1814,7 +1814,7 @@ SYSCALL_DEFINE4(epoll_ctl, int, epfd, int, op, int, fd, | |||
1814 | 1814 | ||
1815 | /* The target file descriptor must support poll */ | 1815 | /* The target file descriptor must support poll */ |
1816 | error = -EPERM; | 1816 | error = -EPERM; |
1817 | if (!tf.file->f_op || !tf.file->f_op->poll) | 1817 | if (!tf.file->f_op->poll) |
1818 | goto error_tgt_fput; | 1818 | goto error_tgt_fput; |
1819 | 1819 | ||
1820 | /* Check if EPOLLWAKEUP is allowed */ | 1820 | /* Check if EPOLLWAKEUP is allowed */ |
@@ -106,6 +106,7 @@ static inline void put_binfmt(struct linux_binfmt * fmt) | |||
106 | */ | 106 | */ |
107 | SYSCALL_DEFINE1(uselib, const char __user *, library) | 107 | SYSCALL_DEFINE1(uselib, const char __user *, library) |
108 | { | 108 | { |
109 | struct linux_binfmt *fmt; | ||
109 | struct file *file; | 110 | struct file *file; |
110 | struct filename *tmp = getname(library); | 111 | struct filename *tmp = getname(library); |
111 | int error = PTR_ERR(tmp); | 112 | int error = PTR_ERR(tmp); |
@@ -136,24 +137,21 @@ SYSCALL_DEFINE1(uselib, const char __user *, library) | |||
136 | fsnotify_open(file); | 137 | fsnotify_open(file); |
137 | 138 | ||
138 | error = -ENOEXEC; | 139 | error = -ENOEXEC; |
139 | if(file->f_op) { | ||
140 | struct linux_binfmt * fmt; | ||
141 | 140 | ||
142 | read_lock(&binfmt_lock); | 141 | read_lock(&binfmt_lock); |
143 | list_for_each_entry(fmt, &formats, lh) { | 142 | list_for_each_entry(fmt, &formats, lh) { |
144 | if (!fmt->load_shlib) | 143 | if (!fmt->load_shlib) |
145 | continue; | 144 | continue; |
146 | if (!try_module_get(fmt->module)) | 145 | if (!try_module_get(fmt->module)) |
147 | continue; | 146 | continue; |
148 | read_unlock(&binfmt_lock); | ||
149 | error = fmt->load_shlib(file); | ||
150 | read_lock(&binfmt_lock); | ||
151 | put_binfmt(fmt); | ||
152 | if (error != -ENOEXEC) | ||
153 | break; | ||
154 | } | ||
155 | read_unlock(&binfmt_lock); | 147 | read_unlock(&binfmt_lock); |
148 | error = fmt->load_shlib(file); | ||
149 | read_lock(&binfmt_lock); | ||
150 | put_binfmt(fmt); | ||
151 | if (error != -ENOEXEC) | ||
152 | break; | ||
156 | } | 153 | } |
154 | read_unlock(&binfmt_lock); | ||
157 | exit: | 155 | exit: |
158 | fput(file); | 156 | fput(file); |
159 | out: | 157 | out: |
@@ -1277,13 +1275,10 @@ static int check_unsafe_exec(struct linux_binprm *bprm) | |||
1277 | */ | 1275 | */ |
1278 | int prepare_binprm(struct linux_binprm *bprm) | 1276 | int prepare_binprm(struct linux_binprm *bprm) |
1279 | { | 1277 | { |
1280 | umode_t mode; | 1278 | struct inode *inode = file_inode(bprm->file); |
1281 | struct inode * inode = file_inode(bprm->file); | 1279 | umode_t mode = inode->i_mode; |
1282 | int retval; | 1280 | int retval; |
1283 | 1281 | ||
1284 | mode = inode->i_mode; | ||
1285 | if (bprm->file->f_op == NULL) | ||
1286 | return -EACCES; | ||
1287 | 1282 | ||
1288 | /* clear any previous set[ug]id data from a previous binary */ | 1283 | /* clear any previous set[ug]id data from a previous binary */ |
1289 | bprm->cred->euid = current_euid(); | 1284 | bprm->cred->euid = current_euid(); |
diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index a235f0016889..48a359dd286e 100644 --- a/fs/exportfs/expfs.c +++ b/fs/exportfs/expfs.c | |||
@@ -69,145 +69,162 @@ find_acceptable_alias(struct dentry *result, | |||
69 | return NULL; | 69 | return NULL; |
70 | } | 70 | } |
71 | 71 | ||
72 | /* | 72 | static bool dentry_connected(struct dentry *dentry) |
73 | * Find root of a disconnected subtree and return a reference to it. | ||
74 | */ | ||
75 | static struct dentry * | ||
76 | find_disconnected_root(struct dentry *dentry) | ||
77 | { | 73 | { |
78 | dget(dentry); | 74 | dget(dentry); |
79 | while (!IS_ROOT(dentry)) { | 75 | while (dentry->d_flags & DCACHE_DISCONNECTED) { |
80 | struct dentry *parent = dget_parent(dentry); | 76 | struct dentry *parent = dget_parent(dentry); |
81 | 77 | ||
82 | if (!(parent->d_flags & DCACHE_DISCONNECTED)) { | 78 | dput(dentry); |
79 | if (IS_ROOT(dentry)) { | ||
83 | dput(parent); | 80 | dput(parent); |
84 | break; | 81 | return false; |
85 | } | 82 | } |
83 | dentry = parent; | ||
84 | } | ||
85 | dput(dentry); | ||
86 | return true; | ||
87 | } | ||
88 | |||
89 | static void clear_disconnected(struct dentry *dentry) | ||
90 | { | ||
91 | dget(dentry); | ||
92 | while (dentry->d_flags & DCACHE_DISCONNECTED) { | ||
93 | struct dentry *parent = dget_parent(dentry); | ||
94 | |||
95 | WARN_ON_ONCE(IS_ROOT(dentry)); | ||
96 | |||
97 | spin_lock(&dentry->d_lock); | ||
98 | dentry->d_flags &= ~DCACHE_DISCONNECTED; | ||
99 | spin_unlock(&dentry->d_lock); | ||
86 | 100 | ||
87 | dput(dentry); | 101 | dput(dentry); |
88 | dentry = parent; | 102 | dentry = parent; |
89 | } | 103 | } |
90 | return dentry; | 104 | dput(dentry); |
105 | } | ||
106 | |||
107 | /* | ||
108 | * Reconnect a directory dentry with its parent. | ||
109 | * | ||
110 | * This can return a dentry, or NULL, or an error. | ||
111 | * | ||
112 | * In the first case the returned dentry is the parent of the given | ||
113 | * dentry, and may itself need to be reconnected to its parent. | ||
114 | * | ||
115 | * In the NULL case, a concurrent VFS operation has either renamed or | ||
116 | * removed this directory. The concurrent operation has reconnected our | ||
117 | * dentry, so we no longer need to. | ||
118 | */ | ||
119 | static struct dentry *reconnect_one(struct vfsmount *mnt, | ||
120 | struct dentry *dentry, char *nbuf) | ||
121 | { | ||
122 | struct dentry *parent; | ||
123 | struct dentry *tmp; | ||
124 | int err; | ||
125 | |||
126 | parent = ERR_PTR(-EACCES); | ||
127 | mutex_lock(&dentry->d_inode->i_mutex); | ||
128 | if (mnt->mnt_sb->s_export_op->get_parent) | ||
129 | parent = mnt->mnt_sb->s_export_op->get_parent(dentry); | ||
130 | mutex_unlock(&dentry->d_inode->i_mutex); | ||
131 | |||
132 | if (IS_ERR(parent)) { | ||
133 | dprintk("%s: get_parent of %ld failed, err %d\n", | ||
134 | __func__, dentry->d_inode->i_ino, PTR_ERR(parent)); | ||
135 | return parent; | ||
136 | } | ||
137 | |||
138 | dprintk("%s: find name of %lu in %lu\n", __func__, | ||
139 | dentry->d_inode->i_ino, parent->d_inode->i_ino); | ||
140 | err = exportfs_get_name(mnt, parent, nbuf, dentry); | ||
141 | if (err == -ENOENT) | ||
142 | goto out_reconnected; | ||
143 | if (err) | ||
144 | goto out_err; | ||
145 | dprintk("%s: found name: %s\n", __func__, nbuf); | ||
146 | mutex_lock(&parent->d_inode->i_mutex); | ||
147 | tmp = lookup_one_len(nbuf, parent, strlen(nbuf)); | ||
148 | mutex_unlock(&parent->d_inode->i_mutex); | ||
149 | if (IS_ERR(tmp)) { | ||
150 | dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp)); | ||
151 | goto out_err; | ||
152 | } | ||
153 | if (tmp != dentry) { | ||
154 | dput(tmp); | ||
155 | goto out_reconnected; | ||
156 | } | ||
157 | dput(tmp); | ||
158 | if (IS_ROOT(dentry)) { | ||
159 | err = -ESTALE; | ||
160 | goto out_err; | ||
161 | } | ||
162 | return parent; | ||
163 | |||
164 | out_err: | ||
165 | dput(parent); | ||
166 | return ERR_PTR(err); | ||
167 | out_reconnected: | ||
168 | dput(parent); | ||
169 | /* | ||
170 | * Someone must have renamed our entry into another parent, in | ||
171 | * which case it has been reconnected by the rename. | ||
172 | * | ||
173 | * Or someone removed it entirely, in which case filehandle | ||
174 | * lookup will succeed but the directory is now IS_DEAD and | ||
175 | * subsequent operations on it will fail. | ||
176 | * | ||
177 | * Alternatively, maybe there was no race at all, and the | ||
178 | * filesystem is just corrupt and gave us a parent that doesn't | ||
179 | * actually contain any entry pointing to this inode. So, | ||
180 | * double check that this worked and return -ESTALE if not: | ||
181 | */ | ||
182 | if (!dentry_connected(dentry)) | ||
183 | return ERR_PTR(-ESTALE); | ||
184 | return NULL; | ||
91 | } | 185 | } |
92 | 186 | ||
93 | /* | 187 | /* |
94 | * Make sure target_dir is fully connected to the dentry tree. | 188 | * Make sure target_dir is fully connected to the dentry tree. |
95 | * | 189 | * |
96 | * It may already be, as the flag isn't always updated when connection happens. | 190 | * On successful return, DCACHE_DISCONNECTED will be cleared on |
191 | * target_dir, and target_dir->d_parent->...->d_parent will reach the | ||
192 | * root of the filesystem. | ||
193 | * | ||
194 | * Whenever DCACHE_DISCONNECTED is unset, target_dir is fully connected. | ||
195 | * But the converse is not true: target_dir may have DCACHE_DISCONNECTED | ||
196 | * set but already be connected. In that case we'll verify the | ||
197 | * connection to root and then clear the flag. | ||
198 | * | ||
199 | * Note that target_dir could be removed by a concurrent operation. In | ||
200 | * that case reconnect_path may still succeed with target_dir fully | ||
201 | * connected, but further operations using the filehandle will fail when | ||
202 | * necessary (due to S_DEAD being set on the directory). | ||
97 | */ | 203 | */ |
98 | static int | 204 | static int |
99 | reconnect_path(struct vfsmount *mnt, struct dentry *target_dir, char *nbuf) | 205 | reconnect_path(struct vfsmount *mnt, struct dentry *target_dir, char *nbuf) |
100 | { | 206 | { |
101 | int noprogress = 0; | 207 | struct dentry *dentry, *parent; |
102 | int err = -ESTALE; | ||
103 | 208 | ||
104 | /* | 209 | dentry = dget(target_dir); |
105 | * It is possible that a confused file system might not let us complete | ||
106 | * the path to the root. For example, if get_parent returns a directory | ||
107 | * in which we cannot find a name for the child. While this implies a | ||
108 | * very sick filesystem we don't want it to cause knfsd to spin. Hence | ||
109 | * the noprogress counter. If we go through the loop 10 times (2 is | ||
110 | * probably enough) without getting anywhere, we just give up | ||
111 | */ | ||
112 | while (target_dir->d_flags & DCACHE_DISCONNECTED && noprogress++ < 10) { | ||
113 | struct dentry *pd = find_disconnected_root(target_dir); | ||
114 | |||
115 | if (!IS_ROOT(pd)) { | ||
116 | /* must have found a connected parent - great */ | ||
117 | spin_lock(&pd->d_lock); | ||
118 | pd->d_flags &= ~DCACHE_DISCONNECTED; | ||
119 | spin_unlock(&pd->d_lock); | ||
120 | noprogress = 0; | ||
121 | } else if (pd == mnt->mnt_sb->s_root) { | ||
122 | printk(KERN_ERR "export: Eeek filesystem root is not connected, impossible\n"); | ||
123 | spin_lock(&pd->d_lock); | ||
124 | pd->d_flags &= ~DCACHE_DISCONNECTED; | ||
125 | spin_unlock(&pd->d_lock); | ||
126 | noprogress = 0; | ||
127 | } else { | ||
128 | /* | ||
129 | * We have hit the top of a disconnected path, try to | ||
130 | * find parent and connect. | ||
131 | * | ||
132 | * Racing with some other process renaming a directory | ||
133 | * isn't much of a problem here. If someone renames | ||
134 | * the directory, it will end up properly connected, | ||
135 | * which is what we want | ||
136 | * | ||
137 | * Getting the parent can't be supported generically, | ||
138 | * the locking is too icky. | ||
139 | * | ||
140 | * Instead we just return EACCES. If server reboots | ||
141 | * or inodes get flushed, you lose | ||
142 | */ | ||
143 | struct dentry *ppd = ERR_PTR(-EACCES); | ||
144 | struct dentry *npd; | ||
145 | |||
146 | mutex_lock(&pd->d_inode->i_mutex); | ||
147 | if (mnt->mnt_sb->s_export_op->get_parent) | ||
148 | ppd = mnt->mnt_sb->s_export_op->get_parent(pd); | ||
149 | mutex_unlock(&pd->d_inode->i_mutex); | ||
150 | |||
151 | if (IS_ERR(ppd)) { | ||
152 | err = PTR_ERR(ppd); | ||
153 | dprintk("%s: get_parent of %ld failed, err %d\n", | ||
154 | __func__, pd->d_inode->i_ino, err); | ||
155 | dput(pd); | ||
156 | break; | ||
157 | } | ||
158 | 210 | ||
159 | dprintk("%s: find name of %lu in %lu\n", __func__, | 211 | while (dentry->d_flags & DCACHE_DISCONNECTED) { |
160 | pd->d_inode->i_ino, ppd->d_inode->i_ino); | 212 | BUG_ON(dentry == mnt->mnt_sb->s_root); |
161 | err = exportfs_get_name(mnt, ppd, nbuf, pd); | ||
162 | if (err) { | ||
163 | dput(ppd); | ||
164 | dput(pd); | ||
165 | if (err == -ENOENT) | ||
166 | /* some race between get_parent and | ||
167 | * get_name? just try again | ||
168 | */ | ||
169 | continue; | ||
170 | break; | ||
171 | } | ||
172 | dprintk("%s: found name: %s\n", __func__, nbuf); | ||
173 | mutex_lock(&ppd->d_inode->i_mutex); | ||
174 | npd = lookup_one_len(nbuf, ppd, strlen(nbuf)); | ||
175 | mutex_unlock(&ppd->d_inode->i_mutex); | ||
176 | if (IS_ERR(npd)) { | ||
177 | err = PTR_ERR(npd); | ||
178 | dprintk("%s: lookup failed: %d\n", | ||
179 | __func__, err); | ||
180 | dput(ppd); | ||
181 | dput(pd); | ||
182 | break; | ||
183 | } | ||
184 | /* we didn't really want npd, we really wanted | ||
185 | * a side-effect of the lookup. | ||
186 | * hopefully, npd == pd, though it isn't really | ||
187 | * a problem if it isn't | ||
188 | */ | ||
189 | if (npd == pd) | ||
190 | noprogress = 0; | ||
191 | else | ||
192 | printk("%s: npd != pd\n", __func__); | ||
193 | dput(npd); | ||
194 | dput(ppd); | ||
195 | if (IS_ROOT(pd)) { | ||
196 | /* something went wrong, we have to give up */ | ||
197 | dput(pd); | ||
198 | break; | ||
199 | } | ||
200 | } | ||
201 | dput(pd); | ||
202 | } | ||
203 | 213 | ||
204 | if (target_dir->d_flags & DCACHE_DISCONNECTED) { | 214 | if (IS_ROOT(dentry)) |
205 | /* something went wrong - oh-well */ | 215 | parent = reconnect_one(mnt, dentry, nbuf); |
206 | if (!err) | 216 | else |
207 | err = -ESTALE; | 217 | parent = dget_parent(dentry); |
208 | return err; | ||
209 | } | ||
210 | 218 | ||
219 | if (!parent) | ||
220 | break; | ||
221 | dput(dentry); | ||
222 | if (IS_ERR(parent)) | ||
223 | return PTR_ERR(parent); | ||
224 | dentry = parent; | ||
225 | } | ||
226 | dput(dentry); | ||
227 | clear_disconnected(target_dir); | ||
211 | return 0; | 228 | return 0; |
212 | } | 229 | } |
213 | 230 | ||
@@ -215,7 +232,7 @@ struct getdents_callback { | |||
215 | struct dir_context ctx; | 232 | struct dir_context ctx; |
216 | char *name; /* name that was found. It already points to a | 233 | char *name; /* name that was found. It already points to a |
217 | buffer NAME_MAX+1 is size */ | 234 | buffer NAME_MAX+1 is size */ |
218 | unsigned long ino; /* the inum we are looking for */ | 235 | u64 ino; /* the inum we are looking for */ |
219 | int found; /* inode matched? */ | 236 | int found; /* inode matched? */ |
220 | int sequence; /* sequence counter */ | 237 | int sequence; /* sequence counter */ |
221 | }; | 238 | }; |
@@ -255,10 +272,14 @@ static int get_name(const struct path *path, char *name, struct dentry *child) | |||
255 | struct inode *dir = path->dentry->d_inode; | 272 | struct inode *dir = path->dentry->d_inode; |
256 | int error; | 273 | int error; |
257 | struct file *file; | 274 | struct file *file; |
275 | struct kstat stat; | ||
276 | struct path child_path = { | ||
277 | .mnt = path->mnt, | ||
278 | .dentry = child, | ||
279 | }; | ||
258 | struct getdents_callback buffer = { | 280 | struct getdents_callback buffer = { |
259 | .ctx.actor = filldir_one, | 281 | .ctx.actor = filldir_one, |
260 | .name = name, | 282 | .name = name, |
261 | .ino = child->d_inode->i_ino | ||
262 | }; | 283 | }; |
263 | 284 | ||
264 | error = -ENOTDIR; | 285 | error = -ENOTDIR; |
@@ -268,6 +289,16 @@ static int get_name(const struct path *path, char *name, struct dentry *child) | |||
268 | if (!dir->i_fop) | 289 | if (!dir->i_fop) |
269 | goto out; | 290 | goto out; |
270 | /* | 291 | /* |
292 | * inode->i_ino is unsigned long, kstat->ino is u64, so the | ||
293 | * former would be insufficient on 32-bit hosts when the | ||
294 | * filesystem supports 64-bit inode numbers. So we need to | ||
295 | * actually call ->getattr, not just read i_ino: | ||
296 | */ | ||
297 | error = vfs_getattr_nosec(&child_path, &stat); | ||
298 | if (error) | ||
299 | return error; | ||
300 | buffer.ino = stat.ino; | ||
301 | /* | ||
271 | * Open the directory ... | 302 | * Open the directory ... |
272 | */ | 303 | */ |
273 | file = dentry_open(path, O_RDONLY, cred); | 304 | file = dentry_open(path, O_RDONLY, cred); |
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index af815ea9d7cc..d01d62315f7e 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
@@ -2734,8 +2734,6 @@ extern void ext4_double_down_write_data_sem(struct inode *first, | |||
2734 | struct inode *second); | 2734 | struct inode *second); |
2735 | extern void ext4_double_up_write_data_sem(struct inode *orig_inode, | 2735 | extern void ext4_double_up_write_data_sem(struct inode *orig_inode, |
2736 | struct inode *donor_inode); | 2736 | struct inode *donor_inode); |
2737 | void ext4_inode_double_lock(struct inode *inode1, struct inode *inode2); | ||
2738 | void ext4_inode_double_unlock(struct inode *inode1, struct inode *inode2); | ||
2739 | extern int ext4_move_extents(struct file *o_filp, struct file *d_filp, | 2737 | extern int ext4_move_extents(struct file *o_filp, struct file *d_filp, |
2740 | __u64 start_orig, __u64 start_donor, | 2738 | __u64 start_orig, __u64 start_donor, |
2741 | __u64 len, __u64 *moved_len); | 2739 | __u64 len, __u64 *moved_len); |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index a569d335f804..60589b60e9b0 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
@@ -130,7 +130,7 @@ static long swap_inode_boot_loader(struct super_block *sb, | |||
130 | 130 | ||
131 | /* Protect orig inodes against a truncate and make sure, | 131 | /* Protect orig inodes against a truncate and make sure, |
132 | * that only 1 swap_inode_boot_loader is running. */ | 132 | * that only 1 swap_inode_boot_loader is running. */ |
133 | ext4_inode_double_lock(inode, inode_bl); | 133 | lock_two_nondirectories(inode, inode_bl); |
134 | 134 | ||
135 | truncate_inode_pages(&inode->i_data, 0); | 135 | truncate_inode_pages(&inode->i_data, 0); |
136 | truncate_inode_pages(&inode_bl->i_data, 0); | 136 | truncate_inode_pages(&inode_bl->i_data, 0); |
@@ -205,7 +205,7 @@ static long swap_inode_boot_loader(struct super_block *sb, | |||
205 | ext4_inode_resume_unlocked_dio(inode); | 205 | ext4_inode_resume_unlocked_dio(inode); |
206 | ext4_inode_resume_unlocked_dio(inode_bl); | 206 | ext4_inode_resume_unlocked_dio(inode_bl); |
207 | 207 | ||
208 | ext4_inode_double_unlock(inode, inode_bl); | 208 | unlock_two_nondirectories(inode, inode_bl); |
209 | 209 | ||
210 | iput(inode_bl); | 210 | iput(inode_bl); |
211 | 211 | ||
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 7fa4d855dbd5..773b503bd18c 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c | |||
@@ -1203,42 +1203,6 @@ mext_check_arguments(struct inode *orig_inode, | |||
1203 | } | 1203 | } |
1204 | 1204 | ||
1205 | /** | 1205 | /** |
1206 | * ext4_inode_double_lock - Lock i_mutex on both @inode1 and @inode2 | ||
1207 | * | ||
1208 | * @inode1: the inode structure | ||
1209 | * @inode2: the inode structure | ||
1210 | * | ||
1211 | * Lock two inodes' i_mutex | ||
1212 | */ | ||
1213 | void | ||
1214 | ext4_inode_double_lock(struct inode *inode1, struct inode *inode2) | ||
1215 | { | ||
1216 | BUG_ON(inode1 == inode2); | ||
1217 | if (inode1 < inode2) { | ||
1218 | mutex_lock_nested(&inode1->i_mutex, I_MUTEX_PARENT); | ||
1219 | mutex_lock_nested(&inode2->i_mutex, I_MUTEX_CHILD); | ||
1220 | } else { | ||
1221 | mutex_lock_nested(&inode2->i_mutex, I_MUTEX_PARENT); | ||
1222 | mutex_lock_nested(&inode1->i_mutex, I_MUTEX_CHILD); | ||
1223 | } | ||
1224 | } | ||
1225 | |||
1226 | /** | ||
1227 | * ext4_inode_double_unlock - Release i_mutex on both @inode1 and @inode2 | ||
1228 | * | ||
1229 | * @inode1: the inode that is released first | ||
1230 | * @inode2: the inode that is released second | ||
1231 | * | ||
1232 | */ | ||
1233 | |||
1234 | void | ||
1235 | ext4_inode_double_unlock(struct inode *inode1, struct inode *inode2) | ||
1236 | { | ||
1237 | mutex_unlock(&inode1->i_mutex); | ||
1238 | mutex_unlock(&inode2->i_mutex); | ||
1239 | } | ||
1240 | |||
1241 | /** | ||
1242 | * ext4_move_extents - Exchange the specified range of a file | 1206 | * ext4_move_extents - Exchange the specified range of a file |
1243 | * | 1207 | * |
1244 | * @o_filp: file structure of the original file | 1208 | * @o_filp: file structure of the original file |
@@ -1327,7 +1291,7 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1327 | return -EINVAL; | 1291 | return -EINVAL; |
1328 | } | 1292 | } |
1329 | /* Protect orig and donor inodes against a truncate */ | 1293 | /* Protect orig and donor inodes against a truncate */ |
1330 | ext4_inode_double_lock(orig_inode, donor_inode); | 1294 | lock_two_nondirectories(orig_inode, donor_inode); |
1331 | 1295 | ||
1332 | /* Wait for all existing dio workers */ | 1296 | /* Wait for all existing dio workers */ |
1333 | ext4_inode_block_unlocked_dio(orig_inode); | 1297 | ext4_inode_block_unlocked_dio(orig_inode); |
@@ -1535,7 +1499,7 @@ out: | |||
1535 | ext4_double_up_write_data_sem(orig_inode, donor_inode); | 1499 | ext4_double_up_write_data_sem(orig_inode, donor_inode); |
1536 | ext4_inode_resume_unlocked_dio(orig_inode); | 1500 | ext4_inode_resume_unlocked_dio(orig_inode); |
1537 | ext4_inode_resume_unlocked_dio(donor_inode); | 1501 | ext4_inode_resume_unlocked_dio(donor_inode); |
1538 | ext4_inode_double_unlock(orig_inode, donor_inode); | 1502 | unlock_two_nondirectories(orig_inode, donor_inode); |
1539 | 1503 | ||
1540 | return ret; | 1504 | return ret; |
1541 | } | 1505 | } |
diff --git a/fs/fat/fat.h b/fs/fat/fat.h index 4241e6f39e86..7c31f4bc74a9 100644 --- a/fs/fat/fat.h +++ b/fs/fat/fat.h | |||
@@ -102,6 +102,7 @@ struct msdos_sb_info { | |||
102 | struct hlist_head dir_hashtable[FAT_HASH_SIZE]; | 102 | struct hlist_head dir_hashtable[FAT_HASH_SIZE]; |
103 | 103 | ||
104 | unsigned int dirty; /* fs state before mount */ | 104 | unsigned int dirty; /* fs state before mount */ |
105 | struct rcu_head rcu; | ||
105 | }; | 106 | }; |
106 | 107 | ||
107 | #define FAT_CACHE_VALID 0 /* special case for valid cache */ | 108 | #define FAT_CACHE_VALID 0 /* special case for valid cache */ |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 0062da21dd8b..854b578f6695 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -548,6 +548,16 @@ static void fat_set_state(struct super_block *sb, | |||
548 | brelse(bh); | 548 | brelse(bh); |
549 | } | 549 | } |
550 | 550 | ||
551 | static void delayed_free(struct rcu_head *p) | ||
552 | { | ||
553 | struct msdos_sb_info *sbi = container_of(p, struct msdos_sb_info, rcu); | ||
554 | unload_nls(sbi->nls_disk); | ||
555 | unload_nls(sbi->nls_io); | ||
556 | if (sbi->options.iocharset != fat_default_iocharset) | ||
557 | kfree(sbi->options.iocharset); | ||
558 | kfree(sbi); | ||
559 | } | ||
560 | |||
551 | static void fat_put_super(struct super_block *sb) | 561 | static void fat_put_super(struct super_block *sb) |
552 | { | 562 | { |
553 | struct msdos_sb_info *sbi = MSDOS_SB(sb); | 563 | struct msdos_sb_info *sbi = MSDOS_SB(sb); |
@@ -557,14 +567,7 @@ static void fat_put_super(struct super_block *sb) | |||
557 | iput(sbi->fsinfo_inode); | 567 | iput(sbi->fsinfo_inode); |
558 | iput(sbi->fat_inode); | 568 | iput(sbi->fat_inode); |
559 | 569 | ||
560 | unload_nls(sbi->nls_disk); | 570 | call_rcu(&sbi->rcu, delayed_free); |
561 | unload_nls(sbi->nls_io); | ||
562 | |||
563 | if (sbi->options.iocharset != fat_default_iocharset) | ||
564 | kfree(sbi->options.iocharset); | ||
565 | |||
566 | sb->s_fs_info = NULL; | ||
567 | kfree(sbi); | ||
568 | } | 571 | } |
569 | 572 | ||
570 | static struct kmem_cache *fat_inode_cachep; | 573 | static struct kmem_cache *fat_inode_cachep; |
diff --git a/fs/fcntl.c b/fs/fcntl.c index 65343c3741ff..ef6866592a0f 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c | |||
@@ -56,7 +56,7 @@ static int setfl(int fd, struct file * filp, unsigned long arg) | |||
56 | return -EINVAL; | 56 | return -EINVAL; |
57 | } | 57 | } |
58 | 58 | ||
59 | if (filp->f_op && filp->f_op->check_flags) | 59 | if (filp->f_op->check_flags) |
60 | error = filp->f_op->check_flags(arg); | 60 | error = filp->f_op->check_flags(arg); |
61 | if (error) | 61 | if (error) |
62 | return error; | 62 | return error; |
@@ -64,8 +64,7 @@ static int setfl(int fd, struct file * filp, unsigned long arg) | |||
64 | /* | 64 | /* |
65 | * ->fasync() is responsible for setting the FASYNC bit. | 65 | * ->fasync() is responsible for setting the FASYNC bit. |
66 | */ | 66 | */ |
67 | if (((arg ^ filp->f_flags) & FASYNC) && filp->f_op && | 67 | if (((arg ^ filp->f_flags) & FASYNC) && filp->f_op->fasync) { |
68 | filp->f_op->fasync) { | ||
69 | error = filp->f_op->fasync(fd, filp, (arg & FASYNC) != 0); | 68 | error = filp->f_op->fasync(fd, filp, (arg & FASYNC) != 0); |
70 | if (error < 0) | 69 | if (error < 0) |
71 | goto out; | 70 | goto out; |
diff --git a/fs/file_table.c b/fs/file_table.c index e900ca518635..5fff9030be34 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
@@ -36,8 +36,6 @@ struct files_stat_struct files_stat = { | |||
36 | .max_files = NR_FILE | 36 | .max_files = NR_FILE |
37 | }; | 37 | }; |
38 | 38 | ||
39 | DEFINE_STATIC_LGLOCK(files_lglock); | ||
40 | |||
41 | /* SLAB cache for file structures */ | 39 | /* SLAB cache for file structures */ |
42 | static struct kmem_cache *filp_cachep __read_mostly; | 40 | static struct kmem_cache *filp_cachep __read_mostly; |
43 | 41 | ||
@@ -134,7 +132,6 @@ struct file *get_empty_filp(void) | |||
134 | return ERR_PTR(error); | 132 | return ERR_PTR(error); |
135 | } | 133 | } |
136 | 134 | ||
137 | INIT_LIST_HEAD(&f->f_u.fu_list); | ||
138 | atomic_long_set(&f->f_count, 1); | 135 | atomic_long_set(&f->f_count, 1); |
139 | rwlock_init(&f->f_owner.lock); | 136 | rwlock_init(&f->f_owner.lock); |
140 | spin_lock_init(&f->f_lock); | 137 | spin_lock_init(&f->f_lock); |
@@ -240,11 +237,11 @@ static void __fput(struct file *file) | |||
240 | locks_remove_flock(file); | 237 | locks_remove_flock(file); |
241 | 238 | ||
242 | if (unlikely(file->f_flags & FASYNC)) { | 239 | if (unlikely(file->f_flags & FASYNC)) { |
243 | if (file->f_op && file->f_op->fasync) | 240 | if (file->f_op->fasync) |
244 | file->f_op->fasync(-1, file, 0); | 241 | file->f_op->fasync(-1, file, 0); |
245 | } | 242 | } |
246 | ima_file_free(file); | 243 | ima_file_free(file); |
247 | if (file->f_op && file->f_op->release) | 244 | if (file->f_op->release) |
248 | file->f_op->release(inode, file); | 245 | file->f_op->release(inode, file); |
249 | security_file_free(file); | 246 | security_file_free(file); |
250 | if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL && | 247 | if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL && |
@@ -304,7 +301,6 @@ void fput(struct file *file) | |||
304 | if (atomic_long_dec_and_test(&file->f_count)) { | 301 | if (atomic_long_dec_and_test(&file->f_count)) { |
305 | struct task_struct *task = current; | 302 | struct task_struct *task = current; |
306 | 303 | ||
307 | file_sb_list_del(file); | ||
308 | if (likely(!in_interrupt() && !(task->flags & PF_KTHREAD))) { | 304 | if (likely(!in_interrupt() && !(task->flags & PF_KTHREAD))) { |
309 | init_task_work(&file->f_u.fu_rcuhead, ____fput); | 305 | init_task_work(&file->f_u.fu_rcuhead, ____fput); |
310 | if (!task_work_add(task, &file->f_u.fu_rcuhead, true)) | 306 | if (!task_work_add(task, &file->f_u.fu_rcuhead, true)) |
@@ -333,7 +329,6 @@ void __fput_sync(struct file *file) | |||
333 | { | 329 | { |
334 | if (atomic_long_dec_and_test(&file->f_count)) { | 330 | if (atomic_long_dec_and_test(&file->f_count)) { |
335 | struct task_struct *task = current; | 331 | struct task_struct *task = current; |
336 | file_sb_list_del(file); | ||
337 | BUG_ON(!(task->flags & PF_KTHREAD)); | 332 | BUG_ON(!(task->flags & PF_KTHREAD)); |
338 | __fput(file); | 333 | __fput(file); |
339 | } | 334 | } |
@@ -345,129 +340,10 @@ void put_filp(struct file *file) | |||
345 | { | 340 | { |
346 | if (atomic_long_dec_and_test(&file->f_count)) { | 341 | if (atomic_long_dec_and_test(&file->f_count)) { |
347 | security_file_free(file); | 342 | security_file_free(file); |
348 | file_sb_list_del(file); | ||
349 | file_free(file); | 343 | file_free(file); |
350 | } | 344 | } |
351 | } | 345 | } |
352 | 346 | ||
353 | static inline int file_list_cpu(struct file *file) | ||
354 | { | ||
355 | #ifdef CONFIG_SMP | ||
356 | return file->f_sb_list_cpu; | ||
357 | #else | ||
358 | return smp_processor_id(); | ||
359 | #endif | ||
360 | } | ||
361 | |||
362 | /* helper for file_sb_list_add to reduce ifdefs */ | ||
363 | static inline void __file_sb_list_add(struct file *file, struct super_block *sb) | ||
364 | { | ||
365 | struct list_head *list; | ||
366 | #ifdef CONFIG_SMP | ||
367 | int cpu; | ||
368 | cpu = smp_processor_id(); | ||
369 | file->f_sb_list_cpu = cpu; | ||
370 | list = per_cpu_ptr(sb->s_files, cpu); | ||
371 | #else | ||
372 | list = &sb->s_files; | ||
373 | #endif | ||
374 | list_add(&file->f_u.fu_list, list); | ||
375 | } | ||
376 | |||
377 | /** | ||
378 | * file_sb_list_add - add a file to the sb's file list | ||
379 | * @file: file to add | ||
380 | * @sb: sb to add it to | ||
381 | * | ||
382 | * Use this function to associate a file with the superblock of the inode it | ||
383 | * refers to. | ||
384 | */ | ||
385 | void file_sb_list_add(struct file *file, struct super_block *sb) | ||
386 | { | ||
387 | if (likely(!(file->f_mode & FMODE_WRITE))) | ||
388 | return; | ||
389 | if (!S_ISREG(file_inode(file)->i_mode)) | ||
390 | return; | ||
391 | lg_local_lock(&files_lglock); | ||
392 | __file_sb_list_add(file, sb); | ||
393 | lg_local_unlock(&files_lglock); | ||
394 | } | ||
395 | |||
396 | /** | ||
397 | * file_sb_list_del - remove a file from the sb's file list | ||
398 | * @file: file to remove | ||
399 | * @sb: sb to remove it from | ||
400 | * | ||
401 | * Use this function to remove a file from its superblock. | ||
402 | */ | ||
403 | void file_sb_list_del(struct file *file) | ||
404 | { | ||
405 | if (!list_empty(&file->f_u.fu_list)) { | ||
406 | lg_local_lock_cpu(&files_lglock, file_list_cpu(file)); | ||
407 | list_del_init(&file->f_u.fu_list); | ||
408 | lg_local_unlock_cpu(&files_lglock, file_list_cpu(file)); | ||
409 | } | ||
410 | } | ||
411 | |||
412 | #ifdef CONFIG_SMP | ||
413 | |||
414 | /* | ||
415 | * These macros iterate all files on all CPUs for a given superblock. | ||
416 | * files_lglock must be held globally. | ||
417 | */ | ||
418 | #define do_file_list_for_each_entry(__sb, __file) \ | ||
419 | { \ | ||
420 | int i; \ | ||
421 | for_each_possible_cpu(i) { \ | ||
422 | struct list_head *list; \ | ||
423 | list = per_cpu_ptr((__sb)->s_files, i); \ | ||
424 | list_for_each_entry((__file), list, f_u.fu_list) | ||
425 | |||
426 | #define while_file_list_for_each_entry \ | ||
427 | } \ | ||
428 | } | ||
429 | |||
430 | #else | ||
431 | |||
432 | #define do_file_list_for_each_entry(__sb, __file) \ | ||
433 | { \ | ||
434 | struct list_head *list; \ | ||
435 | list = &(sb)->s_files; \ | ||
436 | list_for_each_entry((__file), list, f_u.fu_list) | ||
437 | |||
438 | #define while_file_list_for_each_entry \ | ||
439 | } | ||
440 | |||
441 | #endif | ||
442 | |||
443 | /** | ||
444 | * mark_files_ro - mark all files read-only | ||
445 | * @sb: superblock in question | ||
446 | * | ||
447 | * All files are marked read-only. We don't care about pending | ||
448 | * delete files so this should be used in 'force' mode only. | ||
449 | */ | ||
450 | void mark_files_ro(struct super_block *sb) | ||
451 | { | ||
452 | struct file *f; | ||
453 | |||
454 | lg_global_lock(&files_lglock); | ||
455 | do_file_list_for_each_entry(sb, f) { | ||
456 | if (!file_count(f)) | ||
457 | continue; | ||
458 | if (!(f->f_mode & FMODE_WRITE)) | ||
459 | continue; | ||
460 | spin_lock(&f->f_lock); | ||
461 | f->f_mode &= ~FMODE_WRITE; | ||
462 | spin_unlock(&f->f_lock); | ||
463 | if (file_check_writeable(f) != 0) | ||
464 | continue; | ||
465 | __mnt_drop_write(f->f_path.mnt); | ||
466 | file_release_write(f); | ||
467 | } while_file_list_for_each_entry; | ||
468 | lg_global_unlock(&files_lglock); | ||
469 | } | ||
470 | |||
471 | void __init files_init(unsigned long mempages) | 347 | void __init files_init(unsigned long mempages) |
472 | { | 348 | { |
473 | unsigned long n; | 349 | unsigned long n; |
@@ -483,6 +359,5 @@ void __init files_init(unsigned long mempages) | |||
483 | n = (mempages * (PAGE_SIZE / 1024)) / 10; | 359 | n = (mempages * (PAGE_SIZE / 1024)) / 10; |
484 | files_stat.max_files = max_t(unsigned long, n, NR_FILE); | 360 | files_stat.max_files = max_t(unsigned long, n, NR_FILE); |
485 | files_defer_init(); | 361 | files_defer_init(); |
486 | lg_lock_init(&files_lglock, "files_lglock"); | ||
487 | percpu_counter_init(&nr_files, 0); | 362 | percpu_counter_init(&nr_files, 0); |
488 | } | 363 | } |
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 9f4935b8f208..09c11329a17c 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include <linux/blkdev.h> | 26 | #include <linux/blkdev.h> |
27 | #include <linux/backing-dev.h> | 27 | #include <linux/backing-dev.h> |
28 | #include <linux/tracepoint.h> | 28 | #include <linux/tracepoint.h> |
29 | #include <linux/device.h> | ||
29 | #include "internal.h" | 30 | #include "internal.h" |
30 | 31 | ||
31 | /* | 32 | /* |
diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c index 24da581cb52b..b96a49b37d66 100644 --- a/fs/fuse/cuse.c +++ b/fs/fuse/cuse.c | |||
@@ -473,7 +473,7 @@ err: | |||
473 | static void cuse_fc_release(struct fuse_conn *fc) | 473 | static void cuse_fc_release(struct fuse_conn *fc) |
474 | { | 474 | { |
475 | struct cuse_conn *cc = fc_to_cc(fc); | 475 | struct cuse_conn *cc = fc_to_cc(fc); |
476 | kfree(cc); | 476 | kfree_rcu(cc, fc.rcu); |
477 | } | 477 | } |
478 | 478 | ||
479 | /** | 479 | /** |
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index b7989f2ab4c4..c3eb2c46c8f1 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c | |||
@@ -342,24 +342,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, struct qstr *name, | |||
342 | return err; | 342 | return err; |
343 | } | 343 | } |
344 | 344 | ||
345 | static struct dentry *fuse_materialise_dentry(struct dentry *dentry, | ||
346 | struct inode *inode) | ||
347 | { | ||
348 | struct dentry *newent; | ||
349 | |||
350 | if (inode && S_ISDIR(inode->i_mode)) { | ||
351 | struct fuse_conn *fc = get_fuse_conn(inode); | ||
352 | |||
353 | mutex_lock(&fc->inst_mutex); | ||
354 | newent = d_materialise_unique(dentry, inode); | ||
355 | mutex_unlock(&fc->inst_mutex); | ||
356 | } else { | ||
357 | newent = d_materialise_unique(dentry, inode); | ||
358 | } | ||
359 | |||
360 | return newent; | ||
361 | } | ||
362 | |||
363 | static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, | 345 | static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, |
364 | unsigned int flags) | 346 | unsigned int flags) |
365 | { | 347 | { |
@@ -382,7 +364,7 @@ static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, | |||
382 | if (inode && get_node_id(inode) == FUSE_ROOT_ID) | 364 | if (inode && get_node_id(inode) == FUSE_ROOT_ID) |
383 | goto out_iput; | 365 | goto out_iput; |
384 | 366 | ||
385 | newent = fuse_materialise_dentry(entry, inode); | 367 | newent = d_materialise_unique(entry, inode); |
386 | err = PTR_ERR(newent); | 368 | err = PTR_ERR(newent); |
387 | if (IS_ERR(newent)) | 369 | if (IS_ERR(newent)) |
388 | goto out_err; | 370 | goto out_err; |
@@ -601,21 +583,9 @@ static int create_new_entry(struct fuse_conn *fc, struct fuse_req *req, | |||
601 | } | 583 | } |
602 | kfree(forget); | 584 | kfree(forget); |
603 | 585 | ||
604 | if (S_ISDIR(inode->i_mode)) { | 586 | err = d_instantiate_no_diralias(entry, inode); |
605 | struct dentry *alias; | 587 | if (err) |
606 | mutex_lock(&fc->inst_mutex); | 588 | return err; |
607 | alias = d_find_alias(inode); | ||
608 | if (alias) { | ||
609 | /* New directory must have moved since mkdir */ | ||
610 | mutex_unlock(&fc->inst_mutex); | ||
611 | dput(alias); | ||
612 | iput(inode); | ||
613 | return -EBUSY; | ||
614 | } | ||
615 | d_instantiate(entry, inode); | ||
616 | mutex_unlock(&fc->inst_mutex); | ||
617 | } else | ||
618 | d_instantiate(entry, inode); | ||
619 | 589 | ||
620 | fuse_change_entry_timeout(entry, &outarg); | 590 | fuse_change_entry_timeout(entry, &outarg); |
621 | fuse_invalidate_attr(dir); | 591 | fuse_invalidate_attr(dir); |
@@ -1284,7 +1254,7 @@ static int fuse_direntplus_link(struct file *file, | |||
1284 | if (!inode) | 1254 | if (!inode) |
1285 | goto out; | 1255 | goto out; |
1286 | 1256 | ||
1287 | alias = fuse_materialise_dentry(dentry, inode); | 1257 | alias = d_materialise_unique(dentry, inode); |
1288 | err = PTR_ERR(alias); | 1258 | err = PTR_ERR(alias); |
1289 | if (IS_ERR(alias)) | 1259 | if (IS_ERR(alias)) |
1290 | goto out; | 1260 | goto out; |
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index 643274852c8b..7d2730912667 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h | |||
@@ -375,12 +375,11 @@ struct fuse_conn { | |||
375 | /** Lock protecting accessess to members of this structure */ | 375 | /** Lock protecting accessess to members of this structure */ |
376 | spinlock_t lock; | 376 | spinlock_t lock; |
377 | 377 | ||
378 | /** Mutex protecting against directory alias creation */ | ||
379 | struct mutex inst_mutex; | ||
380 | |||
381 | /** Refcount */ | 378 | /** Refcount */ |
382 | atomic_t count; | 379 | atomic_t count; |
383 | 380 | ||
381 | struct rcu_head rcu; | ||
382 | |||
384 | /** The user id for this mount */ | 383 | /** The user id for this mount */ |
385 | kuid_t user_id; | 384 | kuid_t user_id; |
386 | 385 | ||
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index a8ce6dab60a0..d468643a68b2 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c | |||
@@ -565,7 +565,6 @@ void fuse_conn_init(struct fuse_conn *fc) | |||
565 | { | 565 | { |
566 | memset(fc, 0, sizeof(*fc)); | 566 | memset(fc, 0, sizeof(*fc)); |
567 | spin_lock_init(&fc->lock); | 567 | spin_lock_init(&fc->lock); |
568 | mutex_init(&fc->inst_mutex); | ||
569 | init_rwsem(&fc->killsb); | 568 | init_rwsem(&fc->killsb); |
570 | atomic_set(&fc->count, 1); | 569 | atomic_set(&fc->count, 1); |
571 | init_waitqueue_head(&fc->waitq); | 570 | init_waitqueue_head(&fc->waitq); |
@@ -596,7 +595,6 @@ void fuse_conn_put(struct fuse_conn *fc) | |||
596 | if (atomic_dec_and_test(&fc->count)) { | 595 | if (atomic_dec_and_test(&fc->count)) { |
597 | if (fc->destroy_req) | 596 | if (fc->destroy_req) |
598 | fuse_request_free(fc->destroy_req); | 597 | fuse_request_free(fc->destroy_req); |
599 | mutex_destroy(&fc->inst_mutex); | ||
600 | fc->release(fc); | 598 | fc->release(fc); |
601 | } | 599 | } |
602 | } | 600 | } |
@@ -920,7 +918,7 @@ static void fuse_send_init(struct fuse_conn *fc, struct fuse_req *req) | |||
920 | 918 | ||
921 | static void fuse_free_conn(struct fuse_conn *fc) | 919 | static void fuse_free_conn(struct fuse_conn *fc) |
922 | { | 920 | { |
923 | kfree(fc); | 921 | kfree_rcu(fc, rcu); |
924 | } | 922 | } |
925 | 923 | ||
926 | static int fuse_bdi_init(struct fuse_conn *fc, struct super_block *sb) | 924 | static int fuse_bdi_init(struct fuse_conn *fc, struct super_block *sb) |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 109ce9325b76..1615df16cf4e 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -1514,13 +1514,6 @@ out: | |||
1514 | return NULL; | 1514 | return NULL; |
1515 | } | 1515 | } |
1516 | 1516 | ||
1517 | static void gfs2_put_link(struct dentry *dentry, struct nameidata *nd, void *p) | ||
1518 | { | ||
1519 | char *s = nd_get_link(nd); | ||
1520 | if (!IS_ERR(s)) | ||
1521 | kfree(s); | ||
1522 | } | ||
1523 | |||
1524 | /** | 1517 | /** |
1525 | * gfs2_permission - | 1518 | * gfs2_permission - |
1526 | * @inode: The inode | 1519 | * @inode: The inode |
@@ -1872,7 +1865,7 @@ const struct inode_operations gfs2_dir_iops = { | |||
1872 | const struct inode_operations gfs2_symlink_iops = { | 1865 | const struct inode_operations gfs2_symlink_iops = { |
1873 | .readlink = generic_readlink, | 1866 | .readlink = generic_readlink, |
1874 | .follow_link = gfs2_follow_link, | 1867 | .follow_link = gfs2_follow_link, |
1875 | .put_link = gfs2_put_link, | 1868 | .put_link = kfree_put_link, |
1876 | .permission = gfs2_permission, | 1869 | .permission = gfs2_permission, |
1877 | .setattr = gfs2_setattr, | 1870 | .setattr = gfs2_setattr, |
1878 | .getattr = gfs2_getattr, | 1871 | .getattr = gfs2_getattr, |
diff --git a/fs/hpfs/hpfs_fn.h b/fs/hpfs/hpfs_fn.h index 1b398636e990..6797bf80f6e2 100644 --- a/fs/hpfs/hpfs_fn.h +++ b/fs/hpfs/hpfs_fn.h | |||
@@ -80,6 +80,7 @@ struct hpfs_sb_info { | |||
80 | unsigned sb_c_bitmap; /* current bitmap */ | 80 | unsigned sb_c_bitmap; /* current bitmap */ |
81 | unsigned sb_max_fwd_alloc; /* max forwad allocation */ | 81 | unsigned sb_max_fwd_alloc; /* max forwad allocation */ |
82 | int sb_timeshift; | 82 | int sb_timeshift; |
83 | struct rcu_head rcu; | ||
83 | }; | 84 | }; |
84 | 85 | ||
85 | /* Four 512-byte buffers and the 2k block obtained by concatenating them */ | 86 | /* Four 512-byte buffers and the 2k block obtained by concatenating them */ |
diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 345713d2f8f3..1b39afdd86fd 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c | |||
@@ -407,7 +407,7 @@ again: | |||
407 | /*printk("HPFS: truncating file before delete.\n");*/ | 407 | /*printk("HPFS: truncating file before delete.\n");*/ |
408 | newattrs.ia_size = 0; | 408 | newattrs.ia_size = 0; |
409 | newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; | 409 | newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; |
410 | err = notify_change(dentry, &newattrs); | 410 | err = notify_change(dentry, &newattrs, NULL); |
411 | put_write_access(inode); | 411 | put_write_access(inode); |
412 | if (!err) | 412 | if (!err) |
413 | goto again; | 413 | goto again; |
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c index 4334cda8dba1..b8d01ef6f531 100644 --- a/fs/hpfs/super.c +++ b/fs/hpfs/super.c | |||
@@ -101,18 +101,24 @@ int hpfs_stop_cycles(struct super_block *s, int key, int *c1, int *c2, | |||
101 | return 0; | 101 | return 0; |
102 | } | 102 | } |
103 | 103 | ||
104 | static void hpfs_put_super(struct super_block *s) | 104 | static void free_sbi(struct hpfs_sb_info *sbi) |
105 | { | 105 | { |
106 | struct hpfs_sb_info *sbi = hpfs_sb(s); | 106 | kfree(sbi->sb_cp_table); |
107 | kfree(sbi->sb_bmp_dir); | ||
108 | kfree(sbi); | ||
109 | } | ||
107 | 110 | ||
111 | static void lazy_free_sbi(struct rcu_head *rcu) | ||
112 | { | ||
113 | free_sbi(container_of(rcu, struct hpfs_sb_info, rcu)); | ||
114 | } | ||
115 | |||
116 | static void hpfs_put_super(struct super_block *s) | ||
117 | { | ||
108 | hpfs_lock(s); | 118 | hpfs_lock(s); |
109 | unmark_dirty(s); | 119 | unmark_dirty(s); |
110 | hpfs_unlock(s); | 120 | hpfs_unlock(s); |
111 | 121 | call_rcu(&hpfs_sb(s)->rcu, lazy_free_sbi); | |
112 | kfree(sbi->sb_cp_table); | ||
113 | kfree(sbi->sb_bmp_dir); | ||
114 | s->s_fs_info = NULL; | ||
115 | kfree(sbi); | ||
116 | } | 122 | } |
117 | 123 | ||
118 | unsigned hpfs_count_one_bitmap(struct super_block *s, secno secno) | 124 | unsigned hpfs_count_one_bitmap(struct super_block *s, secno secno) |
@@ -485,9 +491,6 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent) | |||
485 | } | 491 | } |
486 | s->s_fs_info = sbi; | 492 | s->s_fs_info = sbi; |
487 | 493 | ||
488 | sbi->sb_bmp_dir = NULL; | ||
489 | sbi->sb_cp_table = NULL; | ||
490 | |||
491 | mutex_init(&sbi->hpfs_mutex); | 494 | mutex_init(&sbi->hpfs_mutex); |
492 | hpfs_lock(s); | 495 | hpfs_lock(s); |
493 | 496 | ||
@@ -679,10 +682,7 @@ bail2: brelse(bh0); | |||
679 | bail1: | 682 | bail1: |
680 | bail0: | 683 | bail0: |
681 | hpfs_unlock(s); | 684 | hpfs_unlock(s); |
682 | kfree(sbi->sb_bmp_dir); | 685 | free_sbi(sbi); |
683 | kfree(sbi->sb_cp_table); | ||
684 | s->s_fs_info = NULL; | ||
685 | kfree(sbi); | ||
686 | return -EINVAL; | 686 | return -EINVAL; |
687 | } | 687 | } |
688 | 688 | ||
diff --git a/fs/inode.c b/fs/inode.c index b33ba8e021cc..4bcdad3c9361 100644 --- a/fs/inode.c +++ b/fs/inode.c | |||
@@ -773,15 +773,11 @@ static struct inode *find_inode(struct super_block *sb, | |||
773 | 773 | ||
774 | repeat: | 774 | repeat: |
775 | hlist_for_each_entry(inode, head, i_hash) { | 775 | hlist_for_each_entry(inode, head, i_hash) { |
776 | spin_lock(&inode->i_lock); | 776 | if (inode->i_sb != sb) |
777 | if (inode->i_sb != sb) { | ||
778 | spin_unlock(&inode->i_lock); | ||
779 | continue; | 777 | continue; |
780 | } | 778 | if (!test(inode, data)) |
781 | if (!test(inode, data)) { | ||
782 | spin_unlock(&inode->i_lock); | ||
783 | continue; | 779 | continue; |
784 | } | 780 | spin_lock(&inode->i_lock); |
785 | if (inode->i_state & (I_FREEING|I_WILL_FREE)) { | 781 | if (inode->i_state & (I_FREEING|I_WILL_FREE)) { |
786 | __wait_on_freeing_inode(inode); | 782 | __wait_on_freeing_inode(inode); |
787 | goto repeat; | 783 | goto repeat; |
@@ -804,15 +800,11 @@ static struct inode *find_inode_fast(struct super_block *sb, | |||
804 | 800 | ||
805 | repeat: | 801 | repeat: |
806 | hlist_for_each_entry(inode, head, i_hash) { | 802 | hlist_for_each_entry(inode, head, i_hash) { |
807 | spin_lock(&inode->i_lock); | 803 | if (inode->i_ino != ino) |
808 | if (inode->i_ino != ino) { | ||
809 | spin_unlock(&inode->i_lock); | ||
810 | continue; | 804 | continue; |
811 | } | 805 | if (inode->i_sb != sb) |
812 | if (inode->i_sb != sb) { | ||
813 | spin_unlock(&inode->i_lock); | ||
814 | continue; | 806 | continue; |
815 | } | 807 | spin_lock(&inode->i_lock); |
816 | if (inode->i_state & (I_FREEING|I_WILL_FREE)) { | 808 | if (inode->i_state & (I_FREEING|I_WILL_FREE)) { |
817 | __wait_on_freeing_inode(inode); | 809 | __wait_on_freeing_inode(inode); |
818 | goto repeat; | 810 | goto repeat; |
@@ -951,6 +943,42 @@ void unlock_new_inode(struct inode *inode) | |||
951 | EXPORT_SYMBOL(unlock_new_inode); | 943 | EXPORT_SYMBOL(unlock_new_inode); |
952 | 944 | ||
953 | /** | 945 | /** |
946 | * lock_two_nondirectories - take two i_mutexes on non-directory objects | ||
947 | * @inode1: first inode to lock | ||
948 | * @inode2: second inode to lock | ||
949 | */ | ||
950 | void lock_two_nondirectories(struct inode *inode1, struct inode *inode2) | ||
951 | { | ||
952 | WARN_ON_ONCE(S_ISDIR(inode1->i_mode)); | ||
953 | if (inode1 == inode2 || !inode2) { | ||
954 | mutex_lock(&inode1->i_mutex); | ||
955 | return; | ||
956 | } | ||
957 | WARN_ON_ONCE(S_ISDIR(inode2->i_mode)); | ||
958 | if (inode1 < inode2) { | ||
959 | mutex_lock(&inode1->i_mutex); | ||
960 | mutex_lock_nested(&inode2->i_mutex, I_MUTEX_NONDIR2); | ||
961 | } else { | ||
962 | mutex_lock(&inode2->i_mutex); | ||
963 | mutex_lock_nested(&inode1->i_mutex, I_MUTEX_NONDIR2); | ||
964 | } | ||
965 | } | ||
966 | EXPORT_SYMBOL(lock_two_nondirectories); | ||
967 | |||
968 | /** | ||
969 | * unlock_two_nondirectories - release locks from lock_two_nondirectories() | ||
970 | * @inode1: first inode to unlock | ||
971 | * @inode2: second inode to unlock | ||
972 | */ | ||
973 | void unlock_two_nondirectories(struct inode *inode1, struct inode *inode2) | ||
974 | { | ||
975 | mutex_unlock(&inode1->i_mutex); | ||
976 | if (inode2 && inode2 != inode1) | ||
977 | mutex_unlock(&inode2->i_mutex); | ||
978 | } | ||
979 | EXPORT_SYMBOL(unlock_two_nondirectories); | ||
980 | |||
981 | /** | ||
954 | * iget5_locked - obtain an inode from a mounted file system | 982 | * iget5_locked - obtain an inode from a mounted file system |
955 | * @sb: super block of file system | 983 | * @sb: super block of file system |
956 | * @hashval: hash value (usually inode number) to get | 984 | * @hashval: hash value (usually inode number) to get |
@@ -1575,7 +1603,11 @@ static int __remove_suid(struct dentry *dentry, int kill) | |||
1575 | struct iattr newattrs; | 1603 | struct iattr newattrs; |
1576 | 1604 | ||
1577 | newattrs.ia_valid = ATTR_FORCE | kill; | 1605 | newattrs.ia_valid = ATTR_FORCE | kill; |
1578 | return notify_change(dentry, &newattrs); | 1606 | /* |
1607 | * Note we call this on write, so notify_change will not | ||
1608 | * encounter any conflicting delegations: | ||
1609 | */ | ||
1610 | return notify_change(dentry, &newattrs, NULL); | ||
1579 | } | 1611 | } |
1580 | 1612 | ||
1581 | int file_remove_suid(struct file *file) | 1613 | int file_remove_suid(struct file *file) |
diff --git a/fs/internal.h b/fs/internal.h index 513e0d859a6c..465742407466 100644 --- a/fs/internal.h +++ b/fs/internal.h | |||
@@ -9,8 +9,6 @@ | |||
9 | * 2 of the License, or (at your option) any later version. | 9 | * 2 of the License, or (at your option) any later version. |
10 | */ | 10 | */ |
11 | 11 | ||
12 | #include <linux/lglock.h> | ||
13 | |||
14 | struct super_block; | 12 | struct super_block; |
15 | struct file_system_type; | 13 | struct file_system_type; |
16 | struct linux_binprm; | 14 | struct linux_binprm; |
@@ -62,8 +60,6 @@ extern int sb_prepare_remount_readonly(struct super_block *); | |||
62 | 60 | ||
63 | extern void __init mnt_init(void); | 61 | extern void __init mnt_init(void); |
64 | 62 | ||
65 | extern struct lglock vfsmount_lock; | ||
66 | |||
67 | extern int __mnt_want_write(struct vfsmount *); | 63 | extern int __mnt_want_write(struct vfsmount *); |
68 | extern int __mnt_want_write_file(struct file *); | 64 | extern int __mnt_want_write_file(struct file *); |
69 | extern void __mnt_drop_write(struct vfsmount *); | 65 | extern void __mnt_drop_write(struct vfsmount *); |
@@ -77,9 +73,6 @@ extern void chroot_fs_refs(const struct path *, const struct path *); | |||
77 | /* | 73 | /* |
78 | * file_table.c | 74 | * file_table.c |
79 | */ | 75 | */ |
80 | extern void file_sb_list_add(struct file *f, struct super_block *sb); | ||
81 | extern void file_sb_list_del(struct file *f); | ||
82 | extern void mark_files_ro(struct super_block *); | ||
83 | extern struct file *get_empty_filp(void); | 76 | extern struct file *get_empty_filp(void); |
84 | 77 | ||
85 | /* | 78 | /* |
diff --git a/fs/ioctl.c b/fs/ioctl.c index fd507fb460f8..8ac3fad36192 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c | |||
@@ -37,7 +37,7 @@ static long vfs_ioctl(struct file *filp, unsigned int cmd, | |||
37 | { | 37 | { |
38 | int error = -ENOTTY; | 38 | int error = -ENOTTY; |
39 | 39 | ||
40 | if (!filp->f_op || !filp->f_op->unlocked_ioctl) | 40 | if (!filp->f_op->unlocked_ioctl) |
41 | goto out; | 41 | goto out; |
42 | 42 | ||
43 | error = filp->f_op->unlocked_ioctl(filp, cmd, arg); | 43 | error = filp->f_op->unlocked_ioctl(filp, cmd, arg); |
@@ -501,7 +501,7 @@ static int ioctl_fioasync(unsigned int fd, struct file *filp, | |||
501 | 501 | ||
502 | /* Did FASYNC state change ? */ | 502 | /* Did FASYNC state change ? */ |
503 | if ((flag ^ filp->f_flags) & FASYNC) { | 503 | if ((flag ^ filp->f_flags) & FASYNC) { |
504 | if (filp->f_op && filp->f_op->fasync) | 504 | if (filp->f_op->fasync) |
505 | /* fasync() adjusts filp->f_flags */ | 505 | /* fasync() adjusts filp->f_flags */ |
506 | error = filp->f_op->fasync(fd, filp, on); | 506 | error = filp->f_op->fasync(fd, filp, on); |
507 | else | 507 | else |
diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c index e5d408a7ea4a..4a9e10ea13f2 100644 --- a/fs/isofs/inode.c +++ b/fs/isofs/inode.c | |||
@@ -181,7 +181,7 @@ struct iso9660_options{ | |||
181 | * Compute the hash for the isofs name corresponding to the dentry. | 181 | * Compute the hash for the isofs name corresponding to the dentry. |
182 | */ | 182 | */ |
183 | static int | 183 | static int |
184 | isofs_hash_common(const struct dentry *dentry, struct qstr *qstr, int ms) | 184 | isofs_hash_common(struct qstr *qstr, int ms) |
185 | { | 185 | { |
186 | const char *name; | 186 | const char *name; |
187 | int len; | 187 | int len; |
@@ -202,7 +202,7 @@ isofs_hash_common(const struct dentry *dentry, struct qstr *qstr, int ms) | |||
202 | * Compute the hash for the isofs name corresponding to the dentry. | 202 | * Compute the hash for the isofs name corresponding to the dentry. |
203 | */ | 203 | */ |
204 | static int | 204 | static int |
205 | isofs_hashi_common(const struct dentry *dentry, struct qstr *qstr, int ms) | 205 | isofs_hashi_common(struct qstr *qstr, int ms) |
206 | { | 206 | { |
207 | const char *name; | 207 | const char *name; |
208 | int len; | 208 | int len; |
@@ -259,13 +259,13 @@ static int isofs_dentry_cmp_common( | |||
259 | static int | 259 | static int |
260 | isofs_hash(const struct dentry *dentry, struct qstr *qstr) | 260 | isofs_hash(const struct dentry *dentry, struct qstr *qstr) |
261 | { | 261 | { |
262 | return isofs_hash_common(dentry, qstr, 0); | 262 | return isofs_hash_common(qstr, 0); |
263 | } | 263 | } |
264 | 264 | ||
265 | static int | 265 | static int |
266 | isofs_hashi(const struct dentry *dentry, struct qstr *qstr) | 266 | isofs_hashi(const struct dentry *dentry, struct qstr *qstr) |
267 | { | 267 | { |
268 | return isofs_hashi_common(dentry, qstr, 0); | 268 | return isofs_hashi_common(qstr, 0); |
269 | } | 269 | } |
270 | 270 | ||
271 | static int | 271 | static int |
@@ -286,13 +286,13 @@ isofs_dentry_cmpi(const struct dentry *parent, const struct dentry *dentry, | |||
286 | static int | 286 | static int |
287 | isofs_hash_ms(const struct dentry *dentry, struct qstr *qstr) | 287 | isofs_hash_ms(const struct dentry *dentry, struct qstr *qstr) |
288 | { | 288 | { |
289 | return isofs_hash_common(dentry, qstr, 1); | 289 | return isofs_hash_common(qstr, 1); |
290 | } | 290 | } |
291 | 291 | ||
292 | static int | 292 | static int |
293 | isofs_hashi_ms(const struct dentry *dentry, struct qstr *qstr) | 293 | isofs_hashi_ms(const struct dentry *dentry, struct qstr *qstr) |
294 | { | 294 | { |
295 | return isofs_hashi_common(dentry, qstr, 1); | 295 | return isofs_hashi_common(qstr, 1); |
296 | } | 296 | } |
297 | 297 | ||
298 | static int | 298 | static int |
diff --git a/fs/libfs.c b/fs/libfs.c index 3a3a9b53bf5a..5de06947ba5e 100644 --- a/fs/libfs.c +++ b/fs/libfs.c | |||
@@ -10,6 +10,7 @@ | |||
10 | #include <linux/vfs.h> | 10 | #include <linux/vfs.h> |
11 | #include <linux/quotaops.h> | 11 | #include <linux/quotaops.h> |
12 | #include <linux/mutex.h> | 12 | #include <linux/mutex.h> |
13 | #include <linux/namei.h> | ||
13 | #include <linux/exportfs.h> | 14 | #include <linux/exportfs.h> |
14 | #include <linux/writeback.h> | 15 | #include <linux/writeback.h> |
15 | #include <linux/buffer_head.h> /* sync_mapping_buffers */ | 16 | #include <linux/buffer_head.h> /* sync_mapping_buffers */ |
@@ -31,6 +32,7 @@ int simple_getattr(struct vfsmount *mnt, struct dentry *dentry, | |||
31 | stat->blocks = inode->i_mapping->nrpages << (PAGE_CACHE_SHIFT - 9); | 32 | stat->blocks = inode->i_mapping->nrpages << (PAGE_CACHE_SHIFT - 9); |
32 | return 0; | 33 | return 0; |
33 | } | 34 | } |
35 | EXPORT_SYMBOL(simple_getattr); | ||
34 | 36 | ||
35 | int simple_statfs(struct dentry *dentry, struct kstatfs *buf) | 37 | int simple_statfs(struct dentry *dentry, struct kstatfs *buf) |
36 | { | 38 | { |
@@ -39,6 +41,7 @@ int simple_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
39 | buf->f_namelen = NAME_MAX; | 41 | buf->f_namelen = NAME_MAX; |
40 | return 0; | 42 | return 0; |
41 | } | 43 | } |
44 | EXPORT_SYMBOL(simple_statfs); | ||
42 | 45 | ||
43 | /* | 46 | /* |
44 | * Retaining negative dentries for an in-memory filesystem just wastes | 47 | * Retaining negative dentries for an in-memory filesystem just wastes |
@@ -66,6 +69,7 @@ struct dentry *simple_lookup(struct inode *dir, struct dentry *dentry, unsigned | |||
66 | d_add(dentry, NULL); | 69 | d_add(dentry, NULL); |
67 | return NULL; | 70 | return NULL; |
68 | } | 71 | } |
72 | EXPORT_SYMBOL(simple_lookup); | ||
69 | 73 | ||
70 | int dcache_dir_open(struct inode *inode, struct file *file) | 74 | int dcache_dir_open(struct inode *inode, struct file *file) |
71 | { | 75 | { |
@@ -75,12 +79,14 @@ int dcache_dir_open(struct inode *inode, struct file *file) | |||
75 | 79 | ||
76 | return file->private_data ? 0 : -ENOMEM; | 80 | return file->private_data ? 0 : -ENOMEM; |
77 | } | 81 | } |
82 | EXPORT_SYMBOL(dcache_dir_open); | ||
78 | 83 | ||
79 | int dcache_dir_close(struct inode *inode, struct file *file) | 84 | int dcache_dir_close(struct inode *inode, struct file *file) |
80 | { | 85 | { |
81 | dput(file->private_data); | 86 | dput(file->private_data); |
82 | return 0; | 87 | return 0; |
83 | } | 88 | } |
89 | EXPORT_SYMBOL(dcache_dir_close); | ||
84 | 90 | ||
85 | loff_t dcache_dir_lseek(struct file *file, loff_t offset, int whence) | 91 | loff_t dcache_dir_lseek(struct file *file, loff_t offset, int whence) |
86 | { | 92 | { |
@@ -123,6 +129,7 @@ loff_t dcache_dir_lseek(struct file *file, loff_t offset, int whence) | |||
123 | mutex_unlock(&dentry->d_inode->i_mutex); | 129 | mutex_unlock(&dentry->d_inode->i_mutex); |
124 | return offset; | 130 | return offset; |
125 | } | 131 | } |
132 | EXPORT_SYMBOL(dcache_dir_lseek); | ||
126 | 133 | ||
127 | /* Relationship between i_mode and the DT_xxx types */ | 134 | /* Relationship between i_mode and the DT_xxx types */ |
128 | static inline unsigned char dt_type(struct inode *inode) | 135 | static inline unsigned char dt_type(struct inode *inode) |
@@ -172,11 +179,13 @@ int dcache_readdir(struct file *file, struct dir_context *ctx) | |||
172 | spin_unlock(&dentry->d_lock); | 179 | spin_unlock(&dentry->d_lock); |
173 | return 0; | 180 | return 0; |
174 | } | 181 | } |
182 | EXPORT_SYMBOL(dcache_readdir); | ||
175 | 183 | ||
176 | ssize_t generic_read_dir(struct file *filp, char __user *buf, size_t siz, loff_t *ppos) | 184 | ssize_t generic_read_dir(struct file *filp, char __user *buf, size_t siz, loff_t *ppos) |
177 | { | 185 | { |
178 | return -EISDIR; | 186 | return -EISDIR; |
179 | } | 187 | } |
188 | EXPORT_SYMBOL(generic_read_dir); | ||
180 | 189 | ||
181 | const struct file_operations simple_dir_operations = { | 190 | const struct file_operations simple_dir_operations = { |
182 | .open = dcache_dir_open, | 191 | .open = dcache_dir_open, |
@@ -186,10 +195,12 @@ const struct file_operations simple_dir_operations = { | |||
186 | .iterate = dcache_readdir, | 195 | .iterate = dcache_readdir, |
187 | .fsync = noop_fsync, | 196 | .fsync = noop_fsync, |
188 | }; | 197 | }; |
198 | EXPORT_SYMBOL(simple_dir_operations); | ||
189 | 199 | ||
190 | const struct inode_operations simple_dir_inode_operations = { | 200 | const struct inode_operations simple_dir_inode_operations = { |
191 | .lookup = simple_lookup, | 201 | .lookup = simple_lookup, |
192 | }; | 202 | }; |
203 | EXPORT_SYMBOL(simple_dir_inode_operations); | ||
193 | 204 | ||
194 | static const struct super_operations simple_super_operations = { | 205 | static const struct super_operations simple_super_operations = { |
195 | .statfs = simple_statfs, | 206 | .statfs = simple_statfs, |
@@ -244,6 +255,7 @@ Enomem: | |||
244 | deactivate_locked_super(s); | 255 | deactivate_locked_super(s); |
245 | return ERR_PTR(-ENOMEM); | 256 | return ERR_PTR(-ENOMEM); |
246 | } | 257 | } |
258 | EXPORT_SYMBOL(mount_pseudo); | ||
247 | 259 | ||
248 | int simple_open(struct inode *inode, struct file *file) | 260 | int simple_open(struct inode *inode, struct file *file) |
249 | { | 261 | { |
@@ -251,6 +263,7 @@ int simple_open(struct inode *inode, struct file *file) | |||
251 | file->private_data = inode->i_private; | 263 | file->private_data = inode->i_private; |
252 | return 0; | 264 | return 0; |
253 | } | 265 | } |
266 | EXPORT_SYMBOL(simple_open); | ||
254 | 267 | ||
255 | int simple_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) | 268 | int simple_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) |
256 | { | 269 | { |
@@ -263,6 +276,7 @@ int simple_link(struct dentry *old_dentry, struct inode *dir, struct dentry *den | |||
263 | d_instantiate(dentry, inode); | 276 | d_instantiate(dentry, inode); |
264 | return 0; | 277 | return 0; |
265 | } | 278 | } |
279 | EXPORT_SYMBOL(simple_link); | ||
266 | 280 | ||
267 | int simple_empty(struct dentry *dentry) | 281 | int simple_empty(struct dentry *dentry) |
268 | { | 282 | { |
@@ -283,6 +297,7 @@ out: | |||
283 | spin_unlock(&dentry->d_lock); | 297 | spin_unlock(&dentry->d_lock); |
284 | return ret; | 298 | return ret; |
285 | } | 299 | } |
300 | EXPORT_SYMBOL(simple_empty); | ||
286 | 301 | ||
287 | int simple_unlink(struct inode *dir, struct dentry *dentry) | 302 | int simple_unlink(struct inode *dir, struct dentry *dentry) |
288 | { | 303 | { |
@@ -293,6 +308,7 @@ int simple_unlink(struct inode *dir, struct dentry *dentry) | |||
293 | dput(dentry); | 308 | dput(dentry); |
294 | return 0; | 309 | return 0; |
295 | } | 310 | } |
311 | EXPORT_SYMBOL(simple_unlink); | ||
296 | 312 | ||
297 | int simple_rmdir(struct inode *dir, struct dentry *dentry) | 313 | int simple_rmdir(struct inode *dir, struct dentry *dentry) |
298 | { | 314 | { |
@@ -304,6 +320,7 @@ int simple_rmdir(struct inode *dir, struct dentry *dentry) | |||
304 | drop_nlink(dir); | 320 | drop_nlink(dir); |
305 | return 0; | 321 | return 0; |
306 | } | 322 | } |
323 | EXPORT_SYMBOL(simple_rmdir); | ||
307 | 324 | ||
308 | int simple_rename(struct inode *old_dir, struct dentry *old_dentry, | 325 | int simple_rename(struct inode *old_dir, struct dentry *old_dentry, |
309 | struct inode *new_dir, struct dentry *new_dentry) | 326 | struct inode *new_dir, struct dentry *new_dentry) |
@@ -330,6 +347,7 @@ int simple_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
330 | 347 | ||
331 | return 0; | 348 | return 0; |
332 | } | 349 | } |
350 | EXPORT_SYMBOL(simple_rename); | ||
333 | 351 | ||
334 | /** | 352 | /** |
335 | * simple_setattr - setattr for simple filesystem | 353 | * simple_setattr - setattr for simple filesystem |
@@ -370,6 +388,7 @@ int simple_readpage(struct file *file, struct page *page) | |||
370 | unlock_page(page); | 388 | unlock_page(page); |
371 | return 0; | 389 | return 0; |
372 | } | 390 | } |
391 | EXPORT_SYMBOL(simple_readpage); | ||
373 | 392 | ||
374 | int simple_write_begin(struct file *file, struct address_space *mapping, | 393 | int simple_write_begin(struct file *file, struct address_space *mapping, |
375 | loff_t pos, unsigned len, unsigned flags, | 394 | loff_t pos, unsigned len, unsigned flags, |
@@ -393,6 +412,7 @@ int simple_write_begin(struct file *file, struct address_space *mapping, | |||
393 | } | 412 | } |
394 | return 0; | 413 | return 0; |
395 | } | 414 | } |
415 | EXPORT_SYMBOL(simple_write_begin); | ||
396 | 416 | ||
397 | /** | 417 | /** |
398 | * simple_write_end - .write_end helper for non-block-device FSes | 418 | * simple_write_end - .write_end helper for non-block-device FSes |
@@ -444,6 +464,7 @@ int simple_write_end(struct file *file, struct address_space *mapping, | |||
444 | 464 | ||
445 | return copied; | 465 | return copied; |
446 | } | 466 | } |
467 | EXPORT_SYMBOL(simple_write_end); | ||
447 | 468 | ||
448 | /* | 469 | /* |
449 | * the inodes created here are not hashed. If you use iunique to generate | 470 | * the inodes created here are not hashed. If you use iunique to generate |
@@ -512,6 +533,7 @@ out: | |||
512 | dput(root); | 533 | dput(root); |
513 | return -ENOMEM; | 534 | return -ENOMEM; |
514 | } | 535 | } |
536 | EXPORT_SYMBOL(simple_fill_super); | ||
515 | 537 | ||
516 | static DEFINE_SPINLOCK(pin_fs_lock); | 538 | static DEFINE_SPINLOCK(pin_fs_lock); |
517 | 539 | ||
@@ -534,6 +556,7 @@ int simple_pin_fs(struct file_system_type *type, struct vfsmount **mount, int *c | |||
534 | mntput(mnt); | 556 | mntput(mnt); |
535 | return 0; | 557 | return 0; |
536 | } | 558 | } |
559 | EXPORT_SYMBOL(simple_pin_fs); | ||
537 | 560 | ||
538 | void simple_release_fs(struct vfsmount **mount, int *count) | 561 | void simple_release_fs(struct vfsmount **mount, int *count) |
539 | { | 562 | { |
@@ -545,6 +568,7 @@ void simple_release_fs(struct vfsmount **mount, int *count) | |||
545 | spin_unlock(&pin_fs_lock); | 568 | spin_unlock(&pin_fs_lock); |
546 | mntput(mnt); | 569 | mntput(mnt); |
547 | } | 570 | } |
571 | EXPORT_SYMBOL(simple_release_fs); | ||
548 | 572 | ||
549 | /** | 573 | /** |
550 | * simple_read_from_buffer - copy data from the buffer to user space | 574 | * simple_read_from_buffer - copy data from the buffer to user space |
@@ -579,6 +603,7 @@ ssize_t simple_read_from_buffer(void __user *to, size_t count, loff_t *ppos, | |||
579 | *ppos = pos + count; | 603 | *ppos = pos + count; |
580 | return count; | 604 | return count; |
581 | } | 605 | } |
606 | EXPORT_SYMBOL(simple_read_from_buffer); | ||
582 | 607 | ||
583 | /** | 608 | /** |
584 | * simple_write_to_buffer - copy data from user space to the buffer | 609 | * simple_write_to_buffer - copy data from user space to the buffer |
@@ -613,6 +638,7 @@ ssize_t simple_write_to_buffer(void *to, size_t available, loff_t *ppos, | |||
613 | *ppos = pos + count; | 638 | *ppos = pos + count; |
614 | return count; | 639 | return count; |
615 | } | 640 | } |
641 | EXPORT_SYMBOL(simple_write_to_buffer); | ||
616 | 642 | ||
617 | /** | 643 | /** |
618 | * memory_read_from_buffer - copy data from the buffer | 644 | * memory_read_from_buffer - copy data from the buffer |
@@ -644,6 +670,7 @@ ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos, | |||
644 | 670 | ||
645 | return count; | 671 | return count; |
646 | } | 672 | } |
673 | EXPORT_SYMBOL(memory_read_from_buffer); | ||
647 | 674 | ||
648 | /* | 675 | /* |
649 | * Transaction based IO. | 676 | * Transaction based IO. |
@@ -665,6 +692,7 @@ void simple_transaction_set(struct file *file, size_t n) | |||
665 | smp_mb(); | 692 | smp_mb(); |
666 | ar->size = n; | 693 | ar->size = n; |
667 | } | 694 | } |
695 | EXPORT_SYMBOL(simple_transaction_set); | ||
668 | 696 | ||
669 | char *simple_transaction_get(struct file *file, const char __user *buf, size_t size) | 697 | char *simple_transaction_get(struct file *file, const char __user *buf, size_t size) |
670 | { | 698 | { |
@@ -696,6 +724,7 @@ char *simple_transaction_get(struct file *file, const char __user *buf, size_t s | |||
696 | 724 | ||
697 | return ar->data; | 725 | return ar->data; |
698 | } | 726 | } |
727 | EXPORT_SYMBOL(simple_transaction_get); | ||
699 | 728 | ||
700 | ssize_t simple_transaction_read(struct file *file, char __user *buf, size_t size, loff_t *pos) | 729 | ssize_t simple_transaction_read(struct file *file, char __user *buf, size_t size, loff_t *pos) |
701 | { | 730 | { |
@@ -705,12 +734,14 @@ ssize_t simple_transaction_read(struct file *file, char __user *buf, size_t size | |||
705 | return 0; | 734 | return 0; |
706 | return simple_read_from_buffer(buf, size, pos, ar->data, ar->size); | 735 | return simple_read_from_buffer(buf, size, pos, ar->data, ar->size); |
707 | } | 736 | } |
737 | EXPORT_SYMBOL(simple_transaction_read); | ||
708 | 738 | ||
709 | int simple_transaction_release(struct inode *inode, struct file *file) | 739 | int simple_transaction_release(struct inode *inode, struct file *file) |
710 | { | 740 | { |
711 | free_page((unsigned long)file->private_data); | 741 | free_page((unsigned long)file->private_data); |
712 | return 0; | 742 | return 0; |
713 | } | 743 | } |
744 | EXPORT_SYMBOL(simple_transaction_release); | ||
714 | 745 | ||
715 | /* Simple attribute files */ | 746 | /* Simple attribute files */ |
716 | 747 | ||
@@ -746,12 +777,14 @@ int simple_attr_open(struct inode *inode, struct file *file, | |||
746 | 777 | ||
747 | return nonseekable_open(inode, file); | 778 | return nonseekable_open(inode, file); |
748 | } | 779 | } |
780 | EXPORT_SYMBOL_GPL(simple_attr_open); | ||
749 | 781 | ||
750 | int simple_attr_release(struct inode *inode, struct file *file) | 782 | int simple_attr_release(struct inode *inode, struct file *file) |
751 | { | 783 | { |
752 | kfree(file->private_data); | 784 | kfree(file->private_data); |
753 | return 0; | 785 | return 0; |
754 | } | 786 | } |
787 | EXPORT_SYMBOL_GPL(simple_attr_release); /* GPL-only? This? Really? */ | ||
755 | 788 | ||
756 | /* read from the buffer that is filled with the get function */ | 789 | /* read from the buffer that is filled with the get function */ |
757 | ssize_t simple_attr_read(struct file *file, char __user *buf, | 790 | ssize_t simple_attr_read(struct file *file, char __user *buf, |
@@ -787,6 +820,7 @@ out: | |||
787 | mutex_unlock(&attr->mutex); | 820 | mutex_unlock(&attr->mutex); |
788 | return ret; | 821 | return ret; |
789 | } | 822 | } |
823 | EXPORT_SYMBOL_GPL(simple_attr_read); | ||
790 | 824 | ||
791 | /* interpret the buffer as a number to call the set function with */ | 825 | /* interpret the buffer as a number to call the set function with */ |
792 | ssize_t simple_attr_write(struct file *file, const char __user *buf, | 826 | ssize_t simple_attr_write(struct file *file, const char __user *buf, |
@@ -819,6 +853,7 @@ out: | |||
819 | mutex_unlock(&attr->mutex); | 853 | mutex_unlock(&attr->mutex); |
820 | return ret; | 854 | return ret; |
821 | } | 855 | } |
856 | EXPORT_SYMBOL_GPL(simple_attr_write); | ||
822 | 857 | ||
823 | /** | 858 | /** |
824 | * generic_fh_to_dentry - generic helper for the fh_to_dentry export operation | 859 | * generic_fh_to_dentry - generic helper for the fh_to_dentry export operation |
@@ -957,39 +992,56 @@ int noop_fsync(struct file *file, loff_t start, loff_t end, int datasync) | |||
957 | { | 992 | { |
958 | return 0; | 993 | return 0; |
959 | } | 994 | } |
960 | |||
961 | EXPORT_SYMBOL(dcache_dir_close); | ||
962 | EXPORT_SYMBOL(dcache_dir_lseek); | ||
963 | EXPORT_SYMBOL(dcache_dir_open); | ||
964 | EXPORT_SYMBOL(dcache_readdir); | ||
965 | EXPORT_SYMBOL(generic_read_dir); | ||
966 | EXPORT_SYMBOL(mount_pseudo); | ||
967 | EXPORT_SYMBOL(simple_write_begin); | ||
968 | EXPORT_SYMBOL(simple_write_end); | ||
969 | EXPORT_SYMBOL(simple_dir_inode_operations); | ||
970 | EXPORT_SYMBOL(simple_dir_operations); | ||
971 | EXPORT_SYMBOL(simple_empty); | ||
972 | EXPORT_SYMBOL(simple_fill_super); | ||
973 | EXPORT_SYMBOL(simple_getattr); | ||
974 | EXPORT_SYMBOL(simple_open); | ||
975 | EXPORT_SYMBOL(simple_link); | ||
976 | EXPORT_SYMBOL(simple_lookup); | ||
977 | EXPORT_SYMBOL(simple_pin_fs); | ||
978 | EXPORT_SYMBOL(simple_readpage); | ||
979 | EXPORT_SYMBOL(simple_release_fs); | ||
980 | EXPORT_SYMBOL(simple_rename); | ||
981 | EXPORT_SYMBOL(simple_rmdir); | ||
982 | EXPORT_SYMBOL(simple_statfs); | ||
983 | EXPORT_SYMBOL(noop_fsync); | 995 | EXPORT_SYMBOL(noop_fsync); |
984 | EXPORT_SYMBOL(simple_unlink); | 996 | |
985 | EXPORT_SYMBOL(simple_read_from_buffer); | 997 | void kfree_put_link(struct dentry *dentry, struct nameidata *nd, |
986 | EXPORT_SYMBOL(simple_write_to_buffer); | 998 | void *cookie) |
987 | EXPORT_SYMBOL(memory_read_from_buffer); | 999 | { |
988 | EXPORT_SYMBOL(simple_transaction_set); | 1000 | char *s = nd_get_link(nd); |
989 | EXPORT_SYMBOL(simple_transaction_get); | 1001 | if (!IS_ERR(s)) |
990 | EXPORT_SYMBOL(simple_transaction_read); | 1002 | kfree(s); |
991 | EXPORT_SYMBOL(simple_transaction_release); | 1003 | } |
992 | EXPORT_SYMBOL_GPL(simple_attr_open); | 1004 | EXPORT_SYMBOL(kfree_put_link); |
993 | EXPORT_SYMBOL_GPL(simple_attr_release); | 1005 | |
994 | EXPORT_SYMBOL_GPL(simple_attr_read); | 1006 | /* |
995 | EXPORT_SYMBOL_GPL(simple_attr_write); | 1007 | * nop .set_page_dirty method so that people can use .page_mkwrite on |
1008 | * anon inodes. | ||
1009 | */ | ||
1010 | static int anon_set_page_dirty(struct page *page) | ||
1011 | { | ||
1012 | return 0; | ||
1013 | }; | ||
1014 | |||
1015 | /* | ||
1016 | * A single inode exists for all anon_inode files. Contrary to pipes, | ||
1017 | * anon_inode inodes have no associated per-instance data, so we need | ||
1018 | * only allocate one of them. | ||
1019 | */ | ||
1020 | struct inode *alloc_anon_inode(struct super_block *s) | ||
1021 | { | ||
1022 | static const struct address_space_operations anon_aops = { | ||
1023 | .set_page_dirty = anon_set_page_dirty, | ||
1024 | }; | ||
1025 | struct inode *inode = new_inode_pseudo(s); | ||
1026 | |||
1027 | if (!inode) | ||
1028 | return ERR_PTR(-ENOMEM); | ||
1029 | |||
1030 | inode->i_ino = get_next_ino(); | ||
1031 | inode->i_mapping->a_ops = &anon_aops; | ||
1032 | |||
1033 | /* | ||
1034 | * Mark the inode dirty from the very beginning, | ||
1035 | * that way it will never be moved to the dirty | ||
1036 | * list because mark_inode_dirty() will think | ||
1037 | * that it already _is_ on the dirty list. | ||
1038 | */ | ||
1039 | inode->i_state = I_DIRTY; | ||
1040 | inode->i_mode = S_IRUSR | S_IWUSR; | ||
1041 | inode->i_uid = current_fsuid(); | ||
1042 | inode->i_gid = current_fsgid(); | ||
1043 | inode->i_flags |= S_PRIVATE; | ||
1044 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; | ||
1045 | return inode; | ||
1046 | } | ||
1047 | EXPORT_SYMBOL(alloc_anon_inode); | ||
diff --git a/fs/locks.c b/fs/locks.c index b27a3005d78d..f99d52bdd05a 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -134,7 +134,7 @@ | |||
134 | 134 | ||
135 | #define IS_POSIX(fl) (fl->fl_flags & FL_POSIX) | 135 | #define IS_POSIX(fl) (fl->fl_flags & FL_POSIX) |
136 | #define IS_FLOCK(fl) (fl->fl_flags & FL_FLOCK) | 136 | #define IS_FLOCK(fl) (fl->fl_flags & FL_FLOCK) |
137 | #define IS_LEASE(fl) (fl->fl_flags & FL_LEASE) | 137 | #define IS_LEASE(fl) (fl->fl_flags & (FL_LEASE|FL_DELEG)) |
138 | 138 | ||
139 | static bool lease_breaking(struct file_lock *fl) | 139 | static bool lease_breaking(struct file_lock *fl) |
140 | { | 140 | { |
@@ -1292,28 +1292,40 @@ static void time_out_leases(struct inode *inode) | |||
1292 | } | 1292 | } |
1293 | } | 1293 | } |
1294 | 1294 | ||
1295 | static bool leases_conflict(struct file_lock *lease, struct file_lock *breaker) | ||
1296 | { | ||
1297 | if ((breaker->fl_flags & FL_DELEG) && (lease->fl_flags & FL_LEASE)) | ||
1298 | return false; | ||
1299 | return locks_conflict(breaker, lease); | ||
1300 | } | ||
1301 | |||
1295 | /** | 1302 | /** |
1296 | * __break_lease - revoke all outstanding leases on file | 1303 | * __break_lease - revoke all outstanding leases on file |
1297 | * @inode: the inode of the file to return | 1304 | * @inode: the inode of the file to return |
1298 | * @mode: the open mode (read or write) | 1305 | * @mode: O_RDONLY: break only write leases; O_WRONLY or O_RDWR: |
1306 | * break all leases | ||
1307 | * @type: FL_LEASE: break leases and delegations; FL_DELEG: break | ||
1308 | * only delegations | ||
1299 | * | 1309 | * |
1300 | * break_lease (inlined for speed) has checked there already is at least | 1310 | * break_lease (inlined for speed) has checked there already is at least |
1301 | * some kind of lock (maybe a lease) on this file. Leases are broken on | 1311 | * some kind of lock (maybe a lease) on this file. Leases are broken on |
1302 | * a call to open() or truncate(). This function can sleep unless you | 1312 | * a call to open() or truncate(). This function can sleep unless you |
1303 | * specified %O_NONBLOCK to your open(). | 1313 | * specified %O_NONBLOCK to your open(). |
1304 | */ | 1314 | */ |
1305 | int __break_lease(struct inode *inode, unsigned int mode) | 1315 | int __break_lease(struct inode *inode, unsigned int mode, unsigned int type) |
1306 | { | 1316 | { |
1307 | int error = 0; | 1317 | int error = 0; |
1308 | struct file_lock *new_fl, *flock; | 1318 | struct file_lock *new_fl, *flock; |
1309 | struct file_lock *fl; | 1319 | struct file_lock *fl; |
1310 | unsigned long break_time; | 1320 | unsigned long break_time; |
1311 | int i_have_this_lease = 0; | 1321 | int i_have_this_lease = 0; |
1322 | bool lease_conflict = false; | ||
1312 | int want_write = (mode & O_ACCMODE) != O_RDONLY; | 1323 | int want_write = (mode & O_ACCMODE) != O_RDONLY; |
1313 | 1324 | ||
1314 | new_fl = lease_alloc(NULL, want_write ? F_WRLCK : F_RDLCK); | 1325 | new_fl = lease_alloc(NULL, want_write ? F_WRLCK : F_RDLCK); |
1315 | if (IS_ERR(new_fl)) | 1326 | if (IS_ERR(new_fl)) |
1316 | return PTR_ERR(new_fl); | 1327 | return PTR_ERR(new_fl); |
1328 | new_fl->fl_flags = type; | ||
1317 | 1329 | ||
1318 | spin_lock(&inode->i_lock); | 1330 | spin_lock(&inode->i_lock); |
1319 | 1331 | ||
@@ -1323,13 +1335,16 @@ int __break_lease(struct inode *inode, unsigned int mode) | |||
1323 | if ((flock == NULL) || !IS_LEASE(flock)) | 1335 | if ((flock == NULL) || !IS_LEASE(flock)) |
1324 | goto out; | 1336 | goto out; |
1325 | 1337 | ||
1326 | if (!locks_conflict(flock, new_fl)) | 1338 | for (fl = flock; fl && IS_LEASE(fl); fl = fl->fl_next) { |
1339 | if (leases_conflict(fl, new_fl)) { | ||
1340 | lease_conflict = true; | ||
1341 | if (fl->fl_owner == current->files) | ||
1342 | i_have_this_lease = 1; | ||
1343 | } | ||
1344 | } | ||
1345 | if (!lease_conflict) | ||
1327 | goto out; | 1346 | goto out; |
1328 | 1347 | ||
1329 | for (fl = flock; fl && IS_LEASE(fl); fl = fl->fl_next) | ||
1330 | if (fl->fl_owner == current->files) | ||
1331 | i_have_this_lease = 1; | ||
1332 | |||
1333 | break_time = 0; | 1348 | break_time = 0; |
1334 | if (lease_break_time > 0) { | 1349 | if (lease_break_time > 0) { |
1335 | break_time = jiffies + lease_break_time * HZ; | 1350 | break_time = jiffies + lease_break_time * HZ; |
@@ -1338,6 +1353,8 @@ int __break_lease(struct inode *inode, unsigned int mode) | |||
1338 | } | 1353 | } |
1339 | 1354 | ||
1340 | for (fl = flock; fl && IS_LEASE(fl); fl = fl->fl_next) { | 1355 | for (fl = flock; fl && IS_LEASE(fl); fl = fl->fl_next) { |
1356 | if (!leases_conflict(fl, new_fl)) | ||
1357 | continue; | ||
1341 | if (want_write) { | 1358 | if (want_write) { |
1342 | if (fl->fl_flags & FL_UNLOCK_PENDING) | 1359 | if (fl->fl_flags & FL_UNLOCK_PENDING) |
1343 | continue; | 1360 | continue; |
@@ -1379,7 +1396,7 @@ restart: | |||
1379 | */ | 1396 | */ |
1380 | for (flock = inode->i_flock; flock && IS_LEASE(flock); | 1397 | for (flock = inode->i_flock; flock && IS_LEASE(flock); |
1381 | flock = flock->fl_next) { | 1398 | flock = flock->fl_next) { |
1382 | if (locks_conflict(new_fl, flock)) | 1399 | if (leases_conflict(new_fl, flock)) |
1383 | goto restart; | 1400 | goto restart; |
1384 | } | 1401 | } |
1385 | error = 0; | 1402 | error = 0; |
@@ -1460,9 +1477,26 @@ static int generic_add_lease(struct file *filp, long arg, struct file_lock **flp | |||
1460 | struct file_lock *fl, **before, **my_before = NULL, *lease; | 1477 | struct file_lock *fl, **before, **my_before = NULL, *lease; |
1461 | struct dentry *dentry = filp->f_path.dentry; | 1478 | struct dentry *dentry = filp->f_path.dentry; |
1462 | struct inode *inode = dentry->d_inode; | 1479 | struct inode *inode = dentry->d_inode; |
1480 | bool is_deleg = (*flp)->fl_flags & FL_DELEG; | ||
1463 | int error; | 1481 | int error; |
1464 | 1482 | ||
1465 | lease = *flp; | 1483 | lease = *flp; |
1484 | /* | ||
1485 | * In the delegation case we need mutual exclusion with | ||
1486 | * a number of operations that take the i_mutex. We trylock | ||
1487 | * because delegations are an optional optimization, and if | ||
1488 | * there's some chance of a conflict--we'd rather not | ||
1489 | * bother, maybe that's a sign this just isn't a good file to | ||
1490 | * hand out a delegation on. | ||
1491 | */ | ||
1492 | if (is_deleg && !mutex_trylock(&inode->i_mutex)) | ||
1493 | return -EAGAIN; | ||
1494 | |||
1495 | if (is_deleg && arg == F_WRLCK) { | ||
1496 | /* Write delegations are not currently supported: */ | ||
1497 | WARN_ON_ONCE(1); | ||
1498 | return -EINVAL; | ||
1499 | } | ||
1466 | 1500 | ||
1467 | error = -EAGAIN; | 1501 | error = -EAGAIN; |
1468 | if ((arg == F_RDLCK) && (atomic_read(&inode->i_writecount) > 0)) | 1502 | if ((arg == F_RDLCK) && (atomic_read(&inode->i_writecount) > 0)) |
@@ -1514,9 +1548,10 @@ static int generic_add_lease(struct file *filp, long arg, struct file_lock **flp | |||
1514 | goto out; | 1548 | goto out; |
1515 | 1549 | ||
1516 | locks_insert_lock(before, lease); | 1550 | locks_insert_lock(before, lease); |
1517 | return 0; | 1551 | error = 0; |
1518 | |||
1519 | out: | 1552 | out: |
1553 | if (is_deleg) | ||
1554 | mutex_unlock(&inode->i_mutex); | ||
1520 | return error; | 1555 | return error; |
1521 | } | 1556 | } |
1522 | 1557 | ||
@@ -1579,7 +1614,7 @@ EXPORT_SYMBOL(generic_setlease); | |||
1579 | 1614 | ||
1580 | static int __vfs_setlease(struct file *filp, long arg, struct file_lock **lease) | 1615 | static int __vfs_setlease(struct file *filp, long arg, struct file_lock **lease) |
1581 | { | 1616 | { |
1582 | if (filp->f_op && filp->f_op->setlease) | 1617 | if (filp->f_op->setlease) |
1583 | return filp->f_op->setlease(filp, arg, lease); | 1618 | return filp->f_op->setlease(filp, arg, lease); |
1584 | else | 1619 | else |
1585 | return generic_setlease(filp, arg, lease); | 1620 | return generic_setlease(filp, arg, lease); |
@@ -1771,7 +1806,7 @@ SYSCALL_DEFINE2(flock, unsigned int, fd, unsigned int, cmd) | |||
1771 | if (error) | 1806 | if (error) |
1772 | goto out_free; | 1807 | goto out_free; |
1773 | 1808 | ||
1774 | if (f.file->f_op && f.file->f_op->flock) | 1809 | if (f.file->f_op->flock) |
1775 | error = f.file->f_op->flock(f.file, | 1810 | error = f.file->f_op->flock(f.file, |
1776 | (can_sleep) ? F_SETLKW : F_SETLK, | 1811 | (can_sleep) ? F_SETLKW : F_SETLK, |
1777 | lock); | 1812 | lock); |
@@ -1797,7 +1832,7 @@ SYSCALL_DEFINE2(flock, unsigned int, fd, unsigned int, cmd) | |||
1797 | */ | 1832 | */ |
1798 | int vfs_test_lock(struct file *filp, struct file_lock *fl) | 1833 | int vfs_test_lock(struct file *filp, struct file_lock *fl) |
1799 | { | 1834 | { |
1800 | if (filp->f_op && filp->f_op->lock) | 1835 | if (filp->f_op->lock) |
1801 | return filp->f_op->lock(filp, F_GETLK, fl); | 1836 | return filp->f_op->lock(filp, F_GETLK, fl); |
1802 | posix_test_lock(filp, fl); | 1837 | posix_test_lock(filp, fl); |
1803 | return 0; | 1838 | return 0; |
@@ -1909,7 +1944,7 @@ out: | |||
1909 | */ | 1944 | */ |
1910 | int vfs_lock_file(struct file *filp, unsigned int cmd, struct file_lock *fl, struct file_lock *conf) | 1945 | int vfs_lock_file(struct file *filp, unsigned int cmd, struct file_lock *fl, struct file_lock *conf) |
1911 | { | 1946 | { |
1912 | if (filp->f_op && filp->f_op->lock) | 1947 | if (filp->f_op->lock) |
1913 | return filp->f_op->lock(filp, cmd, fl); | 1948 | return filp->f_op->lock(filp, cmd, fl); |
1914 | else | 1949 | else |
1915 | return posix_lock_file(filp, fl, conf); | 1950 | return posix_lock_file(filp, fl, conf); |
@@ -2182,7 +2217,7 @@ void locks_remove_flock(struct file *filp) | |||
2182 | if (!inode->i_flock) | 2217 | if (!inode->i_flock) |
2183 | return; | 2218 | return; |
2184 | 2219 | ||
2185 | if (filp->f_op && filp->f_op->flock) { | 2220 | if (filp->f_op->flock) { |
2186 | struct file_lock fl = { | 2221 | struct file_lock fl = { |
2187 | .fl_pid = current->tgid, | 2222 | .fl_pid = current->tgid, |
2188 | .fl_file = filp, | 2223 | .fl_file = filp, |
@@ -2246,7 +2281,7 @@ EXPORT_SYMBOL(posix_unblock_lock); | |||
2246 | */ | 2281 | */ |
2247 | int vfs_cancel_lock(struct file *filp, struct file_lock *fl) | 2282 | int vfs_cancel_lock(struct file *filp, struct file_lock *fl) |
2248 | { | 2283 | { |
2249 | if (filp->f_op && filp->f_op->lock) | 2284 | if (filp->f_op->lock) |
2250 | return filp->f_op->lock(filp, F_CANCELLK, fl); | 2285 | return filp->f_op->lock(filp, F_CANCELLK, fl); |
2251 | return 0; | 2286 | return 0; |
2252 | } | 2287 | } |
diff --git a/fs/mount.h b/fs/mount.h index 64a858143ff9..d64c594be6c4 100644 --- a/fs/mount.h +++ b/fs/mount.h | |||
@@ -29,6 +29,7 @@ struct mount { | |||
29 | struct mount *mnt_parent; | 29 | struct mount *mnt_parent; |
30 | struct dentry *mnt_mountpoint; | 30 | struct dentry *mnt_mountpoint; |
31 | struct vfsmount mnt; | 31 | struct vfsmount mnt; |
32 | struct rcu_head mnt_rcu; | ||
32 | #ifdef CONFIG_SMP | 33 | #ifdef CONFIG_SMP |
33 | struct mnt_pcp __percpu *mnt_pcp; | 34 | struct mnt_pcp __percpu *mnt_pcp; |
34 | #else | 35 | #else |
@@ -55,7 +56,7 @@ struct mount { | |||
55 | int mnt_group_id; /* peer group identifier */ | 56 | int mnt_group_id; /* peer group identifier */ |
56 | int mnt_expiry_mark; /* true if marked for expiry */ | 57 | int mnt_expiry_mark; /* true if marked for expiry */ |
57 | int mnt_pinned; | 58 | int mnt_pinned; |
58 | int mnt_ghosts; | 59 | struct path mnt_ex_mountpoint; |
59 | }; | 60 | }; |
60 | 61 | ||
61 | #define MNT_NS_INTERNAL ERR_PTR(-EINVAL) /* distinct from any mnt_namespace */ | 62 | #define MNT_NS_INTERNAL ERR_PTR(-EINVAL) /* distinct from any mnt_namespace */ |
@@ -76,13 +77,28 @@ static inline int is_mounted(struct vfsmount *mnt) | |||
76 | return !IS_ERR_OR_NULL(real_mount(mnt)); | 77 | return !IS_ERR_OR_NULL(real_mount(mnt)); |
77 | } | 78 | } |
78 | 79 | ||
79 | extern struct mount *__lookup_mnt(struct vfsmount *, struct dentry *, int); | 80 | extern struct mount *__lookup_mnt(struct vfsmount *, struct dentry *); |
81 | extern struct mount *__lookup_mnt_last(struct vfsmount *, struct dentry *); | ||
82 | |||
83 | extern bool legitimize_mnt(struct vfsmount *, unsigned); | ||
80 | 84 | ||
81 | static inline void get_mnt_ns(struct mnt_namespace *ns) | 85 | static inline void get_mnt_ns(struct mnt_namespace *ns) |
82 | { | 86 | { |
83 | atomic_inc(&ns->count); | 87 | atomic_inc(&ns->count); |
84 | } | 88 | } |
85 | 89 | ||
90 | extern seqlock_t mount_lock; | ||
91 | |||
92 | static inline void lock_mount_hash(void) | ||
93 | { | ||
94 | write_seqlock(&mount_lock); | ||
95 | } | ||
96 | |||
97 | static inline void unlock_mount_hash(void) | ||
98 | { | ||
99 | write_sequnlock(&mount_lock); | ||
100 | } | ||
101 | |||
86 | struct proc_mounts { | 102 | struct proc_mounts { |
87 | struct seq_file m; | 103 | struct seq_file m; |
88 | struct mnt_namespace *ns; | 104 | struct mnt_namespace *ns; |
diff --git a/fs/namei.c b/fs/namei.c index caa28051e197..e029a4cbff7d 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -482,18 +482,6 @@ EXPORT_SYMBOL(path_put); | |||
482 | * to restart the path walk from the beginning in ref-walk mode. | 482 | * to restart the path walk from the beginning in ref-walk mode. |
483 | */ | 483 | */ |
484 | 484 | ||
485 | static inline void lock_rcu_walk(void) | ||
486 | { | ||
487 | br_read_lock(&vfsmount_lock); | ||
488 | rcu_read_lock(); | ||
489 | } | ||
490 | |||
491 | static inline void unlock_rcu_walk(void) | ||
492 | { | ||
493 | rcu_read_unlock(); | ||
494 | br_read_unlock(&vfsmount_lock); | ||
495 | } | ||
496 | |||
497 | /** | 485 | /** |
498 | * unlazy_walk - try to switch to ref-walk mode. | 486 | * unlazy_walk - try to switch to ref-walk mode. |
499 | * @nd: nameidata pathwalk data | 487 | * @nd: nameidata pathwalk data |
@@ -512,26 +500,23 @@ static int unlazy_walk(struct nameidata *nd, struct dentry *dentry) | |||
512 | BUG_ON(!(nd->flags & LOOKUP_RCU)); | 500 | BUG_ON(!(nd->flags & LOOKUP_RCU)); |
513 | 501 | ||
514 | /* | 502 | /* |
515 | * Get a reference to the parent first: we're | 503 | * After legitimizing the bastards, terminate_walk() |
516 | * going to make "path_put(nd->path)" valid in | 504 | * will do the right thing for non-RCU mode, and all our |
517 | * non-RCU context for "terminate_walk()". | 505 | * subsequent exit cases should rcu_read_unlock() |
518 | * | 506 | * before returning. Do vfsmount first; if dentry |
519 | * If this doesn't work, return immediately with | 507 | * can't be legitimized, just set nd->path.dentry to NULL |
520 | * RCU walking still active (and then we will do | 508 | * and rely on dput(NULL) being a no-op. |
521 | * the RCU walk cleanup in terminate_walk()). | ||
522 | */ | 509 | */ |
523 | if (!lockref_get_not_dead(&parent->d_lockref)) | 510 | if (!legitimize_mnt(nd->path.mnt, nd->m_seq)) |
524 | return -ECHILD; | 511 | return -ECHILD; |
525 | |||
526 | /* | ||
527 | * After the mntget(), we terminate_walk() will do | ||
528 | * the right thing for non-RCU mode, and all our | ||
529 | * subsequent exit cases should unlock_rcu_walk() | ||
530 | * before returning. | ||
531 | */ | ||
532 | mntget(nd->path.mnt); | ||
533 | nd->flags &= ~LOOKUP_RCU; | 512 | nd->flags &= ~LOOKUP_RCU; |
534 | 513 | ||
514 | if (!lockref_get_not_dead(&parent->d_lockref)) { | ||
515 | nd->path.dentry = NULL; | ||
516 | rcu_read_unlock(); | ||
517 | return -ECHILD; | ||
518 | } | ||
519 | |||
535 | /* | 520 | /* |
536 | * For a negative lookup, the lookup sequence point is the parents | 521 | * For a negative lookup, the lookup sequence point is the parents |
537 | * sequence point, and it only needs to revalidate the parent dentry. | 522 | * sequence point, and it only needs to revalidate the parent dentry. |
@@ -566,17 +551,17 @@ static int unlazy_walk(struct nameidata *nd, struct dentry *dentry) | |||
566 | spin_unlock(&fs->lock); | 551 | spin_unlock(&fs->lock); |
567 | } | 552 | } |
568 | 553 | ||
569 | unlock_rcu_walk(); | 554 | rcu_read_unlock(); |
570 | return 0; | 555 | return 0; |
571 | 556 | ||
572 | unlock_and_drop_dentry: | 557 | unlock_and_drop_dentry: |
573 | spin_unlock(&fs->lock); | 558 | spin_unlock(&fs->lock); |
574 | drop_dentry: | 559 | drop_dentry: |
575 | unlock_rcu_walk(); | 560 | rcu_read_unlock(); |
576 | dput(dentry); | 561 | dput(dentry); |
577 | goto drop_root_mnt; | 562 | goto drop_root_mnt; |
578 | out: | 563 | out: |
579 | unlock_rcu_walk(); | 564 | rcu_read_unlock(); |
580 | drop_root_mnt: | 565 | drop_root_mnt: |
581 | if (!(nd->flags & LOOKUP_ROOT)) | 566 | if (!(nd->flags & LOOKUP_ROOT)) |
582 | nd->root.mnt = NULL; | 567 | nd->root.mnt = NULL; |
@@ -608,17 +593,22 @@ static int complete_walk(struct nameidata *nd) | |||
608 | if (!(nd->flags & LOOKUP_ROOT)) | 593 | if (!(nd->flags & LOOKUP_ROOT)) |
609 | nd->root.mnt = NULL; | 594 | nd->root.mnt = NULL; |
610 | 595 | ||
596 | if (!legitimize_mnt(nd->path.mnt, nd->m_seq)) { | ||
597 | rcu_read_unlock(); | ||
598 | return -ECHILD; | ||
599 | } | ||
611 | if (unlikely(!lockref_get_not_dead(&dentry->d_lockref))) { | 600 | if (unlikely(!lockref_get_not_dead(&dentry->d_lockref))) { |
612 | unlock_rcu_walk(); | 601 | rcu_read_unlock(); |
602 | mntput(nd->path.mnt); | ||
613 | return -ECHILD; | 603 | return -ECHILD; |
614 | } | 604 | } |
615 | if (read_seqcount_retry(&dentry->d_seq, nd->seq)) { | 605 | if (read_seqcount_retry(&dentry->d_seq, nd->seq)) { |
616 | unlock_rcu_walk(); | 606 | rcu_read_unlock(); |
617 | dput(dentry); | 607 | dput(dentry); |
608 | mntput(nd->path.mnt); | ||
618 | return -ECHILD; | 609 | return -ECHILD; |
619 | } | 610 | } |
620 | mntget(nd->path.mnt); | 611 | rcu_read_unlock(); |
621 | unlock_rcu_walk(); | ||
622 | } | 612 | } |
623 | 613 | ||
624 | if (likely(!(nd->flags & LOOKUP_JUMPED))) | 614 | if (likely(!(nd->flags & LOOKUP_JUMPED))) |
@@ -909,15 +899,15 @@ int follow_up(struct path *path) | |||
909 | struct mount *parent; | 899 | struct mount *parent; |
910 | struct dentry *mountpoint; | 900 | struct dentry *mountpoint; |
911 | 901 | ||
912 | br_read_lock(&vfsmount_lock); | 902 | read_seqlock_excl(&mount_lock); |
913 | parent = mnt->mnt_parent; | 903 | parent = mnt->mnt_parent; |
914 | if (parent == mnt) { | 904 | if (parent == mnt) { |
915 | br_read_unlock(&vfsmount_lock); | 905 | read_sequnlock_excl(&mount_lock); |
916 | return 0; | 906 | return 0; |
917 | } | 907 | } |
918 | mntget(&parent->mnt); | 908 | mntget(&parent->mnt); |
919 | mountpoint = dget(mnt->mnt_mountpoint); | 909 | mountpoint = dget(mnt->mnt_mountpoint); |
920 | br_read_unlock(&vfsmount_lock); | 910 | read_sequnlock_excl(&mount_lock); |
921 | dput(path->dentry); | 911 | dput(path->dentry); |
922 | path->dentry = mountpoint; | 912 | path->dentry = mountpoint; |
923 | mntput(path->mnt); | 913 | mntput(path->mnt); |
@@ -1048,8 +1038,8 @@ static int follow_managed(struct path *path, unsigned flags) | |||
1048 | 1038 | ||
1049 | /* Something is mounted on this dentry in another | 1039 | /* Something is mounted on this dentry in another |
1050 | * namespace and/or whatever was mounted there in this | 1040 | * namespace and/or whatever was mounted there in this |
1051 | * namespace got unmounted before we managed to get the | 1041 | * namespace got unmounted before lookup_mnt() could |
1052 | * vfsmount_lock */ | 1042 | * get it */ |
1053 | } | 1043 | } |
1054 | 1044 | ||
1055 | /* Handle an automount point */ | 1045 | /* Handle an automount point */ |
@@ -1111,7 +1101,7 @@ static bool __follow_mount_rcu(struct nameidata *nd, struct path *path, | |||
1111 | if (!d_mountpoint(path->dentry)) | 1101 | if (!d_mountpoint(path->dentry)) |
1112 | break; | 1102 | break; |
1113 | 1103 | ||
1114 | mounted = __lookup_mnt(path->mnt, path->dentry, 1); | 1104 | mounted = __lookup_mnt(path->mnt, path->dentry); |
1115 | if (!mounted) | 1105 | if (!mounted) |
1116 | break; | 1106 | break; |
1117 | path->mnt = &mounted->mnt; | 1107 | path->mnt = &mounted->mnt; |
@@ -1132,7 +1122,7 @@ static void follow_mount_rcu(struct nameidata *nd) | |||
1132 | { | 1122 | { |
1133 | while (d_mountpoint(nd->path.dentry)) { | 1123 | while (d_mountpoint(nd->path.dentry)) { |
1134 | struct mount *mounted; | 1124 | struct mount *mounted; |
1135 | mounted = __lookup_mnt(nd->path.mnt, nd->path.dentry, 1); | 1125 | mounted = __lookup_mnt(nd->path.mnt, nd->path.dentry); |
1136 | if (!mounted) | 1126 | if (!mounted) |
1137 | break; | 1127 | break; |
1138 | nd->path.mnt = &mounted->mnt; | 1128 | nd->path.mnt = &mounted->mnt; |
@@ -1174,7 +1164,7 @@ failed: | |||
1174 | nd->flags &= ~LOOKUP_RCU; | 1164 | nd->flags &= ~LOOKUP_RCU; |
1175 | if (!(nd->flags & LOOKUP_ROOT)) | 1165 | if (!(nd->flags & LOOKUP_ROOT)) |
1176 | nd->root.mnt = NULL; | 1166 | nd->root.mnt = NULL; |
1177 | unlock_rcu_walk(); | 1167 | rcu_read_unlock(); |
1178 | return -ECHILD; | 1168 | return -ECHILD; |
1179 | } | 1169 | } |
1180 | 1170 | ||
@@ -1308,8 +1298,8 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir, | |||
1308 | } | 1298 | } |
1309 | 1299 | ||
1310 | /* | 1300 | /* |
1311 | * Call i_op->lookup on the dentry. The dentry must be negative but may be | 1301 | * Call i_op->lookup on the dentry. The dentry must be negative and |
1312 | * hashed if it was pouplated with DCACHE_NEED_LOOKUP. | 1302 | * unhashed. |
1313 | * | 1303 | * |
1314 | * dir->d_inode->i_mutex must be held | 1304 | * dir->d_inode->i_mutex must be held |
1315 | */ | 1305 | */ |
@@ -1501,7 +1491,7 @@ static void terminate_walk(struct nameidata *nd) | |||
1501 | nd->flags &= ~LOOKUP_RCU; | 1491 | nd->flags &= ~LOOKUP_RCU; |
1502 | if (!(nd->flags & LOOKUP_ROOT)) | 1492 | if (!(nd->flags & LOOKUP_ROOT)) |
1503 | nd->root.mnt = NULL; | 1493 | nd->root.mnt = NULL; |
1504 | unlock_rcu_walk(); | 1494 | rcu_read_unlock(); |
1505 | } | 1495 | } |
1506 | } | 1496 | } |
1507 | 1497 | ||
@@ -1511,18 +1501,9 @@ static void terminate_walk(struct nameidata *nd) | |||
1511 | * so we keep a cache of "no, this doesn't need follow_link" | 1501 | * so we keep a cache of "no, this doesn't need follow_link" |
1512 | * for the common case. | 1502 | * for the common case. |
1513 | */ | 1503 | */ |
1514 | static inline int should_follow_link(struct inode *inode, int follow) | 1504 | static inline int should_follow_link(struct dentry *dentry, int follow) |
1515 | { | 1505 | { |
1516 | if (unlikely(!(inode->i_opflags & IOP_NOFOLLOW))) { | 1506 | return unlikely(d_is_symlink(dentry)) ? follow : 0; |
1517 | if (likely(inode->i_op->follow_link)) | ||
1518 | return follow; | ||
1519 | |||
1520 | /* This gets set once for the inode lifetime */ | ||
1521 | spin_lock(&inode->i_lock); | ||
1522 | inode->i_opflags |= IOP_NOFOLLOW; | ||
1523 | spin_unlock(&inode->i_lock); | ||
1524 | } | ||
1525 | return 0; | ||
1526 | } | 1507 | } |
1527 | 1508 | ||
1528 | static inline int walk_component(struct nameidata *nd, struct path *path, | 1509 | static inline int walk_component(struct nameidata *nd, struct path *path, |
@@ -1552,7 +1533,7 @@ static inline int walk_component(struct nameidata *nd, struct path *path, | |||
1552 | if (!inode) | 1533 | if (!inode) |
1553 | goto out_path_put; | 1534 | goto out_path_put; |
1554 | 1535 | ||
1555 | if (should_follow_link(inode, follow)) { | 1536 | if (should_follow_link(path->dentry, follow)) { |
1556 | if (nd->flags & LOOKUP_RCU) { | 1537 | if (nd->flags & LOOKUP_RCU) { |
1557 | if (unlikely(unlazy_walk(nd, path->dentry))) { | 1538 | if (unlikely(unlazy_walk(nd, path->dentry))) { |
1558 | err = -ECHILD; | 1539 | err = -ECHILD; |
@@ -1611,26 +1592,6 @@ static inline int nested_symlink(struct path *path, struct nameidata *nd) | |||
1611 | } | 1592 | } |
1612 | 1593 | ||
1613 | /* | 1594 | /* |
1614 | * We really don't want to look at inode->i_op->lookup | ||
1615 | * when we don't have to. So we keep a cache bit in | ||
1616 | * the inode ->i_opflags field that says "yes, we can | ||
1617 | * do lookup on this inode". | ||
1618 | */ | ||
1619 | static inline int can_lookup(struct inode *inode) | ||
1620 | { | ||
1621 | if (likely(inode->i_opflags & IOP_LOOKUP)) | ||
1622 | return 1; | ||
1623 | if (likely(!inode->i_op->lookup)) | ||
1624 | return 0; | ||
1625 | |||
1626 | /* We do this once for the lifetime of the inode */ | ||
1627 | spin_lock(&inode->i_lock); | ||
1628 | inode->i_opflags |= IOP_LOOKUP; | ||
1629 | spin_unlock(&inode->i_lock); | ||
1630 | return 1; | ||
1631 | } | ||
1632 | |||
1633 | /* | ||
1634 | * We can do the critical dentry name comparison and hashing | 1595 | * We can do the critical dentry name comparison and hashing |
1635 | * operations one word at a time, but we are limited to: | 1596 | * operations one word at a time, but we are limited to: |
1636 | * | 1597 | * |
@@ -1833,7 +1794,7 @@ static int link_path_walk(const char *name, struct nameidata *nd) | |||
1833 | if (err) | 1794 | if (err) |
1834 | return err; | 1795 | return err; |
1835 | } | 1796 | } |
1836 | if (!can_lookup(nd->inode)) { | 1797 | if (!d_is_directory(nd->path.dentry)) { |
1837 | err = -ENOTDIR; | 1798 | err = -ENOTDIR; |
1838 | break; | 1799 | break; |
1839 | } | 1800 | } |
@@ -1851,9 +1812,10 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1851 | nd->flags = flags | LOOKUP_JUMPED; | 1812 | nd->flags = flags | LOOKUP_JUMPED; |
1852 | nd->depth = 0; | 1813 | nd->depth = 0; |
1853 | if (flags & LOOKUP_ROOT) { | 1814 | if (flags & LOOKUP_ROOT) { |
1854 | struct inode *inode = nd->root.dentry->d_inode; | 1815 | struct dentry *root = nd->root.dentry; |
1816 | struct inode *inode = root->d_inode; | ||
1855 | if (*name) { | 1817 | if (*name) { |
1856 | if (!can_lookup(inode)) | 1818 | if (!d_is_directory(root)) |
1857 | return -ENOTDIR; | 1819 | return -ENOTDIR; |
1858 | retval = inode_permission(inode, MAY_EXEC); | 1820 | retval = inode_permission(inode, MAY_EXEC); |
1859 | if (retval) | 1821 | if (retval) |
@@ -1862,8 +1824,9 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1862 | nd->path = nd->root; | 1824 | nd->path = nd->root; |
1863 | nd->inode = inode; | 1825 | nd->inode = inode; |
1864 | if (flags & LOOKUP_RCU) { | 1826 | if (flags & LOOKUP_RCU) { |
1865 | lock_rcu_walk(); | 1827 | rcu_read_lock(); |
1866 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); | 1828 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); |
1829 | nd->m_seq = read_seqbegin(&mount_lock); | ||
1867 | } else { | 1830 | } else { |
1868 | path_get(&nd->path); | 1831 | path_get(&nd->path); |
1869 | } | 1832 | } |
@@ -1872,9 +1835,10 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1872 | 1835 | ||
1873 | nd->root.mnt = NULL; | 1836 | nd->root.mnt = NULL; |
1874 | 1837 | ||
1838 | nd->m_seq = read_seqbegin(&mount_lock); | ||
1875 | if (*name=='/') { | 1839 | if (*name=='/') { |
1876 | if (flags & LOOKUP_RCU) { | 1840 | if (flags & LOOKUP_RCU) { |
1877 | lock_rcu_walk(); | 1841 | rcu_read_lock(); |
1878 | set_root_rcu(nd); | 1842 | set_root_rcu(nd); |
1879 | } else { | 1843 | } else { |
1880 | set_root(nd); | 1844 | set_root(nd); |
@@ -1886,7 +1850,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1886 | struct fs_struct *fs = current->fs; | 1850 | struct fs_struct *fs = current->fs; |
1887 | unsigned seq; | 1851 | unsigned seq; |
1888 | 1852 | ||
1889 | lock_rcu_walk(); | 1853 | rcu_read_lock(); |
1890 | 1854 | ||
1891 | do { | 1855 | do { |
1892 | seq = read_seqcount_begin(&fs->seq); | 1856 | seq = read_seqcount_begin(&fs->seq); |
@@ -1907,7 +1871,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1907 | dentry = f.file->f_path.dentry; | 1871 | dentry = f.file->f_path.dentry; |
1908 | 1872 | ||
1909 | if (*name) { | 1873 | if (*name) { |
1910 | if (!can_lookup(dentry->d_inode)) { | 1874 | if (!d_is_directory(dentry)) { |
1911 | fdput(f); | 1875 | fdput(f); |
1912 | return -ENOTDIR; | 1876 | return -ENOTDIR; |
1913 | } | 1877 | } |
@@ -1918,7 +1882,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1918 | if (f.need_put) | 1882 | if (f.need_put) |
1919 | *fp = f.file; | 1883 | *fp = f.file; |
1920 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); | 1884 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); |
1921 | lock_rcu_walk(); | 1885 | rcu_read_lock(); |
1922 | } else { | 1886 | } else { |
1923 | path_get(&nd->path); | 1887 | path_get(&nd->path); |
1924 | fdput(f); | 1888 | fdput(f); |
@@ -1989,7 +1953,7 @@ static int path_lookupat(int dfd, const char *name, | |||
1989 | err = complete_walk(nd); | 1953 | err = complete_walk(nd); |
1990 | 1954 | ||
1991 | if (!err && nd->flags & LOOKUP_DIRECTORY) { | 1955 | if (!err && nd->flags & LOOKUP_DIRECTORY) { |
1992 | if (!can_lookup(nd->inode)) { | 1956 | if (!d_is_directory(nd->path.dentry)) { |
1993 | path_put(&nd->path); | 1957 | path_put(&nd->path); |
1994 | err = -ENOTDIR; | 1958 | err = -ENOTDIR; |
1995 | } | 1959 | } |
@@ -2281,7 +2245,7 @@ done: | |||
2281 | } | 2245 | } |
2282 | path->dentry = dentry; | 2246 | path->dentry = dentry; |
2283 | path->mnt = mntget(nd->path.mnt); | 2247 | path->mnt = mntget(nd->path.mnt); |
2284 | if (should_follow_link(dentry->d_inode, nd->flags & LOOKUP_FOLLOW)) | 2248 | if (should_follow_link(dentry, nd->flags & LOOKUP_FOLLOW)) |
2285 | return 1; | 2249 | return 1; |
2286 | follow_mount(path); | 2250 | follow_mount(path); |
2287 | error = 0; | 2251 | error = 0; |
@@ -2426,12 +2390,14 @@ static inline int check_sticky(struct inode *dir, struct inode *inode) | |||
2426 | * 10. We don't allow removal of NFS sillyrenamed files; it's handled by | 2390 | * 10. We don't allow removal of NFS sillyrenamed files; it's handled by |
2427 | * nfs_async_unlink(). | 2391 | * nfs_async_unlink(). |
2428 | */ | 2392 | */ |
2429 | static int may_delete(struct inode *dir,struct dentry *victim,int isdir) | 2393 | static int may_delete(struct inode *dir, struct dentry *victim, bool isdir) |
2430 | { | 2394 | { |
2395 | struct inode *inode = victim->d_inode; | ||
2431 | int error; | 2396 | int error; |
2432 | 2397 | ||
2433 | if (!victim->d_inode) | 2398 | if (d_is_negative(victim)) |
2434 | return -ENOENT; | 2399 | return -ENOENT; |
2400 | BUG_ON(!inode); | ||
2435 | 2401 | ||
2436 | BUG_ON(victim->d_parent->d_inode != dir); | 2402 | BUG_ON(victim->d_parent->d_inode != dir); |
2437 | audit_inode_child(dir, victim, AUDIT_TYPE_CHILD_DELETE); | 2403 | audit_inode_child(dir, victim, AUDIT_TYPE_CHILD_DELETE); |
@@ -2441,15 +2407,16 @@ static int may_delete(struct inode *dir,struct dentry *victim,int isdir) | |||
2441 | return error; | 2407 | return error; |
2442 | if (IS_APPEND(dir)) | 2408 | if (IS_APPEND(dir)) |
2443 | return -EPERM; | 2409 | return -EPERM; |
2444 | if (check_sticky(dir, victim->d_inode)||IS_APPEND(victim->d_inode)|| | 2410 | |
2445 | IS_IMMUTABLE(victim->d_inode) || IS_SWAPFILE(victim->d_inode)) | 2411 | if (check_sticky(dir, inode) || IS_APPEND(inode) || |
2412 | IS_IMMUTABLE(inode) || IS_SWAPFILE(inode)) | ||
2446 | return -EPERM; | 2413 | return -EPERM; |
2447 | if (isdir) { | 2414 | if (isdir) { |
2448 | if (!S_ISDIR(victim->d_inode->i_mode)) | 2415 | if (!d_is_directory(victim) && !d_is_autodir(victim)) |
2449 | return -ENOTDIR; | 2416 | return -ENOTDIR; |
2450 | if (IS_ROOT(victim)) | 2417 | if (IS_ROOT(victim)) |
2451 | return -EBUSY; | 2418 | return -EBUSY; |
2452 | } else if (S_ISDIR(victim->d_inode->i_mode)) | 2419 | } else if (d_is_directory(victim) || d_is_autodir(victim)) |
2453 | return -EISDIR; | 2420 | return -EISDIR; |
2454 | if (IS_DEADDIR(dir)) | 2421 | if (IS_DEADDIR(dir)) |
2455 | return -ENOENT; | 2422 | return -ENOENT; |
@@ -2983,7 +2950,7 @@ retry_lookup: | |||
2983 | /* | 2950 | /* |
2984 | * create/update audit record if it already exists. | 2951 | * create/update audit record if it already exists. |
2985 | */ | 2952 | */ |
2986 | if (path->dentry->d_inode) | 2953 | if (d_is_positive(path->dentry)) |
2987 | audit_inode(name, path->dentry, 0); | 2954 | audit_inode(name, path->dentry, 0); |
2988 | 2955 | ||
2989 | /* | 2956 | /* |
@@ -3012,12 +2979,12 @@ retry_lookup: | |||
3012 | finish_lookup: | 2979 | finish_lookup: |
3013 | /* we _can_ be in RCU mode here */ | 2980 | /* we _can_ be in RCU mode here */ |
3014 | error = -ENOENT; | 2981 | error = -ENOENT; |
3015 | if (!inode) { | 2982 | if (d_is_negative(path->dentry)) { |
3016 | path_to_nameidata(path, nd); | 2983 | path_to_nameidata(path, nd); |
3017 | goto out; | 2984 | goto out; |
3018 | } | 2985 | } |
3019 | 2986 | ||
3020 | if (should_follow_link(inode, !symlink_ok)) { | 2987 | if (should_follow_link(path->dentry, !symlink_ok)) { |
3021 | if (nd->flags & LOOKUP_RCU) { | 2988 | if (nd->flags & LOOKUP_RCU) { |
3022 | if (unlikely(unlazy_walk(nd, path->dentry))) { | 2989 | if (unlikely(unlazy_walk(nd, path->dentry))) { |
3023 | error = -ECHILD; | 2990 | error = -ECHILD; |
@@ -3046,10 +3013,11 @@ finish_open: | |||
3046 | } | 3013 | } |
3047 | audit_inode(name, nd->path.dentry, 0); | 3014 | audit_inode(name, nd->path.dentry, 0); |
3048 | error = -EISDIR; | 3015 | error = -EISDIR; |
3049 | if ((open_flag & O_CREAT) && S_ISDIR(nd->inode->i_mode)) | 3016 | if ((open_flag & O_CREAT) && |
3017 | (d_is_directory(nd->path.dentry) || d_is_autodir(nd->path.dentry))) | ||
3050 | goto out; | 3018 | goto out; |
3051 | error = -ENOTDIR; | 3019 | error = -ENOTDIR; |
3052 | if ((nd->flags & LOOKUP_DIRECTORY) && !can_lookup(nd->inode)) | 3020 | if ((nd->flags & LOOKUP_DIRECTORY) && !d_is_directory(nd->path.dentry)) |
3053 | goto out; | 3021 | goto out; |
3054 | if (!S_ISREG(nd->inode->i_mode)) | 3022 | if (!S_ISREG(nd->inode->i_mode)) |
3055 | will_truncate = false; | 3023 | will_truncate = false; |
@@ -3275,7 +3243,7 @@ struct file *do_file_open_root(struct dentry *dentry, struct vfsmount *mnt, | |||
3275 | nd.root.mnt = mnt; | 3243 | nd.root.mnt = mnt; |
3276 | nd.root.dentry = dentry; | 3244 | nd.root.dentry = dentry; |
3277 | 3245 | ||
3278 | if (dentry->d_inode->i_op->follow_link && op->intent & LOOKUP_OPEN) | 3246 | if (d_is_symlink(dentry) && op->intent & LOOKUP_OPEN) |
3279 | return ERR_PTR(-ELOOP); | 3247 | return ERR_PTR(-ELOOP); |
3280 | 3248 | ||
3281 | file = path_openat(-1, &filename, &nd, op, flags | LOOKUP_RCU); | 3249 | file = path_openat(-1, &filename, &nd, op, flags | LOOKUP_RCU); |
@@ -3325,8 +3293,9 @@ struct dentry *kern_path_create(int dfd, const char *pathname, | |||
3325 | goto unlock; | 3293 | goto unlock; |
3326 | 3294 | ||
3327 | error = -EEXIST; | 3295 | error = -EEXIST; |
3328 | if (dentry->d_inode) | 3296 | if (d_is_positive(dentry)) |
3329 | goto fail; | 3297 | goto fail; |
3298 | |||
3330 | /* | 3299 | /* |
3331 | * Special case - lookup gave negative, but... we had foo/bar/ | 3300 | * Special case - lookup gave negative, but... we had foo/bar/ |
3332 | * From the vfs_mknod() POV we just have a negative dentry - | 3301 | * From the vfs_mknod() POV we just have a negative dentry - |
@@ -3647,8 +3616,27 @@ SYSCALL_DEFINE1(rmdir, const char __user *, pathname) | |||
3647 | return do_rmdir(AT_FDCWD, pathname); | 3616 | return do_rmdir(AT_FDCWD, pathname); |
3648 | } | 3617 | } |
3649 | 3618 | ||
3650 | int vfs_unlink(struct inode *dir, struct dentry *dentry) | 3619 | /** |
3620 | * vfs_unlink - unlink a filesystem object | ||
3621 | * @dir: parent directory | ||
3622 | * @dentry: victim | ||
3623 | * @delegated_inode: returns victim inode, if the inode is delegated. | ||
3624 | * | ||
3625 | * The caller must hold dir->i_mutex. | ||
3626 | * | ||
3627 | * If vfs_unlink discovers a delegation, it will return -EWOULDBLOCK and | ||
3628 | * return a reference to the inode in delegated_inode. The caller | ||
3629 | * should then break the delegation on that inode and retry. Because | ||
3630 | * breaking a delegation may take a long time, the caller should drop | ||
3631 | * dir->i_mutex before doing so. | ||
3632 | * | ||
3633 | * Alternatively, a caller may pass NULL for delegated_inode. This may | ||
3634 | * be appropriate for callers that expect the underlying filesystem not | ||
3635 | * to be NFS exported. | ||
3636 | */ | ||
3637 | int vfs_unlink(struct inode *dir, struct dentry *dentry, struct inode **delegated_inode) | ||
3651 | { | 3638 | { |
3639 | struct inode *target = dentry->d_inode; | ||
3652 | int error = may_delete(dir, dentry, 0); | 3640 | int error = may_delete(dir, dentry, 0); |
3653 | 3641 | ||
3654 | if (error) | 3642 | if (error) |
@@ -3657,22 +3645,26 @@ int vfs_unlink(struct inode *dir, struct dentry *dentry) | |||
3657 | if (!dir->i_op->unlink) | 3645 | if (!dir->i_op->unlink) |
3658 | return -EPERM; | 3646 | return -EPERM; |
3659 | 3647 | ||
3660 | mutex_lock(&dentry->d_inode->i_mutex); | 3648 | mutex_lock(&target->i_mutex); |
3661 | if (d_mountpoint(dentry)) | 3649 | if (d_mountpoint(dentry)) |
3662 | error = -EBUSY; | 3650 | error = -EBUSY; |
3663 | else { | 3651 | else { |
3664 | error = security_inode_unlink(dir, dentry); | 3652 | error = security_inode_unlink(dir, dentry); |
3665 | if (!error) { | 3653 | if (!error) { |
3654 | error = try_break_deleg(target, delegated_inode); | ||
3655 | if (error) | ||
3656 | goto out; | ||
3666 | error = dir->i_op->unlink(dir, dentry); | 3657 | error = dir->i_op->unlink(dir, dentry); |
3667 | if (!error) | 3658 | if (!error) |
3668 | dont_mount(dentry); | 3659 | dont_mount(dentry); |
3669 | } | 3660 | } |
3670 | } | 3661 | } |
3671 | mutex_unlock(&dentry->d_inode->i_mutex); | 3662 | out: |
3663 | mutex_unlock(&target->i_mutex); | ||
3672 | 3664 | ||
3673 | /* We don't d_delete() NFS sillyrenamed files--they still exist. */ | 3665 | /* We don't d_delete() NFS sillyrenamed files--they still exist. */ |
3674 | if (!error && !(dentry->d_flags & DCACHE_NFSFS_RENAMED)) { | 3666 | if (!error && !(dentry->d_flags & DCACHE_NFSFS_RENAMED)) { |
3675 | fsnotify_link_count(dentry->d_inode); | 3667 | fsnotify_link_count(target); |
3676 | d_delete(dentry); | 3668 | d_delete(dentry); |
3677 | } | 3669 | } |
3678 | 3670 | ||
@@ -3692,6 +3684,7 @@ static long do_unlinkat(int dfd, const char __user *pathname) | |||
3692 | struct dentry *dentry; | 3684 | struct dentry *dentry; |
3693 | struct nameidata nd; | 3685 | struct nameidata nd; |
3694 | struct inode *inode = NULL; | 3686 | struct inode *inode = NULL; |
3687 | struct inode *delegated_inode = NULL; | ||
3695 | unsigned int lookup_flags = 0; | 3688 | unsigned int lookup_flags = 0; |
3696 | retry: | 3689 | retry: |
3697 | name = user_path_parent(dfd, pathname, &nd, lookup_flags); | 3690 | name = user_path_parent(dfd, pathname, &nd, lookup_flags); |
@@ -3706,7 +3699,7 @@ retry: | |||
3706 | error = mnt_want_write(nd.path.mnt); | 3699 | error = mnt_want_write(nd.path.mnt); |
3707 | if (error) | 3700 | if (error) |
3708 | goto exit1; | 3701 | goto exit1; |
3709 | 3702 | retry_deleg: | |
3710 | mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT); | 3703 | mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT); |
3711 | dentry = lookup_hash(&nd); | 3704 | dentry = lookup_hash(&nd); |
3712 | error = PTR_ERR(dentry); | 3705 | error = PTR_ERR(dentry); |
@@ -3715,19 +3708,25 @@ retry: | |||
3715 | if (nd.last.name[nd.last.len]) | 3708 | if (nd.last.name[nd.last.len]) |
3716 | goto slashes; | 3709 | goto slashes; |
3717 | inode = dentry->d_inode; | 3710 | inode = dentry->d_inode; |
3718 | if (!inode) | 3711 | if (d_is_negative(dentry)) |
3719 | goto slashes; | 3712 | goto slashes; |
3720 | ihold(inode); | 3713 | ihold(inode); |
3721 | error = security_path_unlink(&nd.path, dentry); | 3714 | error = security_path_unlink(&nd.path, dentry); |
3722 | if (error) | 3715 | if (error) |
3723 | goto exit2; | 3716 | goto exit2; |
3724 | error = vfs_unlink(nd.path.dentry->d_inode, dentry); | 3717 | error = vfs_unlink(nd.path.dentry->d_inode, dentry, &delegated_inode); |
3725 | exit2: | 3718 | exit2: |
3726 | dput(dentry); | 3719 | dput(dentry); |
3727 | } | 3720 | } |
3728 | mutex_unlock(&nd.path.dentry->d_inode->i_mutex); | 3721 | mutex_unlock(&nd.path.dentry->d_inode->i_mutex); |
3729 | if (inode) | 3722 | if (inode) |
3730 | iput(inode); /* truncate the inode here */ | 3723 | iput(inode); /* truncate the inode here */ |
3724 | inode = NULL; | ||
3725 | if (delegated_inode) { | ||
3726 | error = break_deleg_wait(&delegated_inode); | ||
3727 | if (!error) | ||
3728 | goto retry_deleg; | ||
3729 | } | ||
3731 | mnt_drop_write(nd.path.mnt); | 3730 | mnt_drop_write(nd.path.mnt); |
3732 | exit1: | 3731 | exit1: |
3733 | path_put(&nd.path); | 3732 | path_put(&nd.path); |
@@ -3740,8 +3739,12 @@ exit1: | |||
3740 | return error; | 3739 | return error; |
3741 | 3740 | ||
3742 | slashes: | 3741 | slashes: |
3743 | error = !dentry->d_inode ? -ENOENT : | 3742 | if (d_is_negative(dentry)) |
3744 | S_ISDIR(dentry->d_inode->i_mode) ? -EISDIR : -ENOTDIR; | 3743 | error = -ENOENT; |
3744 | else if (d_is_directory(dentry) || d_is_autodir(dentry)) | ||
3745 | error = -EISDIR; | ||
3746 | else | ||
3747 | error = -ENOTDIR; | ||
3745 | goto exit2; | 3748 | goto exit2; |
3746 | } | 3749 | } |
3747 | 3750 | ||
@@ -3817,7 +3820,26 @@ SYSCALL_DEFINE2(symlink, const char __user *, oldname, const char __user *, newn | |||
3817 | return sys_symlinkat(oldname, AT_FDCWD, newname); | 3820 | return sys_symlinkat(oldname, AT_FDCWD, newname); |
3818 | } | 3821 | } |
3819 | 3822 | ||
3820 | int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry) | 3823 | /** |
3824 | * vfs_link - create a new link | ||
3825 | * @old_dentry: object to be linked | ||
3826 | * @dir: new parent | ||
3827 | * @new_dentry: where to create the new link | ||
3828 | * @delegated_inode: returns inode needing a delegation break | ||
3829 | * | ||
3830 | * The caller must hold dir->i_mutex | ||
3831 | * | ||
3832 | * If vfs_link discovers a delegation on the to-be-linked file in need | ||
3833 | * of breaking, it will return -EWOULDBLOCK and return a reference to the | ||
3834 | * inode in delegated_inode. The caller should then break the delegation | ||
3835 | * and retry. Because breaking a delegation may take a long time, the | ||
3836 | * caller should drop the i_mutex before doing so. | ||
3837 | * | ||
3838 | * Alternatively, a caller may pass NULL for delegated_inode. This may | ||
3839 | * be appropriate for callers that expect the underlying filesystem not | ||
3840 | * to be NFS exported. | ||
3841 | */ | ||
3842 | int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry, struct inode **delegated_inode) | ||
3821 | { | 3843 | { |
3822 | struct inode *inode = old_dentry->d_inode; | 3844 | struct inode *inode = old_dentry->d_inode; |
3823 | unsigned max_links = dir->i_sb->s_max_links; | 3845 | unsigned max_links = dir->i_sb->s_max_links; |
@@ -3853,8 +3875,11 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de | |||
3853 | error = -ENOENT; | 3875 | error = -ENOENT; |
3854 | else if (max_links && inode->i_nlink >= max_links) | 3876 | else if (max_links && inode->i_nlink >= max_links) |
3855 | error = -EMLINK; | 3877 | error = -EMLINK; |
3856 | else | 3878 | else { |
3857 | error = dir->i_op->link(old_dentry, dir, new_dentry); | 3879 | error = try_break_deleg(inode, delegated_inode); |
3880 | if (!error) | ||
3881 | error = dir->i_op->link(old_dentry, dir, new_dentry); | ||
3882 | } | ||
3858 | 3883 | ||
3859 | if (!error && (inode->i_state & I_LINKABLE)) { | 3884 | if (!error && (inode->i_state & I_LINKABLE)) { |
3860 | spin_lock(&inode->i_lock); | 3885 | spin_lock(&inode->i_lock); |
@@ -3881,6 +3906,7 @@ SYSCALL_DEFINE5(linkat, int, olddfd, const char __user *, oldname, | |||
3881 | { | 3906 | { |
3882 | struct dentry *new_dentry; | 3907 | struct dentry *new_dentry; |
3883 | struct path old_path, new_path; | 3908 | struct path old_path, new_path; |
3909 | struct inode *delegated_inode = NULL; | ||
3884 | int how = 0; | 3910 | int how = 0; |
3885 | int error; | 3911 | int error; |
3886 | 3912 | ||
@@ -3919,9 +3945,14 @@ retry: | |||
3919 | error = security_path_link(old_path.dentry, &new_path, new_dentry); | 3945 | error = security_path_link(old_path.dentry, &new_path, new_dentry); |
3920 | if (error) | 3946 | if (error) |
3921 | goto out_dput; | 3947 | goto out_dput; |
3922 | error = vfs_link(old_path.dentry, new_path.dentry->d_inode, new_dentry); | 3948 | error = vfs_link(old_path.dentry, new_path.dentry->d_inode, new_dentry, &delegated_inode); |
3923 | out_dput: | 3949 | out_dput: |
3924 | done_path_create(&new_path, new_dentry); | 3950 | done_path_create(&new_path, new_dentry); |
3951 | if (delegated_inode) { | ||
3952 | error = break_deleg_wait(&delegated_inode); | ||
3953 | if (!error) | ||
3954 | goto retry; | ||
3955 | } | ||
3925 | if (retry_estale(error, how)) { | 3956 | if (retry_estale(error, how)) { |
3926 | how |= LOOKUP_REVAL; | 3957 | how |= LOOKUP_REVAL; |
3927 | goto retry; | 3958 | goto retry; |
@@ -3946,7 +3977,8 @@ SYSCALL_DEFINE2(link, const char __user *, oldname, const char __user *, newname | |||
3946 | * That's where 4.4 screws up. Current fix: serialization on | 3977 | * That's where 4.4 screws up. Current fix: serialization on |
3947 | * sb->s_vfs_rename_mutex. We might be more accurate, but that's another | 3978 | * sb->s_vfs_rename_mutex. We might be more accurate, but that's another |
3948 | * story. | 3979 | * story. |
3949 | * c) we have to lock _three_ objects - parents and victim (if it exists). | 3980 | * c) we have to lock _four_ objects - parents and victim (if it exists), |
3981 | * and source (if it is not a directory). | ||
3950 | * And that - after we got ->i_mutex on parents (until then we don't know | 3982 | * And that - after we got ->i_mutex on parents (until then we don't know |
3951 | * whether the target exists). Solution: try to be smart with locking | 3983 | * whether the target exists). Solution: try to be smart with locking |
3952 | * order for inodes. We rely on the fact that tree topology may change | 3984 | * order for inodes. We rely on the fact that tree topology may change |
@@ -4019,9 +4051,11 @@ out: | |||
4019 | } | 4051 | } |
4020 | 4052 | ||
4021 | static int vfs_rename_other(struct inode *old_dir, struct dentry *old_dentry, | 4053 | static int vfs_rename_other(struct inode *old_dir, struct dentry *old_dentry, |
4022 | struct inode *new_dir, struct dentry *new_dentry) | 4054 | struct inode *new_dir, struct dentry *new_dentry, |
4055 | struct inode **delegated_inode) | ||
4023 | { | 4056 | { |
4024 | struct inode *target = new_dentry->d_inode; | 4057 | struct inode *target = new_dentry->d_inode; |
4058 | struct inode *source = old_dentry->d_inode; | ||
4025 | int error; | 4059 | int error; |
4026 | 4060 | ||
4027 | error = security_inode_rename(old_dir, old_dentry, new_dir, new_dentry); | 4061 | error = security_inode_rename(old_dir, old_dentry, new_dir, new_dentry); |
@@ -4029,13 +4063,20 @@ static int vfs_rename_other(struct inode *old_dir, struct dentry *old_dentry, | |||
4029 | return error; | 4063 | return error; |
4030 | 4064 | ||
4031 | dget(new_dentry); | 4065 | dget(new_dentry); |
4032 | if (target) | 4066 | lock_two_nondirectories(source, target); |
4033 | mutex_lock(&target->i_mutex); | ||
4034 | 4067 | ||
4035 | error = -EBUSY; | 4068 | error = -EBUSY; |
4036 | if (d_mountpoint(old_dentry)||d_mountpoint(new_dentry)) | 4069 | if (d_mountpoint(old_dentry)||d_mountpoint(new_dentry)) |
4037 | goto out; | 4070 | goto out; |
4038 | 4071 | ||
4072 | error = try_break_deleg(source, delegated_inode); | ||
4073 | if (error) | ||
4074 | goto out; | ||
4075 | if (target) { | ||
4076 | error = try_break_deleg(target, delegated_inode); | ||
4077 | if (error) | ||
4078 | goto out; | ||
4079 | } | ||
4039 | error = old_dir->i_op->rename(old_dir, old_dentry, new_dir, new_dentry); | 4080 | error = old_dir->i_op->rename(old_dir, old_dentry, new_dir, new_dentry); |
4040 | if (error) | 4081 | if (error) |
4041 | goto out; | 4082 | goto out; |
@@ -4045,17 +4086,38 @@ static int vfs_rename_other(struct inode *old_dir, struct dentry *old_dentry, | |||
4045 | if (!(old_dir->i_sb->s_type->fs_flags & FS_RENAME_DOES_D_MOVE)) | 4086 | if (!(old_dir->i_sb->s_type->fs_flags & FS_RENAME_DOES_D_MOVE)) |
4046 | d_move(old_dentry, new_dentry); | 4087 | d_move(old_dentry, new_dentry); |
4047 | out: | 4088 | out: |
4048 | if (target) | 4089 | unlock_two_nondirectories(source, target); |
4049 | mutex_unlock(&target->i_mutex); | ||
4050 | dput(new_dentry); | 4090 | dput(new_dentry); |
4051 | return error; | 4091 | return error; |
4052 | } | 4092 | } |
4053 | 4093 | ||
4094 | /** | ||
4095 | * vfs_rename - rename a filesystem object | ||
4096 | * @old_dir: parent of source | ||
4097 | * @old_dentry: source | ||
4098 | * @new_dir: parent of destination | ||
4099 | * @new_dentry: destination | ||
4100 | * @delegated_inode: returns an inode needing a delegation break | ||
4101 | * | ||
4102 | * The caller must hold multiple mutexes--see lock_rename()). | ||
4103 | * | ||
4104 | * If vfs_rename discovers a delegation in need of breaking at either | ||
4105 | * the source or destination, it will return -EWOULDBLOCK and return a | ||
4106 | * reference to the inode in delegated_inode. The caller should then | ||
4107 | * break the delegation and retry. Because breaking a delegation may | ||
4108 | * take a long time, the caller should drop all locks before doing | ||
4109 | * so. | ||
4110 | * | ||
4111 | * Alternatively, a caller may pass NULL for delegated_inode. This may | ||
4112 | * be appropriate for callers that expect the underlying filesystem not | ||
4113 | * to be NFS exported. | ||
4114 | */ | ||
4054 | int vfs_rename(struct inode *old_dir, struct dentry *old_dentry, | 4115 | int vfs_rename(struct inode *old_dir, struct dentry *old_dentry, |
4055 | struct inode *new_dir, struct dentry *new_dentry) | 4116 | struct inode *new_dir, struct dentry *new_dentry, |
4117 | struct inode **delegated_inode) | ||
4056 | { | 4118 | { |
4057 | int error; | 4119 | int error; |
4058 | int is_dir = S_ISDIR(old_dentry->d_inode->i_mode); | 4120 | int is_dir = d_is_directory(old_dentry) || d_is_autodir(old_dentry); |
4059 | const unsigned char *old_name; | 4121 | const unsigned char *old_name; |
4060 | 4122 | ||
4061 | if (old_dentry->d_inode == new_dentry->d_inode) | 4123 | if (old_dentry->d_inode == new_dentry->d_inode) |
@@ -4080,7 +4142,7 @@ int vfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
4080 | if (is_dir) | 4142 | if (is_dir) |
4081 | error = vfs_rename_dir(old_dir,old_dentry,new_dir,new_dentry); | 4143 | error = vfs_rename_dir(old_dir,old_dentry,new_dir,new_dentry); |
4082 | else | 4144 | else |
4083 | error = vfs_rename_other(old_dir,old_dentry,new_dir,new_dentry); | 4145 | error = vfs_rename_other(old_dir,old_dentry,new_dir,new_dentry,delegated_inode); |
4084 | if (!error) | 4146 | if (!error) |
4085 | fsnotify_move(old_dir, new_dir, old_name, is_dir, | 4147 | fsnotify_move(old_dir, new_dir, old_name, is_dir, |
4086 | new_dentry->d_inode, old_dentry); | 4148 | new_dentry->d_inode, old_dentry); |
@@ -4096,6 +4158,7 @@ SYSCALL_DEFINE4(renameat, int, olddfd, const char __user *, oldname, | |||
4096 | struct dentry *old_dentry, *new_dentry; | 4158 | struct dentry *old_dentry, *new_dentry; |
4097 | struct dentry *trap; | 4159 | struct dentry *trap; |
4098 | struct nameidata oldnd, newnd; | 4160 | struct nameidata oldnd, newnd; |
4161 | struct inode *delegated_inode = NULL; | ||
4099 | struct filename *from; | 4162 | struct filename *from; |
4100 | struct filename *to; | 4163 | struct filename *to; |
4101 | unsigned int lookup_flags = 0; | 4164 | unsigned int lookup_flags = 0; |
@@ -4135,6 +4198,7 @@ retry: | |||
4135 | newnd.flags &= ~LOOKUP_PARENT; | 4198 | newnd.flags &= ~LOOKUP_PARENT; |
4136 | newnd.flags |= LOOKUP_RENAME_TARGET; | 4199 | newnd.flags |= LOOKUP_RENAME_TARGET; |
4137 | 4200 | ||
4201 | retry_deleg: | ||
4138 | trap = lock_rename(new_dir, old_dir); | 4202 | trap = lock_rename(new_dir, old_dir); |
4139 | 4203 | ||
4140 | old_dentry = lookup_hash(&oldnd); | 4204 | old_dentry = lookup_hash(&oldnd); |
@@ -4143,10 +4207,10 @@ retry: | |||
4143 | goto exit3; | 4207 | goto exit3; |
4144 | /* source must exist */ | 4208 | /* source must exist */ |
4145 | error = -ENOENT; | 4209 | error = -ENOENT; |
4146 | if (!old_dentry->d_inode) | 4210 | if (d_is_negative(old_dentry)) |
4147 | goto exit4; | 4211 | goto exit4; |
4148 | /* unless the source is a directory trailing slashes give -ENOTDIR */ | 4212 | /* unless the source is a directory trailing slashes give -ENOTDIR */ |
4149 | if (!S_ISDIR(old_dentry->d_inode->i_mode)) { | 4213 | if (!d_is_directory(old_dentry) && !d_is_autodir(old_dentry)) { |
4150 | error = -ENOTDIR; | 4214 | error = -ENOTDIR; |
4151 | if (oldnd.last.name[oldnd.last.len]) | 4215 | if (oldnd.last.name[oldnd.last.len]) |
4152 | goto exit4; | 4216 | goto exit4; |
@@ -4171,13 +4235,19 @@ retry: | |||
4171 | if (error) | 4235 | if (error) |
4172 | goto exit5; | 4236 | goto exit5; |
4173 | error = vfs_rename(old_dir->d_inode, old_dentry, | 4237 | error = vfs_rename(old_dir->d_inode, old_dentry, |
4174 | new_dir->d_inode, new_dentry); | 4238 | new_dir->d_inode, new_dentry, |
4239 | &delegated_inode); | ||
4175 | exit5: | 4240 | exit5: |
4176 | dput(new_dentry); | 4241 | dput(new_dentry); |
4177 | exit4: | 4242 | exit4: |
4178 | dput(old_dentry); | 4243 | dput(old_dentry); |
4179 | exit3: | 4244 | exit3: |
4180 | unlock_rename(new_dir, old_dir); | 4245 | unlock_rename(new_dir, old_dir); |
4246 | if (delegated_inode) { | ||
4247 | error = break_deleg_wait(&delegated_inode); | ||
4248 | if (!error) | ||
4249 | goto retry_deleg; | ||
4250 | } | ||
4181 | mnt_drop_write(oldnd.path.mnt); | 4251 | mnt_drop_write(oldnd.path.mnt); |
4182 | exit2: | 4252 | exit2: |
4183 | if (retry_estale(error, lookup_flags)) | 4253 | if (retry_estale(error, lookup_flags)) |
diff --git a/fs/namespace.c b/fs/namespace.c index da5c49483430..ac2ce8a766e1 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
@@ -39,7 +39,7 @@ static int mnt_group_start = 1; | |||
39 | static struct list_head *mount_hashtable __read_mostly; | 39 | static struct list_head *mount_hashtable __read_mostly; |
40 | static struct list_head *mountpoint_hashtable __read_mostly; | 40 | static struct list_head *mountpoint_hashtable __read_mostly; |
41 | static struct kmem_cache *mnt_cache __read_mostly; | 41 | static struct kmem_cache *mnt_cache __read_mostly; |
42 | static struct rw_semaphore namespace_sem; | 42 | static DECLARE_RWSEM(namespace_sem); |
43 | 43 | ||
44 | /* /sys/fs */ | 44 | /* /sys/fs */ |
45 | struct kobject *fs_kobj; | 45 | struct kobject *fs_kobj; |
@@ -53,7 +53,7 @@ EXPORT_SYMBOL_GPL(fs_kobj); | |||
53 | * It should be taken for write in all cases where the vfsmount | 53 | * It should be taken for write in all cases where the vfsmount |
54 | * tree or hash is modified or when a vfsmount structure is modified. | 54 | * tree or hash is modified or when a vfsmount structure is modified. |
55 | */ | 55 | */ |
56 | DEFINE_BRLOCK(vfsmount_lock); | 56 | __cacheline_aligned_in_smp DEFINE_SEQLOCK(mount_lock); |
57 | 57 | ||
58 | static inline unsigned long hash(struct vfsmount *mnt, struct dentry *dentry) | 58 | static inline unsigned long hash(struct vfsmount *mnt, struct dentry *dentry) |
59 | { | 59 | { |
@@ -63,8 +63,6 @@ static inline unsigned long hash(struct vfsmount *mnt, struct dentry *dentry) | |||
63 | return tmp & (HASH_SIZE - 1); | 63 | return tmp & (HASH_SIZE - 1); |
64 | } | 64 | } |
65 | 65 | ||
66 | #define MNT_WRITER_UNDERFLOW_LIMIT -(1<<16) | ||
67 | |||
68 | /* | 66 | /* |
69 | * allocation is serialized by namespace_sem, but we need the spinlock to | 67 | * allocation is serialized by namespace_sem, but we need the spinlock to |
70 | * serialize with freeing. | 68 | * serialize with freeing. |
@@ -458,7 +456,7 @@ static int mnt_make_readonly(struct mount *mnt) | |||
458 | { | 456 | { |
459 | int ret = 0; | 457 | int ret = 0; |
460 | 458 | ||
461 | br_write_lock(&vfsmount_lock); | 459 | lock_mount_hash(); |
462 | mnt->mnt.mnt_flags |= MNT_WRITE_HOLD; | 460 | mnt->mnt.mnt_flags |= MNT_WRITE_HOLD; |
463 | /* | 461 | /* |
464 | * After storing MNT_WRITE_HOLD, we'll read the counters. This store | 462 | * After storing MNT_WRITE_HOLD, we'll read the counters. This store |
@@ -492,15 +490,15 @@ static int mnt_make_readonly(struct mount *mnt) | |||
492 | */ | 490 | */ |
493 | smp_wmb(); | 491 | smp_wmb(); |
494 | mnt->mnt.mnt_flags &= ~MNT_WRITE_HOLD; | 492 | mnt->mnt.mnt_flags &= ~MNT_WRITE_HOLD; |
495 | br_write_unlock(&vfsmount_lock); | 493 | unlock_mount_hash(); |
496 | return ret; | 494 | return ret; |
497 | } | 495 | } |
498 | 496 | ||
499 | static void __mnt_unmake_readonly(struct mount *mnt) | 497 | static void __mnt_unmake_readonly(struct mount *mnt) |
500 | { | 498 | { |
501 | br_write_lock(&vfsmount_lock); | 499 | lock_mount_hash(); |
502 | mnt->mnt.mnt_flags &= ~MNT_READONLY; | 500 | mnt->mnt.mnt_flags &= ~MNT_READONLY; |
503 | br_write_unlock(&vfsmount_lock); | 501 | unlock_mount_hash(); |
504 | } | 502 | } |
505 | 503 | ||
506 | int sb_prepare_remount_readonly(struct super_block *sb) | 504 | int sb_prepare_remount_readonly(struct super_block *sb) |
@@ -512,7 +510,7 @@ int sb_prepare_remount_readonly(struct super_block *sb) | |||
512 | if (atomic_long_read(&sb->s_remove_count)) | 510 | if (atomic_long_read(&sb->s_remove_count)) |
513 | return -EBUSY; | 511 | return -EBUSY; |
514 | 512 | ||
515 | br_write_lock(&vfsmount_lock); | 513 | lock_mount_hash(); |
516 | list_for_each_entry(mnt, &sb->s_mounts, mnt_instance) { | 514 | list_for_each_entry(mnt, &sb->s_mounts, mnt_instance) { |
517 | if (!(mnt->mnt.mnt_flags & MNT_READONLY)) { | 515 | if (!(mnt->mnt.mnt_flags & MNT_READONLY)) { |
518 | mnt->mnt.mnt_flags |= MNT_WRITE_HOLD; | 516 | mnt->mnt.mnt_flags |= MNT_WRITE_HOLD; |
@@ -534,7 +532,7 @@ int sb_prepare_remount_readonly(struct super_block *sb) | |||
534 | if (mnt->mnt.mnt_flags & MNT_WRITE_HOLD) | 532 | if (mnt->mnt.mnt_flags & MNT_WRITE_HOLD) |
535 | mnt->mnt.mnt_flags &= ~MNT_WRITE_HOLD; | 533 | mnt->mnt.mnt_flags &= ~MNT_WRITE_HOLD; |
536 | } | 534 | } |
537 | br_write_unlock(&vfsmount_lock); | 535 | unlock_mount_hash(); |
538 | 536 | ||
539 | return err; | 537 | return err; |
540 | } | 538 | } |
@@ -549,30 +547,56 @@ static void free_vfsmnt(struct mount *mnt) | |||
549 | kmem_cache_free(mnt_cache, mnt); | 547 | kmem_cache_free(mnt_cache, mnt); |
550 | } | 548 | } |
551 | 549 | ||
550 | /* call under rcu_read_lock */ | ||
551 | bool legitimize_mnt(struct vfsmount *bastard, unsigned seq) | ||
552 | { | ||
553 | struct mount *mnt; | ||
554 | if (read_seqretry(&mount_lock, seq)) | ||
555 | return false; | ||
556 | if (bastard == NULL) | ||
557 | return true; | ||
558 | mnt = real_mount(bastard); | ||
559 | mnt_add_count(mnt, 1); | ||
560 | if (likely(!read_seqretry(&mount_lock, seq))) | ||
561 | return true; | ||
562 | if (bastard->mnt_flags & MNT_SYNC_UMOUNT) { | ||
563 | mnt_add_count(mnt, -1); | ||
564 | return false; | ||
565 | } | ||
566 | rcu_read_unlock(); | ||
567 | mntput(bastard); | ||
568 | rcu_read_lock(); | ||
569 | return false; | ||
570 | } | ||
571 | |||
552 | /* | 572 | /* |
553 | * find the first or last mount at @dentry on vfsmount @mnt depending on | 573 | * find the first mount at @dentry on vfsmount @mnt. |
554 | * @dir. If @dir is set return the first mount else return the last mount. | 574 | * call under rcu_read_lock() |
555 | * vfsmount_lock must be held for read or write. | ||
556 | */ | 575 | */ |
557 | struct mount *__lookup_mnt(struct vfsmount *mnt, struct dentry *dentry, | 576 | struct mount *__lookup_mnt(struct vfsmount *mnt, struct dentry *dentry) |
558 | int dir) | ||
559 | { | 577 | { |
560 | struct list_head *head = mount_hashtable + hash(mnt, dentry); | 578 | struct list_head *head = mount_hashtable + hash(mnt, dentry); |
561 | struct list_head *tmp = head; | 579 | struct mount *p; |
562 | struct mount *p, *found = NULL; | ||
563 | 580 | ||
564 | for (;;) { | 581 | list_for_each_entry_rcu(p, head, mnt_hash) |
565 | tmp = dir ? tmp->next : tmp->prev; | 582 | if (&p->mnt_parent->mnt == mnt && p->mnt_mountpoint == dentry) |
566 | p = NULL; | 583 | return p; |
567 | if (tmp == head) | 584 | return NULL; |
568 | break; | 585 | } |
569 | p = list_entry(tmp, struct mount, mnt_hash); | 586 | |
570 | if (&p->mnt_parent->mnt == mnt && p->mnt_mountpoint == dentry) { | 587 | /* |
571 | found = p; | 588 | * find the last mount at @dentry on vfsmount @mnt. |
572 | break; | 589 | * mount_lock must be held. |
573 | } | 590 | */ |
574 | } | 591 | struct mount *__lookup_mnt_last(struct vfsmount *mnt, struct dentry *dentry) |
575 | return found; | 592 | { |
593 | struct list_head *head = mount_hashtable + hash(mnt, dentry); | ||
594 | struct mount *p; | ||
595 | |||
596 | list_for_each_entry_reverse(p, head, mnt_hash) | ||
597 | if (&p->mnt_parent->mnt == mnt && p->mnt_mountpoint == dentry) | ||
598 | return p; | ||
599 | return NULL; | ||
576 | } | 600 | } |
577 | 601 | ||
578 | /* | 602 | /* |
@@ -594,17 +618,17 @@ struct mount *__lookup_mnt(struct vfsmount *mnt, struct dentry *dentry, | |||
594 | struct vfsmount *lookup_mnt(struct path *path) | 618 | struct vfsmount *lookup_mnt(struct path *path) |
595 | { | 619 | { |
596 | struct mount *child_mnt; | 620 | struct mount *child_mnt; |
621 | struct vfsmount *m; | ||
622 | unsigned seq; | ||
597 | 623 | ||
598 | br_read_lock(&vfsmount_lock); | 624 | rcu_read_lock(); |
599 | child_mnt = __lookup_mnt(path->mnt, path->dentry, 1); | 625 | do { |
600 | if (child_mnt) { | 626 | seq = read_seqbegin(&mount_lock); |
601 | mnt_add_count(child_mnt, 1); | 627 | child_mnt = __lookup_mnt(path->mnt, path->dentry); |
602 | br_read_unlock(&vfsmount_lock); | 628 | m = child_mnt ? &child_mnt->mnt : NULL; |
603 | return &child_mnt->mnt; | 629 | } while (!legitimize_mnt(m, seq)); |
604 | } else { | 630 | rcu_read_unlock(); |
605 | br_read_unlock(&vfsmount_lock); | 631 | return m; |
606 | return NULL; | ||
607 | } | ||
608 | } | 632 | } |
609 | 633 | ||
610 | static struct mountpoint *new_mountpoint(struct dentry *dentry) | 634 | static struct mountpoint *new_mountpoint(struct dentry *dentry) |
@@ -796,9 +820,9 @@ vfs_kern_mount(struct file_system_type *type, int flags, const char *name, void | |||
796 | mnt->mnt.mnt_sb = root->d_sb; | 820 | mnt->mnt.mnt_sb = root->d_sb; |
797 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; | 821 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; |
798 | mnt->mnt_parent = mnt; | 822 | mnt->mnt_parent = mnt; |
799 | br_write_lock(&vfsmount_lock); | 823 | lock_mount_hash(); |
800 | list_add_tail(&mnt->mnt_instance, &root->d_sb->s_mounts); | 824 | list_add_tail(&mnt->mnt_instance, &root->d_sb->s_mounts); |
801 | br_write_unlock(&vfsmount_lock); | 825 | unlock_mount_hash(); |
802 | return &mnt->mnt; | 826 | return &mnt->mnt; |
803 | } | 827 | } |
804 | EXPORT_SYMBOL_GPL(vfs_kern_mount); | 828 | EXPORT_SYMBOL_GPL(vfs_kern_mount); |
@@ -839,9 +863,9 @@ static struct mount *clone_mnt(struct mount *old, struct dentry *root, | |||
839 | mnt->mnt.mnt_root = dget(root); | 863 | mnt->mnt.mnt_root = dget(root); |
840 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; | 864 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; |
841 | mnt->mnt_parent = mnt; | 865 | mnt->mnt_parent = mnt; |
842 | br_write_lock(&vfsmount_lock); | 866 | lock_mount_hash(); |
843 | list_add_tail(&mnt->mnt_instance, &sb->s_mounts); | 867 | list_add_tail(&mnt->mnt_instance, &sb->s_mounts); |
844 | br_write_unlock(&vfsmount_lock); | 868 | unlock_mount_hash(); |
845 | 869 | ||
846 | if ((flag & CL_SLAVE) || | 870 | if ((flag & CL_SLAVE) || |
847 | ((flag & CL_SHARED_TO_SLAVE) && IS_MNT_SHARED(old))) { | 871 | ((flag & CL_SHARED_TO_SLAVE) && IS_MNT_SHARED(old))) { |
@@ -872,64 +896,66 @@ static struct mount *clone_mnt(struct mount *old, struct dentry *root, | |||
872 | return ERR_PTR(err); | 896 | return ERR_PTR(err); |
873 | } | 897 | } |
874 | 898 | ||
875 | static inline void mntfree(struct mount *mnt) | 899 | static void delayed_free(struct rcu_head *head) |
876 | { | 900 | { |
877 | struct vfsmount *m = &mnt->mnt; | 901 | struct mount *mnt = container_of(head, struct mount, mnt_rcu); |
878 | struct super_block *sb = m->mnt_sb; | 902 | kfree(mnt->mnt_devname); |
879 | 903 | #ifdef CONFIG_SMP | |
880 | /* | 904 | free_percpu(mnt->mnt_pcp); |
881 | * This probably indicates that somebody messed | 905 | #endif |
882 | * up a mnt_want/drop_write() pair. If this | 906 | kmem_cache_free(mnt_cache, mnt); |
883 | * happens, the filesystem was probably unable | ||
884 | * to make r/w->r/o transitions. | ||
885 | */ | ||
886 | /* | ||
887 | * The locking used to deal with mnt_count decrement provides barriers, | ||
888 | * so mnt_get_writers() below is safe. | ||
889 | */ | ||
890 | WARN_ON(mnt_get_writers(mnt)); | ||
891 | fsnotify_vfsmount_delete(m); | ||
892 | dput(m->mnt_root); | ||
893 | free_vfsmnt(mnt); | ||
894 | deactivate_super(sb); | ||
895 | } | 907 | } |
896 | 908 | ||
897 | static void mntput_no_expire(struct mount *mnt) | 909 | static void mntput_no_expire(struct mount *mnt) |
898 | { | 910 | { |
899 | put_again: | 911 | put_again: |
900 | #ifdef CONFIG_SMP | 912 | rcu_read_lock(); |
901 | br_read_lock(&vfsmount_lock); | 913 | mnt_add_count(mnt, -1); |
902 | if (likely(mnt->mnt_ns)) { | 914 | if (likely(mnt->mnt_ns)) { /* shouldn't be the last one */ |
903 | /* shouldn't be the last one */ | 915 | rcu_read_unlock(); |
904 | mnt_add_count(mnt, -1); | ||
905 | br_read_unlock(&vfsmount_lock); | ||
906 | return; | 916 | return; |
907 | } | 917 | } |
908 | br_read_unlock(&vfsmount_lock); | 918 | lock_mount_hash(); |
909 | |||
910 | br_write_lock(&vfsmount_lock); | ||
911 | mnt_add_count(mnt, -1); | ||
912 | if (mnt_get_count(mnt)) { | 919 | if (mnt_get_count(mnt)) { |
913 | br_write_unlock(&vfsmount_lock); | 920 | rcu_read_unlock(); |
921 | unlock_mount_hash(); | ||
914 | return; | 922 | return; |
915 | } | 923 | } |
916 | #else | ||
917 | mnt_add_count(mnt, -1); | ||
918 | if (likely(mnt_get_count(mnt))) | ||
919 | return; | ||
920 | br_write_lock(&vfsmount_lock); | ||
921 | #endif | ||
922 | if (unlikely(mnt->mnt_pinned)) { | 924 | if (unlikely(mnt->mnt_pinned)) { |
923 | mnt_add_count(mnt, mnt->mnt_pinned + 1); | 925 | mnt_add_count(mnt, mnt->mnt_pinned + 1); |
924 | mnt->mnt_pinned = 0; | 926 | mnt->mnt_pinned = 0; |
925 | br_write_unlock(&vfsmount_lock); | 927 | rcu_read_unlock(); |
928 | unlock_mount_hash(); | ||
926 | acct_auto_close_mnt(&mnt->mnt); | 929 | acct_auto_close_mnt(&mnt->mnt); |
927 | goto put_again; | 930 | goto put_again; |
928 | } | 931 | } |
932 | if (unlikely(mnt->mnt.mnt_flags & MNT_DOOMED)) { | ||
933 | rcu_read_unlock(); | ||
934 | unlock_mount_hash(); | ||
935 | return; | ||
936 | } | ||
937 | mnt->mnt.mnt_flags |= MNT_DOOMED; | ||
938 | rcu_read_unlock(); | ||
929 | 939 | ||
930 | list_del(&mnt->mnt_instance); | 940 | list_del(&mnt->mnt_instance); |
931 | br_write_unlock(&vfsmount_lock); | 941 | unlock_mount_hash(); |
932 | mntfree(mnt); | 942 | |
943 | /* | ||
944 | * This probably indicates that somebody messed | ||
945 | * up a mnt_want/drop_write() pair. If this | ||
946 | * happens, the filesystem was probably unable | ||
947 | * to make r/w->r/o transitions. | ||
948 | */ | ||
949 | /* | ||
950 | * The locking used to deal with mnt_count decrement provides barriers, | ||
951 | * so mnt_get_writers() below is safe. | ||
952 | */ | ||
953 | WARN_ON(mnt_get_writers(mnt)); | ||
954 | fsnotify_vfsmount_delete(&mnt->mnt); | ||
955 | dput(mnt->mnt.mnt_root); | ||
956 | deactivate_super(mnt->mnt.mnt_sb); | ||
957 | mnt_free_id(mnt); | ||
958 | call_rcu(&mnt->mnt_rcu, delayed_free); | ||
933 | } | 959 | } |
934 | 960 | ||
935 | void mntput(struct vfsmount *mnt) | 961 | void mntput(struct vfsmount *mnt) |
@@ -954,21 +980,21 @@ EXPORT_SYMBOL(mntget); | |||
954 | 980 | ||
955 | void mnt_pin(struct vfsmount *mnt) | 981 | void mnt_pin(struct vfsmount *mnt) |
956 | { | 982 | { |
957 | br_write_lock(&vfsmount_lock); | 983 | lock_mount_hash(); |
958 | real_mount(mnt)->mnt_pinned++; | 984 | real_mount(mnt)->mnt_pinned++; |
959 | br_write_unlock(&vfsmount_lock); | 985 | unlock_mount_hash(); |
960 | } | 986 | } |
961 | EXPORT_SYMBOL(mnt_pin); | 987 | EXPORT_SYMBOL(mnt_pin); |
962 | 988 | ||
963 | void mnt_unpin(struct vfsmount *m) | 989 | void mnt_unpin(struct vfsmount *m) |
964 | { | 990 | { |
965 | struct mount *mnt = real_mount(m); | 991 | struct mount *mnt = real_mount(m); |
966 | br_write_lock(&vfsmount_lock); | 992 | lock_mount_hash(); |
967 | if (mnt->mnt_pinned) { | 993 | if (mnt->mnt_pinned) { |
968 | mnt_add_count(mnt, 1); | 994 | mnt_add_count(mnt, 1); |
969 | mnt->mnt_pinned--; | 995 | mnt->mnt_pinned--; |
970 | } | 996 | } |
971 | br_write_unlock(&vfsmount_lock); | 997 | unlock_mount_hash(); |
972 | } | 998 | } |
973 | EXPORT_SYMBOL(mnt_unpin); | 999 | EXPORT_SYMBOL(mnt_unpin); |
974 | 1000 | ||
@@ -1085,12 +1111,12 @@ int may_umount_tree(struct vfsmount *m) | |||
1085 | BUG_ON(!m); | 1111 | BUG_ON(!m); |
1086 | 1112 | ||
1087 | /* write lock needed for mnt_get_count */ | 1113 | /* write lock needed for mnt_get_count */ |
1088 | br_write_lock(&vfsmount_lock); | 1114 | lock_mount_hash(); |
1089 | for (p = mnt; p; p = next_mnt(p, mnt)) { | 1115 | for (p = mnt; p; p = next_mnt(p, mnt)) { |
1090 | actual_refs += mnt_get_count(p); | 1116 | actual_refs += mnt_get_count(p); |
1091 | minimum_refs += 2; | 1117 | minimum_refs += 2; |
1092 | } | 1118 | } |
1093 | br_write_unlock(&vfsmount_lock); | 1119 | unlock_mount_hash(); |
1094 | 1120 | ||
1095 | if (actual_refs > minimum_refs) | 1121 | if (actual_refs > minimum_refs) |
1096 | return 0; | 1122 | return 0; |
@@ -1117,10 +1143,10 @@ int may_umount(struct vfsmount *mnt) | |||
1117 | { | 1143 | { |
1118 | int ret = 1; | 1144 | int ret = 1; |
1119 | down_read(&namespace_sem); | 1145 | down_read(&namespace_sem); |
1120 | br_write_lock(&vfsmount_lock); | 1146 | lock_mount_hash(); |
1121 | if (propagate_mount_busy(real_mount(mnt), 2)) | 1147 | if (propagate_mount_busy(real_mount(mnt), 2)) |
1122 | ret = 0; | 1148 | ret = 0; |
1123 | br_write_unlock(&vfsmount_lock); | 1149 | unlock_mount_hash(); |
1124 | up_read(&namespace_sem); | 1150 | up_read(&namespace_sem); |
1125 | return ret; | 1151 | return ret; |
1126 | } | 1152 | } |
@@ -1142,23 +1168,13 @@ static void namespace_unlock(void) | |||
1142 | list_splice_init(&unmounted, &head); | 1168 | list_splice_init(&unmounted, &head); |
1143 | up_write(&namespace_sem); | 1169 | up_write(&namespace_sem); |
1144 | 1170 | ||
1171 | synchronize_rcu(); | ||
1172 | |||
1145 | while (!list_empty(&head)) { | 1173 | while (!list_empty(&head)) { |
1146 | mnt = list_first_entry(&head, struct mount, mnt_hash); | 1174 | mnt = list_first_entry(&head, struct mount, mnt_hash); |
1147 | list_del_init(&mnt->mnt_hash); | 1175 | list_del_init(&mnt->mnt_hash); |
1148 | if (mnt_has_parent(mnt)) { | 1176 | if (mnt->mnt_ex_mountpoint.mnt) |
1149 | struct dentry *dentry; | 1177 | path_put(&mnt->mnt_ex_mountpoint); |
1150 | struct mount *m; | ||
1151 | |||
1152 | br_write_lock(&vfsmount_lock); | ||
1153 | dentry = mnt->mnt_mountpoint; | ||
1154 | m = mnt->mnt_parent; | ||
1155 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; | ||
1156 | mnt->mnt_parent = mnt; | ||
1157 | m->mnt_ghosts--; | ||
1158 | br_write_unlock(&vfsmount_lock); | ||
1159 | dput(dentry); | ||
1160 | mntput(&m->mnt); | ||
1161 | } | ||
1162 | mntput(&mnt->mnt); | 1178 | mntput(&mnt->mnt); |
1163 | } | 1179 | } |
1164 | } | 1180 | } |
@@ -1169,10 +1185,13 @@ static inline void namespace_lock(void) | |||
1169 | } | 1185 | } |
1170 | 1186 | ||
1171 | /* | 1187 | /* |
1172 | * vfsmount lock must be held for write | 1188 | * mount_lock must be held |
1173 | * namespace_sem must be held for write | 1189 | * namespace_sem must be held for write |
1190 | * how = 0 => just this tree, don't propagate | ||
1191 | * how = 1 => propagate; we know that nobody else has reference to any victims | ||
1192 | * how = 2 => lazy umount | ||
1174 | */ | 1193 | */ |
1175 | void umount_tree(struct mount *mnt, int propagate) | 1194 | void umount_tree(struct mount *mnt, int how) |
1176 | { | 1195 | { |
1177 | LIST_HEAD(tmp_list); | 1196 | LIST_HEAD(tmp_list); |
1178 | struct mount *p; | 1197 | struct mount *p; |
@@ -1180,7 +1199,7 @@ void umount_tree(struct mount *mnt, int propagate) | |||
1180 | for (p = mnt; p; p = next_mnt(p, mnt)) | 1199 | for (p = mnt; p; p = next_mnt(p, mnt)) |
1181 | list_move(&p->mnt_hash, &tmp_list); | 1200 | list_move(&p->mnt_hash, &tmp_list); |
1182 | 1201 | ||
1183 | if (propagate) | 1202 | if (how) |
1184 | propagate_umount(&tmp_list); | 1203 | propagate_umount(&tmp_list); |
1185 | 1204 | ||
1186 | list_for_each_entry(p, &tmp_list, mnt_hash) { | 1205 | list_for_each_entry(p, &tmp_list, mnt_hash) { |
@@ -1188,10 +1207,16 @@ void umount_tree(struct mount *mnt, int propagate) | |||
1188 | list_del_init(&p->mnt_list); | 1207 | list_del_init(&p->mnt_list); |
1189 | __touch_mnt_namespace(p->mnt_ns); | 1208 | __touch_mnt_namespace(p->mnt_ns); |
1190 | p->mnt_ns = NULL; | 1209 | p->mnt_ns = NULL; |
1210 | if (how < 2) | ||
1211 | p->mnt.mnt_flags |= MNT_SYNC_UMOUNT; | ||
1191 | list_del_init(&p->mnt_child); | 1212 | list_del_init(&p->mnt_child); |
1192 | if (mnt_has_parent(p)) { | 1213 | if (mnt_has_parent(p)) { |
1193 | p->mnt_parent->mnt_ghosts++; | ||
1194 | put_mountpoint(p->mnt_mp); | 1214 | put_mountpoint(p->mnt_mp); |
1215 | /* move the reference to mountpoint into ->mnt_ex_mountpoint */ | ||
1216 | p->mnt_ex_mountpoint.dentry = p->mnt_mountpoint; | ||
1217 | p->mnt_ex_mountpoint.mnt = &p->mnt_parent->mnt; | ||
1218 | p->mnt_mountpoint = p->mnt.mnt_root; | ||
1219 | p->mnt_parent = p; | ||
1195 | p->mnt_mp = NULL; | 1220 | p->mnt_mp = NULL; |
1196 | } | 1221 | } |
1197 | change_mnt_propagation(p, MS_PRIVATE); | 1222 | change_mnt_propagation(p, MS_PRIVATE); |
@@ -1225,12 +1250,12 @@ static int do_umount(struct mount *mnt, int flags) | |||
1225 | * probably don't strictly need the lock here if we examined | 1250 | * probably don't strictly need the lock here if we examined |
1226 | * all race cases, but it's a slowpath. | 1251 | * all race cases, but it's a slowpath. |
1227 | */ | 1252 | */ |
1228 | br_write_lock(&vfsmount_lock); | 1253 | lock_mount_hash(); |
1229 | if (mnt_get_count(mnt) != 2) { | 1254 | if (mnt_get_count(mnt) != 2) { |
1230 | br_write_unlock(&vfsmount_lock); | 1255 | unlock_mount_hash(); |
1231 | return -EBUSY; | 1256 | return -EBUSY; |
1232 | } | 1257 | } |
1233 | br_write_unlock(&vfsmount_lock); | 1258 | unlock_mount_hash(); |
1234 | 1259 | ||
1235 | if (!xchg(&mnt->mnt_expiry_mark, 1)) | 1260 | if (!xchg(&mnt->mnt_expiry_mark, 1)) |
1236 | return -EAGAIN; | 1261 | return -EAGAIN; |
@@ -1272,19 +1297,23 @@ static int do_umount(struct mount *mnt, int flags) | |||
1272 | } | 1297 | } |
1273 | 1298 | ||
1274 | namespace_lock(); | 1299 | namespace_lock(); |
1275 | br_write_lock(&vfsmount_lock); | 1300 | lock_mount_hash(); |
1276 | event++; | 1301 | event++; |
1277 | 1302 | ||
1278 | if (!(flags & MNT_DETACH)) | 1303 | if (flags & MNT_DETACH) { |
1279 | shrink_submounts(mnt); | ||
1280 | |||
1281 | retval = -EBUSY; | ||
1282 | if (flags & MNT_DETACH || !propagate_mount_busy(mnt, 2)) { | ||
1283 | if (!list_empty(&mnt->mnt_list)) | 1304 | if (!list_empty(&mnt->mnt_list)) |
1284 | umount_tree(mnt, 1); | 1305 | umount_tree(mnt, 2); |
1285 | retval = 0; | 1306 | retval = 0; |
1307 | } else { | ||
1308 | shrink_submounts(mnt); | ||
1309 | retval = -EBUSY; | ||
1310 | if (!propagate_mount_busy(mnt, 2)) { | ||
1311 | if (!list_empty(&mnt->mnt_list)) | ||
1312 | umount_tree(mnt, 1); | ||
1313 | retval = 0; | ||
1314 | } | ||
1286 | } | 1315 | } |
1287 | br_write_unlock(&vfsmount_lock); | 1316 | unlock_mount_hash(); |
1288 | namespace_unlock(); | 1317 | namespace_unlock(); |
1289 | return retval; | 1318 | return retval; |
1290 | } | 1319 | } |
@@ -1427,18 +1456,18 @@ struct mount *copy_tree(struct mount *mnt, struct dentry *dentry, | |||
1427 | q = clone_mnt(p, p->mnt.mnt_root, flag); | 1456 | q = clone_mnt(p, p->mnt.mnt_root, flag); |
1428 | if (IS_ERR(q)) | 1457 | if (IS_ERR(q)) |
1429 | goto out; | 1458 | goto out; |
1430 | br_write_lock(&vfsmount_lock); | 1459 | lock_mount_hash(); |
1431 | list_add_tail(&q->mnt_list, &res->mnt_list); | 1460 | list_add_tail(&q->mnt_list, &res->mnt_list); |
1432 | attach_mnt(q, parent, p->mnt_mp); | 1461 | attach_mnt(q, parent, p->mnt_mp); |
1433 | br_write_unlock(&vfsmount_lock); | 1462 | unlock_mount_hash(); |
1434 | } | 1463 | } |
1435 | } | 1464 | } |
1436 | return res; | 1465 | return res; |
1437 | out: | 1466 | out: |
1438 | if (res) { | 1467 | if (res) { |
1439 | br_write_lock(&vfsmount_lock); | 1468 | lock_mount_hash(); |
1440 | umount_tree(res, 0); | 1469 | umount_tree(res, 0); |
1441 | br_write_unlock(&vfsmount_lock); | 1470 | unlock_mount_hash(); |
1442 | } | 1471 | } |
1443 | return q; | 1472 | return q; |
1444 | } | 1473 | } |
@@ -1460,9 +1489,9 @@ struct vfsmount *collect_mounts(struct path *path) | |||
1460 | void drop_collected_mounts(struct vfsmount *mnt) | 1489 | void drop_collected_mounts(struct vfsmount *mnt) |
1461 | { | 1490 | { |
1462 | namespace_lock(); | 1491 | namespace_lock(); |
1463 | br_write_lock(&vfsmount_lock); | 1492 | lock_mount_hash(); |
1464 | umount_tree(real_mount(mnt), 0); | 1493 | umount_tree(real_mount(mnt), 0); |
1465 | br_write_unlock(&vfsmount_lock); | 1494 | unlock_mount_hash(); |
1466 | namespace_unlock(); | 1495 | namespace_unlock(); |
1467 | } | 1496 | } |
1468 | 1497 | ||
@@ -1589,7 +1618,7 @@ static int attach_recursive_mnt(struct mount *source_mnt, | |||
1589 | if (err) | 1618 | if (err) |
1590 | goto out_cleanup_ids; | 1619 | goto out_cleanup_ids; |
1591 | 1620 | ||
1592 | br_write_lock(&vfsmount_lock); | 1621 | lock_mount_hash(); |
1593 | 1622 | ||
1594 | if (IS_MNT_SHARED(dest_mnt)) { | 1623 | if (IS_MNT_SHARED(dest_mnt)) { |
1595 | for (p = source_mnt; p; p = next_mnt(p, source_mnt)) | 1624 | for (p = source_mnt; p; p = next_mnt(p, source_mnt)) |
@@ -1608,7 +1637,7 @@ static int attach_recursive_mnt(struct mount *source_mnt, | |||
1608 | list_del_init(&child->mnt_hash); | 1637 | list_del_init(&child->mnt_hash); |
1609 | commit_tree(child); | 1638 | commit_tree(child); |
1610 | } | 1639 | } |
1611 | br_write_unlock(&vfsmount_lock); | 1640 | unlock_mount_hash(); |
1612 | 1641 | ||
1613 | return 0; | 1642 | return 0; |
1614 | 1643 | ||
@@ -1710,10 +1739,10 @@ static int do_change_type(struct path *path, int flag) | |||
1710 | goto out_unlock; | 1739 | goto out_unlock; |
1711 | } | 1740 | } |
1712 | 1741 | ||
1713 | br_write_lock(&vfsmount_lock); | 1742 | lock_mount_hash(); |
1714 | for (m = mnt; m; m = (recurse ? next_mnt(m, mnt) : NULL)) | 1743 | for (m = mnt; m; m = (recurse ? next_mnt(m, mnt) : NULL)) |
1715 | change_mnt_propagation(m, type); | 1744 | change_mnt_propagation(m, type); |
1716 | br_write_unlock(&vfsmount_lock); | 1745 | unlock_mount_hash(); |
1717 | 1746 | ||
1718 | out_unlock: | 1747 | out_unlock: |
1719 | namespace_unlock(); | 1748 | namespace_unlock(); |
@@ -1785,9 +1814,9 @@ static int do_loopback(struct path *path, const char *old_name, | |||
1785 | 1814 | ||
1786 | err = graft_tree(mnt, parent, mp); | 1815 | err = graft_tree(mnt, parent, mp); |
1787 | if (err) { | 1816 | if (err) { |
1788 | br_write_lock(&vfsmount_lock); | 1817 | lock_mount_hash(); |
1789 | umount_tree(mnt, 0); | 1818 | umount_tree(mnt, 0); |
1790 | br_write_unlock(&vfsmount_lock); | 1819 | unlock_mount_hash(); |
1791 | } | 1820 | } |
1792 | out2: | 1821 | out2: |
1793 | unlock_mount(mp); | 1822 | unlock_mount(mp); |
@@ -1846,17 +1875,13 @@ static int do_remount(struct path *path, int flags, int mnt_flags, | |||
1846 | else | 1875 | else |
1847 | err = do_remount_sb(sb, flags, data, 0); | 1876 | err = do_remount_sb(sb, flags, data, 0); |
1848 | if (!err) { | 1877 | if (!err) { |
1849 | br_write_lock(&vfsmount_lock); | 1878 | lock_mount_hash(); |
1850 | mnt_flags |= mnt->mnt.mnt_flags & MNT_PROPAGATION_MASK; | 1879 | mnt_flags |= mnt->mnt.mnt_flags & MNT_PROPAGATION_MASK; |
1851 | mnt->mnt.mnt_flags = mnt_flags; | 1880 | mnt->mnt.mnt_flags = mnt_flags; |
1852 | br_write_unlock(&vfsmount_lock); | ||
1853 | } | ||
1854 | up_write(&sb->s_umount); | ||
1855 | if (!err) { | ||
1856 | br_write_lock(&vfsmount_lock); | ||
1857 | touch_mnt_namespace(mnt->mnt_ns); | 1881 | touch_mnt_namespace(mnt->mnt_ns); |
1858 | br_write_unlock(&vfsmount_lock); | 1882 | unlock_mount_hash(); |
1859 | } | 1883 | } |
1884 | up_write(&sb->s_umount); | ||
1860 | return err; | 1885 | return err; |
1861 | } | 1886 | } |
1862 | 1887 | ||
@@ -1972,7 +1997,7 @@ static int do_add_mount(struct mount *newmnt, struct path *path, int mnt_flags) | |||
1972 | struct mount *parent; | 1997 | struct mount *parent; |
1973 | int err; | 1998 | int err; |
1974 | 1999 | ||
1975 | mnt_flags &= ~(MNT_SHARED | MNT_WRITE_HOLD | MNT_INTERNAL); | 2000 | mnt_flags &= ~(MNT_SHARED | MNT_WRITE_HOLD | MNT_INTERNAL | MNT_DOOMED | MNT_SYNC_UMOUNT); |
1976 | 2001 | ||
1977 | mp = lock_mount(path); | 2002 | mp = lock_mount(path); |
1978 | if (IS_ERR(mp)) | 2003 | if (IS_ERR(mp)) |
@@ -2077,9 +2102,7 @@ fail: | |||
2077 | /* remove m from any expiration list it may be on */ | 2102 | /* remove m from any expiration list it may be on */ |
2078 | if (!list_empty(&mnt->mnt_expire)) { | 2103 | if (!list_empty(&mnt->mnt_expire)) { |
2079 | namespace_lock(); | 2104 | namespace_lock(); |
2080 | br_write_lock(&vfsmount_lock); | ||
2081 | list_del_init(&mnt->mnt_expire); | 2105 | list_del_init(&mnt->mnt_expire); |
2082 | br_write_unlock(&vfsmount_lock); | ||
2083 | namespace_unlock(); | 2106 | namespace_unlock(); |
2084 | } | 2107 | } |
2085 | mntput(m); | 2108 | mntput(m); |
@@ -2095,11 +2118,9 @@ fail: | |||
2095 | void mnt_set_expiry(struct vfsmount *mnt, struct list_head *expiry_list) | 2118 | void mnt_set_expiry(struct vfsmount *mnt, struct list_head *expiry_list) |
2096 | { | 2119 | { |
2097 | namespace_lock(); | 2120 | namespace_lock(); |
2098 | br_write_lock(&vfsmount_lock); | ||
2099 | 2121 | ||
2100 | list_add_tail(&real_mount(mnt)->mnt_expire, expiry_list); | 2122 | list_add_tail(&real_mount(mnt)->mnt_expire, expiry_list); |
2101 | 2123 | ||
2102 | br_write_unlock(&vfsmount_lock); | ||
2103 | namespace_unlock(); | 2124 | namespace_unlock(); |
2104 | } | 2125 | } |
2105 | EXPORT_SYMBOL(mnt_set_expiry); | 2126 | EXPORT_SYMBOL(mnt_set_expiry); |
@@ -2118,7 +2139,7 @@ void mark_mounts_for_expiry(struct list_head *mounts) | |||
2118 | return; | 2139 | return; |
2119 | 2140 | ||
2120 | namespace_lock(); | 2141 | namespace_lock(); |
2121 | br_write_lock(&vfsmount_lock); | 2142 | lock_mount_hash(); |
2122 | 2143 | ||
2123 | /* extract from the expiration list every vfsmount that matches the | 2144 | /* extract from the expiration list every vfsmount that matches the |
2124 | * following criteria: | 2145 | * following criteria: |
@@ -2137,7 +2158,7 @@ void mark_mounts_for_expiry(struct list_head *mounts) | |||
2137 | touch_mnt_namespace(mnt->mnt_ns); | 2158 | touch_mnt_namespace(mnt->mnt_ns); |
2138 | umount_tree(mnt, 1); | 2159 | umount_tree(mnt, 1); |
2139 | } | 2160 | } |
2140 | br_write_unlock(&vfsmount_lock); | 2161 | unlock_mount_hash(); |
2141 | namespace_unlock(); | 2162 | namespace_unlock(); |
2142 | } | 2163 | } |
2143 | 2164 | ||
@@ -2193,7 +2214,7 @@ resume: | |||
2193 | * process a list of expirable mountpoints with the intent of discarding any | 2214 | * process a list of expirable mountpoints with the intent of discarding any |
2194 | * submounts of a specific parent mountpoint | 2215 | * submounts of a specific parent mountpoint |
2195 | * | 2216 | * |
2196 | * vfsmount_lock must be held for write | 2217 | * mount_lock must be held for write |
2197 | */ | 2218 | */ |
2198 | static void shrink_submounts(struct mount *mnt) | 2219 | static void shrink_submounts(struct mount *mnt) |
2199 | { | 2220 | { |
@@ -2414,20 +2435,25 @@ static struct mnt_namespace *alloc_mnt_ns(struct user_namespace *user_ns) | |||
2414 | return new_ns; | 2435 | return new_ns; |
2415 | } | 2436 | } |
2416 | 2437 | ||
2417 | /* | 2438 | struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns, |
2418 | * Allocate a new namespace structure and populate it with contents | 2439 | struct user_namespace *user_ns, struct fs_struct *new_fs) |
2419 | * copied from the namespace of the passed in task structure. | ||
2420 | */ | ||
2421 | static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | ||
2422 | struct user_namespace *user_ns, struct fs_struct *fs) | ||
2423 | { | 2440 | { |
2424 | struct mnt_namespace *new_ns; | 2441 | struct mnt_namespace *new_ns; |
2425 | struct vfsmount *rootmnt = NULL, *pwdmnt = NULL; | 2442 | struct vfsmount *rootmnt = NULL, *pwdmnt = NULL; |
2426 | struct mount *p, *q; | 2443 | struct mount *p, *q; |
2427 | struct mount *old = mnt_ns->root; | 2444 | struct mount *old; |
2428 | struct mount *new; | 2445 | struct mount *new; |
2429 | int copy_flags; | 2446 | int copy_flags; |
2430 | 2447 | ||
2448 | BUG_ON(!ns); | ||
2449 | |||
2450 | if (likely(!(flags & CLONE_NEWNS))) { | ||
2451 | get_mnt_ns(ns); | ||
2452 | return ns; | ||
2453 | } | ||
2454 | |||
2455 | old = ns->root; | ||
2456 | |||
2431 | new_ns = alloc_mnt_ns(user_ns); | 2457 | new_ns = alloc_mnt_ns(user_ns); |
2432 | if (IS_ERR(new_ns)) | 2458 | if (IS_ERR(new_ns)) |
2433 | return new_ns; | 2459 | return new_ns; |
@@ -2435,7 +2461,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | |||
2435 | namespace_lock(); | 2461 | namespace_lock(); |
2436 | /* First pass: copy the tree topology */ | 2462 | /* First pass: copy the tree topology */ |
2437 | copy_flags = CL_COPY_UNBINDABLE | CL_EXPIRE; | 2463 | copy_flags = CL_COPY_UNBINDABLE | CL_EXPIRE; |
2438 | if (user_ns != mnt_ns->user_ns) | 2464 | if (user_ns != ns->user_ns) |
2439 | copy_flags |= CL_SHARED_TO_SLAVE | CL_UNPRIVILEGED; | 2465 | copy_flags |= CL_SHARED_TO_SLAVE | CL_UNPRIVILEGED; |
2440 | new = copy_tree(old, old->mnt.mnt_root, copy_flags); | 2466 | new = copy_tree(old, old->mnt.mnt_root, copy_flags); |
2441 | if (IS_ERR(new)) { | 2467 | if (IS_ERR(new)) { |
@@ -2444,9 +2470,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | |||
2444 | return ERR_CAST(new); | 2470 | return ERR_CAST(new); |
2445 | } | 2471 | } |
2446 | new_ns->root = new; | 2472 | new_ns->root = new; |
2447 | br_write_lock(&vfsmount_lock); | ||
2448 | list_add_tail(&new_ns->list, &new->mnt_list); | 2473 | list_add_tail(&new_ns->list, &new->mnt_list); |
2449 | br_write_unlock(&vfsmount_lock); | ||
2450 | 2474 | ||
2451 | /* | 2475 | /* |
2452 | * Second pass: switch the tsk->fs->* elements and mark new vfsmounts | 2476 | * Second pass: switch the tsk->fs->* elements and mark new vfsmounts |
@@ -2457,13 +2481,13 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | |||
2457 | q = new; | 2481 | q = new; |
2458 | while (p) { | 2482 | while (p) { |
2459 | q->mnt_ns = new_ns; | 2483 | q->mnt_ns = new_ns; |
2460 | if (fs) { | 2484 | if (new_fs) { |
2461 | if (&p->mnt == fs->root.mnt) { | 2485 | if (&p->mnt == new_fs->root.mnt) { |
2462 | fs->root.mnt = mntget(&q->mnt); | 2486 | new_fs->root.mnt = mntget(&q->mnt); |
2463 | rootmnt = &p->mnt; | 2487 | rootmnt = &p->mnt; |
2464 | } | 2488 | } |
2465 | if (&p->mnt == fs->pwd.mnt) { | 2489 | if (&p->mnt == new_fs->pwd.mnt) { |
2466 | fs->pwd.mnt = mntget(&q->mnt); | 2490 | new_fs->pwd.mnt = mntget(&q->mnt); |
2467 | pwdmnt = &p->mnt; | 2491 | pwdmnt = &p->mnt; |
2468 | } | 2492 | } |
2469 | } | 2493 | } |
@@ -2484,23 +2508,6 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | |||
2484 | return new_ns; | 2508 | return new_ns; |
2485 | } | 2509 | } |
2486 | 2510 | ||
2487 | struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns, | ||
2488 | struct user_namespace *user_ns, struct fs_struct *new_fs) | ||
2489 | { | ||
2490 | struct mnt_namespace *new_ns; | ||
2491 | |||
2492 | BUG_ON(!ns); | ||
2493 | get_mnt_ns(ns); | ||
2494 | |||
2495 | if (!(flags & CLONE_NEWNS)) | ||
2496 | return ns; | ||
2497 | |||
2498 | new_ns = dup_mnt_ns(ns, user_ns, new_fs); | ||
2499 | |||
2500 | put_mnt_ns(ns); | ||
2501 | return new_ns; | ||
2502 | } | ||
2503 | |||
2504 | /** | 2511 | /** |
2505 | * create_mnt_ns - creates a private namespace and adds a root filesystem | 2512 | * create_mnt_ns - creates a private namespace and adds a root filesystem |
2506 | * @mnt: pointer to the new root filesystem mountpoint | 2513 | * @mnt: pointer to the new root filesystem mountpoint |
@@ -2593,7 +2600,7 @@ out_type: | |||
2593 | /* | 2600 | /* |
2594 | * Return true if path is reachable from root | 2601 | * Return true if path is reachable from root |
2595 | * | 2602 | * |
2596 | * namespace_sem or vfsmount_lock is held | 2603 | * namespace_sem or mount_lock is held |
2597 | */ | 2604 | */ |
2598 | bool is_path_reachable(struct mount *mnt, struct dentry *dentry, | 2605 | bool is_path_reachable(struct mount *mnt, struct dentry *dentry, |
2599 | const struct path *root) | 2606 | const struct path *root) |
@@ -2608,9 +2615,9 @@ bool is_path_reachable(struct mount *mnt, struct dentry *dentry, | |||
2608 | int path_is_under(struct path *path1, struct path *path2) | 2615 | int path_is_under(struct path *path1, struct path *path2) |
2609 | { | 2616 | { |
2610 | int res; | 2617 | int res; |
2611 | br_read_lock(&vfsmount_lock); | 2618 | read_seqlock_excl(&mount_lock); |
2612 | res = is_path_reachable(real_mount(path1->mnt), path1->dentry, path2); | 2619 | res = is_path_reachable(real_mount(path1->mnt), path1->dentry, path2); |
2613 | br_read_unlock(&vfsmount_lock); | 2620 | read_sequnlock_excl(&mount_lock); |
2614 | return res; | 2621 | return res; |
2615 | } | 2622 | } |
2616 | EXPORT_SYMBOL(path_is_under); | 2623 | EXPORT_SYMBOL(path_is_under); |
@@ -2701,7 +2708,7 @@ SYSCALL_DEFINE2(pivot_root, const char __user *, new_root, | |||
2701 | if (!is_path_reachable(old_mnt, old.dentry, &new)) | 2708 | if (!is_path_reachable(old_mnt, old.dentry, &new)) |
2702 | goto out4; | 2709 | goto out4; |
2703 | root_mp->m_count++; /* pin it so it won't go away */ | 2710 | root_mp->m_count++; /* pin it so it won't go away */ |
2704 | br_write_lock(&vfsmount_lock); | 2711 | lock_mount_hash(); |
2705 | detach_mnt(new_mnt, &parent_path); | 2712 | detach_mnt(new_mnt, &parent_path); |
2706 | detach_mnt(root_mnt, &root_parent); | 2713 | detach_mnt(root_mnt, &root_parent); |
2707 | if (root_mnt->mnt.mnt_flags & MNT_LOCKED) { | 2714 | if (root_mnt->mnt.mnt_flags & MNT_LOCKED) { |
@@ -2713,7 +2720,7 @@ SYSCALL_DEFINE2(pivot_root, const char __user *, new_root, | |||
2713 | /* mount new_root on / */ | 2720 | /* mount new_root on / */ |
2714 | attach_mnt(new_mnt, real_mount(root_parent.mnt), root_mp); | 2721 | attach_mnt(new_mnt, real_mount(root_parent.mnt), root_mp); |
2715 | touch_mnt_namespace(current->nsproxy->mnt_ns); | 2722 | touch_mnt_namespace(current->nsproxy->mnt_ns); |
2716 | br_write_unlock(&vfsmount_lock); | 2723 | unlock_mount_hash(); |
2717 | chroot_fs_refs(&root, &new); | 2724 | chroot_fs_refs(&root, &new); |
2718 | put_mountpoint(root_mp); | 2725 | put_mountpoint(root_mp); |
2719 | error = 0; | 2726 | error = 0; |
@@ -2767,8 +2774,6 @@ void __init mnt_init(void) | |||
2767 | unsigned u; | 2774 | unsigned u; |
2768 | int err; | 2775 | int err; |
2769 | 2776 | ||
2770 | init_rwsem(&namespace_sem); | ||
2771 | |||
2772 | mnt_cache = kmem_cache_create("mnt_cache", sizeof(struct mount), | 2777 | mnt_cache = kmem_cache_create("mnt_cache", sizeof(struct mount), |
2773 | 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL); | 2778 | 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL); |
2774 | 2779 | ||
@@ -2785,8 +2790,6 @@ void __init mnt_init(void) | |||
2785 | for (u = 0; u < HASH_SIZE; u++) | 2790 | for (u = 0; u < HASH_SIZE; u++) |
2786 | INIT_LIST_HEAD(&mountpoint_hashtable[u]); | 2791 | INIT_LIST_HEAD(&mountpoint_hashtable[u]); |
2787 | 2792 | ||
2788 | br_lock_init(&vfsmount_lock); | ||
2789 | |||
2790 | err = sysfs_init(); | 2793 | err = sysfs_init(); |
2791 | if (err) | 2794 | if (err) |
2792 | printk(KERN_WARNING "%s: sysfs_init error: %d\n", | 2795 | printk(KERN_WARNING "%s: sysfs_init error: %d\n", |
@@ -2802,11 +2805,7 @@ void put_mnt_ns(struct mnt_namespace *ns) | |||
2802 | { | 2805 | { |
2803 | if (!atomic_dec_and_test(&ns->count)) | 2806 | if (!atomic_dec_and_test(&ns->count)) |
2804 | return; | 2807 | return; |
2805 | namespace_lock(); | 2808 | drop_collected_mounts(&ns->root->mnt); |
2806 | br_write_lock(&vfsmount_lock); | ||
2807 | umount_tree(ns->root, 0); | ||
2808 | br_write_unlock(&vfsmount_lock); | ||
2809 | namespace_unlock(); | ||
2810 | free_mnt_ns(ns); | 2809 | free_mnt_ns(ns); |
2811 | } | 2810 | } |
2812 | 2811 | ||
@@ -2829,9 +2828,8 @@ void kern_unmount(struct vfsmount *mnt) | |||
2829 | { | 2828 | { |
2830 | /* release long term mount so mount point can be released */ | 2829 | /* release long term mount so mount point can be released */ |
2831 | if (!IS_ERR_OR_NULL(mnt)) { | 2830 | if (!IS_ERR_OR_NULL(mnt)) { |
2832 | br_write_lock(&vfsmount_lock); | ||
2833 | real_mount(mnt)->mnt_ns = NULL; | 2831 | real_mount(mnt)->mnt_ns = NULL; |
2834 | br_write_unlock(&vfsmount_lock); | 2832 | synchronize_rcu(); /* yecchhh... */ |
2835 | mntput(mnt); | 2833 | mntput(mnt); |
2836 | } | 2834 | } |
2837 | } | 2835 | } |
@@ -2875,7 +2873,7 @@ bool fs_fully_visible(struct file_system_type *type) | |||
2875 | if (unlikely(!ns)) | 2873 | if (unlikely(!ns)) |
2876 | return false; | 2874 | return false; |
2877 | 2875 | ||
2878 | namespace_lock(); | 2876 | down_read(&namespace_sem); |
2879 | list_for_each_entry(mnt, &ns->list, mnt_list) { | 2877 | list_for_each_entry(mnt, &ns->list, mnt_list) { |
2880 | struct mount *child; | 2878 | struct mount *child; |
2881 | if (mnt->mnt.mnt_sb->s_type != type) | 2879 | if (mnt->mnt.mnt_sb->s_type != type) |
@@ -2896,7 +2894,7 @@ bool fs_fully_visible(struct file_system_type *type) | |||
2896 | next: ; | 2894 | next: ; |
2897 | } | 2895 | } |
2898 | found: | 2896 | found: |
2899 | namespace_unlock(); | 2897 | up_read(&namespace_sem); |
2900 | return visible; | 2898 | return visible; |
2901 | } | 2899 | } |
2902 | 2900 | ||
diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 3be047474bfc..c320ac52353e 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c | |||
@@ -339,9 +339,8 @@ ncp_lookup_validate(struct dentry *dentry, unsigned int flags) | |||
339 | if (val) | 339 | if (val) |
340 | goto finished; | 340 | goto finished; |
341 | 341 | ||
342 | DDPRINTK("ncp_lookup_validate: %s/%s not valid, age=%ld, server lookup\n", | 342 | DDPRINTK("ncp_lookup_validate: %pd2 not valid, age=%ld, server lookup\n", |
343 | dentry->d_parent->d_name.name, dentry->d_name.name, | 343 | dentry, NCP_GET_AGE(dentry)); |
344 | NCP_GET_AGE(dentry)); | ||
345 | 344 | ||
346 | len = sizeof(__name); | 345 | len = sizeof(__name); |
347 | if (ncp_is_server_root(dir)) { | 346 | if (ncp_is_server_root(dir)) { |
@@ -359,8 +358,8 @@ ncp_lookup_validate(struct dentry *dentry, unsigned int flags) | |||
359 | res = ncp_obtain_info(server, dir, __name, &(finfo.i)); | 358 | res = ncp_obtain_info(server, dir, __name, &(finfo.i)); |
360 | } | 359 | } |
361 | finfo.volume = finfo.i.volNumber; | 360 | finfo.volume = finfo.i.volNumber; |
362 | DDPRINTK("ncp_lookup_validate: looked for %s/%s, res=%d\n", | 361 | DDPRINTK("ncp_lookup_validate: looked for %pd/%s, res=%d\n", |
363 | dentry->d_parent->d_name.name, __name, res); | 362 | dentry->d_parent, __name, res); |
364 | /* | 363 | /* |
365 | * If we didn't find it, or if it has a different dirEntNum to | 364 | * If we didn't find it, or if it has a different dirEntNum to |
366 | * what we remember, it's not valid any more. | 365 | * what we remember, it's not valid any more. |
@@ -454,8 +453,7 @@ static int ncp_readdir(struct file *file, struct dir_context *ctx) | |||
454 | ctl.page = NULL; | 453 | ctl.page = NULL; |
455 | ctl.cache = NULL; | 454 | ctl.cache = NULL; |
456 | 455 | ||
457 | DDPRINTK("ncp_readdir: reading %s/%s, pos=%d\n", | 456 | DDPRINTK("ncp_readdir: reading %pD2, pos=%d\n", file, |
458 | dentry->d_parent->d_name.name, dentry->d_name.name, | ||
459 | (int) ctx->pos); | 457 | (int) ctx->pos); |
460 | 458 | ||
461 | result = -EIO; | 459 | result = -EIO; |
@@ -740,12 +738,10 @@ ncp_do_readdir(struct file *file, struct dir_context *ctx, | |||
740 | int more; | 738 | int more; |
741 | size_t bufsize; | 739 | size_t bufsize; |
742 | 740 | ||
743 | DPRINTK("ncp_do_readdir: %s/%s, fpos=%ld\n", | 741 | DPRINTK("ncp_do_readdir: %pD2, fpos=%ld\n", file, |
744 | dentry->d_parent->d_name.name, dentry->d_name.name, | ||
745 | (unsigned long) ctx->pos); | 742 | (unsigned long) ctx->pos); |
746 | PPRINTK("ncp_do_readdir: init %s, volnum=%d, dirent=%u\n", | 743 | PPRINTK("ncp_do_readdir: init %pD, volnum=%d, dirent=%u\n", |
747 | dentry->d_name.name, NCP_FINFO(dir)->volNumber, | 744 | file, NCP_FINFO(dir)->volNumber, NCP_FINFO(dir)->dirEntNum); |
748 | NCP_FINFO(dir)->dirEntNum); | ||
749 | 745 | ||
750 | err = ncp_initialize_search(server, dir, &seq); | 746 | err = ncp_initialize_search(server, dir, &seq); |
751 | if (err) { | 747 | if (err) { |
@@ -850,8 +846,7 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig | |||
850 | if (!ncp_conn_valid(server)) | 846 | if (!ncp_conn_valid(server)) |
851 | goto finished; | 847 | goto finished; |
852 | 848 | ||
853 | PPRINTK("ncp_lookup: server lookup for %s/%s\n", | 849 | PPRINTK("ncp_lookup: server lookup for %pd2\n", dentry); |
854 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
855 | 850 | ||
856 | len = sizeof(__name); | 851 | len = sizeof(__name); |
857 | if (ncp_is_server_root(dir)) { | 852 | if (ncp_is_server_root(dir)) { |
@@ -867,8 +862,7 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig | |||
867 | if (!res) | 862 | if (!res) |
868 | res = ncp_obtain_info(server, dir, __name, &(finfo.i)); | 863 | res = ncp_obtain_info(server, dir, __name, &(finfo.i)); |
869 | } | 864 | } |
870 | PPRINTK("ncp_lookup: looked for %s/%s, res=%d\n", | 865 | PPRINTK("ncp_lookup: looked for %pd2, res=%d\n", dentry, res); |
871 | dentry->d_parent->d_name.name, __name, res); | ||
872 | /* | 866 | /* |
873 | * If we didn't find an entry, make a negative dentry. | 867 | * If we didn't find an entry, make a negative dentry. |
874 | */ | 868 | */ |
@@ -915,8 +909,7 @@ out: | |||
915 | return error; | 909 | return error; |
916 | 910 | ||
917 | out_close: | 911 | out_close: |
918 | PPRINTK("ncp_instantiate: %s/%s failed, closing file\n", | 912 | PPRINTK("ncp_instantiate: %pd2 failed, closing file\n", dentry); |
919 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
920 | ncp_close_file(NCP_SERVER(dir), finfo->file_handle); | 913 | ncp_close_file(NCP_SERVER(dir), finfo->file_handle); |
921 | goto out; | 914 | goto out; |
922 | } | 915 | } |
@@ -930,8 +923,7 @@ int ncp_create_new(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
930 | int opmode; | 923 | int opmode; |
931 | __u8 __name[NCP_MAXPATHLEN + 1]; | 924 | __u8 __name[NCP_MAXPATHLEN + 1]; |
932 | 925 | ||
933 | PPRINTK("ncp_create_new: creating %s/%s, mode=%hx\n", | 926 | PPRINTK("ncp_create_new: creating %pd2, mode=%hx\n", dentry, mode); |
934 | dentry->d_parent->d_name.name, dentry->d_name.name, mode); | ||
935 | 927 | ||
936 | ncp_age_dentry(server, dentry); | 928 | ncp_age_dentry(server, dentry); |
937 | len = sizeof(__name); | 929 | len = sizeof(__name); |
@@ -960,8 +952,7 @@ int ncp_create_new(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
960 | error = -ENAMETOOLONG; | 952 | error = -ENAMETOOLONG; |
961 | else if (result < 0) | 953 | else if (result < 0) |
962 | error = result; | 954 | error = result; |
963 | DPRINTK("ncp_create: %s/%s failed\n", | 955 | DPRINTK("ncp_create: %pd2 failed\n", dentry); |
964 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
965 | goto out; | 956 | goto out; |
966 | } | 957 | } |
967 | opmode = O_WRONLY; | 958 | opmode = O_WRONLY; |
@@ -994,8 +985,7 @@ static int ncp_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) | |||
994 | int error, len; | 985 | int error, len; |
995 | __u8 __name[NCP_MAXPATHLEN + 1]; | 986 | __u8 __name[NCP_MAXPATHLEN + 1]; |
996 | 987 | ||
997 | DPRINTK("ncp_mkdir: making %s/%s\n", | 988 | DPRINTK("ncp_mkdir: making %pd2\n", dentry); |
998 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
999 | 989 | ||
1000 | ncp_age_dentry(server, dentry); | 990 | ncp_age_dentry(server, dentry); |
1001 | len = sizeof(__name); | 991 | len = sizeof(__name); |
@@ -1032,8 +1022,7 @@ static int ncp_rmdir(struct inode *dir, struct dentry *dentry) | |||
1032 | int error, result, len; | 1022 | int error, result, len; |
1033 | __u8 __name[NCP_MAXPATHLEN + 1]; | 1023 | __u8 __name[NCP_MAXPATHLEN + 1]; |
1034 | 1024 | ||
1035 | DPRINTK("ncp_rmdir: removing %s/%s\n", | 1025 | DPRINTK("ncp_rmdir: removing %pd2\n", dentry); |
1036 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
1037 | 1026 | ||
1038 | len = sizeof(__name); | 1027 | len = sizeof(__name); |
1039 | error = ncp_io2vol(server, __name, &len, dentry->d_name.name, | 1028 | error = ncp_io2vol(server, __name, &len, dentry->d_name.name, |
@@ -1078,8 +1067,7 @@ static int ncp_unlink(struct inode *dir, struct dentry *dentry) | |||
1078 | int error; | 1067 | int error; |
1079 | 1068 | ||
1080 | server = NCP_SERVER(dir); | 1069 | server = NCP_SERVER(dir); |
1081 | DPRINTK("ncp_unlink: unlinking %s/%s\n", | 1070 | DPRINTK("ncp_unlink: unlinking %pd2\n", dentry); |
1082 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
1083 | 1071 | ||
1084 | /* | 1072 | /* |
1085 | * Check whether to close the file ... | 1073 | * Check whether to close the file ... |
@@ -1099,8 +1087,7 @@ static int ncp_unlink(struct inode *dir, struct dentry *dentry) | |||
1099 | #endif | 1087 | #endif |
1100 | switch (error) { | 1088 | switch (error) { |
1101 | case 0x00: | 1089 | case 0x00: |
1102 | DPRINTK("ncp: removed %s/%s\n", | 1090 | DPRINTK("ncp: removed %pd2\n", dentry); |
1103 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
1104 | break; | 1091 | break; |
1105 | case 0x85: | 1092 | case 0x85: |
1106 | case 0x8A: | 1093 | case 0x8A: |
@@ -1133,9 +1120,7 @@ static int ncp_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1133 | int old_len, new_len; | 1120 | int old_len, new_len; |
1134 | __u8 __old_name[NCP_MAXPATHLEN + 1], __new_name[NCP_MAXPATHLEN + 1]; | 1121 | __u8 __old_name[NCP_MAXPATHLEN + 1], __new_name[NCP_MAXPATHLEN + 1]; |
1135 | 1122 | ||
1136 | DPRINTK("ncp_rename: %s/%s to %s/%s\n", | 1123 | DPRINTK("ncp_rename: %pd2 to %pd2\n", old_dentry, new_dentry); |
1137 | old_dentry->d_parent->d_name.name, old_dentry->d_name.name, | ||
1138 | new_dentry->d_parent->d_name.name, new_dentry->d_name.name); | ||
1139 | 1124 | ||
1140 | ncp_age_dentry(server, old_dentry); | 1125 | ncp_age_dentry(server, old_dentry); |
1141 | ncp_age_dentry(server, new_dentry); | 1126 | ncp_age_dentry(server, new_dentry); |
@@ -1165,8 +1150,8 @@ static int ncp_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1165 | #endif | 1150 | #endif |
1166 | switch (error) { | 1151 | switch (error) { |
1167 | case 0x00: | 1152 | case 0x00: |
1168 | DPRINTK("ncp renamed %s -> %s.\n", | 1153 | DPRINTK("ncp renamed %pd -> %pd.\n", |
1169 | old_dentry->d_name.name,new_dentry->d_name.name); | 1154 | old_dentry, new_dentry); |
1170 | break; | 1155 | break; |
1171 | case 0x9E: | 1156 | case 0x9E: |
1172 | error = -ENAMETOOLONG; | 1157 | error = -ENAMETOOLONG; |
diff --git a/fs/ncpfs/file.c b/fs/ncpfs/file.c index 122e260247f5..8f5074e1ecb9 100644 --- a/fs/ncpfs/file.c +++ b/fs/ncpfs/file.c | |||
@@ -107,8 +107,7 @@ ncp_file_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) | |||
107 | void* freepage; | 107 | void* freepage; |
108 | size_t freelen; | 108 | size_t freelen; |
109 | 109 | ||
110 | DPRINTK("ncp_file_read: enter %s/%s\n", | 110 | DPRINTK("ncp_file_read: enter %pd2\n", dentry); |
111 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
112 | 111 | ||
113 | pos = *ppos; | 112 | pos = *ppos; |
114 | 113 | ||
@@ -166,8 +165,7 @@ ncp_file_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) | |||
166 | 165 | ||
167 | file_accessed(file); | 166 | file_accessed(file); |
168 | 167 | ||
169 | DPRINTK("ncp_file_read: exit %s/%s\n", | 168 | DPRINTK("ncp_file_read: exit %pd2\n", dentry); |
170 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
171 | outrel: | 169 | outrel: |
172 | ncp_inode_close(inode); | 170 | ncp_inode_close(inode); |
173 | return already_read ? already_read : error; | 171 | return already_read ? already_read : error; |
@@ -184,8 +182,7 @@ ncp_file_write(struct file *file, const char __user *buf, size_t count, loff_t * | |||
184 | int errno; | 182 | int errno; |
185 | void* bouncebuffer; | 183 | void* bouncebuffer; |
186 | 184 | ||
187 | DPRINTK("ncp_file_write: enter %s/%s\n", | 185 | DPRINTK("ncp_file_write: enter %pd2\n", dentry); |
188 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
189 | if ((ssize_t) count < 0) | 186 | if ((ssize_t) count < 0) |
190 | return -EINVAL; | 187 | return -EINVAL; |
191 | pos = *ppos; | 188 | pos = *ppos; |
@@ -264,8 +261,7 @@ ncp_file_write(struct file *file, const char __user *buf, size_t count, loff_t * | |||
264 | i_size_write(inode, pos); | 261 | i_size_write(inode, pos); |
265 | mutex_unlock(&inode->i_mutex); | 262 | mutex_unlock(&inode->i_mutex); |
266 | } | 263 | } |
267 | DPRINTK("ncp_file_write: exit %s/%s\n", | 264 | DPRINTK("ncp_file_write: exit %pd2\n", dentry); |
268 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
269 | outrel: | 265 | outrel: |
270 | ncp_inode_close(inode); | 266 | ncp_inode_close(inode); |
271 | return already_written ? already_written : errno; | 267 | return already_written ? already_written : errno; |
diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c index 4659da67e7f6..2cf2ebecb55f 100644 --- a/fs/ncpfs/inode.c +++ b/fs/ncpfs/inode.c | |||
@@ -782,6 +782,17 @@ out: | |||
782 | return error; | 782 | return error; |
783 | } | 783 | } |
784 | 784 | ||
785 | static void delayed_free(struct rcu_head *p) | ||
786 | { | ||
787 | struct ncp_server *server = container_of(p, struct ncp_server, rcu); | ||
788 | #ifdef CONFIG_NCPFS_NLS | ||
789 | /* unload the NLS charsets */ | ||
790 | unload_nls(server->nls_vol); | ||
791 | unload_nls(server->nls_io); | ||
792 | #endif /* CONFIG_NCPFS_NLS */ | ||
793 | kfree(server); | ||
794 | } | ||
795 | |||
785 | static void ncp_put_super(struct super_block *sb) | 796 | static void ncp_put_super(struct super_block *sb) |
786 | { | 797 | { |
787 | struct ncp_server *server = NCP_SBP(sb); | 798 | struct ncp_server *server = NCP_SBP(sb); |
@@ -792,11 +803,6 @@ static void ncp_put_super(struct super_block *sb) | |||
792 | 803 | ||
793 | ncp_stop_tasks(server); | 804 | ncp_stop_tasks(server); |
794 | 805 | ||
795 | #ifdef CONFIG_NCPFS_NLS | ||
796 | /* unload the NLS charsets */ | ||
797 | unload_nls(server->nls_vol); | ||
798 | unload_nls(server->nls_io); | ||
799 | #endif /* CONFIG_NCPFS_NLS */ | ||
800 | mutex_destroy(&server->rcv.creq_mutex); | 806 | mutex_destroy(&server->rcv.creq_mutex); |
801 | mutex_destroy(&server->root_setup_lock); | 807 | mutex_destroy(&server->root_setup_lock); |
802 | mutex_destroy(&server->mutex); | 808 | mutex_destroy(&server->mutex); |
@@ -813,8 +819,7 @@ static void ncp_put_super(struct super_block *sb) | |||
813 | vfree(server->rxbuf); | 819 | vfree(server->rxbuf); |
814 | vfree(server->txbuf); | 820 | vfree(server->txbuf); |
815 | vfree(server->packet); | 821 | vfree(server->packet); |
816 | sb->s_fs_info = NULL; | 822 | call_rcu(&server->rcu, delayed_free); |
817 | kfree(server); | ||
818 | } | 823 | } |
819 | 824 | ||
820 | static int ncp_statfs(struct dentry *dentry, struct kstatfs *buf) | 825 | static int ncp_statfs(struct dentry *dentry, struct kstatfs *buf) |
diff --git a/fs/ncpfs/ncp_fs_sb.h b/fs/ncpfs/ncp_fs_sb.h index c51b2c543539..b81e97adc5a9 100644 --- a/fs/ncpfs/ncp_fs_sb.h +++ b/fs/ncpfs/ncp_fs_sb.h | |||
@@ -38,7 +38,7 @@ struct ncp_mount_data_kernel { | |||
38 | }; | 38 | }; |
39 | 39 | ||
40 | struct ncp_server { | 40 | struct ncp_server { |
41 | 41 | struct rcu_head rcu; | |
42 | struct ncp_mount_data_kernel m; /* Nearly all of the mount data is of | 42 | struct ncp_mount_data_kernel m; /* Nearly all of the mount data is of |
43 | interest for us later, so we store | 43 | interest for us later, so we store |
44 | it completely. */ | 44 | it completely. */ |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 9a8676f33350..812154aff981 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c | |||
@@ -98,9 +98,7 @@ nfs_opendir(struct inode *inode, struct file *filp) | |||
98 | struct nfs_open_dir_context *ctx; | 98 | struct nfs_open_dir_context *ctx; |
99 | struct rpc_cred *cred; | 99 | struct rpc_cred *cred; |
100 | 100 | ||
101 | dfprintk(FILE, "NFS: open dir(%s/%s)\n", | 101 | dfprintk(FILE, "NFS: open dir(%pD2)\n", filp); |
102 | filp->f_path.dentry->d_parent->d_name.name, | ||
103 | filp->f_path.dentry->d_name.name); | ||
104 | 102 | ||
105 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); | 103 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); |
106 | 104 | ||
@@ -297,11 +295,10 @@ int nfs_readdir_search_for_cookie(struct nfs_cache_array *array, nfs_readdir_des | |||
297 | if (ctx->duped > 0 | 295 | if (ctx->duped > 0 |
298 | && ctx->dup_cookie == *desc->dir_cookie) { | 296 | && ctx->dup_cookie == *desc->dir_cookie) { |
299 | if (printk_ratelimit()) { | 297 | if (printk_ratelimit()) { |
300 | pr_notice("NFS: directory %s/%s contains a readdir loop." | 298 | pr_notice("NFS: directory %pD2 contains a readdir loop." |
301 | "Please contact your server vendor. " | 299 | "Please contact your server vendor. " |
302 | "The file: %s has duplicate cookie %llu\n", | 300 | "The file: %s has duplicate cookie %llu\n", |
303 | desc->file->f_dentry->d_parent->d_name.name, | 301 | desc->file, |
304 | desc->file->f_dentry->d_name.name, | ||
305 | array->array[i].string.name, | 302 | array->array[i].string.name, |
306 | *desc->dir_cookie); | 303 | *desc->dir_cookie); |
307 | } | 304 | } |
@@ -822,9 +819,8 @@ static int nfs_readdir(struct file *file, struct dir_context *ctx) | |||
822 | struct nfs_open_dir_context *dir_ctx = file->private_data; | 819 | struct nfs_open_dir_context *dir_ctx = file->private_data; |
823 | int res = 0; | 820 | int res = 0; |
824 | 821 | ||
825 | dfprintk(FILE, "NFS: readdir(%s/%s) starting at cookie %llu\n", | 822 | dfprintk(FILE, "NFS: readdir(%pD2) starting at cookie %llu\n", |
826 | dentry->d_parent->d_name.name, dentry->d_name.name, | 823 | file, (long long)ctx->pos); |
827 | (long long)ctx->pos); | ||
828 | nfs_inc_stats(inode, NFSIOS_VFSGETDENTS); | 824 | nfs_inc_stats(inode, NFSIOS_VFSGETDENTS); |
829 | 825 | ||
830 | /* | 826 | /* |
@@ -880,22 +876,17 @@ out: | |||
880 | nfs_unblock_sillyrename(dentry); | 876 | nfs_unblock_sillyrename(dentry); |
881 | if (res > 0) | 877 | if (res > 0) |
882 | res = 0; | 878 | res = 0; |
883 | dfprintk(FILE, "NFS: readdir(%s/%s) returns %d\n", | 879 | dfprintk(FILE, "NFS: readdir(%pD2) returns %d\n", file, res); |
884 | dentry->d_parent->d_name.name, dentry->d_name.name, | ||
885 | res); | ||
886 | return res; | 880 | return res; |
887 | } | 881 | } |
888 | 882 | ||
889 | static loff_t nfs_llseek_dir(struct file *filp, loff_t offset, int whence) | 883 | static loff_t nfs_llseek_dir(struct file *filp, loff_t offset, int whence) |
890 | { | 884 | { |
891 | struct dentry *dentry = filp->f_path.dentry; | 885 | struct inode *inode = file_inode(filp); |
892 | struct inode *inode = dentry->d_inode; | ||
893 | struct nfs_open_dir_context *dir_ctx = filp->private_data; | 886 | struct nfs_open_dir_context *dir_ctx = filp->private_data; |
894 | 887 | ||
895 | dfprintk(FILE, "NFS: llseek dir(%s/%s, %lld, %d)\n", | 888 | dfprintk(FILE, "NFS: llseek dir(%pD2, %lld, %d)\n", |
896 | dentry->d_parent->d_name.name, | 889 | filp, offset, whence); |
897 | dentry->d_name.name, | ||
898 | offset, whence); | ||
899 | 890 | ||
900 | mutex_lock(&inode->i_mutex); | 891 | mutex_lock(&inode->i_mutex); |
901 | switch (whence) { | 892 | switch (whence) { |
@@ -925,15 +916,12 @@ out: | |||
925 | static int nfs_fsync_dir(struct file *filp, loff_t start, loff_t end, | 916 | static int nfs_fsync_dir(struct file *filp, loff_t start, loff_t end, |
926 | int datasync) | 917 | int datasync) |
927 | { | 918 | { |
928 | struct dentry *dentry = filp->f_path.dentry; | 919 | struct inode *inode = file_inode(filp); |
929 | struct inode *inode = dentry->d_inode; | ||
930 | 920 | ||
931 | dfprintk(FILE, "NFS: fsync dir(%s/%s) datasync %d\n", | 921 | dfprintk(FILE, "NFS: fsync dir(%pD2) datasync %d\n", filp, datasync); |
932 | dentry->d_parent->d_name.name, dentry->d_name.name, | ||
933 | datasync); | ||
934 | 922 | ||
935 | mutex_lock(&inode->i_mutex); | 923 | mutex_lock(&inode->i_mutex); |
936 | nfs_inc_stats(dentry->d_inode, NFSIOS_VFSFSYNC); | 924 | nfs_inc_stats(inode, NFSIOS_VFSFSYNC); |
937 | mutex_unlock(&inode->i_mutex); | 925 | mutex_unlock(&inode->i_mutex); |
938 | return 0; | 926 | return 0; |
939 | } | 927 | } |
@@ -1073,9 +1061,8 @@ static int nfs_lookup_revalidate(struct dentry *dentry, unsigned int flags) | |||
1073 | } | 1061 | } |
1074 | 1062 | ||
1075 | if (is_bad_inode(inode)) { | 1063 | if (is_bad_inode(inode)) { |
1076 | dfprintk(LOOKUPCACHE, "%s: %s/%s has dud inode\n", | 1064 | dfprintk(LOOKUPCACHE, "%s: %pd2 has dud inode\n", |
1077 | __func__, dentry->d_parent->d_name.name, | 1065 | __func__, dentry); |
1078 | dentry->d_name.name); | ||
1079 | goto out_bad; | 1066 | goto out_bad; |
1080 | } | 1067 | } |
1081 | 1068 | ||
@@ -1125,9 +1112,8 @@ out_set_verifier: | |||
1125 | nfs_advise_use_readdirplus(dir); | 1112 | nfs_advise_use_readdirplus(dir); |
1126 | out_valid_noent: | 1113 | out_valid_noent: |
1127 | dput(parent); | 1114 | dput(parent); |
1128 | dfprintk(LOOKUPCACHE, "NFS: %s(%s/%s) is valid\n", | 1115 | dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) is valid\n", |
1129 | __func__, dentry->d_parent->d_name.name, | 1116 | __func__, dentry); |
1130 | dentry->d_name.name); | ||
1131 | return 1; | 1117 | return 1; |
1132 | out_zap_parent: | 1118 | out_zap_parent: |
1133 | nfs_zap_caches(dir); | 1119 | nfs_zap_caches(dir); |
@@ -1153,18 +1139,16 @@ out_zap_parent: | |||
1153 | goto out_valid; | 1139 | goto out_valid; |
1154 | 1140 | ||
1155 | dput(parent); | 1141 | dput(parent); |
1156 | dfprintk(LOOKUPCACHE, "NFS: %s(%s/%s) is invalid\n", | 1142 | dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) is invalid\n", |
1157 | __func__, dentry->d_parent->d_name.name, | 1143 | __func__, dentry); |
1158 | dentry->d_name.name); | ||
1159 | return 0; | 1144 | return 0; |
1160 | out_error: | 1145 | out_error: |
1161 | nfs_free_fattr(fattr); | 1146 | nfs_free_fattr(fattr); |
1162 | nfs_free_fhandle(fhandle); | 1147 | nfs_free_fhandle(fhandle); |
1163 | nfs4_label_free(label); | 1148 | nfs4_label_free(label); |
1164 | dput(parent); | 1149 | dput(parent); |
1165 | dfprintk(LOOKUPCACHE, "NFS: %s(%s/%s) lookup returned error %d\n", | 1150 | dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) lookup returned error %d\n", |
1166 | __func__, dentry->d_parent->d_name.name, | 1151 | __func__, dentry, error); |
1167 | dentry->d_name.name, error); | ||
1168 | return error; | 1152 | return error; |
1169 | } | 1153 | } |
1170 | 1154 | ||
@@ -1188,16 +1172,14 @@ static int nfs_weak_revalidate(struct dentry *dentry, unsigned int flags) | |||
1188 | * eventually need to do something more here. | 1172 | * eventually need to do something more here. |
1189 | */ | 1173 | */ |
1190 | if (!inode) { | 1174 | if (!inode) { |
1191 | dfprintk(LOOKUPCACHE, "%s: %s/%s has negative inode\n", | 1175 | dfprintk(LOOKUPCACHE, "%s: %pd2 has negative inode\n", |
1192 | __func__, dentry->d_parent->d_name.name, | 1176 | __func__, dentry); |
1193 | dentry->d_name.name); | ||
1194 | return 1; | 1177 | return 1; |
1195 | } | 1178 | } |
1196 | 1179 | ||
1197 | if (is_bad_inode(inode)) { | 1180 | if (is_bad_inode(inode)) { |
1198 | dfprintk(LOOKUPCACHE, "%s: %s/%s has dud inode\n", | 1181 | dfprintk(LOOKUPCACHE, "%s: %pd2 has dud inode\n", |
1199 | __func__, dentry->d_parent->d_name.name, | 1182 | __func__, dentry); |
1200 | dentry->d_name.name); | ||
1201 | return 0; | 1183 | return 0; |
1202 | } | 1184 | } |
1203 | 1185 | ||
@@ -1212,9 +1194,8 @@ static int nfs_weak_revalidate(struct dentry *dentry, unsigned int flags) | |||
1212 | */ | 1194 | */ |
1213 | static int nfs_dentry_delete(const struct dentry *dentry) | 1195 | static int nfs_dentry_delete(const struct dentry *dentry) |
1214 | { | 1196 | { |
1215 | dfprintk(VFS, "NFS: dentry_delete(%s/%s, %x)\n", | 1197 | dfprintk(VFS, "NFS: dentry_delete(%pd2, %x)\n", |
1216 | dentry->d_parent->d_name.name, dentry->d_name.name, | 1198 | dentry, dentry->d_flags); |
1217 | dentry->d_flags); | ||
1218 | 1199 | ||
1219 | /* Unhash any dentry with a stale inode */ | 1200 | /* Unhash any dentry with a stale inode */ |
1220 | if (dentry->d_inode != NULL && NFS_STALE(dentry->d_inode)) | 1201 | if (dentry->d_inode != NULL && NFS_STALE(dentry->d_inode)) |
@@ -1292,8 +1273,7 @@ struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, unsigned in | |||
1292 | struct nfs4_label *label = NULL; | 1273 | struct nfs4_label *label = NULL; |
1293 | int error; | 1274 | int error; |
1294 | 1275 | ||
1295 | dfprintk(VFS, "NFS: lookup(%s/%s)\n", | 1276 | dfprintk(VFS, "NFS: lookup(%pd2)\n", dentry); |
1296 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
1297 | nfs_inc_stats(dir, NFSIOS_VFSLOOKUP); | 1277 | nfs_inc_stats(dir, NFSIOS_VFSLOOKUP); |
1298 | 1278 | ||
1299 | res = ERR_PTR(-ENAMETOOLONG); | 1279 | res = ERR_PTR(-ENAMETOOLONG); |
@@ -1424,8 +1404,8 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry, | |||
1424 | /* Expect a negative dentry */ | 1404 | /* Expect a negative dentry */ |
1425 | BUG_ON(dentry->d_inode); | 1405 | BUG_ON(dentry->d_inode); |
1426 | 1406 | ||
1427 | dfprintk(VFS, "NFS: atomic_open(%s/%ld), %s\n", | 1407 | dfprintk(VFS, "NFS: atomic_open(%s/%ld), %pd\n", |
1428 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1408 | dir->i_sb->s_id, dir->i_ino, dentry); |
1429 | 1409 | ||
1430 | err = nfs_check_flags(open_flags); | 1410 | err = nfs_check_flags(open_flags); |
1431 | if (err) | 1411 | if (err) |
@@ -1614,8 +1594,8 @@ int nfs_create(struct inode *dir, struct dentry *dentry, | |||
1614 | int open_flags = excl ? O_CREAT | O_EXCL : O_CREAT; | 1594 | int open_flags = excl ? O_CREAT | O_EXCL : O_CREAT; |
1615 | int error; | 1595 | int error; |
1616 | 1596 | ||
1617 | dfprintk(VFS, "NFS: create(%s/%ld), %s\n", | 1597 | dfprintk(VFS, "NFS: create(%s/%ld), %pd\n", |
1618 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1598 | dir->i_sb->s_id, dir->i_ino, dentry); |
1619 | 1599 | ||
1620 | attr.ia_mode = mode; | 1600 | attr.ia_mode = mode; |
1621 | attr.ia_valid = ATTR_MODE; | 1601 | attr.ia_valid = ATTR_MODE; |
@@ -1641,8 +1621,8 @@ nfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev) | |||
1641 | struct iattr attr; | 1621 | struct iattr attr; |
1642 | int status; | 1622 | int status; |
1643 | 1623 | ||
1644 | dfprintk(VFS, "NFS: mknod(%s/%ld), %s\n", | 1624 | dfprintk(VFS, "NFS: mknod(%s/%ld), %pd\n", |
1645 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1625 | dir->i_sb->s_id, dir->i_ino, dentry); |
1646 | 1626 | ||
1647 | if (!new_valid_dev(rdev)) | 1627 | if (!new_valid_dev(rdev)) |
1648 | return -EINVAL; | 1628 | return -EINVAL; |
@@ -1670,8 +1650,8 @@ int nfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) | |||
1670 | struct iattr attr; | 1650 | struct iattr attr; |
1671 | int error; | 1651 | int error; |
1672 | 1652 | ||
1673 | dfprintk(VFS, "NFS: mkdir(%s/%ld), %s\n", | 1653 | dfprintk(VFS, "NFS: mkdir(%s/%ld), %pd\n", |
1674 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1654 | dir->i_sb->s_id, dir->i_ino, dentry); |
1675 | 1655 | ||
1676 | attr.ia_valid = ATTR_MODE; | 1656 | attr.ia_valid = ATTR_MODE; |
1677 | attr.ia_mode = mode | S_IFDIR; | 1657 | attr.ia_mode = mode | S_IFDIR; |
@@ -1698,8 +1678,8 @@ int nfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
1698 | { | 1678 | { |
1699 | int error; | 1679 | int error; |
1700 | 1680 | ||
1701 | dfprintk(VFS, "NFS: rmdir(%s/%ld), %s\n", | 1681 | dfprintk(VFS, "NFS: rmdir(%s/%ld), %pd\n", |
1702 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1682 | dir->i_sb->s_id, dir->i_ino, dentry); |
1703 | 1683 | ||
1704 | trace_nfs_rmdir_enter(dir, dentry); | 1684 | trace_nfs_rmdir_enter(dir, dentry); |
1705 | if (dentry->d_inode) { | 1685 | if (dentry->d_inode) { |
@@ -1734,8 +1714,7 @@ static int nfs_safe_remove(struct dentry *dentry) | |||
1734 | struct inode *inode = dentry->d_inode; | 1714 | struct inode *inode = dentry->d_inode; |
1735 | int error = -EBUSY; | 1715 | int error = -EBUSY; |
1736 | 1716 | ||
1737 | dfprintk(VFS, "NFS: safe_remove(%s/%s)\n", | 1717 | dfprintk(VFS, "NFS: safe_remove(%pd2)\n", dentry); |
1738 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
1739 | 1718 | ||
1740 | /* If the dentry was sillyrenamed, we simply call d_delete() */ | 1719 | /* If the dentry was sillyrenamed, we simply call d_delete() */ |
1741 | if (dentry->d_flags & DCACHE_NFSFS_RENAMED) { | 1720 | if (dentry->d_flags & DCACHE_NFSFS_RENAMED) { |
@@ -1768,8 +1747,8 @@ int nfs_unlink(struct inode *dir, struct dentry *dentry) | |||
1768 | int error; | 1747 | int error; |
1769 | int need_rehash = 0; | 1748 | int need_rehash = 0; |
1770 | 1749 | ||
1771 | dfprintk(VFS, "NFS: unlink(%s/%ld, %s)\n", dir->i_sb->s_id, | 1750 | dfprintk(VFS, "NFS: unlink(%s/%ld, %pd)\n", dir->i_sb->s_id, |
1772 | dir->i_ino, dentry->d_name.name); | 1751 | dir->i_ino, dentry); |
1773 | 1752 | ||
1774 | trace_nfs_unlink_enter(dir, dentry); | 1753 | trace_nfs_unlink_enter(dir, dentry); |
1775 | spin_lock(&dentry->d_lock); | 1754 | spin_lock(&dentry->d_lock); |
@@ -1819,8 +1798,8 @@ int nfs_symlink(struct inode *dir, struct dentry *dentry, const char *symname) | |||
1819 | unsigned int pathlen = strlen(symname); | 1798 | unsigned int pathlen = strlen(symname); |
1820 | int error; | 1799 | int error; |
1821 | 1800 | ||
1822 | dfprintk(VFS, "NFS: symlink(%s/%ld, %s, %s)\n", dir->i_sb->s_id, | 1801 | dfprintk(VFS, "NFS: symlink(%s/%ld, %pd, %s)\n", dir->i_sb->s_id, |
1823 | dir->i_ino, dentry->d_name.name, symname); | 1802 | dir->i_ino, dentry, symname); |
1824 | 1803 | ||
1825 | if (pathlen > PAGE_SIZE) | 1804 | if (pathlen > PAGE_SIZE) |
1826 | return -ENAMETOOLONG; | 1805 | return -ENAMETOOLONG; |
@@ -1842,9 +1821,9 @@ int nfs_symlink(struct inode *dir, struct dentry *dentry, const char *symname) | |||
1842 | error = NFS_PROTO(dir)->symlink(dir, dentry, page, pathlen, &attr); | 1821 | error = NFS_PROTO(dir)->symlink(dir, dentry, page, pathlen, &attr); |
1843 | trace_nfs_symlink_exit(dir, dentry, error); | 1822 | trace_nfs_symlink_exit(dir, dentry, error); |
1844 | if (error != 0) { | 1823 | if (error != 0) { |
1845 | dfprintk(VFS, "NFS: symlink(%s/%ld, %s, %s) error %d\n", | 1824 | dfprintk(VFS, "NFS: symlink(%s/%ld, %pd, %s) error %d\n", |
1846 | dir->i_sb->s_id, dir->i_ino, | 1825 | dir->i_sb->s_id, dir->i_ino, |
1847 | dentry->d_name.name, symname, error); | 1826 | dentry, symname, error); |
1848 | d_drop(dentry); | 1827 | d_drop(dentry); |
1849 | __free_page(page); | 1828 | __free_page(page); |
1850 | return error; | 1829 | return error; |
@@ -1871,9 +1850,8 @@ nfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) | |||
1871 | struct inode *inode = old_dentry->d_inode; | 1850 | struct inode *inode = old_dentry->d_inode; |
1872 | int error; | 1851 | int error; |
1873 | 1852 | ||
1874 | dfprintk(VFS, "NFS: link(%s/%s -> %s/%s)\n", | 1853 | dfprintk(VFS, "NFS: link(%pd2 -> %pd2)\n", |
1875 | old_dentry->d_parent->d_name.name, old_dentry->d_name.name, | 1854 | old_dentry, dentry); |
1876 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
1877 | 1855 | ||
1878 | trace_nfs_link_enter(inode, dir, dentry); | 1856 | trace_nfs_link_enter(inode, dir, dentry); |
1879 | NFS_PROTO(inode)->return_delegation(inode); | 1857 | NFS_PROTO(inode)->return_delegation(inode); |
@@ -1921,9 +1899,8 @@ int nfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1921 | struct dentry *dentry = NULL, *rehash = NULL; | 1899 | struct dentry *dentry = NULL, *rehash = NULL; |
1922 | int error = -EBUSY; | 1900 | int error = -EBUSY; |
1923 | 1901 | ||
1924 | dfprintk(VFS, "NFS: rename(%s/%s -> %s/%s, ct=%d)\n", | 1902 | dfprintk(VFS, "NFS: rename(%pd2 -> %pd2, ct=%d)\n", |
1925 | old_dentry->d_parent->d_name.name, old_dentry->d_name.name, | 1903 | old_dentry, new_dentry, |
1926 | new_dentry->d_parent->d_name.name, new_dentry->d_name.name, | ||
1927 | d_count(new_dentry)); | 1904 | d_count(new_dentry)); |
1928 | 1905 | ||
1929 | trace_nfs_rename_enter(old_dir, old_dentry, new_dir, new_dentry); | 1906 | trace_nfs_rename_enter(old_dir, old_dentry, new_dir, new_dentry); |
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 91ff089d3412..d71d66c9e0a1 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c | |||
@@ -124,9 +124,8 @@ static inline int put_dreq(struct nfs_direct_req *dreq) | |||
124 | ssize_t nfs_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, loff_t pos, unsigned long nr_segs) | 124 | ssize_t nfs_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, loff_t pos, unsigned long nr_segs) |
125 | { | 125 | { |
126 | #ifndef CONFIG_NFS_SWAP | 126 | #ifndef CONFIG_NFS_SWAP |
127 | dprintk("NFS: nfs_direct_IO (%s) off/no(%Ld/%lu) EINVAL\n", | 127 | dprintk("NFS: nfs_direct_IO (%pD) off/no(%Ld/%lu) EINVAL\n", |
128 | iocb->ki_filp->f_path.dentry->d_name.name, | 128 | iocb->ki_filp, (long long) pos, nr_segs); |
129 | (long long) pos, nr_segs); | ||
130 | 129 | ||
131 | return -EINVAL; | 130 | return -EINVAL; |
132 | #else | 131 | #else |
@@ -909,10 +908,8 @@ ssize_t nfs_file_direct_read(struct kiocb *iocb, const struct iovec *iov, | |||
909 | count = iov_length(iov, nr_segs); | 908 | count = iov_length(iov, nr_segs); |
910 | nfs_add_stats(mapping->host, NFSIOS_DIRECTREADBYTES, count); | 909 | nfs_add_stats(mapping->host, NFSIOS_DIRECTREADBYTES, count); |
911 | 910 | ||
912 | dfprintk(FILE, "NFS: direct read(%s/%s, %zd@%Ld)\n", | 911 | dfprintk(FILE, "NFS: direct read(%pD2, %zd@%Ld)\n", |
913 | file->f_path.dentry->d_parent->d_name.name, | 912 | file, count, (long long) pos); |
914 | file->f_path.dentry->d_name.name, | ||
915 | count, (long long) pos); | ||
916 | 913 | ||
917 | retval = 0; | 914 | retval = 0; |
918 | if (!count) | 915 | if (!count) |
@@ -965,10 +962,8 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, const struct iovec *iov, | |||
965 | count = iov_length(iov, nr_segs); | 962 | count = iov_length(iov, nr_segs); |
966 | nfs_add_stats(mapping->host, NFSIOS_DIRECTWRITTENBYTES, count); | 963 | nfs_add_stats(mapping->host, NFSIOS_DIRECTWRITTENBYTES, count); |
967 | 964 | ||
968 | dfprintk(FILE, "NFS: direct write(%s/%s, %zd@%Ld)\n", | 965 | dfprintk(FILE, "NFS: direct write(%pD2, %zd@%Ld)\n", |
969 | file->f_path.dentry->d_parent->d_name.name, | 966 | file, count, (long long) pos); |
970 | file->f_path.dentry->d_name.name, | ||
971 | count, (long long) pos); | ||
972 | 967 | ||
973 | retval = generic_write_checks(file, &pos, &count, 0); | 968 | retval = generic_write_checks(file, &pos, &count, 0); |
974 | if (retval) | 969 | if (retval) |
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 1e6bfdbc1aff..e2fcacf07de3 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c | |||
@@ -65,9 +65,7 @@ nfs_file_open(struct inode *inode, struct file *filp) | |||
65 | { | 65 | { |
66 | int res; | 66 | int res; |
67 | 67 | ||
68 | dprintk("NFS: open file(%s/%s)\n", | 68 | dprintk("NFS: open file(%pD2)\n", filp); |
69 | filp->f_path.dentry->d_parent->d_name.name, | ||
70 | filp->f_path.dentry->d_name.name); | ||
71 | 69 | ||
72 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); | 70 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); |
73 | res = nfs_check_flags(filp->f_flags); | 71 | res = nfs_check_flags(filp->f_flags); |
@@ -81,9 +79,7 @@ nfs_file_open(struct inode *inode, struct file *filp) | |||
81 | int | 79 | int |
82 | nfs_file_release(struct inode *inode, struct file *filp) | 80 | nfs_file_release(struct inode *inode, struct file *filp) |
83 | { | 81 | { |
84 | dprintk("NFS: release(%s/%s)\n", | 82 | dprintk("NFS: release(%pD2)\n", filp); |
85 | filp->f_path.dentry->d_parent->d_name.name, | ||
86 | filp->f_path.dentry->d_name.name); | ||
87 | 83 | ||
88 | nfs_inc_stats(inode, NFSIOS_VFSRELEASE); | 84 | nfs_inc_stats(inode, NFSIOS_VFSRELEASE); |
89 | return nfs_release(inode, filp); | 85 | return nfs_release(inode, filp); |
@@ -123,10 +119,8 @@ force_reval: | |||
123 | 119 | ||
124 | loff_t nfs_file_llseek(struct file *filp, loff_t offset, int whence) | 120 | loff_t nfs_file_llseek(struct file *filp, loff_t offset, int whence) |
125 | { | 121 | { |
126 | dprintk("NFS: llseek file(%s/%s, %lld, %d)\n", | 122 | dprintk("NFS: llseek file(%pD2, %lld, %d)\n", |
127 | filp->f_path.dentry->d_parent->d_name.name, | 123 | filp, offset, whence); |
128 | filp->f_path.dentry->d_name.name, | ||
129 | offset, whence); | ||
130 | 124 | ||
131 | /* | 125 | /* |
132 | * whence == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate | 126 | * whence == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate |
@@ -150,12 +144,9 @@ EXPORT_SYMBOL_GPL(nfs_file_llseek); | |||
150 | int | 144 | int |
151 | nfs_file_flush(struct file *file, fl_owner_t id) | 145 | nfs_file_flush(struct file *file, fl_owner_t id) |
152 | { | 146 | { |
153 | struct dentry *dentry = file->f_path.dentry; | 147 | struct inode *inode = file_inode(file); |
154 | struct inode *inode = dentry->d_inode; | ||
155 | 148 | ||
156 | dprintk("NFS: flush(%s/%s)\n", | 149 | dprintk("NFS: flush(%pD2)\n", file); |
157 | dentry->d_parent->d_name.name, | ||
158 | dentry->d_name.name); | ||
159 | 150 | ||
160 | nfs_inc_stats(inode, NFSIOS_VFSFLUSH); | 151 | nfs_inc_stats(inode, NFSIOS_VFSFLUSH); |
161 | if ((file->f_mode & FMODE_WRITE) == 0) | 152 | if ((file->f_mode & FMODE_WRITE) == 0) |
@@ -177,15 +168,14 @@ ssize_t | |||
177 | nfs_file_read(struct kiocb *iocb, const struct iovec *iov, | 168 | nfs_file_read(struct kiocb *iocb, const struct iovec *iov, |
178 | unsigned long nr_segs, loff_t pos) | 169 | unsigned long nr_segs, loff_t pos) |
179 | { | 170 | { |
180 | struct dentry * dentry = iocb->ki_filp->f_path.dentry; | 171 | struct inode *inode = file_inode(iocb->ki_filp); |
181 | struct inode * inode = dentry->d_inode; | ||
182 | ssize_t result; | 172 | ssize_t result; |
183 | 173 | ||
184 | if (iocb->ki_filp->f_flags & O_DIRECT) | 174 | if (iocb->ki_filp->f_flags & O_DIRECT) |
185 | return nfs_file_direct_read(iocb, iov, nr_segs, pos, true); | 175 | return nfs_file_direct_read(iocb, iov, nr_segs, pos, true); |
186 | 176 | ||
187 | dprintk("NFS: read(%s/%s, %lu@%lu)\n", | 177 | dprintk("NFS: read(%pD2, %lu@%lu)\n", |
188 | dentry->d_parent->d_name.name, dentry->d_name.name, | 178 | iocb->ki_filp, |
189 | (unsigned long) iov_length(iov, nr_segs), (unsigned long) pos); | 179 | (unsigned long) iov_length(iov, nr_segs), (unsigned long) pos); |
190 | 180 | ||
191 | result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping); | 181 | result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping); |
@@ -203,13 +193,11 @@ nfs_file_splice_read(struct file *filp, loff_t *ppos, | |||
203 | struct pipe_inode_info *pipe, size_t count, | 193 | struct pipe_inode_info *pipe, size_t count, |
204 | unsigned int flags) | 194 | unsigned int flags) |
205 | { | 195 | { |
206 | struct dentry *dentry = filp->f_path.dentry; | 196 | struct inode *inode = file_inode(filp); |
207 | struct inode *inode = dentry->d_inode; | ||
208 | ssize_t res; | 197 | ssize_t res; |
209 | 198 | ||
210 | dprintk("NFS: splice_read(%s/%s, %lu@%Lu)\n", | 199 | dprintk("NFS: splice_read(%pD2, %lu@%Lu)\n", |
211 | dentry->d_parent->d_name.name, dentry->d_name.name, | 200 | filp, (unsigned long) count, (unsigned long long) *ppos); |
212 | (unsigned long) count, (unsigned long long) *ppos); | ||
213 | 201 | ||
214 | res = nfs_revalidate_mapping(inode, filp->f_mapping); | 202 | res = nfs_revalidate_mapping(inode, filp->f_mapping); |
215 | if (!res) { | 203 | if (!res) { |
@@ -224,12 +212,10 @@ EXPORT_SYMBOL_GPL(nfs_file_splice_read); | |||
224 | int | 212 | int |
225 | nfs_file_mmap(struct file * file, struct vm_area_struct * vma) | 213 | nfs_file_mmap(struct file * file, struct vm_area_struct * vma) |
226 | { | 214 | { |
227 | struct dentry *dentry = file->f_path.dentry; | 215 | struct inode *inode = file_inode(file); |
228 | struct inode *inode = dentry->d_inode; | ||
229 | int status; | 216 | int status; |
230 | 217 | ||
231 | dprintk("NFS: mmap(%s/%s)\n", | 218 | dprintk("NFS: mmap(%pD2)\n", file); |
232 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
233 | 219 | ||
234 | /* Note: generic_file_mmap() returns ENOSYS on nommu systems | 220 | /* Note: generic_file_mmap() returns ENOSYS on nommu systems |
235 | * so we call that before revalidating the mapping | 221 | * so we call that before revalidating the mapping |
@@ -258,15 +244,12 @@ EXPORT_SYMBOL_GPL(nfs_file_mmap); | |||
258 | int | 244 | int |
259 | nfs_file_fsync_commit(struct file *file, loff_t start, loff_t end, int datasync) | 245 | nfs_file_fsync_commit(struct file *file, loff_t start, loff_t end, int datasync) |
260 | { | 246 | { |
261 | struct dentry *dentry = file->f_path.dentry; | ||
262 | struct nfs_open_context *ctx = nfs_file_open_context(file); | 247 | struct nfs_open_context *ctx = nfs_file_open_context(file); |
263 | struct inode *inode = dentry->d_inode; | 248 | struct inode *inode = file_inode(file); |
264 | int have_error, do_resend, status; | 249 | int have_error, do_resend, status; |
265 | int ret = 0; | 250 | int ret = 0; |
266 | 251 | ||
267 | dprintk("NFS: fsync file(%s/%s) datasync %d\n", | 252 | dprintk("NFS: fsync file(%pD2) datasync %d\n", file, datasync); |
268 | dentry->d_parent->d_name.name, dentry->d_name.name, | ||
269 | datasync); | ||
270 | 253 | ||
271 | nfs_inc_stats(inode, NFSIOS_VFSFSYNC); | 254 | nfs_inc_stats(inode, NFSIOS_VFSFSYNC); |
272 | do_resend = test_and_clear_bit(NFS_CONTEXT_RESEND_WRITES, &ctx->flags); | 255 | do_resend = test_and_clear_bit(NFS_CONTEXT_RESEND_WRITES, &ctx->flags); |
@@ -371,10 +354,8 @@ static int nfs_write_begin(struct file *file, struct address_space *mapping, | |||
371 | struct page *page; | 354 | struct page *page; |
372 | int once_thru = 0; | 355 | int once_thru = 0; |
373 | 356 | ||
374 | dfprintk(PAGECACHE, "NFS: write_begin(%s/%s(%ld), %u@%lld)\n", | 357 | dfprintk(PAGECACHE, "NFS: write_begin(%pD2(%ld), %u@%lld)\n", |
375 | file->f_path.dentry->d_parent->d_name.name, | 358 | file, mapping->host->i_ino, len, (long long) pos); |
376 | file->f_path.dentry->d_name.name, | ||
377 | mapping->host->i_ino, len, (long long) pos); | ||
378 | 359 | ||
379 | start: | 360 | start: |
380 | /* | 361 | /* |
@@ -414,10 +395,8 @@ static int nfs_write_end(struct file *file, struct address_space *mapping, | |||
414 | struct nfs_open_context *ctx = nfs_file_open_context(file); | 395 | struct nfs_open_context *ctx = nfs_file_open_context(file); |
415 | int status; | 396 | int status; |
416 | 397 | ||
417 | dfprintk(PAGECACHE, "NFS: write_end(%s/%s(%ld), %u@%lld)\n", | 398 | dfprintk(PAGECACHE, "NFS: write_end(%pD2(%ld), %u@%lld)\n", |
418 | file->f_path.dentry->d_parent->d_name.name, | 399 | file, mapping->host->i_ino, len, (long long) pos); |
419 | file->f_path.dentry->d_name.name, | ||
420 | mapping->host->i_ino, len, (long long) pos); | ||
421 | 400 | ||
422 | /* | 401 | /* |
423 | * Zero any uninitialised parts of the page, and then mark the page | 402 | * Zero any uninitialised parts of the page, and then mark the page |
@@ -601,22 +580,21 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
601 | { | 580 | { |
602 | struct page *page = vmf->page; | 581 | struct page *page = vmf->page; |
603 | struct file *filp = vma->vm_file; | 582 | struct file *filp = vma->vm_file; |
604 | struct dentry *dentry = filp->f_path.dentry; | 583 | struct inode *inode = file_inode(filp); |
605 | unsigned pagelen; | 584 | unsigned pagelen; |
606 | int ret = VM_FAULT_NOPAGE; | 585 | int ret = VM_FAULT_NOPAGE; |
607 | struct address_space *mapping; | 586 | struct address_space *mapping; |
608 | 587 | ||
609 | dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%s/%s(%ld), offset %lld)\n", | 588 | dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%ld), offset %lld)\n", |
610 | dentry->d_parent->d_name.name, dentry->d_name.name, | 589 | filp, filp->f_mapping->host->i_ino, |
611 | filp->f_mapping->host->i_ino, | ||
612 | (long long)page_offset(page)); | 590 | (long long)page_offset(page)); |
613 | 591 | ||
614 | /* make sure the cache has finished storing the page */ | 592 | /* make sure the cache has finished storing the page */ |
615 | nfs_fscache_wait_on_page_write(NFS_I(dentry->d_inode), page); | 593 | nfs_fscache_wait_on_page_write(NFS_I(inode), page); |
616 | 594 | ||
617 | lock_page(page); | 595 | lock_page(page); |
618 | mapping = page_file_mapping(page); | 596 | mapping = page_file_mapping(page); |
619 | if (mapping != dentry->d_inode->i_mapping) | 597 | if (mapping != inode->i_mapping) |
620 | goto out_unlock; | 598 | goto out_unlock; |
621 | 599 | ||
622 | wait_on_page_writeback(page); | 600 | wait_on_page_writeback(page); |
@@ -659,22 +637,21 @@ static int nfs_need_sync_write(struct file *filp, struct inode *inode) | |||
659 | ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, | 637 | ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, |
660 | unsigned long nr_segs, loff_t pos) | 638 | unsigned long nr_segs, loff_t pos) |
661 | { | 639 | { |
662 | struct dentry * dentry = iocb->ki_filp->f_path.dentry; | 640 | struct file *file = iocb->ki_filp; |
663 | struct inode * inode = dentry->d_inode; | 641 | struct inode *inode = file_inode(file); |
664 | unsigned long written = 0; | 642 | unsigned long written = 0; |
665 | ssize_t result; | 643 | ssize_t result; |
666 | size_t count = iov_length(iov, nr_segs); | 644 | size_t count = iov_length(iov, nr_segs); |
667 | 645 | ||
668 | result = nfs_key_timeout_notify(iocb->ki_filp, inode); | 646 | result = nfs_key_timeout_notify(file, inode); |
669 | if (result) | 647 | if (result) |
670 | return result; | 648 | return result; |
671 | 649 | ||
672 | if (iocb->ki_filp->f_flags & O_DIRECT) | 650 | if (file->f_flags & O_DIRECT) |
673 | return nfs_file_direct_write(iocb, iov, nr_segs, pos, true); | 651 | return nfs_file_direct_write(iocb, iov, nr_segs, pos, true); |
674 | 652 | ||
675 | dprintk("NFS: write(%s/%s, %lu@%Ld)\n", | 653 | dprintk("NFS: write(%pD2, %lu@%Ld)\n", |
676 | dentry->d_parent->d_name.name, dentry->d_name.name, | 654 | file, (unsigned long) count, (long long) pos); |
677 | (unsigned long) count, (long long) pos); | ||
678 | 655 | ||
679 | result = -EBUSY; | 656 | result = -EBUSY; |
680 | if (IS_SWAPFILE(inode)) | 657 | if (IS_SWAPFILE(inode)) |
@@ -682,8 +659,8 @@ ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
682 | /* | 659 | /* |
683 | * O_APPEND implies that we must revalidate the file length. | 660 | * O_APPEND implies that we must revalidate the file length. |
684 | */ | 661 | */ |
685 | if (iocb->ki_filp->f_flags & O_APPEND) { | 662 | if (file->f_flags & O_APPEND) { |
686 | result = nfs_revalidate_file_size(inode, iocb->ki_filp); | 663 | result = nfs_revalidate_file_size(inode, file); |
687 | if (result) | 664 | if (result) |
688 | goto out; | 665 | goto out; |
689 | } | 666 | } |
@@ -697,8 +674,8 @@ ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
697 | written = result; | 674 | written = result; |
698 | 675 | ||
699 | /* Return error values for O_DSYNC and IS_SYNC() */ | 676 | /* Return error values for O_DSYNC and IS_SYNC() */ |
700 | if (result >= 0 && nfs_need_sync_write(iocb->ki_filp, inode)) { | 677 | if (result >= 0 && nfs_need_sync_write(file, inode)) { |
701 | int err = vfs_fsync(iocb->ki_filp, 0); | 678 | int err = vfs_fsync(file, 0); |
702 | if (err < 0) | 679 | if (err < 0) |
703 | result = err; | 680 | result = err; |
704 | } | 681 | } |
@@ -717,14 +694,12 @@ ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe, | |||
717 | struct file *filp, loff_t *ppos, | 694 | struct file *filp, loff_t *ppos, |
718 | size_t count, unsigned int flags) | 695 | size_t count, unsigned int flags) |
719 | { | 696 | { |
720 | struct dentry *dentry = filp->f_path.dentry; | 697 | struct inode *inode = file_inode(filp); |
721 | struct inode *inode = dentry->d_inode; | ||
722 | unsigned long written = 0; | 698 | unsigned long written = 0; |
723 | ssize_t ret; | 699 | ssize_t ret; |
724 | 700 | ||
725 | dprintk("NFS splice_write(%s/%s, %lu@%llu)\n", | 701 | dprintk("NFS splice_write(%pD2, %lu@%llu)\n", |
726 | dentry->d_parent->d_name.name, dentry->d_name.name, | 702 | filp, (unsigned long) count, (unsigned long long) *ppos); |
727 | (unsigned long) count, (unsigned long long) *ppos); | ||
728 | 703 | ||
729 | /* | 704 | /* |
730 | * The combination of splice and an O_APPEND destination is disallowed. | 705 | * The combination of splice and an O_APPEND destination is disallowed. |
@@ -883,10 +858,8 @@ int nfs_lock(struct file *filp, int cmd, struct file_lock *fl) | |||
883 | int ret = -ENOLCK; | 858 | int ret = -ENOLCK; |
884 | int is_local = 0; | 859 | int is_local = 0; |
885 | 860 | ||
886 | dprintk("NFS: lock(%s/%s, t=%x, fl=%x, r=%lld:%lld)\n", | 861 | dprintk("NFS: lock(%pD2, t=%x, fl=%x, r=%lld:%lld)\n", |
887 | filp->f_path.dentry->d_parent->d_name.name, | 862 | filp, fl->fl_type, fl->fl_flags, |
888 | filp->f_path.dentry->d_name.name, | ||
889 | fl->fl_type, fl->fl_flags, | ||
890 | (long long)fl->fl_start, (long long)fl->fl_end); | 863 | (long long)fl->fl_start, (long long)fl->fl_end); |
891 | 864 | ||
892 | nfs_inc_stats(inode, NFSIOS_VFSLOCK); | 865 | nfs_inc_stats(inode, NFSIOS_VFSLOCK); |
@@ -923,10 +896,8 @@ int nfs_flock(struct file *filp, int cmd, struct file_lock *fl) | |||
923 | struct inode *inode = filp->f_mapping->host; | 896 | struct inode *inode = filp->f_mapping->host; |
924 | int is_local = 0; | 897 | int is_local = 0; |
925 | 898 | ||
926 | dprintk("NFS: flock(%s/%s, t=%x, fl=%x)\n", | 899 | dprintk("NFS: flock(%pD2, t=%x, fl=%x)\n", |
927 | filp->f_path.dentry->d_parent->d_name.name, | 900 | filp, fl->fl_type, fl->fl_flags); |
928 | filp->f_path.dentry->d_name.name, | ||
929 | fl->fl_type, fl->fl_flags); | ||
930 | 901 | ||
931 | if (!(fl->fl_flags & FL_FLOCK)) | 902 | if (!(fl->fl_flags & FL_FLOCK)) |
932 | return -ENOLCK; | 903 | return -ENOLCK; |
@@ -960,9 +931,7 @@ EXPORT_SYMBOL_GPL(nfs_flock); | |||
960 | */ | 931 | */ |
961 | int nfs_setlease(struct file *file, long arg, struct file_lock **fl) | 932 | int nfs_setlease(struct file *file, long arg, struct file_lock **fl) |
962 | { | 933 | { |
963 | dprintk("NFS: setlease(%s/%s, arg=%ld)\n", | 934 | dprintk("NFS: setlease(%pD2, arg=%ld)\n", file, arg); |
964 | file->f_path.dentry->d_parent->d_name.name, | ||
965 | file->f_path.dentry->d_name.name, arg); | ||
966 | return -EINVAL; | 935 | return -EINVAL; |
967 | } | 936 | } |
968 | EXPORT_SYMBOL_GPL(nfs_setlease); | 937 | EXPORT_SYMBOL_GPL(nfs_setlease); |
diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c index 348b535cd786..b5a0afc3ee10 100644 --- a/fs/nfs/namespace.c +++ b/fs/nfs/namespace.c | |||
@@ -253,9 +253,8 @@ struct vfsmount *nfs_do_submount(struct dentry *dentry, struct nfs_fh *fh, | |||
253 | 253 | ||
254 | dprintk("--> nfs_do_submount()\n"); | 254 | dprintk("--> nfs_do_submount()\n"); |
255 | 255 | ||
256 | dprintk("%s: submounting on %s/%s\n", __func__, | 256 | dprintk("%s: submounting on %pd2\n", __func__, |
257 | dentry->d_parent->d_name.name, | 257 | dentry); |
258 | dentry->d_name.name); | ||
259 | if (page == NULL) | 258 | if (page == NULL) |
260 | goto out; | 259 | goto out; |
261 | devname = nfs_devname(dentry, page, PAGE_SIZE); | 260 | devname = nfs_devname(dentry, page, PAGE_SIZE); |
diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c index 90cb10d7b693..01b6f6a49d16 100644 --- a/fs/nfs/nfs3proc.c +++ b/fs/nfs/nfs3proc.c | |||
@@ -321,7 +321,7 @@ nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | |||
321 | umode_t mode = sattr->ia_mode; | 321 | umode_t mode = sattr->ia_mode; |
322 | int status = -ENOMEM; | 322 | int status = -ENOMEM; |
323 | 323 | ||
324 | dprintk("NFS call create %s\n", dentry->d_name.name); | 324 | dprintk("NFS call create %pd\n", dentry); |
325 | 325 | ||
326 | data = nfs3_alloc_createdata(); | 326 | data = nfs3_alloc_createdata(); |
327 | if (data == NULL) | 327 | if (data == NULL) |
@@ -548,7 +548,7 @@ nfs3_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page, | |||
548 | if (len > NFS3_MAXPATHLEN) | 548 | if (len > NFS3_MAXPATHLEN) |
549 | return -ENAMETOOLONG; | 549 | return -ENAMETOOLONG; |
550 | 550 | ||
551 | dprintk("NFS call symlink %s\n", dentry->d_name.name); | 551 | dprintk("NFS call symlink %pd\n", dentry); |
552 | 552 | ||
553 | data = nfs3_alloc_createdata(); | 553 | data = nfs3_alloc_createdata(); |
554 | if (data == NULL) | 554 | if (data == NULL) |
@@ -576,7 +576,7 @@ nfs3_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr *sattr) | |||
576 | umode_t mode = sattr->ia_mode; | 576 | umode_t mode = sattr->ia_mode; |
577 | int status = -ENOMEM; | 577 | int status = -ENOMEM; |
578 | 578 | ||
579 | dprintk("NFS call mkdir %s\n", dentry->d_name.name); | 579 | dprintk("NFS call mkdir %pd\n", dentry); |
580 | 580 | ||
581 | sattr->ia_mode &= ~current_umask(); | 581 | sattr->ia_mode &= ~current_umask(); |
582 | 582 | ||
@@ -695,7 +695,7 @@ nfs3_proc_mknod(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | |||
695 | umode_t mode = sattr->ia_mode; | 695 | umode_t mode = sattr->ia_mode; |
696 | int status = -ENOMEM; | 696 | int status = -ENOMEM; |
697 | 697 | ||
698 | dprintk("NFS call mknod %s %u:%u\n", dentry->d_name.name, | 698 | dprintk("NFS call mknod %pd %u:%u\n", dentry, |
699 | MAJOR(rdev), MINOR(rdev)); | 699 | MAJOR(rdev), MINOR(rdev)); |
700 | 700 | ||
701 | sattr->ia_mode &= ~current_umask(); | 701 | sattr->ia_mode &= ~current_umask(); |
diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c index 1f01b55692ee..8de3407e0360 100644 --- a/fs/nfs/nfs4file.c +++ b/fs/nfs/nfs4file.c | |||
@@ -31,9 +31,7 @@ nfs4_file_open(struct inode *inode, struct file *filp) | |||
31 | * -EOPENSTALE. The VFS will retry the lookup/create/open. | 31 | * -EOPENSTALE. The VFS will retry the lookup/create/open. |
32 | */ | 32 | */ |
33 | 33 | ||
34 | dprintk("NFS: open file(%s/%s)\n", | 34 | dprintk("NFS: open file(%pd2)\n", dentry); |
35 | dentry->d_parent->d_name.name, | ||
36 | dentry->d_name.name); | ||
37 | 35 | ||
38 | if ((openflags & O_ACCMODE) == 3) | 36 | if ((openflags & O_ACCMODE) == 3) |
39 | openflags--; | 37 | openflags--; |
diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c index c08cbf40c59e..4e7f05d3e9db 100644 --- a/fs/nfs/nfs4namespace.c +++ b/fs/nfs/nfs4namespace.c | |||
@@ -292,8 +292,7 @@ static struct vfsmount *nfs_follow_referral(struct dentry *dentry, | |||
292 | if (locations == NULL || locations->nlocations <= 0) | 292 | if (locations == NULL || locations->nlocations <= 0) |
293 | goto out; | 293 | goto out; |
294 | 294 | ||
295 | dprintk("%s: referral at %s/%s\n", __func__, | 295 | dprintk("%s: referral at %pd2\n", __func__, dentry); |
296 | dentry->d_parent->d_name.name, dentry->d_name.name); | ||
297 | 296 | ||
298 | page = (char *) __get_free_page(GFP_USER); | 297 | page = (char *) __get_free_page(GFP_USER); |
299 | if (!page) | 298 | if (!page) |
@@ -357,8 +356,8 @@ static struct vfsmount *nfs_do_refmount(struct rpc_clnt *client, struct dentry * | |||
357 | mnt = ERR_PTR(-ENOENT); | 356 | mnt = ERR_PTR(-ENOENT); |
358 | 357 | ||
359 | parent = dget_parent(dentry); | 358 | parent = dget_parent(dentry); |
360 | dprintk("%s: getting locations for %s/%s\n", | 359 | dprintk("%s: getting locations for %pd2\n", |
361 | __func__, parent->d_name.name, dentry->d_name.name); | 360 | __func__, dentry); |
362 | 361 | ||
363 | err = nfs4_proc_fs_locations(client, parent->d_inode, &dentry->d_name, fs_locations, page); | 362 | err = nfs4_proc_fs_locations(client, parent->d_inode, &dentry->d_name, fs_locations, page); |
364 | dput(parent); | 363 | dput(parent); |
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 5ab33c0792df..659990c0109e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
@@ -3771,9 +3771,8 @@ static int _nfs4_proc_readdir(struct dentry *dentry, struct rpc_cred *cred, | |||
3771 | }; | 3771 | }; |
3772 | int status; | 3772 | int status; |
3773 | 3773 | ||
3774 | dprintk("%s: dentry = %s/%s, cookie = %Lu\n", __func__, | 3774 | dprintk("%s: dentry = %pd2, cookie = %Lu\n", __func__, |
3775 | dentry->d_parent->d_name.name, | 3775 | dentry, |
3776 | dentry->d_name.name, | ||
3777 | (unsigned long long)cookie); | 3776 | (unsigned long long)cookie); |
3778 | nfs4_setup_readdir(cookie, NFS_I(dir)->cookieverf, dentry, &args); | 3777 | nfs4_setup_readdir(cookie, NFS_I(dir)->cookieverf, dentry, &args); |
3779 | res.pgbase = args.pgbase; | 3778 | res.pgbase = args.pgbase; |
diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index a8f57c728df5..fddbba2d9eff 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c | |||
@@ -235,7 +235,7 @@ nfs_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | |||
235 | }; | 235 | }; |
236 | int status = -ENOMEM; | 236 | int status = -ENOMEM; |
237 | 237 | ||
238 | dprintk("NFS call create %s\n", dentry->d_name.name); | 238 | dprintk("NFS call create %pd\n", dentry); |
239 | data = nfs_alloc_createdata(dir, dentry, sattr); | 239 | data = nfs_alloc_createdata(dir, dentry, sattr); |
240 | if (data == NULL) | 240 | if (data == NULL) |
241 | goto out; | 241 | goto out; |
@@ -265,7 +265,7 @@ nfs_proc_mknod(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | |||
265 | umode_t mode; | 265 | umode_t mode; |
266 | int status = -ENOMEM; | 266 | int status = -ENOMEM; |
267 | 267 | ||
268 | dprintk("NFS call mknod %s\n", dentry->d_name.name); | 268 | dprintk("NFS call mknod %pd\n", dentry); |
269 | 269 | ||
270 | mode = sattr->ia_mode; | 270 | mode = sattr->ia_mode; |
271 | if (S_ISFIFO(mode)) { | 271 | if (S_ISFIFO(mode)) { |
@@ -423,7 +423,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page, | |||
423 | }; | 423 | }; |
424 | int status = -ENAMETOOLONG; | 424 | int status = -ENAMETOOLONG; |
425 | 425 | ||
426 | dprintk("NFS call symlink %s\n", dentry->d_name.name); | 426 | dprintk("NFS call symlink %pd\n", dentry); |
427 | 427 | ||
428 | if (len > NFS2_MAXPATHLEN) | 428 | if (len > NFS2_MAXPATHLEN) |
429 | goto out; | 429 | goto out; |
@@ -462,7 +462,7 @@ nfs_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr *sattr) | |||
462 | }; | 462 | }; |
463 | int status = -ENOMEM; | 463 | int status = -ENOMEM; |
464 | 464 | ||
465 | dprintk("NFS call mkdir %s\n", dentry->d_name.name); | 465 | dprintk("NFS call mkdir %pd\n", dentry); |
466 | data = nfs_alloc_createdata(dir, dentry, sattr); | 466 | data = nfs_alloc_createdata(dir, dentry, sattr); |
467 | if (data == NULL) | 467 | if (data == NULL) |
468 | goto out; | 468 | goto out; |
diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c index 0c29b1bb3936..11d78944de79 100644 --- a/fs/nfs/unlink.c +++ b/fs/nfs/unlink.c | |||
@@ -495,9 +495,8 @@ nfs_sillyrename(struct inode *dir, struct dentry *dentry) | |||
495 | struct rpc_task *task; | 495 | struct rpc_task *task; |
496 | int error = -EBUSY; | 496 | int error = -EBUSY; |
497 | 497 | ||
498 | dfprintk(VFS, "NFS: silly-rename(%s/%s, ct=%d)\n", | 498 | dfprintk(VFS, "NFS: silly-rename(%pd2, ct=%d)\n", |
499 | dentry->d_parent->d_name.name, dentry->d_name.name, | 499 | dentry, d_count(dentry)); |
500 | d_count(dentry)); | ||
501 | nfs_inc_stats(dir, NFSIOS_SILLYRENAME); | 500 | nfs_inc_stats(dir, NFSIOS_SILLYRENAME); |
502 | 501 | ||
503 | /* | 502 | /* |
@@ -521,8 +520,8 @@ nfs_sillyrename(struct inode *dir, struct dentry *dentry) | |||
521 | SILLYNAME_FILEID_LEN, fileid, | 520 | SILLYNAME_FILEID_LEN, fileid, |
522 | SILLYNAME_COUNTER_LEN, sillycounter); | 521 | SILLYNAME_COUNTER_LEN, sillycounter); |
523 | 522 | ||
524 | dfprintk(VFS, "NFS: trying to rename %s to %s\n", | 523 | dfprintk(VFS, "NFS: trying to rename %pd to %s\n", |
525 | dentry->d_name.name, silly); | 524 | dentry, silly); |
526 | 525 | ||
527 | sdentry = lookup_one_len(silly, dentry->d_parent, slen); | 526 | sdentry = lookup_one_len(silly, dentry->d_parent, slen); |
528 | /* | 527 | /* |
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index ac1dc331ba31..c1d548211c31 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -954,10 +954,8 @@ int nfs_updatepage(struct file *file, struct page *page, | |||
954 | 954 | ||
955 | nfs_inc_stats(inode, NFSIOS_VFSUPDATEPAGE); | 955 | nfs_inc_stats(inode, NFSIOS_VFSUPDATEPAGE); |
956 | 956 | ||
957 | dprintk("NFS: nfs_updatepage(%s/%s %d@%lld)\n", | 957 | dprintk("NFS: nfs_updatepage(%pD2 %d@%lld)\n", |
958 | file->f_path.dentry->d_parent->d_name.name, | 958 | file, count, (long long)(page_file_offset(page) + offset)); |
959 | file->f_path.dentry->d_name.name, count, | ||
960 | (long long)(page_file_offset(page) + offset)); | ||
961 | 959 | ||
962 | if (nfs_can_extend_write(file, page, inode)) { | 960 | if (nfs_can_extend_write(file, page, inode)) { |
963 | count = max(count + offset, nfs_page_length(page)); | 961 | count = max(count + offset, nfs_page_length(page)); |
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index e0a65a9e37e9..9c271f42604a 100644 --- a/fs/nfsd/nfs4recover.c +++ b/fs/nfsd/nfs4recover.c | |||
@@ -385,8 +385,8 @@ purge_old(struct dentry *parent, struct dentry *child, struct nfsd_net *nn) | |||
385 | 385 | ||
386 | status = vfs_rmdir(parent->d_inode, child); | 386 | status = vfs_rmdir(parent->d_inode, child); |
387 | if (status) | 387 | if (status) |
388 | printk("failed to remove client recovery directory %s\n", | 388 | printk("failed to remove client recovery directory %pd\n", |
389 | child->d_name.name); | 389 | child); |
390 | /* Keep trying, success or failure: */ | 390 | /* Keep trying, success or failure: */ |
391 | return 0; | 391 | return 0; |
392 | } | 392 | } |
@@ -410,15 +410,15 @@ out: | |||
410 | nfs4_release_reclaim(nn); | 410 | nfs4_release_reclaim(nn); |
411 | if (status) | 411 | if (status) |
412 | printk("nfsd4: failed to purge old clients from recovery" | 412 | printk("nfsd4: failed to purge old clients from recovery" |
413 | " directory %s\n", nn->rec_file->f_path.dentry->d_name.name); | 413 | " directory %pD\n", nn->rec_file); |
414 | } | 414 | } |
415 | 415 | ||
416 | static int | 416 | static int |
417 | load_recdir(struct dentry *parent, struct dentry *child, struct nfsd_net *nn) | 417 | load_recdir(struct dentry *parent, struct dentry *child, struct nfsd_net *nn) |
418 | { | 418 | { |
419 | if (child->d_name.len != HEXDIR_LEN - 1) { | 419 | if (child->d_name.len != HEXDIR_LEN - 1) { |
420 | printk("nfsd4: illegal name %s in recovery directory\n", | 420 | printk("nfsd4: illegal name %pd in recovery directory\n", |
421 | child->d_name.name); | 421 | child); |
422 | /* Keep trying; maybe the others are OK: */ | 422 | /* Keep trying; maybe the others are OK: */ |
423 | return 0; | 423 | return 0; |
424 | } | 424 | } |
@@ -437,7 +437,7 @@ nfsd4_recdir_load(struct net *net) { | |||
437 | status = nfsd4_list_rec_dir(load_recdir, nn); | 437 | status = nfsd4_list_rec_dir(load_recdir, nn); |
438 | if (status) | 438 | if (status) |
439 | printk("nfsd4: failed loading clients from recovery" | 439 | printk("nfsd4: failed loading clients from recovery" |
440 | " directory %s\n", nn->rec_file->f_path.dentry->d_name.name); | 440 | " directory %pD\n", nn->rec_file); |
441 | return status; | 441 | return status; |
442 | } | 442 | } |
443 | 443 | ||
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 0874998a49cd..f36a30a9f2d1 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c | |||
@@ -3008,7 +3008,7 @@ static struct file_lock *nfs4_alloc_init_lease(struct nfs4_delegation *dp, int f | |||
3008 | return NULL; | 3008 | return NULL; |
3009 | locks_init_lock(fl); | 3009 | locks_init_lock(fl); |
3010 | fl->fl_lmops = &nfsd_lease_mng_ops; | 3010 | fl->fl_lmops = &nfsd_lease_mng_ops; |
3011 | fl->fl_flags = FL_LEASE; | 3011 | fl->fl_flags = FL_DELEG; |
3012 | fl->fl_type = flag == NFS4_OPEN_DELEGATE_READ? F_RDLCK: F_WRLCK; | 3012 | fl->fl_type = flag == NFS4_OPEN_DELEGATE_READ? F_RDLCK: F_WRLCK; |
3013 | fl->fl_end = OFFSET_MAX; | 3013 | fl->fl_end = OFFSET_MAX; |
3014 | fl->fl_owner = (fl_owner_t)(dp->dl_file); | 3014 | fl->fl_owner = (fl_owner_t)(dp->dl_file); |
@@ -3843,9 +3843,8 @@ nfsd4_open_confirm(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, | |||
3843 | struct nfs4_ol_stateid *stp; | 3843 | struct nfs4_ol_stateid *stp; |
3844 | struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); | 3844 | struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); |
3845 | 3845 | ||
3846 | dprintk("NFSD: nfsd4_open_confirm on file %.*s\n", | 3846 | dprintk("NFSD: nfsd4_open_confirm on file %pd\n", |
3847 | (int)cstate->current_fh.fh_dentry->d_name.len, | 3847 | cstate->current_fh.fh_dentry); |
3848 | cstate->current_fh.fh_dentry->d_name.name); | ||
3849 | 3848 | ||
3850 | status = fh_verify(rqstp, &cstate->current_fh, S_IFREG, 0); | 3849 | status = fh_verify(rqstp, &cstate->current_fh, S_IFREG, 0); |
3851 | if (status) | 3850 | if (status) |
@@ -3922,9 +3921,8 @@ nfsd4_open_downgrade(struct svc_rqst *rqstp, | |||
3922 | struct nfs4_ol_stateid *stp; | 3921 | struct nfs4_ol_stateid *stp; |
3923 | struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); | 3922 | struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); |
3924 | 3923 | ||
3925 | dprintk("NFSD: nfsd4_open_downgrade on file %.*s\n", | 3924 | dprintk("NFSD: nfsd4_open_downgrade on file %pd\n", |
3926 | (int)cstate->current_fh.fh_dentry->d_name.len, | 3925 | cstate->current_fh.fh_dentry); |
3927 | cstate->current_fh.fh_dentry->d_name.name); | ||
3928 | 3926 | ||
3929 | /* We don't yet support WANT bits: */ | 3927 | /* We don't yet support WANT bits: */ |
3930 | if (od->od_deleg_want) | 3928 | if (od->od_deleg_want) |
@@ -3980,9 +3978,8 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, | |||
3980 | struct net *net = SVC_NET(rqstp); | 3978 | struct net *net = SVC_NET(rqstp); |
3981 | struct nfsd_net *nn = net_generic(net, nfsd_net_id); | 3979 | struct nfsd_net *nn = net_generic(net, nfsd_net_id); |
3982 | 3980 | ||
3983 | dprintk("NFSD: nfsd4_close on file %.*s\n", | 3981 | dprintk("NFSD: nfsd4_close on file %pd\n", |
3984 | (int)cstate->current_fh.fh_dentry->d_name.len, | 3982 | cstate->current_fh.fh_dentry); |
3985 | cstate->current_fh.fh_dentry->d_name.name); | ||
3986 | 3983 | ||
3987 | nfs4_lock_state(); | 3984 | nfs4_lock_state(); |
3988 | status = nfs4_preprocess_seqid_op(cstate, close->cl_seqid, | 3985 | status = nfs4_preprocess_seqid_op(cstate, close->cl_seqid, |
diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 814afaa4458a..3d0e15ae6f72 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c | |||
@@ -47,7 +47,7 @@ static int nfsd_acceptable(void *expv, struct dentry *dentry) | |||
47 | tdentry = parent; | 47 | tdentry = parent; |
48 | } | 48 | } |
49 | if (tdentry != exp->ex_path.dentry) | 49 | if (tdentry != exp->ex_path.dentry) |
50 | dprintk("nfsd_acceptable failed at %p %s\n", tdentry, tdentry->d_name.name); | 50 | dprintk("nfsd_acceptable failed at %p %pd\n", tdentry, tdentry); |
51 | rv = (tdentry == exp->ex_path.dentry); | 51 | rv = (tdentry == exp->ex_path.dentry); |
52 | dput(tdentry); | 52 | dput(tdentry); |
53 | return rv; | 53 | return rv; |
@@ -253,8 +253,8 @@ static __be32 nfsd_set_fh_dentry(struct svc_rqst *rqstp, struct svc_fh *fhp) | |||
253 | 253 | ||
254 | if (S_ISDIR(dentry->d_inode->i_mode) && | 254 | if (S_ISDIR(dentry->d_inode->i_mode) && |
255 | (dentry->d_flags & DCACHE_DISCONNECTED)) { | 255 | (dentry->d_flags & DCACHE_DISCONNECTED)) { |
256 | printk("nfsd: find_fh_dentry returned a DISCONNECTED directory: %s/%s\n", | 256 | printk("nfsd: find_fh_dentry returned a DISCONNECTED directory: %pd2\n", |
257 | dentry->d_parent->d_name.name, dentry->d_name.name); | 257 | dentry); |
258 | } | 258 | } |
259 | 259 | ||
260 | fhp->fh_dentry = dentry; | 260 | fhp->fh_dentry = dentry; |
@@ -361,10 +361,9 @@ skip_pseudoflavor_check: | |||
361 | error = nfsd_permission(rqstp, exp, dentry, access); | 361 | error = nfsd_permission(rqstp, exp, dentry, access); |
362 | 362 | ||
363 | if (error) { | 363 | if (error) { |
364 | dprintk("fh_verify: %s/%s permission failure, " | 364 | dprintk("fh_verify: %pd2 permission failure, " |
365 | "acc=%x, error=%d\n", | 365 | "acc=%x, error=%d\n", |
366 | dentry->d_parent->d_name.name, | 366 | dentry, |
367 | dentry->d_name.name, | ||
368 | access, ntohl(error)); | 367 | access, ntohl(error)); |
369 | } | 368 | } |
370 | out: | 369 | out: |
@@ -514,14 +513,13 @@ fh_compose(struct svc_fh *fhp, struct svc_export *exp, struct dentry *dentry, | |||
514 | */ | 513 | */ |
515 | 514 | ||
516 | struct inode * inode = dentry->d_inode; | 515 | struct inode * inode = dentry->d_inode; |
517 | struct dentry *parent = dentry->d_parent; | ||
518 | __u32 *datap; | 516 | __u32 *datap; |
519 | dev_t ex_dev = exp_sb(exp)->s_dev; | 517 | dev_t ex_dev = exp_sb(exp)->s_dev; |
520 | 518 | ||
521 | dprintk("nfsd: fh_compose(exp %02x:%02x/%ld %s/%s, ino=%ld)\n", | 519 | dprintk("nfsd: fh_compose(exp %02x:%02x/%ld %pd2, ino=%ld)\n", |
522 | MAJOR(ex_dev), MINOR(ex_dev), | 520 | MAJOR(ex_dev), MINOR(ex_dev), |
523 | (long) exp->ex_path.dentry->d_inode->i_ino, | 521 | (long) exp->ex_path.dentry->d_inode->i_ino, |
524 | parent->d_name.name, dentry->d_name.name, | 522 | dentry, |
525 | (inode ? inode->i_ino : 0)); | 523 | (inode ? inode->i_ino : 0)); |
526 | 524 | ||
527 | /* Choose filehandle version and fsid type based on | 525 | /* Choose filehandle version and fsid type based on |
@@ -534,13 +532,13 @@ fh_compose(struct svc_fh *fhp, struct svc_export *exp, struct dentry *dentry, | |||
534 | fh_put(ref_fh); | 532 | fh_put(ref_fh); |
535 | 533 | ||
536 | if (fhp->fh_locked || fhp->fh_dentry) { | 534 | if (fhp->fh_locked || fhp->fh_dentry) { |
537 | printk(KERN_ERR "fh_compose: fh %s/%s not initialized!\n", | 535 | printk(KERN_ERR "fh_compose: fh %pd2 not initialized!\n", |
538 | parent->d_name.name, dentry->d_name.name); | 536 | dentry); |
539 | } | 537 | } |
540 | if (fhp->fh_maxsize < NFS_FHSIZE) | 538 | if (fhp->fh_maxsize < NFS_FHSIZE) |
541 | printk(KERN_ERR "fh_compose: called with maxsize %d! %s/%s\n", | 539 | printk(KERN_ERR "fh_compose: called with maxsize %d! %pd2\n", |
542 | fhp->fh_maxsize, | 540 | fhp->fh_maxsize, |
543 | parent->d_name.name, dentry->d_name.name); | 541 | dentry); |
544 | 542 | ||
545 | fhp->fh_dentry = dget(dentry); /* our internal copy */ | 543 | fhp->fh_dentry = dget(dentry); /* our internal copy */ |
546 | fhp->fh_export = exp; | 544 | fhp->fh_export = exp; |
@@ -613,8 +611,8 @@ out_bad: | |||
613 | printk(KERN_ERR "fh_update: fh not verified!\n"); | 611 | printk(KERN_ERR "fh_update: fh not verified!\n"); |
614 | goto out; | 612 | goto out; |
615 | out_negative: | 613 | out_negative: |
616 | printk(KERN_ERR "fh_update: %s/%s still negative!\n", | 614 | printk(KERN_ERR "fh_update: %pd2 still negative!\n", |
617 | dentry->d_parent->d_name.name, dentry->d_name.name); | 615 | dentry); |
618 | goto out; | 616 | goto out; |
619 | } | 617 | } |
620 | 618 | ||
diff --git a/fs/nfsd/nfsfh.h b/fs/nfsd/nfsfh.h index e5e6707ba687..4775bc4896c8 100644 --- a/fs/nfsd/nfsfh.h +++ b/fs/nfsd/nfsfh.h | |||
@@ -173,8 +173,8 @@ fh_lock_nested(struct svc_fh *fhp, unsigned int subclass) | |||
173 | BUG_ON(!dentry); | 173 | BUG_ON(!dentry); |
174 | 174 | ||
175 | if (fhp->fh_locked) { | 175 | if (fhp->fh_locked) { |
176 | printk(KERN_WARNING "fh_lock: %s/%s already locked!\n", | 176 | printk(KERN_WARNING "fh_lock: %pd2 already locked!\n", |
177 | dentry->d_parent->d_name.name, dentry->d_name.name); | 177 | dentry); |
178 | return; | 178 | return; |
179 | } | 179 | } |
180 | 180 | ||
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index c827acb0e943..94b5f5d2bfed 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -427,7 +427,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap, | |||
427 | goto out_nfserr; | 427 | goto out_nfserr; |
428 | fh_lock(fhp); | 428 | fh_lock(fhp); |
429 | 429 | ||
430 | host_err = notify_change(dentry, iap); | 430 | host_err = notify_change(dentry, iap, NULL); |
431 | err = nfserrno(host_err); | 431 | err = nfserrno(host_err); |
432 | fh_unlock(fhp); | 432 | fh_unlock(fhp); |
433 | } | 433 | } |
@@ -988,7 +988,11 @@ static void kill_suid(struct dentry *dentry) | |||
988 | ia.ia_valid = ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; | 988 | ia.ia_valid = ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; |
989 | 989 | ||
990 | mutex_lock(&dentry->d_inode->i_mutex); | 990 | mutex_lock(&dentry->d_inode->i_mutex); |
991 | notify_change(dentry, &ia); | 991 | /* |
992 | * Note we call this on write, so notify_change will not | ||
993 | * encounter any conflicting delegations: | ||
994 | */ | ||
995 | notify_change(dentry, &ia, NULL); | ||
992 | mutex_unlock(&dentry->d_inode->i_mutex); | 996 | mutex_unlock(&dentry->d_inode->i_mutex); |
993 | } | 997 | } |
994 | 998 | ||
@@ -1317,9 +1321,8 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, | |||
1317 | if (!fhp->fh_locked) { | 1321 | if (!fhp->fh_locked) { |
1318 | /* not actually possible */ | 1322 | /* not actually possible */ |
1319 | printk(KERN_ERR | 1323 | printk(KERN_ERR |
1320 | "nfsd_create: parent %s/%s not locked!\n", | 1324 | "nfsd_create: parent %pd2 not locked!\n", |
1321 | dentry->d_parent->d_name.name, | 1325 | dentry); |
1322 | dentry->d_name.name); | ||
1323 | err = nfserr_io; | 1326 | err = nfserr_io; |
1324 | goto out; | 1327 | goto out; |
1325 | } | 1328 | } |
@@ -1329,8 +1332,8 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, | |||
1329 | */ | 1332 | */ |
1330 | err = nfserr_exist; | 1333 | err = nfserr_exist; |
1331 | if (dchild->d_inode) { | 1334 | if (dchild->d_inode) { |
1332 | dprintk("nfsd_create: dentry %s/%s not negative!\n", | 1335 | dprintk("nfsd_create: dentry %pd/%pd not negative!\n", |
1333 | dentry->d_name.name, dchild->d_name.name); | 1336 | dentry, dchild); |
1334 | goto out; | 1337 | goto out; |
1335 | } | 1338 | } |
1336 | 1339 | ||
@@ -1737,7 +1740,7 @@ nfsd_link(struct svc_rqst *rqstp, struct svc_fh *ffhp, | |||
1737 | err = nfserrno(host_err); | 1740 | err = nfserrno(host_err); |
1738 | goto out_dput; | 1741 | goto out_dput; |
1739 | } | 1742 | } |
1740 | host_err = vfs_link(dold, dirp, dnew); | 1743 | host_err = vfs_link(dold, dirp, dnew, NULL); |
1741 | if (!host_err) { | 1744 | if (!host_err) { |
1742 | err = nfserrno(commit_metadata(ffhp)); | 1745 | err = nfserrno(commit_metadata(ffhp)); |
1743 | if (!err) | 1746 | if (!err) |
@@ -1838,7 +1841,7 @@ nfsd_rename(struct svc_rqst *rqstp, struct svc_fh *ffhp, char *fname, int flen, | |||
1838 | if (host_err) | 1841 | if (host_err) |
1839 | goto out_dput_new; | 1842 | goto out_dput_new; |
1840 | } | 1843 | } |
1841 | host_err = vfs_rename(fdir, odentry, tdir, ndentry); | 1844 | host_err = vfs_rename(fdir, odentry, tdir, ndentry, NULL); |
1842 | if (!host_err) { | 1845 | if (!host_err) { |
1843 | host_err = commit_metadata(tfhp); | 1846 | host_err = commit_metadata(tfhp); |
1844 | if (!host_err) | 1847 | if (!host_err) |
@@ -1911,7 +1914,7 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, | |||
1911 | if (host_err) | 1914 | if (host_err) |
1912 | goto out_put; | 1915 | goto out_put; |
1913 | if (type != S_IFDIR) | 1916 | if (type != S_IFDIR) |
1914 | host_err = vfs_unlink(dirp, rdentry); | 1917 | host_err = vfs_unlink(dirp, rdentry, NULL); |
1915 | else | 1918 | else |
1916 | host_err = vfs_rmdir(dirp, rdentry); | 1919 | host_err = vfs_rmdir(dirp, rdentry); |
1917 | if (!host_err) | 1920 | if (!host_err) |
diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index 2778b0255dc6..ffb9b3675736 100644 --- a/fs/ntfs/inode.c +++ b/fs/ntfs/inode.c | |||
@@ -55,7 +55,7 @@ | |||
55 | * | 55 | * |
56 | * Return 1 if the attributes match and 0 if not. | 56 | * Return 1 if the attributes match and 0 if not. |
57 | * | 57 | * |
58 | * NOTE: This function runs with the inode->i_lock spin lock held so it is not | 58 | * NOTE: This function runs with the inode_hash_lock spin lock held so it is not |
59 | * allowed to sleep. | 59 | * allowed to sleep. |
60 | */ | 60 | */ |
61 | int ntfs_test_inode(struct inode *vi, ntfs_attr *na) | 61 | int ntfs_test_inode(struct inode *vi, ntfs_attr *na) |
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index f87f9bd1edff..f29a90fde619 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c | |||
@@ -386,19 +386,9 @@ static int ocfs2_read_locked_inode(struct inode *inode, | |||
386 | u32 generation = 0; | 386 | u32 generation = 0; |
387 | 387 | ||
388 | status = -EINVAL; | 388 | status = -EINVAL; |
389 | if (inode == NULL || inode->i_sb == NULL) { | ||
390 | mlog(ML_ERROR, "bad inode\n"); | ||
391 | return status; | ||
392 | } | ||
393 | sb = inode->i_sb; | 389 | sb = inode->i_sb; |
394 | osb = OCFS2_SB(sb); | 390 | osb = OCFS2_SB(sb); |
395 | 391 | ||
396 | if (!args) { | ||
397 | mlog(ML_ERROR, "bad inode args\n"); | ||
398 | make_bad_inode(inode); | ||
399 | return status; | ||
400 | } | ||
401 | |||
402 | /* | 392 | /* |
403 | * To improve performance of cold-cache inode stats, we take | 393 | * To improve performance of cold-cache inode stats, we take |
404 | * the cluster lock here if possible. | 394 | * the cluster lock here if possible. |
@@ -57,7 +57,8 @@ int do_truncate(struct dentry *dentry, loff_t length, unsigned int time_attrs, | |||
57 | newattrs.ia_valid |= ret | ATTR_FORCE; | 57 | newattrs.ia_valid |= ret | ATTR_FORCE; |
58 | 58 | ||
59 | mutex_lock(&dentry->d_inode->i_mutex); | 59 | mutex_lock(&dentry->d_inode->i_mutex); |
60 | ret = notify_change(dentry, &newattrs); | 60 | /* Note any delegations or leases have already been broken: */ |
61 | ret = notify_change(dentry, &newattrs, NULL); | ||
61 | mutex_unlock(&dentry->d_inode->i_mutex); | 62 | mutex_unlock(&dentry->d_inode->i_mutex); |
62 | return ret; | 63 | return ret; |
63 | } | 64 | } |
@@ -464,21 +465,28 @@ out: | |||
464 | static int chmod_common(struct path *path, umode_t mode) | 465 | static int chmod_common(struct path *path, umode_t mode) |
465 | { | 466 | { |
466 | struct inode *inode = path->dentry->d_inode; | 467 | struct inode *inode = path->dentry->d_inode; |
468 | struct inode *delegated_inode = NULL; | ||
467 | struct iattr newattrs; | 469 | struct iattr newattrs; |
468 | int error; | 470 | int error; |
469 | 471 | ||
470 | error = mnt_want_write(path->mnt); | 472 | error = mnt_want_write(path->mnt); |
471 | if (error) | 473 | if (error) |
472 | return error; | 474 | return error; |
475 | retry_deleg: | ||
473 | mutex_lock(&inode->i_mutex); | 476 | mutex_lock(&inode->i_mutex); |
474 | error = security_path_chmod(path, mode); | 477 | error = security_path_chmod(path, mode); |
475 | if (error) | 478 | if (error) |
476 | goto out_unlock; | 479 | goto out_unlock; |
477 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); | 480 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); |
478 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; | 481 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; |
479 | error = notify_change(path->dentry, &newattrs); | 482 | error = notify_change(path->dentry, &newattrs, &delegated_inode); |
480 | out_unlock: | 483 | out_unlock: |
481 | mutex_unlock(&inode->i_mutex); | 484 | mutex_unlock(&inode->i_mutex); |
485 | if (delegated_inode) { | ||
486 | error = break_deleg_wait(&delegated_inode); | ||
487 | if (!error) | ||
488 | goto retry_deleg; | ||
489 | } | ||
482 | mnt_drop_write(path->mnt); | 490 | mnt_drop_write(path->mnt); |
483 | return error; | 491 | return error; |
484 | } | 492 | } |
@@ -522,6 +530,7 @@ SYSCALL_DEFINE2(chmod, const char __user *, filename, umode_t, mode) | |||
522 | static int chown_common(struct path *path, uid_t user, gid_t group) | 530 | static int chown_common(struct path *path, uid_t user, gid_t group) |
523 | { | 531 | { |
524 | struct inode *inode = path->dentry->d_inode; | 532 | struct inode *inode = path->dentry->d_inode; |
533 | struct inode *delegated_inode = NULL; | ||
525 | int error; | 534 | int error; |
526 | struct iattr newattrs; | 535 | struct iattr newattrs; |
527 | kuid_t uid; | 536 | kuid_t uid; |
@@ -546,12 +555,17 @@ static int chown_common(struct path *path, uid_t user, gid_t group) | |||
546 | if (!S_ISDIR(inode->i_mode)) | 555 | if (!S_ISDIR(inode->i_mode)) |
547 | newattrs.ia_valid |= | 556 | newattrs.ia_valid |= |
548 | ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; | 557 | ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; |
558 | retry_deleg: | ||
549 | mutex_lock(&inode->i_mutex); | 559 | mutex_lock(&inode->i_mutex); |
550 | error = security_path_chown(path, uid, gid); | 560 | error = security_path_chown(path, uid, gid); |
551 | if (!error) | 561 | if (!error) |
552 | error = notify_change(path->dentry, &newattrs); | 562 | error = notify_change(path->dentry, &newattrs, &delegated_inode); |
553 | mutex_unlock(&inode->i_mutex); | 563 | mutex_unlock(&inode->i_mutex); |
554 | 564 | if (delegated_inode) { | |
565 | error = break_deleg_wait(&delegated_inode); | ||
566 | if (!error) | ||
567 | goto retry_deleg; | ||
568 | } | ||
555 | return error; | 569 | return error; |
556 | } | 570 | } |
557 | 571 | ||
@@ -685,7 +699,6 @@ static int do_dentry_open(struct file *f, | |||
685 | } | 699 | } |
686 | 700 | ||
687 | f->f_mapping = inode->i_mapping; | 701 | f->f_mapping = inode->i_mapping; |
688 | file_sb_list_add(f, inode->i_sb); | ||
689 | 702 | ||
690 | if (unlikely(f->f_mode & FMODE_PATH)) { | 703 | if (unlikely(f->f_mode & FMODE_PATH)) { |
691 | f->f_op = &empty_fops; | 704 | f->f_op = &empty_fops; |
@@ -693,6 +706,10 @@ static int do_dentry_open(struct file *f, | |||
693 | } | 706 | } |
694 | 707 | ||
695 | f->f_op = fops_get(inode->i_fop); | 708 | f->f_op = fops_get(inode->i_fop); |
709 | if (unlikely(WARN_ON(!f->f_op))) { | ||
710 | error = -ENODEV; | ||
711 | goto cleanup_all; | ||
712 | } | ||
696 | 713 | ||
697 | error = security_file_open(f, cred); | 714 | error = security_file_open(f, cred); |
698 | if (error) | 715 | if (error) |
@@ -702,7 +719,7 @@ static int do_dentry_open(struct file *f, | |||
702 | if (error) | 719 | if (error) |
703 | goto cleanup_all; | 720 | goto cleanup_all; |
704 | 721 | ||
705 | if (!open && f->f_op) | 722 | if (!open) |
706 | open = f->f_op->open; | 723 | open = f->f_op->open; |
707 | if (open) { | 724 | if (open) { |
708 | error = open(inode, f); | 725 | error = open(inode, f); |
@@ -720,7 +737,6 @@ static int do_dentry_open(struct file *f, | |||
720 | 737 | ||
721 | cleanup_all: | 738 | cleanup_all: |
722 | fops_put(f->f_op); | 739 | fops_put(f->f_op); |
723 | file_sb_list_del(f); | ||
724 | if (f->f_mode & FMODE_WRITE) { | 740 | if (f->f_mode & FMODE_WRITE) { |
725 | put_write_access(inode); | 741 | put_write_access(inode); |
726 | if (!special_file(inode->i_mode)) { | 742 | if (!special_file(inode->i_mode)) { |
@@ -1023,7 +1039,7 @@ int filp_close(struct file *filp, fl_owner_t id) | |||
1023 | return 0; | 1039 | return 0; |
1024 | } | 1040 | } |
1025 | 1041 | ||
1026 | if (filp->f_op && filp->f_op->flush) | 1042 | if (filp->f_op->flush) |
1027 | retval = filp->f_op->flush(filp, id); | 1043 | retval = filp->f_op->flush(filp, id); |
1028 | 1044 | ||
1029 | if (likely(!(filp->f_mode & FMODE_PATH))) { | 1045 | if (likely(!(filp->f_mode & FMODE_PATH))) { |
diff --git a/fs/pnode.c b/fs/pnode.c index 9af0df15256e..c7221bb19801 100644 --- a/fs/pnode.c +++ b/fs/pnode.c | |||
@@ -264,12 +264,12 @@ int propagate_mnt(struct mount *dest_mnt, struct mountpoint *dest_mp, | |||
264 | prev_src_mnt = child; | 264 | prev_src_mnt = child; |
265 | } | 265 | } |
266 | out: | 266 | out: |
267 | br_write_lock(&vfsmount_lock); | 267 | lock_mount_hash(); |
268 | while (!list_empty(&tmp_list)) { | 268 | while (!list_empty(&tmp_list)) { |
269 | child = list_first_entry(&tmp_list, struct mount, mnt_hash); | 269 | child = list_first_entry(&tmp_list, struct mount, mnt_hash); |
270 | umount_tree(child, 0); | 270 | umount_tree(child, 0); |
271 | } | 271 | } |
272 | br_write_unlock(&vfsmount_lock); | 272 | unlock_mount_hash(); |
273 | return ret; | 273 | return ret; |
274 | } | 274 | } |
275 | 275 | ||
@@ -278,8 +278,7 @@ out: | |||
278 | */ | 278 | */ |
279 | static inline int do_refcount_check(struct mount *mnt, int count) | 279 | static inline int do_refcount_check(struct mount *mnt, int count) |
280 | { | 280 | { |
281 | int mycount = mnt_get_count(mnt) - mnt->mnt_ghosts; | 281 | return mnt_get_count(mnt) > count; |
282 | return (mycount > count); | ||
283 | } | 282 | } |
284 | 283 | ||
285 | /* | 284 | /* |
@@ -311,7 +310,7 @@ int propagate_mount_busy(struct mount *mnt, int refcnt) | |||
311 | 310 | ||
312 | for (m = propagation_next(parent, parent); m; | 311 | for (m = propagation_next(parent, parent); m; |
313 | m = propagation_next(m, parent)) { | 312 | m = propagation_next(m, parent)) { |
314 | child = __lookup_mnt(&m->mnt, mnt->mnt_mountpoint, 0); | 313 | child = __lookup_mnt_last(&m->mnt, mnt->mnt_mountpoint); |
315 | if (child && list_empty(&child->mnt_mounts) && | 314 | if (child && list_empty(&child->mnt_mounts) && |
316 | (ret = do_refcount_check(child, 1))) | 315 | (ret = do_refcount_check(child, 1))) |
317 | break; | 316 | break; |
@@ -333,8 +332,8 @@ static void __propagate_umount(struct mount *mnt) | |||
333 | for (m = propagation_next(parent, parent); m; | 332 | for (m = propagation_next(parent, parent); m; |
334 | m = propagation_next(m, parent)) { | 333 | m = propagation_next(m, parent)) { |
335 | 334 | ||
336 | struct mount *child = __lookup_mnt(&m->mnt, | 335 | struct mount *child = __lookup_mnt_last(&m->mnt, |
337 | mnt->mnt_mountpoint, 0); | 336 | mnt->mnt_mountpoint); |
338 | /* | 337 | /* |
339 | * umount the child only if the child has no | 338 | * umount the child only if the child has no |
340 | * other children | 339 | * other children |
diff --git a/fs/proc/self.c b/fs/proc/self.c index 6b6a993b5c25..ffeb202ec942 100644 --- a/fs/proc/self.c +++ b/fs/proc/self.c | |||
@@ -36,18 +36,10 @@ static void *proc_self_follow_link(struct dentry *dentry, struct nameidata *nd) | |||
36 | return NULL; | 36 | return NULL; |
37 | } | 37 | } |
38 | 38 | ||
39 | static void proc_self_put_link(struct dentry *dentry, struct nameidata *nd, | ||
40 | void *cookie) | ||
41 | { | ||
42 | char *s = nd_get_link(nd); | ||
43 | if (!IS_ERR(s)) | ||
44 | kfree(s); | ||
45 | } | ||
46 | |||
47 | static const struct inode_operations proc_self_inode_operations = { | 39 | static const struct inode_operations proc_self_inode_operations = { |
48 | .readlink = proc_self_readlink, | 40 | .readlink = proc_self_readlink, |
49 | .follow_link = proc_self_follow_link, | 41 | .follow_link = proc_self_follow_link, |
50 | .put_link = proc_self_put_link, | 42 | .put_link = kfree_put_link, |
51 | }; | 43 | }; |
52 | 44 | ||
53 | static unsigned self_inum; | 45 | static unsigned self_inum; |
diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c index 5fe34c355e85..439406e081af 100644 --- a/fs/proc_namespace.c +++ b/fs/proc_namespace.c | |||
@@ -20,15 +20,15 @@ static unsigned mounts_poll(struct file *file, poll_table *wait) | |||
20 | struct proc_mounts *p = proc_mounts(file->private_data); | 20 | struct proc_mounts *p = proc_mounts(file->private_data); |
21 | struct mnt_namespace *ns = p->ns; | 21 | struct mnt_namespace *ns = p->ns; |
22 | unsigned res = POLLIN | POLLRDNORM; | 22 | unsigned res = POLLIN | POLLRDNORM; |
23 | int event; | ||
23 | 24 | ||
24 | poll_wait(file, &p->ns->poll, wait); | 25 | poll_wait(file, &p->ns->poll, wait); |
25 | 26 | ||
26 | br_read_lock(&vfsmount_lock); | 27 | event = ACCESS_ONCE(ns->event); |
27 | if (p->m.poll_event != ns->event) { | 28 | if (p->m.poll_event != event) { |
28 | p->m.poll_event = ns->event; | 29 | p->m.poll_event = event; |
29 | res |= POLLERR | POLLPRI; | 30 | res |= POLLERR | POLLPRI; |
30 | } | 31 | } |
31 | br_read_unlock(&vfsmount_lock); | ||
32 | 32 | ||
33 | return res; | 33 | return res; |
34 | } | 34 | } |
diff --git a/fs/qnx4/namei.c b/fs/qnx4/namei.c index d024505ba007..e62c8183777a 100644 --- a/fs/qnx4/namei.c +++ b/fs/qnx4/namei.c | |||
@@ -60,10 +60,6 @@ static struct buffer_head *qnx4_find_entry(int len, struct inode *dir, | |||
60 | struct buffer_head *bh; | 60 | struct buffer_head *bh; |
61 | 61 | ||
62 | *res_dir = NULL; | 62 | *res_dir = NULL; |
63 | if (!dir->i_sb) { | ||
64 | printk(KERN_WARNING "qnx4: no superblock on dir.\n"); | ||
65 | return NULL; | ||
66 | } | ||
67 | bh = NULL; | 63 | bh = NULL; |
68 | block = offset = blkofs = 0; | 64 | block = offset = blkofs = 0; |
69 | while (blkofs * QNX4_BLOCK_SIZE + offset < dir->i_size) { | 65 | while (blkofs * QNX4_BLOCK_SIZE + offset < dir->i_size) { |
diff --git a/fs/read_write.c b/fs/read_write.c index e3cd280b158c..58e440df1bc6 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
@@ -257,7 +257,7 @@ loff_t vfs_llseek(struct file *file, loff_t offset, int whence) | |||
257 | 257 | ||
258 | fn = no_llseek; | 258 | fn = no_llseek; |
259 | if (file->f_mode & FMODE_LSEEK) { | 259 | if (file->f_mode & FMODE_LSEEK) { |
260 | if (file->f_op && file->f_op->llseek) | 260 | if (file->f_op->llseek) |
261 | fn = file->f_op->llseek; | 261 | fn = file->f_op->llseek; |
262 | } | 262 | } |
263 | return fn(file, offset, whence); | 263 | return fn(file, offset, whence); |
@@ -384,7 +384,7 @@ ssize_t vfs_read(struct file *file, char __user *buf, size_t count, loff_t *pos) | |||
384 | 384 | ||
385 | if (!(file->f_mode & FMODE_READ)) | 385 | if (!(file->f_mode & FMODE_READ)) |
386 | return -EBADF; | 386 | return -EBADF; |
387 | if (!file->f_op || (!file->f_op->read && !file->f_op->aio_read)) | 387 | if (!file->f_op->read && !file->f_op->aio_read) |
388 | return -EINVAL; | 388 | return -EINVAL; |
389 | if (unlikely(!access_ok(VERIFY_WRITE, buf, count))) | 389 | if (unlikely(!access_ok(VERIFY_WRITE, buf, count))) |
390 | return -EFAULT; | 390 | return -EFAULT; |
@@ -433,7 +433,7 @@ ssize_t __kernel_write(struct file *file, const char *buf, size_t count, loff_t | |||
433 | const char __user *p; | 433 | const char __user *p; |
434 | ssize_t ret; | 434 | ssize_t ret; |
435 | 435 | ||
436 | if (!file->f_op || (!file->f_op->write && !file->f_op->aio_write)) | 436 | if (!file->f_op->write && !file->f_op->aio_write) |
437 | return -EINVAL; | 437 | return -EINVAL; |
438 | 438 | ||
439 | old_fs = get_fs(); | 439 | old_fs = get_fs(); |
@@ -460,7 +460,7 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_ | |||
460 | 460 | ||
461 | if (!(file->f_mode & FMODE_WRITE)) | 461 | if (!(file->f_mode & FMODE_WRITE)) |
462 | return -EBADF; | 462 | return -EBADF; |
463 | if (!file->f_op || (!file->f_op->write && !file->f_op->aio_write)) | 463 | if (!file->f_op->write && !file->f_op->aio_write) |
464 | return -EINVAL; | 464 | return -EINVAL; |
465 | if (unlikely(!access_ok(VERIFY_READ, buf, count))) | 465 | if (unlikely(!access_ok(VERIFY_READ, buf, count))) |
466 | return -EFAULT; | 466 | return -EFAULT; |
@@ -727,11 +727,6 @@ static ssize_t do_readv_writev(int type, struct file *file, | |||
727 | io_fn_t fn; | 727 | io_fn_t fn; |
728 | iov_fn_t fnv; | 728 | iov_fn_t fnv; |
729 | 729 | ||
730 | if (!file->f_op) { | ||
731 | ret = -EINVAL; | ||
732 | goto out; | ||
733 | } | ||
734 | |||
735 | ret = rw_copy_check_uvector(type, uvector, nr_segs, | 730 | ret = rw_copy_check_uvector(type, uvector, nr_segs, |
736 | ARRAY_SIZE(iovstack), iovstack, &iov); | 731 | ARRAY_SIZE(iovstack), iovstack, &iov); |
737 | if (ret <= 0) | 732 | if (ret <= 0) |
@@ -778,7 +773,7 @@ ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, | |||
778 | { | 773 | { |
779 | if (!(file->f_mode & FMODE_READ)) | 774 | if (!(file->f_mode & FMODE_READ)) |
780 | return -EBADF; | 775 | return -EBADF; |
781 | if (!file->f_op || (!file->f_op->aio_read && !file->f_op->read)) | 776 | if (!file->f_op->aio_read && !file->f_op->read) |
782 | return -EINVAL; | 777 | return -EINVAL; |
783 | 778 | ||
784 | return do_readv_writev(READ, file, vec, vlen, pos); | 779 | return do_readv_writev(READ, file, vec, vlen, pos); |
@@ -791,7 +786,7 @@ ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, | |||
791 | { | 786 | { |
792 | if (!(file->f_mode & FMODE_WRITE)) | 787 | if (!(file->f_mode & FMODE_WRITE)) |
793 | return -EBADF; | 788 | return -EBADF; |
794 | if (!file->f_op || (!file->f_op->aio_write && !file->f_op->write)) | 789 | if (!file->f_op->aio_write && !file->f_op->write) |
795 | return -EINVAL; | 790 | return -EINVAL; |
796 | 791 | ||
797 | return do_readv_writev(WRITE, file, vec, vlen, pos); | 792 | return do_readv_writev(WRITE, file, vec, vlen, pos); |
@@ -906,10 +901,6 @@ static ssize_t compat_do_readv_writev(int type, struct file *file, | |||
906 | io_fn_t fn; | 901 | io_fn_t fn; |
907 | iov_fn_t fnv; | 902 | iov_fn_t fnv; |
908 | 903 | ||
909 | ret = -EINVAL; | ||
910 | if (!file->f_op) | ||
911 | goto out; | ||
912 | |||
913 | ret = -EFAULT; | 904 | ret = -EFAULT; |
914 | if (!access_ok(VERIFY_READ, uvector, nr_segs*sizeof(*uvector))) | 905 | if (!access_ok(VERIFY_READ, uvector, nr_segs*sizeof(*uvector))) |
915 | goto out; | 906 | goto out; |
@@ -965,7 +956,7 @@ static size_t compat_readv(struct file *file, | |||
965 | goto out; | 956 | goto out; |
966 | 957 | ||
967 | ret = -EINVAL; | 958 | ret = -EINVAL; |
968 | if (!file->f_op || (!file->f_op->aio_read && !file->f_op->read)) | 959 | if (!file->f_op->aio_read && !file->f_op->read) |
969 | goto out; | 960 | goto out; |
970 | 961 | ||
971 | ret = compat_do_readv_writev(READ, file, vec, vlen, pos); | 962 | ret = compat_do_readv_writev(READ, file, vec, vlen, pos); |
@@ -1032,7 +1023,7 @@ static size_t compat_writev(struct file *file, | |||
1032 | goto out; | 1023 | goto out; |
1033 | 1024 | ||
1034 | ret = -EINVAL; | 1025 | ret = -EINVAL; |
1035 | if (!file->f_op || (!file->f_op->aio_write && !file->f_op->write)) | 1026 | if (!file->f_op->aio_write && !file->f_op->write) |
1036 | goto out; | 1027 | goto out; |
1037 | 1028 | ||
1038 | ret = compat_do_readv_writev(WRITE, file, vec, vlen, pos); | 1029 | ret = compat_do_readv_writev(WRITE, file, vec, vlen, pos); |
diff --git a/fs/readdir.c b/fs/readdir.c index 93d71e574310..5b53d995cae6 100644 --- a/fs/readdir.c +++ b/fs/readdir.c | |||
@@ -24,7 +24,7 @@ int iterate_dir(struct file *file, struct dir_context *ctx) | |||
24 | { | 24 | { |
25 | struct inode *inode = file_inode(file); | 25 | struct inode *inode = file_inode(file); |
26 | int res = -ENOTDIR; | 26 | int res = -ENOTDIR; |
27 | if (!file->f_op || !file->f_op->iterate) | 27 | if (!file->f_op->iterate) |
28 | goto out; | 28 | goto out; |
29 | 29 | ||
30 | res = security_file_permission(file, MAY_READ); | 30 | res = security_file_permission(file, MAY_READ); |
diff --git a/fs/select.c b/fs/select.c index dfd5cb18c012..467bb1cb3ea5 100644 --- a/fs/select.c +++ b/fs/select.c | |||
@@ -454,7 +454,7 @@ int do_select(int n, fd_set_bits *fds, struct timespec *end_time) | |||
454 | const struct file_operations *f_op; | 454 | const struct file_operations *f_op; |
455 | f_op = f.file->f_op; | 455 | f_op = f.file->f_op; |
456 | mask = DEFAULT_POLLMASK; | 456 | mask = DEFAULT_POLLMASK; |
457 | if (f_op && f_op->poll) { | 457 | if (f_op->poll) { |
458 | wait_key_set(wait, in, out, | 458 | wait_key_set(wait, in, out, |
459 | bit, busy_flag); | 459 | bit, busy_flag); |
460 | mask = (*f_op->poll)(f.file, wait); | 460 | mask = (*f_op->poll)(f.file, wait); |
@@ -761,7 +761,7 @@ static inline unsigned int do_pollfd(struct pollfd *pollfd, poll_table *pwait, | |||
761 | mask = POLLNVAL; | 761 | mask = POLLNVAL; |
762 | if (f.file) { | 762 | if (f.file) { |
763 | mask = DEFAULT_POLLMASK; | 763 | mask = DEFAULT_POLLMASK; |
764 | if (f.file->f_op && f.file->f_op->poll) { | 764 | if (f.file->f_op->poll) { |
765 | pwait->_key = pollfd->events|POLLERR|POLLHUP; | 765 | pwait->_key = pollfd->events|POLLERR|POLLHUP; |
766 | pwait->_key |= busy_flag; | 766 | pwait->_key |= busy_flag; |
767 | mask = f.file->f_op->poll(f.file, pwait); | 767 | mask = f.file->f_op->poll(f.file, pwait); |
diff --git a/fs/splice.c b/fs/splice.c index 3b7ee656f3aa..46a08f772d7d 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
@@ -695,7 +695,7 @@ static int pipe_to_sendpage(struct pipe_inode_info *pipe, | |||
695 | loff_t pos = sd->pos; | 695 | loff_t pos = sd->pos; |
696 | int more; | 696 | int more; |
697 | 697 | ||
698 | if (!likely(file->f_op && file->f_op->sendpage)) | 698 | if (!likely(file->f_op->sendpage)) |
699 | return -EINVAL; | 699 | return -EINVAL; |
700 | 700 | ||
701 | more = (sd->flags & SPLICE_F_MORE) ? MSG_MORE : 0; | 701 | more = (sd->flags & SPLICE_F_MORE) ? MSG_MORE : 0; |
@@ -1099,7 +1099,7 @@ static long do_splice_from(struct pipe_inode_info *pipe, struct file *out, | |||
1099 | ssize_t (*splice_write)(struct pipe_inode_info *, struct file *, | 1099 | ssize_t (*splice_write)(struct pipe_inode_info *, struct file *, |
1100 | loff_t *, size_t, unsigned int); | 1100 | loff_t *, size_t, unsigned int); |
1101 | 1101 | ||
1102 | if (out->f_op && out->f_op->splice_write) | 1102 | if (out->f_op->splice_write) |
1103 | splice_write = out->f_op->splice_write; | 1103 | splice_write = out->f_op->splice_write; |
1104 | else | 1104 | else |
1105 | splice_write = default_file_splice_write; | 1105 | splice_write = default_file_splice_write; |
@@ -1125,7 +1125,7 @@ static long do_splice_to(struct file *in, loff_t *ppos, | |||
1125 | if (unlikely(ret < 0)) | 1125 | if (unlikely(ret < 0)) |
1126 | return ret; | 1126 | return ret; |
1127 | 1127 | ||
1128 | if (in->f_op && in->f_op->splice_read) | 1128 | if (in->f_op->splice_read) |
1129 | splice_read = in->f_op->splice_read; | 1129 | splice_read = in->f_op->splice_read; |
1130 | else | 1130 | else |
1131 | splice_read = default_file_splice_read; | 1131 | splice_read = default_file_splice_read; |
@@ -37,14 +37,21 @@ void generic_fillattr(struct inode *inode, struct kstat *stat) | |||
37 | 37 | ||
38 | EXPORT_SYMBOL(generic_fillattr); | 38 | EXPORT_SYMBOL(generic_fillattr); |
39 | 39 | ||
40 | int vfs_getattr(struct path *path, struct kstat *stat) | 40 | /** |
41 | * vfs_getattr_nosec - getattr without security checks | ||
42 | * @path: file to get attributes from | ||
43 | * @stat: structure to return attributes in | ||
44 | * | ||
45 | * Get attributes without calling security_inode_getattr. | ||
46 | * | ||
47 | * Currently the only caller other than vfs_getattr is internal to the | ||
48 | * filehandle lookup code, which uses only the inode number and returns | ||
49 | * no attributes to any user. Any other code probably wants | ||
50 | * vfs_getattr. | ||
51 | */ | ||
52 | int vfs_getattr_nosec(struct path *path, struct kstat *stat) | ||
41 | { | 53 | { |
42 | struct inode *inode = path->dentry->d_inode; | 54 | struct inode *inode = path->dentry->d_inode; |
43 | int retval; | ||
44 | |||
45 | retval = security_inode_getattr(path->mnt, path->dentry); | ||
46 | if (retval) | ||
47 | return retval; | ||
48 | 55 | ||
49 | if (inode->i_op->getattr) | 56 | if (inode->i_op->getattr) |
50 | return inode->i_op->getattr(path->mnt, path->dentry, stat); | 57 | return inode->i_op->getattr(path->mnt, path->dentry, stat); |
@@ -53,6 +60,18 @@ int vfs_getattr(struct path *path, struct kstat *stat) | |||
53 | return 0; | 60 | return 0; |
54 | } | 61 | } |
55 | 62 | ||
63 | EXPORT_SYMBOL(vfs_getattr_nosec); | ||
64 | |||
65 | int vfs_getattr(struct path *path, struct kstat *stat) | ||
66 | { | ||
67 | int retval; | ||
68 | |||
69 | retval = security_inode_getattr(path->mnt, path->dentry); | ||
70 | if (retval) | ||
71 | return retval; | ||
72 | return vfs_getattr_nosec(path, stat); | ||
73 | } | ||
74 | |||
56 | EXPORT_SYMBOL(vfs_getattr); | 75 | EXPORT_SYMBOL(vfs_getattr); |
57 | 76 | ||
58 | int vfs_fstat(unsigned int fd, struct kstat *stat) | 77 | int vfs_fstat(unsigned int fd, struct kstat *stat) |
diff --git a/fs/super.c b/fs/super.c index 0225c20f8770..e5f6c2cfac38 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -129,33 +129,24 @@ static unsigned long super_cache_count(struct shrinker *shrink, | |||
129 | return total_objects; | 129 | return total_objects; |
130 | } | 130 | } |
131 | 131 | ||
132 | static int init_sb_writers(struct super_block *s, struct file_system_type *type) | 132 | /** |
133 | { | 133 | * destroy_super - frees a superblock |
134 | int err; | 134 | * @s: superblock to free |
135 | int i; | 135 | * |
136 | 136 | * Frees a superblock. | |
137 | for (i = 0; i < SB_FREEZE_LEVELS; i++) { | 137 | */ |
138 | err = percpu_counter_init(&s->s_writers.counter[i], 0); | 138 | static void destroy_super(struct super_block *s) |
139 | if (err < 0) | ||
140 | goto err_out; | ||
141 | lockdep_init_map(&s->s_writers.lock_map[i], sb_writers_name[i], | ||
142 | &type->s_writers_key[i], 0); | ||
143 | } | ||
144 | init_waitqueue_head(&s->s_writers.wait); | ||
145 | init_waitqueue_head(&s->s_writers.wait_unfrozen); | ||
146 | return 0; | ||
147 | err_out: | ||
148 | while (--i >= 0) | ||
149 | percpu_counter_destroy(&s->s_writers.counter[i]); | ||
150 | return err; | ||
151 | } | ||
152 | |||
153 | static void destroy_sb_writers(struct super_block *s) | ||
154 | { | 139 | { |
155 | int i; | 140 | int i; |
156 | 141 | list_lru_destroy(&s->s_dentry_lru); | |
142 | list_lru_destroy(&s->s_inode_lru); | ||
157 | for (i = 0; i < SB_FREEZE_LEVELS; i++) | 143 | for (i = 0; i < SB_FREEZE_LEVELS; i++) |
158 | percpu_counter_destroy(&s->s_writers.counter[i]); | 144 | percpu_counter_destroy(&s->s_writers.counter[i]); |
145 | security_sb_free(s); | ||
146 | WARN_ON(!list_empty(&s->s_mounts)); | ||
147 | kfree(s->s_subtype); | ||
148 | kfree(s->s_options); | ||
149 | kfree_rcu(s, rcu); | ||
159 | } | 150 | } |
160 | 151 | ||
161 | /** | 152 | /** |
@@ -170,111 +161,74 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags) | |||
170 | { | 161 | { |
171 | struct super_block *s = kzalloc(sizeof(struct super_block), GFP_USER); | 162 | struct super_block *s = kzalloc(sizeof(struct super_block), GFP_USER); |
172 | static const struct super_operations default_op; | 163 | static const struct super_operations default_op; |
164 | int i; | ||
173 | 165 | ||
174 | if (s) { | 166 | if (!s) |
175 | if (security_sb_alloc(s)) | 167 | return NULL; |
176 | goto out_free_sb; | ||
177 | 168 | ||
178 | #ifdef CONFIG_SMP | 169 | if (security_sb_alloc(s)) |
179 | s->s_files = alloc_percpu(struct list_head); | 170 | goto fail; |
180 | if (!s->s_files) | ||
181 | goto err_out; | ||
182 | else { | ||
183 | int i; | ||
184 | 171 | ||
185 | for_each_possible_cpu(i) | 172 | for (i = 0; i < SB_FREEZE_LEVELS; i++) { |
186 | INIT_LIST_HEAD(per_cpu_ptr(s->s_files, i)); | 173 | if (percpu_counter_init(&s->s_writers.counter[i], 0) < 0) |
187 | } | 174 | goto fail; |
188 | #else | 175 | lockdep_init_map(&s->s_writers.lock_map[i], sb_writers_name[i], |
189 | INIT_LIST_HEAD(&s->s_files); | 176 | &type->s_writers_key[i], 0); |
190 | #endif | ||
191 | if (init_sb_writers(s, type)) | ||
192 | goto err_out; | ||
193 | s->s_flags = flags; | ||
194 | s->s_bdi = &default_backing_dev_info; | ||
195 | INIT_HLIST_NODE(&s->s_instances); | ||
196 | INIT_HLIST_BL_HEAD(&s->s_anon); | ||
197 | INIT_LIST_HEAD(&s->s_inodes); | ||
198 | |||
199 | if (list_lru_init(&s->s_dentry_lru)) | ||
200 | goto err_out; | ||
201 | if (list_lru_init(&s->s_inode_lru)) | ||
202 | goto err_out_dentry_lru; | ||
203 | |||
204 | INIT_LIST_HEAD(&s->s_mounts); | ||
205 | init_rwsem(&s->s_umount); | ||
206 | lockdep_set_class(&s->s_umount, &type->s_umount_key); | ||
207 | /* | ||
208 | * sget() can have s_umount recursion. | ||
209 | * | ||
210 | * When it cannot find a suitable sb, it allocates a new | ||
211 | * one (this one), and tries again to find a suitable old | ||
212 | * one. | ||
213 | * | ||
214 | * In case that succeeds, it will acquire the s_umount | ||
215 | * lock of the old one. Since these are clearly distrinct | ||
216 | * locks, and this object isn't exposed yet, there's no | ||
217 | * risk of deadlocks. | ||
218 | * | ||
219 | * Annotate this by putting this lock in a different | ||
220 | * subclass. | ||
221 | */ | ||
222 | down_write_nested(&s->s_umount, SINGLE_DEPTH_NESTING); | ||
223 | s->s_count = 1; | ||
224 | atomic_set(&s->s_active, 1); | ||
225 | mutex_init(&s->s_vfs_rename_mutex); | ||
226 | lockdep_set_class(&s->s_vfs_rename_mutex, &type->s_vfs_rename_key); | ||
227 | mutex_init(&s->s_dquot.dqio_mutex); | ||
228 | mutex_init(&s->s_dquot.dqonoff_mutex); | ||
229 | init_rwsem(&s->s_dquot.dqptr_sem); | ||
230 | s->s_maxbytes = MAX_NON_LFS; | ||
231 | s->s_op = &default_op; | ||
232 | s->s_time_gran = 1000000000; | ||
233 | s->cleancache_poolid = -1; | ||
234 | |||
235 | s->s_shrink.seeks = DEFAULT_SEEKS; | ||
236 | s->s_shrink.scan_objects = super_cache_scan; | ||
237 | s->s_shrink.count_objects = super_cache_count; | ||
238 | s->s_shrink.batch = 1024; | ||
239 | s->s_shrink.flags = SHRINKER_NUMA_AWARE; | ||
240 | } | 177 | } |
241 | out: | 178 | init_waitqueue_head(&s->s_writers.wait); |
179 | init_waitqueue_head(&s->s_writers.wait_unfrozen); | ||
180 | s->s_flags = flags; | ||
181 | s->s_bdi = &default_backing_dev_info; | ||
182 | INIT_HLIST_NODE(&s->s_instances); | ||
183 | INIT_HLIST_BL_HEAD(&s->s_anon); | ||
184 | INIT_LIST_HEAD(&s->s_inodes); | ||
185 | |||
186 | if (list_lru_init(&s->s_dentry_lru)) | ||
187 | goto fail; | ||
188 | if (list_lru_init(&s->s_inode_lru)) | ||
189 | goto fail; | ||
190 | |||
191 | INIT_LIST_HEAD(&s->s_mounts); | ||
192 | init_rwsem(&s->s_umount); | ||
193 | lockdep_set_class(&s->s_umount, &type->s_umount_key); | ||
194 | /* | ||
195 | * sget() can have s_umount recursion. | ||
196 | * | ||
197 | * When it cannot find a suitable sb, it allocates a new | ||
198 | * one (this one), and tries again to find a suitable old | ||
199 | * one. | ||
200 | * | ||
201 | * In case that succeeds, it will acquire the s_umount | ||
202 | * lock of the old one. Since these are clearly distrinct | ||
203 | * locks, and this object isn't exposed yet, there's no | ||
204 | * risk of deadlocks. | ||
205 | * | ||
206 | * Annotate this by putting this lock in a different | ||
207 | * subclass. | ||
208 | */ | ||
209 | down_write_nested(&s->s_umount, SINGLE_DEPTH_NESTING); | ||
210 | s->s_count = 1; | ||
211 | atomic_set(&s->s_active, 1); | ||
212 | mutex_init(&s->s_vfs_rename_mutex); | ||
213 | lockdep_set_class(&s->s_vfs_rename_mutex, &type->s_vfs_rename_key); | ||
214 | mutex_init(&s->s_dquot.dqio_mutex); | ||
215 | mutex_init(&s->s_dquot.dqonoff_mutex); | ||
216 | init_rwsem(&s->s_dquot.dqptr_sem); | ||
217 | s->s_maxbytes = MAX_NON_LFS; | ||
218 | s->s_op = &default_op; | ||
219 | s->s_time_gran = 1000000000; | ||
220 | s->cleancache_poolid = -1; | ||
221 | |||
222 | s->s_shrink.seeks = DEFAULT_SEEKS; | ||
223 | s->s_shrink.scan_objects = super_cache_scan; | ||
224 | s->s_shrink.count_objects = super_cache_count; | ||
225 | s->s_shrink.batch = 1024; | ||
226 | s->s_shrink.flags = SHRINKER_NUMA_AWARE; | ||
242 | return s; | 227 | return s; |
243 | 228 | ||
244 | err_out_dentry_lru: | 229 | fail: |
245 | list_lru_destroy(&s->s_dentry_lru); | 230 | destroy_super(s); |
246 | err_out: | 231 | return NULL; |
247 | security_sb_free(s); | ||
248 | #ifdef CONFIG_SMP | ||
249 | if (s->s_files) | ||
250 | free_percpu(s->s_files); | ||
251 | #endif | ||
252 | destroy_sb_writers(s); | ||
253 | out_free_sb: | ||
254 | kfree(s); | ||
255 | s = NULL; | ||
256 | goto out; | ||
257 | } | ||
258 | |||
259 | /** | ||
260 | * destroy_super - frees a superblock | ||
261 | * @s: superblock to free | ||
262 | * | ||
263 | * Frees a superblock. | ||
264 | */ | ||
265 | static inline void destroy_super(struct super_block *s) | ||
266 | { | ||
267 | list_lru_destroy(&s->s_dentry_lru); | ||
268 | list_lru_destroy(&s->s_inode_lru); | ||
269 | #ifdef CONFIG_SMP | ||
270 | free_percpu(s->s_files); | ||
271 | #endif | ||
272 | destroy_sb_writers(s); | ||
273 | security_sb_free(s); | ||
274 | WARN_ON(!list_empty(&s->s_mounts)); | ||
275 | kfree(s->s_subtype); | ||
276 | kfree(s->s_options); | ||
277 | kfree(s); | ||
278 | } | 232 | } |
279 | 233 | ||
280 | /* Superblock refcounting */ | 234 | /* Superblock refcounting */ |
@@ -756,7 +710,8 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
756 | make sure there are no rw files opened */ | 710 | make sure there are no rw files opened */ |
757 | if (remount_ro) { | 711 | if (remount_ro) { |
758 | if (force) { | 712 | if (force) { |
759 | mark_files_ro(sb); | 713 | sb->s_readonly_remount = 1; |
714 | smp_wmb(); | ||
760 | } else { | 715 | } else { |
761 | retval = sb_prepare_remount_readonly(sb); | 716 | retval = sb_prepare_remount_readonly(sb); |
762 | if (retval) | 717 | if (retval) |
@@ -177,7 +177,7 @@ SYSCALL_DEFINE1(syncfs, int, fd) | |||
177 | */ | 177 | */ |
178 | int vfs_fsync_range(struct file *file, loff_t start, loff_t end, int datasync) | 178 | int vfs_fsync_range(struct file *file, loff_t start, loff_t end, int datasync) |
179 | { | 179 | { |
180 | if (!file->f_op || !file->f_op->fsync) | 180 | if (!file->f_op->fsync) |
181 | return -EINVAL; | 181 | return -EINVAL; |
182 | return file->f_op->fsync(file, start, end, datasync); | 182 | return file->f_op->fsync(file, start, end, datasync); |
183 | } | 183 | } |
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 6b4947f75af7..ea41649e4ca5 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c | |||
@@ -192,8 +192,7 @@ static struct dentry *ubifs_lookup(struct inode *dir, struct dentry *dentry, | |||
192 | struct ubifs_dent_node *dent; | 192 | struct ubifs_dent_node *dent; |
193 | struct ubifs_info *c = dir->i_sb->s_fs_info; | 193 | struct ubifs_info *c = dir->i_sb->s_fs_info; |
194 | 194 | ||
195 | dbg_gen("'%.*s' in dir ino %lu", | 195 | dbg_gen("'%pd' in dir ino %lu", dentry, dir->i_ino); |
196 | dentry->d_name.len, dentry->d_name.name, dir->i_ino); | ||
197 | 196 | ||
198 | if (dentry->d_name.len > UBIFS_MAX_NLEN) | 197 | if (dentry->d_name.len > UBIFS_MAX_NLEN) |
199 | return ERR_PTR(-ENAMETOOLONG); | 198 | return ERR_PTR(-ENAMETOOLONG); |
@@ -225,8 +224,8 @@ static struct dentry *ubifs_lookup(struct inode *dir, struct dentry *dentry, | |||
225 | * checking. | 224 | * checking. |
226 | */ | 225 | */ |
227 | err = PTR_ERR(inode); | 226 | err = PTR_ERR(inode); |
228 | ubifs_err("dead directory entry '%.*s', error %d", | 227 | ubifs_err("dead directory entry '%pd', error %d", |
229 | dentry->d_name.len, dentry->d_name.name, err); | 228 | dentry, err); |
230 | ubifs_ro_mode(c, err); | 229 | ubifs_ro_mode(c, err); |
231 | goto out; | 230 | goto out; |
232 | } | 231 | } |
@@ -260,8 +259,8 @@ static int ubifs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
260 | * parent directory inode. | 259 | * parent directory inode. |
261 | */ | 260 | */ |
262 | 261 | ||
263 | dbg_gen("dent '%.*s', mode %#hx in dir ino %lu", | 262 | dbg_gen("dent '%pd', mode %#hx in dir ino %lu", |
264 | dentry->d_name.len, dentry->d_name.name, mode, dir->i_ino); | 263 | dentry, mode, dir->i_ino); |
265 | 264 | ||
266 | err = ubifs_budget_space(c, &req); | 265 | err = ubifs_budget_space(c, &req); |
267 | if (err) | 266 | if (err) |
@@ -509,8 +508,8 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir, | |||
509 | * changing the parent inode. | 508 | * changing the parent inode. |
510 | */ | 509 | */ |
511 | 510 | ||
512 | dbg_gen("dent '%.*s' to ino %lu (nlink %d) in dir ino %lu", | 511 | dbg_gen("dent '%pd' to ino %lu (nlink %d) in dir ino %lu", |
513 | dentry->d_name.len, dentry->d_name.name, inode->i_ino, | 512 | dentry, inode->i_ino, |
514 | inode->i_nlink, dir->i_ino); | 513 | inode->i_nlink, dir->i_ino); |
515 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); | 514 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); |
516 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); | 515 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); |
@@ -566,8 +565,8 @@ static int ubifs_unlink(struct inode *dir, struct dentry *dentry) | |||
566 | * deletions. | 565 | * deletions. |
567 | */ | 566 | */ |
568 | 567 | ||
569 | dbg_gen("dent '%.*s' from ino %lu (nlink %d) in dir ino %lu", | 568 | dbg_gen("dent '%pd' from ino %lu (nlink %d) in dir ino %lu", |
570 | dentry->d_name.len, dentry->d_name.name, inode->i_ino, | 569 | dentry, inode->i_ino, |
571 | inode->i_nlink, dir->i_ino); | 570 | inode->i_nlink, dir->i_ino); |
572 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); | 571 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); |
573 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); | 572 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); |
@@ -656,8 +655,8 @@ static int ubifs_rmdir(struct inode *dir, struct dentry *dentry) | |||
656 | * because we have extra space reserved for deletions. | 655 | * because we have extra space reserved for deletions. |
657 | */ | 656 | */ |
658 | 657 | ||
659 | dbg_gen("directory '%.*s', ino %lu in dir ino %lu", dentry->d_name.len, | 658 | dbg_gen("directory '%pd', ino %lu in dir ino %lu", dentry, |
660 | dentry->d_name.name, inode->i_ino, dir->i_ino); | 659 | inode->i_ino, dir->i_ino); |
661 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); | 660 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); |
662 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); | 661 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); |
663 | err = check_dir_empty(c, dentry->d_inode); | 662 | err = check_dir_empty(c, dentry->d_inode); |
@@ -716,8 +715,8 @@ static int ubifs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) | |||
716 | * directory inode. | 715 | * directory inode. |
717 | */ | 716 | */ |
718 | 717 | ||
719 | dbg_gen("dent '%.*s', mode %#hx in dir ino %lu", | 718 | dbg_gen("dent '%pd', mode %#hx in dir ino %lu", |
720 | dentry->d_name.len, dentry->d_name.name, mode, dir->i_ino); | 719 | dentry, mode, dir->i_ino); |
721 | 720 | ||
722 | err = ubifs_budget_space(c, &req); | 721 | err = ubifs_budget_space(c, &req); |
723 | if (err) | 722 | if (err) |
@@ -778,8 +777,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry, | |||
778 | * directory inode. | 777 | * directory inode. |
779 | */ | 778 | */ |
780 | 779 | ||
781 | dbg_gen("dent '%.*s' in dir ino %lu", | 780 | dbg_gen("dent '%pd' in dir ino %lu", dentry, dir->i_ino); |
782 | dentry->d_name.len, dentry->d_name.name, dir->i_ino); | ||
783 | 781 | ||
784 | if (!new_valid_dev(rdev)) | 782 | if (!new_valid_dev(rdev)) |
785 | return -EINVAL; | 783 | return -EINVAL; |
@@ -853,8 +851,8 @@ static int ubifs_symlink(struct inode *dir, struct dentry *dentry, | |||
853 | * directory inode. | 851 | * directory inode. |
854 | */ | 852 | */ |
855 | 853 | ||
856 | dbg_gen("dent '%.*s', target '%s' in dir ino %lu", dentry->d_name.len, | 854 | dbg_gen("dent '%pd', target '%s' in dir ino %lu", dentry, |
857 | dentry->d_name.name, symname, dir->i_ino); | 855 | symname, dir->i_ino); |
858 | 856 | ||
859 | if (len > UBIFS_MAX_INO_DATA) | 857 | if (len > UBIFS_MAX_INO_DATA) |
860 | return -ENAMETOOLONG; | 858 | return -ENAMETOOLONG; |
@@ -979,10 +977,9 @@ static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
979 | * separately. | 977 | * separately. |
980 | */ | 978 | */ |
981 | 979 | ||
982 | dbg_gen("dent '%.*s' ino %lu in dir ino %lu to dent '%.*s' in dir ino %lu", | 980 | dbg_gen("dent '%pd' ino %lu in dir ino %lu to dent '%pd' in dir ino %lu", |
983 | old_dentry->d_name.len, old_dentry->d_name.name, | 981 | old_dentry, old_inode->i_ino, old_dir->i_ino, |
984 | old_inode->i_ino, old_dir->i_ino, new_dentry->d_name.len, | 982 | new_dentry, new_dir->i_ino); |
985 | new_dentry->d_name.name, new_dir->i_ino); | ||
986 | ubifs_assert(mutex_is_locked(&old_dir->i_mutex)); | 983 | ubifs_assert(mutex_is_locked(&old_dir->i_mutex)); |
987 | ubifs_assert(mutex_is_locked(&new_dir->i_mutex)); | 984 | ubifs_assert(mutex_is_locked(&new_dir->i_mutex)); |
988 | if (unlink) | 985 | if (unlink) |
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c index afaad07f3b29..0e045e75abd8 100644 --- a/fs/ubifs/journal.c +++ b/fs/ubifs/journal.c | |||
@@ -933,10 +933,8 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir, | |||
933 | int move = (old_dir != new_dir); | 933 | int move = (old_dir != new_dir); |
934 | struct ubifs_inode *uninitialized_var(new_ui); | 934 | struct ubifs_inode *uninitialized_var(new_ui); |
935 | 935 | ||
936 | dbg_jnl("dent '%.*s' in dir ino %lu to dent '%.*s' in dir ino %lu", | 936 | dbg_jnl("dent '%pd' in dir ino %lu to dent '%pd' in dir ino %lu", |
937 | old_dentry->d_name.len, old_dentry->d_name.name, | 937 | old_dentry, old_dir->i_ino, new_dentry, new_dir->i_ino); |
938 | old_dir->i_ino, new_dentry->d_name.len, | ||
939 | new_dentry->d_name.name, new_dir->i_ino); | ||
940 | ubifs_assert(ubifs_inode(old_dir)->data_len == 0); | 938 | ubifs_assert(ubifs_inode(old_dir)->data_len == 0); |
941 | ubifs_assert(ubifs_inode(new_dir)->data_len == 0); | 939 | ubifs_assert(ubifs_inode(new_dir)->data_len == 0); |
942 | ubifs_assert(mutex_is_locked(&ubifs_inode(old_dir)->ui_mutex)); | 940 | ubifs_assert(mutex_is_locked(&ubifs_inode(old_dir)->ui_mutex)); |
diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c index 0f7139bdb2c2..5e0a63b1b0d5 100644 --- a/fs/ubifs/xattr.c +++ b/fs/ubifs/xattr.c | |||
@@ -303,8 +303,8 @@ int ubifs_setxattr(struct dentry *dentry, const char *name, | |||
303 | union ubifs_key key; | 303 | union ubifs_key key; |
304 | int err, type; | 304 | int err, type; |
305 | 305 | ||
306 | dbg_gen("xattr '%s', host ino %lu ('%.*s'), size %zd", name, | 306 | dbg_gen("xattr '%s', host ino %lu ('%pd'), size %zd", name, |
307 | host->i_ino, dentry->d_name.len, dentry->d_name.name, size); | 307 | host->i_ino, dentry, size); |
308 | ubifs_assert(mutex_is_locked(&host->i_mutex)); | 308 | ubifs_assert(mutex_is_locked(&host->i_mutex)); |
309 | 309 | ||
310 | if (size > UBIFS_MAX_INO_DATA) | 310 | if (size > UBIFS_MAX_INO_DATA) |
@@ -367,8 +367,8 @@ ssize_t ubifs_getxattr(struct dentry *dentry, const char *name, void *buf, | |||
367 | union ubifs_key key; | 367 | union ubifs_key key; |
368 | int err; | 368 | int err; |
369 | 369 | ||
370 | dbg_gen("xattr '%s', ino %lu ('%.*s'), buf size %zd", name, | 370 | dbg_gen("xattr '%s', ino %lu ('%pd'), buf size %zd", name, |
371 | host->i_ino, dentry->d_name.len, dentry->d_name.name, size); | 371 | host->i_ino, dentry, size); |
372 | 372 | ||
373 | err = check_namespace(&nm); | 373 | err = check_namespace(&nm); |
374 | if (err < 0) | 374 | if (err < 0) |
@@ -426,8 +426,8 @@ ssize_t ubifs_listxattr(struct dentry *dentry, char *buffer, size_t size) | |||
426 | int err, len, written = 0; | 426 | int err, len, written = 0; |
427 | struct qstr nm = { .name = NULL }; | 427 | struct qstr nm = { .name = NULL }; |
428 | 428 | ||
429 | dbg_gen("ino %lu ('%.*s'), buffer size %zd", host->i_ino, | 429 | dbg_gen("ino %lu ('%pd'), buffer size %zd", host->i_ino, |
430 | dentry->d_name.len, dentry->d_name.name, size); | 430 | dentry, size); |
431 | 431 | ||
432 | len = host_ui->xattr_names + host_ui->xattr_cnt; | 432 | len = host_ui->xattr_names + host_ui->xattr_cnt; |
433 | if (!buffer) | 433 | if (!buffer) |
@@ -529,8 +529,8 @@ int ubifs_removexattr(struct dentry *dentry, const char *name) | |||
529 | union ubifs_key key; | 529 | union ubifs_key key; |
530 | int err; | 530 | int err; |
531 | 531 | ||
532 | dbg_gen("xattr '%s', ino %lu ('%.*s')", name, | 532 | dbg_gen("xattr '%s', ino %lu ('%pd')", name, |
533 | host->i_ino, dentry->d_name.len, dentry->d_name.name); | 533 | host->i_ino, dentry); |
534 | ubifs_assert(mutex_is_locked(&host->i_mutex)); | 534 | ubifs_assert(mutex_is_locked(&host->i_mutex)); |
535 | 535 | ||
536 | err = check_namespace(&nm); | 536 | err = check_namespace(&nm); |
diff --git a/fs/utimes.c b/fs/utimes.c index f4fb7eca10e8..aa138d64560a 100644 --- a/fs/utimes.c +++ b/fs/utimes.c | |||
@@ -53,6 +53,7 @@ static int utimes_common(struct path *path, struct timespec *times) | |||
53 | int error; | 53 | int error; |
54 | struct iattr newattrs; | 54 | struct iattr newattrs; |
55 | struct inode *inode = path->dentry->d_inode; | 55 | struct inode *inode = path->dentry->d_inode; |
56 | struct inode *delegated_inode = NULL; | ||
56 | 57 | ||
57 | error = mnt_want_write(path->mnt); | 58 | error = mnt_want_write(path->mnt); |
58 | if (error) | 59 | if (error) |
@@ -101,9 +102,15 @@ static int utimes_common(struct path *path, struct timespec *times) | |||
101 | goto mnt_drop_write_and_out; | 102 | goto mnt_drop_write_and_out; |
102 | } | 103 | } |
103 | } | 104 | } |
105 | retry_deleg: | ||
104 | mutex_lock(&inode->i_mutex); | 106 | mutex_lock(&inode->i_mutex); |
105 | error = notify_change(path->dentry, &newattrs); | 107 | error = notify_change(path->dentry, &newattrs, &delegated_inode); |
106 | mutex_unlock(&inode->i_mutex); | 108 | mutex_unlock(&inode->i_mutex); |
109 | if (delegated_inode) { | ||
110 | error = break_deleg_wait(&delegated_inode); | ||
111 | if (!error) | ||
112 | goto retry_deleg; | ||
113 | } | ||
107 | 114 | ||
108 | mnt_drop_write_and_out: | 115 | mnt_drop_write_and_out: |
109 | mnt_drop_write(path->mnt); | 116 | mnt_drop_write(path->mnt); |