diff options
Diffstat (limited to 'drivers/pinctrl/pinctrl-rockchip.c')
-rw-r--r-- | drivers/pinctrl/pinctrl-rockchip.c | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 192aaee8de07..e2e66c8ccf03 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c | |||
@@ -1492,10 +1492,7 @@ fail: | |||
1492 | for (--i, --bank; i >= 0; --i, --bank) { | 1492 | for (--i, --bank; i >= 0; --i, --bank) { |
1493 | if (!bank->valid) | 1493 | if (!bank->valid) |
1494 | continue; | 1494 | continue; |
1495 | 1495 | gpiochip_remove(&bank->gpio_chip); | |
1496 | if (gpiochip_remove(&bank->gpio_chip)) | ||
1497 | dev_err(&pdev->dev, "gpio chip %s remove failed\n", | ||
1498 | bank->gpio_chip.label); | ||
1499 | } | 1496 | } |
1500 | return ret; | 1497 | return ret; |
1501 | } | 1498 | } |
@@ -1505,20 +1502,15 @@ static int rockchip_gpiolib_unregister(struct platform_device *pdev, | |||
1505 | { | 1502 | { |
1506 | struct rockchip_pin_ctrl *ctrl = info->ctrl; | 1503 | struct rockchip_pin_ctrl *ctrl = info->ctrl; |
1507 | struct rockchip_pin_bank *bank = ctrl->pin_banks; | 1504 | struct rockchip_pin_bank *bank = ctrl->pin_banks; |
1508 | int ret = 0; | ||
1509 | int i; | 1505 | int i; |
1510 | 1506 | ||
1511 | for (i = 0; !ret && i < ctrl->nr_banks; ++i, ++bank) { | 1507 | for (i = 0; i < ctrl->nr_banks; ++i, ++bank) { |
1512 | if (!bank->valid) | 1508 | if (!bank->valid) |
1513 | continue; | 1509 | continue; |
1514 | 1510 | gpiochip_remove(&bank->gpio_chip); | |
1515 | ret = gpiochip_remove(&bank->gpio_chip); | ||
1516 | } | 1511 | } |
1517 | 1512 | ||
1518 | if (ret) | 1513 | return 0; |
1519 | dev_err(&pdev->dev, "gpio chip remove failed\n"); | ||
1520 | |||
1521 | return ret; | ||
1522 | } | 1514 | } |
1523 | 1515 | ||
1524 | static int rockchip_get_bank_data(struct rockchip_pin_bank *bank, | 1516 | static int rockchip_get_bank_data(struct rockchip_pin_bank *bank, |