summaryrefslogtreecommitdiffstats
path: root/drivers/net/macvtap.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/net/macvtap.c')
-rw-r--r--drivers/net/macvtap.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 9093004f9b63..f599c47524f4 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -588,7 +588,7 @@ static int macvtap_skb_from_vnet_hdr(struct sk_buff *skb,
588 return 0; 588 return 0;
589} 589}
590 590
591static int macvtap_skb_to_vnet_hdr(const struct sk_buff *skb, 591static void macvtap_skb_to_vnet_hdr(const struct sk_buff *skb,
592 struct virtio_net_hdr *vnet_hdr) 592 struct virtio_net_hdr *vnet_hdr)
593{ 593{
594 memset(vnet_hdr, 0, sizeof(*vnet_hdr)); 594 memset(vnet_hdr, 0, sizeof(*vnet_hdr));
@@ -619,8 +619,6 @@ static int macvtap_skb_to_vnet_hdr(const struct sk_buff *skb,
619 } else if (skb->ip_summed == CHECKSUM_UNNECESSARY) { 619 } else if (skb->ip_summed == CHECKSUM_UNNECESSARY) {
620 vnet_hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID; 620 vnet_hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID;
621 } /* else everything is zero */ 621 } /* else everything is zero */
622
623 return 0;
624} 622}
625 623
626/* Get packet from user space buffer */ 624/* Get packet from user space buffer */
@@ -778,9 +776,7 @@ static ssize_t macvtap_put_user(struct macvtap_queue *q,
778 if ((len -= vnet_hdr_len) < 0) 776 if ((len -= vnet_hdr_len) < 0)
779 return -EINVAL; 777 return -EINVAL;
780 778
781 ret = macvtap_skb_to_vnet_hdr(skb, &vnet_hdr); 779 macvtap_skb_to_vnet_hdr(skb, &vnet_hdr);
782 if (ret)
783 return ret;
784 780
785 if (memcpy_toiovecend(iv, (void *)&vnet_hdr, 0, sizeof(vnet_hdr))) 781 if (memcpy_toiovecend(iv, (void *)&vnet_hdr, 0, sizeof(vnet_hdr)))
786 return -EFAULT; 782 return -EFAULT;