diff options
Diffstat (limited to 'drivers/block')
-rw-r--r-- | drivers/block/floppy.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index b70d6e103a57..671a0ae434b4 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c | |||
@@ -3380,7 +3380,8 @@ static int fd_getgeo(struct block_device *bdev, struct hd_geometry *geo) | |||
3380 | return 0; | 3380 | return 0; |
3381 | } | 3381 | } |
3382 | 3382 | ||
3383 | static bool valid_floppy_drive_params(const short autodetect[8]) | 3383 | static bool valid_floppy_drive_params(const short autodetect[8], |
3384 | int native_format) | ||
3384 | { | 3385 | { |
3385 | size_t floppy_type_size = ARRAY_SIZE(floppy_type); | 3386 | size_t floppy_type_size = ARRAY_SIZE(floppy_type); |
3386 | size_t i = 0; | 3387 | size_t i = 0; |
@@ -3391,6 +3392,9 @@ static bool valid_floppy_drive_params(const short autodetect[8]) | |||
3391 | return false; | 3392 | return false; |
3392 | } | 3393 | } |
3393 | 3394 | ||
3395 | if (native_format < 0 || native_format >= floppy_type_size) | ||
3396 | return false; | ||
3397 | |||
3394 | return true; | 3398 | return true; |
3395 | } | 3399 | } |
3396 | 3400 | ||
@@ -3520,7 +3524,8 @@ static int fd_locked_ioctl(struct block_device *bdev, fmode_t mode, unsigned int | |||
3520 | SUPBOUND(size, strlen((const char *)outparam) + 1); | 3524 | SUPBOUND(size, strlen((const char *)outparam) + 1); |
3521 | break; | 3525 | break; |
3522 | case FDSETDRVPRM: | 3526 | case FDSETDRVPRM: |
3523 | if (!valid_floppy_drive_params(inparam.dp.autodetect)) | 3527 | if (!valid_floppy_drive_params(inparam.dp.autodetect, |
3528 | inparam.dp.native_format)) | ||
3524 | return -EINVAL; | 3529 | return -EINVAL; |
3525 | *UDP = inparam.dp; | 3530 | *UDP = inparam.dp; |
3526 | break; | 3531 | break; |
@@ -3719,7 +3724,7 @@ static int compat_setdrvprm(int drive, | |||
3719 | return -EPERM; | 3724 | return -EPERM; |
3720 | if (copy_from_user(&v, arg, sizeof(struct compat_floppy_drive_params))) | 3725 | if (copy_from_user(&v, arg, sizeof(struct compat_floppy_drive_params))) |
3721 | return -EFAULT; | 3726 | return -EFAULT; |
3722 | if (!valid_floppy_drive_params(v.autodetect)) | 3727 | if (!valid_floppy_drive_params(v.autodetect, v.native_format)) |
3723 | return -EINVAL; | 3728 | return -EINVAL; |
3724 | mutex_lock(&floppy_mutex); | 3729 | mutex_lock(&floppy_mutex); |
3725 | UDP->cmos = v.cmos; | 3730 | UDP->cmos = v.cmos; |