summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
Diffstat (limited to 'arch')
-rw-r--r--arch/arm/common/scoop.c10
-rw-r--r--arch/mips/txx9/generic/setup.c4
-rw-r--r--arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c3
-rw-r--r--arch/sh/boards/mach-x3proto/gpio.c6
4 files changed, 8 insertions, 15 deletions
diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c
index a20fa80776d3..45f4c21e393c 100644
--- a/arch/arm/common/scoop.c
+++ b/arch/arm/common/scoop.c
@@ -243,18 +243,12 @@ err_ioremap:
243static int scoop_remove(struct platform_device *pdev) 243static int scoop_remove(struct platform_device *pdev)
244{ 244{
245 struct scoop_dev *sdev = platform_get_drvdata(pdev); 245 struct scoop_dev *sdev = platform_get_drvdata(pdev);
246 int ret;
247 246
248 if (!sdev) 247 if (!sdev)
249 return -EINVAL; 248 return -EINVAL;
250 249
251 if (sdev->gpio.base != -1) { 250 if (sdev->gpio.base != -1)
252 ret = gpiochip_remove(&sdev->gpio); 251 gpiochip_remove(&sdev->gpio);
253 if (ret) {
254 dev_err(&pdev->dev, "Can't remove gpio chip: %d\n", ret);
255 return ret;
256 }
257 }
258 252
259 platform_set_drvdata(pdev, NULL); 253 platform_set_drvdata(pdev, NULL);
260 iounmap(sdev->base); 254 iounmap(sdev->base);
diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c
index 9ff200ae1c9a..2791b8641df6 100644
--- a/arch/mips/txx9/generic/setup.c
+++ b/arch/mips/txx9/generic/setup.c
@@ -789,11 +789,11 @@ void __init txx9_iocled_init(unsigned long baseaddr,
789 if (platform_device_add(pdev)) 789 if (platform_device_add(pdev))
790 goto out_pdev; 790 goto out_pdev;
791 return; 791 return;
792
792out_pdev: 793out_pdev:
793 platform_device_put(pdev); 794 platform_device_put(pdev);
794out_gpio: 795out_gpio:
795 if (gpiochip_remove(&iocled->chip)) 796 gpiochip_remove(&iocled->chip);
796 return;
797out_unmap: 797out_unmap:
798 iounmap(iocled->mmioaddr); 798 iounmap(iocled->mmioaddr);
799out_free: 799out_free:
diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index e238b6a55b15..73997027b085 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -141,7 +141,8 @@ static int mcu_gpiochip_add(struct mcu *mcu)
141 141
142static int mcu_gpiochip_remove(struct mcu *mcu) 142static int mcu_gpiochip_remove(struct mcu *mcu)
143{ 143{
144 return gpiochip_remove(&mcu->gc); 144 gpiochip_remove(&mcu->gc);
145 return 0;
145} 146}
146 147
147static int mcu_probe(struct i2c_client *client, const struct i2c_device_id *id) 148static int mcu_probe(struct i2c_client *client, const struct i2c_device_id *id)
diff --git a/arch/sh/boards/mach-x3proto/gpio.c b/arch/sh/boards/mach-x3proto/gpio.c
index 3ea65e9b56e8..f035a7ac6456 100644
--- a/arch/sh/boards/mach-x3proto/gpio.c
+++ b/arch/sh/boards/mach-x3proto/gpio.c
@@ -128,10 +128,8 @@ int __init x3proto_gpio_setup(void)
128 return 0; 128 return 0;
129 129
130err_irq: 130err_irq:
131 ret = gpiochip_remove(&x3proto_gpio_chip); 131 gpiochip_remove(&x3proto_gpio_chip);
132 if (unlikely(ret)) 132 ret = 0;
133 pr_err("Failed deregistering GPIO\n");
134
135err_gpio: 133err_gpio:
136 synchronize_irq(ilsel); 134 synchronize_irq(ilsel);
137 135