14 files changed, 126 insertions, 37 deletions

diff --git a/drivers/hid/hid-axff.c b/drivers/hid/hid-axff.c
index 6654c1550e2e..fbe4e16ab029 100644
--- a/drivers/hid/hid-axff.c
+++ b/drivers/hid/hid-axff.c
@@ -63,13 +63,20 @@ static int axff_init(struct hid_device *hid)
 {
         struct axff_device *axff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+        struct hid_input *hidinput;
         struct list_head *report_list =&hid->report_enum[HID_OUTPUT_REPORT].report_list;
-        struct input_dev *dev = hidinput->input;
+        struct input_dev *dev;
         int field_count = 0;
         int i, j;
         int error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+        dev = hidinput->input;
+
         if (list_empty(report_list)) {
                 hid_err(hid, "no output reports found\n");
                 return -ENODEV;
diff --git a/drivers/hid/hid-dr.c b/drivers/hid/hid-dr.c
index 17e17f9a597b..947f19f8685f 100644
--- a/drivers/hid/hid-dr.c
+++ b/drivers/hid/hid-dr.c
@@ -75,13 +75,19 @@ static int drff_init(struct hid_device *hid)
 {
         struct drff_device *drff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_first_entry(&hid->inputs,
-                                                struct hid_input, list);
+        struct hid_input *hidinput;
         struct list_head *report_list =
                         &hid->report_enum[HID_OUTPUT_REPORT].report_list;
-        struct input_dev *dev = hidinput->input;
+        struct input_dev *dev;
         int error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+        dev = hidinput->input;
+
         if (list_empty(report_list)) {
                 hid_err(hid, "no output reports found\n");
                 return -ENODEV;
diff --git a/drivers/hid/hid-emsff.c b/drivers/hid/hid-emsff.c
index 7cd5651872d3..c34f2e5a049f 100644
--- a/drivers/hid/hid-emsff.c
+++ b/drivers/hid/hid-emsff.c
@@ -47,13 +47,19 @@ static int emsff_init(struct hid_device *hid)
 {
         struct emsff_device *emsff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_first_entry(&hid->inputs,
-                                                struct hid_input, list);
+        struct hid_input *hidinput;
         struct list_head *report_list =
                         &hid->report_enum[HID_OUTPUT_REPORT].report_list;
-        struct input_dev *dev = hidinput->input;
+        struct input_dev *dev;
         int error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+        dev = hidinput->input;
+
         if (list_empty(report_list)) {
                 hid_err(hid, "no output reports found\n");
                 return -ENODEV;
diff --git a/drivers/hid/hid-gaff.c b/drivers/hid/hid-gaff.c
index 0f95c96b70f8..ecbd3995a4eb 100644
--- a/drivers/hid/hid-gaff.c
+++ b/drivers/hid/hid-gaff.c
@@ -64,14 +64,20 @@ static int gaff_init(struct hid_device *hid)
 {
         struct gaff_device *gaff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_entry(hid->inputs.next,
-                                                struct hid_input, list);
+        struct hid_input *hidinput;
         struct list_head *report_list =
                         &hid->report_enum[HID_OUTPUT_REPORT].report_list;
         struct list_head *report_ptr = report_list;
-        struct input_dev *dev = hidinput->input;
+        struct input_dev *dev;
         int error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         if (list_empty(report_list)) {
                 hid_err(hid, "no output reports found\n");
                 return -ENODEV;
diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
index 10a720558830..8619b80c834c 100644
--- a/drivers/hid/hid-holtekff.c
+++ b/drivers/hid/hid-holtekff.c
@@ -124,13 +124,19 @@ static int holtekff_init(struct hid_device *hid)
 {
         struct holtekff_device *holtekff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_entry(hid->inputs.next,
-                                                struct hid_input, list);
+        struct hid_input *hidinput;
         struct list_head *report_list =
                         &hid->report_enum[HID_OUTPUT_REPORT].report_list;
-        struct input_dev *dev = hidinput->input;
+        struct input_dev *dev;
         int error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         if (list_empty(report_list)) {
                 hid_err(hid, "no output report found\n");
                 return -ENODEV;
diff --git a/drivers/hid/hid-lg2ff.c b/drivers/hid/hid-lg2ff.c
index dd1a6c3a7de6..73d07e35f12a 100644
--- a/drivers/hid/hid-lg2ff.c
+++ b/drivers/hid/hid-lg2ff.c
@@ -50,11 +50,17 @@ int lg2ff_init(struct hid_device *hid)
 {
         struct lg2ff_device *lg2ff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_entry(hid->inputs.next,
-                                                struct hid_input, list);
-        struct input_dev *dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *dev;
         int error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         /* Check that the report looks ok */
         report = hid_validate_values(hid, HID_OUTPUT_REPORT, 0, 0, 7);
         if (!report)
diff --git a/drivers/hid/hid-lg3ff.c b/drivers/hid/hid-lg3ff.c
index 9ecb6fd06203..b7e1949f3cf7 100644
--- a/drivers/hid/hid-lg3ff.c
+++ b/drivers/hid/hid-lg3ff.c
@@ -117,12 +117,19 @@ static const signed short ff3_joystick_ac[] = {
 
 int lg3ff_init(struct hid_device *hid)
 {
-        struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
-        struct input_dev *dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *dev;
         const signed short *ff_bits = ff3_joystick_ac;
         int error;
         int i;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         /* Check that the report looks ok */
         if (!hid_validate_values(hid, HID_OUTPUT_REPORT, 0, 0, 35))
                 return -ENODEV;
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index 03f0220062ca..5e6a0cef2a06 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -1253,8 +1253,8 @@ static int lg4ff_handle_multimode_wheel(struct hid_device *hid, u16 *real_produc
 
 int lg4ff_init(struct hid_device *hid)
 {
-        struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
-        struct input_dev *dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *dev;
         struct list_head *report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list;
         struct hid_report *report = list_entry(report_list->next, struct hid_report, list);
         const struct usb_device_descriptor *udesc = &(hid_to_usb_dev(hid)->descriptor);
@@ -1266,6 +1266,13 @@ int lg4ff_init(struct hid_device *hid)
         int mmode_ret, mmode_idx = -1;
         u16 real_product_id;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         /* Check that the report looks ok */
         if (!hid_validate_values(hid, HID_OUTPUT_REPORT, 0, 0, 7))
                 return -1;
diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
index c79a6ec43745..aed4ddc397a9 100644
--- a/drivers/hid/hid-lgff.c
+++ b/drivers/hid/hid-lgff.c
@@ -115,12 +115,19 @@ static void hid_lgff_set_autocenter(struct input_dev *dev, u16 magnitude)
 
 int lgff_init(struct hid_device* hid)
 {
-        struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
-        struct input_dev *dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *dev;
         const signed short *ff_bits = ff_joystick;
         int error;
         int i;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         /* Check that the report looks ok */
         if (!hid_validate_values(hid, HID_OUTPUT_REPORT, 0, 0, 7))
                 return -ENODEV;
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 0179f7ed77e5..1ac1ecc1e67c 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -2084,8 +2084,8 @@ static void hidpp_ff_destroy(struct ff_device *ff)
 static int hidpp_ff_init(struct hidpp_device *hidpp, u8 feature_index)
 {
         struct hid_device *hid = hidpp->hid_dev;
-        struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
-        struct input_dev *dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *dev;
         const struct usb_device_descriptor *udesc = &(hid_to_usb_dev(hid)->descriptor);
         const u16 bcdDevice = le16_to_cpu(udesc->bcdDevice);
         struct ff_device *ff;
@@ -2094,6 +2094,13 @@ static int hidpp_ff_init(struct hidpp_device *hidpp, u8 feature_index)
         int error, j, num_slots;
         u8 version;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         if (!dev) {
                 hid_err(hid, "Struct input_dev not set!\n");
                 return -EINVAL;
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 2cf83856f2e4..2d8b589201a4 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -328,11 +328,17 @@ static int ms_play_effect(struct input_dev *dev, void *data,
 
 static int ms_init_ff(struct hid_device *hdev)
 {
-        struct hid_input *hidinput = list_entry(hdev->inputs.next,
-                                                struct hid_input, list);
-        struct input_dev *input_dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *input_dev;
         struct ms_data *ms = hid_get_drvdata(hdev);
 
+        if (list_empty(&hdev->inputs)) {
+                hid_err(hdev, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hdev->inputs.next, struct hid_input, list);
+        input_dev = hidinput->input;
+
         if (!(ms->quirks & MS_QUIRK_FF))
                 return 0;
 
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 73c0f7a95e2d..4c6ed6ef31f1 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2254,9 +2254,15 @@ static int sony_play_effect(struct input_dev *dev, void *data,
 
 static int sony_init_ff(struct sony_sc *sc)
 {
-        struct hid_input *hidinput = list_entry(sc->hdev->inputs.next,
-                                                struct hid_input, list);
-        struct input_dev *input_dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *input_dev;
+
+        if (list_empty(&sc->hdev->inputs)) {
+                hid_err(sc->hdev, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(sc->hdev->inputs.next, struct hid_input, list);
+        input_dev = hidinput->input;
 
         input_set_capability(input_dev, EV_FF, FF_RUMBLE);
         return input_ff_create_memless(input_dev, NULL, sony_play_effect);
diff --git a/drivers/hid/hid-tmff.c b/drivers/hid/hid-tmff.c
index bdfc5ff3b2c5..90acef304536 100644
--- a/drivers/hid/hid-tmff.c
+++ b/drivers/hid/hid-tmff.c
@@ -124,12 +124,18 @@ static int tmff_init(struct hid_device *hid, const signed short *ff_bits)
         struct tmff_device *tmff;
         struct hid_report *report;
         struct list_head *report_list;
-        struct hid_input *hidinput = list_entry(hid->inputs.next,
-                                                        struct hid_input, list);
-        struct input_dev *input_dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *input_dev;
         int error;
         int i;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        input_dev = hidinput->input;
+
         tmff = kzalloc(sizeof(struct tmff_device), GFP_KERNEL);
         if (!tmff)
                 return -ENOMEM;
diff --git a/drivers/hid/hid-zpff.c b/drivers/hid/hid-zpff.c
index f90959e94028..3abaca045869 100644
--- a/drivers/hid/hid-zpff.c
+++ b/drivers/hid/hid-zpff.c
@@ -54,11 +54,17 @@ static int zpff_init(struct hid_device *hid)
 {
         struct zpff_device *zpff;
         struct hid_report *report;
-        struct hid_input *hidinput = list_entry(hid->inputs.next,
-                                                struct hid_input, list);
-        struct input_dev *dev = hidinput->input;
+        struct hid_input *hidinput;
+        struct input_dev *dev;
         int i, error;
 
+        if (list_empty(&hid->inputs)) {
+                hid_err(hid, "no inputs found\n");
+                return -ENODEV;
+        }
+        hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+        dev = hidinput->input;
+
         for (i = 0; i < 4; i++) {
                 report = hid_validate_values(hid, HID_OUTPUT_REPORT, 0, i, 1);
                 if (!report)