diff options
-rw-r--r-- | net/ipv4/tcp_cong.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c index 79c4817abc94..6e3c512054a6 100644 --- a/net/ipv4/tcp_cong.c +++ b/net/ipv4/tcp_cong.c | |||
@@ -168,12 +168,8 @@ void tcp_assign_congestion_control(struct sock *sk) | |||
168 | } | 168 | } |
169 | out: | 169 | out: |
170 | rcu_read_unlock(); | 170 | rcu_read_unlock(); |
171 | memset(icsk->icsk_ca_priv, 0, sizeof(icsk->icsk_ca_priv)); | ||
171 | 172 | ||
172 | /* Clear out private data before diag gets it and | ||
173 | * the ca has not been initialized. | ||
174 | */ | ||
175 | if (ca->get_info) | ||
176 | memset(icsk->icsk_ca_priv, 0, sizeof(icsk->icsk_ca_priv)); | ||
177 | if (ca->flags & TCP_CONG_NEEDS_ECN) | 173 | if (ca->flags & TCP_CONG_NEEDS_ECN) |
178 | INET_ECN_xmit(sk); | 174 | INET_ECN_xmit(sk); |
179 | else | 175 | else |
@@ -200,11 +196,10 @@ static void tcp_reinit_congestion_control(struct sock *sk, | |||
200 | tcp_cleanup_congestion_control(sk); | 196 | tcp_cleanup_congestion_control(sk); |
201 | icsk->icsk_ca_ops = ca; | 197 | icsk->icsk_ca_ops = ca; |
202 | icsk->icsk_ca_setsockopt = 1; | 198 | icsk->icsk_ca_setsockopt = 1; |
199 | memset(icsk->icsk_ca_priv, 0, sizeof(icsk->icsk_ca_priv)); | ||
203 | 200 | ||
204 | if (sk->sk_state != TCP_CLOSE) { | 201 | if (sk->sk_state != TCP_CLOSE) |
205 | memset(icsk->icsk_ca_priv, 0, sizeof(icsk->icsk_ca_priv)); | ||
206 | tcp_init_congestion_control(sk); | 202 | tcp_init_congestion_control(sk); |
207 | } | ||
208 | } | 203 | } |
209 | 204 | ||
210 | /* Manage refcounts on socket close. */ | 205 | /* Manage refcounts on socket close. */ |