summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--kernel/time/hrtimer.c23
1 files changed, 13 insertions, 10 deletions
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index b1b795e5e0b1..1604157374d7 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -889,10 +889,10 @@ static void __remove_hrtimer(struct hrtimer *timer,
889 * remove hrtimer, called with base lock held 889 * remove hrtimer, called with base lock held
890 */ 890 */
891static inline int 891static inline int
892remove_hrtimer(struct hrtimer *timer, struct hrtimer_clock_base *base) 892remove_hrtimer(struct hrtimer *timer, struct hrtimer_clock_base *base, bool restart)
893{ 893{
894 if (hrtimer_is_queued(timer)) { 894 if (hrtimer_is_queued(timer)) {
895 unsigned long state; 895 unsigned long state = timer->state;
896 int reprogram; 896 int reprogram;
897 897
898 /* 898 /*
@@ -906,12 +906,15 @@ remove_hrtimer(struct hrtimer *timer, struct hrtimer_clock_base *base)
906 debug_deactivate(timer); 906 debug_deactivate(timer);
907 timer_stats_hrtimer_clear_start_info(timer); 907 timer_stats_hrtimer_clear_start_info(timer);
908 reprogram = base->cpu_base == this_cpu_ptr(&hrtimer_bases); 908 reprogram = base->cpu_base == this_cpu_ptr(&hrtimer_bases);
909 /* 909
910 * We must preserve the CALLBACK state flag here, 910 if (!restart) {
911 * otherwise we could move the timer base in 911 /*
912 * switch_hrtimer_base. 912 * We must preserve the CALLBACK state flag here,
913 */ 913 * otherwise we could move the timer base in
914 state = timer->state & HRTIMER_STATE_CALLBACK; 914 * switch_hrtimer_base.
915 */
916 state &= HRTIMER_STATE_CALLBACK;
917 }
915 __remove_hrtimer(timer, base, state, reprogram); 918 __remove_hrtimer(timer, base, state, reprogram);
916 return 1; 919 return 1;
917 } 920 }
@@ -936,7 +939,7 @@ void hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim,
936 base = lock_hrtimer_base(timer, &flags); 939 base = lock_hrtimer_base(timer, &flags);
937 940
938 /* Remove an active timer from the queue: */ 941 /* Remove an active timer from the queue: */
939 remove_hrtimer(timer, base); 942 remove_hrtimer(timer, base, true);
940 943
941 if (mode & HRTIMER_MODE_REL) { 944 if (mode & HRTIMER_MODE_REL) {
942 tim = ktime_add_safe(tim, base->get_time()); 945 tim = ktime_add_safe(tim, base->get_time());
@@ -1005,7 +1008,7 @@ int hrtimer_try_to_cancel(struct hrtimer *timer)
1005 base = lock_hrtimer_base(timer, &flags); 1008 base = lock_hrtimer_base(timer, &flags);
1006 1009
1007 if (!hrtimer_callback_running(timer)) 1010 if (!hrtimer_callback_running(timer))
1008 ret = remove_hrtimer(timer, base); 1011 ret = remove_hrtimer(timer, base, false);
1009 1012
1010 unlock_hrtimer_base(timer, &flags); 1013 unlock_hrtimer_base(timer, &flags);
1011 1014