summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Documentation/ABI/stable/sysfs-devices-system-xen_memory9
-rw-r--r--Documentation/admin-guide/kernel-parameters.txt6
-rw-r--r--Documentation/device-mapper/dm-raid.txt4
-rw-r--r--Documentation/devicetree/bindings/input/gpio-keys.txt2
-rw-r--r--Documentation/devicetree/bindings/net/macb.txt1
-rw-r--r--Documentation/driver-api/fpga/fpga-mgr.rst5
-rw-r--r--Documentation/fb/uvesafb.txt5
-rw-r--r--Documentation/filesystems/vfs.txt21
-rw-r--r--Documentation/media/uapi/dvb/video_function_calls.rst1
-rw-r--r--Documentation/networking/ip-sysctl.txt2
-rw-r--r--Documentation/process/code-of-conduct.rst81
-rw-r--r--Documentation/process/code-of-conflict.rst28
-rw-r--r--Documentation/process/index.rst2
-rw-r--r--Documentation/virtual/kvm/api.txt12
-rw-r--r--Documentation/x86/earlyprintk.txt25
-rw-r--r--MAINTAINERS81
-rw-r--r--Makefile32
-rw-r--r--arch/arc/Kconfig2
-rw-r--r--arch/arc/Makefile26
-rw-r--r--arch/arc/kernel/process.c20
-rw-r--r--arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts2
-rw-r--r--arch/arm/boot/dts/bcm63138.dtsi14
-rw-r--r--arch/arm/boot/dts/imx53-qsb-common.dtsi11
-rw-r--r--arch/arm/boot/dts/sama5d3_emac.dtsi2
-rw-r--r--arch/arm/boot/dts/stm32mp157c.dtsi4
-rw-r--r--arch/arm/boot/dts/sun8i-r40.dtsi3
-rw-r--r--arch/arm/kernel/vmlinux.lds.h2
-rw-r--r--arch/arm/kvm/coproc.c8
-rw-r--r--arch/arm/mm/ioremap.c2
-rw-r--r--arch/arm/tools/syscall.tbl1
-rw-r--r--arch/arm64/include/asm/jump_label.h4
-rw-r--r--arch/arm64/kernel/Makefile1
-rw-r--r--arch/arm64/kernel/crash_core.c19
-rw-r--r--arch/arm64/kernel/machine_kexec.c11
-rw-r--r--arch/arm64/kernel/perf_event.c7
-rw-r--r--arch/arm64/kernel/setup.c56
-rw-r--r--arch/arm64/kvm/guest.c55
-rw-r--r--arch/arm64/mm/hugetlbpage.c50
-rw-r--r--arch/hexagon/include/asm/bitops.h4
-rw-r--r--arch/hexagon/kernel/dma.c2
-rw-r--r--arch/mips/include/asm/mach-lantiq/xway/xway_dma.h1
-rw-r--r--arch/mips/include/asm/processor.h10
-rw-r--r--arch/mips/kernel/process.c25
-rw-r--r--arch/mips/kernel/setup.c48
-rw-r--r--arch/mips/kernel/vdso.c18
-rw-r--r--arch/mips/lantiq/xway/dma.c4
-rw-r--r--arch/mips/lib/memset.S4
-rw-r--r--arch/powerpc/include/asm/book3s/64/pgtable.h5
-rw-r--r--arch/powerpc/include/asm/iommu.h2
-rw-r--r--arch/powerpc/include/asm/mmu_context.h1
-rw-r--r--arch/powerpc/include/asm/setup.h1
-rw-r--r--arch/powerpc/kernel/exceptions-64s.S4
-rw-r--r--arch/powerpc/kernel/iommu.c25
-rw-r--r--arch/powerpc/kernel/process.c10
-rw-r--r--arch/powerpc/kernel/tm.S20
-rw-r--r--arch/powerpc/kvm/book3s_64_mmu_radix.c101
-rw-r--r--arch/powerpc/kvm/book3s_64_vio_hv.c39
-rw-r--r--arch/powerpc/lib/checksum_64.S3
-rw-r--r--arch/powerpc/lib/code-patching.c14
-rw-r--r--arch/powerpc/mm/init_64.c49
-rw-r--r--arch/powerpc/mm/mem.c2
-rw-r--r--arch/powerpc/mm/mmu_context_iommu.c34
-rw-r--r--arch/powerpc/mm/numa.c12
-rw-r--r--arch/powerpc/mm/pkeys.c2
-rw-r--r--arch/powerpc/platforms/powernv/pci-ioda-tce.c2
-rw-r--r--arch/riscv/include/asm/asm-prototypes.h7
-rw-r--r--arch/riscv/kernel/setup.c9
-rw-r--r--arch/s390/crypto/paes_s390.c2
-rw-r--r--arch/s390/include/asm/sclp.h3
-rw-r--r--arch/s390/kernel/early_printk.c2
-rw-r--r--arch/s390/kernel/swsusp.S8
-rw-r--r--arch/s390/kvm/kvm-s390.c4
-rw-r--r--arch/s390/mm/gmap.c4
-rw-r--r--arch/sparc/kernel/auxio_64.c4
-rw-r--r--arch/sparc/kernel/kgdb_32.c2
-rw-r--r--arch/sparc/kernel/kgdb_64.c2
-rw-r--r--arch/sparc/kernel/power.c4
-rw-r--r--arch/sparc/kernel/prom_32.c26
-rw-r--r--arch/sparc/kernel/prom_64.c68
-rw-r--r--arch/sparc/kernel/viohs.c12
-rw-r--r--arch/sparc/vdso/Makefile8
-rw-r--r--arch/x86/boot/compressed/mem_encrypt.S19
-rw-r--r--arch/x86/crypto/aegis128-aesni-glue.c1
-rw-r--r--arch/x86/crypto/aegis128l-aesni-glue.c1
-rw-r--r--arch/x86/crypto/aegis256-aesni-glue.c1
-rw-r--r--arch/x86/crypto/morus1280-sse2-glue.c1
-rw-r--r--arch/x86/crypto/morus640-sse2-glue.c1
-rw-r--r--arch/x86/entry/vdso/Makefile16
-rw-r--r--arch/x86/entry/vdso/vclock_gettime.c26
-rw-r--r--arch/x86/events/amd/uncore.c10
-rw-r--r--arch/x86/events/intel/lbr.c4
-rw-r--r--arch/x86/events/intel/uncore_snbep.c14
-rw-r--r--arch/x86/hyperv/hv_apic.c8
-rw-r--r--arch/x86/include/asm/fixmap.h10
-rw-r--r--arch/x86/include/asm/hyperv-tlfs.h16
-rw-r--r--arch/x86/include/asm/kvm_host.h5
-rw-r--r--arch/x86/include/asm/mem_encrypt.h7
-rw-r--r--arch/x86/include/asm/perf_event.h8
-rw-r--r--arch/x86/include/asm/pgtable-2level.h9
-rw-r--r--arch/x86/include/asm/pgtable_64.h3
-rw-r--r--arch/x86/include/asm/pgtable_types.h2
-rw-r--r--arch/x86/include/asm/uv/uv.h6
-rw-r--r--arch/x86/include/uapi/asm/kvm.h1
-rw-r--r--arch/x86/kernel/apm_32.c2
-rw-r--r--arch/x86/kernel/cpu/amd.c2
-rw-r--r--arch/x86/kernel/cpu/intel_rdt.h23
-rw-r--r--arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c27
-rw-r--r--arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c20
-rw-r--r--arch/x86/kernel/cpu/intel_rdt_rdtgroup.c89
-rw-r--r--arch/x86/kernel/eisa.c10
-rw-r--r--arch/x86/kernel/head64.c20
-rw-r--r--arch/x86/kernel/head_64.S16
-rw-r--r--arch/x86/kernel/kvmclock.c52
-rw-r--r--arch/x86/kernel/paravirt.c4
-rw-r--r--arch/x86/kernel/topology.c4
-rw-r--r--arch/x86/kernel/tsc.c4
-rw-r--r--arch/x86/kernel/vmlinux.lds.S19
-rw-r--r--arch/x86/kvm/lapic.c22
-rw-r--r--arch/x86/kvm/mmu.c33
-rw-r--r--arch/x86/kvm/svm.c13
-rw-r--r--arch/x86/kvm/vmx.c279
-rw-r--r--arch/x86/kvm/x86.c103
-rw-r--r--arch/x86/mm/init.c4
-rw-r--r--arch/x86/mm/mem_encrypt.c24
-rw-r--r--arch/x86/mm/pgtable.c19
-rw-r--r--arch/x86/platform/efi/efi_32.c3
-rw-r--r--arch/x86/xen/mmu_pv.c8
-rw-r--r--arch/x86/xen/pmu.c2
-rw-r--r--arch/xtensa/Kconfig1
-rw-r--r--arch/xtensa/Makefile4
-rw-r--r--arch/xtensa/platforms/iss/setup.c25
-rw-r--r--block/bio.c2
-rw-r--r--block/blk-cgroup.c4
-rw-r--r--block/blk-core.c4
-rw-r--r--block/blk-mq-tag.c13
-rw-r--r--block/blk-mq.c4
-rw-r--r--block/blk-wbt.c2
-rw-r--r--block/elevator.c2
-rw-r--r--block/genhd.c6
-rw-r--r--block/partition-generic.c6
-rw-r--r--drivers/acpi/Kconfig6
-rw-r--r--drivers/acpi/acpi_lpss.c118
-rw-r--r--drivers/acpi/acpi_processor.c7
-rw-r--r--drivers/acpi/acpi_tad.c201
-rw-r--r--drivers/acpi/acpica/Makefile1
-rw-r--r--drivers/acpi/acpica/acevents.h2
-rw-r--r--drivers/acpi/acpica/acinterp.h23
-rw-r--r--drivers/acpi/acpica/aclocal.h2
-rw-r--r--drivers/acpi/acpica/amlcode.h10
-rw-r--r--drivers/acpi/acpica/dsopcode.c4
-rw-r--r--drivers/acpi/acpica/evregion.c17
-rw-r--r--drivers/acpi/acpica/evrgnini.c6
-rw-r--r--drivers/acpi/acpica/evxfregn.c1
-rw-r--r--drivers/acpi/acpica/exfield.c326
-rw-r--r--drivers/acpi/acpica/exserial.c360
-rw-r--r--drivers/acpi/acpica/psloop.c16
-rw-r--r--drivers/acpi/acpica/tbxfload.c3
-rw-r--r--drivers/acpi/bus.c44
-rw-r--r--drivers/acpi/custom_method.c3
-rw-r--r--drivers/acpi/glue.c2
-rw-r--r--drivers/acpi/osl.c16
-rw-r--r--drivers/acpi/pmic/intel_pmic_bxtwc.c12
-rw-r--r--drivers/acpi/pmic/intel_pmic_chtdc_ti.c1
-rw-r--r--drivers/acpi/pmic/intel_pmic_chtwc.c10
-rw-r--r--drivers/acpi/pmic/intel_pmic_crc.c16
-rw-r--r--drivers/acpi/pmic/intel_pmic_xpower.c16
-rw-r--r--drivers/acpi/pmic/tps68470_pmic.c2
-rw-r--r--drivers/acpi/pptt.c33
-rw-r--r--drivers/acpi/sbs.c8
-rw-r--r--drivers/acpi/sbshc.c2
-rw-r--r--drivers/acpi/scan.c1
-rw-r--r--drivers/android/binder_alloc.c43
-rw-r--r--drivers/ata/libata-core.c14
-rw-r--r--drivers/base/cacheinfo.c2
-rw-r--r--drivers/base/firmware_loader/main.c35
-rw-r--r--drivers/base/power/main.c5
-rw-r--r--drivers/block/floppy.c3
-rw-r--r--drivers/block/null_blk.h17
-rw-r--r--drivers/block/null_blk_main.c45
-rw-r--r--drivers/block/null_blk_zoned.c34
-rw-r--r--drivers/block/xen-blkfront.c4
-rw-r--r--drivers/bluetooth/hci_ldisc.c2
-rw-r--r--drivers/bluetooth/hci_qca.c2
-rw-r--r--drivers/char/ipmi/ipmi_bt_sm.c92
-rw-r--r--drivers/char/ipmi/ipmi_msghandler.c53
-rw-r--r--drivers/char/ipmi/ipmi_si_intf.c17
-rw-r--r--drivers/char/ipmi/ipmi_ssif.c32
-rw-r--r--drivers/char/ipmi/kcs_bmc.c7
-rw-r--r--drivers/clk/x86/clk-pmc-atom.c18
-rw-r--r--drivers/clocksource/timer-atmel-pit.c20
-rw-r--r--drivers/clocksource/timer-fttmr010.c18
-rw-r--r--drivers/clocksource/timer-ti-32k.c3
-rw-r--r--drivers/cpufreq/qcom-cpufreq-kryo.c4
-rw-r--r--drivers/crypto/caam/caamalg.c8
-rw-r--r--drivers/crypto/ccp/psp-dev.c46
-rw-r--r--drivers/crypto/chelsio/chcr_algo.c32
-rw-r--r--drivers/crypto/chelsio/chcr_crypto.h2
-rw-r--r--drivers/crypto/inside-secure/safexcel.c8
-rw-r--r--drivers/crypto/mxs-dcp.c53
-rw-r--r--drivers/crypto/qat/qat_c3xxx/adf_drv.c6
-rw-r--r--drivers/crypto/qat/qat_c3xxxvf/adf_drv.c6
-rw-r--r--drivers/crypto/qat/qat_c62x/adf_drv.c6
-rw-r--r--drivers/crypto/qat/qat_c62xvf/adf_drv.c6
-rw-r--r--drivers/crypto/qat/qat_dh895xcc/adf_drv.c6
-rw-r--r--drivers/crypto/qat/qat_dh895xccvf/adf_drv.c6
-rw-r--r--drivers/dax/device.c6
-rw-r--r--drivers/dma/mic_x100_dma.c4
-rw-r--r--drivers/firmware/efi/Kconfig9
-rw-r--r--drivers/fpga/dfl-fme-pr.c2
-rw-r--r--drivers/fpga/dfl-fme-region.c4
-rw-r--r--drivers/fpga/fpga-bridge.c2
-rw-r--r--drivers/fpga/of-fpga-region.c3
-rw-r--r--drivers/gpio/gpiolib.c5
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c6
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c14
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c25
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_device.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c1
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c3
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c4
-rw-r--r--drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c7
-rw-r--r--drivers/gpu/drm/amd/amdkfd/kfd_device.c3
-rw-r--r--drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c37
-rw-r--r--drivers/gpu/drm/amd/amdkfd/kfd_iommu.c13
-rw-r--r--drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c2
-rw-r--r--drivers/gpu/drm/amd/amdkfd/kfd_priv.h1
-rw-r--r--drivers/gpu/drm/amd/amdkfd/kfd_topology.c21
-rw-r--r--drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c149
-rw-r--r--drivers/gpu/drm/amd/display/dc/core/dc_link.c4
-rw-r--r--drivers/gpu/drm/amd/display/dc/dc_link.h1
-rw-r--r--drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c2
-rw-r--r--drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.h5
-rw-r--r--drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c12
-rw-r--r--drivers/gpu/drm/amd/include/kgd_kfd_interface.h2
-rw-r--r--drivers/gpu/drm/arm/malidp_drv.c1
-rw-r--r--drivers/gpu/drm/arm/malidp_hw.c25
-rw-r--r--drivers/gpu/drm/arm/malidp_hw.h3
-rw-r--r--drivers/gpu/drm/arm/malidp_mw.c25
-rw-r--r--drivers/gpu/drm/arm/malidp_regs.h2
-rw-r--r--drivers/gpu/drm/drm_atomic.c2
-rw-r--r--drivers/gpu/drm/drm_client.c35
-rw-r--r--drivers/gpu/drm/drm_debugfs.c2
-rw-r--r--drivers/gpu/drm/drm_fb_cma_helper.c4
-rw-r--r--drivers/gpu/drm/drm_fb_helper.c7
-rw-r--r--drivers/gpu/drm/drm_lease.c6
-rw-r--r--drivers/gpu/drm/drm_panel.c10
-rw-r--r--drivers/gpu/drm/drm_syncobj.c5
-rw-r--r--drivers/gpu/drm/etnaviv/etnaviv_drv.c27
-rw-r--r--drivers/gpu/drm/exynos/exynos_drm_iommu.h34
-rw-r--r--drivers/gpu/drm/i2c/tda9950.c5
-rw-r--r--drivers/gpu/drm/i915/gvt/handlers.c1
-rw-r--r--drivers/gpu/drm/i915/gvt/kvmgt.c17
-rw-r--r--drivers/gpu/drm/i915/gvt/mmio.c28
-rw-r--r--drivers/gpu/drm/i915/gvt/opregion.c20
-rw-r--r--drivers/gpu/drm/i915/gvt/vgpu.c1
-rw-r--r--drivers/gpu/drm/i915/i915_gpu_error.c88
-rw-r--r--drivers/gpu/drm/i915/i915_gpu_error.h1
-rw-r--r--drivers/gpu/drm/i915/i915_irq.c33
-rw-r--r--drivers/gpu/drm/i915/i915_pci.c1
-rw-r--r--drivers/gpu/drm/i915/intel_display.c8
-rw-r--r--drivers/gpu/drm/i915/intel_overlay.c228
-rw-r--r--drivers/gpu/drm/mediatek/mtk_drm_crtc.c2
-rw-r--r--drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c4
-rw-r--r--drivers/gpu/drm/nouveau/dispnv50/disp.c82
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_connector.c110
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_display.c44
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_display.h2
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_drm.c21
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_fbcon.c57
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_fbcon.h5
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_vga.c2
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c14
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c54
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h1
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c6
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c18
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h5
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm200.c24
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c2
-rw-r--r--drivers/gpu/drm/pl111/pl111_vexpress.c3
-rw-r--r--drivers/gpu/drm/sun4i/sun4i_drv.c1
-rw-r--r--drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c1
-rw-r--r--drivers/gpu/drm/sun4i/sun8i_mixer.c24
-rw-r--r--drivers/gpu/drm/sun4i/sun8i_tcon_top.c1
-rw-r--r--drivers/gpu/drm/udl/udl_fb.c8
-rw-r--r--drivers/gpu/drm/vc4/vc4_plane.c25
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c2
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_kms.c42
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c25
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_surface.c24
-rw-r--r--drivers/gpu/vga/vga_switcheroo.c2
-rw-r--r--drivers/hid/hid-apple.c9
-rw-r--r--drivers/hid/hid-core.c5
-rw-r--r--drivers/hid/hid-ids.h7
-rw-r--r--drivers/hid/hid-input.c5
-rw-r--r--drivers/hid/hid-multitouch.c19
-rw-r--r--drivers/hid/hid-saitek.c2
-rw-r--r--drivers/hid/hid-sensor-hub.c23
-rw-r--r--drivers/hid/i2c-hid/i2c-hid.c34
-rw-r--r--drivers/hid/intel-ish-hid/ipc/hw-ish.h2
-rw-r--r--drivers/hid/intel-ish-hid/ipc/pci-ish.c2
-rw-r--r--drivers/hv/connection.c8
-rw-r--r--drivers/hv/vmbus_drv.c3
-rw-r--r--drivers/hwmon/nct6775.c72
-rw-r--r--drivers/hwmon/npcm750-pwm-fan.c2
-rw-r--r--drivers/hwtracing/intel_th/core.c16
-rw-r--r--drivers/hwtracing/intel_th/pci.c5
-rw-r--r--drivers/i2c/busses/i2c-designware-master.c4
-rw-r--r--drivers/i2c/busses/i2c-isch.c2
-rw-r--r--drivers/i2c/busses/i2c-qcom-geni.c22
-rw-r--r--drivers/i2c/busses/i2c-scmi.c1
-rw-r--r--drivers/i2c/i2c-core-base.c2
-rw-r--r--drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c13
-rw-r--r--drivers/iio/temperature/maxim_thermocouple.c1
-rw-r--r--drivers/infiniband/core/cache.c68
-rw-r--r--drivers/infiniband/core/cma.c12
-rw-r--r--drivers/infiniband/core/rdma_core.c2
-rw-r--r--drivers/infiniband/core/ucma.c8
-rw-r--r--drivers/infiniband/core/uverbs_cmd.c68
-rw-r--r--drivers/infiniband/core/uverbs_main.c6
-rw-r--r--drivers/infiniband/core/uverbs_uapi.c1
-rw-r--r--drivers/infiniband/hw/bnxt_re/ib_verbs.c2
-rw-r--r--drivers/infiniband/hw/bnxt_re/main.c93
-rw-r--r--drivers/infiniband/hw/bnxt_re/qplib_fp.c2
-rw-r--r--drivers/infiniband/hw/cxgb4/qp.c6
-rw-r--r--drivers/infiniband/hw/hfi1/chip.c6
-rw-r--r--drivers/infiniband/hw/hfi1/pcie.c11
-rw-r--r--drivers/infiniband/hw/hfi1/pio.c51
-rw-r--r--drivers/infiniband/hw/hfi1/pio.h2
-rw-r--r--drivers/infiniband/hw/hfi1/user_sdma.c2
-rw-r--r--drivers/infiniband/hw/hfi1/verbs.c8
-rw-r--r--drivers/infiniband/hw/mlx4/main.c8
-rw-r--r--drivers/infiniband/hw/mlx5/devx.c5
-rw-r--r--drivers/infiniband/hw/mlx5/mr.c12
-rw-r--r--drivers/infiniband/ulp/ipoib/ipoib_cm.c2
-rw-r--r--drivers/infiniband/ulp/srp/ib_srp.c6
-rw-r--r--drivers/input/evdev.c1
-rw-r--r--drivers/input/joystick/xpad.c3
-rw-r--r--drivers/input/keyboard/atakbd.c74
-rw-r--r--drivers/input/misc/uinput.c3
-rw-r--r--drivers/input/mouse/elantech.c2
-rw-r--r--drivers/input/mousedev.c1
-rw-r--r--drivers/input/serio/i8042.c29
-rw-r--r--drivers/input/touchscreen/egalax_ts.c6
-rw-r--r--drivers/iommu/amd_iommu.c8
-rw-r--r--drivers/iommu/intel-iommu.c6
-rw-r--r--drivers/iommu/intel-pasid.h2
-rw-r--r--drivers/iommu/rockchip-iommu.c6
-rw-r--r--drivers/mailbox/pcc.c7
-rw-r--r--drivers/md/bcache/bcache.h1
-rw-r--r--drivers/md/bcache/journal.c6
-rw-r--r--drivers/md/bcache/super.c8
-rw-r--r--drivers/md/dm-cache-metadata.c4
-rw-r--r--drivers/md/dm-cache-target.c14
-rw-r--r--drivers/md/dm-crypt.c10
-rw-r--r--drivers/md/dm-flakey.c2
-rw-r--r--drivers/md/dm-integrity.c7
-rw-r--r--drivers/md/dm-linear.c8
-rw-r--r--drivers/md/dm-mpath.c14
-rw-r--r--drivers/md/dm-raid.c154
-rw-r--r--drivers/md/dm-thin-metadata.c34
-rw-r--r--drivers/md/dm-thin.c73
-rw-r--r--drivers/md/dm-verity-target.c24
-rw-r--r--drivers/md/dm.c27
-rw-r--r--drivers/media/i2c/mt9v111.c41
-rw-r--r--drivers/media/platform/Kconfig2
-rw-r--r--drivers/media/platform/qcom/camss/camss-csid.c1
-rw-r--r--drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c1
-rw-r--r--drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c1
-rw-r--r--drivers/media/platform/qcom/camss/camss-csiphy.c1
-rw-r--r--drivers/media/platform/qcom/camss/camss-ispif.c5
-rw-r--r--drivers/media/platform/qcom/camss/camss-vfe-4-1.c1
-rw-r--r--drivers/media/platform/qcom/camss/camss-vfe-4-7.c1
-rw-r--r--drivers/media/platform/qcom/camss/camss.c15
-rw-r--r--drivers/media/usb/dvb-usb-v2/af9035.c6
-rw-r--r--drivers/media/v4l2-core/v4l2-event.c38
-rw-r--r--drivers/media/v4l2-core/v4l2-fh.c2
-rw-r--r--drivers/mfd/omap-usb-host.c11
-rw-r--r--drivers/misc/hmc6352.c2
-rw-r--r--drivers/misc/ibmvmc.c2
-rw-r--r--drivers/misc/mei/bus.c12
-rw-r--r--drivers/misc/mei/client.c2
-rw-r--r--drivers/misc/mei/hbm.c9
-rw-r--r--drivers/mmc/core/block.c10
-rw-r--r--drivers/mmc/core/host.c2
-rw-r--r--drivers/mmc/core/slot-gpio.c2
-rw-r--r--drivers/mmc/host/meson-mx-sdio.c8
-rw-r--r--drivers/mmc/host/omap_hsmmc.c1
-rw-r--r--drivers/mmc/host/renesas_sdhi_sys_dmac.c3
-rw-r--r--drivers/mtd/devices/m25p80.c26
-rw-r--r--drivers/mtd/mtdpart.c5
-rw-r--r--drivers/mtd/nand/raw/denali.c6
-rw-r--r--drivers/mtd/nand/raw/marvell_nand.c4
-rw-r--r--drivers/mux/adgs1408.c2
-rw-r--r--drivers/net/appletalk/ipddp.c8
-rw-r--r--drivers/net/bonding/bond_main.c76
-rw-r--r--drivers/net/dsa/b53/b53_common.c4
-rw-r--r--drivers/net/dsa/bcm_sf2.c14
-rw-r--r--drivers/net/dsa/mv88e6xxx/global1.h2
-rw-r--r--drivers/net/dsa/mv88e6xxx/global1_atu.c2
-rw-r--r--drivers/net/ethernet/amazon/ena/ena_com.c24
-rw-r--r--drivers/net/ethernet/amazon/ena/ena_eth_com.c14
-rw-r--r--drivers/net/ethernet/amazon/ena/ena_eth_com.h8
-rw-r--r--drivers/net/ethernet/amazon/ena/ena_netdev.c126
-rw-r--r--drivers/net/ethernet/amazon/ena/ena_netdev.h11
-rw-r--r--drivers/net/ethernet/amd/declance.c10
-rw-r--r--drivers/net/ethernet/apple/bmac.c4
-rw-r--r--drivers/net/ethernet/apple/mace.c4
-rw-r--r--drivers/net/ethernet/apple/macmace.c4
-rw-r--r--drivers/net/ethernet/aquantia/atlantic/aq_ring.c32
-rw-r--r--drivers/net/ethernet/broadcom/bcmsysport.c28
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c16
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt.c54
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c6
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c3
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c9
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h2
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c20
-rw-r--r--drivers/net/ethernet/cadence/macb_main.c9
-rw-r--r--drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c17
-rw-r--r--drivers/net/ethernet/chelsio/cxgb4/t4_msg.h1
-rw-r--r--drivers/net/ethernet/cirrus/ep93xx_eth.c2
-rw-r--r--drivers/net/ethernet/cirrus/mac89x0.c4
-rw-r--r--drivers/net/ethernet/emulex/benet/be_cmds.c2
-rw-r--r--drivers/net/ethernet/emulex/benet/be_main.c5
-rw-r--r--drivers/net/ethernet/freescale/fec_main.c8
-rw-r--r--drivers/net/ethernet/hisilicon/hns/hnae.c2
-rw-r--r--drivers/net/ethernet/hisilicon/hns/hns_enet.c48
-rw-r--r--drivers/net/ethernet/hp/hp100.c2
-rw-r--r--drivers/net/ethernet/huawei/hinic/hinic_main.c20
-rw-r--r--drivers/net/ethernet/i825xx/ether1.c5
-rw-r--r--drivers/net/ethernet/i825xx/lib82596.c4
-rw-r--r--drivers/net/ethernet/i825xx/sun3_82586.c6
-rw-r--r--drivers/net/ethernet/ibm/ehea/ehea_main.c14
-rw-r--r--drivers/net/ethernet/ibm/emac/core.c15
-rw-r--r--drivers/net/ethernet/ibm/ibmvnic.c16
-rw-r--r--drivers/net/ethernet/intel/fm10k/fm10k.h3
-rw-r--r--drivers/net/ethernet/intel/fm10k/fm10k_netdev.c3
-rw-r--r--drivers/net/ethernet/intel/fm10k/fm10k_pci.c22
-rw-r--r--drivers/net/ethernet/intel/i40evf/i40evf_main.c26
-rw-r--r--drivers/net/ethernet/intel/ice/ice_main.c27
-rw-r--r--drivers/net/ethernet/intel/igb/igb_main.c30
-rw-r--r--drivers/net/ethernet/intel/ixgb/ixgb_main.c25
-rw-r--r--drivers/net/ethernet/intel/ixgbe/ixgbe_main.c37
-rw-r--r--drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c21
-rw-r--r--drivers/net/ethernet/lantiq_etop.c1
-rw-r--r--drivers/net/ethernet/marvell/mvneta.c13
-rw-r--r--drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c40
-rw-r--r--drivers/net/ethernet/mellanox/mlx4/en_netdev.c20
-rw-r--r--drivers/net/ethernet/mellanox/mlx4/eq.c3
-rw-r--r--drivers/net/ethernet/mellanox/mlx4/main.c43
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/cmd.c2
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/dev.c22
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en.h1
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en/fs.h2
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c3
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c2
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_main.c21
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_tc.c65
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/eswitch.c4
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c1
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/fs_core.c76
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/health.c10
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/main.c12
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/transobj.c7
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/wq.c6
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/wq.h2
-rw-r--r--drivers/net/ethernet/mellanox/mlxsw/pci.c11
-rw-r--r--drivers/net/ethernet/mellanox/mlxsw/spectrum.c6
-rw-r--r--drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c16
-rw-r--r--drivers/net/ethernet/microchip/lan743x_main.c6
-rw-r--r--drivers/net/ethernet/mscc/ocelot_board.c12
-rw-r--r--drivers/net/ethernet/netronome/nfp/flower/action.c6
-rw-r--r--drivers/net/ethernet/netronome/nfp/flower/main.h1
-rw-r--r--drivers/net/ethernet/netronome/nfp/flower/match.c2
-rw-r--r--drivers/net/ethernet/netronome/nfp/flower/offload.c11
-rw-r--r--drivers/net/ethernet/netronome/nfp/nfp_net_common.c35
-rw-r--r--drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c23
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_dcbx.c45
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_dcbx.h1
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_dev.c15
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_hsi.h5
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_iwarp.c4
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_mcp.c24
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_rdma.c2
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_reg_addr.h6
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_roce.c15
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_sp_commands.c2
-rw-r--r--drivers/net/ethernet/qlogic/qed/qed_vf.c5
-rw-r--r--drivers/net/ethernet/qlogic/qlcnic/qlcnic.h8
-rw-r--r--drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c3
-rw-r--r--drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h3
-rw-r--r--drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.h3
-rw-r--r--drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c12
-rw-r--r--drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c45
-rw-r--r--drivers/net/ethernet/qualcomm/qca_7k.c76
-rw-r--r--drivers/net/ethernet/qualcomm/qca_spi.c110
-rw-r--r--drivers/net/ethernet/qualcomm/qca_spi.h5
-rw-r--r--drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c7
-rw-r--r--drivers/net/ethernet/realtek/r8169.c88
-rw-r--r--drivers/net/ethernet/renesas/Kconfig1
-rw-r--r--drivers/net/ethernet/renesas/Makefile1
-rw-r--r--drivers/net/ethernet/renesas/ravb.h5
-rw-r--r--drivers/net/ethernet/renesas/ravb_main.c11
-rw-r--r--drivers/net/ethernet/renesas/ravb_ptp.c8
-rw-r--r--drivers/net/ethernet/seeq/ether3.c5
-rw-r--r--drivers/net/ethernet/seeq/sgiseeq.c3
-rw-r--r--drivers/net/ethernet/sfc/efx.c26
-rw-r--r--drivers/net/ethernet/sfc/falcon/efx.c26
-rw-r--r--drivers/net/ethernet/sgi/ioc3-eth.c4
-rw-r--r--drivers/net/ethernet/sgi/meth.c2
-rw-r--r--drivers/net/ethernet/socionext/netsec.c5
-rw-r--r--drivers/net/ethernet/stmicro/stmmac/common.h4
-rw-r--r--drivers/net/ethernet/stmicro/stmmac/stmmac.h14
-rw-r--r--drivers/net/ethernet/stmicro/stmmac/stmmac_main.c238
-rw-r--r--drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c5
-rw-r--r--drivers/net/ethernet/ti/Kconfig1
-rw-r--r--drivers/net/ethernet/wiznet/w5100.c2
-rw-r--r--drivers/net/ethernet/wiznet/w5300.c2
-rw-r--r--drivers/net/hamradio/yam.c4
-rw-r--r--drivers/net/hyperv/netvsc.c3
-rw-r--r--drivers/net/hyperv/netvsc_drv.c67
-rw-r--r--drivers/net/ieee802154/adf7242.c3
-rw-r--r--drivers/net/ieee802154/ca8210.c6
-rw-r--r--drivers/net/ieee802154/mcr20a.c8
-rw-r--r--drivers/net/phy/phy_device.c12
-rw-r--r--drivers/net/phy/phylink.c48
-rw-r--r--drivers/net/phy/sfp-bus.c4
-rw-r--r--drivers/net/phy/sfp.c9
-rw-r--r--drivers/net/ppp/pppoe.c3
-rw-r--r--drivers/net/team/team.c6
-rw-r--r--drivers/net/tun.c80
-rw-r--r--drivers/net/usb/asix_common.c3
-rw-r--r--drivers/net/usb/ax88179_178a.c3
-rw-r--r--drivers/net/usb/lan78xx.c17
-rw-r--r--drivers/net/usb/qmi_wwan.c45
-rw-r--r--drivers/net/usb/r8152.c3
-rw-r--r--drivers/net/usb/smsc75xx.c4
-rw-r--r--drivers/net/usb/smsc95xx.c3
-rw-r--r--drivers/net/usb/sr9800.c3
-rw-r--r--drivers/net/veth.c4
-rw-r--r--drivers/net/virtio_net.c14
-rw-r--r--drivers/net/vxlan.c3
-rw-r--r--drivers/net/wimax/i2400m/control.c2
-rw-r--r--drivers/net/wireless/broadcom/b43/dma.c6
-rw-r--r--drivers/net/wireless/intel/iwlwifi/cfg/1000.c1
-rw-r--r--drivers/net/wireless/mac80211_hwsim.c36
-rw-r--r--drivers/net/wireless/marvell/libertas/if_sdio.c4
-rw-r--r--drivers/net/wireless/mediatek/mt76/mt76x0/main.c3
-rw-r--r--drivers/net/wireless/mediatek/mt76/usb.c10
-rw-r--r--drivers/net/xen-netback/common.h3
-rw-r--r--drivers/net/xen-netback/hash.c51
-rw-r--r--drivers/net/xen-netback/interface.c3
-rw-r--r--drivers/net/xen-netfront.c32
-rw-r--r--drivers/nvme/host/multipath.c6
-rw-r--r--drivers/nvme/target/admin-cmd.c4
-rw-r--r--drivers/nvme/target/rdma.c27
-rw-r--r--drivers/of/base.c3
-rw-r--r--drivers/of/unittest.c26
-rw-r--r--drivers/pci/controller/dwc/pcie-designware.c8
-rw-r--r--drivers/pci/controller/dwc/pcie-designware.h3
-rw-r--r--drivers/pci/controller/pci-hyperv.c39
-rw-r--r--drivers/pci/controller/pci-mvebu.c52
-rw-r--r--drivers/pci/controller/pcie-cadence.c4
-rw-r--r--drivers/pci/hotplug/acpiphp_glue.c11
-rw-r--r--drivers/pci/hotplug/pciehp_hpc.c18
-rw-r--r--drivers/pci/pci.c30
-rw-r--r--drivers/pci/probe.c5
-rw-r--r--drivers/pci/quirks.c6
-rw-r--r--drivers/pci/switch/switchtec.c4
-rw-r--r--drivers/perf/arm_pmu.c8
-rw-r--r--drivers/pinctrl/cirrus/pinctrl-madera-core.c2
-rw-r--r--drivers/pinctrl/intel/pinctrl-cannonlake.c35
-rw-r--r--drivers/pinctrl/intel/pinctrl-intel.c143
-rw-r--r--drivers/pinctrl/pinctrl-amd.c33
-rw-r--r--drivers/pinctrl/pinctrl-ingenic.c4
-rw-r--r--drivers/pinctrl/pinctrl-mcp23s08.c13
-rw-r--r--drivers/pinctrl/qcom/pinctrl-msm.c24
-rw-r--r--drivers/platform/chrome/cros_ec_proto.c2
-rw-r--r--drivers/platform/x86/alienware-wmi.c1
-rw-r--r--drivers/platform/x86/dell-smbios-wmi.c1
-rw-r--r--drivers/platform/x86/intel_cht_int33fe.c24
-rw-r--r--drivers/regulator/bd71837-regulator.c19
-rw-r--r--drivers/regulator/core.c4
-rw-r--r--drivers/regulator/of_regulator.c2
-rw-r--r--drivers/s390/char/sclp_early_core.c11
-rw-r--r--drivers/s390/cio/vfio_ccw_cp.c2
-rw-r--r--drivers/s390/cio/vfio_ccw_drv.c24
-rw-r--r--drivers/s390/cio/vfio_ccw_fsm.c6
-rw-r--r--drivers/s390/cio/vfio_ccw_ops.c4
-rw-r--r--drivers/s390/cio/vfio_ccw_private.h2
-rw-r--r--drivers/s390/crypto/ap_bus.c86
-rw-r--r--drivers/s390/net/qeth_core_main.c13
-rw-r--r--drivers/s390/net/qeth_core_mpc.c33
-rw-r--r--drivers/s390/net/qeth_core_mpc.h4
-rw-r--r--drivers/s390/net/qeth_l2_main.c2
-rw-r--r--drivers/s390/net/qeth_l3_main.c2
-rw-r--r--drivers/sbus/char/openprom.c11
-rw-r--r--drivers/sbus/char/oradax.c3
-rw-r--r--drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c5
-rw-r--r--drivers/scsi/ipr.c106
-rw-r--r--drivers/scsi/ipr.h1
-rw-r--r--drivers/scsi/lpfc/lpfc_attr.c15
-rw-r--r--drivers/scsi/lpfc/lpfc_debugfs.c10
-rw-r--r--drivers/scsi/lpfc/lpfc_nvme.c11
-rw-r--r--drivers/scsi/qedi/qedi.h7
-rw-r--r--drivers/scsi/qedi/qedi_main.c29
-rw-r--r--drivers/scsi/qla2xxx/qla_target.h4
-rw-r--r--drivers/scsi/sd.c6
-rw-r--r--drivers/scsi/ufs/ufshcd.c7
-rw-r--r--drivers/soc/fsl/qbman/bman_ccsr.c11
-rw-r--r--drivers/soc/fsl/qbman/qman.c3
-rw-r--r--drivers/soc/fsl/qbman/qman_ccsr.c11
-rw-r--r--drivers/soc/fsl/qbman/qman_portal.c8
-rw-r--r--drivers/soc/fsl/qe/ucc.c2
-rw-r--r--drivers/soundwire/stream.c23
-rw-r--r--drivers/spi/spi-fsl-dspi.c6
-rw-r--r--drivers/spi/spi-gpio.c4
-rw-r--r--drivers/spi/spi-rspi.c34
-rw-r--r--drivers/spi/spi-sh-msiof.c28
-rw-r--r--drivers/spi/spi-tegra20-slink.c31
-rw-r--r--drivers/spi/spi.c13
-rw-r--r--drivers/staging/erofs/Kconfig2
-rw-r--r--drivers/staging/erofs/super.c4
-rw-r--r--drivers/staging/fbtft/TODO4
-rw-r--r--drivers/staging/gasket/TODO13
-rw-r--r--drivers/staging/media/mt9t031/Kconfig6
-rw-r--r--drivers/staging/vboxvideo/vbox_drv.c7
-rw-r--r--drivers/staging/vboxvideo/vbox_mode.c5
-rw-r--r--drivers/staging/wilc1000/Makefile3
-rw-r--r--drivers/staging/wilc1000/linux_wlan.c6
-rw-r--r--drivers/staging/wilc1000/wilc_debugfs.c7
-rw-r--r--drivers/staging/wilc1000/wilc_wlan.c6
-rw-r--r--drivers/staging/wilc1000/wilc_wlan_if.h2
-rw-r--r--drivers/target/iscsi/iscsi_target.c31
-rw-r--r--drivers/target/iscsi/iscsi_target_auth.c45
-rw-r--r--drivers/target/iscsi/iscsi_target_login.c149
-rw-r--r--drivers/target/iscsi/iscsi_target_login.h2
-rw-r--r--drivers/thunderbolt/icm.c49
-rw-r--r--drivers/thunderbolt/nhi.c2
-rw-r--r--drivers/tty/hvc/hvc_console.c38
-rw-r--r--drivers/tty/serial/8250/8250_dw.c4
-rw-r--r--drivers/tty/serial/cpm_uart/cpm_uart_core.c10
-rw-r--r--drivers/tty/serial/fsl_lpuart.c3
-rw-r--r--drivers/tty/serial/imx.c8
-rw-r--r--drivers/tty/serial/mvebu-uart.c1
-rw-r--r--drivers/tty/serial/qcom_geni_serial.c4
-rw-r--r--drivers/tty/serial/sh-sci.c56
-rw-r--r--drivers/tty/tty_io.c11
-rw-r--r--drivers/tty/vt/vt_ioctl.c4
-rw-r--r--drivers/usb/class/cdc-acm.c79
-rw-r--r--drivers/usb/class/cdc-acm.h1
-rw-r--r--drivers/usb/common/common.c25
-rw-r--r--drivers/usb/common/roles.c15
-rw-r--r--drivers/usb/core/devio.c24
-rw-r--r--drivers/usb/core/driver.c28
-rw-r--r--drivers/usb/core/hcd-pci.c2
-rw-r--r--drivers/usb/core/message.c11
-rw-r--r--drivers/usb/core/of.c26
-rw-r--r--drivers/usb/core/quirks.c10
-rw-r--r--drivers/usb/core/usb.c2
-rw-r--r--drivers/usb/dwc2/platform.c4
-rw-r--r--drivers/usb/dwc3/dwc3-of-simple.c10
-rw-r--r--drivers/usb/dwc3/dwc3-pci.c4
-rw-r--r--drivers/usb/dwc3/gadget.c1
-rw-r--r--drivers/usb/gadget/udc/fotg210-udc.c15
-rw-r--r--drivers/usb/gadget/udc/net2280.c16
-rw-r--r--drivers/usb/gadget/udc/renesas_usb3.c5
-rw-r--r--drivers/usb/host/u132-hcd.c2
-rw-r--r--drivers/usb/host/xhci-mem.c4
-rw-r--r--drivers/usb/host/xhci-mtk.c4
-rw-r--r--drivers/usb/host/xhci-pci.c2
-rw-r--r--drivers/usb/host/xhci-plat.c27
-rw-r--r--drivers/usb/host/xhci.c30
-rw-r--r--drivers/usb/misc/uss720.c4
-rw-r--r--drivers/usb/misc/yurex.c8
-rw-r--r--drivers/usb/mtu3/mtu3_core.c6
-rw-r--r--drivers/usb/mtu3/mtu3_hw_regs.h1
-rw-r--r--drivers/usb/musb/musb_dsps.c12
-rw-r--r--drivers/usb/serial/io_ti.h2
-rw-r--r--drivers/usb/serial/option.c15
-rw-r--r--drivers/usb/serial/ti_usb_3410_5052.c2
-rw-r--r--drivers/usb/serial/usb-serial-simple.c3
-rw-r--r--drivers/usb/storage/scsiglue.c9
-rw-r--r--drivers/usb/storage/uas.c21
-rw-r--r--drivers/usb/storage/unusual_devs.h7
-rw-r--r--drivers/usb/typec/bus.c7
-rw-r--r--drivers/usb/typec/class.c1
-rw-r--r--drivers/usb/typec/mux.c17
-rw-r--r--drivers/video/fbdev/aty/atyfb.h3
-rw-r--r--drivers/video/fbdev/aty/atyfb_base.c7
-rw-r--r--drivers/video/fbdev/aty/mach64_ct.c10
-rw-r--r--drivers/video/fbdev/efifb.c6
-rw-r--r--drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c5
-rw-r--r--drivers/video/fbdev/pxa168fb.c6
-rw-r--r--drivers/video/fbdev/stifb.c2
-rw-r--r--drivers/xen/Kconfig10
-rw-r--r--drivers/xen/cpu_hotplug.c15
-rw-r--r--drivers/xen/events/events_base.c2
-rw-r--r--drivers/xen/gntdev.c26
-rw-r--r--drivers/xen/grant-table.c27
-rw-r--r--drivers/xen/manage.c6
-rw-r--r--drivers/xen/mem-reservation.c4
-rw-r--r--drivers/xen/xen-balloon.c3
-rw-r--r--fs/afs/cell.c17
-rw-r--r--fs/afs/dynroot.c2
-rw-r--r--fs/afs/internal.h4
-rw-r--r--fs/afs/main.c2
-rw-r--r--fs/afs/proc.c7
-rw-r--r--fs/afs/server.c2
-rw-r--r--fs/cifs/Kconfig1
-rw-r--r--fs/cifs/cifsglob.h1
-rw-r--r--fs/cifs/cifssmb.c11
-rw-r--r--fs/cifs/connect.c13
-rw-r--r--fs/cifs/misc.c8
-rw-r--r--fs/cifs/readdir.c11
-rw-r--r--fs/cifs/smb2ops.c2
-rw-r--r--fs/cifs/smb2pdu.c29
-rw-r--r--fs/cifs/transport.c21
-rw-r--r--fs/dax.c27
-rw-r--r--fs/ext2/inode.c2
-rw-r--r--fs/ext4/dir.c20
-rw-r--r--fs/ext4/ext4.h20
-rw-r--r--fs/ext4/inline.c4
-rw-r--r--fs/ext4/inode.c20
-rw-r--r--fs/ext4/mmp.c1
-rw-r--r--fs/ext4/namei.c6
-rw-r--r--fs/ext4/resize.c23
-rw-r--r--fs/ext4/super.c4
-rw-r--r--fs/fat/fatent.c1
-rw-r--r--fs/gfs2/bmap.c2
-rw-r--r--fs/ioctl.c2
-rw-r--r--fs/iomap.c2
-rw-r--r--fs/nfs/nfs4proc.c31
-rw-r--r--fs/nfs/nfs4state.c2
-rw-r--r--fs/nfs/nfs4trace.h4
-rw-r--r--fs/nfs/pnfs.c26
-rw-r--r--fs/nfsd/vfs.c3
-rw-r--r--fs/ocfs2/buffer_head_io.c1
-rw-r--r--fs/ocfs2/dlm/dlmmaster.c4
-rw-r--r--fs/ocfs2/dlmglue.c2
-rw-r--r--fs/ocfs2/refcounttree.c16
-rw-r--r--fs/overlayfs/copy_up.c2
-rw-r--r--fs/overlayfs/file.c25
-rw-r--r--fs/overlayfs/inode.c10
-rw-r--r--fs/overlayfs/namei.c2
-rw-r--r--fs/overlayfs/overlayfs.h4
-rw-r--r--fs/overlayfs/super.c26
-rw-r--r--fs/overlayfs/util.c3
-rw-r--r--fs/proc/base.c14
-rw-r--r--fs/proc/kcore.c1
-rw-r--r--fs/pstore/ram.c29
-rw-r--r--fs/pstore/ram_core.c17
-rw-r--r--fs/read_write.c17
-rw-r--r--fs/ubifs/super.c11
-rw-r--r--fs/ubifs/xattr.c24
-rw-r--r--fs/xattr.c24
-rw-r--r--fs/xfs/libxfs/xfs_attr.c28
-rw-r--r--fs/xfs/libxfs/xfs_attr_remote.c10
-rw-r--r--fs/xfs/libxfs/xfs_bmap.c24
-rw-r--r--fs/xfs/libxfs/xfs_format.h2
-rw-r--r--fs/xfs/libxfs/xfs_inode_buf.c30
-rw-r--r--fs/xfs/scrub/alloc.c1
-rw-r--r--fs/xfs/scrub/inode.c4
-rw-r--r--fs/xfs/xfs_bmap_util.c20
-rw-r--r--fs/xfs/xfs_buf_item.c119
-rw-r--r--fs/xfs/xfs_buf_item.h1
-rw-r--r--fs/xfs/xfs_inode.c10
-rw-r--r--fs/xfs/xfs_iops.c12
-rw-r--r--fs/xfs/xfs_log_recover.c10
-rw-r--r--fs/xfs/xfs_reflink.c337
-rw-r--r--fs/xfs/xfs_trace.h1
-rw-r--r--fs/xfs/xfs_trans.c10
-rw-r--r--fs/xfs/xfs_trans_buf.c99
-rw-r--r--include/acpi/acconfig.h17
-rw-r--r--include/acpi/acexcep.h9
-rw-r--r--include/acpi/acpixf.h9
-rw-r--r--include/asm-generic/io.h3
-rw-r--r--include/asm-generic/vmlinux.lds.h6
-rw-r--r--include/drm/drm_client.h5
-rw-r--r--include/drm/drm_drv.h2
-rw-r--r--include/drm/drm_panel.h1
-rw-r--r--include/linux/blkdev.h2
-rw-r--r--include/linux/cgroup-defs.h1
-rw-r--r--include/linux/compiler-gcc.h14
-rw-r--r--include/linux/compiler_types.h8
-rw-r--r--include/linux/fpga/fpga-mgr.h20
-rw-r--r--include/linux/fs.h22
-rw-r--r--include/linux/genhd.h5
-rw-r--r--include/linux/gpio/driver.h7
-rw-r--r--include/linux/hid.h1
-rw-r--r--include/linux/hugetlb.h14
-rw-r--r--include/linux/kvm_host.h2
-rw-r--r--include/linux/mfd/da9063/pdata.h16
-rw-r--r--include/linux/mfd/rohm-bd718x7.h33
-rw-r--r--include/linux/mlx5/driver.h8
-rw-r--r--include/linux/mlx5/transobj.h2
-rw-r--r--include/linux/mm.h6
-rw-r--r--include/linux/mm_types.h2
-rw-r--r--include/linux/mm_types_task.h2
-rw-r--r--include/linux/mmzone.h10
-rw-r--r--include/linux/mod_devicetable.h1
-rw-r--r--include/linux/netdevice.h10
-rw-r--r--include/linux/netfilter.h2
-rw-r--r--include/linux/netpoll.h5
-rw-r--r--include/linux/pci.h3
-rw-r--r--include/linux/perf/arm_pmu.h1
-rw-r--r--include/linux/platform_device.h1
-rw-r--r--include/linux/regulator/machine.h6
-rw-r--r--include/linux/serial_sci.h1
-rw-r--r--include/linux/spi/spi-mem.h7
-rw-r--r--include/linux/stmmac.h1
-rw-r--r--include/linux/suspend.h2
-rw-r--r--include/linux/uio.h2
-rw-r--r--include/linux/vga_switcheroo.h3
-rw-r--r--include/linux/virtio_net.h18
-rw-r--r--include/linux/vm_event_item.h1
-rw-r--r--include/linux/vmacache.h5
-rw-r--r--include/media/v4l2-fh.h4
-rw-r--r--include/net/bonding.h7
-rw-r--r--include/net/cfg80211.h2
-rw-r--r--include/net/devlink.h12
-rw-r--r--include/net/inet_sock.h6
-rw-r--r--include/net/ip_fib.h1
-rw-r--r--include/net/netfilter/nf_conntrack_timeout.h2
-rw-r--r--include/net/netlink.h2
-rw-r--r--include/net/nfc/hci.h2
-rw-r--r--include/net/tls.h19
-rw-r--r--include/soc/fsl/bman.h8
-rw-r--r--include/soc/fsl/qman.h8
-rw-r--r--include/sound/hdaudio.h1
-rw-r--r--include/sound/soc-dapm.h1
-rw-r--r--include/trace/events/migrate.h27
-rw-r--r--include/trace/events/rxrpc.h5
-rw-r--r--include/uapi/asm-generic/hugetlb_encode.h2
-rw-r--r--include/uapi/linux/keyctl.h2
-rw-r--r--include/uapi/linux/kvm.h1
-rw-r--r--include/uapi/linux/memfd.h2
-rw-r--r--include/uapi/linux/mman.h2
-rw-r--r--include/uapi/linux/perf_event.h2
-rw-r--r--include/uapi/linux/shm.h2
-rw-r--r--include/uapi/linux/smc_diag.h25
-rw-r--r--include/uapi/linux/udp.h1
-rw-r--r--include/uapi/sound/skl-tplg-interface.h106
-rw-r--r--include/xen/mem-reservation.h7
-rw-r--r--ipc/shm.c2
-rw-r--r--kernel/bpf/btf.c2
-rw-r--r--kernel/bpf/local_storage.c5
-rw-r--r--kernel/bpf/sockmap.c91
-rw-r--r--kernel/bpf/verifier.c12
-rw-r--r--kernel/cgroup/cgroup.c25
-rw-r--r--kernel/dma/Kconfig3
-rw-r--r--kernel/events/core.c32
-rw-r--r--kernel/events/hw_breakpoint.c13
-rw-r--r--kernel/jump_label.c2
-rw-r--r--kernel/locking/lockdep.c1
-rw-r--r--kernel/locking/mutex.c3
-rw-r--r--kernel/locking/test-ww_mutex.c12
-rw-r--r--kernel/pid.c2
-rw-r--r--kernel/power/suspend.c6
-rw-r--r--kernel/printk/printk.c12
-rw-r--r--kernel/sched/core.c2
-rw-r--r--kernel/sched/deadline.c2
-rw-r--r--kernel/sched/debug.c6
-rw-r--r--kernel/sched/fair.c130
-rw-r--r--kernel/sched/sched.h3
-rw-r--r--kernel/sched/topology.c5
-rw-r--r--kernel/sys.c3
-rw-r--r--kernel/trace/ring_buffer.c2
-rw-r--r--lib/Makefile1
-rw-r--r--lib/bch.c17
-rw-r--r--lib/vsprintf.c2
-rw-r--r--lib/xz/xz_crc32.c1
-rw-r--r--lib/xz/xz_private.h4
-rw-r--r--mm/Kconfig1
-rw-r--r--mm/Makefile3
-rw-r--r--mm/debug.c4
-rw-r--r--mm/fadvise.c81
-rw-r--r--mm/gup_benchmark.c3
-rw-r--r--mm/huge_memory.c8
-rw-r--r--mm/hugetlb.c90
-rw-r--r--mm/madvise.c2
-rw-r--r--mm/migrate.c62
-rw-r--r--mm/mmap.c2
-rw-r--r--mm/page_alloc.c12
-rw-r--r--mm/percpu.c1
-rw-r--r--mm/readahead.c45
-rw-r--r--mm/rmap.c42
-rw-r--r--mm/shmem.c2
-rw-r--r--mm/vmacache.c38
-rw-r--r--mm/vmscan.c18
-rw-r--r--mm/vmstat.c4
-rw-r--r--net/batman-adv/bat_v_elp.c10
-rw-r--r--net/batman-adv/bridge_loop_avoidance.c10
-rw-r--r--net/batman-adv/gateway_client.c11
-rw-r--r--net/batman-adv/main.h2
-rw-r--r--net/batman-adv/network-coding.c27
-rw-r--r--net/batman-adv/soft-interface.c25
-rw-r--r--net/batman-adv/sysfs.c30
-rw-r--r--net/batman-adv/translation-table.c6
-rw-r--r--net/batman-adv/tvlv.c8
-rw-r--r--net/bluetooth/mgmt.c7
-rw-r--r--net/bluetooth/smp.c45
-rw-r--r--net/bluetooth/smp.h3
-rw-r--r--net/bpfilter/bpfilter_kern.c4
-rw-r--r--net/bridge/br_netfilter_hooks.c3
-rw-r--r--net/core/dev.c28
-rw-r--r--net/core/devlink.c46
-rw-r--r--net/core/ethtool.c10
-rw-r--r--net/core/filter.c3
-rw-r--r--net/core/neighbour.c13
-rw-r--r--net/core/netpoll.c41
-rw-r--r--net/core/rtnetlink.c43
-rw-r--r--net/core/skbuff.c15
-rw-r--r--net/dccp/input.c4
-rw-r--r--net/dccp/ipv4.c4
-rw-r--r--net/ipv4/af_inet.c1
-rw-r--r--net/ipv4/fib_frontend.c12
-rw-r--r--net/ipv4/fib_semantics.c50
-rw-r--r--net/ipv4/inet_connection_sock.c5
-rw-r--r--net/ipv4/ip_fragment.c1
-rw-r--r--net/ipv4/ip_gre.c5
-rw-r--r--net/ipv4/ip_sockglue.c3
-rw-r--r--net/ipv4/ip_tunnel.c9
-rw-r--r--net/ipv4/netfilter/Kconfig8
-rw-r--r--net/ipv4/route.c7
-rw-r--r--net/ipv4/sysctl_net_ipv4.c6
-rw-r--r--net/ipv4/tcp.c2
-rw-r--r--net/ipv4/tcp_input.c8
-rw-r--r--net/ipv4/tcp_ipv4.c4
-rw-r--r--net/ipv4/udp.c51
-rw-r--r--net/ipv4/xfrm4_input.c1
-rw-r--r--net/ipv4/xfrm4_mode_transport.c4
-rw-r--r--net/ipv6/addrconf.c4
-rw-r--r--net/ipv6/ip6_fib.c2
-rw-r--r--net/ipv6/ip6_offload.c1
-rw-r--r--net/ipv6/ip6_output.c6
-rw-r--r--net/ipv6/ip6_tunnel.c13
-rw-r--r--net/ipv6/netfilter/nf_conntrack_reasm.c1
-rw-r--r--net/ipv6/raw.c29
-rw-r--r--net/ipv6/route.c58
-rw-r--r--net/ipv6/udp.c65
-rw-r--r--net/ipv6/xfrm6_input.c1
-rw-r--r--net/ipv6/xfrm6_mode_transport.c4
-rw-r--r--net/ipv6/xfrm6_output.c2
-rw-r--r--net/iucv/af_iucv.c38
-rw-r--r--net/iucv/iucv.c2
-rw-r--r--net/mac80211/cfg.c2
-rw-r--r--net/mac80211/iface.c3
-rw-r--r--net/mac80211/mesh.h3
-rw-r--r--net/mac80211/mesh_hwmp.c9
-rw-r--r--net/mac80211/status.c11
-rw-r--r--net/mac80211/tdls.c8
-rw-r--r--net/mac80211/tx.c6
-rw-r--r--net/mpls/af_mpls.c6
-rw-r--r--net/netfilter/Kconfig12
-rw-r--r--net/netfilter/nf_conntrack_proto.c26
-rw-r--r--net/netfilter/nf_conntrack_proto_dccp.c19
-rw-r--r--net/netfilter/nf_conntrack_proto_generic.c8
-rw-r--r--net/netfilter/nf_conntrack_proto_gre.c8
-rw-r--r--net/netfilter/nf_conntrack_proto_icmp.c8
-rw-r--r--net/netfilter/nf_conntrack_proto_icmpv6.c8
-rw-r--r--net/netfilter/nf_conntrack_proto_sctp.c21
-rw-r--r--net/netfilter/nf_conntrack_proto_tcp.c23
-rw-r--r--net/netfilter/nf_conntrack_proto_udp.c21
-rw-r--r--net/netfilter/nf_tables_api.c1
-rw-r--r--net/netfilter/nfnetlink_cttimeout.c6
-rw-r--r--net/netfilter/nfnetlink_queue.c1
-rw-r--r--net/netfilter/nft_ct.c59
-rw-r--r--net/netfilter/nft_osf.c2
-rw-r--r--net/netfilter/nft_set_rbtree.c28
-rw-r--r--net/netfilter/xt_CHECKSUM.c22
-rw-r--r--net/netfilter/xt_cluster.c14
-rw-r--r--net/netfilter/xt_hashlimit.c18
-rw-r--r--net/netfilter/xt_socket.c4
-rw-r--r--net/netlabel/netlabel_unlabeled.c3
-rw-r--r--net/nfc/hci/core.c10
-rw-r--r--net/openvswitch/conntrack.c10
-rw-r--r--net/packet/af_packet.c11
-rw-r--r--net/rds/bind.c5
-rw-r--r--net/rds/ib.h2
-rw-r--r--net/rds/send.c13
-rw-r--r--net/rxrpc/ar-internal.h55
-rw-r--r--net/rxrpc/call_accept.c68
-rw-r--r--net/rxrpc/call_object.c7
-rw-r--r--net/rxrpc/conn_client.c14
-rw-r--r--net/rxrpc/conn_event.c26
-rw-r--r--net/rxrpc/conn_object.c14
-rw-r--r--net/rxrpc/input.c329
-rw-r--r--net/rxrpc/local_object.c62
-rw-r--r--net/rxrpc/output.c54
-rw-r--r--net/rxrpc/peer_event.c51
-rw-r--r--net/rxrpc/peer_object.c77
-rw-r--r--net/rxrpc/protocol.h15
-rw-r--r--net/sched/act_ipt.c2
-rw-r--r--net/sched/act_sample.c2
-rw-r--r--net/sched/act_tunnel_key.c28
-rw-r--r--net/sched/cls_api.c2
-rw-r--r--net/sched/cls_u32.c10
-rw-r--r--net/sched/sch_api.c24
-rw-r--r--net/sched/sch_cake.c2
-rw-r--r--net/sctp/outqueue.c2
-rw-r--r--net/sctp/transport.c12
-rw-r--r--net/smc/af_smc.c26
-rw-r--r--net/smc/smc_clc.c14
-rw-r--r--net/smc/smc_close.c14
-rw-r--r--net/smc/smc_pnet.c2
-rw-r--r--net/socket.c22
-rw-r--r--net/tipc/bearer.c12
-rw-r--r--net/tipc/link.c68
-rw-r--r--net/tipc/link.h3
-rw-r--r--net/tipc/netlink_compat.c5
-rw-r--r--net/tipc/node.c14
-rw-r--r--net/tipc/socket.c36
-rw-r--r--net/tipc/socket.h1
-rw-r--r--net/tls/tls_device.c6
-rw-r--r--net/tls/tls_device_fallback.c2
-rw-r--r--net/tls/tls_main.c22
-rw-r--r--net/tls/tls_sw.c27
-rw-r--r--net/wireless/nl80211.c20
-rw-r--r--net/wireless/reg.c8
-rw-r--r--net/wireless/scan.c58
-rw-r--r--net/wireless/wext-compat.c14
-rw-r--r--net/xfrm/xfrm_input.c1
-rw-r--r--net/xfrm/xfrm_output.c4
-rw-r--r--net/xfrm/xfrm_policy.c4
-rw-r--r--net/xfrm/xfrm_user.c15
-rw-r--r--samples/Kconfig1
-rw-r--r--scripts/Makefile.build2
-rw-r--r--scripts/subarch.include13
-rw-r--r--security/Kconfig2
-rw-r--r--security/keys/dh.c2
-rw-r--r--sound/firewire/bebob/bebob.c2
-rw-r--r--sound/firewire/bebob/bebob_maudio.c28
-rw-r--r--sound/firewire/digi00x/digi00x.c1
-rw-r--r--sound/firewire/fireface/ff-protocol-ff400.c9
-rw-r--r--sound/firewire/fireworks/fireworks.c2
-rw-r--r--sound/firewire/oxfw/oxfw.c10
-rw-r--r--sound/firewire/tascam/tascam.c1
-rw-r--r--sound/hda/hdac_controller.c15
-rw-r--r--sound/hda/hdac_i915.c4
-rw-r--r--sound/pci/emu10k1/emufx.c2
-rw-r--r--sound/pci/hda/hda_intel.c86
-rw-r--r--sound/pci/hda/hda_intel.h1
-rw-r--r--sound/pci/hda/patch_realtek.c1
-rw-r--r--sound/soc/amd/acp-pcm-dma.c21
-rw-r--r--sound/soc/codecs/cs4265.c4
-rw-r--r--sound/soc/codecs/max98373.c3
-rw-r--r--sound/soc/codecs/rt5514.c8
-rw-r--r--sound/soc/codecs/rt5682.c8
-rw-r--r--sound/soc/codecs/sigmadsp.c3
-rw-r--r--sound/soc/codecs/tas6424.c12
-rw-r--r--sound/soc/codecs/wm8804-i2c.c15
-rw-r--r--sound/soc/codecs/wm9712.c2
-rw-r--r--sound/soc/intel/boards/bytcr_rt5640.c26
-rw-r--r--sound/soc/intel/skylake/skl.c2
-rw-r--r--sound/soc/qcom/qdsp6/q6routing.c4
-rw-r--r--sound/soc/sh/rcar/adg.c5
-rw-r--r--sound/soc/sh/rcar/core.c21
-rw-r--r--sound/soc/sh/rcar/dma.c4
-rw-r--r--sound/soc/sh/rcar/rsnd.h7
-rw-r--r--sound/soc/sh/rcar/ssi.c16
-rw-r--r--sound/soc/soc-core.c4
-rw-r--r--sound/soc/soc-dapm.c4
-rw-r--r--tools/arch/arm/include/uapi/asm/kvm.h13
-rw-r--r--tools/arch/arm64/include/uapi/asm/kvm.h13
-rw-r--r--tools/arch/s390/include/uapi/asm/kvm.h5
-rw-r--r--tools/arch/x86/include/uapi/asm/kvm.h37
-rw-r--r--tools/hv/hv_fcopy_daemon.c1
-rw-r--r--tools/hv/hv_kvp_daemon.c2
-rw-r--r--tools/include/linux/lockdep.h3
-rw-r--r--tools/include/linux/nmi.h0
-rw-r--r--tools/include/tools/libc_compat.h2
-rw-r--r--tools/include/uapi/asm-generic/unistd.h4
-rw-r--r--tools/include/uapi/drm/drm.h9
-rw-r--r--tools/include/uapi/linux/if_link.h17
-rw-r--r--tools/include/uapi/linux/kvm.h6
-rw-r--r--tools/include/uapi/linux/perf_event.h2
-rw-r--r--tools/include/uapi/linux/vhost.h18
-rwxr-xr-xtools/kvm/kvm_stat/kvm_stat2
-rw-r--r--tools/lib/bpf/Build2
-rw-r--r--tools/lib/bpf/libbpf.c20
-rw-r--r--tools/lib/bpf/str_error.c18
-rw-r--r--tools/lib/bpf/str_error.h6
-rw-r--r--tools/perf/Documentation/Makefile2
-rw-r--r--tools/perf/Makefile.perf14
-rw-r--r--tools/perf/arch/arm64/Makefile5
-rwxr-xr-xtools/perf/arch/arm64/entry/syscalls/mksyscalltbl6
-rw-r--r--tools/perf/arch/powerpc/util/sym-handling.c4
-rw-r--r--tools/perf/arch/x86/include/arch-tests.h1
-rw-r--r--tools/perf/arch/x86/tests/Build1
-rw-r--r--tools/perf/arch/x86/tests/arch-tests.c6
-rw-r--r--tools/perf/arch/x86/tests/bp-modify.c213
-rw-r--r--tools/perf/scripts/python/export-to-postgresql.py9
-rw-r--r--tools/perf/scripts/python/export-to-sqlite.py6
-rw-r--r--tools/perf/util/annotate.c32
-rw-r--r--tools/perf/util/annotate.h1
-rw-r--r--tools/perf/util/evsel.c5
-rw-r--r--tools/perf/util/machine.c8
-rw-r--r--tools/perf/util/map.c11
-rw-r--r--tools/perf/util/setup.py2
-rw-r--r--tools/perf/util/trace-event-info.c2
-rw-r--r--tools/perf/util/trace-event-parse.c7
-rw-r--r--tools/testing/selftests/android/Makefile2
-rw-r--r--tools/testing/selftests/android/config (renamed from tools/testing/selftests/android/ion/config)0
-rw-r--r--tools/testing/selftests/android/ion/Makefile2
-rw-r--r--tools/testing/selftests/bpf/test_maps.c10
-rw-r--r--tools/testing/selftests/cgroup/.gitignore1
-rw-r--r--tools/testing/selftests/cgroup/cgroup_util.c38
-rw-r--r--tools/testing/selftests/cgroup/cgroup_util.h1
-rw-r--r--tools/testing/selftests/cgroup/test_memcontrol.c205
-rw-r--r--tools/testing/selftests/efivarfs/config1
-rw-r--r--tools/testing/selftests/futex/functional/Makefile1
-rw-r--r--tools/testing/selftests/gpio/Makefile7
-rw-r--r--tools/testing/selftests/kselftest.h1
-rw-r--r--tools/testing/selftests/kvm/.gitignore1
-rw-r--r--tools/testing/selftests/kvm/Makefile12
-rw-r--r--tools/testing/selftests/kvm/include/kvm_util.h4
-rw-r--r--tools/testing/selftests/kvm/lib/kvm_util.c89
-rw-r--r--tools/testing/selftests/kvm/platform_info_test.c110
-rw-r--r--tools/testing/selftests/lib.mk12
-rw-r--r--tools/testing/selftests/memory-hotplug/config1
-rw-r--r--tools/testing/selftests/net/Makefile1
-rwxr-xr-xtools/testing/selftests/net/pmtu.sh4
-rwxr-xr-xtools/testing/selftests/net/rtnetlink.sh2
-rw-r--r--tools/testing/selftests/net/tls.c49
-rwxr-xr-xtools/testing/selftests/net/udpgso_bench.sh2
-rw-r--r--tools/testing/selftests/networking/timestamping/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/alignment/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/benchmarks/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/cache_shape/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/copyloops/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/dscr/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/math/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/mm/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/pmu/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/pmu/ebb/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/primitives/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/ptrace/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/signal/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/stringloops/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/switch_endian/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/syscalls/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/tm/Makefile1
-rw-r--r--tools/testing/selftests/powerpc/vphn/Makefile1
-rw-r--r--tools/testing/selftests/rseq/param_test.c19
-rw-r--r--tools/testing/selftests/vm/Makefile4
-rw-r--r--tools/testing/selftests/x86/test_vdso.c172
1150 files changed, 12024 insertions, 6811 deletions
diff --git a/Documentation/ABI/stable/sysfs-devices-system-xen_memory b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
index caa311d59ac1..6d83f95a8a8e 100644
--- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
+++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
@@ -75,3 +75,12 @@ Contact: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
75Description: 75Description:
76 Amount (in KiB) of low (or normal) memory in the 76 Amount (in KiB) of low (or normal) memory in the
77 balloon. 77 balloon.
78
79What: /sys/devices/system/xen_memory/xen_memory0/scrub_pages
80Date: September 2018
81KernelVersion: 4.20
82Contact: xen-devel@lists.xenproject.org
83Description:
84 Control scrubbing pages before returning them to Xen for others domains
85 use. Can be set with xen_scrub_pages cmdline
86 parameter. Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 64a3bf54b974..92eb1f42240d 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -5000,6 +5000,12 @@
5000 Disables the PV optimizations forcing the HVM guest to 5000 Disables the PV optimizations forcing the HVM guest to
5001 run as generic HVM guest with no PV drivers. 5001 run as generic HVM guest with no PV drivers.
5002 5002
5003 xen_scrub_pages= [XEN]
5004 Boolean option to control scrubbing pages before giving them back
5005 to Xen, for use by other domains. Can be also changed at runtime
5006 with /sys/devices/system/xen_memory/xen_memory0/scrub_pages.
5007 Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
5008
5003 xirc2ps_cs= [NET,PCMCIA] 5009 xirc2ps_cs= [NET,PCMCIA]
5004 Format: 5010 Format:
5005 <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]] 5011 <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]
diff --git a/Documentation/device-mapper/dm-raid.txt b/Documentation/device-mapper/dm-raid.txt
index 390c145f01d7..52a719b49afd 100644
--- a/Documentation/device-mapper/dm-raid.txt
+++ b/Documentation/device-mapper/dm-raid.txt
@@ -348,3 +348,7 @@ Version History
3481.13.1 Fix deadlock caused by early md_stop_writes(). Also fix size an 3481.13.1 Fix deadlock caused by early md_stop_writes(). Also fix size an
349 state races. 349 state races.
3501.13.2 Fix raid redundancy validation and avoid keeping raid set frozen 3501.13.2 Fix raid redundancy validation and avoid keeping raid set frozen
3511.14.0 Fix reshape race on small devices. Fix stripe adding reshape
352 deadlock/potential data corruption. Update superblock when
353 specific devices are requested via rebuild. Fix RAID leg
354 rebuild errors.
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
index 996ce84352cb..7cccc49b6bea 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.txt
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -1,4 +1,4 @@
1Device-Tree bindings for input/gpio_keys.c keyboard driver 1Device-Tree bindings for input/keyboard/gpio_keys.c keyboard driver
2 2
3Required properties: 3Required properties:
4 - compatible = "gpio-keys"; 4 - compatible = "gpio-keys";
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 457d5ae16f23..3e17ac1d5d58 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -10,6 +10,7 @@ Required properties:
10 Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on 10 Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
11 the Cadence GEM, or the generic form: "cdns,gem". 11 the Cadence GEM, or the generic form: "cdns,gem".
12 Use "atmel,sama5d2-gem" for the GEM IP (10/100) available on Atmel sama5d2 SoCs. 12 Use "atmel,sama5d2-gem" for the GEM IP (10/100) available on Atmel sama5d2 SoCs.
13 Use "atmel,sama5d3-macb" for the 10/100Mbit IP available on Atmel sama5d3 SoCs.
13 Use "atmel,sama5d3-gem" for the Gigabit IP available on Atmel sama5d3 SoCs. 14 Use "atmel,sama5d3-gem" for the Gigabit IP available on Atmel sama5d3 SoCs.
14 Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs. 15 Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs.
15 Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC. 16 Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC.
diff --git a/Documentation/driver-api/fpga/fpga-mgr.rst b/Documentation/driver-api/fpga/fpga-mgr.rst
index 4b3825da48d9..82b6dbbd31cd 100644
--- a/Documentation/driver-api/fpga/fpga-mgr.rst
+++ b/Documentation/driver-api/fpga/fpga-mgr.rst
@@ -184,6 +184,11 @@ API for implementing a new FPGA Manager driver
184API for programming an FPGA 184API for programming an FPGA
185--------------------------- 185---------------------------
186 186
187FPGA Manager flags
188
189.. kernel-doc:: include/linux/fpga/fpga-mgr.h
190 :doc: FPGA Manager flags
191
187.. kernel-doc:: include/linux/fpga/fpga-mgr.h 192.. kernel-doc:: include/linux/fpga/fpga-mgr.h
188 :functions: fpga_image_info 193 :functions: fpga_image_info
189 194
diff --git a/Documentation/fb/uvesafb.txt b/Documentation/fb/uvesafb.txt
index f6362d88763b..aa924196c366 100644
--- a/Documentation/fb/uvesafb.txt
+++ b/Documentation/fb/uvesafb.txt
@@ -15,7 +15,8 @@ than x86. Check the v86d documentation for a list of currently supported
15arches. 15arches.
16 16
17v86d source code can be downloaded from the following website: 17v86d source code can be downloaded from the following website:
18 http://dev.gentoo.org/~spock/projects/uvesafb 18
19 https://github.com/mjanusz/v86d
19 20
20Please refer to the v86d documentation for detailed configuration and 21Please refer to the v86d documentation for detailed configuration and
21installation instructions. 22installation instructions.
@@ -177,7 +178,7 @@ from the Video BIOS if you set pixclock to 0 in fb_var_screeninfo.
177 178
178-- 179--
179 Michal Januszewski <spock@gentoo.org> 180 Michal Januszewski <spock@gentoo.org>
180 Last updated: 2009-03-30 181 Last updated: 2017-10-10
181 182
182 Documentation of the uvesafb options is loosely based on vesafb.txt. 183 Documentation of the uvesafb options is loosely based on vesafb.txt.
183 184
diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
index 4b2084d0f1fb..a6c6a8af48a2 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -848,7 +848,7 @@ struct file_operations
848---------------------- 848----------------------
849 849
850This describes how the VFS can manipulate an open file. As of kernel 850This describes how the VFS can manipulate an open file. As of kernel
8514.1, the following members are defined: 8514.18, the following members are defined:
852 852
853struct file_operations { 853struct file_operations {
854 struct module *owner; 854 struct module *owner;
@@ -858,11 +858,11 @@ struct file_operations {
858 ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); 858 ssize_t (*read_iter) (struct kiocb *, struct iov_iter *);
859 ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); 859 ssize_t (*write_iter) (struct kiocb *, struct iov_iter *);
860 int (*iterate) (struct file *, struct dir_context *); 860 int (*iterate) (struct file *, struct dir_context *);
861 int (*iterate_shared) (struct file *, struct dir_context *);
861 __poll_t (*poll) (struct file *, struct poll_table_struct *); 862 __poll_t (*poll) (struct file *, struct poll_table_struct *);
862 long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long); 863 long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long);
863 long (*compat_ioctl) (struct file *, unsigned int, unsigned long); 864 long (*compat_ioctl) (struct file *, unsigned int, unsigned long);
864 int (*mmap) (struct file *, struct vm_area_struct *); 865 int (*mmap) (struct file *, struct vm_area_struct *);
865 int (*mremap)(struct file *, struct vm_area_struct *);
866 int (*open) (struct inode *, struct file *); 866 int (*open) (struct inode *, struct file *);
867 int (*flush) (struct file *, fl_owner_t id); 867 int (*flush) (struct file *, fl_owner_t id);
868 int (*release) (struct inode *, struct file *); 868 int (*release) (struct inode *, struct file *);
@@ -882,6 +882,10 @@ struct file_operations {
882#ifndef CONFIG_MMU 882#ifndef CONFIG_MMU
883 unsigned (*mmap_capabilities)(struct file *); 883 unsigned (*mmap_capabilities)(struct file *);
884#endif 884#endif
885 ssize_t (*copy_file_range)(struct file *, loff_t, struct file *, loff_t, size_t, unsigned int);
886 int (*clone_file_range)(struct file *, loff_t, struct file *, loff_t, u64);
887 int (*dedupe_file_range)(struct file *, loff_t, struct file *, loff_t, u64);
888 int (*fadvise)(struct file *, loff_t, loff_t, int);
885}; 889};
886 890
887Again, all methods are called without any locks being held, unless 891Again, all methods are called without any locks being held, unless
@@ -899,6 +903,9 @@ otherwise noted.
899 903
900 iterate: called when the VFS needs to read the directory contents 904 iterate: called when the VFS needs to read the directory contents
901 905
906 iterate_shared: called when the VFS needs to read the directory contents
907 when filesystem supports concurrent dir iterators
908
902 poll: called by the VFS when a process wants to check if there is 909 poll: called by the VFS when a process wants to check if there is
903 activity on this file and (optionally) go to sleep until there 910 activity on this file and (optionally) go to sleep until there
904 is activity. Called by the select(2) and poll(2) system calls 911 is activity. Called by the select(2) and poll(2) system calls
@@ -951,6 +958,16 @@ otherwise noted.
951 958
952 fallocate: called by the VFS to preallocate blocks or punch a hole. 959 fallocate: called by the VFS to preallocate blocks or punch a hole.
953 960
961 copy_file_range: called by the copy_file_range(2) system call.
962
963 clone_file_range: called by the ioctl(2) system call for FICLONERANGE and
964 FICLONE commands.
965
966 dedupe_file_range: called by the ioctl(2) system call for FIDEDUPERANGE
967 command.
968
969 fadvise: possibly called by the fadvise64() system call.
970
954Note that the file operations are implemented by the specific 971Note that the file operations are implemented by the specific
955filesystem in which the inode resides. When opening a device node 972filesystem in which the inode resides. When opening a device node
956(character or block special) most filesystems will call special 973(character or block special) most filesystems will call special
diff --git a/Documentation/media/uapi/dvb/video_function_calls.rst b/Documentation/media/uapi/dvb/video_function_calls.rst
index 3f4f6c9ffad7..a4222b6cd2d3 100644
--- a/Documentation/media/uapi/dvb/video_function_calls.rst
+++ b/Documentation/media/uapi/dvb/video_function_calls.rst
@@ -33,4 +33,3 @@ Video Function Calls
33 video-clear-buffer 33 video-clear-buffer
34 video-set-streamtype 34 video-set-streamtype
35 video-set-format 35 video-set-format
36 video-set-attributes
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 8313a636dd53..960de8fe3f40 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -425,7 +425,7 @@ tcp_mtu_probing - INTEGER
425 1 - Disabled by default, enabled when an ICMP black hole detected 425 1 - Disabled by default, enabled when an ICMP black hole detected
426 2 - Always enabled, use initial MSS of tcp_base_mss. 426 2 - Always enabled, use initial MSS of tcp_base_mss.
427 427
428tcp_probe_interval - INTEGER 428tcp_probe_interval - UNSIGNED INTEGER
429 Controls how often to start TCP Packetization-Layer Path MTU 429 Controls how often to start TCP Packetization-Layer Path MTU
430 Discovery reprobe. The default is reprobing every 10 minutes as 430 Discovery reprobe. The default is reprobing every 10 minutes as
431 per RFC4821. 431 per RFC4821.
diff --git a/Documentation/process/code-of-conduct.rst b/Documentation/process/code-of-conduct.rst
new file mode 100644
index 000000000000..ab7c24b5478c
--- /dev/null
+++ b/Documentation/process/code-of-conduct.rst
@@ -0,0 +1,81 @@
1Contributor Covenant Code of Conduct
2++++++++++++++++++++++++++++++++++++
3
4Our Pledge
5==========
6
7In the interest of fostering an open and welcoming environment, we as
8contributors and maintainers pledge to making participation in our project and
9our community a harassment-free experience for everyone, regardless of age, body
10size, disability, ethnicity, sex characteristics, gender identity and
11expression, level of experience, education, socio-economic status, nationality,
12personal appearance, race, religion, or sexual identity and orientation.
13
14Our Standards
15=============
16
17Examples of behavior that contributes to creating a positive environment
18include:
19
20* Using welcoming and inclusive language
21* Being respectful of differing viewpoints and experiences
22* Gracefully accepting constructive criticism
23* Focusing on what is best for the community
24* Showing empathy towards other community members
25
26
27Examples of unacceptable behavior by participants include:
28
29* The use of sexualized language or imagery and unwelcome sexual attention or
30 advances
31* Trolling, insulting/derogatory comments, and personal or political attacks
32* Public or private harassment
33* Publishing others’ private information, such as a physical or electronic
34 address, without explicit permission
35* Other conduct which could reasonably be considered inappropriate in a
36 professional setting
37
38
39Our Responsibilities
40====================
41
42Maintainers are responsible for clarifying the standards of acceptable behavior
43and are expected to take appropriate and fair corrective action in response to
44any instances of unacceptable behavior.
45
46Maintainers have the right and responsibility to remove, edit, or reject
47comments, commits, code, wiki edits, issues, and other contributions that are
48not aligned to this Code of Conduct, or to ban temporarily or permanently any
49contributor for other behaviors that they deem inappropriate, threatening,
50offensive, or harmful.
51
52Scope
53=====
54
55This Code of Conduct applies both within project spaces and in public spaces
56when an individual is representing the project or its community. Examples of
57representing a project or community include using an official project e-mail
58address, posting via an official social media account, or acting as an appointed
59representative at an online or offline event. Representation of a project may be
60further defined and clarified by project maintainers.
61
62Enforcement
63===========
64
65Instances of abusive, harassing, or otherwise unacceptable behavior may be
66reported by contacting the Technical Advisory Board (TAB) at
67<tab@lists.linux-foundation.org>. All complaints will be reviewed and
68investigated and will result in a response that is deemed necessary and
69appropriate to the circumstances. The TAB is obligated to maintain
70confidentiality with regard to the reporter of an incident. Further details of
71specific enforcement policies may be posted separately.
72
73Maintainers who do not follow or enforce the Code of Conduct in good faith may
74face temporary or permanent repercussions as determined by other members of the
75project’s leadership.
76
77Attribution
78===========
79
80This Code of Conduct is adapted from the Contributor Covenant, version 1.4,
81available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
diff --git a/Documentation/process/code-of-conflict.rst b/Documentation/process/code-of-conflict.rst
deleted file mode 100644
index 47b6de763203..000000000000
--- a/Documentation/process/code-of-conflict.rst
+++ /dev/null
@@ -1,28 +0,0 @@
1Code of Conflict
2----------------
3
4The Linux kernel development effort is a very personal process compared
5to "traditional" ways of developing software. Your code and ideas
6behind it will be carefully reviewed, often resulting in critique and
7criticism. The review will almost always require improvements to the
8code before it can be included in the kernel. Know that this happens
9because everyone involved wants to see the best possible solution for
10the overall success of Linux. This development process has been proven
11to create the most robust operating system kernel ever, and we do not
12want to do anything to cause the quality of submission and eventual
13result to ever decrease.
14
15If however, anyone feels personally abused, threatened, or otherwise
16uncomfortable due to this process, that is not acceptable. If so,
17please contact the Linux Foundation's Technical Advisory Board at
18<tab@lists.linux-foundation.org>, or the individual members, and they
19will work to resolve the issue to the best of their ability. For more
20information on who is on the Technical Advisory Board and what their
21role is, please see:
22
23 - http://www.linuxfoundation.org/projects/linux/tab
24
25As a reviewer of code, please strive to keep things civil and focused on
26the technical issues involved. We are all humans, and frustrations can
27be high on both sides of the process. Try to keep in mind the immortal
28words of Bill and Ted, "Be excellent to each other."
diff --git a/Documentation/process/index.rst b/Documentation/process/index.rst
index 37bd0628b6ee..9ae3e317bddf 100644
--- a/Documentation/process/index.rst
+++ b/Documentation/process/index.rst
@@ -20,7 +20,7 @@ Below are the essential guides that every developer should read.
20 :maxdepth: 1 20 :maxdepth: 1
21 21
22 howto 22 howto
23 code-of-conflict 23 code-of-conduct
24 development-process 24 development-process
25 submitting-patches 25 submitting-patches
26 coding-style 26 coding-style
diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index c664064f76fb..647f94128a85 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -4510,7 +4510,8 @@ Do not enable KVM_FEATURE_PV_UNHALT if you disable HLT exits.
4510Architectures: s390 4510Architectures: s390
4511Parameters: none 4511Parameters: none
4512Returns: 0 on success, -EINVAL if hpage module parameter was not set 4512Returns: 0 on success, -EINVAL if hpage module parameter was not set
4513 or cmma is enabled 4513 or cmma is enabled, or the VM has the KVM_VM_S390_UCONTROL
4514 flag set
4514 4515
4515With this capability the KVM support for memory backing with 1m pages 4516With this capability the KVM support for memory backing with 1m pages
4516through hugetlbfs can be enabled for a VM. After the capability is 4517through hugetlbfs can be enabled for a VM. After the capability is
@@ -4521,6 +4522,15 @@ hpage module parameter is not set to 1, -EINVAL is returned.
4521While it is generally possible to create a huge page backed VM without 4522While it is generally possible to create a huge page backed VM without
4522this capability, the VM will not be able to run. 4523this capability, the VM will not be able to run.
4523 4524
45257.14 KVM_CAP_MSR_PLATFORM_INFO
4526
4527Architectures: x86
4528Parameters: args[0] whether feature should be enabled or not
4529
4530With this capability, a guest may read the MSR_PLATFORM_INFO MSR. Otherwise,
4531a #GP would be raised when the guest tries to access. Currently, this
4532capability does not enable write permissions of this MSR for the guest.
4533
45248. Other capabilities. 45348. Other capabilities.
4525---------------------- 4535----------------------
4526 4536
diff --git a/Documentation/x86/earlyprintk.txt b/Documentation/x86/earlyprintk.txt
index 688e3eeed21d..46933e06c972 100644
--- a/Documentation/x86/earlyprintk.txt
+++ b/Documentation/x86/earlyprintk.txt
@@ -35,25 +35,25 @@ and two USB cables, connected like this:
35( If your system does not list a debug port capability then you probably 35( If your system does not list a debug port capability then you probably
36 won't be able to use the USB debug key. ) 36 won't be able to use the USB debug key. )
37 37
38 b.) You also need a Netchip USB debug cable/key: 38 b.) You also need a NetChip USB debug cable/key:
39 39
40 http://www.plxtech.com/products/NET2000/NET20DC/default.asp 40 http://www.plxtech.com/products/NET2000/NET20DC/default.asp
41 41
42 This is a small blue plastic connector with two USB connections, 42 This is a small blue plastic connector with two USB connections;
43 it draws power from its USB connections. 43 it draws power from its USB connections.
44 44
45 c.) You need a second client/console system with a high speed USB 2.0 45 c.) You need a second client/console system with a high speed USB 2.0
46 port. 46 port.
47 47
48 d.) The Netchip device must be plugged directly into the physical 48 d.) The NetChip device must be plugged directly into the physical
49 debug port on the "host/target" system. You cannot use a USB hub in 49 debug port on the "host/target" system. You cannot use a USB hub in
50 between the physical debug port and the "host/target" system. 50 between the physical debug port and the "host/target" system.
51 51
52 The EHCI debug controller is bound to a specific physical USB 52 The EHCI debug controller is bound to a specific physical USB
53 port and the Netchip device will only work as an early printk 53 port and the NetChip device will only work as an early printk
54 device in this port. The EHCI host controllers are electrically 54 device in this port. The EHCI host controllers are electrically
55 wired such that the EHCI debug controller is hooked up to the 55 wired such that the EHCI debug controller is hooked up to the
56 first physical and there is no way to change this via software. 56 first physical port and there is no way to change this via software.
57 You can find the physical port through experimentation by trying 57 You can find the physical port through experimentation by trying
58 each physical port on the system and rebooting. Or you can try 58 each physical port on the system and rebooting. Or you can try
59 and use lsusb or look at the kernel info messages emitted by the 59 and use lsusb or look at the kernel info messages emitted by the
@@ -65,9 +65,9 @@ and two USB cables, connected like this:
65 to the hardware vendor, because there is no reason not to wire 65 to the hardware vendor, because there is no reason not to wire
66 this port into one of the physically accessible ports. 66 this port into one of the physically accessible ports.
67 67
68 e.) It is also important to note, that many versions of the Netchip 68 e.) It is also important to note, that many versions of the NetChip
69 device require the "client/console" system to be plugged into the 69 device require the "client/console" system to be plugged into the
70 right and side of the device (with the product logo facing up and 70 right hand side of the device (with the product logo facing up and
71 readable left to right). The reason being is that the 5 volt 71 readable left to right). The reason being is that the 5 volt
72 power supply is taken from only one side of the device and it 72 power supply is taken from only one side of the device and it
73 must be the side that does not get rebooted. 73 must be the side that does not get rebooted.
@@ -81,13 +81,18 @@ and two USB cables, connected like this:
81 CONFIG_EARLY_PRINTK_DBGP=y 81 CONFIG_EARLY_PRINTK_DBGP=y
82 82
83 And you need to add the boot command line: "earlyprintk=dbgp". 83 And you need to add the boot command line: "earlyprintk=dbgp".
84
84 (If you are using Grub, append it to the 'kernel' line in 85 (If you are using Grub, append it to the 'kernel' line in
85 /etc/grub.conf) 86 /etc/grub.conf. If you are using Grub2 on a BIOS firmware system,
87 append it to the 'linux' line in /boot/grub2/grub.cfg. If you are
88 using Grub2 on an EFI firmware system, append it to the 'linux'
89 or 'linuxefi' line in /boot/grub2/grub.cfg or
90 /boot/efi/EFI/<distro>/grub.cfg.)
86 91
87 On systems with more than one EHCI debug controller you must 92 On systems with more than one EHCI debug controller you must
88 specify the correct EHCI debug controller number. The ordering 93 specify the correct EHCI debug controller number. The ordering
89 comes from the PCI bus enumeration of the EHCI controllers. The 94 comes from the PCI bus enumeration of the EHCI controllers. The
90 default with no number argument is "0" the first EHCI debug 95 default with no number argument is "0" or the first EHCI debug
91 controller. To use the second EHCI debug controller, you would 96 controller. To use the second EHCI debug controller, you would
92 use the command line: "earlyprintk=dbgp1" 97 use the command line: "earlyprintk=dbgp1"
93 98
@@ -111,7 +116,7 @@ and two USB cables, connected like this:
111 see the raw output. 116 see the raw output.
112 117
113 c.) On Nvidia Southbridge based systems: the kernel will try to probe 118 c.) On Nvidia Southbridge based systems: the kernel will try to probe
114 and find out which port has debug device connected. 119 and find out which port has a debug device connected.
115 120
1163. Testing that it works fine: 1213. Testing that it works fine:
117 122
diff --git a/MAINTAINERS b/MAINTAINERS
index d870cb57c887..6ac000cc006d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -324,7 +324,6 @@ F: Documentation/ABI/testing/sysfs-bus-acpi
324F: Documentation/ABI/testing/configfs-acpi 324F: Documentation/ABI/testing/configfs-acpi
325F: drivers/pci/*acpi* 325F: drivers/pci/*acpi*
326F: drivers/pci/*/*acpi* 326F: drivers/pci/*/*acpi*
327F: drivers/pci/*/*/*acpi*
328F: tools/power/acpi/ 327F: tools/power/acpi/
329 328
330ACPI APEI 329ACPI APEI
@@ -1251,7 +1250,7 @@ N: meson
1251 1250
1252ARM/Annapurna Labs ALPINE ARCHITECTURE 1251ARM/Annapurna Labs ALPINE ARCHITECTURE
1253M: Tsahee Zidenberg <tsahee@annapurnalabs.com> 1252M: Tsahee Zidenberg <tsahee@annapurnalabs.com>
1254M: Antoine Tenart <antoine.tenart@free-electrons.com> 1253M: Antoine Tenart <antoine.tenart@bootlin.com>
1255L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) 1254L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
1256S: Maintained 1255S: Maintained
1257F: arch/arm/mach-alpine/ 1256F: arch/arm/mach-alpine/
@@ -2956,7 +2955,6 @@ F: include/linux/bcm963xx_tag.h
2956 2955
2957BROADCOM BNX2 GIGABIT ETHERNET DRIVER 2956BROADCOM BNX2 GIGABIT ETHERNET DRIVER
2958M: Rasesh Mody <rasesh.mody@cavium.com> 2957M: Rasesh Mody <rasesh.mody@cavium.com>
2959M: Harish Patil <harish.patil@cavium.com>
2960M: Dept-GELinuxNICDev@cavium.com 2958M: Dept-GELinuxNICDev@cavium.com
2961L: netdev@vger.kernel.org 2959L: netdev@vger.kernel.org
2962S: Supported 2960S: Supported
@@ -2977,6 +2975,7 @@ F: drivers/scsi/bnx2i/
2977 2975
2978BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER 2976BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER
2979M: Ariel Elior <ariel.elior@cavium.com> 2977M: Ariel Elior <ariel.elior@cavium.com>
2978M: Sudarsana Kalluru <sudarsana.kalluru@cavium.com>
2980M: everest-linux-l2@cavium.com 2979M: everest-linux-l2@cavium.com
2981L: netdev@vger.kernel.org 2980L: netdev@vger.kernel.org
2982S: Supported 2981S: Supported
@@ -5470,7 +5469,8 @@ S: Odd Fixes
5470F: drivers/net/ethernet/agere/ 5469F: drivers/net/ethernet/agere/
5471 5470
5472ETHERNET BRIDGE 5471ETHERNET BRIDGE
5473M: Stephen Hemminger <stephen@networkplumber.org> 5472M: Roopa Prabhu <roopa@cumulusnetworks.com>
5473M: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
5474L: bridge@lists.linux-foundation.org (moderated for non-subscribers) 5474L: bridge@lists.linux-foundation.org (moderated for non-subscribers)
5475L: netdev@vger.kernel.org 5475L: netdev@vger.kernel.org
5476W: http://www.linuxfoundation.org/en/Net:Bridge 5476W: http://www.linuxfoundation.org/en/Net:Bridge
@@ -5625,6 +5625,8 @@ F: lib/fault-inject.c
5625 5625
5626FBTFT Framebuffer drivers 5626FBTFT Framebuffer drivers
5627M: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 5627M: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
5628L: dri-devel@lists.freedesktop.org
5629L: linux-fbdev@vger.kernel.org
5628S: Maintained 5630S: Maintained
5629F: drivers/staging/fbtft/ 5631F: drivers/staging/fbtft/
5630 5632
@@ -6060,7 +6062,7 @@ F: Documentation/gcc-plugins.txt
6060 6062
6061GASKET DRIVER FRAMEWORK 6063GASKET DRIVER FRAMEWORK
6062M: Rob Springer <rspringer@google.com> 6064M: Rob Springer <rspringer@google.com>
6063M: John Joseph <jnjoseph@google.com> 6065M: Todd Poynor <toddpoynor@google.com>
6064M: Ben Chan <benchan@chromium.org> 6066M: Ben Chan <benchan@chromium.org>
6065S: Maintained 6067S: Maintained
6066F: drivers/staging/gasket/ 6068F: drivers/staging/gasket/
@@ -7016,6 +7018,20 @@ F: drivers/crypto/vmx/aes*
7016F: drivers/crypto/vmx/ghash* 7018F: drivers/crypto/vmx/ghash*
7017F: drivers/crypto/vmx/ppc-xlate.pl 7019F: drivers/crypto/vmx/ppc-xlate.pl
7018 7020
7021IBM Power PCI Hotplug Driver for RPA-compliant PPC64 platform
7022M: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
7023L: linux-pci@vger.kernel.org
7024L: linuxppc-dev@lists.ozlabs.org
7025S: Supported
7026F: drivers/pci/hotplug/rpaphp*
7027
7028IBM Power IO DLPAR Driver for RPA-compliant PPC64 platform
7029M: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
7030L: linux-pci@vger.kernel.org
7031L: linuxppc-dev@lists.ozlabs.org
7032S: Supported
7033F: drivers/pci/hotplug/rpadlpar*
7034
7019IBM ServeRAID RAID DRIVER 7035IBM ServeRAID RAID DRIVER
7020S: Orphan 7036S: Orphan
7021F: drivers/scsi/ips.* 7037F: drivers/scsi/ips.*
@@ -8300,7 +8316,7 @@ F: include/linux/libata.h
8300F: Documentation/devicetree/bindings/ata/ 8316F: Documentation/devicetree/bindings/ata/
8301 8317
8302LIBLOCKDEP 8318LIBLOCKDEP
8303M: Sasha Levin <alexander.levin@verizon.com> 8319M: Sasha Levin <alexander.levin@microsoft.com>
8304S: Maintained 8320S: Maintained
8305F: tools/lib/lockdep/ 8321F: tools/lib/lockdep/
8306 8322
@@ -8582,7 +8598,6 @@ F: include/linux/spinlock*.h
8582F: arch/*/include/asm/spinlock*.h 8598F: arch/*/include/asm/spinlock*.h
8583F: include/linux/rwlock*.h 8599F: include/linux/rwlock*.h
8584F: include/linux/mutex*.h 8600F: include/linux/mutex*.h
8585F: arch/*/include/asm/mutex*.h
8586F: include/linux/rwsem*.h 8601F: include/linux/rwsem*.h
8587F: arch/*/include/asm/rwsem.h 8602F: arch/*/include/asm/rwsem.h
8588F: include/linux/seqlock.h 8603F: include/linux/seqlock.h
@@ -9642,7 +9657,8 @@ MIPS/LOONGSON2 ARCHITECTURE
9642M: Jiaxun Yang <jiaxun.yang@flygoat.com> 9657M: Jiaxun Yang <jiaxun.yang@flygoat.com>
9643L: linux-mips@linux-mips.org 9658L: linux-mips@linux-mips.org
9644S: Maintained 9659S: Maintained
9645F: arch/mips/loongson64/*{2e/2f}* 9660F: arch/mips/loongson64/fuloong-2e/
9661F: arch/mips/loongson64/lemote-2f/
9646F: arch/mips/include/asm/mach-loongson64/ 9662F: arch/mips/include/asm/mach-loongson64/
9647F: drivers/*/*loongson2* 9663F: drivers/*/*loongson2*
9648F: drivers/*/*/*loongson2* 9664F: drivers/*/*/*loongson2*
@@ -9700,13 +9716,6 @@ Q: http://patchwork.linuxtv.org/project/linux-media/list/
9700S: Maintained 9716S: Maintained
9701F: drivers/media/dvb-frontends/mn88473* 9717F: drivers/media/dvb-frontends/mn88473*
9702 9718
9703PCI DRIVER FOR MOBIVEIL PCIE IP
9704M: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
9705L: linux-pci@vger.kernel.org
9706S: Supported
9707F: Documentation/devicetree/bindings/pci/mobiveil-pcie.txt
9708F: drivers/pci/controller/pcie-mobiveil.c
9709
9710MODULE SUPPORT 9719MODULE SUPPORT
9711M: Jessica Yu <jeyu@kernel.org> 9720M: Jessica Yu <jeyu@kernel.org>
9712T: git git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git modules-next 9721T: git git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git modules-next
@@ -9856,7 +9865,7 @@ M: Peter Rosin <peda@axentia.se>
9856S: Maintained 9865S: Maintained
9857F: Documentation/ABI/testing/sysfs-class-mux* 9866F: Documentation/ABI/testing/sysfs-class-mux*
9858F: Documentation/devicetree/bindings/mux/ 9867F: Documentation/devicetree/bindings/mux/
9859F: include/linux/dt-bindings/mux/ 9868F: include/dt-bindings/mux/
9860F: include/linux/mux/ 9869F: include/linux/mux/
9861F: drivers/mux/ 9870F: drivers/mux/
9862 9871
@@ -10933,7 +10942,7 @@ M: Willy Tarreau <willy@haproxy.com>
10933M: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> 10942M: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
10934S: Odd Fixes 10943S: Odd Fixes
10935F: Documentation/auxdisplay/lcd-panel-cgram.txt 10944F: Documentation/auxdisplay/lcd-panel-cgram.txt
10936F: drivers/misc/panel.c 10945F: drivers/auxdisplay/panel.c
10937 10946
10938PARALLEL PORT SUBSYSTEM 10947PARALLEL PORT SUBSYSTEM
10939M: Sudip Mukherjee <sudipm.mukherjee@gmail.com> 10948M: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
@@ -11121,6 +11130,13 @@ F: include/uapi/linux/switchtec_ioctl.h
11121F: include/linux/switchtec.h 11130F: include/linux/switchtec.h
11122F: drivers/ntb/hw/mscc/ 11131F: drivers/ntb/hw/mscc/
11123 11132
11133PCI DRIVER FOR MOBIVEIL PCIE IP
11134M: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
11135L: linux-pci@vger.kernel.org
11136S: Supported
11137F: Documentation/devicetree/bindings/pci/mobiveil-pcie.txt
11138F: drivers/pci/controller/pcie-mobiveil.c
11139
11124PCI DRIVER FOR MVEBU (Marvell Armada 370 and Armada XP SOC support) 11140PCI DRIVER FOR MVEBU (Marvell Armada 370 and Armada XP SOC support)
11125M: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 11141M: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
11126M: Jason Cooper <jason@lakedaemon.net> 11142M: Jason Cooper <jason@lakedaemon.net>
@@ -11154,7 +11170,7 @@ F: drivers/pci/controller/dwc/pci-exynos.c
11154 11170
11155PCI DRIVER FOR SYNOPSYS DESIGNWARE 11171PCI DRIVER FOR SYNOPSYS DESIGNWARE
11156M: Jingoo Han <jingoohan1@gmail.com> 11172M: Jingoo Han <jingoohan1@gmail.com>
11157M: Joao Pinto <Joao.Pinto@synopsys.com> 11173M: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
11158L: linux-pci@vger.kernel.org 11174L: linux-pci@vger.kernel.org
11159S: Maintained 11175S: Maintained
11160F: Documentation/devicetree/bindings/pci/designware-pcie.txt 11176F: Documentation/devicetree/bindings/pci/designware-pcie.txt
@@ -11187,8 +11203,14 @@ F: tools/pci/
11187 11203
11188PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC 11204PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
11189M: Russell Currey <ruscur@russell.cc> 11205M: Russell Currey <ruscur@russell.cc>
11206M: Sam Bobroff <sbobroff@linux.ibm.com>
11207M: Oliver O'Halloran <oohall@gmail.com>
11190L: linuxppc-dev@lists.ozlabs.org 11208L: linuxppc-dev@lists.ozlabs.org
11191S: Supported 11209S: Supported
11210F: Documentation/PCI/pci-error-recovery.txt
11211F: drivers/pci/pcie/aer.c
11212F: drivers/pci/pcie/dpc.c
11213F: drivers/pci/pcie/err.c
11192F: Documentation/powerpc/eeh-pci-error-recovery.txt 11214F: Documentation/powerpc/eeh-pci-error-recovery.txt
11193F: arch/powerpc/kernel/eeh*.c 11215F: arch/powerpc/kernel/eeh*.c
11194F: arch/powerpc/platforms/*/eeh*.c 11216F: arch/powerpc/platforms/*/eeh*.c
@@ -11346,10 +11368,10 @@ S: Maintained
11346F: drivers/platform/x86/peaq-wmi.c 11368F: drivers/platform/x86/peaq-wmi.c
11347 11369
11348PER-CPU MEMORY ALLOCATOR 11370PER-CPU MEMORY ALLOCATOR
11371M: Dennis Zhou <dennis@kernel.org>
11349M: Tejun Heo <tj@kernel.org> 11372M: Tejun Heo <tj@kernel.org>
11350M: Christoph Lameter <cl@linux.com> 11373M: Christoph Lameter <cl@linux.com>
11351M: Dennis Zhou <dennisszhou@gmail.com> 11374T: git git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu.git
11352T: git git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git
11353S: Maintained 11375S: Maintained
11354F: include/linux/percpu*.h 11376F: include/linux/percpu*.h
11355F: mm/percpu*.c 11377F: mm/percpu*.c
@@ -11957,7 +11979,7 @@ F: Documentation/scsi/LICENSE.qla4xxx
11957F: drivers/scsi/qla4xxx/ 11979F: drivers/scsi/qla4xxx/
11958 11980
11959QLOGIC QLCNIC (1/10)Gb ETHERNET DRIVER 11981QLOGIC QLCNIC (1/10)Gb ETHERNET DRIVER
11960M: Harish Patil <harish.patil@cavium.com> 11982M: Shahed Shaikh <Shahed.Shaikh@cavium.com>
11961M: Manish Chopra <manish.chopra@cavium.com> 11983M: Manish Chopra <manish.chopra@cavium.com>
11962M: Dept-GELinuxNICDev@cavium.com 11984M: Dept-GELinuxNICDev@cavium.com
11963L: netdev@vger.kernel.org 11985L: netdev@vger.kernel.org
@@ -11965,7 +11987,6 @@ S: Supported
11965F: drivers/net/ethernet/qlogic/qlcnic/ 11987F: drivers/net/ethernet/qlogic/qlcnic/
11966 11988
11967QLOGIC QLGE 10Gb ETHERNET DRIVER 11989QLOGIC QLGE 10Gb ETHERNET DRIVER
11968M: Harish Patil <harish.patil@cavium.com>
11969M: Manish Chopra <manish.chopra@cavium.com> 11990M: Manish Chopra <manish.chopra@cavium.com>
11970M: Dept-GELinuxNICDev@cavium.com 11991M: Dept-GELinuxNICDev@cavium.com
11971L: netdev@vger.kernel.org 11992L: netdev@vger.kernel.org
@@ -12244,6 +12265,7 @@ F: Documentation/networking/rds.txt
12244 12265
12245RDT - RESOURCE ALLOCATION 12266RDT - RESOURCE ALLOCATION
12246M: Fenghua Yu <fenghua.yu@intel.com> 12267M: Fenghua Yu <fenghua.yu@intel.com>
12268M: Reinette Chatre <reinette.chatre@intel.com>
12247L: linux-kernel@vger.kernel.org 12269L: linux-kernel@vger.kernel.org
12248S: Supported 12270S: Supported
12249F: arch/x86/kernel/cpu/intel_rdt* 12271F: arch/x86/kernel/cpu/intel_rdt*
@@ -13433,9 +13455,8 @@ F: drivers/i2c/busses/i2c-synquacer.c
13433F: Documentation/devicetree/bindings/i2c/i2c-synquacer.txt 13455F: Documentation/devicetree/bindings/i2c/i2c-synquacer.txt
13434 13456
13435SOCIONEXT UNIPHIER SOUND DRIVER 13457SOCIONEXT UNIPHIER SOUND DRIVER
13436M: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
13437L: alsa-devel@alsa-project.org (moderated for non-subscribers) 13458L: alsa-devel@alsa-project.org (moderated for non-subscribers)
13438S: Maintained 13459S: Orphan
13439F: sound/soc/uniphier/ 13460F: sound/soc/uniphier/
13440 13461
13441SOEKRIS NET48XX LED SUPPORT 13462SOEKRIS NET48XX LED SUPPORT
@@ -15373,7 +15394,7 @@ S: Maintained
15373UVESAFB DRIVER 15394UVESAFB DRIVER
15374M: Michal Januszewski <spock@gentoo.org> 15395M: Michal Januszewski <spock@gentoo.org>
15375L: linux-fbdev@vger.kernel.org 15396L: linux-fbdev@vger.kernel.org
15376W: http://dev.gentoo.org/~spock/projects/uvesafb/ 15397W: https://github.com/mjanusz/v86d
15377S: Maintained 15398S: Maintained
15378F: Documentation/fb/uvesafb.txt 15399F: Documentation/fb/uvesafb.txt
15379F: drivers/video/fbdev/uvesafb.* 15400F: drivers/video/fbdev/uvesafb.*
@@ -15897,6 +15918,7 @@ F: net/x25/
15897X86 ARCHITECTURE (32-BIT AND 64-BIT) 15918X86 ARCHITECTURE (32-BIT AND 64-BIT)
15898M: Thomas Gleixner <tglx@linutronix.de> 15919M: Thomas Gleixner <tglx@linutronix.de>
15899M: Ingo Molnar <mingo@redhat.com> 15920M: Ingo Molnar <mingo@redhat.com>
15921M: Borislav Petkov <bp@alien8.de>
15900R: "H. Peter Anvin" <hpa@zytor.com> 15922R: "H. Peter Anvin" <hpa@zytor.com>
15901M: x86@kernel.org 15923M: x86@kernel.org
15902L: linux-kernel@vger.kernel.org 15924L: linux-kernel@vger.kernel.org
@@ -15925,6 +15947,15 @@ M: Borislav Petkov <bp@alien8.de>
15925S: Maintained 15947S: Maintained
15926F: arch/x86/kernel/cpu/microcode/* 15948F: arch/x86/kernel/cpu/microcode/*
15927 15949
15950X86 MM
15951M: Dave Hansen <dave.hansen@linux.intel.com>
15952M: Andy Lutomirski <luto@kernel.org>
15953M: Peter Zijlstra <peterz@infradead.org>
15954L: linux-kernel@vger.kernel.org
15955T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm
15956S: Maintained
15957F: arch/x86/mm/
15958
15928X86 PLATFORM DRIVERS 15959X86 PLATFORM DRIVERS
15929M: Darren Hart <dvhart@infradead.org> 15960M: Darren Hart <dvhart@infradead.org>
15930M: Andy Shevchenko <andy@infradead.org> 15961M: Andy Shevchenko <andy@infradead.org>
diff --git a/Makefile b/Makefile
index 4d5c883a98e5..bf3786e4ffec 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
2VERSION = 4 2VERSION = 4
3PATCHLEVEL = 19 3PATCHLEVEL = 19
4SUBLEVEL = 0 4SUBLEVEL = 0
5EXTRAVERSION = -rc3 5EXTRAVERSION = -rc8
6NAME = Merciless Moray 6NAME = Merciless Moray
7 7
8# *DOCUMENTATION* 8# *DOCUMENTATION*
@@ -299,19 +299,7 @@ KERNELRELEASE = $(shell cat include/config/kernel.release 2> /dev/null)
299KERNELVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION) 299KERNELVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION)
300export VERSION PATCHLEVEL SUBLEVEL KERNELRELEASE KERNELVERSION 300export VERSION PATCHLEVEL SUBLEVEL KERNELRELEASE KERNELVERSION
301 301
302# SUBARCH tells the usermode build what the underlying arch is. That is set 302include scripts/subarch.include
303# first, and if a usermode build is happening, the "ARCH=um" on the command
304# line overrides the setting of ARCH below. If a native build is happening,
305# then ARCH is assigned, getting whatever value it gets normally, and
306# SUBARCH is subsequently ignored.
307
308SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
309 -e s/sun4u/sparc64/ \
310 -e s/arm.*/arm/ -e s/sa110/arm/ \
311 -e s/s390x/s390/ -e s/parisc64/parisc/ \
312 -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
313 -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
314 -e s/riscv.*/riscv/)
315 303
316# Cross compiling and selecting different set of gcc/bin-utils 304# Cross compiling and selecting different set of gcc/bin-utils
317# --------------------------------------------------------------------------- 305# ---------------------------------------------------------------------------
@@ -495,13 +483,15 @@ endif
495ifeq ($(cc-name),clang) 483ifeq ($(cc-name),clang)
496ifneq ($(CROSS_COMPILE),) 484ifneq ($(CROSS_COMPILE),)
497CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%)) 485CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%))
498GCC_TOOLCHAIN := $(realpath $(dir $(shell which $(LD)))/..) 486GCC_TOOLCHAIN_DIR := $(dir $(shell which $(LD)))
487CLANG_PREFIX := --prefix=$(GCC_TOOLCHAIN_DIR)
488GCC_TOOLCHAIN := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
499endif 489endif
500ifneq ($(GCC_TOOLCHAIN),) 490ifneq ($(GCC_TOOLCHAIN),)
501CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN) 491CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN)
502endif 492endif
503KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) 493KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
504KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) 494KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
505KBUILD_CFLAGS += $(call cc-option, -no-integrated-as) 495KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
506KBUILD_AFLAGS += $(call cc-option, -no-integrated-as) 496KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
507endif 497endif
@@ -616,6 +606,11 @@ CFLAGS_GCOV := -fprofile-arcs -ftest-coverage \
616 $(call cc-disable-warning,maybe-uninitialized,) 606 $(call cc-disable-warning,maybe-uninitialized,)
617export CFLAGS_GCOV 607export CFLAGS_GCOV
618 608
609# The arch Makefiles can override CC_FLAGS_FTRACE. We may also append it later.
610ifdef CONFIG_FUNCTION_TRACER
611 CC_FLAGS_FTRACE := -pg
612endif
613
619# The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default 614# The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default
620# values of the respective KBUILD_* variables 615# values of the respective KBUILD_* variables
621ARCH_CPPFLAGS := 616ARCH_CPPFLAGS :=
@@ -755,9 +750,6 @@ KBUILD_CFLAGS += $(call cc-option, -femit-struct-debug-baseonly) \
755endif 750endif
756 751
757ifdef CONFIG_FUNCTION_TRACER 752ifdef CONFIG_FUNCTION_TRACER
758ifndef CC_FLAGS_FTRACE
759CC_FLAGS_FTRACE := -pg
760endif
761ifdef CONFIG_FTRACE_MCOUNT_RECORD 753ifdef CONFIG_FTRACE_MCOUNT_RECORD
762 # gcc 5 supports generating the mcount tables directly 754 # gcc 5 supports generating the mcount tables directly
763 ifeq ($(call cc-option-yn,-mrecord-mcount),y) 755 ifeq ($(call cc-option-yn,-mrecord-mcount),y)
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index b4441b0764d7..a045f3086047 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -149,7 +149,7 @@ config ARC_CPU_770
149 Support for ARC770 core introduced with Rel 4.10 (Summer 2011) 149 Support for ARC770 core introduced with Rel 4.10 (Summer 2011)
150 This core has a bunch of cool new features: 150 This core has a bunch of cool new features:
151 -MMU-v3: Variable Page Sz (4k, 8k, 16k), bigger J-TLB (128x4) 151 -MMU-v3: Variable Page Sz (4k, 8k, 16k), bigger J-TLB (128x4)
152 Shared Address Spaces (for sharing TLB entires in MMU) 152 Shared Address Spaces (for sharing TLB entries in MMU)
153 -Caches: New Prog Model, Region Flush 153 -Caches: New Prog Model, Region Flush
154 -Insns: endian swap, load-locked/store-conditional, time-stamp-ctr 154 -Insns: endian swap, load-locked/store-conditional, time-stamp-ctr
155 155
diff --git a/arch/arc/Makefile b/arch/arc/Makefile
index 99cce77ab98f..644815c0516e 100644
--- a/arch/arc/Makefile
+++ b/arch/arc/Makefile
@@ -6,33 +6,11 @@
6# published by the Free Software Foundation. 6# published by the Free Software Foundation.
7# 7#
8 8
9ifeq ($(CROSS_COMPILE),)
10ifndef CONFIG_CPU_BIG_ENDIAN
11CROSS_COMPILE := arc-linux-
12else
13CROSS_COMPILE := arceb-linux-
14endif
15endif
16
17KBUILD_DEFCONFIG := nsim_700_defconfig 9KBUILD_DEFCONFIG := nsim_700_defconfig
18 10
19cflags-y += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__ 11cflags-y += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
20cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7 12cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7
21cflags-$(CONFIG_ISA_ARCV2) += -mcpu=archs 13cflags-$(CONFIG_ISA_ARCV2) += -mcpu=hs38
22
23is_700 = $(shell $(CC) -dM -E - < /dev/null | grep -q "ARC700" && echo 1 || echo 0)
24
25ifdef CONFIG_ISA_ARCOMPACT
26ifeq ($(is_700), 0)
27 $(error Toolchain not configured for ARCompact builds)
28endif
29endif
30
31ifdef CONFIG_ISA_ARCV2
32ifeq ($(is_700), 1)
33 $(error Toolchain not configured for ARCv2 builds)
34endif
35endif
36 14
37ifdef CONFIG_ARC_CURR_IN_REG 15ifdef CONFIG_ARC_CURR_IN_REG
38# For a global register defintion, make sure it gets passed to every file 16# For a global register defintion, make sure it gets passed to every file
@@ -79,7 +57,7 @@ cflags-$(disable_small_data) += -mno-sdata -fcall-used-gp
79cflags-$(CONFIG_CPU_BIG_ENDIAN) += -mbig-endian 57cflags-$(CONFIG_CPU_BIG_ENDIAN) += -mbig-endian
80ldflags-$(CONFIG_CPU_BIG_ENDIAN) += -EB 58ldflags-$(CONFIG_CPU_BIG_ENDIAN) += -EB
81 59
82LIBGCC := $(shell $(CC) $(cflags-y) --print-libgcc-file-name) 60LIBGCC = $(shell $(CC) $(cflags-y) --print-libgcc-file-name)
83 61
84# Modules with short calls might break for calls into builtin-kernel 62# Modules with short calls might break for calls into builtin-kernel
85KBUILD_CFLAGS_MODULE += -mlong-calls -mno-millicode 63KBUILD_CFLAGS_MODULE += -mlong-calls -mno-millicode
diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
index 4674541eba3f..8ce6e7235915 100644
--- a/arch/arc/kernel/process.c
+++ b/arch/arc/kernel/process.c
@@ -241,6 +241,26 @@ int copy_thread(unsigned long clone_flags,
241 task_thread_info(current)->thr_ptr; 241 task_thread_info(current)->thr_ptr;
242 } 242 }
243 243
244
245 /*
246 * setup usermode thread pointer #1:
247 * when child is picked by scheduler, __switch_to() uses @c_callee to
248 * populate usermode callee regs: this works (despite being in a kernel
249 * function) since special return path for child @ret_from_fork()
250 * ensures those regs are not clobbered all the way to RTIE to usermode
251 */
252 c_callee->r25 = task_thread_info(p)->thr_ptr;
253
254#ifdef CONFIG_ARC_CURR_IN_REG
255 /*
256 * setup usermode thread pointer #2:
257 * however for this special use of r25 in kernel, __switch_to() sets
258 * r25 for kernel needs and only in the final return path is usermode
259 * r25 setup, from pt_regs->user_r25. So set that up as well
260 */
261 c_regs->user_r25 = c_callee->r25;
262#endif
263
244 return 0; 264 return 0;
245} 265}
246 266
diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
index b10dccd0958f..3b1baa8605a7 100644
--- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
@@ -11,6 +11,7 @@
11#include "sama5d2-pinfunc.h" 11#include "sama5d2-pinfunc.h"
12#include <dt-bindings/mfd/atmel-flexcom.h> 12#include <dt-bindings/mfd/atmel-flexcom.h>
13#include <dt-bindings/gpio/gpio.h> 13#include <dt-bindings/gpio/gpio.h>
14#include <dt-bindings/pinctrl/at91.h>
14 15
15/ { 16/ {
16 model = "Atmel SAMA5D2 PTC EK"; 17 model = "Atmel SAMA5D2 PTC EK";
@@ -299,6 +300,7 @@
299 <PIN_PA30__NWE_NANDWE>, 300 <PIN_PA30__NWE_NANDWE>,
300 <PIN_PB2__NRD_NANDOE>; 301 <PIN_PB2__NRD_NANDOE>;
301 bias-pull-up; 302 bias-pull-up;
303 atmel,drive-strength = <ATMEL_PIO_DRVSTR_ME>;
302 }; 304 };
303 305
304 ale_cle_rdy_cs { 306 ale_cle_rdy_cs {
diff --git a/arch/arm/boot/dts/bcm63138.dtsi b/arch/arm/boot/dts/bcm63138.dtsi
index 43ee992ccdcf..6df61518776f 100644
--- a/arch/arm/boot/dts/bcm63138.dtsi
+++ b/arch/arm/boot/dts/bcm63138.dtsi
@@ -106,21 +106,23 @@
106 global_timer: timer@1e200 { 106 global_timer: timer@1e200 {
107 compatible = "arm,cortex-a9-global-timer"; 107 compatible = "arm,cortex-a9-global-timer";
108 reg = <0x1e200 0x20>; 108 reg = <0x1e200 0x20>;
109 interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; 109 interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>;
110 clocks = <&axi_clk>; 110 clocks = <&axi_clk>;
111 }; 111 };
112 112
113 local_timer: local-timer@1e600 { 113 local_timer: local-timer@1e600 {
114 compatible = "arm,cortex-a9-twd-timer"; 114 compatible = "arm,cortex-a9-twd-timer";
115 reg = <0x1e600 0x20>; 115 reg = <0x1e600 0x20>;
116 interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>; 116 interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
117 IRQ_TYPE_EDGE_RISING)>;
117 clocks = <&axi_clk>; 118 clocks = <&axi_clk>;
118 }; 119 };
119 120
120 twd_watchdog: watchdog@1e620 { 121 twd_watchdog: watchdog@1e620 {
121 compatible = "arm,cortex-a9-twd-wdt"; 122 compatible = "arm,cortex-a9-twd-wdt";
122 reg = <0x1e620 0x20>; 123 reg = <0x1e620 0x20>;
123 interrupts = <GIC_PPI 14 IRQ_TYPE_LEVEL_HIGH>; 124 interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) |
125 IRQ_TYPE_LEVEL_HIGH)>;
124 }; 126 };
125 127
126 armpll: armpll { 128 armpll: armpll {
@@ -158,7 +160,7 @@
158 serial0: serial@600 { 160 serial0: serial@600 {
159 compatible = "brcm,bcm6345-uart"; 161 compatible = "brcm,bcm6345-uart";
160 reg = <0x600 0x1b>; 162 reg = <0x600 0x1b>;
161 interrupts = <GIC_SPI 32 0>; 163 interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
162 clocks = <&periph_clk>; 164 clocks = <&periph_clk>;
163 clock-names = "periph"; 165 clock-names = "periph";
164 status = "disabled"; 166 status = "disabled";
@@ -167,7 +169,7 @@
167 serial1: serial@620 { 169 serial1: serial@620 {
168 compatible = "brcm,bcm6345-uart"; 170 compatible = "brcm,bcm6345-uart";
169 reg = <0x620 0x1b>; 171 reg = <0x620 0x1b>;
170 interrupts = <GIC_SPI 33 0>; 172 interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
171 clocks = <&periph_clk>; 173 clocks = <&periph_clk>;
172 clock-names = "periph"; 174 clock-names = "periph";
173 status = "disabled"; 175 status = "disabled";
@@ -180,7 +182,7 @@
180 reg = <0x2000 0x600>, <0xf0 0x10>; 182 reg = <0x2000 0x600>, <0xf0 0x10>;
181 reg-names = "nand", "nand-int-base"; 183 reg-names = "nand", "nand-int-base";
182 status = "disabled"; 184 status = "disabled";
183 interrupts = <GIC_SPI 38 0>; 185 interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
184 interrupt-names = "nand"; 186 interrupt-names = "nand";
185 }; 187 };
186 188
diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi
index 7423d462d1e4..50dde84b72ed 100644
--- a/arch/arm/boot/dts/imx53-qsb-common.dtsi
+++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi
@@ -123,6 +123,17 @@
123 }; 123 };
124}; 124};
125 125
126&cpu0 {
127 /* CPU rated to 1GHz, not 1.2GHz as per the default settings */
128 operating-points = <
129 /* kHz uV */
130 166666 850000
131 400000 900000
132 800000 1050000
133 1000000 1200000
134 >;
135};
136
126&esdhc1 { 137&esdhc1 {
127 pinctrl-names = "default"; 138 pinctrl-names = "default";
128 pinctrl-0 = <&pinctrl_esdhc1>; 139 pinctrl-0 = <&pinctrl_esdhc1>;
diff --git a/arch/arm/boot/dts/sama5d3_emac.dtsi b/arch/arm/boot/dts/sama5d3_emac.dtsi
index 7cb235ef0fb6..6e9e1c2f9def 100644
--- a/arch/arm/boot/dts/sama5d3_emac.dtsi
+++ b/arch/arm/boot/dts/sama5d3_emac.dtsi
@@ -41,7 +41,7 @@
41 }; 41 };
42 42
43 macb1: ethernet@f802c000 { 43 macb1: ethernet@f802c000 {
44 compatible = "cdns,at91sam9260-macb", "cdns,macb"; 44 compatible = "atmel,sama5d3-macb", "cdns,at91sam9260-macb", "cdns,macb";
45 reg = <0xf802c000 0x100>; 45 reg = <0xf802c000 0x100>;
46 interrupts = <35 IRQ_TYPE_LEVEL_HIGH 3>; 46 interrupts = <35 IRQ_TYPE_LEVEL_HIGH 3>;
47 pinctrl-names = "default"; 47 pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 661be948ab74..185541a5b69f 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -1078,8 +1078,8 @@
1078 interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; 1078 interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
1079 clocks = <&rcc SPI6_K>; 1079 clocks = <&rcc SPI6_K>;
1080 resets = <&rcc SPI6_R>; 1080 resets = <&rcc SPI6_R>;
1081 dmas = <&mdma1 34 0x0 0x40008 0x0 0x0 0>, 1081 dmas = <&mdma1 34 0x0 0x40008 0x0 0x0>,
1082 <&mdma1 35 0x0 0x40002 0x0 0x0 0>; 1082 <&mdma1 35 0x0 0x40002 0x0 0x0>;
1083 dma-names = "rx", "tx"; 1083 dma-names = "rx", "tx";
1084 status = "disabled"; 1084 status = "disabled";
1085 }; 1085 };
diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index ffd9f00f74a4..5f547c161baf 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -800,8 +800,7 @@
800 }; 800 };
801 801
802 hdmi_phy: hdmi-phy@1ef0000 { 802 hdmi_phy: hdmi-phy@1ef0000 {
803 compatible = "allwinner,sun8i-r40-hdmi-phy", 803 compatible = "allwinner,sun8i-r40-hdmi-phy";
804 "allwinner,sun50i-a64-hdmi-phy";
805 reg = <0x01ef0000 0x10000>; 804 reg = <0x01ef0000 0x10000>;
806 clocks = <&ccu CLK_BUS_HDMI1>, <&ccu CLK_HDMI_SLOW>, 805 clocks = <&ccu CLK_BUS_HDMI1>, <&ccu CLK_HDMI_SLOW>,
807 <&ccu 7>, <&ccu 16>; 806 <&ccu 7>, <&ccu 16>;
diff --git a/arch/arm/kernel/vmlinux.lds.h b/arch/arm/kernel/vmlinux.lds.h
index ae5fdff18406..8247bc15addc 100644
--- a/arch/arm/kernel/vmlinux.lds.h
+++ b/arch/arm/kernel/vmlinux.lds.h
@@ -49,6 +49,8 @@
49#define ARM_DISCARD \ 49#define ARM_DISCARD \
50 *(.ARM.exidx.exit.text) \ 50 *(.ARM.exidx.exit.text) \
51 *(.ARM.extab.exit.text) \ 51 *(.ARM.extab.exit.text) \
52 *(.ARM.exidx.text.exit) \
53 *(.ARM.extab.text.exit) \
52 ARM_CPU_DISCARD(*(.ARM.exidx.cpuexit.text)) \ 54 ARM_CPU_DISCARD(*(.ARM.exidx.cpuexit.text)) \
53 ARM_CPU_DISCARD(*(.ARM.extab.cpuexit.text)) \ 55 ARM_CPU_DISCARD(*(.ARM.extab.cpuexit.text)) \
54 ARM_EXIT_DISCARD(EXIT_TEXT) \ 56 ARM_EXIT_DISCARD(EXIT_TEXT) \
diff --git a/arch/arm/kvm/coproc.c b/arch/arm/kvm/coproc.c
index 450c7a4fbc8a..cb094e55dc5f 100644
--- a/arch/arm/kvm/coproc.c
+++ b/arch/arm/kvm/coproc.c
@@ -478,15 +478,15 @@ static const struct coproc_reg cp15_regs[] = {
478 478
479 /* ICC_SGI1R */ 479 /* ICC_SGI1R */
480 { CRm64(12), Op1( 0), is64, access_gic_sgi}, 480 { CRm64(12), Op1( 0), is64, access_gic_sgi},
481 /* ICC_ASGI1R */
482 { CRm64(12), Op1( 1), is64, access_gic_sgi},
483 /* ICC_SGI0R */
484 { CRm64(12), Op1( 2), is64, access_gic_sgi},
485 481
486 /* VBAR: swapped by interrupt.S. */ 482 /* VBAR: swapped by interrupt.S. */
487 { CRn(12), CRm( 0), Op1( 0), Op2( 0), is32, 483 { CRn(12), CRm( 0), Op1( 0), Op2( 0), is32,
488 NULL, reset_val, c12_VBAR, 0x00000000 }, 484 NULL, reset_val, c12_VBAR, 0x00000000 },
489 485
486 /* ICC_ASGI1R */
487 { CRm64(12), Op1( 1), is64, access_gic_sgi},
488 /* ICC_SGI0R */
489 { CRm64(12), Op1( 2), is64, access_gic_sgi},
490 /* ICC_SRE */ 490 /* ICC_SRE */
491 { CRn(12), CRm(12), Op1( 0), Op2(5), is32, access_gic_sre }, 491 { CRn(12), CRm(12), Op1( 0), Op2(5), is32, access_gic_sre },
492 492
diff --git a/arch/arm/mm/ioremap.c b/arch/arm/mm/ioremap.c
index fc91205ff46c..5bf9443cfbaa 100644
--- a/arch/arm/mm/ioremap.c
+++ b/arch/arm/mm/ioremap.c
@@ -473,7 +473,7 @@ void pci_ioremap_set_mem_type(int mem_type)
473 473
474int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr) 474int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr)
475{ 475{
476 BUG_ON(offset + SZ_64K > IO_SPACE_LIMIT); 476 BUG_ON(offset + SZ_64K - 1 > IO_SPACE_LIMIT);
477 477
478 return ioremap_page_range(PCI_IO_VIRT_BASE + offset, 478 return ioremap_page_range(PCI_IO_VIRT_BASE + offset,
479 PCI_IO_VIRT_BASE + offset + SZ_64K, 479 PCI_IO_VIRT_BASE + offset + SZ_64K,
diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl
index fbc74b5fa3ed..8edf93b4490f 100644
--- a/arch/arm/tools/syscall.tbl
+++ b/arch/arm/tools/syscall.tbl
@@ -413,3 +413,4 @@
413396 common pkey_free sys_pkey_free 413396 common pkey_free sys_pkey_free
414397 common statx sys_statx 414397 common statx sys_statx
415398 common rseq sys_rseq 415398 common rseq sys_rseq
416399 common io_pgetevents sys_io_pgetevents
diff --git a/arch/arm64/include/asm/jump_label.h b/arch/arm64/include/asm/jump_label.h
index 1b5e0e843c3a..7e2b3e360086 100644
--- a/arch/arm64/include/asm/jump_label.h
+++ b/arch/arm64/include/asm/jump_label.h
@@ -28,7 +28,7 @@
28 28
29static __always_inline bool arch_static_branch(struct static_key *key, bool branch) 29static __always_inline bool arch_static_branch(struct static_key *key, bool branch)
30{ 30{
31 asm goto("1: nop\n\t" 31 asm_volatile_goto("1: nop\n\t"
32 ".pushsection __jump_table, \"aw\"\n\t" 32 ".pushsection __jump_table, \"aw\"\n\t"
33 ".align 3\n\t" 33 ".align 3\n\t"
34 ".quad 1b, %l[l_yes], %c0\n\t" 34 ".quad 1b, %l[l_yes], %c0\n\t"
@@ -42,7 +42,7 @@ l_yes:
42 42
43static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch) 43static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch)
44{ 44{
45 asm goto("1: b %l[l_yes]\n\t" 45 asm_volatile_goto("1: b %l[l_yes]\n\t"
46 ".pushsection __jump_table, \"aw\"\n\t" 46 ".pushsection __jump_table, \"aw\"\n\t"
47 ".align 3\n\t" 47 ".align 3\n\t"
48 ".quad 1b, %l[l_yes], %c0\n\t" 48 ".quad 1b, %l[l_yes], %c0\n\t"
diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile
index 95ac7374d723..4c8b13bede80 100644
--- a/arch/arm64/kernel/Makefile
+++ b/arch/arm64/kernel/Makefile
@@ -54,6 +54,7 @@ arm64-obj-$(CONFIG_KEXEC) += machine_kexec.o relocate_kernel.o \
54arm64-obj-$(CONFIG_ARM64_RELOC_TEST) += arm64-reloc-test.o 54arm64-obj-$(CONFIG_ARM64_RELOC_TEST) += arm64-reloc-test.o
55arm64-reloc-test-y := reloc_test_core.o reloc_test_syms.o 55arm64-reloc-test-y := reloc_test_core.o reloc_test_syms.o
56arm64-obj-$(CONFIG_CRASH_DUMP) += crash_dump.o 56arm64-obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
57arm64-obj-$(CONFIG_CRASH_CORE) += crash_core.o
57arm64-obj-$(CONFIG_ARM_SDE_INTERFACE) += sdei.o 58arm64-obj-$(CONFIG_ARM_SDE_INTERFACE) += sdei.o
58arm64-obj-$(CONFIG_ARM64_SSBD) += ssbd.o 59arm64-obj-$(CONFIG_ARM64_SSBD) += ssbd.o
59 60
diff --git a/arch/arm64/kernel/crash_core.c b/arch/arm64/kernel/crash_core.c
new file mode 100644
index 000000000000..ca4c3e12d8c5
--- /dev/null
+++ b/arch/arm64/kernel/crash_core.c
@@ -0,0 +1,19 @@
1// SPDX-License-Identifier: GPL-2.0
2/*
3 * Copyright (C) Linaro.
4 * Copyright (C) Huawei Futurewei Technologies.
5 */
6
7#include <linux/crash_core.h>
8#include <asm/memory.h>
9
10void arch_crash_save_vmcoreinfo(void)
11{
12 VMCOREINFO_NUMBER(VA_BITS);
13 /* Please note VMCOREINFO_NUMBER() uses "%d", not "%x" */
14 vmcoreinfo_append_str("NUMBER(kimage_voffset)=0x%llx\n",
15 kimage_voffset);
16 vmcoreinfo_append_str("NUMBER(PHYS_OFFSET)=0x%llx\n",
17 PHYS_OFFSET);
18 vmcoreinfo_append_str("KERNELOFFSET=%lx\n", kaslr_offset());
19}
diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index f6a5c6bc1434..922add8adb74 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -358,14 +358,3 @@ void crash_free_reserved_phys_range(unsigned long begin, unsigned long end)
358 } 358 }
359} 359}
360#endif /* CONFIG_HIBERNATION */ 360#endif /* CONFIG_HIBERNATION */
361
362void arch_crash_save_vmcoreinfo(void)
363{
364 VMCOREINFO_NUMBER(VA_BITS);
365 /* Please note VMCOREINFO_NUMBER() uses "%d", not "%x" */
366 vmcoreinfo_append_str("NUMBER(kimage_voffset)=0x%llx\n",
367 kimage_voffset);
368 vmcoreinfo_append_str("NUMBER(PHYS_OFFSET)=0x%llx\n",
369 PHYS_OFFSET);
370 vmcoreinfo_append_str("KERNELOFFSET=%lx\n", kaslr_offset());
371}
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 8e38d5267f22..e213f8e867f6 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -966,6 +966,12 @@ static int armv8pmu_set_event_filter(struct hw_perf_event *event,
966 return 0; 966 return 0;
967} 967}
968 968
969static int armv8pmu_filter_match(struct perf_event *event)
970{
971 unsigned long evtype = event->hw.config_base & ARMV8_PMU_EVTYPE_EVENT;
972 return evtype != ARMV8_PMUV3_PERFCTR_CHAIN;
973}
974
969static void armv8pmu_reset(void *info) 975static void armv8pmu_reset(void *info)
970{ 976{
971 struct arm_pmu *cpu_pmu = (struct arm_pmu *)info; 977 struct arm_pmu *cpu_pmu = (struct arm_pmu *)info;
@@ -1114,6 +1120,7 @@ static int armv8_pmu_init(struct arm_pmu *cpu_pmu)
1114 cpu_pmu->stop = armv8pmu_stop, 1120 cpu_pmu->stop = armv8pmu_stop,
1115 cpu_pmu->reset = armv8pmu_reset, 1121 cpu_pmu->reset = armv8pmu_reset,
1116 cpu_pmu->set_event_filter = armv8pmu_set_event_filter; 1122 cpu_pmu->set_event_filter = armv8pmu_set_event_filter;
1123 cpu_pmu->filter_match = armv8pmu_filter_match;
1117 1124
1118 return 0; 1125 return 0;
1119} 1126}
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 5b4fac434c84..b3354ff94e79 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -64,6 +64,9 @@
64#include <asm/xen/hypervisor.h> 64#include <asm/xen/hypervisor.h>
65#include <asm/mmu_context.h> 65#include <asm/mmu_context.h>
66 66
67static int num_standard_resources;
68static struct resource *standard_resources;
69
67phys_addr_t __fdt_pointer __initdata; 70phys_addr_t __fdt_pointer __initdata;
68 71
69/* 72/*
@@ -206,14 +209,19 @@ static void __init request_standard_resources(void)
206{ 209{
207 struct memblock_region *region; 210 struct memblock_region *region;
208 struct resource *res; 211 struct resource *res;
212 unsigned long i = 0;
209 213
210 kernel_code.start = __pa_symbol(_text); 214 kernel_code.start = __pa_symbol(_text);
211 kernel_code.end = __pa_symbol(__init_begin - 1); 215 kernel_code.end = __pa_symbol(__init_begin - 1);
212 kernel_data.start = __pa_symbol(_sdata); 216 kernel_data.start = __pa_symbol(_sdata);
213 kernel_data.end = __pa_symbol(_end - 1); 217 kernel_data.end = __pa_symbol(_end - 1);
214 218
219 num_standard_resources = memblock.memory.cnt;
220 standard_resources = alloc_bootmem_low(num_standard_resources *
221 sizeof(*standard_resources));
222
215 for_each_memblock(memory, region) { 223 for_each_memblock(memory, region) {
216 res = alloc_bootmem_low(sizeof(*res)); 224 res = &standard_resources[i++];
217 if (memblock_is_nomap(region)) { 225 if (memblock_is_nomap(region)) {
218 res->name = "reserved"; 226 res->name = "reserved";
219 res->flags = IORESOURCE_MEM; 227 res->flags = IORESOURCE_MEM;
@@ -243,36 +251,26 @@ static void __init request_standard_resources(void)
243 251
244static int __init reserve_memblock_reserved_regions(void) 252static int __init reserve_memblock_reserved_regions(void)
245{ 253{
246 phys_addr_t start, end, roundup_end = 0; 254 u64 i, j;
247 struct resource *mem, *res; 255
248 u64 i; 256 for (i = 0; i < num_standard_resources; ++i) {
249 257 struct resource *mem = &standard_resources[i];
250 for_each_reserved_mem_region(i, &start, &end) { 258 phys_addr_t r_start, r_end, mem_size = resource_size(mem);
251 if (end <= roundup_end) 259
252 continue; /* done already */ 260 if (!memblock_is_region_reserved(mem->start, mem_size))
253
254 start = __pfn_to_phys(PFN_DOWN(start));
255 end = __pfn_to_phys(PFN_UP(end)) - 1;
256 roundup_end = end;
257
258 res = kzalloc(sizeof(*res), GFP_ATOMIC);
259 if (WARN_ON(!res))
260 return -ENOMEM;
261 res->start = start;
262 res->end = end;
263 res->name = "reserved";
264 res->flags = IORESOURCE_MEM;
265
266 mem = request_resource_conflict(&iomem_resource, res);
267 /*
268 * We expected memblock_reserve() regions to conflict with
269 * memory created by request_standard_resources().
270 */
271 if (WARN_ON_ONCE(!mem))
272 continue; 261 continue;
273 kfree(res);
274 262
275 reserve_region_with_split(mem, start, end, "reserved"); 263 for_each_reserved_mem_region(j, &r_start, &r_end) {
264 resource_size_t start, end;
265
266 start = max(PFN_PHYS(PFN_DOWN(r_start)), mem->start);
267 end = min(PFN_PHYS(PFN_UP(r_end)) - 1, mem->end);
268
269 if (start > mem->end || end < mem->start)
270 continue;
271
272 reserve_region_with_split(mem, start, end, "reserved");
273 }
276 } 274 }
277 275
278 return 0; 276 return 0;
diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c
index 07256b08226c..a6c9fbaeaefc 100644
--- a/arch/arm64/kvm/guest.c
+++ b/arch/arm64/kvm/guest.c
@@ -57,6 +57,45 @@ static u64 core_reg_offset_from_id(u64 id)
57 return id & ~(KVM_REG_ARCH_MASK | KVM_REG_SIZE_MASK | KVM_REG_ARM_CORE); 57 return id & ~(KVM_REG_ARCH_MASK | KVM_REG_SIZE_MASK | KVM_REG_ARM_CORE);
58} 58}
59 59
60static int validate_core_offset(const struct kvm_one_reg *reg)
61{
62 u64 off = core_reg_offset_from_id(reg->id);
63 int size;
64
65 switch (off) {
66 case KVM_REG_ARM_CORE_REG(regs.regs[0]) ...
67 KVM_REG_ARM_CORE_REG(regs.regs[30]):
68 case KVM_REG_ARM_CORE_REG(regs.sp):
69 case KVM_REG_ARM_CORE_REG(regs.pc):
70 case KVM_REG_ARM_CORE_REG(regs.pstate):
71 case KVM_REG_ARM_CORE_REG(sp_el1):
72 case KVM_REG_ARM_CORE_REG(elr_el1):
73 case KVM_REG_ARM_CORE_REG(spsr[0]) ...
74 KVM_REG_ARM_CORE_REG(spsr[KVM_NR_SPSR - 1]):
75 size = sizeof(__u64);
76 break;
77
78 case KVM_REG_ARM_CORE_REG(fp_regs.vregs[0]) ...
79 KVM_REG_ARM_CORE_REG(fp_regs.vregs[31]):
80 size = sizeof(__uint128_t);
81 break;
82
83 case KVM_REG_ARM_CORE_REG(fp_regs.fpsr):
84 case KVM_REG_ARM_CORE_REG(fp_regs.fpcr):
85 size = sizeof(__u32);
86 break;
87
88 default:
89 return -EINVAL;
90 }
91
92 if (KVM_REG_SIZE(reg->id) == size &&
93 IS_ALIGNED(off, size / sizeof(__u32)))
94 return 0;
95
96 return -EINVAL;
97}
98
60static int get_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg) 99static int get_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
61{ 100{
62 /* 101 /*
@@ -76,6 +115,9 @@ static int get_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
76 (off + (KVM_REG_SIZE(reg->id) / sizeof(__u32))) >= nr_regs) 115 (off + (KVM_REG_SIZE(reg->id) / sizeof(__u32))) >= nr_regs)
77 return -ENOENT; 116 return -ENOENT;
78 117
118 if (validate_core_offset(reg))
119 return -EINVAL;
120
79 if (copy_to_user(uaddr, ((u32 *)regs) + off, KVM_REG_SIZE(reg->id))) 121 if (copy_to_user(uaddr, ((u32 *)regs) + off, KVM_REG_SIZE(reg->id)))
80 return -EFAULT; 122 return -EFAULT;
81 123
@@ -98,6 +140,9 @@ static int set_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
98 (off + (KVM_REG_SIZE(reg->id) / sizeof(__u32))) >= nr_regs) 140 (off + (KVM_REG_SIZE(reg->id) / sizeof(__u32))) >= nr_regs)
99 return -ENOENT; 141 return -ENOENT;
100 142
143 if (validate_core_offset(reg))
144 return -EINVAL;
145
101 if (KVM_REG_SIZE(reg->id) > sizeof(tmp)) 146 if (KVM_REG_SIZE(reg->id) > sizeof(tmp))
102 return -EINVAL; 147 return -EINVAL;
103 148
@@ -107,17 +152,25 @@ static int set_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
107 } 152 }
108 153
109 if (off == KVM_REG_ARM_CORE_REG(regs.pstate)) { 154 if (off == KVM_REG_ARM_CORE_REG(regs.pstate)) {
110 u32 mode = (*(u32 *)valp) & PSR_AA32_MODE_MASK; 155 u64 mode = (*(u64 *)valp) & PSR_AA32_MODE_MASK;
111 switch (mode) { 156 switch (mode) {
112 case PSR_AA32_MODE_USR: 157 case PSR_AA32_MODE_USR:
158 if (!system_supports_32bit_el0())
159 return -EINVAL;
160 break;
113 case PSR_AA32_MODE_FIQ: 161 case PSR_AA32_MODE_FIQ:
114 case PSR_AA32_MODE_IRQ: 162 case PSR_AA32_MODE_IRQ:
115 case PSR_AA32_MODE_SVC: 163 case PSR_AA32_MODE_SVC:
116 case PSR_AA32_MODE_ABT: 164 case PSR_AA32_MODE_ABT:
117 case PSR_AA32_MODE_UND: 165 case PSR_AA32_MODE_UND:
166 if (!vcpu_el1_is_32bit(vcpu))
167 return -EINVAL;
168 break;
118 case PSR_MODE_EL0t: 169 case PSR_MODE_EL0t:
119 case PSR_MODE_EL1t: 170 case PSR_MODE_EL1t:
120 case PSR_MODE_EL1h: 171 case PSR_MODE_EL1h:
172 if (vcpu_el1_is_32bit(vcpu))
173 return -EINVAL;
121 break; 174 break;
122 default: 175 default:
123 err = -EINVAL; 176 err = -EINVAL;
diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index 192b3ba07075..f58ea503ad01 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -117,11 +117,14 @@ static pte_t get_clear_flush(struct mm_struct *mm,
117 117
118 /* 118 /*
119 * If HW_AFDBM is enabled, then the HW could turn on 119 * If HW_AFDBM is enabled, then the HW could turn on
120 * the dirty bit for any page in the set, so check 120 * the dirty or accessed bit for any page in the set,
121 * them all. All hugetlb entries are already young. 121 * so check them all.
122 */ 122 */
123 if (pte_dirty(pte)) 123 if (pte_dirty(pte))
124 orig_pte = pte_mkdirty(orig_pte); 124 orig_pte = pte_mkdirty(orig_pte);
125
126 if (pte_young(pte))
127 orig_pte = pte_mkyoung(orig_pte);
125 } 128 }
126 129
127 if (valid) { 130 if (valid) {
@@ -320,11 +323,40 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm,
320 return get_clear_flush(mm, addr, ptep, pgsize, ncontig); 323 return get_clear_flush(mm, addr, ptep, pgsize, ncontig);
321} 324}
322 325
326/*
327 * huge_ptep_set_access_flags will update access flags (dirty, accesssed)
328 * and write permission.
329 *
330 * For a contiguous huge pte range we need to check whether or not write
331 * permission has to change only on the first pte in the set. Then for
332 * all the contiguous ptes we need to check whether or not there is a
333 * discrepancy between dirty or young.
334 */
335static int __cont_access_flags_changed(pte_t *ptep, pte_t pte, int ncontig)
336{
337 int i;
338
339 if (pte_write(pte) != pte_write(huge_ptep_get(ptep)))
340 return 1;
341
342 for (i = 0; i < ncontig; i++) {
343 pte_t orig_pte = huge_ptep_get(ptep + i);
344
345 if (pte_dirty(pte) != pte_dirty(orig_pte))
346 return 1;
347
348 if (pte_young(pte) != pte_young(orig_pte))
349 return 1;
350 }
351
352 return 0;
353}
354
323int huge_ptep_set_access_flags(struct vm_area_struct *vma, 355int huge_ptep_set_access_flags(struct vm_area_struct *vma,
324 unsigned long addr, pte_t *ptep, 356 unsigned long addr, pte_t *ptep,
325 pte_t pte, int dirty) 357 pte_t pte, int dirty)
326{ 358{
327 int ncontig, i, changed = 0; 359 int ncontig, i;
328 size_t pgsize = 0; 360 size_t pgsize = 0;
329 unsigned long pfn = pte_pfn(pte), dpfn; 361 unsigned long pfn = pte_pfn(pte), dpfn;
330 pgprot_t hugeprot; 362 pgprot_t hugeprot;
@@ -336,19 +368,23 @@ int huge_ptep_set_access_flags(struct vm_area_struct *vma,
336 ncontig = find_num_contig(vma->vm_mm, addr, ptep, &pgsize); 368 ncontig = find_num_contig(vma->vm_mm, addr, ptep, &pgsize);
337 dpfn = pgsize >> PAGE_SHIFT; 369 dpfn = pgsize >> PAGE_SHIFT;
338 370
371 if (!__cont_access_flags_changed(ptep, pte, ncontig))
372 return 0;
373
339 orig_pte = get_clear_flush(vma->vm_mm, addr, ptep, pgsize, ncontig); 374 orig_pte = get_clear_flush(vma->vm_mm, addr, ptep, pgsize, ncontig);
340 if (!pte_same(orig_pte, pte))
341 changed = 1;
342 375
343 /* Make sure we don't lose the dirty state */ 376 /* Make sure we don't lose the dirty or young state */
344 if (pte_dirty(orig_pte)) 377 if (pte_dirty(orig_pte))
345 pte = pte_mkdirty(pte); 378 pte = pte_mkdirty(pte);
346 379
380 if (pte_young(orig_pte))
381 pte = pte_mkyoung(pte);
382
347 hugeprot = pte_pgprot(pte); 383 hugeprot = pte_pgprot(pte);
348 for (i = 0; i < ncontig; i++, ptep++, addr += pgsize, pfn += dpfn) 384 for (i = 0; i < ncontig; i++, ptep++, addr += pgsize, pfn += dpfn)
349 set_pte_at(vma->vm_mm, addr, ptep, pfn_pte(pfn, hugeprot)); 385 set_pte_at(vma->vm_mm, addr, ptep, pfn_pte(pfn, hugeprot));
350 386
351 return changed; 387 return 1;
352} 388}
353 389
354void huge_ptep_set_wrprotect(struct mm_struct *mm, 390void huge_ptep_set_wrprotect(struct mm_struct *mm,
diff --git a/arch/hexagon/include/asm/bitops.h b/arch/hexagon/include/asm/bitops.h
index 5e4a59b3ec1b..2691a1857d20 100644
--- a/arch/hexagon/include/asm/bitops.h
+++ b/arch/hexagon/include/asm/bitops.h
@@ -211,7 +211,7 @@ static inline long ffz(int x)
211 * This is defined the same way as ffs. 211 * This is defined the same way as ffs.
212 * Note fls(0) = 0, fls(1) = 1, fls(0x80000000) = 32. 212 * Note fls(0) = 0, fls(1) = 1, fls(0x80000000) = 32.
213 */ 213 */
214static inline long fls(int x) 214static inline int fls(int x)
215{ 215{
216 int r; 216 int r;
217 217
@@ -232,7 +232,7 @@ static inline long fls(int x)
232 * the libc and compiler builtin ffs routines, therefore 232 * the libc and compiler builtin ffs routines, therefore
233 * differs in spirit from the above ffz (man ffs). 233 * differs in spirit from the above ffz (man ffs).
234 */ 234 */
235static inline long ffs(int x) 235static inline int ffs(int x)
236{ 236{
237 int r; 237 int r;
238 238
diff --git a/arch/hexagon/kernel/dma.c b/arch/hexagon/kernel/dma.c
index 77459df34e2e..7ebe7ad19d15 100644
--- a/arch/hexagon/kernel/dma.c
+++ b/arch/hexagon/kernel/dma.c
@@ -60,7 +60,7 @@ static void *hexagon_dma_alloc_coherent(struct device *dev, size_t size,
60 panic("Can't create %s() memory pool!", __func__); 60 panic("Can't create %s() memory pool!", __func__);
61 else 61 else
62 gen_pool_add(coherent_pool, 62 gen_pool_add(coherent_pool,
63 pfn_to_virt(max_low_pfn), 63 (unsigned long)pfn_to_virt(max_low_pfn),
64 hexagon_coherent_pool_size, -1); 64 hexagon_coherent_pool_size, -1);
65 } 65 }
66 66
diff --git a/arch/mips/include/asm/mach-lantiq/xway/xway_dma.h b/arch/mips/include/asm/mach-lantiq/xway/xway_dma.h
index 4901833498f7..8441b2698e64 100644
--- a/arch/mips/include/asm/mach-lantiq/xway/xway_dma.h
+++ b/arch/mips/include/asm/mach-lantiq/xway/xway_dma.h
@@ -40,6 +40,7 @@ struct ltq_dma_channel {
40 int desc; /* the current descriptor */ 40 int desc; /* the current descriptor */
41 struct ltq_dma_desc *desc_base; /* the descriptor base */ 41 struct ltq_dma_desc *desc_base; /* the descriptor base */
42 int phys; /* physical addr */ 42 int phys; /* physical addr */
43 struct device *dev;
43}; 44};
44 45
45enum { 46enum {
diff --git a/arch/mips/include/asm/processor.h b/arch/mips/include/asm/processor.h
index b2fa62922d88..49d6046ca1d0 100644
--- a/arch/mips/include/asm/processor.h
+++ b/arch/mips/include/asm/processor.h
@@ -13,6 +13,7 @@
13 13
14#include <linux/atomic.h> 14#include <linux/atomic.h>
15#include <linux/cpumask.h> 15#include <linux/cpumask.h>
16#include <linux/sizes.h>
16#include <linux/threads.h> 17#include <linux/threads.h>
17 18
18#include <asm/cachectl.h> 19#include <asm/cachectl.h>
@@ -80,11 +81,10 @@ extern unsigned int vced_count, vcei_count;
80 81
81#endif 82#endif
82 83
83/* 84#define VDSO_RANDOMIZE_SIZE (TASK_IS_32BIT_ADDR ? SZ_1M : SZ_256M)
84 * One page above the stack is used for branch delay slot "emulation". 85
85 * See dsemul.c for details. 86extern unsigned long mips_stack_top(void);
86 */ 87#define STACK_TOP mips_stack_top()
87#define STACK_TOP ((TASK_SIZE & PAGE_MASK) - PAGE_SIZE)
88 88
89/* 89/*
90 * This decides where the kernel will search for a free chunk of vm 90 * This decides where the kernel will search for a free chunk of vm
diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
index 8fc69891e117..d4f7fd4550e1 100644
--- a/arch/mips/kernel/process.c
+++ b/arch/mips/kernel/process.c
@@ -32,6 +32,7 @@
32#include <linux/nmi.h> 32#include <linux/nmi.h>
33#include <linux/cpu.h> 33#include <linux/cpu.h>
34 34
35#include <asm/abi.h>
35#include <asm/asm.h> 36#include <asm/asm.h>
36#include <asm/bootinfo.h> 37#include <asm/bootinfo.h>
37#include <asm/cpu.h> 38#include <asm/cpu.h>
@@ -39,6 +40,7 @@
39#include <asm/dsp.h> 40#include <asm/dsp.h>
40#include <asm/fpu.h> 41#include <asm/fpu.h>
41#include <asm/irq.h> 42#include <asm/irq.h>
43#include <asm/mips-cps.h>
42#include <asm/msa.h> 44#include <asm/msa.h>
43#include <asm/pgtable.h> 45#include <asm/pgtable.h>
44#include <asm/mipsregs.h> 46#include <asm/mipsregs.h>
@@ -645,6 +647,29 @@ out:
645 return pc; 647 return pc;
646} 648}
647 649
650unsigned long mips_stack_top(void)
651{
652 unsigned long top = TASK_SIZE & PAGE_MASK;
653
654 /* One page for branch delay slot "emulation" */
655 top -= PAGE_SIZE;
656
657 /* Space for the VDSO, data page & GIC user page */
658 top -= PAGE_ALIGN(current->thread.abi->vdso->size);
659 top -= PAGE_SIZE;
660 top -= mips_gic_present() ? PAGE_SIZE : 0;
661
662 /* Space for cache colour alignment */
663 if (cpu_has_dc_aliases)
664 top -= shm_align_mask + 1;
665
666 /* Space to randomize the VDSO base */
667 if (current->flags & PF_RANDOMIZE)
668 top -= VDSO_RANDOMIZE_SIZE;
669
670 return top;
671}
672
648/* 673/*
649 * Don't forget that the stack pointer must be aligned on a 8 bytes 674 * Don't forget that the stack pointer must be aligned on a 8 bytes
650 * boundary for 32-bits ABI and 16 bytes for 64-bits ABI. 675 * boundary for 32-bits ABI and 16 bytes for 64-bits ABI.
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index c71d1eb7da59..8aaaa42f91ed 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -846,6 +846,34 @@ static void __init arch_mem_init(char **cmdline_p)
846 struct memblock_region *reg; 846 struct memblock_region *reg;
847 extern void plat_mem_setup(void); 847 extern void plat_mem_setup(void);
848 848
849 /*
850 * Initialize boot_command_line to an innocuous but non-empty string in
851 * order to prevent early_init_dt_scan_chosen() from copying
852 * CONFIG_CMDLINE into it without our knowledge. We handle
853 * CONFIG_CMDLINE ourselves below & don't want to duplicate its
854 * content because repeating arguments can be problematic.
855 */
856 strlcpy(boot_command_line, " ", COMMAND_LINE_SIZE);
857
858 /* call board setup routine */
859 plat_mem_setup();
860
861 /*
862 * Make sure all kernel memory is in the maps. The "UP" and
863 * "DOWN" are opposite for initdata since if it crosses over
864 * into another memory section you don't want that to be
865 * freed when the initdata is freed.
866 */
867 arch_mem_addpart(PFN_DOWN(__pa_symbol(&_text)) << PAGE_SHIFT,
868 PFN_UP(__pa_symbol(&_edata)) << PAGE_SHIFT,
869 BOOT_MEM_RAM);
870 arch_mem_addpart(PFN_UP(__pa_symbol(&__init_begin)) << PAGE_SHIFT,
871 PFN_DOWN(__pa_symbol(&__init_end)) << PAGE_SHIFT,
872 BOOT_MEM_INIT_RAM);
873
874 pr_info("Determined physical RAM map:\n");
875 print_memory_map();
876
849#if defined(CONFIG_CMDLINE_BOOL) && defined(CONFIG_CMDLINE_OVERRIDE) 877#if defined(CONFIG_CMDLINE_BOOL) && defined(CONFIG_CMDLINE_OVERRIDE)
850 strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE); 878 strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
851#else 879#else
@@ -873,26 +901,6 @@ static void __init arch_mem_init(char **cmdline_p)
873 } 901 }
874#endif 902#endif
875#endif 903#endif
876
877 /* call board setup routine */
878 plat_mem_setup();
879
880 /*
881 * Make sure all kernel memory is in the maps. The "UP" and
882 * "DOWN" are opposite for initdata since if it crosses over
883 * into another memory section you don't want that to be
884 * freed when the initdata is freed.
885 */
886 arch_mem_addpart(PFN_DOWN(__pa_symbol(&_text)) << PAGE_SHIFT,
887 PFN_UP(__pa_symbol(&_edata)) << PAGE_SHIFT,
888 BOOT_MEM_RAM);
889 arch_mem_addpart(PFN_UP(__pa_symbol(&__init_begin)) << PAGE_SHIFT,
890 PFN_DOWN(__pa_symbol(&__init_end)) << PAGE_SHIFT,
891 BOOT_MEM_INIT_RAM);
892
893 pr_info("Determined physical RAM map:\n");
894 print_memory_map();
895
896 strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE); 904 strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
897 905
898 *cmdline_p = command_line; 906 *cmdline_p = command_line;
diff --git a/arch/mips/kernel/vdso.c b/arch/mips/kernel/vdso.c
index 8f845f6e5f42..48a9c6b90e07 100644
--- a/arch/mips/kernel/vdso.c
+++ b/arch/mips/kernel/vdso.c
@@ -15,6 +15,7 @@
15#include <linux/ioport.h> 15#include <linux/ioport.h>
16#include <linux/kernel.h> 16#include <linux/kernel.h>
17#include <linux/mm.h> 17#include <linux/mm.h>
18#include <linux/random.h>
18#include <linux/sched.h> 19#include <linux/sched.h>
19#include <linux/slab.h> 20#include <linux/slab.h>
20#include <linux/timekeeper_internal.h> 21#include <linux/timekeeper_internal.h>
@@ -97,6 +98,21 @@ void update_vsyscall_tz(void)
97 } 98 }
98} 99}
99 100
101static unsigned long vdso_base(void)
102{
103 unsigned long base;
104
105 /* Skip the delay slot emulation page */
106 base = STACK_TOP + PAGE_SIZE;
107
108 if (current->flags & PF_RANDOMIZE) {
109 base += get_random_int() & (VDSO_RANDOMIZE_SIZE - 1);
110 base = PAGE_ALIGN(base);
111 }
112
113 return base;
114}
115
100int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp) 116int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
101{ 117{
102 struct mips_vdso_image *image = current->thread.abi->vdso; 118 struct mips_vdso_image *image = current->thread.abi->vdso;
@@ -137,7 +153,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
137 if (cpu_has_dc_aliases) 153 if (cpu_has_dc_aliases)
138 size += shm_align_mask + 1; 154 size += shm_align_mask + 1;
139 155
140 base = get_unmapped_area(NULL, 0, size, 0, 0); 156 base = get_unmapped_area(NULL, vdso_base(), size, 0, 0);
141 if (IS_ERR_VALUE(base)) { 157 if (IS_ERR_VALUE(base)) {
142 ret = base; 158 ret = base;
143 goto out; 159 goto out;
diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
index 4b9fbb6744ad..664f2f7f55c1 100644
--- a/arch/mips/lantiq/xway/dma.c
+++ b/arch/mips/lantiq/xway/dma.c
@@ -130,7 +130,7 @@ ltq_dma_alloc(struct ltq_dma_channel *ch)
130 unsigned long flags; 130 unsigned long flags;
131 131
132 ch->desc = 0; 132 ch->desc = 0;
133 ch->desc_base = dma_zalloc_coherent(NULL, 133 ch->desc_base = dma_zalloc_coherent(ch->dev,
134 LTQ_DESC_NUM * LTQ_DESC_SIZE, 134 LTQ_DESC_NUM * LTQ_DESC_SIZE,
135 &ch->phys, GFP_ATOMIC); 135 &ch->phys, GFP_ATOMIC);
136 136
@@ -182,7 +182,7 @@ ltq_dma_free(struct ltq_dma_channel *ch)
182 if (!ch->desc_base) 182 if (!ch->desc_base)
183 return; 183 return;
184 ltq_dma_close(ch); 184 ltq_dma_close(ch);
185 dma_free_coherent(NULL, LTQ_DESC_NUM * LTQ_DESC_SIZE, 185 dma_free_coherent(ch->dev, LTQ_DESC_NUM * LTQ_DESC_SIZE,
186 ch->desc_base, ch->phys); 186 ch->desc_base, ch->phys);
187} 187}
188EXPORT_SYMBOL_GPL(ltq_dma_free); 188EXPORT_SYMBOL_GPL(ltq_dma_free);
diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S
index 3a6f34ef5ffc..069acec3df9f 100644
--- a/arch/mips/lib/memset.S
+++ b/arch/mips/lib/memset.S
@@ -280,9 +280,11 @@
280 * unset_bytes = end_addr - current_addr + 1 280 * unset_bytes = end_addr - current_addr + 1
281 * a2 = t1 - a0 + 1 281 * a2 = t1 - a0 + 1
282 */ 282 */
283 .set reorder
283 PTR_SUBU a2, t1, a0 284 PTR_SUBU a2, t1, a0
285 PTR_ADDIU a2, 1
284 jr ra 286 jr ra
285 PTR_ADDIU a2, 1 287 .set noreorder
286 288
287 .endm 289 .endm
288 290
diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h
index 13a688fc8cd0..2a2486526d1f 100644
--- a/arch/powerpc/include/asm/book3s/64/pgtable.h
+++ b/arch/powerpc/include/asm/book3s/64/pgtable.h
@@ -114,7 +114,7 @@
114 */ 114 */
115#define _HPAGE_CHG_MASK (PTE_RPN_MASK | _PAGE_HPTEFLAGS | _PAGE_DIRTY | \ 115#define _HPAGE_CHG_MASK (PTE_RPN_MASK | _PAGE_HPTEFLAGS | _PAGE_DIRTY | \
116 _PAGE_ACCESSED | H_PAGE_THP_HUGE | _PAGE_PTE | \ 116 _PAGE_ACCESSED | H_PAGE_THP_HUGE | _PAGE_PTE | \
117 _PAGE_SOFT_DIRTY) 117 _PAGE_SOFT_DIRTY | _PAGE_DEVMAP)
118/* 118/*
119 * user access blocked by key 119 * user access blocked by key
120 */ 120 */
@@ -132,7 +132,7 @@
132 */ 132 */
133#define _PAGE_CHG_MASK (PTE_RPN_MASK | _PAGE_HPTEFLAGS | _PAGE_DIRTY | \ 133#define _PAGE_CHG_MASK (PTE_RPN_MASK | _PAGE_HPTEFLAGS | _PAGE_DIRTY | \
134 _PAGE_ACCESSED | _PAGE_SPECIAL | _PAGE_PTE | \ 134 _PAGE_ACCESSED | _PAGE_SPECIAL | _PAGE_PTE | \
135 _PAGE_SOFT_DIRTY) 135 _PAGE_SOFT_DIRTY | _PAGE_DEVMAP)
136 136
137#define H_PTE_PKEY (H_PTE_PKEY_BIT0 | H_PTE_PKEY_BIT1 | H_PTE_PKEY_BIT2 | \ 137#define H_PTE_PKEY (H_PTE_PKEY_BIT0 | H_PTE_PKEY_BIT1 | H_PTE_PKEY_BIT2 | \
138 H_PTE_PKEY_BIT3 | H_PTE_PKEY_BIT4) 138 H_PTE_PKEY_BIT3 | H_PTE_PKEY_BIT4)
@@ -1051,7 +1051,6 @@ static inline void vmemmap_remove_mapping(unsigned long start,
1051 return hash__vmemmap_remove_mapping(start, page_size); 1051 return hash__vmemmap_remove_mapping(start, page_size);
1052} 1052}
1053#endif 1053#endif
1054struct page *realmode_pfn_to_page(unsigned long pfn);
1055 1054
1056static inline pte_t pmd_pte(pmd_t pmd) 1055static inline pte_t pmd_pte(pmd_t pmd)
1057{ 1056{
diff --git a/arch/powerpc/include/asm/iommu.h b/arch/powerpc/include/asm/iommu.h
index ab3a4fba38e3..3d4b88cb8599 100644
--- a/arch/powerpc/include/asm/iommu.h
+++ b/arch/powerpc/include/asm/iommu.h
@@ -220,8 +220,6 @@ extern void iommu_del_device(struct device *dev);
220extern int __init tce_iommu_bus_notifier_init(void); 220extern int __init tce_iommu_bus_notifier_init(void);
221extern long iommu_tce_xchg(struct iommu_table *tbl, unsigned long entry, 221extern long iommu_tce_xchg(struct iommu_table *tbl, unsigned long entry,
222 unsigned long *hpa, enum dma_data_direction *direction); 222 unsigned long *hpa, enum dma_data_direction *direction);
223extern long iommu_tce_xchg_rm(struct iommu_table *tbl, unsigned long entry,
224 unsigned long *hpa, enum dma_data_direction *direction);
225#else 223#else
226static inline void iommu_register_group(struct iommu_table_group *table_group, 224static inline void iommu_register_group(struct iommu_table_group *table_group,
227 int pci_domain_number, 225 int pci_domain_number,
diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h
index b2f89b621b15..b694d6af1150 100644
--- a/arch/powerpc/include/asm/mmu_context.h
+++ b/arch/powerpc/include/asm/mmu_context.h
@@ -38,6 +38,7 @@ extern long mm_iommu_ua_to_hpa(struct mm_iommu_table_group_mem_t *mem,
38 unsigned long ua, unsigned int pageshift, unsigned long *hpa); 38 unsigned long ua, unsigned int pageshift, unsigned long *hpa);
39extern long mm_iommu_ua_to_hpa_rm(struct mm_iommu_table_group_mem_t *mem, 39extern long mm_iommu_ua_to_hpa_rm(struct mm_iommu_table_group_mem_t *mem,
40 unsigned long ua, unsigned int pageshift, unsigned long *hpa); 40 unsigned long ua, unsigned int pageshift, unsigned long *hpa);
41extern void mm_iommu_ua_mark_dirty_rm(struct mm_struct *mm, unsigned long ua);
41extern long mm_iommu_mapped_inc(struct mm_iommu_table_group_mem_t *mem); 42extern long mm_iommu_mapped_inc(struct mm_iommu_table_group_mem_t *mem);
42extern void mm_iommu_mapped_dec(struct mm_iommu_table_group_mem_t *mem); 43extern void mm_iommu_mapped_dec(struct mm_iommu_table_group_mem_t *mem);
43#endif 44#endif
diff --git a/arch/powerpc/include/asm/setup.h b/arch/powerpc/include/asm/setup.h
index 1a951b00465d..1fffbba8d6a5 100644
--- a/arch/powerpc/include/asm/setup.h
+++ b/arch/powerpc/include/asm/setup.h
@@ -9,6 +9,7 @@ extern void ppc_printk_progress(char *s, unsigned short hex);
9 9
10extern unsigned int rtas_data; 10extern unsigned int rtas_data;
11extern unsigned long long memory_limit; 11extern unsigned long long memory_limit;
12extern bool init_mem_is_free;
12extern unsigned long klimit; 13extern unsigned long klimit;
13extern void *zalloc_maybe_bootmem(size_t size, gfp_t mask); 14extern void *zalloc_maybe_bootmem(size_t size, gfp_t mask);
14 15
diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
index ea04dfb8c092..2d8fc8c9da7a 100644
--- a/arch/powerpc/kernel/exceptions-64s.S
+++ b/arch/powerpc/kernel/exceptions-64s.S
@@ -1314,9 +1314,7 @@ EXC_REAL_BEGIN(denorm_exception_hv, 0x1500, 0x100)
1314 1314
1315#ifdef CONFIG_PPC_DENORMALISATION 1315#ifdef CONFIG_PPC_DENORMALISATION
1316 mfspr r10,SPRN_HSRR1 1316 mfspr r10,SPRN_HSRR1
1317 mfspr r11,SPRN_HSRR0 /* save HSRR0 */
1318 andis. r10,r10,(HSRR1_DENORM)@h /* denorm? */ 1317 andis. r10,r10,(HSRR1_DENORM)@h /* denorm? */
1319 addi r11,r11,-4 /* HSRR0 is next instruction */
1320 bne+ denorm_assist 1318 bne+ denorm_assist
1321#endif 1319#endif
1322 1320
@@ -1382,6 +1380,8 @@ END_FTR_SECTION_IFCLR(CPU_FTR_ARCH_207S)
1382 */ 1380 */
1383 XVCPSGNDP32(32) 1381 XVCPSGNDP32(32)
1384denorm_done: 1382denorm_done:
1383 mfspr r11,SPRN_HSRR0
1384 subi r11,r11,4
1385 mtspr SPRN_HSRR0,r11 1385 mtspr SPRN_HSRR0,r11
1386 mtcrf 0x80,r9 1386 mtcrf 0x80,r9
1387 ld r9,PACA_EXGEN+EX_R9(r13) 1387 ld r9,PACA_EXGEN+EX_R9(r13)
diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
index af7a20dc6e09..19b4c628f3be 100644
--- a/arch/powerpc/kernel/iommu.c
+++ b/arch/powerpc/kernel/iommu.c
@@ -1013,31 +1013,6 @@ long iommu_tce_xchg(struct iommu_table *tbl, unsigned long entry,
1013} 1013}
1014EXPORT_SYMBOL_GPL(iommu_tce_xchg); 1014EXPORT_SYMBOL_GPL(iommu_tce_xchg);
1015 1015
1016#ifdef CONFIG_PPC_BOOK3S_64
1017long iommu_tce_xchg_rm(struct iommu_table *tbl, unsigned long entry,
1018 unsigned long *hpa, enum dma_data_direction *direction)
1019{
1020 long ret;
1021
1022 ret = tbl->it_ops->exchange_rm(tbl, entry, hpa, direction);
1023
1024 if (!ret && ((*direction == DMA_FROM_DEVICE) ||
1025 (*direction == DMA_BIDIRECTIONAL))) {
1026 struct page *pg = realmode_pfn_to_page(*hpa >> PAGE_SHIFT);
1027
1028 if (likely(pg)) {
1029 SetPageDirty(pg);
1030 } else {
1031 tbl->it_ops->exchange_rm(tbl, entry, hpa, direction);
1032 ret = -EFAULT;
1033 }
1034 }
1035
1036 return ret;
1037}
1038EXPORT_SYMBOL_GPL(iommu_tce_xchg_rm);
1039#endif
1040
1041int iommu_take_ownership(struct iommu_table *tbl) 1016int iommu_take_ownership(struct iommu_table *tbl)
1042{ 1017{
1043 unsigned long flags, i, sz = (tbl->it_size + 7) >> 3; 1018 unsigned long flags, i, sz = (tbl->it_size + 7) >> 3;
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 913c5725cdb2..bb6ac471a784 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1306,6 +1306,16 @@ void show_user_instructions(struct pt_regs *regs)
1306 1306
1307 pc = regs->nip - (instructions_to_print * 3 / 4 * sizeof(int)); 1307 pc = regs->nip - (instructions_to_print * 3 / 4 * sizeof(int));
1308 1308
1309 /*
1310 * Make sure the NIP points at userspace, not kernel text/data or
1311 * elsewhere.
1312 */
1313 if (!__access_ok(pc, instructions_to_print * sizeof(int), USER_DS)) {
1314 pr_info("%s[%d]: Bad NIP, not dumping instructions.\n",
1315 current->comm, current->pid);
1316 return;
1317 }
1318
1309 pr_info("%s[%d]: code: ", current->comm, current->pid); 1319 pr_info("%s[%d]: code: ", current->comm, current->pid);
1310 1320
1311 for (i = 0; i < instructions_to_print; i++) { 1321 for (i = 0; i < instructions_to_print; i++) {
diff --git a/arch/powerpc/kernel/tm.S b/arch/powerpc/kernel/tm.S
index 6bffbc5affe7..7716374786bd 100644
--- a/arch/powerpc/kernel/tm.S
+++ b/arch/powerpc/kernel/tm.S
@@ -176,13 +176,27 @@ _GLOBAL(tm_reclaim)
176 std r1, PACATMSCRATCH(r13) 176 std r1, PACATMSCRATCH(r13)
177 ld r1, PACAR1(r13) 177 ld r1, PACAR1(r13)
178 178
179 /* Store the PPR in r11 and reset to decent value */
180 std r11, GPR11(r1) /* Temporary stash */ 179 std r11, GPR11(r1) /* Temporary stash */
181 180
181 /*
182 * Move the saved user r1 to the kernel stack in case PACATMSCRATCH is
183 * clobbered by an exception once we turn on MSR_RI below.
184 */
185 ld r11, PACATMSCRATCH(r13)
186 std r11, GPR1(r1)
187
188 /*
189 * Store r13 away so we can free up the scratch SPR for the SLB fault
190 * handler (needed once we start accessing the thread_struct).
191 */
192 GET_SCRATCH0(r11)
193 std r11, GPR13(r1)
194
182 /* Reset MSR RI so we can take SLB faults again */ 195 /* Reset MSR RI so we can take SLB faults again */
183 li r11, MSR_RI 196 li r11, MSR_RI
184 mtmsrd r11, 1 197 mtmsrd r11, 1
185 198
199 /* Store the PPR in r11 and reset to decent value */
186 mfspr r11, SPRN_PPR 200 mfspr r11, SPRN_PPR
187 HMT_MEDIUM 201 HMT_MEDIUM
188 202
@@ -207,11 +221,11 @@ _GLOBAL(tm_reclaim)
207 SAVE_GPR(8, r7) /* user r8 */ 221 SAVE_GPR(8, r7) /* user r8 */
208 SAVE_GPR(9, r7) /* user r9 */ 222 SAVE_GPR(9, r7) /* user r9 */
209 SAVE_GPR(10, r7) /* user r10 */ 223 SAVE_GPR(10, r7) /* user r10 */
210 ld r3, PACATMSCRATCH(r13) /* user r1 */ 224 ld r3, GPR1(r1) /* user r1 */
211 ld r4, GPR7(r1) /* user r7 */ 225 ld r4, GPR7(r1) /* user r7 */
212 ld r5, GPR11(r1) /* user r11 */ 226 ld r5, GPR11(r1) /* user r11 */
213 ld r6, GPR12(r1) /* user r12 */ 227 ld r6, GPR12(r1) /* user r12 */
214 GET_SCRATCH0(8) /* user r13 */ 228 ld r8, GPR13(r1) /* user r13 */
215 std r3, GPR1(r7) 229 std r3, GPR1(r7)
216 std r4, GPR7(r7) 230 std r4, GPR7(r7)
217 std r5, GPR11(r7) 231 std r5, GPR11(r7)
diff --git a/arch/powerpc/kvm/book3s_64_mmu_radix.c b/arch/powerpc/kvm/book3s_64_mmu_radix.c
index fd6e8c13685f..998f8d089ac7 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_radix.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_radix.c
@@ -525,8 +525,8 @@ int kvmppc_book3s_radix_page_fault(struct kvm_run *run, struct kvm_vcpu *vcpu,
525 unsigned long ea, unsigned long dsisr) 525 unsigned long ea, unsigned long dsisr)
526{ 526{
527 struct kvm *kvm = vcpu->kvm; 527 struct kvm *kvm = vcpu->kvm;
528 unsigned long mmu_seq, pte_size; 528 unsigned long mmu_seq;
529 unsigned long gpa, gfn, hva, pfn; 529 unsigned long gpa, gfn, hva;
530 struct kvm_memory_slot *memslot; 530 struct kvm_memory_slot *memslot;
531 struct page *page = NULL; 531 struct page *page = NULL;
532 long ret; 532 long ret;
@@ -623,9 +623,10 @@ int kvmppc_book3s_radix_page_fault(struct kvm_run *run, struct kvm_vcpu *vcpu,
623 */ 623 */
624 hva = gfn_to_hva_memslot(memslot, gfn); 624 hva = gfn_to_hva_memslot(memslot, gfn);
625 if (upgrade_p && __get_user_pages_fast(hva, 1, 1, &page) == 1) { 625 if (upgrade_p && __get_user_pages_fast(hva, 1, 1, &page) == 1) {
626 pfn = page_to_pfn(page);
627 upgrade_write = true; 626 upgrade_write = true;
628 } else { 627 } else {
628 unsigned long pfn;
629
629 /* Call KVM generic code to do the slow-path check */ 630 /* Call KVM generic code to do the slow-path check */
630 pfn = __gfn_to_pfn_memslot(memslot, gfn, false, NULL, 631 pfn = __gfn_to_pfn_memslot(memslot, gfn, false, NULL,
631 writing, upgrade_p); 632 writing, upgrade_p);
@@ -639,63 +640,55 @@ int kvmppc_book3s_radix_page_fault(struct kvm_run *run, struct kvm_vcpu *vcpu,
639 } 640 }
640 } 641 }
641 642
642 /* See if we can insert a 1GB or 2MB large PTE here */
643 level = 0;
644 if (page && PageCompound(page)) {
645 pte_size = PAGE_SIZE << compound_order(compound_head(page));
646 if (pte_size >= PUD_SIZE &&
647 (gpa & (PUD_SIZE - PAGE_SIZE)) ==
648 (hva & (PUD_SIZE - PAGE_SIZE))) {
649 level = 2;
650 pfn &= ~((PUD_SIZE >> PAGE_SHIFT) - 1);
651 } else if (pte_size >= PMD_SIZE &&
652 (gpa & (PMD_SIZE - PAGE_SIZE)) ==
653 (hva & (PMD_SIZE - PAGE_SIZE))) {
654 level = 1;
655 pfn &= ~((PMD_SIZE >> PAGE_SHIFT) - 1);
656 }
657 }
658
659 /* 643 /*
660 * Compute the PTE value that we need to insert. 644 * Read the PTE from the process' radix tree and use that
645 * so we get the shift and attribute bits.
661 */ 646 */
662 if (page) { 647 local_irq_disable();
663 pgflags = _PAGE_READ | _PAGE_EXEC | _PAGE_PRESENT | _PAGE_PTE | 648 ptep = __find_linux_pte(vcpu->arch.pgdir, hva, NULL, &shift);
664 _PAGE_ACCESSED; 649 /*
665 if (writing || upgrade_write) 650 * If the PTE disappeared temporarily due to a THP
666 pgflags |= _PAGE_WRITE | _PAGE_DIRTY; 651 * collapse, just return and let the guest try again.
667 pte = pfn_pte(pfn, __pgprot(pgflags)); 652 */
668 } else { 653 if (!ptep) {
669 /*
670 * Read the PTE from the process' radix tree and use that
671 * so we get the attribute bits.
672 */
673 local_irq_disable();
674 ptep = __find_linux_pte(vcpu->arch.pgdir, hva, NULL, &shift);
675 pte = *ptep;
676 local_irq_enable(); 654 local_irq_enable();
677 if (shift == PUD_SHIFT && 655 if (page)
678 (gpa & (PUD_SIZE - PAGE_SIZE)) == 656 put_page(page);
679 (hva & (PUD_SIZE - PAGE_SIZE))) { 657 return RESUME_GUEST;
680 level = 2; 658 }
681 } else if (shift == PMD_SHIFT && 659 pte = *ptep;
682 (gpa & (PMD_SIZE - PAGE_SIZE)) == 660 local_irq_enable();
683 (hva & (PMD_SIZE - PAGE_SIZE))) { 661
684 level = 1; 662 /* Get pte level from shift/size */
685 } else if (shift && shift != PAGE_SHIFT) { 663 if (shift == PUD_SHIFT &&
686 /* Adjust PFN */ 664 (gpa & (PUD_SIZE - PAGE_SIZE)) ==
687 unsigned long mask = (1ul << shift) - PAGE_SIZE; 665 (hva & (PUD_SIZE - PAGE_SIZE))) {
688 pte = __pte(pte_val(pte) | (hva & mask)); 666 level = 2;
689 } 667 } else if (shift == PMD_SHIFT &&
690 pte = __pte(pte_val(pte) | _PAGE_EXEC | _PAGE_ACCESSED); 668 (gpa & (PMD_SIZE - PAGE_SIZE)) ==
691 if (writing || upgrade_write) { 669 (hva & (PMD_SIZE - PAGE_SIZE))) {
692 if (pte_val(pte) & _PAGE_WRITE) 670 level = 1;
693 pte = __pte(pte_val(pte) | _PAGE_DIRTY); 671 } else {
694 } else { 672 level = 0;
695 pte = __pte(pte_val(pte) & ~(_PAGE_WRITE | _PAGE_DIRTY)); 673 if (shift > PAGE_SHIFT) {
674 /*
675 * If the pte maps more than one page, bring over
676 * bits from the virtual address to get the real
677 * address of the specific single page we want.
678 */
679 unsigned long rpnmask = (1ul << shift) - PAGE_SIZE;
680 pte = __pte(pte_val(pte) | (hva & rpnmask));
696 } 681 }
697 } 682 }
698 683
684 pte = __pte(pte_val(pte) | _PAGE_EXEC | _PAGE_ACCESSED);
685 if (writing || upgrade_write) {
686 if (pte_val(pte) & _PAGE_WRITE)
687 pte = __pte(pte_val(pte) | _PAGE_DIRTY);
688 } else {
689 pte = __pte(pte_val(pte) & ~(_PAGE_WRITE | _PAGE_DIRTY));
690 }
691
699 /* Allocate space in the tree and write the PTE */ 692 /* Allocate space in the tree and write the PTE */
700 ret = kvmppc_create_pte(kvm, pte, gpa, level, mmu_seq); 693 ret = kvmppc_create_pte(kvm, pte, gpa, level, mmu_seq);
701 694
diff --git a/arch/powerpc/kvm/book3s_64_vio_hv.c b/arch/powerpc/kvm/book3s_64_vio_hv.c
index 506a4d400458..6821ead4b4eb 100644
--- a/arch/powerpc/kvm/book3s_64_vio_hv.c
+++ b/arch/powerpc/kvm/book3s_64_vio_hv.c
@@ -187,12 +187,35 @@ long kvmppc_gpa_to_ua(struct kvm *kvm, unsigned long gpa,
187EXPORT_SYMBOL_GPL(kvmppc_gpa_to_ua); 187EXPORT_SYMBOL_GPL(kvmppc_gpa_to_ua);
188 188
189#ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE 189#ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE
190static void kvmppc_rm_clear_tce(struct iommu_table *tbl, unsigned long entry) 190static long iommu_tce_xchg_rm(struct mm_struct *mm, struct iommu_table *tbl,
191 unsigned long entry, unsigned long *hpa,
192 enum dma_data_direction *direction)
193{
194 long ret;
195
196 ret = tbl->it_ops->exchange_rm(tbl, entry, hpa, direction);
197
198 if (!ret && ((*direction == DMA_FROM_DEVICE) ||
199 (*direction == DMA_BIDIRECTIONAL))) {
200 __be64 *pua = IOMMU_TABLE_USERSPACE_ENTRY_RM(tbl, entry);
201 /*
202 * kvmppc_rm_tce_iommu_do_map() updates the UA cache after
203 * calling this so we still get here a valid UA.
204 */
205 if (pua && *pua)
206 mm_iommu_ua_mark_dirty_rm(mm, be64_to_cpu(*pua));
207 }
208
209 return ret;
210}
211
212static void kvmppc_rm_clear_tce(struct kvm *kvm, struct iommu_table *tbl,
213 unsigned long entry)
191{ 214{
192 unsigned long hpa = 0; 215 unsigned long hpa = 0;
193 enum dma_data_direction dir = DMA_NONE; 216 enum dma_data_direction dir = DMA_NONE;
194 217
195 iommu_tce_xchg_rm(tbl, entry, &hpa, &dir); 218 iommu_tce_xchg_rm(kvm->mm, tbl, entry, &hpa, &dir);
196} 219}
197 220
198static long kvmppc_rm_tce_iommu_mapped_dec(struct kvm *kvm, 221static long kvmppc_rm_tce_iommu_mapped_dec(struct kvm *kvm,
@@ -224,7 +247,7 @@ static long kvmppc_rm_tce_iommu_do_unmap(struct kvm *kvm,
224 unsigned long hpa = 0; 247 unsigned long hpa = 0;
225 long ret; 248 long ret;
226 249
227 if (iommu_tce_xchg_rm(tbl, entry, &hpa, &dir)) 250 if (iommu_tce_xchg_rm(kvm->mm, tbl, entry, &hpa, &dir))
228 /* 251 /*
229 * real mode xchg can fail if struct page crosses 252 * real mode xchg can fail if struct page crosses
230 * a page boundary 253 * a page boundary
@@ -236,7 +259,7 @@ static long kvmppc_rm_tce_iommu_do_unmap(struct kvm *kvm,
236 259
237 ret = kvmppc_rm_tce_iommu_mapped_dec(kvm, tbl, entry); 260 ret = kvmppc_rm_tce_iommu_mapped_dec(kvm, tbl, entry);
238 if (ret) 261 if (ret)
239 iommu_tce_xchg_rm(tbl, entry, &hpa, &dir); 262 iommu_tce_xchg_rm(kvm->mm, tbl, entry, &hpa, &dir);
240 263
241 return ret; 264 return ret;
242} 265}
@@ -282,7 +305,7 @@ static long kvmppc_rm_tce_iommu_do_map(struct kvm *kvm, struct iommu_table *tbl,
282 if (WARN_ON_ONCE_RM(mm_iommu_mapped_inc(mem))) 305 if (WARN_ON_ONCE_RM(mm_iommu_mapped_inc(mem)))
283 return H_CLOSED; 306 return H_CLOSED;
284 307
285 ret = iommu_tce_xchg_rm(tbl, entry, &hpa, &dir); 308 ret = iommu_tce_xchg_rm(kvm->mm, tbl, entry, &hpa, &dir);
286 if (ret) { 309 if (ret) {
287 mm_iommu_mapped_dec(mem); 310 mm_iommu_mapped_dec(mem);
288 /* 311 /*
@@ -371,7 +394,7 @@ long kvmppc_rm_h_put_tce(struct kvm_vcpu *vcpu, unsigned long liobn,
371 return ret; 394 return ret;
372 395
373 WARN_ON_ONCE_RM(1); 396 WARN_ON_ONCE_RM(1);
374 kvmppc_rm_clear_tce(stit->tbl, entry); 397 kvmppc_rm_clear_tce(vcpu->kvm, stit->tbl, entry);
375 } 398 }
376 399
377 kvmppc_tce_put(stt, entry, tce); 400 kvmppc_tce_put(stt, entry, tce);
@@ -520,7 +543,7 @@ long kvmppc_rm_h_put_tce_indirect(struct kvm_vcpu *vcpu,
520 goto unlock_exit; 543 goto unlock_exit;
521 544
522 WARN_ON_ONCE_RM(1); 545 WARN_ON_ONCE_RM(1);
523 kvmppc_rm_clear_tce(stit->tbl, entry); 546 kvmppc_rm_clear_tce(vcpu->kvm, stit->tbl, entry);
524 } 547 }
525 548
526 kvmppc_tce_put(stt, entry + i, tce); 549 kvmppc_tce_put(stt, entry + i, tce);
@@ -571,7 +594,7 @@ long kvmppc_rm_h_stuff_tce(struct kvm_vcpu *vcpu,
571 return ret; 594 return ret;
572 595
573 WARN_ON_ONCE_RM(1); 596 WARN_ON_ONCE_RM(1);
574 kvmppc_rm_clear_tce(stit->tbl, entry); 597 kvmppc_rm_clear_tce(vcpu->kvm, stit->tbl, entry);
575 } 598 }
576 } 599 }
577 600
diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
index 886ed94b9c13..d05c8af4ac51 100644
--- a/arch/powerpc/lib/checksum_64.S
+++ b/arch/powerpc/lib/checksum_64.S
@@ -443,6 +443,9 @@ _GLOBAL(csum_ipv6_magic)
443 addc r0, r8, r9 443 addc r0, r8, r9
444 ld r10, 0(r4) 444 ld r10, 0(r4)
445 ld r11, 8(r4) 445 ld r11, 8(r4)
446#ifdef CONFIG_CPU_LITTLE_ENDIAN
447 rotldi r5, r5, 8
448#endif
446 adde r0, r0, r10 449 adde r0, r0, r10
447 add r5, r5, r7 450 add r5, r5, r7
448 adde r0, r0, r11 451 adde r0, r0, r11
diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c
index 850f3b8f4da5..5ffee298745f 100644
--- a/arch/powerpc/lib/code-patching.c
+++ b/arch/powerpc/lib/code-patching.c
@@ -142,7 +142,7 @@ static inline int unmap_patch_area(unsigned long addr)
142 return 0; 142 return 0;
143} 143}
144 144
145int patch_instruction(unsigned int *addr, unsigned int instr) 145static int do_patch_instruction(unsigned int *addr, unsigned int instr)
146{ 146{
147 int err; 147 int err;
148 unsigned int *patch_addr = NULL; 148 unsigned int *patch_addr = NULL;
@@ -182,12 +182,22 @@ out:
182} 182}
183#else /* !CONFIG_STRICT_KERNEL_RWX */ 183#else /* !CONFIG_STRICT_KERNEL_RWX */
184 184
185int patch_instruction(unsigned int *addr, unsigned int instr) 185static int do_patch_instruction(unsigned int *addr, unsigned int instr)
186{ 186{
187 return raw_patch_instruction(addr, instr); 187 return raw_patch_instruction(addr, instr);
188} 188}
189 189
190#endif /* CONFIG_STRICT_KERNEL_RWX */ 190#endif /* CONFIG_STRICT_KERNEL_RWX */
191
192int patch_instruction(unsigned int *addr, unsigned int instr)
193{
194 /* Make sure we aren't patching a freed init section */
195 if (init_mem_is_free && init_section_contains(addr, 4)) {
196 pr_debug("Skipping init section patching addr: 0x%px\n", addr);
197 return 0;
198 }
199 return do_patch_instruction(addr, instr);
200}
191NOKPROBE_SYMBOL(patch_instruction); 201NOKPROBE_SYMBOL(patch_instruction);
192 202
193int patch_branch(unsigned int *addr, unsigned long target, int flags) 203int patch_branch(unsigned int *addr, unsigned long target, int flags)
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c
index 51ce091914f9..7a9886f98b0c 100644
--- a/arch/powerpc/mm/init_64.c
+++ b/arch/powerpc/mm/init_64.c
@@ -308,55 +308,6 @@ void register_page_bootmem_memmap(unsigned long section_nr,
308{ 308{
309} 309}
310 310
311/*
312 * We do not have access to the sparsemem vmemmap, so we fallback to
313 * walking the list of sparsemem blocks which we already maintain for
314 * the sake of crashdump. In the long run, we might want to maintain
315 * a tree if performance of that linear walk becomes a problem.
316 *
317 * realmode_pfn_to_page functions can fail due to:
318 * 1) As real sparsemem blocks do not lay in RAM continously (they
319 * are in virtual address space which is not available in the real mode),
320 * the requested page struct can be split between blocks so get_page/put_page
321 * may fail.
322 * 2) When huge pages are used, the get_page/put_page API will fail
323 * in real mode as the linked addresses in the page struct are virtual
324 * too.
325 */
326struct page *realmode_pfn_to_page(unsigned long pfn)
327{
328 struct vmemmap_backing *vmem_back;
329 struct page *page;
330 unsigned long page_size = 1 << mmu_psize_defs[mmu_vmemmap_psize].shift;
331 unsigned long pg_va = (unsigned long) pfn_to_page(pfn);
332
333 for (vmem_back = vmemmap_list; vmem_back; vmem_back = vmem_back->list) {
334 if (pg_va < vmem_back->virt_addr)
335 continue;
336
337 /* After vmemmap_list entry free is possible, need check all */
338 if ((pg_va + sizeof(struct page)) <=
339 (vmem_back->virt_addr + page_size)) {
340 page = (struct page *) (vmem_back->phys + pg_va -
341 vmem_back->virt_addr);
342 return page;
343 }
344 }
345
346 /* Probably that page struct is split between real pages */
347 return NULL;
348}
349EXPORT_SYMBOL_GPL(realmode_pfn_to_page);
350
351#else
352
353struct page *realmode_pfn_to_page(unsigned long pfn)
354{
355 struct page *page = pfn_to_page(pfn);
356 return page;
357}
358EXPORT_SYMBOL_GPL(realmode_pfn_to_page);
359
360#endif /* CONFIG_SPARSEMEM_VMEMMAP */ 311#endif /* CONFIG_SPARSEMEM_VMEMMAP */
361 312
362#ifdef CONFIG_PPC_BOOK3S_64 313#ifdef CONFIG_PPC_BOOK3S_64
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 5c8530d0c611..04ccb274a620 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -63,6 +63,7 @@
63#endif 63#endif
64 64
65unsigned long long memory_limit; 65unsigned long long memory_limit;
66bool init_mem_is_free;
66 67
67#ifdef CONFIG_HIGHMEM 68#ifdef CONFIG_HIGHMEM
68pte_t *kmap_pte; 69pte_t *kmap_pte;
@@ -396,6 +397,7 @@ void free_initmem(void)
396{ 397{
397 ppc_md.progress = ppc_printk_progress; 398 ppc_md.progress = ppc_printk_progress;
398 mark_initmem_nx(); 399 mark_initmem_nx();
400 init_mem_is_free = true;
399 free_initmem_default(POISON_FREE_INITMEM); 401 free_initmem_default(POISON_FREE_INITMEM);
400} 402}
401 403
diff --git a/arch/powerpc/mm/mmu_context_iommu.c b/arch/powerpc/mm/mmu_context_iommu.c
index c9ee9e23845f..56c2234cc6ae 100644
--- a/arch/powerpc/mm/mmu_context_iommu.c
+++ b/arch/powerpc/mm/mmu_context_iommu.c
@@ -18,11 +18,15 @@
18#include <linux/migrate.h> 18#include <linux/migrate.h>
19#include <linux/hugetlb.h> 19#include <linux/hugetlb.h>
20#include <linux/swap.h> 20#include <linux/swap.h>
21#include <linux/sizes.h>
21#include <asm/mmu_context.h> 22#include <asm/mmu_context.h>
22#include <asm/pte-walk.h> 23#include <asm/pte-walk.h>
23 24
24static DEFINE_MUTEX(mem_list_mutex); 25static DEFINE_MUTEX(mem_list_mutex);
25 26
27#define MM_IOMMU_TABLE_GROUP_PAGE_DIRTY 0x1
28#define MM_IOMMU_TABLE_GROUP_PAGE_MASK ~(SZ_4K - 1)
29
26struct mm_iommu_table_group_mem_t { 30struct mm_iommu_table_group_mem_t {
27 struct list_head next; 31 struct list_head next;
28 struct rcu_head rcu; 32 struct rcu_head rcu;
@@ -263,6 +267,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem)
263 if (!page) 267 if (!page)
264 continue; 268 continue;
265 269
270 if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY)
271 SetPageDirty(page);
272
266 put_page(page); 273 put_page(page);
267 mem->hpas[i] = 0; 274 mem->hpas[i] = 0;
268 } 275 }
@@ -360,7 +367,6 @@ struct mm_iommu_table_group_mem_t *mm_iommu_lookup_rm(struct mm_struct *mm,
360 367
361 return ret; 368 return ret;
362} 369}
363EXPORT_SYMBOL_GPL(mm_iommu_lookup_rm);
364 370
365struct mm_iommu_table_group_mem_t *mm_iommu_find(struct mm_struct *mm, 371struct mm_iommu_table_group_mem_t *mm_iommu_find(struct mm_struct *mm,
366 unsigned long ua, unsigned long entries) 372 unsigned long ua, unsigned long entries)
@@ -390,7 +396,7 @@ long mm_iommu_ua_to_hpa(struct mm_iommu_table_group_mem_t *mem,
390 if (pageshift > mem->pageshift) 396 if (pageshift > mem->pageshift)
391 return -EFAULT; 397 return -EFAULT;
392 398
393 *hpa = *va | (ua & ~PAGE_MASK); 399 *hpa = (*va & MM_IOMMU_TABLE_GROUP_PAGE_MASK) | (ua & ~PAGE_MASK);
394 400
395 return 0; 401 return 0;
396} 402}
@@ -413,11 +419,31 @@ long mm_iommu_ua_to_hpa_rm(struct mm_iommu_table_group_mem_t *mem,
413 if (!pa) 419 if (!pa)
414 return -EFAULT; 420 return -EFAULT;
415 421
416 *hpa = *pa | (ua & ~PAGE_MASK); 422 *hpa = (*pa & MM_IOMMU_TABLE_GROUP_PAGE_MASK) | (ua & ~PAGE_MASK);
417 423
418 return 0; 424 return 0;
419} 425}
420EXPORT_SYMBOL_GPL(mm_iommu_ua_to_hpa_rm); 426
427extern void mm_iommu_ua_mark_dirty_rm(struct mm_struct *mm, unsigned long ua)
428{
429 struct mm_iommu_table_group_mem_t *mem;
430 long entry;
431 void *va;
432 unsigned long *pa;
433
434 mem = mm_iommu_lookup_rm(mm, ua, PAGE_SIZE);
435 if (!mem)
436 return;
437
438 entry = (ua - mem->ua) >> PAGE_SHIFT;
439 va = &mem->hpas[entry];
440
441 pa = (void *) vmalloc_to_phys(va);
442 if (!pa)
443 return;
444
445 *pa |= MM_IOMMU_TABLE_GROUP_PAGE_DIRTY;
446}
421 447
422long mm_iommu_mapped_inc(struct mm_iommu_table_group_mem_t *mem) 448long mm_iommu_mapped_inc(struct mm_iommu_table_group_mem_t *mem)
423{ 449{
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 35ac5422903a..055b211b7126 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -1204,7 +1204,9 @@ int find_and_online_cpu_nid(int cpu)
1204 int new_nid; 1204 int new_nid;
1205 1205
1206 /* Use associativity from first thread for all siblings */ 1206 /* Use associativity from first thread for all siblings */
1207 vphn_get_associativity(cpu, associativity); 1207 if (vphn_get_associativity(cpu, associativity))
1208 return cpu_to_node(cpu);
1209
1208 new_nid = associativity_to_nid(associativity); 1210 new_nid = associativity_to_nid(associativity);
1209 if (new_nid < 0 || !node_possible(new_nid)) 1211 if (new_nid < 0 || !node_possible(new_nid))
1210 new_nid = first_online_node; 1212 new_nid = first_online_node;
@@ -1215,9 +1217,10 @@ int find_and_online_cpu_nid(int cpu)
1215 * Need to ensure that NODE_DATA is initialized for a node from 1217 * Need to ensure that NODE_DATA is initialized for a node from
1216 * available memory (see memblock_alloc_try_nid). If unable to 1218 * available memory (see memblock_alloc_try_nid). If unable to
1217 * init the node, then default to nearest node that has memory 1219 * init the node, then default to nearest node that has memory
1218 * installed. 1220 * installed. Skip onlining a node if the subsystems are not
1221 * yet initialized.
1219 */ 1222 */
1220 if (try_online_node(new_nid)) 1223 if (!topology_inited || try_online_node(new_nid))
1221 new_nid = first_online_node; 1224 new_nid = first_online_node;
1222#else 1225#else
1223 /* 1226 /*
@@ -1452,7 +1455,8 @@ static struct timer_list topology_timer;
1452 1455
1453static void reset_topology_timer(void) 1456static void reset_topology_timer(void)
1454{ 1457{
1455 mod_timer(&topology_timer, jiffies + topology_timer_secs * HZ); 1458 if (vphn_enabled)
1459 mod_timer(&topology_timer, jiffies + topology_timer_secs * HZ);
1456} 1460}
1457 1461
1458#ifdef CONFIG_SMP 1462#ifdef CONFIG_SMP
diff --git a/arch/powerpc/mm/pkeys.c b/arch/powerpc/mm/pkeys.c
index 333b1f80c435..b271b283c785 100644
--- a/arch/powerpc/mm/pkeys.c
+++ b/arch/powerpc/mm/pkeys.c
@@ -45,7 +45,7 @@ static void scan_pkey_feature(void)
45 * Since any pkey can be used for data or execute, we will just treat 45 * Since any pkey can be used for data or execute, we will just treat
46 * all keys as equal and track them as one entity. 46 * all keys as equal and track them as one entity.
47 */ 47 */
48 pkeys_total = be32_to_cpu(vals[0]); 48 pkeys_total = vals[0];
49 pkeys_devtree_defined = true; 49 pkeys_devtree_defined = true;
50} 50}
51 51
diff --git a/arch/powerpc/platforms/powernv/pci-ioda-tce.c b/arch/powerpc/platforms/powernv/pci-ioda-tce.c
index 6c5db1acbe8d..fe9691040f54 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda-tce.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda-tce.c
@@ -276,7 +276,7 @@ long pnv_pci_ioda2_table_alloc_pages(int nid, __u64 bus_offset,
276 level_shift = entries_shift + 3; 276 level_shift = entries_shift + 3;
277 level_shift = max_t(unsigned int, level_shift, PAGE_SHIFT); 277 level_shift = max_t(unsigned int, level_shift, PAGE_SHIFT);
278 278
279 if ((level_shift - 3) * levels + page_shift >= 60) 279 if ((level_shift - 3) * levels + page_shift >= 55)
280 return -EINVAL; 280 return -EINVAL;
281 281
282 /* Allocate TCE table */ 282 /* Allocate TCE table */
diff --git a/arch/riscv/include/asm/asm-prototypes.h b/arch/riscv/include/asm/asm-prototypes.h
new file mode 100644
index 000000000000..c9fecd120d18
--- /dev/null
+++ b/arch/riscv/include/asm/asm-prototypes.h
@@ -0,0 +1,7 @@
1/* SPDX-License-Identifier: GPL-2.0 */
2#ifndef _ASM_RISCV_PROTOTYPES_H
3
4#include <linux/ftrace.h>
5#include <asm-generic/asm-prototypes.h>
6
7#endif /* _ASM_RISCV_PROTOTYPES_H */
diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index db20dc630e7e..b2d26d9d8489 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -85,15 +85,8 @@ atomic_t hart_lottery;
85#ifdef CONFIG_BLK_DEV_INITRD 85#ifdef CONFIG_BLK_DEV_INITRD
86static void __init setup_initrd(void) 86static void __init setup_initrd(void)
87{ 87{
88 extern char __initramfs_start[];
89 extern unsigned long __initramfs_size;
90 unsigned long size; 88 unsigned long size;
91 89
92 if (__initramfs_size > 0) {
93 initrd_start = (unsigned long)(&__initramfs_start);
94 initrd_end = initrd_start + __initramfs_size;
95 }
96
97 if (initrd_start >= initrd_end) { 90 if (initrd_start >= initrd_end) {
98 printk(KERN_INFO "initrd not found or empty"); 91 printk(KERN_INFO "initrd not found or empty");
99 goto disable; 92 goto disable;
@@ -193,7 +186,7 @@ static void __init setup_bootmem(void)
193 BUG_ON(mem_size == 0); 186 BUG_ON(mem_size == 0);
194 187
195 set_max_mapnr(PFN_DOWN(mem_size)); 188 set_max_mapnr(PFN_DOWN(mem_size));
196 max_low_pfn = pfn_base + PFN_DOWN(mem_size); 189 max_low_pfn = memblock_end_of_DRAM();
197 190
198#ifdef CONFIG_BLK_DEV_INITRD 191#ifdef CONFIG_BLK_DEV_INITRD
199 setup_initrd(); 192 setup_initrd();
diff --git a/arch/s390/crypto/paes_s390.c b/arch/s390/crypto/paes_s390.c
index 80b27294c1de..ab9a0ebecc19 100644
--- a/arch/s390/crypto/paes_s390.c
+++ b/arch/s390/crypto/paes_s390.c
@@ -208,7 +208,7 @@ static int cbc_paes_crypt(struct blkcipher_desc *desc, unsigned long modifier,
208 walk->dst.virt.addr, walk->src.virt.addr, n); 208 walk->dst.virt.addr, walk->src.virt.addr, n);
209 if (k) 209 if (k)
210 ret = blkcipher_walk_done(desc, walk, nbytes - k); 210 ret = blkcipher_walk_done(desc, walk, nbytes - k);
211 if (n < k) { 211 if (k < n) {
212 if (__cbc_paes_set_key(ctx) != 0) 212 if (__cbc_paes_set_key(ctx) != 0)
213 return blkcipher_walk_done(desc, walk, -EIO); 213 return blkcipher_walk_done(desc, walk, -EIO);
214 memcpy(param.key, ctx->pk.protkey, MAXPROTKEYSIZE); 214 memcpy(param.key, ctx->pk.protkey, MAXPROTKEYSIZE);
diff --git a/arch/s390/include/asm/sclp.h b/arch/s390/include/asm/sclp.h
index 3cae9168f63c..e44a8d7959f5 100644
--- a/arch/s390/include/asm/sclp.h
+++ b/arch/s390/include/asm/sclp.h
@@ -108,7 +108,8 @@ int sclp_early_get_core_info(struct sclp_core_info *info);
108void sclp_early_get_ipl_info(struct sclp_ipl_info *info); 108void sclp_early_get_ipl_info(struct sclp_ipl_info *info);
109void sclp_early_detect(void); 109void sclp_early_detect(void);
110void sclp_early_printk(const char *s); 110void sclp_early_printk(const char *s);
111void __sclp_early_printk(const char *s, unsigned int len); 111void sclp_early_printk_force(const char *s);
112void __sclp_early_printk(const char *s, unsigned int len, unsigned int force);
112 113
113int _sclp_get_core_info(struct sclp_core_info *info); 114int _sclp_get_core_info(struct sclp_core_info *info);
114int sclp_core_configure(u8 core); 115int sclp_core_configure(u8 core);
diff --git a/arch/s390/kernel/early_printk.c b/arch/s390/kernel/early_printk.c
index 9431784d7796..40c1dfec944e 100644
--- a/arch/s390/kernel/early_printk.c
+++ b/arch/s390/kernel/early_printk.c
@@ -10,7 +10,7 @@
10 10
11static void sclp_early_write(struct console *con, const char *s, unsigned int len) 11static void sclp_early_write(struct console *con, const char *s, unsigned int len)
12{ 12{
13 __sclp_early_printk(s, len); 13 __sclp_early_printk(s, len, 0);
14} 14}
15 15
16static struct console sclp_early_console = { 16static struct console sclp_early_console = {
diff --git a/arch/s390/kernel/swsusp.S b/arch/s390/kernel/swsusp.S
index a049a7b9d6e8..c1a080b11ae9 100644
--- a/arch/s390/kernel/swsusp.S
+++ b/arch/s390/kernel/swsusp.S
@@ -198,12 +198,10 @@ pgm_check_entry:
198 198
199 /* Suspend CPU not available -> panic */ 199 /* Suspend CPU not available -> panic */
200 larl %r15,init_thread_union 200 larl %r15,init_thread_union
201 ahi %r15,1<<(PAGE_SHIFT+THREAD_SIZE_ORDER) 201 aghi %r15,1<<(PAGE_SHIFT+THREAD_SIZE_ORDER)
202 aghi %r15,-STACK_FRAME_OVERHEAD
202 larl %r2,.Lpanic_string 203 larl %r2,.Lpanic_string
203 lghi %r1,0 204 brasl %r14,sclp_early_printk_force
204 sam31
205 sigp %r1,%r0,SIGP_SET_ARCHITECTURE
206 brasl %r14,sclp_early_printk
207 larl %r3,.Ldisabled_wait_31 205 larl %r3,.Ldisabled_wait_31
208 lpsw 0(%r3) 206 lpsw 0(%r3)
2094: 2074:
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index f69333fd2fa3..ac5da6b0b862 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -481,7 +481,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
481 break; 481 break;
482 case KVM_CAP_S390_HPAGE_1M: 482 case KVM_CAP_S390_HPAGE_1M:
483 r = 0; 483 r = 0;
484 if (hpage) 484 if (hpage && !kvm_is_ucontrol(kvm))
485 r = 1; 485 r = 1;
486 break; 486 break;
487 case KVM_CAP_S390_MEM_OP: 487 case KVM_CAP_S390_MEM_OP:
@@ -691,7 +691,7 @@ static int kvm_vm_ioctl_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap)
691 mutex_lock(&kvm->lock); 691 mutex_lock(&kvm->lock);
692 if (kvm->created_vcpus) 692 if (kvm->created_vcpus)
693 r = -EBUSY; 693 r = -EBUSY;
694 else if (!hpage || kvm->arch.use_cmma) 694 else if (!hpage || kvm->arch.use_cmma || kvm_is_ucontrol(kvm))
695 r = -EINVAL; 695 r = -EINVAL;
696 else { 696 else {
697 r = 0; 697 r = 0;
diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
index bb44990c8212..911c7ded35f1 100644
--- a/arch/s390/mm/gmap.c
+++ b/arch/s390/mm/gmap.c
@@ -708,11 +708,13 @@ void gmap_discard(struct gmap *gmap, unsigned long from, unsigned long to)
708 vmaddr |= gaddr & ~PMD_MASK; 708 vmaddr |= gaddr & ~PMD_MASK;
709 /* Find vma in the parent mm */ 709 /* Find vma in the parent mm */
710 vma = find_vma(gmap->mm, vmaddr); 710 vma = find_vma(gmap->mm, vmaddr);
711 if (!vma)
712 continue;
711 /* 713 /*
712 * We do not discard pages that are backed by 714 * We do not discard pages that are backed by
713 * hugetlbfs, so we don't have to refault them. 715 * hugetlbfs, so we don't have to refault them.
714 */ 716 */
715 if (vma && is_vm_hugetlb_page(vma)) 717 if (is_vm_hugetlb_page(vma))
716 continue; 718 continue;
717 size = min(to - gaddr, PMD_SIZE - (gaddr & ~PMD_MASK)); 719 size = min(to - gaddr, PMD_SIZE - (gaddr & ~PMD_MASK));
718 zap_page_range(vma, vmaddr, size); 720 zap_page_range(vma, vmaddr, size);
diff --git a/arch/sparc/kernel/auxio_64.c b/arch/sparc/kernel/auxio_64.c
index 4e8f56c3793c..cc42225c20f3 100644
--- a/arch/sparc/kernel/auxio_64.c
+++ b/arch/sparc/kernel/auxio_64.c
@@ -115,8 +115,8 @@ static int auxio_probe(struct platform_device *dev)
115 auxio_devtype = AUXIO_TYPE_SBUS; 115 auxio_devtype = AUXIO_TYPE_SBUS;
116 size = 1; 116 size = 1;
117 } else { 117 } else {
118 printk("auxio: Unknown parent bus type [%s]\n", 118 printk("auxio: Unknown parent bus type [%pOFn]\n",
119 dp->parent->name); 119 dp->parent);
120 return -ENODEV; 120 return -ENODEV;
121 } 121 }
122 auxio_register = of_ioremap(&dev->resource[0], 0, size, "auxio"); 122 auxio_register = of_ioremap(&dev->resource[0], 0, size, "auxio");
diff --git a/arch/sparc/kernel/kgdb_32.c b/arch/sparc/kernel/kgdb_32.c
index 5868fc333ea8..639c8e54530a 100644
--- a/arch/sparc/kernel/kgdb_32.c
+++ b/arch/sparc/kernel/kgdb_32.c
@@ -122,7 +122,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
122 linux_regs->pc = addr; 122 linux_regs->pc = addr;
123 linux_regs->npc = addr + 4; 123 linux_regs->npc = addr + 4;
124 } 124 }
125 /* fallthru */ 125 /* fall through */
126 126
127 case 'D': 127 case 'D':
128 case 'k': 128 case 'k':
diff --git a/arch/sparc/kernel/kgdb_64.c b/arch/sparc/kernel/kgdb_64.c
index d5f7dc6323d5..a68bbddbdba4 100644
--- a/arch/sparc/kernel/kgdb_64.c
+++ b/arch/sparc/kernel/kgdb_64.c
@@ -148,7 +148,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
148 linux_regs->tpc = addr; 148 linux_regs->tpc = addr;
149 linux_regs->tnpc = addr + 4; 149 linux_regs->tnpc = addr + 4;
150 } 150 }
151 /* fallthru */ 151 /* fall through */
152 152
153 case 'D': 153 case 'D':
154 case 'k': 154 case 'k':
diff --git a/arch/sparc/kernel/power.c b/arch/sparc/kernel/power.c
index 92627abce311..d941875dd718 100644
--- a/arch/sparc/kernel/power.c
+++ b/arch/sparc/kernel/power.c
@@ -41,8 +41,8 @@ static int power_probe(struct platform_device *op)
41 41
42 power_reg = of_ioremap(res, 0, 0x4, "power"); 42 power_reg = of_ioremap(res, 0, 0x4, "power");
43 43
44 printk(KERN_INFO "%s: Control reg at %llx\n", 44 printk(KERN_INFO "%pOFn: Control reg at %llx\n",
45 op->dev.of_node->name, res->start); 45 op->dev.of_node, res->start);
46 46
47 if (has_button_interrupt(irq, op->dev.of_node)) { 47 if (has_button_interrupt(irq, op->dev.of_node)) {
48 if (request_irq(irq, 48 if (request_irq(irq,
diff --git a/arch/sparc/kernel/prom_32.c b/arch/sparc/kernel/prom_32.c
index b51cbb9e87dc..17c87d29ff20 100644
--- a/arch/sparc/kernel/prom_32.c
+++ b/arch/sparc/kernel/prom_32.c
@@ -68,8 +68,8 @@ static void __init sparc32_path_component(struct device_node *dp, char *tmp_buf)
68 return; 68 return;
69 69
70 regs = rprop->value; 70 regs = rprop->value;
71 sprintf(tmp_buf, "%s@%x,%x", 71 sprintf(tmp_buf, "%pOFn@%x,%x",
72 dp->name, 72 dp,
73 regs->which_io, regs->phys_addr); 73 regs->which_io, regs->phys_addr);
74} 74}
75 75
@@ -84,8 +84,8 @@ static void __init sbus_path_component(struct device_node *dp, char *tmp_buf)
84 return; 84 return;
85 85
86 regs = prop->value; 86 regs = prop->value;
87 sprintf(tmp_buf, "%s@%x,%x", 87 sprintf(tmp_buf, "%pOFn@%x,%x",
88 dp->name, 88 dp,
89 regs->which_io, 89 regs->which_io,
90 regs->phys_addr); 90 regs->phys_addr);
91} 91}
@@ -104,13 +104,13 @@ static void __init pci_path_component(struct device_node *dp, char *tmp_buf)
104 regs = prop->value; 104 regs = prop->value;
105 devfn = (regs->phys_hi >> 8) & 0xff; 105 devfn = (regs->phys_hi >> 8) & 0xff;
106 if (devfn & 0x07) { 106 if (devfn & 0x07) {
107 sprintf(tmp_buf, "%s@%x,%x", 107 sprintf(tmp_buf, "%pOFn@%x,%x",
108 dp->name, 108 dp,
109 devfn >> 3, 109 devfn >> 3,
110 devfn & 0x07); 110 devfn & 0x07);
111 } else { 111 } else {
112 sprintf(tmp_buf, "%s@%x", 112 sprintf(tmp_buf, "%pOFn@%x",
113 dp->name, 113 dp,
114 devfn >> 3); 114 devfn >> 3);
115 } 115 }
116} 116}
@@ -127,8 +127,8 @@ static void __init ebus_path_component(struct device_node *dp, char *tmp_buf)
127 127
128 regs = prop->value; 128 regs = prop->value;
129 129
130 sprintf(tmp_buf, "%s@%x,%x", 130 sprintf(tmp_buf, "%pOFn@%x,%x",
131 dp->name, 131 dp,
132 regs->which_io, regs->phys_addr); 132 regs->which_io, regs->phys_addr);
133} 133}
134 134
@@ -167,8 +167,8 @@ static void __init ambapp_path_component(struct device_node *dp, char *tmp_buf)
167 return; 167 return;
168 device = prop->value; 168 device = prop->value;
169 169
170 sprintf(tmp_buf, "%s:%d:%d@%x,%x", 170 sprintf(tmp_buf, "%pOFn:%d:%d@%x,%x",
171 dp->name, *vendor, *device, 171 dp, *vendor, *device,
172 *intr, reg0); 172 *intr, reg0);
173} 173}
174 174
@@ -201,7 +201,7 @@ char * __init build_path_component(struct device_node *dp)
201 tmp_buf[0] = '\0'; 201 tmp_buf[0] = '\0';
202 __build_path_component(dp, tmp_buf); 202 __build_path_component(dp, tmp_buf);
203 if (tmp_buf[0] == '\0') 203 if (tmp_buf[0] == '\0')
204 strcpy(tmp_buf, dp->name); 204 snprintf(tmp_buf, sizeof(tmp_buf), "%pOFn", dp);
205 205
206 n = prom_early_alloc(strlen(tmp_buf) + 1); 206 n = prom_early_alloc(strlen(tmp_buf) + 1);
207 strcpy(n, tmp_buf); 207 strcpy(n, tmp_buf);
diff --git a/arch/sparc/kernel/prom_64.c b/arch/sparc/kernel/prom_64.c
index baeaeed64993..6220411ce8fc 100644
--- a/arch/sparc/kernel/prom_64.c
+++ b/arch/sparc/kernel/prom_64.c
@@ -82,8 +82,8 @@ static void __init sun4v_path_component(struct device_node *dp, char *tmp_buf)
82 82
83 regs = rprop->value; 83 regs = rprop->value;
84 if (!of_node_is_root(dp->parent)) { 84 if (!of_node_is_root(dp->parent)) {
85 sprintf(tmp_buf, "%s@%x,%x", 85 sprintf(tmp_buf, "%pOFn@%x,%x",
86 dp->name, 86 dp,
87 (unsigned int) (regs->phys_addr >> 32UL), 87 (unsigned int) (regs->phys_addr >> 32UL),
88 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 88 (unsigned int) (regs->phys_addr & 0xffffffffUL));
89 return; 89 return;
@@ -97,17 +97,17 @@ static void __init sun4v_path_component(struct device_node *dp, char *tmp_buf)
97 const char *prefix = (type == 0) ? "m" : "i"; 97 const char *prefix = (type == 0) ? "m" : "i";
98 98
99 if (low_bits) 99 if (low_bits)
100 sprintf(tmp_buf, "%s@%s%x,%x", 100 sprintf(tmp_buf, "%pOFn@%s%x,%x",
101 dp->name, prefix, 101 dp, prefix,
102 high_bits, low_bits); 102 high_bits, low_bits);
103 else 103 else
104 sprintf(tmp_buf, "%s@%s%x", 104 sprintf(tmp_buf, "%pOFn@%s%x",
105 dp->name, 105 dp,
106 prefix, 106 prefix,
107 high_bits); 107 high_bits);
108 } else if (type == 12) { 108 } else if (type == 12) {
109 sprintf(tmp_buf, "%s@%x", 109 sprintf(tmp_buf, "%pOFn@%x",
110 dp->name, high_bits); 110 dp, high_bits);
111 } 111 }
112} 112}
113 113
@@ -122,8 +122,8 @@ static void __init sun4u_path_component(struct device_node *dp, char *tmp_buf)
122 122
123 regs = prop->value; 123 regs = prop->value;
124 if (!of_node_is_root(dp->parent)) { 124 if (!of_node_is_root(dp->parent)) {
125 sprintf(tmp_buf, "%s@%x,%x", 125 sprintf(tmp_buf, "%pOFn@%x,%x",
126 dp->name, 126 dp,
127 (unsigned int) (regs->phys_addr >> 32UL), 127 (unsigned int) (regs->phys_addr >> 32UL),
128 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 128 (unsigned int) (regs->phys_addr & 0xffffffffUL));
129 return; 129 return;
@@ -138,8 +138,8 @@ static void __init sun4u_path_component(struct device_node *dp, char *tmp_buf)
138 if (tlb_type >= cheetah) 138 if (tlb_type >= cheetah)
139 mask = 0x7fffff; 139 mask = 0x7fffff;
140 140
141 sprintf(tmp_buf, "%s@%x,%x", 141 sprintf(tmp_buf, "%pOFn@%x,%x",
142 dp->name, 142 dp,
143 *(u32 *)prop->value, 143 *(u32 *)prop->value,
144 (unsigned int) (regs->phys_addr & mask)); 144 (unsigned int) (regs->phys_addr & mask));
145 } 145 }
@@ -156,8 +156,8 @@ static void __init sbus_path_component(struct device_node *dp, char *tmp_buf)
156 return; 156 return;
157 157
158 regs = prop->value; 158 regs = prop->value;
159 sprintf(tmp_buf, "%s@%x,%x", 159 sprintf(tmp_buf, "%pOFn@%x,%x",
160 dp->name, 160 dp,
161 regs->which_io, 161 regs->which_io,
162 regs->phys_addr); 162 regs->phys_addr);
163} 163}
@@ -176,13 +176,13 @@ static void __init pci_path_component(struct device_node *dp, char *tmp_buf)
176 regs = prop->value; 176 regs = prop->value;
177 devfn = (regs->phys_hi >> 8) & 0xff; 177 devfn = (regs->phys_hi >> 8) & 0xff;
178 if (devfn & 0x07) { 178 if (devfn & 0x07) {
179 sprintf(tmp_buf, "%s@%x,%x", 179 sprintf(tmp_buf, "%pOFn@%x,%x",
180 dp->name, 180 dp,
181 devfn >> 3, 181 devfn >> 3,
182 devfn & 0x07); 182 devfn & 0x07);
183 } else { 183 } else {
184 sprintf(tmp_buf, "%s@%x", 184 sprintf(tmp_buf, "%pOFn@%x",
185 dp->name, 185 dp,
186 devfn >> 3); 186 devfn >> 3);
187 } 187 }
188} 188}
@@ -203,8 +203,8 @@ static void __init upa_path_component(struct device_node *dp, char *tmp_buf)
203 if (!prop) 203 if (!prop)
204 return; 204 return;
205 205
206 sprintf(tmp_buf, "%s@%x,%x", 206 sprintf(tmp_buf, "%pOFn@%x,%x",
207 dp->name, 207 dp,
208 *(u32 *) prop->value, 208 *(u32 *) prop->value,
209 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 209 (unsigned int) (regs->phys_addr & 0xffffffffUL));
210} 210}
@@ -221,7 +221,7 @@ static void __init vdev_path_component(struct device_node *dp, char *tmp_buf)
221 221
222 regs = prop->value; 222 regs = prop->value;
223 223
224 sprintf(tmp_buf, "%s@%x", dp->name, *regs); 224 sprintf(tmp_buf, "%pOFn@%x", dp, *regs);
225} 225}
226 226
227/* "name@addrhi,addrlo" */ 227/* "name@addrhi,addrlo" */
@@ -236,8 +236,8 @@ static void __init ebus_path_component(struct device_node *dp, char *tmp_buf)
236 236
237 regs = prop->value; 237 regs = prop->value;
238 238
239 sprintf(tmp_buf, "%s@%x,%x", 239 sprintf(tmp_buf, "%pOFn@%x,%x",
240 dp->name, 240 dp,
241 (unsigned int) (regs->phys_addr >> 32UL), 241 (unsigned int) (regs->phys_addr >> 32UL),
242 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 242 (unsigned int) (regs->phys_addr & 0xffffffffUL));
243} 243}
@@ -257,8 +257,8 @@ static void __init i2c_path_component(struct device_node *dp, char *tmp_buf)
257 /* This actually isn't right... should look at the #address-cells 257 /* This actually isn't right... should look at the #address-cells
258 * property of the i2c bus node etc. etc. 258 * property of the i2c bus node etc. etc.
259 */ 259 */
260 sprintf(tmp_buf, "%s@%x,%x", 260 sprintf(tmp_buf, "%pOFn@%x,%x",
261 dp->name, regs[0], regs[1]); 261 dp, regs[0], regs[1]);
262} 262}
263 263
264/* "name@reg0[,reg1]" */ 264/* "name@reg0[,reg1]" */
@@ -274,11 +274,11 @@ static void __init usb_path_component(struct device_node *dp, char *tmp_buf)
274 regs = prop->value; 274 regs = prop->value;
275 275
276 if (prop->length == sizeof(u32) || regs[1] == 1) { 276 if (prop->length == sizeof(u32) || regs[1] == 1) {
277 sprintf(tmp_buf, "%s@%x", 277 sprintf(tmp_buf, "%pOFn@%x",
278 dp->name, regs[0]); 278 dp, regs[0]);
279 } else { 279 } else {
280 sprintf(tmp_buf, "%s@%x,%x", 280 sprintf(tmp_buf, "%pOFn@%x,%x",
281 dp->name, regs[0], regs[1]); 281 dp, regs[0], regs[1]);
282 } 282 }
283} 283}
284 284
@@ -295,11 +295,11 @@ static void __init ieee1394_path_component(struct device_node *dp, char *tmp_buf
295 regs = prop->value; 295 regs = prop->value;
296 296
297 if (regs[2] || regs[3]) { 297 if (regs[2] || regs[3]) {
298 sprintf(tmp_buf, "%s@%08x%08x,%04x%08x", 298 sprintf(tmp_buf, "%pOFn@%08x%08x,%04x%08x",
299 dp->name, regs[0], regs[1], regs[2], regs[3]); 299 dp, regs[0], regs[1], regs[2], regs[3]);
300 } else { 300 } else {
301 sprintf(tmp_buf, "%s@%08x%08x", 301 sprintf(tmp_buf, "%pOFn@%08x%08x",
302 dp->name, regs[0], regs[1]); 302 dp, regs[0], regs[1]);
303 } 303 }
304} 304}
305 305
@@ -361,7 +361,7 @@ char * __init build_path_component(struct device_node *dp)
361 tmp_buf[0] = '\0'; 361 tmp_buf[0] = '\0';
362 __build_path_component(dp, tmp_buf); 362 __build_path_component(dp, tmp_buf);
363 if (tmp_buf[0] == '\0') 363 if (tmp_buf[0] == '\0')
364 strcpy(tmp_buf, dp->name); 364 snprintf(tmp_buf, sizeof(tmp_buf), "%pOFn", dp);
365 365
366 n = prom_early_alloc(strlen(tmp_buf) + 1); 366 n = prom_early_alloc(strlen(tmp_buf) + 1);
367 strcpy(n, tmp_buf); 367 strcpy(n, tmp_buf);
diff --git a/arch/sparc/kernel/viohs.c b/arch/sparc/kernel/viohs.c
index 635d67ffc9a3..7db5aabe9708 100644
--- a/arch/sparc/kernel/viohs.c
+++ b/arch/sparc/kernel/viohs.c
@@ -180,11 +180,17 @@ static int send_dreg(struct vio_driver_state *vio)
180 struct vio_dring_register pkt; 180 struct vio_dring_register pkt;
181 char all[sizeof(struct vio_dring_register) + 181 char all[sizeof(struct vio_dring_register) +
182 (sizeof(struct ldc_trans_cookie) * 182 (sizeof(struct ldc_trans_cookie) *
183 dr->ncookies)]; 183 VIO_MAX_RING_COOKIES)];
184 } u; 184 } u;
185 size_t bytes = sizeof(struct vio_dring_register) +
186 (sizeof(struct ldc_trans_cookie) *
187 dr->ncookies);
185 int i; 188 int i;
186 189
187 memset(&u, 0, sizeof(u)); 190 if (WARN_ON(bytes > sizeof(u)))
191 return -EINVAL;
192
193 memset(&u, 0, bytes);
188 init_tag(&u.pkt.tag, VIO_TYPE_CTRL, VIO_SUBTYPE_INFO, VIO_DRING_REG); 194 init_tag(&u.pkt.tag, VIO_TYPE_CTRL, VIO_SUBTYPE_INFO, VIO_DRING_REG);
189 u.pkt.dring_ident = 0; 195 u.pkt.dring_ident = 0;
190 u.pkt.num_descr = dr->num_entries; 196 u.pkt.num_descr = dr->num_entries;
@@ -206,7 +212,7 @@ static int send_dreg(struct vio_driver_state *vio)
206 (unsigned long long) u.pkt.cookies[i].cookie_size); 212 (unsigned long long) u.pkt.cookies[i].cookie_size);
207 } 213 }
208 214
209 return send_ctrl(vio, &u.pkt.tag, sizeof(u)); 215 return send_ctrl(vio, &u.pkt.tag, bytes);
210} 216}
211 217
212static int send_rdx(struct vio_driver_state *vio) 218static int send_rdx(struct vio_driver_state *vio)
diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
index dd0b5a92ffd0..dc85570d8839 100644
--- a/arch/sparc/vdso/Makefile
+++ b/arch/sparc/vdso/Makefile
@@ -31,23 +31,21 @@ obj-y += $(vdso_img_objs)
31targets += $(vdso_img_cfiles) 31targets += $(vdso_img_cfiles)
32targets += $(vdso_img_sodbg) $(vdso_img-y:%=vdso%.so) 32targets += $(vdso_img_sodbg) $(vdso_img-y:%=vdso%.so)
33 33
34export CPPFLAGS_vdso.lds += -P -C 34CPPFLAGS_vdso.lds += -P -C
35 35
36VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ 36VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
37 -Wl,--no-undefined \ 37 -Wl,--no-undefined \
38 -Wl,-z,max-page-size=8192 -Wl,-z,common-page-size=8192 \ 38 -Wl,-z,max-page-size=8192 -Wl,-z,common-page-size=8192 \
39 $(DISABLE_LTO) 39 $(DISABLE_LTO)
40 40
41$(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE 41$(obj)/vdso64.so.dbg: $(obj)/vdso.lds $(vobjs) FORCE
42 $(call if_changed,vdso) 42 $(call if_changed,vdso)
43 43
44HOST_EXTRACFLAGS += -I$(srctree)/tools/include 44HOST_EXTRACFLAGS += -I$(srctree)/tools/include
45hostprogs-y += vdso2c 45hostprogs-y += vdso2c
46 46
47quiet_cmd_vdso2c = VDSO2C $@ 47quiet_cmd_vdso2c = VDSO2C $@
48define cmd_vdso2c 48 cmd_vdso2c = $(obj)/vdso2c $< $(<:%.dbg=%) $@
49 $(obj)/vdso2c $< $(<:%.dbg=%) $@
50endef
51 49
52$(obj)/vdso-image-%.c: $(obj)/vdso%.so.dbg $(obj)/vdso%.so $(obj)/vdso2c FORCE 50$(obj)/vdso-image-%.c: $(obj)/vdso%.so.dbg $(obj)/vdso%.so $(obj)/vdso2c FORCE
53 $(call if_changed,vdso2c) 51 $(call if_changed,vdso2c)
diff --git a/arch/x86/boot/compressed/mem_encrypt.S b/arch/x86/boot/compressed/mem_encrypt.S
index eaa843a52907..a480356e0ed8 100644
--- a/arch/x86/boot/compressed/mem_encrypt.S
+++ b/arch/x86/boot/compressed/mem_encrypt.S
@@ -25,20 +25,6 @@ ENTRY(get_sev_encryption_bit)
25 push %ebx 25 push %ebx
26 push %ecx 26 push %ecx
27 push %edx 27 push %edx
28 push %edi
29
30 /*
31 * RIP-relative addressing is needed to access the encryption bit
32 * variable. Since we are running in 32-bit mode we need this call/pop
33 * sequence to get the proper relative addressing.
34 */
35 call 1f
361: popl %edi
37 subl $1b, %edi
38
39 movl enc_bit(%edi), %eax
40 cmpl $0, %eax
41 jge .Lsev_exit
42 28
43 /* Check if running under a hypervisor */ 29 /* Check if running under a hypervisor */
44 movl $1, %eax 30 movl $1, %eax
@@ -69,15 +55,12 @@ ENTRY(get_sev_encryption_bit)
69 55
70 movl %ebx, %eax 56 movl %ebx, %eax
71 andl $0x3f, %eax /* Return the encryption bit location */ 57 andl $0x3f, %eax /* Return the encryption bit location */
72 movl %eax, enc_bit(%edi)
73 jmp .Lsev_exit 58 jmp .Lsev_exit
74 59
75.Lno_sev: 60.Lno_sev:
76 xor %eax, %eax 61 xor %eax, %eax
77 movl %eax, enc_bit(%edi)
78 62
79.Lsev_exit: 63.Lsev_exit:
80 pop %edi
81 pop %edx 64 pop %edx
82 pop %ecx 65 pop %ecx
83 pop %ebx 66 pop %ebx
@@ -113,8 +96,6 @@ ENTRY(set_sev_encryption_mask)
113ENDPROC(set_sev_encryption_mask) 96ENDPROC(set_sev_encryption_mask)
114 97
115 .data 98 .data
116enc_bit:
117 .int 0xffffffff
118 99
119#ifdef CONFIG_AMD_MEM_ENCRYPT 100#ifdef CONFIG_AMD_MEM_ENCRYPT
120 .balign 8 101 .balign 8
diff --git a/arch/x86/crypto/aegis128-aesni-glue.c b/arch/x86/crypto/aegis128-aesni-glue.c
index acd11b3bf639..2a356b948720 100644
--- a/arch/x86/crypto/aegis128-aesni-glue.c
+++ b/arch/x86/crypto/aegis128-aesni-glue.c
@@ -379,7 +379,6 @@ static int __init crypto_aegis128_aesni_module_init(void)
379{ 379{
380 if (!boot_cpu_has(X86_FEATURE_XMM2) || 380 if (!boot_cpu_has(X86_FEATURE_XMM2) ||
381 !boot_cpu_has(X86_FEATURE_AES) || 381 !boot_cpu_has(X86_FEATURE_AES) ||
382 !boot_cpu_has(X86_FEATURE_OSXSAVE) ||
383 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL)) 382 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL))
384 return -ENODEV; 383 return -ENODEV;
385 384
diff --git a/arch/x86/crypto/aegis128l-aesni-glue.c b/arch/x86/crypto/aegis128l-aesni-glue.c
index 2071c3d1ae07..dbe8bb980da1 100644
--- a/arch/x86/crypto/aegis128l-aesni-glue.c
+++ b/arch/x86/crypto/aegis128l-aesni-glue.c
@@ -379,7 +379,6 @@ static int __init crypto_aegis128l_aesni_module_init(void)
379{ 379{
380 if (!boot_cpu_has(X86_FEATURE_XMM2) || 380 if (!boot_cpu_has(X86_FEATURE_XMM2) ||
381 !boot_cpu_has(X86_FEATURE_AES) || 381 !boot_cpu_has(X86_FEATURE_AES) ||
382 !boot_cpu_has(X86_FEATURE_OSXSAVE) ||
383 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL)) 382 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL))
384 return -ENODEV; 383 return -ENODEV;
385 384
diff --git a/arch/x86/crypto/aegis256-aesni-glue.c b/arch/x86/crypto/aegis256-aesni-glue.c
index b5f2a8fd5a71..8bebda2de92f 100644
--- a/arch/x86/crypto/aegis256-aesni-glue.c
+++ b/arch/x86/crypto/aegis256-aesni-glue.c
@@ -379,7 +379,6 @@ static int __init crypto_aegis256_aesni_module_init(void)
379{ 379{
380 if (!boot_cpu_has(X86_FEATURE_XMM2) || 380 if (!boot_cpu_has(X86_FEATURE_XMM2) ||
381 !boot_cpu_has(X86_FEATURE_AES) || 381 !boot_cpu_has(X86_FEATURE_AES) ||
382 !boot_cpu_has(X86_FEATURE_OSXSAVE) ||
383 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL)) 382 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL))
384 return -ENODEV; 383 return -ENODEV;
385 384
diff --git a/arch/x86/crypto/morus1280-sse2-glue.c b/arch/x86/crypto/morus1280-sse2-glue.c
index 95cf857d2cbb..f40244eaf14d 100644
--- a/arch/x86/crypto/morus1280-sse2-glue.c
+++ b/arch/x86/crypto/morus1280-sse2-glue.c
@@ -40,7 +40,6 @@ MORUS1280_DECLARE_ALGS(sse2, "morus1280-sse2", 350);
40static int __init crypto_morus1280_sse2_module_init(void) 40static int __init crypto_morus1280_sse2_module_init(void)
41{ 41{
42 if (!boot_cpu_has(X86_FEATURE_XMM2) || 42 if (!boot_cpu_has(X86_FEATURE_XMM2) ||
43 !boot_cpu_has(X86_FEATURE_OSXSAVE) ||
44 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL)) 43 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL))
45 return -ENODEV; 44 return -ENODEV;
46 45
diff --git a/arch/x86/crypto/morus640-sse2-glue.c b/arch/x86/crypto/morus640-sse2-glue.c
index 615fb7bc9a32..9afaf8f8565a 100644
--- a/arch/x86/crypto/morus640-sse2-glue.c
+++ b/arch/x86/crypto/morus640-sse2-glue.c
@@ -40,7 +40,6 @@ MORUS640_DECLARE_ALGS(sse2, "morus640-sse2", 400);
40static int __init crypto_morus640_sse2_module_init(void) 40static int __init crypto_morus640_sse2_module_init(void)
41{ 41{
42 if (!boot_cpu_has(X86_FEATURE_XMM2) || 42 if (!boot_cpu_has(X86_FEATURE_XMM2) ||
43 !boot_cpu_has(X86_FEATURE_OSXSAVE) ||
44 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL)) 43 !cpu_has_xfeatures(XFEATURE_MASK_SSE, NULL))
45 return -ENODEV; 44 return -ENODEV;
46 45
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index fa3f439f0a92..141d415a8c80 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -68,7 +68,13 @@ $(obj)/vdso-image-%.c: $(obj)/vdso%.so.dbg $(obj)/vdso%.so $(obj)/vdso2c FORCE
68CFL := $(PROFILING) -mcmodel=small -fPIC -O2 -fasynchronous-unwind-tables -m64 \ 68CFL := $(PROFILING) -mcmodel=small -fPIC -O2 -fasynchronous-unwind-tables -m64 \
69 $(filter -g%,$(KBUILD_CFLAGS)) $(call cc-option, -fno-stack-protector) \ 69 $(filter -g%,$(KBUILD_CFLAGS)) $(call cc-option, -fno-stack-protector) \
70 -fno-omit-frame-pointer -foptimize-sibling-calls \ 70 -fno-omit-frame-pointer -foptimize-sibling-calls \
71 -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO $(RETPOLINE_VDSO_CFLAGS) 71 -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO
72
73ifdef CONFIG_RETPOLINE
74ifneq ($(RETPOLINE_VDSO_CFLAGS),)
75 CFL += $(RETPOLINE_VDSO_CFLAGS)
76endif
77endif
72 78
73$(vobjs): KBUILD_CFLAGS := $(filter-out $(GCC_PLUGINS_CFLAGS) $(RETPOLINE_CFLAGS),$(KBUILD_CFLAGS)) $(CFL) 79$(vobjs): KBUILD_CFLAGS := $(filter-out $(GCC_PLUGINS_CFLAGS) $(RETPOLINE_CFLAGS),$(KBUILD_CFLAGS)) $(CFL)
74 80
@@ -138,7 +144,13 @@ KBUILD_CFLAGS_32 += $(call cc-option, -fno-stack-protector)
138KBUILD_CFLAGS_32 += $(call cc-option, -foptimize-sibling-calls) 144KBUILD_CFLAGS_32 += $(call cc-option, -foptimize-sibling-calls)
139KBUILD_CFLAGS_32 += -fno-omit-frame-pointer 145KBUILD_CFLAGS_32 += -fno-omit-frame-pointer
140KBUILD_CFLAGS_32 += -DDISABLE_BRANCH_PROFILING 146KBUILD_CFLAGS_32 += -DDISABLE_BRANCH_PROFILING
141KBUILD_CFLAGS_32 += $(RETPOLINE_VDSO_CFLAGS) 147
148ifdef CONFIG_RETPOLINE
149ifneq ($(RETPOLINE_VDSO_CFLAGS),)
150 KBUILD_CFLAGS_32 += $(RETPOLINE_VDSO_CFLAGS)
151endif
152endif
153
142$(obj)/vdso32.so.dbg: KBUILD_CFLAGS = $(KBUILD_CFLAGS_32) 154$(obj)/vdso32.so.dbg: KBUILD_CFLAGS = $(KBUILD_CFLAGS_32)
143 155
144$(obj)/vdso32.so.dbg: FORCE \ 156$(obj)/vdso32.so.dbg: FORCE \
diff --git a/arch/x86/entry/vdso/vclock_gettime.c b/arch/x86/entry/vdso/vclock_gettime.c
index f19856d95c60..e48ca3afa091 100644
--- a/arch/x86/entry/vdso/vclock_gettime.c
+++ b/arch/x86/entry/vdso/vclock_gettime.c
@@ -43,8 +43,9 @@ extern u8 hvclock_page
43notrace static long vdso_fallback_gettime(long clock, struct timespec *ts) 43notrace static long vdso_fallback_gettime(long clock, struct timespec *ts)
44{ 44{
45 long ret; 45 long ret;
46 asm("syscall" : "=a" (ret) : 46 asm ("syscall" : "=a" (ret), "=m" (*ts) :
47 "0" (__NR_clock_gettime), "D" (clock), "S" (ts) : "memory"); 47 "0" (__NR_clock_gettime), "D" (clock), "S" (ts) :
48 "memory", "rcx", "r11");
48 return ret; 49 return ret;
49} 50}
50 51
@@ -52,8 +53,9 @@ notrace static long vdso_fallback_gtod(struct timeval *tv, struct timezone *tz)
52{ 53{
53 long ret; 54 long ret;
54 55
55 asm("syscall" : "=a" (ret) : 56 asm ("syscall" : "=a" (ret), "=m" (*tv), "=m" (*tz) :
56 "0" (__NR_gettimeofday), "D" (tv), "S" (tz) : "memory"); 57 "0" (__NR_gettimeofday), "D" (tv), "S" (tz) :
58 "memory", "rcx", "r11");
57 return ret; 59 return ret;
58} 60}
59 61
@@ -64,13 +66,13 @@ notrace static long vdso_fallback_gettime(long clock, struct timespec *ts)
64{ 66{
65 long ret; 67 long ret;
66 68
67 asm( 69 asm (
68 "mov %%ebx, %%edx \n" 70 "mov %%ebx, %%edx \n"
69 "mov %2, %%ebx \n" 71 "mov %[clock], %%ebx \n"
70 "call __kernel_vsyscall \n" 72 "call __kernel_vsyscall \n"
71 "mov %%edx, %%ebx \n" 73 "mov %%edx, %%ebx \n"
72 : "=a" (ret) 74 : "=a" (ret), "=m" (*ts)
73 : "0" (__NR_clock_gettime), "g" (clock), "c" (ts) 75 : "0" (__NR_clock_gettime), [clock] "g" (clock), "c" (ts)
74 : "memory", "edx"); 76 : "memory", "edx");
75 return ret; 77 return ret;
76} 78}
@@ -79,13 +81,13 @@ notrace static long vdso_fallback_gtod(struct timeval *tv, struct timezone *tz)
79{ 81{
80 long ret; 82 long ret;
81 83
82 asm( 84 asm (
83 "mov %%ebx, %%edx \n" 85 "mov %%ebx, %%edx \n"
84 "mov %2, %%ebx \n" 86 "mov %[tv], %%ebx \n"
85 "call __kernel_vsyscall \n" 87 "call __kernel_vsyscall \n"
86 "mov %%edx, %%ebx \n" 88 "mov %%edx, %%ebx \n"
87 : "=a" (ret) 89 : "=a" (ret), "=m" (*tv), "=m" (*tz)
88 : "0" (__NR_gettimeofday), "g" (tv), "c" (tz) 90 : "0" (__NR_gettimeofday), [tv] "g" (tv), "c" (tz)
89 : "memory", "edx"); 91 : "memory", "edx");
90 return ret; 92 return ret;
91} 93}
diff --git a/arch/x86/events/amd/uncore.c b/arch/x86/events/amd/uncore.c
index 981ba5e8241b..8671de126eac 100644
--- a/arch/x86/events/amd/uncore.c
+++ b/arch/x86/events/amd/uncore.c
@@ -36,6 +36,7 @@
36 36
37static int num_counters_llc; 37static int num_counters_llc;
38static int num_counters_nb; 38static int num_counters_nb;
39static bool l3_mask;
39 40
40static HLIST_HEAD(uncore_unused_list); 41static HLIST_HEAD(uncore_unused_list);
41 42
@@ -209,6 +210,13 @@ static int amd_uncore_event_init(struct perf_event *event)
209 hwc->config = event->attr.config & AMD64_RAW_EVENT_MASK_NB; 210 hwc->config = event->attr.config & AMD64_RAW_EVENT_MASK_NB;
210 hwc->idx = -1; 211 hwc->idx = -1;
211 212
213 /*
214 * SliceMask and ThreadMask need to be set for certain L3 events in
215 * Family 17h. For other events, the two fields do not affect the count.
216 */
217 if (l3_mask)
218 hwc->config |= (AMD64_L3_SLICE_MASK | AMD64_L3_THREAD_MASK);
219
212 if (event->cpu < 0) 220 if (event->cpu < 0)
213 return -EINVAL; 221 return -EINVAL;
214 222
@@ -525,6 +533,7 @@ static int __init amd_uncore_init(void)
525 amd_llc_pmu.name = "amd_l3"; 533 amd_llc_pmu.name = "amd_l3";
526 format_attr_event_df.show = &event_show_df; 534 format_attr_event_df.show = &event_show_df;
527 format_attr_event_l3.show = &event_show_l3; 535 format_attr_event_l3.show = &event_show_l3;
536 l3_mask = true;
528 } else { 537 } else {
529 num_counters_nb = NUM_COUNTERS_NB; 538 num_counters_nb = NUM_COUNTERS_NB;
530 num_counters_llc = NUM_COUNTERS_L2; 539 num_counters_llc = NUM_COUNTERS_L2;
@@ -532,6 +541,7 @@ static int __init amd_uncore_init(void)
532 amd_llc_pmu.name = "amd_l2"; 541 amd_llc_pmu.name = "amd_l2";
533 format_attr_event_df = format_attr_event; 542 format_attr_event_df = format_attr_event;
534 format_attr_event_l3 = format_attr_event; 543 format_attr_event_l3 = format_attr_event;
544 l3_mask = false;
535 } 545 }
536 546
537 amd_nb_pmu.attr_groups = amd_uncore_attr_groups_df; 547 amd_nb_pmu.attr_groups = amd_uncore_attr_groups_df;
diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
index f3e006bed9a7..c88ed39582a1 100644
--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c
@@ -1272,4 +1272,8 @@ void intel_pmu_lbr_init_knl(void)
1272 1272
1273 x86_pmu.lbr_sel_mask = LBR_SEL_MASK; 1273 x86_pmu.lbr_sel_mask = LBR_SEL_MASK;
1274 x86_pmu.lbr_sel_map = snb_lbr_sel_map; 1274 x86_pmu.lbr_sel_map = snb_lbr_sel_map;
1275
1276 /* Knights Landing does have MISPREDICT bit */
1277 if (x86_pmu.intel_cap.lbr_format == LBR_FORMAT_LIP)
1278 x86_pmu.intel_cap.lbr_format = LBR_FORMAT_EIP_FLAGS;
1275} 1279}
diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 51d7c117e3c7..c07bee31abe8 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3061,7 +3061,7 @@ static struct event_constraint bdx_uncore_pcu_constraints[] = {
3061 3061
3062void bdx_uncore_cpu_init(void) 3062void bdx_uncore_cpu_init(void)
3063{ 3063{
3064 int pkg = topology_phys_to_logical_pkg(0); 3064 int pkg = topology_phys_to_logical_pkg(boot_cpu_data.phys_proc_id);
3065 3065
3066 if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores) 3066 if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores)
3067 bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores; 3067 bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores;
@@ -3931,16 +3931,16 @@ static const struct pci_device_id skx_uncore_pci_ids[] = {
3931 .driver_data = UNCORE_PCI_DEV_FULL_DATA(21, 5, SKX_PCI_UNCORE_M2PCIE, 3), 3931 .driver_data = UNCORE_PCI_DEV_FULL_DATA(21, 5, SKX_PCI_UNCORE_M2PCIE, 3),
3932 }, 3932 },
3933 { /* M3UPI0 Link 0 */ 3933 { /* M3UPI0 Link 0 */
3934 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204C), 3934 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204D),
3935 .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 0, SKX_PCI_UNCORE_M3UPI, 0), 3935 .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 1, SKX_PCI_UNCORE_M3UPI, 0),
3936 }, 3936 },
3937 { /* M3UPI0 Link 1 */ 3937 { /* M3UPI0 Link 1 */
3938 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204D), 3938 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204E),
3939 .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 1, SKX_PCI_UNCORE_M3UPI, 1), 3939 .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 2, SKX_PCI_UNCORE_M3UPI, 1),
3940 }, 3940 },
3941 { /* M3UPI1 Link 2 */ 3941 { /* M3UPI1 Link 2 */
3942 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204C), 3942 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204D),
3943 .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 4, SKX_PCI_UNCORE_M3UPI, 2), 3943 .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 5, SKX_PCI_UNCORE_M3UPI, 2),
3944 }, 3944 },
3945 { /* end: all zeroes */ } 3945 { /* end: all zeroes */ }
3946}; 3946};
diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
index 5b0f613428c2..2c43e3055948 100644
--- a/arch/x86/hyperv/hv_apic.c
+++ b/arch/x86/hyperv/hv_apic.c
@@ -95,8 +95,8 @@ static void hv_apic_eoi_write(u32 reg, u32 val)
95 */ 95 */
96static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector) 96static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector)
97{ 97{
98 struct ipi_arg_ex **arg; 98 struct hv_send_ipi_ex **arg;
99 struct ipi_arg_ex *ipi_arg; 99 struct hv_send_ipi_ex *ipi_arg;
100 unsigned long flags; 100 unsigned long flags;
101 int nr_bank = 0; 101 int nr_bank = 0;
102 int ret = 1; 102 int ret = 1;
@@ -105,7 +105,7 @@ static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector)
105 return false; 105 return false;
106 106
107 local_irq_save(flags); 107 local_irq_save(flags);
108 arg = (struct ipi_arg_ex **)this_cpu_ptr(hyperv_pcpu_input_arg); 108 arg = (struct hv_send_ipi_ex **)this_cpu_ptr(hyperv_pcpu_input_arg);
109 109
110 ipi_arg = *arg; 110 ipi_arg = *arg;
111 if (unlikely(!ipi_arg)) 111 if (unlikely(!ipi_arg))
@@ -135,7 +135,7 @@ ipi_mask_ex_done:
135static bool __send_ipi_mask(const struct cpumask *mask, int vector) 135static bool __send_ipi_mask(const struct cpumask *mask, int vector)
136{ 136{
137 int cur_cpu, vcpu; 137 int cur_cpu, vcpu;
138 struct ipi_arg_non_ex ipi_arg; 138 struct hv_send_ipi ipi_arg;
139 int ret = 1; 139 int ret = 1;
140 140
141 trace_hyperv_send_ipi_mask(mask, vector); 141 trace_hyperv_send_ipi_mask(mask, vector);
diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
index e203169931c7..6390bd8c141b 100644
--- a/arch/x86/include/asm/fixmap.h
+++ b/arch/x86/include/asm/fixmap.h
@@ -14,6 +14,16 @@
14#ifndef _ASM_X86_FIXMAP_H 14#ifndef _ASM_X86_FIXMAP_H
15#define _ASM_X86_FIXMAP_H 15#define _ASM_X86_FIXMAP_H
16 16
17/*
18 * Exposed to assembly code for setting up initial page tables. Cannot be
19 * calculated in assembly code (fixmap entries are an enum), but is sanity
20 * checked in the actual fixmap C code to make sure that the fixmap is
21 * covered fully.
22 */
23#define FIXMAP_PMD_NUM 2
24/* fixmap starts downwards from the 507th entry in level2_fixmap_pgt */
25#define FIXMAP_PMD_TOP 507
26
17#ifndef __ASSEMBLY__ 27#ifndef __ASSEMBLY__
18#include <linux/kernel.h> 28#include <linux/kernel.h>
19#include <asm/acpi.h> 29#include <asm/acpi.h>
diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h
index e977b6b3a538..00e01d215f74 100644
--- a/arch/x86/include/asm/hyperv-tlfs.h
+++ b/arch/x86/include/asm/hyperv-tlfs.h
@@ -726,19 +726,21 @@ struct hv_enlightened_vmcs {
726#define HV_STIMER_AUTOENABLE (1ULL << 3) 726#define HV_STIMER_AUTOENABLE (1ULL << 3)
727#define HV_STIMER_SINT(config) (__u8)(((config) >> 16) & 0x0F) 727#define HV_STIMER_SINT(config) (__u8)(((config) >> 16) & 0x0F)
728 728
729struct ipi_arg_non_ex {
730 u32 vector;
731 u32 reserved;
732 u64 cpu_mask;
733};
734
735struct hv_vpset { 729struct hv_vpset {
736 u64 format; 730 u64 format;
737 u64 valid_bank_mask; 731 u64 valid_bank_mask;
738 u64 bank_contents[]; 732 u64 bank_contents[];
739}; 733};
740 734
741struct ipi_arg_ex { 735/* HvCallSendSyntheticClusterIpi hypercall */
736struct hv_send_ipi {
737 u32 vector;
738 u32 reserved;
739 u64 cpu_mask;
740};
741
742/* HvCallSendSyntheticClusterIpiEx hypercall */
743struct hv_send_ipi_ex {
742 u32 vector; 744 u32 vector;
743 u32 reserved; 745 u32 reserved;
744 struct hv_vpset vp_set; 746 struct hv_vpset vp_set;
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 8e90488c3d56..09b2e3e2cf1b 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -869,6 +869,8 @@ struct kvm_arch {
869 869
870 bool x2apic_format; 870 bool x2apic_format;
871 bool x2apic_broadcast_quirk_disabled; 871 bool x2apic_broadcast_quirk_disabled;
872
873 bool guest_can_read_msr_platform_info;
872}; 874};
873 875
874struct kvm_vm_stat { 876struct kvm_vm_stat {
@@ -1022,6 +1024,7 @@ struct kvm_x86_ops {
1022 void (*refresh_apicv_exec_ctrl)(struct kvm_vcpu *vcpu); 1024 void (*refresh_apicv_exec_ctrl)(struct kvm_vcpu *vcpu);
1023 void (*hwapic_irr_update)(struct kvm_vcpu *vcpu, int max_irr); 1025 void (*hwapic_irr_update)(struct kvm_vcpu *vcpu, int max_irr);
1024 void (*hwapic_isr_update)(struct kvm_vcpu *vcpu, int isr); 1026 void (*hwapic_isr_update)(struct kvm_vcpu *vcpu, int isr);
1027 bool (*guest_apic_has_interrupt)(struct kvm_vcpu *vcpu);
1025 void (*load_eoi_exitmap)(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap); 1028 void (*load_eoi_exitmap)(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap);
1026 void (*set_virtual_apic_mode)(struct kvm_vcpu *vcpu); 1029 void (*set_virtual_apic_mode)(struct kvm_vcpu *vcpu);
1027 void (*set_apic_access_page_addr)(struct kvm_vcpu *vcpu, hpa_t hpa); 1030 void (*set_apic_access_page_addr)(struct kvm_vcpu *vcpu, hpa_t hpa);
@@ -1055,6 +1058,7 @@ struct kvm_x86_ops {
1055 bool (*umip_emulated)(void); 1058 bool (*umip_emulated)(void);
1056 1059
1057 int (*check_nested_events)(struct kvm_vcpu *vcpu, bool external_intr); 1060 int (*check_nested_events)(struct kvm_vcpu *vcpu, bool external_intr);
1061 void (*request_immediate_exit)(struct kvm_vcpu *vcpu);
1058 1062
1059 void (*sched_in)(struct kvm_vcpu *kvm, int cpu); 1063 void (*sched_in)(struct kvm_vcpu *kvm, int cpu);
1060 1064
@@ -1482,6 +1486,7 @@ extern bool kvm_find_async_pf_gfn(struct kvm_vcpu *vcpu, gfn_t gfn);
1482 1486
1483int kvm_skip_emulated_instruction(struct kvm_vcpu *vcpu); 1487int kvm_skip_emulated_instruction(struct kvm_vcpu *vcpu);
1484int kvm_complete_insn_gp(struct kvm_vcpu *vcpu, int err); 1488int kvm_complete_insn_gp(struct kvm_vcpu *vcpu, int err);
1489void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu);
1485 1490
1486int kvm_is_in_guest(void); 1491int kvm_is_in_guest(void);
1487 1492
diff --git a/arch/x86/include/asm/mem_encrypt.h b/arch/x86/include/asm/mem_encrypt.h
index c0643831706e..616f8e637bc3 100644
--- a/arch/x86/include/asm/mem_encrypt.h
+++ b/arch/x86/include/asm/mem_encrypt.h
@@ -48,10 +48,13 @@ int __init early_set_memory_encrypted(unsigned long vaddr, unsigned long size);
48 48
49/* Architecture __weak replacement functions */ 49/* Architecture __weak replacement functions */
50void __init mem_encrypt_init(void); 50void __init mem_encrypt_init(void);
51void __init mem_encrypt_free_decrypted_mem(void);
51 52
52bool sme_active(void); 53bool sme_active(void);
53bool sev_active(void); 54bool sev_active(void);
54 55
56#define __bss_decrypted __attribute__((__section__(".bss..decrypted")))
57
55#else /* !CONFIG_AMD_MEM_ENCRYPT */ 58#else /* !CONFIG_AMD_MEM_ENCRYPT */
56 59
57#define sme_me_mask 0ULL 60#define sme_me_mask 0ULL
@@ -77,6 +80,8 @@ early_set_memory_decrypted(unsigned long vaddr, unsigned long size) { return 0;
77static inline int __init 80static inline int __init
78early_set_memory_encrypted(unsigned long vaddr, unsigned long size) { return 0; } 81early_set_memory_encrypted(unsigned long vaddr, unsigned long size) { return 0; }
79 82
83#define __bss_decrypted
84
80#endif /* CONFIG_AMD_MEM_ENCRYPT */ 85#endif /* CONFIG_AMD_MEM_ENCRYPT */
81 86
82/* 87/*
@@ -88,6 +93,8 @@ early_set_memory_encrypted(unsigned long vaddr, unsigned long size) { return 0;
88#define __sme_pa(x) (__pa(x) | sme_me_mask) 93#define __sme_pa(x) (__pa(x) | sme_me_mask)
89#define __sme_pa_nodebug(x) (__pa_nodebug(x) | sme_me_mask) 94#define __sme_pa_nodebug(x) (__pa_nodebug(x) | sme_me_mask)
90 95
96extern char __start_bss_decrypted[], __end_bss_decrypted[], __start_bss_decrypted_unused[];
97
91#endif /* __ASSEMBLY__ */ 98#endif /* __ASSEMBLY__ */
92 99
93#endif /* __X86_MEM_ENCRYPT_H__ */ 100#endif /* __X86_MEM_ENCRYPT_H__ */
diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
index 12f54082f4c8..78241b736f2a 100644
--- a/arch/x86/include/asm/perf_event.h
+++ b/arch/x86/include/asm/perf_event.h
@@ -46,6 +46,14 @@
46#define INTEL_ARCH_EVENT_MASK \ 46#define INTEL_ARCH_EVENT_MASK \
47 (ARCH_PERFMON_EVENTSEL_UMASK | ARCH_PERFMON_EVENTSEL_EVENT) 47 (ARCH_PERFMON_EVENTSEL_UMASK | ARCH_PERFMON_EVENTSEL_EVENT)
48 48
49#define AMD64_L3_SLICE_SHIFT 48
50#define AMD64_L3_SLICE_MASK \
51 ((0xFULL) << AMD64_L3_SLICE_SHIFT)
52
53#define AMD64_L3_THREAD_SHIFT 56
54#define AMD64_L3_THREAD_MASK \
55 ((0xFFULL) << AMD64_L3_THREAD_SHIFT)
56
49#define X86_RAW_EVENT_MASK \ 57#define X86_RAW_EVENT_MASK \
50 (ARCH_PERFMON_EVENTSEL_EVENT | \ 58 (ARCH_PERFMON_EVENTSEL_EVENT | \
51 ARCH_PERFMON_EVENTSEL_UMASK | \ 59 ARCH_PERFMON_EVENTSEL_UMASK | \
diff --git a/arch/x86/include/asm/pgtable-2level.h b/arch/x86/include/asm/pgtable-2level.h
index 24c6cf5f16b7..60d0f9015317 100644
--- a/arch/x86/include/asm/pgtable-2level.h
+++ b/arch/x86/include/asm/pgtable-2level.h
@@ -19,9 +19,6 @@ static inline void native_set_pte(pte_t *ptep , pte_t pte)
19 19
20static inline void native_set_pmd(pmd_t *pmdp, pmd_t pmd) 20static inline void native_set_pmd(pmd_t *pmdp, pmd_t pmd)
21{ 21{
22#ifdef CONFIG_PAGE_TABLE_ISOLATION
23 pmd.pud.p4d.pgd = pti_set_user_pgtbl(&pmdp->pud.p4d.pgd, pmd.pud.p4d.pgd);
24#endif
25 *pmdp = pmd; 22 *pmdp = pmd;
26} 23}
27 24
@@ -61,9 +58,6 @@ static inline pte_t native_ptep_get_and_clear(pte_t *xp)
61#ifdef CONFIG_SMP 58#ifdef CONFIG_SMP
62static inline pmd_t native_pmdp_get_and_clear(pmd_t *xp) 59static inline pmd_t native_pmdp_get_and_clear(pmd_t *xp)
63{ 60{
64#ifdef CONFIG_PAGE_TABLE_ISOLATION
65 pti_set_user_pgtbl(&xp->pud.p4d.pgd, __pgd(0));
66#endif
67 return __pmd(xchg((pmdval_t *)xp, 0)); 61 return __pmd(xchg((pmdval_t *)xp, 0));
68} 62}
69#else 63#else
@@ -73,9 +67,6 @@ static inline pmd_t native_pmdp_get_and_clear(pmd_t *xp)
73#ifdef CONFIG_SMP 67#ifdef CONFIG_SMP
74static inline pud_t native_pudp_get_and_clear(pud_t *xp) 68static inline pud_t native_pudp_get_and_clear(pud_t *xp)
75{ 69{
76#ifdef CONFIG_PAGE_TABLE_ISOLATION
77 pti_set_user_pgtbl(&xp->p4d.pgd, __pgd(0));
78#endif
79 return __pud(xchg((pudval_t *)xp, 0)); 70 return __pud(xchg((pudval_t *)xp, 0));
80} 71}
81#else 72#else
diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h
index ce2b59047cb8..9c85b54bf03c 100644
--- a/arch/x86/include/asm/pgtable_64.h
+++ b/arch/x86/include/asm/pgtable_64.h
@@ -14,6 +14,7 @@
14#include <asm/processor.h> 14#include <asm/processor.h>
15#include <linux/bitops.h> 15#include <linux/bitops.h>
16#include <linux/threads.h> 16#include <linux/threads.h>
17#include <asm/fixmap.h>
17 18
18extern p4d_t level4_kernel_pgt[512]; 19extern p4d_t level4_kernel_pgt[512];
19extern p4d_t level4_ident_pgt[512]; 20extern p4d_t level4_ident_pgt[512];
@@ -22,7 +23,7 @@ extern pud_t level3_ident_pgt[512];
22extern pmd_t level2_kernel_pgt[512]; 23extern pmd_t level2_kernel_pgt[512];
23extern pmd_t level2_fixmap_pgt[512]; 24extern pmd_t level2_fixmap_pgt[512];
24extern pmd_t level2_ident_pgt[512]; 25extern pmd_t level2_ident_pgt[512];
25extern pte_t level1_fixmap_pgt[512]; 26extern pte_t level1_fixmap_pgt[512 * FIXMAP_PMD_NUM];
26extern pgd_t init_top_pgt[]; 27extern pgd_t init_top_pgt[];
27 28
28#define swapper_pg_dir init_top_pgt 29#define swapper_pg_dir init_top_pgt
diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
index b64acb08a62b..106b7d0e2dae 100644
--- a/arch/x86/include/asm/pgtable_types.h
+++ b/arch/x86/include/asm/pgtable_types.h
@@ -124,7 +124,7 @@
124 */ 124 */
125#define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | \ 125#define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | \
126 _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY | \ 126 _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY | \
127 _PAGE_SOFT_DIRTY) 127 _PAGE_SOFT_DIRTY | _PAGE_DEVMAP)
128#define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE) 128#define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE)
129 129
130/* 130/*
diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
index a80c0673798f..e60c45fd3679 100644
--- a/arch/x86/include/asm/uv/uv.h
+++ b/arch/x86/include/asm/uv/uv.h
@@ -10,8 +10,13 @@ struct cpumask;
10struct mm_struct; 10struct mm_struct;
11 11
12#ifdef CONFIG_X86_UV 12#ifdef CONFIG_X86_UV
13#include <linux/efi.h>
13 14
14extern enum uv_system_type get_uv_system_type(void); 15extern enum uv_system_type get_uv_system_type(void);
16static inline bool is_early_uv_system(void)
17{
18 return !((efi.uv_systab == EFI_INVALID_TABLE_ADDR) || !efi.uv_systab);
19}
15extern int is_uv_system(void); 20extern int is_uv_system(void);
16extern int is_uv_hubless(void); 21extern int is_uv_hubless(void);
17extern void uv_cpu_init(void); 22extern void uv_cpu_init(void);
@@ -23,6 +28,7 @@ extern const struct cpumask *uv_flush_tlb_others(const struct cpumask *cpumask,
23#else /* X86_UV */ 28#else /* X86_UV */
24 29
25static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; } 30static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; }
31static inline bool is_early_uv_system(void) { return 0; }
26static inline int is_uv_system(void) { return 0; } 32static inline int is_uv_system(void) { return 0; }
27static inline int is_uv_hubless(void) { return 0; } 33static inline int is_uv_hubless(void) { return 0; }
28static inline void uv_cpu_init(void) { } 34static inline void uv_cpu_init(void) { }
diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h
index 86299efa804a..fd23d5778ea1 100644
--- a/arch/x86/include/uapi/asm/kvm.h
+++ b/arch/x86/include/uapi/asm/kvm.h
@@ -377,6 +377,7 @@ struct kvm_sync_regs {
377 377
378#define KVM_X86_QUIRK_LINT0_REENABLED (1 << 0) 378#define KVM_X86_QUIRK_LINT0_REENABLED (1 << 0)
379#define KVM_X86_QUIRK_CD_NW_CLEARED (1 << 1) 379#define KVM_X86_QUIRK_CD_NW_CLEARED (1 << 1)
380#define KVM_X86_QUIRK_LAPIC_MMIO_HOLE (1 << 2)
380 381
381#define KVM_STATE_NESTED_GUEST_MODE 0x00000001 382#define KVM_STATE_NESTED_GUEST_MODE 0x00000001
382#define KVM_STATE_NESTED_RUN_PENDING 0x00000002 383#define KVM_STATE_NESTED_RUN_PENDING 0x00000002
diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
index ec00d1ff5098..f7151cd03cb0 100644
--- a/arch/x86/kernel/apm_32.c
+++ b/arch/x86/kernel/apm_32.c
@@ -1640,6 +1640,7 @@ static int do_open(struct inode *inode, struct file *filp)
1640 return 0; 1640 return 0;
1641} 1641}
1642 1642
1643#ifdef CONFIG_PROC_FS
1643static int proc_apm_show(struct seq_file *m, void *v) 1644static int proc_apm_show(struct seq_file *m, void *v)
1644{ 1645{
1645 unsigned short bx; 1646 unsigned short bx;
@@ -1719,6 +1720,7 @@ static int proc_apm_show(struct seq_file *m, void *v)
1719 units); 1720 units);
1720 return 0; 1721 return 0;
1721} 1722}
1723#endif
1722 1724
1723static int apm(void *unused) 1725static int apm(void *unused)
1724{ 1726{
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 22ab408177b2..eeea634bee0a 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -922,7 +922,7 @@ static void init_amd(struct cpuinfo_x86 *c)
922static unsigned int amd_size_cache(struct cpuinfo_x86 *c, unsigned int size) 922static unsigned int amd_size_cache(struct cpuinfo_x86 *c, unsigned int size)
923{ 923{
924 /* AMD errata T13 (order #21922) */ 924 /* AMD errata T13 (order #21922) */
925 if ((c->x86 == 6)) { 925 if (c->x86 == 6) {
926 /* Duron Rev A0 */ 926 /* Duron Rev A0 */
927 if (c->x86_model == 3 && c->x86_stepping == 0) 927 if (c->x86_model == 3 && c->x86_stepping == 0)
928 size = 64; 928 size = 64;
diff --git a/arch/x86/kernel/cpu/intel_rdt.h b/arch/x86/kernel/cpu/intel_rdt.h
index 4e588f36228f..3736f6dc9545 100644
--- a/arch/x86/kernel/cpu/intel_rdt.h
+++ b/arch/x86/kernel/cpu/intel_rdt.h
@@ -382,6 +382,11 @@ static inline bool is_mbm_event(int e)
382 e <= QOS_L3_MBM_LOCAL_EVENT_ID); 382 e <= QOS_L3_MBM_LOCAL_EVENT_ID);
383} 383}
384 384
385struct rdt_parse_data {
386 struct rdtgroup *rdtgrp;
387 char *buf;
388};
389
385/** 390/**
386 * struct rdt_resource - attributes of an RDT resource 391 * struct rdt_resource - attributes of an RDT resource
387 * @rid: The index of the resource 392 * @rid: The index of the resource
@@ -423,16 +428,19 @@ struct rdt_resource {
423 struct rdt_cache cache; 428 struct rdt_cache cache;
424 struct rdt_membw membw; 429 struct rdt_membw membw;
425 const char *format_str; 430 const char *format_str;
426 int (*parse_ctrlval) (void *data, struct rdt_resource *r, 431 int (*parse_ctrlval)(struct rdt_parse_data *data,
427 struct rdt_domain *d); 432 struct rdt_resource *r,
433 struct rdt_domain *d);
428 struct list_head evt_list; 434 struct list_head evt_list;
429 int num_rmid; 435 int num_rmid;
430 unsigned int mon_scale; 436 unsigned int mon_scale;
431 unsigned long fflags; 437 unsigned long fflags;
432}; 438};
433 439
434int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d); 440int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r,
435int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d); 441 struct rdt_domain *d);
442int parse_bw(struct rdt_parse_data *data, struct rdt_resource *r,
443 struct rdt_domain *d);
436 444
437extern struct mutex rdtgroup_mutex; 445extern struct mutex rdtgroup_mutex;
438 446
@@ -521,14 +529,14 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of,
521int rdtgroup_schemata_show(struct kernfs_open_file *of, 529int rdtgroup_schemata_show(struct kernfs_open_file *of,
522 struct seq_file *s, void *v); 530 struct seq_file *s, void *v);
523bool rdtgroup_cbm_overlaps(struct rdt_resource *r, struct rdt_domain *d, 531bool rdtgroup_cbm_overlaps(struct rdt_resource *r, struct rdt_domain *d,
524 u32 _cbm, int closid, bool exclusive); 532 unsigned long cbm, int closid, bool exclusive);
525unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r, struct rdt_domain *d, 533unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r, struct rdt_domain *d,
526 u32 cbm); 534 unsigned long cbm);
527enum rdtgrp_mode rdtgroup_mode_by_closid(int closid); 535enum rdtgrp_mode rdtgroup_mode_by_closid(int closid);
528int rdtgroup_tasks_assigned(struct rdtgroup *r); 536int rdtgroup_tasks_assigned(struct rdtgroup *r);
529int rdtgroup_locksetup_enter(struct rdtgroup *rdtgrp); 537int rdtgroup_locksetup_enter(struct rdtgroup *rdtgrp);
530int rdtgroup_locksetup_exit(struct rdtgroup *rdtgrp); 538int rdtgroup_locksetup_exit(struct rdtgroup *rdtgrp);
531bool rdtgroup_cbm_overlaps_pseudo_locked(struct rdt_domain *d, u32 _cbm); 539bool rdtgroup_cbm_overlaps_pseudo_locked(struct rdt_domain *d, unsigned long cbm);
532bool rdtgroup_pseudo_locked_in_hierarchy(struct rdt_domain *d); 540bool rdtgroup_pseudo_locked_in_hierarchy(struct rdt_domain *d);
533int rdt_pseudo_lock_init(void); 541int rdt_pseudo_lock_init(void);
534void rdt_pseudo_lock_release(void); 542void rdt_pseudo_lock_release(void);
@@ -536,6 +544,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp);
536void rdtgroup_pseudo_lock_remove(struct rdtgroup *rdtgrp); 544void rdtgroup_pseudo_lock_remove(struct rdtgroup *rdtgrp);
537struct rdt_domain *get_domain_from_cpu(int cpu, struct rdt_resource *r); 545struct rdt_domain *get_domain_from_cpu(int cpu, struct rdt_resource *r);
538int update_domains(struct rdt_resource *r, int closid); 546int update_domains(struct rdt_resource *r, int closid);
547int closids_supported(void);
539void closid_free(int closid); 548void closid_free(int closid);
540int alloc_rmid(void); 549int alloc_rmid(void);
541void free_rmid(u32 rmid); 550void free_rmid(u32 rmid);
diff --git a/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c b/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c
index af358ca05160..0f53049719cd 100644
--- a/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c
+++ b/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c
@@ -64,19 +64,19 @@ static bool bw_validate(char *buf, unsigned long *data, struct rdt_resource *r)
64 return true; 64 return true;
65} 65}
66 66
67int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d) 67int parse_bw(struct rdt_parse_data *data, struct rdt_resource *r,
68 struct rdt_domain *d)
68{ 69{
69 unsigned long data; 70 unsigned long bw_val;
70 char *buf = _buf;
71 71
72 if (d->have_new_ctrl) { 72 if (d->have_new_ctrl) {
73 rdt_last_cmd_printf("duplicate domain %d\n", d->id); 73 rdt_last_cmd_printf("duplicate domain %d\n", d->id);
74 return -EINVAL; 74 return -EINVAL;
75 } 75 }
76 76
77 if (!bw_validate(buf, &data, r)) 77 if (!bw_validate(data->buf, &bw_val, r))
78 return -EINVAL; 78 return -EINVAL;
79 d->new_ctrl = data; 79 d->new_ctrl = bw_val;
80 d->have_new_ctrl = true; 80 d->have_new_ctrl = true;
81 81
82 return 0; 82 return 0;
@@ -123,18 +123,13 @@ static bool cbm_validate(char *buf, u32 *data, struct rdt_resource *r)
123 return true; 123 return true;
124} 124}
125 125
126struct rdt_cbm_parse_data {
127 struct rdtgroup *rdtgrp;
128 char *buf;
129};
130
131/* 126/*
132 * Read one cache bit mask (hex). Check that it is valid for the current 127 * Read one cache bit mask (hex). Check that it is valid for the current
133 * resource type. 128 * resource type.
134 */ 129 */
135int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d) 130int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r,
131 struct rdt_domain *d)
136{ 132{
137 struct rdt_cbm_parse_data *data = _data;
138 struct rdtgroup *rdtgrp = data->rdtgrp; 133 struct rdtgroup *rdtgrp = data->rdtgrp;
139 u32 cbm_val; 134 u32 cbm_val;
140 135
@@ -195,11 +190,17 @@ int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d)
195static int parse_line(char *line, struct rdt_resource *r, 190static int parse_line(char *line, struct rdt_resource *r,
196 struct rdtgroup *rdtgrp) 191 struct rdtgroup *rdtgrp)
197{ 192{
198 struct rdt_cbm_parse_data data; 193 struct rdt_parse_data data;
199 char *dom = NULL, *id; 194 char *dom = NULL, *id;
200 struct rdt_domain *d; 195 struct rdt_domain *d;
201 unsigned long dom_id; 196 unsigned long dom_id;
202 197
198 if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP &&
199 r->rid == RDT_RESOURCE_MBA) {
200 rdt_last_cmd_puts("Cannot pseudo-lock MBA resource\n");
201 return -EINVAL;
202 }
203
203next: 204next:
204 if (!line || line[0] == '\0') 205 if (!line || line[0] == '\0')
205 return 0; 206 return 0;
diff --git a/arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c b/arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c
index 40f3903ae5d9..f8c260d522ca 100644
--- a/arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c
+++ b/arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c
@@ -797,25 +797,27 @@ int rdtgroup_locksetup_exit(struct rdtgroup *rdtgrp)
797/** 797/**
798 * rdtgroup_cbm_overlaps_pseudo_locked - Test if CBM or portion is pseudo-locked 798 * rdtgroup_cbm_overlaps_pseudo_locked - Test if CBM or portion is pseudo-locked
799 * @d: RDT domain 799 * @d: RDT domain
800 * @_cbm: CBM to test 800 * @cbm: CBM to test
801 * 801 *
802 * @d represents a cache instance and @_cbm a capacity bitmask that is 802 * @d represents a cache instance and @cbm a capacity bitmask that is
803 * considered for it. Determine if @_cbm overlaps with any existing 803 * considered for it. Determine if @cbm overlaps with any existing
804 * pseudo-locked region on @d. 804 * pseudo-locked region on @d.
805 * 805 *
806 * Return: true if @_cbm overlaps with pseudo-locked region on @d, false 806 * @cbm is unsigned long, even if only 32 bits are used, to make the
807 * bitmap functions work correctly.
808 *
809 * Return: true if @cbm overlaps with pseudo-locked region on @d, false
807 * otherwise. 810 * otherwise.
808 */ 811 */
809bool rdtgroup_cbm_overlaps_pseudo_locked(struct rdt_domain *d, u32 _cbm) 812bool rdtgroup_cbm_overlaps_pseudo_locked(struct rdt_domain *d, unsigned long cbm)
810{ 813{
811 unsigned long *cbm = (unsigned long *)&_cbm;
812 unsigned long *cbm_b;
813 unsigned int cbm_len; 814 unsigned int cbm_len;
815 unsigned long cbm_b;
814 816
815 if (d->plr) { 817 if (d->plr) {
816 cbm_len = d->plr->r->cache.cbm_len; 818 cbm_len = d->plr->r->cache.cbm_len;
817 cbm_b = (unsigned long *)&d->plr->cbm; 819 cbm_b = d->plr->cbm;
818 if (bitmap_intersects(cbm, cbm_b, cbm_len)) 820 if (bitmap_intersects(&cbm, &cbm_b, cbm_len))
819 return true; 821 return true;
820 } 822 }
821 return false; 823 return false;
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index b799c00bef09..b140c68bc14b 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -97,6 +97,12 @@ void rdt_last_cmd_printf(const char *fmt, ...)
97 * limited as the number of resources grows. 97 * limited as the number of resources grows.
98 */ 98 */
99static int closid_free_map; 99static int closid_free_map;
100static int closid_free_map_len;
101
102int closids_supported(void)
103{
104 return closid_free_map_len;
105}
100 106
101static void closid_init(void) 107static void closid_init(void)
102{ 108{
@@ -111,6 +117,7 @@ static void closid_init(void)
111 117
112 /* CLOSID 0 is always reserved for the default group */ 118 /* CLOSID 0 is always reserved for the default group */
113 closid_free_map &= ~1; 119 closid_free_map &= ~1;
120 closid_free_map_len = rdt_min_closid;
114} 121}
115 122
116static int closid_alloc(void) 123static int closid_alloc(void)
@@ -802,7 +809,7 @@ static int rdt_bit_usage_show(struct kernfs_open_file *of,
802 sw_shareable = 0; 809 sw_shareable = 0;
803 exclusive = 0; 810 exclusive = 0;
804 seq_printf(seq, "%d=", dom->id); 811 seq_printf(seq, "%d=", dom->id);
805 for (i = 0; i < r->num_closid; i++, ctrl++) { 812 for (i = 0; i < closids_supported(); i++, ctrl++) {
806 if (!closid_allocated(i)) 813 if (!closid_allocated(i))
807 continue; 814 continue;
808 mode = rdtgroup_mode_by_closid(i); 815 mode = rdtgroup_mode_by_closid(i);
@@ -968,33 +975,34 @@ static int rdtgroup_mode_show(struct kernfs_open_file *of,
968 * is false then overlaps with any resource group or hardware entities 975 * is false then overlaps with any resource group or hardware entities
969 * will be considered. 976 * will be considered.
970 * 977 *
978 * @cbm is unsigned long, even if only 32 bits are used, to make the
979 * bitmap functions work correctly.
980 *
971 * Return: false if CBM does not overlap, true if it does. 981 * Return: false if CBM does not overlap, true if it does.
972 */ 982 */
973bool rdtgroup_cbm_overlaps(struct rdt_resource *r, struct rdt_domain *d, 983bool rdtgroup_cbm_overlaps(struct rdt_resource *r, struct rdt_domain *d,
974 u32 _cbm, int closid, bool exclusive) 984 unsigned long cbm, int closid, bool exclusive)
975{ 985{
976 unsigned long *cbm = (unsigned long *)&_cbm;
977 unsigned long *ctrl_b;
978 enum rdtgrp_mode mode; 986 enum rdtgrp_mode mode;
987 unsigned long ctrl_b;
979 u32 *ctrl; 988 u32 *ctrl;
980 int i; 989 int i;
981 990
982 /* Check for any overlap with regions used by hardware directly */ 991 /* Check for any overlap with regions used by hardware directly */
983 if (!exclusive) { 992 if (!exclusive) {
984 if (bitmap_intersects(cbm, 993 ctrl_b = r->cache.shareable_bits;
985 (unsigned long *)&r->cache.shareable_bits, 994 if (bitmap_intersects(&cbm, &ctrl_b, r->cache.cbm_len))
986 r->cache.cbm_len))
987 return true; 995 return true;
988 } 996 }
989 997
990 /* Check for overlap with other resource groups */ 998 /* Check for overlap with other resource groups */
991 ctrl = d->ctrl_val; 999 ctrl = d->ctrl_val;
992 for (i = 0; i < r->num_closid; i++, ctrl++) { 1000 for (i = 0; i < closids_supported(); i++, ctrl++) {
993 ctrl_b = (unsigned long *)ctrl; 1001 ctrl_b = *ctrl;
994 mode = rdtgroup_mode_by_closid(i); 1002 mode = rdtgroup_mode_by_closid(i);
995 if (closid_allocated(i) && i != closid && 1003 if (closid_allocated(i) && i != closid &&
996 mode != RDT_MODE_PSEUDO_LOCKSETUP) { 1004 mode != RDT_MODE_PSEUDO_LOCKSETUP) {
997 if (bitmap_intersects(cbm, ctrl_b, r->cache.cbm_len)) { 1005 if (bitmap_intersects(&cbm, &ctrl_b, r->cache.cbm_len)) {
998 if (exclusive) { 1006 if (exclusive) {
999 if (mode == RDT_MODE_EXCLUSIVE) 1007 if (mode == RDT_MODE_EXCLUSIVE)
1000 return true; 1008 return true;
@@ -1024,16 +1032,27 @@ static bool rdtgroup_mode_test_exclusive(struct rdtgroup *rdtgrp)
1024{ 1032{
1025 int closid = rdtgrp->closid; 1033 int closid = rdtgrp->closid;
1026 struct rdt_resource *r; 1034 struct rdt_resource *r;
1035 bool has_cache = false;
1027 struct rdt_domain *d; 1036 struct rdt_domain *d;
1028 1037
1029 for_each_alloc_enabled_rdt_resource(r) { 1038 for_each_alloc_enabled_rdt_resource(r) {
1039 if (r->rid == RDT_RESOURCE_MBA)
1040 continue;
1041 has_cache = true;
1030 list_for_each_entry(d, &r->domains, list) { 1042 list_for_each_entry(d, &r->domains, list) {
1031 if (rdtgroup_cbm_overlaps(r, d, d->ctrl_val[closid], 1043 if (rdtgroup_cbm_overlaps(r, d, d->ctrl_val[closid],
1032 rdtgrp->closid, false)) 1044 rdtgrp->closid, false)) {
1045 rdt_last_cmd_puts("schemata overlaps\n");
1033 return false; 1046 return false;
1047 }
1034 } 1048 }
1035 } 1049 }
1036 1050
1051 if (!has_cache) {
1052 rdt_last_cmd_puts("cannot be exclusive without CAT/CDP\n");
1053 return false;
1054 }
1055
1037 return true; 1056 return true;
1038} 1057}
1039 1058
@@ -1085,7 +1104,6 @@ static ssize_t rdtgroup_mode_write(struct kernfs_open_file *of,
1085 rdtgrp->mode = RDT_MODE_SHAREABLE; 1104 rdtgrp->mode = RDT_MODE_SHAREABLE;
1086 } else if (!strcmp(buf, "exclusive")) { 1105 } else if (!strcmp(buf, "exclusive")) {
1087 if (!rdtgroup_mode_test_exclusive(rdtgrp)) { 1106 if (!rdtgroup_mode_test_exclusive(rdtgrp)) {
1088 rdt_last_cmd_printf("schemata overlaps\n");
1089 ret = -EINVAL; 1107 ret = -EINVAL;
1090 goto out; 1108 goto out;
1091 } 1109 }
@@ -1121,15 +1139,18 @@ out:
1121 * computed by first dividing the total cache size by the CBM length to 1139 * computed by first dividing the total cache size by the CBM length to
1122 * determine how many bytes each bit in the bitmask represents. The result 1140 * determine how many bytes each bit in the bitmask represents. The result
1123 * is multiplied with the number of bits set in the bitmask. 1141 * is multiplied with the number of bits set in the bitmask.
1142 *
1143 * @cbm is unsigned long, even if only 32 bits are used to make the
1144 * bitmap functions work correctly.
1124 */ 1145 */
1125unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r, 1146unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r,
1126 struct rdt_domain *d, u32 cbm) 1147 struct rdt_domain *d, unsigned long cbm)
1127{ 1148{
1128 struct cpu_cacheinfo *ci; 1149 struct cpu_cacheinfo *ci;
1129 unsigned int size = 0; 1150 unsigned int size = 0;
1130 int num_b, i; 1151 int num_b, i;
1131 1152
1132 num_b = bitmap_weight((unsigned long *)&cbm, r->cache.cbm_len); 1153 num_b = bitmap_weight(&cbm, r->cache.cbm_len);
1133 ci = get_cpu_cacheinfo(cpumask_any(&d->cpu_mask)); 1154 ci = get_cpu_cacheinfo(cpumask_any(&d->cpu_mask));
1134 for (i = 0; i < ci->num_leaves; i++) { 1155 for (i = 0; i < ci->num_leaves; i++) {
1135 if (ci->info_list[i].level == r->cache_level) { 1156 if (ci->info_list[i].level == r->cache_level) {
@@ -1155,8 +1176,8 @@ static int rdtgroup_size_show(struct kernfs_open_file *of,
1155 struct rdt_resource *r; 1176 struct rdt_resource *r;
1156 struct rdt_domain *d; 1177 struct rdt_domain *d;
1157 unsigned int size; 1178 unsigned int size;
1158 bool sep = false; 1179 bool sep;
1159 u32 cbm; 1180 u32 ctrl;
1160 1181
1161 rdtgrp = rdtgroup_kn_lock_live(of->kn); 1182 rdtgrp = rdtgroup_kn_lock_live(of->kn);
1162 if (!rdtgrp) { 1183 if (!rdtgrp) {
@@ -1174,6 +1195,7 @@ static int rdtgroup_size_show(struct kernfs_open_file *of,
1174 } 1195 }
1175 1196
1176 for_each_alloc_enabled_rdt_resource(r) { 1197 for_each_alloc_enabled_rdt_resource(r) {
1198 sep = false;
1177 seq_printf(s, "%*s:", max_name_width, r->name); 1199 seq_printf(s, "%*s:", max_name_width, r->name);
1178 list_for_each_entry(d, &r->domains, list) { 1200 list_for_each_entry(d, &r->domains, list) {
1179 if (sep) 1201 if (sep)
@@ -1181,8 +1203,13 @@ static int rdtgroup_size_show(struct kernfs_open_file *of,
1181 if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) { 1203 if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) {
1182 size = 0; 1204 size = 0;
1183 } else { 1205 } else {
1184 cbm = d->ctrl_val[rdtgrp->closid]; 1206 ctrl = (!is_mba_sc(r) ?
1185 size = rdtgroup_cbm_to_size(r, d, cbm); 1207 d->ctrl_val[rdtgrp->closid] :
1208 d->mbps_val[rdtgrp->closid]);
1209 if (r->rid == RDT_RESOURCE_MBA)
1210 size = ctrl;
1211 else
1212 size = rdtgroup_cbm_to_size(r, d, ctrl);
1186 } 1213 }
1187 seq_printf(s, "%d=%u", d->id, size); 1214 seq_printf(s, "%d=%u", d->id, size);
1188 sep = true; 1215 sep = true;
@@ -2330,18 +2357,25 @@ static int rdtgroup_init_alloc(struct rdtgroup *rdtgrp)
2330 u32 used_b = 0, unused_b = 0; 2357 u32 used_b = 0, unused_b = 0;
2331 u32 closid = rdtgrp->closid; 2358 u32 closid = rdtgrp->closid;
2332 struct rdt_resource *r; 2359 struct rdt_resource *r;
2360 unsigned long tmp_cbm;
2333 enum rdtgrp_mode mode; 2361 enum rdtgrp_mode mode;
2334 struct rdt_domain *d; 2362 struct rdt_domain *d;
2335 int i, ret; 2363 int i, ret;
2336 u32 *ctrl; 2364 u32 *ctrl;
2337 2365
2338 for_each_alloc_enabled_rdt_resource(r) { 2366 for_each_alloc_enabled_rdt_resource(r) {
2367 /*
2368 * Only initialize default allocations for CBM cache
2369 * resources
2370 */
2371 if (r->rid == RDT_RESOURCE_MBA)
2372 continue;
2339 list_for_each_entry(d, &r->domains, list) { 2373 list_for_each_entry(d, &r->domains, list) {
2340 d->have_new_ctrl = false; 2374 d->have_new_ctrl = false;
2341 d->new_ctrl = r->cache.shareable_bits; 2375 d->new_ctrl = r->cache.shareable_bits;
2342 used_b = r->cache.shareable_bits; 2376 used_b = r->cache.shareable_bits;
2343 ctrl = d->ctrl_val; 2377 ctrl = d->ctrl_val;
2344 for (i = 0; i < r->num_closid; i++, ctrl++) { 2378 for (i = 0; i < closids_supported(); i++, ctrl++) {
2345 if (closid_allocated(i) && i != closid) { 2379 if (closid_allocated(i) && i != closid) {
2346 mode = rdtgroup_mode_by_closid(i); 2380 mode = rdtgroup_mode_by_closid(i);
2347 if (mode == RDT_MODE_PSEUDO_LOCKSETUP) 2381 if (mode == RDT_MODE_PSEUDO_LOCKSETUP)
@@ -2361,9 +2395,14 @@ static int rdtgroup_init_alloc(struct rdtgroup *rdtgrp)
2361 * modify the CBM based on system availability. 2395 * modify the CBM based on system availability.
2362 */ 2396 */
2363 cbm_ensure_valid(&d->new_ctrl, r); 2397 cbm_ensure_valid(&d->new_ctrl, r);
2364 if (bitmap_weight((unsigned long *) &d->new_ctrl, 2398 /*
2365 r->cache.cbm_len) < 2399 * Assign the u32 CBM to an unsigned long to ensure
2366 r->cache.min_cbm_bits) { 2400 * that bitmap_weight() does not access out-of-bound
2401 * memory.
2402 */
2403 tmp_cbm = d->new_ctrl;
2404 if (bitmap_weight(&tmp_cbm, r->cache.cbm_len) <
2405 r->cache.min_cbm_bits) {
2367 rdt_last_cmd_printf("no space on %s:%d\n", 2406 rdt_last_cmd_printf("no space on %s:%d\n",
2368 r->name, d->id); 2407 r->name, d->id);
2369 return -ENOSPC; 2408 return -ENOSPC;
@@ -2373,6 +2412,12 @@ static int rdtgroup_init_alloc(struct rdtgroup *rdtgrp)
2373 } 2412 }
2374 2413
2375 for_each_alloc_enabled_rdt_resource(r) { 2414 for_each_alloc_enabled_rdt_resource(r) {
2415 /*
2416 * Only initialize default allocations for CBM cache
2417 * resources
2418 */
2419 if (r->rid == RDT_RESOURCE_MBA)
2420 continue;
2376 ret = update_domains(r, rdtgrp->closid); 2421 ret = update_domains(r, rdtgrp->closid);
2377 if (ret < 0) { 2422 if (ret < 0) {
2378 rdt_last_cmd_puts("failed to initialize allocations\n"); 2423 rdt_last_cmd_puts("failed to initialize allocations\n");
diff --git a/arch/x86/kernel/eisa.c b/arch/x86/kernel/eisa.c
index f260e452e4f8..e8c8c5d78dbd 100644
--- a/arch/x86/kernel/eisa.c
+++ b/arch/x86/kernel/eisa.c
@@ -7,11 +7,17 @@
7#include <linux/eisa.h> 7#include <linux/eisa.h>
8#include <linux/io.h> 8#include <linux/io.h>
9 9
10#include <xen/xen.h>
11
10static __init int eisa_bus_probe(void) 12static __init int eisa_bus_probe(void)
11{ 13{
12 void __iomem *p = ioremap(0x0FFFD9, 4); 14 void __iomem *p;
15
16 if (xen_pv_domain() && !xen_initial_domain())
17 return 0;
13 18
14 if (readl(p) == 'E' + ('I'<<8) + ('S'<<16) + ('A'<<24)) 19 p = ioremap(0x0FFFD9, 4);
20 if (p && readl(p) == 'E' + ('I' << 8) + ('S' << 16) + ('A' << 24))
15 EISA_bus = 1; 21 EISA_bus = 1;
16 iounmap(p); 22 iounmap(p);
17 return 0; 23 return 0;
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index 8047379e575a..ddee1f0870c4 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -35,6 +35,7 @@
35#include <asm/bootparam_utils.h> 35#include <asm/bootparam_utils.h>
36#include <asm/microcode.h> 36#include <asm/microcode.h>
37#include <asm/kasan.h> 37#include <asm/kasan.h>
38#include <asm/fixmap.h>
38 39
39/* 40/*
40 * Manage page tables very early on. 41 * Manage page tables very early on.
@@ -112,6 +113,7 @@ static bool __head check_la57_support(unsigned long physaddr)
112unsigned long __head __startup_64(unsigned long physaddr, 113unsigned long __head __startup_64(unsigned long physaddr,
113 struct boot_params *bp) 114 struct boot_params *bp)
114{ 115{
116 unsigned long vaddr, vaddr_end;
115 unsigned long load_delta, *p; 117 unsigned long load_delta, *p;
116 unsigned long pgtable_flags; 118 unsigned long pgtable_flags;
117 pgdval_t *pgd; 119 pgdval_t *pgd;
@@ -165,7 +167,8 @@ unsigned long __head __startup_64(unsigned long physaddr,
165 pud[511] += load_delta; 167 pud[511] += load_delta;
166 168
167 pmd = fixup_pointer(level2_fixmap_pgt, physaddr); 169 pmd = fixup_pointer(level2_fixmap_pgt, physaddr);
168 pmd[506] += load_delta; 170 for (i = FIXMAP_PMD_TOP; i > FIXMAP_PMD_TOP - FIXMAP_PMD_NUM; i--)
171 pmd[i] += load_delta;
169 172
170 /* 173 /*
171 * Set up the identity mapping for the switchover. These 174 * Set up the identity mapping for the switchover. These
@@ -235,6 +238,21 @@ unsigned long __head __startup_64(unsigned long physaddr,
235 sme_encrypt_kernel(bp); 238 sme_encrypt_kernel(bp);
236 239
237 /* 240 /*
241 * Clear the memory encryption mask from the .bss..decrypted section.
242 * The bss section will be memset to zero later in the initialization so
243 * there is no need to zero it after changing the memory encryption
244 * attribute.
245 */
246 if (mem_encrypt_active()) {
247 vaddr = (unsigned long)__start_bss_decrypted;
248 vaddr_end = (unsigned long)__end_bss_decrypted;
249 for (; vaddr < vaddr_end; vaddr += PMD_SIZE) {
250 i = pmd_index(vaddr);
251 pmd[i] -= sme_get_me_mask();
252 }
253 }
254
255 /*
238 * Return the SME encryption mask (if SME is active) to be used as a 256 * Return the SME encryption mask (if SME is active) to be used as a
239 * modifier for the initial pgdir entry programmed into CR3. 257 * modifier for the initial pgdir entry programmed into CR3.
240 */ 258 */
diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index 15ebc2fc166e..a3618cf04cf6 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -24,6 +24,7 @@
24#include "../entry/calling.h" 24#include "../entry/calling.h"
25#include <asm/export.h> 25#include <asm/export.h>
26#include <asm/nospec-branch.h> 26#include <asm/nospec-branch.h>
27#include <asm/fixmap.h>
27 28
28#ifdef CONFIG_PARAVIRT 29#ifdef CONFIG_PARAVIRT
29#include <asm/asm-offsets.h> 30#include <asm/asm-offsets.h>
@@ -445,13 +446,20 @@ NEXT_PAGE(level2_kernel_pgt)
445 KERNEL_IMAGE_SIZE/PMD_SIZE) 446 KERNEL_IMAGE_SIZE/PMD_SIZE)
446 447
447NEXT_PAGE(level2_fixmap_pgt) 448NEXT_PAGE(level2_fixmap_pgt)
448 .fill 506,8,0 449 .fill (512 - 4 - FIXMAP_PMD_NUM),8,0
449 .quad level1_fixmap_pgt - __START_KERNEL_map + _PAGE_TABLE_NOENC 450 pgtno = 0
450 /* 8MB reserved for vsyscalls + a 2MB hole = 4 + 1 entries */ 451 .rept (FIXMAP_PMD_NUM)
451 .fill 5,8,0 452 .quad level1_fixmap_pgt + (pgtno << PAGE_SHIFT) - __START_KERNEL_map \
453 + _PAGE_TABLE_NOENC;
454 pgtno = pgtno + 1
455 .endr
456 /* 6 MB reserved space + a 2MB hole */
457 .fill 4,8,0
452 458
453NEXT_PAGE(level1_fixmap_pgt) 459NEXT_PAGE(level1_fixmap_pgt)
460 .rept (FIXMAP_PMD_NUM)
454 .fill 512,8,0 461 .fill 512,8,0
462 .endr
455 463
456#undef PMDS 464#undef PMDS
457 465
diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index 1e6764648af3..013fe3d21dbb 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -28,6 +28,7 @@
28#include <linux/sched/clock.h> 28#include <linux/sched/clock.h>
29#include <linux/mm.h> 29#include <linux/mm.h>
30#include <linux/slab.h> 30#include <linux/slab.h>
31#include <linux/set_memory.h>
31 32
32#include <asm/hypervisor.h> 33#include <asm/hypervisor.h>
33#include <asm/mem_encrypt.h> 34#include <asm/mem_encrypt.h>
@@ -61,9 +62,10 @@ early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall);
61 (PAGE_SIZE / sizeof(struct pvclock_vsyscall_time_info)) 62 (PAGE_SIZE / sizeof(struct pvclock_vsyscall_time_info))
62 63
63static struct pvclock_vsyscall_time_info 64static struct pvclock_vsyscall_time_info
64 hv_clock_boot[HVC_BOOT_ARRAY_SIZE] __aligned(PAGE_SIZE); 65 hv_clock_boot[HVC_BOOT_ARRAY_SIZE] __bss_decrypted __aligned(PAGE_SIZE);
65static struct pvclock_wall_clock wall_clock; 66static struct pvclock_wall_clock wall_clock __bss_decrypted;
66static DEFINE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu); 67static DEFINE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu);
68static struct pvclock_vsyscall_time_info *hvclock_mem;
67 69
68static inline struct pvclock_vcpu_time_info *this_cpu_pvti(void) 70static inline struct pvclock_vcpu_time_info *this_cpu_pvti(void)
69{ 71{
@@ -236,6 +238,45 @@ static void kvm_shutdown(void)
236 native_machine_shutdown(); 238 native_machine_shutdown();
237} 239}
238 240
241static void __init kvmclock_init_mem(void)
242{
243 unsigned long ncpus;
244 unsigned int order;
245 struct page *p;
246 int r;
247
248 if (HVC_BOOT_ARRAY_SIZE >= num_possible_cpus())
249 return;
250
251 ncpus = num_possible_cpus() - HVC_BOOT_ARRAY_SIZE;
252 order = get_order(ncpus * sizeof(*hvclock_mem));
253
254 p = alloc_pages(GFP_KERNEL, order);
255 if (!p) {
256 pr_warn("%s: failed to alloc %d pages", __func__, (1U << order));
257 return;
258 }
259
260 hvclock_mem = page_address(p);
261
262 /*
263 * hvclock is shared between the guest and the hypervisor, must
264 * be mapped decrypted.
265 */
266 if (sev_active()) {
267 r = set_memory_decrypted((unsigned long) hvclock_mem,
268 1UL << order);
269 if (r) {
270 __free_pages(p, order);
271 hvclock_mem = NULL;
272 pr_warn("kvmclock: set_memory_decrypted() failed. Disabling\n");
273 return;
274 }
275 }
276
277 memset(hvclock_mem, 0, PAGE_SIZE << order);
278}
279
239static int __init kvm_setup_vsyscall_timeinfo(void) 280static int __init kvm_setup_vsyscall_timeinfo(void)
240{ 281{
241#ifdef CONFIG_X86_64 282#ifdef CONFIG_X86_64
@@ -250,6 +291,9 @@ static int __init kvm_setup_vsyscall_timeinfo(void)
250 291
251 kvm_clock.archdata.vclock_mode = VCLOCK_PVCLOCK; 292 kvm_clock.archdata.vclock_mode = VCLOCK_PVCLOCK;
252#endif 293#endif
294
295 kvmclock_init_mem();
296
253 return 0; 297 return 0;
254} 298}
255early_initcall(kvm_setup_vsyscall_timeinfo); 299early_initcall(kvm_setup_vsyscall_timeinfo);
@@ -269,8 +313,10 @@ static int kvmclock_setup_percpu(unsigned int cpu)
269 /* Use the static page for the first CPUs, allocate otherwise */ 313 /* Use the static page for the first CPUs, allocate otherwise */
270 if (cpu < HVC_BOOT_ARRAY_SIZE) 314 if (cpu < HVC_BOOT_ARRAY_SIZE)
271 p = &hv_clock_boot[cpu]; 315 p = &hv_clock_boot[cpu];
316 else if (hvclock_mem)
317 p = hvclock_mem + cpu - HVC_BOOT_ARRAY_SIZE;
272 else 318 else
273 p = kzalloc(sizeof(*p), GFP_KERNEL); 319 return -ENOMEM;
274 320
275 per_cpu(hv_clock_per_cpu, cpu) = p; 321 per_cpu(hv_clock_per_cpu, cpu) = p;
276 return p ? 0 : -ENOMEM; 322 return p ? 0 : -ENOMEM;
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index afdb303285f8..8dc69d82567e 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -91,7 +91,7 @@ unsigned paravirt_patch_call(void *insnbuf,
91 91
92 if (len < 5) { 92 if (len < 5) {
93#ifdef CONFIG_RETPOLINE 93#ifdef CONFIG_RETPOLINE
94 WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr); 94 WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
95#endif 95#endif
96 return len; /* call too long for patch site */ 96 return len; /* call too long for patch site */
97 } 97 }
@@ -111,7 +111,7 @@ unsigned paravirt_patch_jmp(void *insnbuf, const void *target,
111 111
112 if (len < 5) { 112 if (len < 5) {
113#ifdef CONFIG_RETPOLINE 113#ifdef CONFIG_RETPOLINE
114 WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr); 114 WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
115#endif 115#endif
116 return len; /* call too long for patch site */ 116 return len; /* call too long for patch site */
117 } 117 }
diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
index 12cbe2b88c0f..738bf42b0218 100644
--- a/arch/x86/kernel/topology.c
+++ b/arch/x86/kernel/topology.c
@@ -111,8 +111,10 @@ int arch_register_cpu(int num)
111 /* 111 /*
112 * Currently CPU0 is only hotpluggable on Intel platforms. Other 112 * Currently CPU0 is only hotpluggable on Intel platforms. Other
113 * vendors can add hotplug support later. 113 * vendors can add hotplug support later.
114 * Xen PV guests don't support CPU0 hotplug at all.
114 */ 115 */
115 if (c->x86_vendor != X86_VENDOR_INTEL) 116 if (c->x86_vendor != X86_VENDOR_INTEL ||
117 boot_cpu_has(X86_FEATURE_XENPV))
116 cpu0_hotpluggable = 0; 118 cpu0_hotpluggable = 0;
117 119
118 /* 120 /*
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 6490f618e096..b52bd2b6cdb4 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -26,6 +26,7 @@
26#include <asm/apic.h> 26#include <asm/apic.h>
27#include <asm/intel-family.h> 27#include <asm/intel-family.h>
28#include <asm/i8259.h> 28#include <asm/i8259.h>
29#include <asm/uv/uv.h>
29 30
30unsigned int __read_mostly cpu_khz; /* TSC clocks / usec, not used here */ 31unsigned int __read_mostly cpu_khz; /* TSC clocks / usec, not used here */
31EXPORT_SYMBOL(cpu_khz); 32EXPORT_SYMBOL(cpu_khz);
@@ -1433,6 +1434,9 @@ void __init tsc_early_init(void)
1433{ 1434{
1434 if (!boot_cpu_has(X86_FEATURE_TSC)) 1435 if (!boot_cpu_has(X86_FEATURE_TSC))
1435 return; 1436 return;
1437 /* Don't change UV TSC multi-chassis synchronization */
1438 if (is_early_uv_system())
1439 return;
1436 if (!determine_cpu_tsc_frequencies(true)) 1440 if (!determine_cpu_tsc_frequencies(true))
1437 return; 1441 return;
1438 loops_per_jiffy = get_loops_per_jiffy(); 1442 loops_per_jiffy = get_loops_per_jiffy();
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 8bde0a419f86..5dd3317d761f 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -65,6 +65,23 @@ jiffies_64 = jiffies;
65#define ALIGN_ENTRY_TEXT_BEGIN . = ALIGN(PMD_SIZE); 65#define ALIGN_ENTRY_TEXT_BEGIN . = ALIGN(PMD_SIZE);
66#define ALIGN_ENTRY_TEXT_END . = ALIGN(PMD_SIZE); 66#define ALIGN_ENTRY_TEXT_END . = ALIGN(PMD_SIZE);
67 67
68/*
69 * This section contains data which will be mapped as decrypted. Memory
70 * encryption operates on a page basis. Make this section PMD-aligned
71 * to avoid splitting the pages while mapping the section early.
72 *
73 * Note: We use a separate section so that only this section gets
74 * decrypted to avoid exposing more than we wish.
75 */
76#define BSS_DECRYPTED \
77 . = ALIGN(PMD_SIZE); \
78 __start_bss_decrypted = .; \
79 *(.bss..decrypted); \
80 . = ALIGN(PAGE_SIZE); \
81 __start_bss_decrypted_unused = .; \
82 . = ALIGN(PMD_SIZE); \
83 __end_bss_decrypted = .; \
84
68#else 85#else
69 86
70#define X86_ALIGN_RODATA_BEGIN 87#define X86_ALIGN_RODATA_BEGIN
@@ -74,6 +91,7 @@ jiffies_64 = jiffies;
74 91
75#define ALIGN_ENTRY_TEXT_BEGIN 92#define ALIGN_ENTRY_TEXT_BEGIN
76#define ALIGN_ENTRY_TEXT_END 93#define ALIGN_ENTRY_TEXT_END
94#define BSS_DECRYPTED
77 95
78#endif 96#endif
79 97
@@ -355,6 +373,7 @@ SECTIONS
355 __bss_start = .; 373 __bss_start = .;
356 *(.bss..page_aligned) 374 *(.bss..page_aligned)
357 *(.bss) 375 *(.bss)
376 BSS_DECRYPTED
358 . = ALIGN(PAGE_SIZE); 377 . = ALIGN(PAGE_SIZE);
359 __bss_stop = .; 378 __bss_stop = .;
360 } 379 }
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 17c0472c5b34..fbb0e6df121b 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1344,9 +1344,8 @@ EXPORT_SYMBOL_GPL(kvm_lapic_reg_read);
1344 1344
1345static int apic_mmio_in_range(struct kvm_lapic *apic, gpa_t addr) 1345static int apic_mmio_in_range(struct kvm_lapic *apic, gpa_t addr)
1346{ 1346{
1347 return kvm_apic_hw_enabled(apic) && 1347 return addr >= apic->base_address &&
1348 addr >= apic->base_address && 1348 addr < apic->base_address + LAPIC_MMIO_LENGTH;
1349 addr < apic->base_address + LAPIC_MMIO_LENGTH;
1350} 1349}
1351 1350
1352static int apic_mmio_read(struct kvm_vcpu *vcpu, struct kvm_io_device *this, 1351static int apic_mmio_read(struct kvm_vcpu *vcpu, struct kvm_io_device *this,
@@ -1358,6 +1357,15 @@ static int apic_mmio_read(struct kvm_vcpu *vcpu, struct kvm_io_device *this,
1358 if (!apic_mmio_in_range(apic, address)) 1357 if (!apic_mmio_in_range(apic, address))
1359 return -EOPNOTSUPP; 1358 return -EOPNOTSUPP;
1360 1359
1360 if (!kvm_apic_hw_enabled(apic) || apic_x2apic_mode(apic)) {
1361 if (!kvm_check_has_quirk(vcpu->kvm,
1362 KVM_X86_QUIRK_LAPIC_MMIO_HOLE))
1363 return -EOPNOTSUPP;
1364
1365 memset(data, 0xff, len);
1366 return 0;
1367 }
1368
1361 kvm_lapic_reg_read(apic, offset, len, data); 1369 kvm_lapic_reg_read(apic, offset, len, data);
1362 1370
1363 return 0; 1371 return 0;
@@ -1917,6 +1925,14 @@ static int apic_mmio_write(struct kvm_vcpu *vcpu, struct kvm_io_device *this,
1917 if (!apic_mmio_in_range(apic, address)) 1925 if (!apic_mmio_in_range(apic, address))
1918 return -EOPNOTSUPP; 1926 return -EOPNOTSUPP;
1919 1927
1928 if (!kvm_apic_hw_enabled(apic) || apic_x2apic_mode(apic)) {
1929 if (!kvm_check_has_quirk(vcpu->kvm,
1930 KVM_X86_QUIRK_LAPIC_MMIO_HOLE))
1931 return -EOPNOTSUPP;
1932
1933 return 0;
1934 }
1935
1920 /* 1936 /*
1921 * APIC register must be aligned on 128-bits boundary. 1937 * APIC register must be aligned on 128-bits boundary.
1922 * 32/64/128 bits registers must be accessed thru 32 bits. 1938 * 32/64/128 bits registers must be accessed thru 32 bits.
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index e24ea7067373..51b953ad9d4e 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -249,6 +249,17 @@ static u64 __read_mostly shadow_nonpresent_or_rsvd_mask;
249 */ 249 */
250static const u64 shadow_nonpresent_or_rsvd_mask_len = 5; 250static const u64 shadow_nonpresent_or_rsvd_mask_len = 5;
251 251
252/*
253 * In some cases, we need to preserve the GFN of a non-present or reserved
254 * SPTE when we usurp the upper five bits of the physical address space to
255 * defend against L1TF, e.g. for MMIO SPTEs. To preserve the GFN, we'll
256 * shift bits of the GFN that overlap with shadow_nonpresent_or_rsvd_mask
257 * left into the reserved bits, i.e. the GFN in the SPTE will be split into
258 * high and low parts. This mask covers the lower bits of the GFN.
259 */
260static u64 __read_mostly shadow_nonpresent_or_rsvd_lower_gfn_mask;
261
262
252static void mmu_spte_set(u64 *sptep, u64 spte); 263static void mmu_spte_set(u64 *sptep, u64 spte);
253static union kvm_mmu_page_role 264static union kvm_mmu_page_role
254kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); 265kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu);
@@ -357,9 +368,7 @@ static bool is_mmio_spte(u64 spte)
357 368
358static gfn_t get_mmio_spte_gfn(u64 spte) 369static gfn_t get_mmio_spte_gfn(u64 spte)
359{ 370{
360 u64 mask = generation_mmio_spte_mask(MMIO_GEN_MASK) | shadow_mmio_mask | 371 u64 gpa = spte & shadow_nonpresent_or_rsvd_lower_gfn_mask;
361 shadow_nonpresent_or_rsvd_mask;
362 u64 gpa = spte & ~mask;
363 372
364 gpa |= (spte >> shadow_nonpresent_or_rsvd_mask_len) 373 gpa |= (spte >> shadow_nonpresent_or_rsvd_mask_len)
365 & shadow_nonpresent_or_rsvd_mask; 374 & shadow_nonpresent_or_rsvd_mask;
@@ -423,6 +432,8 @@ EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
423 432
424static void kvm_mmu_reset_all_pte_masks(void) 433static void kvm_mmu_reset_all_pte_masks(void)
425{ 434{
435 u8 low_phys_bits;
436
426 shadow_user_mask = 0; 437 shadow_user_mask = 0;
427 shadow_accessed_mask = 0; 438 shadow_accessed_mask = 0;
428 shadow_dirty_mask = 0; 439 shadow_dirty_mask = 0;
@@ -437,12 +448,17 @@ static void kvm_mmu_reset_all_pte_masks(void)
437 * appropriate mask to guard against L1TF attacks. Otherwise, it is 448 * appropriate mask to guard against L1TF attacks. Otherwise, it is
438 * assumed that the CPU is not vulnerable to L1TF. 449 * assumed that the CPU is not vulnerable to L1TF.
439 */ 450 */
451 low_phys_bits = boot_cpu_data.x86_phys_bits;
440 if (boot_cpu_data.x86_phys_bits < 452 if (boot_cpu_data.x86_phys_bits <
441 52 - shadow_nonpresent_or_rsvd_mask_len) 453 52 - shadow_nonpresent_or_rsvd_mask_len) {
442 shadow_nonpresent_or_rsvd_mask = 454 shadow_nonpresent_or_rsvd_mask =
443 rsvd_bits(boot_cpu_data.x86_phys_bits - 455 rsvd_bits(boot_cpu_data.x86_phys_bits -
444 shadow_nonpresent_or_rsvd_mask_len, 456 shadow_nonpresent_or_rsvd_mask_len,
445 boot_cpu_data.x86_phys_bits - 1); 457 boot_cpu_data.x86_phys_bits - 1);
458 low_phys_bits -= shadow_nonpresent_or_rsvd_mask_len;
459 }
460 shadow_nonpresent_or_rsvd_lower_gfn_mask =
461 GENMASK_ULL(low_phys_bits - 1, PAGE_SHIFT);
446} 462}
447 463
448static int is_cpuid_PSE36(void) 464static int is_cpuid_PSE36(void)
@@ -899,7 +915,7 @@ static void walk_shadow_page_lockless_end(struct kvm_vcpu *vcpu)
899{ 915{
900 /* 916 /*
901 * Make sure the write to vcpu->mode is not reordered in front of 917 * Make sure the write to vcpu->mode is not reordered in front of
902 * reads to sptes. If it does, kvm_commit_zap_page() can see us 918 * reads to sptes. If it does, kvm_mmu_commit_zap_page() can see us
903 * OUTSIDE_GUEST_MODE and proceed to free the shadow page table. 919 * OUTSIDE_GUEST_MODE and proceed to free the shadow page table.
904 */ 920 */
905 smp_store_release(&vcpu->mode, OUTSIDE_GUEST_MODE); 921 smp_store_release(&vcpu->mode, OUTSIDE_GUEST_MODE);
@@ -5417,7 +5433,12 @@ void kvm_mmu_setup(struct kvm_vcpu *vcpu)
5417{ 5433{
5418 MMU_WARN_ON(VALID_PAGE(vcpu->arch.mmu.root_hpa)); 5434 MMU_WARN_ON(VALID_PAGE(vcpu->arch.mmu.root_hpa));
5419 5435
5420 kvm_init_mmu(vcpu, true); 5436 /*
5437 * kvm_mmu_setup() is called only on vCPU initialization.
5438 * Therefore, no need to reset mmu roots as they are not yet
5439 * initialized.
5440 */
5441 kvm_init_mmu(vcpu, false);
5421} 5442}
5422 5443
5423static void kvm_mmu_invalidate_zap_pages_in_memslot(struct kvm *kvm, 5444static void kvm_mmu_invalidate_zap_pages_in_memslot(struct kvm *kvm,
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 89c4c5aa15f1..61ccfb13899e 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -436,14 +436,18 @@ static inline struct kvm_svm *to_kvm_svm(struct kvm *kvm)
436 436
437static inline bool svm_sev_enabled(void) 437static inline bool svm_sev_enabled(void)
438{ 438{
439 return max_sev_asid; 439 return IS_ENABLED(CONFIG_KVM_AMD_SEV) ? max_sev_asid : 0;
440} 440}
441 441
442static inline bool sev_guest(struct kvm *kvm) 442static inline bool sev_guest(struct kvm *kvm)
443{ 443{
444#ifdef CONFIG_KVM_AMD_SEV
444 struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; 445 struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;
445 446
446 return sev->active; 447 return sev->active;
448#else
449 return false;
450#endif
447} 451}
448 452
449static inline int sev_get_asid(struct kvm *kvm) 453static inline int sev_get_asid(struct kvm *kvm)
@@ -1226,8 +1230,7 @@ static __init int sev_hardware_setup(void)
1226 min_sev_asid = cpuid_edx(0x8000001F); 1230 min_sev_asid = cpuid_edx(0x8000001F);
1227 1231
1228 /* Initialize SEV ASID bitmap */ 1232 /* Initialize SEV ASID bitmap */
1229 sev_asid_bitmap = kcalloc(BITS_TO_LONGS(max_sev_asid), 1233 sev_asid_bitmap = bitmap_zalloc(max_sev_asid, GFP_KERNEL);
1230 sizeof(unsigned long), GFP_KERNEL);
1231 if (!sev_asid_bitmap) 1234 if (!sev_asid_bitmap)
1232 return 1; 1235 return 1;
1233 1236
@@ -1405,7 +1408,7 @@ static __exit void svm_hardware_unsetup(void)
1405 int cpu; 1408 int cpu;
1406 1409
1407 if (svm_sev_enabled()) 1410 if (svm_sev_enabled())
1408 kfree(sev_asid_bitmap); 1411 bitmap_free(sev_asid_bitmap);
1409 1412
1410 for_each_possible_cpu(cpu) 1413 for_each_possible_cpu(cpu)
1411 svm_cpu_uninit(cpu); 1414 svm_cpu_uninit(cpu);
@@ -7149,6 +7152,8 @@ static struct kvm_x86_ops svm_x86_ops __ro_after_init = {
7149 .check_intercept = svm_check_intercept, 7152 .check_intercept = svm_check_intercept,
7150 .handle_external_intr = svm_handle_external_intr, 7153 .handle_external_intr = svm_handle_external_intr,
7151 7154
7155 .request_immediate_exit = __kvm_request_immediate_exit,
7156
7152 .sched_in = svm_sched_in, 7157 .sched_in = svm_sched_in,
7153 7158
7154 .pmu_ops = &amd_pmu_ops, 7159 .pmu_ops = &amd_pmu_ops,
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 533a327372c8..e665aa7167cf 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -121,7 +121,6 @@ module_param_named(pml, enable_pml, bool, S_IRUGO);
121 121
122#define MSR_BITMAP_MODE_X2APIC 1 122#define MSR_BITMAP_MODE_X2APIC 1
123#define MSR_BITMAP_MODE_X2APIC_APICV 2 123#define MSR_BITMAP_MODE_X2APIC_APICV 2
124#define MSR_BITMAP_MODE_LM 4
125 124
126#define KVM_VMX_TSC_MULTIPLIER_MAX 0xffffffffffffffffULL 125#define KVM_VMX_TSC_MULTIPLIER_MAX 0xffffffffffffffffULL
127 126
@@ -397,6 +396,7 @@ struct loaded_vmcs {
397 int cpu; 396 int cpu;
398 bool launched; 397 bool launched;
399 bool nmi_known_unmasked; 398 bool nmi_known_unmasked;
399 bool hv_timer_armed;
400 /* Support for vnmi-less CPUs */ 400 /* Support for vnmi-less CPUs */
401 int soft_vnmi_blocked; 401 int soft_vnmi_blocked;
402 ktime_t entry_time; 402 ktime_t entry_time;
@@ -856,6 +856,7 @@ struct nested_vmx {
856 856
857 /* to migrate it to L2 if VM_ENTRY_LOAD_DEBUG_CONTROLS is off */ 857 /* to migrate it to L2 if VM_ENTRY_LOAD_DEBUG_CONTROLS is off */
858 u64 vmcs01_debugctl; 858 u64 vmcs01_debugctl;
859 u64 vmcs01_guest_bndcfgs;
859 860
860 u16 vpid02; 861 u16 vpid02;
861 u16 last_vpid; 862 u16 last_vpid;
@@ -1019,6 +1020,8 @@ struct vcpu_vmx {
1019 int ple_window; 1020 int ple_window;
1020 bool ple_window_dirty; 1021 bool ple_window_dirty;
1021 1022
1023 bool req_immediate_exit;
1024
1022 /* Support for PML */ 1025 /* Support for PML */
1023#define PML_ENTITY_NUM 512 1026#define PML_ENTITY_NUM 512
1024 struct page *pml_pg; 1027 struct page *pml_pg;
@@ -1569,8 +1572,12 @@ static int vmx_hv_remote_flush_tlb(struct kvm *kvm)
1569 goto out; 1572 goto out;
1570 } 1573 }
1571 1574
1575 /*
1576 * FLUSH_GUEST_PHYSICAL_ADDRESS_SPACE hypercall needs the address of the
1577 * base of EPT PML4 table, strip off EPT configuration information.
1578 */
1572 ret = hyperv_flush_guest_mapping( 1579 ret = hyperv_flush_guest_mapping(
1573 to_vmx(kvm_get_vcpu(kvm, 0))->ept_pointer); 1580 to_vmx(kvm_get_vcpu(kvm, 0))->ept_pointer & PAGE_MASK);
1574 1581
1575out: 1582out:
1576 spin_unlock(&to_kvm_vmx(kvm)->ept_pointer_lock); 1583 spin_unlock(&to_kvm_vmx(kvm)->ept_pointer_lock);
@@ -2864,6 +2871,8 @@ static void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
2864 u16 fs_sel, gs_sel; 2871 u16 fs_sel, gs_sel;
2865 int i; 2872 int i;
2866 2873
2874 vmx->req_immediate_exit = false;
2875
2867 if (vmx->loaded_cpu_state) 2876 if (vmx->loaded_cpu_state)
2868 return; 2877 return;
2869 2878
@@ -2894,8 +2903,7 @@ static void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
2894 vmx->msr_host_kernel_gs_base = read_msr(MSR_KERNEL_GS_BASE); 2903 vmx->msr_host_kernel_gs_base = read_msr(MSR_KERNEL_GS_BASE);
2895 } 2904 }
2896 2905
2897 if (is_long_mode(&vmx->vcpu)) 2906 wrmsrl(MSR_KERNEL_GS_BASE, vmx->msr_guest_kernel_gs_base);
2898 wrmsrl(MSR_KERNEL_GS_BASE, vmx->msr_guest_kernel_gs_base);
2899#else 2907#else
2900 savesegment(fs, fs_sel); 2908 savesegment(fs, fs_sel);
2901 savesegment(gs, gs_sel); 2909 savesegment(gs, gs_sel);
@@ -2946,8 +2954,7 @@ static void vmx_prepare_switch_to_host(struct vcpu_vmx *vmx)
2946 vmx->loaded_cpu_state = NULL; 2954 vmx->loaded_cpu_state = NULL;
2947 2955
2948#ifdef CONFIG_X86_64 2956#ifdef CONFIG_X86_64
2949 if (is_long_mode(&vmx->vcpu)) 2957 rdmsrl(MSR_KERNEL_GS_BASE, vmx->msr_guest_kernel_gs_base);
2950 rdmsrl(MSR_KERNEL_GS_BASE, vmx->msr_guest_kernel_gs_base);
2951#endif 2958#endif
2952 if (host_state->ldt_sel || (host_state->gs_sel & 7)) { 2959 if (host_state->ldt_sel || (host_state->gs_sel & 7)) {
2953 kvm_load_ldt(host_state->ldt_sel); 2960 kvm_load_ldt(host_state->ldt_sel);
@@ -2975,24 +2982,19 @@ static void vmx_prepare_switch_to_host(struct vcpu_vmx *vmx)
2975#ifdef CONFIG_X86_64 2982#ifdef CONFIG_X86_64
2976static u64 vmx_read_guest_kernel_gs_base(struct vcpu_vmx *vmx) 2983static u64 vmx_read_guest_kernel_gs_base(struct vcpu_vmx *vmx)
2977{ 2984{
2978 if (is_long_mode(&vmx->vcpu)) { 2985 preempt_disable();
2979 preempt_disable(); 2986 if (vmx->loaded_cpu_state)
2980 if (vmx->loaded_cpu_state) 2987 rdmsrl(MSR_KERNEL_GS_BASE, vmx->msr_guest_kernel_gs_base);
2981 rdmsrl(MSR_KERNEL_GS_BASE, 2988 preempt_enable();
2982 vmx->msr_guest_kernel_gs_base);
2983 preempt_enable();
2984 }
2985 return vmx->msr_guest_kernel_gs_base; 2989 return vmx->msr_guest_kernel_gs_base;
2986} 2990}
2987 2991
2988static void vmx_write_guest_kernel_gs_base(struct vcpu_vmx *vmx, u64 data) 2992static void vmx_write_guest_kernel_gs_base(struct vcpu_vmx *vmx, u64 data)
2989{ 2993{
2990 if (is_long_mode(&vmx->vcpu)) { 2994 preempt_disable();
2991 preempt_disable(); 2995 if (vmx->loaded_cpu_state)
2992 if (vmx->loaded_cpu_state) 2996 wrmsrl(MSR_KERNEL_GS_BASE, data);
2993 wrmsrl(MSR_KERNEL_GS_BASE, data); 2997 preempt_enable();
2994 preempt_enable();
2995 }
2996 vmx->msr_guest_kernel_gs_base = data; 2998 vmx->msr_guest_kernel_gs_base = data;
2997} 2999}
2998#endif 3000#endif
@@ -3528,9 +3530,6 @@ static void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, bool apicv)
3528 VM_EXIT_LOAD_IA32_EFER | VM_EXIT_SAVE_IA32_EFER | 3530 VM_EXIT_LOAD_IA32_EFER | VM_EXIT_SAVE_IA32_EFER |
3529 VM_EXIT_SAVE_VMX_PREEMPTION_TIMER | VM_EXIT_ACK_INTR_ON_EXIT; 3531 VM_EXIT_SAVE_VMX_PREEMPTION_TIMER | VM_EXIT_ACK_INTR_ON_EXIT;
3530 3532
3531 if (kvm_mpx_supported())
3532 msrs->exit_ctls_high |= VM_EXIT_CLEAR_BNDCFGS;
3533
3534 /* We support free control of debug control saving. */ 3533 /* We support free control of debug control saving. */
3535 msrs->exit_ctls_low &= ~VM_EXIT_SAVE_DEBUG_CONTROLS; 3534 msrs->exit_ctls_low &= ~VM_EXIT_SAVE_DEBUG_CONTROLS;
3536 3535
@@ -3547,8 +3546,6 @@ static void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, bool apicv)
3547 VM_ENTRY_LOAD_IA32_PAT; 3546 VM_ENTRY_LOAD_IA32_PAT;
3548 msrs->entry_ctls_high |= 3547 msrs->entry_ctls_high |=
3549 (VM_ENTRY_ALWAYSON_WITHOUT_TRUE_MSR | VM_ENTRY_LOAD_IA32_EFER); 3548 (VM_ENTRY_ALWAYSON_WITHOUT_TRUE_MSR | VM_ENTRY_LOAD_IA32_EFER);
3550 if (kvm_mpx_supported())
3551 msrs->entry_ctls_high |= VM_ENTRY_LOAD_BNDCFGS;
3552 3549
3553 /* We support free control of debug control loading. */ 3550 /* We support free control of debug control loading. */
3554 msrs->entry_ctls_low &= ~VM_ENTRY_LOAD_DEBUG_CONTROLS; 3551 msrs->entry_ctls_low &= ~VM_ENTRY_LOAD_DEBUG_CONTROLS;
@@ -3596,12 +3593,12 @@ static void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, bool apicv)
3596 msrs->secondary_ctls_high); 3593 msrs->secondary_ctls_high);
3597 msrs->secondary_ctls_low = 0; 3594 msrs->secondary_ctls_low = 0;
3598 msrs->secondary_ctls_high &= 3595 msrs->secondary_ctls_high &=
3599 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES |
3600 SECONDARY_EXEC_DESC | 3596 SECONDARY_EXEC_DESC |
3601 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE | 3597 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE |
3602 SECONDARY_EXEC_APIC_REGISTER_VIRT | 3598 SECONDARY_EXEC_APIC_REGISTER_VIRT |
3603 SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY | 3599 SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY |
3604 SECONDARY_EXEC_WBINVD_EXITING; 3600 SECONDARY_EXEC_WBINVD_EXITING;
3601
3605 /* 3602 /*
3606 * We can emulate "VMCS shadowing," even if the hardware 3603 * We can emulate "VMCS shadowing," even if the hardware
3607 * doesn't support it. 3604 * doesn't support it.
@@ -3658,6 +3655,10 @@ static void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, bool apicv)
3658 msrs->secondary_ctls_high |= 3655 msrs->secondary_ctls_high |=
3659 SECONDARY_EXEC_UNRESTRICTED_GUEST; 3656 SECONDARY_EXEC_UNRESTRICTED_GUEST;
3660 3657
3658 if (flexpriority_enabled)
3659 msrs->secondary_ctls_high |=
3660 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
3661
3661 /* miscellaneous data */ 3662 /* miscellaneous data */
3662 rdmsr(MSR_IA32_VMX_MISC, 3663 rdmsr(MSR_IA32_VMX_MISC,
3663 msrs->misc_low, 3664 msrs->misc_low,
@@ -5068,19 +5069,6 @@ static void vmx_set_efer(struct kvm_vcpu *vcpu, u64 efer)
5068 if (!msr) 5069 if (!msr)
5069 return; 5070 return;
5070 5071
5071 /*
5072 * MSR_KERNEL_GS_BASE is not intercepted when the guest is in
5073 * 64-bit mode as a 64-bit kernel may frequently access the
5074 * MSR. This means we need to manually save/restore the MSR
5075 * when switching between guest and host state, but only if
5076 * the guest is in 64-bit mode. Sync our cached value if the
5077 * guest is transitioning to 32-bit mode and the CPU contains
5078 * guest state, i.e. the cache is stale.
5079 */
5080#ifdef CONFIG_X86_64
5081 if (!(efer & EFER_LMA))
5082 (void)vmx_read_guest_kernel_gs_base(vmx);
5083#endif
5084 vcpu->arch.efer = efer; 5072 vcpu->arch.efer = efer;
5085 if (efer & EFER_LMA) { 5073 if (efer & EFER_LMA) {
5086 vm_entry_controls_setbit(to_vmx(vcpu), VM_ENTRY_IA32E_MODE); 5074 vm_entry_controls_setbit(to_vmx(vcpu), VM_ENTRY_IA32E_MODE);
@@ -5393,9 +5381,10 @@ static int vmx_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4)
5393 * To use VMXON (and later other VMX instructions), a guest 5381 * To use VMXON (and later other VMX instructions), a guest
5394 * must first be able to turn on cr4.VMXE (see handle_vmon()). 5382 * must first be able to turn on cr4.VMXE (see handle_vmon()).
5395 * So basically the check on whether to allow nested VMX 5383 * So basically the check on whether to allow nested VMX
5396 * is here. 5384 * is here. We operate under the default treatment of SMM,
5385 * so VMX cannot be enabled under SMM.
5397 */ 5386 */
5398 if (!nested_vmx_allowed(vcpu)) 5387 if (!nested_vmx_allowed(vcpu) || is_smm(vcpu))
5399 return 1; 5388 return 1;
5400 } 5389 }
5401 5390
@@ -6072,9 +6061,6 @@ static u8 vmx_msr_bitmap_mode(struct kvm_vcpu *vcpu)
6072 mode |= MSR_BITMAP_MODE_X2APIC_APICV; 6061 mode |= MSR_BITMAP_MODE_X2APIC_APICV;
6073 } 6062 }
6074 6063
6075 if (is_long_mode(vcpu))
6076 mode |= MSR_BITMAP_MODE_LM;
6077
6078 return mode; 6064 return mode;
6079} 6065}
6080 6066
@@ -6115,9 +6101,6 @@ static void vmx_update_msr_bitmap(struct kvm_vcpu *vcpu)
6115 if (!changed) 6101 if (!changed)
6116 return; 6102 return;
6117 6103
6118 vmx_set_intercept_for_msr(msr_bitmap, MSR_KERNEL_GS_BASE, MSR_TYPE_RW,
6119 !(mode & MSR_BITMAP_MODE_LM));
6120
6121 if (changed & (MSR_BITMAP_MODE_X2APIC | MSR_BITMAP_MODE_X2APIC_APICV)) 6104 if (changed & (MSR_BITMAP_MODE_X2APIC | MSR_BITMAP_MODE_X2APIC_APICV))
6122 vmx_update_msr_bitmap_x2apic(msr_bitmap, mode); 6105 vmx_update_msr_bitmap_x2apic(msr_bitmap, mode);
6123 6106
@@ -6183,6 +6166,32 @@ static void vmx_complete_nested_posted_interrupt(struct kvm_vcpu *vcpu)
6183 nested_mark_vmcs12_pages_dirty(vcpu); 6166 nested_mark_vmcs12_pages_dirty(vcpu);
6184} 6167}
6185 6168
6169static u8 vmx_get_rvi(void)
6170{
6171 return vmcs_read16(GUEST_INTR_STATUS) & 0xff;
6172}
6173
6174static bool vmx_guest_apic_has_interrupt(struct kvm_vcpu *vcpu)
6175{
6176 struct vcpu_vmx *vmx = to_vmx(vcpu);
6177 void *vapic_page;
6178 u32 vppr;
6179 int rvi;
6180
6181 if (WARN_ON_ONCE(!is_guest_mode(vcpu)) ||
6182 !nested_cpu_has_vid(get_vmcs12(vcpu)) ||
6183 WARN_ON_ONCE(!vmx->nested.virtual_apic_page))
6184 return false;
6185
6186 rvi = vmx_get_rvi();
6187
6188 vapic_page = kmap(vmx->nested.virtual_apic_page);
6189 vppr = *((u32 *)(vapic_page + APIC_PROCPRI));
6190 kunmap(vmx->nested.virtual_apic_page);
6191
6192 return ((rvi & 0xf0) > (vppr & 0xf0));
6193}
6194
6186static inline bool kvm_vcpu_trigger_posted_interrupt(struct kvm_vcpu *vcpu, 6195static inline bool kvm_vcpu_trigger_posted_interrupt(struct kvm_vcpu *vcpu,
6187 bool nested) 6196 bool nested)
6188{ 6197{
@@ -7966,6 +7975,9 @@ static __init int hardware_setup(void)
7966 kvm_x86_ops->enable_log_dirty_pt_masked = NULL; 7975 kvm_x86_ops->enable_log_dirty_pt_masked = NULL;
7967 } 7976 }
7968 7977
7978 if (!cpu_has_vmx_preemption_timer())
7979 kvm_x86_ops->request_immediate_exit = __kvm_request_immediate_exit;
7980
7969 if (cpu_has_vmx_preemption_timer() && enable_preemption_timer) { 7981 if (cpu_has_vmx_preemption_timer() && enable_preemption_timer) {
7970 u64 vmx_msr; 7982 u64 vmx_msr;
7971 7983
@@ -9208,7 +9220,8 @@ static int handle_pml_full(struct kvm_vcpu *vcpu)
9208 9220
9209static int handle_preemption_timer(struct kvm_vcpu *vcpu) 9221static int handle_preemption_timer(struct kvm_vcpu *vcpu)
9210{ 9222{
9211 kvm_lapic_expired_hv_timer(vcpu); 9223 if (!to_vmx(vcpu)->req_immediate_exit)
9224 kvm_lapic_expired_hv_timer(vcpu);
9212 return 1; 9225 return 1;
9213} 9226}
9214 9227
@@ -10214,15 +10227,16 @@ static void vmx_set_virtual_apic_mode(struct kvm_vcpu *vcpu)
10214 if (!lapic_in_kernel(vcpu)) 10227 if (!lapic_in_kernel(vcpu))
10215 return; 10228 return;
10216 10229
10230 if (!flexpriority_enabled &&
10231 !cpu_has_vmx_virtualize_x2apic_mode())
10232 return;
10233
10217 /* Postpone execution until vmcs01 is the current VMCS. */ 10234 /* Postpone execution until vmcs01 is the current VMCS. */
10218 if (is_guest_mode(vcpu)) { 10235 if (is_guest_mode(vcpu)) {
10219 to_vmx(vcpu)->nested.change_vmcs01_virtual_apic_mode = true; 10236 to_vmx(vcpu)->nested.change_vmcs01_virtual_apic_mode = true;
10220 return; 10237 return;
10221 } 10238 }
10222 10239
10223 if (!cpu_need_tpr_shadow(vcpu))
10224 return;
10225
10226 sec_exec_control = vmcs_read32(SECONDARY_VM_EXEC_CONTROL); 10240 sec_exec_control = vmcs_read32(SECONDARY_VM_EXEC_CONTROL);
10227 sec_exec_control &= ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | 10241 sec_exec_control &= ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES |
10228 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE); 10242 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE);
@@ -10344,6 +10358,14 @@ static int vmx_sync_pir_to_irr(struct kvm_vcpu *vcpu)
10344 return max_irr; 10358 return max_irr;
10345} 10359}
10346 10360
10361static u8 vmx_has_apicv_interrupt(struct kvm_vcpu *vcpu)
10362{
10363 u8 rvi = vmx_get_rvi();
10364 u8 vppr = kvm_lapic_get_reg(vcpu->arch.apic, APIC_PROCPRI);
10365
10366 return ((rvi & 0xf0) > (vppr & 0xf0));
10367}
10368
10347static void vmx_load_eoi_exitmap(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap) 10369static void vmx_load_eoi_exitmap(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap)
10348{ 10370{
10349 if (!kvm_vcpu_apicv_active(vcpu)) 10371 if (!kvm_vcpu_apicv_active(vcpu))
@@ -10595,24 +10617,43 @@ static void atomic_switch_perf_msrs(struct vcpu_vmx *vmx)
10595 msrs[i].host, false); 10617 msrs[i].host, false);
10596} 10618}
10597 10619
10598static void vmx_arm_hv_timer(struct kvm_vcpu *vcpu) 10620static void vmx_arm_hv_timer(struct vcpu_vmx *vmx, u32 val)
10621{
10622 vmcs_write32(VMX_PREEMPTION_TIMER_VALUE, val);
10623 if (!vmx->loaded_vmcs->hv_timer_armed)
10624 vmcs_set_bits(PIN_BASED_VM_EXEC_CONTROL,
10625 PIN_BASED_VMX_PREEMPTION_TIMER);
10626 vmx->loaded_vmcs->hv_timer_armed = true;
10627}
10628
10629static void vmx_update_hv_timer(struct kvm_vcpu *vcpu)
10599{ 10630{
10600 struct vcpu_vmx *vmx = to_vmx(vcpu); 10631 struct vcpu_vmx *vmx = to_vmx(vcpu);
10601 u64 tscl; 10632 u64 tscl;
10602 u32 delta_tsc; 10633 u32 delta_tsc;
10603 10634
10604 if (vmx->hv_deadline_tsc == -1) 10635 if (vmx->req_immediate_exit) {
10636 vmx_arm_hv_timer(vmx, 0);
10605 return; 10637 return;
10638 }
10606 10639
10607 tscl = rdtsc(); 10640 if (vmx->hv_deadline_tsc != -1) {
10608 if (vmx->hv_deadline_tsc > tscl) 10641 tscl = rdtsc();
10609 /* sure to be 32 bit only because checked on set_hv_timer */ 10642 if (vmx->hv_deadline_tsc > tscl)
10610 delta_tsc = (u32)((vmx->hv_deadline_tsc - tscl) >> 10643 /* set_hv_timer ensures the delta fits in 32-bits */
10611 cpu_preemption_timer_multi); 10644 delta_tsc = (u32)((vmx->hv_deadline_tsc - tscl) >>
10612 else 10645 cpu_preemption_timer_multi);
10613 delta_tsc = 0; 10646 else
10647 delta_tsc = 0;
10648
10649 vmx_arm_hv_timer(vmx, delta_tsc);
10650 return;
10651 }
10614 10652
10615 vmcs_write32(VMX_PREEMPTION_TIMER_VALUE, delta_tsc); 10653 if (vmx->loaded_vmcs->hv_timer_armed)
10654 vmcs_clear_bits(PIN_BASED_VM_EXEC_CONTROL,
10655 PIN_BASED_VMX_PREEMPTION_TIMER);
10656 vmx->loaded_vmcs->hv_timer_armed = false;
10616} 10657}
10617 10658
10618static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu) 10659static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
@@ -10672,7 +10713,7 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
10672 10713
10673 atomic_switch_perf_msrs(vmx); 10714 atomic_switch_perf_msrs(vmx);
10674 10715
10675 vmx_arm_hv_timer(vcpu); 10716 vmx_update_hv_timer(vcpu);
10676 10717
10677 /* 10718 /*
10678 * If this vCPU has touched SPEC_CTRL, restore the guest's value if 10719 * If this vCPU has touched SPEC_CTRL, restore the guest's value if
@@ -11214,6 +11255,23 @@ static void nested_vmx_cr_fixed1_bits_update(struct kvm_vcpu *vcpu)
11214#undef cr4_fixed1_update 11255#undef cr4_fixed1_update
11215} 11256}
11216 11257
11258static void nested_vmx_entry_exit_ctls_update(struct kvm_vcpu *vcpu)
11259{
11260 struct vcpu_vmx *vmx = to_vmx(vcpu);
11261
11262 if (kvm_mpx_supported()) {
11263 bool mpx_enabled = guest_cpuid_has(vcpu, X86_FEATURE_MPX);
11264
11265 if (mpx_enabled) {
11266 vmx->nested.msrs.entry_ctls_high |= VM_ENTRY_LOAD_BNDCFGS;
11267 vmx->nested.msrs.exit_ctls_high |= VM_EXIT_CLEAR_BNDCFGS;
11268 } else {
11269 vmx->nested.msrs.entry_ctls_high &= ~VM_ENTRY_LOAD_BNDCFGS;
11270 vmx->nested.msrs.exit_ctls_high &= ~VM_EXIT_CLEAR_BNDCFGS;
11271 }
11272 }
11273}
11274
11217static void vmx_cpuid_update(struct kvm_vcpu *vcpu) 11275static void vmx_cpuid_update(struct kvm_vcpu *vcpu)
11218{ 11276{
11219 struct vcpu_vmx *vmx = to_vmx(vcpu); 11277 struct vcpu_vmx *vmx = to_vmx(vcpu);
@@ -11230,8 +11288,10 @@ static void vmx_cpuid_update(struct kvm_vcpu *vcpu)
11230 to_vmx(vcpu)->msr_ia32_feature_control_valid_bits &= 11288 to_vmx(vcpu)->msr_ia32_feature_control_valid_bits &=
11231 ~FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX; 11289 ~FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX;
11232 11290
11233 if (nested_vmx_allowed(vcpu)) 11291 if (nested_vmx_allowed(vcpu)) {
11234 nested_vmx_cr_fixed1_bits_update(vcpu); 11292 nested_vmx_cr_fixed1_bits_update(vcpu);
11293 nested_vmx_entry_exit_ctls_update(vcpu);
11294 }
11235} 11295}
11236 11296
11237static void vmx_set_supported_cpuid(u32 func, struct kvm_cpuid_entry2 *entry) 11297static void vmx_set_supported_cpuid(u32 func, struct kvm_cpuid_entry2 *entry)
@@ -11427,16 +11487,18 @@ static void vmx_start_preemption_timer(struct kvm_vcpu *vcpu)
11427 u64 preemption_timeout = get_vmcs12(vcpu)->vmx_preemption_timer_value; 11487 u64 preemption_timeout = get_vmcs12(vcpu)->vmx_preemption_timer_value;
11428 struct vcpu_vmx *vmx = to_vmx(vcpu); 11488 struct vcpu_vmx *vmx = to_vmx(vcpu);
11429 11489
11430 if (vcpu->arch.virtual_tsc_khz == 0) 11490 /*
11431 return; 11491 * A timer value of zero is architecturally guaranteed to cause
11432 11492 * a VMExit prior to executing any instructions in the guest.
11433 /* Make sure short timeouts reliably trigger an immediate vmexit. 11493 */
11434 * hrtimer_start does not guarantee this. */ 11494 if (preemption_timeout == 0) {
11435 if (preemption_timeout <= 1) {
11436 vmx_preemption_timer_fn(&vmx->nested.preemption_timer); 11495 vmx_preemption_timer_fn(&vmx->nested.preemption_timer);
11437 return; 11496 return;
11438 } 11497 }
11439 11498
11499 if (vcpu->arch.virtual_tsc_khz == 0)
11500 return;
11501
11440 preemption_timeout <<= VMX_MISC_EMULATED_PREEMPTION_TIMER_RATE; 11502 preemption_timeout <<= VMX_MISC_EMULATED_PREEMPTION_TIMER_RATE;
11441 preemption_timeout *= 1000000; 11503 preemption_timeout *= 1000000;
11442 do_div(preemption_timeout, vcpu->arch.virtual_tsc_khz); 11504 do_div(preemption_timeout, vcpu->arch.virtual_tsc_khz);
@@ -11646,11 +11708,15 @@ static int nested_vmx_check_apicv_controls(struct kvm_vcpu *vcpu,
11646 * bits 15:8 should be zero in posted_intr_nv, 11708 * bits 15:8 should be zero in posted_intr_nv,
11647 * the descriptor address has been already checked 11709 * the descriptor address has been already checked
11648 * in nested_get_vmcs12_pages. 11710 * in nested_get_vmcs12_pages.
11711 *
11712 * bits 5:0 of posted_intr_desc_addr should be zero.
11649 */ 11713 */
11650 if (nested_cpu_has_posted_intr(vmcs12) && 11714 if (nested_cpu_has_posted_intr(vmcs12) &&
11651 (!nested_cpu_has_vid(vmcs12) || 11715 (!nested_cpu_has_vid(vmcs12) ||
11652 !nested_exit_intr_ack_set(vcpu) || 11716 !nested_exit_intr_ack_set(vcpu) ||
11653 vmcs12->posted_intr_nv & 0xff00)) 11717 (vmcs12->posted_intr_nv & 0xff00) ||
11718 (vmcs12->posted_intr_desc_addr & 0x3f) ||
11719 (!page_address_valid(vcpu, vmcs12->posted_intr_desc_addr))))
11654 return -EINVAL; 11720 return -EINVAL;
11655 11721
11656 /* tpr shadow is needed by all apicv features. */ 11722 /* tpr shadow is needed by all apicv features. */
@@ -11993,8 +12059,13 @@ static void prepare_vmcs02_full(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
11993 12059
11994 set_cr4_guest_host_mask(vmx); 12060 set_cr4_guest_host_mask(vmx);
11995 12061
11996 if (vmx_mpx_supported()) 12062 if (kvm_mpx_supported()) {
11997 vmcs_write64(GUEST_BNDCFGS, vmcs12->guest_bndcfgs); 12063 if (vmx->nested.nested_run_pending &&
12064 (vmcs12->vm_entry_controls & VM_ENTRY_LOAD_BNDCFGS))
12065 vmcs_write64(GUEST_BNDCFGS, vmcs12->guest_bndcfgs);
12066 else
12067 vmcs_write64(GUEST_BNDCFGS, vmx->nested.vmcs01_guest_bndcfgs);
12068 }
11998 12069
11999 if (enable_vpid) { 12070 if (enable_vpid) {
12000 if (nested_cpu_has_vpid(vmcs12) && vmx->nested.vpid02) 12071 if (nested_cpu_has_vpid(vmcs12) && vmx->nested.vpid02)
@@ -12076,11 +12147,10 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
12076 12147
12077 exec_control = vmcs12->pin_based_vm_exec_control; 12148 exec_control = vmcs12->pin_based_vm_exec_control;
12078 12149
12079 /* Preemption timer setting is only taken from vmcs01. */ 12150 /* Preemption timer setting is computed directly in vmx_vcpu_run. */
12080 exec_control &= ~PIN_BASED_VMX_PREEMPTION_TIMER;
12081 exec_control |= vmcs_config.pin_based_exec_ctrl; 12151 exec_control |= vmcs_config.pin_based_exec_ctrl;
12082 if (vmx->hv_deadline_tsc == -1) 12152 exec_control &= ~PIN_BASED_VMX_PREEMPTION_TIMER;
12083 exec_control &= ~PIN_BASED_VMX_PREEMPTION_TIMER; 12153 vmx->loaded_vmcs->hv_timer_armed = false;
12084 12154
12085 /* Posted interrupts setting is only taken from vmcs12. */ 12155 /* Posted interrupts setting is only taken from vmcs12. */
12086 if (nested_cpu_has_posted_intr(vmcs12)) { 12156 if (nested_cpu_has_posted_intr(vmcs12)) {
@@ -12318,6 +12388,9 @@ static int check_vmentry_prereqs(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
12318 vmcs12->guest_activity_state != GUEST_ACTIVITY_HLT) 12388 vmcs12->guest_activity_state != GUEST_ACTIVITY_HLT)
12319 return VMXERR_ENTRY_INVALID_CONTROL_FIELD; 12389 return VMXERR_ENTRY_INVALID_CONTROL_FIELD;
12320 12390
12391 if (nested_cpu_has_vpid(vmcs12) && !vmcs12->virtual_processor_id)
12392 return VMXERR_ENTRY_INVALID_CONTROL_FIELD;
12393
12321 if (nested_vmx_check_io_bitmap_controls(vcpu, vmcs12)) 12394 if (nested_vmx_check_io_bitmap_controls(vcpu, vmcs12))
12322 return VMXERR_ENTRY_INVALID_CONTROL_FIELD; 12395 return VMXERR_ENTRY_INVALID_CONTROL_FIELD;
12323 12396
@@ -12537,15 +12610,21 @@ static int enter_vmx_non_root_mode(struct kvm_vcpu *vcpu, u32 *exit_qual)
12537 struct vmcs12 *vmcs12 = get_vmcs12(vcpu); 12610 struct vmcs12 *vmcs12 = get_vmcs12(vcpu);
12538 bool from_vmentry = !!exit_qual; 12611 bool from_vmentry = !!exit_qual;
12539 u32 dummy_exit_qual; 12612 u32 dummy_exit_qual;
12540 u32 vmcs01_cpu_exec_ctrl; 12613 bool evaluate_pending_interrupts;
12541 int r = 0; 12614 int r = 0;
12542 12615
12543 vmcs01_cpu_exec_ctrl = vmcs_read32(CPU_BASED_VM_EXEC_CONTROL); 12616 evaluate_pending_interrupts = vmcs_read32(CPU_BASED_VM_EXEC_CONTROL) &
12617 (CPU_BASED_VIRTUAL_INTR_PENDING | CPU_BASED_VIRTUAL_NMI_PENDING);
12618 if (likely(!evaluate_pending_interrupts) && kvm_vcpu_apicv_active(vcpu))
12619 evaluate_pending_interrupts |= vmx_has_apicv_interrupt(vcpu);
12544 12620
12545 enter_guest_mode(vcpu); 12621 enter_guest_mode(vcpu);
12546 12622
12547 if (!(vmcs12->vm_entry_controls & VM_ENTRY_LOAD_DEBUG_CONTROLS)) 12623 if (!(vmcs12->vm_entry_controls & VM_ENTRY_LOAD_DEBUG_CONTROLS))
12548 vmx->nested.vmcs01_debugctl = vmcs_read64(GUEST_IA32_DEBUGCTL); 12624 vmx->nested.vmcs01_debugctl = vmcs_read64(GUEST_IA32_DEBUGCTL);
12625 if (kvm_mpx_supported() &&
12626 !(vmcs12->vm_entry_controls & VM_ENTRY_LOAD_BNDCFGS))
12627 vmx->nested.vmcs01_guest_bndcfgs = vmcs_read64(GUEST_BNDCFGS);
12549 12628
12550 vmx_switch_vmcs(vcpu, &vmx->nested.vmcs02); 12629 vmx_switch_vmcs(vcpu, &vmx->nested.vmcs02);
12551 vmx_segment_cache_clear(vmx); 12630 vmx_segment_cache_clear(vmx);
@@ -12585,16 +12664,14 @@ static int enter_vmx_non_root_mode(struct kvm_vcpu *vcpu, u32 *exit_qual)
12585 * to L1 or delivered directly to L2 (e.g. In case L1 don't 12664 * to L1 or delivered directly to L2 (e.g. In case L1 don't
12586 * intercept EXTERNAL_INTERRUPT). 12665 * intercept EXTERNAL_INTERRUPT).
12587 * 12666 *
12588 * Usually this would be handled by L0 requesting a 12667 * Usually this would be handled by the processor noticing an
12589 * IRQ/NMI window by setting VMCS accordingly. However, 12668 * IRQ/NMI window request, or checking RVI during evaluation of
12590 * this setting was done on VMCS01 and now VMCS02 is active 12669 * pending virtual interrupts. However, this setting was done
12591 * instead. Thus, we force L0 to perform pending event 12670 * on VMCS01 and now VMCS02 is active instead. Thus, we force L0
12592 * evaluation by requesting a KVM_REQ_EVENT. 12671 * to perform pending event evaluation by requesting a KVM_REQ_EVENT.
12593 */ 12672 */
12594 if (vmcs01_cpu_exec_ctrl & 12673 if (unlikely(evaluate_pending_interrupts))
12595 (CPU_BASED_VIRTUAL_INTR_PENDING | CPU_BASED_VIRTUAL_NMI_PENDING)) {
12596 kvm_make_request(KVM_REQ_EVENT, vcpu); 12674 kvm_make_request(KVM_REQ_EVENT, vcpu);
12597 }
12598 12675
12599 /* 12676 /*
12600 * Note no nested_vmx_succeed or nested_vmx_fail here. At this point 12677 * Note no nested_vmx_succeed or nested_vmx_fail here. At this point
@@ -12863,6 +12940,11 @@ static int vmx_check_nested_events(struct kvm_vcpu *vcpu, bool external_intr)
12863 return 0; 12940 return 0;
12864} 12941}
12865 12942
12943static void vmx_request_immediate_exit(struct kvm_vcpu *vcpu)
12944{
12945 to_vmx(vcpu)->req_immediate_exit = true;
12946}
12947
12866static u32 vmx_get_preemption_timer_value(struct kvm_vcpu *vcpu) 12948static u32 vmx_get_preemption_timer_value(struct kvm_vcpu *vcpu)
12867{ 12949{
12868 ktime_t remaining = 12950 ktime_t remaining =
@@ -13253,12 +13335,7 @@ static void nested_vmx_vmexit(struct kvm_vcpu *vcpu, u32 exit_reason,
13253 vmcs_write32(VM_EXIT_MSR_LOAD_COUNT, vmx->msr_autoload.host.nr); 13335 vmcs_write32(VM_EXIT_MSR_LOAD_COUNT, vmx->msr_autoload.host.nr);
13254 vmcs_write32(VM_ENTRY_MSR_LOAD_COUNT, vmx->msr_autoload.guest.nr); 13336 vmcs_write32(VM_ENTRY_MSR_LOAD_COUNT, vmx->msr_autoload.guest.nr);
13255 vmcs_write64(TSC_OFFSET, vcpu->arch.tsc_offset); 13337 vmcs_write64(TSC_OFFSET, vcpu->arch.tsc_offset);
13256 if (vmx->hv_deadline_tsc == -1) 13338
13257 vmcs_clear_bits(PIN_BASED_VM_EXEC_CONTROL,
13258 PIN_BASED_VMX_PREEMPTION_TIMER);
13259 else
13260 vmcs_set_bits(PIN_BASED_VM_EXEC_CONTROL,
13261 PIN_BASED_VMX_PREEMPTION_TIMER);
13262 if (kvm_has_tsc_control) 13339 if (kvm_has_tsc_control)
13263 decache_tsc_multiplier(vmx); 13340 decache_tsc_multiplier(vmx);
13264 13341
@@ -13462,18 +13539,12 @@ static int vmx_set_hv_timer(struct kvm_vcpu *vcpu, u64 guest_deadline_tsc)
13462 return -ERANGE; 13539 return -ERANGE;
13463 13540
13464 vmx->hv_deadline_tsc = tscl + delta_tsc; 13541 vmx->hv_deadline_tsc = tscl + delta_tsc;
13465 vmcs_set_bits(PIN_BASED_VM_EXEC_CONTROL,
13466 PIN_BASED_VMX_PREEMPTION_TIMER);
13467
13468 return delta_tsc == 0; 13542 return delta_tsc == 0;
13469} 13543}
13470 13544
13471static void vmx_cancel_hv_timer(struct kvm_vcpu *vcpu) 13545static void vmx_cancel_hv_timer(struct kvm_vcpu *vcpu)
13472{ 13546{
13473 struct vcpu_vmx *vmx = to_vmx(vcpu); 13547 to_vmx(vcpu)->hv_deadline_tsc = -1;
13474 vmx->hv_deadline_tsc = -1;
13475 vmcs_clear_bits(PIN_BASED_VM_EXEC_CONTROL,
13476 PIN_BASED_VMX_PREEMPTION_TIMER);
13477} 13548}
13478#endif 13549#endif
13479 13550
@@ -13954,6 +14025,14 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
13954 ~(KVM_STATE_NESTED_SMM_GUEST_MODE | KVM_STATE_NESTED_SMM_VMXON)) 14025 ~(KVM_STATE_NESTED_SMM_GUEST_MODE | KVM_STATE_NESTED_SMM_VMXON))
13955 return -EINVAL; 14026 return -EINVAL;
13956 14027
14028 /*
14029 * SMM temporarily disables VMX, so we cannot be in guest mode,
14030 * nor can VMLAUNCH/VMRESUME be pending. Outside SMM, SMM flags
14031 * must be zero.
14032 */
14033 if (is_smm(vcpu) ? kvm_state->flags : kvm_state->vmx.smm.flags)
14034 return -EINVAL;
14035
13957 if ((kvm_state->vmx.smm.flags & KVM_STATE_NESTED_SMM_GUEST_MODE) && 14036 if ((kvm_state->vmx.smm.flags & KVM_STATE_NESTED_SMM_GUEST_MODE) &&
13958 !(kvm_state->vmx.smm.flags & KVM_STATE_NESTED_SMM_VMXON)) 14037 !(kvm_state->vmx.smm.flags & KVM_STATE_NESTED_SMM_VMXON))
13959 return -EINVAL; 14038 return -EINVAL;
@@ -14097,6 +14176,7 @@ static struct kvm_x86_ops vmx_x86_ops __ro_after_init = {
14097 .apicv_post_state_restore = vmx_apicv_post_state_restore, 14176 .apicv_post_state_restore = vmx_apicv_post_state_restore,
14098 .hwapic_irr_update = vmx_hwapic_irr_update, 14177 .hwapic_irr_update = vmx_hwapic_irr_update,
14099 .hwapic_isr_update = vmx_hwapic_isr_update, 14178 .hwapic_isr_update = vmx_hwapic_isr_update,
14179 .guest_apic_has_interrupt = vmx_guest_apic_has_interrupt,
14100 .sync_pir_to_irr = vmx_sync_pir_to_irr, 14180 .sync_pir_to_irr = vmx_sync_pir_to_irr,
14101 .deliver_posted_interrupt = vmx_deliver_posted_interrupt, 14181 .deliver_posted_interrupt = vmx_deliver_posted_interrupt,
14102 14182
@@ -14130,6 +14210,7 @@ static struct kvm_x86_ops vmx_x86_ops __ro_after_init = {
14130 .umip_emulated = vmx_umip_emulated, 14210 .umip_emulated = vmx_umip_emulated,
14131 14211
14132 .check_nested_events = vmx_check_nested_events, 14212 .check_nested_events = vmx_check_nested_events,
14213 .request_immediate_exit = vmx_request_immediate_exit,
14133 14214
14134 .sched_in = vmx_sched_in, 14215 .sched_in = vmx_sched_in,
14135 14216
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 542f6315444d..ca717737347e 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -628,7 +628,7 @@ bool pdptrs_changed(struct kvm_vcpu *vcpu)
628 gfn_t gfn; 628 gfn_t gfn;
629 int r; 629 int r;
630 630
631 if (is_long_mode(vcpu) || !is_pae(vcpu)) 631 if (is_long_mode(vcpu) || !is_pae(vcpu) || !is_paging(vcpu))
632 return false; 632 return false;
633 633
634 if (!test_bit(VCPU_EXREG_PDPTR, 634 if (!test_bit(VCPU_EXREG_PDPTR,
@@ -2537,7 +2537,6 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
2537 break; 2537 break;
2538 case MSR_PLATFORM_INFO: 2538 case MSR_PLATFORM_INFO:
2539 if (!msr_info->host_initiated || 2539 if (!msr_info->host_initiated ||
2540 data & ~MSR_PLATFORM_INFO_CPUID_FAULT ||
2541 (!(data & MSR_PLATFORM_INFO_CPUID_FAULT) && 2540 (!(data & MSR_PLATFORM_INFO_CPUID_FAULT) &&
2542 cpuid_fault_enabled(vcpu))) 2541 cpuid_fault_enabled(vcpu)))
2543 return 1; 2542 return 1;
@@ -2780,6 +2779,9 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
2780 msr_info->data = vcpu->arch.osvw.status; 2779 msr_info->data = vcpu->arch.osvw.status;
2781 break; 2780 break;
2782 case MSR_PLATFORM_INFO: 2781 case MSR_PLATFORM_INFO:
2782 if (!msr_info->host_initiated &&
2783 !vcpu->kvm->arch.guest_can_read_msr_platform_info)
2784 return 1;
2783 msr_info->data = vcpu->arch.msr_platform_info; 2785 msr_info->data = vcpu->arch.msr_platform_info;
2784 break; 2786 break;
2785 case MSR_MISC_FEATURES_ENABLES: 2787 case MSR_MISC_FEATURES_ENABLES:
@@ -2927,6 +2929,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
2927 case KVM_CAP_SPLIT_IRQCHIP: 2929 case KVM_CAP_SPLIT_IRQCHIP:
2928 case KVM_CAP_IMMEDIATE_EXIT: 2930 case KVM_CAP_IMMEDIATE_EXIT:
2929 case KVM_CAP_GET_MSR_FEATURES: 2931 case KVM_CAP_GET_MSR_FEATURES:
2932 case KVM_CAP_MSR_PLATFORM_INFO:
2930 r = 1; 2933 r = 1;
2931 break; 2934 break;
2932 case KVM_CAP_SYNC_REGS: 2935 case KVM_CAP_SYNC_REGS:
@@ -4007,19 +4010,23 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
4007 break; 4010 break;
4008 4011
4009 BUILD_BUG_ON(sizeof(user_data_size) != sizeof(user_kvm_nested_state->size)); 4012 BUILD_BUG_ON(sizeof(user_data_size) != sizeof(user_kvm_nested_state->size));
4013 r = -EFAULT;
4010 if (get_user(user_data_size, &user_kvm_nested_state->size)) 4014 if (get_user(user_data_size, &user_kvm_nested_state->size))
4011 return -EFAULT; 4015 break;
4012 4016
4013 r = kvm_x86_ops->get_nested_state(vcpu, user_kvm_nested_state, 4017 r = kvm_x86_ops->get_nested_state(vcpu, user_kvm_nested_state,
4014 user_data_size); 4018 user_data_size);
4015 if (r < 0) 4019 if (r < 0)
4016 return r; 4020 break;
4017 4021
4018 if (r > user_data_size) { 4022 if (r > user_data_size) {
4019 if (put_user(r, &user_kvm_nested_state->size)) 4023 if (put_user(r, &user_kvm_nested_state->size))
4020 return -EFAULT; 4024 r = -EFAULT;
4021 return -E2BIG; 4025 else
4026 r = -E2BIG;
4027 break;
4022 } 4028 }
4029
4023 r = 0; 4030 r = 0;
4024 break; 4031 break;
4025 } 4032 }
@@ -4031,19 +4038,21 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
4031 if (!kvm_x86_ops->set_nested_state) 4038 if (!kvm_x86_ops->set_nested_state)
4032 break; 4039 break;
4033 4040
4041 r = -EFAULT;
4034 if (copy_from_user(&kvm_state, user_kvm_nested_state, sizeof(kvm_state))) 4042 if (copy_from_user(&kvm_state, user_kvm_nested_state, sizeof(kvm_state)))
4035 return -EFAULT; 4043 break;
4036 4044
4045 r = -EINVAL;
4037 if (kvm_state.size < sizeof(kvm_state)) 4046 if (kvm_state.size < sizeof(kvm_state))
4038 return -EINVAL; 4047 break;
4039 4048
4040 if (kvm_state.flags & 4049 if (kvm_state.flags &
4041 ~(KVM_STATE_NESTED_RUN_PENDING | KVM_STATE_NESTED_GUEST_MODE)) 4050 ~(KVM_STATE_NESTED_RUN_PENDING | KVM_STATE_NESTED_GUEST_MODE))
4042 return -EINVAL; 4051 break;
4043 4052
4044 /* nested_run_pending implies guest_mode. */ 4053 /* nested_run_pending implies guest_mode. */
4045 if (kvm_state.flags == KVM_STATE_NESTED_RUN_PENDING) 4054 if (kvm_state.flags == KVM_STATE_NESTED_RUN_PENDING)
4046 return -EINVAL; 4055 break;
4047 4056
4048 r = kvm_x86_ops->set_nested_state(vcpu, user_kvm_nested_state, &kvm_state); 4057 r = kvm_x86_ops->set_nested_state(vcpu, user_kvm_nested_state, &kvm_state);
4049 break; 4058 break;
@@ -4350,6 +4359,10 @@ split_irqchip_unlock:
4350 kvm->arch.pause_in_guest = true; 4359 kvm->arch.pause_in_guest = true;
4351 r = 0; 4360 r = 0;
4352 break; 4361 break;
4362 case KVM_CAP_MSR_PLATFORM_INFO:
4363 kvm->arch.guest_can_read_msr_platform_info = cap->args[0];
4364 r = 0;
4365 break;
4353 default: 4366 default:
4354 r = -EINVAL; 4367 r = -EINVAL;
4355 break; 4368 break;
@@ -4685,7 +4698,7 @@ static void kvm_init_msr_list(void)
4685 */ 4698 */
4686 switch (msrs_to_save[i]) { 4699 switch (msrs_to_save[i]) {
4687 case MSR_IA32_BNDCFGS: 4700 case MSR_IA32_BNDCFGS:
4688 if (!kvm_x86_ops->mpx_supported()) 4701 if (!kvm_mpx_supported())
4689 continue; 4702 continue;
4690 break; 4703 break;
4691 case MSR_TSC_AUX: 4704 case MSR_TSC_AUX:
@@ -7361,6 +7374,12 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
7361} 7374}
7362EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page); 7375EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
7363 7376
7377void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
7378{
7379 smp_send_reschedule(vcpu->cpu);
7380}
7381EXPORT_SYMBOL_GPL(__kvm_request_immediate_exit);
7382
7364/* 7383/*
7365 * Returns 1 to let vcpu_run() continue the guest execution loop without 7384 * Returns 1 to let vcpu_run() continue the guest execution loop without
7366 * exiting to the userspace. Otherwise, the value will be returned to the 7385 * exiting to the userspace. Otherwise, the value will be returned to the
@@ -7565,7 +7584,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
7565 7584
7566 if (req_immediate_exit) { 7585 if (req_immediate_exit) {
7567 kvm_make_request(KVM_REQ_EVENT, vcpu); 7586 kvm_make_request(KVM_REQ_EVENT, vcpu);
7568 smp_send_reschedule(vcpu->cpu); 7587 kvm_x86_ops->request_immediate_exit(vcpu);
7569 } 7588 }
7570 7589
7571 trace_kvm_entry(vcpu->vcpu_id); 7590 trace_kvm_entry(vcpu->vcpu_id);
@@ -7829,6 +7848,29 @@ static int complete_emulated_mmio(struct kvm_vcpu *vcpu)
7829 return 0; 7848 return 0;
7830} 7849}
7831 7850
7851/* Swap (qemu) user FPU context for the guest FPU context. */
7852static void kvm_load_guest_fpu(struct kvm_vcpu *vcpu)
7853{
7854 preempt_disable();
7855 copy_fpregs_to_fpstate(&vcpu->arch.user_fpu);
7856 /* PKRU is separately restored in kvm_x86_ops->run. */
7857 __copy_kernel_to_fpregs(&vcpu->arch.guest_fpu.state,
7858 ~XFEATURE_MASK_PKRU);
7859 preempt_enable();
7860 trace_kvm_fpu(1);
7861}
7862
7863/* When vcpu_run ends, restore user space FPU context. */
7864static void kvm_put_guest_fpu(struct kvm_vcpu *vcpu)
7865{
7866 preempt_disable();
7867 copy_fpregs_to_fpstate(&vcpu->arch.guest_fpu);
7868 copy_kernel_to_fpregs(&vcpu->arch.user_fpu.state);
7869 preempt_enable();
7870 ++vcpu->stat.fpu_reload;
7871 trace_kvm_fpu(0);
7872}
7873
7832int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) 7874int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
7833{ 7875{
7834 int r; 7876 int r;
@@ -8177,7 +8219,7 @@ static int __set_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs)
8177 kvm_update_cpuid(vcpu); 8219 kvm_update_cpuid(vcpu);
8178 8220
8179 idx = srcu_read_lock(&vcpu->kvm->srcu); 8221 idx = srcu_read_lock(&vcpu->kvm->srcu);
8180 if (!is_long_mode(vcpu) && is_pae(vcpu)) { 8222 if (!is_long_mode(vcpu) && is_pae(vcpu) && is_paging(vcpu)) {
8181 load_pdptrs(vcpu, vcpu->arch.walk_mmu, kvm_read_cr3(vcpu)); 8223 load_pdptrs(vcpu, vcpu->arch.walk_mmu, kvm_read_cr3(vcpu));
8182 mmu_reset_needed = 1; 8224 mmu_reset_needed = 1;
8183 } 8225 }
@@ -8406,29 +8448,6 @@ static void fx_init(struct kvm_vcpu *vcpu)
8406 vcpu->arch.cr0 |= X86_CR0_ET; 8448 vcpu->arch.cr0 |= X86_CR0_ET;
8407} 8449}
8408 8450
8409/* Swap (qemu) user FPU context for the guest FPU context. */
8410void kvm_load_guest_fpu(struct kvm_vcpu *vcpu)
8411{
8412 preempt_disable();
8413 copy_fpregs_to_fpstate(&vcpu->arch.user_fpu);
8414 /* PKRU is separately restored in kvm_x86_ops->run. */
8415 __copy_kernel_to_fpregs(&vcpu->arch.guest_fpu.state,
8416 ~XFEATURE_MASK_PKRU);
8417 preempt_enable();
8418 trace_kvm_fpu(1);
8419}
8420
8421/* When vcpu_run ends, restore user space FPU context. */
8422void kvm_put_guest_fpu(struct kvm_vcpu *vcpu)
8423{
8424 preempt_disable();
8425 copy_fpregs_to_fpstate(&vcpu->arch.guest_fpu);
8426 copy_kernel_to_fpregs(&vcpu->arch.user_fpu.state);
8427 preempt_enable();
8428 ++vcpu->stat.fpu_reload;
8429 trace_kvm_fpu(0);
8430}
8431
8432void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu) 8451void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu)
8433{ 8452{
8434 void *wbinvd_dirty_mask = vcpu->arch.wbinvd_dirty_mask; 8453 void *wbinvd_dirty_mask = vcpu->arch.wbinvd_dirty_mask;
@@ -8852,6 +8871,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
8852 kvm->arch.kvmclock_offset = -ktime_get_boot_ns(); 8871 kvm->arch.kvmclock_offset = -ktime_get_boot_ns();
8853 pvclock_update_vm_gtod_copy(kvm); 8872 pvclock_update_vm_gtod_copy(kvm);
8854 8873
8874 kvm->arch.guest_can_read_msr_platform_info = true;
8875
8855 INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn); 8876 INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn);
8856 INIT_DELAYED_WORK(&kvm->arch.kvmclock_sync_work, kvmclock_sync_fn); 8877 INIT_DELAYED_WORK(&kvm->arch.kvmclock_sync_work, kvmclock_sync_fn);
8857 8878
@@ -9200,6 +9221,13 @@ void kvm_arch_flush_shadow_memslot(struct kvm *kvm,
9200 kvm_page_track_flush_slot(kvm, slot); 9221 kvm_page_track_flush_slot(kvm, slot);
9201} 9222}
9202 9223
9224static inline bool kvm_guest_apic_has_interrupt(struct kvm_vcpu *vcpu)
9225{
9226 return (is_guest_mode(vcpu) &&
9227 kvm_x86_ops->guest_apic_has_interrupt &&
9228 kvm_x86_ops->guest_apic_has_interrupt(vcpu));
9229}
9230
9203static inline bool kvm_vcpu_has_events(struct kvm_vcpu *vcpu) 9231static inline bool kvm_vcpu_has_events(struct kvm_vcpu *vcpu)
9204{ 9232{
9205 if (!list_empty_careful(&vcpu->async_pf.done)) 9233 if (!list_empty_careful(&vcpu->async_pf.done))
@@ -9224,7 +9252,8 @@ static inline bool kvm_vcpu_has_events(struct kvm_vcpu *vcpu)
9224 return true; 9252 return true;
9225 9253
9226 if (kvm_arch_interrupt_allowed(vcpu) && 9254 if (kvm_arch_interrupt_allowed(vcpu) &&
9227 kvm_cpu_has_interrupt(vcpu)) 9255 (kvm_cpu_has_interrupt(vcpu) ||
9256 kvm_guest_apic_has_interrupt(vcpu)))
9228 return true; 9257 return true;
9229 9258
9230 if (kvm_hv_has_stimer_pending(vcpu)) 9259 if (kvm_hv_has_stimer_pending(vcpu))
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 7a8fc26c1115..faca978ebf9d 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -815,10 +815,14 @@ void free_kernel_image_pages(void *begin, void *end)
815 set_memory_np_noalias(begin_ul, len_pages); 815 set_memory_np_noalias(begin_ul, len_pages);
816} 816}
817 817
818void __weak mem_encrypt_free_decrypted_mem(void) { }
819
818void __ref free_initmem(void) 820void __ref free_initmem(void)
819{ 821{
820 e820__reallocate_tables(); 822 e820__reallocate_tables();
821 823
824 mem_encrypt_free_decrypted_mem();
825
822 free_kernel_image_pages(&__init_begin, &__init_end); 826 free_kernel_image_pages(&__init_begin, &__init_end);
823} 827}
824 828
diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
index b2de398d1fd3..006f373f54ab 100644
--- a/arch/x86/mm/mem_encrypt.c
+++ b/arch/x86/mm/mem_encrypt.c
@@ -348,6 +348,30 @@ bool sev_active(void)
348EXPORT_SYMBOL(sev_active); 348EXPORT_SYMBOL(sev_active);
349 349
350/* Architecture __weak replacement functions */ 350/* Architecture __weak replacement functions */
351void __init mem_encrypt_free_decrypted_mem(void)
352{
353 unsigned long vaddr, vaddr_end, npages;
354 int r;
355
356 vaddr = (unsigned long)__start_bss_decrypted_unused;
357 vaddr_end = (unsigned long)__end_bss_decrypted;
358 npages = (vaddr_end - vaddr) >> PAGE_SHIFT;
359
360 /*
361 * The unused memory range was mapped decrypted, change the encryption
362 * attribute from decrypted to encrypted before freeing it.
363 */
364 if (mem_encrypt_active()) {
365 r = set_memory_encrypted(vaddr, npages);
366 if (r) {
367 pr_warn("failed to free unused decrypted pages\n");
368 return;
369 }
370 }
371
372 free_init_pages("unused decrypted", vaddr, vaddr_end);
373}
374
351void __init mem_encrypt_init(void) 375void __init mem_encrypt_init(void)
352{ 376{
353 if (!sme_me_mask) 377 if (!sme_me_mask)
diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
index ae394552fb94..59274e2c1ac4 100644
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -115,6 +115,8 @@ static inline void pgd_list_del(pgd_t *pgd)
115 115
116#define UNSHARED_PTRS_PER_PGD \ 116#define UNSHARED_PTRS_PER_PGD \
117 (SHARED_KERNEL_PMD ? KERNEL_PGD_BOUNDARY : PTRS_PER_PGD) 117 (SHARED_KERNEL_PMD ? KERNEL_PGD_BOUNDARY : PTRS_PER_PGD)
118#define MAX_UNSHARED_PTRS_PER_PGD \
119 max_t(size_t, KERNEL_PGD_BOUNDARY, PTRS_PER_PGD)
118 120
119 121
120static void pgd_set_mm(pgd_t *pgd, struct mm_struct *mm) 122static void pgd_set_mm(pgd_t *pgd, struct mm_struct *mm)
@@ -181,6 +183,7 @@ static void pgd_dtor(pgd_t *pgd)
181 * and initialize the kernel pmds here. 183 * and initialize the kernel pmds here.
182 */ 184 */
183#define PREALLOCATED_PMDS UNSHARED_PTRS_PER_PGD 185#define PREALLOCATED_PMDS UNSHARED_PTRS_PER_PGD
186#define MAX_PREALLOCATED_PMDS MAX_UNSHARED_PTRS_PER_PGD
184 187
185/* 188/*
186 * We allocate separate PMDs for the kernel part of the user page-table 189 * We allocate separate PMDs for the kernel part of the user page-table
@@ -189,6 +192,7 @@ static void pgd_dtor(pgd_t *pgd)
189 */ 192 */
190#define PREALLOCATED_USER_PMDS (static_cpu_has(X86_FEATURE_PTI) ? \ 193#define PREALLOCATED_USER_PMDS (static_cpu_has(X86_FEATURE_PTI) ? \
191 KERNEL_PGD_PTRS : 0) 194 KERNEL_PGD_PTRS : 0)
195#define MAX_PREALLOCATED_USER_PMDS KERNEL_PGD_PTRS
192 196
193void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd) 197void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd)
194{ 198{
@@ -210,7 +214,9 @@ void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd)
210 214
211/* No need to prepopulate any pagetable entries in non-PAE modes. */ 215/* No need to prepopulate any pagetable entries in non-PAE modes. */
212#define PREALLOCATED_PMDS 0 216#define PREALLOCATED_PMDS 0
217#define MAX_PREALLOCATED_PMDS 0
213#define PREALLOCATED_USER_PMDS 0 218#define PREALLOCATED_USER_PMDS 0
219#define MAX_PREALLOCATED_USER_PMDS 0
214#endif /* CONFIG_X86_PAE */ 220#endif /* CONFIG_X86_PAE */
215 221
216static void free_pmds(struct mm_struct *mm, pmd_t *pmds[], int count) 222static void free_pmds(struct mm_struct *mm, pmd_t *pmds[], int count)
@@ -428,8 +434,8 @@ static inline void _pgd_free(pgd_t *pgd)
428pgd_t *pgd_alloc(struct mm_struct *mm) 434pgd_t *pgd_alloc(struct mm_struct *mm)
429{ 435{
430 pgd_t *pgd; 436 pgd_t *pgd;
431 pmd_t *u_pmds[PREALLOCATED_USER_PMDS]; 437 pmd_t *u_pmds[MAX_PREALLOCATED_USER_PMDS];
432 pmd_t *pmds[PREALLOCATED_PMDS]; 438 pmd_t *pmds[MAX_PREALLOCATED_PMDS];
433 439
434 pgd = _pgd_alloc(); 440 pgd = _pgd_alloc();
435 441
@@ -637,6 +643,15 @@ void __native_set_fixmap(enum fixed_addresses idx, pte_t pte)
637{ 643{
638 unsigned long address = __fix_to_virt(idx); 644 unsigned long address = __fix_to_virt(idx);
639 645
646#ifdef CONFIG_X86_64
647 /*
648 * Ensure that the static initial page tables are covering the
649 * fixmap completely.
650 */
651 BUILD_BUG_ON(__end_of_permanent_fixed_addresses >
652 (FIXMAP_PMD_NUM * PTRS_PER_PTE));
653#endif
654
640 if (idx >= __end_of_fixed_addresses) { 655 if (idx >= __end_of_fixed_addresses) {
641 BUG(); 656 BUG();
642 return; 657 return;
diff --git a/arch/x86/platform/efi/efi_32.c b/arch/x86/platform/efi/efi_32.c
index 05ca14222463..9959657127f4 100644
--- a/arch/x86/platform/efi/efi_32.c
+++ b/arch/x86/platform/efi/efi_32.c
@@ -85,10 +85,9 @@ pgd_t * __init efi_call_phys_prolog(void)
85 85
86void __init efi_call_phys_epilog(pgd_t *save_pgd) 86void __init efi_call_phys_epilog(pgd_t *save_pgd)
87{ 87{
88 load_fixmap_gdt(0);
88 load_cr3(save_pgd); 89 load_cr3(save_pgd);
89 __flush_tlb_all(); 90 __flush_tlb_all();
90
91 load_fixmap_gdt(0);
92} 91}
93 92
94void __init efi_runtime_update_mappings(void) 93void __init efi_runtime_update_mappings(void)
diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 2fe5c9b1816b..dd461c0167ef 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -1907,7 +1907,7 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
1907 /* L3_k[511] -> level2_fixmap_pgt */ 1907 /* L3_k[511] -> level2_fixmap_pgt */
1908 convert_pfn_mfn(level3_kernel_pgt); 1908 convert_pfn_mfn(level3_kernel_pgt);
1909 1909
1910 /* L3_k[511][506] -> level1_fixmap_pgt */ 1910 /* L3_k[511][508-FIXMAP_PMD_NUM ... 507] -> level1_fixmap_pgt */
1911 convert_pfn_mfn(level2_fixmap_pgt); 1911 convert_pfn_mfn(level2_fixmap_pgt);
1912 1912
1913 /* We get [511][511] and have Xen's version of level2_kernel_pgt */ 1913 /* We get [511][511] and have Xen's version of level2_kernel_pgt */
@@ -1952,7 +1952,11 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
1952 set_page_prot(level2_ident_pgt, PAGE_KERNEL_RO); 1952 set_page_prot(level2_ident_pgt, PAGE_KERNEL_RO);
1953 set_page_prot(level2_kernel_pgt, PAGE_KERNEL_RO); 1953 set_page_prot(level2_kernel_pgt, PAGE_KERNEL_RO);
1954 set_page_prot(level2_fixmap_pgt, PAGE_KERNEL_RO); 1954 set_page_prot(level2_fixmap_pgt, PAGE_KERNEL_RO);
1955 set_page_prot(level1_fixmap_pgt, PAGE_KERNEL_RO); 1955
1956 for (i = 0; i < FIXMAP_PMD_NUM; i++) {
1957 set_page_prot(level1_fixmap_pgt + i * PTRS_PER_PTE,
1958 PAGE_KERNEL_RO);
1959 }
1956 1960
1957 /* Pin down new L4 */ 1961 /* Pin down new L4 */
1958 pin_pagetable_pfn(MMUEXT_PIN_L4_TABLE, 1962 pin_pagetable_pfn(MMUEXT_PIN_L4_TABLE,
diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 7d00d4ad44d4..95997e6c0696 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -478,7 +478,7 @@ static void xen_convert_regs(const struct xen_pmu_regs *xen_regs,
478irqreturn_t xen_pmu_irq_handler(int irq, void *dev_id) 478irqreturn_t xen_pmu_irq_handler(int irq, void *dev_id)
479{ 479{
480 int err, ret = IRQ_NONE; 480 int err, ret = IRQ_NONE;
481 struct pt_regs regs; 481 struct pt_regs regs = {0};
482 const struct xen_pmu_data *xenpmu_data = get_xenpmu_data(); 482 const struct xen_pmu_data *xenpmu_data = get_xenpmu_data();
483 uint8_t xenpmu_flags = get_xenpmu_flags(); 483 uint8_t xenpmu_flags = get_xenpmu_flags();
484 484
diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
index 04d038f3b6fa..b9ad83a0ee5d 100644
--- a/arch/xtensa/Kconfig
+++ b/arch/xtensa/Kconfig
@@ -4,6 +4,7 @@ config ZONE_DMA
4 4
5config XTENSA 5config XTENSA
6 def_bool y 6 def_bool y
7 select ARCH_HAS_SG_CHAIN
7 select ARCH_HAS_SYNC_DMA_FOR_CPU 8 select ARCH_HAS_SYNC_DMA_FOR_CPU
8 select ARCH_HAS_SYNC_DMA_FOR_DEVICE 9 select ARCH_HAS_SYNC_DMA_FOR_DEVICE
9 select ARCH_NO_COHERENT_DMA_MMAP if !MMU 10 select ARCH_NO_COHERENT_DMA_MMAP if !MMU
diff --git a/arch/xtensa/Makefile b/arch/xtensa/Makefile
index 295c120ed099..d67e30faff9c 100644
--- a/arch/xtensa/Makefile
+++ b/arch/xtensa/Makefile
@@ -64,11 +64,7 @@ endif
64vardirs := $(patsubst %,arch/xtensa/variants/%/,$(variant-y)) 64vardirs := $(patsubst %,arch/xtensa/variants/%/,$(variant-y))
65plfdirs := $(patsubst %,arch/xtensa/platforms/%/,$(platform-y)) 65plfdirs := $(patsubst %,arch/xtensa/platforms/%/,$(platform-y))
66 66
67ifeq ($(KBUILD_SRC),)
68KBUILD_CPPFLAGS += $(patsubst %,-I%include,$(vardirs) $(plfdirs))
69else
70KBUILD_CPPFLAGS += $(patsubst %,-I$(srctree)/%include,$(vardirs) $(plfdirs)) 67KBUILD_CPPFLAGS += $(patsubst %,-I$(srctree)/%include,$(vardirs) $(plfdirs))
71endif
72 68
73KBUILD_DEFCONFIG := iss_defconfig 69KBUILD_DEFCONFIG := iss_defconfig
74 70
diff --git a/arch/xtensa/platforms/iss/setup.c b/arch/xtensa/platforms/iss/setup.c
index f4bbb28026f8..58709e89a8ed 100644
--- a/arch/xtensa/platforms/iss/setup.c
+++ b/arch/xtensa/platforms/iss/setup.c
@@ -78,23 +78,28 @@ static struct notifier_block iss_panic_block = {
78 78
79void __init platform_setup(char **p_cmdline) 79void __init platform_setup(char **p_cmdline)
80{ 80{
81 static void *argv[COMMAND_LINE_SIZE / sizeof(void *)] __initdata;
82 static char cmdline[COMMAND_LINE_SIZE] __initdata;
81 int argc = simc_argc(); 83 int argc = simc_argc();
82 int argv_size = simc_argv_size(); 84 int argv_size = simc_argv_size();
83 85
84 if (argc > 1) { 86 if (argc > 1) {
85 void **argv = alloc_bootmem(argv_size); 87 if (argv_size > sizeof(argv)) {
86 char *cmdline = alloc_bootmem(argv_size); 88 pr_err("%s: command line too long: argv_size = %d\n",
87 int i; 89 __func__, argv_size);
90 } else {
91 int i;
88 92
89 cmdline[0] = 0; 93 cmdline[0] = 0;
90 simc_argv((void *)argv); 94 simc_argv((void *)argv);
91 95
92 for (i = 1; i < argc; ++i) { 96 for (i = 1; i < argc; ++i) {
93 if (i > 1) 97 if (i > 1)
94 strcat(cmdline, " "); 98 strcat(cmdline, " ");
95 strcat(cmdline, argv[i]); 99 strcat(cmdline, argv[i]);
100 }
101 *p_cmdline = cmdline;
96 } 102 }
97 *p_cmdline = cmdline;
98 } 103 }
99 104
100 atomic_notifier_chain_register(&panic_notifier_list, &iss_panic_block); 105 atomic_notifier_chain_register(&panic_notifier_list, &iss_panic_block);
diff --git a/block/bio.c b/block/bio.c
index 8c680a776171..0093bed81c0e 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1684,7 +1684,7 @@ void generic_end_io_acct(struct request_queue *q, int req_op,
1684 const int sgrp = op_stat_group(req_op); 1684 const int sgrp = op_stat_group(req_op);
1685 int cpu = part_stat_lock(); 1685 int cpu = part_stat_lock();
1686 1686
1687 part_stat_add(cpu, part, ticks[sgrp], duration); 1687 part_stat_add(cpu, part, nsecs[sgrp], jiffies_to_nsecs(duration));
1688 part_round_stats(q, cpu, part); 1688 part_round_stats(q, cpu, part);
1689 part_dec_in_flight(q, part, op_is_write(req_op)); 1689 part_dec_in_flight(q, part, op_is_write(req_op));
1690 1690
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index c19f9078da1e..c630e02836a8 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1510,8 +1510,10 @@ int blkcg_policy_register(struct blkcg_policy *pol)
1510 for (i = 0; i < BLKCG_MAX_POLS; i++) 1510 for (i = 0; i < BLKCG_MAX_POLS; i++)
1511 if (!blkcg_policy[i]) 1511 if (!blkcg_policy[i])
1512 break; 1512 break;
1513 if (i >= BLKCG_MAX_POLS) 1513 if (i >= BLKCG_MAX_POLS) {
1514 pr_warn("blkcg_policy_register: BLKCG_MAX_POLS too small\n");
1514 goto err_unlock; 1515 goto err_unlock;
1516 }
1515 1517
1516 /* Make sure cpd/pd_alloc_fn and cpd/pd_free_fn in pairs */ 1518 /* Make sure cpd/pd_alloc_fn and cpd/pd_free_fn in pairs */
1517 if ((!pol->cpd_alloc_fn ^ !pol->cpd_free_fn) || 1519 if ((!pol->cpd_alloc_fn ^ !pol->cpd_free_fn) ||
diff --git a/block/blk-core.c b/block/blk-core.c
index 4dbc93f43b38..cff0a60ee200 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2733,17 +2733,15 @@ void blk_account_io_done(struct request *req, u64 now)
2733 * containing request is enough. 2733 * containing request is enough.
2734 */ 2734 */
2735 if (blk_do_io_stat(req) && !(req->rq_flags & RQF_FLUSH_SEQ)) { 2735 if (blk_do_io_stat(req) && !(req->rq_flags & RQF_FLUSH_SEQ)) {
2736 unsigned long duration;
2737 const int sgrp = op_stat_group(req_op(req)); 2736 const int sgrp = op_stat_group(req_op(req));
2738 struct hd_struct *part; 2737 struct hd_struct *part;
2739 int cpu; 2738 int cpu;
2740 2739
2741 duration = nsecs_to_jiffies(now - req->start_time_ns);
2742 cpu = part_stat_lock(); 2740 cpu = part_stat_lock();
2743 part = req->part; 2741 part = req->part;
2744 2742
2745 part_stat_inc(cpu, part, ios[sgrp]); 2743 part_stat_inc(cpu, part, ios[sgrp]);
2746 part_stat_add(cpu, part, ticks[sgrp], duration); 2744 part_stat_add(cpu, part, nsecs[sgrp], now - req->start_time_ns);
2747 part_round_stats(req->q, cpu, part); 2745 part_round_stats(req->q, cpu, part);
2748 part_dec_in_flight(req->q, part, rq_data_dir(req)); 2746 part_dec_in_flight(req->q, part, rq_data_dir(req));
2749 2747
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 94e1ed667b6e..41317c50a446 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -322,16 +322,11 @@ void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_iter_fn *fn,
322 322
323 /* 323 /*
324 * __blk_mq_update_nr_hw_queues will update the nr_hw_queues and 324 * __blk_mq_update_nr_hw_queues will update the nr_hw_queues and
325 * queue_hw_ctx after freeze the queue. So we could use q_usage_counter 325 * queue_hw_ctx after freeze the queue, so we use q_usage_counter
326 * to avoid race with it. __blk_mq_update_nr_hw_queues will users 326 * to avoid race with it.
327 * synchronize_rcu to ensure all of the users go out of the critical
328 * section below and see zeroed q_usage_counter.
329 */ 327 */
330 rcu_read_lock(); 328 if (!percpu_ref_tryget(&q->q_usage_counter))
331 if (percpu_ref_is_zero(&q->q_usage_counter)) {
332 rcu_read_unlock();
333 return; 329 return;
334 }
335 330
336 queue_for_each_hw_ctx(q, hctx, i) { 331 queue_for_each_hw_ctx(q, hctx, i) {
337 struct blk_mq_tags *tags = hctx->tags; 332 struct blk_mq_tags *tags = hctx->tags;
@@ -347,7 +342,7 @@ void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_iter_fn *fn,
347 bt_for_each(hctx, &tags->breserved_tags, fn, priv, true); 342 bt_for_each(hctx, &tags->breserved_tags, fn, priv, true);
348 bt_for_each(hctx, &tags->bitmap_tags, fn, priv, false); 343 bt_for_each(hctx, &tags->bitmap_tags, fn, priv, false);
349 } 344 }
350 rcu_read_unlock(); 345 blk_queue_exit(q);
351} 346}
352 347
353static int bt_alloc(struct sbitmap_queue *bt, unsigned int depth, 348static int bt_alloc(struct sbitmap_queue *bt, unsigned int depth,
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 85a1c1a59c72..e3c39ea8e17b 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1628,7 +1628,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
1628 BUG_ON(!rq->q); 1628 BUG_ON(!rq->q);
1629 if (rq->mq_ctx != this_ctx) { 1629 if (rq->mq_ctx != this_ctx) {
1630 if (this_ctx) { 1630 if (this_ctx) {
1631 trace_block_unplug(this_q, depth, from_schedule); 1631 trace_block_unplug(this_q, depth, !from_schedule);
1632 blk_mq_sched_insert_requests(this_q, this_ctx, 1632 blk_mq_sched_insert_requests(this_q, this_ctx,
1633 &ctx_list, 1633 &ctx_list,
1634 from_schedule); 1634 from_schedule);
@@ -1648,7 +1648,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
1648 * on 'ctx_list'. Do those. 1648 * on 'ctx_list'. Do those.
1649 */ 1649 */
1650 if (this_ctx) { 1650 if (this_ctx) {
1651 trace_block_unplug(this_q, depth, from_schedule); 1651 trace_block_unplug(this_q, depth, !from_schedule);
1652 blk_mq_sched_insert_requests(this_q, this_ctx, &ctx_list, 1652 blk_mq_sched_insert_requests(this_q, this_ctx, &ctx_list,
1653 from_schedule); 1653 from_schedule);
1654 } 1654 }
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 8e20a0677dcf..8ac93fcbaa2e 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -310,6 +310,7 @@ static void scale_up(struct rq_wb *rwb)
310 rq_depth_scale_up(&rwb->rq_depth); 310 rq_depth_scale_up(&rwb->rq_depth);
311 calc_wb_limits(rwb); 311 calc_wb_limits(rwb);
312 rwb->unknown_cnt = 0; 312 rwb->unknown_cnt = 0;
313 rwb_wake_all(rwb);
313 rwb_trace_step(rwb, "scale up"); 314 rwb_trace_step(rwb, "scale up");
314} 315}
315 316
@@ -318,7 +319,6 @@ static void scale_down(struct rq_wb *rwb, bool hard_throttle)
318 rq_depth_scale_down(&rwb->rq_depth, hard_throttle); 319 rq_depth_scale_down(&rwb->rq_depth, hard_throttle);
319 calc_wb_limits(rwb); 320 calc_wb_limits(rwb);
320 rwb->unknown_cnt = 0; 321 rwb->unknown_cnt = 0;
321 rwb_wake_all(rwb);
322 rwb_trace_step(rwb, "scale down"); 322 rwb_trace_step(rwb, "scale down");
323} 323}
324 324
diff --git a/block/elevator.c b/block/elevator.c
index 6a06b5d040e5..fae58b2f906f 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -609,7 +609,7 @@ void elv_drain_elevator(struct request_queue *q)
609 609
610 while (e->type->ops.sq.elevator_dispatch_fn(q, 1)) 610 while (e->type->ops.sq.elevator_dispatch_fn(q, 1))
611 ; 611 ;
612 if (q->nr_sorted && printed++ < 10) { 612 if (q->nr_sorted && !blk_queue_is_zoned(q) && printed++ < 10 ) {
613 printk(KERN_ERR "%s: forced dispatching is broken " 613 printk(KERN_ERR "%s: forced dispatching is broken "
614 "(nr_sorted=%u), please report this\n", 614 "(nr_sorted=%u), please report this\n",
615 q->elevator->type->elevator_name, q->nr_sorted); 615 q->elevator->type->elevator_name, q->nr_sorted);
diff --git a/block/genhd.c b/block/genhd.c
index 8cc719a37b32..be5bab20b2ab 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1343,18 +1343,18 @@ static int diskstats_show(struct seq_file *seqf, void *v)
1343 part_stat_read(hd, ios[STAT_READ]), 1343 part_stat_read(hd, ios[STAT_READ]),
1344 part_stat_read(hd, merges[STAT_READ]), 1344 part_stat_read(hd, merges[STAT_READ]),
1345 part_stat_read(hd, sectors[STAT_READ]), 1345 part_stat_read(hd, sectors[STAT_READ]),
1346 jiffies_to_msecs(part_stat_read(hd, ticks[STAT_READ])), 1346 (unsigned int)part_stat_read_msecs(hd, STAT_READ),
1347 part_stat_read(hd, ios[STAT_WRITE]), 1347 part_stat_read(hd, ios[STAT_WRITE]),
1348 part_stat_read(hd, merges[STAT_WRITE]), 1348 part_stat_read(hd, merges[STAT_WRITE]),
1349 part_stat_read(hd, sectors[STAT_WRITE]), 1349 part_stat_read(hd, sectors[STAT_WRITE]),
1350 jiffies_to_msecs(part_stat_read(hd, ticks[STAT_WRITE])), 1350 (unsigned int)part_stat_read_msecs(hd, STAT_WRITE),
1351 inflight[0], 1351 inflight[0],
1352 jiffies_to_msecs(part_stat_read(hd, io_ticks)), 1352 jiffies_to_msecs(part_stat_read(hd, io_ticks)),
1353 jiffies_to_msecs(part_stat_read(hd, time_in_queue)), 1353 jiffies_to_msecs(part_stat_read(hd, time_in_queue)),
1354 part_stat_read(hd, ios[STAT_DISCARD]), 1354 part_stat_read(hd, ios[STAT_DISCARD]),
1355 part_stat_read(hd, merges[STAT_DISCARD]), 1355 part_stat_read(hd, merges[STAT_DISCARD]),
1356 part_stat_read(hd, sectors[STAT_DISCARD]), 1356 part_stat_read(hd, sectors[STAT_DISCARD]),
1357 jiffies_to_msecs(part_stat_read(hd, ticks[STAT_DISCARD])) 1357 (unsigned int)part_stat_read_msecs(hd, STAT_DISCARD)
1358 ); 1358 );
1359 } 1359 }
1360 disk_part_iter_exit(&piter); 1360 disk_part_iter_exit(&piter);
diff --git a/block/partition-generic.c b/block/partition-generic.c
index 5a8975a1201c..d3d14e81fb12 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -136,18 +136,18 @@ ssize_t part_stat_show(struct device *dev,
136 part_stat_read(p, ios[STAT_READ]), 136 part_stat_read(p, ios[STAT_READ]),
137 part_stat_read(p, merges[STAT_READ]), 137 part_stat_read(p, merges[STAT_READ]),
138 (unsigned long long)part_stat_read(p, sectors[STAT_READ]), 138 (unsigned long long)part_stat_read(p, sectors[STAT_READ]),
139 jiffies_to_msecs(part_stat_read(p, ticks[STAT_READ])), 139 (unsigned int)part_stat_read_msecs(p, STAT_READ),
140 part_stat_read(p, ios[STAT_WRITE]), 140 part_stat_read(p, ios[STAT_WRITE]),
141 part_stat_read(p, merges[STAT_WRITE]), 141 part_stat_read(p, merges[STAT_WRITE]),
142 (unsigned long long)part_stat_read(p, sectors[STAT_WRITE]), 142 (unsigned long long)part_stat_read(p, sectors[STAT_WRITE]),
143 jiffies_to_msecs(part_stat_read(p, ticks[STAT_WRITE])), 143 (unsigned int)part_stat_read_msecs(p, STAT_WRITE),
144 inflight[0], 144 inflight[0],
145 jiffies_to_msecs(part_stat_read(p, io_ticks)), 145 jiffies_to_msecs(part_stat_read(p, io_ticks)),
146 jiffies_to_msecs(part_stat_read(p, time_in_queue)), 146 jiffies_to_msecs(part_stat_read(p, time_in_queue)),
147 part_stat_read(p, ios[STAT_DISCARD]), 147 part_stat_read(p, ios[STAT_DISCARD]),
148 part_stat_read(p, merges[STAT_DISCARD]), 148 part_stat_read(p, merges[STAT_DISCARD]),
149 (unsigned long long)part_stat_read(p, sectors[STAT_DISCARD]), 149 (unsigned long long)part_stat_read(p, sectors[STAT_DISCARD]),
150 jiffies_to_msecs(part_stat_read(p, ticks[STAT_DISCARD]))); 150 (unsigned int)part_stat_read_msecs(p, STAT_DISCARD));
151} 151}
152 152
153ssize_t part_inflight_show(struct device *dev, struct device_attribute *attr, 153ssize_t part_inflight_show(struct device *dev, struct device_attribute *attr,
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index dd1eea90f67f..9705fc986da9 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -138,7 +138,6 @@ config ACPI_REV_OVERRIDE_POSSIBLE
138 138
139config ACPI_EC_DEBUGFS 139config ACPI_EC_DEBUGFS
140 tristate "EC read/write access through /sys/kernel/debug/ec" 140 tristate "EC read/write access through /sys/kernel/debug/ec"
141 default n
142 help 141 help
143 Say N to disable Embedded Controller /sys/kernel/debug interface 142 Say N to disable Embedded Controller /sys/kernel/debug interface
144 143
@@ -283,7 +282,6 @@ config ACPI_PROCESSOR
283config ACPI_IPMI 282config ACPI_IPMI
284 tristate "IPMI" 283 tristate "IPMI"
285 depends on IPMI_HANDLER 284 depends on IPMI_HANDLER
286 default n
287 help 285 help
288 This driver enables the ACPI to access the BMC controller. And it 286 This driver enables the ACPI to access the BMC controller. And it
289 uses the IPMI request/response message to communicate with BMC 287 uses the IPMI request/response message to communicate with BMC
@@ -361,7 +359,6 @@ config ACPI_TABLE_UPGRADE
361 359
362config ACPI_DEBUG 360config ACPI_DEBUG
363 bool "Debug Statements" 361 bool "Debug Statements"
364 default n
365 help 362 help
366 The ACPI subsystem can produce debug output. Saying Y enables this 363 The ACPI subsystem can produce debug output. Saying Y enables this
367 output and increases the kernel size by around 50K. 364 output and increases the kernel size by around 50K.
@@ -374,7 +371,6 @@ config ACPI_DEBUG
374config ACPI_PCI_SLOT 371config ACPI_PCI_SLOT
375 bool "PCI slot detection driver" 372 bool "PCI slot detection driver"
376 depends on SYSFS 373 depends on SYSFS
377 default n
378 help 374 help
379 This driver creates entries in /sys/bus/pci/slots/ for all PCI 375 This driver creates entries in /sys/bus/pci/slots/ for all PCI
380 slots in the system. This can help correlate PCI bus addresses, 376 slots in the system. This can help correlate PCI bus addresses,
@@ -436,7 +432,6 @@ config ACPI_HED
436config ACPI_CUSTOM_METHOD 432config ACPI_CUSTOM_METHOD
437 tristate "Allow ACPI methods to be inserted/replaced at run time" 433 tristate "Allow ACPI methods to be inserted/replaced at run time"
438 depends on DEBUG_FS 434 depends on DEBUG_FS
439 default n
440 help 435 help
441 This debug facility allows ACPI AML methods to be inserted and/or 436 This debug facility allows ACPI AML methods to be inserted and/or
442 replaced without rebooting the system. For details refer to: 437 replaced without rebooting the system. For details refer to:
@@ -481,7 +476,6 @@ config ACPI_EXTLOG
481 tristate "Extended Error Log support" 476 tristate "Extended Error Log support"
482 depends on X86_MCE && X86_LOCAL_APIC && EDAC 477 depends on X86_MCE && X86_LOCAL_APIC && EDAC
483 select UEFI_CPER 478 select UEFI_CPER
484 default n
485 help 479 help
486 Certain usages such as Predictive Failure Analysis (PFA) require 480 Certain usages such as Predictive Failure Analysis (PFA) require
487 more information about the error than what can be described in 481 more information about the error than what can be described in
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index bf64cfa30feb..10adb8cb3a3f 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -16,6 +16,7 @@
16#include <linux/err.h> 16#include <linux/err.h>
17#include <linux/io.h> 17#include <linux/io.h>
18#include <linux/mutex.h> 18#include <linux/mutex.h>
19#include <linux/pci.h>
19#include <linux/platform_device.h> 20#include <linux/platform_device.h>
20#include <linux/platform_data/clk-lpss.h> 21#include <linux/platform_data/clk-lpss.h>
21#include <linux/platform_data/x86/pmc_atom.h> 22#include <linux/platform_data/x86/pmc_atom.h>
@@ -83,6 +84,7 @@ struct lpss_device_desc {
83 size_t prv_size_override; 84 size_t prv_size_override;
84 struct property_entry *properties; 85 struct property_entry *properties;
85 void (*setup)(struct lpss_private_data *pdata); 86 void (*setup)(struct lpss_private_data *pdata);
87 bool resume_from_noirq;
86}; 88};
87 89
88static const struct lpss_device_desc lpss_dma_desc = { 90static const struct lpss_device_desc lpss_dma_desc = {
@@ -99,6 +101,9 @@ struct lpss_private_data {
99 u32 prv_reg_ctx[LPSS_PRV_REG_COUNT]; 101 u32 prv_reg_ctx[LPSS_PRV_REG_COUNT];
100}; 102};
101 103
104/* Devices which need to be in D3 before lpss_iosf_enter_d3_state() proceeds */
105static u32 pmc_atom_d3_mask = 0xfe000ffe;
106
102/* LPSS run time quirks */ 107/* LPSS run time quirks */
103static unsigned int lpss_quirks; 108static unsigned int lpss_quirks;
104 109
@@ -175,6 +180,21 @@ static void byt_pwm_setup(struct lpss_private_data *pdata)
175 180
176static void byt_i2c_setup(struct lpss_private_data *pdata) 181static void byt_i2c_setup(struct lpss_private_data *pdata)
177{ 182{
183 const char *uid_str = acpi_device_uid(pdata->adev);
184 acpi_handle handle = pdata->adev->handle;
185 unsigned long long shared_host = 0;
186 acpi_status status;
187 long uid = 0;
188
189 /* Expected to always be true, but better safe then sorry */
190 if (uid_str)
191 uid = simple_strtol(uid_str, NULL, 10);
192
193 /* Detect I2C bus shared with PUNIT and ignore its d3 status */
194 status = acpi_evaluate_integer(handle, "_SEM", NULL, &shared_host);
195 if (ACPI_SUCCESS(status) && shared_host && uid)
196 pmc_atom_d3_mask &= ~(BIT_LPSS2_F1_I2C1 << (uid - 1));
197
178 lpss_deassert_reset(pdata); 198 lpss_deassert_reset(pdata);
179 199
180 if (readl(pdata->mmio_base + pdata->dev_desc->prv_offset)) 200 if (readl(pdata->mmio_base + pdata->dev_desc->prv_offset))
@@ -274,12 +294,14 @@ static const struct lpss_device_desc byt_i2c_dev_desc = {
274 .flags = LPSS_CLK | LPSS_SAVE_CTX, 294 .flags = LPSS_CLK | LPSS_SAVE_CTX,
275 .prv_offset = 0x800, 295 .prv_offset = 0x800,
276 .setup = byt_i2c_setup, 296 .setup = byt_i2c_setup,
297 .resume_from_noirq = true,
277}; 298};
278 299
279static const struct lpss_device_desc bsw_i2c_dev_desc = { 300static const struct lpss_device_desc bsw_i2c_dev_desc = {
280 .flags = LPSS_CLK | LPSS_SAVE_CTX | LPSS_NO_D3_DELAY, 301 .flags = LPSS_CLK | LPSS_SAVE_CTX | LPSS_NO_D3_DELAY,
281 .prv_offset = 0x800, 302 .prv_offset = 0x800,
282 .setup = byt_i2c_setup, 303 .setup = byt_i2c_setup,
304 .resume_from_noirq = true,
283}; 305};
284 306
285static const struct lpss_device_desc bsw_spi_dev_desc = { 307static const struct lpss_device_desc bsw_spi_dev_desc = {
@@ -327,9 +349,11 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
327 { "INT33FC", }, 349 { "INT33FC", },
328 350
329 /* Braswell LPSS devices */ 351 /* Braswell LPSS devices */
352 { "80862286", LPSS_ADDR(lpss_dma_desc) },
330 { "80862288", LPSS_ADDR(bsw_pwm_dev_desc) }, 353 { "80862288", LPSS_ADDR(bsw_pwm_dev_desc) },
331 { "8086228A", LPSS_ADDR(bsw_uart_dev_desc) }, 354 { "8086228A", LPSS_ADDR(bsw_uart_dev_desc) },
332 { "8086228E", LPSS_ADDR(bsw_spi_dev_desc) }, 355 { "8086228E", LPSS_ADDR(bsw_spi_dev_desc) },
356 { "808622C0", LPSS_ADDR(lpss_dma_desc) },
333 { "808622C1", LPSS_ADDR(bsw_i2c_dev_desc) }, 357 { "808622C1", LPSS_ADDR(bsw_i2c_dev_desc) },
334 358
335 /* Broadwell LPSS devices */ 359 /* Broadwell LPSS devices */
@@ -451,26 +475,35 @@ struct lpss_device_links {
451 */ 475 */
452static const struct lpss_device_links lpss_device_links[] = { 476static const struct lpss_device_links lpss_device_links[] = {
453 {"808622C1", "7", "80860F14", "3", DL_FLAG_PM_RUNTIME}, 477 {"808622C1", "7", "80860F14", "3", DL_FLAG_PM_RUNTIME},
478 {"808622C1", "7", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME},
479 {"80860F41", "5", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME},
454}; 480};
455 481
456static bool hid_uid_match(const char *hid1, const char *uid1, 482static bool hid_uid_match(struct acpi_device *adev,
457 const char *hid2, const char *uid2) 483 const char *hid2, const char *uid2)
458{ 484{
459 return !strcmp(hid1, hid2) && uid1 && uid2 && !strcmp(uid1, uid2); 485 const char *hid1 = acpi_device_hid(adev);
486 const char *uid1 = acpi_device_uid(adev);
487
488 if (strcmp(hid1, hid2))
489 return false;
490
491 if (!uid2)
492 return true;
493
494 return uid1 && !strcmp(uid1, uid2);
460} 495}
461 496
462static bool acpi_lpss_is_supplier(struct acpi_device *adev, 497static bool acpi_lpss_is_supplier(struct acpi_device *adev,
463 const struct lpss_device_links *link) 498 const struct lpss_device_links *link)
464{ 499{
465 return hid_uid_match(acpi_device_hid(adev), acpi_device_uid(adev), 500 return hid_uid_match(adev, link->supplier_hid, link->supplier_uid);
466 link->supplier_hid, link->supplier_uid);
467} 501}
468 502
469static bool acpi_lpss_is_consumer(struct acpi_device *adev, 503static bool acpi_lpss_is_consumer(struct acpi_device *adev,
470 const struct lpss_device_links *link) 504 const struct lpss_device_links *link)
471{ 505{
472 return hid_uid_match(acpi_device_hid(adev), acpi_device_uid(adev), 506 return hid_uid_match(adev, link->consumer_hid, link->consumer_uid);
473 link->consumer_hid, link->consumer_uid);
474} 507}
475 508
476struct hid_uid { 509struct hid_uid {
@@ -486,18 +519,23 @@ static int match_hid_uid(struct device *dev, void *data)
486 if (!adev) 519 if (!adev)
487 return 0; 520 return 0;
488 521
489 return hid_uid_match(acpi_device_hid(adev), acpi_device_uid(adev), 522 return hid_uid_match(adev, id->hid, id->uid);
490 id->hid, id->uid);
491} 523}
492 524
493static struct device *acpi_lpss_find_device(const char *hid, const char *uid) 525static struct device *acpi_lpss_find_device(const char *hid, const char *uid)
494{ 526{
527 struct device *dev;
528
495 struct hid_uid data = { 529 struct hid_uid data = {
496 .hid = hid, 530 .hid = hid,
497 .uid = uid, 531 .uid = uid,
498 }; 532 };
499 533
500 return bus_find_device(&platform_bus_type, NULL, &data, match_hid_uid); 534 dev = bus_find_device(&platform_bus_type, NULL, &data, match_hid_uid);
535 if (dev)
536 return dev;
537
538 return bus_find_device(&pci_bus_type, NULL, &data, match_hid_uid);
501} 539}
502 540
503static bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle) 541static bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle)
@@ -892,7 +930,7 @@ static void lpss_iosf_enter_d3_state(void)
892 * Here we read the values related to LPSS power island, i.e. LPSS 930 * Here we read the values related to LPSS power island, i.e. LPSS
893 * devices, excluding both LPSS DMA controllers, along with SCC domain. 931 * devices, excluding both LPSS DMA controllers, along with SCC domain.
894 */ 932 */
895 u32 func_dis, d3_sts_0, pmc_status, pmc_mask = 0xfe000ffe; 933 u32 func_dis, d3_sts_0, pmc_status;
896 int ret; 934 int ret;
897 935
898 ret = pmc_atom_read(PMC_FUNC_DIS, &func_dis); 936 ret = pmc_atom_read(PMC_FUNC_DIS, &func_dis);
@@ -910,7 +948,7 @@ static void lpss_iosf_enter_d3_state(void)
910 * Shutdown both LPSS DMA controllers if and only if all other devices 948 * Shutdown both LPSS DMA controllers if and only if all other devices
911 * are already in D3hot. 949 * are already in D3hot.
912 */ 950 */
913 pmc_status = (~(d3_sts_0 | func_dis)) & pmc_mask; 951 pmc_status = (~(d3_sts_0 | func_dis)) & pmc_atom_d3_mask;
914 if (pmc_status) 952 if (pmc_status)
915 goto exit; 953 goto exit;
916 954
@@ -1004,7 +1042,7 @@ static int acpi_lpss_resume(struct device *dev)
1004} 1042}
1005 1043
1006#ifdef CONFIG_PM_SLEEP 1044#ifdef CONFIG_PM_SLEEP
1007static int acpi_lpss_suspend_late(struct device *dev) 1045static int acpi_lpss_do_suspend_late(struct device *dev)
1008{ 1046{
1009 int ret; 1047 int ret;
1010 1048
@@ -1015,12 +1053,62 @@ static int acpi_lpss_suspend_late(struct device *dev)
1015 return ret ? ret : acpi_lpss_suspend(dev, device_may_wakeup(dev)); 1053 return ret ? ret : acpi_lpss_suspend(dev, device_may_wakeup(dev));
1016} 1054}
1017 1055
1018static int acpi_lpss_resume_early(struct device *dev) 1056static int acpi_lpss_suspend_late(struct device *dev)
1057{
1058 struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
1059
1060 if (pdata->dev_desc->resume_from_noirq)
1061 return 0;
1062
1063 return acpi_lpss_do_suspend_late(dev);
1064}
1065
1066static int acpi_lpss_suspend_noirq(struct device *dev)
1067{
1068 struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
1069 int ret;
1070
1071 if (pdata->dev_desc->resume_from_noirq) {
1072 ret = acpi_lpss_do_suspend_late(dev);
1073 if (ret)
1074 return ret;
1075 }
1076
1077 return acpi_subsys_suspend_noirq(dev);
1078}
1079
1080static int acpi_lpss_do_resume_early(struct device *dev)
1019{ 1081{
1020 int ret = acpi_lpss_resume(dev); 1082 int ret = acpi_lpss_resume(dev);
1021 1083
1022 return ret ? ret : pm_generic_resume_early(dev); 1084 return ret ? ret : pm_generic_resume_early(dev);
1023} 1085}
1086
1087static int acpi_lpss_resume_early(struct device *dev)
1088{
1089 struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
1090
1091 if (pdata->dev_desc->resume_from_noirq)
1092 return 0;
1093
1094 return acpi_lpss_do_resume_early(dev);
1095}
1096
1097static int acpi_lpss_resume_noirq(struct device *dev)
1098{
1099 struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
1100 int ret;
1101
1102 ret = acpi_subsys_resume_noirq(dev);
1103 if (ret)
1104 return ret;
1105
1106 if (!dev_pm_may_skip_resume(dev) && pdata->dev_desc->resume_from_noirq)
1107 ret = acpi_lpss_do_resume_early(dev);
1108
1109 return ret;
1110}
1111
1024#endif /* CONFIG_PM_SLEEP */ 1112#endif /* CONFIG_PM_SLEEP */
1025 1113
1026static int acpi_lpss_runtime_suspend(struct device *dev) 1114static int acpi_lpss_runtime_suspend(struct device *dev)
@@ -1050,8 +1138,8 @@ static struct dev_pm_domain acpi_lpss_pm_domain = {
1050 .complete = acpi_subsys_complete, 1138 .complete = acpi_subsys_complete,
1051 .suspend = acpi_subsys_suspend, 1139 .suspend = acpi_subsys_suspend,
1052 .suspend_late = acpi_lpss_suspend_late, 1140 .suspend_late = acpi_lpss_suspend_late,
1053 .suspend_noirq = acpi_subsys_suspend_noirq, 1141 .suspend_noirq = acpi_lpss_suspend_noirq,
1054 .resume_noirq = acpi_subsys_resume_noirq, 1142 .resume_noirq = acpi_lpss_resume_noirq,
1055 .resume_early = acpi_lpss_resume_early, 1143 .resume_early = acpi_lpss_resume_early,
1056 .freeze = acpi_subsys_freeze, 1144 .freeze = acpi_subsys_freeze,
1057 .freeze_late = acpi_subsys_freeze_late, 1145 .freeze_late = acpi_subsys_freeze_late,
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index 449d86d39965..fc447410ae4d 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -643,7 +643,7 @@ static acpi_status __init acpi_processor_ids_walk(acpi_handle handle,
643 643
644 status = acpi_get_type(handle, &acpi_type); 644 status = acpi_get_type(handle, &acpi_type);
645 if (ACPI_FAILURE(status)) 645 if (ACPI_FAILURE(status))
646 return false; 646 return status;
647 647
648 switch (acpi_type) { 648 switch (acpi_type) {
649 case ACPI_TYPE_PROCESSOR: 649 case ACPI_TYPE_PROCESSOR:
@@ -663,11 +663,12 @@ static acpi_status __init acpi_processor_ids_walk(acpi_handle handle,
663 } 663 }
664 664
665 processor_validated_ids_update(uid); 665 processor_validated_ids_update(uid);
666 return true; 666 return AE_OK;
667 667
668err: 668err:
669 /* Exit on error, but don't abort the namespace walk */
669 acpi_handle_info(handle, "Invalid processor object\n"); 670 acpi_handle_info(handle, "Invalid processor object\n");
670 return false; 671 return AE_OK;
671 672
672} 673}
673 674
diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c
index e99c4ed7e677..33a4bcdaa4d7 100644
--- a/drivers/acpi/acpi_tad.c
+++ b/drivers/acpi/acpi_tad.c
@@ -52,6 +52,201 @@ struct acpi_tad_driver_data {
52 u32 capabilities; 52 u32 capabilities;
53}; 53};
54 54
55struct acpi_tad_rt {
56 u16 year; /* 1900 - 9999 */
57 u8 month; /* 1 - 12 */
58 u8 day; /* 1 - 31 */
59 u8 hour; /* 0 - 23 */
60 u8 minute; /* 0 - 59 */
61 u8 second; /* 0 - 59 */
62 u8 valid; /* 0 (failed) or 1 (success) for reads, 0 for writes */
63 u16 msec; /* 1 - 1000 */
64 s16 tz; /* -1440 to 1440 or 2047 (unspecified) */
65 u8 daylight;
66 u8 padding[3]; /* must be 0 */
67} __packed;
68
69static int acpi_tad_set_real_time(struct device *dev, struct acpi_tad_rt *rt)
70{
71 acpi_handle handle = ACPI_HANDLE(dev);
72 union acpi_object args[] = {
73 { .type = ACPI_TYPE_BUFFER, },
74 };
75 struct acpi_object_list arg_list = {
76 .pointer = args,
77 .count = ARRAY_SIZE(args),
78 };
79 unsigned long long retval;
80 acpi_status status;
81
82 if (rt->year < 1900 || rt->year > 9999 ||
83 rt->month < 1 || rt->month > 12 ||
84 rt->hour > 23 || rt->minute > 59 || rt->second > 59 ||
85 rt->tz < -1440 || (rt->tz > 1440 && rt->tz != 2047) ||
86 rt->daylight > 3)
87 return -ERANGE;
88
89 args[0].buffer.pointer = (u8 *)rt;
90 args[0].buffer.length = sizeof(*rt);
91
92 pm_runtime_get_sync(dev);
93
94 status = acpi_evaluate_integer(handle, "_SRT", &arg_list, &retval);
95
96 pm_runtime_put_sync(dev);
97
98 if (ACPI_FAILURE(status) || retval)
99 return -EIO;
100
101 return 0;
102}
103
104static int acpi_tad_get_real_time(struct device *dev, struct acpi_tad_rt *rt)
105{
106 acpi_handle handle = ACPI_HANDLE(dev);
107 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER };
108 union acpi_object *out_obj;
109 struct acpi_tad_rt *data;
110 acpi_status status;
111 int ret = -EIO;
112
113 pm_runtime_get_sync(dev);
114
115 status = acpi_evaluate_object(handle, "_GRT", NULL, &output);
116
117 pm_runtime_put_sync(dev);
118
119 if (ACPI_FAILURE(status))
120 goto out_free;
121
122 out_obj = output.pointer;
123 if (out_obj->type != ACPI_TYPE_BUFFER)
124 goto out_free;
125
126 if (out_obj->buffer.length != sizeof(*rt))
127 goto out_free;
128
129 data = (struct acpi_tad_rt *)(out_obj->buffer.pointer);
130 if (!data->valid)
131 goto out_free;
132
133 memcpy(rt, data, sizeof(*rt));
134 ret = 0;
135
136out_free:
137 ACPI_FREE(output.pointer);
138 return ret;
139}
140
141static char *acpi_tad_rt_next_field(char *s, int *val)
142{
143 char *p;
144
145 p = strchr(s, ':');
146 if (!p)
147 return NULL;
148
149 *p = '\0';
150 if (kstrtoint(s, 10, val))
151 return NULL;
152
153 return p + 1;
154}
155
156static ssize_t time_store(struct device *dev, struct device_attribute *attr,
157 const char *buf, size_t count)
158{
159 struct acpi_tad_rt rt;
160 char *str, *s;
161 int val, ret = -ENODATA;
162
163 str = kmemdup_nul(buf, count, GFP_KERNEL);
164 if (!str)
165 return -ENOMEM;
166
167 s = acpi_tad_rt_next_field(str, &val);
168 if (!s)
169 goto out_free;
170
171 rt.year = val;
172
173 s = acpi_tad_rt_next_field(s, &val);
174 if (!s)
175 goto out_free;
176
177 rt.month = val;
178
179 s = acpi_tad_rt_next_field(s, &val);
180 if (!s)
181 goto out_free;
182
183 rt.day = val;
184
185 s = acpi_tad_rt_next_field(s, &val);
186 if (!s)
187 goto out_free;
188
189 rt.hour = val;
190
191 s = acpi_tad_rt_next_field(s, &val);
192 if (!s)
193 goto out_free;
194
195 rt.minute = val;
196
197 s = acpi_tad_rt_next_field(s, &val);
198 if (!s)
199 goto out_free;
200
201 rt.second = val;
202
203 s = acpi_tad_rt_next_field(s, &val);
204 if (!s)
205 goto out_free;
206
207 rt.tz = val;
208
209 if (kstrtoint(s, 10, &val))
210 goto out_free;
211
212 rt.daylight = val;
213
214 rt.valid = 0;
215 rt.msec = 0;
216 memset(rt.padding, 0, 3);
217
218 ret = acpi_tad_set_real_time(dev, &rt);
219
220out_free:
221 kfree(str);
222 return ret ? ret : count;
223}
224
225static ssize_t time_show(struct device *dev, struct device_attribute *attr,
226 char *buf)
227{
228 struct acpi_tad_rt rt;
229 int ret;
230
231 ret = acpi_tad_get_real_time(dev, &rt);
232 if (ret)
233 return ret;
234
235 return sprintf(buf, "%u:%u:%u:%u:%u:%u:%d:%u\n",
236 rt.year, rt.month, rt.day, rt.hour, rt.minute, rt.second,
237 rt.tz, rt.daylight);
238}
239
240static DEVICE_ATTR(time, S_IRUSR | S_IWUSR, time_show, time_store);
241
242static struct attribute *acpi_tad_time_attrs[] = {
243 &dev_attr_time.attr,
244 NULL,
245};
246static const struct attribute_group acpi_tad_time_attr_group = {
247 .attrs = acpi_tad_time_attrs,
248};
249
55static int acpi_tad_wake_set(struct device *dev, char *method, u32 timer_id, 250static int acpi_tad_wake_set(struct device *dev, char *method, u32 timer_id,
56 u32 value) 251 u32 value)
57{ 252{
@@ -448,6 +643,12 @@ static int acpi_tad_probe(struct platform_device *pdev)
448 goto fail; 643 goto fail;
449 } 644 }
450 645
646 if (caps & ACPI_TAD_RT) {
647 ret = sysfs_create_group(&dev->kobj, &acpi_tad_time_attr_group);
648 if (ret)
649 goto fail;
650 }
651
451 return 0; 652 return 0;
452 653
453fail: 654fail:
diff --git a/drivers/acpi/acpica/Makefile b/drivers/acpi/acpica/Makefile
index 71f6f2624deb..b14621da5413 100644
--- a/drivers/acpi/acpica/Makefile
+++ b/drivers/acpi/acpica/Makefile
@@ -65,6 +65,7 @@ acpi-y += \
65 exresnte.o \ 65 exresnte.o \
66 exresolv.o \ 66 exresolv.o \
67 exresop.o \ 67 exresop.o \
68 exserial.o \
68 exstore.o \ 69 exstore.o \
69 exstoren.o \ 70 exstoren.o \
70 exstorob.o \ 71 exstorob.o \
diff --git a/drivers/acpi/acpica/acevents.h b/drivers/acpi/acpica/acevents.h
index 704bebbd35b0..b412aa909907 100644
--- a/drivers/acpi/acpica/acevents.h
+++ b/drivers/acpi/acpica/acevents.h
@@ -229,6 +229,8 @@ acpi_ev_default_region_setup(acpi_handle handle,
229 229
230acpi_status acpi_ev_initialize_region(union acpi_operand_object *region_obj); 230acpi_status acpi_ev_initialize_region(union acpi_operand_object *region_obj);
231 231
232u8 acpi_ev_is_pci_root_bridge(struct acpi_namespace_node *node);
233
232/* 234/*
233 * evsci - SCI (System Control Interrupt) handling/dispatch 235 * evsci - SCI (System Control Interrupt) handling/dispatch
234 */ 236 */
diff --git a/drivers/acpi/acpica/acinterp.h b/drivers/acpi/acpica/acinterp.h
index 9613b0115dad..c5b2be0b6613 100644
--- a/drivers/acpi/acpica/acinterp.h
+++ b/drivers/acpi/acpica/acinterp.h
@@ -124,6 +124,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
124 * exfield - ACPI AML (p-code) execution - field manipulation 124 * exfield - ACPI AML (p-code) execution - field manipulation
125 */ 125 */
126acpi_status 126acpi_status
127acpi_ex_get_protocol_buffer_length(u32 protocol_id, u32 *return_length);
128
129acpi_status
127acpi_ex_common_buffer_setup(union acpi_operand_object *obj_desc, 130acpi_ex_common_buffer_setup(union acpi_operand_object *obj_desc,
128 u32 buffer_length, u32 * datum_count); 131 u32 buffer_length, u32 * datum_count);
129 132
@@ -268,6 +271,26 @@ acpi_ex_prep_common_field_object(union acpi_operand_object *obj_desc,
268acpi_status acpi_ex_prep_field_value(struct acpi_create_field_info *info); 271acpi_status acpi_ex_prep_field_value(struct acpi_create_field_info *info);
269 272
270/* 273/*
274 * exserial - field_unit support for serial address spaces
275 */
276acpi_status
277acpi_ex_read_serial_bus(union acpi_operand_object *obj_desc,
278 union acpi_operand_object **return_buffer);
279
280acpi_status
281acpi_ex_write_serial_bus(union acpi_operand_object *source_desc,
282 union acpi_operand_object *obj_desc,
283 union acpi_operand_object **return_buffer);
284
285acpi_status
286acpi_ex_read_gpio(union acpi_operand_object *obj_desc, void *buffer);
287
288acpi_status
289acpi_ex_write_gpio(union acpi_operand_object *source_desc,
290 union acpi_operand_object *obj_desc,
291 union acpi_operand_object **return_buffer);
292
293/*
271 * exsystem - Interface to OS services 294 * exsystem - Interface to OS services
272 */ 295 */
273acpi_status 296acpi_status
diff --git a/drivers/acpi/acpica/aclocal.h b/drivers/acpi/acpica/aclocal.h
index 0f28a38a43ea..99b0da899109 100644
--- a/drivers/acpi/acpica/aclocal.h
+++ b/drivers/acpi/acpica/aclocal.h
@@ -395,9 +395,9 @@ struct acpi_simple_repair_info {
395/* Info for running the _REG methods */ 395/* Info for running the _REG methods */
396 396
397struct acpi_reg_walk_info { 397struct acpi_reg_walk_info {
398 acpi_adr_space_type space_id;
399 u32 function; 398 u32 function;
400 u32 reg_run_count; 399 u32 reg_run_count;
400 acpi_adr_space_type space_id;
401}; 401};
402 402
403/***************************************************************************** 403/*****************************************************************************
diff --git a/drivers/acpi/acpica/amlcode.h b/drivers/acpi/acpica/amlcode.h
index 250dba02bab6..6c05355447c1 100644
--- a/drivers/acpi/acpica/amlcode.h
+++ b/drivers/acpi/acpica/amlcode.h
@@ -432,15 +432,15 @@ typedef enum {
432 */ 432 */
433typedef enum { 433typedef enum {
434 AML_FIELD_ATTRIB_QUICK = 0x02, 434 AML_FIELD_ATTRIB_QUICK = 0x02,
435 AML_FIELD_ATTRIB_SEND_RCV = 0x04, 435 AML_FIELD_ATTRIB_SEND_RECEIVE = 0x04,
436 AML_FIELD_ATTRIB_BYTE = 0x06, 436 AML_FIELD_ATTRIB_BYTE = 0x06,
437 AML_FIELD_ATTRIB_WORD = 0x08, 437 AML_FIELD_ATTRIB_WORD = 0x08,
438 AML_FIELD_ATTRIB_BLOCK = 0x0A, 438 AML_FIELD_ATTRIB_BLOCK = 0x0A,
439 AML_FIELD_ATTRIB_MULTIBYTE = 0x0B, 439 AML_FIELD_ATTRIB_BYTES = 0x0B,
440 AML_FIELD_ATTRIB_WORD_CALL = 0x0C, 440 AML_FIELD_ATTRIB_PROCESS_CALL = 0x0C,
441 AML_FIELD_ATTRIB_BLOCK_CALL = 0x0D, 441 AML_FIELD_ATTRIB_BLOCK_PROCESS_CALL = 0x0D,
442 AML_FIELD_ATTRIB_RAW_BYTES = 0x0E, 442 AML_FIELD_ATTRIB_RAW_BYTES = 0x0E,
443 AML_FIELD_ATTRIB_RAW_PROCESS = 0x0F 443 AML_FIELD_ATTRIB_RAW_PROCESS_BYTES = 0x0F
444} AML_ACCESS_ATTRIBUTE; 444} AML_ACCESS_ATTRIBUTE;
445 445
446/* Bit fields in the AML method_flags byte */ 446/* Bit fields in the AML method_flags byte */
diff --git a/drivers/acpi/acpica/dsopcode.c b/drivers/acpi/acpica/dsopcode.c
index e9fb0bf3c8d2..78f9de260d5f 100644
--- a/drivers/acpi/acpica/dsopcode.c
+++ b/drivers/acpi/acpica/dsopcode.c
@@ -417,6 +417,10 @@ acpi_ds_eval_region_operands(struct acpi_walk_state *walk_state,
417 ACPI_FORMAT_UINT64(obj_desc->region.address), 417 ACPI_FORMAT_UINT64(obj_desc->region.address),
418 obj_desc->region.length)); 418 obj_desc->region.length));
419 419
420 status = acpi_ut_add_address_range(obj_desc->region.space_id,
421 obj_desc->region.address,
422 obj_desc->region.length, node);
423
420 /* Now the address and length are valid for this opregion */ 424 /* Now the address and length are valid for this opregion */
421 425
422 obj_desc->region.flags |= AOPOBJ_DATA_VALID; 426 obj_desc->region.flags |= AOPOBJ_DATA_VALID;
diff --git a/drivers/acpi/acpica/evregion.c b/drivers/acpi/acpica/evregion.c
index 70c2bd169f66..49decca4e08f 100644
--- a/drivers/acpi/acpica/evregion.c
+++ b/drivers/acpi/acpica/evregion.c
@@ -653,6 +653,19 @@ acpi_ev_execute_reg_methods(struct acpi_namespace_node *node,
653 653
654 ACPI_FUNCTION_TRACE(ev_execute_reg_methods); 654 ACPI_FUNCTION_TRACE(ev_execute_reg_methods);
655 655
656 /*
657 * These address spaces do not need a call to _REG, since the ACPI
658 * specification defines them as: "must always be accessible". Since
659 * they never change state (never become unavailable), no need to ever
660 * call _REG on them. Also, a data_table is not a "real" address space,
661 * so do not call _REG. September 2018.
662 */
663 if ((space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) ||
664 (space_id == ACPI_ADR_SPACE_SYSTEM_IO) ||
665 (space_id == ACPI_ADR_SPACE_DATA_TABLE)) {
666 return_VOID;
667 }
668
656 info.space_id = space_id; 669 info.space_id = space_id;
657 info.function = function; 670 info.function = function;
658 info.reg_run_count = 0; 671 info.reg_run_count = 0;
@@ -714,8 +727,8 @@ acpi_ev_reg_run(acpi_handle obj_handle,
714 } 727 }
715 728
716 /* 729 /*
717 * We only care about regions.and objects that are allowed to have address 730 * We only care about regions and objects that are allowed to have
718 * space handlers 731 * address space handlers
719 */ 732 */
720 if ((node->type != ACPI_TYPE_REGION) && (node != acpi_gbl_root_node)) { 733 if ((node->type != ACPI_TYPE_REGION) && (node != acpi_gbl_root_node)) {
721 return (AE_OK); 734 return (AE_OK);
diff --git a/drivers/acpi/acpica/evrgnini.c b/drivers/acpi/acpica/evrgnini.c
index 39284deedd88..17df5dacd43c 100644
--- a/drivers/acpi/acpica/evrgnini.c
+++ b/drivers/acpi/acpica/evrgnini.c
@@ -16,9 +16,6 @@
16#define _COMPONENT ACPI_EVENTS 16#define _COMPONENT ACPI_EVENTS
17ACPI_MODULE_NAME("evrgnini") 17ACPI_MODULE_NAME("evrgnini")
18 18
19/* Local prototypes */
20static u8 acpi_ev_is_pci_root_bridge(struct acpi_namespace_node *node);
21
22/******************************************************************************* 19/*******************************************************************************
23 * 20 *
24 * FUNCTION: acpi_ev_system_memory_region_setup 21 * FUNCTION: acpi_ev_system_memory_region_setup
@@ -33,7 +30,6 @@ static u8 acpi_ev_is_pci_root_bridge(struct acpi_namespace_node *node);
33 * DESCRIPTION: Setup a system_memory operation region 30 * DESCRIPTION: Setup a system_memory operation region
34 * 31 *
35 ******************************************************************************/ 32 ******************************************************************************/
36
37acpi_status 33acpi_status
38acpi_ev_system_memory_region_setup(acpi_handle handle, 34acpi_ev_system_memory_region_setup(acpi_handle handle,
39 u32 function, 35 u32 function,
@@ -313,7 +309,7 @@ acpi_ev_pci_config_region_setup(acpi_handle handle,
313 * 309 *
314 ******************************************************************************/ 310 ******************************************************************************/
315 311
316static u8 acpi_ev_is_pci_root_bridge(struct acpi_namespace_node *node) 312u8 acpi_ev_is_pci_root_bridge(struct acpi_namespace_node *node)
317{ 313{
318 acpi_status status; 314 acpi_status status;
319 struct acpi_pnp_device_id *hid; 315 struct acpi_pnp_device_id *hid;
diff --git a/drivers/acpi/acpica/evxfregn.c b/drivers/acpi/acpica/evxfregn.c
index 091415b14fbf..3b3a25d9f0e6 100644
--- a/drivers/acpi/acpica/evxfregn.c
+++ b/drivers/acpi/acpica/evxfregn.c
@@ -193,7 +193,6 @@ acpi_remove_address_space_handler(acpi_handle device,
193 */ 193 */
194 region_obj = 194 region_obj =
195 handler_obj->address_space.region_list; 195 handler_obj->address_space.region_list;
196
197 } 196 }
198 197
199 /* Remove this Handler object from the list */ 198 /* Remove this Handler object from the list */
diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
index b272c329d45d..e5798f15793a 100644
--- a/drivers/acpi/acpica/exfield.c
+++ b/drivers/acpi/acpica/exfield.c
@@ -1,7 +1,7 @@
1// SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 1// SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0
2/****************************************************************************** 2/******************************************************************************
3 * 3 *
4 * Module Name: exfield - ACPI AML (p-code) execution - field manipulation 4 * Module Name: exfield - AML execution - field_unit read/write
5 * 5 *
6 * Copyright (C) 2000 - 2018, Intel Corp. 6 * Copyright (C) 2000 - 2018, Intel Corp.
7 * 7 *
@@ -16,64 +16,62 @@
16#define _COMPONENT ACPI_EXECUTER 16#define _COMPONENT ACPI_EXECUTER
17ACPI_MODULE_NAME("exfield") 17ACPI_MODULE_NAME("exfield")
18 18
19/* Local prototypes */ 19/*
20static u32 20 * This table maps the various Attrib protocols to the byte transfer
21acpi_ex_get_serial_access_length(u32 accessor_type, u32 access_length); 21 * length. Used for the generic serial bus.
22 */
23#define ACPI_INVALID_PROTOCOL_ID 0x80
24#define ACPI_MAX_PROTOCOL_ID 0x0F
25const u8 acpi_protocol_lengths[] = {
26 ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
27 ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
28 0x00, /* 2 - ATTRIB_QUICK */
29 ACPI_INVALID_PROTOCOL_ID, /* 3 - reserved */
30 0x01, /* 4 - ATTRIB_SEND_RECEIVE */
31 ACPI_INVALID_PROTOCOL_ID, /* 5 - reserved */
32 0x01, /* 6 - ATTRIB_BYTE */
33 ACPI_INVALID_PROTOCOL_ID, /* 7 - reserved */
34 0x02, /* 8 - ATTRIB_WORD */
35 ACPI_INVALID_PROTOCOL_ID, /* 9 - reserved */
36 0xFF, /* A - ATTRIB_BLOCK */
37 0xFF, /* B - ATTRIB_BYTES */
38 0x02, /* C - ATTRIB_PROCESS_CALL */
39 0xFF, /* D - ATTRIB_BLOCK_PROCESS_CALL */
40 0xFF, /* E - ATTRIB_RAW_BYTES */
41 0xFF /* F - ATTRIB_RAW_PROCESS_BYTES */
42};
22 43
23/******************************************************************************* 44/*******************************************************************************
24 * 45 *
25 * FUNCTION: acpi_ex_get_serial_access_length 46 * FUNCTION: acpi_ex_get_protocol_buffer_length
26 * 47 *
27 * PARAMETERS: accessor_type - The type of the protocol indicated by region 48 * PARAMETERS: protocol_id - The type of the protocol indicated by region
28 * field access attributes 49 * field access attributes
29 * access_length - The access length of the region field 50 * return_length - Where the protocol byte transfer length is
51 * returned
30 * 52 *
31 * RETURN: Decoded access length 53 * RETURN: Status and decoded byte transfer length
32 * 54 *
33 * DESCRIPTION: This routine returns the length of the generic_serial_bus 55 * DESCRIPTION: This routine returns the length of the generic_serial_bus
34 * protocol bytes 56 * protocol bytes
35 * 57 *
36 ******************************************************************************/ 58 ******************************************************************************/
37 59
38static u32 60acpi_status
39acpi_ex_get_serial_access_length(u32 accessor_type, u32 access_length) 61acpi_ex_get_protocol_buffer_length(u32 protocol_id, u32 *return_length)
40{ 62{
41 u32 length;
42
43 switch (accessor_type) {
44 case AML_FIELD_ATTRIB_QUICK:
45
46 length = 0;
47 break;
48
49 case AML_FIELD_ATTRIB_SEND_RCV:
50 case AML_FIELD_ATTRIB_BYTE:
51
52 length = 1;
53 break;
54
55 case AML_FIELD_ATTRIB_WORD:
56 case AML_FIELD_ATTRIB_WORD_CALL:
57
58 length = 2;
59 break;
60 63
61 case AML_FIELD_ATTRIB_MULTIBYTE: 64 if ((protocol_id > ACPI_MAX_PROTOCOL_ID) ||
62 case AML_FIELD_ATTRIB_RAW_BYTES: 65 (acpi_protocol_lengths[protocol_id] == ACPI_INVALID_PROTOCOL_ID)) {
63 case AML_FIELD_ATTRIB_RAW_PROCESS: 66 ACPI_ERROR((AE_INFO,
67 "Invalid Field/AccessAs protocol ID: 0x%4.4X",
68 protocol_id));
64 69
65 length = access_length; 70 return (AE_AML_PROTOCOL);
66 break;
67
68 case AML_FIELD_ATTRIB_BLOCK:
69 case AML_FIELD_ATTRIB_BLOCK_CALL:
70 default:
71
72 length = ACPI_GSBUS_BUFFER_SIZE - 2;
73 break;
74 } 71 }
75 72
76 return (length); 73 *return_length = acpi_protocol_lengths[protocol_id];
74 return (AE_OK);
77} 75}
78 76
79/******************************************************************************* 77/*******************************************************************************
@@ -98,10 +96,8 @@ acpi_ex_read_data_from_field(struct acpi_walk_state *walk_state,
98{ 96{
99 acpi_status status; 97 acpi_status status;
100 union acpi_operand_object *buffer_desc; 98 union acpi_operand_object *buffer_desc;
101 acpi_size length;
102 void *buffer; 99 void *buffer;
103 u32 function; 100 u32 buffer_length;
104 u16 accessor_type;
105 101
106 ACPI_FUNCTION_TRACE_PTR(ex_read_data_from_field, obj_desc); 102 ACPI_FUNCTION_TRACE_PTR(ex_read_data_from_field, obj_desc);
107 103
@@ -132,60 +128,11 @@ acpi_ex_read_data_from_field(struct acpi_walk_state *walk_state,
132 ACPI_ADR_SPACE_GSBUS 128 ACPI_ADR_SPACE_GSBUS
133 || obj_desc->field.region_obj->region.space_id == 129 || obj_desc->field.region_obj->region.space_id ==
134 ACPI_ADR_SPACE_IPMI)) { 130 ACPI_ADR_SPACE_IPMI)) {
135 /*
136 * This is an SMBus, GSBus or IPMI read. We must create a buffer to
137 * hold the data and then directly access the region handler.
138 *
139 * Note: SMBus and GSBus protocol value is passed in upper 16-bits
140 * of Function
141 */
142 if (obj_desc->field.region_obj->region.space_id ==
143 ACPI_ADR_SPACE_SMBUS) {
144 length = ACPI_SMBUS_BUFFER_SIZE;
145 function =
146 ACPI_READ | (obj_desc->field.attribute << 16);
147 } else if (obj_desc->field.region_obj->region.space_id ==
148 ACPI_ADR_SPACE_GSBUS) {
149 accessor_type = obj_desc->field.attribute;
150 length =
151 acpi_ex_get_serial_access_length(accessor_type,
152 obj_desc->field.
153 access_length);
154
155 /*
156 * Add additional 2 bytes for the generic_serial_bus data buffer:
157 *
158 * Status; (Byte 0 of the data buffer)
159 * Length; (Byte 1 of the data buffer)
160 * Data[x-1]: (Bytes 2-x of the arbitrary length data buffer)
161 */
162 length += 2;
163 function = ACPI_READ | (accessor_type << 16);
164 } else { /* IPMI */
165
166 length = ACPI_IPMI_BUFFER_SIZE;
167 function = ACPI_READ;
168 }
169
170 buffer_desc = acpi_ut_create_buffer_object(length);
171 if (!buffer_desc) {
172 return_ACPI_STATUS(AE_NO_MEMORY);
173 }
174
175 /* Lock entire transaction if requested */
176
177 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags);
178
179 /* Call the region handler for the read */
180 131
181 status = acpi_ex_access_region(obj_desc, 0, 132 /* SMBus, GSBus, IPMI serial */
182 ACPI_CAST_PTR(u64,
183 buffer_desc->
184 buffer.pointer),
185 function);
186 133
187 acpi_ex_release_global_lock(obj_desc->common_field.field_flags); 134 status = acpi_ex_read_serial_bus(obj_desc, ret_buffer_desc);
188 goto exit; 135 return_ACPI_STATUS(status);
189 } 136 }
190 137
191 /* 138 /*
@@ -198,14 +145,14 @@ acpi_ex_read_data_from_field(struct acpi_walk_state *walk_state,
198 * 145 *
199 * Note: Field.length is in bits. 146 * Note: Field.length is in bits.
200 */ 147 */
201 length = 148 buffer_length =
202 (acpi_size)ACPI_ROUND_BITS_UP_TO_BYTES(obj_desc->field.bit_length); 149 (acpi_size)ACPI_ROUND_BITS_UP_TO_BYTES(obj_desc->field.bit_length);
203 150
204 if (length > acpi_gbl_integer_byte_width) { 151 if (buffer_length > acpi_gbl_integer_byte_width) {
205 152
206 /* Field is too large for an Integer, create a Buffer instead */ 153 /* Field is too large for an Integer, create a Buffer instead */
207 154
208 buffer_desc = acpi_ut_create_buffer_object(length); 155 buffer_desc = acpi_ut_create_buffer_object(buffer_length);
209 if (!buffer_desc) { 156 if (!buffer_desc) {
210 return_ACPI_STATUS(AE_NO_MEMORY); 157 return_ACPI_STATUS(AE_NO_MEMORY);
211 } 158 }
@@ -218,47 +165,24 @@ acpi_ex_read_data_from_field(struct acpi_walk_state *walk_state,
218 return_ACPI_STATUS(AE_NO_MEMORY); 165 return_ACPI_STATUS(AE_NO_MEMORY);
219 } 166 }
220 167
221 length = acpi_gbl_integer_byte_width; 168 buffer_length = acpi_gbl_integer_byte_width;
222 buffer = &buffer_desc->integer.value; 169 buffer = &buffer_desc->integer.value;
223 } 170 }
224 171
225 if ((obj_desc->common.type == ACPI_TYPE_LOCAL_REGION_FIELD) && 172 if ((obj_desc->common.type == ACPI_TYPE_LOCAL_REGION_FIELD) &&
226 (obj_desc->field.region_obj->region.space_id == 173 (obj_desc->field.region_obj->region.space_id ==
227 ACPI_ADR_SPACE_GPIO)) { 174 ACPI_ADR_SPACE_GPIO)) {
228 /*
229 * For GPIO (general_purpose_io), the Address will be the bit offset
230 * from the previous Connection() operator, making it effectively a
231 * pin number index. The bit_length is the length of the field, which
232 * is thus the number of pins.
233 */
234 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
235 "GPIO FieldRead [FROM]: Pin %u Bits %u\n",
236 obj_desc->field.pin_number_index,
237 obj_desc->field.bit_length));
238
239 /* Lock entire transaction if requested */
240 175
241 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags); 176 /* General Purpose I/O */
242 177
243 /* Perform the write */ 178 status = acpi_ex_read_gpio(obj_desc, buffer);
244 179 goto exit;
245 status =
246 acpi_ex_access_region(obj_desc, 0, (u64 *)buffer,
247 ACPI_READ);
248
249 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
250 if (ACPI_FAILURE(status)) {
251 acpi_ut_remove_reference(buffer_desc);
252 } else {
253 *ret_buffer_desc = buffer_desc;
254 }
255 return_ACPI_STATUS(status);
256 } 180 }
257 181
258 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD, 182 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
259 "FieldRead [TO]: Obj %p, Type %X, Buf %p, ByteLen %X\n", 183 "FieldRead [TO]: Obj %p, Type %X, Buf %p, ByteLen %X\n",
260 obj_desc, obj_desc->common.type, buffer, 184 obj_desc, obj_desc->common.type, buffer,
261 (u32) length)); 185 buffer_length));
262 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD, 186 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
263 "FieldRead [FROM]: BitLen %X, BitOff %X, ByteOff %X\n", 187 "FieldRead [FROM]: BitLen %X, BitOff %X, ByteOff %X\n",
264 obj_desc->common_field.bit_length, 188 obj_desc->common_field.bit_length,
@@ -271,7 +195,7 @@ acpi_ex_read_data_from_field(struct acpi_walk_state *walk_state,
271 195
272 /* Read from the field */ 196 /* Read from the field */
273 197
274 status = acpi_ex_extract_from_field(obj_desc, buffer, (u32) length); 198 status = acpi_ex_extract_from_field(obj_desc, buffer, buffer_length);
275 acpi_ex_release_global_lock(obj_desc->common_field.field_flags); 199 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
276 200
277exit: 201exit:
@@ -304,11 +228,8 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
304 union acpi_operand_object **result_desc) 228 union acpi_operand_object **result_desc)
305{ 229{
306 acpi_status status; 230 acpi_status status;
307 u32 length; 231 u32 buffer_length;
308 void *buffer; 232 void *buffer;
309 union acpi_operand_object *buffer_desc;
310 u32 function;
311 u16 accessor_type;
312 233
313 ACPI_FUNCTION_TRACE_PTR(ex_write_data_to_field, obj_desc); 234 ACPI_FUNCTION_TRACE_PTR(ex_write_data_to_field, obj_desc);
314 235
@@ -331,130 +252,25 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
331 } 252 }
332 } else if ((obj_desc->common.type == ACPI_TYPE_LOCAL_REGION_FIELD) && 253 } else if ((obj_desc->common.type == ACPI_TYPE_LOCAL_REGION_FIELD) &&
333 (obj_desc->field.region_obj->region.space_id == 254 (obj_desc->field.region_obj->region.space_id ==
334 ACPI_ADR_SPACE_SMBUS 255 ACPI_ADR_SPACE_GPIO)) {
335 || obj_desc->field.region_obj->region.space_id ==
336 ACPI_ADR_SPACE_GSBUS
337 || obj_desc->field.region_obj->region.space_id ==
338 ACPI_ADR_SPACE_IPMI)) {
339 /*
340 * This is an SMBus, GSBus or IPMI write. We will bypass the entire
341 * field mechanism and handoff the buffer directly to the handler.
342 * For these address spaces, the buffer is bi-directional; on a
343 * write, return data is returned in the same buffer.
344 *
345 * Source must be a buffer of sufficient size:
346 * ACPI_SMBUS_BUFFER_SIZE, ACPI_GSBUS_BUFFER_SIZE, or
347 * ACPI_IPMI_BUFFER_SIZE.
348 *
349 * Note: SMBus and GSBus protocol type is passed in upper 16-bits
350 * of Function
351 */
352 if (source_desc->common.type != ACPI_TYPE_BUFFER) {
353 ACPI_ERROR((AE_INFO,
354 "SMBus/IPMI/GenericSerialBus write requires "
355 "Buffer, found type %s",
356 acpi_ut_get_object_type_name(source_desc)));
357
358 return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
359 }
360
361 if (obj_desc->field.region_obj->region.space_id ==
362 ACPI_ADR_SPACE_SMBUS) {
363 length = ACPI_SMBUS_BUFFER_SIZE;
364 function =
365 ACPI_WRITE | (obj_desc->field.attribute << 16);
366 } else if (obj_desc->field.region_obj->region.space_id ==
367 ACPI_ADR_SPACE_GSBUS) {
368 accessor_type = obj_desc->field.attribute;
369 length =
370 acpi_ex_get_serial_access_length(accessor_type,
371 obj_desc->field.
372 access_length);
373
374 /*
375 * Add additional 2 bytes for the generic_serial_bus data buffer:
376 *
377 * Status; (Byte 0 of the data buffer)
378 * Length; (Byte 1 of the data buffer)
379 * Data[x-1]: (Bytes 2-x of the arbitrary length data buffer)
380 */
381 length += 2;
382 function = ACPI_WRITE | (accessor_type << 16);
383 } else { /* IPMI */
384
385 length = ACPI_IPMI_BUFFER_SIZE;
386 function = ACPI_WRITE;
387 }
388
389 if (source_desc->buffer.length < length) {
390 ACPI_ERROR((AE_INFO,
391 "SMBus/IPMI/GenericSerialBus write requires "
392 "Buffer of length %u, found length %u",
393 length, source_desc->buffer.length));
394
395 return_ACPI_STATUS(AE_AML_BUFFER_LIMIT);
396 }
397
398 /* Create the bi-directional buffer */
399
400 buffer_desc = acpi_ut_create_buffer_object(length);
401 if (!buffer_desc) {
402 return_ACPI_STATUS(AE_NO_MEMORY);
403 }
404
405 buffer = buffer_desc->buffer.pointer;
406 memcpy(buffer, source_desc->buffer.pointer, length);
407
408 /* Lock entire transaction if requested */
409 256
410 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags); 257 /* General Purpose I/O */
411 258
412 /* 259 status = acpi_ex_write_gpio(source_desc, obj_desc, result_desc);
413 * Perform the write (returns status and perhaps data in the
414 * same buffer)
415 */
416 status =
417 acpi_ex_access_region(obj_desc, 0, (u64 *)buffer, function);
418 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
419
420 *result_desc = buffer_desc;
421 return_ACPI_STATUS(status); 260 return_ACPI_STATUS(status);
422 } else if ((obj_desc->common.type == ACPI_TYPE_LOCAL_REGION_FIELD) && 261 } else if ((obj_desc->common.type == ACPI_TYPE_LOCAL_REGION_FIELD) &&
423 (obj_desc->field.region_obj->region.space_id == 262 (obj_desc->field.region_obj->region.space_id ==
424 ACPI_ADR_SPACE_GPIO)) { 263 ACPI_ADR_SPACE_SMBUS
425 /* 264 || obj_desc->field.region_obj->region.space_id ==
426 * For GPIO (general_purpose_io), we will bypass the entire field 265 ACPI_ADR_SPACE_GSBUS
427 * mechanism and handoff the bit address and bit width directly to 266 || obj_desc->field.region_obj->region.space_id ==
428 * the handler. The Address will be the bit offset 267 ACPI_ADR_SPACE_IPMI)) {
429 * from the previous Connection() operator, making it effectively a
430 * pin number index. The bit_length is the length of the field, which
431 * is thus the number of pins.
432 */
433 if (source_desc->common.type != ACPI_TYPE_INTEGER) {
434 return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
435 }
436
437 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
438 "GPIO FieldWrite [FROM]: (%s:%X), Val %.8X [TO]: Pin %u Bits %u\n",
439 acpi_ut_get_type_name(source_desc->common.
440 type),
441 source_desc->common.type,
442 (u32)source_desc->integer.value,
443 obj_desc->field.pin_number_index,
444 obj_desc->field.bit_length));
445
446 buffer = &source_desc->integer.value;
447
448 /* Lock entire transaction if requested */
449
450 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags);
451 268
452 /* Perform the write */ 269 /* SMBus, GSBus, IPMI serial */
453 270
454 status = 271 status =
455 acpi_ex_access_region(obj_desc, 0, (u64 *)buffer, 272 acpi_ex_write_serial_bus(source_desc, obj_desc,
456 ACPI_WRITE); 273 result_desc);
457 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
458 return_ACPI_STATUS(status); 274 return_ACPI_STATUS(status);
459 } 275 }
460 276
@@ -464,23 +280,22 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
464 case ACPI_TYPE_INTEGER: 280 case ACPI_TYPE_INTEGER:
465 281
466 buffer = &source_desc->integer.value; 282 buffer = &source_desc->integer.value;
467 length = sizeof(source_desc->integer.value); 283 buffer_length = sizeof(source_desc->integer.value);
468 break; 284 break;
469 285
470 case ACPI_TYPE_BUFFER: 286 case ACPI_TYPE_BUFFER:
471 287
472 buffer = source_desc->buffer.pointer; 288 buffer = source_desc->buffer.pointer;
473 length = source_desc->buffer.length; 289 buffer_length = source_desc->buffer.length;
474 break; 290 break;
475 291
476 case ACPI_TYPE_STRING: 292 case ACPI_TYPE_STRING:
477 293
478 buffer = source_desc->string.pointer; 294 buffer = source_desc->string.pointer;
479 length = source_desc->string.length; 295 buffer_length = source_desc->string.length;
480 break; 296 break;
481 297
482 default: 298 default:
483
484 return_ACPI_STATUS(AE_AML_OPERAND_TYPE); 299 return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
485 } 300 }
486 301
@@ -488,7 +303,7 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
488 "FieldWrite [FROM]: Obj %p (%s:%X), Buf %p, ByteLen %X\n", 303 "FieldWrite [FROM]: Obj %p (%s:%X), Buf %p, ByteLen %X\n",
489 source_desc, 304 source_desc,
490 acpi_ut_get_type_name(source_desc->common.type), 305 acpi_ut_get_type_name(source_desc->common.type),
491 source_desc->common.type, buffer, length)); 306 source_desc->common.type, buffer, buffer_length));
492 307
493 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD, 308 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
494 "FieldWrite [TO]: Obj %p (%s:%X), BitLen %X, BitOff %X, ByteOff %X\n", 309 "FieldWrite [TO]: Obj %p (%s:%X), BitLen %X, BitOff %X, ByteOff %X\n",
@@ -505,8 +320,7 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
505 320
506 /* Write to the field */ 321 /* Write to the field */
507 322
508 status = acpi_ex_insert_into_field(obj_desc, buffer, length); 323 status = acpi_ex_insert_into_field(obj_desc, buffer, buffer_length);
509 acpi_ex_release_global_lock(obj_desc->common_field.field_flags); 324 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
510
511 return_ACPI_STATUS(status); 325 return_ACPI_STATUS(status);
512} 326}
diff --git a/drivers/acpi/acpica/exserial.c b/drivers/acpi/acpica/exserial.c
new file mode 100644
index 000000000000..0d42f30e5b25
--- /dev/null
+++ b/drivers/acpi/acpica/exserial.c
@@ -0,0 +1,360 @@
1// SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0
2/******************************************************************************
3 *
4 * Module Name: exserial - field_unit support for serial address spaces
5 *
6 * Copyright (C) 2000 - 2018, Intel Corp.
7 *
8 *****************************************************************************/
9
10#include <acpi/acpi.h>
11#include "accommon.h"
12#include "acdispat.h"
13#include "acinterp.h"
14#include "amlcode.h"
15
16#define _COMPONENT ACPI_EXECUTER
17ACPI_MODULE_NAME("exserial")
18
19/*******************************************************************************
20 *
21 * FUNCTION: acpi_ex_read_gpio
22 *
23 * PARAMETERS: obj_desc - The named field to read
24 * buffer - Where the return data is returnd
25 *
26 * RETURN: Status
27 *
28 * DESCRIPTION: Read from a named field that references a Generic Serial Bus
29 * field
30 *
31 ******************************************************************************/
32acpi_status acpi_ex_read_gpio(union acpi_operand_object *obj_desc, void *buffer)
33{
34 acpi_status status;
35
36 ACPI_FUNCTION_TRACE_PTR(ex_read_gpio, obj_desc);
37
38 /*
39 * For GPIO (general_purpose_io), the Address will be the bit offset
40 * from the previous Connection() operator, making it effectively a
41 * pin number index. The bit_length is the length of the field, which
42 * is thus the number of pins.
43 */
44 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
45 "GPIO FieldRead [FROM]: Pin %u Bits %u\n",
46 obj_desc->field.pin_number_index,
47 obj_desc->field.bit_length));
48
49 /* Lock entire transaction if requested */
50
51 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags);
52
53 /* Perform the read */
54
55 status = acpi_ex_access_region(obj_desc, 0, (u64 *)buffer, ACPI_READ);
56
57 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
58 return_ACPI_STATUS(status);
59}
60
61/*******************************************************************************
62 *
63 * FUNCTION: acpi_ex_write_gpio
64 *
65 * PARAMETERS: source_desc - Contains data to write. Expect to be
66 * an Integer object.
67 * obj_desc - The named field
68 * result_desc - Where the return value is returned, if any
69 *
70 * RETURN: Status
71 *
72 * DESCRIPTION: Write to a named field that references a General Purpose I/O
73 * field.
74 *
75 ******************************************************************************/
76
77acpi_status
78acpi_ex_write_gpio(union acpi_operand_object *source_desc,
79 union acpi_operand_object *obj_desc,
80 union acpi_operand_object **return_buffer)
81{
82 acpi_status status;
83 void *buffer;
84
85 ACPI_FUNCTION_TRACE_PTR(ex_write_gpio, obj_desc);
86
87 /*
88 * For GPIO (general_purpose_io), we will bypass the entire field
89 * mechanism and handoff the bit address and bit width directly to
90 * the handler. The Address will be the bit offset
91 * from the previous Connection() operator, making it effectively a
92 * pin number index. The bit_length is the length of the field, which
93 * is thus the number of pins.
94 */
95 if (source_desc->common.type != ACPI_TYPE_INTEGER) {
96 return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
97 }
98
99 ACPI_DEBUG_PRINT((ACPI_DB_BFIELD,
100 "GPIO FieldWrite [FROM]: (%s:%X), Value %.8X [TO]: Pin %u Bits %u\n",
101 acpi_ut_get_type_name(source_desc->common.type),
102 source_desc->common.type,
103 (u32)source_desc->integer.value,
104 obj_desc->field.pin_number_index,
105 obj_desc->field.bit_length));
106
107 buffer = &source_desc->integer.value;
108
109 /* Lock entire transaction if requested */
110
111 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags);
112
113 /* Perform the write */
114
115 status = acpi_ex_access_region(obj_desc, 0, (u64 *)buffer, ACPI_WRITE);
116 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
117 return_ACPI_STATUS(status);
118}
119
120/*******************************************************************************
121 *
122 * FUNCTION: acpi_ex_read_serial_bus
123 *
124 * PARAMETERS: obj_desc - The named field to read
125 * return_buffer - Where the return value is returned, if any
126 *
127 * RETURN: Status
128 *
129 * DESCRIPTION: Read from a named field that references a serial bus
130 * (SMBus, IPMI, or GSBus).
131 *
132 ******************************************************************************/
133
134acpi_status
135acpi_ex_read_serial_bus(union acpi_operand_object *obj_desc,
136 union acpi_operand_object **return_buffer)
137{
138 acpi_status status;
139 u32 buffer_length;
140 union acpi_operand_object *buffer_desc;
141 u32 function;
142 u16 accessor_type;
143
144 ACPI_FUNCTION_TRACE_PTR(ex_read_serial_bus, obj_desc);
145
146 /*
147 * This is an SMBus, GSBus or IPMI read. We must create a buffer to
148 * hold the data and then directly access the region handler.
149 *
150 * Note: SMBus and GSBus protocol value is passed in upper 16-bits
151 * of Function
152 *
153 * Common buffer format:
154 * Status; (Byte 0 of the data buffer)
155 * Length; (Byte 1 of the data buffer)
156 * Data[x-1]: (Bytes 2-x of the arbitrary length data buffer)
157 */
158 switch (obj_desc->field.region_obj->region.space_id) {
159 case ACPI_ADR_SPACE_SMBUS:
160
161 buffer_length = ACPI_SMBUS_BUFFER_SIZE;
162 function = ACPI_READ | (obj_desc->field.attribute << 16);
163 break;
164
165 case ACPI_ADR_SPACE_IPMI:
166
167 buffer_length = ACPI_IPMI_BUFFER_SIZE;
168 function = ACPI_READ;
169 break;
170
171 case ACPI_ADR_SPACE_GSBUS:
172
173 accessor_type = obj_desc->field.attribute;
174 if (accessor_type == AML_FIELD_ATTRIB_RAW_PROCESS_BYTES) {
175 ACPI_ERROR((AE_INFO,
176 "Invalid direct read using bidirectional write-then-read protocol"));
177
178 return_ACPI_STATUS(AE_AML_PROTOCOL);
179 }
180
181 status =
182 acpi_ex_get_protocol_buffer_length(accessor_type,
183 &buffer_length);
184 if (ACPI_FAILURE(status)) {
185 ACPI_ERROR((AE_INFO,
186 "Invalid protocol ID for GSBus: 0x%4.4X",
187 accessor_type));
188
189 return_ACPI_STATUS(status);
190 }
191
192 /* Add header length to get the full size of the buffer */
193
194 buffer_length += ACPI_SERIAL_HEADER_SIZE;
195 function = ACPI_READ | (accessor_type << 16);
196 break;
197
198 default:
199 return_ACPI_STATUS(AE_AML_INVALID_SPACE_ID);
200 }
201
202 /* Create the local transfer buffer that is returned to the caller */
203
204 buffer_desc = acpi_ut_create_buffer_object(buffer_length);
205 if (!buffer_desc) {
206 return_ACPI_STATUS(AE_NO_MEMORY);
207 }
208
209 /* Lock entire transaction if requested */
210
211 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags);
212
213 /* Call the region handler for the write-then-read */
214
215 status = acpi_ex_access_region(obj_desc, 0,
216 ACPI_CAST_PTR(u64,
217 buffer_desc->buffer.
218 pointer), function);
219 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
220
221 *return_buffer = buffer_desc;
222 return_ACPI_STATUS(status);
223}
224
225/*******************************************************************************
226 *
227 * FUNCTION: acpi_ex_write_serial_bus
228 *
229 * PARAMETERS: source_desc - Contains data to write
230 * obj_desc - The named field
231 * return_buffer - Where the return value is returned, if any
232 *
233 * RETURN: Status
234 *
235 * DESCRIPTION: Write to a named field that references a serial bus
236 * (SMBus, IPMI, GSBus).
237 *
238 ******************************************************************************/
239
240acpi_status
241acpi_ex_write_serial_bus(union acpi_operand_object *source_desc,
242 union acpi_operand_object *obj_desc,
243 union acpi_operand_object **return_buffer)
244{
245 acpi_status status;
246 u32 buffer_length;
247 u32 data_length;
248 void *buffer;
249 union acpi_operand_object *buffer_desc;
250 u32 function;
251 u16 accessor_type;
252
253 ACPI_FUNCTION_TRACE_PTR(ex_write_serial_bus, obj_desc);
254
255 /*
256 * This is an SMBus, GSBus or IPMI write. We will bypass the entire
257 * field mechanism and handoff the buffer directly to the handler.
258 * For these address spaces, the buffer is bidirectional; on a
259 * write, return data is returned in the same buffer.
260 *
261 * Source must be a buffer of sufficient size, these are fixed size:
262 * ACPI_SMBUS_BUFFER_SIZE, or ACPI_IPMI_BUFFER_SIZE.
263 *
264 * Note: SMBus and GSBus protocol type is passed in upper 16-bits
265 * of Function
266 *
267 * Common buffer format:
268 * Status; (Byte 0 of the data buffer)
269 * Length; (Byte 1 of the data buffer)
270 * Data[x-1]: (Bytes 2-x of the arbitrary length data buffer)
271 */
272 if (source_desc->common.type != ACPI_TYPE_BUFFER) {
273 ACPI_ERROR((AE_INFO,
274 "SMBus/IPMI/GenericSerialBus write requires "
275 "Buffer, found type %s",
276 acpi_ut_get_object_type_name(source_desc)));
277
278 return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
279 }
280
281 switch (obj_desc->field.region_obj->region.space_id) {
282 case ACPI_ADR_SPACE_SMBUS:
283
284 buffer_length = ACPI_SMBUS_BUFFER_SIZE;
285 data_length = ACPI_SMBUS_DATA_SIZE;
286 function = ACPI_WRITE | (obj_desc->field.attribute << 16);
287 break;
288
289 case ACPI_ADR_SPACE_IPMI:
290
291 buffer_length = ACPI_IPMI_BUFFER_SIZE;
292 data_length = ACPI_IPMI_DATA_SIZE;
293 function = ACPI_WRITE;
294 break;
295
296 case ACPI_ADR_SPACE_GSBUS:
297
298 accessor_type = obj_desc->field.attribute;
299 status =
300 acpi_ex_get_protocol_buffer_length(accessor_type,
301 &buffer_length);
302 if (ACPI_FAILURE(status)) {
303 ACPI_ERROR((AE_INFO,
304 "Invalid protocol ID for GSBus: 0x%4.4X",
305 accessor_type));
306
307 return_ACPI_STATUS(status);
308 }
309
310 /* Add header length to get the full size of the buffer */
311
312 buffer_length += ACPI_SERIAL_HEADER_SIZE;
313 data_length = source_desc->buffer.pointer[1];
314 function = ACPI_WRITE | (accessor_type << 16);
315 break;
316
317 default:
318 return_ACPI_STATUS(AE_AML_INVALID_SPACE_ID);
319 }
320
321#if 0
322 OBSOLETE ?
323 /* Check for possible buffer overflow */
324 if (data_length > source_desc->buffer.length) {
325 ACPI_ERROR((AE_INFO,
326 "Length in buffer header (%u)(%u) is greater than "
327 "the physical buffer length (%u) and will overflow",
328 data_length, buffer_length,
329 source_desc->buffer.length));
330
331 return_ACPI_STATUS(AE_AML_BUFFER_LIMIT);
332 }
333#endif
334
335 /* Create the transfer/bidirectional/return buffer */
336
337 buffer_desc = acpi_ut_create_buffer_object(buffer_length);
338 if (!buffer_desc) {
339 return_ACPI_STATUS(AE_NO_MEMORY);
340 }
341
342 /* Copy the input buffer data to the transfer buffer */
343
344 buffer = buffer_desc->buffer.pointer;
345 memcpy(buffer, source_desc->buffer.pointer, data_length);
346
347 /* Lock entire transaction if requested */
348
349 acpi_ex_acquire_global_lock(obj_desc->common_field.field_flags);
350
351 /*
352 * Perform the write (returns status and perhaps data in the
353 * same buffer)
354 */
355 status = acpi_ex_access_region(obj_desc, 0, (u64 *)buffer, function);
356 acpi_ex_release_global_lock(obj_desc->common_field.field_flags);
357
358 *return_buffer = buffer_desc;
359 return_ACPI_STATUS(status);
360}
diff --git a/drivers/acpi/acpica/psloop.c b/drivers/acpi/acpica/psloop.c
index 34fc2f7476ed..0fa01c9e353e 100644
--- a/drivers/acpi/acpica/psloop.c
+++ b/drivers/acpi/acpica/psloop.c
@@ -147,7 +147,7 @@ acpi_ps_get_arguments(struct acpi_walk_state *walk_state,
147 * future. Use of this option can cause problems with AML code that 147 * future. Use of this option can cause problems with AML code that
148 * depends upon in-order immediate execution of module-level code. 148 * depends upon in-order immediate execution of module-level code.
149 */ 149 */
150 if (acpi_gbl_group_module_level_code && 150 if (!acpi_gbl_execute_tables_as_methods &&
151 (walk_state->pass_number <= ACPI_IMODE_LOAD_PASS2) && 151 (walk_state->pass_number <= ACPI_IMODE_LOAD_PASS2) &&
152 ((walk_state->parse_flags & ACPI_PARSE_DISASSEMBLE) == 0)) { 152 ((walk_state->parse_flags & ACPI_PARSE_DISASSEMBLE) == 0)) {
153 /* 153 /*
@@ -417,6 +417,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
417 union acpi_parse_object *op = NULL; /* current op */ 417 union acpi_parse_object *op = NULL; /* current op */
418 struct acpi_parse_state *parser_state; 418 struct acpi_parse_state *parser_state;
419 u8 *aml_op_start = NULL; 419 u8 *aml_op_start = NULL;
420 u8 opcode_length;
420 421
421 ACPI_FUNCTION_TRACE_PTR(ps_parse_loop, walk_state); 422 ACPI_FUNCTION_TRACE_PTR(ps_parse_loop, walk_state);
422 423
@@ -540,8 +541,19 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
540 "Skip parsing opcode %s", 541 "Skip parsing opcode %s",
541 acpi_ps_get_opcode_name 542 acpi_ps_get_opcode_name
542 (walk_state->opcode))); 543 (walk_state->opcode)));
544
545 /*
546 * Determine the opcode length before skipping the opcode.
547 * An opcode can be 1 byte or 2 bytes in length.
548 */
549 opcode_length = 1;
550 if ((walk_state->opcode & 0xFF00) ==
551 AML_EXTENDED_OPCODE) {
552 opcode_length = 2;
553 }
543 walk_state->parser_state.aml = 554 walk_state->parser_state.aml =
544 walk_state->aml + 1; 555 walk_state->aml + opcode_length;
556
545 walk_state->parser_state.aml = 557 walk_state->parser_state.aml =
546 acpi_ps_get_next_package_end 558 acpi_ps_get_next_package_end
547 (&walk_state->parser_state); 559 (&walk_state->parser_state);
diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index 2f40f71c06db..9011297552af 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -69,8 +69,7 @@ acpi_status ACPI_INIT_FUNCTION acpi_load_tables(void)
69 "While loading namespace from ACPI tables")); 69 "While loading namespace from ACPI tables"));
70 } 70 }
71 71
72 if (acpi_gbl_execute_tables_as_methods 72 if (acpi_gbl_execute_tables_as_methods) {
73 || !acpi_gbl_group_module_level_code) {
74 /* 73 /*
75 * If the module-level code support is enabled, initialize the objects 74 * If the module-level code support is enabled, initialize the objects
76 * in the namespace that remain uninitialized. This runs the executable 75 * in the namespace that remain uninitialized. This runs the executable
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index d2e29a19890d..bb3d96dea6db 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -1054,15 +1054,17 @@ void __init acpi_early_init(void)
1054 goto error0; 1054 goto error0;
1055 } 1055 }
1056 1056
1057 if (!acpi_gbl_execute_tables_as_methods && 1057 /*
1058 acpi_gbl_group_module_level_code) { 1058 * ACPI 2.0 requires the EC driver to be loaded and work before
1059 status = acpi_load_tables(); 1059 * the EC device is found in the namespace (i.e. before
1060 if (ACPI_FAILURE(status)) { 1060 * acpi_load_tables() is called).
1061 printk(KERN_ERR PREFIX 1061 *
1062 "Unable to load the System Description Tables\n"); 1062 * This is accomplished by looking for the ECDT table, and getting
1063 goto error0; 1063 * the EC parameters out of that.
1064 } 1064 *
1065 } 1065 * Ignore the result. Not having an ECDT is not fatal.
1066 */
1067 status = acpi_ec_ecdt_probe();
1066 1068
1067#ifdef CONFIG_X86 1069#ifdef CONFIG_X86
1068 if (!acpi_ioapic) { 1070 if (!acpi_ioapic) {
@@ -1133,25 +1135,11 @@ static int __init acpi_bus_init(void)
1133 1135
1134 acpi_os_initialize1(); 1136 acpi_os_initialize1();
1135 1137
1136 /* 1138 status = acpi_load_tables();
1137 * ACPI 2.0 requires the EC driver to be loaded and work before 1139 if (ACPI_FAILURE(status)) {
1138 * the EC device is found in the namespace (i.e. before 1140 printk(KERN_ERR PREFIX
1139 * acpi_load_tables() is called). 1141 "Unable to load the System Description Tables\n");
1140 * 1142 goto error1;
1141 * This is accomplished by looking for the ECDT table, and getting
1142 * the EC parameters out of that.
1143 */
1144 status = acpi_ec_ecdt_probe();
1145 /* Ignore result. Not having an ECDT is not fatal. */
1146
1147 if (acpi_gbl_execute_tables_as_methods ||
1148 !acpi_gbl_group_module_level_code) {
1149 status = acpi_load_tables();
1150 if (ACPI_FAILURE(status)) {
1151 printk(KERN_ERR PREFIX
1152 "Unable to load the System Description Tables\n");
1153 goto error1;
1154 }
1155 } 1143 }
1156 1144
1157 status = acpi_enable_subsystem(ACPI_NO_ACPI_ENABLE); 1145 status = acpi_enable_subsystem(ACPI_NO_ACPI_ENABLE);
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
index e967c1173ba3..4451877f83b6 100644
--- a/drivers/acpi/custom_method.c
+++ b/drivers/acpi/custom_method.c
@@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
92 92
93static void __exit acpi_custom_method_exit(void) 93static void __exit acpi_custom_method_exit(void)
94{ 94{
95 if (cm_dentry) 95 debugfs_remove(cm_dentry);
96 debugfs_remove(cm_dentry);
97} 96}
98 97
99module_init(acpi_custom_method_init); 98module_init(acpi_custom_method_init);
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
index 3be1433853bf..12ba2bee8789 100644
--- a/drivers/acpi/glue.c
+++ b/drivers/acpi/glue.c
@@ -320,7 +320,7 @@ static int acpi_platform_notify(struct device *dev)
320 if (!adev) 320 if (!adev)
321 goto out; 321 goto out;
322 322
323 if (dev->bus == &platform_bus_type) 323 if (dev_is_platform(dev))
324 acpi_configure_pmsi_domain(dev); 324 acpi_configure_pmsi_domain(dev);
325 325
326 if (type && type->setup) 326 if (type && type->setup)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 8df9abfa947b..b48874b8e1ea 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -617,15 +617,18 @@ void acpi_os_stall(u32 us)
617} 617}
618 618
619/* 619/*
620 * Support ACPI 3.0 AML Timer operand 620 * Support ACPI 3.0 AML Timer operand. Returns a 64-bit free-running,
621 * Returns 64-bit free-running, monotonically increasing timer 621 * monotonically increasing timer with 100ns granularity. Do not use
622 * with 100ns granularity 622 * ktime_get() to implement this function because this function may get
623 * called after timekeeping has been suspended. Note: calling this function
624 * after timekeeping has been suspended may lead to unexpected results
625 * because when timekeeping is suspended the jiffies counter is not
626 * incremented. See also timekeeping_suspend().
623 */ 627 */
624u64 acpi_os_get_timer(void) 628u64 acpi_os_get_timer(void)
625{ 629{
626 u64 time_ns = ktime_to_ns(ktime_get()); 630 return (get_jiffies_64() - INITIAL_JIFFIES) *
627 do_div(time_ns, 100); 631 (ACPI_100NSEC_PER_SEC / HZ);
628 return time_ns;
629} 632}
630 633
631acpi_status acpi_os_read_port(acpi_io_address port, u32 * value, u32 width) 634acpi_status acpi_os_read_port(acpi_io_address port, u32 * value, u32 width)
@@ -1129,6 +1132,7 @@ void acpi_os_wait_events_complete(void)
1129 flush_workqueue(kacpid_wq); 1132 flush_workqueue(kacpid_wq);
1130 flush_workqueue(kacpi_notify_wq); 1133 flush_workqueue(kacpi_notify_wq);
1131} 1134}
1135EXPORT_SYMBOL(acpi_os_wait_events_complete);
1132 1136
1133struct acpi_hp_work { 1137struct acpi_hp_work {
1134 struct work_struct work; 1138 struct work_struct work;
diff --git a/drivers/acpi/pmic/intel_pmic_bxtwc.c b/drivers/acpi/pmic/intel_pmic_bxtwc.c
index 886ac8b93cd0..bd7621edd60b 100644
--- a/drivers/acpi/pmic/intel_pmic_bxtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_bxtwc.c
@@ -1,16 +1,8 @@
1// SPDX-License-Identifier: GPL-2.0
1/* 2/*
2 * intel_pmic_bxtwc.c - Intel BXT WhiskeyCove PMIC operation region driver 3 * Intel BXT WhiskeyCove PMIC operation region driver
3 * 4 *
4 * Copyright (C) 2015 Intel Corporation. All rights reserved. 5 * Copyright (C) 2015 Intel Corporation. All rights reserved.
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License version
8 * 2 as published by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 */ 6 */
15 7
16#include <linux/init.h> 8#include <linux/init.h>
diff --git a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
index f6d73a243d80..7ccd7d9660bc 100644
--- a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
+++ b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
@@ -1,3 +1,4 @@
1// SPDX-License-Identifier: GPL-2.0
1/* 2/*
2 * Dollar Cove TI PMIC operation region driver 3 * Dollar Cove TI PMIC operation region driver
3 * Copyright (C) 2014 Intel Corporation. All rights reserved. 4 * Copyright (C) 2014 Intel Corporation. All rights reserved.
diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
index 9912422c8185..078b0448f30a 100644
--- a/drivers/acpi/pmic/intel_pmic_chtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
@@ -1,18 +1,10 @@
1// SPDX-License-Identifier: GPL-2.0
1/* 2/*
2 * Intel CHT Whiskey Cove PMIC operation region driver 3 * Intel CHT Whiskey Cove PMIC operation region driver
3 * Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com> 4 * Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
4 * 5 *
5 * Based on various non upstream patches to support the CHT Whiskey Cove PMIC: 6 * Based on various non upstream patches to support the CHT Whiskey Cove PMIC:
6 * Copyright (C) 2013-2015 Intel Corporation. All rights reserved. 7 * Copyright (C) 2013-2015 Intel Corporation. All rights reserved.
7 *
8 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License version
10 * 2 as published by the Free Software Foundation.
11 *
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
16 */ 8 */
17 9
18#include <linux/acpi.h> 10#include <linux/acpi.h>
diff --git a/drivers/acpi/pmic/intel_pmic_crc.c b/drivers/acpi/pmic/intel_pmic_crc.c
index 22c9e374c923..a0f411a6e5ac 100644
--- a/drivers/acpi/pmic/intel_pmic_crc.c
+++ b/drivers/acpi/pmic/intel_pmic_crc.c
@@ -1,23 +1,15 @@
1// SPDX-License-Identifier: GPL-2.0
1/* 2/*
2 * intel_pmic_crc.c - Intel CrystalCove PMIC operation region driver 3 * Intel CrystalCove PMIC operation region driver
3 * 4 *
4 * Copyright (C) 2014 Intel Corporation. All rights reserved. 5 * Copyright (C) 2014 Intel Corporation. All rights reserved.
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License version
8 * 2 as published by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 */ 6 */
15 7
16#include <linux/init.h>
17#include <linux/acpi.h> 8#include <linux/acpi.h>
9#include <linux/init.h>
18#include <linux/mfd/intel_soc_pmic.h> 10#include <linux/mfd/intel_soc_pmic.h>
19#include <linux/regmap.h>
20#include <linux/platform_device.h> 11#include <linux/platform_device.h>
12#include <linux/regmap.h>
21#include "intel_pmic.h" 13#include "intel_pmic.h"
22 14
23#define PWR_SOURCE_SELECT BIT(1) 15#define PWR_SOURCE_SELECT BIT(1)
diff --git a/drivers/acpi/pmic/intel_pmic_xpower.c b/drivers/acpi/pmic/intel_pmic_xpower.c
index 316e55174aa9..aadc86db804c 100644
--- a/drivers/acpi/pmic/intel_pmic_xpower.c
+++ b/drivers/acpi/pmic/intel_pmic_xpower.c
@@ -1,23 +1,15 @@
1// SPDX-License-Identifier: GPL-2.0
1/* 2/*
2 * intel_pmic_xpower.c - XPower AXP288 PMIC operation region driver 3 * XPower AXP288 PMIC operation region driver
3 * 4 *
4 * Copyright (C) 2014 Intel Corporation. All rights reserved. 5 * Copyright (C) 2014 Intel Corporation. All rights reserved.
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License version
8 * 2 as published by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 */ 6 */
15 7
16#include <linux/init.h>
17#include <linux/acpi.h> 8#include <linux/acpi.h>
9#include <linux/init.h>
18#include <linux/mfd/axp20x.h> 10#include <linux/mfd/axp20x.h>
19#include <linux/regmap.h>
20#include <linux/platform_device.h> 11#include <linux/platform_device.h>
12#include <linux/regmap.h>
21#include "intel_pmic.h" 13#include "intel_pmic.h"
22 14
23#define XPOWER_GPADC_LOW 0x5b 15#define XPOWER_GPADC_LOW 0x5b
diff --git a/drivers/acpi/pmic/tps68470_pmic.c b/drivers/acpi/pmic/tps68470_pmic.c
index a083de507009..ebd03e472955 100644
--- a/drivers/acpi/pmic/tps68470_pmic.c
+++ b/drivers/acpi/pmic/tps68470_pmic.c
@@ -10,8 +10,8 @@
10 */ 10 */
11 11
12#include <linux/acpi.h> 12#include <linux/acpi.h>
13#include <linux/mfd/tps68470.h>
14#include <linux/init.h> 13#include <linux/init.h>
14#include <linux/mfd/tps68470.h>
15#include <linux/platform_device.h> 15#include <linux/platform_device.h>
16#include <linux/regmap.h> 16#include <linux/regmap.h>
17 17
diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
index d1e26cb599bf..da031b1df6f5 100644
--- a/drivers/acpi/pptt.c
+++ b/drivers/acpi/pptt.c
@@ -338,9 +338,6 @@ static struct acpi_pptt_cache *acpi_find_cache_node(struct acpi_table_header *ta
338 return found; 338 return found;
339} 339}
340 340
341/* total number of attributes checked by the properties code */
342#define PPTT_CHECKED_ATTRIBUTES 4
343
344/** 341/**
345 * update_cache_properties() - Update cacheinfo for the given processor 342 * update_cache_properties() - Update cacheinfo for the given processor
346 * @this_leaf: Kernel cache info structure being updated 343 * @this_leaf: Kernel cache info structure being updated
@@ -357,25 +354,15 @@ static void update_cache_properties(struct cacheinfo *this_leaf,
357 struct acpi_pptt_cache *found_cache, 354 struct acpi_pptt_cache *found_cache,
358 struct acpi_pptt_processor *cpu_node) 355 struct acpi_pptt_processor *cpu_node)
359{ 356{
360 int valid_flags = 0;
361
362 this_leaf->fw_token = cpu_node; 357 this_leaf->fw_token = cpu_node;
363 if (found_cache->flags & ACPI_PPTT_SIZE_PROPERTY_VALID) { 358 if (found_cache->flags & ACPI_PPTT_SIZE_PROPERTY_VALID)
364 this_leaf->size = found_cache->size; 359 this_leaf->size = found_cache->size;
365 valid_flags++; 360 if (found_cache->flags & ACPI_PPTT_LINE_SIZE_VALID)
366 }
367 if (found_cache->flags & ACPI_PPTT_LINE_SIZE_VALID) {
368 this_leaf->coherency_line_size = found_cache->line_size; 361 this_leaf->coherency_line_size = found_cache->line_size;
369 valid_flags++; 362 if (found_cache->flags & ACPI_PPTT_NUMBER_OF_SETS_VALID)
370 }
371 if (found_cache->flags & ACPI_PPTT_NUMBER_OF_SETS_VALID) {
372 this_leaf->number_of_sets = found_cache->number_of_sets; 363 this_leaf->number_of_sets = found_cache->number_of_sets;
373 valid_flags++; 364 if (found_cache->flags & ACPI_PPTT_ASSOCIATIVITY_VALID)
374 }
375 if (found_cache->flags & ACPI_PPTT_ASSOCIATIVITY_VALID) {
376 this_leaf->ways_of_associativity = found_cache->associativity; 365 this_leaf->ways_of_associativity = found_cache->associativity;
377 valid_flags++;
378 }
379 if (found_cache->flags & ACPI_PPTT_WRITE_POLICY_VALID) { 366 if (found_cache->flags & ACPI_PPTT_WRITE_POLICY_VALID) {
380 switch (found_cache->attributes & ACPI_PPTT_MASK_WRITE_POLICY) { 367 switch (found_cache->attributes & ACPI_PPTT_MASK_WRITE_POLICY) {
381 case ACPI_PPTT_CACHE_POLICY_WT: 368 case ACPI_PPTT_CACHE_POLICY_WT:
@@ -402,11 +389,17 @@ static void update_cache_properties(struct cacheinfo *this_leaf,
402 } 389 }
403 } 390 }
404 /* 391 /*
405 * If the above flags are valid, and the cache type is NOCACHE 392 * If cache type is NOCACHE, then the cache hasn't been specified
406 * update the cache type as well. 393 * via other mechanisms. Update the type if a cache type has been
394 * provided.
395 *
396 * Note, we assume such caches are unified based on conventional system
397 * design and known examples. Significant work is required elsewhere to
398 * fully support data/instruction only type caches which are only
399 * specified in PPTT.
407 */ 400 */
408 if (this_leaf->type == CACHE_TYPE_NOCACHE && 401 if (this_leaf->type == CACHE_TYPE_NOCACHE &&
409 valid_flags == PPTT_CHECKED_ATTRIBUTES) 402 found_cache->flags & ACPI_PPTT_CACHE_TYPE_VALID)
410 this_leaf->type = CACHE_TYPE_UNIFIED; 403 this_leaf->type = CACHE_TYPE_UNIFIED;
411} 404}
412 405
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index 295b59271189..96c5e27967f4 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -441,9 +441,13 @@ static int acpi_ac_get_present(struct acpi_sbs *sbs)
441 441
442 /* 442 /*
443 * The spec requires that bit 4 always be 1. If it's not set, assume 443 * The spec requires that bit 4 always be 1. If it's not set, assume
444 * that the implementation doesn't support an SBS charger 444 * that the implementation doesn't support an SBS charger.
445 *
446 * And on some MacBooks a status of 0xffff is always returned, no
447 * matter whether the charger is plugged in or not, which is also
448 * wrong, so ignore the SBS charger for those too.
445 */ 449 */
446 if (!((status >> 4) & 0x1)) 450 if (!((status >> 4) & 0x1) || status == 0xffff)
447 return -ENODEV; 451 return -ENODEV;
448 452
449 sbs->charger_present = (status >> 15) & 0x1; 453 sbs->charger_present = (status >> 15) & 0x1;
diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c
index 7a3431018e0a..5008ead4609a 100644
--- a/drivers/acpi/sbshc.c
+++ b/drivers/acpi/sbshc.c
@@ -196,6 +196,7 @@ int acpi_smbus_unregister_callback(struct acpi_smb_hc *hc)
196 hc->callback = NULL; 196 hc->callback = NULL;
197 hc->context = NULL; 197 hc->context = NULL;
198 mutex_unlock(&hc->lock); 198 mutex_unlock(&hc->lock);
199 acpi_os_wait_events_complete();
199 return 0; 200 return 0;
200} 201}
201 202
@@ -292,6 +293,7 @@ static int acpi_smbus_hc_remove(struct acpi_device *device)
292 293
293 hc = acpi_driver_data(device); 294 hc = acpi_driver_data(device);
294 acpi_ec_remove_query_handler(hc->ec, hc->query_bit); 295 acpi_ec_remove_query_handler(hc->ec, hc->query_bit);
296 acpi_os_wait_events_complete();
295 kfree(hc); 297 kfree(hc);
296 device->driver_data = NULL; 298 device->driver_data = NULL;
297 return 0; 299 return 0;
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index e1b6231cfa1c..1dcc48b9d33c 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1550,6 +1550,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device)
1550 */ 1550 */
1551 static const struct acpi_device_id i2c_multi_instantiate_ids[] = { 1551 static const struct acpi_device_id i2c_multi_instantiate_ids[] = {
1552 {"BSG1160", }, 1552 {"BSG1160", },
1553 {"INT33FE", },
1553 {} 1554 {}
1554 }; 1555 };
1555 1556
diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index 3f3b7b253445..64fd96eada31 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -332,6 +332,35 @@ err_no_vma:
332 return vma ? -ENOMEM : -ESRCH; 332 return vma ? -ENOMEM : -ESRCH;
333} 333}
334 334
335
336static inline void binder_alloc_set_vma(struct binder_alloc *alloc,
337 struct vm_area_struct *vma)
338{
339 if (vma)
340 alloc->vma_vm_mm = vma->vm_mm;
341 /*
342 * If we see alloc->vma is not NULL, buffer data structures set up
343 * completely. Look at smp_rmb side binder_alloc_get_vma.
344 * We also want to guarantee new alloc->vma_vm_mm is always visible
345 * if alloc->vma is set.
346 */
347 smp_wmb();
348 alloc->vma = vma;
349}
350
351static inline struct vm_area_struct *binder_alloc_get_vma(
352 struct binder_alloc *alloc)
353{
354 struct vm_area_struct *vma = NULL;
355
356 if (alloc->vma) {
357 /* Look at description in binder_alloc_set_vma */
358 smp_rmb();
359 vma = alloc->vma;
360 }
361 return vma;
362}
363
335static struct binder_buffer *binder_alloc_new_buf_locked( 364static struct binder_buffer *binder_alloc_new_buf_locked(
336 struct binder_alloc *alloc, 365 struct binder_alloc *alloc,
337 size_t data_size, 366 size_t data_size,
@@ -348,7 +377,7 @@ static struct binder_buffer *binder_alloc_new_buf_locked(
348 size_t size, data_offsets_size; 377 size_t size, data_offsets_size;
349 int ret; 378 int ret;
350 379
351 if (alloc->vma == NULL) { 380 if (!binder_alloc_get_vma(alloc)) {
352 binder_alloc_debug(BINDER_DEBUG_USER_ERROR, 381 binder_alloc_debug(BINDER_DEBUG_USER_ERROR,
353 "%d: binder_alloc_buf, no vma\n", 382 "%d: binder_alloc_buf, no vma\n",
354 alloc->pid); 383 alloc->pid);
@@ -723,9 +752,7 @@ int binder_alloc_mmap_handler(struct binder_alloc *alloc,
723 buffer->free = 1; 752 buffer->free = 1;
724 binder_insert_free_buffer(alloc, buffer); 753 binder_insert_free_buffer(alloc, buffer);
725 alloc->free_async_space = alloc->buffer_size / 2; 754 alloc->free_async_space = alloc->buffer_size / 2;
726 barrier(); 755 binder_alloc_set_vma(alloc, vma);
727 alloc->vma = vma;
728 alloc->vma_vm_mm = vma->vm_mm;
729 mmgrab(alloc->vma_vm_mm); 756 mmgrab(alloc->vma_vm_mm);
730 757
731 return 0; 758 return 0;
@@ -754,10 +781,10 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
754 int buffers, page_count; 781 int buffers, page_count;
755 struct binder_buffer *buffer; 782 struct binder_buffer *buffer;
756 783
757 BUG_ON(alloc->vma);
758
759 buffers = 0; 784 buffers = 0;
760 mutex_lock(&alloc->mutex); 785 mutex_lock(&alloc->mutex);
786 BUG_ON(alloc->vma);
787
761 while ((n = rb_first(&alloc->allocated_buffers))) { 788 while ((n = rb_first(&alloc->allocated_buffers))) {
762 buffer = rb_entry(n, struct binder_buffer, rb_node); 789 buffer = rb_entry(n, struct binder_buffer, rb_node);
763 790
@@ -900,7 +927,7 @@ int binder_alloc_get_allocated_count(struct binder_alloc *alloc)
900 */ 927 */
901void binder_alloc_vma_close(struct binder_alloc *alloc) 928void binder_alloc_vma_close(struct binder_alloc *alloc)
902{ 929{
903 WRITE_ONCE(alloc->vma, NULL); 930 binder_alloc_set_vma(alloc, NULL);
904} 931}
905 932
906/** 933/**
@@ -935,7 +962,7 @@ enum lru_status binder_alloc_free_page(struct list_head *item,
935 962
936 index = page - alloc->pages; 963 index = page - alloc->pages;
937 page_addr = (uintptr_t)alloc->buffer + index * PAGE_SIZE; 964 page_addr = (uintptr_t)alloc->buffer + index * PAGE_SIZE;
938 vma = alloc->vma; 965 vma = binder_alloc_get_vma(alloc);
939 if (vma) { 966 if (vma) {
940 if (!mmget_not_zero(alloc->vma_vm_mm)) 967 if (!mmget_not_zero(alloc->vma_vm_mm))
941 goto err_mmget; 968 goto err_mmget;
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 599e01bcdef2..a9dd4ea7467d 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5359,10 +5359,20 @@ void ata_qc_complete(struct ata_queued_cmd *qc)
5359 */ 5359 */
5360int ata_qc_complete_multiple(struct ata_port *ap, u64 qc_active) 5360int ata_qc_complete_multiple(struct ata_port *ap, u64 qc_active)
5361{ 5361{
5362 u64 done_mask, ap_qc_active = ap->qc_active;
5362 int nr_done = 0; 5363 int nr_done = 0;
5363 u64 done_mask;
5364 5364
5365 done_mask = ap->qc_active ^ qc_active; 5365 /*
5366 * If the internal tag is set on ap->qc_active, then we care about
5367 * bit0 on the passed in qc_active mask. Move that bit up to match
5368 * the internal tag.
5369 */
5370 if (ap_qc_active & (1ULL << ATA_TAG_INTERNAL)) {
5371 qc_active |= (qc_active & 0x01) << ATA_TAG_INTERNAL;
5372 qc_active ^= qc_active & 0x01;
5373 }
5374
5375 done_mask = ap_qc_active ^ qc_active;
5366 5376
5367 if (unlikely(done_mask & qc_active)) { 5377 if (unlikely(done_mask & qc_active)) {
5368 ata_port_err(ap, "illegal qc_active transition (%08llx->%08llx)\n", 5378 ata_port_err(ap, "illegal qc_active transition (%08llx->%08llx)\n",
diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index 5d5b5988e88b..cf78fa6d470d 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -615,6 +615,8 @@ static int cache_add_dev(unsigned int cpu)
615 this_leaf = this_cpu_ci->info_list + i; 615 this_leaf = this_cpu_ci->info_list + i;
616 if (this_leaf->disable_sysfs) 616 if (this_leaf->disable_sysfs)
617 continue; 617 continue;
618 if (this_leaf->type == CACHE_TYPE_NOCACHE)
619 break;
618 cache_groups = cache_get_attribute_groups(this_leaf); 620 cache_groups = cache_get_attribute_groups(this_leaf);
619 ci_dev = cpu_device_create(parent, this_leaf, cache_groups, 621 ci_dev = cpu_device_create(parent, this_leaf, cache_groups,
620 "index%1u", i); 622 "index%1u", i);
diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 0943e7065e0e..8e9213b36e31 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -209,22 +209,28 @@ static struct fw_priv *__lookup_fw_priv(const char *fw_name)
209static int alloc_lookup_fw_priv(const char *fw_name, 209static int alloc_lookup_fw_priv(const char *fw_name,
210 struct firmware_cache *fwc, 210 struct firmware_cache *fwc,
211 struct fw_priv **fw_priv, void *dbuf, 211 struct fw_priv **fw_priv, void *dbuf,
212 size_t size) 212 size_t size, enum fw_opt opt_flags)
213{ 213{
214 struct fw_priv *tmp; 214 struct fw_priv *tmp;
215 215
216 spin_lock(&fwc->lock); 216 spin_lock(&fwc->lock);
217 tmp = __lookup_fw_priv(fw_name); 217 if (!(opt_flags & FW_OPT_NOCACHE)) {
218 if (tmp) { 218 tmp = __lookup_fw_priv(fw_name);
219 kref_get(&tmp->ref); 219 if (tmp) {
220 spin_unlock(&fwc->lock); 220 kref_get(&tmp->ref);
221 *fw_priv = tmp; 221 spin_unlock(&fwc->lock);
222 pr_debug("batched request - sharing the same struct fw_priv and lookup for multiple requests\n"); 222 *fw_priv = tmp;
223 return 1; 223 pr_debug("batched request - sharing the same struct fw_priv and lookup for multiple requests\n");
224 return 1;
225 }
224 } 226 }
227
225 tmp = __allocate_fw_priv(fw_name, fwc, dbuf, size); 228 tmp = __allocate_fw_priv(fw_name, fwc, dbuf, size);
226 if (tmp) 229 if (tmp) {
227 list_add(&tmp->list, &fwc->head); 230 INIT_LIST_HEAD(&tmp->list);
231 if (!(opt_flags & FW_OPT_NOCACHE))
232 list_add(&tmp->list, &fwc->head);
233 }
228 spin_unlock(&fwc->lock); 234 spin_unlock(&fwc->lock);
229 235
230 *fw_priv = tmp; 236 *fw_priv = tmp;
@@ -493,7 +499,8 @@ int assign_fw(struct firmware *fw, struct device *device,
493 */ 499 */
494static int 500static int
495_request_firmware_prepare(struct firmware **firmware_p, const char *name, 501_request_firmware_prepare(struct firmware **firmware_p, const char *name,
496 struct device *device, void *dbuf, size_t size) 502 struct device *device, void *dbuf, size_t size,
503 enum fw_opt opt_flags)
497{ 504{
498 struct firmware *firmware; 505 struct firmware *firmware;
499 struct fw_priv *fw_priv; 506 struct fw_priv *fw_priv;
@@ -511,7 +518,8 @@ _request_firmware_prepare(struct firmware **firmware_p, const char *name,
511 return 0; /* assigned */ 518 return 0; /* assigned */
512 } 519 }
513 520
514 ret = alloc_lookup_fw_priv(name, &fw_cache, &fw_priv, dbuf, size); 521 ret = alloc_lookup_fw_priv(name, &fw_cache, &fw_priv, dbuf, size,
522 opt_flags);
515 523
516 /* 524 /*
517 * bind with 'priv' now to avoid warning in failure path 525 * bind with 'priv' now to avoid warning in failure path
@@ -571,7 +579,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
571 goto out; 579 goto out;
572 } 580 }
573 581
574 ret = _request_firmware_prepare(&fw, name, device, buf, size); 582 ret = _request_firmware_prepare(&fw, name, device, buf, size,
583 opt_flags);
575 if (ret <= 0) /* error or already assigned */ 584 if (ret <= 0) /* error or already assigned */
576 goto out; 585 goto out;
577 586
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 3f68e2919dc5..a690fd400260 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1713,8 +1713,10 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async)
1713 1713
1714 dpm_wait_for_subordinate(dev, async); 1714 dpm_wait_for_subordinate(dev, async);
1715 1715
1716 if (async_error) 1716 if (async_error) {
1717 dev->power.direct_complete = false;
1717 goto Complete; 1718 goto Complete;
1719 }
1718 1720
1719 /* 1721 /*
1720 * If a device configured to wake up the system from sleep states 1722 * If a device configured to wake up the system from sleep states
@@ -1726,6 +1728,7 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async)
1726 pm_wakeup_event(dev, 0); 1728 pm_wakeup_event(dev, 0);
1727 1729
1728 if (pm_wakeup_pending()) { 1730 if (pm_wakeup_pending()) {
1731 dev->power.direct_complete = false;
1729 async_error = -EBUSY; 1732 async_error = -EBUSY;
1730 goto Complete; 1733 goto Complete;
1731 } 1734 }
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 48f622728ce6..f2b6f4da1034 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -3467,6 +3467,9 @@ static int fd_locked_ioctl(struct block_device *bdev, fmode_t mode, unsigned int
3467 (struct floppy_struct **)&outparam); 3467 (struct floppy_struct **)&outparam);
3468 if (ret) 3468 if (ret)
3469 return ret; 3469 return ret;
3470 memcpy(&inparam.g, outparam,
3471 offsetof(struct floppy_struct, name));
3472 outparam = &inparam.g;
3470 break; 3473 break;
3471 case FDMSGON: 3474 case FDMSGON:
3472 UDP->flags |= FTD_MSG; 3475 UDP->flags |= FTD_MSG;
diff --git a/drivers/block/null_blk.h b/drivers/block/null_blk.h
index d81781f22dba..34e0030f0592 100644
--- a/drivers/block/null_blk.h
+++ b/drivers/block/null_blk.h
@@ -87,10 +87,10 @@ struct nullb {
87#ifdef CONFIG_BLK_DEV_ZONED 87#ifdef CONFIG_BLK_DEV_ZONED
88int null_zone_init(struct nullb_device *dev); 88int null_zone_init(struct nullb_device *dev);
89void null_zone_exit(struct nullb_device *dev); 89void null_zone_exit(struct nullb_device *dev);
90blk_status_t null_zone_report(struct nullb *nullb, 90blk_status_t null_zone_report(struct nullb *nullb, struct bio *bio);
91 struct nullb_cmd *cmd); 91void null_zone_write(struct nullb_cmd *cmd, sector_t sector,
92void null_zone_write(struct nullb_cmd *cmd); 92 unsigned int nr_sectors);
93void null_zone_reset(struct nullb_cmd *cmd); 93void null_zone_reset(struct nullb_cmd *cmd, sector_t sector);
94#else 94#else
95static inline int null_zone_init(struct nullb_device *dev) 95static inline int null_zone_init(struct nullb_device *dev)
96{ 96{
@@ -98,11 +98,14 @@ static inline int null_zone_init(struct nullb_device *dev)
98} 98}
99static inline void null_zone_exit(struct nullb_device *dev) {} 99static inline void null_zone_exit(struct nullb_device *dev) {}
100static inline blk_status_t null_zone_report(struct nullb *nullb, 100static inline blk_status_t null_zone_report(struct nullb *nullb,
101 struct nullb_cmd *cmd) 101 struct bio *bio)
102{ 102{
103 return BLK_STS_NOTSUPP; 103 return BLK_STS_NOTSUPP;
104} 104}
105static inline void null_zone_write(struct nullb_cmd *cmd) {} 105static inline void null_zone_write(struct nullb_cmd *cmd, sector_t sector,
106static inline void null_zone_reset(struct nullb_cmd *cmd) {} 106 unsigned int nr_sectors)
107{
108}
109static inline void null_zone_reset(struct nullb_cmd *cmd, sector_t sector) {}
107#endif /* CONFIG_BLK_DEV_ZONED */ 110#endif /* CONFIG_BLK_DEV_ZONED */
108#endif /* __NULL_BLK_H */ 111#endif /* __NULL_BLK_H */
diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
index 6127e3ff7b4b..093b614d6524 100644
--- a/drivers/block/null_blk_main.c
+++ b/drivers/block/null_blk_main.c
@@ -1157,16 +1157,33 @@ static void null_restart_queue_async(struct nullb *nullb)
1157 } 1157 }
1158} 1158}
1159 1159
1160static bool cmd_report_zone(struct nullb *nullb, struct nullb_cmd *cmd)
1161{
1162 struct nullb_device *dev = cmd->nq->dev;
1163
1164 if (dev->queue_mode == NULL_Q_BIO) {
1165 if (bio_op(cmd->bio) == REQ_OP_ZONE_REPORT) {
1166 cmd->error = null_zone_report(nullb, cmd->bio);
1167 return true;
1168 }
1169 } else {
1170 if (req_op(cmd->rq) == REQ_OP_ZONE_REPORT) {
1171 cmd->error = null_zone_report(nullb, cmd->rq->bio);
1172 return true;
1173 }
1174 }
1175
1176 return false;
1177}
1178
1160static blk_status_t null_handle_cmd(struct nullb_cmd *cmd) 1179static blk_status_t null_handle_cmd(struct nullb_cmd *cmd)
1161{ 1180{
1162 struct nullb_device *dev = cmd->nq->dev; 1181 struct nullb_device *dev = cmd->nq->dev;
1163 struct nullb *nullb = dev->nullb; 1182 struct nullb *nullb = dev->nullb;
1164 int err = 0; 1183 int err = 0;
1165 1184
1166 if (req_op(cmd->rq) == REQ_OP_ZONE_REPORT) { 1185 if (cmd_report_zone(nullb, cmd))
1167 cmd->error = null_zone_report(nullb, cmd);
1168 goto out; 1186 goto out;
1169 }
1170 1187
1171 if (test_bit(NULLB_DEV_FL_THROTTLED, &dev->flags)) { 1188 if (test_bit(NULLB_DEV_FL_THROTTLED, &dev->flags)) {
1172 struct request *rq = cmd->rq; 1189 struct request *rq = cmd->rq;
@@ -1234,10 +1251,24 @@ static blk_status_t null_handle_cmd(struct nullb_cmd *cmd)
1234 cmd->error = errno_to_blk_status(err); 1251 cmd->error = errno_to_blk_status(err);
1235 1252
1236 if (!cmd->error && dev->zoned) { 1253 if (!cmd->error && dev->zoned) {
1237 if (req_op(cmd->rq) == REQ_OP_WRITE) 1254 sector_t sector;
1238 null_zone_write(cmd); 1255 unsigned int nr_sectors;
1239 else if (req_op(cmd->rq) == REQ_OP_ZONE_RESET) 1256 int op;
1240 null_zone_reset(cmd); 1257
1258 if (dev->queue_mode == NULL_Q_BIO) {
1259 op = bio_op(cmd->bio);
1260 sector = cmd->bio->bi_iter.bi_sector;
1261 nr_sectors = cmd->bio->bi_iter.bi_size >> 9;
1262 } else {
1263 op = req_op(cmd->rq);
1264 sector = blk_rq_pos(cmd->rq);
1265 nr_sectors = blk_rq_sectors(cmd->rq);
1266 }
1267
1268 if (op == REQ_OP_WRITE)
1269 null_zone_write(cmd, sector, nr_sectors);
1270 else if (op == REQ_OP_ZONE_RESET)
1271 null_zone_reset(cmd, sector);
1241 } 1272 }
1242out: 1273out:
1243 /* Complete IO by inline, softirq or timer */ 1274 /* Complete IO by inline, softirq or timer */
diff --git a/drivers/block/null_blk_zoned.c b/drivers/block/null_blk_zoned.c
index a979ca00d7be..7c6b86d98700 100644
--- a/drivers/block/null_blk_zoned.c
+++ b/drivers/block/null_blk_zoned.c
@@ -48,8 +48,8 @@ void null_zone_exit(struct nullb_device *dev)
48 kvfree(dev->zones); 48 kvfree(dev->zones);
49} 49}
50 50
51static void null_zone_fill_rq(struct nullb_device *dev, struct request *rq, 51static void null_zone_fill_bio(struct nullb_device *dev, struct bio *bio,
52 unsigned int zno, unsigned int nr_zones) 52 unsigned int zno, unsigned int nr_zones)
53{ 53{
54 struct blk_zone_report_hdr *hdr = NULL; 54 struct blk_zone_report_hdr *hdr = NULL;
55 struct bio_vec bvec; 55 struct bio_vec bvec;
@@ -57,7 +57,7 @@ static void null_zone_fill_rq(struct nullb_device *dev, struct request *rq,
57 void *addr; 57 void *addr;
58 unsigned int zones_to_cpy; 58 unsigned int zones_to_cpy;
59 59
60 bio_for_each_segment(bvec, rq->bio, iter) { 60 bio_for_each_segment(bvec, bio, iter) {
61 addr = kmap_atomic(bvec.bv_page); 61 addr = kmap_atomic(bvec.bv_page);
62 62
63 zones_to_cpy = bvec.bv_len / sizeof(struct blk_zone); 63 zones_to_cpy = bvec.bv_len / sizeof(struct blk_zone);
@@ -84,29 +84,24 @@ static void null_zone_fill_rq(struct nullb_device *dev, struct request *rq,
84 } 84 }
85} 85}
86 86
87blk_status_t null_zone_report(struct nullb *nullb, 87blk_status_t null_zone_report(struct nullb *nullb, struct bio *bio)
88 struct nullb_cmd *cmd)
89{ 88{
90 struct nullb_device *dev = nullb->dev; 89 struct nullb_device *dev = nullb->dev;
91 struct request *rq = cmd->rq; 90 unsigned int zno = null_zone_no(dev, bio->bi_iter.bi_sector);
92 unsigned int zno = null_zone_no(dev, blk_rq_pos(rq));
93 unsigned int nr_zones = dev->nr_zones - zno; 91 unsigned int nr_zones = dev->nr_zones - zno;
94 unsigned int max_zones = (blk_rq_bytes(rq) / 92 unsigned int max_zones;
95 sizeof(struct blk_zone)) - 1;
96 93
94 max_zones = (bio->bi_iter.bi_size / sizeof(struct blk_zone)) - 1;
97 nr_zones = min_t(unsigned int, nr_zones, max_zones); 95 nr_zones = min_t(unsigned int, nr_zones, max_zones);
98 96 null_zone_fill_bio(nullb->dev, bio, zno, nr_zones);
99 null_zone_fill_rq(nullb->dev, rq, zno, nr_zones);
100 97
101 return BLK_STS_OK; 98 return BLK_STS_OK;
102} 99}
103 100
104void null_zone_write(struct nullb_cmd *cmd) 101void null_zone_write(struct nullb_cmd *cmd, sector_t sector,
102 unsigned int nr_sectors)
105{ 103{
106 struct nullb_device *dev = cmd->nq->dev; 104 struct nullb_device *dev = cmd->nq->dev;
107 struct request *rq = cmd->rq;
108 sector_t sector = blk_rq_pos(rq);
109 unsigned int rq_sectors = blk_rq_sectors(rq);
110 unsigned int zno = null_zone_no(dev, sector); 105 unsigned int zno = null_zone_no(dev, sector);
111 struct blk_zone *zone = &dev->zones[zno]; 106 struct blk_zone *zone = &dev->zones[zno];
112 107
@@ -118,7 +113,7 @@ void null_zone_write(struct nullb_cmd *cmd)
118 case BLK_ZONE_COND_EMPTY: 113 case BLK_ZONE_COND_EMPTY:
119 case BLK_ZONE_COND_IMP_OPEN: 114 case BLK_ZONE_COND_IMP_OPEN:
120 /* Writes must be at the write pointer position */ 115 /* Writes must be at the write pointer position */
121 if (blk_rq_pos(rq) != zone->wp) { 116 if (sector != zone->wp) {
122 cmd->error = BLK_STS_IOERR; 117 cmd->error = BLK_STS_IOERR;
123 break; 118 break;
124 } 119 }
@@ -126,7 +121,7 @@ void null_zone_write(struct nullb_cmd *cmd)
126 if (zone->cond == BLK_ZONE_COND_EMPTY) 121 if (zone->cond == BLK_ZONE_COND_EMPTY)
127 zone->cond = BLK_ZONE_COND_IMP_OPEN; 122 zone->cond = BLK_ZONE_COND_IMP_OPEN;
128 123
129 zone->wp += rq_sectors; 124 zone->wp += nr_sectors;
130 if (zone->wp == zone->start + zone->len) 125 if (zone->wp == zone->start + zone->len)
131 zone->cond = BLK_ZONE_COND_FULL; 126 zone->cond = BLK_ZONE_COND_FULL;
132 break; 127 break;
@@ -137,11 +132,10 @@ void null_zone_write(struct nullb_cmd *cmd)
137 } 132 }
138} 133}
139 134
140void null_zone_reset(struct nullb_cmd *cmd) 135void null_zone_reset(struct nullb_cmd *cmd, sector_t sector)
141{ 136{
142 struct nullb_device *dev = cmd->nq->dev; 137 struct nullb_device *dev = cmd->nq->dev;
143 struct request *rq = cmd->rq; 138 unsigned int zno = null_zone_no(dev, sector);
144 unsigned int zno = null_zone_no(dev, blk_rq_pos(rq));
145 struct blk_zone *zone = &dev->zones[zno]; 139 struct blk_zone *zone = &dev->zones[zno];
146 140
147 zone->cond = BLK_ZONE_COND_EMPTY; 141 zone->cond = BLK_ZONE_COND_EMPTY;
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index a71d817e900d..429d20131c7e 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2670,8 +2670,8 @@ static void purge_persistent_grants(struct blkfront_info *info)
2670 list_del(&gnt_list_entry->node); 2670 list_del(&gnt_list_entry->node);
2671 gnttab_end_foreign_access(gnt_list_entry->gref, 0, 0UL); 2671 gnttab_end_foreign_access(gnt_list_entry->gref, 0, 0UL);
2672 rinfo->persistent_gnts_c--; 2672 rinfo->persistent_gnts_c--;
2673 __free_page(gnt_list_entry->page); 2673 gnt_list_entry->gref = GRANT_INVALID_REF;
2674 kfree(gnt_list_entry); 2674 list_add_tail(&gnt_list_entry->node, &rinfo->grants);
2675 } 2675 }
2676 2676
2677 spin_unlock_irqrestore(&rinfo->ring_lock, flags); 2677 spin_unlock_irqrestore(&rinfo->ring_lock, flags);
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 963bb0309e25..ea6238ed5c0e 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -543,6 +543,8 @@ static void hci_uart_tty_close(struct tty_struct *tty)
543 } 543 }
544 clear_bit(HCI_UART_PROTO_SET, &hu->flags); 544 clear_bit(HCI_UART_PROTO_SET, &hu->flags);
545 545
546 percpu_free_rwsem(&hu->proto_lock);
547
546 kfree(hu); 548 kfree(hu);
547} 549}
548 550
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index e182f6019f68..2fee65886d50 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1322,7 +1322,7 @@ static int qca_init_regulators(struct qca_power *qca,
1322{ 1322{
1323 int i; 1323 int i;
1324 1324
1325 qca->vreg_bulk = devm_kzalloc(qca->dev, num_vregs * 1325 qca->vreg_bulk = devm_kcalloc(qca->dev, num_vregs,
1326 sizeof(struct regulator_bulk_data), 1326 sizeof(struct regulator_bulk_data),
1327 GFP_KERNEL); 1327 GFP_KERNEL);
1328 if (!qca->vreg_bulk) 1328 if (!qca->vreg_bulk)
diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
index a3397664f800..97d6856c9c0f 100644
--- a/drivers/char/ipmi/ipmi_bt_sm.c
+++ b/drivers/char/ipmi/ipmi_bt_sm.c
@@ -59,8 +59,6 @@ enum bt_states {
59 BT_STATE_RESET3, 59 BT_STATE_RESET3,
60 BT_STATE_RESTART, 60 BT_STATE_RESTART,
61 BT_STATE_PRINTME, 61 BT_STATE_PRINTME,
62 BT_STATE_CAPABILITIES_BEGIN,
63 BT_STATE_CAPABILITIES_END,
64 BT_STATE_LONG_BUSY /* BT doesn't get hosed :-) */ 62 BT_STATE_LONG_BUSY /* BT doesn't get hosed :-) */
65}; 63};
66 64
@@ -86,7 +84,6 @@ struct si_sm_data {
86 int error_retries; /* end of "common" fields */ 84 int error_retries; /* end of "common" fields */
87 int nonzero_status; /* hung BMCs stay all 0 */ 85 int nonzero_status; /* hung BMCs stay all 0 */
88 enum bt_states complete; /* to divert the state machine */ 86 enum bt_states complete; /* to divert the state machine */
89 int BT_CAP_outreqs;
90 long BT_CAP_req2rsp; 87 long BT_CAP_req2rsp;
91 int BT_CAP_retries; /* Recommended retries */ 88 int BT_CAP_retries; /* Recommended retries */
92}; 89};
@@ -137,8 +134,6 @@ static char *state2txt(unsigned char state)
137 case BT_STATE_RESET3: return("RESET3"); 134 case BT_STATE_RESET3: return("RESET3");
138 case BT_STATE_RESTART: return("RESTART"); 135 case BT_STATE_RESTART: return("RESTART");
139 case BT_STATE_LONG_BUSY: return("LONG_BUSY"); 136 case BT_STATE_LONG_BUSY: return("LONG_BUSY");
140 case BT_STATE_CAPABILITIES_BEGIN: return("CAP_BEGIN");
141 case BT_STATE_CAPABILITIES_END: return("CAP_END");
142 } 137 }
143 return("BAD STATE"); 138 return("BAD STATE");
144} 139}
@@ -185,7 +180,6 @@ static unsigned int bt_init_data(struct si_sm_data *bt, struct si_sm_io *io)
185 bt->complete = BT_STATE_IDLE; /* end here */ 180 bt->complete = BT_STATE_IDLE; /* end here */
186 bt->BT_CAP_req2rsp = BT_NORMAL_TIMEOUT * USEC_PER_SEC; 181 bt->BT_CAP_req2rsp = BT_NORMAL_TIMEOUT * USEC_PER_SEC;
187 bt->BT_CAP_retries = BT_NORMAL_RETRY_LIMIT; 182 bt->BT_CAP_retries = BT_NORMAL_RETRY_LIMIT;
188 /* BT_CAP_outreqs == zero is a flag to read BT Capabilities */
189 return 3; /* We claim 3 bytes of space; ought to check SPMI table */ 183 return 3; /* We claim 3 bytes of space; ought to check SPMI table */
190} 184}
191 185
@@ -451,7 +445,7 @@ static enum si_sm_result error_recovery(struct si_sm_data *bt,
451 445
452static enum si_sm_result bt_event(struct si_sm_data *bt, long time) 446static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
453{ 447{
454 unsigned char status, BT_CAP[8]; 448 unsigned char status;
455 static enum bt_states last_printed = BT_STATE_PRINTME; 449 static enum bt_states last_printed = BT_STATE_PRINTME;
456 int i; 450 int i;
457 451
@@ -504,12 +498,6 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
504 if (status & BT_H_BUSY) /* clear a leftover H_BUSY */ 498 if (status & BT_H_BUSY) /* clear a leftover H_BUSY */
505 BT_CONTROL(BT_H_BUSY); 499 BT_CONTROL(BT_H_BUSY);
506 500
507 bt->timeout = bt->BT_CAP_req2rsp;
508
509 /* Read BT capabilities if it hasn't been done yet */
510 if (!bt->BT_CAP_outreqs)
511 BT_STATE_CHANGE(BT_STATE_CAPABILITIES_BEGIN,
512 SI_SM_CALL_WITHOUT_DELAY);
513 BT_SI_SM_RETURN(SI_SM_IDLE); 501 BT_SI_SM_RETURN(SI_SM_IDLE);
514 502
515 case BT_STATE_XACTION_START: 503 case BT_STATE_XACTION_START:
@@ -614,37 +602,6 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
614 BT_STATE_CHANGE(BT_STATE_XACTION_START, 602 BT_STATE_CHANGE(BT_STATE_XACTION_START,
615 SI_SM_CALL_WITH_DELAY); 603 SI_SM_CALL_WITH_DELAY);
616 604
617 /*
618 * Get BT Capabilities, using timing of upper level state machine.
619 * Set outreqs to prevent infinite loop on timeout.
620 */
621 case BT_STATE_CAPABILITIES_BEGIN:
622 bt->BT_CAP_outreqs = 1;
623 {
624 unsigned char GetBT_CAP[] = { 0x18, 0x36 };
625 bt->state = BT_STATE_IDLE;
626 bt_start_transaction(bt, GetBT_CAP, sizeof(GetBT_CAP));
627 }
628 bt->complete = BT_STATE_CAPABILITIES_END;
629 BT_STATE_CHANGE(BT_STATE_XACTION_START,
630 SI_SM_CALL_WITH_DELAY);
631
632 case BT_STATE_CAPABILITIES_END:
633 i = bt_get_result(bt, BT_CAP, sizeof(BT_CAP));
634 bt_init_data(bt, bt->io);
635 if ((i == 8) && !BT_CAP[2]) {
636 bt->BT_CAP_outreqs = BT_CAP[3];
637 bt->BT_CAP_req2rsp = BT_CAP[6] * USEC_PER_SEC;
638 bt->BT_CAP_retries = BT_CAP[7];
639 } else
640 printk(KERN_WARNING "IPMI BT: using default values\n");
641 if (!bt->BT_CAP_outreqs)
642 bt->BT_CAP_outreqs = 1;
643 printk(KERN_WARNING "IPMI BT: req2rsp=%ld secs retries=%d\n",
644 bt->BT_CAP_req2rsp / USEC_PER_SEC, bt->BT_CAP_retries);
645 bt->timeout = bt->BT_CAP_req2rsp;
646 return SI_SM_CALL_WITHOUT_DELAY;
647
648 default: /* should never occur */ 605 default: /* should never occur */
649 return error_recovery(bt, 606 return error_recovery(bt,
650 status, 607 status,
@@ -655,6 +612,11 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
655 612
656static int bt_detect(struct si_sm_data *bt) 613static int bt_detect(struct si_sm_data *bt)
657{ 614{
615 unsigned char GetBT_CAP[] = { 0x18, 0x36 };
616 unsigned char BT_CAP[8];
617 enum si_sm_result smi_result;
618 int rv;
619
658 /* 620 /*
659 * It's impossible for the BT status and interrupt registers to be 621 * It's impossible for the BT status and interrupt registers to be
660 * all 1's, (assuming a properly functioning, self-initialized BMC) 622 * all 1's, (assuming a properly functioning, self-initialized BMC)
@@ -665,6 +627,48 @@ static int bt_detect(struct si_sm_data *bt)
665 if ((BT_STATUS == 0xFF) && (BT_INTMASK_R == 0xFF)) 627 if ((BT_STATUS == 0xFF) && (BT_INTMASK_R == 0xFF))
666 return 1; 628 return 1;
667 reset_flags(bt); 629 reset_flags(bt);
630
631 /*
632 * Try getting the BT capabilities here.
633 */
634 rv = bt_start_transaction(bt, GetBT_CAP, sizeof(GetBT_CAP));
635 if (rv) {
636 dev_warn(bt->io->dev,
637 "Can't start capabilities transaction: %d\n", rv);
638 goto out_no_bt_cap;
639 }
640
641 smi_result = SI_SM_CALL_WITHOUT_DELAY;
642 for (;;) {
643 if (smi_result == SI_SM_CALL_WITH_DELAY ||
644 smi_result == SI_SM_CALL_WITH_TICK_DELAY) {
645 schedule_timeout_uninterruptible(1);
646 smi_result = bt_event(bt, jiffies_to_usecs(1));
647 } else if (smi_result == SI_SM_CALL_WITHOUT_DELAY) {
648 smi_result = bt_event(bt, 0);
649 } else
650 break;
651 }
652
653 rv = bt_get_result(bt, BT_CAP, sizeof(BT_CAP));
654 bt_init_data(bt, bt->io);
655 if (rv < 8) {
656 dev_warn(bt->io->dev, "bt cap response too short: %d\n", rv);
657 goto out_no_bt_cap;
658 }
659
660 if (BT_CAP[2]) {
661 dev_warn(bt->io->dev, "Error fetching bt cap: %x\n", BT_CAP[2]);
662out_no_bt_cap:
663 dev_warn(bt->io->dev, "using default values\n");
664 } else {
665 bt->BT_CAP_req2rsp = BT_CAP[6] * USEC_PER_SEC;
666 bt->BT_CAP_retries = BT_CAP[7];
667 }
668
669 dev_info(bt->io->dev, "req2rsp=%ld secs retries=%d\n",
670 bt->BT_CAP_req2rsp / USEC_PER_SEC, bt->BT_CAP_retries);
671
668 return 0; 672 return 0;
669} 673}
670 674
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 51832b8a2c62..7fc9612070a1 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -3381,39 +3381,45 @@ int ipmi_register_smi(const struct ipmi_smi_handlers *handlers,
3381 3381
3382 rv = handlers->start_processing(send_info, intf); 3382 rv = handlers->start_processing(send_info, intf);
3383 if (rv) 3383 if (rv)
3384 goto out; 3384 goto out_err;
3385 3385
3386 rv = __bmc_get_device_id(intf, NULL, &id, NULL, NULL, i); 3386 rv = __bmc_get_device_id(intf, NULL, &id, NULL, NULL, i);
3387 if (rv) { 3387 if (rv) {
3388 dev_err(si_dev, "Unable to get the device id: %d\n", rv); 3388 dev_err(si_dev, "Unable to get the device id: %d\n", rv);
3389 goto out; 3389 goto out_err_started;
3390 } 3390 }
3391 3391
3392 mutex_lock(&intf->bmc_reg_mutex); 3392 mutex_lock(&intf->bmc_reg_mutex);
3393 rv = __scan_channels(intf, &id); 3393 rv = __scan_channels(intf, &id);
3394 mutex_unlock(&intf->bmc_reg_mutex); 3394 mutex_unlock(&intf->bmc_reg_mutex);
3395 if (rv)
3396 goto out_err_bmc_reg;
3395 3397
3396 out: 3398 /*
3397 if (rv) { 3399 * Keep memory order straight for RCU readers. Make
3398 ipmi_bmc_unregister(intf); 3400 * sure everything else is committed to memory before
3399 list_del_rcu(&intf->link); 3401 * setting intf_num to mark the interface valid.
3400 mutex_unlock(&ipmi_interfaces_mutex); 3402 */
3401 synchronize_srcu(&ipmi_interfaces_srcu); 3403 smp_wmb();
3402 cleanup_srcu_struct(&intf->users_srcu); 3404 intf->intf_num = i;
3403 kref_put(&intf->refcount, intf_free); 3405 mutex_unlock(&ipmi_interfaces_mutex);
3404 } else {
3405 /*
3406 * Keep memory order straight for RCU readers. Make
3407 * sure everything else is committed to memory before
3408 * setting intf_num to mark the interface valid.
3409 */
3410 smp_wmb();
3411 intf->intf_num = i;
3412 mutex_unlock(&ipmi_interfaces_mutex);
3413 3406
3414 /* After this point the interface is legal to use. */ 3407 /* After this point the interface is legal to use. */
3415 call_smi_watchers(i, intf->si_dev); 3408 call_smi_watchers(i, intf->si_dev);
3416 } 3409
3410 return 0;
3411
3412 out_err_bmc_reg:
3413 ipmi_bmc_unregister(intf);
3414 out_err_started:
3415 if (intf->handlers->shutdown)
3416 intf->handlers->shutdown(intf->send_info);
3417 out_err:
3418 list_del_rcu(&intf->link);
3419 mutex_unlock(&ipmi_interfaces_mutex);
3420 synchronize_srcu(&ipmi_interfaces_srcu);
3421 cleanup_srcu_struct(&intf->users_srcu);
3422 kref_put(&intf->refcount, intf_free);
3417 3423
3418 return rv; 3424 return rv;
3419} 3425}
@@ -3504,7 +3510,8 @@ void ipmi_unregister_smi(struct ipmi_smi *intf)
3504 } 3510 }
3505 srcu_read_unlock(&intf->users_srcu, index); 3511 srcu_read_unlock(&intf->users_srcu, index);
3506 3512
3507 intf->handlers->shutdown(intf->send_info); 3513 if (intf->handlers->shutdown)
3514 intf->handlers->shutdown(intf->send_info);
3508 3515
3509 cleanup_smi_msgs(intf); 3516 cleanup_smi_msgs(intf);
3510 3517
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 90ec010bffbd..5faa917df1b6 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2083,18 +2083,9 @@ static int try_smi_init(struct smi_info *new_smi)
2083 si_to_str[new_smi->io.si_type]); 2083 si_to_str[new_smi->io.si_type]);
2084 2084
2085 WARN_ON(new_smi->io.dev->init_name != NULL); 2085 WARN_ON(new_smi->io.dev->init_name != NULL);
2086 kfree(init_name);
2087
2088 return 0;
2089
2090out_err:
2091 if (new_smi->intf) {
2092 ipmi_unregister_smi(new_smi->intf);
2093 new_smi->intf = NULL;
2094 }
2095 2086
2087 out_err:
2096 kfree(init_name); 2088 kfree(init_name);
2097
2098 return rv; 2089 return rv;
2099} 2090}
2100 2091
@@ -2227,6 +2218,8 @@ static void shutdown_smi(void *send_info)
2227 2218
2228 kfree(smi_info->si_sm); 2219 kfree(smi_info->si_sm);
2229 smi_info->si_sm = NULL; 2220 smi_info->si_sm = NULL;
2221
2222 smi_info->intf = NULL;
2230} 2223}
2231 2224
2232/* 2225/*
@@ -2240,10 +2233,8 @@ static void cleanup_one_si(struct smi_info *smi_info)
2240 2233
2241 list_del(&smi_info->link); 2234 list_del(&smi_info->link);
2242 2235
2243 if (smi_info->intf) { 2236 if (smi_info->intf)
2244 ipmi_unregister_smi(smi_info->intf); 2237 ipmi_unregister_smi(smi_info->intf);
2245 smi_info->intf = NULL;
2246 }
2247 2238
2248 if (smi_info->pdev) { 2239 if (smi_info->pdev) {
2249 if (smi_info->pdev_registered) 2240 if (smi_info->pdev_registered)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index 18e4650c233b..29e67a80fb20 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -181,6 +181,8 @@ struct ssif_addr_info {
181 struct device *dev; 181 struct device *dev;
182 struct i2c_client *client; 182 struct i2c_client *client;
183 183
184 struct i2c_client *added_client;
185
184 struct mutex clients_mutex; 186 struct mutex clients_mutex;
185 struct list_head clients; 187 struct list_head clients;
186 188
@@ -1214,18 +1216,11 @@ static void shutdown_ssif(void *send_info)
1214 complete(&ssif_info->wake_thread); 1216 complete(&ssif_info->wake_thread);
1215 kthread_stop(ssif_info->thread); 1217 kthread_stop(ssif_info->thread);
1216 } 1218 }
1217
1218 /*
1219 * No message can be outstanding now, we have removed the
1220 * upper layer and it permitted us to do so.
1221 */
1222 kfree(ssif_info);
1223} 1219}
1224 1220
1225static int ssif_remove(struct i2c_client *client) 1221static int ssif_remove(struct i2c_client *client)
1226{ 1222{
1227 struct ssif_info *ssif_info = i2c_get_clientdata(client); 1223 struct ssif_info *ssif_info = i2c_get_clientdata(client);
1228 struct ipmi_smi *intf;
1229 struct ssif_addr_info *addr_info; 1224 struct ssif_addr_info *addr_info;
1230 1225
1231 if (!ssif_info) 1226 if (!ssif_info)
@@ -1235,9 +1230,7 @@ static int ssif_remove(struct i2c_client *client)
1235 * After this point, we won't deliver anything asychronously 1230 * After this point, we won't deliver anything asychronously
1236 * to the message handler. We can unregister ourself. 1231 * to the message handler. We can unregister ourself.
1237 */ 1232 */
1238 intf = ssif_info->intf; 1233 ipmi_unregister_smi(ssif_info->intf);
1239 ssif_info->intf = NULL;
1240 ipmi_unregister_smi(intf);
1241 1234
1242 list_for_each_entry(addr_info, &ssif_infos, link) { 1235 list_for_each_entry(addr_info, &ssif_infos, link) {
1243 if (addr_info->client == client) { 1236 if (addr_info->client == client) {
@@ -1246,6 +1239,8 @@ static int ssif_remove(struct i2c_client *client)
1246 } 1239 }
1247 } 1240 }
1248 1241
1242 kfree(ssif_info);
1243
1249 return 0; 1244 return 0;
1250} 1245}
1251 1246
@@ -1648,15 +1643,9 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id)
1648 1643
1649 out: 1644 out:
1650 if (rv) { 1645 if (rv) {
1651 /* 1646 if (addr_info)
1652 * Note that if addr_info->client is assigned, we 1647 addr_info->client = NULL;
1653 * leave it. The i2c client hangs around even if we 1648
1654 * return a failure here, and the failure here is not
1655 * propagated back to the i2c code. This seems to be
1656 * design intent, strange as it may be. But if we
1657 * don't leave it, ssif_platform_remove will not remove
1658 * the client like it should.
1659 */
1660 dev_err(&client->dev, "Unable to start IPMI SSIF: %d\n", rv); 1649 dev_err(&client->dev, "Unable to start IPMI SSIF: %d\n", rv);
1661 kfree(ssif_info); 1650 kfree(ssif_info);
1662 } 1651 }
@@ -1676,7 +1665,8 @@ static int ssif_adapter_handler(struct device *adev, void *opaque)
1676 if (adev->type != &i2c_adapter_type) 1665 if (adev->type != &i2c_adapter_type)
1677 return 0; 1666 return 0;
1678 1667
1679 i2c_new_device(to_i2c_adapter(adev), &addr_info->binfo); 1668 addr_info->added_client = i2c_new_device(to_i2c_adapter(adev),
1669 &addr_info->binfo);
1680 1670
1681 if (!addr_info->adapter_name) 1671 if (!addr_info->adapter_name)
1682 return 1; /* Only try the first I2C adapter by default. */ 1672 return 1; /* Only try the first I2C adapter by default. */
@@ -1849,7 +1839,7 @@ static int ssif_platform_remove(struct platform_device *dev)
1849 return 0; 1839 return 0;
1850 1840
1851 mutex_lock(&ssif_infos_mutex); 1841 mutex_lock(&ssif_infos_mutex);
1852 i2c_unregister_device(addr_info->client); 1842 i2c_unregister_device(addr_info->added_client);
1853 1843
1854 list_del(&addr_info->link); 1844 list_del(&addr_info->link);
1855 kfree(addr_info); 1845 kfree(addr_info);
diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c
index bb882ab161fe..e6124bd548df 100644
--- a/drivers/char/ipmi/kcs_bmc.c
+++ b/drivers/char/ipmi/kcs_bmc.c
@@ -16,6 +16,8 @@
16 16
17#include "kcs_bmc.h" 17#include "kcs_bmc.h"
18 18
19#define DEVICE_NAME "ipmi-kcs"
20
19#define KCS_MSG_BUFSIZ 1000 21#define KCS_MSG_BUFSIZ 1000
20 22
21#define KCS_ZERO_DATA 0 23#define KCS_ZERO_DATA 0
@@ -429,8 +431,6 @@ struct kcs_bmc *kcs_bmc_alloc(struct device *dev, int sizeof_priv, u32 channel)
429 if (!kcs_bmc) 431 if (!kcs_bmc)
430 return NULL; 432 return NULL;
431 433
432 dev_set_name(dev, "ipmi-kcs%u", channel);
433
434 spin_lock_init(&kcs_bmc->lock); 434 spin_lock_init(&kcs_bmc->lock);
435 kcs_bmc->channel = channel; 435 kcs_bmc->channel = channel;
436 436
@@ -444,7 +444,8 @@ struct kcs_bmc *kcs_bmc_alloc(struct device *dev, int sizeof_priv, u32 channel)
444 return NULL; 444 return NULL;
445 445
446 kcs_bmc->miscdev.minor = MISC_DYNAMIC_MINOR; 446 kcs_bmc->miscdev.minor = MISC_DYNAMIC_MINOR;
447 kcs_bmc->miscdev.name = dev_name(dev); 447 kcs_bmc->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%u",
448 DEVICE_NAME, channel);
448 kcs_bmc->miscdev.fops = &kcs_bmc_fops; 449 kcs_bmc->miscdev.fops = &kcs_bmc_fops;
449 450
450 return kcs_bmc; 451 return kcs_bmc;
diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
index 08ef69945ffb..d977193842df 100644
--- a/drivers/clk/x86/clk-pmc-atom.c
+++ b/drivers/clk/x86/clk-pmc-atom.c
@@ -55,6 +55,7 @@ struct clk_plt_data {
55 u8 nparents; 55 u8 nparents;
56 struct clk_plt *clks[PMC_CLK_NUM]; 56 struct clk_plt *clks[PMC_CLK_NUM];
57 struct clk_lookup *mclk_lookup; 57 struct clk_lookup *mclk_lookup;
58 struct clk_lookup *ether_clk_lookup;
58}; 59};
59 60
60/* Return an index in parent table */ 61/* Return an index in parent table */
@@ -186,13 +187,6 @@ static struct clk_plt *plt_clk_register(struct platform_device *pdev, int id,
186 pclk->reg = base + PMC_CLK_CTL_OFFSET + id * PMC_CLK_CTL_SIZE; 187 pclk->reg = base + PMC_CLK_CTL_OFFSET + id * PMC_CLK_CTL_SIZE;
187 spin_lock_init(&pclk->lock); 188 spin_lock_init(&pclk->lock);
188 189
189 /*
190 * If the clock was already enabled by the firmware mark it as critical
191 * to avoid it being gated by the clock framework if no driver owns it.
192 */
193 if (plt_clk_is_enabled(&pclk->hw))
194 init.flags |= CLK_IS_CRITICAL;
195
196 ret = devm_clk_hw_register(&pdev->dev, &pclk->hw); 190 ret = devm_clk_hw_register(&pdev->dev, &pclk->hw);
197 if (ret) { 191 if (ret) {
198 pclk = ERR_PTR(ret); 192 pclk = ERR_PTR(ret);
@@ -351,11 +345,20 @@ static int plt_clk_probe(struct platform_device *pdev)
351 goto err_unreg_clk_plt; 345 goto err_unreg_clk_plt;
352 } 346 }
353 347
348 data->ether_clk_lookup = clkdev_hw_create(&data->clks[4]->hw,
349 "ether_clk", NULL);
350 if (!data->ether_clk_lookup) {
351 err = -ENOMEM;
352 goto err_drop_mclk;
353 }
354
354 plt_clk_free_parent_names_loop(parent_names, data->nparents); 355 plt_clk_free_parent_names_loop(parent_names, data->nparents);
355 356
356 platform_set_drvdata(pdev, data); 357 platform_set_drvdata(pdev, data);
357 return 0; 358 return 0;
358 359
360err_drop_mclk:
361 clkdev_drop(data->mclk_lookup);
359err_unreg_clk_plt: 362err_unreg_clk_plt:
360 plt_clk_unregister_loop(data, i); 363 plt_clk_unregister_loop(data, i);
361 plt_clk_unregister_parents(data); 364 plt_clk_unregister_parents(data);
@@ -369,6 +372,7 @@ static int plt_clk_remove(struct platform_device *pdev)
369 372
370 data = platform_get_drvdata(pdev); 373 data = platform_get_drvdata(pdev);
371 374
375 clkdev_drop(data->ether_clk_lookup);
372 clkdev_drop(data->mclk_lookup); 376 clkdev_drop(data->mclk_lookup);
373 plt_clk_unregister_loop(data, PMC_CLK_NUM); 377 plt_clk_unregister_loop(data, PMC_CLK_NUM);
374 plt_clk_unregister_parents(data); 378 plt_clk_unregister_parents(data);
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index ec8a4376f74f..2fab18fae4fc 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -180,26 +180,29 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node)
180 data->base = of_iomap(node, 0); 180 data->base = of_iomap(node, 0);
181 if (!data->base) { 181 if (!data->base) {
182 pr_err("Could not map PIT address\n"); 182 pr_err("Could not map PIT address\n");
183 return -ENXIO; 183 ret = -ENXIO;
184 goto exit;
184 } 185 }
185 186
186 data->mck = of_clk_get(node, 0); 187 data->mck = of_clk_get(node, 0);
187 if (IS_ERR(data->mck)) { 188 if (IS_ERR(data->mck)) {
188 pr_err("Unable to get mck clk\n"); 189 pr_err("Unable to get mck clk\n");
189 return PTR_ERR(data->mck); 190 ret = PTR_ERR(data->mck);
191 goto exit;
190 } 192 }
191 193
192 ret = clk_prepare_enable(data->mck); 194 ret = clk_prepare_enable(data->mck);
193 if (ret) { 195 if (ret) {
194 pr_err("Unable to enable mck\n"); 196 pr_err("Unable to enable mck\n");
195 return ret; 197 goto exit;
196 } 198 }
197 199
198 /* Get the interrupts property */ 200 /* Get the interrupts property */
199 data->irq = irq_of_parse_and_map(node, 0); 201 data->irq = irq_of_parse_and_map(node, 0);
200 if (!data->irq) { 202 if (!data->irq) {
201 pr_err("Unable to get IRQ from DT\n"); 203 pr_err("Unable to get IRQ from DT\n");
202 return -EINVAL; 204 ret = -EINVAL;
205 goto exit;
203 } 206 }
204 207
205 /* 208 /*
@@ -227,7 +230,7 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node)
227 ret = clocksource_register_hz(&data->clksrc, pit_rate); 230 ret = clocksource_register_hz(&data->clksrc, pit_rate);
228 if (ret) { 231 if (ret) {
229 pr_err("Failed to register clocksource\n"); 232 pr_err("Failed to register clocksource\n");
230 return ret; 233 goto exit;
231 } 234 }
232 235
233 /* Set up irq handler */ 236 /* Set up irq handler */
@@ -236,7 +239,8 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node)
236 "at91_tick", data); 239 "at91_tick", data);
237 if (ret) { 240 if (ret) {
238 pr_err("Unable to setup IRQ\n"); 241 pr_err("Unable to setup IRQ\n");
239 return ret; 242 clocksource_unregister(&data->clksrc);
243 goto exit;
240 } 244 }
241 245
242 /* Set up and register clockevents */ 246 /* Set up and register clockevents */
@@ -254,6 +258,10 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node)
254 clockevents_register_device(&data->clkevt); 258 clockevents_register_device(&data->clkevt);
255 259
256 return 0; 260 return 0;
261
262exit:
263 kfree(data);
264 return ret;
257} 265}
258TIMER_OF_DECLARE(at91sam926x_pit, "atmel,at91sam9260-pit", 266TIMER_OF_DECLARE(at91sam926x_pit, "atmel,at91sam9260-pit",
259 at91sam926x_pit_dt_init); 267 at91sam926x_pit_dt_init);
diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index c020038ebfab..cf93f6419b51 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -130,13 +130,17 @@ static int fttmr010_timer_set_next_event(unsigned long cycles,
130 cr &= ~fttmr010->t1_enable_val; 130 cr &= ~fttmr010->t1_enable_val;
131 writel(cr, fttmr010->base + TIMER_CR); 131 writel(cr, fttmr010->base + TIMER_CR);
132 132
133 /* Setup the match register forward/backward in time */ 133 if (fttmr010->count_down) {
134 cr = readl(fttmr010->base + TIMER1_COUNT); 134 /*
135 if (fttmr010->count_down) 135 * ASPEED Timer Controller will load TIMER1_LOAD register
136 cr -= cycles; 136 * into TIMER1_COUNT register when the timer is re-enabled.
137 else 137 */
138 cr += cycles; 138 writel(cycles, fttmr010->base + TIMER1_LOAD);
139 writel(cr, fttmr010->base + TIMER1_MATCH1); 139 } else {
140 /* Setup the match register forward in time */
141 cr = readl(fttmr010->base + TIMER1_COUNT);
142 writel(cr + cycles, fttmr010->base + TIMER1_MATCH1);
143 }
140 144
141 /* Start */ 145 /* Start */
142 cr = readl(fttmr010->base + TIMER_CR); 146 cr = readl(fttmr010->base + TIMER_CR);
diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
index 29e2e1a78a43..6949a9113dbb 100644
--- a/drivers/clocksource/timer-ti-32k.c
+++ b/drivers/clocksource/timer-ti-32k.c
@@ -97,6 +97,9 @@ static int __init ti_32k_timer_init(struct device_node *np)
97 return -ENXIO; 97 return -ENXIO;
98 } 98 }
99 99
100 if (!of_machine_is_compatible("ti,am43"))
101 ti_32k_timer.cs.flags |= CLOCK_SOURCE_SUSPEND_NONSTOP;
102
100 ti_32k_timer.counter = ti_32k_timer.base; 103 ti_32k_timer.counter = ti_32k_timer.base;
101 104
102 /* 105 /*
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
index a1830fa25fc5..2a3675c24032 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -44,7 +44,7 @@ enum _msm8996_version {
44 44
45struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev; 45struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
46 46
47static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void) 47static enum _msm8996_version qcom_cpufreq_kryo_get_msm_id(void)
48{ 48{
49 size_t len; 49 size_t len;
50 u32 *msm_id; 50 u32 *msm_id;
@@ -222,7 +222,7 @@ static int __init qcom_cpufreq_kryo_init(void)
222} 222}
223module_init(qcom_cpufreq_kryo_init); 223module_init(qcom_cpufreq_kryo_init);
224 224
225static void __init qcom_cpufreq_kryo_exit(void) 225static void __exit qcom_cpufreq_kryo_exit(void)
226{ 226{
227 platform_device_unregister(kryo_cpufreq_pdev); 227 platform_device_unregister(kryo_cpufreq_pdev);
228 platform_driver_unregister(&qcom_cpufreq_kryo_driver); 228 platform_driver_unregister(&qcom_cpufreq_kryo_driver);
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
index d67667970f7e..ec40f991e6c6 100644
--- a/drivers/crypto/caam/caamalg.c
+++ b/drivers/crypto/caam/caamalg.c
@@ -1553,8 +1553,8 @@ static struct ablkcipher_edesc *ablkcipher_edesc_alloc(struct ablkcipher_request
1553 edesc->src_nents = src_nents; 1553 edesc->src_nents = src_nents;
1554 edesc->dst_nents = dst_nents; 1554 edesc->dst_nents = dst_nents;
1555 edesc->sec4_sg_bytes = sec4_sg_bytes; 1555 edesc->sec4_sg_bytes = sec4_sg_bytes;
1556 edesc->sec4_sg = (void *)edesc + sizeof(struct ablkcipher_edesc) + 1556 edesc->sec4_sg = (struct sec4_sg_entry *)((u8 *)edesc->hw_desc +
1557 desc_bytes; 1557 desc_bytes);
1558 edesc->iv_dir = DMA_TO_DEVICE; 1558 edesc->iv_dir = DMA_TO_DEVICE;
1559 1559
1560 /* Make sure IV is located in a DMAable area */ 1560 /* Make sure IV is located in a DMAable area */
@@ -1757,8 +1757,8 @@ static struct ablkcipher_edesc *ablkcipher_giv_edesc_alloc(
1757 edesc->src_nents = src_nents; 1757 edesc->src_nents = src_nents;
1758 edesc->dst_nents = dst_nents; 1758 edesc->dst_nents = dst_nents;
1759 edesc->sec4_sg_bytes = sec4_sg_bytes; 1759 edesc->sec4_sg_bytes = sec4_sg_bytes;
1760 edesc->sec4_sg = (void *)edesc + sizeof(struct ablkcipher_edesc) + 1760 edesc->sec4_sg = (struct sec4_sg_entry *)((u8 *)edesc->hw_desc +
1761 desc_bytes; 1761 desc_bytes);
1762 edesc->iv_dir = DMA_FROM_DEVICE; 1762 edesc->iv_dir = DMA_FROM_DEVICE;
1763 1763
1764 /* Make sure IV is located in a DMAable area */ 1764 /* Make sure IV is located in a DMAable area */
diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
index 218739b961fe..72790d88236d 100644
--- a/drivers/crypto/ccp/psp-dev.c
+++ b/drivers/crypto/ccp/psp-dev.c
@@ -38,6 +38,17 @@ static DEFINE_MUTEX(sev_cmd_mutex);
38static struct sev_misc_dev *misc_dev; 38static struct sev_misc_dev *misc_dev;
39static struct psp_device *psp_master; 39static struct psp_device *psp_master;
40 40
41static int psp_cmd_timeout = 100;
42module_param(psp_cmd_timeout, int, 0644);
43MODULE_PARM_DESC(psp_cmd_timeout, " default timeout value, in seconds, for PSP commands");
44
45static int psp_probe_timeout = 5;
46module_param(psp_probe_timeout, int, 0644);
47MODULE_PARM_DESC(psp_probe_timeout, " default timeout value, in seconds, during PSP device probe");
48
49static bool psp_dead;
50static int psp_timeout;
51
41static struct psp_device *psp_alloc_struct(struct sp_device *sp) 52static struct psp_device *psp_alloc_struct(struct sp_device *sp)
42{ 53{
43 struct device *dev = sp->dev; 54 struct device *dev = sp->dev;
@@ -82,10 +93,19 @@ done:
82 return IRQ_HANDLED; 93 return IRQ_HANDLED;
83} 94}
84 95
85static void sev_wait_cmd_ioc(struct psp_device *psp, unsigned int *reg) 96static int sev_wait_cmd_ioc(struct psp_device *psp,
97 unsigned int *reg, unsigned int timeout)
86{ 98{
87 wait_event(psp->sev_int_queue, psp->sev_int_rcvd); 99 int ret;
100
101 ret = wait_event_timeout(psp->sev_int_queue,
102 psp->sev_int_rcvd, timeout * HZ);
103 if (!ret)
104 return -ETIMEDOUT;
105
88 *reg = ioread32(psp->io_regs + psp->vdata->cmdresp_reg); 106 *reg = ioread32(psp->io_regs + psp->vdata->cmdresp_reg);
107
108 return 0;
89} 109}
90 110
91static int sev_cmd_buffer_len(int cmd) 111static int sev_cmd_buffer_len(int cmd)
@@ -133,12 +153,15 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret)
133 if (!psp) 153 if (!psp)
134 return -ENODEV; 154 return -ENODEV;
135 155
156 if (psp_dead)
157 return -EBUSY;
158
136 /* Get the physical address of the command buffer */ 159 /* Get the physical address of the command buffer */
137 phys_lsb = data ? lower_32_bits(__psp_pa(data)) : 0; 160 phys_lsb = data ? lower_32_bits(__psp_pa(data)) : 0;
138 phys_msb = data ? upper_32_bits(__psp_pa(data)) : 0; 161 phys_msb = data ? upper_32_bits(__psp_pa(data)) : 0;
139 162
140 dev_dbg(psp->dev, "sev command id %#x buffer 0x%08x%08x\n", 163 dev_dbg(psp->dev, "sev command id %#x buffer 0x%08x%08x timeout %us\n",
141 cmd, phys_msb, phys_lsb); 164 cmd, phys_msb, phys_lsb, psp_timeout);
142 165
143 print_hex_dump_debug("(in): ", DUMP_PREFIX_OFFSET, 16, 2, data, 166 print_hex_dump_debug("(in): ", DUMP_PREFIX_OFFSET, 16, 2, data,
144 sev_cmd_buffer_len(cmd), false); 167 sev_cmd_buffer_len(cmd), false);
@@ -154,7 +177,18 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret)
154 iowrite32(reg, psp->io_regs + psp->vdata->cmdresp_reg); 177 iowrite32(reg, psp->io_regs + psp->vdata->cmdresp_reg);
155 178
156 /* wait for command completion */ 179 /* wait for command completion */
157 sev_wait_cmd_ioc(psp, &reg); 180 ret = sev_wait_cmd_ioc(psp, &reg, psp_timeout);
181 if (ret) {
182 if (psp_ret)
183 *psp_ret = 0;
184
185 dev_err(psp->dev, "sev command %#x timed out, disabling PSP \n", cmd);
186 psp_dead = true;
187
188 return ret;
189 }
190
191 psp_timeout = psp_cmd_timeout;
158 192
159 if (psp_ret) 193 if (psp_ret)
160 *psp_ret = reg & PSP_CMDRESP_ERR_MASK; 194 *psp_ret = reg & PSP_CMDRESP_ERR_MASK;
@@ -888,6 +922,8 @@ void psp_pci_init(void)
888 922
889 psp_master = sp->psp_data; 923 psp_master = sp->psp_data;
890 924
925 psp_timeout = psp_probe_timeout;
926
891 if (sev_get_api_version()) 927 if (sev_get_api_version())
892 goto err; 928 goto err;
893 929
diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index 5c539af8ed60..010bbf607797 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -367,7 +367,8 @@ static inline void dsgl_walk_init(struct dsgl_walk *walk,
367 walk->to = (struct phys_sge_pairs *)(dsgl + 1); 367 walk->to = (struct phys_sge_pairs *)(dsgl + 1);
368} 368}
369 369
370static inline void dsgl_walk_end(struct dsgl_walk *walk, unsigned short qid) 370static inline void dsgl_walk_end(struct dsgl_walk *walk, unsigned short qid,
371 int pci_chan_id)
371{ 372{
372 struct cpl_rx_phys_dsgl *phys_cpl; 373 struct cpl_rx_phys_dsgl *phys_cpl;
373 374
@@ -385,6 +386,7 @@ static inline void dsgl_walk_end(struct dsgl_walk *walk, unsigned short qid)
385 phys_cpl->rss_hdr_int.opcode = CPL_RX_PHYS_ADDR; 386 phys_cpl->rss_hdr_int.opcode = CPL_RX_PHYS_ADDR;
386 phys_cpl->rss_hdr_int.qid = htons(qid); 387 phys_cpl->rss_hdr_int.qid = htons(qid);
387 phys_cpl->rss_hdr_int.hash_val = 0; 388 phys_cpl->rss_hdr_int.hash_val = 0;
389 phys_cpl->rss_hdr_int.channel = pci_chan_id;
388} 390}
389 391
390static inline void dsgl_walk_add_page(struct dsgl_walk *walk, 392static inline void dsgl_walk_add_page(struct dsgl_walk *walk,
@@ -718,7 +720,7 @@ static inline void create_wreq(struct chcr_context *ctx,
718 FILL_WR_RX_Q_ID(ctx->dev->rx_channel_id, qid, 720 FILL_WR_RX_Q_ID(ctx->dev->rx_channel_id, qid,
719 !!lcb, ctx->tx_qidx); 721 !!lcb, ctx->tx_qidx);
720 722
721 chcr_req->ulptx.cmd_dest = FILL_ULPTX_CMD_DEST(ctx->dev->tx_channel_id, 723 chcr_req->ulptx.cmd_dest = FILL_ULPTX_CMD_DEST(ctx->tx_chan_id,
722 qid); 724 qid);
723 chcr_req->ulptx.len = htonl((DIV_ROUND_UP(len16, 16) - 725 chcr_req->ulptx.len = htonl((DIV_ROUND_UP(len16, 16) -
724 ((sizeof(chcr_req->wreq)) >> 4))); 726 ((sizeof(chcr_req->wreq)) >> 4)));
@@ -1339,16 +1341,23 @@ static int chcr_device_init(struct chcr_context *ctx)
1339 adap->vres.ncrypto_fc); 1341 adap->vres.ncrypto_fc);
1340 rxq_perchan = u_ctx->lldi.nrxq / u_ctx->lldi.nchan; 1342 rxq_perchan = u_ctx->lldi.nrxq / u_ctx->lldi.nchan;
1341 txq_perchan = ntxq / u_ctx->lldi.nchan; 1343 txq_perchan = ntxq / u_ctx->lldi.nchan;
1342 rxq_idx = ctx->dev->tx_channel_id * rxq_perchan;
1343 rxq_idx += id % rxq_perchan;
1344 txq_idx = ctx->dev->tx_channel_id * txq_perchan;
1345 txq_idx += id % txq_perchan;
1346 spin_lock(&ctx->dev->lock_chcr_dev); 1344 spin_lock(&ctx->dev->lock_chcr_dev);
1347 ctx->rx_qidx = rxq_idx; 1345 ctx->tx_chan_id = ctx->dev->tx_channel_id;
1348 ctx->tx_qidx = txq_idx;
1349 ctx->dev->tx_channel_id = !ctx->dev->tx_channel_id; 1346 ctx->dev->tx_channel_id = !ctx->dev->tx_channel_id;
1350 ctx->dev->rx_channel_id = 0; 1347 ctx->dev->rx_channel_id = 0;
1351 spin_unlock(&ctx->dev->lock_chcr_dev); 1348 spin_unlock(&ctx->dev->lock_chcr_dev);
1349 rxq_idx = ctx->tx_chan_id * rxq_perchan;
1350 rxq_idx += id % rxq_perchan;
1351 txq_idx = ctx->tx_chan_id * txq_perchan;
1352 txq_idx += id % txq_perchan;
1353 ctx->rx_qidx = rxq_idx;
1354 ctx->tx_qidx = txq_idx;
1355 /* Channel Id used by SGE to forward packet to Host.
1356 * Same value should be used in cpl_fw6_pld RSS_CH field
1357 * by FW. Driver programs PCI channel ID to be used in fw
1358 * at the time of queue allocation with value "pi->tx_chan"
1359 */
1360 ctx->pci_chan_id = txq_idx / txq_perchan;
1352 } 1361 }
1353out: 1362out:
1354 return err; 1363 return err;
@@ -2503,6 +2512,7 @@ void chcr_add_aead_dst_ent(struct aead_request *req,
2503 struct crypto_aead *tfm = crypto_aead_reqtfm(req); 2512 struct crypto_aead *tfm = crypto_aead_reqtfm(req);
2504 struct dsgl_walk dsgl_walk; 2513 struct dsgl_walk dsgl_walk;
2505 unsigned int authsize = crypto_aead_authsize(tfm); 2514 unsigned int authsize = crypto_aead_authsize(tfm);
2515 struct chcr_context *ctx = a_ctx(tfm);
2506 u32 temp; 2516 u32 temp;
2507 2517
2508 dsgl_walk_init(&dsgl_walk, phys_cpl); 2518 dsgl_walk_init(&dsgl_walk, phys_cpl);
@@ -2512,7 +2522,7 @@ void chcr_add_aead_dst_ent(struct aead_request *req,
2512 dsgl_walk_add_page(&dsgl_walk, IV, &reqctx->iv_dma); 2522 dsgl_walk_add_page(&dsgl_walk, IV, &reqctx->iv_dma);
2513 temp = req->cryptlen + (reqctx->op ? -authsize : authsize); 2523 temp = req->cryptlen + (reqctx->op ? -authsize : authsize);
2514 dsgl_walk_add_sg(&dsgl_walk, req->dst, temp, req->assoclen); 2524 dsgl_walk_add_sg(&dsgl_walk, req->dst, temp, req->assoclen);
2515 dsgl_walk_end(&dsgl_walk, qid); 2525 dsgl_walk_end(&dsgl_walk, qid, ctx->pci_chan_id);
2516} 2526}
2517 2527
2518void chcr_add_cipher_src_ent(struct ablkcipher_request *req, 2528void chcr_add_cipher_src_ent(struct ablkcipher_request *req,
@@ -2544,6 +2554,8 @@ void chcr_add_cipher_dst_ent(struct ablkcipher_request *req,
2544 unsigned short qid) 2554 unsigned short qid)
2545{ 2555{
2546 struct chcr_blkcipher_req_ctx *reqctx = ablkcipher_request_ctx(req); 2556 struct chcr_blkcipher_req_ctx *reqctx = ablkcipher_request_ctx(req);
2557 struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(wrparam->req);
2558 struct chcr_context *ctx = c_ctx(tfm);
2547 struct dsgl_walk dsgl_walk; 2559 struct dsgl_walk dsgl_walk;
2548 2560
2549 dsgl_walk_init(&dsgl_walk, phys_cpl); 2561 dsgl_walk_init(&dsgl_walk, phys_cpl);
@@ -2552,7 +2564,7 @@ void chcr_add_cipher_dst_ent(struct ablkcipher_request *req,
2552 reqctx->dstsg = dsgl_walk.last_sg; 2564 reqctx->dstsg = dsgl_walk.last_sg;
2553 reqctx->dst_ofst = dsgl_walk.last_sg_len; 2565 reqctx->dst_ofst = dsgl_walk.last_sg_len;
2554 2566
2555 dsgl_walk_end(&dsgl_walk, qid); 2567 dsgl_walk_end(&dsgl_walk, qid, ctx->pci_chan_id);
2556} 2568}
2557 2569
2558void chcr_add_hash_src_ent(struct ahash_request *req, 2570void chcr_add_hash_src_ent(struct ahash_request *req,
diff --git a/drivers/crypto/chelsio/chcr_crypto.h b/drivers/crypto/chelsio/chcr_crypto.h
index 54835cb109e5..0d2c70c344f3 100644
--- a/drivers/crypto/chelsio/chcr_crypto.h
+++ b/drivers/crypto/chelsio/chcr_crypto.h
@@ -255,6 +255,8 @@ struct chcr_context {
255 struct chcr_dev *dev; 255 struct chcr_dev *dev;
256 unsigned char tx_qidx; 256 unsigned char tx_qidx;
257 unsigned char rx_qidx; 257 unsigned char rx_qidx;
258 unsigned char tx_chan_id;
259 unsigned char pci_chan_id;
258 struct __crypto_ctx crypto_ctx[0]; 260 struct __crypto_ctx crypto_ctx[0];
259}; 261};
260 262
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 7e71043457a6..86c699c14f84 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1044,7 +1044,8 @@ static int safexcel_probe(struct platform_device *pdev)
1044 1044
1045 safexcel_configure(priv); 1045 safexcel_configure(priv);
1046 1046
1047 priv->ring = devm_kzalloc(dev, priv->config.rings * sizeof(*priv->ring), 1047 priv->ring = devm_kcalloc(dev, priv->config.rings,
1048 sizeof(*priv->ring),
1048 GFP_KERNEL); 1049 GFP_KERNEL);
1049 if (!priv->ring) { 1050 if (!priv->ring) {
1050 ret = -ENOMEM; 1051 ret = -ENOMEM;
@@ -1063,8 +1064,9 @@ static int safexcel_probe(struct platform_device *pdev)
1063 if (ret) 1064 if (ret)
1064 goto err_reg_clk; 1065 goto err_reg_clk;
1065 1066
1066 priv->ring[i].rdr_req = devm_kzalloc(dev, 1067 priv->ring[i].rdr_req = devm_kcalloc(dev,
1067 sizeof(priv->ring[i].rdr_req) * EIP197_DEFAULT_RING_SIZE, 1068 EIP197_DEFAULT_RING_SIZE,
1069 sizeof(priv->ring[i].rdr_req),
1068 GFP_KERNEL); 1070 GFP_KERNEL);
1069 if (!priv->ring[i].rdr_req) { 1071 if (!priv->ring[i].rdr_req) {
1070 ret = -ENOMEM; 1072 ret = -ENOMEM;
diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c
index a10c418d4e5c..56bd28174f52 100644
--- a/drivers/crypto/mxs-dcp.c
+++ b/drivers/crypto/mxs-dcp.c
@@ -63,7 +63,7 @@ struct dcp {
63 struct dcp_coherent_block *coh; 63 struct dcp_coherent_block *coh;
64 64
65 struct completion completion[DCP_MAX_CHANS]; 65 struct completion completion[DCP_MAX_CHANS];
66 struct mutex mutex[DCP_MAX_CHANS]; 66 spinlock_t lock[DCP_MAX_CHANS];
67 struct task_struct *thread[DCP_MAX_CHANS]; 67 struct task_struct *thread[DCP_MAX_CHANS];
68 struct crypto_queue queue[DCP_MAX_CHANS]; 68 struct crypto_queue queue[DCP_MAX_CHANS];
69}; 69};
@@ -349,13 +349,20 @@ static int dcp_chan_thread_aes(void *data)
349 349
350 int ret; 350 int ret;
351 351
352 do { 352 while (!kthread_should_stop()) {
353 __set_current_state(TASK_INTERRUPTIBLE); 353 set_current_state(TASK_INTERRUPTIBLE);
354 354
355 mutex_lock(&sdcp->mutex[chan]); 355 spin_lock(&sdcp->lock[chan]);
356 backlog = crypto_get_backlog(&sdcp->queue[chan]); 356 backlog = crypto_get_backlog(&sdcp->queue[chan]);
357 arq = crypto_dequeue_request(&sdcp->queue[chan]); 357 arq = crypto_dequeue_request(&sdcp->queue[chan]);
358 mutex_unlock(&sdcp->mutex[chan]); 358 spin_unlock(&sdcp->lock[chan]);
359
360 if (!backlog && !arq) {
361 schedule();
362 continue;
363 }
364
365 set_current_state(TASK_RUNNING);
359 366
360 if (backlog) 367 if (backlog)
361 backlog->complete(backlog, -EINPROGRESS); 368 backlog->complete(backlog, -EINPROGRESS);
@@ -363,11 +370,8 @@ static int dcp_chan_thread_aes(void *data)
363 if (arq) { 370 if (arq) {
364 ret = mxs_dcp_aes_block_crypt(arq); 371 ret = mxs_dcp_aes_block_crypt(arq);
365 arq->complete(arq, ret); 372 arq->complete(arq, ret);
366 continue;
367 } 373 }
368 374 }
369 schedule();
370 } while (!kthread_should_stop());
371 375
372 return 0; 376 return 0;
373} 377}
@@ -409,9 +413,9 @@ static int mxs_dcp_aes_enqueue(struct ablkcipher_request *req, int enc, int ecb)
409 rctx->ecb = ecb; 413 rctx->ecb = ecb;
410 actx->chan = DCP_CHAN_CRYPTO; 414 actx->chan = DCP_CHAN_CRYPTO;
411 415
412 mutex_lock(&sdcp->mutex[actx->chan]); 416 spin_lock(&sdcp->lock[actx->chan]);
413 ret = crypto_enqueue_request(&sdcp->queue[actx->chan], &req->base); 417 ret = crypto_enqueue_request(&sdcp->queue[actx->chan], &req->base);
414 mutex_unlock(&sdcp->mutex[actx->chan]); 418 spin_unlock(&sdcp->lock[actx->chan]);
415 419
416 wake_up_process(sdcp->thread[actx->chan]); 420 wake_up_process(sdcp->thread[actx->chan]);
417 421
@@ -640,13 +644,20 @@ static int dcp_chan_thread_sha(void *data)
640 struct ahash_request *req; 644 struct ahash_request *req;
641 int ret, fini; 645 int ret, fini;
642 646
643 do { 647 while (!kthread_should_stop()) {
644 __set_current_state(TASK_INTERRUPTIBLE); 648 set_current_state(TASK_INTERRUPTIBLE);
645 649
646 mutex_lock(&sdcp->mutex[chan]); 650 spin_lock(&sdcp->lock[chan]);
647 backlog = crypto_get_backlog(&sdcp->queue[chan]); 651 backlog = crypto_get_backlog(&sdcp->queue[chan]);
648 arq = crypto_dequeue_request(&sdcp->queue[chan]); 652 arq = crypto_dequeue_request(&sdcp->queue[chan]);
649 mutex_unlock(&sdcp->mutex[chan]); 653 spin_unlock(&sdcp->lock[chan]);
654
655 if (!backlog && !arq) {
656 schedule();
657 continue;
658 }
659
660 set_current_state(TASK_RUNNING);
650 661
651 if (backlog) 662 if (backlog)
652 backlog->complete(backlog, -EINPROGRESS); 663 backlog->complete(backlog, -EINPROGRESS);
@@ -658,12 +669,8 @@ static int dcp_chan_thread_sha(void *data)
658 ret = dcp_sha_req_to_buf(arq); 669 ret = dcp_sha_req_to_buf(arq);
659 fini = rctx->fini; 670 fini = rctx->fini;
660 arq->complete(arq, ret); 671 arq->complete(arq, ret);
661 if (!fini)
662 continue;
663 } 672 }
664 673 }
665 schedule();
666 } while (!kthread_should_stop());
667 674
668 return 0; 675 return 0;
669} 676}
@@ -721,9 +728,9 @@ static int dcp_sha_update_fx(struct ahash_request *req, int fini)
721 rctx->init = 1; 728 rctx->init = 1;
722 } 729 }
723 730
724 mutex_lock(&sdcp->mutex[actx->chan]); 731 spin_lock(&sdcp->lock[actx->chan]);
725 ret = crypto_enqueue_request(&sdcp->queue[actx->chan], &req->base); 732 ret = crypto_enqueue_request(&sdcp->queue[actx->chan], &req->base);
726 mutex_unlock(&sdcp->mutex[actx->chan]); 733 spin_unlock(&sdcp->lock[actx->chan]);
727 734
728 wake_up_process(sdcp->thread[actx->chan]); 735 wake_up_process(sdcp->thread[actx->chan]);
729 mutex_unlock(&actx->mutex); 736 mutex_unlock(&actx->mutex);
@@ -997,7 +1004,7 @@ static int mxs_dcp_probe(struct platform_device *pdev)
997 platform_set_drvdata(pdev, sdcp); 1004 platform_set_drvdata(pdev, sdcp);
998 1005
999 for (i = 0; i < DCP_MAX_CHANS; i++) { 1006 for (i = 0; i < DCP_MAX_CHANS; i++) {
1000 mutex_init(&sdcp->mutex[i]); 1007 spin_lock_init(&sdcp->lock[i]);
1001 init_completion(&sdcp->completion[i]); 1008 init_completion(&sdcp->completion[i]);
1002 crypto_init_queue(&sdcp->queue[i], 50); 1009 crypto_init_queue(&sdcp->queue[i], 50);
1003 } 1010 }
diff --git a/drivers/crypto/qat/qat_c3xxx/adf_drv.c b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
index ba197f34c252..763c2166ee0e 100644
--- a/drivers/crypto/qat/qat_c3xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
@@ -123,7 +123,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
123 struct adf_hw_device_data *hw_data; 123 struct adf_hw_device_data *hw_data;
124 char name[ADF_DEVICE_NAME_LENGTH]; 124 char name[ADF_DEVICE_NAME_LENGTH];
125 unsigned int i, bar_nr; 125 unsigned int i, bar_nr;
126 int ret, bar_mask; 126 unsigned long bar_mask;
127 int ret;
127 128
128 switch (ent->device) { 129 switch (ent->device) {
129 case ADF_C3XXX_PCI_DEVICE_ID: 130 case ADF_C3XXX_PCI_DEVICE_ID:
@@ -235,8 +236,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
235 /* Find and map all the device's BARS */ 236 /* Find and map all the device's BARS */
236 i = 0; 237 i = 0;
237 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM); 238 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
238 for_each_set_bit(bar_nr, (const unsigned long *)&bar_mask, 239 for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
239 ADF_PCI_MAX_BARS * 2) {
240 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++]; 240 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
241 241
242 bar->base_addr = pci_resource_start(pdev, bar_nr); 242 bar->base_addr = pci_resource_start(pdev, bar_nr);
diff --git a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
index 24ec908eb26c..613c7d5644ce 100644
--- a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
@@ -125,7 +125,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
125 struct adf_hw_device_data *hw_data; 125 struct adf_hw_device_data *hw_data;
126 char name[ADF_DEVICE_NAME_LENGTH]; 126 char name[ADF_DEVICE_NAME_LENGTH];
127 unsigned int i, bar_nr; 127 unsigned int i, bar_nr;
128 int ret, bar_mask; 128 unsigned long bar_mask;
129 int ret;
129 130
130 switch (ent->device) { 131 switch (ent->device) {
131 case ADF_C3XXXIOV_PCI_DEVICE_ID: 132 case ADF_C3XXXIOV_PCI_DEVICE_ID:
@@ -215,8 +216,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
215 /* Find and map all the device's BARS */ 216 /* Find and map all the device's BARS */
216 i = 0; 217 i = 0;
217 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM); 218 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
218 for_each_set_bit(bar_nr, (const unsigned long *)&bar_mask, 219 for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
219 ADF_PCI_MAX_BARS * 2) {
220 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++]; 220 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
221 221
222 bar->base_addr = pci_resource_start(pdev, bar_nr); 222 bar->base_addr = pci_resource_start(pdev, bar_nr);
diff --git a/drivers/crypto/qat/qat_c62x/adf_drv.c b/drivers/crypto/qat/qat_c62x/adf_drv.c
index 59a5a0df50b6..9cb832963357 100644
--- a/drivers/crypto/qat/qat_c62x/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62x/adf_drv.c
@@ -123,7 +123,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
123 struct adf_hw_device_data *hw_data; 123 struct adf_hw_device_data *hw_data;
124 char name[ADF_DEVICE_NAME_LENGTH]; 124 char name[ADF_DEVICE_NAME_LENGTH];
125 unsigned int i, bar_nr; 125 unsigned int i, bar_nr;
126 int ret, bar_mask; 126 unsigned long bar_mask;
127 int ret;
127 128
128 switch (ent->device) { 129 switch (ent->device) {
129 case ADF_C62X_PCI_DEVICE_ID: 130 case ADF_C62X_PCI_DEVICE_ID:
@@ -235,8 +236,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
235 /* Find and map all the device's BARS */ 236 /* Find and map all the device's BARS */
236 i = (hw_data->fuses & ADF_DEVICE_FUSECTL_MASK) ? 1 : 0; 237 i = (hw_data->fuses & ADF_DEVICE_FUSECTL_MASK) ? 1 : 0;
237 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM); 238 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
238 for_each_set_bit(bar_nr, (const unsigned long *)&bar_mask, 239 for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
239 ADF_PCI_MAX_BARS * 2) {
240 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++]; 240 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
241 241
242 bar->base_addr = pci_resource_start(pdev, bar_nr); 242 bar->base_addr = pci_resource_start(pdev, bar_nr);
diff --git a/drivers/crypto/qat/qat_c62xvf/adf_drv.c b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
index b9f3e0e4fde9..278452b8ef81 100644
--- a/drivers/crypto/qat/qat_c62xvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
@@ -125,7 +125,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
125 struct adf_hw_device_data *hw_data; 125 struct adf_hw_device_data *hw_data;
126 char name[ADF_DEVICE_NAME_LENGTH]; 126 char name[ADF_DEVICE_NAME_LENGTH];
127 unsigned int i, bar_nr; 127 unsigned int i, bar_nr;
128 int ret, bar_mask; 128 unsigned long bar_mask;
129 int ret;
129 130
130 switch (ent->device) { 131 switch (ent->device) {
131 case ADF_C62XIOV_PCI_DEVICE_ID: 132 case ADF_C62XIOV_PCI_DEVICE_ID:
@@ -215,8 +216,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
215 /* Find and map all the device's BARS */ 216 /* Find and map all the device's BARS */
216 i = 0; 217 i = 0;
217 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM); 218 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
218 for_each_set_bit(bar_nr, (const unsigned long *)&bar_mask, 219 for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
219 ADF_PCI_MAX_BARS * 2) {
220 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++]; 220 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
221 221
222 bar->base_addr = pci_resource_start(pdev, bar_nr); 222 bar->base_addr = pci_resource_start(pdev, bar_nr);
diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index be5c5a988ca5..3a9708ef4ce2 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -123,7 +123,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
123 struct adf_hw_device_data *hw_data; 123 struct adf_hw_device_data *hw_data;
124 char name[ADF_DEVICE_NAME_LENGTH]; 124 char name[ADF_DEVICE_NAME_LENGTH];
125 unsigned int i, bar_nr; 125 unsigned int i, bar_nr;
126 int ret, bar_mask; 126 unsigned long bar_mask;
127 int ret;
127 128
128 switch (ent->device) { 129 switch (ent->device) {
129 case ADF_DH895XCC_PCI_DEVICE_ID: 130 case ADF_DH895XCC_PCI_DEVICE_ID:
@@ -237,8 +238,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
237 /* Find and map all the device's BARS */ 238 /* Find and map all the device's BARS */
238 i = 0; 239 i = 0;
239 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM); 240 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
240 for_each_set_bit(bar_nr, (const unsigned long *)&bar_mask, 241 for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
241 ADF_PCI_MAX_BARS * 2) {
242 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++]; 242 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
243 243
244 bar->base_addr = pci_resource_start(pdev, bar_nr); 244 bar->base_addr = pci_resource_start(pdev, bar_nr);
diff --git a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
index 26ab17bfc6da..3da0f951cb59 100644
--- a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
@@ -125,7 +125,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
125 struct adf_hw_device_data *hw_data; 125 struct adf_hw_device_data *hw_data;
126 char name[ADF_DEVICE_NAME_LENGTH]; 126 char name[ADF_DEVICE_NAME_LENGTH];
127 unsigned int i, bar_nr; 127 unsigned int i, bar_nr;
128 int ret, bar_mask; 128 unsigned long bar_mask;
129 int ret;
129 130
130 switch (ent->device) { 131 switch (ent->device) {
131 case ADF_DH895XCCIOV_PCI_DEVICE_ID: 132 case ADF_DH895XCCIOV_PCI_DEVICE_ID:
@@ -215,8 +216,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
215 /* Find and map all the device's BARS */ 216 /* Find and map all the device's BARS */
216 i = 0; 217 i = 0;
217 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM); 218 bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
218 for_each_set_bit(bar_nr, (const unsigned long *)&bar_mask, 219 for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
219 ADF_PCI_MAX_BARS * 2) {
220 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++]; 220 struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
221 221
222 bar->base_addr = pci_resource_start(pdev, bar_nr); 222 bar->base_addr = pci_resource_start(pdev, bar_nr);
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index bbe4d72ca105..948806e57cee 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -535,6 +535,11 @@ static unsigned long dax_get_unmapped_area(struct file *filp,
535 return current->mm->get_unmapped_area(filp, addr, len, pgoff, flags); 535 return current->mm->get_unmapped_area(filp, addr, len, pgoff, flags);
536} 536}
537 537
538static const struct address_space_operations dev_dax_aops = {
539 .set_page_dirty = noop_set_page_dirty,
540 .invalidatepage = noop_invalidatepage,
541};
542
538static int dax_open(struct inode *inode, struct file *filp) 543static int dax_open(struct inode *inode, struct file *filp)
539{ 544{
540 struct dax_device *dax_dev = inode_dax(inode); 545 struct dax_device *dax_dev = inode_dax(inode);
@@ -544,6 +549,7 @@ static int dax_open(struct inode *inode, struct file *filp)
544 dev_dbg(&dev_dax->dev, "trace\n"); 549 dev_dbg(&dev_dax->dev, "trace\n");
545 inode->i_mapping = __dax_inode->i_mapping; 550 inode->i_mapping = __dax_inode->i_mapping;
546 inode->i_mapping->host = __dax_inode; 551 inode->i_mapping->host = __dax_inode;
552 inode->i_mapping->a_ops = &dev_dax_aops;
547 filp->f_mapping = inode->i_mapping; 553 filp->f_mapping = inode->i_mapping;
548 filp->f_wb_err = filemap_sample_wb_err(filp->f_mapping); 554 filp->f_wb_err = filemap_sample_wb_err(filp->f_mapping);
549 filp->private_data = dev_dax; 555 filp->private_data = dev_dax;
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index b76cb17d879c..adfd316db1a8 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -639,7 +639,7 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
639 int ret; 639 int ret;
640 struct device *dev = &mbdev->dev; 640 struct device *dev = &mbdev->dev;
641 641
642 mic_dma_dev = kzalloc(sizeof(*mic_dma_dev), GFP_KERNEL); 642 mic_dma_dev = devm_kzalloc(dev, sizeof(*mic_dma_dev), GFP_KERNEL);
643 if (!mic_dma_dev) { 643 if (!mic_dma_dev) {
644 ret = -ENOMEM; 644 ret = -ENOMEM;
645 goto alloc_error; 645 goto alloc_error;
@@ -664,7 +664,6 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
664reg_error: 664reg_error:
665 mic_dma_uninit(mic_dma_dev); 665 mic_dma_uninit(mic_dma_dev);
666init_error: 666init_error:
667 kfree(mic_dma_dev);
668 mic_dma_dev = NULL; 667 mic_dma_dev = NULL;
669alloc_error: 668alloc_error:
670 dev_err(dev, "Error at %s %d ret=%d\n", __func__, __LINE__, ret); 669 dev_err(dev, "Error at %s %d ret=%d\n", __func__, __LINE__, ret);
@@ -674,7 +673,6 @@ alloc_error:
674static void mic_dma_dev_unreg(struct mic_dma_device *mic_dma_dev) 673static void mic_dma_dev_unreg(struct mic_dma_device *mic_dma_dev)
675{ 674{
676 mic_dma_uninit(mic_dma_dev); 675 mic_dma_uninit(mic_dma_dev);
677 kfree(mic_dma_dev);
678} 676}
679 677
680/* DEBUGFS CODE */ 678/* DEBUGFS CODE */
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index d8e159feb573..89110dfc7127 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -90,14 +90,17 @@ config EFI_ARMSTUB
90config EFI_ARMSTUB_DTB_LOADER 90config EFI_ARMSTUB_DTB_LOADER
91 bool "Enable the DTB loader" 91 bool "Enable the DTB loader"
92 depends on EFI_ARMSTUB 92 depends on EFI_ARMSTUB
93 default y
93 help 94 help
94 Select this config option to add support for the dtb= command 95 Select this config option to add support for the dtb= command
95 line parameter, allowing a device tree blob to be loaded into 96 line parameter, allowing a device tree blob to be loaded into
96 memory from the EFI System Partition by the stub. 97 memory from the EFI System Partition by the stub.
97 98
98 The device tree is typically provided by the platform or by 99 If the device tree is provided by the platform or by
99 the bootloader, so this option is mostly for development 100 the bootloader this option may not be needed.
100 purposes only. 101 But, for various development reasons and to maintain existing
102 functionality for bootloaders that do not have such support
103 this option is necessary.
101 104
102config EFI_BOOTLOADER_CONTROL 105config EFI_BOOTLOADER_CONTROL
103 tristate "EFI Bootloader Control" 106 tristate "EFI Bootloader Control"
diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
index fc9fd2d0482f..0b840531ef33 100644
--- a/drivers/fpga/dfl-fme-pr.c
+++ b/drivers/fpga/dfl-fme-pr.c
@@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
420 /* Create region for each port */ 420 /* Create region for each port */
421 fme_region = dfl_fme_create_region(pdata, mgr, 421 fme_region = dfl_fme_create_region(pdata, mgr,
422 fme_br->br, i); 422 fme_br->br, i);
423 if (!fme_region) { 423 if (IS_ERR(fme_region)) {
424 ret = PTR_ERR(fme_region); 424 ret = PTR_ERR(fme_region);
425 goto destroy_region; 425 goto destroy_region;
426 } 426 }
diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
index 0b7e19c27c6d..51a5ac2293a7 100644
--- a/drivers/fpga/dfl-fme-region.c
+++ b/drivers/fpga/dfl-fme-region.c
@@ -14,6 +14,7 @@
14 */ 14 */
15 15
16#include <linux/module.h> 16#include <linux/module.h>
17#include <linux/fpga/fpga-mgr.h>
17#include <linux/fpga/fpga-region.h> 18#include <linux/fpga/fpga-region.h>
18 19
19#include "dfl-fme-pr.h" 20#include "dfl-fme-pr.h"
@@ -66,9 +67,10 @@ eprobe_mgr_put:
66static int fme_region_remove(struct platform_device *pdev) 67static int fme_region_remove(struct platform_device *pdev)
67{ 68{
68 struct fpga_region *region = dev_get_drvdata(&pdev->dev); 69 struct fpga_region *region = dev_get_drvdata(&pdev->dev);
70 struct fpga_manager *mgr = region->mgr;
69 71
70 fpga_region_unregister(region); 72 fpga_region_unregister(region);
71 fpga_mgr_put(region->mgr); 73 fpga_mgr_put(mgr);
72 74
73 return 0; 75 return 0;
74} 76}
diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
index 24b8f98b73ec..c983dac97501 100644
--- a/drivers/fpga/fpga-bridge.c
+++ b/drivers/fpga/fpga-bridge.c
@@ -125,7 +125,7 @@ static int fpga_bridge_dev_match(struct device *dev, const void *data)
125 * 125 *
126 * Given a device, get an exclusive reference to a fpga bridge. 126 * Given a device, get an exclusive reference to a fpga bridge.
127 * 127 *
128 * Return: fpga manager struct or IS_ERR() condition containing error code. 128 * Return: fpga bridge struct or IS_ERR() condition containing error code.
129 */ 129 */
130struct fpga_bridge *fpga_bridge_get(struct device *dev, 130struct fpga_bridge *fpga_bridge_get(struct device *dev,
131 struct fpga_image_info *info) 131 struct fpga_image_info *info)
diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
index 35fabb8083fb..052a1342ab7e 100644
--- a/drivers/fpga/of-fpga-region.c
+++ b/drivers/fpga/of-fpga-region.c
@@ -437,9 +437,10 @@ eprobe_mgr_put:
437static int of_fpga_region_remove(struct platform_device *pdev) 437static int of_fpga_region_remove(struct platform_device *pdev)
438{ 438{
439 struct fpga_region *region = platform_get_drvdata(pdev); 439 struct fpga_region *region = platform_get_drvdata(pdev);
440 struct fpga_manager *mgr = region->mgr;
440 441
441 fpga_region_unregister(region); 442 fpga_region_unregister(region);
442 fpga_mgr_put(region->mgr); 443 fpga_mgr_put(mgr);
443 444
444 return 0; 445 return 0;
445} 446}
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e8f8a1999393..25187403e3ac 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
571 if (ret) 571 if (ret)
572 goto out_free_descs; 572 goto out_free_descs;
573 lh->descs[i] = desc; 573 lh->descs[i] = desc;
574 count = i; 574 count = i + 1;
575 575
576 if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW) 576 if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW)
577 set_bit(FLAG_ACTIVE_LOW, &desc->flags); 577 set_bit(FLAG_ACTIVE_LOW, &desc->flags);
@@ -1682,7 +1682,8 @@ static void gpiochip_set_cascaded_irqchip(struct gpio_chip *gpiochip,
1682 irq_set_chained_handler_and_data(parent_irq, parent_handler, 1682 irq_set_chained_handler_and_data(parent_irq, parent_handler,
1683 gpiochip); 1683 gpiochip);
1684 1684
1685 gpiochip->irq.parents = &parent_irq; 1685 gpiochip->irq.parent_irq = parent_irq;
1686 gpiochip->irq.parents = &gpiochip->irq.parent_irq;
1686 gpiochip->irq.num_parents = 1; 1687 gpiochip->irq.num_parents = 1;
1687 } 1688 }
1688 1689
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index f8bbbb3a9504..0c791e35acf0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -272,7 +272,7 @@ void amdgpu_amdkfd_gpu_reset(struct kgd_dev *kgd)
272 272
273int alloc_gtt_mem(struct kgd_dev *kgd, size_t size, 273int alloc_gtt_mem(struct kgd_dev *kgd, size_t size,
274 void **mem_obj, uint64_t *gpu_addr, 274 void **mem_obj, uint64_t *gpu_addr,
275 void **cpu_ptr) 275 void **cpu_ptr, bool mqd_gfx9)
276{ 276{
277 struct amdgpu_device *adev = (struct amdgpu_device *)kgd; 277 struct amdgpu_device *adev = (struct amdgpu_device *)kgd;
278 struct amdgpu_bo *bo = NULL; 278 struct amdgpu_bo *bo = NULL;
@@ -287,6 +287,10 @@ int alloc_gtt_mem(struct kgd_dev *kgd, size_t size,
287 bp.flags = AMDGPU_GEM_CREATE_CPU_GTT_USWC; 287 bp.flags = AMDGPU_GEM_CREATE_CPU_GTT_USWC;
288 bp.type = ttm_bo_type_kernel; 288 bp.type = ttm_bo_type_kernel;
289 bp.resv = NULL; 289 bp.resv = NULL;
290
291 if (mqd_gfx9)
292 bp.flags |= AMDGPU_GEM_CREATE_MQD_GFX9;
293
290 r = amdgpu_bo_create(adev, &bp, &bo); 294 r = amdgpu_bo_create(adev, &bp, &bo);
291 if (r) { 295 if (r) {
292 dev_err(adev->dev, 296 dev_err(adev->dev,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h
index 2f379c183ed2..cc9aeab5468c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h
@@ -136,7 +136,7 @@ void amdgpu_amdkfd_gpu_reset(struct kgd_dev *kgd);
136/* Shared API */ 136/* Shared API */
137int alloc_gtt_mem(struct kgd_dev *kgd, size_t size, 137int alloc_gtt_mem(struct kgd_dev *kgd, size_t size,
138 void **mem_obj, uint64_t *gpu_addr, 138 void **mem_obj, uint64_t *gpu_addr,
139 void **cpu_ptr); 139 void **cpu_ptr, bool mqd_gfx9);
140void free_gtt_mem(struct kgd_dev *kgd, void *mem_obj); 140void free_gtt_mem(struct kgd_dev *kgd, void *mem_obj);
141void get_local_mem_info(struct kgd_dev *kgd, 141void get_local_mem_info(struct kgd_dev *kgd,
142 struct kfd_local_mem_info *mem_info); 142 struct kfd_local_mem_info *mem_info);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
index ea3f698aef5e..9803b91f3e77 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
@@ -685,7 +685,7 @@ static int kgd_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd,
685 685
686 while (true) { 686 while (true) {
687 temp = RREG32(sdma_base_addr + mmSDMA0_RLC0_CONTEXT_STATUS); 687 temp = RREG32(sdma_base_addr + mmSDMA0_RLC0_CONTEXT_STATUS);
688 if (temp & SDMA0_STATUS_REG__RB_CMD_IDLE__SHIFT) 688 if (temp & SDMA0_RLC0_CONTEXT_STATUS__IDLE_MASK)
689 break; 689 break;
690 if (time_after(jiffies, end_jiffies)) 690 if (time_after(jiffies, end_jiffies))
691 return -ETIME; 691 return -ETIME;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
index 693ec5ea4950..8816c697b205 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
@@ -367,12 +367,14 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device,
367 break; 367 break;
368 case CHIP_POLARIS10: 368 case CHIP_POLARIS10:
369 if (type == CGS_UCODE_ID_SMU) { 369 if (type == CGS_UCODE_ID_SMU) {
370 if ((adev->pdev->device == 0x67df) && 370 if (((adev->pdev->device == 0x67df) &&
371 ((adev->pdev->revision == 0xe0) || 371 ((adev->pdev->revision == 0xe0) ||
372 (adev->pdev->revision == 0xe3) || 372 (adev->pdev->revision == 0xe3) ||
373 (adev->pdev->revision == 0xe4) || 373 (adev->pdev->revision == 0xe4) ||
374 (adev->pdev->revision == 0xe5) || 374 (adev->pdev->revision == 0xe5) ||
375 (adev->pdev->revision == 0xe7) || 375 (adev->pdev->revision == 0xe7) ||
376 (adev->pdev->revision == 0xef))) ||
377 ((adev->pdev->device == 0x6fdf) &&
376 (adev->pdev->revision == 0xef))) { 378 (adev->pdev->revision == 0xef))) {
377 info->is_kicker = true; 379 info->is_kicker = true;
378 strcpy(fw_name, "amdgpu/polaris10_k_smc.bin"); 380 strcpy(fw_name, "amdgpu/polaris10_k_smc.bin");
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index b6e9df11115d..b31d121a876b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -39,6 +39,7 @@ static int amdgpu_cs_user_fence_chunk(struct amdgpu_cs_parser *p,
39{ 39{
40 struct drm_gem_object *gobj; 40 struct drm_gem_object *gobj;
41 unsigned long size; 41 unsigned long size;
42 int r;
42 43
43 gobj = drm_gem_object_lookup(p->filp, data->handle); 44 gobj = drm_gem_object_lookup(p->filp, data->handle);
44 if (gobj == NULL) 45 if (gobj == NULL)
@@ -50,20 +51,26 @@ static int amdgpu_cs_user_fence_chunk(struct amdgpu_cs_parser *p,
50 p->uf_entry.tv.shared = true; 51 p->uf_entry.tv.shared = true;
51 p->uf_entry.user_pages = NULL; 52 p->uf_entry.user_pages = NULL;
52 53
53 size = amdgpu_bo_size(p->uf_entry.robj);
54 if (size != PAGE_SIZE || (data->offset + 8) > size)
55 return -EINVAL;
56
57 *offset = data->offset;
58
59 drm_gem_object_put_unlocked(gobj); 54 drm_gem_object_put_unlocked(gobj);
60 55
56 size = amdgpu_bo_size(p->uf_entry.robj);
57 if (size != PAGE_SIZE || (data->offset + 8) > size) {
58 r = -EINVAL;
59 goto error_unref;
60 }
61
61 if (amdgpu_ttm_tt_get_usermm(p->uf_entry.robj->tbo.ttm)) { 62 if (amdgpu_ttm_tt_get_usermm(p->uf_entry.robj->tbo.ttm)) {
62 amdgpu_bo_unref(&p->uf_entry.robj); 63 r = -EINVAL;
63 return -EINVAL; 64 goto error_unref;
64 } 65 }
65 66
67 *offset = data->offset;
68
66 return 0; 69 return 0;
70
71error_unref:
72 amdgpu_bo_unref(&p->uf_entry.robj);
73 return r;
67} 74}
68 75
69static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p, 76static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
@@ -1262,10 +1269,10 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
1262error_abort: 1269error_abort:
1263 dma_fence_put(&job->base.s_fence->finished); 1270 dma_fence_put(&job->base.s_fence->finished);
1264 job->base.s_fence = NULL; 1271 job->base.s_fence = NULL;
1272 amdgpu_mn_unlock(p->mn);
1265 1273
1266error_unlock: 1274error_unlock:
1267 amdgpu_job_free(job); 1275 amdgpu_job_free(job);
1268 amdgpu_mn_unlock(p->mn);
1269 return r; 1276 return r;
1270} 1277}
1271 1278
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 8ab5ccbc14ac..39bf2ce548c6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2063,6 +2063,7 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
2063 static enum amd_ip_block_type ip_order[] = { 2063 static enum amd_ip_block_type ip_order[] = {
2064 AMD_IP_BLOCK_TYPE_GMC, 2064 AMD_IP_BLOCK_TYPE_GMC,
2065 AMD_IP_BLOCK_TYPE_COMMON, 2065 AMD_IP_BLOCK_TYPE_COMMON,
2066 AMD_IP_BLOCK_TYPE_PSP,
2066 AMD_IP_BLOCK_TYPE_IH, 2067 AMD_IP_BLOCK_TYPE_IH,
2067 }; 2068 };
2068 2069
@@ -2093,7 +2094,6 @@ static int amdgpu_device_ip_reinit_late_sriov(struct amdgpu_device *adev)
2093 2094
2094 static enum amd_ip_block_type ip_order[] = { 2095 static enum amd_ip_block_type ip_order[] = {
2095 AMD_IP_BLOCK_TYPE_SMC, 2096 AMD_IP_BLOCK_TYPE_SMC,
2096 AMD_IP_BLOCK_TYPE_PSP,
2097 AMD_IP_BLOCK_TYPE_DCE, 2097 AMD_IP_BLOCK_TYPE_DCE,
2098 AMD_IP_BLOCK_TYPE_GFX, 2098 AMD_IP_BLOCK_TYPE_GFX,
2099 AMD_IP_BLOCK_TYPE_SDMA, 2099 AMD_IP_BLOCK_TYPE_SDMA,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 8843a06360fa..0f41d8647376 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -740,6 +740,7 @@ static const struct pci_device_id pciidlist[] = {
740 {0x1002, 0x67CA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10}, 740 {0x1002, 0x67CA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10},
741 {0x1002, 0x67CC, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10}, 741 {0x1002, 0x67CC, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10},
742 {0x1002, 0x67CF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10}, 742 {0x1002, 0x67CF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10},
743 {0x1002, 0x6FDF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS10},
743 /* Polaris12 */ 744 /* Polaris12 */
744 {0x1002, 0x6980, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS12}, 745 {0x1002, 0x6980, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS12},
745 {0x1002, 0x6981, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS12}, 746 {0x1002, 0x6981, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_POLARIS12},
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
index 0cc5190f4f36..5f3f54073818 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
@@ -258,6 +258,8 @@ int amdgpu_vce_suspend(struct amdgpu_device *adev)
258{ 258{
259 int i; 259 int i;
260 260
261 cancel_delayed_work_sync(&adev->vce.idle_work);
262
261 if (adev->vce.vcpu_bo == NULL) 263 if (adev->vce.vcpu_bo == NULL)
262 return 0; 264 return 0;
263 265
@@ -268,7 +270,6 @@ int amdgpu_vce_suspend(struct amdgpu_device *adev)
268 if (i == AMDGPU_MAX_VCE_HANDLES) 270 if (i == AMDGPU_MAX_VCE_HANDLES)
269 return 0; 271 return 0;
270 272
271 cancel_delayed_work_sync(&adev->vce.idle_work);
272 /* TODO: suspending running encoding sessions isn't supported */ 273 /* TODO: suspending running encoding sessions isn't supported */
273 return -EINVAL; 274 return -EINVAL;
274} 275}
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index fd654a4406db..400fc74bbae2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
@@ -153,11 +153,11 @@ int amdgpu_vcn_suspend(struct amdgpu_device *adev)
153 unsigned size; 153 unsigned size;
154 void *ptr; 154 void *ptr;
155 155
156 cancel_delayed_work_sync(&adev->vcn.idle_work);
157
156 if (adev->vcn.vcpu_bo == NULL) 158 if (adev->vcn.vcpu_bo == NULL)
157 return 0; 159 return 0;
158 160
159 cancel_delayed_work_sync(&adev->vcn.idle_work);
160
161 size = amdgpu_bo_size(adev->vcn.vcpu_bo); 161 size = amdgpu_bo_size(adev->vcn.vcpu_bo);
162 ptr = adev->vcn.cpu_addr; 162 ptr = adev->vcn.cpu_addr;
163 163
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
index e7ca4623cfb9..7c3b634d8d5f 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
@@ -70,6 +70,7 @@ static const struct soc15_reg_golden golden_settings_sdma_4[] = {
70 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_IB_CNTL, 0x800f0100, 0x00000100), 70 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_IB_CNTL, 0x800f0100, 0x00000100),
71 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_RB_WPTR_POLL_CNTL, 0x0000fff0, 0x00403000), 71 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_RB_WPTR_POLL_CNTL, 0x0000fff0, 0x00403000),
72 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_UTCL1_PAGE, 0x000003ff, 0x000003c0), 72 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_UTCL1_PAGE, 0x000003ff, 0x000003c0),
73 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_UTCL1_WATERMK, 0xfc000000, 0x00000000),
73 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_CHICKEN_BITS, 0xfe931f07, 0x02831f07), 74 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_CHICKEN_BITS, 0xfe931f07, 0x02831f07),
74 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_CLK_CTRL, 0xffffffff, 0x3f000100), 75 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_CLK_CTRL, 0xffffffff, 0x3f000100),
75 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_GFX_IB_CNTL, 0x800f0100, 0x00000100), 76 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_GFX_IB_CNTL, 0x800f0100, 0x00000100),
@@ -81,7 +82,8 @@ static const struct soc15_reg_golden golden_settings_sdma_4[] = {
81 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_RLC0_RB_WPTR_POLL_CNTL, 0x0000fff0, 0x00403000), 82 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_RLC0_RB_WPTR_POLL_CNTL, 0x0000fff0, 0x00403000),
82 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_RLC1_IB_CNTL, 0x800f0100, 0x00000100), 83 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_RLC1_IB_CNTL, 0x800f0100, 0x00000100),
83 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_RLC1_RB_WPTR_POLL_CNTL, 0x0000fff0, 0x00403000), 84 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_RLC1_RB_WPTR_POLL_CNTL, 0x0000fff0, 0x00403000),
84 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_UTCL1_PAGE, 0x000003ff, 0x000003c0) 85 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_UTCL1_PAGE, 0x000003ff, 0x000003c0),
86 SOC15_REG_GOLDEN_VALUE(SDMA1, 0, mmSDMA1_UTCL1_WATERMK, 0xfc000000, 0x00000000)
85}; 87};
86 88
87static const struct soc15_reg_golden golden_settings_sdma_vg10[] = { 89static const struct soc15_reg_golden golden_settings_sdma_vg10[] = {
@@ -109,7 +111,8 @@ static const struct soc15_reg_golden golden_settings_sdma_4_1[] =
109 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC0_RB_WPTR_POLL_CNTL, 0xfffffff7, 0x00403000), 111 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC0_RB_WPTR_POLL_CNTL, 0xfffffff7, 0x00403000),
110 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_IB_CNTL, 0x800f0111, 0x00000100), 112 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_IB_CNTL, 0x800f0111, 0x00000100),
111 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_RB_WPTR_POLL_CNTL, 0xfffffff7, 0x00403000), 113 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_RLC1_RB_WPTR_POLL_CNTL, 0xfffffff7, 0x00403000),
112 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_UTCL1_PAGE, 0x000003ff, 0x000003c0) 114 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_UTCL1_PAGE, 0x000003ff, 0x000003c0),
115 SOC15_REG_GOLDEN_VALUE(SDMA0, 0, mmSDMA0_UTCL1_WATERMK, 0xfc000000, 0x00000000)
113}; 116};
114 117
115static const struct soc15_reg_golden golden_settings_sdma_4_2[] = 118static const struct soc15_reg_golden golden_settings_sdma_4_2[] =
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index 1b048715ab8a..29ac74f40dce 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -457,7 +457,8 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd,
457 457
458 if (kfd->kfd2kgd->init_gtt_mem_allocation( 458 if (kfd->kfd2kgd->init_gtt_mem_allocation(
459 kfd->kgd, size, &kfd->gtt_mem, 459 kfd->kgd, size, &kfd->gtt_mem,
460 &kfd->gtt_start_gpu_addr, &kfd->gtt_start_cpu_ptr)){ 460 &kfd->gtt_start_gpu_addr, &kfd->gtt_start_cpu_ptr,
461 false)) {
461 dev_err(kfd_device, "Could not allocate %d bytes\n", size); 462 dev_err(kfd_device, "Could not allocate %d bytes\n", size);
462 goto out; 463 goto out;
463 } 464 }
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index ec0d62a16e53..4f22e745df51 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -358,8 +358,8 @@ static int create_compute_queue_nocpsch(struct device_queue_manager *dqm,
358 struct queue *q, 358 struct queue *q,
359 struct qcm_process_device *qpd) 359 struct qcm_process_device *qpd)
360{ 360{
361 int retval;
362 struct mqd_manager *mqd_mgr; 361 struct mqd_manager *mqd_mgr;
362 int retval;
363 363
364 mqd_mgr = dqm->ops.get_mqd_manager(dqm, KFD_MQD_TYPE_COMPUTE); 364 mqd_mgr = dqm->ops.get_mqd_manager(dqm, KFD_MQD_TYPE_COMPUTE);
365 if (!mqd_mgr) 365 if (!mqd_mgr)
@@ -387,8 +387,12 @@ static int create_compute_queue_nocpsch(struct device_queue_manager *dqm,
387 if (!q->properties.is_active) 387 if (!q->properties.is_active)
388 return 0; 388 return 0;
389 389
390 retval = mqd_mgr->load_mqd(mqd_mgr, q->mqd, q->pipe, q->queue, 390 if (WARN(q->process->mm != current->mm,
391 &q->properties, q->process->mm); 391 "should only run in user thread"))
392 retval = -EFAULT;
393 else
394 retval = mqd_mgr->load_mqd(mqd_mgr, q->mqd, q->pipe, q->queue,
395 &q->properties, current->mm);
392 if (retval) 396 if (retval)
393 goto out_uninit_mqd; 397 goto out_uninit_mqd;
394 398
@@ -545,9 +549,15 @@ static int update_queue(struct device_queue_manager *dqm, struct queue *q)
545 retval = map_queues_cpsch(dqm); 549 retval = map_queues_cpsch(dqm);
546 else if (q->properties.is_active && 550 else if (q->properties.is_active &&
547 (q->properties.type == KFD_QUEUE_TYPE_COMPUTE || 551 (q->properties.type == KFD_QUEUE_TYPE_COMPUTE ||
548 q->properties.type == KFD_QUEUE_TYPE_SDMA)) 552 q->properties.type == KFD_QUEUE_TYPE_SDMA)) {
549 retval = mqd_mgr->load_mqd(mqd_mgr, q->mqd, q->pipe, q->queue, 553 if (WARN(q->process->mm != current->mm,
550 &q->properties, q->process->mm); 554 "should only run in user thread"))
555 retval = -EFAULT;
556 else
557 retval = mqd_mgr->load_mqd(mqd_mgr, q->mqd,
558 q->pipe, q->queue,
559 &q->properties, current->mm);
560 }
551 561
552out_unlock: 562out_unlock:
553 dqm_unlock(dqm); 563 dqm_unlock(dqm);
@@ -653,6 +663,7 @@ out:
653static int restore_process_queues_nocpsch(struct device_queue_manager *dqm, 663static int restore_process_queues_nocpsch(struct device_queue_manager *dqm,
654 struct qcm_process_device *qpd) 664 struct qcm_process_device *qpd)
655{ 665{
666 struct mm_struct *mm = NULL;
656 struct queue *q; 667 struct queue *q;
657 struct mqd_manager *mqd_mgr; 668 struct mqd_manager *mqd_mgr;
658 struct kfd_process_device *pdd; 669 struct kfd_process_device *pdd;
@@ -686,6 +697,15 @@ static int restore_process_queues_nocpsch(struct device_queue_manager *dqm,
686 kfd_flush_tlb(pdd); 697 kfd_flush_tlb(pdd);
687 } 698 }
688 699
700 /* Take a safe reference to the mm_struct, which may otherwise
701 * disappear even while the kfd_process is still referenced.
702 */
703 mm = get_task_mm(pdd->process->lead_thread);
704 if (!mm) {
705 retval = -EFAULT;
706 goto out;
707 }
708
689 /* activate all active queues on the qpd */ 709 /* activate all active queues on the qpd */
690 list_for_each_entry(q, &qpd->queues_list, list) { 710 list_for_each_entry(q, &qpd->queues_list, list) {
691 if (!q->properties.is_evicted) 711 if (!q->properties.is_evicted)
@@ -700,14 +720,15 @@ static int restore_process_queues_nocpsch(struct device_queue_manager *dqm,
700 q->properties.is_evicted = false; 720 q->properties.is_evicted = false;
701 q->properties.is_active = true; 721 q->properties.is_active = true;
702 retval = mqd_mgr->load_mqd(mqd_mgr, q->mqd, q->pipe, 722 retval = mqd_mgr->load_mqd(mqd_mgr, q->mqd, q->pipe,
703 q->queue, &q->properties, 723 q->queue, &q->properties, mm);
704 q->process->mm);
705 if (retval) 724 if (retval)
706 goto out; 725 goto out;
707 dqm->queue_count++; 726 dqm->queue_count++;
708 } 727 }
709 qpd->evicted = 0; 728 qpd->evicted = 0;
710out: 729out:
730 if (mm)
731 mmput(mm);
711 dqm_unlock(dqm); 732 dqm_unlock(dqm);
712 return retval; 733 return retval;
713} 734}
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
index 7a61f38c09e6..01494752c36a 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
@@ -62,9 +62,20 @@ int kfd_iommu_device_init(struct kfd_dev *kfd)
62 struct amd_iommu_device_info iommu_info; 62 struct amd_iommu_device_info iommu_info;
63 unsigned int pasid_limit; 63 unsigned int pasid_limit;
64 int err; 64 int err;
65 struct kfd_topology_device *top_dev;
65 66
66 if (!kfd->device_info->needs_iommu_device) 67 top_dev = kfd_topology_device_by_id(kfd->id);
68
69 /*
70 * Overwrite ATS capability according to needs_iommu_device to fix
71 * potential missing corresponding bit in CRAT of BIOS.
72 */
73 if (!kfd->device_info->needs_iommu_device) {
74 top_dev->node_props.capability &= ~HSA_CAP_ATS_PRESENT;
67 return 0; 75 return 0;
76 }
77
78 top_dev->node_props.capability |= HSA_CAP_ATS_PRESENT;
68 79
69 iommu_info.flags = 0; 80 iommu_info.flags = 0;
70 err = amd_iommu_device_info(kfd->pdev, &iommu_info); 81 err = amd_iommu_device_info(kfd->pdev, &iommu_info);
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
index f5fc3675f21e..0cedb37cf513 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
@@ -88,7 +88,7 @@ static int init_mqd(struct mqd_manager *mm, void **mqd,
88 ALIGN(sizeof(struct v9_mqd), PAGE_SIZE), 88 ALIGN(sizeof(struct v9_mqd), PAGE_SIZE),
89 &((*mqd_mem_obj)->gtt_mem), 89 &((*mqd_mem_obj)->gtt_mem),
90 &((*mqd_mem_obj)->gpu_addr), 90 &((*mqd_mem_obj)->gpu_addr),
91 (void *)&((*mqd_mem_obj)->cpu_ptr)); 91 (void *)&((*mqd_mem_obj)->cpu_ptr), true);
92 } else 92 } else
93 retval = kfd_gtt_sa_allocate(mm->dev, sizeof(struct v9_mqd), 93 retval = kfd_gtt_sa_allocate(mm->dev, sizeof(struct v9_mqd),
94 mqd_mem_obj); 94 mqd_mem_obj);
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
index f971710f1c91..92b285ca73aa 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
@@ -806,6 +806,7 @@ int kfd_topology_add_device(struct kfd_dev *gpu);
806int kfd_topology_remove_device(struct kfd_dev *gpu); 806int kfd_topology_remove_device(struct kfd_dev *gpu);
807struct kfd_topology_device *kfd_topology_device_by_proximity_domain( 807struct kfd_topology_device *kfd_topology_device_by_proximity_domain(
808 uint32_t proximity_domain); 808 uint32_t proximity_domain);
809struct kfd_topology_device *kfd_topology_device_by_id(uint32_t gpu_id);
809struct kfd_dev *kfd_device_by_id(uint32_t gpu_id); 810struct kfd_dev *kfd_device_by_id(uint32_t gpu_id);
810struct kfd_dev *kfd_device_by_pci_dev(const struct pci_dev *pdev); 811struct kfd_dev *kfd_device_by_pci_dev(const struct pci_dev *pdev);
811int kfd_topology_enum_kfd_devices(uint8_t idx, struct kfd_dev **kdev); 812int kfd_topology_enum_kfd_devices(uint8_t idx, struct kfd_dev **kdev);
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index bc95d4dfee2e..80f5db4ef75f 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -63,22 +63,33 @@ struct kfd_topology_device *kfd_topology_device_by_proximity_domain(
63 return device; 63 return device;
64} 64}
65 65
66struct kfd_dev *kfd_device_by_id(uint32_t gpu_id) 66struct kfd_topology_device *kfd_topology_device_by_id(uint32_t gpu_id)
67{ 67{
68 struct kfd_topology_device *top_dev; 68 struct kfd_topology_device *top_dev = NULL;
69 struct kfd_dev *device = NULL; 69 struct kfd_topology_device *ret = NULL;
70 70
71 down_read(&topology_lock); 71 down_read(&topology_lock);
72 72
73 list_for_each_entry(top_dev, &topology_device_list, list) 73 list_for_each_entry(top_dev, &topology_device_list, list)
74 if (top_dev->gpu_id == gpu_id) { 74 if (top_dev->gpu_id == gpu_id) {
75 device = top_dev->gpu; 75 ret = top_dev;
76 break; 76 break;
77 } 77 }
78 78
79 up_read(&topology_lock); 79 up_read(&topology_lock);
80 80
81 return device; 81 return ret;
82}
83
84struct kfd_dev *kfd_device_by_id(uint32_t gpu_id)
85{
86 struct kfd_topology_device *top_dev;
87
88 top_dev = kfd_topology_device_by_id(gpu_id);
89 if (!top_dev)
90 return NULL;
91
92 return top_dev->gpu;
82} 93}
83 94
84struct kfd_dev *kfd_device_by_pci_dev(const struct pci_dev *pdev) 95struct kfd_dev *kfd_device_by_pci_dev(const struct pci_dev *pdev)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 800f481a6995..6903fe6c894b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -641,6 +641,87 @@ amdgpu_dm_find_first_crtc_matching_connector(struct drm_atomic_state *state,
641 return NULL; 641 return NULL;
642} 642}
643 643
644static void emulated_link_detect(struct dc_link *link)
645{
646 struct dc_sink_init_data sink_init_data = { 0 };
647 struct display_sink_capability sink_caps = { 0 };
648 enum dc_edid_status edid_status;
649 struct dc_context *dc_ctx = link->ctx;
650 struct dc_sink *sink = NULL;
651 struct dc_sink *prev_sink = NULL;
652
653 link->type = dc_connection_none;
654 prev_sink = link->local_sink;
655
656 if (prev_sink != NULL)
657 dc_sink_retain(prev_sink);
658
659 switch (link->connector_signal) {
660 case SIGNAL_TYPE_HDMI_TYPE_A: {
661 sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
662 sink_caps.signal = SIGNAL_TYPE_HDMI_TYPE_A;
663 break;
664 }
665
666 case SIGNAL_TYPE_DVI_SINGLE_LINK: {
667 sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
668 sink_caps.signal = SIGNAL_TYPE_DVI_SINGLE_LINK;
669 break;
670 }
671
672 case SIGNAL_TYPE_DVI_DUAL_LINK: {
673 sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
674 sink_caps.signal = SIGNAL_TYPE_DVI_DUAL_LINK;
675 break;
676 }
677
678 case SIGNAL_TYPE_LVDS: {
679 sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
680 sink_caps.signal = SIGNAL_TYPE_LVDS;
681 break;
682 }
683
684 case SIGNAL_TYPE_EDP: {
685 sink_caps.transaction_type =
686 DDC_TRANSACTION_TYPE_I2C_OVER_AUX;
687 sink_caps.signal = SIGNAL_TYPE_EDP;
688 break;
689 }
690
691 case SIGNAL_TYPE_DISPLAY_PORT: {
692 sink_caps.transaction_type =
693 DDC_TRANSACTION_TYPE_I2C_OVER_AUX;
694 sink_caps.signal = SIGNAL_TYPE_VIRTUAL;
695 break;
696 }
697
698 default:
699 DC_ERROR("Invalid connector type! signal:%d\n",
700 link->connector_signal);
701 return;
702 }
703
704 sink_init_data.link = link;
705 sink_init_data.sink_signal = sink_caps.signal;
706
707 sink = dc_sink_create(&sink_init_data);
708 if (!sink) {
709 DC_ERROR("Failed to create sink!\n");
710 return;
711 }
712
713 link->local_sink = sink;
714
715 edid_status = dm_helpers_read_local_edid(
716 link->ctx,
717 link,
718 sink);
719
720 if (edid_status != EDID_OK)
721 DC_ERROR("Failed to read EDID");
722
723}
724
644static int dm_resume(void *handle) 725static int dm_resume(void *handle)
645{ 726{
646 struct amdgpu_device *adev = handle; 727 struct amdgpu_device *adev = handle;
@@ -654,6 +735,7 @@ static int dm_resume(void *handle)
654 struct drm_plane *plane; 735 struct drm_plane *plane;
655 struct drm_plane_state *new_plane_state; 736 struct drm_plane_state *new_plane_state;
656 struct dm_plane_state *dm_new_plane_state; 737 struct dm_plane_state *dm_new_plane_state;
738 enum dc_connection_type new_connection_type = dc_connection_none;
657 int ret; 739 int ret;
658 int i; 740 int i;
659 741
@@ -684,7 +766,13 @@ static int dm_resume(void *handle)
684 continue; 766 continue;
685 767
686 mutex_lock(&aconnector->hpd_lock); 768 mutex_lock(&aconnector->hpd_lock);
687 dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD); 769 if (!dc_link_detect_sink(aconnector->dc_link, &new_connection_type))
770 DRM_ERROR("KMS: Failed to detect connector\n");
771
772 if (aconnector->base.force && new_connection_type == dc_connection_none)
773 emulated_link_detect(aconnector->dc_link);
774 else
775 dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD);
688 776
689 if (aconnector->fake_enable && aconnector->dc_link->local_sink) 777 if (aconnector->fake_enable && aconnector->dc_link->local_sink)
690 aconnector->fake_enable = false; 778 aconnector->fake_enable = false;
@@ -922,6 +1010,7 @@ static void handle_hpd_irq(void *param)
922 struct amdgpu_dm_connector *aconnector = (struct amdgpu_dm_connector *)param; 1010 struct amdgpu_dm_connector *aconnector = (struct amdgpu_dm_connector *)param;
923 struct drm_connector *connector = &aconnector->base; 1011 struct drm_connector *connector = &aconnector->base;
924 struct drm_device *dev = connector->dev; 1012 struct drm_device *dev = connector->dev;
1013 enum dc_connection_type new_connection_type = dc_connection_none;
925 1014
926 /* In case of failure or MST no need to update connector status or notify the OS 1015 /* In case of failure or MST no need to update connector status or notify the OS
927 * since (for MST case) MST does this in it's own context. 1016 * since (for MST case) MST does this in it's own context.
@@ -931,7 +1020,21 @@ static void handle_hpd_irq(void *param)
931 if (aconnector->fake_enable) 1020 if (aconnector->fake_enable)
932 aconnector->fake_enable = false; 1021 aconnector->fake_enable = false;
933 1022
934 if (dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD)) { 1023 if (!dc_link_detect_sink(aconnector->dc_link, &new_connection_type))
1024 DRM_ERROR("KMS: Failed to detect connector\n");
1025
1026 if (aconnector->base.force && new_connection_type == dc_connection_none) {
1027 emulated_link_detect(aconnector->dc_link);
1028
1029
1030 drm_modeset_lock_all(dev);
1031 dm_restore_drm_connector_state(dev, connector);
1032 drm_modeset_unlock_all(dev);
1033
1034 if (aconnector->base.force == DRM_FORCE_UNSPECIFIED)
1035 drm_kms_helper_hotplug_event(dev);
1036
1037 } else if (dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD)) {
935 amdgpu_dm_update_connector_after_detect(aconnector); 1038 amdgpu_dm_update_connector_after_detect(aconnector);
936 1039
937 1040
@@ -1031,6 +1134,7 @@ static void handle_hpd_rx_irq(void *param)
1031 struct drm_device *dev = connector->dev; 1134 struct drm_device *dev = connector->dev;
1032 struct dc_link *dc_link = aconnector->dc_link; 1135 struct dc_link *dc_link = aconnector->dc_link;
1033 bool is_mst_root_connector = aconnector->mst_mgr.mst_state; 1136 bool is_mst_root_connector = aconnector->mst_mgr.mst_state;
1137 enum dc_connection_type new_connection_type = dc_connection_none;
1034 1138
1035 /* TODO:Temporary add mutex to protect hpd interrupt not have a gpio 1139 /* TODO:Temporary add mutex to protect hpd interrupt not have a gpio
1036 * conflict, after implement i2c helper, this mutex should be 1140 * conflict, after implement i2c helper, this mutex should be
@@ -1042,7 +1146,24 @@ static void handle_hpd_rx_irq(void *param)
1042 if (dc_link_handle_hpd_rx_irq(dc_link, NULL, NULL) && 1146 if (dc_link_handle_hpd_rx_irq(dc_link, NULL, NULL) &&
1043 !is_mst_root_connector) { 1147 !is_mst_root_connector) {
1044 /* Downstream Port status changed. */ 1148 /* Downstream Port status changed. */
1045 if (dc_link_detect(dc_link, DETECT_REASON_HPDRX)) { 1149 if (!dc_link_detect_sink(dc_link, &new_connection_type))
1150 DRM_ERROR("KMS: Failed to detect connector\n");
1151
1152 if (aconnector->base.force && new_connection_type == dc_connection_none) {
1153 emulated_link_detect(dc_link);
1154
1155 if (aconnector->fake_enable)
1156 aconnector->fake_enable = false;
1157
1158 amdgpu_dm_update_connector_after_detect(aconnector);
1159
1160
1161 drm_modeset_lock_all(dev);
1162 dm_restore_drm_connector_state(dev, connector);
1163 drm_modeset_unlock_all(dev);
1164
1165 drm_kms_helper_hotplug_event(dev);
1166 } else if (dc_link_detect(dc_link, DETECT_REASON_HPDRX)) {
1046 1167
1047 if (aconnector->fake_enable) 1168 if (aconnector->fake_enable)
1048 aconnector->fake_enable = false; 1169 aconnector->fake_enable = false;
@@ -1433,6 +1554,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
1433 struct amdgpu_mode_info *mode_info = &adev->mode_info; 1554 struct amdgpu_mode_info *mode_info = &adev->mode_info;
1434 uint32_t link_cnt; 1555 uint32_t link_cnt;
1435 int32_t total_overlay_planes, total_primary_planes; 1556 int32_t total_overlay_planes, total_primary_planes;
1557 enum dc_connection_type new_connection_type = dc_connection_none;
1436 1558
1437 link_cnt = dm->dc->caps.max_links; 1559 link_cnt = dm->dc->caps.max_links;
1438 if (amdgpu_dm_mode_config_init(dm->adev)) { 1560 if (amdgpu_dm_mode_config_init(dm->adev)) {
@@ -1499,7 +1621,14 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
1499 1621
1500 link = dc_get_link_at_index(dm->dc, i); 1622 link = dc_get_link_at_index(dm->dc, i);
1501 1623
1502 if (dc_link_detect(link, DETECT_REASON_BOOT)) { 1624 if (!dc_link_detect_sink(link, &new_connection_type))
1625 DRM_ERROR("KMS: Failed to detect connector\n");
1626
1627 if (aconnector->base.force && new_connection_type == dc_connection_none) {
1628 emulated_link_detect(link);
1629 amdgpu_dm_update_connector_after_detect(aconnector);
1630
1631 } else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
1503 amdgpu_dm_update_connector_after_detect(aconnector); 1632 amdgpu_dm_update_connector_after_detect(aconnector);
1504 register_backlight_device(dm, link); 1633 register_backlight_device(dm, link);
1505 } 1634 }
@@ -2494,7 +2623,7 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
2494 if (dm_state && dm_state->freesync_capable) 2623 if (dm_state && dm_state->freesync_capable)
2495 stream->ignore_msa_timing_param = true; 2624 stream->ignore_msa_timing_param = true;
2496finish: 2625finish:
2497 if (sink && sink->sink_signal == SIGNAL_TYPE_VIRTUAL) 2626 if (sink && sink->sink_signal == SIGNAL_TYPE_VIRTUAL && aconnector->base.force != DRM_FORCE_ON)
2498 dc_sink_release(sink); 2627 dc_sink_release(sink);
2499 2628
2500 return stream; 2629 return stream;
@@ -4504,12 +4633,18 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)
4504 } 4633 }
4505 spin_unlock_irqrestore(&adev->ddev->event_lock, flags); 4634 spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
4506 4635
4507 /* Signal HW programming completion */
4508 drm_atomic_helper_commit_hw_done(state);
4509 4636
4510 if (wait_for_vblank) 4637 if (wait_for_vblank)
4511 drm_atomic_helper_wait_for_flip_done(dev, state); 4638 drm_atomic_helper_wait_for_flip_done(dev, state);
4512 4639
4640 /*
4641 * FIXME:
4642 * Delay hw_done() until flip_done() is signaled. This is to block
4643 * another commit from freeing the CRTC state while we're still
4644 * waiting on flip_done.
4645 */
4646 drm_atomic_helper_commit_hw_done(state);
4647
4513 drm_atomic_helper_cleanup_planes(dev, state); 4648 drm_atomic_helper_cleanup_planes(dev, state);
4514 4649
4515 /* Finally, drop a runtime PM reference for each newly disabled CRTC, 4650 /* Finally, drop a runtime PM reference for each newly disabled CRTC,
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 37eaf72ace54..fced3c1c2ef5 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -195,7 +195,7 @@ static bool program_hpd_filter(
195 return result; 195 return result;
196} 196}
197 197
198static bool detect_sink(struct dc_link *link, enum dc_connection_type *type) 198bool dc_link_detect_sink(struct dc_link *link, enum dc_connection_type *type)
199{ 199{
200 uint32_t is_hpd_high = 0; 200 uint32_t is_hpd_high = 0;
201 struct gpio *hpd_pin; 201 struct gpio *hpd_pin;
@@ -604,7 +604,7 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)
604 if (link->connector_signal == SIGNAL_TYPE_VIRTUAL) 604 if (link->connector_signal == SIGNAL_TYPE_VIRTUAL)
605 return false; 605 return false;
606 606
607 if (false == detect_sink(link, &new_connection_type)) { 607 if (false == dc_link_detect_sink(link, &new_connection_type)) {
608 BREAK_TO_DEBUGGER(); 608 BREAK_TO_DEBUGGER();
609 return false; 609 return false;
610 } 610 }
diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
index d43cefbc43d3..1b48ab9aea89 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_link.h
+++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
@@ -215,6 +215,7 @@ void dc_link_enable_hpd_filter(struct dc_link *link, bool enable);
215 215
216bool dc_link_is_dp_sink_present(struct dc_link *link); 216bool dc_link_is_dp_sink_present(struct dc_link *link);
217 217
218bool dc_link_detect_sink(struct dc_link *link, enum dc_connection_type *type);
218/* 219/*
219 * DPCD access interfaces 220 * DPCD access interfaces
220 */ 221 */
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 14384d9675a8..b2f308766a9e 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -2560,7 +2560,7 @@ static void pplib_apply_display_requirements(
2560 dc->prev_display_config = *pp_display_cfg; 2560 dc->prev_display_config = *pp_display_cfg;
2561} 2561}
2562 2562
2563void dce110_set_bandwidth( 2563static void dce110_set_bandwidth(
2564 struct dc *dc, 2564 struct dc *dc,
2565 struct dc_state *context, 2565 struct dc_state *context,
2566 bool decrease_allowed) 2566 bool decrease_allowed)
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.h b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.h
index e4c5db75c4c6..d6db3dbd9015 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.h
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.h
@@ -68,11 +68,6 @@ void dce110_fill_display_configs(
68 const struct dc_state *context, 68 const struct dc_state *context,
69 struct dm_pp_display_configuration *pp_display_cfg); 69 struct dm_pp_display_configuration *pp_display_cfg);
70 70
71void dce110_set_bandwidth(
72 struct dc *dc,
73 struct dc_state *context,
74 bool decrease_allowed);
75
76uint32_t dce110_get_min_vblank_time_us(const struct dc_state *context); 71uint32_t dce110_get_min_vblank_time_us(const struct dc_state *context);
77 72
78void dp_receiver_power_ctrl(struct dc_link *link, bool on); 73void dp_receiver_power_ctrl(struct dc_link *link, bool on);
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c
index 5853522a6182..eb0f5f9a973b 100644
--- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c
@@ -244,17 +244,6 @@ static void dce120_update_dchub(
244 dh_data->dchub_info_valid = false; 244 dh_data->dchub_info_valid = false;
245} 245}
246 246
247static void dce120_set_bandwidth(
248 struct dc *dc,
249 struct dc_state *context,
250 bool decrease_allowed)
251{
252 if (context->stream_count <= 0)
253 return;
254
255 dce110_set_bandwidth(dc, context, decrease_allowed);
256}
257
258void dce120_hw_sequencer_construct(struct dc *dc) 247void dce120_hw_sequencer_construct(struct dc *dc)
259{ 248{
260 /* All registers used by dce11.2 match those in dce11 in offset and 249 /* All registers used by dce11.2 match those in dce11 in offset and
@@ -263,6 +252,5 @@ void dce120_hw_sequencer_construct(struct dc *dc)
263 dce110_hw_sequencer_construct(dc); 252 dce110_hw_sequencer_construct(dc);
264 dc->hwss.enable_display_power_gating = dce120_enable_display_power_gating; 253 dc->hwss.enable_display_power_gating = dce120_enable_display_power_gating;
265 dc->hwss.update_dchub = dce120_update_dchub; 254 dc->hwss.update_dchub = dce120_update_dchub;
266 dc->hwss.set_bandwidth = dce120_set_bandwidth;
267} 255}
268 256
diff --git a/drivers/gpu/drm/amd/include/kgd_kfd_interface.h b/drivers/gpu/drm/amd/include/kgd_kfd_interface.h
index 14391b06080c..43b82e14007e 100644
--- a/drivers/gpu/drm/amd/include/kgd_kfd_interface.h
+++ b/drivers/gpu/drm/amd/include/kgd_kfd_interface.h
@@ -292,7 +292,7 @@ struct tile_config {
292struct kfd2kgd_calls { 292struct kfd2kgd_calls {
293 int (*init_gtt_mem_allocation)(struct kgd_dev *kgd, size_t size, 293 int (*init_gtt_mem_allocation)(struct kgd_dev *kgd, size_t size,
294 void **mem_obj, uint64_t *gpu_addr, 294 void **mem_obj, uint64_t *gpu_addr,
295 void **cpu_ptr); 295 void **cpu_ptr, bool mqd_gfx9);
296 296
297 void (*free_gtt_mem)(struct kgd_dev *kgd, void *mem_obj); 297 void (*free_gtt_mem)(struct kgd_dev *kgd, void *mem_obj);
298 298
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 08b5bb219816..94d6dabec2dc 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -754,6 +754,7 @@ static int malidp_bind(struct device *dev)
754 drm->irq_enabled = true; 754 drm->irq_enabled = true;
755 755
756 ret = drm_vblank_init(drm, drm->mode_config.num_crtc); 756 ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
757 drm_crtc_vblank_reset(&malidp->crtc);
757 if (ret < 0) { 758 if (ret < 0) {
758 DRM_ERROR("failed to initialise vblank\n"); 759 DRM_ERROR("failed to initialise vblank\n");
759 goto vblank_fail; 760 goto vblank_fail;
diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
index c94a4422e0e9..2781e462c1ed 100644
--- a/drivers/gpu/drm/arm/malidp_hw.c
+++ b/drivers/gpu/drm/arm/malidp_hw.c
@@ -384,7 +384,8 @@ static long malidp500_se_calc_mclk(struct malidp_hw_device *hwdev,
384 384
385static int malidp500_enable_memwrite(struct malidp_hw_device *hwdev, 385static int malidp500_enable_memwrite(struct malidp_hw_device *hwdev,
386 dma_addr_t *addrs, s32 *pitches, 386 dma_addr_t *addrs, s32 *pitches,
387 int num_planes, u16 w, u16 h, u32 fmt_id) 387 int num_planes, u16 w, u16 h, u32 fmt_id,
388 const s16 *rgb2yuv_coeffs)
388{ 389{
389 u32 base = MALIDP500_SE_MEMWRITE_BASE; 390 u32 base = MALIDP500_SE_MEMWRITE_BASE;
390 u32 de_base = malidp_get_block_base(hwdev, MALIDP_DE_BLOCK); 391 u32 de_base = malidp_get_block_base(hwdev, MALIDP_DE_BLOCK);
@@ -416,6 +417,16 @@ static int malidp500_enable_memwrite(struct malidp_hw_device *hwdev,
416 417
417 malidp_hw_write(hwdev, MALIDP_DE_H_ACTIVE(w) | MALIDP_DE_V_ACTIVE(h), 418 malidp_hw_write(hwdev, MALIDP_DE_H_ACTIVE(w) | MALIDP_DE_V_ACTIVE(h),
418 MALIDP500_SE_MEMWRITE_OUT_SIZE); 419 MALIDP500_SE_MEMWRITE_OUT_SIZE);
420
421 if (rgb2yuv_coeffs) {
422 int i;
423
424 for (i = 0; i < MALIDP_COLORADJ_NUM_COEFFS; i++) {
425 malidp_hw_write(hwdev, rgb2yuv_coeffs[i],
426 MALIDP500_SE_RGB_YUV_COEFFS + i * 4);
427 }
428 }
429
419 malidp_hw_setbits(hwdev, MALIDP_SE_MEMWRITE_EN, MALIDP500_SE_CONTROL); 430 malidp_hw_setbits(hwdev, MALIDP_SE_MEMWRITE_EN, MALIDP500_SE_CONTROL);
420 431
421 return 0; 432 return 0;
@@ -658,7 +669,8 @@ static long malidp550_se_calc_mclk(struct malidp_hw_device *hwdev,
658 669
659static int malidp550_enable_memwrite(struct malidp_hw_device *hwdev, 670static int malidp550_enable_memwrite(struct malidp_hw_device *hwdev,
660 dma_addr_t *addrs, s32 *pitches, 671 dma_addr_t *addrs, s32 *pitches,
661 int num_planes, u16 w, u16 h, u32 fmt_id) 672 int num_planes, u16 w, u16 h, u32 fmt_id,
673 const s16 *rgb2yuv_coeffs)
662{ 674{
663 u32 base = MALIDP550_SE_MEMWRITE_BASE; 675 u32 base = MALIDP550_SE_MEMWRITE_BASE;
664 u32 de_base = malidp_get_block_base(hwdev, MALIDP_DE_BLOCK); 676 u32 de_base = malidp_get_block_base(hwdev, MALIDP_DE_BLOCK);
@@ -689,6 +701,15 @@ static int malidp550_enable_memwrite(struct malidp_hw_device *hwdev,
689 malidp_hw_setbits(hwdev, MALIDP550_SE_MEMWRITE_ONESHOT | MALIDP_SE_MEMWRITE_EN, 701 malidp_hw_setbits(hwdev, MALIDP550_SE_MEMWRITE_ONESHOT | MALIDP_SE_MEMWRITE_EN,
690 MALIDP550_SE_CONTROL); 702 MALIDP550_SE_CONTROL);
691 703
704 if (rgb2yuv_coeffs) {
705 int i;
706
707 for (i = 0; i < MALIDP_COLORADJ_NUM_COEFFS; i++) {
708 malidp_hw_write(hwdev, rgb2yuv_coeffs[i],
709 MALIDP550_SE_RGB_YUV_COEFFS + i * 4);
710 }
711 }
712
692 return 0; 713 return 0;
693} 714}
694 715
diff --git a/drivers/gpu/drm/arm/malidp_hw.h b/drivers/gpu/drm/arm/malidp_hw.h
index ad2e96915d44..9fc94c08190f 100644
--- a/drivers/gpu/drm/arm/malidp_hw.h
+++ b/drivers/gpu/drm/arm/malidp_hw.h
@@ -191,7 +191,8 @@ struct malidp_hw {
191 * @param fmt_id - internal format ID of output buffer 191 * @param fmt_id - internal format ID of output buffer
192 */ 192 */
193 int (*enable_memwrite)(struct malidp_hw_device *hwdev, dma_addr_t *addrs, 193 int (*enable_memwrite)(struct malidp_hw_device *hwdev, dma_addr_t *addrs,
194 s32 *pitches, int num_planes, u16 w, u16 h, u32 fmt_id); 194 s32 *pitches, int num_planes, u16 w, u16 h, u32 fmt_id,
195 const s16 *rgb2yuv_coeffs);
195 196
196 /* 197 /*
197 * Disable the writing to memory of the next frame's content. 198 * Disable the writing to memory of the next frame's content.
diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c
index ba6ae66387c9..91472e5e0c8b 100644
--- a/drivers/gpu/drm/arm/malidp_mw.c
+++ b/drivers/gpu/drm/arm/malidp_mw.c
@@ -26,6 +26,8 @@ struct malidp_mw_connector_state {
26 s32 pitches[2]; 26 s32 pitches[2];
27 u8 format; 27 u8 format;
28 u8 n_planes; 28 u8 n_planes;
29 bool rgb2yuv_initialized;
30 const s16 *rgb2yuv_coeffs;
29}; 31};
30 32
31static int malidp_mw_connector_get_modes(struct drm_connector *connector) 33static int malidp_mw_connector_get_modes(struct drm_connector *connector)
@@ -84,7 +86,7 @@ static void malidp_mw_connector_destroy(struct drm_connector *connector)
84static struct drm_connector_state * 86static struct drm_connector_state *
85malidp_mw_connector_duplicate_state(struct drm_connector *connector) 87malidp_mw_connector_duplicate_state(struct drm_connector *connector)
86{ 88{
87 struct malidp_mw_connector_state *mw_state; 89 struct malidp_mw_connector_state *mw_state, *mw_current_state;
88 90
89 if (WARN_ON(!connector->state)) 91 if (WARN_ON(!connector->state))
90 return NULL; 92 return NULL;
@@ -93,7 +95,10 @@ malidp_mw_connector_duplicate_state(struct drm_connector *connector)
93 if (!mw_state) 95 if (!mw_state)
94 return NULL; 96 return NULL;
95 97
96 /* No need to preserve any of our driver-local data */ 98 mw_current_state = to_mw_state(connector->state);
99 mw_state->rgb2yuv_coeffs = mw_current_state->rgb2yuv_coeffs;
100 mw_state->rgb2yuv_initialized = mw_current_state->rgb2yuv_initialized;
101
97 __drm_atomic_helper_connector_duplicate_state(connector, &mw_state->base); 102 __drm_atomic_helper_connector_duplicate_state(connector, &mw_state->base);
98 103
99 return &mw_state->base; 104 return &mw_state->base;
@@ -108,6 +113,13 @@ static const struct drm_connector_funcs malidp_mw_connector_funcs = {
108 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, 113 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
109}; 114};
110 115
116static const s16 rgb2yuv_coeffs_bt709_limited[MALIDP_COLORADJ_NUM_COEFFS] = {
117 47, 157, 16,
118 -26, -87, 112,
119 112, -102, -10,
120 16, 128, 128
121};
122
111static int 123static int
112malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, 124malidp_mw_encoder_atomic_check(struct drm_encoder *encoder,
113 struct drm_crtc_state *crtc_state, 125 struct drm_crtc_state *crtc_state,
@@ -157,6 +169,9 @@ malidp_mw_encoder_atomic_check(struct drm_encoder *encoder,
157 } 169 }
158 mw_state->n_planes = n_planes; 170 mw_state->n_planes = n_planes;
159 171
172 if (fb->format->is_yuv)
173 mw_state->rgb2yuv_coeffs = rgb2yuv_coeffs_bt709_limited;
174
160 return 0; 175 return 0;
161} 176}
162 177
@@ -239,10 +254,12 @@ void malidp_mw_atomic_commit(struct drm_device *drm,
239 254
240 drm_writeback_queue_job(mw_conn, conn_state->writeback_job); 255 drm_writeback_queue_job(mw_conn, conn_state->writeback_job);
241 conn_state->writeback_job = NULL; 256 conn_state->writeback_job = NULL;
242
243 hwdev->hw->enable_memwrite(hwdev, mw_state->addrs, 257 hwdev->hw->enable_memwrite(hwdev, mw_state->addrs,
244 mw_state->pitches, mw_state->n_planes, 258 mw_state->pitches, mw_state->n_planes,
245 fb->width, fb->height, mw_state->format); 259 fb->width, fb->height, mw_state->format,
260 !mw_state->rgb2yuv_initialized ?
261 mw_state->rgb2yuv_coeffs : NULL);
262 mw_state->rgb2yuv_initialized = !!mw_state->rgb2yuv_coeffs;
246 } else { 263 } else {
247 DRM_DEV_DEBUG_DRIVER(drm->dev, "Disable memwrite\n"); 264 DRM_DEV_DEBUG_DRIVER(drm->dev, "Disable memwrite\n");
248 hwdev->hw->disable_memwrite(hwdev); 265 hwdev->hw->disable_memwrite(hwdev);
diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h
index 3579d36b2a71..6ffe849774f2 100644
--- a/drivers/gpu/drm/arm/malidp_regs.h
+++ b/drivers/gpu/drm/arm/malidp_regs.h
@@ -205,6 +205,7 @@
205#define MALIDP500_SE_BASE 0x00c00 205#define MALIDP500_SE_BASE 0x00c00
206#define MALIDP500_SE_CONTROL 0x00c0c 206#define MALIDP500_SE_CONTROL 0x00c0c
207#define MALIDP500_SE_MEMWRITE_OUT_SIZE 0x00c2c 207#define MALIDP500_SE_MEMWRITE_OUT_SIZE 0x00c2c
208#define MALIDP500_SE_RGB_YUV_COEFFS 0x00C74
208#define MALIDP500_SE_MEMWRITE_BASE 0x00e00 209#define MALIDP500_SE_MEMWRITE_BASE 0x00e00
209#define MALIDP500_DC_IRQ_BASE 0x00f00 210#define MALIDP500_DC_IRQ_BASE 0x00f00
210#define MALIDP500_CONFIG_VALID 0x00f00 211#define MALIDP500_CONFIG_VALID 0x00f00
@@ -238,6 +239,7 @@
238#define MALIDP550_SE_CONTROL 0x08010 239#define MALIDP550_SE_CONTROL 0x08010
239#define MALIDP550_SE_MEMWRITE_ONESHOT (1 << 7) 240#define MALIDP550_SE_MEMWRITE_ONESHOT (1 << 7)
240#define MALIDP550_SE_MEMWRITE_OUT_SIZE 0x08030 241#define MALIDP550_SE_MEMWRITE_OUT_SIZE 0x08030
242#define MALIDP550_SE_RGB_YUV_COEFFS 0x08078
241#define MALIDP550_SE_MEMWRITE_BASE 0x08100 243#define MALIDP550_SE_MEMWRITE_BASE 0x08100
242#define MALIDP550_DC_BASE 0x0c000 244#define MALIDP550_DC_BASE 0x0c000
243#define MALIDP550_DC_CONTROL 0x0c010 245#define MALIDP550_DC_CONTROL 0x0c010
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 3eb061e11e2e..018fcdb353d2 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -2067,7 +2067,7 @@ static void __drm_state_dump(struct drm_device *dev, struct drm_printer *p,
2067 struct drm_connector *connector; 2067 struct drm_connector *connector;
2068 struct drm_connector_list_iter conn_iter; 2068 struct drm_connector_list_iter conn_iter;
2069 2069
2070 if (!drm_core_check_feature(dev, DRIVER_ATOMIC)) 2070 if (!drm_drv_uses_atomic_modeset(dev))
2071 return; 2071 return;
2072 2072
2073 list_for_each_entry(plane, &config->plane_list, head) { 2073 list_for_each_entry(plane, &config->plane_list, head) {
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index baff50a4c234..df31c3815092 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -63,20 +63,21 @@ static void drm_client_close(struct drm_client_dev *client)
63EXPORT_SYMBOL(drm_client_close); 63EXPORT_SYMBOL(drm_client_close);
64 64
65/** 65/**
66 * drm_client_new - Create a DRM client 66 * drm_client_init - Initialise a DRM client
67 * @dev: DRM device 67 * @dev: DRM device
68 * @client: DRM client 68 * @client: DRM client
69 * @name: Client name 69 * @name: Client name
70 * @funcs: DRM client functions (optional) 70 * @funcs: DRM client functions (optional)
71 * 71 *
72 * This initialises the client and opens a &drm_file. Use drm_client_add() to complete the process.
72 * The caller needs to hold a reference on @dev before calling this function. 73 * The caller needs to hold a reference on @dev before calling this function.
73 * The client is freed when the &drm_device is unregistered. See drm_client_release(). 74 * The client is freed when the &drm_device is unregistered. See drm_client_release().
74 * 75 *
75 * Returns: 76 * Returns:
76 * Zero on success or negative error code on failure. 77 * Zero on success or negative error code on failure.
77 */ 78 */
78int drm_client_new(struct drm_device *dev, struct drm_client_dev *client, 79int drm_client_init(struct drm_device *dev, struct drm_client_dev *client,
79 const char *name, const struct drm_client_funcs *funcs) 80 const char *name, const struct drm_client_funcs *funcs)
80{ 81{
81 int ret; 82 int ret;
82 83
@@ -95,10 +96,6 @@ int drm_client_new(struct drm_device *dev, struct drm_client_dev *client,
95 if (ret) 96 if (ret)
96 goto err_put_module; 97 goto err_put_module;
97 98
98 mutex_lock(&dev->clientlist_mutex);
99 list_add(&client->list, &dev->clientlist);
100 mutex_unlock(&dev->clientlist_mutex);
101
102 drm_dev_get(dev); 99 drm_dev_get(dev);
103 100
104 return 0; 101 return 0;
@@ -109,13 +106,33 @@ err_put_module:
109 106
110 return ret; 107 return ret;
111} 108}
112EXPORT_SYMBOL(drm_client_new); 109EXPORT_SYMBOL(drm_client_init);
110
111/**
112 * drm_client_add - Add client to the device list
113 * @client: DRM client
114 *
115 * Add the client to the &drm_device client list to activate its callbacks.
116 * @client must be initialized by a call to drm_client_init(). After
117 * drm_client_add() it is no longer permissible to call drm_client_release()
118 * directly (outside the unregister callback), instead cleanup will happen
119 * automatically on driver unload.
120 */
121void drm_client_add(struct drm_client_dev *client)
122{
123 struct drm_device *dev = client->dev;
124
125 mutex_lock(&dev->clientlist_mutex);
126 list_add(&client->list, &dev->clientlist);
127 mutex_unlock(&dev->clientlist_mutex);
128}
129EXPORT_SYMBOL(drm_client_add);
113 130
114/** 131/**
115 * drm_client_release - Release DRM client resources 132 * drm_client_release - Release DRM client resources
116 * @client: DRM client 133 * @client: DRM client
117 * 134 *
118 * Releases resources by closing the &drm_file that was opened by drm_client_new(). 135 * Releases resources by closing the &drm_file that was opened by drm_client_init().
119 * It is called automatically if the &drm_client_funcs.unregister callback is _not_ set. 136 * It is called automatically if the &drm_client_funcs.unregister callback is _not_ set.
120 * 137 *
121 * This function should only be called from the unregister callback. An exception 138 * This function should only be called from the unregister callback. An exception
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 6f28fe58f169..373bd4c2b698 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -151,7 +151,7 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id,
151 return ret; 151 return ret;
152 } 152 }
153 153
154 if (drm_core_check_feature(dev, DRIVER_ATOMIC)) { 154 if (drm_drv_uses_atomic_modeset(dev)) {
155 ret = drm_atomic_debugfs_init(minor); 155 ret = drm_atomic_debugfs_init(minor);
156 if (ret) { 156 if (ret) {
157 DRM_ERROR("Failed to create atomic debugfs files\n"); 157 DRM_ERROR("Failed to create atomic debugfs files\n");
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index 9da36a6271d3..9ac1f2e0f064 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -160,7 +160,7 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev,
160 160
161 fb_helper = &fbdev_cma->fb_helper; 161 fb_helper = &fbdev_cma->fb_helper;
162 162
163 ret = drm_client_new(dev, &fb_helper->client, "fbdev", NULL); 163 ret = drm_client_init(dev, &fb_helper->client, "fbdev", NULL);
164 if (ret) 164 if (ret)
165 goto err_free; 165 goto err_free;
166 166
@@ -169,6 +169,8 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev,
169 if (ret) 169 if (ret)
170 goto err_client_put; 170 goto err_client_put;
171 171
172 drm_client_add(&fb_helper->client);
173
172 return fbdev_cma; 174 return fbdev_cma;
173 175
174err_client_put: 176err_client_put:
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 4b0dd20bccb8..515a7aec57ac 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2370,7 +2370,6 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,
2370{ 2370{
2371 int c, o; 2371 int c, o;
2372 struct drm_connector *connector; 2372 struct drm_connector *connector;
2373 const struct drm_connector_helper_funcs *connector_funcs;
2374 int my_score, best_score, score; 2373 int my_score, best_score, score;
2375 struct drm_fb_helper_crtc **crtcs, *crtc; 2374 struct drm_fb_helper_crtc **crtcs, *crtc;
2376 struct drm_fb_helper_connector *fb_helper_conn; 2375 struct drm_fb_helper_connector *fb_helper_conn;
@@ -2399,8 +2398,6 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,
2399 if (drm_has_preferred_mode(fb_helper_conn, width, height)) 2398 if (drm_has_preferred_mode(fb_helper_conn, width, height))
2400 my_score++; 2399 my_score++;
2401 2400
2402 connector_funcs = connector->helper_private;
2403
2404 /* 2401 /*
2405 * select a crtc for this connector and then attempt to configure 2402 * select a crtc for this connector and then attempt to configure
2406 * remaining connectors 2403 * remaining connectors
@@ -3221,12 +3218,14 @@ int drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
3221 if (!fb_helper) 3218 if (!fb_helper)
3222 return -ENOMEM; 3219 return -ENOMEM;
3223 3220
3224 ret = drm_client_new(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs); 3221 ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs);
3225 if (ret) { 3222 if (ret) {
3226 kfree(fb_helper); 3223 kfree(fb_helper);
3227 return ret; 3224 return ret;
3228 } 3225 }
3229 3226
3227 drm_client_add(&fb_helper->client);
3228
3230 fb_helper->preferred_bpp = preferred_bpp; 3229 fb_helper->preferred_bpp = preferred_bpp;
3231 3230
3232 drm_fbdev_client_hotplug(&fb_helper->client); 3231 drm_fbdev_client_hotplug(&fb_helper->client);
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c
index b54fb78a283c..b82da96ded5c 100644
--- a/drivers/gpu/drm/drm_lease.c
+++ b/drivers/gpu/drm/drm_lease.c
@@ -566,14 +566,14 @@ int drm_mode_create_lease_ioctl(struct drm_device *dev,
566 lessee_priv->is_master = 1; 566 lessee_priv->is_master = 1;
567 lessee_priv->authenticated = 1; 567 lessee_priv->authenticated = 1;
568 568
569 /* Hook up the fd */
570 fd_install(fd, lessee_file);
571
572 /* Pass fd back to userspace */ 569 /* Pass fd back to userspace */
573 DRM_DEBUG_LEASE("Returning fd %d id %d\n", fd, lessee->lessee_id); 570 DRM_DEBUG_LEASE("Returning fd %d id %d\n", fd, lessee->lessee_id);
574 cl->fd = fd; 571 cl->fd = fd;
575 cl->lessee_id = lessee->lessee_id; 572 cl->lessee_id = lessee->lessee_id;
576 573
574 /* Hook up the fd */
575 fd_install(fd, lessee_file);
576
577 DRM_DEBUG_LEASE("drm_mode_create_lease_ioctl succeeded\n"); 577 DRM_DEBUG_LEASE("drm_mode_create_lease_ioctl succeeded\n");
578 return 0; 578 return 0;
579 579
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index b902361dee6e..1d9a9d2fe0e0 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -24,7 +24,6 @@
24#include <linux/err.h> 24#include <linux/err.h>
25#include <linux/module.h> 25#include <linux/module.h>
26 26
27#include <drm/drm_device.h>
28#include <drm/drm_crtc.h> 27#include <drm/drm_crtc.h>
29#include <drm/drm_panel.h> 28#include <drm/drm_panel.h>
30 29
@@ -105,13 +104,6 @@ int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector)
105 if (panel->connector) 104 if (panel->connector)
106 return -EBUSY; 105 return -EBUSY;
107 106
108 panel->link = device_link_add(connector->dev->dev, panel->dev, 0);
109 if (!panel->link) {
110 dev_err(panel->dev, "failed to link panel to %s\n",
111 dev_name(connector->dev->dev));
112 return -EINVAL;
113 }
114
115 panel->connector = connector; 107 panel->connector = connector;
116 panel->drm = connector->dev; 108 panel->drm = connector->dev;
117 109
@@ -133,8 +125,6 @@ EXPORT_SYMBOL(drm_panel_attach);
133 */ 125 */
134int drm_panel_detach(struct drm_panel *panel) 126int drm_panel_detach(struct drm_panel *panel)
135{ 127{
136 device_link_del(panel->link);
137
138 panel->connector = NULL; 128 panel->connector = NULL;
139 panel->drm = NULL; 129 panel->drm = NULL;
140 130
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index adb3cb27d31e..759278fef35a 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -97,6 +97,8 @@ static int drm_syncobj_fence_get_or_add_callback(struct drm_syncobj *syncobj,
97{ 97{
98 int ret; 98 int ret;
99 99
100 WARN_ON(*fence);
101
100 *fence = drm_syncobj_fence_get(syncobj); 102 *fence = drm_syncobj_fence_get(syncobj);
101 if (*fence) 103 if (*fence)
102 return 1; 104 return 1;
@@ -743,6 +745,9 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,
743 745
744 if (flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT) { 746 if (flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT) {
745 for (i = 0; i < count; ++i) { 747 for (i = 0; i < count; ++i) {
748 if (entries[i].fence)
749 continue;
750
746 drm_syncobj_fence_get_or_add_callback(syncobjs[i], 751 drm_syncobj_fence_get_or_add_callback(syncobjs[i],
747 &entries[i].fence, 752 &entries[i].fence,
748 &entries[i].syncobj_cb, 753 &entries[i].syncobj_cb,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 9b2720b41571..83c1f46670bf 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -592,8 +592,6 @@ static int etnaviv_pdev_probe(struct platform_device *pdev)
592 struct device *dev = &pdev->dev; 592 struct device *dev = &pdev->dev;
593 struct component_match *match = NULL; 593 struct component_match *match = NULL;
594 594
595 dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
596
597 if (!dev->platform_data) { 595 if (!dev->platform_data) {
598 struct device_node *core_node; 596 struct device_node *core_node;
599 597
@@ -655,13 +653,30 @@ static int __init etnaviv_init(void)
655 for_each_compatible_node(np, NULL, "vivante,gc") { 653 for_each_compatible_node(np, NULL, "vivante,gc") {
656 if (!of_device_is_available(np)) 654 if (!of_device_is_available(np))
657 continue; 655 continue;
658 pdev = platform_device_register_simple("etnaviv", -1, 656
659 NULL, 0); 657 pdev = platform_device_alloc("etnaviv", -1);
660 if (IS_ERR(pdev)) { 658 if (!pdev) {
661 ret = PTR_ERR(pdev); 659 ret = -ENOMEM;
660 of_node_put(np);
661 goto unregister_platform_driver;
662 }
663 pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40);
664 pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
665
666 /*
667 * Apply the same DMA configuration to the virtual etnaviv
668 * device as the GPU we found. This assumes that all Vivante
669 * GPUs in the system share the same DMA constraints.
670 */
671 of_dma_configure(&pdev->dev, np, true);
672
673 ret = platform_device_add(pdev);
674 if (ret) {
675 platform_device_put(pdev);
662 of_node_put(np); 676 of_node_put(np);
663 goto unregister_platform_driver; 677 goto unregister_platform_driver;
664 } 678 }
679
665 etnaviv_drm = pdev; 680 etnaviv_drm = pdev;
666 of_node_put(np); 681 of_node_put(np);
667 break; 682 break;
diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
index 87f6b5672e11..797d9ee5f15a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
@@ -55,37 +55,12 @@ static inline void __exynos_iommu_detach(struct exynos_drm_private *priv,
55static inline int __exynos_iommu_create_mapping(struct exynos_drm_private *priv, 55static inline int __exynos_iommu_create_mapping(struct exynos_drm_private *priv,
56 unsigned long start, unsigned long size) 56 unsigned long start, unsigned long size)
57{ 57{
58 struct iommu_domain *domain; 58 priv->mapping = iommu_get_domain_for_dev(priv->dma_dev);
59 int ret;
60
61 domain = iommu_domain_alloc(priv->dma_dev->bus);
62 if (!domain)
63 return -ENOMEM;
64
65 ret = iommu_get_dma_cookie(domain);
66 if (ret)
67 goto free_domain;
68
69 ret = iommu_dma_init_domain(domain, start, size, NULL);
70 if (ret)
71 goto put_cookie;
72
73 priv->mapping = domain;
74 return 0; 59 return 0;
75
76put_cookie:
77 iommu_put_dma_cookie(domain);
78free_domain:
79 iommu_domain_free(domain);
80 return ret;
81} 60}
82 61
83static inline void __exynos_iommu_release_mapping(struct exynos_drm_private *priv) 62static inline void __exynos_iommu_release_mapping(struct exynos_drm_private *priv)
84{ 63{
85 struct iommu_domain *domain = priv->mapping;
86
87 iommu_put_dma_cookie(domain);
88 iommu_domain_free(domain);
89 priv->mapping = NULL; 64 priv->mapping = NULL;
90} 65}
91 66
@@ -94,7 +69,9 @@ static inline int __exynos_iommu_attach(struct exynos_drm_private *priv,
94{ 69{
95 struct iommu_domain *domain = priv->mapping; 70 struct iommu_domain *domain = priv->mapping;
96 71
97 return iommu_attach_device(domain, dev); 72 if (dev != priv->dma_dev)
73 return iommu_attach_device(domain, dev);
74 return 0;
98} 75}
99 76
100static inline void __exynos_iommu_detach(struct exynos_drm_private *priv, 77static inline void __exynos_iommu_detach(struct exynos_drm_private *priv,
@@ -102,7 +79,8 @@ static inline void __exynos_iommu_detach(struct exynos_drm_private *priv,
102{ 79{
103 struct iommu_domain *domain = priv->mapping; 80 struct iommu_domain *domain = priv->mapping;
104 81
105 iommu_detach_device(domain, dev); 82 if (dev != priv->dma_dev)
83 iommu_detach_device(domain, dev);
106} 84}
107#else 85#else
108#error Unsupported architecture and IOMMU/DMA-mapping glue code 86#error Unsupported architecture and IOMMU/DMA-mapping glue code
diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c
index 5d2f0d548469..250b5e02a314 100644
--- a/drivers/gpu/drm/i2c/tda9950.c
+++ b/drivers/gpu/drm/i2c/tda9950.c
@@ -191,7 +191,8 @@ static irqreturn_t tda9950_irq(int irq, void *data)
191 break; 191 break;
192 } 192 }
193 /* TDA9950 executes all retries for us */ 193 /* TDA9950 executes all retries for us */
194 tx_status |= CEC_TX_STATUS_MAX_RETRIES; 194 if (tx_status != CEC_TX_STATUS_OK)
195 tx_status |= CEC_TX_STATUS_MAX_RETRIES;
195 cec_transmit_done(priv->adap, tx_status, arb_lost_cnt, 196 cec_transmit_done(priv->adap, tx_status, arb_lost_cnt,
196 nack_cnt, 0, err_cnt); 197 nack_cnt, 0, err_cnt);
197 break; 198 break;
@@ -310,7 +311,7 @@ static void tda9950_release(struct tda9950_priv *priv)
310 /* Wait up to .5s for it to signal non-busy */ 311 /* Wait up to .5s for it to signal non-busy */
311 do { 312 do {
312 csr = tda9950_read(client, REG_CSR); 313 csr = tda9950_read(client, REG_CSR);
313 if (!(csr & CSR_BUSY) || --timeout) 314 if (!(csr & CSR_BUSY) || !--timeout)
314 break; 315 break;
315 msleep(10); 316 msleep(10);
316 } while (1); 317 } while (1);
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 72afa518edd9..94c1089ecf59 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -3210,6 +3210,7 @@ static int init_bxt_mmio_info(struct intel_gvt *gvt)
3210 MMIO_D(BXT_DSI_PLL_ENABLE, D_BXT); 3210 MMIO_D(BXT_DSI_PLL_ENABLE, D_BXT);
3211 3211
3212 MMIO_D(GEN9_CLKGATE_DIS_0, D_BXT); 3212 MMIO_D(GEN9_CLKGATE_DIS_0, D_BXT);
3213 MMIO_D(GEN9_CLKGATE_DIS_4, D_BXT);
3213 3214
3214 MMIO_D(HSW_TVIDEO_DIP_GCP(TRANSCODER_A), D_BXT); 3215 MMIO_D(HSW_TVIDEO_DIP_GCP(TRANSCODER_A), D_BXT);
3215 MMIO_D(HSW_TVIDEO_DIP_GCP(TRANSCODER_B), D_BXT); 3216 MMIO_D(HSW_TVIDEO_DIP_GCP(TRANSCODER_B), D_BXT);
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index a45f46d8537f..9ad89e38f6c0 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -32,6 +32,7 @@
32#include <linux/device.h> 32#include <linux/device.h>
33#include <linux/mm.h> 33#include <linux/mm.h>
34#include <linux/mmu_context.h> 34#include <linux/mmu_context.h>
35#include <linux/sched/mm.h>
35#include <linux/types.h> 36#include <linux/types.h>
36#include <linux/list.h> 37#include <linux/list.h>
37#include <linux/rbtree.h> 38#include <linux/rbtree.h>
@@ -1792,16 +1793,21 @@ static int kvmgt_rw_gpa(unsigned long handle, unsigned long gpa,
1792 info = (struct kvmgt_guest_info *)handle; 1793 info = (struct kvmgt_guest_info *)handle;
1793 kvm = info->kvm; 1794 kvm = info->kvm;
1794 1795
1795 if (kthread) 1796 if (kthread) {
1797 if (!mmget_not_zero(kvm->mm))
1798 return -EFAULT;
1796 use_mm(kvm->mm); 1799 use_mm(kvm->mm);
1800 }
1797 1801
1798 idx = srcu_read_lock(&kvm->srcu); 1802 idx = srcu_read_lock(&kvm->srcu);
1799 ret = write ? kvm_write_guest(kvm, gpa, buf, len) : 1803 ret = write ? kvm_write_guest(kvm, gpa, buf, len) :
1800 kvm_read_guest(kvm, gpa, buf, len); 1804 kvm_read_guest(kvm, gpa, buf, len);
1801 srcu_read_unlock(&kvm->srcu, idx); 1805 srcu_read_unlock(&kvm->srcu, idx);
1802 1806
1803 if (kthread) 1807 if (kthread) {
1804 unuse_mm(kvm->mm); 1808 unuse_mm(kvm->mm);
1809 mmput(kvm->mm);
1810 }
1805 1811
1806 return ret; 1812 return ret;
1807} 1813}
@@ -1827,6 +1833,8 @@ static bool kvmgt_is_valid_gfn(unsigned long handle, unsigned long gfn)
1827{ 1833{
1828 struct kvmgt_guest_info *info; 1834 struct kvmgt_guest_info *info;
1829 struct kvm *kvm; 1835 struct kvm *kvm;
1836 int idx;
1837 bool ret;
1830 1838
1831 if (!handle_valid(handle)) 1839 if (!handle_valid(handle))
1832 return false; 1840 return false;
@@ -1834,8 +1842,11 @@ static bool kvmgt_is_valid_gfn(unsigned long handle, unsigned long gfn)
1834 info = (struct kvmgt_guest_info *)handle; 1842 info = (struct kvmgt_guest_info *)handle;
1835 kvm = info->kvm; 1843 kvm = info->kvm;
1836 1844
1837 return kvm_is_visible_gfn(kvm, gfn); 1845 idx = srcu_read_lock(&kvm->srcu);
1846 ret = kvm_is_visible_gfn(kvm, gfn);
1847 srcu_read_unlock(&kvm->srcu, idx);
1838 1848
1849 return ret;
1839} 1850}
1840 1851
1841struct intel_gvt_mpt kvmgt_mpt = { 1852struct intel_gvt_mpt kvmgt_mpt = {
diff --git a/drivers/gpu/drm/i915/gvt/mmio.c b/drivers/gpu/drm/i915/gvt/mmio.c
index 994366035364..9bb9a85c992c 100644
--- a/drivers/gpu/drm/i915/gvt/mmio.c
+++ b/drivers/gpu/drm/i915/gvt/mmio.c
@@ -244,6 +244,34 @@ void intel_vgpu_reset_mmio(struct intel_vgpu *vgpu, bool dmlr)
244 244
245 /* set the bit 0:2(Core C-State ) to C0 */ 245 /* set the bit 0:2(Core C-State ) to C0 */
246 vgpu_vreg_t(vgpu, GEN6_GT_CORE_STATUS) = 0; 246 vgpu_vreg_t(vgpu, GEN6_GT_CORE_STATUS) = 0;
247
248 if (IS_BROXTON(vgpu->gvt->dev_priv)) {
249 vgpu_vreg_t(vgpu, BXT_P_CR_GT_DISP_PWRON) &=
250 ~(BIT(0) | BIT(1));
251 vgpu_vreg_t(vgpu, BXT_PORT_CL1CM_DW0(DPIO_PHY0)) &=
252 ~PHY_POWER_GOOD;
253 vgpu_vreg_t(vgpu, BXT_PORT_CL1CM_DW0(DPIO_PHY1)) &=
254 ~PHY_POWER_GOOD;
255 vgpu_vreg_t(vgpu, BXT_PHY_CTL_FAMILY(DPIO_PHY0)) &=
256 ~BIT(30);
257 vgpu_vreg_t(vgpu, BXT_PHY_CTL_FAMILY(DPIO_PHY1)) &=
258 ~BIT(30);
259 vgpu_vreg_t(vgpu, BXT_PHY_CTL(PORT_A)) &=
260 ~BXT_PHY_LANE_ENABLED;
261 vgpu_vreg_t(vgpu, BXT_PHY_CTL(PORT_A)) |=
262 BXT_PHY_CMNLANE_POWERDOWN_ACK |
263 BXT_PHY_LANE_POWERDOWN_ACK;
264 vgpu_vreg_t(vgpu, BXT_PHY_CTL(PORT_B)) &=
265 ~BXT_PHY_LANE_ENABLED;
266 vgpu_vreg_t(vgpu, BXT_PHY_CTL(PORT_B)) |=
267 BXT_PHY_CMNLANE_POWERDOWN_ACK |
268 BXT_PHY_LANE_POWERDOWN_ACK;
269 vgpu_vreg_t(vgpu, BXT_PHY_CTL(PORT_C)) &=
270 ~BXT_PHY_LANE_ENABLED;
271 vgpu_vreg_t(vgpu, BXT_PHY_CTL(PORT_C)) |=
272 BXT_PHY_CMNLANE_POWERDOWN_ACK |
273 BXT_PHY_LANE_POWERDOWN_ACK;
274 }
247 } else { 275 } else {
248#define GVT_GEN8_MMIO_RESET_OFFSET (0x44200) 276#define GVT_GEN8_MMIO_RESET_OFFSET (0x44200)
249 /* only reset the engine related, so starting with 0x44200 277 /* only reset the engine related, so starting with 0x44200
diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c
index fa75a2eead90..b0d3a43ccd03 100644
--- a/drivers/gpu/drm/i915/gvt/opregion.c
+++ b/drivers/gpu/drm/i915/gvt/opregion.c
@@ -42,8 +42,6 @@
42#define DEVICE_TYPE_EFP3 0x20 42#define DEVICE_TYPE_EFP3 0x20
43#define DEVICE_TYPE_EFP4 0x10 43#define DEVICE_TYPE_EFP4 0x10
44 44
45#define DEV_SIZE 38
46
47struct opregion_header { 45struct opregion_header {
48 u8 signature[16]; 46 u8 signature[16];
49 u32 size; 47 u32 size;
@@ -63,6 +61,10 @@ struct bdb_data_header {
63 u16 size; /* data size */ 61 u16 size; /* data size */
64} __packed; 62} __packed;
65 63
64/* For supporting windows guest with opregion, here hardcode the emulated
65 * bdb header version as '186', and the corresponding child_device_config
66 * length should be '33' but not '38'.
67 */
66struct efp_child_device_config { 68struct efp_child_device_config {
67 u16 handle; 69 u16 handle;
68 u16 device_type; 70 u16 device_type;
@@ -109,12 +111,6 @@ struct efp_child_device_config {
109 u8 mipi_bridge_type; /* 171 */ 111 u8 mipi_bridge_type; /* 171 */
110 u16 device_class_ext; 112 u16 device_class_ext;
111 u8 dvo_function; 113 u8 dvo_function;
112 u8 dp_usb_type_c:1; /* 195 */
113 u8 skip6:7;
114 u8 dp_usb_type_c_2x_gpio_index; /* 195 */
115 u16 dp_usb_type_c_2x_gpio_pin; /* 195 */
116 u8 iboost_dp:4; /* 196 */
117 u8 iboost_hdmi:4; /* 196 */
118} __packed; 114} __packed;
119 115
120struct vbt { 116struct vbt {
@@ -155,7 +151,7 @@ static void virt_vbt_generation(struct vbt *v)
155 v->header.bdb_offset = offsetof(struct vbt, bdb_header); 151 v->header.bdb_offset = offsetof(struct vbt, bdb_header);
156 152
157 strcpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK"); 153 strcpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
158 v->bdb_header.version = 186; /* child_dev_size = 38 */ 154 v->bdb_header.version = 186; /* child_dev_size = 33 */
159 v->bdb_header.header_size = sizeof(v->bdb_header); 155 v->bdb_header.header_size = sizeof(v->bdb_header);
160 156
161 v->bdb_header.bdb_size = sizeof(struct vbt) - sizeof(struct vbt_header) 157 v->bdb_header.bdb_size = sizeof(struct vbt) - sizeof(struct vbt_header)
@@ -169,11 +165,13 @@ static void virt_vbt_generation(struct vbt *v)
169 165
170 /* child device */ 166 /* child device */
171 num_child = 4; /* each port has one child */ 167 num_child = 4; /* each port has one child */
168 v->general_definitions.child_dev_size =
169 sizeof(struct efp_child_device_config);
172 v->general_definitions_header.id = BDB_GENERAL_DEFINITIONS; 170 v->general_definitions_header.id = BDB_GENERAL_DEFINITIONS;
173 /* size will include child devices */ 171 /* size will include child devices */
174 v->general_definitions_header.size = 172 v->general_definitions_header.size =
175 sizeof(struct bdb_general_definitions) + num_child * DEV_SIZE; 173 sizeof(struct bdb_general_definitions) +
176 v->general_definitions.child_dev_size = DEV_SIZE; 174 num_child * v->general_definitions.child_dev_size;
177 175
178 /* portA */ 176 /* portA */
179 v->child0.handle = DEVICE_TYPE_EFP1; 177 v->child0.handle = DEVICE_TYPE_EFP1;
diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
index a4e8e3cf74fd..c628be05fbfe 100644
--- a/drivers/gpu/drm/i915/gvt/vgpu.c
+++ b/drivers/gpu/drm/i915/gvt/vgpu.c
@@ -281,6 +281,7 @@ void intel_gvt_destroy_vgpu(struct intel_vgpu *vgpu)
281 intel_vgpu_clean_submission(vgpu); 281 intel_vgpu_clean_submission(vgpu);
282 intel_vgpu_clean_display(vgpu); 282 intel_vgpu_clean_display(vgpu);
283 intel_vgpu_clean_opregion(vgpu); 283 intel_vgpu_clean_opregion(vgpu);
284 intel_vgpu_reset_ggtt(vgpu, true);
284 intel_vgpu_clean_gtt(vgpu); 285 intel_vgpu_clean_gtt(vgpu);
285 intel_gvt_hypervisor_detach_vgpu(vgpu); 286 intel_gvt_hypervisor_detach_vgpu(vgpu);
286 intel_vgpu_free_resource(vgpu); 287 intel_vgpu_free_resource(vgpu);
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index f7f2aa71d8d9..a262a64f5625 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -232,6 +232,20 @@ static bool compress_init(struct compress *c)
232 return true; 232 return true;
233} 233}
234 234
235static void *compress_next_page(struct drm_i915_error_object *dst)
236{
237 unsigned long page;
238
239 if (dst->page_count >= dst->num_pages)
240 return ERR_PTR(-ENOSPC);
241
242 page = __get_free_page(GFP_ATOMIC | __GFP_NOWARN);
243 if (!page)
244 return ERR_PTR(-ENOMEM);
245
246 return dst->pages[dst->page_count++] = (void *)page;
247}
248
235static int compress_page(struct compress *c, 249static int compress_page(struct compress *c,
236 void *src, 250 void *src,
237 struct drm_i915_error_object *dst) 251 struct drm_i915_error_object *dst)
@@ -245,19 +259,14 @@ static int compress_page(struct compress *c,
245 259
246 do { 260 do {
247 if (zstream->avail_out == 0) { 261 if (zstream->avail_out == 0) {
248 unsigned long page; 262 zstream->next_out = compress_next_page(dst);
249 263 if (IS_ERR(zstream->next_out))
250 page = __get_free_page(GFP_ATOMIC | __GFP_NOWARN); 264 return PTR_ERR(zstream->next_out);
251 if (!page)
252 return -ENOMEM;
253 265
254 dst->pages[dst->page_count++] = (void *)page;
255
256 zstream->next_out = (void *)page;
257 zstream->avail_out = PAGE_SIZE; 266 zstream->avail_out = PAGE_SIZE;
258 } 267 }
259 268
260 if (zlib_deflate(zstream, Z_SYNC_FLUSH) != Z_OK) 269 if (zlib_deflate(zstream, Z_NO_FLUSH) != Z_OK)
261 return -EIO; 270 return -EIO;
262 } while (zstream->avail_in); 271 } while (zstream->avail_in);
263 272
@@ -268,19 +277,42 @@ static int compress_page(struct compress *c,
268 return 0; 277 return 0;
269} 278}
270 279
271static void compress_fini(struct compress *c, 280static int compress_flush(struct compress *c,
272 struct drm_i915_error_object *dst) 281 struct drm_i915_error_object *dst)
273{ 282{
274 struct z_stream_s *zstream = &c->zstream; 283 struct z_stream_s *zstream = &c->zstream;
275 284
276 if (dst) { 285 do {
277 zlib_deflate(zstream, Z_FINISH); 286 switch (zlib_deflate(zstream, Z_FINISH)) {
278 dst->unused = zstream->avail_out; 287 case Z_OK: /* more space requested */
279 } 288 zstream->next_out = compress_next_page(dst);
289 if (IS_ERR(zstream->next_out))
290 return PTR_ERR(zstream->next_out);
291
292 zstream->avail_out = PAGE_SIZE;
293 break;
294
295 case Z_STREAM_END:
296 goto end;
297
298 default: /* any error */
299 return -EIO;
300 }
301 } while (1);
302
303end:
304 memset(zstream->next_out, 0, zstream->avail_out);
305 dst->unused = zstream->avail_out;
306 return 0;
307}
308
309static void compress_fini(struct compress *c,
310 struct drm_i915_error_object *dst)
311{
312 struct z_stream_s *zstream = &c->zstream;
280 313
281 zlib_deflateEnd(zstream); 314 zlib_deflateEnd(zstream);
282 kfree(zstream->workspace); 315 kfree(zstream->workspace);
283
284 if (c->tmp) 316 if (c->tmp)
285 free_page((unsigned long)c->tmp); 317 free_page((unsigned long)c->tmp);
286} 318}
@@ -319,6 +351,12 @@ static int compress_page(struct compress *c,
319 return 0; 351 return 0;
320} 352}
321 353
354static int compress_flush(struct compress *c,
355 struct drm_i915_error_object *dst)
356{
357 return 0;
358}
359
322static void compress_fini(struct compress *c, 360static void compress_fini(struct compress *c,
323 struct drm_i915_error_object *dst) 361 struct drm_i915_error_object *dst)
324{ 362{
@@ -917,6 +955,7 @@ i915_error_object_create(struct drm_i915_private *i915,
917 unsigned long num_pages; 955 unsigned long num_pages;
918 struct sgt_iter iter; 956 struct sgt_iter iter;
919 dma_addr_t dma; 957 dma_addr_t dma;
958 int ret;
920 959
921 if (!vma) 960 if (!vma)
922 return NULL; 961 return NULL;
@@ -930,6 +969,7 @@ i915_error_object_create(struct drm_i915_private *i915,
930 969
931 dst->gtt_offset = vma->node.start; 970 dst->gtt_offset = vma->node.start;
932 dst->gtt_size = vma->node.size; 971 dst->gtt_size = vma->node.size;
972 dst->num_pages = num_pages;
933 dst->page_count = 0; 973 dst->page_count = 0;
934 dst->unused = 0; 974 dst->unused = 0;
935 975
@@ -938,28 +978,26 @@ i915_error_object_create(struct drm_i915_private *i915,
938 return NULL; 978 return NULL;
939 } 979 }
940 980
981 ret = -EINVAL;
941 for_each_sgt_dma(dma, iter, vma->pages) { 982 for_each_sgt_dma(dma, iter, vma->pages) {
942 void __iomem *s; 983 void __iomem *s;
943 int ret;
944 984
945 ggtt->vm.insert_page(&ggtt->vm, dma, slot, I915_CACHE_NONE, 0); 985 ggtt->vm.insert_page(&ggtt->vm, dma, slot, I915_CACHE_NONE, 0);
946 986
947 s = io_mapping_map_atomic_wc(&ggtt->iomap, slot); 987 s = io_mapping_map_atomic_wc(&ggtt->iomap, slot);
948 ret = compress_page(&compress, (void __force *)s, dst); 988 ret = compress_page(&compress, (void __force *)s, dst);
949 io_mapping_unmap_atomic(s); 989 io_mapping_unmap_atomic(s);
950
951 if (ret) 990 if (ret)
952 goto unwind; 991 break;
953 } 992 }
954 goto out;
955 993
956unwind: 994 if (ret || compress_flush(&compress, dst)) {
957 while (dst->page_count--) 995 while (dst->page_count--)
958 free_page((unsigned long)dst->pages[dst->page_count]); 996 free_page((unsigned long)dst->pages[dst->page_count]);
959 kfree(dst); 997 kfree(dst);
960 dst = NULL; 998 dst = NULL;
999 }
961 1000
962out:
963 compress_fini(&compress, dst); 1001 compress_fini(&compress, dst);
964 ggtt->vm.clear_range(&ggtt->vm, slot, PAGE_SIZE); 1002 ggtt->vm.clear_range(&ggtt->vm, slot, PAGE_SIZE);
965 return dst; 1003 return dst;
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
index f893a4e8b783..8710fb18ed74 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.h
+++ b/drivers/gpu/drm/i915/i915_gpu_error.h
@@ -135,6 +135,7 @@ struct i915_gpu_state {
135 struct drm_i915_error_object { 135 struct drm_i915_error_object {
136 u64 gtt_offset; 136 u64 gtt_offset;
137 u64 gtt_size; 137 u64 gtt_size;
138 int num_pages;
138 int page_count; 139 int page_count;
139 int unused; 140 int unused;
140 u32 *pages[0]; 141 u32 *pages[0];
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 90628a47ae17..29877969310d 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3091,36 +3091,27 @@ gen11_gt_irq_handler(struct drm_i915_private * const i915,
3091 spin_unlock(&i915->irq_lock); 3091 spin_unlock(&i915->irq_lock);
3092} 3092}
3093 3093
3094static void 3094static u32
3095gen11_gu_misc_irq_ack(struct drm_i915_private *dev_priv, const u32 master_ctl, 3095gen11_gu_misc_irq_ack(struct drm_i915_private *dev_priv, const u32 master_ctl)
3096 u32 *iir)
3097{ 3096{
3098 void __iomem * const regs = dev_priv->regs; 3097 void __iomem * const regs = dev_priv->regs;
3098 u32 iir;
3099 3099
3100 if (!(master_ctl & GEN11_GU_MISC_IRQ)) 3100 if (!(master_ctl & GEN11_GU_MISC_IRQ))
3101 return; 3101 return 0;
3102
3103 iir = raw_reg_read(regs, GEN11_GU_MISC_IIR);
3104 if (likely(iir))
3105 raw_reg_write(regs, GEN11_GU_MISC_IIR, iir);
3102 3106
3103 *iir = raw_reg_read(regs, GEN11_GU_MISC_IIR); 3107 return iir;
3104 if (likely(*iir))
3105 raw_reg_write(regs, GEN11_GU_MISC_IIR, *iir);
3106} 3108}
3107 3109
3108static void 3110static void
3109gen11_gu_misc_irq_handler(struct drm_i915_private *dev_priv, 3111gen11_gu_misc_irq_handler(struct drm_i915_private *dev_priv, const u32 iir)
3110 const u32 master_ctl, const u32 iir)
3111{ 3112{
3112 if (!(master_ctl & GEN11_GU_MISC_IRQ))
3113 return;
3114
3115 if (unlikely(!iir)) {
3116 DRM_ERROR("GU_MISC iir blank!\n");
3117 return;
3118 }
3119
3120 if (iir & GEN11_GU_MISC_GSE) 3113 if (iir & GEN11_GU_MISC_GSE)
3121 intel_opregion_asle_intr(dev_priv); 3114 intel_opregion_asle_intr(dev_priv);
3122 else
3123 DRM_ERROR("Unexpected GU_MISC interrupt 0x%x\n", iir);
3124} 3115}
3125 3116
3126static irqreturn_t gen11_irq_handler(int irq, void *arg) 3117static irqreturn_t gen11_irq_handler(int irq, void *arg)
@@ -3157,12 +3148,12 @@ static irqreturn_t gen11_irq_handler(int irq, void *arg)
3157 enable_rpm_wakeref_asserts(i915); 3148 enable_rpm_wakeref_asserts(i915);
3158 } 3149 }
3159 3150
3160 gen11_gu_misc_irq_ack(i915, master_ctl, &gu_misc_iir); 3151 gu_misc_iir = gen11_gu_misc_irq_ack(i915, master_ctl);
3161 3152
3162 /* Acknowledge and enable interrupts. */ 3153 /* Acknowledge and enable interrupts. */
3163 raw_reg_write(regs, GEN11_GFX_MSTR_IRQ, GEN11_MASTER_IRQ | master_ctl); 3154 raw_reg_write(regs, GEN11_GFX_MSTR_IRQ, GEN11_MASTER_IRQ | master_ctl);
3164 3155
3165 gen11_gu_misc_irq_handler(i915, master_ctl, gu_misc_iir); 3156 gen11_gu_misc_irq_handler(i915, gu_misc_iir);
3166 3157
3167 return IRQ_HANDLED; 3158 return IRQ_HANDLED;
3168} 3159}
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 6a4d1388ad2d..1df3ce134cd0 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -592,7 +592,6 @@ static const struct intel_device_info intel_cannonlake_info = {
592 GEN10_FEATURES, \ 592 GEN10_FEATURES, \
593 GEN(11), \ 593 GEN(11), \
594 .ddb_size = 2048, \ 594 .ddb_size = 2048, \
595 .has_csr = 0, \
596 .has_logical_ring_elsq = 1 595 .has_logical_ring_elsq = 1
597 596
598static const struct intel_device_info intel_icelake_11_info = { 597static const struct intel_device_info intel_icelake_11_info = {
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 4a3c8ee9a973..d2951096bca0 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5079,10 +5079,14 @@ void hsw_disable_ips(const struct intel_crtc_state *crtc_state)
5079 mutex_lock(&dev_priv->pcu_lock); 5079 mutex_lock(&dev_priv->pcu_lock);
5080 WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL, 0)); 5080 WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL, 0));
5081 mutex_unlock(&dev_priv->pcu_lock); 5081 mutex_unlock(&dev_priv->pcu_lock);
5082 /* wait for pcode to finish disabling IPS, which may take up to 42ms */ 5082 /*
5083 * Wait for PCODE to finish disabling IPS. The BSpec specified
5084 * 42ms timeout value leads to occasional timeouts so use 100ms
5085 * instead.
5086 */
5083 if (intel_wait_for_register(dev_priv, 5087 if (intel_wait_for_register(dev_priv,
5084 IPS_CTL, IPS_ENABLE, 0, 5088 IPS_CTL, IPS_ENABLE, 0,
5085 42)) 5089 100))
5086 DRM_ERROR("Timed out waiting for IPS disable\n"); 5090 DRM_ERROR("Timed out waiting for IPS disable\n");
5087 } else { 5091 } else {
5088 I915_WRITE(IPS_CTL, 0); 5092 I915_WRITE(IPS_CTL, 0);
diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
index c2f10d899329..443dfaefd7a6 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+++ b/drivers/gpu/drm/i915/intel_overlay.c
@@ -181,8 +181,9 @@ struct intel_overlay {
181 u32 brightness, contrast, saturation; 181 u32 brightness, contrast, saturation;
182 u32 old_xscale, old_yscale; 182 u32 old_xscale, old_yscale;
183 /* register access */ 183 /* register access */
184 u32 flip_addr;
185 struct drm_i915_gem_object *reg_bo; 184 struct drm_i915_gem_object *reg_bo;
185 struct overlay_registers __iomem *regs;
186 u32 flip_addr;
186 /* flip handling */ 187 /* flip handling */
187 struct i915_gem_active last_flip; 188 struct i915_gem_active last_flip;
188}; 189};
@@ -210,29 +211,6 @@ static void i830_overlay_clock_gating(struct drm_i915_private *dev_priv,
210 PCI_DEVFN(0, 0), I830_CLOCK_GATE, val); 211 PCI_DEVFN(0, 0), I830_CLOCK_GATE, val);
211} 212}
212 213
213static struct overlay_registers __iomem *
214intel_overlay_map_regs(struct intel_overlay *overlay)
215{
216 struct drm_i915_private *dev_priv = overlay->i915;
217 struct overlay_registers __iomem *regs;
218
219 if (OVERLAY_NEEDS_PHYSICAL(dev_priv))
220 regs = (struct overlay_registers __iomem *)overlay->reg_bo->phys_handle->vaddr;
221 else
222 regs = io_mapping_map_wc(&dev_priv->ggtt.iomap,
223 overlay->flip_addr,
224 PAGE_SIZE);
225
226 return regs;
227}
228
229static void intel_overlay_unmap_regs(struct intel_overlay *overlay,
230 struct overlay_registers __iomem *regs)
231{
232 if (!OVERLAY_NEEDS_PHYSICAL(overlay->i915))
233 io_mapping_unmap(regs);
234}
235
236static void intel_overlay_submit_request(struct intel_overlay *overlay, 214static void intel_overlay_submit_request(struct intel_overlay *overlay,
237 struct i915_request *rq, 215 struct i915_request *rq,
238 i915_gem_retire_fn retire) 216 i915_gem_retire_fn retire)
@@ -784,13 +762,13 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
784 struct drm_i915_gem_object *new_bo, 762 struct drm_i915_gem_object *new_bo,
785 struct put_image_params *params) 763 struct put_image_params *params)
786{ 764{
787 int ret, tmp_width; 765 struct overlay_registers __iomem *regs = overlay->regs;
788 struct overlay_registers __iomem *regs;
789 bool scale_changed = false;
790 struct drm_i915_private *dev_priv = overlay->i915; 766 struct drm_i915_private *dev_priv = overlay->i915;
791 u32 swidth, swidthsw, sheight, ostride; 767 u32 swidth, swidthsw, sheight, ostride;
792 enum pipe pipe = overlay->crtc->pipe; 768 enum pipe pipe = overlay->crtc->pipe;
769 bool scale_changed = false;
793 struct i915_vma *vma; 770 struct i915_vma *vma;
771 int ret, tmp_width;
794 772
795 lockdep_assert_held(&dev_priv->drm.struct_mutex); 773 lockdep_assert_held(&dev_priv->drm.struct_mutex);
796 WARN_ON(!drm_modeset_is_locked(&dev_priv->drm.mode_config.connection_mutex)); 774 WARN_ON(!drm_modeset_is_locked(&dev_priv->drm.mode_config.connection_mutex));
@@ -815,30 +793,19 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
815 793
816 if (!overlay->active) { 794 if (!overlay->active) {
817 u32 oconfig; 795 u32 oconfig;
818 regs = intel_overlay_map_regs(overlay); 796
819 if (!regs) {
820 ret = -ENOMEM;
821 goto out_unpin;
822 }
823 oconfig = OCONF_CC_OUT_8BIT; 797 oconfig = OCONF_CC_OUT_8BIT;
824 if (IS_GEN4(dev_priv)) 798 if (IS_GEN4(dev_priv))
825 oconfig |= OCONF_CSC_MODE_BT709; 799 oconfig |= OCONF_CSC_MODE_BT709;
826 oconfig |= pipe == 0 ? 800 oconfig |= pipe == 0 ?
827 OCONF_PIPE_A : OCONF_PIPE_B; 801 OCONF_PIPE_A : OCONF_PIPE_B;
828 iowrite32(oconfig, &regs->OCONFIG); 802 iowrite32(oconfig, &regs->OCONFIG);
829 intel_overlay_unmap_regs(overlay, regs);
830 803
831 ret = intel_overlay_on(overlay); 804 ret = intel_overlay_on(overlay);
832 if (ret != 0) 805 if (ret != 0)
833 goto out_unpin; 806 goto out_unpin;
834 } 807 }
835 808
836 regs = intel_overlay_map_regs(overlay);
837 if (!regs) {
838 ret = -ENOMEM;
839 goto out_unpin;
840 }
841
842 iowrite32((params->dst_y << 16) | params->dst_x, &regs->DWINPOS); 809 iowrite32((params->dst_y << 16) | params->dst_x, &regs->DWINPOS);
843 iowrite32((params->dst_h << 16) | params->dst_w, &regs->DWINSZ); 810 iowrite32((params->dst_h << 16) | params->dst_w, &regs->DWINSZ);
844 811
@@ -882,8 +849,6 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
882 849
883 iowrite32(overlay_cmd_reg(params), &regs->OCMD); 850 iowrite32(overlay_cmd_reg(params), &regs->OCMD);
884 851
885 intel_overlay_unmap_regs(overlay, regs);
886
887 ret = intel_overlay_continue(overlay, vma, scale_changed); 852 ret = intel_overlay_continue(overlay, vma, scale_changed);
888 if (ret) 853 if (ret)
889 goto out_unpin; 854 goto out_unpin;
@@ -901,7 +866,6 @@ out_pin_section:
901int intel_overlay_switch_off(struct intel_overlay *overlay) 866int intel_overlay_switch_off(struct intel_overlay *overlay)
902{ 867{
903 struct drm_i915_private *dev_priv = overlay->i915; 868 struct drm_i915_private *dev_priv = overlay->i915;
904 struct overlay_registers __iomem *regs;
905 int ret; 869 int ret;
906 870
907 lockdep_assert_held(&dev_priv->drm.struct_mutex); 871 lockdep_assert_held(&dev_priv->drm.struct_mutex);
@@ -918,9 +882,7 @@ int intel_overlay_switch_off(struct intel_overlay *overlay)
918 if (ret != 0) 882 if (ret != 0)
919 return ret; 883 return ret;
920 884
921 regs = intel_overlay_map_regs(overlay); 885 iowrite32(0, &overlay->regs->OCMD);
922 iowrite32(0, &regs->OCMD);
923 intel_overlay_unmap_regs(overlay, regs);
924 886
925 return intel_overlay_off(overlay); 887 return intel_overlay_off(overlay);
926} 888}
@@ -1305,7 +1267,6 @@ int intel_overlay_attrs_ioctl(struct drm_device *dev, void *data,
1305 struct drm_intel_overlay_attrs *attrs = data; 1267 struct drm_intel_overlay_attrs *attrs = data;
1306 struct drm_i915_private *dev_priv = to_i915(dev); 1268 struct drm_i915_private *dev_priv = to_i915(dev);
1307 struct intel_overlay *overlay; 1269 struct intel_overlay *overlay;
1308 struct overlay_registers __iomem *regs;
1309 int ret; 1270 int ret;
1310 1271
1311 overlay = dev_priv->overlay; 1272 overlay = dev_priv->overlay;
@@ -1345,15 +1306,7 @@ int intel_overlay_attrs_ioctl(struct drm_device *dev, void *data,
1345 overlay->contrast = attrs->contrast; 1306 overlay->contrast = attrs->contrast;
1346 overlay->saturation = attrs->saturation; 1307 overlay->saturation = attrs->saturation;
1347 1308
1348 regs = intel_overlay_map_regs(overlay); 1309 update_reg_attrs(overlay, overlay->regs);
1349 if (!regs) {
1350 ret = -ENOMEM;
1351 goto out_unlock;
1352 }
1353
1354 update_reg_attrs(overlay, regs);
1355
1356 intel_overlay_unmap_regs(overlay, regs);
1357 1310
1358 if (attrs->flags & I915_OVERLAY_UPDATE_GAMMA) { 1311 if (attrs->flags & I915_OVERLAY_UPDATE_GAMMA) {
1359 if (IS_GEN2(dev_priv)) 1312 if (IS_GEN2(dev_priv))
@@ -1386,12 +1339,47 @@ out_unlock:
1386 return ret; 1339 return ret;
1387} 1340}
1388 1341
1342static int get_registers(struct intel_overlay *overlay, bool use_phys)
1343{
1344 struct drm_i915_gem_object *obj;
1345 struct i915_vma *vma;
1346 int err;
1347
1348 obj = i915_gem_object_create_stolen(overlay->i915, PAGE_SIZE);
1349 if (obj == NULL)
1350 obj = i915_gem_object_create_internal(overlay->i915, PAGE_SIZE);
1351 if (IS_ERR(obj))
1352 return PTR_ERR(obj);
1353
1354 vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, PIN_MAPPABLE);
1355 if (IS_ERR(vma)) {
1356 err = PTR_ERR(vma);
1357 goto err_put_bo;
1358 }
1359
1360 if (use_phys)
1361 overlay->flip_addr = sg_dma_address(obj->mm.pages->sgl);
1362 else
1363 overlay->flip_addr = i915_ggtt_offset(vma);
1364 overlay->regs = i915_vma_pin_iomap(vma);
1365 i915_vma_unpin(vma);
1366
1367 if (IS_ERR(overlay->regs)) {
1368 err = PTR_ERR(overlay->regs);
1369 goto err_put_bo;
1370 }
1371
1372 overlay->reg_bo = obj;
1373 return 0;
1374
1375err_put_bo:
1376 i915_gem_object_put(obj);
1377 return err;
1378}
1379
1389void intel_setup_overlay(struct drm_i915_private *dev_priv) 1380void intel_setup_overlay(struct drm_i915_private *dev_priv)
1390{ 1381{
1391 struct intel_overlay *overlay; 1382 struct intel_overlay *overlay;
1392 struct drm_i915_gem_object *reg_bo;
1393 struct overlay_registers __iomem *regs;
1394 struct i915_vma *vma = NULL;
1395 int ret; 1383 int ret;
1396 1384
1397 if (!HAS_OVERLAY(dev_priv)) 1385 if (!HAS_OVERLAY(dev_priv))
@@ -1401,46 +1389,8 @@ void intel_setup_overlay(struct drm_i915_private *dev_priv)
1401 if (!overlay) 1389 if (!overlay)
1402 return; 1390 return;
1403 1391
1404 mutex_lock(&dev_priv->drm.struct_mutex);
1405 if (WARN_ON(dev_priv->overlay))
1406 goto out_free;
1407
1408 overlay->i915 = dev_priv; 1392 overlay->i915 = dev_priv;
1409 1393
1410 reg_bo = NULL;
1411 if (!OVERLAY_NEEDS_PHYSICAL(dev_priv))
1412 reg_bo = i915_gem_object_create_stolen(dev_priv, PAGE_SIZE);
1413 if (reg_bo == NULL)
1414 reg_bo = i915_gem_object_create(dev_priv, PAGE_SIZE);
1415 if (IS_ERR(reg_bo))
1416 goto out_free;
1417 overlay->reg_bo = reg_bo;
1418
1419 if (OVERLAY_NEEDS_PHYSICAL(dev_priv)) {
1420 ret = i915_gem_object_attach_phys(reg_bo, PAGE_SIZE);
1421 if (ret) {
1422 DRM_ERROR("failed to attach phys overlay regs\n");
1423 goto out_free_bo;
1424 }
1425 overlay->flip_addr = reg_bo->phys_handle->busaddr;
1426 } else {
1427 vma = i915_gem_object_ggtt_pin(reg_bo, NULL,
1428 0, PAGE_SIZE, PIN_MAPPABLE);
1429 if (IS_ERR(vma)) {
1430 DRM_ERROR("failed to pin overlay register bo\n");
1431 ret = PTR_ERR(vma);
1432 goto out_free_bo;
1433 }
1434 overlay->flip_addr = i915_ggtt_offset(vma);
1435
1436 ret = i915_gem_object_set_to_gtt_domain(reg_bo, true);
1437 if (ret) {
1438 DRM_ERROR("failed to move overlay register bo into the GTT\n");
1439 goto out_unpin_bo;
1440 }
1441 }
1442
1443 /* init all values */
1444 overlay->color_key = 0x0101fe; 1394 overlay->color_key = 0x0101fe;
1445 overlay->color_key_enabled = true; 1395 overlay->color_key_enabled = true;
1446 overlay->brightness = -19; 1396 overlay->brightness = -19;
@@ -1449,44 +1399,51 @@ void intel_setup_overlay(struct drm_i915_private *dev_priv)
1449 1399
1450 init_request_active(&overlay->last_flip, NULL); 1400 init_request_active(&overlay->last_flip, NULL);
1451 1401
1452 regs = intel_overlay_map_regs(overlay); 1402 mutex_lock(&dev_priv->drm.struct_mutex);
1453 if (!regs) 1403
1454 goto out_unpin_bo; 1404 ret = get_registers(overlay, OVERLAY_NEEDS_PHYSICAL(dev_priv));
1405 if (ret)
1406 goto out_free;
1407
1408 ret = i915_gem_object_set_to_gtt_domain(overlay->reg_bo, true);
1409 if (ret)
1410 goto out_reg_bo;
1455 1411
1456 memset_io(regs, 0, sizeof(struct overlay_registers)); 1412 mutex_unlock(&dev_priv->drm.struct_mutex);
1457 update_polyphase_filter(regs);
1458 update_reg_attrs(overlay, regs);
1459 1413
1460 intel_overlay_unmap_regs(overlay, regs); 1414 memset_io(overlay->regs, 0, sizeof(struct overlay_registers));
1415 update_polyphase_filter(overlay->regs);
1416 update_reg_attrs(overlay, overlay->regs);
1461 1417
1462 dev_priv->overlay = overlay; 1418 dev_priv->overlay = overlay;
1463 mutex_unlock(&dev_priv->drm.struct_mutex); 1419 DRM_INFO("Initialized overlay support.\n");
1464 DRM_INFO("initialized overlay support\n");
1465 return; 1420 return;
1466 1421
1467out_unpin_bo: 1422out_reg_bo:
1468 if (vma) 1423 i915_gem_object_put(overlay->reg_bo);
1469 i915_vma_unpin(vma);
1470out_free_bo:
1471 i915_gem_object_put(reg_bo);
1472out_free: 1424out_free:
1473 mutex_unlock(&dev_priv->drm.struct_mutex); 1425 mutex_unlock(&dev_priv->drm.struct_mutex);
1474 kfree(overlay); 1426 kfree(overlay);
1475 return;
1476} 1427}
1477 1428
1478void intel_cleanup_overlay(struct drm_i915_private *dev_priv) 1429void intel_cleanup_overlay(struct drm_i915_private *dev_priv)
1479{ 1430{
1480 if (!dev_priv->overlay) 1431 struct intel_overlay *overlay;
1432
1433 overlay = fetch_and_zero(&dev_priv->overlay);
1434 if (!overlay)
1481 return; 1435 return;
1482 1436
1483 /* The bo's should be free'd by the generic code already. 1437 /*
1438 * The bo's should be free'd by the generic code already.
1484 * Furthermore modesetting teardown happens beforehand so the 1439 * Furthermore modesetting teardown happens beforehand so the
1485 * hardware should be off already */ 1440 * hardware should be off already.
1486 WARN_ON(dev_priv->overlay->active); 1441 */
1442 WARN_ON(overlay->active);
1443
1444 i915_gem_object_put(overlay->reg_bo);
1487 1445
1488 i915_gem_object_put(dev_priv->overlay->reg_bo); 1446 kfree(overlay);
1489 kfree(dev_priv->overlay);
1490} 1447}
1491 1448
1492#if IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR) 1449#if IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR)
@@ -1498,37 +1455,11 @@ struct intel_overlay_error_state {
1498 u32 isr; 1455 u32 isr;
1499}; 1456};
1500 1457
1501static struct overlay_registers __iomem *
1502intel_overlay_map_regs_atomic(struct intel_overlay *overlay)
1503{
1504 struct drm_i915_private *dev_priv = overlay->i915;
1505 struct overlay_registers __iomem *regs;
1506
1507 if (OVERLAY_NEEDS_PHYSICAL(dev_priv))
1508 /* Cast to make sparse happy, but it's wc memory anyway, so
1509 * equivalent to the wc io mapping on X86. */
1510 regs = (struct overlay_registers __iomem *)
1511 overlay->reg_bo->phys_handle->vaddr;
1512 else
1513 regs = io_mapping_map_atomic_wc(&dev_priv->ggtt.iomap,
1514 overlay->flip_addr);
1515
1516 return regs;
1517}
1518
1519static void intel_overlay_unmap_regs_atomic(struct intel_overlay *overlay,
1520 struct overlay_registers __iomem *regs)
1521{
1522 if (!OVERLAY_NEEDS_PHYSICAL(overlay->i915))
1523 io_mapping_unmap_atomic(regs);
1524}
1525
1526struct intel_overlay_error_state * 1458struct intel_overlay_error_state *
1527intel_overlay_capture_error_state(struct drm_i915_private *dev_priv) 1459intel_overlay_capture_error_state(struct drm_i915_private *dev_priv)
1528{ 1460{
1529 struct intel_overlay *overlay = dev_priv->overlay; 1461 struct intel_overlay *overlay = dev_priv->overlay;
1530 struct intel_overlay_error_state *error; 1462 struct intel_overlay_error_state *error;
1531 struct overlay_registers __iomem *regs;
1532 1463
1533 if (!overlay || !overlay->active) 1464 if (!overlay || !overlay->active)
1534 return NULL; 1465 return NULL;
@@ -1541,18 +1472,9 @@ intel_overlay_capture_error_state(struct drm_i915_private *dev_priv)
1541 error->isr = I915_READ(ISR); 1472 error->isr = I915_READ(ISR);
1542 error->base = overlay->flip_addr; 1473 error->base = overlay->flip_addr;
1543 1474
1544 regs = intel_overlay_map_regs_atomic(overlay); 1475 memcpy_fromio(&error->regs, overlay->regs, sizeof(error->regs));
1545 if (!regs)
1546 goto err;
1547
1548 memcpy_fromio(&error->regs, regs, sizeof(struct overlay_registers));
1549 intel_overlay_unmap_regs_atomic(overlay, regs);
1550 1476
1551 return error; 1477 return error;
1552
1553err:
1554 kfree(error);
1555 return NULL;
1556} 1478}
1557 1479
1558void 1480void
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
index 0b976dfd04df..92ecb9bf982c 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -600,7 +600,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev,
600 } 600 }
601 601
602 mtk_crtc->layer_nr = mtk_ddp_comp_layer_nr(mtk_crtc->ddp_comp[0]); 602 mtk_crtc->layer_nr = mtk_ddp_comp_layer_nr(mtk_crtc->ddp_comp[0]);
603 mtk_crtc->planes = devm_kzalloc(dev, mtk_crtc->layer_nr * 603 mtk_crtc->planes = devm_kcalloc(dev, mtk_crtc->layer_nr,
604 sizeof(struct drm_plane), 604 sizeof(struct drm_plane),
605 GFP_KERNEL); 605 GFP_KERNEL);
606 606
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c
index 790d39f816dc..b557687b1964 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c
@@ -153,8 +153,8 @@ int msm_dss_parse_clock(struct platform_device *pdev,
153 return 0; 153 return 0;
154 } 154 }
155 155
156 mp->clk_config = devm_kzalloc(&pdev->dev, 156 mp->clk_config = devm_kcalloc(&pdev->dev,
157 sizeof(struct dss_clk) * num_clk, 157 num_clk, sizeof(struct dss_clk),
158 GFP_KERNEL); 158 GFP_KERNEL);
159 if (!mp->clk_config) 159 if (!mp->clk_config)
160 return -ENOMEM; 160 return -ENOMEM;
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 8412119bd940..041e7daf8a33 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -900,9 +900,22 @@ static enum drm_connector_status
900nv50_mstc_detect(struct drm_connector *connector, bool force) 900nv50_mstc_detect(struct drm_connector *connector, bool force)
901{ 901{
902 struct nv50_mstc *mstc = nv50_mstc(connector); 902 struct nv50_mstc *mstc = nv50_mstc(connector);
903 enum drm_connector_status conn_status;
904 int ret;
905
903 if (!mstc->port) 906 if (!mstc->port)
904 return connector_status_disconnected; 907 return connector_status_disconnected;
905 return drm_dp_mst_detect_port(connector, mstc->port->mgr, mstc->port); 908
909 ret = pm_runtime_get_sync(connector->dev->dev);
910 if (ret < 0 && ret != -EACCES)
911 return connector_status_disconnected;
912
913 conn_status = drm_dp_mst_detect_port(connector, mstc->port->mgr,
914 mstc->port);
915
916 pm_runtime_mark_last_busy(connector->dev->dev);
917 pm_runtime_put_autosuspend(connector->dev->dev);
918 return conn_status;
906} 919}
907 920
908static void 921static void
@@ -1123,17 +1136,21 @@ nv50_mstm_enable(struct nv50_mstm *mstm, u8 dpcd, int state)
1123 int ret; 1136 int ret;
1124 1137
1125 if (dpcd >= 0x12) { 1138 if (dpcd >= 0x12) {
1126 ret = drm_dp_dpcd_readb(mstm->mgr.aux, DP_MSTM_CTRL, &dpcd); 1139 /* Even if we're enabling MST, start with disabling the
1140 * branching unit to clear any sink-side MST topology state
1141 * that wasn't set by us
1142 */
1143 ret = drm_dp_dpcd_writeb(mstm->mgr.aux, DP_MSTM_CTRL, 0);
1127 if (ret < 0) 1144 if (ret < 0)
1128 return ret; 1145 return ret;
1129 1146
1130 dpcd &= ~DP_MST_EN; 1147 if (state) {
1131 if (state) 1148 /* Now, start initializing */
1132 dpcd |= DP_MST_EN; 1149 ret = drm_dp_dpcd_writeb(mstm->mgr.aux, DP_MSTM_CTRL,
1133 1150 DP_MST_EN);
1134 ret = drm_dp_dpcd_writeb(mstm->mgr.aux, DP_MSTM_CTRL, dpcd); 1151 if (ret < 0)
1135 if (ret < 0) 1152 return ret;
1136 return ret; 1153 }
1137 } 1154 }
1138 1155
1139 return nvif_mthd(disp, 0, &args, sizeof(args)); 1156 return nvif_mthd(disp, 0, &args, sizeof(args));
@@ -1142,31 +1159,58 @@ nv50_mstm_enable(struct nv50_mstm *mstm, u8 dpcd, int state)
1142int 1159int
1143nv50_mstm_detect(struct nv50_mstm *mstm, u8 dpcd[8], int allow) 1160nv50_mstm_detect(struct nv50_mstm *mstm, u8 dpcd[8], int allow)
1144{ 1161{
1145 int ret, state = 0; 1162 struct drm_dp_aux *aux;
1163 int ret;
1164 bool old_state, new_state;
1165 u8 mstm_ctrl;
1146 1166
1147 if (!mstm) 1167 if (!mstm)
1148 return 0; 1168 return 0;
1149 1169
1150 if (dpcd[0] >= 0x12) { 1170 mutex_lock(&mstm->mgr.lock);
1151 ret = drm_dp_dpcd_readb(mstm->mgr.aux, DP_MSTM_CAP, &dpcd[1]); 1171
1172 old_state = mstm->mgr.mst_state;
1173 new_state = old_state;
1174 aux = mstm->mgr.aux;
1175
1176 if (old_state) {
1177 /* Just check that the MST hub is still as we expect it */
1178 ret = drm_dp_dpcd_readb(aux, DP_MSTM_CTRL, &mstm_ctrl);
1179 if (ret < 0 || !(mstm_ctrl & DP_MST_EN)) {
1180 DRM_DEBUG_KMS("Hub gone, disabling MST topology\n");
1181 new_state = false;
1182 }
1183 } else if (dpcd[0] >= 0x12) {
1184 ret = drm_dp_dpcd_readb(aux, DP_MSTM_CAP, &dpcd[1]);
1152 if (ret < 0) 1185 if (ret < 0)
1153 return ret; 1186 goto probe_error;
1154 1187
1155 if (!(dpcd[1] & DP_MST_CAP)) 1188 if (!(dpcd[1] & DP_MST_CAP))
1156 dpcd[0] = 0x11; 1189 dpcd[0] = 0x11;
1157 else 1190 else
1158 state = allow; 1191 new_state = allow;
1159 } 1192 }
1160 1193
1161 ret = nv50_mstm_enable(mstm, dpcd[0], state); 1194 if (new_state == old_state) {
1195 mutex_unlock(&mstm->mgr.lock);
1196 return new_state;
1197 }
1198
1199 ret = nv50_mstm_enable(mstm, dpcd[0], new_state);
1162 if (ret) 1200 if (ret)
1163 return ret; 1201 goto probe_error;
1202
1203 mutex_unlock(&mstm->mgr.lock);
1164 1204
1165 ret = drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, state); 1205 ret = drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, new_state);
1166 if (ret) 1206 if (ret)
1167 return nv50_mstm_enable(mstm, dpcd[0], 0); 1207 return nv50_mstm_enable(mstm, dpcd[0], 0);
1168 1208
1169 return mstm->mgr.mst_state; 1209 return new_state;
1210
1211probe_error:
1212 mutex_unlock(&mstm->mgr.lock);
1213 return ret;
1170} 1214}
1171 1215
1172static void 1216static void
@@ -2074,7 +2118,7 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev)
2074static const struct drm_mode_config_funcs 2118static const struct drm_mode_config_funcs
2075nv50_disp_func = { 2119nv50_disp_func = {
2076 .fb_create = nouveau_user_framebuffer_create, 2120 .fb_create = nouveau_user_framebuffer_create,
2077 .output_poll_changed = drm_fb_helper_output_poll_changed, 2121 .output_poll_changed = nouveau_fbcon_output_poll_changed,
2078 .atomic_check = nv50_disp_atomic_check, 2122 .atomic_check = nv50_disp_atomic_check,
2079 .atomic_commit = nv50_disp_atomic_commit, 2123 .atomic_commit = nv50_disp_atomic_commit,
2080 .atomic_state_alloc = nv50_disp_atomic_state_alloc, 2124 .atomic_state_alloc = nv50_disp_atomic_state_alloc,
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 51932c72334e..247f72cc4d10 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -409,59 +409,45 @@ static struct nouveau_encoder *
409nouveau_connector_ddc_detect(struct drm_connector *connector) 409nouveau_connector_ddc_detect(struct drm_connector *connector)
410{ 410{
411 struct drm_device *dev = connector->dev; 411 struct drm_device *dev = connector->dev;
412 struct nouveau_connector *nv_connector = nouveau_connector(connector); 412 struct nouveau_encoder *nv_encoder = NULL, *found = NULL;
413 struct nouveau_drm *drm = nouveau_drm(dev);
414 struct nvkm_gpio *gpio = nvxx_gpio(&drm->client.device);
415 struct nouveau_encoder *nv_encoder = NULL;
416 struct drm_encoder *encoder; 413 struct drm_encoder *encoder;
417 int i, panel = -ENODEV; 414 int i, ret;
418 415 bool switcheroo_ddc = false;
419 /* eDP panels need powering on by us (if the VBIOS doesn't default it
420 * to on) before doing any AUX channel transactions. LVDS panel power
421 * is handled by the SOR itself, and not required for LVDS DDC.
422 */
423 if (nv_connector->type == DCB_CONNECTOR_eDP) {
424 panel = nvkm_gpio_get(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff);
425 if (panel == 0) {
426 nvkm_gpio_set(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff, 1);
427 msleep(300);
428 }
429 }
430 416
431 drm_connector_for_each_possible_encoder(connector, encoder, i) { 417 drm_connector_for_each_possible_encoder(connector, encoder, i) {
432 nv_encoder = nouveau_encoder(encoder); 418 nv_encoder = nouveau_encoder(encoder);
433 419
434 if (nv_encoder->dcb->type == DCB_OUTPUT_DP) { 420 switch (nv_encoder->dcb->type) {
435 int ret = nouveau_dp_detect(nv_encoder); 421 case DCB_OUTPUT_DP:
422 ret = nouveau_dp_detect(nv_encoder);
436 if (ret == NOUVEAU_DP_MST) 423 if (ret == NOUVEAU_DP_MST)
437 return NULL; 424 return NULL;
438 if (ret == NOUVEAU_DP_SST) 425 else if (ret == NOUVEAU_DP_SST)
439 break; 426 found = nv_encoder;
440 } else 427
441 if ((vga_switcheroo_handler_flags() & 428 break;
442 VGA_SWITCHEROO_CAN_SWITCH_DDC) && 429 case DCB_OUTPUT_LVDS:
443 nv_encoder->dcb->type == DCB_OUTPUT_LVDS && 430 switcheroo_ddc = !!(vga_switcheroo_handler_flags() &
444 nv_encoder->i2c) { 431 VGA_SWITCHEROO_CAN_SWITCH_DDC);
445 int ret; 432 /* fall-through */
446 vga_switcheroo_lock_ddc(dev->pdev); 433 default:
447 ret = nvkm_probe_i2c(nv_encoder->i2c, 0x50); 434 if (!nv_encoder->i2c)
448 vga_switcheroo_unlock_ddc(dev->pdev);
449 if (ret)
450 break; 435 break;
451 } else 436
452 if (nv_encoder->i2c) { 437 if (switcheroo_ddc)
438 vga_switcheroo_lock_ddc(dev->pdev);
453 if (nvkm_probe_i2c(nv_encoder->i2c, 0x50)) 439 if (nvkm_probe_i2c(nv_encoder->i2c, 0x50))
454 break; 440 found = nv_encoder;
441 if (switcheroo_ddc)
442 vga_switcheroo_unlock_ddc(dev->pdev);
443
444 break;
455 } 445 }
446 if (found)
447 break;
456 } 448 }
457 449
458 /* eDP panel not detected, restore panel power GPIO to previous 450 return found;
459 * state to avoid confusing the SOR for other output types.
460 */
461 if (!nv_encoder && panel == 0)
462 nvkm_gpio_set(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff, panel);
463
464 return nv_encoder;
465} 451}
466 452
467static struct nouveau_encoder * 453static struct nouveau_encoder *
@@ -555,12 +541,16 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
555 nv_connector->edid = NULL; 541 nv_connector->edid = NULL;
556 } 542 }
557 543
558 /* Outputs are only polled while runtime active, so acquiring a 544 /* Outputs are only polled while runtime active, so resuming the
559 * runtime PM ref here is unnecessary (and would deadlock upon 545 * device here is unnecessary (and would deadlock upon runtime suspend
560 * runtime suspend because it waits for polling to finish). 546 * because it waits for polling to finish). We do however, want to
547 * prevent the autosuspend timer from elapsing during this operation
548 * if possible.
561 */ 549 */
562 if (!drm_kms_helper_is_poll_worker()) { 550 if (drm_kms_helper_is_poll_worker()) {
563 ret = pm_runtime_get_sync(connector->dev->dev); 551 pm_runtime_get_noresume(dev->dev);
552 } else {
553 ret = pm_runtime_get_sync(dev->dev);
564 if (ret < 0 && ret != -EACCES) 554 if (ret < 0 && ret != -EACCES)
565 return conn_status; 555 return conn_status;
566 } 556 }
@@ -638,10 +628,8 @@ detect_analog:
638 628
639 out: 629 out:
640 630
641 if (!drm_kms_helper_is_poll_worker()) { 631 pm_runtime_mark_last_busy(dev->dev);
642 pm_runtime_mark_last_busy(connector->dev->dev); 632 pm_runtime_put_autosuspend(dev->dev);
643 pm_runtime_put_autosuspend(connector->dev->dev);
644 }
645 633
646 return conn_status; 634 return conn_status;
647} 635}
@@ -1105,6 +1093,26 @@ nouveau_connector_hotplug(struct nvif_notify *notify)
1105 const struct nvif_notify_conn_rep_v0 *rep = notify->data; 1093 const struct nvif_notify_conn_rep_v0 *rep = notify->data;
1106 const char *name = connector->name; 1094 const char *name = connector->name;
1107 struct nouveau_encoder *nv_encoder; 1095 struct nouveau_encoder *nv_encoder;
1096 int ret;
1097
1098 ret = pm_runtime_get(drm->dev->dev);
1099 if (ret == 0) {
1100 /* We can't block here if there's a pending PM request
1101 * running, as we'll deadlock nouveau_display_fini() when it
1102 * calls nvif_put() on our nvif_notify struct. So, simply
1103 * defer the hotplug event until the device finishes resuming
1104 */
1105 NV_DEBUG(drm, "Deferring HPD on %s until runtime resume\n",
1106 name);
1107 schedule_work(&drm->hpd_work);
1108
1109 pm_runtime_put_noidle(drm->dev->dev);
1110 return NVIF_NOTIFY_KEEP;
1111 } else if (ret != 1 && ret != -EACCES) {
1112 NV_WARN(drm, "HPD on %s dropped due to RPM failure: %d\n",
1113 name, ret);
1114 return NVIF_NOTIFY_DROP;
1115 }
1108 1116
1109 if (rep->mask & NVIF_NOTIFY_CONN_V0_IRQ) { 1117 if (rep->mask & NVIF_NOTIFY_CONN_V0_IRQ) {
1110 NV_DEBUG(drm, "service %s\n", name); 1118 NV_DEBUG(drm, "service %s\n", name);
@@ -1122,6 +1130,8 @@ nouveau_connector_hotplug(struct nvif_notify *notify)
1122 drm_helper_hpd_irq_event(connector->dev); 1130 drm_helper_hpd_irq_event(connector->dev);
1123 } 1131 }
1124 1132
1133 pm_runtime_mark_last_busy(drm->dev->dev);
1134 pm_runtime_put_autosuspend(drm->dev->dev);
1125 return NVIF_NOTIFY_KEEP; 1135 return NVIF_NOTIFY_KEEP;
1126} 1136}
1127 1137
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index 139368b31916..540c0cbbfcee 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -293,7 +293,7 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
293 293
294static const struct drm_mode_config_funcs nouveau_mode_config_funcs = { 294static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
295 .fb_create = nouveau_user_framebuffer_create, 295 .fb_create = nouveau_user_framebuffer_create,
296 .output_poll_changed = drm_fb_helper_output_poll_changed, 296 .output_poll_changed = nouveau_fbcon_output_poll_changed,
297}; 297};
298 298
299 299
@@ -355,8 +355,6 @@ nouveau_display_hpd_work(struct work_struct *work)
355 pm_runtime_get_sync(drm->dev->dev); 355 pm_runtime_get_sync(drm->dev->dev);
356 356
357 drm_helper_hpd_irq_event(drm->dev); 357 drm_helper_hpd_irq_event(drm->dev);
358 /* enable polling for external displays */
359 drm_kms_helper_poll_enable(drm->dev);
360 358
361 pm_runtime_mark_last_busy(drm->dev->dev); 359 pm_runtime_mark_last_busy(drm->dev->dev);
362 pm_runtime_put_sync(drm->dev->dev); 360 pm_runtime_put_sync(drm->dev->dev);
@@ -379,15 +377,29 @@ nouveau_display_acpi_ntfy(struct notifier_block *nb, unsigned long val,
379{ 377{
380 struct nouveau_drm *drm = container_of(nb, typeof(*drm), acpi_nb); 378 struct nouveau_drm *drm = container_of(nb, typeof(*drm), acpi_nb);
381 struct acpi_bus_event *info = data; 379 struct acpi_bus_event *info = data;
380 int ret;
382 381
383 if (!strcmp(info->device_class, ACPI_VIDEO_CLASS)) { 382 if (!strcmp(info->device_class, ACPI_VIDEO_CLASS)) {
384 if (info->type == ACPI_VIDEO_NOTIFY_PROBE) { 383 if (info->type == ACPI_VIDEO_NOTIFY_PROBE) {
385 /* 384 ret = pm_runtime_get(drm->dev->dev);
386 * This may be the only indication we receive of a 385 if (ret == 1 || ret == -EACCES) {
387 * connector hotplug on a runtime suspended GPU, 386 /* If the GPU is already awake, or in a state
388 * schedule hpd_work to check. 387 * where we can't wake it up, it can handle
389 */ 388 * it's own hotplug events.
390 schedule_work(&drm->hpd_work); 389 */
390 pm_runtime_put_autosuspend(drm->dev->dev);
391 } else if (ret == 0) {
392 /* This may be the only indication we receive
393 * of a connector hotplug on a runtime
394 * suspended GPU, schedule hpd_work to check.
395 */
396 NV_DEBUG(drm, "ACPI requested connector reprobe\n");
397 schedule_work(&drm->hpd_work);
398 pm_runtime_put_noidle(drm->dev->dev);
399 } else {
400 NV_WARN(drm, "Dropped ACPI reprobe event due to RPM error: %d\n",
401 ret);
402 }
391 403
392 /* acpi-video should not generate keypresses for this */ 404 /* acpi-video should not generate keypresses for this */
393 return NOTIFY_BAD; 405 return NOTIFY_BAD;
@@ -411,6 +423,11 @@ nouveau_display_init(struct drm_device *dev)
411 if (ret) 423 if (ret)
412 return ret; 424 return ret;
413 425
426 /* enable connector detection and polling for connectors without HPD
427 * support
428 */
429 drm_kms_helper_poll_enable(dev);
430
414 /* enable hotplug interrupts */ 431 /* enable hotplug interrupts */
415 drm_connector_list_iter_begin(dev, &conn_iter); 432 drm_connector_list_iter_begin(dev, &conn_iter);
416 nouveau_for_each_non_mst_connector_iter(connector, &conn_iter) { 433 nouveau_for_each_non_mst_connector_iter(connector, &conn_iter) {
@@ -425,7 +442,7 @@ nouveau_display_init(struct drm_device *dev)
425} 442}
426 443
427void 444void
428nouveau_display_fini(struct drm_device *dev, bool suspend) 445nouveau_display_fini(struct drm_device *dev, bool suspend, bool runtime)
429{ 446{
430 struct nouveau_display *disp = nouveau_display(dev); 447 struct nouveau_display *disp = nouveau_display(dev);
431 struct nouveau_drm *drm = nouveau_drm(dev); 448 struct nouveau_drm *drm = nouveau_drm(dev);
@@ -450,6 +467,9 @@ nouveau_display_fini(struct drm_device *dev, bool suspend)
450 } 467 }
451 drm_connector_list_iter_end(&conn_iter); 468 drm_connector_list_iter_end(&conn_iter);
452 469
470 if (!runtime)
471 cancel_work_sync(&drm->hpd_work);
472
453 drm_kms_helper_poll_disable(dev); 473 drm_kms_helper_poll_disable(dev);
454 disp->fini(dev); 474 disp->fini(dev);
455} 475}
@@ -618,11 +638,11 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)
618 } 638 }
619 } 639 }
620 640
621 nouveau_display_fini(dev, true); 641 nouveau_display_fini(dev, true, runtime);
622 return 0; 642 return 0;
623 } 643 }
624 644
625 nouveau_display_fini(dev, true); 645 nouveau_display_fini(dev, true, runtime);
626 646
627 list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) { 647 list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
628 struct nouveau_framebuffer *nouveau_fb; 648 struct nouveau_framebuffer *nouveau_fb;
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.h b/drivers/gpu/drm/nouveau/nouveau_display.h
index 54aa7c3fa42d..ff92b54ce448 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.h
+++ b/drivers/gpu/drm/nouveau/nouveau_display.h
@@ -62,7 +62,7 @@ nouveau_display(struct drm_device *dev)
62int nouveau_display_create(struct drm_device *dev); 62int nouveau_display_create(struct drm_device *dev);
63void nouveau_display_destroy(struct drm_device *dev); 63void nouveau_display_destroy(struct drm_device *dev);
64int nouveau_display_init(struct drm_device *dev); 64int nouveau_display_init(struct drm_device *dev);
65void nouveau_display_fini(struct drm_device *dev, bool suspend); 65void nouveau_display_fini(struct drm_device *dev, bool suspend, bool runtime);
66int nouveau_display_suspend(struct drm_device *dev, bool runtime); 66int nouveau_display_suspend(struct drm_device *dev, bool runtime);
67void nouveau_display_resume(struct drm_device *dev, bool runtime); 67void nouveau_display_resume(struct drm_device *dev, bool runtime);
68int nouveau_display_vblank_enable(struct drm_device *, unsigned int); 68int nouveau_display_vblank_enable(struct drm_device *, unsigned int);
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index c7ec86d6c3c9..74d2283f2c28 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -230,7 +230,7 @@ nouveau_cli_init(struct nouveau_drm *drm, const char *sname,
230 mutex_unlock(&drm->master.lock); 230 mutex_unlock(&drm->master.lock);
231 } 231 }
232 if (ret) { 232 if (ret) {
233 NV_ERROR(drm, "Client allocation failed: %d\n", ret); 233 NV_PRINTK(err, cli, "Client allocation failed: %d\n", ret);
234 goto done; 234 goto done;
235 } 235 }
236 236
@@ -240,37 +240,37 @@ nouveau_cli_init(struct nouveau_drm *drm, const char *sname,
240 }, sizeof(struct nv_device_v0), 240 }, sizeof(struct nv_device_v0),
241 &cli->device); 241 &cli->device);
242 if (ret) { 242 if (ret) {
243 NV_ERROR(drm, "Device allocation failed: %d\n", ret); 243 NV_PRINTK(err, cli, "Device allocation failed: %d\n", ret);
244 goto done; 244 goto done;
245 } 245 }
246 246
247 ret = nvif_mclass(&cli->device.object, mmus); 247 ret = nvif_mclass(&cli->device.object, mmus);
248 if (ret < 0) { 248 if (ret < 0) {
249 NV_ERROR(drm, "No supported MMU class\n"); 249 NV_PRINTK(err, cli, "No supported MMU class\n");
250 goto done; 250 goto done;
251 } 251 }
252 252
253 ret = nvif_mmu_init(&cli->device.object, mmus[ret].oclass, &cli->mmu); 253 ret = nvif_mmu_init(&cli->device.object, mmus[ret].oclass, &cli->mmu);
254 if (ret) { 254 if (ret) {
255 NV_ERROR(drm, "MMU allocation failed: %d\n", ret); 255 NV_PRINTK(err, cli, "MMU allocation failed: %d\n", ret);
256 goto done; 256 goto done;
257 } 257 }
258 258
259 ret = nvif_mclass(&cli->mmu.object, vmms); 259 ret = nvif_mclass(&cli->mmu.object, vmms);
260 if (ret < 0) { 260 if (ret < 0) {
261 NV_ERROR(drm, "No supported VMM class\n"); 261 NV_PRINTK(err, cli, "No supported VMM class\n");
262 goto done; 262 goto done;
263 } 263 }
264 264
265 ret = nouveau_vmm_init(cli, vmms[ret].oclass, &cli->vmm); 265 ret = nouveau_vmm_init(cli, vmms[ret].oclass, &cli->vmm);
266 if (ret) { 266 if (ret) {
267 NV_ERROR(drm, "VMM allocation failed: %d\n", ret); 267 NV_PRINTK(err, cli, "VMM allocation failed: %d\n", ret);
268 goto done; 268 goto done;
269 } 269 }
270 270
271 ret = nvif_mclass(&cli->mmu.object, mems); 271 ret = nvif_mclass(&cli->mmu.object, mems);
272 if (ret < 0) { 272 if (ret < 0) {
273 NV_ERROR(drm, "No supported MEM class\n"); 273 NV_PRINTK(err, cli, "No supported MEM class\n");
274 goto done; 274 goto done;
275 } 275 }
276 276
@@ -592,10 +592,8 @@ nouveau_drm_load(struct drm_device *dev, unsigned long flags)
592 pm_runtime_allow(dev->dev); 592 pm_runtime_allow(dev->dev);
593 pm_runtime_mark_last_busy(dev->dev); 593 pm_runtime_mark_last_busy(dev->dev);
594 pm_runtime_put(dev->dev); 594 pm_runtime_put(dev->dev);
595 } else {
596 /* enable polling for external displays */
597 drm_kms_helper_poll_enable(dev);
598 } 595 }
596
599 return 0; 597 return 0;
600 598
601fail_dispinit: 599fail_dispinit:
@@ -629,7 +627,7 @@ nouveau_drm_unload(struct drm_device *dev)
629 nouveau_debugfs_fini(drm); 627 nouveau_debugfs_fini(drm);
630 628
631 if (dev->mode_config.num_crtc) 629 if (dev->mode_config.num_crtc)
632 nouveau_display_fini(dev, false); 630 nouveau_display_fini(dev, false, false);
633 nouveau_display_destroy(dev); 631 nouveau_display_destroy(dev);
634 632
635 nouveau_bios_takedown(dev); 633 nouveau_bios_takedown(dev);
@@ -835,7 +833,6 @@ nouveau_pmops_runtime_suspend(struct device *dev)
835 return -EBUSY; 833 return -EBUSY;
836 } 834 }
837 835
838 drm_kms_helper_poll_disable(drm_dev);
839 nouveau_switcheroo_optimus_dsm(); 836 nouveau_switcheroo_optimus_dsm();
840 ret = nouveau_do_suspend(drm_dev, true); 837 ret = nouveau_do_suspend(drm_dev, true);
841 pci_save_state(pdev); 838 pci_save_state(pdev);
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 844498c4267c..0f64c0a1d4b3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -466,6 +466,7 @@ nouveau_fbcon_set_suspend_work(struct work_struct *work)
466 console_unlock(); 466 console_unlock();
467 467
468 if (state == FBINFO_STATE_RUNNING) { 468 if (state == FBINFO_STATE_RUNNING) {
469 nouveau_fbcon_hotplug_resume(drm->fbcon);
469 pm_runtime_mark_last_busy(drm->dev->dev); 470 pm_runtime_mark_last_busy(drm->dev->dev);
470 pm_runtime_put_sync(drm->dev->dev); 471 pm_runtime_put_sync(drm->dev->dev);
471 } 472 }
@@ -487,6 +488,61 @@ nouveau_fbcon_set_suspend(struct drm_device *dev, int state)
487 schedule_work(&drm->fbcon_work); 488 schedule_work(&drm->fbcon_work);
488} 489}
489 490
491void
492nouveau_fbcon_output_poll_changed(struct drm_device *dev)
493{
494 struct nouveau_drm *drm = nouveau_drm(dev);
495 struct nouveau_fbdev *fbcon = drm->fbcon;
496 int ret;
497
498 if (!fbcon)
499 return;
500
501 mutex_lock(&fbcon->hotplug_lock);
502
503 ret = pm_runtime_get(dev->dev);
504 if (ret == 1 || ret == -EACCES) {
505 drm_fb_helper_hotplug_event(&fbcon->helper);
506
507 pm_runtime_mark_last_busy(dev->dev);
508 pm_runtime_put_autosuspend(dev->dev);
509 } else if (ret == 0) {
510 /* If the GPU was already in the process of suspending before
511 * this event happened, then we can't block here as we'll
512 * deadlock the runtime pmops since they wait for us to
513 * finish. So, just defer this event for when we runtime
514 * resume again. It will be handled by fbcon_work.
515 */
516 NV_DEBUG(drm, "fbcon HPD event deferred until runtime resume\n");
517 fbcon->hotplug_waiting = true;
518 pm_runtime_put_noidle(drm->dev->dev);
519 } else {
520 DRM_WARN("fbcon HPD event lost due to RPM failure: %d\n",
521 ret);
522 }
523
524 mutex_unlock(&fbcon->hotplug_lock);
525}
526
527void
528nouveau_fbcon_hotplug_resume(struct nouveau_fbdev *fbcon)
529{
530 struct nouveau_drm *drm;
531
532 if (!fbcon)
533 return;
534 drm = nouveau_drm(fbcon->helper.dev);
535
536 mutex_lock(&fbcon->hotplug_lock);
537 if (fbcon->hotplug_waiting) {
538 fbcon->hotplug_waiting = false;
539
540 NV_DEBUG(drm, "Handling deferred fbcon HPD events\n");
541 drm_fb_helper_hotplug_event(&fbcon->helper);
542 }
543 mutex_unlock(&fbcon->hotplug_lock);
544}
545
490int 546int
491nouveau_fbcon_init(struct drm_device *dev) 547nouveau_fbcon_init(struct drm_device *dev)
492{ 548{
@@ -505,6 +561,7 @@ nouveau_fbcon_init(struct drm_device *dev)
505 561
506 drm->fbcon = fbcon; 562 drm->fbcon = fbcon;
507 INIT_WORK(&drm->fbcon_work, nouveau_fbcon_set_suspend_work); 563 INIT_WORK(&drm->fbcon_work, nouveau_fbcon_set_suspend_work);
564 mutex_init(&fbcon->hotplug_lock);
508 565
509 drm_fb_helper_prepare(dev, &fbcon->helper, &nouveau_fbcon_helper_funcs); 566 drm_fb_helper_prepare(dev, &fbcon->helper, &nouveau_fbcon_helper_funcs);
510 567
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.h b/drivers/gpu/drm/nouveau/nouveau_fbcon.h
index a6f192ea3fa6..db9d52047ef8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.h
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.h
@@ -41,6 +41,9 @@ struct nouveau_fbdev {
41 struct nvif_object gdi; 41 struct nvif_object gdi;
42 struct nvif_object blit; 42 struct nvif_object blit;
43 struct nvif_object twod; 43 struct nvif_object twod;
44
45 struct mutex hotplug_lock;
46 bool hotplug_waiting;
44}; 47};
45 48
46void nouveau_fbcon_restore(void); 49void nouveau_fbcon_restore(void);
@@ -68,6 +71,8 @@ void nouveau_fbcon_set_suspend(struct drm_device *dev, int state);
68void nouveau_fbcon_accel_save_disable(struct drm_device *dev); 71void nouveau_fbcon_accel_save_disable(struct drm_device *dev);
69void nouveau_fbcon_accel_restore(struct drm_device *dev); 72void nouveau_fbcon_accel_restore(struct drm_device *dev);
70 73
74void nouveau_fbcon_output_poll_changed(struct drm_device *dev);
75void nouveau_fbcon_hotplug_resume(struct nouveau_fbdev *fbcon);
71extern int nouveau_nofbaccel; 76extern int nouveau_nofbaccel;
72 77
73#endif /* __NV50_FBCON_H__ */ 78#endif /* __NV50_FBCON_H__ */
diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c
index 3da5a4305aa4..8f1ce4833230 100644
--- a/drivers/gpu/drm/nouveau/nouveau_vga.c
+++ b/drivers/gpu/drm/nouveau/nouveau_vga.c
@@ -46,12 +46,10 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev,
46 pr_err("VGA switcheroo: switched nouveau on\n"); 46 pr_err("VGA switcheroo: switched nouveau on\n");
47 dev->switch_power_state = DRM_SWITCH_POWER_CHANGING; 47 dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
48 nouveau_pmops_resume(&pdev->dev); 48 nouveau_pmops_resume(&pdev->dev);
49 drm_kms_helper_poll_enable(dev);
50 dev->switch_power_state = DRM_SWITCH_POWER_ON; 49 dev->switch_power_state = DRM_SWITCH_POWER_ON;
51 } else { 50 } else {
52 pr_err("VGA switcheroo: switched nouveau off\n"); 51 pr_err("VGA switcheroo: switched nouveau off\n");
53 dev->switch_power_state = DRM_SWITCH_POWER_CHANGING; 52 dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
54 drm_kms_helper_poll_disable(dev);
55 nouveau_switcheroo_optimus_dsm(); 53 nouveau_switcheroo_optimus_dsm();
56 nouveau_pmops_suspend(&pdev->dev); 54 nouveau_pmops_suspend(&pdev->dev);
57 dev->switch_power_state = DRM_SWITCH_POWER_OFF; 55 dev->switch_power_state = DRM_SWITCH_POWER_OFF;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c
index 32fa94a9773f..cbd33e87b799 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c
@@ -275,6 +275,7 @@ nvkm_disp_oneinit(struct nvkm_engine *engine)
275 struct nvkm_outp *outp, *outt, *pair; 275 struct nvkm_outp *outp, *outt, *pair;
276 struct nvkm_conn *conn; 276 struct nvkm_conn *conn;
277 struct nvkm_head *head; 277 struct nvkm_head *head;
278 struct nvkm_ior *ior;
278 struct nvbios_connE connE; 279 struct nvbios_connE connE;
279 struct dcb_output dcbE; 280 struct dcb_output dcbE;
280 u8 hpd = 0, ver, hdr; 281 u8 hpd = 0, ver, hdr;
@@ -399,6 +400,19 @@ nvkm_disp_oneinit(struct nvkm_engine *engine)
399 return ret; 400 return ret;
400 } 401 }
401 402
403 /* Enforce identity-mapped SOR assignment for panels, which have
404 * certain bits (ie. backlight controls) wired to a specific SOR.
405 */
406 list_for_each_entry(outp, &disp->outp, head) {
407 if (outp->conn->info.type == DCB_CONNECTOR_LVDS ||
408 outp->conn->info.type == DCB_CONNECTOR_eDP) {
409 ior = nvkm_ior_find(disp, SOR, ffs(outp->info.or) - 1);
410 if (!WARN_ON(!ior))
411 ior->identity = true;
412 outp->identity = true;
413 }
414 }
415
402 i = 0; 416 i = 0;
403 list_for_each_entry(head, &disp->head, head) 417 list_for_each_entry(head, &disp->head, head)
404 i = max(i, head->id + 1); 418 i = max(i, head->id + 1);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c
index 7c5bed29ffef..5f301e632599 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c
@@ -28,6 +28,7 @@
28 28
29#include <subdev/bios.h> 29#include <subdev/bios.h>
30#include <subdev/bios/init.h> 30#include <subdev/bios/init.h>
31#include <subdev/gpio.h>
31#include <subdev/i2c.h> 32#include <subdev/i2c.h>
32 33
33#include <nvif/event.h> 34#include <nvif/event.h>
@@ -412,14 +413,10 @@ nvkm_dp_train(struct nvkm_dp *dp, u32 dataKBps)
412} 413}
413 414
414static void 415static void
415nvkm_dp_release(struct nvkm_outp *outp, struct nvkm_ior *ior) 416nvkm_dp_disable(struct nvkm_outp *outp, struct nvkm_ior *ior)
416{ 417{
417 struct nvkm_dp *dp = nvkm_dp(outp); 418 struct nvkm_dp *dp = nvkm_dp(outp);
418 419
419 /* Prevent link from being retrained if sink sends an IRQ. */
420 atomic_set(&dp->lt.done, 0);
421 ior->dp.nr = 0;
422
423 /* Execute DisableLT script from DP Info Table. */ 420 /* Execute DisableLT script from DP Info Table. */
424 nvbios_init(&ior->disp->engine.subdev, dp->info.script[4], 421 nvbios_init(&ior->disp->engine.subdev, dp->info.script[4],
425 init.outp = &dp->outp.info; 422 init.outp = &dp->outp.info;
@@ -428,6 +425,16 @@ nvkm_dp_release(struct nvkm_outp *outp, struct nvkm_ior *ior)
428 ); 425 );
429} 426}
430 427
428static void
429nvkm_dp_release(struct nvkm_outp *outp)
430{
431 struct nvkm_dp *dp = nvkm_dp(outp);
432
433 /* Prevent link from being retrained if sink sends an IRQ. */
434 atomic_set(&dp->lt.done, 0);
435 dp->outp.ior->dp.nr = 0;
436}
437
431static int 438static int
432nvkm_dp_acquire(struct nvkm_outp *outp) 439nvkm_dp_acquire(struct nvkm_outp *outp)
433{ 440{
@@ -491,7 +498,7 @@ done:
491 return ret; 498 return ret;
492} 499}
493 500
494static void 501static bool
495nvkm_dp_enable(struct nvkm_dp *dp, bool enable) 502nvkm_dp_enable(struct nvkm_dp *dp, bool enable)
496{ 503{
497 struct nvkm_i2c_aux *aux = dp->aux; 504 struct nvkm_i2c_aux *aux = dp->aux;
@@ -505,7 +512,7 @@ nvkm_dp_enable(struct nvkm_dp *dp, bool enable)
505 512
506 if (!nvkm_rdaux(aux, DPCD_RC00_DPCD_REV, dp->dpcd, 513 if (!nvkm_rdaux(aux, DPCD_RC00_DPCD_REV, dp->dpcd,
507 sizeof(dp->dpcd))) 514 sizeof(dp->dpcd)))
508 return; 515 return true;
509 } 516 }
510 517
511 if (dp->present) { 518 if (dp->present) {
@@ -515,6 +522,7 @@ nvkm_dp_enable(struct nvkm_dp *dp, bool enable)
515 } 522 }
516 523
517 atomic_set(&dp->lt.done, 0); 524 atomic_set(&dp->lt.done, 0);
525 return false;
518} 526}
519 527
520static int 528static int
@@ -555,9 +563,38 @@ nvkm_dp_fini(struct nvkm_outp *outp)
555static void 563static void
556nvkm_dp_init(struct nvkm_outp *outp) 564nvkm_dp_init(struct nvkm_outp *outp)
557{ 565{
566 struct nvkm_gpio *gpio = outp->disp->engine.subdev.device->gpio;
558 struct nvkm_dp *dp = nvkm_dp(outp); 567 struct nvkm_dp *dp = nvkm_dp(outp);
568
559 nvkm_notify_put(&dp->outp.conn->hpd); 569 nvkm_notify_put(&dp->outp.conn->hpd);
560 nvkm_dp_enable(dp, true); 570
571 /* eDP panels need powering on by us (if the VBIOS doesn't default it
572 * to on) before doing any AUX channel transactions. LVDS panel power
573 * is handled by the SOR itself, and not required for LVDS DDC.
574 */
575 if (dp->outp.conn->info.type == DCB_CONNECTOR_eDP) {
576 int power = nvkm_gpio_get(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff);
577 if (power == 0)
578 nvkm_gpio_set(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff, 1);
579
580 /* We delay here unconditionally, even if already powered,
581 * because some laptop panels having a significant resume
582 * delay before the panel begins responding.
583 *
584 * This is likely a bit of a hack, but no better idea for
585 * handling this at the moment.
586 */
587 msleep(300);
588
589 /* If the eDP panel can't be detected, we need to restore
590 * the panel power GPIO to avoid breaking another output.
591 */
592 if (!nvkm_dp_enable(dp, true) && power == 0)
593 nvkm_gpio_set(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff, 0);
594 } else {
595 nvkm_dp_enable(dp, true);
596 }
597
561 nvkm_notify_get(&dp->hpd); 598 nvkm_notify_get(&dp->hpd);
562} 599}
563 600
@@ -576,6 +613,7 @@ nvkm_dp_func = {
576 .fini = nvkm_dp_fini, 613 .fini = nvkm_dp_fini,
577 .acquire = nvkm_dp_acquire, 614 .acquire = nvkm_dp_acquire,
578 .release = nvkm_dp_release, 615 .release = nvkm_dp_release,
616 .disable = nvkm_dp_disable,
579}; 617};
580 618
581static int 619static int
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h b/drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h
index e0b4e0c5704e..19911211a12a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h
@@ -16,6 +16,7 @@ struct nvkm_ior {
16 char name[8]; 16 char name[8];
17 17
18 struct list_head head; 18 struct list_head head;
19 bool identity;
19 20
20 struct nvkm_ior_state { 21 struct nvkm_ior_state {
21 struct nvkm_outp *outp; 22 struct nvkm_outp *outp;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
index f89c7b977aa5..def005dd5fda 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
@@ -501,11 +501,11 @@ nv50_disp_super_2_0(struct nv50_disp *disp, struct nvkm_head *head)
501 nv50_disp_super_ied_off(head, ior, 2); 501 nv50_disp_super_ied_off(head, ior, 2);
502 502
503 /* If we're shutting down the OR's only active head, execute 503 /* If we're shutting down the OR's only active head, execute
504 * the output path's release function. 504 * the output path's disable function.
505 */ 505 */
506 if (ior->arm.head == (1 << head->id)) { 506 if (ior->arm.head == (1 << head->id)) {
507 if ((outp = ior->arm.outp) && outp->func->release) 507 if ((outp = ior->arm.outp) && outp->func->disable)
508 outp->func->release(outp, ior); 508 outp->func->disable(outp, ior);
509 } 509 }
510} 510}
511 511
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c
index be9e7f8c3b23..c62030c96fba 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c
@@ -93,6 +93,8 @@ nvkm_outp_release(struct nvkm_outp *outp, u8 user)
93 if (ior) { 93 if (ior) {
94 outp->acquired &= ~user; 94 outp->acquired &= ~user;
95 if (!outp->acquired) { 95 if (!outp->acquired) {
96 if (outp->func->release && outp->ior)
97 outp->func->release(outp);
96 outp->ior->asy.outp = NULL; 98 outp->ior->asy.outp = NULL;
97 outp->ior = NULL; 99 outp->ior = NULL;
98 } 100 }
@@ -127,17 +129,26 @@ nvkm_outp_acquire(struct nvkm_outp *outp, u8 user)
127 if (proto == UNKNOWN) 129 if (proto == UNKNOWN)
128 return -ENOSYS; 130 return -ENOSYS;
129 131
132 /* Deal with panels requiring identity-mapped SOR assignment. */
133 if (outp->identity) {
134 ior = nvkm_ior_find(outp->disp, SOR, ffs(outp->info.or) - 1);
135 if (WARN_ON(!ior))
136 return -ENOSPC;
137 return nvkm_outp_acquire_ior(outp, user, ior);
138 }
139
130 /* First preference is to reuse the OR that is currently armed 140 /* First preference is to reuse the OR that is currently armed
131 * on HW, if any, in order to prevent unnecessary switching. 141 * on HW, if any, in order to prevent unnecessary switching.
132 */ 142 */
133 list_for_each_entry(ior, &outp->disp->ior, head) { 143 list_for_each_entry(ior, &outp->disp->ior, head) {
134 if (!ior->asy.outp && ior->arm.outp == outp) 144 if (!ior->identity && !ior->asy.outp && ior->arm.outp == outp)
135 return nvkm_outp_acquire_ior(outp, user, ior); 145 return nvkm_outp_acquire_ior(outp, user, ior);
136 } 146 }
137 147
138 /* Failing that, a completely unused OR is the next best thing. */ 148 /* Failing that, a completely unused OR is the next best thing. */
139 list_for_each_entry(ior, &outp->disp->ior, head) { 149 list_for_each_entry(ior, &outp->disp->ior, head) {
140 if (!ior->asy.outp && ior->type == type && !ior->arm.outp && 150 if (!ior->identity &&
151 !ior->asy.outp && ior->type == type && !ior->arm.outp &&
141 (ior->func->route.set || ior->id == __ffs(outp->info.or))) 152 (ior->func->route.set || ior->id == __ffs(outp->info.or)))
142 return nvkm_outp_acquire_ior(outp, user, ior); 153 return nvkm_outp_acquire_ior(outp, user, ior);
143 } 154 }
@@ -146,7 +157,7 @@ nvkm_outp_acquire(struct nvkm_outp *outp, u8 user)
146 * but will be released during the next modeset. 157 * but will be released during the next modeset.
147 */ 158 */
148 list_for_each_entry(ior, &outp->disp->ior, head) { 159 list_for_each_entry(ior, &outp->disp->ior, head) {
149 if (!ior->asy.outp && ior->type == type && 160 if (!ior->identity && !ior->asy.outp && ior->type == type &&
150 (ior->func->route.set || ior->id == __ffs(outp->info.or))) 161 (ior->func->route.set || ior->id == __ffs(outp->info.or)))
151 return nvkm_outp_acquire_ior(outp, user, ior); 162 return nvkm_outp_acquire_ior(outp, user, ior);
152 } 163 }
@@ -245,7 +256,6 @@ nvkm_outp_ctor(const struct nvkm_outp_func *func, struct nvkm_disp *disp,
245 outp->index = index; 256 outp->index = index;
246 outp->info = *dcbE; 257 outp->info = *dcbE;
247 outp->i2c = nvkm_i2c_bus_find(i2c, dcbE->i2c_index); 258 outp->i2c = nvkm_i2c_bus_find(i2c, dcbE->i2c_index);
248 outp->or = ffs(outp->info.or) - 1;
249 259
250 OUTP_DBG(outp, "type %02x loc %d or %d link %d con %x " 260 OUTP_DBG(outp, "type %02x loc %d or %d link %d con %x "
251 "edid %x bus %d head %x", 261 "edid %x bus %d head %x",
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h
index ea84d7d5741a..6c8aa5cfed9d 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h
@@ -13,10 +13,10 @@ struct nvkm_outp {
13 struct dcb_output info; 13 struct dcb_output info;
14 14
15 struct nvkm_i2c_bus *i2c; 15 struct nvkm_i2c_bus *i2c;
16 int or;
17 16
18 struct list_head head; 17 struct list_head head;
19 struct nvkm_conn *conn; 18 struct nvkm_conn *conn;
19 bool identity;
20 20
21 /* Assembly state. */ 21 /* Assembly state. */
22#define NVKM_OUTP_PRIV 1 22#define NVKM_OUTP_PRIV 1
@@ -41,7 +41,8 @@ struct nvkm_outp_func {
41 void (*init)(struct nvkm_outp *); 41 void (*init)(struct nvkm_outp *);
42 void (*fini)(struct nvkm_outp *); 42 void (*fini)(struct nvkm_outp *);
43 int (*acquire)(struct nvkm_outp *); 43 int (*acquire)(struct nvkm_outp *);
44 void (*release)(struct nvkm_outp *, struct nvkm_ior *); 44 void (*release)(struct nvkm_outp *);
45 void (*disable)(struct nvkm_outp *, struct nvkm_ior *);
45}; 46};
46 47
47#define OUTP_MSG(o,l,f,a...) do { \ 48#define OUTP_MSG(o,l,f,a...) do { \
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm200.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm200.c
index b80618e35491..17235e940ca9 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm200.c
@@ -86,10 +86,8 @@ pmu_load(struct nv50_devinit *init, u8 type, bool post,
86 struct nvkm_bios *bios = subdev->device->bios; 86 struct nvkm_bios *bios = subdev->device->bios;
87 struct nvbios_pmuR pmu; 87 struct nvbios_pmuR pmu;
88 88
89 if (!nvbios_pmuRm(bios, type, &pmu)) { 89 if (!nvbios_pmuRm(bios, type, &pmu))
90 nvkm_error(subdev, "VBIOS PMU fuc %02x not found\n", type);
91 return -EINVAL; 90 return -EINVAL;
92 }
93 91
94 if (!post) 92 if (!post)
95 return 0; 93 return 0;
@@ -124,29 +122,30 @@ gm200_devinit_post(struct nvkm_devinit *base, bool post)
124 return -EINVAL; 122 return -EINVAL;
125 } 123 }
126 124
125 /* Upload DEVINIT application from VBIOS onto PMU. */
127 ret = pmu_load(init, 0x04, post, &exec, &args); 126 ret = pmu_load(init, 0x04, post, &exec, &args);
128 if (ret) 127 if (ret) {
128 nvkm_error(subdev, "VBIOS PMU/DEVINIT not found\n");
129 return ret; 129 return ret;
130 }
130 131
131 /* upload first chunk of init data */ 132 /* Upload tables required by opcodes in boot scripts. */
132 if (post) { 133 if (post) {
133 // devinit tables
134 u32 pmu = pmu_args(init, args + 0x08, 0x08); 134 u32 pmu = pmu_args(init, args + 0x08, 0x08);
135 u32 img = nvbios_rd16(bios, bit_I.offset + 0x14); 135 u32 img = nvbios_rd16(bios, bit_I.offset + 0x14);
136 u32 len = nvbios_rd16(bios, bit_I.offset + 0x16); 136 u32 len = nvbios_rd16(bios, bit_I.offset + 0x16);
137 pmu_data(init, pmu, img, len); 137 pmu_data(init, pmu, img, len);
138 } 138 }
139 139
140 /* upload second chunk of init data */ 140 /* Upload boot scripts. */
141 if (post) { 141 if (post) {
142 // devinit boot scripts
143 u32 pmu = pmu_args(init, args + 0x08, 0x10); 142 u32 pmu = pmu_args(init, args + 0x08, 0x10);
144 u32 img = nvbios_rd16(bios, bit_I.offset + 0x18); 143 u32 img = nvbios_rd16(bios, bit_I.offset + 0x18);
145 u32 len = nvbios_rd16(bios, bit_I.offset + 0x1a); 144 u32 len = nvbios_rd16(bios, bit_I.offset + 0x1a);
146 pmu_data(init, pmu, img, len); 145 pmu_data(init, pmu, img, len);
147 } 146 }
148 147
149 /* execute init tables */ 148 /* Execute DEVINIT. */
150 if (post) { 149 if (post) {
151 nvkm_wr32(device, 0x10a040, 0x00005000); 150 nvkm_wr32(device, 0x10a040, 0x00005000);
152 pmu_exec(init, exec); 151 pmu_exec(init, exec);
@@ -157,8 +156,11 @@ gm200_devinit_post(struct nvkm_devinit *base, bool post)
157 return -ETIMEDOUT; 156 return -ETIMEDOUT;
158 } 157 }
159 158
160 /* load and execute some other ucode image (bios therm?) */ 159 /* Optional: Execute PRE_OS application on PMU, which should at
161 return pmu_load(init, 0x01, post, NULL, NULL); 160 * least take care of fans until a full PMU has been loaded.
161 */
162 pmu_load(init, 0x01, post, NULL, NULL);
163 return 0;
162} 164}
163 165
164static const struct nvkm_devinit_func 166static const struct nvkm_devinit_func
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c
index de269eb482dd..7459def78d50 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c
@@ -1423,7 +1423,7 @@ nvkm_vmm_get(struct nvkm_vmm *vmm, u8 page, u64 size, struct nvkm_vma **pvma)
1423void 1423void
1424nvkm_vmm_part(struct nvkm_vmm *vmm, struct nvkm_memory *inst) 1424nvkm_vmm_part(struct nvkm_vmm *vmm, struct nvkm_memory *inst)
1425{ 1425{
1426 if (vmm->func->part && inst) { 1426 if (inst && vmm->func->part) {
1427 mutex_lock(&vmm->mutex); 1427 mutex_lock(&vmm->mutex);
1428 vmm->func->part(vmm, inst); 1428 vmm->func->part(vmm, inst);
1429 mutex_unlock(&vmm->mutex); 1429 mutex_unlock(&vmm->mutex);
diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c
index a534b225e31b..5fa0441bb6df 100644
--- a/drivers/gpu/drm/pl111/pl111_vexpress.c
+++ b/drivers/gpu/drm/pl111/pl111_vexpress.c
@@ -111,7 +111,8 @@ static int vexpress_muxfpga_probe(struct platform_device *pdev)
111} 111}
112 112
113static const struct of_device_id vexpress_muxfpga_match[] = { 113static const struct of_device_id vexpress_muxfpga_match[] = {
114 { .compatible = "arm,vexpress-muxfpga", } 114 { .compatible = "arm,vexpress-muxfpga", },
115 {}
115}; 116};
116 117
117static struct platform_driver vexpress_muxfpga_driver = { 118static struct platform_driver vexpress_muxfpga_driver = {
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index dd19d674055c..8b0cd08034e0 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -418,7 +418,6 @@ static const struct of_device_id sun4i_drv_of_table[] = {
418 { .compatible = "allwinner,sun8i-a33-display-engine" }, 418 { .compatible = "allwinner,sun8i-a33-display-engine" },
419 { .compatible = "allwinner,sun8i-a83t-display-engine" }, 419 { .compatible = "allwinner,sun8i-a83t-display-engine" },
420 { .compatible = "allwinner,sun8i-h3-display-engine" }, 420 { .compatible = "allwinner,sun8i-h3-display-engine" },
421 { .compatible = "allwinner,sun8i-r40-display-engine" },
422 { .compatible = "allwinner,sun8i-v3s-display-engine" }, 421 { .compatible = "allwinner,sun8i-v3s-display-engine" },
423 { .compatible = "allwinner,sun9i-a80-display-engine" }, 422 { .compatible = "allwinner,sun9i-a80-display-engine" },
424 { } 423 { }
diff --git a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
index 82502b351aec..a564b5dfe082 100644
--- a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
+++ b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
@@ -398,7 +398,6 @@ static struct regmap_config sun8i_hdmi_phy_regmap_config = {
398 398
399static const struct sun8i_hdmi_phy_variant sun50i_a64_hdmi_phy = { 399static const struct sun8i_hdmi_phy_variant sun50i_a64_hdmi_phy = {
400 .has_phy_clk = true, 400 .has_phy_clk = true,
401 .has_second_pll = true,
402 .phy_init = &sun8i_hdmi_phy_init_h3, 401 .phy_init = &sun8i_hdmi_phy_init_h3,
403 .phy_disable = &sun8i_hdmi_phy_disable_h3, 402 .phy_disable = &sun8i_hdmi_phy_disable_h3,
404 .phy_config = &sun8i_hdmi_phy_config_h3, 403 .phy_config = &sun8i_hdmi_phy_config_h3,
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index fc3713608f78..cb65b0ed53fd 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -545,22 +545,6 @@ static const struct sun8i_mixer_cfg sun8i_h3_mixer0_cfg = {
545 .vi_num = 1, 545 .vi_num = 1,
546}; 546};
547 547
548static const struct sun8i_mixer_cfg sun8i_r40_mixer0_cfg = {
549 .ccsc = 0,
550 .mod_rate = 297000000,
551 .scaler_mask = 0xf,
552 .ui_num = 3,
553 .vi_num = 1,
554};
555
556static const struct sun8i_mixer_cfg sun8i_r40_mixer1_cfg = {
557 .ccsc = 1,
558 .mod_rate = 297000000,
559 .scaler_mask = 0x3,
560 .ui_num = 1,
561 .vi_num = 1,
562};
563
564static const struct sun8i_mixer_cfg sun8i_v3s_mixer_cfg = { 548static const struct sun8i_mixer_cfg sun8i_v3s_mixer_cfg = {
565 .vi_num = 2, 549 .vi_num = 2,
566 .ui_num = 1, 550 .ui_num = 1,
@@ -583,14 +567,6 @@ static const struct of_device_id sun8i_mixer_of_table[] = {
583 .data = &sun8i_h3_mixer0_cfg, 567 .data = &sun8i_h3_mixer0_cfg,
584 }, 568 },
585 { 569 {
586 .compatible = "allwinner,sun8i-r40-de2-mixer-0",
587 .data = &sun8i_r40_mixer0_cfg,
588 },
589 {
590 .compatible = "allwinner,sun8i-r40-de2-mixer-1",
591 .data = &sun8i_r40_mixer1_cfg,
592 },
593 {
594 .compatible = "allwinner,sun8i-v3s-de2-mixer", 570 .compatible = "allwinner,sun8i-v3s-de2-mixer",
595 .data = &sun8i_v3s_mixer_cfg, 571 .data = &sun8i_v3s_mixer_cfg,
596 }, 572 },
diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
index 55fe398d8290..d5240b777a8f 100644
--- a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
+++ b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
@@ -253,7 +253,6 @@ static int sun8i_tcon_top_remove(struct platform_device *pdev)
253 253
254/* sun4i_drv uses this list to check if a device node is a TCON TOP */ 254/* sun4i_drv uses this list to check if a device node is a TCON TOP */
255const struct of_device_id sun8i_tcon_top_of_table[] = { 255const struct of_device_id sun8i_tcon_top_of_table[] = {
256 { .compatible = "allwinner,sun8i-r40-tcon-top" },
257 { /* sentinel */ } 256 { /* sentinel */ }
258}; 257};
259MODULE_DEVICE_TABLE(of, sun8i_tcon_top_of_table); 258MODULE_DEVICE_TABLE(of, sun8i_tcon_top_of_table);
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index dbb62f6eb48a..dd9ffded223b 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -432,9 +432,11 @@ static void udl_fbdev_destroy(struct drm_device *dev,
432{ 432{
433 drm_fb_helper_unregister_fbi(&ufbdev->helper); 433 drm_fb_helper_unregister_fbi(&ufbdev->helper);
434 drm_fb_helper_fini(&ufbdev->helper); 434 drm_fb_helper_fini(&ufbdev->helper);
435 drm_framebuffer_unregister_private(&ufbdev->ufb.base); 435 if (ufbdev->ufb.obj) {
436 drm_framebuffer_cleanup(&ufbdev->ufb.base); 436 drm_framebuffer_unregister_private(&ufbdev->ufb.base);
437 drm_gem_object_put_unlocked(&ufbdev->ufb.obj->base); 437 drm_framebuffer_cleanup(&ufbdev->ufb.base);
438 drm_gem_object_put_unlocked(&ufbdev->ufb.obj->base);
439 }
438} 440}
439 441
440int udl_fbdev_init(struct drm_device *dev) 442int udl_fbdev_init(struct drm_device *dev)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index cfb50fedfa2b..a3275fa66b7b 100644
--- a/drivers/gpu/drm/vc4/vc4_plane.c
+++ b/drivers/gpu/drm/vc4/vc4_plane.c
@@ -297,6 +297,9 @@ static int vc4_plane_setup_clipping_and_scaling(struct drm_plane_state *state)
297 vc4_state->y_scaling[0] = vc4_get_scaling_mode(vc4_state->src_h[0], 297 vc4_state->y_scaling[0] = vc4_get_scaling_mode(vc4_state->src_h[0],
298 vc4_state->crtc_h); 298 vc4_state->crtc_h);
299 299
300 vc4_state->is_unity = (vc4_state->x_scaling[0] == VC4_SCALING_NONE &&
301 vc4_state->y_scaling[0] == VC4_SCALING_NONE);
302
300 if (num_planes > 1) { 303 if (num_planes > 1) {
301 vc4_state->is_yuv = true; 304 vc4_state->is_yuv = true;
302 305
@@ -312,24 +315,17 @@ static int vc4_plane_setup_clipping_and_scaling(struct drm_plane_state *state)
312 vc4_get_scaling_mode(vc4_state->src_h[1], 315 vc4_get_scaling_mode(vc4_state->src_h[1],
313 vc4_state->crtc_h); 316 vc4_state->crtc_h);
314 317
315 /* YUV conversion requires that scaling be enabled, 318 /* YUV conversion requires that horizontal scaling be enabled,
316 * even on a plane that's otherwise 1:1. Choose TPZ 319 * even on a plane that's otherwise 1:1. Looks like only PPF
317 * for simplicity. 320 * works in that case, so let's pick that one.
318 */ 321 */
319 if (vc4_state->x_scaling[0] == VC4_SCALING_NONE) 322 if (vc4_state->is_unity)
320 vc4_state->x_scaling[0] = VC4_SCALING_TPZ; 323 vc4_state->x_scaling[0] = VC4_SCALING_PPF;
321 if (vc4_state->y_scaling[0] == VC4_SCALING_NONE)
322 vc4_state->y_scaling[0] = VC4_SCALING_TPZ;
323 } else { 324 } else {
324 vc4_state->x_scaling[1] = VC4_SCALING_NONE; 325 vc4_state->x_scaling[1] = VC4_SCALING_NONE;
325 vc4_state->y_scaling[1] = VC4_SCALING_NONE; 326 vc4_state->y_scaling[1] = VC4_SCALING_NONE;
326 } 327 }
327 328
328 vc4_state->is_unity = (vc4_state->x_scaling[0] == VC4_SCALING_NONE &&
329 vc4_state->y_scaling[0] == VC4_SCALING_NONE &&
330 vc4_state->x_scaling[1] == VC4_SCALING_NONE &&
331 vc4_state->y_scaling[1] == VC4_SCALING_NONE);
332
333 /* No configuring scaling on the cursor plane, since it gets 329 /* No configuring scaling on the cursor plane, since it gets
334 non-vblank-synced updates, and scaling requires requires 330 non-vblank-synced updates, and scaling requires requires
335 LBM changes which have to be vblank-synced. 331 LBM changes which have to be vblank-synced.
@@ -672,7 +668,10 @@ static int vc4_plane_mode_set(struct drm_plane *plane,
672 vc4_dlist_write(vc4_state, SCALER_CSC2_ITR_R_601_5); 668 vc4_dlist_write(vc4_state, SCALER_CSC2_ITR_R_601_5);
673 } 669 }
674 670
675 if (!vc4_state->is_unity) { 671 if (vc4_state->x_scaling[0] != VC4_SCALING_NONE ||
672 vc4_state->x_scaling[1] != VC4_SCALING_NONE ||
673 vc4_state->y_scaling[0] != VC4_SCALING_NONE ||
674 vc4_state->y_scaling[1] != VC4_SCALING_NONE) {
676 /* LBM Base Address. */ 675 /* LBM Base Address. */
677 if (vc4_state->y_scaling[0] != VC4_SCALING_NONE || 676 if (vc4_state->y_scaling[0] != VC4_SCALING_NONE ||
678 vc4_state->y_scaling[1] != VC4_SCALING_NONE) { 677 vc4_state->y_scaling[1] != VC4_SCALING_NONE) {
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 1f134570b759..f0ab6b2313bb 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -3729,7 +3729,7 @@ int vmw_validate_single_buffer(struct vmw_private *dev_priv,
3729{ 3729{
3730 struct vmw_buffer_object *vbo = 3730 struct vmw_buffer_object *vbo =
3731 container_of(bo, struct vmw_buffer_object, base); 3731 container_of(bo, struct vmw_buffer_object, base);
3732 struct ttm_operation_ctx ctx = { interruptible, true }; 3732 struct ttm_operation_ctx ctx = { interruptible, false };
3733 int ret; 3733 int ret;
3734 3734
3735 if (vbo->pin_count > 0) 3735 if (vbo->pin_count > 0)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 23beff5d8e3c..6a712a8d59e9 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1512,21 +1512,19 @@ static int vmw_kms_check_display_memory(struct drm_device *dev,
1512 struct drm_rect *rects) 1512 struct drm_rect *rects)
1513{ 1513{
1514 struct vmw_private *dev_priv = vmw_priv(dev); 1514 struct vmw_private *dev_priv = vmw_priv(dev);
1515 struct drm_mode_config *mode_config = &dev->mode_config;
1516 struct drm_rect bounding_box = {0}; 1515 struct drm_rect bounding_box = {0};
1517 u64 total_pixels = 0, pixel_mem, bb_mem; 1516 u64 total_pixels = 0, pixel_mem, bb_mem;
1518 int i; 1517 int i;
1519 1518
1520 for (i = 0; i < num_rects; i++) { 1519 for (i = 0; i < num_rects; i++) {
1521 /* 1520 /*
1522 * Currently this check is limiting the topology within max 1521 * For STDU only individual screen (screen target) is limited by
1523 * texture/screentarget size. This should change in future when 1522 * SCREENTARGET_MAX_WIDTH/HEIGHT registers.
1524 * user-space support multiple fb with topology.
1525 */ 1523 */
1526 if (rects[i].x1 < 0 || rects[i].y1 < 0 || 1524 if (dev_priv->active_display_unit == vmw_du_screen_target &&
1527 rects[i].x2 > mode_config->max_width || 1525 (drm_rect_width(&rects[i]) > dev_priv->stdu_max_width ||
1528 rects[i].y2 > mode_config->max_height) { 1526 drm_rect_height(&rects[i]) > dev_priv->stdu_max_height)) {
1529 DRM_ERROR("Invalid GUI layout.\n"); 1527 DRM_ERROR("Screen size not supported.\n");
1530 return -EINVAL; 1528 return -EINVAL;
1531 } 1529 }
1532 1530
@@ -1615,7 +1613,7 @@ static int vmw_kms_check_topology(struct drm_device *dev,
1615 struct drm_connector_state *conn_state; 1613 struct drm_connector_state *conn_state;
1616 struct vmw_connector_state *vmw_conn_state; 1614 struct vmw_connector_state *vmw_conn_state;
1617 1615
1618 if (!new_crtc_state->enable && old_crtc_state->enable) { 1616 if (!new_crtc_state->enable) {
1619 rects[i].x1 = 0; 1617 rects[i].x1 = 0;
1620 rects[i].y1 = 0; 1618 rects[i].y1 = 0;
1621 rects[i].x2 = 0; 1619 rects[i].x2 = 0;
@@ -2216,12 +2214,16 @@ int vmw_du_connector_fill_modes(struct drm_connector *connector,
2216 if (dev_priv->assume_16bpp) 2214 if (dev_priv->assume_16bpp)
2217 assumed_bpp = 2; 2215 assumed_bpp = 2;
2218 2216
2217 max_width = min(max_width, dev_priv->texture_max_width);
2218 max_height = min(max_height, dev_priv->texture_max_height);
2219
2220 /*
2221 * For STDU extra limit for a mode on SVGA_REG_SCREENTARGET_MAX_WIDTH/
2222 * HEIGHT registers.
2223 */
2219 if (dev_priv->active_display_unit == vmw_du_screen_target) { 2224 if (dev_priv->active_display_unit == vmw_du_screen_target) {
2220 max_width = min(max_width, dev_priv->stdu_max_width); 2225 max_width = min(max_width, dev_priv->stdu_max_width);
2221 max_width = min(max_width, dev_priv->texture_max_width);
2222
2223 max_height = min(max_height, dev_priv->stdu_max_height); 2226 max_height = min(max_height, dev_priv->stdu_max_height);
2224 max_height = min(max_height, dev_priv->texture_max_height);
2225 } 2227 }
2226 2228
2227 /* Add preferred mode */ 2229 /* Add preferred mode */
@@ -2376,6 +2378,7 @@ int vmw_kms_update_layout_ioctl(struct drm_device *dev, void *data,
2376 struct drm_file *file_priv) 2378 struct drm_file *file_priv)
2377{ 2379{
2378 struct vmw_private *dev_priv = vmw_priv(dev); 2380 struct vmw_private *dev_priv = vmw_priv(dev);
2381 struct drm_mode_config *mode_config = &dev->mode_config;
2379 struct drm_vmw_update_layout_arg *arg = 2382 struct drm_vmw_update_layout_arg *arg =
2380 (struct drm_vmw_update_layout_arg *)data; 2383 (struct drm_vmw_update_layout_arg *)data;
2381 void __user *user_rects; 2384 void __user *user_rects;
@@ -2421,6 +2424,21 @@ int vmw_kms_update_layout_ioctl(struct drm_device *dev, void *data,
2421 drm_rects[i].y1 = curr_rect.y; 2424 drm_rects[i].y1 = curr_rect.y;
2422 drm_rects[i].x2 = curr_rect.x + curr_rect.w; 2425 drm_rects[i].x2 = curr_rect.x + curr_rect.w;
2423 drm_rects[i].y2 = curr_rect.y + curr_rect.h; 2426 drm_rects[i].y2 = curr_rect.y + curr_rect.h;
2427
2428 /*
2429 * Currently this check is limiting the topology within
2430 * mode_config->max (which actually is max texture size
2431 * supported by virtual device). This limit is here to address
2432 * window managers that create a big framebuffer for whole
2433 * topology.
2434 */
2435 if (drm_rects[i].x1 < 0 || drm_rects[i].y1 < 0 ||
2436 drm_rects[i].x2 > mode_config->max_width ||
2437 drm_rects[i].y2 > mode_config->max_height) {
2438 DRM_ERROR("Invalid GUI layout.\n");
2439 ret = -EINVAL;
2440 goto out_free;
2441 }
2424 } 2442 }
2425 2443
2426 ret = vmw_kms_check_display_memory(dev, arg->num_outputs, drm_rects); 2444 ret = vmw_kms_check_display_memory(dev, arg->num_outputs, drm_rects);
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
index 93f6b96ca7bb..f30e839f7bfd 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
@@ -1600,31 +1600,6 @@ int vmw_kms_stdu_init_display(struct vmw_private *dev_priv)
1600 1600
1601 dev_priv->active_display_unit = vmw_du_screen_target; 1601 dev_priv->active_display_unit = vmw_du_screen_target;
1602 1602
1603 if (dev_priv->capabilities & SVGA_CAP_3D) {
1604 /*
1605 * For 3D VMs, display (scanout) buffer size is the smaller of
1606 * max texture and max STDU
1607 */
1608 uint32_t max_width, max_height;
1609
1610 max_width = min(dev_priv->texture_max_width,
1611 dev_priv->stdu_max_width);
1612 max_height = min(dev_priv->texture_max_height,
1613 dev_priv->stdu_max_height);
1614
1615 dev->mode_config.max_width = max_width;
1616 dev->mode_config.max_height = max_height;
1617 } else {
1618 /*
1619 * Given various display aspect ratios, there's no way to
1620 * estimate these using prim_bb_mem. So just set these to
1621 * something arbitrarily large and we will reject any layout
1622 * that doesn't fit prim_bb_mem later
1623 */
1624 dev->mode_config.max_width = 8192;
1625 dev->mode_config.max_height = 8192;
1626 }
1627
1628 vmw_kms_create_implicit_placement_property(dev_priv, false); 1603 vmw_kms_create_implicit_placement_property(dev_priv, false);
1629 1604
1630 for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i) { 1605 for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i) {
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
index e125233e074b..80a01cd4c051 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
@@ -1404,22 +1404,17 @@ int vmw_surface_gb_priv_define(struct drm_device *dev,
1404 *srf_out = NULL; 1404 *srf_out = NULL;
1405 1405
1406 if (for_scanout) { 1406 if (for_scanout) {
1407 uint32_t max_width, max_height;
1408
1409 if (!svga3dsurface_is_screen_target_format(format)) { 1407 if (!svga3dsurface_is_screen_target_format(format)) {
1410 DRM_ERROR("Invalid Screen Target surface format."); 1408 DRM_ERROR("Invalid Screen Target surface format.");
1411 return -EINVAL; 1409 return -EINVAL;
1412 } 1410 }
1413 1411
1414 max_width = min(dev_priv->texture_max_width, 1412 if (size.width > dev_priv->texture_max_width ||
1415 dev_priv->stdu_max_width); 1413 size.height > dev_priv->texture_max_height) {
1416 max_height = min(dev_priv->texture_max_height,
1417 dev_priv->stdu_max_height);
1418
1419 if (size.width > max_width || size.height > max_height) {
1420 DRM_ERROR("%ux%u\n, exceeds max surface size %ux%u", 1414 DRM_ERROR("%ux%u\n, exceeds max surface size %ux%u",
1421 size.width, size.height, 1415 size.width, size.height,
1422 max_width, max_height); 1416 dev_priv->texture_max_width,
1417 dev_priv->texture_max_height);
1423 return -EINVAL; 1418 return -EINVAL;
1424 } 1419 }
1425 } else { 1420 } else {
@@ -1495,8 +1490,17 @@ int vmw_surface_gb_priv_define(struct drm_device *dev,
1495 if (srf->flags & SVGA3D_SURFACE_BIND_STREAM_OUTPUT) 1490 if (srf->flags & SVGA3D_SURFACE_BIND_STREAM_OUTPUT)
1496 srf->res.backup_size += sizeof(SVGA3dDXSOState); 1491 srf->res.backup_size += sizeof(SVGA3dDXSOState);
1497 1492
1493 /*
1494 * Don't set SVGA3D_SURFACE_SCREENTARGET flag for a scanout surface with
1495 * size greater than STDU max width/height. This is really a workaround
1496 * to support creation of big framebuffer requested by some user-space
1497 * for whole topology. That big framebuffer won't really be used for
1498 * binding with screen target as during prepare_fb a separate surface is
1499 * created so it's safe to ignore SVGA3D_SURFACE_SCREENTARGET flag.
1500 */
1498 if (dev_priv->active_display_unit == vmw_du_screen_target && 1501 if (dev_priv->active_display_unit == vmw_du_screen_target &&
1499 for_scanout) 1502 for_scanout && size.width <= dev_priv->stdu_max_width &&
1503 size.height <= dev_priv->stdu_max_height)
1500 srf->flags |= SVGA3D_SURFACE_SCREENTARGET; 1504 srf->flags |= SVGA3D_SURFACE_SCREENTARGET;
1501 1505
1502 /* 1506 /*
diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c
index a96bf46bc483..cf2a18571d48 100644
--- a/drivers/gpu/vga/vga_switcheroo.c
+++ b/drivers/gpu/vga/vga_switcheroo.c
@@ -215,6 +215,8 @@ static void vga_switcheroo_enable(void)
215 return; 215 return;
216 216
217 client->id = ret | ID_BIT_AUDIO; 217 client->id = ret | ID_BIT_AUDIO;
218 if (client->ops->gpu_bound)
219 client->ops->gpu_bound(client->pdev, ret);
218 } 220 }
219 221
220 vga_switcheroo_debugfs_init(&vgasr_priv); 222 vga_switcheroo_debugfs_init(&vgasr_priv);
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 25b7bd56ae11..1cb41992aaa1 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -335,7 +335,8 @@ static int apple_input_mapping(struct hid_device *hdev, struct hid_input *hi,
335 struct hid_field *field, struct hid_usage *usage, 335 struct hid_field *field, struct hid_usage *usage,
336 unsigned long **bit, int *max) 336 unsigned long **bit, int *max)
337{ 337{
338 if (usage->hid == (HID_UP_CUSTOM | 0x0003)) { 338 if (usage->hid == (HID_UP_CUSTOM | 0x0003) ||
339 usage->hid == (HID_UP_MSVENDOR | 0x0003)) {
339 /* The fn key on Apple USB keyboards */ 340 /* The fn key on Apple USB keyboards */
340 set_bit(EV_REP, hi->input->evbit); 341 set_bit(EV_REP, hi->input->evbit);
341 hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_FN); 342 hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_FN);
@@ -472,6 +473,12 @@ static const struct hid_device_id apple_devices[] = {
472 .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN }, 473 .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
473 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI), 474 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI),
474 .driver_data = APPLE_HAS_FN }, 475 .driver_data = APPLE_HAS_FN },
476 { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI),
477 .driver_data = APPLE_HAS_FN },
478 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI),
479 .driver_data = APPLE_HAS_FN },
480 { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI),
481 .driver_data = APPLE_HAS_FN },
475 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ANSI), 482 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ANSI),
476 .driver_data = APPLE_HAS_FN }, 483 .driver_data = APPLE_HAS_FN },
477 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ISO), 484 { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ISO),
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 3da354af7a0a..44564f61e9cc 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1000,7 +1000,7 @@ int hid_open_report(struct hid_device *device)
1000 parser = vzalloc(sizeof(struct hid_parser)); 1000 parser = vzalloc(sizeof(struct hid_parser));
1001 if (!parser) { 1001 if (!parser) {
1002 ret = -ENOMEM; 1002 ret = -ENOMEM;
1003 goto err; 1003 goto alloc_err;
1004 } 1004 }
1005 1005
1006 parser->device = device; 1006 parser->device = device;
@@ -1039,6 +1039,7 @@ int hid_open_report(struct hid_device *device)
1039 hid_err(device, "unbalanced delimiter at end of report description\n"); 1039 hid_err(device, "unbalanced delimiter at end of report description\n");
1040 goto err; 1040 goto err;
1041 } 1041 }
1042 kfree(parser->collection_stack);
1042 vfree(parser); 1043 vfree(parser);
1043 device->status |= HID_STAT_PARSED; 1044 device->status |= HID_STAT_PARSED;
1044 return 0; 1045 return 0;
@@ -1047,6 +1048,8 @@ int hid_open_report(struct hid_device *device)
1047 1048
1048 hid_err(device, "item fetching failed at offset %d\n", (int)(end - start)); 1049 hid_err(device, "item fetching failed at offset %d\n", (int)(end - start));
1049err: 1050err:
1051 kfree(parser->collection_stack);
1052alloc_err:
1050 vfree(parser); 1053 vfree(parser);
1051 hid_close_report(device); 1054 hid_close_report(device);
1052 return ret; 1055 return ret;
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 79bdf0c7e351..bc49909aba8e 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -88,6 +88,7 @@
88#define USB_DEVICE_ID_ANTON_TOUCH_PAD 0x3101 88#define USB_DEVICE_ID_ANTON_TOUCH_PAD 0x3101
89 89
90#define USB_VENDOR_ID_APPLE 0x05ac 90#define USB_VENDOR_ID_APPLE 0x05ac
91#define BT_VENDOR_ID_APPLE 0x004c
91#define USB_DEVICE_ID_APPLE_MIGHTYMOUSE 0x0304 92#define USB_DEVICE_ID_APPLE_MIGHTYMOUSE 0x0304
92#define USB_DEVICE_ID_APPLE_MAGICMOUSE 0x030d 93#define USB_DEVICE_ID_APPLE_MAGICMOUSE 0x030d
93#define USB_DEVICE_ID_APPLE_MAGICTRACKPAD 0x030e 94#define USB_DEVICE_ID_APPLE_MAGICTRACKPAD 0x030e
@@ -157,6 +158,7 @@
157#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO 0x0256 158#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO 0x0256
158#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS 0x0257 159#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS 0x0257
159#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI 0x0267 160#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI 0x0267
161#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI 0x026c
160#define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0290 162#define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0290
161#define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0291 163#define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0291
162#define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0292 164#define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0292
@@ -528,9 +530,6 @@
528#define I2C_VENDOR_ID_HANTICK 0x0911 530#define I2C_VENDOR_ID_HANTICK 0x0911
529#define I2C_PRODUCT_ID_HANTICK_5288 0x5288 531#define I2C_PRODUCT_ID_HANTICK_5288 0x5288
530 532
531#define I2C_VENDOR_ID_RAYD 0x2386
532#define I2C_PRODUCT_ID_RAYD_3118 0x3118
533
534#define USB_VENDOR_ID_HANWANG 0x0b57 533#define USB_VENDOR_ID_HANWANG 0x0b57
535#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000 534#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
536#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff 535#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
@@ -950,6 +949,7 @@
950#define USB_DEVICE_ID_SAITEK_RUMBLEPAD 0xff17 949#define USB_DEVICE_ID_SAITEK_RUMBLEPAD 0xff17
951#define USB_DEVICE_ID_SAITEK_PS1000 0x0621 950#define USB_DEVICE_ID_SAITEK_PS1000 0x0621
952#define USB_DEVICE_ID_SAITEK_RAT7_OLD 0x0ccb 951#define USB_DEVICE_ID_SAITEK_RAT7_OLD 0x0ccb
952#define USB_DEVICE_ID_SAITEK_RAT7_CONTAGION 0x0ccd
953#define USB_DEVICE_ID_SAITEK_RAT7 0x0cd7 953#define USB_DEVICE_ID_SAITEK_RAT7 0x0cd7
954#define USB_DEVICE_ID_SAITEK_RAT9 0x0cfa 954#define USB_DEVICE_ID_SAITEK_RAT9 0x0cfa
955#define USB_DEVICE_ID_SAITEK_MMO7 0x0cd0 955#define USB_DEVICE_ID_SAITEK_MMO7 0x0cd0
@@ -976,7 +976,6 @@
976#define USB_DEVICE_ID_SIS817_TOUCH 0x0817 976#define USB_DEVICE_ID_SIS817_TOUCH 0x0817
977#define USB_DEVICE_ID_SIS_TS 0x1013 977#define USB_DEVICE_ID_SIS_TS 0x1013
978#define USB_DEVICE_ID_SIS1030_TOUCH 0x1030 978#define USB_DEVICE_ID_SIS1030_TOUCH 0x1030
979#define USB_DEVICE_ID_SIS10FB_TOUCH 0x10fb
980 979
981#define USB_VENDOR_ID_SKYCABLE 0x1223 980#define USB_VENDOR_ID_SKYCABLE 0x1223
982#define USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER 0x3F07 981#define USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER 0x3F07
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 4e94ea3e280a..a481eaf39e88 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1582,6 +1582,7 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid,
1582 input_dev->dev.parent = &hid->dev; 1582 input_dev->dev.parent = &hid->dev;
1583 1583
1584 hidinput->input = input_dev; 1584 hidinput->input = input_dev;
1585 hidinput->application = application;
1585 list_add_tail(&hidinput->list, &hid->inputs); 1586 list_add_tail(&hidinput->list, &hid->inputs);
1586 1587
1587 INIT_LIST_HEAD(&hidinput->reports); 1588 INIT_LIST_HEAD(&hidinput->reports);
@@ -1677,8 +1678,7 @@ static struct hid_input *hidinput_match_application(struct hid_report *report)
1677 struct hid_input *hidinput; 1678 struct hid_input *hidinput;
1678 1679
1679 list_for_each_entry(hidinput, &hid->inputs, list) { 1680 list_for_each_entry(hidinput, &hid->inputs, list) {
1680 if (hidinput->report && 1681 if (hidinput->application == report->application)
1681 hidinput->report->application == report->application)
1682 return hidinput; 1682 return hidinput;
1683 } 1683 }
1684 1684
@@ -1815,6 +1815,7 @@ void hidinput_disconnect(struct hid_device *hid)
1815 input_unregister_device(hidinput->input); 1815 input_unregister_device(hidinput->input);
1816 else 1816 else
1817 input_free_device(hidinput->input); 1817 input_free_device(hidinput->input);
1818 kfree(hidinput->name);
1818 kfree(hidinput); 1819 kfree(hidinput);
1819 } 1820 }
1820 1821
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 40fbb7c52723..da954f3f4da7 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1375,7 +1375,8 @@ static bool mt_need_to_apply_feature(struct hid_device *hdev,
1375 struct hid_usage *usage, 1375 struct hid_usage *usage,
1376 enum latency_mode latency, 1376 enum latency_mode latency,
1377 bool surface_switch, 1377 bool surface_switch,
1378 bool button_switch) 1378 bool button_switch,
1379 bool *inputmode_found)
1379{ 1380{
1380 struct mt_device *td = hid_get_drvdata(hdev); 1381 struct mt_device *td = hid_get_drvdata(hdev);
1381 struct mt_class *cls = &td->mtclass; 1382 struct mt_class *cls = &td->mtclass;
@@ -1387,6 +1388,14 @@ static bool mt_need_to_apply_feature(struct hid_device *hdev,
1387 1388
1388 switch (usage->hid) { 1389 switch (usage->hid) {
1389 case HID_DG_INPUTMODE: 1390 case HID_DG_INPUTMODE:
1391 /*
1392 * Some elan panels wrongly declare 2 input mode features,
1393 * and silently ignore when we set the value in the second
1394 * field. Skip the second feature and hope for the best.
1395 */
1396 if (*inputmode_found)
1397 return false;
1398
1390 if (cls->quirks & MT_QUIRK_FORCE_GET_FEATURE) { 1399 if (cls->quirks & MT_QUIRK_FORCE_GET_FEATURE) {
1391 report_len = hid_report_len(report); 1400 report_len = hid_report_len(report);
1392 buf = hid_alloc_report_buf(report, GFP_KERNEL); 1401 buf = hid_alloc_report_buf(report, GFP_KERNEL);
@@ -1402,6 +1411,7 @@ static bool mt_need_to_apply_feature(struct hid_device *hdev,
1402 } 1411 }
1403 1412
1404 field->value[index] = td->inputmode_value; 1413 field->value[index] = td->inputmode_value;
1414 *inputmode_found = true;
1405 return true; 1415 return true;
1406 1416
1407 case HID_DG_CONTACTMAX: 1417 case HID_DG_CONTACTMAX:
@@ -1439,6 +1449,7 @@ static void mt_set_modes(struct hid_device *hdev, enum latency_mode latency,
1439 struct hid_usage *usage; 1449 struct hid_usage *usage;
1440 int i, j; 1450 int i, j;
1441 bool update_report; 1451 bool update_report;
1452 bool inputmode_found = false;
1442 1453
1443 rep_enum = &hdev->report_enum[HID_FEATURE_REPORT]; 1454 rep_enum = &hdev->report_enum[HID_FEATURE_REPORT];
1444 list_for_each_entry(rep, &rep_enum->report_list, list) { 1455 list_for_each_entry(rep, &rep_enum->report_list, list) {
@@ -1457,7 +1468,8 @@ static void mt_set_modes(struct hid_device *hdev, enum latency_mode latency,
1457 usage, 1468 usage,
1458 latency, 1469 latency,
1459 surface_switch, 1470 surface_switch,
1460 button_switch)) 1471 button_switch,
1472 &inputmode_found))
1461 update_report = true; 1473 update_report = true;
1462 } 1474 }
1463 } 1475 }
@@ -1685,6 +1697,9 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
1685 */ 1697 */
1686 hdev->quirks |= HID_QUIRK_INPUT_PER_APP; 1698 hdev->quirks |= HID_QUIRK_INPUT_PER_APP;
1687 1699
1700 if (id->group != HID_GROUP_MULTITOUCH_WIN_8)
1701 hdev->quirks |= HID_QUIRK_MULTI_INPUT;
1702
1688 timer_setup(&td->release_timer, mt_expired_timeout, 0); 1703 timer_setup(&td->release_timer, mt_expired_timeout, 0);
1689 1704
1690 ret = hid_parse(hdev); 1705 ret = hid_parse(hdev);
diff --git a/drivers/hid/hid-saitek.c b/drivers/hid/hid-saitek.c
index 39e642686ff0..683861f324e3 100644
--- a/drivers/hid/hid-saitek.c
+++ b/drivers/hid/hid-saitek.c
@@ -183,6 +183,8 @@ static const struct hid_device_id saitek_devices[] = {
183 .driver_data = SAITEK_RELEASE_MODE_RAT7 }, 183 .driver_data = SAITEK_RELEASE_MODE_RAT7 },
184 { HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RAT7), 184 { HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RAT7),
185 .driver_data = SAITEK_RELEASE_MODE_RAT7 }, 185 .driver_data = SAITEK_RELEASE_MODE_RAT7 },
186 { HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RAT7_CONTAGION),
187 .driver_data = SAITEK_RELEASE_MODE_RAT7 },
186 { HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RAT9), 188 { HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RAT9),
187 .driver_data = SAITEK_RELEASE_MODE_RAT7 }, 189 .driver_data = SAITEK_RELEASE_MODE_RAT7 },
188 { HID_USB_DEVICE(USB_VENDOR_ID_MADCATZ, USB_DEVICE_ID_MADCATZ_RAT9), 190 { HID_USB_DEVICE(USB_VENDOR_ID_MADCATZ, USB_DEVICE_ID_MADCATZ_RAT9),
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 50af72baa5ca..2b63487057c2 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -579,6 +579,28 @@ void sensor_hub_device_close(struct hid_sensor_hub_device *hsdev)
579} 579}
580EXPORT_SYMBOL_GPL(sensor_hub_device_close); 580EXPORT_SYMBOL_GPL(sensor_hub_device_close);
581 581
582static __u8 *sensor_hub_report_fixup(struct hid_device *hdev, __u8 *rdesc,
583 unsigned int *rsize)
584{
585 /*
586 * Checks if the report descriptor of Thinkpad Helix 2 has a logical
587 * minimum for magnetic flux axis greater than the maximum.
588 */
589 if (hdev->product == USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA &&
590 *rsize == 2558 && rdesc[913] == 0x17 && rdesc[914] == 0x40 &&
591 rdesc[915] == 0x81 && rdesc[916] == 0x08 &&
592 rdesc[917] == 0x00 && rdesc[918] == 0x27 &&
593 rdesc[921] == 0x07 && rdesc[922] == 0x00) {
594 /* Sets negative logical minimum for mag x, y and z */
595 rdesc[914] = rdesc[935] = rdesc[956] = 0xc0;
596 rdesc[915] = rdesc[936] = rdesc[957] = 0x7e;
597 rdesc[916] = rdesc[937] = rdesc[958] = 0xf7;
598 rdesc[917] = rdesc[938] = rdesc[959] = 0xff;
599 }
600
601 return rdesc;
602}
603
582static int sensor_hub_probe(struct hid_device *hdev, 604static int sensor_hub_probe(struct hid_device *hdev,
583 const struct hid_device_id *id) 605 const struct hid_device_id *id)
584{ 606{
@@ -743,6 +765,7 @@ static struct hid_driver sensor_hub_driver = {
743 .probe = sensor_hub_probe, 765 .probe = sensor_hub_probe,
744 .remove = sensor_hub_remove, 766 .remove = sensor_hub_remove,
745 .raw_event = sensor_hub_raw_event, 767 .raw_event = sensor_hub_raw_event,
768 .report_fixup = sensor_hub_report_fixup,
746#ifdef CONFIG_PM 769#ifdef CONFIG_PM
747 .suspend = sensor_hub_suspend, 770 .suspend = sensor_hub_suspend,
748 .resume = sensor_hub_resume, 771 .resume = sensor_hub_resume,
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 2ce194a84868..4e3592e7a3f7 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -47,7 +47,7 @@
47/* quirks to control the device */ 47/* quirks to control the device */
48#define I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV BIT(0) 48#define I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV BIT(0)
49#define I2C_HID_QUIRK_NO_IRQ_AFTER_RESET BIT(1) 49#define I2C_HID_QUIRK_NO_IRQ_AFTER_RESET BIT(1)
50#define I2C_HID_QUIRK_RESEND_REPORT_DESCR BIT(2) 50#define I2C_HID_QUIRK_NO_RUNTIME_PM BIT(2)
51 51
52/* flags */ 52/* flags */
53#define I2C_HID_STARTED 0 53#define I2C_HID_STARTED 0
@@ -169,11 +169,8 @@ static const struct i2c_hid_quirks {
169 { USB_VENDOR_ID_WEIDA, USB_DEVICE_ID_WEIDA_8755, 169 { USB_VENDOR_ID_WEIDA, USB_DEVICE_ID_WEIDA_8755,
170 I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV }, 170 I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV },
171 { I2C_VENDOR_ID_HANTICK, I2C_PRODUCT_ID_HANTICK_5288, 171 { I2C_VENDOR_ID_HANTICK, I2C_PRODUCT_ID_HANTICK_5288,
172 I2C_HID_QUIRK_NO_IRQ_AFTER_RESET }, 172 I2C_HID_QUIRK_NO_IRQ_AFTER_RESET |
173 { I2C_VENDOR_ID_RAYD, I2C_PRODUCT_ID_RAYD_3118, 173 I2C_HID_QUIRK_NO_RUNTIME_PM },
174 I2C_HID_QUIRK_RESEND_REPORT_DESCR },
175 { USB_VENDOR_ID_SIS_TOUCH, USB_DEVICE_ID_SIS10FB_TOUCH,
176 I2C_HID_QUIRK_RESEND_REPORT_DESCR },
177 { 0, 0 } 174 { 0, 0 }
178}; 175};
179 176
@@ -1107,7 +1104,9 @@ static int i2c_hid_probe(struct i2c_client *client,
1107 goto err_mem_free; 1104 goto err_mem_free;
1108 } 1105 }
1109 1106
1110 pm_runtime_put(&client->dev); 1107 if (!(ihid->quirks & I2C_HID_QUIRK_NO_RUNTIME_PM))
1108 pm_runtime_put(&client->dev);
1109
1111 return 0; 1110 return 0;
1112 1111
1113err_mem_free: 1112err_mem_free:
@@ -1132,7 +1131,8 @@ static int i2c_hid_remove(struct i2c_client *client)
1132 struct i2c_hid *ihid = i2c_get_clientdata(client); 1131 struct i2c_hid *ihid = i2c_get_clientdata(client);
1133 struct hid_device *hid; 1132 struct hid_device *hid;
1134 1133
1135 pm_runtime_get_sync(&client->dev); 1134 if (!(ihid->quirks & I2C_HID_QUIRK_NO_RUNTIME_PM))
1135 pm_runtime_get_sync(&client->dev);
1136 pm_runtime_disable(&client->dev); 1136 pm_runtime_disable(&client->dev);
1137 pm_runtime_set_suspended(&client->dev); 1137 pm_runtime_set_suspended(&client->dev);
1138 pm_runtime_put_noidle(&client->dev); 1138 pm_runtime_put_noidle(&client->dev);
@@ -1235,19 +1235,15 @@ static int i2c_hid_resume(struct device *dev)
1235 pm_runtime_enable(dev); 1235 pm_runtime_enable(dev);
1236 1236
1237 enable_irq(client->irq); 1237 enable_irq(client->irq);
1238 ret = i2c_hid_hwreset(client);
1239 if (ret)
1240 return ret;
1241 1238
1242 /* RAYDIUM device (2386:3118) need to re-send report descr cmd 1239 /* Instead of resetting device, simply powers the device on. This
1243 * after resume, after this it will be back normal. 1240 * solves "incomplete reports" on Raydium devices 2386:3118 and
1244 * otherwise it issues too many incomplete reports. 1241 * 2386:4B33 and fixes various SIS touchscreens no longer sending
1242 * data after a suspend/resume.
1245 */ 1243 */
1246 if (ihid->quirks & I2C_HID_QUIRK_RESEND_REPORT_DESCR) { 1244 ret = i2c_hid_set_power(client, I2C_HID_PWR_ON);
1247 ret = i2c_hid_command(client, &hid_report_descr_cmd, NULL, 0); 1245 if (ret)
1248 if (ret) 1246 return ret;
1249 return ret;
1250 }
1251 1247
1252 if (hid->driver && hid->driver->reset_resume) { 1248 if (hid->driver && hid->driver->reset_resume) {
1253 ret = hid->driver->reset_resume(hid); 1249 ret = hid->driver->reset_resume(hid);
diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
index 97869b7410eb..08a8327dfd22 100644
--- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
+++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
@@ -29,6 +29,8 @@
29#define CNL_Ax_DEVICE_ID 0x9DFC 29#define CNL_Ax_DEVICE_ID 0x9DFC
30#define GLK_Ax_DEVICE_ID 0x31A2 30#define GLK_Ax_DEVICE_ID 0x31A2
31#define CNL_H_DEVICE_ID 0xA37C 31#define CNL_H_DEVICE_ID 0xA37C
32#define ICL_MOBILE_DEVICE_ID 0x34FC
33#define SPT_H_DEVICE_ID 0xA135
32 34
33#define REVISION_ID_CHT_A0 0x6 35#define REVISION_ID_CHT_A0 0x6
34#define REVISION_ID_CHT_Ax_SI 0x0 36#define REVISION_ID_CHT_Ax_SI 0x0
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index 050f9872f5c0..256b3016116c 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -38,6 +38,8 @@ static const struct pci_device_id ish_pci_tbl[] = {
38 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CNL_Ax_DEVICE_ID)}, 38 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CNL_Ax_DEVICE_ID)},
39 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, GLK_Ax_DEVICE_ID)}, 39 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, GLK_Ax_DEVICE_ID)},
40 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CNL_H_DEVICE_ID)}, 40 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CNL_H_DEVICE_ID)},
41 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, ICL_MOBILE_DEVICE_ID)},
42 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, SPT_H_DEVICE_ID)},
41 {0, } 43 {0, }
42}; 44};
43MODULE_DEVICE_TABLE(pci, ish_pci_tbl); 45MODULE_DEVICE_TABLE(pci, ish_pci_tbl);
diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index ced041899456..f4d08c8ac7f8 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -76,6 +76,7 @@ static int vmbus_negotiate_version(struct vmbus_channel_msginfo *msginfo,
76 __u32 version) 76 __u32 version)
77{ 77{
78 int ret = 0; 78 int ret = 0;
79 unsigned int cur_cpu;
79 struct vmbus_channel_initiate_contact *msg; 80 struct vmbus_channel_initiate_contact *msg;
80 unsigned long flags; 81 unsigned long flags;
81 82
@@ -118,9 +119,10 @@ static int vmbus_negotiate_version(struct vmbus_channel_msginfo *msginfo,
118 * the CPU attempting to connect may not be CPU 0. 119 * the CPU attempting to connect may not be CPU 0.
119 */ 120 */
120 if (version >= VERSION_WIN8_1) { 121 if (version >= VERSION_WIN8_1) {
121 msg->target_vcpu = 122 cur_cpu = get_cpu();
122 hv_cpu_number_to_vp_number(smp_processor_id()); 123 msg->target_vcpu = hv_cpu_number_to_vp_number(cur_cpu);
123 vmbus_connection.connect_cpu = smp_processor_id(); 124 vmbus_connection.connect_cpu = cur_cpu;
125 put_cpu();
124 } else { 126 } else {
125 msg->target_vcpu = 0; 127 msg->target_vcpu = 0;
126 vmbus_connection.connect_cpu = 0; 128 vmbus_connection.connect_cpu = 0;
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b1b548a21f91..c71cc857b649 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1291,6 +1291,9 @@ static ssize_t vmbus_chan_attr_show(struct kobject *kobj,
1291 if (!attribute->show) 1291 if (!attribute->show)
1292 return -EIO; 1292 return -EIO;
1293 1293
1294 if (chan->state != CHANNEL_OPENED_STATE)
1295 return -EINVAL;
1296
1294 return attribute->show(chan, buf); 1297 return attribute->show(chan, buf);
1295} 1298}
1296 1299
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
index 944f5b63aecd..78603b78cf41 100644
--- a/drivers/hwmon/nct6775.c
+++ b/drivers/hwmon/nct6775.c
@@ -207,8 +207,6 @@ superio_exit(int ioreg)
207 207
208#define NUM_FAN 7 208#define NUM_FAN 7
209 209
210#define TEMP_SOURCE_VIRTUAL 0x1f
211
212/* Common and NCT6775 specific data */ 210/* Common and NCT6775 specific data */
213 211
214/* Voltage min/max registers for nr=7..14 are in bank 5 */ 212/* Voltage min/max registers for nr=7..14 are in bank 5 */
@@ -299,8 +297,9 @@ static const u16 NCT6775_REG_PWM_READ[] = {
299 297
300static const u16 NCT6775_REG_FAN[] = { 0x630, 0x632, 0x634, 0x636, 0x638 }; 298static const u16 NCT6775_REG_FAN[] = { 0x630, 0x632, 0x634, 0x636, 0x638 };
301static const u16 NCT6775_REG_FAN_MIN[] = { 0x3b, 0x3c, 0x3d }; 299static const u16 NCT6775_REG_FAN_MIN[] = { 0x3b, 0x3c, 0x3d };
302static const u16 NCT6775_REG_FAN_PULSES[] = { 0x641, 0x642, 0x643, 0x644, 0 }; 300static const u16 NCT6775_REG_FAN_PULSES[NUM_FAN] = {
303static const u16 NCT6775_FAN_PULSE_SHIFT[] = { 0, 0, 0, 0, 0, 0 }; 301 0x641, 0x642, 0x643, 0x644 };
302static const u16 NCT6775_FAN_PULSE_SHIFT[NUM_FAN] = { };
304 303
305static const u16 NCT6775_REG_TEMP[] = { 304static const u16 NCT6775_REG_TEMP[] = {
306 0x27, 0x150, 0x250, 0x62b, 0x62c, 0x62d }; 305 0x27, 0x150, 0x250, 0x62b, 0x62c, 0x62d };
@@ -373,6 +372,7 @@ static const char *const nct6775_temp_label[] = {
373}; 372};
374 373
375#define NCT6775_TEMP_MASK 0x001ffffe 374#define NCT6775_TEMP_MASK 0x001ffffe
375#define NCT6775_VIRT_TEMP_MASK 0x00000000
376 376
377static const u16 NCT6775_REG_TEMP_ALTERNATE[32] = { 377static const u16 NCT6775_REG_TEMP_ALTERNATE[32] = {
378 [13] = 0x661, 378 [13] = 0x661,
@@ -425,8 +425,8 @@ static const u8 NCT6776_PWM_MODE_MASK[] = { 0x01, 0, 0, 0, 0, 0 };
425 425
426static const u16 NCT6776_REG_FAN_MIN[] = { 426static const u16 NCT6776_REG_FAN_MIN[] = {
427 0x63a, 0x63c, 0x63e, 0x640, 0x642, 0x64a, 0x64c }; 427 0x63a, 0x63c, 0x63e, 0x640, 0x642, 0x64a, 0x64c };
428static const u16 NCT6776_REG_FAN_PULSES[] = { 428static const u16 NCT6776_REG_FAN_PULSES[NUM_FAN] = {
429 0x644, 0x645, 0x646, 0x647, 0x648, 0x649, 0 }; 429 0x644, 0x645, 0x646, 0x647, 0x648, 0x649 };
430 430
431static const u16 NCT6776_REG_WEIGHT_DUTY_BASE[] = { 431static const u16 NCT6776_REG_WEIGHT_DUTY_BASE[] = {
432 0x13e, 0x23e, 0x33e, 0x83e, 0x93e, 0xa3e }; 432 0x13e, 0x23e, 0x33e, 0x83e, 0x93e, 0xa3e };
@@ -461,6 +461,7 @@ static const char *const nct6776_temp_label[] = {
461}; 461};
462 462
463#define NCT6776_TEMP_MASK 0x007ffffe 463#define NCT6776_TEMP_MASK 0x007ffffe
464#define NCT6776_VIRT_TEMP_MASK 0x00000000
464 465
465static const u16 NCT6776_REG_TEMP_ALTERNATE[32] = { 466static const u16 NCT6776_REG_TEMP_ALTERNATE[32] = {
466 [14] = 0x401, 467 [14] = 0x401,
@@ -501,9 +502,9 @@ static const s8 NCT6779_BEEP_BITS[] = {
501 30, 31 }; /* intrusion0, intrusion1 */ 502 30, 31 }; /* intrusion0, intrusion1 */
502 503
503static const u16 NCT6779_REG_FAN[] = { 504static const u16 NCT6779_REG_FAN[] = {
504 0x4b0, 0x4b2, 0x4b4, 0x4b6, 0x4b8, 0x4ba, 0x660 }; 505 0x4c0, 0x4c2, 0x4c4, 0x4c6, 0x4c8, 0x4ca, 0x4ce };
505static const u16 NCT6779_REG_FAN_PULSES[] = { 506static const u16 NCT6779_REG_FAN_PULSES[NUM_FAN] = {
506 0x644, 0x645, 0x646, 0x647, 0x648, 0x649, 0 }; 507 0x644, 0x645, 0x646, 0x647, 0x648, 0x649 };
507 508
508static const u16 NCT6779_REG_CRITICAL_PWM_ENABLE[] = { 509static const u16 NCT6779_REG_CRITICAL_PWM_ENABLE[] = {
509 0x136, 0x236, 0x336, 0x836, 0x936, 0xa36, 0xb36 }; 510 0x136, 0x236, 0x336, 0x836, 0x936, 0xa36, 0xb36 };
@@ -559,7 +560,9 @@ static const char *const nct6779_temp_label[] = {
559}; 560};
560 561
561#define NCT6779_TEMP_MASK 0x07ffff7e 562#define NCT6779_TEMP_MASK 0x07ffff7e
563#define NCT6779_VIRT_TEMP_MASK 0x00000000
562#define NCT6791_TEMP_MASK 0x87ffff7e 564#define NCT6791_TEMP_MASK 0x87ffff7e
565#define NCT6791_VIRT_TEMP_MASK 0x80000000
563 566
564static const u16 NCT6779_REG_TEMP_ALTERNATE[32] 567static const u16 NCT6779_REG_TEMP_ALTERNATE[32]
565 = { 0x490, 0x491, 0x492, 0x493, 0x494, 0x495, 0, 0, 568 = { 0x490, 0x491, 0x492, 0x493, 0x494, 0x495, 0, 0,
@@ -638,6 +641,7 @@ static const char *const nct6792_temp_label[] = {
638}; 641};
639 642
640#define NCT6792_TEMP_MASK 0x9fffff7e 643#define NCT6792_TEMP_MASK 0x9fffff7e
644#define NCT6792_VIRT_TEMP_MASK 0x80000000
641 645
642static const char *const nct6793_temp_label[] = { 646static const char *const nct6793_temp_label[] = {
643 "", 647 "",
@@ -675,6 +679,7 @@ static const char *const nct6793_temp_label[] = {
675}; 679};
676 680
677#define NCT6793_TEMP_MASK 0xbfff037e 681#define NCT6793_TEMP_MASK 0xbfff037e
682#define NCT6793_VIRT_TEMP_MASK 0x80000000
678 683
679static const char *const nct6795_temp_label[] = { 684static const char *const nct6795_temp_label[] = {
680 "", 685 "",
@@ -712,6 +717,7 @@ static const char *const nct6795_temp_label[] = {
712}; 717};
713 718
714#define NCT6795_TEMP_MASK 0xbfffff7e 719#define NCT6795_TEMP_MASK 0xbfffff7e
720#define NCT6795_VIRT_TEMP_MASK 0x80000000
715 721
716static const char *const nct6796_temp_label[] = { 722static const char *const nct6796_temp_label[] = {
717 "", 723 "",
@@ -724,8 +730,8 @@ static const char *const nct6796_temp_label[] = {
724 "AUXTIN4", 730 "AUXTIN4",
725 "SMBUSMASTER 0", 731 "SMBUSMASTER 0",
726 "SMBUSMASTER 1", 732 "SMBUSMASTER 1",
727 "", 733 "Virtual_TEMP",
728 "", 734 "Virtual_TEMP",
729 "", 735 "",
730 "", 736 "",
731 "", 737 "",
@@ -748,7 +754,8 @@ static const char *const nct6796_temp_label[] = {
748 "Virtual_TEMP" 754 "Virtual_TEMP"
749}; 755};
750 756
751#define NCT6796_TEMP_MASK 0xbfff03fe 757#define NCT6796_TEMP_MASK 0xbfff0ffe
758#define NCT6796_VIRT_TEMP_MASK 0x80000c00
752 759
753/* NCT6102D/NCT6106D specific data */ 760/* NCT6102D/NCT6106D specific data */
754 761
@@ -779,8 +786,8 @@ static const u16 NCT6106_REG_TEMP_CONFIG[] = {
779 786
780static const u16 NCT6106_REG_FAN[] = { 0x20, 0x22, 0x24 }; 787static const u16 NCT6106_REG_FAN[] = { 0x20, 0x22, 0x24 };
781static const u16 NCT6106_REG_FAN_MIN[] = { 0xe0, 0xe2, 0xe4 }; 788static const u16 NCT6106_REG_FAN_MIN[] = { 0xe0, 0xe2, 0xe4 };
782static const u16 NCT6106_REG_FAN_PULSES[] = { 0xf6, 0xf6, 0xf6, 0, 0 }; 789static const u16 NCT6106_REG_FAN_PULSES[] = { 0xf6, 0xf6, 0xf6 };
783static const u16 NCT6106_FAN_PULSE_SHIFT[] = { 0, 2, 4, 0, 0 }; 790static const u16 NCT6106_FAN_PULSE_SHIFT[] = { 0, 2, 4 };
784 791
785static const u8 NCT6106_REG_PWM_MODE[] = { 0xf3, 0xf3, 0xf3 }; 792static const u8 NCT6106_REG_PWM_MODE[] = { 0xf3, 0xf3, 0xf3 };
786static const u8 NCT6106_PWM_MODE_MASK[] = { 0x01, 0x02, 0x04 }; 793static const u8 NCT6106_PWM_MODE_MASK[] = { 0x01, 0x02, 0x04 };
@@ -917,6 +924,11 @@ static unsigned int fan_from_reg16(u16 reg, unsigned int divreg)
917 return 1350000U / (reg << divreg); 924 return 1350000U / (reg << divreg);
918} 925}
919 926
927static unsigned int fan_from_reg_rpm(u16 reg, unsigned int divreg)
928{
929 return reg;
930}
931
920static u16 fan_to_reg(u32 fan, unsigned int divreg) 932static u16 fan_to_reg(u32 fan, unsigned int divreg)
921{ 933{
922 if (!fan) 934 if (!fan)
@@ -969,6 +981,7 @@ struct nct6775_data {
969 u16 reg_temp_config[NUM_TEMP]; 981 u16 reg_temp_config[NUM_TEMP];
970 const char * const *temp_label; 982 const char * const *temp_label;
971 u32 temp_mask; 983 u32 temp_mask;
984 u32 virt_temp_mask;
972 985
973 u16 REG_CONFIG; 986 u16 REG_CONFIG;
974 u16 REG_VBAT; 987 u16 REG_VBAT;
@@ -1276,11 +1289,11 @@ static bool is_word_sized(struct nct6775_data *data, u16 reg)
1276 case nct6795: 1289 case nct6795:
1277 case nct6796: 1290 case nct6796:
1278 return reg == 0x150 || reg == 0x153 || reg == 0x155 || 1291 return reg == 0x150 || reg == 0x153 || reg == 0x155 ||
1279 ((reg & 0xfff0) == 0x4b0 && (reg & 0x000f) < 0x0b) || 1292 (reg & 0xfff0) == 0x4c0 ||
1280 reg == 0x402 || 1293 reg == 0x402 ||
1281 reg == 0x63a || reg == 0x63c || reg == 0x63e || 1294 reg == 0x63a || reg == 0x63c || reg == 0x63e ||
1282 reg == 0x640 || reg == 0x642 || reg == 0x64a || 1295 reg == 0x640 || reg == 0x642 || reg == 0x64a ||
1283 reg == 0x64c || reg == 0x660 || 1296 reg == 0x64c ||
1284 reg == 0x73 || reg == 0x75 || reg == 0x77 || reg == 0x79 || 1297 reg == 0x73 || reg == 0x75 || reg == 0x77 || reg == 0x79 ||
1285 reg == 0x7b || reg == 0x7d; 1298 reg == 0x7b || reg == 0x7d;
1286 } 1299 }
@@ -1558,7 +1571,7 @@ static void nct6775_update_pwm(struct device *dev)
1558 reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]); 1571 reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]);
1559 data->pwm_weight_temp_sel[i] = reg & 0x1f; 1572 data->pwm_weight_temp_sel[i] = reg & 0x1f;
1560 /* If weight is disabled, report weight source as 0 */ 1573 /* If weight is disabled, report weight source as 0 */
1561 if (j == 1 && !(reg & 0x80)) 1574 if (!(reg & 0x80))
1562 data->pwm_weight_temp_sel[i] = 0; 1575 data->pwm_weight_temp_sel[i] = 0;
1563 1576
1564 /* Weight temp data */ 1577 /* Weight temp data */
@@ -1682,9 +1695,13 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
1682 if (data->has_fan_min & BIT(i)) 1695 if (data->has_fan_min & BIT(i))
1683 data->fan_min[i] = nct6775_read_value(data, 1696 data->fan_min[i] = nct6775_read_value(data,
1684 data->REG_FAN_MIN[i]); 1697 data->REG_FAN_MIN[i]);
1685 data->fan_pulses[i] = 1698
1686 (nct6775_read_value(data, data->REG_FAN_PULSES[i]) 1699 if (data->REG_FAN_PULSES[i]) {
1687 >> data->FAN_PULSE_SHIFT[i]) & 0x03; 1700 data->fan_pulses[i] =
1701 (nct6775_read_value(data,
1702 data->REG_FAN_PULSES[i])
1703 >> data->FAN_PULSE_SHIFT[i]) & 0x03;
1704 }
1688 1705
1689 nct6775_select_fan_div(dev, data, i, reg); 1706 nct6775_select_fan_div(dev, data, i, reg);
1690 } 1707 }
@@ -3639,6 +3656,7 @@ static int nct6775_probe(struct platform_device *pdev)
3639 3656
3640 data->temp_label = nct6776_temp_label; 3657 data->temp_label = nct6776_temp_label;
3641 data->temp_mask = NCT6776_TEMP_MASK; 3658 data->temp_mask = NCT6776_TEMP_MASK;
3659 data->virt_temp_mask = NCT6776_VIRT_TEMP_MASK;
3642 3660
3643 data->REG_VBAT = NCT6106_REG_VBAT; 3661 data->REG_VBAT = NCT6106_REG_VBAT;
3644 data->REG_DIODE = NCT6106_REG_DIODE; 3662 data->REG_DIODE = NCT6106_REG_DIODE;
@@ -3717,6 +3735,7 @@ static int nct6775_probe(struct platform_device *pdev)
3717 3735
3718 data->temp_label = nct6775_temp_label; 3736 data->temp_label = nct6775_temp_label;
3719 data->temp_mask = NCT6775_TEMP_MASK; 3737 data->temp_mask = NCT6775_TEMP_MASK;
3738 data->virt_temp_mask = NCT6775_VIRT_TEMP_MASK;
3720 3739
3721 data->REG_CONFIG = NCT6775_REG_CONFIG; 3740 data->REG_CONFIG = NCT6775_REG_CONFIG;
3722 data->REG_VBAT = NCT6775_REG_VBAT; 3741 data->REG_VBAT = NCT6775_REG_VBAT;
@@ -3789,6 +3808,7 @@ static int nct6775_probe(struct platform_device *pdev)
3789 3808
3790 data->temp_label = nct6776_temp_label; 3809 data->temp_label = nct6776_temp_label;
3791 data->temp_mask = NCT6776_TEMP_MASK; 3810 data->temp_mask = NCT6776_TEMP_MASK;
3811 data->virt_temp_mask = NCT6776_VIRT_TEMP_MASK;
3792 3812
3793 data->REG_CONFIG = NCT6775_REG_CONFIG; 3813 data->REG_CONFIG = NCT6775_REG_CONFIG;
3794 data->REG_VBAT = NCT6775_REG_VBAT; 3814 data->REG_VBAT = NCT6775_REG_VBAT;
@@ -3853,7 +3873,7 @@ static int nct6775_probe(struct platform_device *pdev)
3853 data->ALARM_BITS = NCT6779_ALARM_BITS; 3873 data->ALARM_BITS = NCT6779_ALARM_BITS;
3854 data->BEEP_BITS = NCT6779_BEEP_BITS; 3874 data->BEEP_BITS = NCT6779_BEEP_BITS;
3855 3875
3856 data->fan_from_reg = fan_from_reg13; 3876 data->fan_from_reg = fan_from_reg_rpm;
3857 data->fan_from_reg_min = fan_from_reg13; 3877 data->fan_from_reg_min = fan_from_reg13;
3858 data->target_temp_mask = 0xff; 3878 data->target_temp_mask = 0xff;
3859 data->tolerance_mask = 0x07; 3879 data->tolerance_mask = 0x07;
@@ -3861,6 +3881,7 @@ static int nct6775_probe(struct platform_device *pdev)
3861 3881
3862 data->temp_label = nct6779_temp_label; 3882 data->temp_label = nct6779_temp_label;
3863 data->temp_mask = NCT6779_TEMP_MASK; 3883 data->temp_mask = NCT6779_TEMP_MASK;
3884 data->virt_temp_mask = NCT6779_VIRT_TEMP_MASK;
3864 3885
3865 data->REG_CONFIG = NCT6775_REG_CONFIG; 3886 data->REG_CONFIG = NCT6775_REG_CONFIG;
3866 data->REG_VBAT = NCT6775_REG_VBAT; 3887 data->REG_VBAT = NCT6775_REG_VBAT;
@@ -3933,7 +3954,7 @@ static int nct6775_probe(struct platform_device *pdev)
3933 data->ALARM_BITS = NCT6791_ALARM_BITS; 3954 data->ALARM_BITS = NCT6791_ALARM_BITS;
3934 data->BEEP_BITS = NCT6779_BEEP_BITS; 3955 data->BEEP_BITS = NCT6779_BEEP_BITS;
3935 3956
3936 data->fan_from_reg = fan_from_reg13; 3957 data->fan_from_reg = fan_from_reg_rpm;
3937 data->fan_from_reg_min = fan_from_reg13; 3958 data->fan_from_reg_min = fan_from_reg13;
3938 data->target_temp_mask = 0xff; 3959 data->target_temp_mask = 0xff;
3939 data->tolerance_mask = 0x07; 3960 data->tolerance_mask = 0x07;
@@ -3944,22 +3965,27 @@ static int nct6775_probe(struct platform_device *pdev)
3944 case nct6791: 3965 case nct6791:
3945 data->temp_label = nct6779_temp_label; 3966 data->temp_label = nct6779_temp_label;
3946 data->temp_mask = NCT6791_TEMP_MASK; 3967 data->temp_mask = NCT6791_TEMP_MASK;
3968 data->virt_temp_mask = NCT6791_VIRT_TEMP_MASK;
3947 break; 3969 break;
3948 case nct6792: 3970 case nct6792:
3949 data->temp_label = nct6792_temp_label; 3971 data->temp_label = nct6792_temp_label;
3950 data->temp_mask = NCT6792_TEMP_MASK; 3972 data->temp_mask = NCT6792_TEMP_MASK;
3973 data->virt_temp_mask = NCT6792_VIRT_TEMP_MASK;
3951 break; 3974 break;
3952 case nct6793: 3975 case nct6793:
3953 data->temp_label = nct6793_temp_label; 3976 data->temp_label = nct6793_temp_label;
3954 data->temp_mask = NCT6793_TEMP_MASK; 3977 data->temp_mask = NCT6793_TEMP_MASK;
3978 data->virt_temp_mask = NCT6793_VIRT_TEMP_MASK;
3955 break; 3979 break;
3956 case nct6795: 3980 case nct6795:
3957 data->temp_label = nct6795_temp_label; 3981 data->temp_label = nct6795_temp_label;
3958 data->temp_mask = NCT6795_TEMP_MASK; 3982 data->temp_mask = NCT6795_TEMP_MASK;
3983 data->virt_temp_mask = NCT6795_VIRT_TEMP_MASK;
3959 break; 3984 break;
3960 case nct6796: 3985 case nct6796:
3961 data->temp_label = nct6796_temp_label; 3986 data->temp_label = nct6796_temp_label;
3962 data->temp_mask = NCT6796_TEMP_MASK; 3987 data->temp_mask = NCT6796_TEMP_MASK;
3988 data->virt_temp_mask = NCT6796_VIRT_TEMP_MASK;
3963 break; 3989 break;
3964 } 3990 }
3965 3991
@@ -4143,7 +4169,7 @@ static int nct6775_probe(struct platform_device *pdev)
4143 * for each fan reflects a different temperature, and there 4169 * for each fan reflects a different temperature, and there
4144 * are no duplicates. 4170 * are no duplicates.
4145 */ 4171 */
4146 if (src != TEMP_SOURCE_VIRTUAL) { 4172 if (!(data->virt_temp_mask & BIT(src))) {
4147 if (mask & BIT(src)) 4173 if (mask & BIT(src))
4148 continue; 4174 continue;
4149 mask |= BIT(src); 4175 mask |= BIT(src);
diff --git a/drivers/hwmon/npcm750-pwm-fan.c b/drivers/hwmon/npcm750-pwm-fan.c
index 8474d601aa63..b998f9fbed41 100644
--- a/drivers/hwmon/npcm750-pwm-fan.c
+++ b/drivers/hwmon/npcm750-pwm-fan.c
@@ -908,7 +908,7 @@ static int npcm7xx_en_pwm_fan(struct device *dev,
908 if (fan_cnt < 1) 908 if (fan_cnt < 1)
909 return -EINVAL; 909 return -EINVAL;
910 910
911 fan_ch = devm_kzalloc(dev, sizeof(*fan_ch) * fan_cnt, GFP_KERNEL); 911 fan_ch = devm_kcalloc(dev, fan_cnt, sizeof(*fan_ch), GFP_KERNEL);
912 if (!fan_ch) 912 if (!fan_ch)
913 return -ENOMEM; 913 return -ENOMEM;
914 914
diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
index da962aa2cef5..fc6b7f8b62fb 100644
--- a/drivers/hwtracing/intel_th/core.c
+++ b/drivers/hwtracing/intel_th/core.c
@@ -139,7 +139,8 @@ static int intel_th_remove(struct device *dev)
139 th->thdev[i] = NULL; 139 th->thdev[i] = NULL;
140 } 140 }
141 141
142 th->num_thdevs = lowest; 142 if (lowest >= 0)
143 th->num_thdevs = lowest;
143 } 144 }
144 145
145 if (thdrv->attr_group) 146 if (thdrv->attr_group)
@@ -487,7 +488,7 @@ static const struct intel_th_subdevice {
487 .flags = IORESOURCE_MEM, 488 .flags = IORESOURCE_MEM,
488 }, 489 },
489 { 490 {
490 .start = TH_MMIO_SW, 491 .start = 1, /* use resource[1] */
491 .end = 0, 492 .end = 0,
492 .flags = IORESOURCE_MEM, 493 .flags = IORESOURCE_MEM,
493 }, 494 },
@@ -580,6 +581,7 @@ intel_th_subdevice_alloc(struct intel_th *th,
580 struct intel_th_device *thdev; 581 struct intel_th_device *thdev;
581 struct resource res[3]; 582 struct resource res[3];
582 unsigned int req = 0; 583 unsigned int req = 0;
584 bool is64bit = false;
583 int r, err; 585 int r, err;
584 586
585 thdev = intel_th_device_alloc(th, subdev->type, subdev->name, 587 thdev = intel_th_device_alloc(th, subdev->type, subdev->name,
@@ -589,12 +591,18 @@ intel_th_subdevice_alloc(struct intel_th *th,
589 591
590 thdev->drvdata = th->drvdata; 592 thdev->drvdata = th->drvdata;
591 593
594 for (r = 0; r < th->num_resources; r++)
595 if (th->resource[r].flags & IORESOURCE_MEM_64) {
596 is64bit = true;
597 break;
598 }
599
592 memcpy(res, subdev->res, 600 memcpy(res, subdev->res,
593 sizeof(struct resource) * subdev->nres); 601 sizeof(struct resource) * subdev->nres);
594 602
595 for (r = 0; r < subdev->nres; r++) { 603 for (r = 0; r < subdev->nres; r++) {
596 struct resource *devres = th->resource; 604 struct resource *devres = th->resource;
597 int bar = TH_MMIO_CONFIG; 605 int bar = 0; /* cut subdevices' MMIO from resource[0] */
598 606
599 /* 607 /*
600 * Take .end == 0 to mean 'take the whole bar', 608 * Take .end == 0 to mean 'take the whole bar',
@@ -603,6 +611,8 @@ intel_th_subdevice_alloc(struct intel_th *th,
603 */ 611 */
604 if (!res[r].end && res[r].flags == IORESOURCE_MEM) { 612 if (!res[r].end && res[r].flags == IORESOURCE_MEM) {
605 bar = res[r].start; 613 bar = res[r].start;
614 if (is64bit)
615 bar *= 2;
606 res[r].start = 0; 616 res[r].start = 0;
607 res[r].end = resource_size(&devres[bar]) - 1; 617 res[r].end = resource_size(&devres[bar]) - 1;
608 } 618 }
diff --git a/drivers/hwtracing/intel_th/pci.c b/drivers/hwtracing/intel_th/pci.c
index c2e55e5d97f6..1cf6290d6435 100644
--- a/drivers/hwtracing/intel_th/pci.c
+++ b/drivers/hwtracing/intel_th/pci.c
@@ -160,6 +160,11 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
160 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x18e1), 160 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x18e1),
161 .driver_data = (kernel_ulong_t)&intel_th_2x, 161 .driver_data = (kernel_ulong_t)&intel_th_2x,
162 }, 162 },
163 {
164 /* Ice Lake PCH */
165 PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x34a6),
166 .driver_data = (kernel_ulong_t)&intel_th_2x,
167 },
163 { 0 }, 168 { 0 },
164}; 169};
165 170
diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 94d94b4a9a0d..18cc324f3ca9 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -34,11 +34,11 @@ static void i2c_dw_configure_fifo_master(struct dw_i2c_dev *dev)
34 34
35static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev) 35static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
36{ 36{
37 u32 ic_clk = i2c_dw_clk_rate(dev);
38 const char *mode_str, *fp_str = ""; 37 const char *mode_str, *fp_str = "";
39 u32 comp_param1; 38 u32 comp_param1;
40 u32 sda_falling_time, scl_falling_time; 39 u32 sda_falling_time, scl_falling_time;
41 struct i2c_timings *t = &dev->timings; 40 struct i2c_timings *t = &dev->timings;
41 u32 ic_clk;
42 int ret; 42 int ret;
43 43
44 ret = i2c_dw_acquire_lock(dev); 44 ret = i2c_dw_acquire_lock(dev);
@@ -53,6 +53,7 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
53 53
54 /* Calculate SCL timing parameters for standard mode if not set */ 54 /* Calculate SCL timing parameters for standard mode if not set */
55 if (!dev->ss_hcnt || !dev->ss_lcnt) { 55 if (!dev->ss_hcnt || !dev->ss_lcnt) {
56 ic_clk = i2c_dw_clk_rate(dev);
56 dev->ss_hcnt = 57 dev->ss_hcnt =
57 i2c_dw_scl_hcnt(ic_clk, 58 i2c_dw_scl_hcnt(ic_clk,
58 4000, /* tHD;STA = tHIGH = 4.0 us */ 59 4000, /* tHD;STA = tHIGH = 4.0 us */
@@ -89,6 +90,7 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
89 * needed also in high speed mode. 90 * needed also in high speed mode.
90 */ 91 */
91 if (!dev->fs_hcnt || !dev->fs_lcnt) { 92 if (!dev->fs_hcnt || !dev->fs_lcnt) {
93 ic_clk = i2c_dw_clk_rate(dev);
92 dev->fs_hcnt = 94 dev->fs_hcnt =
93 i2c_dw_scl_hcnt(ic_clk, 95 i2c_dw_scl_hcnt(ic_clk,
94 600, /* tHD;STA = tHIGH = 0.6 us */ 96 600, /* tHD;STA = tHIGH = 0.6 us */
diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
index 0cf1379f4e80..5c754bf659e2 100644
--- a/drivers/i2c/busses/i2c-isch.c
+++ b/drivers/i2c/busses/i2c-isch.c
@@ -164,7 +164,7 @@ static s32 sch_access(struct i2c_adapter *adap, u16 addr,
164 * run ~75 kHz instead which should do no harm. 164 * run ~75 kHz instead which should do no harm.
165 */ 165 */
166 dev_notice(&sch_adapter.dev, 166 dev_notice(&sch_adapter.dev,
167 "Clock divider unitialized. Setting defaults\n"); 167 "Clock divider uninitialized. Setting defaults\n");
168 outw(backbone_speed / (4 * 100), SMBHSTCLK); 168 outw(backbone_speed / (4 * 100), SMBHSTCLK);
169 } 169 }
170 170
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index 36732eb688a4..9f2eb02481d3 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -367,20 +367,26 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
367 dma_addr_t rx_dma; 367 dma_addr_t rx_dma;
368 enum geni_se_xfer_mode mode; 368 enum geni_se_xfer_mode mode;
369 unsigned long time_left = XFER_TIMEOUT; 369 unsigned long time_left = XFER_TIMEOUT;
370 void *dma_buf;
370 371
371 gi2c->cur = msg; 372 gi2c->cur = msg;
372 mode = msg->len > 32 ? GENI_SE_DMA : GENI_SE_FIFO; 373 mode = GENI_SE_FIFO;
374 dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
375 if (dma_buf)
376 mode = GENI_SE_DMA;
377
373 geni_se_select_mode(&gi2c->se, mode); 378 geni_se_select_mode(&gi2c->se, mode);
374 writel_relaxed(msg->len, gi2c->se.base + SE_I2C_RX_TRANS_LEN); 379 writel_relaxed(msg->len, gi2c->se.base + SE_I2C_RX_TRANS_LEN);
375 geni_se_setup_m_cmd(&gi2c->se, I2C_READ, m_param); 380 geni_se_setup_m_cmd(&gi2c->se, I2C_READ, m_param);
376 if (mode == GENI_SE_DMA) { 381 if (mode == GENI_SE_DMA) {
377 int ret; 382 int ret;
378 383
379 ret = geni_se_rx_dma_prep(&gi2c->se, msg->buf, msg->len, 384 ret = geni_se_rx_dma_prep(&gi2c->se, dma_buf, msg->len,
380 &rx_dma); 385 &rx_dma);
381 if (ret) { 386 if (ret) {
382 mode = GENI_SE_FIFO; 387 mode = GENI_SE_FIFO;
383 geni_se_select_mode(&gi2c->se, mode); 388 geni_se_select_mode(&gi2c->se, mode);
389 i2c_put_dma_safe_msg_buf(dma_buf, msg, false);
384 } 390 }
385 } 391 }
386 392
@@ -393,6 +399,7 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
393 if (gi2c->err) 399 if (gi2c->err)
394 geni_i2c_rx_fsm_rst(gi2c); 400 geni_i2c_rx_fsm_rst(gi2c);
395 geni_se_rx_dma_unprep(&gi2c->se, rx_dma, msg->len); 401 geni_se_rx_dma_unprep(&gi2c->se, rx_dma, msg->len);
402 i2c_put_dma_safe_msg_buf(dma_buf, msg, !gi2c->err);
396 } 403 }
397 return gi2c->err; 404 return gi2c->err;
398} 405}
@@ -403,20 +410,26 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
403 dma_addr_t tx_dma; 410 dma_addr_t tx_dma;
404 enum geni_se_xfer_mode mode; 411 enum geni_se_xfer_mode mode;
405 unsigned long time_left; 412 unsigned long time_left;
413 void *dma_buf;
406 414
407 gi2c->cur = msg; 415 gi2c->cur = msg;
408 mode = msg->len > 32 ? GENI_SE_DMA : GENI_SE_FIFO; 416 mode = GENI_SE_FIFO;
417 dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
418 if (dma_buf)
419 mode = GENI_SE_DMA;
420
409 geni_se_select_mode(&gi2c->se, mode); 421 geni_se_select_mode(&gi2c->se, mode);
410 writel_relaxed(msg->len, gi2c->se.base + SE_I2C_TX_TRANS_LEN); 422 writel_relaxed(msg->len, gi2c->se.base + SE_I2C_TX_TRANS_LEN);
411 geni_se_setup_m_cmd(&gi2c->se, I2C_WRITE, m_param); 423 geni_se_setup_m_cmd(&gi2c->se, I2C_WRITE, m_param);
412 if (mode == GENI_SE_DMA) { 424 if (mode == GENI_SE_DMA) {
413 int ret; 425 int ret;
414 426
415 ret = geni_se_tx_dma_prep(&gi2c->se, msg->buf, msg->len, 427 ret = geni_se_tx_dma_prep(&gi2c->se, dma_buf, msg->len,
416 &tx_dma); 428 &tx_dma);
417 if (ret) { 429 if (ret) {
418 mode = GENI_SE_FIFO; 430 mode = GENI_SE_FIFO;
419 geni_se_select_mode(&gi2c->se, mode); 431 geni_se_select_mode(&gi2c->se, mode);
432 i2c_put_dma_safe_msg_buf(dma_buf, msg, false);
420 } 433 }
421 } 434 }
422 435
@@ -432,6 +445,7 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
432 if (gi2c->err) 445 if (gi2c->err)
433 geni_i2c_tx_fsm_rst(gi2c); 446 geni_i2c_tx_fsm_rst(gi2c);
434 geni_se_tx_dma_unprep(&gi2c->se, tx_dma, msg->len); 447 geni_se_tx_dma_unprep(&gi2c->se, tx_dma, msg->len);
448 i2c_put_dma_safe_msg_buf(dma_buf, msg, !gi2c->err);
435 } 449 }
436 return gi2c->err; 450 return gi2c->err;
437} 451}
diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
index a01389b85f13..7e9a2bbf5ddc 100644
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -152,6 +152,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
152 mt_params[3].type = ACPI_TYPE_INTEGER; 152 mt_params[3].type = ACPI_TYPE_INTEGER;
153 mt_params[3].integer.value = len; 153 mt_params[3].integer.value = len;
154 mt_params[4].type = ACPI_TYPE_BUFFER; 154 mt_params[4].type = ACPI_TYPE_BUFFER;
155 mt_params[4].buffer.length = len;
155 mt_params[4].buffer.pointer = data->block + 1; 156 mt_params[4].buffer.pointer = data->block + 1;
156 } 157 }
157 break; 158 break;
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 9ee9a15e7134..9200e349f29e 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -2270,7 +2270,7 @@ EXPORT_SYMBOL(i2c_put_adapter);
2270 * 2270 *
2271 * Return: NULL if a DMA safe buffer was not obtained. Use msg->buf with PIO. 2271 * Return: NULL if a DMA safe buffer was not obtained. Use msg->buf with PIO.
2272 * Or a valid pointer to be used with DMA. After use, release it by 2272 * Or a valid pointer to be used with DMA. After use, release it by
2273 * calling i2c_release_dma_safe_msg_buf(). 2273 * calling i2c_put_dma_safe_msg_buf().
2274 * 2274 *
2275 * This function must only be called from process context! 2275 * This function must only be called from process context!
2276 */ 2276 */
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
index 7589f2ad1dae..631360b14ca7 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
@@ -187,12 +187,15 @@ static int st_lsm6dsx_set_fifo_odr(struct st_lsm6dsx_sensor *sensor,
187 187
188int st_lsm6dsx_update_watermark(struct st_lsm6dsx_sensor *sensor, u16 watermark) 188int st_lsm6dsx_update_watermark(struct st_lsm6dsx_sensor *sensor, u16 watermark)
189{ 189{
190 u16 fifo_watermark = ~0, cur_watermark, sip = 0, fifo_th_mask; 190 u16 fifo_watermark = ~0, cur_watermark, fifo_th_mask;
191 struct st_lsm6dsx_hw *hw = sensor->hw; 191 struct st_lsm6dsx_hw *hw = sensor->hw;
192 struct st_lsm6dsx_sensor *cur_sensor; 192 struct st_lsm6dsx_sensor *cur_sensor;
193 int i, err, data; 193 int i, err, data;
194 __le16 wdata; 194 __le16 wdata;
195 195
196 if (!hw->sip)
197 return 0;
198
196 for (i = 0; i < ST_LSM6DSX_ID_MAX; i++) { 199 for (i = 0; i < ST_LSM6DSX_ID_MAX; i++) {
197 cur_sensor = iio_priv(hw->iio_devs[i]); 200 cur_sensor = iio_priv(hw->iio_devs[i]);
198 201
@@ -203,14 +206,10 @@ int st_lsm6dsx_update_watermark(struct st_lsm6dsx_sensor *sensor, u16 watermark)
203 : cur_sensor->watermark; 206 : cur_sensor->watermark;
204 207
205 fifo_watermark = min_t(u16, fifo_watermark, cur_watermark); 208 fifo_watermark = min_t(u16, fifo_watermark, cur_watermark);
206 sip += cur_sensor->sip;
207 } 209 }
208 210
209 if (!sip) 211 fifo_watermark = max_t(u16, fifo_watermark, hw->sip);
210 return 0; 212 fifo_watermark = (fifo_watermark / hw->sip) * hw->sip;
211
212 fifo_watermark = max_t(u16, fifo_watermark, sip);
213 fifo_watermark = (fifo_watermark / sip) * sip;
214 fifo_watermark = fifo_watermark * hw->settings->fifo_ops.th_wl; 213 fifo_watermark = fifo_watermark * hw->settings->fifo_ops.th_wl;
215 214
216 err = regmap_read(hw->regmap, hw->settings->fifo_ops.fifo_th.addr + 1, 215 err = regmap_read(hw->regmap, hw->settings->fifo_ops.fifo_th.addr + 1,
diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
index 54e383231d1e..c31b9633f32d 100644
--- a/drivers/iio/temperature/maxim_thermocouple.c
+++ b/drivers/iio/temperature/maxim_thermocouple.c
@@ -258,7 +258,6 @@ static int maxim_thermocouple_remove(struct spi_device *spi)
258static const struct spi_device_id maxim_thermocouple_id[] = { 258static const struct spi_device_id maxim_thermocouple_id[] = {
259 {"max6675", MAX6675}, 259 {"max6675", MAX6675},
260 {"max31855", MAX31855}, 260 {"max31855", MAX31855},
261 {"max31856", MAX31855},
262 {}, 261 {},
263}; 262};
264MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id); 263MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
index 0bee1f4b914e..3208ad6ad540 100644
--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -338,6 +338,39 @@ static int add_roce_gid(struct ib_gid_table_entry *entry)
338} 338}
339 339
340/** 340/**
341 * del_gid - Delete GID table entry
342 *
343 * @ib_dev: IB device whose GID entry to be deleted
344 * @port: Port number of the IB device
345 * @table: GID table of the IB device for a port
346 * @ix: GID entry index to delete
347 *
348 */
349static void del_gid(struct ib_device *ib_dev, u8 port,
350 struct ib_gid_table *table, int ix)
351{
352 struct ib_gid_table_entry *entry;
353
354 lockdep_assert_held(&table->lock);
355
356 pr_debug("%s device=%s port=%d index=%d gid %pI6\n", __func__,
357 ib_dev->name, port, ix,
358 table->data_vec[ix]->attr.gid.raw);
359
360 write_lock_irq(&table->rwlock);
361 entry = table->data_vec[ix];
362 entry->state = GID_TABLE_ENTRY_PENDING_DEL;
363 /*
364 * For non RoCE protocol, GID entry slot is ready to use.
365 */
366 if (!rdma_protocol_roce(ib_dev, port))
367 table->data_vec[ix] = NULL;
368 write_unlock_irq(&table->rwlock);
369
370 put_gid_entry_locked(entry);
371}
372
373/**
341 * add_modify_gid - Add or modify GID table entry 374 * add_modify_gid - Add or modify GID table entry
342 * 375 *
343 * @table: GID table in which GID to be added or modified 376 * @table: GID table in which GID to be added or modified
@@ -358,7 +391,7 @@ static int add_modify_gid(struct ib_gid_table *table,
358 * this index. 391 * this index.
359 */ 392 */
360 if (is_gid_entry_valid(table->data_vec[attr->index])) 393 if (is_gid_entry_valid(table->data_vec[attr->index]))
361 put_gid_entry(table->data_vec[attr->index]); 394 del_gid(attr->device, attr->port_num, table, attr->index);
362 395
363 /* 396 /*
364 * Some HCA's report multiple GID entries with only one valid GID, and 397 * Some HCA's report multiple GID entries with only one valid GID, and
@@ -386,39 +419,6 @@ done:
386 return ret; 419 return ret;
387} 420}
388 421
389/**
390 * del_gid - Delete GID table entry
391 *
392 * @ib_dev: IB device whose GID entry to be deleted
393 * @port: Port number of the IB device
394 * @table: GID table of the IB device for a port
395 * @ix: GID entry index to delete
396 *
397 */
398static void del_gid(struct ib_device *ib_dev, u8 port,
399 struct ib_gid_table *table, int ix)
400{
401 struct ib_gid_table_entry *entry;
402
403 lockdep_assert_held(&table->lock);
404
405 pr_debug("%s device=%s port=%d index=%d gid %pI6\n", __func__,
406 ib_dev->name, port, ix,
407 table->data_vec[ix]->attr.gid.raw);
408
409 write_lock_irq(&table->rwlock);
410 entry = table->data_vec[ix];
411 entry->state = GID_TABLE_ENTRY_PENDING_DEL;
412 /*
413 * For non RoCE protocol, GID entry slot is ready to use.
414 */
415 if (!rdma_protocol_roce(ib_dev, port))
416 table->data_vec[ix] = NULL;
417 write_unlock_irq(&table->rwlock);
418
419 put_gid_entry_locked(entry);
420}
421
422/* rwlock should be read locked, or lock should be held */ 422/* rwlock should be read locked, or lock should be held */
423static int find_gid(struct ib_gid_table *table, const union ib_gid *gid, 423static int find_gid(struct ib_gid_table *table, const union ib_gid *gid,
424 const struct ib_gid_attr *val, bool default_gid, 424 const struct ib_gid_attr *val, bool default_gid,
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index f72677291b69..a36c94930c31 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -724,6 +724,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv)
724 dgid = (union ib_gid *) &addr->sib_addr; 724 dgid = (union ib_gid *) &addr->sib_addr;
725 pkey = ntohs(addr->sib_pkey); 725 pkey = ntohs(addr->sib_pkey);
726 726
727 mutex_lock(&lock);
727 list_for_each_entry(cur_dev, &dev_list, list) { 728 list_for_each_entry(cur_dev, &dev_list, list) {
728 for (p = 1; p <= cur_dev->device->phys_port_cnt; ++p) { 729 for (p = 1; p <= cur_dev->device->phys_port_cnt; ++p) {
729 if (!rdma_cap_af_ib(cur_dev->device, p)) 730 if (!rdma_cap_af_ib(cur_dev->device, p))
@@ -750,18 +751,19 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv)
750 cma_dev = cur_dev; 751 cma_dev = cur_dev;
751 sgid = gid; 752 sgid = gid;
752 id_priv->id.port_num = p; 753 id_priv->id.port_num = p;
754 goto found;
753 } 755 }
754 } 756 }
755 } 757 }
756 } 758 }
757 759 mutex_unlock(&lock);
758 if (!cma_dev) 760 return -ENODEV;
759 return -ENODEV;
760 761
761found: 762found:
762 cma_attach_to_dev(id_priv, cma_dev); 763 cma_attach_to_dev(id_priv, cma_dev);
763 addr = (struct sockaddr_ib *) cma_src_addr(id_priv); 764 mutex_unlock(&lock);
764 memcpy(&addr->sib_addr, &sgid, sizeof sgid); 765 addr = (struct sockaddr_ib *)cma_src_addr(id_priv);
766 memcpy(&addr->sib_addr, &sgid, sizeof(sgid));
765 cma_translate_ib(addr, &id_priv->id.route.addr.dev_addr); 767 cma_translate_ib(addr, &id_priv->id.route.addr.dev_addr);
766 return 0; 768 return 0;
767} 769}
diff --git a/drivers/infiniband/core/rdma_core.c b/drivers/infiniband/core/rdma_core.c
index 6eb64c6f0802..c4118bcd5103 100644
--- a/drivers/infiniband/core/rdma_core.c
+++ b/drivers/infiniband/core/rdma_core.c
@@ -882,6 +882,8 @@ static int __uverbs_cleanup_ufile(struct ib_uverbs_file *ufile,
882 WARN_ON(uverbs_try_lock_object(obj, UVERBS_LOOKUP_WRITE)); 882 WARN_ON(uverbs_try_lock_object(obj, UVERBS_LOOKUP_WRITE));
883 if (!uverbs_destroy_uobject(obj, reason)) 883 if (!uverbs_destroy_uobject(obj, reason))
884 ret = 0; 884 ret = 0;
885 else
886 atomic_set(&obj->usecnt, 0);
885 } 887 }
886 return ret; 888 return ret;
887} 889}
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index ec8fb289621f..21863ddde63e 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -124,6 +124,8 @@ static DEFINE_MUTEX(mut);
124static DEFINE_IDR(ctx_idr); 124static DEFINE_IDR(ctx_idr);
125static DEFINE_IDR(multicast_idr); 125static DEFINE_IDR(multicast_idr);
126 126
127static const struct file_operations ucma_fops;
128
127static inline struct ucma_context *_ucma_find_context(int id, 129static inline struct ucma_context *_ucma_find_context(int id,
128 struct ucma_file *file) 130 struct ucma_file *file)
129{ 131{
@@ -1581,6 +1583,10 @@ static ssize_t ucma_migrate_id(struct ucma_file *new_file,
1581 f = fdget(cmd.fd); 1583 f = fdget(cmd.fd);
1582 if (!f.file) 1584 if (!f.file)
1583 return -ENOENT; 1585 return -ENOENT;
1586 if (f.file->f_op != &ucma_fops) {
1587 ret = -EINVAL;
1588 goto file_put;
1589 }
1584 1590
1585 /* Validate current fd and prevent destruction of id. */ 1591 /* Validate current fd and prevent destruction of id. */
1586 ctx = ucma_get_ctx(f.file->private_data, cmd.id); 1592 ctx = ucma_get_ctx(f.file->private_data, cmd.id);
@@ -1753,6 +1759,8 @@ static int ucma_close(struct inode *inode, struct file *filp)
1753 mutex_lock(&mut); 1759 mutex_lock(&mut);
1754 if (!ctx->closing) { 1760 if (!ctx->closing) {
1755 mutex_unlock(&mut); 1761 mutex_unlock(&mut);
1762 ucma_put_ctx(ctx);
1763 wait_for_completion(&ctx->comp);
1756 /* rdma_destroy_id ensures that no event handlers are 1764 /* rdma_destroy_id ensures that no event handlers are
1757 * inflight for that id before releasing it. 1765 * inflight for that id before releasing it.
1758 */ 1766 */
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index a21d5214afc3..e012ca80f9d1 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -2027,33 +2027,55 @@ static int modify_qp(struct ib_uverbs_file *file,
2027 2027
2028 if ((cmd->base.attr_mask & IB_QP_CUR_STATE && 2028 if ((cmd->base.attr_mask & IB_QP_CUR_STATE &&
2029 cmd->base.cur_qp_state > IB_QPS_ERR) || 2029 cmd->base.cur_qp_state > IB_QPS_ERR) ||
2030 cmd->base.qp_state > IB_QPS_ERR) { 2030 (cmd->base.attr_mask & IB_QP_STATE &&
2031 cmd->base.qp_state > IB_QPS_ERR)) {
2031 ret = -EINVAL; 2032 ret = -EINVAL;
2032 goto release_qp; 2033 goto release_qp;
2033 } 2034 }
2034 2035
2035 attr->qp_state = cmd->base.qp_state; 2036 if (cmd->base.attr_mask & IB_QP_STATE)
2036 attr->cur_qp_state = cmd->base.cur_qp_state; 2037 attr->qp_state = cmd->base.qp_state;
2037 attr->path_mtu = cmd->base.path_mtu; 2038 if (cmd->base.attr_mask & IB_QP_CUR_STATE)
2038 attr->path_mig_state = cmd->base.path_mig_state; 2039 attr->cur_qp_state = cmd->base.cur_qp_state;
2039 attr->qkey = cmd->base.qkey; 2040 if (cmd->base.attr_mask & IB_QP_PATH_MTU)
2040 attr->rq_psn = cmd->base.rq_psn; 2041 attr->path_mtu = cmd->base.path_mtu;
2041 attr->sq_psn = cmd->base.sq_psn; 2042 if (cmd->base.attr_mask & IB_QP_PATH_MIG_STATE)
2042 attr->dest_qp_num = cmd->base.dest_qp_num; 2043 attr->path_mig_state = cmd->base.path_mig_state;
2043 attr->qp_access_flags = cmd->base.qp_access_flags; 2044 if (cmd->base.attr_mask & IB_QP_QKEY)
2044 attr->pkey_index = cmd->base.pkey_index; 2045 attr->qkey = cmd->base.qkey;
2045 attr->alt_pkey_index = cmd->base.alt_pkey_index; 2046 if (cmd->base.attr_mask & IB_QP_RQ_PSN)
2046 attr->en_sqd_async_notify = cmd->base.en_sqd_async_notify; 2047 attr->rq_psn = cmd->base.rq_psn;
2047 attr->max_rd_atomic = cmd->base.max_rd_atomic; 2048 if (cmd->base.attr_mask & IB_QP_SQ_PSN)
2048 attr->max_dest_rd_atomic = cmd->base.max_dest_rd_atomic; 2049 attr->sq_psn = cmd->base.sq_psn;
2049 attr->min_rnr_timer = cmd->base.min_rnr_timer; 2050 if (cmd->base.attr_mask & IB_QP_DEST_QPN)
2050 attr->port_num = cmd->base.port_num; 2051 attr->dest_qp_num = cmd->base.dest_qp_num;
2051 attr->timeout = cmd->base.timeout; 2052 if (cmd->base.attr_mask & IB_QP_ACCESS_FLAGS)
2052 attr->retry_cnt = cmd->base.retry_cnt; 2053 attr->qp_access_flags = cmd->base.qp_access_flags;
2053 attr->rnr_retry = cmd->base.rnr_retry; 2054 if (cmd->base.attr_mask & IB_QP_PKEY_INDEX)
2054 attr->alt_port_num = cmd->base.alt_port_num; 2055 attr->pkey_index = cmd->base.pkey_index;
2055 attr->alt_timeout = cmd->base.alt_timeout; 2056 if (cmd->base.attr_mask & IB_QP_EN_SQD_ASYNC_NOTIFY)
2056 attr->rate_limit = cmd->rate_limit; 2057 attr->en_sqd_async_notify = cmd->base.en_sqd_async_notify;
2058 if (cmd->base.attr_mask & IB_QP_MAX_QP_RD_ATOMIC)
2059 attr->max_rd_atomic = cmd->base.max_rd_atomic;
2060 if (cmd->base.attr_mask & IB_QP_MAX_DEST_RD_ATOMIC)
2061 attr->max_dest_rd_atomic = cmd->base.max_dest_rd_atomic;
2062 if (cmd->base.attr_mask & IB_QP_MIN_RNR_TIMER)
2063 attr->min_rnr_timer = cmd->base.min_rnr_timer;
2064 if (cmd->base.attr_mask & IB_QP_PORT)
2065 attr->port_num = cmd->base.port_num;
2066 if (cmd->base.attr_mask & IB_QP_TIMEOUT)
2067 attr->timeout = cmd->base.timeout;
2068 if (cmd->base.attr_mask & IB_QP_RETRY_CNT)
2069 attr->retry_cnt = cmd->base.retry_cnt;
2070 if (cmd->base.attr_mask & IB_QP_RNR_RETRY)
2071 attr->rnr_retry = cmd->base.rnr_retry;
2072 if (cmd->base.attr_mask & IB_QP_ALT_PATH) {
2073 attr->alt_port_num = cmd->base.alt_port_num;
2074 attr->alt_timeout = cmd->base.alt_timeout;
2075 attr->alt_pkey_index = cmd->base.alt_pkey_index;
2076 }
2077 if (cmd->base.attr_mask & IB_QP_RATE_LIMIT)
2078 attr->rate_limit = cmd->rate_limit;
2057 2079
2058 if (cmd->base.attr_mask & IB_QP_AV) 2080 if (cmd->base.attr_mask & IB_QP_AV)
2059 copy_ah_attr_from_uverbs(qp->device, &attr->ah_attr, 2081 copy_ah_attr_from_uverbs(qp->device, &attr->ah_attr,
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c
index 823beca448e1..50152c1b1004 100644
--- a/drivers/infiniband/core/uverbs_main.c
+++ b/drivers/infiniband/core/uverbs_main.c
@@ -440,6 +440,7 @@ static int ib_uverbs_comp_event_close(struct inode *inode, struct file *filp)
440 list_del(&entry->obj_list); 440 list_del(&entry->obj_list);
441 kfree(entry); 441 kfree(entry);
442 } 442 }
443 file->ev_queue.is_closed = 1;
443 spin_unlock_irq(&file->ev_queue.lock); 444 spin_unlock_irq(&file->ev_queue.lock);
444 445
445 uverbs_close_fd(filp); 446 uverbs_close_fd(filp);
@@ -1050,7 +1051,7 @@ static void ib_uverbs_add_one(struct ib_device *device)
1050 uverbs_dev->num_comp_vectors = device->num_comp_vectors; 1051 uverbs_dev->num_comp_vectors = device->num_comp_vectors;
1051 1052
1052 if (ib_uverbs_create_uapi(device, uverbs_dev)) 1053 if (ib_uverbs_create_uapi(device, uverbs_dev))
1053 goto err; 1054 goto err_uapi;
1054 1055
1055 cdev_init(&uverbs_dev->cdev, NULL); 1056 cdev_init(&uverbs_dev->cdev, NULL);
1056 uverbs_dev->cdev.owner = THIS_MODULE; 1057 uverbs_dev->cdev.owner = THIS_MODULE;
@@ -1077,11 +1078,10 @@ static void ib_uverbs_add_one(struct ib_device *device)
1077 1078
1078err_class: 1079err_class:
1079 device_destroy(uverbs_class, uverbs_dev->cdev.dev); 1080 device_destroy(uverbs_class, uverbs_dev->cdev.dev);
1080
1081err_cdev: 1081err_cdev:
1082 cdev_del(&uverbs_dev->cdev); 1082 cdev_del(&uverbs_dev->cdev);
1083err_uapi:
1083 clear_bit(devnum, dev_map); 1084 clear_bit(devnum, dev_map);
1084
1085err: 1085err:
1086 if (atomic_dec_and_test(&uverbs_dev->refcount)) 1086 if (atomic_dec_and_test(&uverbs_dev->refcount))
1087 ib_uverbs_comp_dev(uverbs_dev); 1087 ib_uverbs_comp_dev(uverbs_dev);
diff --git a/drivers/infiniband/core/uverbs_uapi.c b/drivers/infiniband/core/uverbs_uapi.c
index 73ea6f0db88f..be854628a7c6 100644
--- a/drivers/infiniband/core/uverbs_uapi.c
+++ b/drivers/infiniband/core/uverbs_uapi.c
@@ -248,6 +248,7 @@ void uverbs_destroy_api(struct uverbs_api *uapi)
248 kfree(rcu_dereference_protected(*slot, true)); 248 kfree(rcu_dereference_protected(*slot, true));
249 radix_tree_iter_delete(&uapi->radix, &iter, slot); 249 radix_tree_iter_delete(&uapi->radix, &iter, slot);
250 } 250 }
251 kfree(uapi);
251} 252}
252 253
253struct uverbs_api *uverbs_alloc_api( 254struct uverbs_api *uverbs_alloc_api(
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index bbfb86eb2d24..bc2b9e038439 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -833,6 +833,8 @@ int bnxt_re_destroy_qp(struct ib_qp *ib_qp)
833 "Failed to destroy Shadow QP"); 833 "Failed to destroy Shadow QP");
834 return rc; 834 return rc;
835 } 835 }
836 bnxt_qplib_free_qp_res(&rdev->qplib_res,
837 &rdev->qp1_sqp->qplib_qp);
836 mutex_lock(&rdev->qp_lock); 838 mutex_lock(&rdev->qp_lock);
837 list_del(&rdev->qp1_sqp->list); 839 list_del(&rdev->qp1_sqp->list);
838 atomic_dec(&rdev->qp_count); 840 atomic_dec(&rdev->qp_count);
diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 20b9f31052bf..85cd1a3593d6 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -78,7 +78,7 @@ static struct list_head bnxt_re_dev_list = LIST_HEAD_INIT(bnxt_re_dev_list);
78/* Mutex to protect the list of bnxt_re devices added */ 78/* Mutex to protect the list of bnxt_re devices added */
79static DEFINE_MUTEX(bnxt_re_dev_lock); 79static DEFINE_MUTEX(bnxt_re_dev_lock);
80static struct workqueue_struct *bnxt_re_wq; 80static struct workqueue_struct *bnxt_re_wq;
81static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev, bool lock_wait); 81static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev);
82 82
83/* SR-IOV helper functions */ 83/* SR-IOV helper functions */
84 84
@@ -182,7 +182,7 @@ static void bnxt_re_shutdown(void *p)
182 if (!rdev) 182 if (!rdev)
183 return; 183 return;
184 184
185 bnxt_re_ib_unreg(rdev, false); 185 bnxt_re_ib_unreg(rdev);
186} 186}
187 187
188static void bnxt_re_stop_irq(void *handle) 188static void bnxt_re_stop_irq(void *handle)
@@ -251,7 +251,7 @@ static struct bnxt_ulp_ops bnxt_re_ulp_ops = {
251/* Driver registration routines used to let the networking driver (bnxt_en) 251/* Driver registration routines used to let the networking driver (bnxt_en)
252 * to know that the RoCE driver is now installed 252 * to know that the RoCE driver is now installed
253 */ 253 */
254static int bnxt_re_unregister_netdev(struct bnxt_re_dev *rdev, bool lock_wait) 254static int bnxt_re_unregister_netdev(struct bnxt_re_dev *rdev)
255{ 255{
256 struct bnxt_en_dev *en_dev; 256 struct bnxt_en_dev *en_dev;
257 int rc; 257 int rc;
@@ -260,14 +260,9 @@ static int bnxt_re_unregister_netdev(struct bnxt_re_dev *rdev, bool lock_wait)
260 return -EINVAL; 260 return -EINVAL;
261 261
262 en_dev = rdev->en_dev; 262 en_dev = rdev->en_dev;
263 /* Acquire rtnl lock if it is not invokded from netdev event */
264 if (lock_wait)
265 rtnl_lock();
266 263
267 rc = en_dev->en_ops->bnxt_unregister_device(rdev->en_dev, 264 rc = en_dev->en_ops->bnxt_unregister_device(rdev->en_dev,
268 BNXT_ROCE_ULP); 265 BNXT_ROCE_ULP);
269 if (lock_wait)
270 rtnl_unlock();
271 return rc; 266 return rc;
272} 267}
273 268
@@ -281,14 +276,12 @@ static int bnxt_re_register_netdev(struct bnxt_re_dev *rdev)
281 276
282 en_dev = rdev->en_dev; 277 en_dev = rdev->en_dev;
283 278
284 rtnl_lock();
285 rc = en_dev->en_ops->bnxt_register_device(en_dev, BNXT_ROCE_ULP, 279 rc = en_dev->en_ops->bnxt_register_device(en_dev, BNXT_ROCE_ULP,
286 &bnxt_re_ulp_ops, rdev); 280 &bnxt_re_ulp_ops, rdev);
287 rtnl_unlock();
288 return rc; 281 return rc;
289} 282}
290 283
291static int bnxt_re_free_msix(struct bnxt_re_dev *rdev, bool lock_wait) 284static int bnxt_re_free_msix(struct bnxt_re_dev *rdev)
292{ 285{
293 struct bnxt_en_dev *en_dev; 286 struct bnxt_en_dev *en_dev;
294 int rc; 287 int rc;
@@ -298,13 +291,9 @@ static int bnxt_re_free_msix(struct bnxt_re_dev *rdev, bool lock_wait)
298 291
299 en_dev = rdev->en_dev; 292 en_dev = rdev->en_dev;
300 293
301 if (lock_wait)
302 rtnl_lock();
303 294
304 rc = en_dev->en_ops->bnxt_free_msix(rdev->en_dev, BNXT_ROCE_ULP); 295 rc = en_dev->en_ops->bnxt_free_msix(rdev->en_dev, BNXT_ROCE_ULP);
305 296
306 if (lock_wait)
307 rtnl_unlock();
308 return rc; 297 return rc;
309} 298}
310 299
@@ -320,7 +309,6 @@ static int bnxt_re_request_msix(struct bnxt_re_dev *rdev)
320 309
321 num_msix_want = min_t(u32, BNXT_RE_MAX_MSIX, num_online_cpus()); 310 num_msix_want = min_t(u32, BNXT_RE_MAX_MSIX, num_online_cpus());
322 311
323 rtnl_lock();
324 num_msix_got = en_dev->en_ops->bnxt_request_msix(en_dev, BNXT_ROCE_ULP, 312 num_msix_got = en_dev->en_ops->bnxt_request_msix(en_dev, BNXT_ROCE_ULP,
325 rdev->msix_entries, 313 rdev->msix_entries,
326 num_msix_want); 314 num_msix_want);
@@ -335,7 +323,6 @@ static int bnxt_re_request_msix(struct bnxt_re_dev *rdev)
335 } 323 }
336 rdev->num_msix = num_msix_got; 324 rdev->num_msix = num_msix_got;
337done: 325done:
338 rtnl_unlock();
339 return rc; 326 return rc;
340} 327}
341 328
@@ -358,24 +345,18 @@ static void bnxt_re_fill_fw_msg(struct bnxt_fw_msg *fw_msg, void *msg,
358 fw_msg->timeout = timeout; 345 fw_msg->timeout = timeout;
359} 346}
360 347
361static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id, 348static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id)
362 bool lock_wait)
363{ 349{
364 struct bnxt_en_dev *en_dev = rdev->en_dev; 350 struct bnxt_en_dev *en_dev = rdev->en_dev;
365 struct hwrm_ring_free_input req = {0}; 351 struct hwrm_ring_free_input req = {0};
366 struct hwrm_ring_free_output resp; 352 struct hwrm_ring_free_output resp;
367 struct bnxt_fw_msg fw_msg; 353 struct bnxt_fw_msg fw_msg;
368 bool do_unlock = false;
369 int rc = -EINVAL; 354 int rc = -EINVAL;
370 355
371 if (!en_dev) 356 if (!en_dev)
372 return rc; 357 return rc;
373 358
374 memset(&fw_msg, 0, sizeof(fw_msg)); 359 memset(&fw_msg, 0, sizeof(fw_msg));
375 if (lock_wait) {
376 rtnl_lock();
377 do_unlock = true;
378 }
379 360
380 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_FREE, -1, -1); 361 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_FREE, -1, -1);
381 req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL; 362 req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
@@ -386,8 +367,6 @@ static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id,
386 if (rc) 367 if (rc)
387 dev_err(rdev_to_dev(rdev), 368 dev_err(rdev_to_dev(rdev),
388 "Failed to free HW ring:%d :%#x", req.ring_id, rc); 369 "Failed to free HW ring:%d :%#x", req.ring_id, rc);
389 if (do_unlock)
390 rtnl_unlock();
391 return rc; 370 return rc;
392} 371}
393 372
@@ -405,7 +384,6 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, dma_addr_t *dma_arr,
405 return rc; 384 return rc;
406 385
407 memset(&fw_msg, 0, sizeof(fw_msg)); 386 memset(&fw_msg, 0, sizeof(fw_msg));
408 rtnl_lock();
409 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_ALLOC, -1, -1); 387 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_ALLOC, -1, -1);
410 req.enables = 0; 388 req.enables = 0;
411 req.page_tbl_addr = cpu_to_le64(dma_arr[0]); 389 req.page_tbl_addr = cpu_to_le64(dma_arr[0]);
@@ -426,27 +404,21 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, dma_addr_t *dma_arr,
426 if (!rc) 404 if (!rc)
427 *fw_ring_id = le16_to_cpu(resp.ring_id); 405 *fw_ring_id = le16_to_cpu(resp.ring_id);
428 406
429 rtnl_unlock();
430 return rc; 407 return rc;
431} 408}
432 409
433static int bnxt_re_net_stats_ctx_free(struct bnxt_re_dev *rdev, 410static int bnxt_re_net_stats_ctx_free(struct bnxt_re_dev *rdev,
434 u32 fw_stats_ctx_id, bool lock_wait) 411 u32 fw_stats_ctx_id)
435{ 412{
436 struct bnxt_en_dev *en_dev = rdev->en_dev; 413 struct bnxt_en_dev *en_dev = rdev->en_dev;
437 struct hwrm_stat_ctx_free_input req = {0}; 414 struct hwrm_stat_ctx_free_input req = {0};
438 struct bnxt_fw_msg fw_msg; 415 struct bnxt_fw_msg fw_msg;
439 bool do_unlock = false;
440 int rc = -EINVAL; 416 int rc = -EINVAL;
441 417
442 if (!en_dev) 418 if (!en_dev)
443 return rc; 419 return rc;
444 420
445 memset(&fw_msg, 0, sizeof(fw_msg)); 421 memset(&fw_msg, 0, sizeof(fw_msg));
446 if (lock_wait) {
447 rtnl_lock();
448 do_unlock = true;
449 }
450 422
451 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_STAT_CTX_FREE, -1, -1); 423 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_STAT_CTX_FREE, -1, -1);
452 req.stat_ctx_id = cpu_to_le32(fw_stats_ctx_id); 424 req.stat_ctx_id = cpu_to_le32(fw_stats_ctx_id);
@@ -457,8 +429,6 @@ static int bnxt_re_net_stats_ctx_free(struct bnxt_re_dev *rdev,
457 dev_err(rdev_to_dev(rdev), 429 dev_err(rdev_to_dev(rdev),
458 "Failed to free HW stats context %#x", rc); 430 "Failed to free HW stats context %#x", rc);
459 431
460 if (do_unlock)
461 rtnl_unlock();
462 return rc; 432 return rc;
463} 433}
464 434
@@ -478,7 +448,6 @@ static int bnxt_re_net_stats_ctx_alloc(struct bnxt_re_dev *rdev,
478 return rc; 448 return rc;
479 449
480 memset(&fw_msg, 0, sizeof(fw_msg)); 450 memset(&fw_msg, 0, sizeof(fw_msg));
481 rtnl_lock();
482 451
483 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_STAT_CTX_ALLOC, -1, -1); 452 bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_STAT_CTX_ALLOC, -1, -1);
484 req.update_period_ms = cpu_to_le32(1000); 453 req.update_period_ms = cpu_to_le32(1000);
@@ -490,7 +459,6 @@ static int bnxt_re_net_stats_ctx_alloc(struct bnxt_re_dev *rdev,
490 if (!rc) 459 if (!rc)
491 *fw_stats_ctx_id = le32_to_cpu(resp.stat_ctx_id); 460 *fw_stats_ctx_id = le32_to_cpu(resp.stat_ctx_id);
492 461
493 rtnl_unlock();
494 return rc; 462 return rc;
495} 463}
496 464
@@ -929,19 +897,19 @@ fail:
929 return rc; 897 return rc;
930} 898}
931 899
932static void bnxt_re_free_nq_res(struct bnxt_re_dev *rdev, bool lock_wait) 900static void bnxt_re_free_nq_res(struct bnxt_re_dev *rdev)
933{ 901{
934 int i; 902 int i;
935 903
936 for (i = 0; i < rdev->num_msix - 1; i++) { 904 for (i = 0; i < rdev->num_msix - 1; i++) {
937 bnxt_re_net_ring_free(rdev, rdev->nq[i].ring_id, lock_wait); 905 bnxt_re_net_ring_free(rdev, rdev->nq[i].ring_id);
938 bnxt_qplib_free_nq(&rdev->nq[i]); 906 bnxt_qplib_free_nq(&rdev->nq[i]);
939 } 907 }
940} 908}
941 909
942static void bnxt_re_free_res(struct bnxt_re_dev *rdev, bool lock_wait) 910static void bnxt_re_free_res(struct bnxt_re_dev *rdev)
943{ 911{
944 bnxt_re_free_nq_res(rdev, lock_wait); 912 bnxt_re_free_nq_res(rdev);
945 913
946 if (rdev->qplib_res.dpi_tbl.max) { 914 if (rdev->qplib_res.dpi_tbl.max) {
947 bnxt_qplib_dealloc_dpi(&rdev->qplib_res, 915 bnxt_qplib_dealloc_dpi(&rdev->qplib_res,
@@ -1219,7 +1187,7 @@ static int bnxt_re_setup_qos(struct bnxt_re_dev *rdev)
1219 return 0; 1187 return 0;
1220} 1188}
1221 1189
1222static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev, bool lock_wait) 1190static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev)
1223{ 1191{
1224 int i, rc; 1192 int i, rc;
1225 1193
@@ -1234,28 +1202,27 @@ static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev, bool lock_wait)
1234 cancel_delayed_work(&rdev->worker); 1202 cancel_delayed_work(&rdev->worker);
1235 1203
1236 bnxt_re_cleanup_res(rdev); 1204 bnxt_re_cleanup_res(rdev);
1237 bnxt_re_free_res(rdev, lock_wait); 1205 bnxt_re_free_res(rdev);
1238 1206
1239 if (test_and_clear_bit(BNXT_RE_FLAG_RCFW_CHANNEL_EN, &rdev->flags)) { 1207 if (test_and_clear_bit(BNXT_RE_FLAG_RCFW_CHANNEL_EN, &rdev->flags)) {
1240 rc = bnxt_qplib_deinit_rcfw(&rdev->rcfw); 1208 rc = bnxt_qplib_deinit_rcfw(&rdev->rcfw);
1241 if (rc) 1209 if (rc)
1242 dev_warn(rdev_to_dev(rdev), 1210 dev_warn(rdev_to_dev(rdev),
1243 "Failed to deinitialize RCFW: %#x", rc); 1211 "Failed to deinitialize RCFW: %#x", rc);
1244 bnxt_re_net_stats_ctx_free(rdev, rdev->qplib_ctx.stats.fw_id, 1212 bnxt_re_net_stats_ctx_free(rdev, rdev->qplib_ctx.stats.fw_id);
1245 lock_wait);
1246 bnxt_qplib_free_ctx(rdev->en_dev->pdev, &rdev->qplib_ctx); 1213 bnxt_qplib_free_ctx(rdev->en_dev->pdev, &rdev->qplib_ctx);
1247 bnxt_qplib_disable_rcfw_channel(&rdev->rcfw); 1214 bnxt_qplib_disable_rcfw_channel(&rdev->rcfw);
1248 bnxt_re_net_ring_free(rdev, rdev->rcfw.creq_ring_id, lock_wait); 1215 bnxt_re_net_ring_free(rdev, rdev->rcfw.creq_ring_id);
1249 bnxt_qplib_free_rcfw_channel(&rdev->rcfw); 1216 bnxt_qplib_free_rcfw_channel(&rdev->rcfw);
1250 } 1217 }
1251 if (test_and_clear_bit(BNXT_RE_FLAG_GOT_MSIX, &rdev->flags)) { 1218 if (test_and_clear_bit(BNXT_RE_FLAG_GOT_MSIX, &rdev->flags)) {
1252 rc = bnxt_re_free_msix(rdev, lock_wait); 1219 rc = bnxt_re_free_msix(rdev);
1253 if (rc) 1220 if (rc)
1254 dev_warn(rdev_to_dev(rdev), 1221 dev_warn(rdev_to_dev(rdev),
1255 "Failed to free MSI-X vectors: %#x", rc); 1222 "Failed to free MSI-X vectors: %#x", rc);
1256 } 1223 }
1257 if (test_and_clear_bit(BNXT_RE_FLAG_NETDEV_REGISTERED, &rdev->flags)) { 1224 if (test_and_clear_bit(BNXT_RE_FLAG_NETDEV_REGISTERED, &rdev->flags)) {
1258 rc = bnxt_re_unregister_netdev(rdev, lock_wait); 1225 rc = bnxt_re_unregister_netdev(rdev);
1259 if (rc) 1226 if (rc)
1260 dev_warn(rdev_to_dev(rdev), 1227 dev_warn(rdev_to_dev(rdev),
1261 "Failed to unregister with netdev: %#x", rc); 1228 "Failed to unregister with netdev: %#x", rc);
@@ -1276,6 +1243,12 @@ static int bnxt_re_ib_reg(struct bnxt_re_dev *rdev)
1276{ 1243{
1277 int i, j, rc; 1244 int i, j, rc;
1278 1245
1246 bool locked;
1247
1248 /* Acquire rtnl lock through out this function */
1249 rtnl_lock();
1250 locked = true;
1251
1279 /* Registered a new RoCE device instance to netdev */ 1252 /* Registered a new RoCE device instance to netdev */
1280 rc = bnxt_re_register_netdev(rdev); 1253 rc = bnxt_re_register_netdev(rdev);
1281 if (rc) { 1254 if (rc) {
@@ -1374,12 +1347,16 @@ static int bnxt_re_ib_reg(struct bnxt_re_dev *rdev)
1374 schedule_delayed_work(&rdev->worker, msecs_to_jiffies(30000)); 1347 schedule_delayed_work(&rdev->worker, msecs_to_jiffies(30000));
1375 } 1348 }
1376 1349
1350 rtnl_unlock();
1351 locked = false;
1352
1377 /* Register ib dev */ 1353 /* Register ib dev */
1378 rc = bnxt_re_register_ib(rdev); 1354 rc = bnxt_re_register_ib(rdev);
1379 if (rc) { 1355 if (rc) {
1380 pr_err("Failed to register with IB: %#x\n", rc); 1356 pr_err("Failed to register with IB: %#x\n", rc);
1381 goto fail; 1357 goto fail;
1382 } 1358 }
1359 set_bit(BNXT_RE_FLAG_IBDEV_REGISTERED, &rdev->flags);
1383 dev_info(rdev_to_dev(rdev), "Device registered successfully"); 1360 dev_info(rdev_to_dev(rdev), "Device registered successfully");
1384 for (i = 0; i < ARRAY_SIZE(bnxt_re_attributes); i++) { 1361 for (i = 0; i < ARRAY_SIZE(bnxt_re_attributes); i++) {
1385 rc = device_create_file(&rdev->ibdev.dev, 1362 rc = device_create_file(&rdev->ibdev.dev,
@@ -1395,7 +1372,6 @@ static int bnxt_re_ib_reg(struct bnxt_re_dev *rdev)
1395 goto fail; 1372 goto fail;
1396 } 1373 }
1397 } 1374 }
1398 set_bit(BNXT_RE_FLAG_IBDEV_REGISTERED, &rdev->flags);
1399 ib_get_eth_speed(&rdev->ibdev, 1, &rdev->active_speed, 1375 ib_get_eth_speed(&rdev->ibdev, 1, &rdev->active_speed,
1400 &rdev->active_width); 1376 &rdev->active_width);
1401 set_bit(BNXT_RE_FLAG_ISSUE_ROCE_STATS, &rdev->flags); 1377 set_bit(BNXT_RE_FLAG_ISSUE_ROCE_STATS, &rdev->flags);
@@ -1404,17 +1380,21 @@ static int bnxt_re_ib_reg(struct bnxt_re_dev *rdev)
1404 1380
1405 return 0; 1381 return 0;
1406free_sctx: 1382free_sctx:
1407 bnxt_re_net_stats_ctx_free(rdev, rdev->qplib_ctx.stats.fw_id, true); 1383 bnxt_re_net_stats_ctx_free(rdev, rdev->qplib_ctx.stats.fw_id);
1408free_ctx: 1384free_ctx:
1409 bnxt_qplib_free_ctx(rdev->en_dev->pdev, &rdev->qplib_ctx); 1385 bnxt_qplib_free_ctx(rdev->en_dev->pdev, &rdev->qplib_ctx);
1410disable_rcfw: 1386disable_rcfw:
1411 bnxt_qplib_disable_rcfw_channel(&rdev->rcfw); 1387 bnxt_qplib_disable_rcfw_channel(&rdev->rcfw);
1412free_ring: 1388free_ring:
1413 bnxt_re_net_ring_free(rdev, rdev->rcfw.creq_ring_id, true); 1389 bnxt_re_net_ring_free(rdev, rdev->rcfw.creq_ring_id);
1414free_rcfw: 1390free_rcfw:
1415 bnxt_qplib_free_rcfw_channel(&rdev->rcfw); 1391 bnxt_qplib_free_rcfw_channel(&rdev->rcfw);
1416fail: 1392fail:
1417 bnxt_re_ib_unreg(rdev, true); 1393 if (!locked)
1394 rtnl_lock();
1395 bnxt_re_ib_unreg(rdev);
1396 rtnl_unlock();
1397
1418 return rc; 1398 return rc;
1419} 1399}
1420 1400
@@ -1567,7 +1547,7 @@ static int bnxt_re_netdev_event(struct notifier_block *notifier,
1567 */ 1547 */
1568 if (atomic_read(&rdev->sched_count) > 0) 1548 if (atomic_read(&rdev->sched_count) > 0)
1569 goto exit; 1549 goto exit;
1570 bnxt_re_ib_unreg(rdev, false); 1550 bnxt_re_ib_unreg(rdev);
1571 bnxt_re_remove_one(rdev); 1551 bnxt_re_remove_one(rdev);
1572 bnxt_re_dev_unreg(rdev); 1552 bnxt_re_dev_unreg(rdev);
1573 break; 1553 break;
@@ -1646,7 +1626,10 @@ static void __exit bnxt_re_mod_exit(void)
1646 */ 1626 */
1647 flush_workqueue(bnxt_re_wq); 1627 flush_workqueue(bnxt_re_wq);
1648 bnxt_re_dev_stop(rdev); 1628 bnxt_re_dev_stop(rdev);
1649 bnxt_re_ib_unreg(rdev, true); 1629 /* Acquire the rtnl_lock as the L2 resources are freed here */
1630 rtnl_lock();
1631 bnxt_re_ib_unreg(rdev);
1632 rtnl_unlock();
1650 bnxt_re_remove_one(rdev); 1633 bnxt_re_remove_one(rdev);
1651 bnxt_re_dev_unreg(rdev); 1634 bnxt_re_dev_unreg(rdev);
1652 } 1635 }
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index e426b990c1dd..6ad0d46ab879 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -196,7 +196,7 @@ static int bnxt_qplib_alloc_qp_hdr_buf(struct bnxt_qplib_res *res,
196 struct bnxt_qplib_qp *qp) 196 struct bnxt_qplib_qp *qp)
197{ 197{
198 struct bnxt_qplib_q *rq = &qp->rq; 198 struct bnxt_qplib_q *rq = &qp->rq;
199 struct bnxt_qplib_q *sq = &qp->rq; 199 struct bnxt_qplib_q *sq = &qp->sq;
200 int rc = 0; 200 int rc = 0;
201 201
202 if (qp->sq_hdr_buf_size && sq->hwq.max_elements) { 202 if (qp->sq_hdr_buf_size && sq->hwq.max_elements) {
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index b3203afa3b1d..347fe18b1a41 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -1685,6 +1685,12 @@ static void flush_qp(struct c4iw_qp *qhp)
1685 schp = to_c4iw_cq(qhp->ibqp.send_cq); 1685 schp = to_c4iw_cq(qhp->ibqp.send_cq);
1686 1686
1687 if (qhp->ibqp.uobject) { 1687 if (qhp->ibqp.uobject) {
1688
1689 /* for user qps, qhp->wq.flushed is protected by qhp->mutex */
1690 if (qhp->wq.flushed)
1691 return;
1692
1693 qhp->wq.flushed = 1;
1688 t4_set_wq_in_error(&qhp->wq, 0); 1694 t4_set_wq_in_error(&qhp->wq, 0);
1689 t4_set_cq_in_error(&rchp->cq); 1695 t4_set_cq_in_error(&rchp->cq);
1690 spin_lock_irqsave(&rchp->comp_handler_lock, flag); 1696 spin_lock_irqsave(&rchp->comp_handler_lock, flag);
diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c
index 2c19bf772451..e1668bcc2d13 100644
--- a/drivers/infiniband/hw/hfi1/chip.c
+++ b/drivers/infiniband/hw/hfi1/chip.c
@@ -6733,6 +6733,7 @@ void start_freeze_handling(struct hfi1_pportdata *ppd, int flags)
6733 struct hfi1_devdata *dd = ppd->dd; 6733 struct hfi1_devdata *dd = ppd->dd;
6734 struct send_context *sc; 6734 struct send_context *sc;
6735 int i; 6735 int i;
6736 int sc_flags;
6736 6737
6737 if (flags & FREEZE_SELF) 6738 if (flags & FREEZE_SELF)
6738 write_csr(dd, CCE_CTRL, CCE_CTRL_SPC_FREEZE_SMASK); 6739 write_csr(dd, CCE_CTRL, CCE_CTRL_SPC_FREEZE_SMASK);
@@ -6743,11 +6744,13 @@ void start_freeze_handling(struct hfi1_pportdata *ppd, int flags)
6743 /* notify all SDMA engines that they are going into a freeze */ 6744 /* notify all SDMA engines that they are going into a freeze */
6744 sdma_freeze_notify(dd, !!(flags & FREEZE_LINK_DOWN)); 6745 sdma_freeze_notify(dd, !!(flags & FREEZE_LINK_DOWN));
6745 6746
6747 sc_flags = SCF_FROZEN | SCF_HALTED | (flags & FREEZE_LINK_DOWN ?
6748 SCF_LINK_DOWN : 0);
6746 /* do halt pre-handling on all enabled send contexts */ 6749 /* do halt pre-handling on all enabled send contexts */
6747 for (i = 0; i < dd->num_send_contexts; i++) { 6750 for (i = 0; i < dd->num_send_contexts; i++) {
6748 sc = dd->send_contexts[i].sc; 6751 sc = dd->send_contexts[i].sc;
6749 if (sc && (sc->flags & SCF_ENABLED)) 6752 if (sc && (sc->flags & SCF_ENABLED))
6750 sc_stop(sc, SCF_FROZEN | SCF_HALTED); 6753 sc_stop(sc, sc_flags);
6751 } 6754 }
6752 6755
6753 /* Send context are frozen. Notify user space */ 6756 /* Send context are frozen. Notify user space */
@@ -10674,6 +10677,7 @@ int set_link_state(struct hfi1_pportdata *ppd, u32 state)
10674 add_rcvctrl(dd, RCV_CTRL_RCV_PORT_ENABLE_SMASK); 10677 add_rcvctrl(dd, RCV_CTRL_RCV_PORT_ENABLE_SMASK);
10675 10678
10676 handle_linkup_change(dd, 1); 10679 handle_linkup_change(dd, 1);
10680 pio_kernel_linkup(dd);
10677 10681
10678 /* 10682 /*
10679 * After link up, a new link width will have been set. 10683 * After link up, a new link width will have been set.
diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
index eec83757d55f..6c967dde58e7 100644
--- a/drivers/infiniband/hw/hfi1/pcie.c
+++ b/drivers/infiniband/hw/hfi1/pcie.c
@@ -893,14 +893,11 @@ static int trigger_sbr(struct hfi1_devdata *dd)
893 } 893 }
894 894
895 /* 895 /*
896 * A secondary bus reset (SBR) issues a hot reset to our device. 896 * This is an end around to do an SBR during probe time. A new API needs
897 * The following routine does a 1s wait after the reset is dropped 897 * to be implemented to have cleaner interface but this fixes the
898 * per PCI Trhfa (recovery time). PCIe 3.0 section 6.6.1 - 898 * current brokenness
899 * Conventional Reset, paragraph 3, line 35 also says that a 1s
900 * delay after a reset is required. Per spec requirements,
901 * the link is either working or not after that point.
902 */ 899 */
903 return pci_reset_bus(dev); 900 return pci_bridge_secondary_bus_reset(dev->bus->self);
904} 901}
905 902
906/* 903/*
diff --git a/drivers/infiniband/hw/hfi1/pio.c b/drivers/infiniband/hw/hfi1/pio.c
index c2c1cba5b23b..752057647f09 100644
--- a/drivers/infiniband/hw/hfi1/pio.c
+++ b/drivers/infiniband/hw/hfi1/pio.c
@@ -86,6 +86,7 @@ void pio_send_control(struct hfi1_devdata *dd, int op)
86 unsigned long flags; 86 unsigned long flags;
87 int write = 1; /* write sendctrl back */ 87 int write = 1; /* write sendctrl back */
88 int flush = 0; /* re-read sendctrl to make sure it is flushed */ 88 int flush = 0; /* re-read sendctrl to make sure it is flushed */
89 int i;
89 90
90 spin_lock_irqsave(&dd->sendctrl_lock, flags); 91 spin_lock_irqsave(&dd->sendctrl_lock, flags);
91 92
@@ -95,9 +96,13 @@ void pio_send_control(struct hfi1_devdata *dd, int op)
95 reg |= SEND_CTRL_SEND_ENABLE_SMASK; 96 reg |= SEND_CTRL_SEND_ENABLE_SMASK;
96 /* Fall through */ 97 /* Fall through */
97 case PSC_DATA_VL_ENABLE: 98 case PSC_DATA_VL_ENABLE:
99 mask = 0;
100 for (i = 0; i < ARRAY_SIZE(dd->vld); i++)
101 if (!dd->vld[i].mtu)
102 mask |= BIT_ULL(i);
98 /* Disallow sending on VLs not enabled */ 103 /* Disallow sending on VLs not enabled */
99 mask = (((~0ull) << num_vls) & SEND_CTRL_UNSUPPORTED_VL_MASK) << 104 mask = (mask & SEND_CTRL_UNSUPPORTED_VL_MASK) <<
100 SEND_CTRL_UNSUPPORTED_VL_SHIFT; 105 SEND_CTRL_UNSUPPORTED_VL_SHIFT;
101 reg = (reg & ~SEND_CTRL_UNSUPPORTED_VL_SMASK) | mask; 106 reg = (reg & ~SEND_CTRL_UNSUPPORTED_VL_SMASK) | mask;
102 break; 107 break;
103 case PSC_GLOBAL_DISABLE: 108 case PSC_GLOBAL_DISABLE:
@@ -921,20 +926,18 @@ void sc_free(struct send_context *sc)
921void sc_disable(struct send_context *sc) 926void sc_disable(struct send_context *sc)
922{ 927{
923 u64 reg; 928 u64 reg;
924 unsigned long flags;
925 struct pio_buf *pbuf; 929 struct pio_buf *pbuf;
926 930
927 if (!sc) 931 if (!sc)
928 return; 932 return;
929 933
930 /* do all steps, even if already disabled */ 934 /* do all steps, even if already disabled */
931 spin_lock_irqsave(&sc->alloc_lock, flags); 935 spin_lock_irq(&sc->alloc_lock);
932 reg = read_kctxt_csr(sc->dd, sc->hw_context, SC(CTRL)); 936 reg = read_kctxt_csr(sc->dd, sc->hw_context, SC(CTRL));
933 reg &= ~SC(CTRL_CTXT_ENABLE_SMASK); 937 reg &= ~SC(CTRL_CTXT_ENABLE_SMASK);
934 sc->flags &= ~SCF_ENABLED; 938 sc->flags &= ~SCF_ENABLED;
935 sc_wait_for_packet_egress(sc, 1); 939 sc_wait_for_packet_egress(sc, 1);
936 write_kctxt_csr(sc->dd, sc->hw_context, SC(CTRL), reg); 940 write_kctxt_csr(sc->dd, sc->hw_context, SC(CTRL), reg);
937 spin_unlock_irqrestore(&sc->alloc_lock, flags);
938 941
939 /* 942 /*
940 * Flush any waiters. Once the context is disabled, 943 * Flush any waiters. Once the context is disabled,
@@ -944,7 +947,7 @@ void sc_disable(struct send_context *sc)
944 * proceed with the flush. 947 * proceed with the flush.
945 */ 948 */
946 udelay(1); 949 udelay(1);
947 spin_lock_irqsave(&sc->release_lock, flags); 950 spin_lock(&sc->release_lock);
948 if (sc->sr) { /* this context has a shadow ring */ 951 if (sc->sr) { /* this context has a shadow ring */
949 while (sc->sr_tail != sc->sr_head) { 952 while (sc->sr_tail != sc->sr_head) {
950 pbuf = &sc->sr[sc->sr_tail].pbuf; 953 pbuf = &sc->sr[sc->sr_tail].pbuf;
@@ -955,7 +958,8 @@ void sc_disable(struct send_context *sc)
955 sc->sr_tail = 0; 958 sc->sr_tail = 0;
956 } 959 }
957 } 960 }
958 spin_unlock_irqrestore(&sc->release_lock, flags); 961 spin_unlock(&sc->release_lock);
962 spin_unlock_irq(&sc->alloc_lock);
959} 963}
960 964
961/* return SendEgressCtxtStatus.PacketOccupancy */ 965/* return SendEgressCtxtStatus.PacketOccupancy */
@@ -1178,11 +1182,39 @@ void pio_kernel_unfreeze(struct hfi1_devdata *dd)
1178 sc = dd->send_contexts[i].sc; 1182 sc = dd->send_contexts[i].sc;
1179 if (!sc || !(sc->flags & SCF_FROZEN) || sc->type == SC_USER) 1183 if (!sc || !(sc->flags & SCF_FROZEN) || sc->type == SC_USER)
1180 continue; 1184 continue;
1185 if (sc->flags & SCF_LINK_DOWN)
1186 continue;
1181 1187
1182 sc_enable(sc); /* will clear the sc frozen flag */ 1188 sc_enable(sc); /* will clear the sc frozen flag */
1183 } 1189 }
1184} 1190}
1185 1191
1192/**
1193 * pio_kernel_linkup() - Re-enable send contexts after linkup event
1194 * @dd: valid devive data
1195 *
1196 * When the link goes down, the freeze path is taken. However, a link down
1197 * event is different from a freeze because if the send context is re-enabled
1198 * whowever is sending data will start sending data again, which will hang
1199 * any QP that is sending data.
1200 *
1201 * The freeze path now looks at the type of event that occurs and takes this
1202 * path for link down event.
1203 */
1204void pio_kernel_linkup(struct hfi1_devdata *dd)
1205{
1206 struct send_context *sc;
1207 int i;
1208
1209 for (i = 0; i < dd->num_send_contexts; i++) {
1210 sc = dd->send_contexts[i].sc;
1211 if (!sc || !(sc->flags & SCF_LINK_DOWN) || sc->type == SC_USER)
1212 continue;
1213
1214 sc_enable(sc); /* will clear the sc link down flag */
1215 }
1216}
1217
1186/* 1218/*
1187 * Wait for the SendPioInitCtxt.PioInitInProgress bit to clear. 1219 * Wait for the SendPioInitCtxt.PioInitInProgress bit to clear.
1188 * Returns: 1220 * Returns:
@@ -1382,11 +1414,10 @@ void sc_stop(struct send_context *sc, int flag)
1382{ 1414{
1383 unsigned long flags; 1415 unsigned long flags;
1384 1416
1385 /* mark the context */
1386 sc->flags |= flag;
1387
1388 /* stop buffer allocations */ 1417 /* stop buffer allocations */
1389 spin_lock_irqsave(&sc->alloc_lock, flags); 1418 spin_lock_irqsave(&sc->alloc_lock, flags);
1419 /* mark the context */
1420 sc->flags |= flag;
1390 sc->flags &= ~SCF_ENABLED; 1421 sc->flags &= ~SCF_ENABLED;
1391 spin_unlock_irqrestore(&sc->alloc_lock, flags); 1422 spin_unlock_irqrestore(&sc->alloc_lock, flags);
1392 wake_up(&sc->halt_wait); 1423 wake_up(&sc->halt_wait);
diff --git a/drivers/infiniband/hw/hfi1/pio.h b/drivers/infiniband/hw/hfi1/pio.h
index 058b08f459ab..aaf372c3e5d6 100644
--- a/drivers/infiniband/hw/hfi1/pio.h
+++ b/drivers/infiniband/hw/hfi1/pio.h
@@ -139,6 +139,7 @@ struct send_context {
139#define SCF_IN_FREE 0x02 139#define SCF_IN_FREE 0x02
140#define SCF_HALTED 0x04 140#define SCF_HALTED 0x04
141#define SCF_FROZEN 0x08 141#define SCF_FROZEN 0x08
142#define SCF_LINK_DOWN 0x10
142 143
143struct send_context_info { 144struct send_context_info {
144 struct send_context *sc; /* allocated working context */ 145 struct send_context *sc; /* allocated working context */
@@ -306,6 +307,7 @@ void set_pio_integrity(struct send_context *sc);
306void pio_reset_all(struct hfi1_devdata *dd); 307void pio_reset_all(struct hfi1_devdata *dd);
307void pio_freeze(struct hfi1_devdata *dd); 308void pio_freeze(struct hfi1_devdata *dd);
308void pio_kernel_unfreeze(struct hfi1_devdata *dd); 309void pio_kernel_unfreeze(struct hfi1_devdata *dd);
310void pio_kernel_linkup(struct hfi1_devdata *dd);
309 311
310/* global PIO send control operations */ 312/* global PIO send control operations */
311#define PSC_GLOBAL_ENABLE 0 313#define PSC_GLOBAL_ENABLE 0
diff --git a/drivers/infiniband/hw/hfi1/user_sdma.c b/drivers/infiniband/hw/hfi1/user_sdma.c
index a3a7b33196d6..5c88706121c1 100644
--- a/drivers/infiniband/hw/hfi1/user_sdma.c
+++ b/drivers/infiniband/hw/hfi1/user_sdma.c
@@ -828,7 +828,7 @@ static int user_sdma_send_pkts(struct user_sdma_request *req, unsigned maxpkts)
828 if (READ_ONCE(iovec->offset) == iovec->iov.iov_len) { 828 if (READ_ONCE(iovec->offset) == iovec->iov.iov_len) {
829 if (++req->iov_idx == req->data_iovs) { 829 if (++req->iov_idx == req->data_iovs) {
830 ret = -EFAULT; 830 ret = -EFAULT;
831 goto free_txreq; 831 goto free_tx;
832 } 832 }
833 iovec = &req->iovs[req->iov_idx]; 833 iovec = &req->iovs[req->iov_idx];
834 WARN_ON(iovec->offset); 834 WARN_ON(iovec->offset);
diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index 13374c727b14..a7c586a5589d 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -1582,6 +1582,7 @@ static int hfi1_check_ah(struct ib_device *ibdev, struct rdma_ah_attr *ah_attr)
1582 struct hfi1_pportdata *ppd; 1582 struct hfi1_pportdata *ppd;
1583 struct hfi1_devdata *dd; 1583 struct hfi1_devdata *dd;
1584 u8 sc5; 1584 u8 sc5;
1585 u8 sl;
1585 1586
1586 if (hfi1_check_mcast(rdma_ah_get_dlid(ah_attr)) && 1587 if (hfi1_check_mcast(rdma_ah_get_dlid(ah_attr)) &&
1587 !(rdma_ah_get_ah_flags(ah_attr) & IB_AH_GRH)) 1588 !(rdma_ah_get_ah_flags(ah_attr) & IB_AH_GRH))
@@ -1590,8 +1591,13 @@ static int hfi1_check_ah(struct ib_device *ibdev, struct rdma_ah_attr *ah_attr)
1590 /* test the mapping for validity */ 1591 /* test the mapping for validity */
1591 ibp = to_iport(ibdev, rdma_ah_get_port_num(ah_attr)); 1592 ibp = to_iport(ibdev, rdma_ah_get_port_num(ah_attr));
1592 ppd = ppd_from_ibp(ibp); 1593 ppd = ppd_from_ibp(ibp);
1593 sc5 = ibp->sl_to_sc[rdma_ah_get_sl(ah_attr)];
1594 dd = dd_from_ppd(ppd); 1594 dd = dd_from_ppd(ppd);
1595
1596 sl = rdma_ah_get_sl(ah_attr);
1597 if (sl >= ARRAY_SIZE(ibp->sl_to_sc))
1598 return -EINVAL;
1599
1600 sc5 = ibp->sl_to_sc[sl];
1595 if (sc_to_vlt(dd, sc5) > num_vls && sc_to_vlt(dd, sc5) != 0xf) 1601 if (sc_to_vlt(dd, sc5) > num_vls && sc_to_vlt(dd, sc5) != 0xf)
1596 return -EINVAL; 1602 return -EINVAL;
1597 return 0; 1603 return 0;
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index ca0f1ee26091..0bbeaaae47e0 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -517,9 +517,11 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
517 props->page_size_cap = dev->dev->caps.page_size_cap; 517 props->page_size_cap = dev->dev->caps.page_size_cap;
518 props->max_qp = dev->dev->quotas.qp; 518 props->max_qp = dev->dev->quotas.qp;
519 props->max_qp_wr = dev->dev->caps.max_wqes - MLX4_IB_SQ_MAX_SPARE; 519 props->max_qp_wr = dev->dev->caps.max_wqes - MLX4_IB_SQ_MAX_SPARE;
520 props->max_send_sge = dev->dev->caps.max_sq_sg; 520 props->max_send_sge =
521 props->max_recv_sge = dev->dev->caps.max_rq_sg; 521 min(dev->dev->caps.max_sq_sg, dev->dev->caps.max_rq_sg);
522 props->max_sge_rd = MLX4_MAX_SGE_RD; 522 props->max_recv_sge =
523 min(dev->dev->caps.max_sq_sg, dev->dev->caps.max_rq_sg);
524 props->max_sge_rd = MLX4_MAX_SGE_RD;
523 props->max_cq = dev->dev->quotas.cq; 525 props->max_cq = dev->dev->quotas.cq;
524 props->max_cqe = dev->dev->caps.max_cqes; 526 props->max_cqe = dev->dev->caps.max_cqes;
525 props->max_mr = dev->dev->quotas.mpt; 527 props->max_mr = dev->dev->quotas.mpt;
diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
index ac116d63e466..f2f11e652dcd 100644
--- a/drivers/infiniband/hw/mlx5/devx.c
+++ b/drivers/infiniband/hw/mlx5/devx.c
@@ -723,6 +723,7 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_OBJ_CREATE)(
723 attrs, MLX5_IB_ATTR_DEVX_OBJ_CREATE_HANDLE); 723 attrs, MLX5_IB_ATTR_DEVX_OBJ_CREATE_HANDLE);
724 struct mlx5_ib_ucontext *c = to_mucontext(uobj->context); 724 struct mlx5_ib_ucontext *c = to_mucontext(uobj->context);
725 struct mlx5_ib_dev *dev = to_mdev(c->ibucontext.device); 725 struct mlx5_ib_dev *dev = to_mdev(c->ibucontext.device);
726 u32 out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)];
726 struct devx_obj *obj; 727 struct devx_obj *obj;
727 int err; 728 int err;
728 729
@@ -754,10 +755,12 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_OBJ_CREATE)(
754 755
755 err = uverbs_copy_to(attrs, MLX5_IB_ATTR_DEVX_OBJ_CREATE_CMD_OUT, cmd_out, cmd_out_len); 756 err = uverbs_copy_to(attrs, MLX5_IB_ATTR_DEVX_OBJ_CREATE_CMD_OUT, cmd_out, cmd_out_len);
756 if (err) 757 if (err)
757 goto obj_free; 758 goto obj_destroy;
758 759
759 return 0; 760 return 0;
760 761
762obj_destroy:
763 mlx5_cmd_exec(obj->mdev, obj->dinbox, obj->dinlen, out, sizeof(out));
761obj_free: 764obj_free:
762 kfree(obj); 765 kfree(obj);
763 return err; 766 return err;
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 9fb1d9cb9401..e22314837645 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -544,6 +544,9 @@ void mlx5_mr_cache_free(struct mlx5_ib_dev *dev, struct mlx5_ib_mr *mr)
544 int shrink = 0; 544 int shrink = 0;
545 int c; 545 int c;
546 546
547 if (!mr->allocated_from_cache)
548 return;
549
547 c = order2idx(dev, mr->order); 550 c = order2idx(dev, mr->order);
548 if (c < 0 || c >= MAX_MR_CACHE_ENTRIES) { 551 if (c < 0 || c >= MAX_MR_CACHE_ENTRIES) {
549 mlx5_ib_warn(dev, "order %d, cache index %d\n", mr->order, c); 552 mlx5_ib_warn(dev, "order %d, cache index %d\n", mr->order, c);
@@ -1647,18 +1650,19 @@ static void dereg_mr(struct mlx5_ib_dev *dev, struct mlx5_ib_mr *mr)
1647 umem = NULL; 1650 umem = NULL;
1648 } 1651 }
1649#endif 1652#endif
1650
1651 clean_mr(dev, mr); 1653 clean_mr(dev, mr);
1652 1654
1655 /*
1656 * We should unregister the DMA address from the HCA before
1657 * remove the DMA mapping.
1658 */
1659 mlx5_mr_cache_free(dev, mr);
1653 if (umem) { 1660 if (umem) {
1654 ib_umem_release(umem); 1661 ib_umem_release(umem);
1655 atomic_sub(npages, &dev->mdev->priv.reg_pages); 1662 atomic_sub(npages, &dev->mdev->priv.reg_pages);
1656 } 1663 }
1657
1658 if (!mr->allocated_from_cache) 1664 if (!mr->allocated_from_cache)
1659 kfree(mr); 1665 kfree(mr);
1660 else
1661 mlx5_mr_cache_free(dev, mr);
1662} 1666}
1663 1667
1664int mlx5_ib_dereg_mr(struct ib_mr *ibmr) 1668int mlx5_ib_dereg_mr(struct ib_mr *ibmr)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
index ea01b8dd2be6..3d5424f335cb 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
@@ -1027,12 +1027,14 @@ static int ipoib_cm_rep_handler(struct ib_cm_id *cm_id,
1027 1027
1028 skb_queue_head_init(&skqueue); 1028 skb_queue_head_init(&skqueue);
1029 1029
1030 netif_tx_lock_bh(p->dev);
1030 spin_lock_irq(&priv->lock); 1031 spin_lock_irq(&priv->lock);
1031 set_bit(IPOIB_FLAG_OPER_UP, &p->flags); 1032 set_bit(IPOIB_FLAG_OPER_UP, &p->flags);
1032 if (p->neigh) 1033 if (p->neigh)
1033 while ((skb = __skb_dequeue(&p->neigh->queue))) 1034 while ((skb = __skb_dequeue(&p->neigh->queue)))
1034 __skb_queue_tail(&skqueue, skb); 1035 __skb_queue_tail(&skqueue, skb);
1035 spin_unlock_irq(&priv->lock); 1036 spin_unlock_irq(&priv->lock);
1037 netif_tx_unlock_bh(p->dev);
1036 1038
1037 while ((skb = __skb_dequeue(&skqueue))) { 1039 while ((skb = __skb_dequeue(&skqueue))) {
1038 skb->dev = p->dev; 1040 skb->dev = p->dev;
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 444d16520506..0b34e909505f 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -2951,7 +2951,7 @@ static int srp_reset_device(struct scsi_cmnd *scmnd)
2951{ 2951{
2952 struct srp_target_port *target = host_to_target(scmnd->device->host); 2952 struct srp_target_port *target = host_to_target(scmnd->device->host);
2953 struct srp_rdma_ch *ch; 2953 struct srp_rdma_ch *ch;
2954 int i; 2954 int i, j;
2955 u8 status; 2955 u8 status;
2956 2956
2957 shost_printk(KERN_ERR, target->scsi_host, "SRP reset_device called\n"); 2957 shost_printk(KERN_ERR, target->scsi_host, "SRP reset_device called\n");
@@ -2965,8 +2965,8 @@ static int srp_reset_device(struct scsi_cmnd *scmnd)
2965 2965
2966 for (i = 0; i < target->ch_count; i++) { 2966 for (i = 0; i < target->ch_count; i++) {
2967 ch = &target->ch[i]; 2967 ch = &target->ch[i];
2968 for (i = 0; i < target->req_ring_size; ++i) { 2968 for (j = 0; j < target->req_ring_size; ++j) {
2969 struct srp_request *req = &ch->req_ring[i]; 2969 struct srp_request *req = &ch->req_ring[j];
2970 2970
2971 srp_finish_req(ch, req, scmnd->device, DID_RESET << 16); 2971 srp_finish_req(ch, req, scmnd->device, DID_RESET << 16);
2972 } 2972 }
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 370206f987f9..f48369d6f3a0 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -564,6 +564,7 @@ static ssize_t evdev_write(struct file *file, const char __user *buffer,
564 564
565 input_inject_event(&evdev->handle, 565 input_inject_event(&evdev->handle,
566 event.type, event.code, event.value); 566 event.type, event.code, event.value);
567 cond_resched();
567 } 568 }
568 569
569 out: 570 out:
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index cd620e009bad..d4b9db487b16 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -231,6 +231,7 @@ static const struct xpad_device {
231 { 0x0e6f, 0x0246, "Rock Candy Gamepad for Xbox One 2015", 0, XTYPE_XBOXONE }, 231 { 0x0e6f, 0x0246, "Rock Candy Gamepad for Xbox One 2015", 0, XTYPE_XBOXONE },
232 { 0x0e6f, 0x02ab, "PDP Controller for Xbox One", 0, XTYPE_XBOXONE }, 232 { 0x0e6f, 0x02ab, "PDP Controller for Xbox One", 0, XTYPE_XBOXONE },
233 { 0x0e6f, 0x02a4, "PDP Wired Controller for Xbox One - Stealth Series", 0, XTYPE_XBOXONE }, 233 { 0x0e6f, 0x02a4, "PDP Wired Controller for Xbox One - Stealth Series", 0, XTYPE_XBOXONE },
234 { 0x0e6f, 0x02a6, "PDP Wired Controller for Xbox One - Camo Series", 0, XTYPE_XBOXONE },
234 { 0x0e6f, 0x0301, "Logic3 Controller", 0, XTYPE_XBOX360 }, 235 { 0x0e6f, 0x0301, "Logic3 Controller", 0, XTYPE_XBOX360 },
235 { 0x0e6f, 0x0346, "Rock Candy Gamepad for Xbox One 2016", 0, XTYPE_XBOXONE }, 236 { 0x0e6f, 0x0346, "Rock Candy Gamepad for Xbox One 2016", 0, XTYPE_XBOXONE },
236 { 0x0e6f, 0x0401, "Logic3 Controller", 0, XTYPE_XBOX360 }, 237 { 0x0e6f, 0x0401, "Logic3 Controller", 0, XTYPE_XBOX360 },
@@ -530,6 +531,8 @@ static const struct xboxone_init_packet xboxone_init_packets[] = {
530 XBOXONE_INIT_PKT(0x0e6f, 0x02ab, xboxone_pdp_init2), 531 XBOXONE_INIT_PKT(0x0e6f, 0x02ab, xboxone_pdp_init2),
531 XBOXONE_INIT_PKT(0x0e6f, 0x02a4, xboxone_pdp_init1), 532 XBOXONE_INIT_PKT(0x0e6f, 0x02a4, xboxone_pdp_init1),
532 XBOXONE_INIT_PKT(0x0e6f, 0x02a4, xboxone_pdp_init2), 533 XBOXONE_INIT_PKT(0x0e6f, 0x02a4, xboxone_pdp_init2),
534 XBOXONE_INIT_PKT(0x0e6f, 0x02a6, xboxone_pdp_init1),
535 XBOXONE_INIT_PKT(0x0e6f, 0x02a6, xboxone_pdp_init2),
533 XBOXONE_INIT_PKT(0x24c6, 0x541a, xboxone_rumblebegin_init), 536 XBOXONE_INIT_PKT(0x24c6, 0x541a, xboxone_rumblebegin_init),
534 XBOXONE_INIT_PKT(0x24c6, 0x542a, xboxone_rumblebegin_init), 537 XBOXONE_INIT_PKT(0x24c6, 0x542a, xboxone_rumblebegin_init),
535 XBOXONE_INIT_PKT(0x24c6, 0x543a, xboxone_rumblebegin_init), 538 XBOXONE_INIT_PKT(0x24c6, 0x543a, xboxone_rumblebegin_init),
diff --git a/drivers/input/keyboard/atakbd.c b/drivers/input/keyboard/atakbd.c
index 6f62da2909ec..6caee807cafa 100644
--- a/drivers/input/keyboard/atakbd.c
+++ b/drivers/input/keyboard/atakbd.c
@@ -75,8 +75,7 @@ MODULE_LICENSE("GPL");
75 */ 75 */
76 76
77 77
78static unsigned char atakbd_keycode[0x72] = { /* American layout */ 78static unsigned char atakbd_keycode[0x73] = { /* American layout */
79 [0] = KEY_GRAVE,
80 [1] = KEY_ESC, 79 [1] = KEY_ESC,
81 [2] = KEY_1, 80 [2] = KEY_1,
82 [3] = KEY_2, 81 [3] = KEY_2,
@@ -117,9 +116,9 @@ static unsigned char atakbd_keycode[0x72] = { /* American layout */
117 [38] = KEY_L, 116 [38] = KEY_L,
118 [39] = KEY_SEMICOLON, 117 [39] = KEY_SEMICOLON,
119 [40] = KEY_APOSTROPHE, 118 [40] = KEY_APOSTROPHE,
120 [41] = KEY_BACKSLASH, /* FIXME, '#' */ 119 [41] = KEY_GRAVE,
121 [42] = KEY_LEFTSHIFT, 120 [42] = KEY_LEFTSHIFT,
122 [43] = KEY_GRAVE, /* FIXME: '~' */ 121 [43] = KEY_BACKSLASH,
123 [44] = KEY_Z, 122 [44] = KEY_Z,
124 [45] = KEY_X, 123 [45] = KEY_X,
125 [46] = KEY_C, 124 [46] = KEY_C,
@@ -145,45 +144,34 @@ static unsigned char atakbd_keycode[0x72] = { /* American layout */
145 [66] = KEY_F8, 144 [66] = KEY_F8,
146 [67] = KEY_F9, 145 [67] = KEY_F9,
147 [68] = KEY_F10, 146 [68] = KEY_F10,
148 [69] = KEY_ESC, 147 [71] = KEY_HOME,
149 [70] = KEY_DELETE, 148 [72] = KEY_UP,
150 [71] = KEY_KP7,
151 [72] = KEY_KP8,
152 [73] = KEY_KP9,
153 [74] = KEY_KPMINUS, 149 [74] = KEY_KPMINUS,
154 [75] = KEY_KP4, 150 [75] = KEY_LEFT,
155 [76] = KEY_KP5, 151 [77] = KEY_RIGHT,
156 [77] = KEY_KP6,
157 [78] = KEY_KPPLUS, 152 [78] = KEY_KPPLUS,
158 [79] = KEY_KP1, 153 [80] = KEY_DOWN,
159 [80] = KEY_KP2, 154 [82] = KEY_INSERT,
160 [81] = KEY_KP3, 155 [83] = KEY_DELETE,
161 [82] = KEY_KP0,
162 [83] = KEY_KPDOT,
163 [90] = KEY_KPLEFTPAREN,
164 [91] = KEY_KPRIGHTPAREN,
165 [92] = KEY_KPASTERISK, /* FIXME */
166 [93] = KEY_KPASTERISK,
167 [94] = KEY_KPPLUS,
168 [95] = KEY_HELP,
169 [96] = KEY_102ND, 156 [96] = KEY_102ND,
170 [97] = KEY_KPASTERISK, /* FIXME */ 157 [97] = KEY_UNDO,
171 [98] = KEY_KPSLASH, 158 [98] = KEY_HELP,
172 [99] = KEY_KPLEFTPAREN, 159 [99] = KEY_KPLEFTPAREN,
173 [100] = KEY_KPRIGHTPAREN, 160 [100] = KEY_KPRIGHTPAREN,
174 [101] = KEY_KPSLASH, 161 [101] = KEY_KPSLASH,
175 [102] = KEY_KPASTERISK, 162 [102] = KEY_KPASTERISK,
176 [103] = KEY_UP, 163 [103] = KEY_KP7,
177 [104] = KEY_KPASTERISK, /* FIXME */ 164 [104] = KEY_KP8,
178 [105] = KEY_LEFT, 165 [105] = KEY_KP9,
179 [106] = KEY_RIGHT, 166 [106] = KEY_KP4,
180 [107] = KEY_KPASTERISK, /* FIXME */ 167 [107] = KEY_KP5,
181 [108] = KEY_DOWN, 168 [108] = KEY_KP6,
182 [109] = KEY_KPASTERISK, /* FIXME */ 169 [109] = KEY_KP1,
183 [110] = KEY_KPASTERISK, /* FIXME */ 170 [110] = KEY_KP2,
184 [111] = KEY_KPASTERISK, /* FIXME */ 171 [111] = KEY_KP3,
185 [112] = KEY_KPASTERISK, /* FIXME */ 172 [112] = KEY_KP0,
186 [113] = KEY_KPASTERISK /* FIXME */ 173 [113] = KEY_KPDOT,
174 [114] = KEY_KPENTER,
187}; 175};
188 176
189static struct input_dev *atakbd_dev; 177static struct input_dev *atakbd_dev;
@@ -191,21 +179,15 @@ static struct input_dev *atakbd_dev;
191static void atakbd_interrupt(unsigned char scancode, char down) 179static void atakbd_interrupt(unsigned char scancode, char down)
192{ 180{
193 181
194 if (scancode < 0x72) { /* scancodes < 0xf2 are keys */ 182 if (scancode < 0x73) { /* scancodes < 0xf3 are keys */
195 183
196 // report raw events here? 184 // report raw events here?
197 185
198 scancode = atakbd_keycode[scancode]; 186 scancode = atakbd_keycode[scancode];
199 187
200 if (scancode == KEY_CAPSLOCK) { /* CapsLock is a toggle switch key on Amiga */ 188 input_report_key(atakbd_dev, scancode, down);
201 input_report_key(atakbd_dev, scancode, 1); 189 input_sync(atakbd_dev);
202 input_report_key(atakbd_dev, scancode, 0); 190 } else /* scancodes >= 0xf3 are mouse data, most likely */
203 input_sync(atakbd_dev);
204 } else {
205 input_report_key(atakbd_dev, scancode, down);
206 input_sync(atakbd_dev);
207 }
208 } else /* scancodes >= 0xf2 are mouse data, most likely */
209 printk(KERN_INFO "atakbd: unhandled scancode %x\n", scancode); 191 printk(KERN_INFO "atakbd: unhandled scancode %x\n", scancode);
210 192
211 return; 193 return;
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 96a887f33698..8ec483e8688b 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -410,7 +410,7 @@ static int uinput_validate_absinfo(struct input_dev *dev, unsigned int code,
410 min = abs->minimum; 410 min = abs->minimum;
411 max = abs->maximum; 411 max = abs->maximum;
412 412
413 if ((min != 0 || max != 0) && max <= min) { 413 if ((min != 0 || max != 0) && max < min) {
414 printk(KERN_DEBUG 414 printk(KERN_DEBUG
415 "%s: invalid abs[%02x] min:%d max:%d\n", 415 "%s: invalid abs[%02x] min:%d max:%d\n",
416 UINPUT_NAME, code, min, max); 416 UINPUT_NAME, code, min, max);
@@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
598 598
599 input_event(udev->dev, ev.type, ev.code, ev.value); 599 input_event(udev->dev, ev.type, ev.code, ev.value);
600 bytes += input_event_size(); 600 bytes += input_event_size();
601 cond_resched();
601 } 602 }
602 603
603 return bytes; 604 return bytes;
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 44f57cf6675b..2d95e8d93cc7 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1178,6 +1178,8 @@ static const struct dmi_system_id elantech_dmi_has_middle_button[] = {
1178static const char * const middle_button_pnp_ids[] = { 1178static const char * const middle_button_pnp_ids[] = {
1179 "LEN2131", /* ThinkPad P52 w/ NFC */ 1179 "LEN2131", /* ThinkPad P52 w/ NFC */
1180 "LEN2132", /* ThinkPad P52 */ 1180 "LEN2132", /* ThinkPad P52 */
1181 "LEN2133", /* ThinkPad P72 w/ NFC */
1182 "LEN2134", /* ThinkPad P72 */
1181 NULL 1183 NULL
1182}; 1184};
1183 1185
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index e08228061bcd..412fa71245af 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -707,6 +707,7 @@ static ssize_t mousedev_write(struct file *file, const char __user *buffer,
707 mousedev_generate_response(client, c); 707 mousedev_generate_response(client, c);
708 708
709 spin_unlock_irq(&client->packet_lock); 709 spin_unlock_irq(&client->packet_lock);
710 cond_resched();
710 } 711 }
711 712
712 kill_fasync(&client->fasync, SIGIO, POLL_IN); 713 kill_fasync(&client->fasync, SIGIO, POLL_IN);
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index b8bc71569349..95a78ccbd847 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -1395,15 +1395,26 @@ static void __init i8042_register_ports(void)
1395 for (i = 0; i < I8042_NUM_PORTS; i++) { 1395 for (i = 0; i < I8042_NUM_PORTS; i++) {
1396 struct serio *serio = i8042_ports[i].serio; 1396 struct serio *serio = i8042_ports[i].serio;
1397 1397
1398 if (serio) { 1398 if (!serio)
1399 printk(KERN_INFO "serio: %s at %#lx,%#lx irq %d\n", 1399 continue;
1400 serio->name, 1400
1401 (unsigned long) I8042_DATA_REG, 1401 printk(KERN_INFO "serio: %s at %#lx,%#lx irq %d\n",
1402 (unsigned long) I8042_COMMAND_REG, 1402 serio->name,
1403 i8042_ports[i].irq); 1403 (unsigned long) I8042_DATA_REG,
1404 serio_register_port(serio); 1404 (unsigned long) I8042_COMMAND_REG,
1405 device_set_wakeup_capable(&serio->dev, true); 1405 i8042_ports[i].irq);
1406 } 1406 serio_register_port(serio);
1407 device_set_wakeup_capable(&serio->dev, true);
1408
1409 /*
1410 * On platforms using suspend-to-idle, allow the keyboard to
1411 * wake up the system from sleep by enabling keyboard wakeups
1412 * by default. This is consistent with keyboard wakeup
1413 * behavior on many platforms using suspend-to-RAM (ACPI S3)
1414 * by default.
1415 */
1416 if (pm_suspend_via_s2idle() && i == I8042_KBD_PORT_NO)
1417 device_set_wakeup_enable(&serio->dev, true);
1407 } 1418 }
1408} 1419}
1409 1420
diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 80e69bb8283e..83ac8c128192 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -241,6 +241,9 @@ static int __maybe_unused egalax_ts_suspend(struct device *dev)
241 struct i2c_client *client = to_i2c_client(dev); 241 struct i2c_client *client = to_i2c_client(dev);
242 int ret; 242 int ret;
243 243
244 if (device_may_wakeup(dev))
245 return enable_irq_wake(client->irq);
246
244 ret = i2c_master_send(client, suspend_cmd, MAX_I2C_DATA_LEN); 247 ret = i2c_master_send(client, suspend_cmd, MAX_I2C_DATA_LEN);
245 return ret > 0 ? 0 : ret; 248 return ret > 0 ? 0 : ret;
246} 249}
@@ -249,6 +252,9 @@ static int __maybe_unused egalax_ts_resume(struct device *dev)
249{ 252{
250 struct i2c_client *client = to_i2c_client(dev); 253 struct i2c_client *client = to_i2c_client(dev);
251 254
255 if (device_may_wakeup(dev))
256 return disable_irq_wake(client->irq);
257
252 return egalax_wake_up_device(client); 258 return egalax_wake_up_device(client);
253} 259}
254 260
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 4e04fff23977..bee0dfb7b93b 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -246,7 +246,13 @@ static u16 get_alias(struct device *dev)
246 246
247 /* The callers make sure that get_device_id() does not fail here */ 247 /* The callers make sure that get_device_id() does not fail here */
248 devid = get_device_id(dev); 248 devid = get_device_id(dev);
249
250 /* For ACPI HID devices, we simply return the devid as such */
251 if (!dev_is_pci(dev))
252 return devid;
253
249 ivrs_alias = amd_iommu_alias_table[devid]; 254 ivrs_alias = amd_iommu_alias_table[devid];
255
250 pci_for_each_dma_alias(pdev, __last_alias, &pci_alias); 256 pci_for_each_dma_alias(pdev, __last_alias, &pci_alias);
251 257
252 if (ivrs_alias == pci_alias) 258 if (ivrs_alias == pci_alias)
@@ -3063,7 +3069,7 @@ static phys_addr_t amd_iommu_iova_to_phys(struct iommu_domain *dom,
3063 return 0; 3069 return 0;
3064 3070
3065 offset_mask = pte_pgsize - 1; 3071 offset_mask = pte_pgsize - 1;
3066 __pte = *pte & PM_ADDR_MASK; 3072 __pte = __sme_clr(*pte & PM_ADDR_MASK);
3067 3073
3068 return (__pte & ~offset_mask) | (iova & offset_mask); 3074 return (__pte & ~offset_mask) | (iova & offset_mask);
3069} 3075}
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 5f3f10cf9d9d..bedc801b06a0 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -2540,9 +2540,9 @@ static struct dmar_domain *dmar_insert_one_dev_info(struct intel_iommu *iommu,
2540 if (dev && dev_is_pci(dev) && info->pasid_supported) { 2540 if (dev && dev_is_pci(dev) && info->pasid_supported) {
2541 ret = intel_pasid_alloc_table(dev); 2541 ret = intel_pasid_alloc_table(dev);
2542 if (ret) { 2542 if (ret) {
2543 __dmar_remove_one_dev_info(info); 2543 pr_warn("No pasid table for %s, pasid disabled\n",
2544 spin_unlock_irqrestore(&device_domain_lock, flags); 2544 dev_name(dev));
2545 return NULL; 2545 info->pasid_supported = 0;
2546 } 2546 }
2547 } 2547 }
2548 spin_unlock_irqrestore(&device_domain_lock, flags); 2548 spin_unlock_irqrestore(&device_domain_lock, flags);
diff --git a/drivers/iommu/intel-pasid.h b/drivers/iommu/intel-pasid.h
index 1c05ed6fc5a5..1fb5e12b029a 100644
--- a/drivers/iommu/intel-pasid.h
+++ b/drivers/iommu/intel-pasid.h
@@ -11,7 +11,7 @@
11#define __INTEL_PASID_H 11#define __INTEL_PASID_H
12 12
13#define PASID_MIN 0x1 13#define PASID_MIN 0x1
14#define PASID_MAX 0x100000 14#define PASID_MAX 0x20000
15 15
16struct pasid_entry { 16struct pasid_entry {
17 u64 val; 17 u64 val;
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index 258115b10fa9..ad3e2b97469e 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -1241,6 +1241,12 @@ err_unprepare_clocks:
1241 1241
1242static void rk_iommu_shutdown(struct platform_device *pdev) 1242static void rk_iommu_shutdown(struct platform_device *pdev)
1243{ 1243{
1244 struct rk_iommu *iommu = platform_get_drvdata(pdev);
1245 int i = 0, irq;
1246
1247 while ((irq = platform_get_irq(pdev, i++)) != -ENXIO)
1248 devm_free_irq(iommu->dev, irq, iommu);
1249
1244 pm_runtime_force_suspend(&pdev->dev); 1250 pm_runtime_force_suspend(&pdev->dev);
1245} 1251}
1246 1252
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index 311e91b1a14f..256f18b67e8a 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -461,8 +461,11 @@ static int __init acpi_pcc_probe(void)
461 count = acpi_table_parse_entries_array(ACPI_SIG_PCCT, 461 count = acpi_table_parse_entries_array(ACPI_SIG_PCCT,
462 sizeof(struct acpi_table_pcct), proc, 462 sizeof(struct acpi_table_pcct), proc,
463 ACPI_PCCT_TYPE_RESERVED, MAX_PCC_SUBSPACES); 463 ACPI_PCCT_TYPE_RESERVED, MAX_PCC_SUBSPACES);
464 if (count == 0 || count > MAX_PCC_SUBSPACES) { 464 if (count <= 0 || count > MAX_PCC_SUBSPACES) {
465 pr_warn("Invalid PCCT: %d PCC subspaces\n", count); 465 if (count < 0)
466 pr_warn("Error parsing PCC subspaces from PCCT\n");
467 else
468 pr_warn("Invalid PCCT: %d PCC subspaces\n", count);
466 return -EINVAL; 469 return -EINVAL;
467 } 470 }
468 471
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index 83504dd8100a..954dad29e6e8 100644
--- a/drivers/md/bcache/bcache.h
+++ b/drivers/md/bcache/bcache.h
@@ -965,6 +965,7 @@ void bch_prio_write(struct cache *ca);
965void bch_write_bdev_super(struct cached_dev *dc, struct closure *parent); 965void bch_write_bdev_super(struct cached_dev *dc, struct closure *parent);
966 966
967extern struct workqueue_struct *bcache_wq; 967extern struct workqueue_struct *bcache_wq;
968extern struct workqueue_struct *bch_journal_wq;
968extern struct mutex bch_register_lock; 969extern struct mutex bch_register_lock;
969extern struct list_head bch_cache_sets; 970extern struct list_head bch_cache_sets;
970 971
diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
index 6116bbf870d8..522c7426f3a0 100644
--- a/drivers/md/bcache/journal.c
+++ b/drivers/md/bcache/journal.c
@@ -485,7 +485,7 @@ static void do_journal_discard(struct cache *ca)
485 485
486 closure_get(&ca->set->cl); 486 closure_get(&ca->set->cl);
487 INIT_WORK(&ja->discard_work, journal_discard_work); 487 INIT_WORK(&ja->discard_work, journal_discard_work);
488 schedule_work(&ja->discard_work); 488 queue_work(bch_journal_wq, &ja->discard_work);
489 } 489 }
490} 490}
491 491
@@ -592,7 +592,7 @@ static void journal_write_done(struct closure *cl)
592 : &j->w[0]; 592 : &j->w[0];
593 593
594 __closure_wake_up(&w->wait); 594 __closure_wake_up(&w->wait);
595 continue_at_nobarrier(cl, journal_write, system_wq); 595 continue_at_nobarrier(cl, journal_write, bch_journal_wq);
596} 596}
597 597
598static void journal_write_unlock(struct closure *cl) 598static void journal_write_unlock(struct closure *cl)
@@ -627,7 +627,7 @@ static void journal_write_unlocked(struct closure *cl)
627 spin_unlock(&c->journal.lock); 627 spin_unlock(&c->journal.lock);
628 628
629 btree_flush_write(c); 629 btree_flush_write(c);
630 continue_at(cl, journal_write, system_wq); 630 continue_at(cl, journal_write, bch_journal_wq);
631 return; 631 return;
632 } 632 }
633 633
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 94c756c66bd7..30ba9aeb5ee8 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -47,6 +47,7 @@ static int bcache_major;
47static DEFINE_IDA(bcache_device_idx); 47static DEFINE_IDA(bcache_device_idx);
48static wait_queue_head_t unregister_wait; 48static wait_queue_head_t unregister_wait;
49struct workqueue_struct *bcache_wq; 49struct workqueue_struct *bcache_wq;
50struct workqueue_struct *bch_journal_wq;
50 51
51#define BTREE_MAX_PAGES (256 * 1024 / PAGE_SIZE) 52#define BTREE_MAX_PAGES (256 * 1024 / PAGE_SIZE)
52/* limitation of partitions number on single bcache device */ 53/* limitation of partitions number on single bcache device */
@@ -2341,6 +2342,9 @@ static void bcache_exit(void)
2341 kobject_put(bcache_kobj); 2342 kobject_put(bcache_kobj);
2342 if (bcache_wq) 2343 if (bcache_wq)
2343 destroy_workqueue(bcache_wq); 2344 destroy_workqueue(bcache_wq);
2345 if (bch_journal_wq)
2346 destroy_workqueue(bch_journal_wq);
2347
2344 if (bcache_major) 2348 if (bcache_major)
2345 unregister_blkdev(bcache_major, "bcache"); 2349 unregister_blkdev(bcache_major, "bcache");
2346 unregister_reboot_notifier(&reboot); 2350 unregister_reboot_notifier(&reboot);
@@ -2370,6 +2374,10 @@ static int __init bcache_init(void)
2370 if (!bcache_wq) 2374 if (!bcache_wq)
2371 goto err; 2375 goto err;
2372 2376
2377 bch_journal_wq = alloc_workqueue("bch_journal", WQ_MEM_RECLAIM, 0);
2378 if (!bch_journal_wq)
2379 goto err;
2380
2373 bcache_kobj = kobject_create_and_add("bcache", fs_kobj); 2381 bcache_kobj = kobject_create_and_add("bcache", fs_kobj);
2374 if (!bcache_kobj) 2382 if (!bcache_kobj)
2375 goto err; 2383 goto err;
diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 69dddeab124c..5936de71883f 100644
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -1455,8 +1455,8 @@ static int __load_mappings(struct dm_cache_metadata *cmd,
1455 if (hints_valid) { 1455 if (hints_valid) {
1456 r = dm_array_cursor_next(&cmd->hint_cursor); 1456 r = dm_array_cursor_next(&cmd->hint_cursor);
1457 if (r) { 1457 if (r) {
1458 DMERR("dm_array_cursor_next for hint failed"); 1458 dm_array_cursor_end(&cmd->hint_cursor);
1459 goto out; 1459 hints_valid = false;
1460 } 1460 }
1461 } 1461 }
1462 1462
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index a53413371725..b29a8327eed1 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -3009,8 +3009,13 @@ static dm_cblock_t get_cache_dev_size(struct cache *cache)
3009 3009
3010static bool can_resize(struct cache *cache, dm_cblock_t new_size) 3010static bool can_resize(struct cache *cache, dm_cblock_t new_size)
3011{ 3011{
3012 if (from_cblock(new_size) > from_cblock(cache->cache_size)) 3012 if (from_cblock(new_size) > from_cblock(cache->cache_size)) {
3013 return true; 3013 if (cache->sized) {
3014 DMERR("%s: unable to extend cache due to missing cache table reload",
3015 cache_device_name(cache));
3016 return false;
3017 }
3018 }
3014 3019
3015 /* 3020 /*
3016 * We can't drop a dirty block when shrinking the cache. 3021 * We can't drop a dirty block when shrinking the cache.
@@ -3479,14 +3484,13 @@ static int __init dm_cache_init(void)
3479 int r; 3484 int r;
3480 3485
3481 migration_cache = KMEM_CACHE(dm_cache_migration, 0); 3486 migration_cache = KMEM_CACHE(dm_cache_migration, 0);
3482 if (!migration_cache) { 3487 if (!migration_cache)
3483 dm_unregister_target(&cache_target);
3484 return -ENOMEM; 3488 return -ENOMEM;
3485 }
3486 3489
3487 r = dm_register_target(&cache_target); 3490 r = dm_register_target(&cache_target);
3488 if (r) { 3491 if (r) {
3489 DMERR("cache target registration failed: %d", r); 3492 DMERR("cache target registration failed: %d", r);
3493 kmem_cache_destroy(migration_cache);
3490 return r; 3494 return r;
3491 } 3495 }
3492 3496
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index f266c81f396f..0481223b1deb 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -332,7 +332,7 @@ static int crypt_iv_essiv_init(struct crypt_config *cc)
332 int err; 332 int err;
333 333
334 desc->tfm = essiv->hash_tfm; 334 desc->tfm = essiv->hash_tfm;
335 desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP; 335 desc->flags = 0;
336 336
337 err = crypto_shash_digest(desc, cc->key, cc->key_size, essiv->salt); 337 err = crypto_shash_digest(desc, cc->key, cc->key_size, essiv->salt);
338 shash_desc_zero(desc); 338 shash_desc_zero(desc);
@@ -606,7 +606,7 @@ static int crypt_iv_lmk_one(struct crypt_config *cc, u8 *iv,
606 int i, r; 606 int i, r;
607 607
608 desc->tfm = lmk->hash_tfm; 608 desc->tfm = lmk->hash_tfm;
609 desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP; 609 desc->flags = 0;
610 610
611 r = crypto_shash_init(desc); 611 r = crypto_shash_init(desc);
612 if (r) 612 if (r)
@@ -768,7 +768,7 @@ static int crypt_iv_tcw_whitening(struct crypt_config *cc,
768 768
769 /* calculate crc32 for every 32bit part and xor it */ 769 /* calculate crc32 for every 32bit part and xor it */
770 desc->tfm = tcw->crc32_tfm; 770 desc->tfm = tcw->crc32_tfm;
771 desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP; 771 desc->flags = 0;
772 for (i = 0; i < 4; i++) { 772 for (i = 0; i < 4; i++) {
773 r = crypto_shash_init(desc); 773 r = crypto_shash_init(desc);
774 if (r) 774 if (r)
@@ -1251,7 +1251,7 @@ static void crypt_alloc_req_skcipher(struct crypt_config *cc,
1251 * requests if driver request queue is full. 1251 * requests if driver request queue is full.
1252 */ 1252 */
1253 skcipher_request_set_callback(ctx->r.req, 1253 skcipher_request_set_callback(ctx->r.req,
1254 CRYPTO_TFM_REQ_MAY_BACKLOG | CRYPTO_TFM_REQ_MAY_SLEEP, 1254 CRYPTO_TFM_REQ_MAY_BACKLOG,
1255 kcryptd_async_done, dmreq_of_req(cc, ctx->r.req)); 1255 kcryptd_async_done, dmreq_of_req(cc, ctx->r.req));
1256} 1256}
1257 1257
@@ -1268,7 +1268,7 @@ static void crypt_alloc_req_aead(struct crypt_config *cc,
1268 * requests if driver request queue is full. 1268 * requests if driver request queue is full.
1269 */ 1269 */
1270 aead_request_set_callback(ctx->r.req_aead, 1270 aead_request_set_callback(ctx->r.req_aead,
1271 CRYPTO_TFM_REQ_MAY_BACKLOG | CRYPTO_TFM_REQ_MAY_SLEEP, 1271 CRYPTO_TFM_REQ_MAY_BACKLOG,
1272 kcryptd_async_done, dmreq_of_req(cc, ctx->r.req_aead)); 1272 kcryptd_async_done, dmreq_of_req(cc, ctx->r.req_aead));
1273} 1273}
1274 1274
diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c
index 21d126a5078c..32aabe27b37c 100644
--- a/drivers/md/dm-flakey.c
+++ b/drivers/md/dm-flakey.c
@@ -467,7 +467,9 @@ static int flakey_iterate_devices(struct dm_target *ti, iterate_devices_callout_
467static struct target_type flakey_target = { 467static struct target_type flakey_target = {
468 .name = "flakey", 468 .name = "flakey",
469 .version = {1, 5, 0}, 469 .version = {1, 5, 0},
470#ifdef CONFIG_BLK_DEV_ZONED
470 .features = DM_TARGET_ZONED_HM, 471 .features = DM_TARGET_ZONED_HM,
472#endif
471 .module = THIS_MODULE, 473 .module = THIS_MODULE,
472 .ctr = flakey_ctr, 474 .ctr = flakey_ctr,
473 .dtr = flakey_dtr, 475 .dtr = flakey_dtr,
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index 378878599466..e1fa6baf4e8e 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -532,7 +532,7 @@ static void section_mac(struct dm_integrity_c *ic, unsigned section, __u8 result
532 unsigned j, size; 532 unsigned j, size;
533 533
534 desc->tfm = ic->journal_mac; 534 desc->tfm = ic->journal_mac;
535 desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP; 535 desc->flags = 0;
536 536
537 r = crypto_shash_init(desc); 537 r = crypto_shash_init(desc);
538 if (unlikely(r)) { 538 if (unlikely(r)) {
@@ -676,7 +676,7 @@ static void complete_journal_encrypt(struct crypto_async_request *req, int err)
676static bool do_crypt(bool encrypt, struct skcipher_request *req, struct journal_completion *comp) 676static bool do_crypt(bool encrypt, struct skcipher_request *req, struct journal_completion *comp)
677{ 677{
678 int r; 678 int r;
679 skcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG | CRYPTO_TFM_REQ_MAY_SLEEP, 679 skcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG,
680 complete_journal_encrypt, comp); 680 complete_journal_encrypt, comp);
681 if (likely(encrypt)) 681 if (likely(encrypt))
682 r = crypto_skcipher_encrypt(req); 682 r = crypto_skcipher_encrypt(req);
@@ -3462,7 +3462,8 @@ try_smaller_buffer:
3462 r = -ENOMEM; 3462 r = -ENOMEM;
3463 goto bad; 3463 goto bad;
3464 } 3464 }
3465 ic->recalc_tags = kvmalloc((RECALC_SECTORS >> ic->sb->log2_sectors_per_block) * ic->tag_size, GFP_KERNEL); 3465 ic->recalc_tags = kvmalloc_array(RECALC_SECTORS >> ic->sb->log2_sectors_per_block,
3466 ic->tag_size, GFP_KERNEL);
3466 if (!ic->recalc_tags) { 3467 if (!ic->recalc_tags) {
3467 ti->error = "Cannot allocate tags for recalculating"; 3468 ti->error = "Cannot allocate tags for recalculating";
3468 r = -ENOMEM; 3469 r = -ENOMEM;
diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
index d10964d41fd7..2f7c44a006c4 100644
--- a/drivers/md/dm-linear.c
+++ b/drivers/md/dm-linear.c
@@ -102,6 +102,7 @@ static int linear_map(struct dm_target *ti, struct bio *bio)
102 return DM_MAPIO_REMAPPED; 102 return DM_MAPIO_REMAPPED;
103} 103}
104 104
105#ifdef CONFIG_BLK_DEV_ZONED
105static int linear_end_io(struct dm_target *ti, struct bio *bio, 106static int linear_end_io(struct dm_target *ti, struct bio *bio,
106 blk_status_t *error) 107 blk_status_t *error)
107{ 108{
@@ -112,6 +113,7 @@ static int linear_end_io(struct dm_target *ti, struct bio *bio,
112 113
113 return DM_ENDIO_DONE; 114 return DM_ENDIO_DONE;
114} 115}
116#endif
115 117
116static void linear_status(struct dm_target *ti, status_type_t type, 118static void linear_status(struct dm_target *ti, status_type_t type,
117 unsigned status_flags, char *result, unsigned maxlen) 119 unsigned status_flags, char *result, unsigned maxlen)
@@ -208,12 +210,16 @@ static size_t linear_dax_copy_to_iter(struct dm_target *ti, pgoff_t pgoff,
208static struct target_type linear_target = { 210static struct target_type linear_target = {
209 .name = "linear", 211 .name = "linear",
210 .version = {1, 4, 0}, 212 .version = {1, 4, 0},
213#ifdef CONFIG_BLK_DEV_ZONED
214 .end_io = linear_end_io,
211 .features = DM_TARGET_PASSES_INTEGRITY | DM_TARGET_ZONED_HM, 215 .features = DM_TARGET_PASSES_INTEGRITY | DM_TARGET_ZONED_HM,
216#else
217 .features = DM_TARGET_PASSES_INTEGRITY,
218#endif
212 .module = THIS_MODULE, 219 .module = THIS_MODULE,
213 .ctr = linear_ctr, 220 .ctr = linear_ctr,
214 .dtr = linear_dtr, 221 .dtr = linear_dtr,
215 .map = linear_map, 222 .map = linear_map,
216 .end_io = linear_end_io,
217 .status = linear_status, 223 .status = linear_status,
218 .prepare_ioctl = linear_prepare_ioctl, 224 .prepare_ioctl = linear_prepare_ioctl,
219 .iterate_devices = linear_iterate_devices, 225 .iterate_devices = linear_iterate_devices,
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index d94ba6f72ff5..419362c2d8ac 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -806,19 +806,19 @@ static int parse_path_selector(struct dm_arg_set *as, struct priority_group *pg,
806} 806}
807 807
808static int setup_scsi_dh(struct block_device *bdev, struct multipath *m, 808static int setup_scsi_dh(struct block_device *bdev, struct multipath *m,
809 const char *attached_handler_name, char **error) 809 const char **attached_handler_name, char **error)
810{ 810{
811 struct request_queue *q = bdev_get_queue(bdev); 811 struct request_queue *q = bdev_get_queue(bdev);
812 int r; 812 int r;
813 813
814 if (test_bit(MPATHF_RETAIN_ATTACHED_HW_HANDLER, &m->flags)) { 814 if (test_bit(MPATHF_RETAIN_ATTACHED_HW_HANDLER, &m->flags)) {
815retain: 815retain:
816 if (attached_handler_name) { 816 if (*attached_handler_name) {
817 /* 817 /*
818 * Clear any hw_handler_params associated with a 818 * Clear any hw_handler_params associated with a
819 * handler that isn't already attached. 819 * handler that isn't already attached.
820 */ 820 */
821 if (m->hw_handler_name && strcmp(attached_handler_name, m->hw_handler_name)) { 821 if (m->hw_handler_name && strcmp(*attached_handler_name, m->hw_handler_name)) {
822 kfree(m->hw_handler_params); 822 kfree(m->hw_handler_params);
823 m->hw_handler_params = NULL; 823 m->hw_handler_params = NULL;
824 } 824 }
@@ -830,7 +830,8 @@ retain:
830 * handler instead of the original table passed in. 830 * handler instead of the original table passed in.
831 */ 831 */
832 kfree(m->hw_handler_name); 832 kfree(m->hw_handler_name);
833 m->hw_handler_name = attached_handler_name; 833 m->hw_handler_name = *attached_handler_name;
834 *attached_handler_name = NULL;
834 } 835 }
835 } 836 }
836 837
@@ -867,7 +868,7 @@ static struct pgpath *parse_path(struct dm_arg_set *as, struct path_selector *ps
867 struct pgpath *p; 868 struct pgpath *p;
868 struct multipath *m = ti->private; 869 struct multipath *m = ti->private;
869 struct request_queue *q; 870 struct request_queue *q;
870 const char *attached_handler_name; 871 const char *attached_handler_name = NULL;
871 872
872 /* we need at least a path arg */ 873 /* we need at least a path arg */
873 if (as->argc < 1) { 874 if (as->argc < 1) {
@@ -890,7 +891,7 @@ static struct pgpath *parse_path(struct dm_arg_set *as, struct path_selector *ps
890 attached_handler_name = scsi_dh_attached_handler_name(q, GFP_KERNEL); 891 attached_handler_name = scsi_dh_attached_handler_name(q, GFP_KERNEL);
891 if (attached_handler_name || m->hw_handler_name) { 892 if (attached_handler_name || m->hw_handler_name) {
892 INIT_DELAYED_WORK(&p->activate_path, activate_path_work); 893 INIT_DELAYED_WORK(&p->activate_path, activate_path_work);
893 r = setup_scsi_dh(p->path.dev->bdev, m, attached_handler_name, &ti->error); 894 r = setup_scsi_dh(p->path.dev->bdev, m, &attached_handler_name, &ti->error);
894 if (r) { 895 if (r) {
895 dm_put_device(ti, p->path.dev); 896 dm_put_device(ti, p->path.dev);
896 goto bad; 897 goto bad;
@@ -905,6 +906,7 @@ static struct pgpath *parse_path(struct dm_arg_set *as, struct path_selector *ps
905 906
906 return p; 907 return p;
907 bad: 908 bad:
909 kfree(attached_handler_name);
908 free_pgpath(p); 910 free_pgpath(p);
909 return ERR_PTR(r); 911 return ERR_PTR(r);
910} 912}
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index cae689de75fd..c44925e4e481 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1,6 +1,6 @@
1/* 1/*
2 * Copyright (C) 2010-2011 Neil Brown 2 * Copyright (C) 2010-2011 Neil Brown
3 * Copyright (C) 2010-2017 Red Hat, Inc. All rights reserved. 3 * Copyright (C) 2010-2018 Red Hat, Inc. All rights reserved.
4 * 4 *
5 * This file is released under the GPL. 5 * This file is released under the GPL.
6 */ 6 */
@@ -29,9 +29,6 @@
29 */ 29 */
30#define MIN_RAID456_JOURNAL_SPACE (4*2048) 30#define MIN_RAID456_JOURNAL_SPACE (4*2048)
31 31
32/* Global list of all raid sets */
33static LIST_HEAD(raid_sets);
34
35static bool devices_handle_discard_safely = false; 32static bool devices_handle_discard_safely = false;
36 33
37/* 34/*
@@ -227,7 +224,6 @@ struct rs_layout {
227 224
228struct raid_set { 225struct raid_set {
229 struct dm_target *ti; 226 struct dm_target *ti;
230 struct list_head list;
231 227
232 uint32_t stripe_cache_entries; 228 uint32_t stripe_cache_entries;
233 unsigned long ctr_flags; 229 unsigned long ctr_flags;
@@ -273,19 +269,6 @@ static void rs_config_restore(struct raid_set *rs, struct rs_layout *l)
273 mddev->new_chunk_sectors = l->new_chunk_sectors; 269 mddev->new_chunk_sectors = l->new_chunk_sectors;
274} 270}
275 271
276/* Find any raid_set in active slot for @rs on global list */
277static struct raid_set *rs_find_active(struct raid_set *rs)
278{
279 struct raid_set *r;
280 struct mapped_device *md = dm_table_get_md(rs->ti->table);
281
282 list_for_each_entry(r, &raid_sets, list)
283 if (r != rs && dm_table_get_md(r->ti->table) == md)
284 return r;
285
286 return NULL;
287}
288
289/* raid10 algorithms (i.e. formats) */ 272/* raid10 algorithms (i.e. formats) */
290#define ALGORITHM_RAID10_DEFAULT 0 273#define ALGORITHM_RAID10_DEFAULT 0
291#define ALGORITHM_RAID10_NEAR 1 274#define ALGORITHM_RAID10_NEAR 1
@@ -764,7 +747,6 @@ static struct raid_set *raid_set_alloc(struct dm_target *ti, struct raid_type *r
764 747
765 mddev_init(&rs->md); 748 mddev_init(&rs->md);
766 749
767 INIT_LIST_HEAD(&rs->list);
768 rs->raid_disks = raid_devs; 750 rs->raid_disks = raid_devs;
769 rs->delta_disks = 0; 751 rs->delta_disks = 0;
770 752
@@ -782,9 +764,6 @@ static struct raid_set *raid_set_alloc(struct dm_target *ti, struct raid_type *r
782 for (i = 0; i < raid_devs; i++) 764 for (i = 0; i < raid_devs; i++)
783 md_rdev_init(&rs->dev[i].rdev); 765 md_rdev_init(&rs->dev[i].rdev);
784 766
785 /* Add @rs to global list. */
786 list_add(&rs->list, &raid_sets);
787
788 /* 767 /*
789 * Remaining items to be initialized by further RAID params: 768 * Remaining items to be initialized by further RAID params:
790 * rs->md.persistent 769 * rs->md.persistent
@@ -797,7 +776,7 @@ static struct raid_set *raid_set_alloc(struct dm_target *ti, struct raid_type *r
797 return rs; 776 return rs;
798} 777}
799 778
800/* Free all @rs allocations and remove it from global list. */ 779/* Free all @rs allocations */
801static void raid_set_free(struct raid_set *rs) 780static void raid_set_free(struct raid_set *rs)
802{ 781{
803 int i; 782 int i;
@@ -815,8 +794,6 @@ static void raid_set_free(struct raid_set *rs)
815 dm_put_device(rs->ti, rs->dev[i].data_dev); 794 dm_put_device(rs->ti, rs->dev[i].data_dev);
816 } 795 }
817 796
818 list_del(&rs->list);
819
820 kfree(rs); 797 kfree(rs);
821} 798}
822 799
@@ -2649,7 +2626,7 @@ static int rs_adjust_data_offsets(struct raid_set *rs)
2649 return 0; 2626 return 0;
2650 } 2627 }
2651 2628
2652 /* HM FIXME: get InSync raid_dev? */ 2629 /* HM FIXME: get In_Sync raid_dev? */
2653 rdev = &rs->dev[0].rdev; 2630 rdev = &rs->dev[0].rdev;
2654 2631
2655 if (rs->delta_disks < 0) { 2632 if (rs->delta_disks < 0) {
@@ -3149,6 +3126,11 @@ static int raid_ctr(struct dm_target *ti, unsigned int argc, char **argv)
3149 set_bit(RT_FLAG_UPDATE_SBS, &rs->runtime_flags); 3126 set_bit(RT_FLAG_UPDATE_SBS, &rs->runtime_flags);
3150 rs_set_new(rs); 3127 rs_set_new(rs);
3151 } else if (rs_is_recovering(rs)) { 3128 } else if (rs_is_recovering(rs)) {
3129 /* Rebuild particular devices */
3130 if (test_bit(__CTR_FLAG_REBUILD, &rs->ctr_flags)) {
3131 set_bit(RT_FLAG_UPDATE_SBS, &rs->runtime_flags);
3132 rs_setup_recovery(rs, MaxSector);
3133 }
3152 /* A recovering raid set may be resized */ 3134 /* A recovering raid set may be resized */
3153 ; /* skip setup rs */ 3135 ; /* skip setup rs */
3154 } else if (rs_is_reshaping(rs)) { 3136 } else if (rs_is_reshaping(rs)) {
@@ -3242,6 +3224,8 @@ static int raid_ctr(struct dm_target *ti, unsigned int argc, char **argv)
3242 /* Start raid set read-only and assumed clean to change in raid_resume() */ 3224 /* Start raid set read-only and assumed clean to change in raid_resume() */
3243 rs->md.ro = 1; 3225 rs->md.ro = 1;
3244 rs->md.in_sync = 1; 3226 rs->md.in_sync = 1;
3227
3228 /* Keep array frozen */
3245 set_bit(MD_RECOVERY_FROZEN, &rs->md.recovery); 3229 set_bit(MD_RECOVERY_FROZEN, &rs->md.recovery);
3246 3230
3247 /* Has to be held on running the array */ 3231 /* Has to be held on running the array */
@@ -3265,7 +3249,7 @@ static int raid_ctr(struct dm_target *ti, unsigned int argc, char **argv)
3265 rs->callbacks.congested_fn = raid_is_congested; 3249 rs->callbacks.congested_fn = raid_is_congested;
3266 dm_table_add_target_callbacks(ti->table, &rs->callbacks); 3250 dm_table_add_target_callbacks(ti->table, &rs->callbacks);
3267 3251
3268 /* If raid4/5/6 journal mode explictely requested (only possible with journal dev) -> set it */ 3252 /* If raid4/5/6 journal mode explicitly requested (only possible with journal dev) -> set it */
3269 if (test_bit(__CTR_FLAG_JOURNAL_MODE, &rs->ctr_flags)) { 3253 if (test_bit(__CTR_FLAG_JOURNAL_MODE, &rs->ctr_flags)) {
3270 r = r5c_journal_mode_set(&rs->md, rs->journal_dev.mode); 3254 r = r5c_journal_mode_set(&rs->md, rs->journal_dev.mode);
3271 if (r) { 3255 if (r) {
@@ -3350,32 +3334,53 @@ static int raid_map(struct dm_target *ti, struct bio *bio)
3350 return DM_MAPIO_SUBMITTED; 3334 return DM_MAPIO_SUBMITTED;
3351} 3335}
3352 3336
3353/* Return string describing the current sync action of @mddev */ 3337/* Return sync state string for @state */
3354static const char *decipher_sync_action(struct mddev *mddev, unsigned long recovery) 3338enum sync_state { st_frozen, st_reshape, st_resync, st_check, st_repair, st_recover, st_idle };
3339static const char *sync_str(enum sync_state state)
3340{
3341 /* Has to be in above sync_state order! */
3342 static const char *sync_strs[] = {
3343 "frozen",
3344 "reshape",
3345 "resync",
3346 "check",
3347 "repair",
3348 "recover",
3349 "idle"
3350 };
3351
3352 return __within_range(state, 0, ARRAY_SIZE(sync_strs) - 1) ? sync_strs[state] : "undef";
3353};
3354
3355/* Return enum sync_state for @mddev derived from @recovery flags */
3356static enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
3355{ 3357{
3356 if (test_bit(MD_RECOVERY_FROZEN, &recovery)) 3358 if (test_bit(MD_RECOVERY_FROZEN, &recovery))
3357 return "frozen"; 3359 return st_frozen;
3358 3360
3359 /* The MD sync thread can be done with io but still be running */ 3361 /* The MD sync thread can be done with io or be interrupted but still be running */
3360 if (!test_bit(MD_RECOVERY_DONE, &recovery) && 3362 if (!test_bit(MD_RECOVERY_DONE, &recovery) &&
3361 (test_bit(MD_RECOVERY_RUNNING, &recovery) || 3363 (test_bit(MD_RECOVERY_RUNNING, &recovery) ||
3362 (!mddev->ro && test_bit(MD_RECOVERY_NEEDED, &recovery)))) { 3364 (!mddev->ro && test_bit(MD_RECOVERY_NEEDED, &recovery)))) {
3363 if (test_bit(MD_RECOVERY_RESHAPE, &recovery)) 3365 if (test_bit(MD_RECOVERY_RESHAPE, &recovery))
3364 return "reshape"; 3366 return st_reshape;
3365 3367
3366 if (test_bit(MD_RECOVERY_SYNC, &recovery)) { 3368 if (test_bit(MD_RECOVERY_SYNC, &recovery)) {
3367 if (!test_bit(MD_RECOVERY_REQUESTED, &recovery)) 3369 if (!test_bit(MD_RECOVERY_REQUESTED, &recovery))
3368 return "resync"; 3370 return st_resync;
3369 else if (test_bit(MD_RECOVERY_CHECK, &recovery)) 3371 if (test_bit(MD_RECOVERY_CHECK, &recovery))
3370 return "check"; 3372 return st_check;
3371 return "repair"; 3373 return st_repair;
3372 } 3374 }
3373 3375
3374 if (test_bit(MD_RECOVERY_RECOVER, &recovery)) 3376 if (test_bit(MD_RECOVERY_RECOVER, &recovery))
3375 return "recover"; 3377 return st_recover;
3378
3379 if (mddev->reshape_position != MaxSector)
3380 return st_reshape;
3376 } 3381 }
3377 3382
3378 return "idle"; 3383 return st_idle;
3379} 3384}
3380 3385
3381/* 3386/*
@@ -3409,6 +3414,7 @@ static sector_t rs_get_progress(struct raid_set *rs, unsigned long recovery,
3409 sector_t resync_max_sectors) 3414 sector_t resync_max_sectors)
3410{ 3415{
3411 sector_t r; 3416 sector_t r;
3417 enum sync_state state;
3412 struct mddev *mddev = &rs->md; 3418 struct mddev *mddev = &rs->md;
3413 3419
3414 clear_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags); 3420 clear_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags);
@@ -3419,20 +3425,14 @@ static sector_t rs_get_progress(struct raid_set *rs, unsigned long recovery,
3419 set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags); 3425 set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags);
3420 3426
3421 } else { 3427 } else {
3422 if (!test_bit(__CTR_FLAG_NOSYNC, &rs->ctr_flags) && 3428 state = decipher_sync_action(mddev, recovery);
3423 !test_bit(MD_RECOVERY_INTR, &recovery) && 3429
3424 (test_bit(MD_RECOVERY_NEEDED, &recovery) || 3430 if (state == st_idle && !test_bit(MD_RECOVERY_INTR, &recovery))
3425 test_bit(MD_RECOVERY_RESHAPE, &recovery) ||
3426 test_bit(MD_RECOVERY_RUNNING, &recovery)))
3427 r = mddev->curr_resync_completed;
3428 else
3429 r = mddev->recovery_cp; 3431 r = mddev->recovery_cp;
3432 else
3433 r = mddev->curr_resync_completed;
3430 3434
3431 if (r >= resync_max_sectors && 3435 if (state == st_idle && r >= resync_max_sectors) {
3432 (!test_bit(MD_RECOVERY_REQUESTED, &recovery) ||
3433 (!test_bit(MD_RECOVERY_FROZEN, &recovery) &&
3434 !test_bit(MD_RECOVERY_NEEDED, &recovery) &&
3435 !test_bit(MD_RECOVERY_RUNNING, &recovery)))) {
3436 /* 3436 /*
3437 * Sync complete. 3437 * Sync complete.
3438 */ 3438 */
@@ -3440,24 +3440,20 @@ static sector_t rs_get_progress(struct raid_set *rs, unsigned long recovery,
3440 if (test_bit(MD_RECOVERY_RECOVER, &recovery)) 3440 if (test_bit(MD_RECOVERY_RECOVER, &recovery))
3441 set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags); 3441 set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags);
3442 3442
3443 } else if (test_bit(MD_RECOVERY_RECOVER, &recovery)) { 3443 } else if (state == st_recover)
3444 /* 3444 /*
3445 * In case we are recovering, the array is not in sync 3445 * In case we are recovering, the array is not in sync
3446 * and health chars should show the recovering legs. 3446 * and health chars should show the recovering legs.
3447 */ 3447 */
3448 ; 3448 ;
3449 3449 else if (state == st_resync)
3450 } else if (test_bit(MD_RECOVERY_SYNC, &recovery) &&
3451 !test_bit(MD_RECOVERY_REQUESTED, &recovery)) {
3452 /* 3450 /*
3453 * If "resync" is occurring, the raid set 3451 * If "resync" is occurring, the raid set
3454 * is or may be out of sync hence the health 3452 * is or may be out of sync hence the health
3455 * characters shall be 'a'. 3453 * characters shall be 'a'.
3456 */ 3454 */
3457 set_bit(RT_FLAG_RS_RESYNCING, &rs->runtime_flags); 3455 set_bit(RT_FLAG_RS_RESYNCING, &rs->runtime_flags);
3458 3456 else if (state == st_reshape)
3459 } else if (test_bit(MD_RECOVERY_RESHAPE, &recovery) &&
3460 !test_bit(MD_RECOVERY_REQUESTED, &recovery)) {
3461 /* 3457 /*
3462 * If "reshape" is occurring, the raid set 3458 * If "reshape" is occurring, the raid set
3463 * is or may be out of sync hence the health 3459 * is or may be out of sync hence the health
@@ -3465,7 +3461,7 @@ static sector_t rs_get_progress(struct raid_set *rs, unsigned long recovery,
3465 */ 3461 */
3466 set_bit(RT_FLAG_RS_RESYNCING, &rs->runtime_flags); 3462 set_bit(RT_FLAG_RS_RESYNCING, &rs->runtime_flags);
3467 3463
3468 } else if (test_bit(MD_RECOVERY_REQUESTED, &recovery)) { 3464 else if (state == st_check || state == st_repair)
3469 /* 3465 /*
3470 * If "check" or "repair" is occurring, the raid set has 3466 * If "check" or "repair" is occurring, the raid set has
3471 * undergone an initial sync and the health characters 3467 * undergone an initial sync and the health characters
@@ -3473,12 +3469,12 @@ static sector_t rs_get_progress(struct raid_set *rs, unsigned long recovery,
3473 */ 3469 */
3474 set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags); 3470 set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags);
3475 3471
3476 } else { 3472 else {
3477 struct md_rdev *rdev; 3473 struct md_rdev *rdev;
3478 3474
3479 /* 3475 /*
3480 * We are idle and recovery is needed, prevent 'A' chars race 3476 * We are idle and recovery is needed, prevent 'A' chars race
3481 * caused by components still set to in-sync by constrcuctor. 3477 * caused by components still set to in-sync by constructor.
3482 */ 3478 */
3483 if (test_bit(MD_RECOVERY_NEEDED, &recovery)) 3479 if (test_bit(MD_RECOVERY_NEEDED, &recovery))
3484 set_bit(RT_FLAG_RS_RESYNCING, &rs->runtime_flags); 3480 set_bit(RT_FLAG_RS_RESYNCING, &rs->runtime_flags);
@@ -3542,7 +3538,7 @@ static void raid_status(struct dm_target *ti, status_type_t type,
3542 progress = rs_get_progress(rs, recovery, resync_max_sectors); 3538 progress = rs_get_progress(rs, recovery, resync_max_sectors);
3543 resync_mismatches = (mddev->last_sync_action && !strcasecmp(mddev->last_sync_action, "check")) ? 3539 resync_mismatches = (mddev->last_sync_action && !strcasecmp(mddev->last_sync_action, "check")) ?
3544 atomic64_read(&mddev->resync_mismatches) : 0; 3540 atomic64_read(&mddev->resync_mismatches) : 0;
3545 sync_action = decipher_sync_action(&rs->md, recovery); 3541 sync_action = sync_str(decipher_sync_action(&rs->md, recovery));
3546 3542
3547 /* HM FIXME: do we want another state char for raid0? It shows 'D'/'A'/'-' now */ 3543 /* HM FIXME: do we want another state char for raid0? It shows 'D'/'A'/'-' now */
3548 for (i = 0; i < rs->raid_disks; i++) 3544 for (i = 0; i < rs->raid_disks; i++)
@@ -3892,14 +3888,13 @@ static int rs_start_reshape(struct raid_set *rs)
3892 struct mddev *mddev = &rs->md; 3888 struct mddev *mddev = &rs->md;
3893 struct md_personality *pers = mddev->pers; 3889 struct md_personality *pers = mddev->pers;
3894 3890
3891 /* Don't allow the sync thread to work until the table gets reloaded. */
3892 set_bit(MD_RECOVERY_WAIT, &mddev->recovery);
3893
3895 r = rs_setup_reshape(rs); 3894 r = rs_setup_reshape(rs);
3896 if (r) 3895 if (r)
3897 return r; 3896 return r;
3898 3897
3899 /* Need to be resumed to be able to start reshape, recovery is frozen until raid_resume() though */
3900 if (test_and_clear_bit(RT_FLAG_RS_SUSPENDED, &rs->runtime_flags))
3901 mddev_resume(mddev);
3902
3903 /* 3898 /*
3904 * Check any reshape constraints enforced by the personalility 3899 * Check any reshape constraints enforced by the personalility
3905 * 3900 *
@@ -3923,10 +3918,6 @@ static int rs_start_reshape(struct raid_set *rs)
3923 } 3918 }
3924 } 3919 }
3925 3920
3926 /* Suspend because a resume will happen in raid_resume() */
3927 set_bit(RT_FLAG_RS_SUSPENDED, &rs->runtime_flags);
3928 mddev_suspend(mddev);
3929
3930 /* 3921 /*
3931 * Now reshape got set up, update superblocks to 3922 * Now reshape got set up, update superblocks to
3932 * reflect the fact so that a table reload will 3923 * reflect the fact so that a table reload will
@@ -3947,29 +3938,6 @@ static int raid_preresume(struct dm_target *ti)
3947 if (test_and_set_bit(RT_FLAG_RS_PRERESUMED, &rs->runtime_flags)) 3938 if (test_and_set_bit(RT_FLAG_RS_PRERESUMED, &rs->runtime_flags))
3948 return 0; 3939 return 0;
3949 3940
3950 if (!test_bit(__CTR_FLAG_REBUILD, &rs->ctr_flags)) {
3951 struct raid_set *rs_active = rs_find_active(rs);
3952
3953 if (rs_active) {
3954 /*
3955 * In case no rebuilds have been requested
3956 * and an active table slot exists, copy
3957 * current resynchonization completed and
3958 * reshape position pointers across from
3959 * suspended raid set in the active slot.
3960 *
3961 * This resumes the new mapping at current
3962 * offsets to continue recover/reshape without
3963 * necessarily redoing a raid set partially or
3964 * causing data corruption in case of a reshape.
3965 */
3966 if (rs_active->md.curr_resync_completed != MaxSector)
3967 mddev->curr_resync_completed = rs_active->md.curr_resync_completed;
3968 if (rs_active->md.reshape_position != MaxSector)
3969 mddev->reshape_position = rs_active->md.reshape_position;
3970 }
3971 }
3972
3973 /* 3941 /*
3974 * The superblocks need to be updated on disk if the 3942 * The superblocks need to be updated on disk if the
3975 * array is new or new devices got added (thus zeroed 3943 * array is new or new devices got added (thus zeroed
@@ -4046,7 +4014,7 @@ static void raid_resume(struct dm_target *ti)
4046 4014
4047static struct target_type raid_target = { 4015static struct target_type raid_target = {
4048 .name = "raid", 4016 .name = "raid",
4049 .version = {1, 13, 2}, 4017 .version = {1, 14, 0},
4050 .module = THIS_MODULE, 4018 .module = THIS_MODULE,
4051 .ctr = raid_ctr, 4019 .ctr = raid_ctr,
4052 .dtr = raid_dtr, 4020 .dtr = raid_dtr,
diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c
index 72142021b5c9..20b0776e39ef 100644
--- a/drivers/md/dm-thin-metadata.c
+++ b/drivers/md/dm-thin-metadata.c
@@ -189,6 +189,12 @@ struct dm_pool_metadata {
189 sector_t data_block_size; 189 sector_t data_block_size;
190 190
191 /* 191 /*
192 * We reserve a section of the metadata for commit overhead.
193 * All reported space does *not* include this.
194 */
195 dm_block_t metadata_reserve;
196
197 /*
192 * Set if a transaction has to be aborted but the attempt to roll back 198 * Set if a transaction has to be aborted but the attempt to roll back
193 * to the previous (good) transaction failed. The only pool metadata 199 * to the previous (good) transaction failed. The only pool metadata
194 * operation possible in this state is the closing of the device. 200 * operation possible in this state is the closing of the device.
@@ -816,6 +822,20 @@ static int __commit_transaction(struct dm_pool_metadata *pmd)
816 return dm_tm_commit(pmd->tm, sblock); 822 return dm_tm_commit(pmd->tm, sblock);
817} 823}
818 824
825static void __set_metadata_reserve(struct dm_pool_metadata *pmd)
826{
827 int r;
828 dm_block_t total;
829 dm_block_t max_blocks = 4096; /* 16M */
830
831 r = dm_sm_get_nr_blocks(pmd->metadata_sm, &total);
832 if (r) {
833 DMERR("could not get size of metadata device");
834 pmd->metadata_reserve = max_blocks;
835 } else
836 pmd->metadata_reserve = min(max_blocks, div_u64(total, 10));
837}
838
819struct dm_pool_metadata *dm_pool_metadata_open(struct block_device *bdev, 839struct dm_pool_metadata *dm_pool_metadata_open(struct block_device *bdev,
820 sector_t data_block_size, 840 sector_t data_block_size,
821 bool format_device) 841 bool format_device)
@@ -849,6 +869,8 @@ struct dm_pool_metadata *dm_pool_metadata_open(struct block_device *bdev,
849 return ERR_PTR(r); 869 return ERR_PTR(r);
850 } 870 }
851 871
872 __set_metadata_reserve(pmd);
873
852 return pmd; 874 return pmd;
853} 875}
854 876
@@ -1820,6 +1842,13 @@ int dm_pool_get_free_metadata_block_count(struct dm_pool_metadata *pmd,
1820 down_read(&pmd->root_lock); 1842 down_read(&pmd->root_lock);
1821 if (!pmd->fail_io) 1843 if (!pmd->fail_io)
1822 r = dm_sm_get_nr_free(pmd->metadata_sm, result); 1844 r = dm_sm_get_nr_free(pmd->metadata_sm, result);
1845
1846 if (!r) {
1847 if (*result < pmd->metadata_reserve)
1848 *result = 0;
1849 else
1850 *result -= pmd->metadata_reserve;
1851 }
1823 up_read(&pmd->root_lock); 1852 up_read(&pmd->root_lock);
1824 1853
1825 return r; 1854 return r;
@@ -1932,8 +1961,11 @@ int dm_pool_resize_metadata_dev(struct dm_pool_metadata *pmd, dm_block_t new_cou
1932 int r = -EINVAL; 1961 int r = -EINVAL;
1933 1962
1934 down_write(&pmd->root_lock); 1963 down_write(&pmd->root_lock);
1935 if (!pmd->fail_io) 1964 if (!pmd->fail_io) {
1936 r = __resize_space_map(pmd->metadata_sm, new_count); 1965 r = __resize_space_map(pmd->metadata_sm, new_count);
1966 if (!r)
1967 __set_metadata_reserve(pmd);
1968 }
1937 up_write(&pmd->root_lock); 1969 up_write(&pmd->root_lock);
1938 1970
1939 return r; 1971 return r;
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 7bd60a150f8f..aaf1ad481ee8 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -200,7 +200,13 @@ struct dm_thin_new_mapping;
200enum pool_mode { 200enum pool_mode {
201 PM_WRITE, /* metadata may be changed */ 201 PM_WRITE, /* metadata may be changed */
202 PM_OUT_OF_DATA_SPACE, /* metadata may be changed, though data may not be allocated */ 202 PM_OUT_OF_DATA_SPACE, /* metadata may be changed, though data may not be allocated */
203
204 /*
205 * Like READ_ONLY, except may switch back to WRITE on metadata resize. Reported as READ_ONLY.
206 */
207 PM_OUT_OF_METADATA_SPACE,
203 PM_READ_ONLY, /* metadata may not be changed */ 208 PM_READ_ONLY, /* metadata may not be changed */
209
204 PM_FAIL, /* all I/O fails */ 210 PM_FAIL, /* all I/O fails */
205}; 211};
206 212
@@ -1371,7 +1377,35 @@ static void set_pool_mode(struct pool *pool, enum pool_mode new_mode);
1371 1377
1372static void requeue_bios(struct pool *pool); 1378static void requeue_bios(struct pool *pool);
1373 1379
1374static void check_for_space(struct pool *pool) 1380static bool is_read_only_pool_mode(enum pool_mode mode)
1381{
1382 return (mode == PM_OUT_OF_METADATA_SPACE || mode == PM_READ_ONLY);
1383}
1384
1385static bool is_read_only(struct pool *pool)
1386{
1387 return is_read_only_pool_mode(get_pool_mode(pool));
1388}
1389
1390static void check_for_metadata_space(struct pool *pool)
1391{
1392 int r;
1393 const char *ooms_reason = NULL;
1394 dm_block_t nr_free;
1395
1396 r = dm_pool_get_free_metadata_block_count(pool->pmd, &nr_free);
1397 if (r)
1398 ooms_reason = "Could not get free metadata blocks";
1399 else if (!nr_free)
1400 ooms_reason = "No free metadata blocks";
1401
1402 if (ooms_reason && !is_read_only(pool)) {
1403 DMERR("%s", ooms_reason);
1404 set_pool_mode(pool, PM_OUT_OF_METADATA_SPACE);
1405 }
1406}
1407
1408static void check_for_data_space(struct pool *pool)
1375{ 1409{
1376 int r; 1410 int r;
1377 dm_block_t nr_free; 1411 dm_block_t nr_free;
@@ -1397,14 +1431,16 @@ static int commit(struct pool *pool)
1397{ 1431{
1398 int r; 1432 int r;
1399 1433
1400 if (get_pool_mode(pool) >= PM_READ_ONLY) 1434 if (get_pool_mode(pool) >= PM_OUT_OF_METADATA_SPACE)
1401 return -EINVAL; 1435 return -EINVAL;
1402 1436
1403 r = dm_pool_commit_metadata(pool->pmd); 1437 r = dm_pool_commit_metadata(pool->pmd);
1404 if (r) 1438 if (r)
1405 metadata_operation_failed(pool, "dm_pool_commit_metadata", r); 1439 metadata_operation_failed(pool, "dm_pool_commit_metadata", r);
1406 else 1440 else {
1407 check_for_space(pool); 1441 check_for_metadata_space(pool);
1442 check_for_data_space(pool);
1443 }
1408 1444
1409 return r; 1445 return r;
1410} 1446}
@@ -1470,6 +1506,19 @@ static int alloc_data_block(struct thin_c *tc, dm_block_t *result)
1470 return r; 1506 return r;
1471 } 1507 }
1472 1508
1509 r = dm_pool_get_free_metadata_block_count(pool->pmd, &free_blocks);
1510 if (r) {
1511 metadata_operation_failed(pool, "dm_pool_get_free_metadata_block_count", r);
1512 return r;
1513 }
1514
1515 if (!free_blocks) {
1516 /* Let's commit before we use up the metadata reserve. */
1517 r = commit(pool);
1518 if (r)
1519 return r;
1520 }
1521
1473 return 0; 1522 return 0;
1474} 1523}
1475 1524
@@ -1501,6 +1550,7 @@ static blk_status_t should_error_unserviceable_bio(struct pool *pool)
1501 case PM_OUT_OF_DATA_SPACE: 1550 case PM_OUT_OF_DATA_SPACE:
1502 return pool->pf.error_if_no_space ? BLK_STS_NOSPC : 0; 1551 return pool->pf.error_if_no_space ? BLK_STS_NOSPC : 0;
1503 1552
1553 case PM_OUT_OF_METADATA_SPACE:
1504 case PM_READ_ONLY: 1554 case PM_READ_ONLY:
1505 case PM_FAIL: 1555 case PM_FAIL:
1506 return BLK_STS_IOERR; 1556 return BLK_STS_IOERR;
@@ -2464,8 +2514,9 @@ static void set_pool_mode(struct pool *pool, enum pool_mode new_mode)
2464 error_retry_list(pool); 2514 error_retry_list(pool);
2465 break; 2515 break;
2466 2516
2517 case PM_OUT_OF_METADATA_SPACE:
2467 case PM_READ_ONLY: 2518 case PM_READ_ONLY:
2468 if (old_mode != new_mode) 2519 if (!is_read_only_pool_mode(old_mode))
2469 notify_of_pool_mode_change(pool, "read-only"); 2520 notify_of_pool_mode_change(pool, "read-only");
2470 dm_pool_metadata_read_only(pool->pmd); 2521 dm_pool_metadata_read_only(pool->pmd);
2471 pool->process_bio = process_bio_read_only; 2522 pool->process_bio = process_bio_read_only;
@@ -3403,6 +3454,10 @@ static int maybe_resize_metadata_dev(struct dm_target *ti, bool *need_commit)
3403 DMINFO("%s: growing the metadata device from %llu to %llu blocks", 3454 DMINFO("%s: growing the metadata device from %llu to %llu blocks",
3404 dm_device_name(pool->pool_md), 3455 dm_device_name(pool->pool_md),
3405 sb_metadata_dev_size, metadata_dev_size); 3456 sb_metadata_dev_size, metadata_dev_size);
3457
3458 if (get_pool_mode(pool) == PM_OUT_OF_METADATA_SPACE)
3459 set_pool_mode(pool, PM_WRITE);
3460
3406 r = dm_pool_resize_metadata_dev(pool->pmd, metadata_dev_size); 3461 r = dm_pool_resize_metadata_dev(pool->pmd, metadata_dev_size);
3407 if (r) { 3462 if (r) {
3408 metadata_operation_failed(pool, "dm_pool_resize_metadata_dev", r); 3463 metadata_operation_failed(pool, "dm_pool_resize_metadata_dev", r);
@@ -3707,7 +3762,7 @@ static int pool_message(struct dm_target *ti, unsigned argc, char **argv,
3707 struct pool_c *pt = ti->private; 3762 struct pool_c *pt = ti->private;
3708 struct pool *pool = pt->pool; 3763 struct pool *pool = pt->pool;
3709 3764
3710 if (get_pool_mode(pool) >= PM_READ_ONLY) { 3765 if (get_pool_mode(pool) >= PM_OUT_OF_METADATA_SPACE) {
3711 DMERR("%s: unable to service pool target messages in READ_ONLY or FAIL mode", 3766 DMERR("%s: unable to service pool target messages in READ_ONLY or FAIL mode",
3712 dm_device_name(pool->pool_md)); 3767 dm_device_name(pool->pool_md));
3713 return -EOPNOTSUPP; 3768 return -EOPNOTSUPP;
@@ -3781,6 +3836,7 @@ static void pool_status(struct dm_target *ti, status_type_t type,
3781 dm_block_t nr_blocks_data; 3836 dm_block_t nr_blocks_data;
3782 dm_block_t nr_blocks_metadata; 3837 dm_block_t nr_blocks_metadata;
3783 dm_block_t held_root; 3838 dm_block_t held_root;
3839 enum pool_mode mode;
3784 char buf[BDEVNAME_SIZE]; 3840 char buf[BDEVNAME_SIZE];
3785 char buf2[BDEVNAME_SIZE]; 3841 char buf2[BDEVNAME_SIZE];
3786 struct pool_c *pt = ti->private; 3842 struct pool_c *pt = ti->private;
@@ -3851,9 +3907,10 @@ static void pool_status(struct dm_target *ti, status_type_t type,
3851 else 3907 else
3852 DMEMIT("- "); 3908 DMEMIT("- ");
3853 3909
3854 if (pool->pf.mode == PM_OUT_OF_DATA_SPACE) 3910 mode = get_pool_mode(pool);
3911 if (mode == PM_OUT_OF_DATA_SPACE)
3855 DMEMIT("out_of_data_space "); 3912 DMEMIT("out_of_data_space ");
3856 else if (pool->pf.mode == PM_READ_ONLY) 3913 else if (is_read_only_pool_mode(mode))
3857 DMEMIT("ro "); 3914 DMEMIT("ro ");
3858 else 3915 else
3859 DMEMIT("rw "); 3916 DMEMIT("rw ");
diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
index 12decdbd722d..fc65f0dedf7f 100644
--- a/drivers/md/dm-verity-target.c
+++ b/drivers/md/dm-verity-target.c
@@ -99,10 +99,26 @@ static int verity_hash_update(struct dm_verity *v, struct ahash_request *req,
99{ 99{
100 struct scatterlist sg; 100 struct scatterlist sg;
101 101
102 sg_init_one(&sg, data, len); 102 if (likely(!is_vmalloc_addr(data))) {
103 ahash_request_set_crypt(req, &sg, NULL, len); 103 sg_init_one(&sg, data, len);
104 104 ahash_request_set_crypt(req, &sg, NULL, len);
105 return crypto_wait_req(crypto_ahash_update(req), wait); 105 return crypto_wait_req(crypto_ahash_update(req), wait);
106 } else {
107 do {
108 int r;
109 size_t this_step = min_t(size_t, len, PAGE_SIZE - offset_in_page(data));
110 flush_kernel_vmap_range((void *)data, this_step);
111 sg_init_table(&sg, 1);
112 sg_set_page(&sg, vmalloc_to_page(data), this_step, offset_in_page(data));
113 ahash_request_set_crypt(req, &sg, NULL, this_step);
114 r = crypto_wait_req(crypto_ahash_update(req), wait);
115 if (unlikely(r))
116 return r;
117 data += this_step;
118 len -= this_step;
119 } while (len);
120 return 0;
121 }
106} 122}
107 123
108/* 124/*
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 20f7e4ef5342..45abb54037fc 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1155,12 +1155,14 @@ void dm_accept_partial_bio(struct bio *bio, unsigned n_sectors)
1155EXPORT_SYMBOL_GPL(dm_accept_partial_bio); 1155EXPORT_SYMBOL_GPL(dm_accept_partial_bio);
1156 1156
1157/* 1157/*
1158 * The zone descriptors obtained with a zone report indicate 1158 * The zone descriptors obtained with a zone report indicate zone positions
1159 * zone positions within the target device. The zone descriptors 1159 * within the target backing device, regardless of that device is a partition
1160 * must be remapped to match their position within the dm device. 1160 * and regardless of the target mapping start sector on the device or partition.
1161 * A target may call dm_remap_zone_report after completion of a 1161 * The zone descriptors start sector and write pointer position must be adjusted
1162 * REQ_OP_ZONE_REPORT bio to remap the zone descriptors obtained 1162 * to match their relative position within the dm device.
1163 * from the target device mapping to the dm device. 1163 * A target may call dm_remap_zone_report() after completion of a
1164 * REQ_OP_ZONE_REPORT bio to remap the zone descriptors obtained from the
1165 * backing device.
1164 */ 1166 */
1165void dm_remap_zone_report(struct dm_target *ti, struct bio *bio, sector_t start) 1167void dm_remap_zone_report(struct dm_target *ti, struct bio *bio, sector_t start)
1166{ 1168{
@@ -1171,6 +1173,7 @@ void dm_remap_zone_report(struct dm_target *ti, struct bio *bio, sector_t start)
1171 struct blk_zone *zone; 1173 struct blk_zone *zone;
1172 unsigned int nr_rep = 0; 1174 unsigned int nr_rep = 0;
1173 unsigned int ofst; 1175 unsigned int ofst;
1176 sector_t part_offset;
1174 struct bio_vec bvec; 1177 struct bio_vec bvec;
1175 struct bvec_iter iter; 1178 struct bvec_iter iter;
1176 void *addr; 1179 void *addr;
@@ -1179,6 +1182,15 @@ void dm_remap_zone_report(struct dm_target *ti, struct bio *bio, sector_t start)
1179 return; 1182 return;
1180 1183
1181 /* 1184 /*
1185 * bio sector was incremented by the request size on completion. Taking
1186 * into account the original request sector, the target start offset on
1187 * the backing device and the target mapping offset (ti->begin), the
1188 * start sector of the backing device. The partition offset is always 0
1189 * if the target uses a whole device.
1190 */
1191 part_offset = bio->bi_iter.bi_sector + ti->begin - (start + bio_end_sector(report_bio));
1192
1193 /*
1182 * Remap the start sector of the reported zones. For sequential zones, 1194 * Remap the start sector of the reported zones. For sequential zones,
1183 * also remap the write pointer position. 1195 * also remap the write pointer position.
1184 */ 1196 */
@@ -1195,6 +1207,7 @@ void dm_remap_zone_report(struct dm_target *ti, struct bio *bio, sector_t start)
1195 /* Set zones start sector */ 1207 /* Set zones start sector */
1196 while (hdr->nr_zones && ofst < bvec.bv_len) { 1208 while (hdr->nr_zones && ofst < bvec.bv_len) {
1197 zone = addr + ofst; 1209 zone = addr + ofst;
1210 zone->start -= part_offset;
1198 if (zone->start >= start + ti->len) { 1211 if (zone->start >= start + ti->len) {
1199 hdr->nr_zones = 0; 1212 hdr->nr_zones = 0;
1200 break; 1213 break;
@@ -1206,7 +1219,7 @@ void dm_remap_zone_report(struct dm_target *ti, struct bio *bio, sector_t start)
1206 else if (zone->cond == BLK_ZONE_COND_EMPTY) 1219 else if (zone->cond == BLK_ZONE_COND_EMPTY)
1207 zone->wp = zone->start; 1220 zone->wp = zone->start;
1208 else 1221 else
1209 zone->wp = zone->wp + ti->begin - start; 1222 zone->wp = zone->wp + ti->begin - start - part_offset;
1210 } 1223 }
1211 ofst += sizeof(struct blk_zone); 1224 ofst += sizeof(struct blk_zone);
1212 hdr->nr_zones--; 1225 hdr->nr_zones--;
diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index b5410aeb5fe2..bb41bea950ac 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -1159,41 +1159,21 @@ static int mt9v111_probe(struct i2c_client *client)
1159 V4L2_CID_AUTO_WHITE_BALANCE, 1159 V4L2_CID_AUTO_WHITE_BALANCE,
1160 0, 1, 1, 1160 0, 1, 1,
1161 V4L2_WHITE_BALANCE_AUTO); 1161 V4L2_WHITE_BALANCE_AUTO);
1162 if (IS_ERR_OR_NULL(mt9v111->auto_awb)) {
1163 ret = PTR_ERR(mt9v111->auto_awb);
1164 goto error_free_ctrls;
1165 }
1166
1167 mt9v111->auto_exp = v4l2_ctrl_new_std_menu(&mt9v111->ctrls, 1162 mt9v111->auto_exp = v4l2_ctrl_new_std_menu(&mt9v111->ctrls,
1168 &mt9v111_ctrl_ops, 1163 &mt9v111_ctrl_ops,
1169 V4L2_CID_EXPOSURE_AUTO, 1164 V4L2_CID_EXPOSURE_AUTO,
1170 V4L2_EXPOSURE_MANUAL, 1165 V4L2_EXPOSURE_MANUAL,
1171 0, V4L2_EXPOSURE_AUTO); 1166 0, V4L2_EXPOSURE_AUTO);
1172 if (IS_ERR_OR_NULL(mt9v111->auto_exp)) {
1173 ret = PTR_ERR(mt9v111->auto_exp);
1174 goto error_free_ctrls;
1175 }
1176
1177 /* Initialize timings */
1178 mt9v111->hblank = v4l2_ctrl_new_std(&mt9v111->ctrls, &mt9v111_ctrl_ops, 1167 mt9v111->hblank = v4l2_ctrl_new_std(&mt9v111->ctrls, &mt9v111_ctrl_ops,
1179 V4L2_CID_HBLANK, 1168 V4L2_CID_HBLANK,
1180 MT9V111_CORE_R05_MIN_HBLANK, 1169 MT9V111_CORE_R05_MIN_HBLANK,
1181 MT9V111_CORE_R05_MAX_HBLANK, 1, 1170 MT9V111_CORE_R05_MAX_HBLANK, 1,
1182 MT9V111_CORE_R05_DEF_HBLANK); 1171 MT9V111_CORE_R05_DEF_HBLANK);
1183 if (IS_ERR_OR_NULL(mt9v111->hblank)) {
1184 ret = PTR_ERR(mt9v111->hblank);
1185 goto error_free_ctrls;
1186 }
1187
1188 mt9v111->vblank = v4l2_ctrl_new_std(&mt9v111->ctrls, &mt9v111_ctrl_ops, 1172 mt9v111->vblank = v4l2_ctrl_new_std(&mt9v111->ctrls, &mt9v111_ctrl_ops,
1189 V4L2_CID_VBLANK, 1173 V4L2_CID_VBLANK,
1190 MT9V111_CORE_R06_MIN_VBLANK, 1174 MT9V111_CORE_R06_MIN_VBLANK,
1191 MT9V111_CORE_R06_MAX_VBLANK, 1, 1175 MT9V111_CORE_R06_MAX_VBLANK, 1,
1192 MT9V111_CORE_R06_DEF_VBLANK); 1176 MT9V111_CORE_R06_DEF_VBLANK);
1193 if (IS_ERR_OR_NULL(mt9v111->vblank)) {
1194 ret = PTR_ERR(mt9v111->vblank);
1195 goto error_free_ctrls;
1196 }
1197 1177
1198 /* PIXEL_RATE is fixed: just expose it to user space. */ 1178 /* PIXEL_RATE is fixed: just expose it to user space. */
1199 v4l2_ctrl_new_std(&mt9v111->ctrls, &mt9v111_ctrl_ops, 1179 v4l2_ctrl_new_std(&mt9v111->ctrls, &mt9v111_ctrl_ops,
@@ -1201,6 +1181,10 @@ static int mt9v111_probe(struct i2c_client *client)
1201 DIV_ROUND_CLOSEST(mt9v111->sysclk, 2), 1, 1181 DIV_ROUND_CLOSEST(mt9v111->sysclk, 2), 1,
1202 DIV_ROUND_CLOSEST(mt9v111->sysclk, 2)); 1182 DIV_ROUND_CLOSEST(mt9v111->sysclk, 2));
1203 1183
1184 if (mt9v111->ctrls.error) {
1185 ret = mt9v111->ctrls.error;
1186 goto error_free_ctrls;
1187 }
1204 mt9v111->sd.ctrl_handler = &mt9v111->ctrls; 1188 mt9v111->sd.ctrl_handler = &mt9v111->ctrls;
1205 1189
1206 /* Start with default configuration: 640x480 UYVY. */ 1190 /* Start with default configuration: 640x480 UYVY. */
@@ -1226,26 +1210,27 @@ static int mt9v111_probe(struct i2c_client *client)
1226 mt9v111->pad.flags = MEDIA_PAD_FL_SOURCE; 1210 mt9v111->pad.flags = MEDIA_PAD_FL_SOURCE;
1227 ret = media_entity_pads_init(&mt9v111->sd.entity, 1, &mt9v111->pad); 1211 ret = media_entity_pads_init(&mt9v111->sd.entity, 1, &mt9v111->pad);
1228 if (ret) 1212 if (ret)
1229 goto error_free_ctrls; 1213 goto error_free_entity;
1230#endif 1214#endif
1231 1215
1232 ret = mt9v111_chip_probe(mt9v111); 1216 ret = mt9v111_chip_probe(mt9v111);
1233 if (ret) 1217 if (ret)
1234 goto error_free_ctrls; 1218 goto error_free_entity;
1235 1219
1236 ret = v4l2_async_register_subdev(&mt9v111->sd); 1220 ret = v4l2_async_register_subdev(&mt9v111->sd);
1237 if (ret) 1221 if (ret)
1238 goto error_free_ctrls; 1222 goto error_free_entity;
1239 1223
1240 return 0; 1224 return 0;
1241 1225
1242error_free_ctrls: 1226error_free_entity:
1243 v4l2_ctrl_handler_free(&mt9v111->ctrls);
1244
1245#if IS_ENABLED(CONFIG_MEDIA_CONTROLLER) 1227#if IS_ENABLED(CONFIG_MEDIA_CONTROLLER)
1246 media_entity_cleanup(&mt9v111->sd.entity); 1228 media_entity_cleanup(&mt9v111->sd.entity);
1247#endif 1229#endif
1248 1230
1231error_free_ctrls:
1232 v4l2_ctrl_handler_free(&mt9v111->ctrls);
1233
1249 mutex_destroy(&mt9v111->pwr_mutex); 1234 mutex_destroy(&mt9v111->pwr_mutex);
1250 mutex_destroy(&mt9v111->stream_mutex); 1235 mutex_destroy(&mt9v111->stream_mutex);
1251 1236
@@ -1259,12 +1244,12 @@ static int mt9v111_remove(struct i2c_client *client)
1259 1244
1260 v4l2_async_unregister_subdev(sd); 1245 v4l2_async_unregister_subdev(sd);
1261 1246
1262 v4l2_ctrl_handler_free(&mt9v111->ctrls);
1263
1264#if IS_ENABLED(CONFIG_MEDIA_CONTROLLER) 1247#if IS_ENABLED(CONFIG_MEDIA_CONTROLLER)
1265 media_entity_cleanup(&sd->entity); 1248 media_entity_cleanup(&sd->entity);
1266#endif 1249#endif
1267 1250
1251 v4l2_ctrl_handler_free(&mt9v111->ctrls);
1252
1268 mutex_destroy(&mt9v111->pwr_mutex); 1253 mutex_destroy(&mt9v111->pwr_mutex);
1269 mutex_destroy(&mt9v111->stream_mutex); 1254 mutex_destroy(&mt9v111->stream_mutex);
1270 1255
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 94c1fe0e9787..54fe90acb5b2 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -541,6 +541,8 @@ config VIDEO_CROS_EC_CEC
541 depends on MFD_CROS_EC 541 depends on MFD_CROS_EC
542 select CEC_CORE 542 select CEC_CORE
543 select CEC_NOTIFIER 543 select CEC_NOTIFIER
544 select CHROME_PLATFORMS
545 select CROS_EC_PROTO
544 ---help--- 546 ---help---
545 If you say yes here you will get support for the 547 If you say yes here you will get support for the
546 ChromeOS Embedded Controller's CEC. 548 ChromeOS Embedded Controller's CEC.
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index 729b31891466..a5ae85674ffb 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -10,6 +10,7 @@
10#include <linux/clk.h> 10#include <linux/clk.h>
11#include <linux/completion.h> 11#include <linux/completion.h>
12#include <linux/interrupt.h> 12#include <linux/interrupt.h>
13#include <linux/io.h>
13#include <linux/kernel.h> 14#include <linux/kernel.h>
14#include <linux/of.h> 15#include <linux/of.h>
15#include <linux/platform_device.h> 16#include <linux/platform_device.h>
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c
index c832539397d7..12bce391d71f 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c
@@ -12,6 +12,7 @@
12 12
13#include <linux/delay.h> 13#include <linux/delay.h>
14#include <linux/interrupt.h> 14#include <linux/interrupt.h>
15#include <linux/io.h>
15 16
16#define CAMSS_CSI_PHY_LNn_CFG2(n) (0x004 + 0x40 * (n)) 17#define CAMSS_CSI_PHY_LNn_CFG2(n) (0x004 + 0x40 * (n))
17#define CAMSS_CSI_PHY_LNn_CFG3(n) (0x008 + 0x40 * (n)) 18#define CAMSS_CSI_PHY_LNn_CFG3(n) (0x008 + 0x40 * (n))
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
index bcd0dfd33618..2e65caf1ecae 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
@@ -12,6 +12,7 @@
12 12
13#include <linux/delay.h> 13#include <linux/delay.h>
14#include <linux/interrupt.h> 14#include <linux/interrupt.h>
15#include <linux/io.h>
15 16
16#define CSIPHY_3PH_LNn_CFG1(n) (0x000 + 0x100 * (n)) 17#define CSIPHY_3PH_LNn_CFG1(n) (0x000 + 0x100 * (n))
17#define CSIPHY_3PH_LNn_CFG1_SWI_REC_DLY_PRG (BIT(7) | BIT(6)) 18#define CSIPHY_3PH_LNn_CFG1_SWI_REC_DLY_PRG (BIT(7) | BIT(6))
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c
index 4559f3b1b38c..008afb85023b 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy.c
@@ -10,6 +10,7 @@
10#include <linux/clk.h> 10#include <linux/clk.h>
11#include <linux/delay.h> 11#include <linux/delay.h>
12#include <linux/interrupt.h> 12#include <linux/interrupt.h>
13#include <linux/io.h>
13#include <linux/kernel.h> 14#include <linux/kernel.h>
14#include <linux/of.h> 15#include <linux/of.h>
15#include <linux/platform_device.h> 16#include <linux/platform_device.h>
diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
index 7f269021d08c..1f33b4eb198c 100644
--- a/drivers/media/platform/qcom/camss/camss-ispif.c
+++ b/drivers/media/platform/qcom/camss/camss-ispif.c
@@ -10,6 +10,7 @@
10#include <linux/clk.h> 10#include <linux/clk.h>
11#include <linux/completion.h> 11#include <linux/completion.h>
12#include <linux/interrupt.h> 12#include <linux/interrupt.h>
13#include <linux/io.h>
13#include <linux/iopoll.h> 14#include <linux/iopoll.h>
14#include <linux/kernel.h> 15#include <linux/kernel.h>
15#include <linux/mutex.h> 16#include <linux/mutex.h>
@@ -1076,8 +1077,8 @@ int msm_ispif_subdev_init(struct ispif_device *ispif,
1076 else 1077 else
1077 return -EINVAL; 1078 return -EINVAL;
1078 1079
1079 ispif->line = kcalloc(ispif->line_num, sizeof(*ispif->line), 1080 ispif->line = devm_kcalloc(dev, ispif->line_num, sizeof(*ispif->line),
1080 GFP_KERNEL); 1081 GFP_KERNEL);
1081 if (!ispif->line) 1082 if (!ispif->line)
1082 return -ENOMEM; 1083 return -ENOMEM;
1083 1084
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
index da3a9fed9f2d..174a36be6f5d 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
@@ -9,6 +9,7 @@
9 */ 9 */
10 10
11#include <linux/interrupt.h> 11#include <linux/interrupt.h>
12#include <linux/io.h>
12#include <linux/iopoll.h> 13#include <linux/iopoll.h>
13 14
14#include "camss-vfe.h" 15#include "camss-vfe.h"
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
index 4c584bffd179..0dca8bf9281e 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
@@ -9,6 +9,7 @@
9 */ 9 */
10 10
11#include <linux/interrupt.h> 11#include <linux/interrupt.h>
12#include <linux/io.h>
12#include <linux/iopoll.h> 13#include <linux/iopoll.h>
13 14
14#include "camss-vfe.h" 15#include "camss-vfe.h"
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index dcc0c30ef1b1..669615fff6a0 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -848,17 +848,18 @@ static int camss_probe(struct platform_device *pdev)
848 return -EINVAL; 848 return -EINVAL;
849 } 849 }
850 850
851 camss->csiphy = kcalloc(camss->csiphy_num, sizeof(*camss->csiphy), 851 camss->csiphy = devm_kcalloc(dev, camss->csiphy_num,
852 GFP_KERNEL); 852 sizeof(*camss->csiphy), GFP_KERNEL);
853 if (!camss->csiphy) 853 if (!camss->csiphy)
854 return -ENOMEM; 854 return -ENOMEM;
855 855
856 camss->csid = kcalloc(camss->csid_num, sizeof(*camss->csid), 856 camss->csid = devm_kcalloc(dev, camss->csid_num, sizeof(*camss->csid),
857 GFP_KERNEL); 857 GFP_KERNEL);
858 if (!camss->csid) 858 if (!camss->csid)
859 return -ENOMEM; 859 return -ENOMEM;
860 860
861 camss->vfe = kcalloc(camss->vfe_num, sizeof(*camss->vfe), GFP_KERNEL); 861 camss->vfe = devm_kcalloc(dev, camss->vfe_num, sizeof(*camss->vfe),
862 GFP_KERNEL);
862 if (!camss->vfe) 863 if (!camss->vfe)
863 return -ENOMEM; 864 return -ENOMEM;
864 865
@@ -993,12 +994,12 @@ static const struct of_device_id camss_dt_match[] = {
993 994
994MODULE_DEVICE_TABLE(of, camss_dt_match); 995MODULE_DEVICE_TABLE(of, camss_dt_match);
995 996
996static int camss_runtime_suspend(struct device *dev) 997static int __maybe_unused camss_runtime_suspend(struct device *dev)
997{ 998{
998 return 0; 999 return 0;
999} 1000}
1000 1001
1001static int camss_runtime_resume(struct device *dev) 1002static int __maybe_unused camss_runtime_resume(struct device *dev)
1002{ 1003{
1003 return 0; 1004 return 0;
1004} 1005}
diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c
index 666d319d3d1a..1f6c1eefe389 100644
--- a/drivers/media/usb/dvb-usb-v2/af9035.c
+++ b/drivers/media/usb/dvb-usb-v2/af9035.c
@@ -402,8 +402,10 @@ static int af9035_i2c_master_xfer(struct i2c_adapter *adap,
402 if (msg[0].addr == state->af9033_i2c_addr[1]) 402 if (msg[0].addr == state->af9033_i2c_addr[1])
403 reg |= 0x100000; 403 reg |= 0x100000;
404 404
405 ret = af9035_wr_regs(d, reg, &msg[0].buf[3], 405 ret = (msg[0].len >= 3) ? af9035_wr_regs(d, reg,
406 msg[0].len - 3); 406 &msg[0].buf[3],
407 msg[0].len - 3)
408 : -EOPNOTSUPP;
407 } else { 409 } else {
408 /* I2C write */ 410 /* I2C write */
409 u8 buf[MAX_XFER_SIZE]; 411 u8 buf[MAX_XFER_SIZE];
diff --git a/drivers/media/v4l2-core/v4l2-event.c b/drivers/media/v4l2-core/v4l2-event.c
index 127fe6eb91d9..a3ef1f50a4b3 100644
--- a/drivers/media/v4l2-core/v4l2-event.c
+++ b/drivers/media/v4l2-core/v4l2-event.c
@@ -115,14 +115,6 @@ static void __v4l2_event_queue_fh(struct v4l2_fh *fh, const struct v4l2_event *e
115 if (sev == NULL) 115 if (sev == NULL)
116 return; 116 return;
117 117
118 /*
119 * If the event has been added to the fh->subscribed list, but its
120 * add op has not completed yet elems will be 0, treat this as
121 * not being subscribed.
122 */
123 if (!sev->elems)
124 return;
125
126 /* Increase event sequence number on fh. */ 118 /* Increase event sequence number on fh. */
127 fh->sequence++; 119 fh->sequence++;
128 120
@@ -208,6 +200,7 @@ int v4l2_event_subscribe(struct v4l2_fh *fh,
208 struct v4l2_subscribed_event *sev, *found_ev; 200 struct v4l2_subscribed_event *sev, *found_ev;
209 unsigned long flags; 201 unsigned long flags;
210 unsigned i; 202 unsigned i;
203 int ret = 0;
211 204
212 if (sub->type == V4L2_EVENT_ALL) 205 if (sub->type == V4L2_EVENT_ALL)
213 return -EINVAL; 206 return -EINVAL;
@@ -225,31 +218,36 @@ int v4l2_event_subscribe(struct v4l2_fh *fh,
225 sev->flags = sub->flags; 218 sev->flags = sub->flags;
226 sev->fh = fh; 219 sev->fh = fh;
227 sev->ops = ops; 220 sev->ops = ops;
221 sev->elems = elems;
222
223 mutex_lock(&fh->subscribe_lock);
228 224
229 spin_lock_irqsave(&fh->vdev->fh_lock, flags); 225 spin_lock_irqsave(&fh->vdev->fh_lock, flags);
230 found_ev = v4l2_event_subscribed(fh, sub->type, sub->id); 226 found_ev = v4l2_event_subscribed(fh, sub->type, sub->id);
231 if (!found_ev)
232 list_add(&sev->list, &fh->subscribed);
233 spin_unlock_irqrestore(&fh->vdev->fh_lock, flags); 227 spin_unlock_irqrestore(&fh->vdev->fh_lock, flags);
234 228
235 if (found_ev) { 229 if (found_ev) {
230 /* Already listening */
236 kvfree(sev); 231 kvfree(sev);
237 return 0; /* Already listening */ 232 goto out_unlock;
238 } 233 }
239 234
240 if (sev->ops && sev->ops->add) { 235 if (sev->ops && sev->ops->add) {
241 int ret = sev->ops->add(sev, elems); 236 ret = sev->ops->add(sev, elems);
242 if (ret) { 237 if (ret) {
243 sev->ops = NULL; 238 kvfree(sev);
244 v4l2_event_unsubscribe(fh, sub); 239 goto out_unlock;
245 return ret;
246 } 240 }
247 } 241 }
248 242
249 /* Mark as ready for use */ 243 spin_lock_irqsave(&fh->vdev->fh_lock, flags);
250 sev->elems = elems; 244 list_add(&sev->list, &fh->subscribed);
245 spin_unlock_irqrestore(&fh->vdev->fh_lock, flags);
251 246
252 return 0; 247out_unlock:
248 mutex_unlock(&fh->subscribe_lock);
249
250 return ret;
253} 251}
254EXPORT_SYMBOL_GPL(v4l2_event_subscribe); 252EXPORT_SYMBOL_GPL(v4l2_event_subscribe);
255 253
@@ -288,6 +286,8 @@ int v4l2_event_unsubscribe(struct v4l2_fh *fh,
288 return 0; 286 return 0;
289 } 287 }
290 288
289 mutex_lock(&fh->subscribe_lock);
290
291 spin_lock_irqsave(&fh->vdev->fh_lock, flags); 291 spin_lock_irqsave(&fh->vdev->fh_lock, flags);
292 292
293 sev = v4l2_event_subscribed(fh, sub->type, sub->id); 293 sev = v4l2_event_subscribed(fh, sub->type, sub->id);
@@ -305,6 +305,8 @@ int v4l2_event_unsubscribe(struct v4l2_fh *fh,
305 if (sev && sev->ops && sev->ops->del) 305 if (sev && sev->ops && sev->ops->del)
306 sev->ops->del(sev); 306 sev->ops->del(sev);
307 307
308 mutex_unlock(&fh->subscribe_lock);
309
308 kvfree(sev); 310 kvfree(sev);
309 311
310 return 0; 312 return 0;
diff --git a/drivers/media/v4l2-core/v4l2-fh.c b/drivers/media/v4l2-core/v4l2-fh.c
index 3895999bf880..c91a7bd3ecfc 100644
--- a/drivers/media/v4l2-core/v4l2-fh.c
+++ b/drivers/media/v4l2-core/v4l2-fh.c
@@ -45,6 +45,7 @@ void v4l2_fh_init(struct v4l2_fh *fh, struct video_device *vdev)
45 INIT_LIST_HEAD(&fh->available); 45 INIT_LIST_HEAD(&fh->available);
46 INIT_LIST_HEAD(&fh->subscribed); 46 INIT_LIST_HEAD(&fh->subscribed);
47 fh->sequence = -1; 47 fh->sequence = -1;
48 mutex_init(&fh->subscribe_lock);
48} 49}
49EXPORT_SYMBOL_GPL(v4l2_fh_init); 50EXPORT_SYMBOL_GPL(v4l2_fh_init);
50 51
@@ -90,6 +91,7 @@ void v4l2_fh_exit(struct v4l2_fh *fh)
90 return; 91 return;
91 v4l_disable_media_source(fh->vdev); 92 v4l_disable_media_source(fh->vdev);
92 v4l2_event_unsubscribe_all(fh); 93 v4l2_event_unsubscribe_all(fh);
94 mutex_destroy(&fh->subscribe_lock);
93 fh->vdev = NULL; 95 fh->vdev = NULL;
94} 96}
95EXPORT_SYMBOL_GPL(v4l2_fh_exit); 97EXPORT_SYMBOL_GPL(v4l2_fh_exit);
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index e11ab12fbdf2..800986a79704 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -528,8 +528,8 @@ static int usbhs_omap_get_dt_pdata(struct device *dev,
528} 528}
529 529
530static const struct of_device_id usbhs_child_match_table[] = { 530static const struct of_device_id usbhs_child_match_table[] = {
531 { .compatible = "ti,omap-ehci", }, 531 { .compatible = "ti,ehci-omap", },
532 { .compatible = "ti,omap-ohci", }, 532 { .compatible = "ti,ohci-omap3", },
533 { } 533 { }
534}; 534};
535 535
@@ -855,6 +855,7 @@ static struct platform_driver usbhs_omap_driver = {
855 .pm = &usbhsomap_dev_pm_ops, 855 .pm = &usbhsomap_dev_pm_ops,
856 .of_match_table = usbhs_omap_dt_ids, 856 .of_match_table = usbhs_omap_dt_ids,
857 }, 857 },
858 .probe = usbhs_omap_probe,
858 .remove = usbhs_omap_remove, 859 .remove = usbhs_omap_remove,
859}; 860};
860 861
@@ -864,9 +865,9 @@ MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
864MODULE_LICENSE("GPL v2"); 865MODULE_LICENSE("GPL v2");
865MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI"); 866MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI");
866 867
867static int __init omap_usbhs_drvinit(void) 868static int omap_usbhs_drvinit(void)
868{ 869{
869 return platform_driver_probe(&usbhs_omap_driver, usbhs_omap_probe); 870 return platform_driver_register(&usbhs_omap_driver);
870} 871}
871 872
872/* 873/*
@@ -878,7 +879,7 @@ static int __init omap_usbhs_drvinit(void)
878 */ 879 */
879fs_initcall_sync(omap_usbhs_drvinit); 880fs_initcall_sync(omap_usbhs_drvinit);
880 881
881static void __exit omap_usbhs_drvexit(void) 882static void omap_usbhs_drvexit(void)
882{ 883{
883 platform_driver_unregister(&usbhs_omap_driver); 884 platform_driver_unregister(&usbhs_omap_driver);
884} 885}
diff --git a/drivers/misc/hmc6352.c b/drivers/misc/hmc6352.c
index eeb7eef62174..38f90e179927 100644
--- a/drivers/misc/hmc6352.c
+++ b/drivers/misc/hmc6352.c
@@ -27,6 +27,7 @@
27#include <linux/err.h> 27#include <linux/err.h>
28#include <linux/delay.h> 28#include <linux/delay.h>
29#include <linux/sysfs.h> 29#include <linux/sysfs.h>
30#include <linux/nospec.h>
30 31
31static DEFINE_MUTEX(compass_mutex); 32static DEFINE_MUTEX(compass_mutex);
32 33
@@ -50,6 +51,7 @@ static int compass_store(struct device *dev, const char *buf, size_t count,
50 return ret; 51 return ret;
51 if (val >= strlen(map)) 52 if (val >= strlen(map))
52 return -EINVAL; 53 return -EINVAL;
54 val = array_index_nospec(val, strlen(map));
53 mutex_lock(&compass_mutex); 55 mutex_lock(&compass_mutex);
54 ret = compass_command(c, map[val]); 56 ret = compass_command(c, map[val]);
55 mutex_unlock(&compass_mutex); 57 mutex_unlock(&compass_mutex);
diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
index 8f82bb9d11e2..b8aaa684c397 100644
--- a/drivers/misc/ibmvmc.c
+++ b/drivers/misc/ibmvmc.c
@@ -2131,7 +2131,7 @@ static int ibmvmc_init_crq_queue(struct crq_server_adapter *adapter)
2131 retrc = plpar_hcall_norets(H_REG_CRQ, 2131 retrc = plpar_hcall_norets(H_REG_CRQ,
2132 vdev->unit_address, 2132 vdev->unit_address,
2133 queue->msg_token, PAGE_SIZE); 2133 queue->msg_token, PAGE_SIZE);
2134 retrc = rc; 2134 rc = retrc;
2135 2135
2136 if (rc == H_RESOURCE) 2136 if (rc == H_RESOURCE)
2137 rc = ibmvmc_reset_crq_queue(adapter); 2137 rc = ibmvmc_reset_crq_queue(adapter);
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index 7bba62a72921..fc3872fe7b25 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -521,17 +521,15 @@ int mei_cldev_enable(struct mei_cl_device *cldev)
521 521
522 cl = cldev->cl; 522 cl = cldev->cl;
523 523
524 mutex_lock(&bus->device_lock);
524 if (cl->state == MEI_FILE_UNINITIALIZED) { 525 if (cl->state == MEI_FILE_UNINITIALIZED) {
525 mutex_lock(&bus->device_lock);
526 ret = mei_cl_link(cl); 526 ret = mei_cl_link(cl);
527 mutex_unlock(&bus->device_lock);
528 if (ret) 527 if (ret)
529 return ret; 528 goto out;
530 /* update pointers */ 529 /* update pointers */
531 cl->cldev = cldev; 530 cl->cldev = cldev;
532 } 531 }
533 532
534 mutex_lock(&bus->device_lock);
535 if (mei_cl_is_connected(cl)) { 533 if (mei_cl_is_connected(cl)) {
536 ret = 0; 534 ret = 0;
537 goto out; 535 goto out;
@@ -616,9 +614,8 @@ int mei_cldev_disable(struct mei_cl_device *cldev)
616 if (err < 0) 614 if (err < 0)
617 dev_err(bus->dev, "Could not disconnect from the ME client\n"); 615 dev_err(bus->dev, "Could not disconnect from the ME client\n");
618 616
619out:
620 mei_cl_bus_module_put(cldev); 617 mei_cl_bus_module_put(cldev);
621 618out:
622 /* Flush queues and remove any pending read */ 619 /* Flush queues and remove any pending read */
623 mei_cl_flush_queues(cl, NULL); 620 mei_cl_flush_queues(cl, NULL);
624 mei_cl_unlink(cl); 621 mei_cl_unlink(cl);
@@ -876,12 +873,13 @@ static void mei_cl_bus_dev_release(struct device *dev)
876 873
877 mei_me_cl_put(cldev->me_cl); 874 mei_me_cl_put(cldev->me_cl);
878 mei_dev_bus_put(cldev->bus); 875 mei_dev_bus_put(cldev->bus);
876 mei_cl_unlink(cldev->cl);
879 kfree(cldev->cl); 877 kfree(cldev->cl);
880 kfree(cldev); 878 kfree(cldev);
881} 879}
882 880
883static const struct device_type mei_cl_device_type = { 881static const struct device_type mei_cl_device_type = {
884 .release = mei_cl_bus_dev_release, 882 .release = mei_cl_bus_dev_release,
885}; 883};
886 884
887/** 885/**
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index 4ab6251d418e..ebdcf0b450e2 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -1767,7 +1767,7 @@ out:
1767 } 1767 }
1768 } 1768 }
1769 1769
1770 rets = buf->size; 1770 rets = len;
1771err: 1771err:
1772 cl_dbg(dev, cl, "rpm: autosuspend\n"); 1772 cl_dbg(dev, cl, "rpm: autosuspend\n");
1773 pm_runtime_mark_last_busy(dev->dev); 1773 pm_runtime_mark_last_busy(dev->dev);
diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c
index 09e233d4c0de..e56f3e72d57a 100644
--- a/drivers/misc/mei/hbm.c
+++ b/drivers/misc/mei/hbm.c
@@ -1161,15 +1161,18 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
1161 1161
1162 props_res = (struct hbm_props_response *)mei_msg; 1162 props_res = (struct hbm_props_response *)mei_msg;
1163 1163
1164 if (props_res->status) { 1164 if (props_res->status == MEI_HBMS_CLIENT_NOT_FOUND) {
1165 dev_dbg(dev->dev, "hbm: properties response: %d CLIENT_NOT_FOUND\n",
1166 props_res->me_addr);
1167 } else if (props_res->status) {
1165 dev_err(dev->dev, "hbm: properties response: wrong status = %d %s\n", 1168 dev_err(dev->dev, "hbm: properties response: wrong status = %d %s\n",
1166 props_res->status, 1169 props_res->status,
1167 mei_hbm_status_str(props_res->status)); 1170 mei_hbm_status_str(props_res->status));
1168 return -EPROTO; 1171 return -EPROTO;
1172 } else {
1173 mei_hbm_me_cl_add(dev, props_res);
1169 } 1174 }
1170 1175
1171 mei_hbm_me_cl_add(dev, props_res);
1172
1173 /* request property for the next client */ 1176 /* request property for the next client */
1174 if (mei_hbm_prop_req(dev, props_res->me_addr + 1)) 1177 if (mei_hbm_prop_req(dev, props_res->me_addr + 1))
1175 return -EIO; 1178 return -EIO;
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index a0b9102c4c6e..e201ccb3fda4 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1371,6 +1371,16 @@ static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
1371 1371
1372 if (brq->data.blocks > 1) { 1372 if (brq->data.blocks > 1) {
1373 /* 1373 /*
1374 * Some SD cards in SPI mode return a CRC error or even lock up
1375 * completely when trying to read the last block using a
1376 * multiblock read command.
1377 */
1378 if (mmc_host_is_spi(card->host) && (rq_data_dir(req) == READ) &&
1379 (blk_rq_pos(req) + blk_rq_sectors(req) ==
1380 get_capacity(md->disk)))
1381 brq->data.blocks--;
1382
1383 /*
1374 * After a read error, we redo the request one sector 1384 * After a read error, we redo the request one sector
1375 * at a time in order to accurately determine which 1385 * at a time in order to accurately determine which
1376 * sectors can be read successfully. 1386 * sectors can be read successfully.
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index abf9e884386c..f57f5de54206 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -235,7 +235,7 @@ int mmc_of_parse(struct mmc_host *host)
235 host->caps |= MMC_CAP_NEEDS_POLL; 235 host->caps |= MMC_CAP_NEEDS_POLL;
236 236
237 ret = mmc_gpiod_request_cd(host, "cd", 0, true, 237 ret = mmc_gpiod_request_cd(host, "cd", 0, true,
238 cd_debounce_delay_ms, 238 cd_debounce_delay_ms * 1000,
239 &cd_gpio_invert); 239 &cd_gpio_invert);
240 if (!ret) 240 if (!ret)
241 dev_info(host->parent, "Got CD GPIO\n"); 241 dev_info(host->parent, "Got CD GPIO\n");
diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
index 2a833686784b..86803a3a04dc 100644
--- a/drivers/mmc/core/slot-gpio.c
+++ b/drivers/mmc/core/slot-gpio.c
@@ -271,7 +271,7 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id,
271 if (debounce) { 271 if (debounce) {
272 ret = gpiod_set_debounce(desc, debounce); 272 ret = gpiod_set_debounce(desc, debounce);
273 if (ret < 0) 273 if (ret < 0)
274 ctx->cd_debounce_delay_ms = debounce; 274 ctx->cd_debounce_delay_ms = debounce / 1000;
275 } 275 }
276 276
277 if (gpio_invert) 277 if (gpio_invert)
diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
index 09cb89645d06..2cfec33178c1 100644
--- a/drivers/mmc/host/meson-mx-sdio.c
+++ b/drivers/mmc/host/meson-mx-sdio.c
@@ -517,19 +517,23 @@ static struct mmc_host_ops meson_mx_mmc_ops = {
517static struct platform_device *meson_mx_mmc_slot_pdev(struct device *parent) 517static struct platform_device *meson_mx_mmc_slot_pdev(struct device *parent)
518{ 518{
519 struct device_node *slot_node; 519 struct device_node *slot_node;
520 struct platform_device *pdev;
520 521
521 /* 522 /*
522 * TODO: the MMC core framework currently does not support 523 * TODO: the MMC core framework currently does not support
523 * controllers with multiple slots properly. So we only register 524 * controllers with multiple slots properly. So we only register
524 * the first slot for now 525 * the first slot for now
525 */ 526 */
526 slot_node = of_find_compatible_node(parent->of_node, NULL, "mmc-slot"); 527 slot_node = of_get_compatible_child(parent->of_node, "mmc-slot");
527 if (!slot_node) { 528 if (!slot_node) {
528 dev_warn(parent, "no 'mmc-slot' sub-node found\n"); 529 dev_warn(parent, "no 'mmc-slot' sub-node found\n");
529 return ERR_PTR(-ENOENT); 530 return ERR_PTR(-ENOENT);
530 } 531 }
531 532
532 return of_platform_device_create(slot_node, NULL, parent); 533 pdev = of_platform_device_create(slot_node, NULL, parent);
534 of_node_put(slot_node);
535
536 return pdev;
533} 537}
534 538
535static int meson_mx_mmc_add_host(struct meson_mx_mmc_host *host) 539static int meson_mx_mmc_add_host(struct meson_mx_mmc_host *host)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 071693ebfe18..68760d4a5d3d 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2177,6 +2177,7 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
2177 dma_release_channel(host->tx_chan); 2177 dma_release_channel(host->tx_chan);
2178 dma_release_channel(host->rx_chan); 2178 dma_release_channel(host->rx_chan);
2179 2179
2180 dev_pm_clear_wake_irq(host->dev);
2180 pm_runtime_dont_use_autosuspend(host->dev); 2181 pm_runtime_dont_use_autosuspend(host->dev);
2181 pm_runtime_put_sync(host->dev); 2182 pm_runtime_put_sync(host->dev);
2182 pm_runtime_disable(host->dev); 2183 pm_runtime_disable(host->dev);
diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 890f192dedbd..5389c4821882 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -498,7 +498,8 @@ static const struct soc_device_attribute gen3_soc_whitelist[] = {
498 498
499static int renesas_sdhi_sys_dmac_probe(struct platform_device *pdev) 499static int renesas_sdhi_sys_dmac_probe(struct platform_device *pdev)
500{ 500{
501 if (of_device_get_match_data(&pdev->dev) == &of_rcar_gen3_compatible && 501 if ((of_device_get_match_data(&pdev->dev) == &of_rcar_gen3_compatible ||
502 of_device_get_match_data(&pdev->dev) == &of_rcar_r8a7795_compatible) &&
502 !soc_device_match(gen3_soc_whitelist)) 503 !soc_device_match(gen3_soc_whitelist))
503 return -ENODEV; 504 return -ENODEV;
504 505
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index cbfafc453274..270d3c9580c5 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -39,13 +39,23 @@ static int m25p80_read_reg(struct spi_nor *nor, u8 code, u8 *val, int len)
39 struct spi_mem_op op = SPI_MEM_OP(SPI_MEM_OP_CMD(code, 1), 39 struct spi_mem_op op = SPI_MEM_OP(SPI_MEM_OP_CMD(code, 1),
40 SPI_MEM_OP_NO_ADDR, 40 SPI_MEM_OP_NO_ADDR,
41 SPI_MEM_OP_NO_DUMMY, 41 SPI_MEM_OP_NO_DUMMY,
42 SPI_MEM_OP_DATA_IN(len, val, 1)); 42 SPI_MEM_OP_DATA_IN(len, NULL, 1));
43 void *scratchbuf;
43 int ret; 44 int ret;
44 45
46 scratchbuf = kmalloc(len, GFP_KERNEL);
47 if (!scratchbuf)
48 return -ENOMEM;
49
50 op.data.buf.in = scratchbuf;
45 ret = spi_mem_exec_op(flash->spimem, &op); 51 ret = spi_mem_exec_op(flash->spimem, &op);
46 if (ret < 0) 52 if (ret < 0)
47 dev_err(&flash->spimem->spi->dev, "error %d reading %x\n", ret, 53 dev_err(&flash->spimem->spi->dev, "error %d reading %x\n", ret,
48 code); 54 code);
55 else
56 memcpy(val, scratchbuf, len);
57
58 kfree(scratchbuf);
49 59
50 return ret; 60 return ret;
51} 61}
@@ -56,9 +66,19 @@ static int m25p80_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)
56 struct spi_mem_op op = SPI_MEM_OP(SPI_MEM_OP_CMD(opcode, 1), 66 struct spi_mem_op op = SPI_MEM_OP(SPI_MEM_OP_CMD(opcode, 1),
57 SPI_MEM_OP_NO_ADDR, 67 SPI_MEM_OP_NO_ADDR,
58 SPI_MEM_OP_NO_DUMMY, 68 SPI_MEM_OP_NO_DUMMY,
59 SPI_MEM_OP_DATA_OUT(len, buf, 1)); 69 SPI_MEM_OP_DATA_OUT(len, NULL, 1));
70 void *scratchbuf;
71 int ret;
60 72
61 return spi_mem_exec_op(flash->spimem, &op); 73 scratchbuf = kmemdup(buf, len, GFP_KERNEL);
74 if (!scratchbuf)
75 return -ENOMEM;
76
77 op.data.buf.out = scratchbuf;
78 ret = spi_mem_exec_op(flash->spimem, &op);
79 kfree(scratchbuf);
80
81 return ret;
62} 82}
63 83
64static ssize_t m25p80_write(struct spi_nor *nor, loff_t to, size_t len, 84static ssize_t m25p80_write(struct spi_nor *nor, loff_t to, size_t len,
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 52e2cb35fc79..99c460facd5e 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -873,8 +873,11 @@ static int mtd_part_of_parse(struct mtd_info *master,
873 int ret, err = 0; 873 int ret, err = 0;
874 874
875 np = mtd_get_of_node(master); 875 np = mtd_get_of_node(master);
876 if (!mtd_is_partition(master)) 876 if (mtd_is_partition(master))
877 of_node_get(np);
878 else
877 np = of_get_child_by_name(np, "partitions"); 879 np = of_get_child_by_name(np, "partitions");
880
878 of_property_for_each_string(np, "compatible", prop, compat) { 881 of_property_for_each_string(np, "compatible", prop, compat) {
879 parser = mtd_part_get_compatible_parser(compat); 882 parser = mtd_part_get_compatible_parser(compat);
880 if (!parser) 883 if (!parser)
diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
index 67b2065e7a19..b864b93dd289 100644
--- a/drivers/mtd/nand/raw/denali.c
+++ b/drivers/mtd/nand/raw/denali.c
@@ -596,6 +596,12 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,
596 } 596 }
597 597
598 iowrite32(DMA_ENABLE__FLAG, denali->reg + DMA_ENABLE); 598 iowrite32(DMA_ENABLE__FLAG, denali->reg + DMA_ENABLE);
599 /*
600 * The ->setup_dma() hook kicks DMA by using the data/command
601 * interface, which belongs to a different AXI port from the
602 * register interface. Read back the register to avoid a race.
603 */
604 ioread32(denali->reg + DMA_ENABLE);
599 605
600 denali_reset_irq(denali); 606 denali_reset_irq(denali);
601 denali->setup_dma(denali, dma_addr, page, write); 607 denali->setup_dma(denali, dma_addr, page, write);
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index 7af4d6213ee5..bc2ef5209783 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -1547,7 +1547,7 @@ static void marvell_nfc_parse_instructions(struct nand_chip *chip,
1547 for (op_id = 0; op_id < subop->ninstrs; op_id++) { 1547 for (op_id = 0; op_id < subop->ninstrs; op_id++) {
1548 unsigned int offset, naddrs; 1548 unsigned int offset, naddrs;
1549 const u8 *addrs; 1549 const u8 *addrs;
1550 int len = nand_subop_get_data_len(subop, op_id); 1550 int len;
1551 1551
1552 instr = &subop->instrs[op_id]; 1552 instr = &subop->instrs[op_id];
1553 1553
@@ -1593,6 +1593,7 @@ static void marvell_nfc_parse_instructions(struct nand_chip *chip,
1593 nfc_op->ndcb[0] |= 1593 nfc_op->ndcb[0] |=
1594 NDCB0_CMD_XTYPE(XTYPE_MONOLITHIC_RW) | 1594 NDCB0_CMD_XTYPE(XTYPE_MONOLITHIC_RW) |
1595 NDCB0_LEN_OVRD; 1595 NDCB0_LEN_OVRD;
1596 len = nand_subop_get_data_len(subop, op_id);
1596 nfc_op->ndcb[3] |= round_up(len, FIFO_DEPTH); 1597 nfc_op->ndcb[3] |= round_up(len, FIFO_DEPTH);
1597 } 1598 }
1598 nfc_op->data_delay_ns = instr->delay_ns; 1599 nfc_op->data_delay_ns = instr->delay_ns;
@@ -1606,6 +1607,7 @@ static void marvell_nfc_parse_instructions(struct nand_chip *chip,
1606 nfc_op->ndcb[0] |= 1607 nfc_op->ndcb[0] |=
1607 NDCB0_CMD_XTYPE(XTYPE_MONOLITHIC_RW) | 1608 NDCB0_CMD_XTYPE(XTYPE_MONOLITHIC_RW) |
1608 NDCB0_LEN_OVRD; 1609 NDCB0_LEN_OVRD;
1610 len = nand_subop_get_data_len(subop, op_id);
1609 nfc_op->ndcb[3] |= round_up(len, FIFO_DEPTH); 1611 nfc_op->ndcb[3] |= round_up(len, FIFO_DEPTH);
1610 } 1612 }
1611 nfc_op->data_delay_ns = instr->delay_ns; 1613 nfc_op->data_delay_ns = instr->delay_ns;
diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
index 0f7cf54e3234..89096f10f4c4 100644
--- a/drivers/mux/adgs1408.c
+++ b/drivers/mux/adgs1408.c
@@ -128,4 +128,4 @@ module_spi_driver(adgs1408_driver);
128 128
129MODULE_AUTHOR("Mircea Caprioru <mircea.caprioru@analog.com>"); 129MODULE_AUTHOR("Mircea Caprioru <mircea.caprioru@analog.com>");
130MODULE_DESCRIPTION("Analog Devices ADGS1408 MUX driver"); 130MODULE_DESCRIPTION("Analog Devices ADGS1408 MUX driver");
131MODULE_LICENSE("GPL v2"); 131MODULE_LICENSE("GPL");
diff --git a/drivers/net/appletalk/ipddp.c b/drivers/net/appletalk/ipddp.c
index 9375cef22420..3d27616d9c85 100644
--- a/drivers/net/appletalk/ipddp.c
+++ b/drivers/net/appletalk/ipddp.c
@@ -283,8 +283,12 @@ static int ipddp_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
283 case SIOCFINDIPDDPRT: 283 case SIOCFINDIPDDPRT:
284 spin_lock_bh(&ipddp_route_lock); 284 spin_lock_bh(&ipddp_route_lock);
285 rp = __ipddp_find_route(&rcp); 285 rp = __ipddp_find_route(&rcp);
286 if (rp) 286 if (rp) {
287 memcpy(&rcp2, rp, sizeof(rcp2)); 287 memset(&rcp2, 0, sizeof(rcp2));
288 rcp2.ip = rp->ip;
289 rcp2.at = rp->at;
290 rcp2.flags = rp->flags;
291 }
288 spin_unlock_bh(&ipddp_route_lock); 292 spin_unlock_bh(&ipddp_route_lock);
289 293
290 if (rp) { 294 if (rp) {
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index a764a83f99da..ee28ec9e0aba 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -210,6 +210,7 @@ static void bond_get_stats(struct net_device *bond_dev,
210static void bond_slave_arr_handler(struct work_struct *work); 210static void bond_slave_arr_handler(struct work_struct *work);
211static bool bond_time_in_interval(struct bonding *bond, unsigned long last_act, 211static bool bond_time_in_interval(struct bonding *bond, unsigned long last_act,
212 int mod); 212 int mod);
213static void bond_netdev_notify_work(struct work_struct *work);
213 214
214/*---------------------------- General routines -----------------------------*/ 215/*---------------------------- General routines -----------------------------*/
215 216
@@ -971,16 +972,13 @@ static void bond_poll_controller(struct net_device *bond_dev)
971 struct slave *slave = NULL; 972 struct slave *slave = NULL;
972 struct list_head *iter; 973 struct list_head *iter;
973 struct ad_info ad_info; 974 struct ad_info ad_info;
974 struct netpoll_info *ni;
975 const struct net_device_ops *ops;
976 975
977 if (BOND_MODE(bond) == BOND_MODE_8023AD) 976 if (BOND_MODE(bond) == BOND_MODE_8023AD)
978 if (bond_3ad_get_active_agg_info(bond, &ad_info)) 977 if (bond_3ad_get_active_agg_info(bond, &ad_info))
979 return; 978 return;
980 979
981 bond_for_each_slave_rcu(bond, slave, iter) { 980 bond_for_each_slave_rcu(bond, slave, iter) {
982 ops = slave->dev->netdev_ops; 981 if (!bond_slave_is_up(slave))
983 if (!bond_slave_is_up(slave) || !ops->ndo_poll_controller)
984 continue; 982 continue;
985 983
986 if (BOND_MODE(bond) == BOND_MODE_8023AD) { 984 if (BOND_MODE(bond) == BOND_MODE_8023AD) {
@@ -992,11 +990,7 @@ static void bond_poll_controller(struct net_device *bond_dev)
992 continue; 990 continue;
993 } 991 }
994 992
995 ni = rcu_dereference_bh(slave->dev->npinfo); 993 netpoll_poll_dev(slave->dev);
996 if (down_trylock(&ni->dev_lock))
997 continue;
998 ops->ndo_poll_controller(slave->dev);
999 up(&ni->dev_lock);
1000 } 994 }
1001} 995}
1002 996
@@ -1177,9 +1171,27 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
1177 } 1171 }
1178 } 1172 }
1179 1173
1180 /* don't change skb->dev for link-local packets */ 1174 /* Link-local multicast packets should be passed to the
1181 if (is_link_local_ether_addr(eth_hdr(skb)->h_dest)) 1175 * stack on the link they arrive as well as pass them to the
1176 * bond-master device. These packets are mostly usable when
1177 * stack receives it with the link on which they arrive
1178 * (e.g. LLDP) they also must be available on master. Some of
1179 * the use cases include (but are not limited to): LLDP agents
1180 * that must be able to operate both on enslaved interfaces as
1181 * well as on bonds themselves; linux bridges that must be able
1182 * to process/pass BPDUs from attached bonds when any kind of
1183 * STP version is enabled on the network.
1184 */
1185 if (is_link_local_ether_addr(eth_hdr(skb)->h_dest)) {
1186 struct sk_buff *nskb = skb_clone(skb, GFP_ATOMIC);
1187
1188 if (nskb) {
1189 nskb->dev = bond->dev;
1190 nskb->queue_mapping = 0;
1191 netif_rx(nskb);
1192 }
1182 return RX_HANDLER_PASS; 1193 return RX_HANDLER_PASS;
1194 }
1183 if (bond_should_deliver_exact_match(skb, slave, bond)) 1195 if (bond_should_deliver_exact_match(skb, slave, bond))
1184 return RX_HANDLER_EXACT; 1196 return RX_HANDLER_EXACT;
1185 1197
@@ -1276,6 +1288,8 @@ static struct slave *bond_alloc_slave(struct bonding *bond)
1276 return NULL; 1288 return NULL;
1277 } 1289 }
1278 } 1290 }
1291 INIT_DELAYED_WORK(&slave->notify_work, bond_netdev_notify_work);
1292
1279 return slave; 1293 return slave;
1280} 1294}
1281 1295
@@ -1283,6 +1297,7 @@ static void bond_free_slave(struct slave *slave)
1283{ 1297{
1284 struct bonding *bond = bond_get_bond_by_slave(slave); 1298 struct bonding *bond = bond_get_bond_by_slave(slave);
1285 1299
1300 cancel_delayed_work_sync(&slave->notify_work);
1286 if (BOND_MODE(bond) == BOND_MODE_8023AD) 1301 if (BOND_MODE(bond) == BOND_MODE_8023AD)
1287 kfree(SLAVE_AD_INFO(slave)); 1302 kfree(SLAVE_AD_INFO(slave));
1288 1303
@@ -1304,39 +1319,26 @@ static void bond_fill_ifslave(struct slave *slave, struct ifslave *info)
1304 info->link_failure_count = slave->link_failure_count; 1319 info->link_failure_count = slave->link_failure_count;
1305} 1320}
1306 1321
1307static void bond_netdev_notify(struct net_device *dev,
1308 struct netdev_bonding_info *info)
1309{
1310 rtnl_lock();
1311 netdev_bonding_info_change(dev, info);
1312 rtnl_unlock();
1313}
1314
1315static void bond_netdev_notify_work(struct work_struct *_work) 1322static void bond_netdev_notify_work(struct work_struct *_work)
1316{ 1323{
1317 struct netdev_notify_work *w = 1324 struct slave *slave = container_of(_work, struct slave,
1318 container_of(_work, struct netdev_notify_work, work.work); 1325 notify_work.work);
1326
1327 if (rtnl_trylock()) {
1328 struct netdev_bonding_info binfo;
1319 1329
1320 bond_netdev_notify(w->dev, &w->bonding_info); 1330 bond_fill_ifslave(slave, &binfo.slave);
1321 dev_put(w->dev); 1331 bond_fill_ifbond(slave->bond, &binfo.master);
1322 kfree(w); 1332 netdev_bonding_info_change(slave->dev, &binfo);
1333 rtnl_unlock();
1334 } else {
1335 queue_delayed_work(slave->bond->wq, &slave->notify_work, 1);
1336 }
1323} 1337}
1324 1338
1325void bond_queue_slave_event(struct slave *slave) 1339void bond_queue_slave_event(struct slave *slave)
1326{ 1340{
1327 struct bonding *bond = slave->bond; 1341 queue_delayed_work(slave->bond->wq, &slave->notify_work, 0);
1328 struct netdev_notify_work *nnw = kzalloc(sizeof(*nnw), GFP_ATOMIC);
1329
1330 if (!nnw)
1331 return;
1332
1333 dev_hold(slave->dev);
1334 nnw->dev = slave->dev;
1335 bond_fill_ifslave(slave, &nnw->bonding_info.slave);
1336 bond_fill_ifbond(bond, &nnw->bonding_info.master);
1337 INIT_DELAYED_WORK(&nnw->work, bond_netdev_notify_work);
1338
1339 queue_delayed_work(slave->bond->wq, &nnw->work, 0);
1340} 1342}
1341 1343
1342void bond_lower_state_changed(struct slave *slave) 1344void bond_lower_state_changed(struct slave *slave)
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index d93c790bfbe8..ad534b90ef21 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -1107,7 +1107,7 @@ void b53_vlan_add(struct dsa_switch *ds, int port,
1107 b53_get_vlan_entry(dev, vid, vl); 1107 b53_get_vlan_entry(dev, vid, vl);
1108 1108
1109 vl->members |= BIT(port); 1109 vl->members |= BIT(port);
1110 if (untagged) 1110 if (untagged && !dsa_is_cpu_port(ds, port))
1111 vl->untag |= BIT(port); 1111 vl->untag |= BIT(port);
1112 else 1112 else
1113 vl->untag &= ~BIT(port); 1113 vl->untag &= ~BIT(port);
@@ -1149,7 +1149,7 @@ int b53_vlan_del(struct dsa_switch *ds, int port,
1149 pvid = 0; 1149 pvid = 0;
1150 } 1150 }
1151 1151
1152 if (untagged) 1152 if (untagged && !dsa_is_cpu_port(ds, port))
1153 vl->untag &= ~(BIT(port)); 1153 vl->untag &= ~(BIT(port));
1154 1154
1155 b53_set_vlan_entry(dev, vid, vl); 1155 b53_set_vlan_entry(dev, vid, vl);
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index e0066adcd2f3..fc8b48adf38b 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -703,7 +703,6 @@ static int bcm_sf2_sw_suspend(struct dsa_switch *ds)
703static int bcm_sf2_sw_resume(struct dsa_switch *ds) 703static int bcm_sf2_sw_resume(struct dsa_switch *ds)
704{ 704{
705 struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds); 705 struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);
706 unsigned int port;
707 int ret; 706 int ret;
708 707
709 ret = bcm_sf2_sw_rst(priv); 708 ret = bcm_sf2_sw_rst(priv);
@@ -715,14 +714,7 @@ static int bcm_sf2_sw_resume(struct dsa_switch *ds)
715 if (priv->hw_params.num_gphy == 1) 714 if (priv->hw_params.num_gphy == 1)
716 bcm_sf2_gphy_enable_set(ds, true); 715 bcm_sf2_gphy_enable_set(ds, true);
717 716
718 for (port = 0; port < DSA_MAX_PORTS; port++) { 717 ds->ops->setup(ds);
719 if (dsa_is_user_port(ds, port))
720 bcm_sf2_port_setup(ds, port, NULL);
721 else if (dsa_is_cpu_port(ds, port))
722 bcm_sf2_imp_setup(ds, port);
723 }
724
725 bcm_sf2_enable_acb(ds);
726 718
727 return 0; 719 return 0;
728} 720}
@@ -1173,10 +1165,10 @@ static int bcm_sf2_sw_remove(struct platform_device *pdev)
1173{ 1165{
1174 struct bcm_sf2_priv *priv = platform_get_drvdata(pdev); 1166 struct bcm_sf2_priv *priv = platform_get_drvdata(pdev);
1175 1167
1176 /* Disable all ports and interrupts */
1177 priv->wol_ports_mask = 0; 1168 priv->wol_ports_mask = 0;
1178 bcm_sf2_sw_suspend(priv->dev->ds);
1179 dsa_unregister_switch(priv->dev->ds); 1169 dsa_unregister_switch(priv->dev->ds);
1170 /* Disable all ports and interrupts */
1171 bcm_sf2_sw_suspend(priv->dev->ds);
1180 bcm_sf2_mdio_unregister(priv); 1172 bcm_sf2_mdio_unregister(priv);
1181 1173
1182 return 0; 1174 return 0;
diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h
index 7c791c1da4b9..bef01331266f 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.h
+++ b/drivers/net/dsa/mv88e6xxx/global1.h
@@ -128,7 +128,7 @@
128#define MV88E6XXX_G1_ATU_OP_GET_CLR_VIOLATION 0x7000 128#define MV88E6XXX_G1_ATU_OP_GET_CLR_VIOLATION 0x7000
129#define MV88E6XXX_G1_ATU_OP_AGE_OUT_VIOLATION BIT(7) 129#define MV88E6XXX_G1_ATU_OP_AGE_OUT_VIOLATION BIT(7)
130#define MV88E6XXX_G1_ATU_OP_MEMBER_VIOLATION BIT(6) 130#define MV88E6XXX_G1_ATU_OP_MEMBER_VIOLATION BIT(6)
131#define MV88E6XXX_G1_ATU_OP_MISS_VIOLTATION BIT(5) 131#define MV88E6XXX_G1_ATU_OP_MISS_VIOLATION BIT(5)
132#define MV88E6XXX_G1_ATU_OP_FULL_VIOLATION BIT(4) 132#define MV88E6XXX_G1_ATU_OP_FULL_VIOLATION BIT(4)
133 133
134/* Offset 0x0C: ATU Data Register */ 134/* Offset 0x0C: ATU Data Register */
diff --git a/drivers/net/dsa/mv88e6xxx/global1_atu.c b/drivers/net/dsa/mv88e6xxx/global1_atu.c
index 307410898fc9..5200e4bdce93 100644
--- a/drivers/net/dsa/mv88e6xxx/global1_atu.c
+++ b/drivers/net/dsa/mv88e6xxx/global1_atu.c
@@ -349,7 +349,7 @@ static irqreturn_t mv88e6xxx_g1_atu_prob_irq_thread_fn(int irq, void *dev_id)
349 chip->ports[entry.portvec].atu_member_violation++; 349 chip->ports[entry.portvec].atu_member_violation++;
350 } 350 }
351 351
352 if (val & MV88E6XXX_G1_ATU_OP_MEMBER_VIOLATION) { 352 if (val & MV88E6XXX_G1_ATU_OP_MISS_VIOLATION) {
353 dev_err_ratelimited(chip->dev, 353 dev_err_ratelimited(chip->dev,
354 "ATU miss violation for %pM portvec %x\n", 354 "ATU miss violation for %pM portvec %x\n",
355 entry.mac, entry.portvec); 355 entry.mac, entry.portvec);
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 17f12c18d225..7635c38e77dd 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -459,12 +459,12 @@ static void ena_com_handle_admin_completion(struct ena_com_admin_queue *admin_qu
459 cqe = &admin_queue->cq.entries[head_masked]; 459 cqe = &admin_queue->cq.entries[head_masked];
460 460
461 /* Go over all the completions */ 461 /* Go over all the completions */
462 while ((cqe->acq_common_descriptor.flags & 462 while ((READ_ONCE(cqe->acq_common_descriptor.flags) &
463 ENA_ADMIN_ACQ_COMMON_DESC_PHASE_MASK) == phase) { 463 ENA_ADMIN_ACQ_COMMON_DESC_PHASE_MASK) == phase) {
464 /* Do not read the rest of the completion entry before the 464 /* Do not read the rest of the completion entry before the
465 * phase bit was validated 465 * phase bit was validated
466 */ 466 */
467 rmb(); 467 dma_rmb();
468 ena_com_handle_single_admin_completion(admin_queue, cqe); 468 ena_com_handle_single_admin_completion(admin_queue, cqe);
469 469
470 head_masked++; 470 head_masked++;
@@ -627,17 +627,10 @@ static u32 ena_com_reg_bar_read32(struct ena_com_dev *ena_dev, u16 offset)
627 mmio_read_reg |= mmio_read->seq_num & 627 mmio_read_reg |= mmio_read->seq_num &
628 ENA_REGS_MMIO_REG_READ_REQ_ID_MASK; 628 ENA_REGS_MMIO_REG_READ_REQ_ID_MASK;
629 629
630 /* make sure read_resp->req_id get updated before the hw can write 630 writel(mmio_read_reg, ena_dev->reg_bar + ENA_REGS_MMIO_REG_READ_OFF);
631 * there
632 */
633 wmb();
634
635 writel_relaxed(mmio_read_reg,
636 ena_dev->reg_bar + ENA_REGS_MMIO_REG_READ_OFF);
637 631
638 mmiowb();
639 for (i = 0; i < timeout; i++) { 632 for (i = 0; i < timeout; i++) {
640 if (read_resp->req_id == mmio_read->seq_num) 633 if (READ_ONCE(read_resp->req_id) == mmio_read->seq_num)
641 break; 634 break;
642 635
643 udelay(1); 636 udelay(1);
@@ -1796,8 +1789,13 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *dev, void *data)
1796 aenq_common = &aenq_e->aenq_common_desc; 1789 aenq_common = &aenq_e->aenq_common_desc;
1797 1790
1798 /* Go over all the events */ 1791 /* Go over all the events */
1799 while ((aenq_common->flags & ENA_ADMIN_AENQ_COMMON_DESC_PHASE_MASK) == 1792 while ((READ_ONCE(aenq_common->flags) &
1800 phase) { 1793 ENA_ADMIN_AENQ_COMMON_DESC_PHASE_MASK) == phase) {
1794 /* Make sure the phase bit (ownership) is as expected before
1795 * reading the rest of the descriptor.
1796 */
1797 dma_rmb();
1798
1801 pr_debug("AENQ! Group[%x] Syndrom[%x] timestamp: [%llus]\n", 1799 pr_debug("AENQ! Group[%x] Syndrom[%x] timestamp: [%llus]\n",
1802 aenq_common->group, aenq_common->syndrom, 1800 aenq_common->group, aenq_common->syndrom,
1803 (u64)aenq_common->timestamp_low + 1801 (u64)aenq_common->timestamp_low +
diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.c b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
index ea149c134e15..2b3ff0c20155 100644
--- a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
@@ -51,6 +51,11 @@ static inline struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc(
51 if (desc_phase != expected_phase) 51 if (desc_phase != expected_phase)
52 return NULL; 52 return NULL;
53 53
54 /* Make sure we read the rest of the descriptor after the phase bit
55 * has been read
56 */
57 dma_rmb();
58
54 return cdesc; 59 return cdesc;
55} 60}
56 61
@@ -240,11 +245,11 @@ static inline void ena_com_rx_set_flags(struct ena_com_rx_ctx *ena_rx_ctx,
240 (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_MASK) >> 245 (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_MASK) >>
241 ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_SHIFT; 246 ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_SHIFT;
242 ena_rx_ctx->l3_csum_err = 247 ena_rx_ctx->l3_csum_err =
243 (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_MASK) >> 248 !!((cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_MASK) >>
244 ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_SHIFT; 249 ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_SHIFT);
245 ena_rx_ctx->l4_csum_err = 250 ena_rx_ctx->l4_csum_err =
246 (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_MASK) >> 251 !!((cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_MASK) >>
247 ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_SHIFT; 252 ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_SHIFT);
248 ena_rx_ctx->hash = cdesc->hash; 253 ena_rx_ctx->hash = cdesc->hash;
249 ena_rx_ctx->frag = 254 ena_rx_ctx->frag =
250 (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_IPV4_FRAG_MASK) >> 255 (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_IPV4_FRAG_MASK) >>
@@ -493,6 +498,7 @@ int ena_com_tx_comp_req_id_get(struct ena_com_io_cq *io_cq, u16 *req_id)
493 if (cdesc_phase != expected_phase) 498 if (cdesc_phase != expected_phase)
494 return -EAGAIN; 499 return -EAGAIN;
495 500
501 dma_rmb();
496 if (unlikely(cdesc->req_id >= io_cq->q_depth)) { 502 if (unlikely(cdesc->req_id >= io_cq->q_depth)) {
497 pr_err("Invalid req id %d\n", cdesc->req_id); 503 pr_err("Invalid req id %d\n", cdesc->req_id);
498 return -EINVAL; 504 return -EINVAL;
diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.h b/drivers/net/ethernet/amazon/ena/ena_eth_com.h
index 6fdc753d9483..2f7657227cfe 100644
--- a/drivers/net/ethernet/amazon/ena/ena_eth_com.h
+++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.h
@@ -107,8 +107,7 @@ static inline int ena_com_sq_empty_space(struct ena_com_io_sq *io_sq)
107 return io_sq->q_depth - 1 - cnt; 107 return io_sq->q_depth - 1 - cnt;
108} 108}
109 109
110static inline int ena_com_write_sq_doorbell(struct ena_com_io_sq *io_sq, 110static inline int ena_com_write_sq_doorbell(struct ena_com_io_sq *io_sq)
111 bool relaxed)
112{ 111{
113 u16 tail; 112 u16 tail;
114 113
@@ -117,10 +116,7 @@ static inline int ena_com_write_sq_doorbell(struct ena_com_io_sq *io_sq,
117 pr_debug("write submission queue doorbell for queue: %d tail: %d\n", 116 pr_debug("write submission queue doorbell for queue: %d tail: %d\n",
118 io_sq->qid, tail); 117 io_sq->qid, tail);
119 118
120 if (relaxed) 119 writel(tail, io_sq->db_addr);
121 writel_relaxed(tail, io_sq->db_addr);
122 else
123 writel(tail, io_sq->db_addr);
124 120
125 return 0; 121 return 0;
126} 122}
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index c673ac2df65b..d906293ce07d 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -76,7 +76,7 @@ MODULE_DEVICE_TABLE(pci, ena_pci_tbl);
76 76
77static int ena_rss_init_default(struct ena_adapter *adapter); 77static int ena_rss_init_default(struct ena_adapter *adapter);
78static void check_for_admin_com_state(struct ena_adapter *adapter); 78static void check_for_admin_com_state(struct ena_adapter *adapter);
79static void ena_destroy_device(struct ena_adapter *adapter); 79static void ena_destroy_device(struct ena_adapter *adapter, bool graceful);
80static int ena_restore_device(struct ena_adapter *adapter); 80static int ena_restore_device(struct ena_adapter *adapter);
81 81
82static void ena_tx_timeout(struct net_device *dev) 82static void ena_tx_timeout(struct net_device *dev)
@@ -461,7 +461,7 @@ static inline int ena_alloc_rx_page(struct ena_ring *rx_ring,
461 return -ENOMEM; 461 return -ENOMEM;
462 } 462 }
463 463
464 dma = dma_map_page(rx_ring->dev, page, 0, PAGE_SIZE, 464 dma = dma_map_page(rx_ring->dev, page, 0, ENA_PAGE_SIZE,
465 DMA_FROM_DEVICE); 465 DMA_FROM_DEVICE);
466 if (unlikely(dma_mapping_error(rx_ring->dev, dma))) { 466 if (unlikely(dma_mapping_error(rx_ring->dev, dma))) {
467 u64_stats_update_begin(&rx_ring->syncp); 467 u64_stats_update_begin(&rx_ring->syncp);
@@ -478,7 +478,7 @@ static inline int ena_alloc_rx_page(struct ena_ring *rx_ring,
478 rx_info->page_offset = 0; 478 rx_info->page_offset = 0;
479 ena_buf = &rx_info->ena_buf; 479 ena_buf = &rx_info->ena_buf;
480 ena_buf->paddr = dma; 480 ena_buf->paddr = dma;
481 ena_buf->len = PAGE_SIZE; 481 ena_buf->len = ENA_PAGE_SIZE;
482 482
483 return 0; 483 return 0;
484} 484}
@@ -495,7 +495,7 @@ static void ena_free_rx_page(struct ena_ring *rx_ring,
495 return; 495 return;
496 } 496 }
497 497
498 dma_unmap_page(rx_ring->dev, ena_buf->paddr, PAGE_SIZE, 498 dma_unmap_page(rx_ring->dev, ena_buf->paddr, ENA_PAGE_SIZE,
499 DMA_FROM_DEVICE); 499 DMA_FROM_DEVICE);
500 500
501 __free_page(page); 501 __free_page(page);
@@ -551,14 +551,9 @@ static int ena_refill_rx_bufs(struct ena_ring *rx_ring, u32 num)
551 rx_ring->qid, i, num); 551 rx_ring->qid, i, num);
552 } 552 }
553 553
554 if (likely(i)) { 554 /* ena_com_write_sq_doorbell issues a wmb() */
555 /* Add memory barrier to make sure the desc were written before 555 if (likely(i))
556 * issue a doorbell 556 ena_com_write_sq_doorbell(rx_ring->ena_com_io_sq);
557 */
558 wmb();
559 ena_com_write_sq_doorbell(rx_ring->ena_com_io_sq, true);
560 mmiowb();
561 }
562 557
563 rx_ring->next_to_use = next_to_use; 558 rx_ring->next_to_use = next_to_use;
564 559
@@ -916,10 +911,10 @@ static struct sk_buff *ena_rx_skb(struct ena_ring *rx_ring,
916 do { 911 do {
917 dma_unmap_page(rx_ring->dev, 912 dma_unmap_page(rx_ring->dev,
918 dma_unmap_addr(&rx_info->ena_buf, paddr), 913 dma_unmap_addr(&rx_info->ena_buf, paddr),
919 PAGE_SIZE, DMA_FROM_DEVICE); 914 ENA_PAGE_SIZE, DMA_FROM_DEVICE);
920 915
921 skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, rx_info->page, 916 skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, rx_info->page,
922 rx_info->page_offset, len, PAGE_SIZE); 917 rx_info->page_offset, len, ENA_PAGE_SIZE);
923 918
924 netif_dbg(rx_ring->adapter, rx_status, rx_ring->netdev, 919 netif_dbg(rx_ring->adapter, rx_status, rx_ring->netdev,
925 "rx skb updated. len %d. data_len %d\n", 920 "rx skb updated. len %d. data_len %d\n",
@@ -1580,8 +1575,6 @@ static int ena_up_complete(struct ena_adapter *adapter)
1580 if (rc) 1575 if (rc)
1581 return rc; 1576 return rc;
1582 1577
1583 ena_init_napi(adapter);
1584
1585 ena_change_mtu(adapter->netdev, adapter->netdev->mtu); 1578 ena_change_mtu(adapter->netdev, adapter->netdev->mtu);
1586 1579
1587 ena_refill_all_rx_bufs(adapter); 1580 ena_refill_all_rx_bufs(adapter);
@@ -1735,6 +1728,13 @@ static int ena_up(struct ena_adapter *adapter)
1735 1728
1736 ena_setup_io_intr(adapter); 1729 ena_setup_io_intr(adapter);
1737 1730
1731 /* napi poll functions should be initialized before running
1732 * request_irq(), to handle a rare condition where there is a pending
1733 * interrupt, causing the ISR to fire immediately while the poll
1734 * function wasn't set yet, causing a null dereference
1735 */
1736 ena_init_napi(adapter);
1737
1738 rc = ena_request_io_irq(adapter); 1738 rc = ena_request_io_irq(adapter);
1739 if (rc) 1739 if (rc)
1740 goto err_req_irq; 1740 goto err_req_irq;
@@ -1900,7 +1900,7 @@ static int ena_close(struct net_device *netdev)
1900 "Destroy failure, restarting device\n"); 1900 "Destroy failure, restarting device\n");
1901 ena_dump_stats_to_dmesg(adapter); 1901 ena_dump_stats_to_dmesg(adapter);
1902 /* rtnl lock already obtained in dev_ioctl() layer */ 1902 /* rtnl lock already obtained in dev_ioctl() layer */
1903 ena_destroy_device(adapter); 1903 ena_destroy_device(adapter, false);
1904 ena_restore_device(adapter); 1904 ena_restore_device(adapter);
1905 } 1905 }
1906 1906
@@ -2112,12 +2112,6 @@ static netdev_tx_t ena_start_xmit(struct sk_buff *skb, struct net_device *dev)
2112 tx_ring->next_to_use = ENA_TX_RING_IDX_NEXT(next_to_use, 2112 tx_ring->next_to_use = ENA_TX_RING_IDX_NEXT(next_to_use,
2113 tx_ring->ring_size); 2113 tx_ring->ring_size);
2114 2114
2115 /* This WMB is aimed to:
2116 * 1 - perform smp barrier before reading next_to_completion
2117 * 2 - make sure the desc were written before trigger DB
2118 */
2119 wmb();
2120
2121 /* stop the queue when no more space available, the packet can have up 2115 /* stop the queue when no more space available, the packet can have up
2122 * to sgl_size + 2. one for the meta descriptor and one for header 2116 * to sgl_size + 2. one for the meta descriptor and one for header
2123 * (if the header is larger than tx_max_header_size). 2117 * (if the header is larger than tx_max_header_size).
@@ -2136,10 +2130,11 @@ static netdev_tx_t ena_start_xmit(struct sk_buff *skb, struct net_device *dev)
2136 * stop the queue but meanwhile clean_tx_irq updates 2130 * stop the queue but meanwhile clean_tx_irq updates
2137 * next_to_completion and terminates. 2131 * next_to_completion and terminates.
2138 * The queue will remain stopped forever. 2132 * The queue will remain stopped forever.
2139 * To solve this issue this function perform rmb, check 2133 * To solve this issue add a mb() to make sure that
2140 * the wakeup condition and wake up the queue if needed. 2134 * netif_tx_stop_queue() write is vissible before checking if
2135 * there is additional space in the queue.
2141 */ 2136 */
2142 smp_rmb(); 2137 smp_mb();
2143 2138
2144 if (ena_com_sq_empty_space(tx_ring->ena_com_io_sq) 2139 if (ena_com_sq_empty_space(tx_ring->ena_com_io_sq)
2145 > ENA_TX_WAKEUP_THRESH) { 2140 > ENA_TX_WAKEUP_THRESH) {
@@ -2151,8 +2146,10 @@ static netdev_tx_t ena_start_xmit(struct sk_buff *skb, struct net_device *dev)
2151 } 2146 }
2152 2147
2153 if (netif_xmit_stopped(txq) || !skb->xmit_more) { 2148 if (netif_xmit_stopped(txq) || !skb->xmit_more) {
2154 /* trigger the dma engine */ 2149 /* trigger the dma engine. ena_com_write_sq_doorbell()
2155 ena_com_write_sq_doorbell(tx_ring->ena_com_io_sq, false); 2150 * has a mb
2151 */
2152 ena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);
2156 u64_stats_update_begin(&tx_ring->syncp); 2153 u64_stats_update_begin(&tx_ring->syncp);
2157 tx_ring->tx_stats.doorbells++; 2154 tx_ring->tx_stats.doorbells++;
2158 u64_stats_update_end(&tx_ring->syncp); 2155 u64_stats_update_end(&tx_ring->syncp);
@@ -2193,25 +2190,6 @@ error_drop_packet:
2193 return NETDEV_TX_OK; 2190 return NETDEV_TX_OK;
2194} 2191}
2195 2192
2196#ifdef CONFIG_NET_POLL_CONTROLLER
2197static void ena_netpoll(struct net_device *netdev)
2198{
2199 struct ena_adapter *adapter = netdev_priv(netdev);
2200 int i;
2201
2202 /* Dont schedule NAPI if the driver is in the middle of reset
2203 * or netdev is down.
2204 */
2205
2206 if (!test_bit(ENA_FLAG_DEV_UP, &adapter->flags) ||
2207 test_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags))
2208 return;
2209
2210 for (i = 0; i < adapter->num_queues; i++)
2211 napi_schedule(&adapter->ena_napi[i].napi);
2212}
2213#endif /* CONFIG_NET_POLL_CONTROLLER */
2214
2215static u16 ena_select_queue(struct net_device *dev, struct sk_buff *skb, 2193static u16 ena_select_queue(struct net_device *dev, struct sk_buff *skb,
2216 struct net_device *sb_dev, 2194 struct net_device *sb_dev,
2217 select_queue_fallback_t fallback) 2195 select_queue_fallback_t fallback)
@@ -2377,9 +2355,6 @@ static const struct net_device_ops ena_netdev_ops = {
2377 .ndo_change_mtu = ena_change_mtu, 2355 .ndo_change_mtu = ena_change_mtu,
2378 .ndo_set_mac_address = NULL, 2356 .ndo_set_mac_address = NULL,
2379 .ndo_validate_addr = eth_validate_addr, 2357 .ndo_validate_addr = eth_validate_addr,
2380#ifdef CONFIG_NET_POLL_CONTROLLER
2381 .ndo_poll_controller = ena_netpoll,
2382#endif /* CONFIG_NET_POLL_CONTROLLER */
2383}; 2358};
2384 2359
2385static int ena_device_validate_params(struct ena_adapter *adapter, 2360static int ena_device_validate_params(struct ena_adapter *adapter,
@@ -2550,12 +2525,15 @@ err_disable_msix:
2550 return rc; 2525 return rc;
2551} 2526}
2552 2527
2553static void ena_destroy_device(struct ena_adapter *adapter) 2528static void ena_destroy_device(struct ena_adapter *adapter, bool graceful)
2554{ 2529{
2555 struct net_device *netdev = adapter->netdev; 2530 struct net_device *netdev = adapter->netdev;
2556 struct ena_com_dev *ena_dev = adapter->ena_dev; 2531 struct ena_com_dev *ena_dev = adapter->ena_dev;
2557 bool dev_up; 2532 bool dev_up;
2558 2533
2534 if (!test_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags))
2535 return;
2536
2559 netif_carrier_off(netdev); 2537 netif_carrier_off(netdev);
2560 2538
2561 del_timer_sync(&adapter->timer_service); 2539 del_timer_sync(&adapter->timer_service);
@@ -2563,7 +2541,8 @@ static void ena_destroy_device(struct ena_adapter *adapter)
2563 dev_up = test_bit(ENA_FLAG_DEV_UP, &adapter->flags); 2541 dev_up = test_bit(ENA_FLAG_DEV_UP, &adapter->flags);
2564 adapter->dev_up_before_reset = dev_up; 2542 adapter->dev_up_before_reset = dev_up;
2565 2543
2566 ena_com_set_admin_running_state(ena_dev, false); 2544 if (!graceful)
2545 ena_com_set_admin_running_state(ena_dev, false);
2567 2546
2568 if (test_bit(ENA_FLAG_DEV_UP, &adapter->flags)) 2547 if (test_bit(ENA_FLAG_DEV_UP, &adapter->flags))
2569 ena_down(adapter); 2548 ena_down(adapter);
@@ -2591,6 +2570,7 @@ static void ena_destroy_device(struct ena_adapter *adapter)
2591 adapter->reset_reason = ENA_REGS_RESET_NORMAL; 2570 adapter->reset_reason = ENA_REGS_RESET_NORMAL;
2592 2571
2593 clear_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags); 2572 clear_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags);
2573 clear_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);
2594} 2574}
2595 2575
2596static int ena_restore_device(struct ena_adapter *adapter) 2576static int ena_restore_device(struct ena_adapter *adapter)
@@ -2635,6 +2615,7 @@ static int ena_restore_device(struct ena_adapter *adapter)
2635 } 2615 }
2636 } 2616 }
2637 2617
2618 set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);
2638 mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ)); 2619 mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ));
2639 dev_err(&pdev->dev, "Device reset completed successfully\n"); 2620 dev_err(&pdev->dev, "Device reset completed successfully\n");
2640 2621
@@ -2643,7 +2624,11 @@ err_disable_msix:
2643 ena_free_mgmnt_irq(adapter); 2624 ena_free_mgmnt_irq(adapter);
2644 ena_disable_msix(adapter); 2625 ena_disable_msix(adapter);
2645err_device_destroy: 2626err_device_destroy:
2627 ena_com_abort_admin_commands(ena_dev);
2628 ena_com_wait_for_abort_completion(ena_dev);
2646 ena_com_admin_destroy(ena_dev); 2629 ena_com_admin_destroy(ena_dev);
2630 ena_com_mmio_reg_read_request_destroy(ena_dev);
2631 ena_com_dev_reset(ena_dev, ENA_REGS_RESET_DRIVER_INVALID_STATE);
2647err: 2632err:
2648 clear_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags); 2633 clear_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);
2649 clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags); 2634 clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags);
@@ -2665,7 +2650,7 @@ static void ena_fw_reset_device(struct work_struct *work)
2665 return; 2650 return;
2666 } 2651 }
2667 rtnl_lock(); 2652 rtnl_lock();
2668 ena_destroy_device(adapter); 2653 ena_destroy_device(adapter, false);
2669 ena_restore_device(adapter); 2654 ena_restore_device(adapter);
2670 rtnl_unlock(); 2655 rtnl_unlock();
2671} 2656}
@@ -3123,15 +3108,8 @@ err_rss_init:
3123 3108
3124static void ena_release_bars(struct ena_com_dev *ena_dev, struct pci_dev *pdev) 3109static void ena_release_bars(struct ena_com_dev *ena_dev, struct pci_dev *pdev)
3125{ 3110{
3126 int release_bars; 3111 int release_bars = pci_select_bars(pdev, IORESOURCE_MEM) & ENA_BAR_MASK;
3127 3112
3128 if (ena_dev->mem_bar)
3129 devm_iounmap(&pdev->dev, ena_dev->mem_bar);
3130
3131 if (ena_dev->reg_bar)
3132 devm_iounmap(&pdev->dev, ena_dev->reg_bar);
3133
3134 release_bars = pci_select_bars(pdev, IORESOURCE_MEM) & ENA_BAR_MASK;
3135 pci_release_selected_regions(pdev, release_bars); 3113 pci_release_selected_regions(pdev, release_bars);
3136} 3114}
3137 3115
@@ -3409,30 +3387,24 @@ static void ena_remove(struct pci_dev *pdev)
3409 netdev->rx_cpu_rmap = NULL; 3387 netdev->rx_cpu_rmap = NULL;
3410 } 3388 }
3411#endif /* CONFIG_RFS_ACCEL */ 3389#endif /* CONFIG_RFS_ACCEL */
3412
3413 unregister_netdev(netdev);
3414 del_timer_sync(&adapter->timer_service); 3390 del_timer_sync(&adapter->timer_service);
3415 3391
3416 cancel_work_sync(&adapter->reset_task); 3392 cancel_work_sync(&adapter->reset_task);
3417 3393
3418 /* Reset the device only if the device is running. */ 3394 unregister_netdev(netdev);
3419 if (test_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags))
3420 ena_com_dev_reset(ena_dev, adapter->reset_reason);
3421 3395
3422 ena_free_mgmnt_irq(adapter); 3396 /* If the device is running then we want to make sure the device will be
3397 * reset to make sure no more events will be issued by the device.
3398 */
3399 if (test_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags))
3400 set_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags);
3423 3401
3424 ena_disable_msix(adapter); 3402 rtnl_lock();
3403 ena_destroy_device(adapter, true);
3404 rtnl_unlock();
3425 3405
3426 free_netdev(netdev); 3406 free_netdev(netdev);
3427 3407
3428 ena_com_mmio_reg_read_request_destroy(ena_dev);
3429
3430 ena_com_abort_admin_commands(ena_dev);
3431
3432 ena_com_wait_for_abort_completion(ena_dev);
3433
3434 ena_com_admin_destroy(ena_dev);
3435
3436 ena_com_rss_destroy(ena_dev); 3408 ena_com_rss_destroy(ena_dev);
3437 3409
3438 ena_com_delete_debug_area(ena_dev); 3410 ena_com_delete_debug_area(ena_dev);
@@ -3467,7 +3439,7 @@ static int ena_suspend(struct pci_dev *pdev, pm_message_t state)
3467 "ignoring device reset request as the device is being suspended\n"); 3439 "ignoring device reset request as the device is being suspended\n");
3468 clear_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags); 3440 clear_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags);
3469 } 3441 }
3470 ena_destroy_device(adapter); 3442 ena_destroy_device(adapter, true);
3471 rtnl_unlock(); 3443 rtnl_unlock();
3472 return 0; 3444 return 0;
3473} 3445}
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h
index f1972b5ab650..7c7ae56c52cf 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
@@ -355,4 +355,15 @@ void ena_dump_stats_to_buf(struct ena_adapter *adapter, u8 *buf);
355 355
356int ena_get_sset_count(struct net_device *netdev, int sset); 356int ena_get_sset_count(struct net_device *netdev, int sset);
357 357
358/* The ENA buffer length fields is 16 bit long. So when PAGE_SIZE == 64kB the
359 * driver passas 0.
360 * Since the max packet size the ENA handles is ~9kB limit the buffer length to
361 * 16kB.
362 */
363#if PAGE_SIZE > SZ_16K
364#define ENA_PAGE_SIZE SZ_16K
365#else
366#define ENA_PAGE_SIZE PAGE_SIZE
367#endif
368
358#endif /* !(ENA_H) */ 369#endif /* !(ENA_H) */
diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 116997a8b593..00332a1ea84b 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c
@@ -1031,6 +1031,7 @@ static int dec_lance_probe(struct device *bdev, const int type)
1031 int i, ret; 1031 int i, ret;
1032 unsigned long esar_base; 1032 unsigned long esar_base;
1033 unsigned char *esar; 1033 unsigned char *esar;
1034 const char *desc;
1034 1035
1035 if (dec_lance_debug && version_printed++ == 0) 1036 if (dec_lance_debug && version_printed++ == 0)
1036 printk(version); 1037 printk(version);
@@ -1216,19 +1217,20 @@ static int dec_lance_probe(struct device *bdev, const int type)
1216 */ 1217 */
1217 switch (type) { 1218 switch (type) {
1218 case ASIC_LANCE: 1219 case ASIC_LANCE:
1219 printk("%s: IOASIC onboard LANCE", name); 1220 desc = "IOASIC onboard LANCE";
1220 break; 1221 break;
1221 case PMAD_LANCE: 1222 case PMAD_LANCE:
1222 printk("%s: PMAD-AA", name); 1223 desc = "PMAD-AA";
1223 break; 1224 break;
1224 case PMAX_LANCE: 1225 case PMAX_LANCE:
1225 printk("%s: PMAX onboard LANCE", name); 1226 desc = "PMAX onboard LANCE";
1226 break; 1227 break;
1227 } 1228 }
1228 for (i = 0; i < 6; i++) 1229 for (i = 0; i < 6; i++)
1229 dev->dev_addr[i] = esar[i * 4]; 1230 dev->dev_addr[i] = esar[i * 4];
1230 1231
1231 printk(", addr = %pM, irq = %d\n", dev->dev_addr, dev->irq); 1232 printk("%s: %s, addr = %pM, irq = %d\n",
1233 name, desc, dev->dev_addr, dev->irq);
1232 1234
1233 dev->netdev_ops = &lance_netdev_ops; 1235 dev->netdev_ops = &lance_netdev_ops;
1234 dev->watchdog_timeo = 5*HZ; 1236 dev->watchdog_timeo = 5*HZ;
diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c
index 024998d6d8c6..6a8e2567f2bd 100644
--- a/drivers/net/ethernet/apple/bmac.c
+++ b/drivers/net/ethernet/apple/bmac.c
@@ -154,7 +154,7 @@ static irqreturn_t bmac_txdma_intr(int irq, void *dev_id);
154static irqreturn_t bmac_rxdma_intr(int irq, void *dev_id); 154static irqreturn_t bmac_rxdma_intr(int irq, void *dev_id);
155static void bmac_set_timeout(struct net_device *dev); 155static void bmac_set_timeout(struct net_device *dev);
156static void bmac_tx_timeout(struct timer_list *t); 156static void bmac_tx_timeout(struct timer_list *t);
157static int bmac_output(struct sk_buff *skb, struct net_device *dev); 157static netdev_tx_t bmac_output(struct sk_buff *skb, struct net_device *dev);
158static void bmac_start(struct net_device *dev); 158static void bmac_start(struct net_device *dev);
159 159
160#define DBDMA_SET(x) ( ((x) | (x) << 16) ) 160#define DBDMA_SET(x) ( ((x) | (x) << 16) )
@@ -1456,7 +1456,7 @@ bmac_start(struct net_device *dev)
1456 spin_unlock_irqrestore(&bp->lock, flags); 1456 spin_unlock_irqrestore(&bp->lock, flags);
1457} 1457}
1458 1458
1459static int 1459static netdev_tx_t
1460bmac_output(struct sk_buff *skb, struct net_device *dev) 1460bmac_output(struct sk_buff *skb, struct net_device *dev)
1461{ 1461{
1462 struct bmac_data *bp = netdev_priv(dev); 1462 struct bmac_data *bp = netdev_priv(dev);
diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c
index 0b5429d76bcf..68b9ee489489 100644
--- a/drivers/net/ethernet/apple/mace.c
+++ b/drivers/net/ethernet/apple/mace.c
@@ -78,7 +78,7 @@ struct mace_data {
78 78
79static int mace_open(struct net_device *dev); 79static int mace_open(struct net_device *dev);
80static int mace_close(struct net_device *dev); 80static int mace_close(struct net_device *dev);
81static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev); 81static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev);
82static void mace_set_multicast(struct net_device *dev); 82static void mace_set_multicast(struct net_device *dev);
83static void mace_reset(struct net_device *dev); 83static void mace_reset(struct net_device *dev);
84static int mace_set_address(struct net_device *dev, void *addr); 84static int mace_set_address(struct net_device *dev, void *addr);
@@ -525,7 +525,7 @@ static inline void mace_set_timeout(struct net_device *dev)
525 mp->timeout_active = 1; 525 mp->timeout_active = 1;
526} 526}
527 527
528static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev) 528static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev)
529{ 529{
530 struct mace_data *mp = netdev_priv(dev); 530 struct mace_data *mp = netdev_priv(dev);
531 volatile struct dbdma_regs __iomem *td = mp->tx_dma; 531 volatile struct dbdma_regs __iomem *td = mp->tx_dma;
diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c
index 137cbb470af2..376f2c2613e7 100644
--- a/drivers/net/ethernet/apple/macmace.c
+++ b/drivers/net/ethernet/apple/macmace.c
@@ -89,7 +89,7 @@ struct mace_frame {
89 89
90static int mace_open(struct net_device *dev); 90static int mace_open(struct net_device *dev);
91static int mace_close(struct net_device *dev); 91static int mace_close(struct net_device *dev);
92static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev); 92static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev);
93static void mace_set_multicast(struct net_device *dev); 93static void mace_set_multicast(struct net_device *dev);
94static int mace_set_address(struct net_device *dev, void *addr); 94static int mace_set_address(struct net_device *dev, void *addr);
95static void mace_reset(struct net_device *dev); 95static void mace_reset(struct net_device *dev);
@@ -444,7 +444,7 @@ static int mace_close(struct net_device *dev)
444 * Transmit a frame 444 * Transmit a frame
445 */ 445 */
446 446
447static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev) 447static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev)
448{ 448{
449 struct mace_data *mp = netdev_priv(dev); 449 struct mace_data *mp = netdev_priv(dev);
450 unsigned long flags; 450 unsigned long flags;
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index b5f1f62e8e25..d1e1a0ba8615 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -225,9 +225,10 @@ int aq_ring_rx_clean(struct aq_ring_s *self,
225 } 225 }
226 226
227 /* for single fragment packets use build_skb() */ 227 /* for single fragment packets use build_skb() */
228 if (buff->is_eop) { 228 if (buff->is_eop &&
229 buff->len <= AQ_CFG_RX_FRAME_MAX - AQ_SKB_ALIGN) {
229 skb = build_skb(page_address(buff->page), 230 skb = build_skb(page_address(buff->page),
230 buff->len + AQ_SKB_ALIGN); 231 AQ_CFG_RX_FRAME_MAX);
231 if (unlikely(!skb)) { 232 if (unlikely(!skb)) {
232 err = -ENOMEM; 233 err = -ENOMEM;
233 goto err_exit; 234 goto err_exit;
@@ -247,18 +248,21 @@ int aq_ring_rx_clean(struct aq_ring_s *self,
247 buff->len - ETH_HLEN, 248 buff->len - ETH_HLEN,
248 SKB_TRUESIZE(buff->len - ETH_HLEN)); 249 SKB_TRUESIZE(buff->len - ETH_HLEN));
249 250
250 for (i = 1U, next_ = buff->next, 251 if (!buff->is_eop) {
251 buff_ = &self->buff_ring[next_]; true; 252 for (i = 1U, next_ = buff->next,
252 next_ = buff_->next, 253 buff_ = &self->buff_ring[next_];
253 buff_ = &self->buff_ring[next_], ++i) { 254 true; next_ = buff_->next,
254 skb_add_rx_frag(skb, i, buff_->page, 0, 255 buff_ = &self->buff_ring[next_], ++i) {
255 buff_->len, 256 skb_add_rx_frag(skb, i,
256 SKB_TRUESIZE(buff->len - 257 buff_->page, 0,
257 ETH_HLEN)); 258 buff_->len,
258 buff_->is_cleaned = 1; 259 SKB_TRUESIZE(buff->len -
259 260 ETH_HLEN));
260 if (buff_->is_eop) 261 buff_->is_cleaned = 1;
261 break; 262
263 if (buff_->is_eop)
264 break;
265 }
262 } 266 }
263 } 267 }
264 268
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 147045757b10..c57238fce863 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1069,9 +1069,6 @@ static void bcm_sysport_resume_from_wol(struct bcm_sysport_priv *priv)
1069{ 1069{
1070 u32 reg; 1070 u32 reg;
1071 1071
1072 /* Stop monitoring MPD interrupt */
1073 intrl2_0_mask_set(priv, INTRL2_0_MPD | INTRL2_0_BRCM_MATCH_TAG);
1074
1075 /* Disable RXCHK, active filters and Broadcom tag matching */ 1072 /* Disable RXCHK, active filters and Broadcom tag matching */
1076 reg = rxchk_readl(priv, RXCHK_CONTROL); 1073 reg = rxchk_readl(priv, RXCHK_CONTROL);
1077 reg &= ~(RXCHK_BRCM_TAG_MATCH_MASK << 1074 reg &= ~(RXCHK_BRCM_TAG_MATCH_MASK <<
@@ -1081,6 +1078,17 @@ static void bcm_sysport_resume_from_wol(struct bcm_sysport_priv *priv)
1081 /* Clear the MagicPacket detection logic */ 1078 /* Clear the MagicPacket detection logic */
1082 mpd_enable_set(priv, false); 1079 mpd_enable_set(priv, false);
1083 1080
1081 reg = intrl2_0_readl(priv, INTRL2_CPU_STATUS);
1082 if (reg & INTRL2_0_MPD)
1083 netdev_info(priv->netdev, "Wake-on-LAN (MPD) interrupt!\n");
1084
1085 if (reg & INTRL2_0_BRCM_MATCH_TAG) {
1086 reg = rxchk_readl(priv, RXCHK_BRCM_TAG_MATCH_STATUS) &
1087 RXCHK_BRCM_TAG_MATCH_MASK;
1088 netdev_info(priv->netdev,
1089 "Wake-on-LAN (filters 0x%02x) interrupt!\n", reg);
1090 }
1091
1084 netif_dbg(priv, wol, priv->netdev, "resumed from WOL\n"); 1092 netif_dbg(priv, wol, priv->netdev, "resumed from WOL\n");
1085} 1093}
1086 1094
@@ -1105,7 +1113,6 @@ static irqreturn_t bcm_sysport_rx_isr(int irq, void *dev_id)
1105 struct bcm_sysport_priv *priv = netdev_priv(dev); 1113 struct bcm_sysport_priv *priv = netdev_priv(dev);
1106 struct bcm_sysport_tx_ring *txr; 1114 struct bcm_sysport_tx_ring *txr;
1107 unsigned int ring, ring_bit; 1115 unsigned int ring, ring_bit;
1108 u32 reg;
1109 1116
1110 priv->irq0_stat = intrl2_0_readl(priv, INTRL2_CPU_STATUS) & 1117 priv->irq0_stat = intrl2_0_readl(priv, INTRL2_CPU_STATUS) &
1111 ~intrl2_0_readl(priv, INTRL2_CPU_MASK_STATUS); 1118 ~intrl2_0_readl(priv, INTRL2_CPU_MASK_STATUS);
@@ -1131,16 +1138,6 @@ static irqreturn_t bcm_sysport_rx_isr(int irq, void *dev_id)
1131 if (priv->irq0_stat & INTRL2_0_TX_RING_FULL) 1138 if (priv->irq0_stat & INTRL2_0_TX_RING_FULL)
1132 bcm_sysport_tx_reclaim_all(priv); 1139 bcm_sysport_tx_reclaim_all(priv);
1133 1140
1134 if (priv->irq0_stat & INTRL2_0_MPD)
1135 netdev_info(priv->netdev, "Wake-on-LAN (MPD) interrupt!\n");
1136
1137 if (priv->irq0_stat & INTRL2_0_BRCM_MATCH_TAG) {
1138 reg = rxchk_readl(priv, RXCHK_BRCM_TAG_MATCH_STATUS) &
1139 RXCHK_BRCM_TAG_MATCH_MASK;
1140 netdev_info(priv->netdev,
1141 "Wake-on-LAN (filters 0x%02x) interrupt!\n", reg);
1142 }
1143
1144 if (!priv->is_lite) 1141 if (!priv->is_lite)
1145 goto out; 1142 goto out;
1146 1143
@@ -2641,9 +2638,6 @@ static int bcm_sysport_suspend_to_wol(struct bcm_sysport_priv *priv)
2641 /* UniMAC receive needs to be turned on */ 2638 /* UniMAC receive needs to be turned on */
2642 umac_enable_set(priv, CMD_RX_EN, 1); 2639 umac_enable_set(priv, CMD_RX_EN, 1);
2643 2640
2644 /* Enable the interrupt wake-up source */
2645 intrl2_0_mask_clear(priv, INTRL2_0_MPD | INTRL2_0_BRCM_MATCH_TAG);
2646
2647 netif_dbg(priv, wol, ndev, "entered WOL mode\n"); 2641 netif_dbg(priv, wol, ndev, "entered WOL mode\n");
2648 2642
2649 return 0; 2643 return 0;
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 71362b7f6040..fcc2328bb0d9 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -12894,19 +12894,6 @@ static int bnx2x_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
12894 } 12894 }
12895} 12895}
12896 12896
12897#ifdef CONFIG_NET_POLL_CONTROLLER
12898static void poll_bnx2x(struct net_device *dev)
12899{
12900 struct bnx2x *bp = netdev_priv(dev);
12901 int i;
12902
12903 for_each_eth_queue(bp, i) {
12904 struct bnx2x_fastpath *fp = &bp->fp[i];
12905 napi_schedule(&bnx2x_fp(bp, fp->index, napi));
12906 }
12907}
12908#endif
12909
12910static int bnx2x_validate_addr(struct net_device *dev) 12897static int bnx2x_validate_addr(struct net_device *dev)
12911{ 12898{
12912 struct bnx2x *bp = netdev_priv(dev); 12899 struct bnx2x *bp = netdev_priv(dev);
@@ -13113,9 +13100,6 @@ static const struct net_device_ops bnx2x_netdev_ops = {
13113 .ndo_tx_timeout = bnx2x_tx_timeout, 13100 .ndo_tx_timeout = bnx2x_tx_timeout,
13114 .ndo_vlan_rx_add_vid = bnx2x_vlan_rx_add_vid, 13101 .ndo_vlan_rx_add_vid = bnx2x_vlan_rx_add_vid,
13115 .ndo_vlan_rx_kill_vid = bnx2x_vlan_rx_kill_vid, 13102 .ndo_vlan_rx_kill_vid = bnx2x_vlan_rx_kill_vid,
13116#ifdef CONFIG_NET_POLL_CONTROLLER
13117 .ndo_poll_controller = poll_bnx2x,
13118#endif
13119 .ndo_setup_tc = __bnx2x_setup_tc, 13103 .ndo_setup_tc = __bnx2x_setup_tc,
13120#ifdef CONFIG_BNX2X_SRIOV 13104#ifdef CONFIG_BNX2X_SRIOV
13121 .ndo_set_vf_mac = bnx2x_set_vf_mac, 13105 .ndo_set_vf_mac = bnx2x_set_vf_mac,
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index cecbb1d1f587..e2d92548226a 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -1884,8 +1884,11 @@ static int bnxt_poll_work(struct bnxt *bp, struct bnxt_napi *bnapi, int budget)
1884 if (TX_CMP_TYPE(txcmp) == CMP_TYPE_TX_L2_CMP) { 1884 if (TX_CMP_TYPE(txcmp) == CMP_TYPE_TX_L2_CMP) {
1885 tx_pkts++; 1885 tx_pkts++;
1886 /* return full budget so NAPI will complete. */ 1886 /* return full budget so NAPI will complete. */
1887 if (unlikely(tx_pkts > bp->tx_wake_thresh)) 1887 if (unlikely(tx_pkts > bp->tx_wake_thresh)) {
1888 rx_pkts = budget; 1888 rx_pkts = budget;
1889 raw_cons = NEXT_RAW_CMP(raw_cons);
1890 break;
1891 }
1889 } else if ((TX_CMP_TYPE(txcmp) & 0x30) == 0x10) { 1892 } else if ((TX_CMP_TYPE(txcmp) & 0x30) == 0x10) {
1890 if (likely(budget)) 1893 if (likely(budget))
1891 rc = bnxt_rx_pkt(bp, bnapi, &raw_cons, &event); 1894 rc = bnxt_rx_pkt(bp, bnapi, &raw_cons, &event);
@@ -1913,7 +1916,7 @@ static int bnxt_poll_work(struct bnxt *bp, struct bnxt_napi *bnapi, int budget)
1913 } 1916 }
1914 raw_cons = NEXT_RAW_CMP(raw_cons); 1917 raw_cons = NEXT_RAW_CMP(raw_cons);
1915 1918
1916 if (rx_pkts == budget) 1919 if (rx_pkts && rx_pkts == budget)
1917 break; 1920 break;
1918 } 1921 }
1919 1922
@@ -2027,8 +2030,12 @@ static int bnxt_poll(struct napi_struct *napi, int budget)
2027 while (1) { 2030 while (1) {
2028 work_done += bnxt_poll_work(bp, bnapi, budget - work_done); 2031 work_done += bnxt_poll_work(bp, bnapi, budget - work_done);
2029 2032
2030 if (work_done >= budget) 2033 if (work_done >= budget) {
2034 if (!budget)
2035 BNXT_CP_DB_REARM(cpr->cp_doorbell,
2036 cpr->cp_raw_cons);
2031 break; 2037 break;
2038 }
2032 2039
2033 if (!bnxt_has_work(bp, cpr)) { 2040 if (!bnxt_has_work(bp, cpr)) {
2034 if (napi_complete_done(napi, work_done)) 2041 if (napi_complete_done(napi, work_done))
@@ -3010,10 +3017,11 @@ static void bnxt_free_hwrm_resources(struct bnxt *bp)
3010{ 3017{
3011 struct pci_dev *pdev = bp->pdev; 3018 struct pci_dev *pdev = bp->pdev;
3012 3019
3013 dma_free_coherent(&pdev->dev, PAGE_SIZE, bp->hwrm_cmd_resp_addr, 3020 if (bp->hwrm_cmd_resp_addr) {
3014 bp->hwrm_cmd_resp_dma_addr); 3021 dma_free_coherent(&pdev->dev, PAGE_SIZE, bp->hwrm_cmd_resp_addr,
3015 3022 bp->hwrm_cmd_resp_dma_addr);
3016 bp->hwrm_cmd_resp_addr = NULL; 3023 bp->hwrm_cmd_resp_addr = NULL;
3024 }
3017} 3025}
3018 3026
3019static int bnxt_alloc_hwrm_resources(struct bnxt *bp) 3027static int bnxt_alloc_hwrm_resources(struct bnxt *bp)
@@ -4643,7 +4651,7 @@ __bnxt_hwrm_reserve_pf_rings(struct bnxt *bp, struct hwrm_func_cfg_input *req,
4643 FUNC_CFG_REQ_ENABLES_NUM_STAT_CTXS : 0; 4651 FUNC_CFG_REQ_ENABLES_NUM_STAT_CTXS : 0;
4644 enables |= ring_grps ? 4652 enables |= ring_grps ?
4645 FUNC_CFG_REQ_ENABLES_NUM_HW_RING_GRPS : 0; 4653 FUNC_CFG_REQ_ENABLES_NUM_HW_RING_GRPS : 0;
4646 enables |= vnics ? FUNC_VF_CFG_REQ_ENABLES_NUM_VNICS : 0; 4654 enables |= vnics ? FUNC_CFG_REQ_ENABLES_NUM_VNICS : 0;
4647 4655
4648 req->num_rx_rings = cpu_to_le16(rx_rings); 4656 req->num_rx_rings = cpu_to_le16(rx_rings);
4649 req->num_hw_ring_grps = cpu_to_le16(ring_grps); 4657 req->num_hw_ring_grps = cpu_to_le16(ring_grps);
@@ -7672,21 +7680,6 @@ static void bnxt_tx_timeout(struct net_device *dev)
7672 bnxt_queue_sp_work(bp); 7680 bnxt_queue_sp_work(bp);
7673} 7681}
7674 7682
7675#ifdef CONFIG_NET_POLL_CONTROLLER
7676static void bnxt_poll_controller(struct net_device *dev)
7677{
7678 struct bnxt *bp = netdev_priv(dev);
7679 int i;
7680
7681 /* Only process tx rings/combined rings in netpoll mode. */
7682 for (i = 0; i < bp->tx_nr_rings; i++) {
7683 struct bnxt_tx_ring_info *txr = &bp->tx_ring[i];
7684
7685 napi_schedule(&txr->bnapi->napi);
7686 }
7687}
7688#endif
7689
7690static void bnxt_timer(struct timer_list *t) 7683static void bnxt_timer(struct timer_list *t)
7691{ 7684{
7692 struct bnxt *bp = from_timer(bp, t, timer); 7685 struct bnxt *bp = from_timer(bp, t, timer);
@@ -8027,7 +8020,7 @@ static int bnxt_change_mac_addr(struct net_device *dev, void *p)
8027 if (ether_addr_equal(addr->sa_data, dev->dev_addr)) 8020 if (ether_addr_equal(addr->sa_data, dev->dev_addr))
8028 return 0; 8021 return 0;
8029 8022
8030 rc = bnxt_approve_mac(bp, addr->sa_data); 8023 rc = bnxt_approve_mac(bp, addr->sa_data, true);
8031 if (rc) 8024 if (rc)
8032 return rc; 8025 return rc;
8033 8026
@@ -8520,9 +8513,6 @@ static const struct net_device_ops bnxt_netdev_ops = {
8520 .ndo_set_vf_spoofchk = bnxt_set_vf_spoofchk, 8513 .ndo_set_vf_spoofchk = bnxt_set_vf_spoofchk,
8521 .ndo_set_vf_trust = bnxt_set_vf_trust, 8514 .ndo_set_vf_trust = bnxt_set_vf_trust,
8522#endif 8515#endif
8523#ifdef CONFIG_NET_POLL_CONTROLLER
8524 .ndo_poll_controller = bnxt_poll_controller,
8525#endif
8526 .ndo_setup_tc = bnxt_setup_tc, 8516 .ndo_setup_tc = bnxt_setup_tc,
8527#ifdef CONFIG_RFS_ACCEL 8517#ifdef CONFIG_RFS_ACCEL
8528 .ndo_rx_flow_steer = bnxt_rx_flow_steer, 8518 .ndo_rx_flow_steer = bnxt_rx_flow_steer,
@@ -8632,7 +8622,7 @@ static void _bnxt_get_max_rings(struct bnxt *bp, int *max_rx, int *max_tx,
8632 *max_tx = hw_resc->max_tx_rings; 8622 *max_tx = hw_resc->max_tx_rings;
8633 *max_rx = hw_resc->max_rx_rings; 8623 *max_rx = hw_resc->max_rx_rings;
8634 *max_cp = min_t(int, bnxt_get_max_func_cp_rings_for_en(bp), 8624 *max_cp = min_t(int, bnxt_get_max_func_cp_rings_for_en(bp),
8635 hw_resc->max_irqs); 8625 hw_resc->max_irqs - bnxt_get_ulp_msix_num(bp));
8636 *max_cp = min_t(int, *max_cp, hw_resc->max_stat_ctxs); 8626 *max_cp = min_t(int, *max_cp, hw_resc->max_stat_ctxs);
8637 max_ring_grps = hw_resc->max_hw_ring_grps; 8627 max_ring_grps = hw_resc->max_hw_ring_grps;
8638 if (BNXT_CHIP_TYPE_NITRO_A0(bp) && BNXT_PF(bp)) { 8628 if (BNXT_CHIP_TYPE_NITRO_A0(bp) && BNXT_PF(bp)) {
@@ -8827,14 +8817,19 @@ static int bnxt_init_mac_addr(struct bnxt *bp)
8827 } else { 8817 } else {
8828#ifdef CONFIG_BNXT_SRIOV 8818#ifdef CONFIG_BNXT_SRIOV
8829 struct bnxt_vf_info *vf = &bp->vf; 8819 struct bnxt_vf_info *vf = &bp->vf;
8820 bool strict_approval = true;
8830 8821
8831 if (is_valid_ether_addr(vf->mac_addr)) { 8822 if (is_valid_ether_addr(vf->mac_addr)) {
8832 /* overwrite netdev dev_addr with admin VF MAC */ 8823 /* overwrite netdev dev_addr with admin VF MAC */
8833 memcpy(bp->dev->dev_addr, vf->mac_addr, ETH_ALEN); 8824 memcpy(bp->dev->dev_addr, vf->mac_addr, ETH_ALEN);
8825 /* Older PF driver or firmware may not approve this
8826 * correctly.
8827 */
8828 strict_approval = false;
8834 } else { 8829 } else {
8835 eth_hw_addr_random(bp->dev); 8830 eth_hw_addr_random(bp->dev);
8836 } 8831 }
8837 rc = bnxt_approve_mac(bp, bp->dev->dev_addr); 8832 rc = bnxt_approve_mac(bp, bp->dev->dev_addr, strict_approval);
8838#endif 8833#endif
8839 } 8834 }
8840 return rc; 8835 return rc;
@@ -9063,6 +9058,7 @@ init_err_cleanup_tc:
9063 bnxt_clear_int_mode(bp); 9058 bnxt_clear_int_mode(bp);
9064 9059
9065init_err_pci_clean: 9060init_err_pci_clean:
9061 bnxt_free_hwrm_resources(bp);
9066 bnxt_cleanup_pci(bp); 9062 bnxt_cleanup_pci(bp);
9067 9063
9068init_err_free: 9064init_err_free:
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c
index ddc98c359488..a85d2be986af 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c
@@ -98,13 +98,13 @@ static int bnxt_hwrm_queue_cos2bw_cfg(struct bnxt *bp, struct ieee_ets *ets,
98 98
99 bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_QUEUE_COS2BW_CFG, -1, -1); 99 bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_QUEUE_COS2BW_CFG, -1, -1);
100 for (i = 0; i < max_tc; i++) { 100 for (i = 0; i < max_tc; i++) {
101 u8 qidx; 101 u8 qidx = bp->tc_to_qidx[i];
102 102
103 req.enables |= cpu_to_le32( 103 req.enables |= cpu_to_le32(
104 QUEUE_COS2BW_CFG_REQ_ENABLES_COS_QUEUE_ID0_VALID << i); 104 QUEUE_COS2BW_CFG_REQ_ENABLES_COS_QUEUE_ID0_VALID <<
105 qidx);
105 106
106 memset(&cos2bw, 0, sizeof(cos2bw)); 107 memset(&cos2bw, 0, sizeof(cos2bw));
107 qidx = bp->tc_to_qidx[i];
108 cos2bw.queue_id = bp->q_info[qidx].queue_id; 108 cos2bw.queue_id = bp->q_info[qidx].queue_id;
109 if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_STRICT) { 109 if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_STRICT) {
110 cos2bw.tsa = 110 cos2bw.tsa =
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index f3b9fbcc705b..790c684f08ab 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -46,6 +46,9 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
46 } 46 }
47 } 47 }
48 48
49 if (i == ARRAY_SIZE(nvm_params))
50 return -EOPNOTSUPP;
51
49 if (nvm_param.dir_type == BNXT_NVM_PORT_CFG) 52 if (nvm_param.dir_type == BNXT_NVM_PORT_CFG)
50 idx = bp->pf.port_id; 53 idx = bp->pf.port_id;
51 else if (nvm_param.dir_type == BNXT_NVM_FUNC_CFG) 54 else if (nvm_param.dir_type == BNXT_NVM_FUNC_CFG)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
index fcd085a9853a..3962f6fd543c 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
@@ -1104,7 +1104,7 @@ update_vf_mac_exit:
1104 mutex_unlock(&bp->hwrm_cmd_lock); 1104 mutex_unlock(&bp->hwrm_cmd_lock);
1105} 1105}
1106 1106
1107int bnxt_approve_mac(struct bnxt *bp, u8 *mac) 1107int bnxt_approve_mac(struct bnxt *bp, u8 *mac, bool strict)
1108{ 1108{
1109 struct hwrm_func_vf_cfg_input req = {0}; 1109 struct hwrm_func_vf_cfg_input req = {0};
1110 int rc = 0; 1110 int rc = 0;
@@ -1122,12 +1122,13 @@ int bnxt_approve_mac(struct bnxt *bp, u8 *mac)
1122 memcpy(req.dflt_mac_addr, mac, ETH_ALEN); 1122 memcpy(req.dflt_mac_addr, mac, ETH_ALEN);
1123 rc = hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); 1123 rc = hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
1124mac_done: 1124mac_done:
1125 if (rc) { 1125 if (rc && strict) {
1126 rc = -EADDRNOTAVAIL; 1126 rc = -EADDRNOTAVAIL;
1127 netdev_warn(bp->dev, "VF MAC address %pM not approved by the PF\n", 1127 netdev_warn(bp->dev, "VF MAC address %pM not approved by the PF\n",
1128 mac); 1128 mac);
1129 return rc;
1129 } 1130 }
1130 return rc; 1131 return 0;
1131} 1132}
1132#else 1133#else
1133 1134
@@ -1144,7 +1145,7 @@ void bnxt_update_vf_mac(struct bnxt *bp)
1144{ 1145{
1145} 1146}
1146 1147
1147int bnxt_approve_mac(struct bnxt *bp, u8 *mac) 1148int bnxt_approve_mac(struct bnxt *bp, u8 *mac, bool strict)
1148{ 1149{
1149 return 0; 1150 return 0;
1150} 1151}
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h
index e9b20cd19881..2eed9eda1195 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h
@@ -39,5 +39,5 @@ int bnxt_sriov_configure(struct pci_dev *pdev, int num_vfs);
39void bnxt_sriov_disable(struct bnxt *); 39void bnxt_sriov_disable(struct bnxt *);
40void bnxt_hwrm_exec_fwd_req(struct bnxt *); 40void bnxt_hwrm_exec_fwd_req(struct bnxt *);
41void bnxt_update_vf_mac(struct bnxt *); 41void bnxt_update_vf_mac(struct bnxt *);
42int bnxt_approve_mac(struct bnxt *, u8 *); 42int bnxt_approve_mac(struct bnxt *, u8 *, bool);
43#endif 43#endif
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
index 092c817f8f11..e1594c9df4c6 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -75,17 +75,23 @@ static int bnxt_tc_parse_redir(struct bnxt *bp,
75 return 0; 75 return 0;
76} 76}
77 77
78static void bnxt_tc_parse_vlan(struct bnxt *bp, 78static int bnxt_tc_parse_vlan(struct bnxt *bp,
79 struct bnxt_tc_actions *actions, 79 struct bnxt_tc_actions *actions,
80 const struct tc_action *tc_act) 80 const struct tc_action *tc_act)
81{ 81{
82 if (tcf_vlan_action(tc_act) == TCA_VLAN_ACT_POP) { 82 switch (tcf_vlan_action(tc_act)) {
83 case TCA_VLAN_ACT_POP:
83 actions->flags |= BNXT_TC_ACTION_FLAG_POP_VLAN; 84 actions->flags |= BNXT_TC_ACTION_FLAG_POP_VLAN;
84 } else if (tcf_vlan_action(tc_act) == TCA_VLAN_ACT_PUSH) { 85 break;
86 case TCA_VLAN_ACT_PUSH:
85 actions->flags |= BNXT_TC_ACTION_FLAG_PUSH_VLAN; 87 actions->flags |= BNXT_TC_ACTION_FLAG_PUSH_VLAN;
86 actions->push_vlan_tci = htons(tcf_vlan_push_vid(tc_act)); 88 actions->push_vlan_tci = htons(tcf_vlan_push_vid(tc_act));
87 actions->push_vlan_tpid = tcf_vlan_push_proto(tc_act); 89 actions->push_vlan_tpid = tcf_vlan_push_proto(tc_act);
90 break;
91 default:
92 return -EOPNOTSUPP;
88 } 93 }
94 return 0;
89} 95}
90 96
91static int bnxt_tc_parse_tunnel_set(struct bnxt *bp, 97static int bnxt_tc_parse_tunnel_set(struct bnxt *bp,
@@ -134,7 +140,9 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
134 140
135 /* Push/pop VLAN */ 141 /* Push/pop VLAN */
136 if (is_tcf_vlan(tc_act)) { 142 if (is_tcf_vlan(tc_act)) {
137 bnxt_tc_parse_vlan(bp, actions, tc_act); 143 rc = bnxt_tc_parse_vlan(bp, actions, tc_act);
144 if (rc)
145 return rc;
138 continue; 146 continue;
139 } 147 }
140 148
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 16e4ef7d7185..58b9744c4058 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -2160,6 +2160,7 @@ static void macb_configure_dma(struct macb *bp)
2160 else 2160 else
2161 dmacfg &= ~GEM_BIT(TXCOEN); 2161 dmacfg &= ~GEM_BIT(TXCOEN);
2162 2162
2163 dmacfg &= ~GEM_BIT(ADDR64);
2163#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT 2164#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
2164 if (bp->hw_dma_cap & HW_DMA_CAP_64B) 2165 if (bp->hw_dma_cap & HW_DMA_CAP_64B)
2165 dmacfg |= GEM_BIT(ADDR64); 2166 dmacfg |= GEM_BIT(ADDR64);
@@ -3837,6 +3838,13 @@ static const struct macb_config at91sam9260_config = {
3837 .init = macb_init, 3838 .init = macb_init,
3838}; 3839};
3839 3840
3841static const struct macb_config sama5d3macb_config = {
3842 .caps = MACB_CAPS_SG_DISABLED
3843 | MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII,
3844 .clk_init = macb_clk_init,
3845 .init = macb_init,
3846};
3847
3840static const struct macb_config pc302gem_config = { 3848static const struct macb_config pc302gem_config = {
3841 .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE, 3849 .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE,
3842 .dma_burst_length = 16, 3850 .dma_burst_length = 16,
@@ -3904,6 +3912,7 @@ static const struct of_device_id macb_dt_ids[] = {
3904 { .compatible = "cdns,gem", .data = &pc302gem_config }, 3912 { .compatible = "cdns,gem", .data = &pc302gem_config },
3905 { .compatible = "atmel,sama5d2-gem", .data = &sama5d2_config }, 3913 { .compatible = "atmel,sama5d2-gem", .data = &sama5d2_config },
3906 { .compatible = "atmel,sama5d3-gem", .data = &sama5d3_config }, 3914 { .compatible = "atmel,sama5d3-gem", .data = &sama5d3_config },
3915 { .compatible = "atmel,sama5d3-macb", .data = &sama5d3macb_config },
3907 { .compatible = "atmel,sama5d4-gem", .data = &sama5d4_config }, 3916 { .compatible = "atmel,sama5d4-gem", .data = &sama5d4_config },
3908 { .compatible = "cdns,at91rm9200-emac", .data = &emac_config }, 3917 { .compatible = "cdns,at91rm9200-emac", .data = &emac_config },
3909 { .compatible = "cdns,emac", .data = &emac_config }, 3918 { .compatible = "cdns,emac", .data = &emac_config },
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
index a19172dbe6be..c34ea385fe4a 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
@@ -2159,6 +2159,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2159 return -EPERM; 2159 return -EPERM;
2160 if (copy_from_user(&t, useraddr, sizeof(t))) 2160 if (copy_from_user(&t, useraddr, sizeof(t)))
2161 return -EFAULT; 2161 return -EFAULT;
2162 if (t.cmd != CHELSIO_SET_QSET_PARAMS)
2163 return -EINVAL;
2162 if (t.qset_idx >= SGE_QSETS) 2164 if (t.qset_idx >= SGE_QSETS)
2163 return -EINVAL; 2165 return -EINVAL;
2164 if (!in_range(t.intr_lat, 0, M_NEWTIMER) || 2166 if (!in_range(t.intr_lat, 0, M_NEWTIMER) ||
@@ -2258,6 +2260,9 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2258 if (copy_from_user(&t, useraddr, sizeof(t))) 2260 if (copy_from_user(&t, useraddr, sizeof(t)))
2259 return -EFAULT; 2261 return -EFAULT;
2260 2262
2263 if (t.cmd != CHELSIO_GET_QSET_PARAMS)
2264 return -EINVAL;
2265
2261 /* Display qsets for all ports when offload enabled */ 2266 /* Display qsets for all ports when offload enabled */
2262 if (test_bit(OFFLOAD_DEVMAP_BIT, &adapter->open_device_map)) { 2267 if (test_bit(OFFLOAD_DEVMAP_BIT, &adapter->open_device_map)) {
2263 q1 = 0; 2268 q1 = 0;
@@ -2303,6 +2308,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2303 return -EBUSY; 2308 return -EBUSY;
2304 if (copy_from_user(&edata, useraddr, sizeof(edata))) 2309 if (copy_from_user(&edata, useraddr, sizeof(edata)))
2305 return -EFAULT; 2310 return -EFAULT;
2311 if (edata.cmd != CHELSIO_SET_QSET_NUM)
2312 return -EINVAL;
2306 if (edata.val < 1 || 2313 if (edata.val < 1 ||
2307 (edata.val > 1 && !(adapter->flags & USING_MSIX))) 2314 (edata.val > 1 && !(adapter->flags & USING_MSIX)))
2308 return -EINVAL; 2315 return -EINVAL;
@@ -2343,6 +2350,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2343 return -EPERM; 2350 return -EPERM;
2344 if (copy_from_user(&t, useraddr, sizeof(t))) 2351 if (copy_from_user(&t, useraddr, sizeof(t)))
2345 return -EFAULT; 2352 return -EFAULT;
2353 if (t.cmd != CHELSIO_LOAD_FW)
2354 return -EINVAL;
2346 /* Check t.len sanity ? */ 2355 /* Check t.len sanity ? */
2347 fw_data = memdup_user(useraddr + sizeof(t), t.len); 2356 fw_data = memdup_user(useraddr + sizeof(t), t.len);
2348 if (IS_ERR(fw_data)) 2357 if (IS_ERR(fw_data))
@@ -2366,6 +2375,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2366 return -EBUSY; 2375 return -EBUSY;
2367 if (copy_from_user(&m, useraddr, sizeof(m))) 2376 if (copy_from_user(&m, useraddr, sizeof(m)))
2368 return -EFAULT; 2377 return -EFAULT;
2378 if (m.cmd != CHELSIO_SETMTUTAB)
2379 return -EINVAL;
2369 if (m.nmtus != NMTUS) 2380 if (m.nmtus != NMTUS)
2370 return -EINVAL; 2381 return -EINVAL;
2371 if (m.mtus[0] < 81) /* accommodate SACK */ 2382 if (m.mtus[0] < 81) /* accommodate SACK */
@@ -2407,6 +2418,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2407 return -EBUSY; 2418 return -EBUSY;
2408 if (copy_from_user(&m, useraddr, sizeof(m))) 2419 if (copy_from_user(&m, useraddr, sizeof(m)))
2409 return -EFAULT; 2420 return -EFAULT;
2421 if (m.cmd != CHELSIO_SET_PM)
2422 return -EINVAL;
2410 if (!is_power_of_2(m.rx_pg_sz) || 2423 if (!is_power_of_2(m.rx_pg_sz) ||
2411 !is_power_of_2(m.tx_pg_sz)) 2424 !is_power_of_2(m.tx_pg_sz))
2412 return -EINVAL; /* not power of 2 */ 2425 return -EINVAL; /* not power of 2 */
@@ -2440,6 +2453,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2440 return -EIO; /* need the memory controllers */ 2453 return -EIO; /* need the memory controllers */
2441 if (copy_from_user(&t, useraddr, sizeof(t))) 2454 if (copy_from_user(&t, useraddr, sizeof(t)))
2442 return -EFAULT; 2455 return -EFAULT;
2456 if (t.cmd != CHELSIO_GET_MEM)
2457 return -EINVAL;
2443 if ((t.addr & 7) || (t.len & 7)) 2458 if ((t.addr & 7) || (t.len & 7))
2444 return -EINVAL; 2459 return -EINVAL;
2445 if (t.mem_id == MEM_CM) 2460 if (t.mem_id == MEM_CM)
@@ -2492,6 +2507,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
2492 return -EAGAIN; 2507 return -EAGAIN;
2493 if (copy_from_user(&t, useraddr, sizeof(t))) 2508 if (copy_from_user(&t, useraddr, sizeof(t)))
2494 return -EFAULT; 2509 return -EFAULT;
2510 if (t.cmd != CHELSIO_SET_TRACE_FILTER)
2511 return -EINVAL;
2495 2512
2496 tp = (const struct trace_params *)&t.sip; 2513 tp = (const struct trace_params *)&t.sip;
2497 if (t.config_tx) 2514 if (t.config_tx)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h
index b8f75a22fb6c..f152da1ce046 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h
@@ -753,7 +753,6 @@ struct cpl_abort_req_rss {
753}; 753};
754 754
755struct cpl_abort_req_rss6 { 755struct cpl_abort_req_rss6 {
756 WR_HDR;
757 union opcode_tid ot; 756 union opcode_tid ot;
758 __be32 srqidx_status; 757 __be32 srqidx_status;
759}; 758};
diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c
index e2a702996db4..13dfdfca49fc 100644
--- a/drivers/net/ethernet/cirrus/ep93xx_eth.c
+++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c
@@ -332,7 +332,7 @@ static int ep93xx_poll(struct napi_struct *napi, int budget)
332 return rx; 332 return rx;
333} 333}
334 334
335static int ep93xx_xmit(struct sk_buff *skb, struct net_device *dev) 335static netdev_tx_t ep93xx_xmit(struct sk_buff *skb, struct net_device *dev)
336{ 336{
337 struct ep93xx_priv *ep = netdev_priv(dev); 337 struct ep93xx_priv *ep = netdev_priv(dev);
338 struct ep93xx_tdesc *txd; 338 struct ep93xx_tdesc *txd;
diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c
index 3f8fe8fd79cc..6324e80960c3 100644
--- a/drivers/net/ethernet/cirrus/mac89x0.c
+++ b/drivers/net/ethernet/cirrus/mac89x0.c
@@ -113,7 +113,7 @@ struct net_local {
113 113
114/* Index to functions, as function prototypes. */ 114/* Index to functions, as function prototypes. */
115static int net_open(struct net_device *dev); 115static int net_open(struct net_device *dev);
116static int net_send_packet(struct sk_buff *skb, struct net_device *dev); 116static netdev_tx_t net_send_packet(struct sk_buff *skb, struct net_device *dev);
117static irqreturn_t net_interrupt(int irq, void *dev_id); 117static irqreturn_t net_interrupt(int irq, void *dev_id);
118static void set_multicast_list(struct net_device *dev); 118static void set_multicast_list(struct net_device *dev);
119static void net_rx(struct net_device *dev); 119static void net_rx(struct net_device *dev);
@@ -324,7 +324,7 @@ net_open(struct net_device *dev)
324 return 0; 324 return 0;
325} 325}
326 326
327static int 327static netdev_tx_t
328net_send_packet(struct sk_buff *skb, struct net_device *dev) 328net_send_packet(struct sk_buff *skb, struct net_device *dev)
329{ 329{
330 struct net_local *lp = netdev_priv(dev); 330 struct net_local *lp = netdev_priv(dev);
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
index ff92ab1daeb8..1e9d882c04ef 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.c
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
@@ -4500,7 +4500,7 @@ int be_cmd_get_profile_config(struct be_adapter *adapter,
4500 port_res->max_vfs += le16_to_cpu(pcie->num_vfs); 4500 port_res->max_vfs += le16_to_cpu(pcie->num_vfs);
4501 } 4501 }
4502 } 4502 }
4503 return status; 4503 goto err;
4504 } 4504 }
4505 4505
4506 pcie = be_get_pcie_desc(resp->func_param, desc_count, 4506 pcie = be_get_pcie_desc(resp->func_param, desc_count,
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 74d122616e76..534787291b44 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -4002,8 +4002,6 @@ static int be_enable_vxlan_offloads(struct be_adapter *adapter)
4002 netdev->hw_enc_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | 4002 netdev->hw_enc_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
4003 NETIF_F_TSO | NETIF_F_TSO6 | 4003 NETIF_F_TSO | NETIF_F_TSO6 |
4004 NETIF_F_GSO_UDP_TUNNEL; 4004 NETIF_F_GSO_UDP_TUNNEL;
4005 netdev->hw_features |= NETIF_F_GSO_UDP_TUNNEL;
4006 netdev->features |= NETIF_F_GSO_UDP_TUNNEL;
4007 4005
4008 dev_info(dev, "Enabled VxLAN offloads for UDP port %d\n", 4006 dev_info(dev, "Enabled VxLAN offloads for UDP port %d\n",
4009 be16_to_cpu(port)); 4007 be16_to_cpu(port));
@@ -4025,8 +4023,6 @@ static void be_disable_vxlan_offloads(struct be_adapter *adapter)
4025 adapter->vxlan_port = 0; 4023 adapter->vxlan_port = 0;
4026 4024
4027 netdev->hw_enc_features = 0; 4025 netdev->hw_enc_features = 0;
4028 netdev->hw_features &= ~(NETIF_F_GSO_UDP_TUNNEL);
4029 netdev->features &= ~(NETIF_F_GSO_UDP_TUNNEL);
4030} 4026}
4031 4027
4032static void be_calculate_vf_res(struct be_adapter *adapter, u16 num_vfs, 4028static void be_calculate_vf_res(struct be_adapter *adapter, u16 num_vfs,
@@ -5320,6 +5316,7 @@ static void be_netdev_init(struct net_device *netdev)
5320 struct be_adapter *adapter = netdev_priv(netdev); 5316 struct be_adapter *adapter = netdev_priv(netdev);
5321 5317
5322 netdev->hw_features |= NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6 | 5318 netdev->hw_features |= NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6 |
5319 NETIF_F_GSO_UDP_TUNNEL |
5323 NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | 5320 NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |
5324 NETIF_F_HW_VLAN_CTAG_TX; 5321 NETIF_F_HW_VLAN_CTAG_TX;
5325 if ((be_if_cap_flags(adapter) & BE_IF_FLAGS_RSS)) 5322 if ((be_if_cap_flags(adapter) & BE_IF_FLAGS_RSS))
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 2708297e7795..bf9b9fd6d2a0 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1158,7 +1158,7 @@ static void fec_enet_timeout_work(struct work_struct *work)
1158 napi_disable(&fep->napi); 1158 napi_disable(&fep->napi);
1159 netif_tx_lock_bh(ndev); 1159 netif_tx_lock_bh(ndev);
1160 fec_restart(ndev); 1160 fec_restart(ndev);
1161 netif_wake_queue(ndev); 1161 netif_tx_wake_all_queues(ndev);
1162 netif_tx_unlock_bh(ndev); 1162 netif_tx_unlock_bh(ndev);
1163 napi_enable(&fep->napi); 1163 napi_enable(&fep->napi);
1164 } 1164 }
@@ -1273,7 +1273,7 @@ skb_done:
1273 1273
1274 /* Since we have freed up a buffer, the ring is no longer full 1274 /* Since we have freed up a buffer, the ring is no longer full
1275 */ 1275 */
1276 if (netif_queue_stopped(ndev)) { 1276 if (netif_tx_queue_stopped(nq)) {
1277 entries_free = fec_enet_get_free_txdesc_num(txq); 1277 entries_free = fec_enet_get_free_txdesc_num(txq);
1278 if (entries_free >= txq->tx_wake_threshold) 1278 if (entries_free >= txq->tx_wake_threshold)
1279 netif_tx_wake_queue(nq); 1279 netif_tx_wake_queue(nq);
@@ -1746,7 +1746,7 @@ static void fec_enet_adjust_link(struct net_device *ndev)
1746 napi_disable(&fep->napi); 1746 napi_disable(&fep->napi);
1747 netif_tx_lock_bh(ndev); 1747 netif_tx_lock_bh(ndev);
1748 fec_restart(ndev); 1748 fec_restart(ndev);
1749 netif_wake_queue(ndev); 1749 netif_tx_wake_all_queues(ndev);
1750 netif_tx_unlock_bh(ndev); 1750 netif_tx_unlock_bh(ndev);
1751 napi_enable(&fep->napi); 1751 napi_enable(&fep->napi);
1752 } 1752 }
@@ -2247,7 +2247,7 @@ static int fec_enet_set_pauseparam(struct net_device *ndev,
2247 napi_disable(&fep->napi); 2247 napi_disable(&fep->napi);
2248 netif_tx_lock_bh(ndev); 2248 netif_tx_lock_bh(ndev);
2249 fec_restart(ndev); 2249 fec_restart(ndev);
2250 netif_wake_queue(ndev); 2250 netif_tx_wake_all_queues(ndev);
2251 netif_tx_unlock_bh(ndev); 2251 netif_tx_unlock_bh(ndev);
2252 napi_enable(&fep->napi); 2252 napi_enable(&fep->napi);
2253 } 2253 }
diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c
index a051e582d541..79d03f8ee7b1 100644
--- a/drivers/net/ethernet/hisilicon/hns/hnae.c
+++ b/drivers/net/ethernet/hisilicon/hns/hnae.c
@@ -84,7 +84,7 @@ static void hnae_unmap_buffer(struct hnae_ring *ring, struct hnae_desc_cb *cb)
84 if (cb->type == DESC_TYPE_SKB) 84 if (cb->type == DESC_TYPE_SKB)
85 dma_unmap_single(ring_to_dev(ring), cb->dma, cb->length, 85 dma_unmap_single(ring_to_dev(ring), cb->dma, cb->length,
86 ring_to_dma_dir(ring)); 86 ring_to_dma_dir(ring));
87 else 87 else if (cb->length)
88 dma_unmap_page(ring_to_dev(ring), cb->dma, cb->length, 88 dma_unmap_page(ring_to_dev(ring), cb->dma, cb->length,
89 ring_to_dma_dir(ring)); 89 ring_to_dma_dir(ring));
90} 90}
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
index f56855e63c96..28e907831b0e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -40,9 +40,9 @@
40#define SKB_TMP_LEN(SKB) \ 40#define SKB_TMP_LEN(SKB) \
41 (((SKB)->transport_header - (SKB)->mac_header) + tcp_hdrlen(SKB)) 41 (((SKB)->transport_header - (SKB)->mac_header) + tcp_hdrlen(SKB))
42 42
43static void fill_v2_desc(struct hnae_ring *ring, void *priv, 43static void fill_v2_desc_hw(struct hnae_ring *ring, void *priv, int size,
44 int size, dma_addr_t dma, int frag_end, 44 int send_sz, dma_addr_t dma, int frag_end,
45 int buf_num, enum hns_desc_type type, int mtu) 45 int buf_num, enum hns_desc_type type, int mtu)
46{ 46{
47 struct hnae_desc *desc = &ring->desc[ring->next_to_use]; 47 struct hnae_desc *desc = &ring->desc[ring->next_to_use];
48 struct hnae_desc_cb *desc_cb = &ring->desc_cb[ring->next_to_use]; 48 struct hnae_desc_cb *desc_cb = &ring->desc_cb[ring->next_to_use];
@@ -64,7 +64,7 @@ static void fill_v2_desc(struct hnae_ring *ring, void *priv,
64 desc_cb->type = type; 64 desc_cb->type = type;
65 65
66 desc->addr = cpu_to_le64(dma); 66 desc->addr = cpu_to_le64(dma);
67 desc->tx.send_size = cpu_to_le16((u16)size); 67 desc->tx.send_size = cpu_to_le16((u16)send_sz);
68 68
69 /* config bd buffer end */ 69 /* config bd buffer end */
70 hnae_set_bit(rrcfv, HNSV2_TXD_VLD_B, 1); 70 hnae_set_bit(rrcfv, HNSV2_TXD_VLD_B, 1);
@@ -133,6 +133,14 @@ static void fill_v2_desc(struct hnae_ring *ring, void *priv,
133 ring_ptr_move_fw(ring, next_to_use); 133 ring_ptr_move_fw(ring, next_to_use);
134} 134}
135 135
136static void fill_v2_desc(struct hnae_ring *ring, void *priv,
137 int size, dma_addr_t dma, int frag_end,
138 int buf_num, enum hns_desc_type type, int mtu)
139{
140 fill_v2_desc_hw(ring, priv, size, size, dma, frag_end,
141 buf_num, type, mtu);
142}
143
136static const struct acpi_device_id hns_enet_acpi_match[] = { 144static const struct acpi_device_id hns_enet_acpi_match[] = {
137 { "HISI00C1", 0 }, 145 { "HISI00C1", 0 },
138 { "HISI00C2", 0 }, 146 { "HISI00C2", 0 },
@@ -289,15 +297,15 @@ static void fill_tso_desc(struct hnae_ring *ring, void *priv,
289 297
290 /* when the frag size is bigger than hardware, split this frag */ 298 /* when the frag size is bigger than hardware, split this frag */
291 for (k = 0; k < frag_buf_num; k++) 299 for (k = 0; k < frag_buf_num; k++)
292 fill_v2_desc(ring, priv, 300 fill_v2_desc_hw(ring, priv, k == 0 ? size : 0,
293 (k == frag_buf_num - 1) ? 301 (k == frag_buf_num - 1) ?
294 sizeoflast : BD_MAX_SEND_SIZE, 302 sizeoflast : BD_MAX_SEND_SIZE,
295 dma + BD_MAX_SEND_SIZE * k, 303 dma + BD_MAX_SEND_SIZE * k,
296 frag_end && (k == frag_buf_num - 1) ? 1 : 0, 304 frag_end && (k == frag_buf_num - 1) ? 1 : 0,
297 buf_num, 305 buf_num,
298 (type == DESC_TYPE_SKB && !k) ? 306 (type == DESC_TYPE_SKB && !k) ?
299 DESC_TYPE_SKB : DESC_TYPE_PAGE, 307 DESC_TYPE_SKB : DESC_TYPE_PAGE,
300 mtu); 308 mtu);
301} 309}
302 310
303netdev_tx_t hns_nic_net_xmit_hw(struct net_device *ndev, 311netdev_tx_t hns_nic_net_xmit_hw(struct net_device *ndev,
@@ -1495,21 +1503,6 @@ static int hns_nic_do_ioctl(struct net_device *netdev, struct ifreq *ifr,
1495 return phy_mii_ioctl(phy_dev, ifr, cmd); 1503 return phy_mii_ioctl(phy_dev, ifr, cmd);
1496} 1504}
1497 1505
1498/* use only for netconsole to poll with the device without interrupt */
1499#ifdef CONFIG_NET_POLL_CONTROLLER
1500static void hns_nic_poll_controller(struct net_device *ndev)
1501{
1502 struct hns_nic_priv *priv = netdev_priv(ndev);
1503 unsigned long flags;
1504 int i;
1505
1506 local_irq_save(flags);
1507 for (i = 0; i < priv->ae_handle->q_num * 2; i++)
1508 napi_schedule(&priv->ring_data[i].napi);
1509 local_irq_restore(flags);
1510}
1511#endif
1512
1513static netdev_tx_t hns_nic_net_xmit(struct sk_buff *skb, 1506static netdev_tx_t hns_nic_net_xmit(struct sk_buff *skb,
1514 struct net_device *ndev) 1507 struct net_device *ndev)
1515{ 1508{
@@ -1962,9 +1955,6 @@ static const struct net_device_ops hns_nic_netdev_ops = {
1962 .ndo_set_features = hns_nic_set_features, 1955 .ndo_set_features = hns_nic_set_features,
1963 .ndo_fix_features = hns_nic_fix_features, 1956 .ndo_fix_features = hns_nic_fix_features,
1964 .ndo_get_stats64 = hns_nic_get_stats64, 1957 .ndo_get_stats64 = hns_nic_get_stats64,
1965#ifdef CONFIG_NET_POLL_CONTROLLER
1966 .ndo_poll_controller = hns_nic_poll_controller,
1967#endif
1968 .ndo_set_rx_mode = hns_nic_set_rx_mode, 1958 .ndo_set_rx_mode = hns_nic_set_rx_mode,
1969 .ndo_select_queue = hns_nic_select_queue, 1959 .ndo_select_queue = hns_nic_select_queue,
1970}; 1960};
diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c
index c8c7ad2eff77..9b5a68b65432 100644
--- a/drivers/net/ethernet/hp/hp100.c
+++ b/drivers/net/ethernet/hp/hp100.c
@@ -2634,7 +2634,7 @@ static int hp100_login_to_vg_hub(struct net_device *dev, u_short force_relogin)
2634 /* Wait for link to drop */ 2634 /* Wait for link to drop */
2635 time = jiffies + (HZ / 10); 2635 time = jiffies + (HZ / 10);
2636 do { 2636 do {
2637 if (~(hp100_inb(VG_LAN_CFG_1) & HP100_LINK_UP_ST)) 2637 if (!(hp100_inb(VG_LAN_CFG_1) & HP100_LINK_UP_ST))
2638 break; 2638 break;
2639 if (!in_interrupt()) 2639 if (!in_interrupt())
2640 schedule_timeout_interruptible(1); 2640 schedule_timeout_interruptible(1);
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
index 09e9da10b786..4a8f82938ed5 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_main.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c
@@ -789,23 +789,6 @@ static void hinic_get_stats64(struct net_device *netdev,
789 stats->tx_errors = nic_tx_stats->tx_dropped; 789 stats->tx_errors = nic_tx_stats->tx_dropped;
790} 790}
791 791
792#ifdef CONFIG_NET_POLL_CONTROLLER
793static void hinic_netpoll(struct net_device *netdev)
794{
795 struct hinic_dev *nic_dev = netdev_priv(netdev);
796 int i, num_qps;
797
798 num_qps = hinic_hwdev_num_qps(nic_dev->hwdev);
799 for (i = 0; i < num_qps; i++) {
800 struct hinic_txq *txq = &nic_dev->txqs[i];
801 struct hinic_rxq *rxq = &nic_dev->rxqs[i];
802
803 napi_schedule(&txq->napi);
804 napi_schedule(&rxq->napi);
805 }
806}
807#endif
808
809static const struct net_device_ops hinic_netdev_ops = { 792static const struct net_device_ops hinic_netdev_ops = {
810 .ndo_open = hinic_open, 793 .ndo_open = hinic_open,
811 .ndo_stop = hinic_close, 794 .ndo_stop = hinic_close,
@@ -818,9 +801,6 @@ static const struct net_device_ops hinic_netdev_ops = {
818 .ndo_start_xmit = hinic_xmit_frame, 801 .ndo_start_xmit = hinic_xmit_frame,
819 .ndo_tx_timeout = hinic_tx_timeout, 802 .ndo_tx_timeout = hinic_tx_timeout,
820 .ndo_get_stats64 = hinic_get_stats64, 803 .ndo_get_stats64 = hinic_get_stats64,
821#ifdef CONFIG_NET_POLL_CONTROLLER
822 .ndo_poll_controller = hinic_netpoll,
823#endif
824}; 804};
825 805
826static void netdev_features_init(struct net_device *netdev) 806static void netdev_features_init(struct net_device *netdev)
diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
index dc983450354b..35f6291a3672 100644
--- a/drivers/net/ethernet/i825xx/ether1.c
+++ b/drivers/net/ethernet/i825xx/ether1.c
@@ -64,7 +64,8 @@ static unsigned int net_debug = NET_DEBUG;
64#define RX_AREA_END 0x0fc00 64#define RX_AREA_END 0x0fc00
65 65
66static int ether1_open(struct net_device *dev); 66static int ether1_open(struct net_device *dev);
67static int ether1_sendpacket(struct sk_buff *skb, struct net_device *dev); 67static netdev_tx_t ether1_sendpacket(struct sk_buff *skb,
68 struct net_device *dev);
68static irqreturn_t ether1_interrupt(int irq, void *dev_id); 69static irqreturn_t ether1_interrupt(int irq, void *dev_id);
69static int ether1_close(struct net_device *dev); 70static int ether1_close(struct net_device *dev);
70static void ether1_setmulticastlist(struct net_device *dev); 71static void ether1_setmulticastlist(struct net_device *dev);
@@ -667,7 +668,7 @@ ether1_timeout(struct net_device *dev)
667 netif_wake_queue(dev); 668 netif_wake_queue(dev);
668} 669}
669 670
670static int 671static netdev_tx_t
671ether1_sendpacket (struct sk_buff *skb, struct net_device *dev) 672ether1_sendpacket (struct sk_buff *skb, struct net_device *dev)
672{ 673{
673 int tmp, tst, nopaddr, txaddr, tbdaddr, dataddr; 674 int tmp, tst, nopaddr, txaddr, tbdaddr, dataddr;
diff --git a/drivers/net/ethernet/i825xx/lib82596.c b/drivers/net/ethernet/i825xx/lib82596.c
index f00a1dc2128c..2f7ae118217f 100644
--- a/drivers/net/ethernet/i825xx/lib82596.c
+++ b/drivers/net/ethernet/i825xx/lib82596.c
@@ -347,7 +347,7 @@ static const char init_setup[] =
347 0x7f /* *multi IA */ }; 347 0x7f /* *multi IA */ };
348 348
349static int i596_open(struct net_device *dev); 349static int i596_open(struct net_device *dev);
350static int i596_start_xmit(struct sk_buff *skb, struct net_device *dev); 350static netdev_tx_t i596_start_xmit(struct sk_buff *skb, struct net_device *dev);
351static irqreturn_t i596_interrupt(int irq, void *dev_id); 351static irqreturn_t i596_interrupt(int irq, void *dev_id);
352static int i596_close(struct net_device *dev); 352static int i596_close(struct net_device *dev);
353static void i596_add_cmd(struct net_device *dev, struct i596_cmd *cmd); 353static void i596_add_cmd(struct net_device *dev, struct i596_cmd *cmd);
@@ -966,7 +966,7 @@ static void i596_tx_timeout (struct net_device *dev)
966} 966}
967 967
968 968
969static int i596_start_xmit(struct sk_buff *skb, struct net_device *dev) 969static netdev_tx_t i596_start_xmit(struct sk_buff *skb, struct net_device *dev)
970{ 970{
971 struct i596_private *lp = netdev_priv(dev); 971 struct i596_private *lp = netdev_priv(dev);
972 struct tx_cmd *tx_cmd; 972 struct tx_cmd *tx_cmd;
diff --git a/drivers/net/ethernet/i825xx/sun3_82586.c b/drivers/net/ethernet/i825xx/sun3_82586.c
index 8bb15a8c2a40..1a86184d44c0 100644
--- a/drivers/net/ethernet/i825xx/sun3_82586.c
+++ b/drivers/net/ethernet/i825xx/sun3_82586.c
@@ -121,7 +121,8 @@ static int sun3_82586_probe1(struct net_device *dev,int ioaddr);
121static irqreturn_t sun3_82586_interrupt(int irq,void *dev_id); 121static irqreturn_t sun3_82586_interrupt(int irq,void *dev_id);
122static int sun3_82586_open(struct net_device *dev); 122static int sun3_82586_open(struct net_device *dev);
123static int sun3_82586_close(struct net_device *dev); 123static int sun3_82586_close(struct net_device *dev);
124static int sun3_82586_send_packet(struct sk_buff *,struct net_device *); 124static netdev_tx_t sun3_82586_send_packet(struct sk_buff *,
125 struct net_device *);
125static struct net_device_stats *sun3_82586_get_stats(struct net_device *dev); 126static struct net_device_stats *sun3_82586_get_stats(struct net_device *dev);
126static void set_multicast_list(struct net_device *dev); 127static void set_multicast_list(struct net_device *dev);
127static void sun3_82586_timeout(struct net_device *dev); 128static void sun3_82586_timeout(struct net_device *dev);
@@ -1002,7 +1003,8 @@ static void sun3_82586_timeout(struct net_device *dev)
1002 * send frame 1003 * send frame
1003 */ 1004 */
1004 1005
1005static int sun3_82586_send_packet(struct sk_buff *skb, struct net_device *dev) 1006static netdev_tx_t
1007sun3_82586_send_packet(struct sk_buff *skb, struct net_device *dev)
1006{ 1008{
1007 int len,i; 1009 int len,i;
1008#ifndef NO_NOPCOMMANDS 1010#ifndef NO_NOPCOMMANDS
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index ba580bfae512..03f64f40b2a3 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -921,17 +921,6 @@ static int ehea_poll(struct napi_struct *napi, int budget)
921 return rx; 921 return rx;
922} 922}
923 923
924#ifdef CONFIG_NET_POLL_CONTROLLER
925static void ehea_netpoll(struct net_device *dev)
926{
927 struct ehea_port *port = netdev_priv(dev);
928 int i;
929
930 for (i = 0; i < port->num_def_qps; i++)
931 napi_schedule(&port->port_res[i].napi);
932}
933#endif
934
935static irqreturn_t ehea_recv_irq_handler(int irq, void *param) 924static irqreturn_t ehea_recv_irq_handler(int irq, void *param)
936{ 925{
937 struct ehea_port_res *pr = param; 926 struct ehea_port_res *pr = param;
@@ -2953,9 +2942,6 @@ static const struct net_device_ops ehea_netdev_ops = {
2953 .ndo_open = ehea_open, 2942 .ndo_open = ehea_open,
2954 .ndo_stop = ehea_stop, 2943 .ndo_stop = ehea_stop,
2955 .ndo_start_xmit = ehea_start_xmit, 2944 .ndo_start_xmit = ehea_start_xmit,
2956#ifdef CONFIG_NET_POLL_CONTROLLER
2957 .ndo_poll_controller = ehea_netpoll,
2958#endif
2959 .ndo_get_stats64 = ehea_get_stats64, 2945 .ndo_get_stats64 = ehea_get_stats64,
2960 .ndo_set_mac_address = ehea_set_mac_addr, 2946 .ndo_set_mac_address = ehea_set_mac_addr,
2961 .ndo_validate_addr = eth_validate_addr, 2947 .ndo_validate_addr = eth_validate_addr,
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index 372664686309..129f4e9f38da 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -2677,12 +2677,17 @@ static int emac_init_phy(struct emac_instance *dev)
2677 if (of_phy_is_fixed_link(np)) { 2677 if (of_phy_is_fixed_link(np)) {
2678 int res = emac_dt_mdio_probe(dev); 2678 int res = emac_dt_mdio_probe(dev);
2679 2679
2680 if (!res) { 2680 if (res)
2681 res = of_phy_register_fixed_link(np); 2681 return res;
2682 if (res) 2682
2683 mdiobus_unregister(dev->mii_bus); 2683 res = of_phy_register_fixed_link(np);
2684 dev->phy_dev = of_phy_find_device(np);
2685 if (res || !dev->phy_dev) {
2686 mdiobus_unregister(dev->mii_bus);
2687 return res ? res : -EINVAL;
2684 } 2688 }
2685 return res; 2689 emac_adjust_link(dev->ndev);
2690 put_device(&dev->phy_dev->mdio.dev);
2686 } 2691 }
2687 return 0; 2692 return 0;
2688 } 2693 }
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4f0daf67b18d..699ef942b615 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -2207,19 +2207,6 @@ restart_poll:
2207 return frames_processed; 2207 return frames_processed;
2208} 2208}
2209 2209
2210#ifdef CONFIG_NET_POLL_CONTROLLER
2211static void ibmvnic_netpoll_controller(struct net_device *dev)
2212{
2213 struct ibmvnic_adapter *adapter = netdev_priv(dev);
2214 int i;
2215
2216 replenish_pools(netdev_priv(dev));
2217 for (i = 0; i < adapter->req_rx_queues; i++)
2218 ibmvnic_interrupt_rx(adapter->rx_scrq[i]->irq,
2219 adapter->rx_scrq[i]);
2220}
2221#endif
2222
2223static int wait_for_reset(struct ibmvnic_adapter *adapter) 2210static int wait_for_reset(struct ibmvnic_adapter *adapter)
2224{ 2211{
2225 int rc, ret; 2212 int rc, ret;
@@ -2292,9 +2279,6 @@ static const struct net_device_ops ibmvnic_netdev_ops = {
2292 .ndo_set_mac_address = ibmvnic_set_mac, 2279 .ndo_set_mac_address = ibmvnic_set_mac,
2293 .ndo_validate_addr = eth_validate_addr, 2280 .ndo_validate_addr = eth_validate_addr,
2294 .ndo_tx_timeout = ibmvnic_tx_timeout, 2281 .ndo_tx_timeout = ibmvnic_tx_timeout,
2295#ifdef CONFIG_NET_POLL_CONTROLLER
2296 .ndo_poll_controller = ibmvnic_netpoll_controller,
2297#endif
2298 .ndo_change_mtu = ibmvnic_change_mtu, 2282 .ndo_change_mtu = ibmvnic_change_mtu,
2299 .ndo_features_check = ibmvnic_features_check, 2283 .ndo_features_check = ibmvnic_features_check,
2300}; 2284};
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k.h b/drivers/net/ethernet/intel/fm10k/fm10k.h
index a903a0ba45e1..7d42582ed48d 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k.h
+++ b/drivers/net/ethernet/intel/fm10k/fm10k.h
@@ -504,9 +504,6 @@ void fm10k_update_stats(struct fm10k_intfc *interface);
504void fm10k_service_event_schedule(struct fm10k_intfc *interface); 504void fm10k_service_event_schedule(struct fm10k_intfc *interface);
505void fm10k_macvlan_schedule(struct fm10k_intfc *interface); 505void fm10k_macvlan_schedule(struct fm10k_intfc *interface);
506void fm10k_update_rx_drop_en(struct fm10k_intfc *interface); 506void fm10k_update_rx_drop_en(struct fm10k_intfc *interface);
507#ifdef CONFIG_NET_POLL_CONTROLLER
508void fm10k_netpoll(struct net_device *netdev);
509#endif
510 507
511/* Netdev */ 508/* Netdev */
512struct net_device *fm10k_alloc_netdev(const struct fm10k_info *info); 509struct net_device *fm10k_alloc_netdev(const struct fm10k_info *info);
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
index 929f538d28bc..538a8467f434 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
@@ -1648,9 +1648,6 @@ static const struct net_device_ops fm10k_netdev_ops = {
1648 .ndo_udp_tunnel_del = fm10k_udp_tunnel_del, 1648 .ndo_udp_tunnel_del = fm10k_udp_tunnel_del,
1649 .ndo_dfwd_add_station = fm10k_dfwd_add_station, 1649 .ndo_dfwd_add_station = fm10k_dfwd_add_station,
1650 .ndo_dfwd_del_station = fm10k_dfwd_del_station, 1650 .ndo_dfwd_del_station = fm10k_dfwd_del_station,
1651#ifdef CONFIG_NET_POLL_CONTROLLER
1652 .ndo_poll_controller = fm10k_netpoll,
1653#endif
1654 .ndo_features_check = fm10k_features_check, 1651 .ndo_features_check = fm10k_features_check,
1655}; 1652};
1656 1653
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 15071e4adb98..c859ababeed5 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -1210,28 +1210,6 @@ static irqreturn_t fm10k_msix_mbx_vf(int __always_unused irq, void *data)
1210 return IRQ_HANDLED; 1210 return IRQ_HANDLED;
1211} 1211}
1212 1212
1213#ifdef CONFIG_NET_POLL_CONTROLLER
1214/**
1215 * fm10k_netpoll - A Polling 'interrupt' handler
1216 * @netdev: network interface device structure
1217 *
1218 * This is used by netconsole to send skbs without having to re-enable
1219 * interrupts. It's not called while the normal interrupt routine is executing.
1220 **/
1221void fm10k_netpoll(struct net_device *netdev)
1222{
1223 struct fm10k_intfc *interface = netdev_priv(netdev);
1224 int i;
1225
1226 /* if interface is down do nothing */
1227 if (test_bit(__FM10K_DOWN, interface->state))
1228 return;
1229
1230 for (i = 0; i < interface->num_q_vectors; i++)
1231 fm10k_msix_clean_rings(0, interface->q_vector[i]);
1232}
1233
1234#endif
1235#define FM10K_ERR_MSG(type) case (type): error = #type; break 1213#define FM10K_ERR_MSG(type) case (type): error = #type; break
1236static void fm10k_handle_fault(struct fm10k_intfc *interface, int type, 1214static void fm10k_handle_fault(struct fm10k_intfc *interface, int type,
1237 struct fm10k_fault *fault) 1215 struct fm10k_fault *fault)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 5906c1c1d19d..fef6d892ed4c 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -396,29 +396,6 @@ static void i40evf_map_rings_to_vectors(struct i40evf_adapter *adapter)
396 adapter->aq_required |= I40EVF_FLAG_AQ_MAP_VECTORS; 396 adapter->aq_required |= I40EVF_FLAG_AQ_MAP_VECTORS;
397} 397}
398 398
399#ifdef CONFIG_NET_POLL_CONTROLLER
400/**
401 * i40evf_netpoll - A Polling 'interrupt' handler
402 * @netdev: network interface device structure
403 *
404 * This is used by netconsole to send skbs without having to re-enable
405 * interrupts. It's not called while the normal interrupt routine is executing.
406 **/
407static void i40evf_netpoll(struct net_device *netdev)
408{
409 struct i40evf_adapter *adapter = netdev_priv(netdev);
410 int q_vectors = adapter->num_msix_vectors - NONQ_VECS;
411 int i;
412
413 /* if interface is down do nothing */
414 if (test_bit(__I40E_VSI_DOWN, adapter->vsi.state))
415 return;
416
417 for (i = 0; i < q_vectors; i++)
418 i40evf_msix_clean_rings(0, &adapter->q_vectors[i]);
419}
420
421#endif
422/** 399/**
423 * i40evf_irq_affinity_notify - Callback for affinity changes 400 * i40evf_irq_affinity_notify - Callback for affinity changes
424 * @notify: context as to what irq was changed 401 * @notify: context as to what irq was changed
@@ -3229,9 +3206,6 @@ static const struct net_device_ops i40evf_netdev_ops = {
3229 .ndo_features_check = i40evf_features_check, 3206 .ndo_features_check = i40evf_features_check,
3230 .ndo_fix_features = i40evf_fix_features, 3207 .ndo_fix_features = i40evf_fix_features,
3231 .ndo_set_features = i40evf_set_features, 3208 .ndo_set_features = i40evf_set_features,
3232#ifdef CONFIG_NET_POLL_CONTROLLER
3233 .ndo_poll_controller = i40evf_netpoll,
3234#endif
3235 .ndo_setup_tc = i40evf_setup_tc, 3209 .ndo_setup_tc = i40evf_setup_tc,
3236}; 3210};
3237 3211
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index f1e80eed2fd6..3f047bb43348 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -4806,30 +4806,6 @@ void ice_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
4806 stats->rx_length_errors = vsi_stats->rx_length_errors; 4806 stats->rx_length_errors = vsi_stats->rx_length_errors;
4807} 4807}
4808 4808
4809#ifdef CONFIG_NET_POLL_CONTROLLER
4810/**
4811 * ice_netpoll - polling "interrupt" handler
4812 * @netdev: network interface device structure
4813 *
4814 * Used by netconsole to send skbs without having to re-enable interrupts.
4815 * This is not called in the normal interrupt path.
4816 */
4817static void ice_netpoll(struct net_device *netdev)
4818{
4819 struct ice_netdev_priv *np = netdev_priv(netdev);
4820 struct ice_vsi *vsi = np->vsi;
4821 struct ice_pf *pf = vsi->back;
4822 int i;
4823
4824 if (test_bit(__ICE_DOWN, vsi->state) ||
4825 !test_bit(ICE_FLAG_MSIX_ENA, pf->flags))
4826 return;
4827
4828 for (i = 0; i < vsi->num_q_vectors; i++)
4829 ice_msix_clean_rings(0, vsi->q_vectors[i]);
4830}
4831#endif /* CONFIG_NET_POLL_CONTROLLER */
4832
4833/** 4809/**
4834 * ice_napi_disable_all - Disable NAPI for all q_vectors in the VSI 4810 * ice_napi_disable_all - Disable NAPI for all q_vectors in the VSI
4835 * @vsi: VSI having NAPI disabled 4811 * @vsi: VSI having NAPI disabled
@@ -5497,9 +5473,6 @@ static const struct net_device_ops ice_netdev_ops = {
5497 .ndo_validate_addr = eth_validate_addr, 5473 .ndo_validate_addr = eth_validate_addr,
5498 .ndo_change_mtu = ice_change_mtu, 5474 .ndo_change_mtu = ice_change_mtu,
5499 .ndo_get_stats64 = ice_get_stats64, 5475 .ndo_get_stats64 = ice_get_stats64,
5500#ifdef CONFIG_NET_POLL_CONTROLLER
5501 .ndo_poll_controller = ice_netpoll,
5502#endif /* CONFIG_NET_POLL_CONTROLLER */
5503 .ndo_vlan_rx_add_vid = ice_vlan_rx_add_vid, 5476 .ndo_vlan_rx_add_vid = ice_vlan_rx_add_vid,
5504 .ndo_vlan_rx_kill_vid = ice_vlan_rx_kill_vid, 5477 .ndo_vlan_rx_kill_vid = ice_vlan_rx_kill_vid,
5505 .ndo_set_features = ice_set_features, 5478 .ndo_set_features = ice_set_features,
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index a32c576c1e65..0796cef96fa3 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -205,10 +205,6 @@ static struct notifier_block dca_notifier = {
205 .priority = 0 205 .priority = 0
206}; 206};
207#endif 207#endif
208#ifdef CONFIG_NET_POLL_CONTROLLER
209/* for netdump / net console */
210static void igb_netpoll(struct net_device *);
211#endif
212#ifdef CONFIG_PCI_IOV 208#ifdef CONFIG_PCI_IOV
213static unsigned int max_vfs; 209static unsigned int max_vfs;
214module_param(max_vfs, uint, 0); 210module_param(max_vfs, uint, 0);
@@ -2881,9 +2877,6 @@ static const struct net_device_ops igb_netdev_ops = {
2881 .ndo_set_vf_spoofchk = igb_ndo_set_vf_spoofchk, 2877 .ndo_set_vf_spoofchk = igb_ndo_set_vf_spoofchk,
2882 .ndo_set_vf_trust = igb_ndo_set_vf_trust, 2878 .ndo_set_vf_trust = igb_ndo_set_vf_trust,
2883 .ndo_get_vf_config = igb_ndo_get_vf_config, 2879 .ndo_get_vf_config = igb_ndo_get_vf_config,
2884#ifdef CONFIG_NET_POLL_CONTROLLER
2885 .ndo_poll_controller = igb_netpoll,
2886#endif
2887 .ndo_fix_features = igb_fix_features, 2880 .ndo_fix_features = igb_fix_features,
2888 .ndo_set_features = igb_set_features, 2881 .ndo_set_features = igb_set_features,
2889 .ndo_fdb_add = igb_ndo_fdb_add, 2882 .ndo_fdb_add = igb_ndo_fdb_add,
@@ -9053,29 +9046,6 @@ static int igb_pci_sriov_configure(struct pci_dev *dev, int num_vfs)
9053 return 0; 9046 return 0;
9054} 9047}
9055 9048
9056#ifdef CONFIG_NET_POLL_CONTROLLER
9057/* Polling 'interrupt' - used by things like netconsole to send skbs
9058 * without having to re-enable interrupts. It's not called while
9059 * the interrupt routine is executing.
9060 */
9061static void igb_netpoll(struct net_device *netdev)
9062{
9063 struct igb_adapter *adapter = netdev_priv(netdev);
9064 struct e1000_hw *hw = &adapter->hw;
9065 struct igb_q_vector *q_vector;
9066 int i;
9067
9068 for (i = 0; i < adapter->num_q_vectors; i++) {
9069 q_vector = adapter->q_vector[i];
9070 if (adapter->flags & IGB_FLAG_HAS_MSIX)
9071 wr32(E1000_EIMC, q_vector->eims_value);
9072 else
9073 igb_irq_disable(adapter);
9074 napi_schedule(&q_vector->napi);
9075 }
9076}
9077#endif /* CONFIG_NET_POLL_CONTROLLER */
9078
9079/** 9049/**
9080 * igb_io_error_detected - called when PCI error is detected 9050 * igb_io_error_detected - called when PCI error is detected
9081 * @pdev: Pointer to PCI device 9051 * @pdev: Pointer to PCI device
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
index d3e72d0f66ef..7722153c4ac2 100644
--- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
+++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
@@ -81,11 +81,6 @@ static int ixgb_vlan_rx_kill_vid(struct net_device *netdev,
81 __be16 proto, u16 vid); 81 __be16 proto, u16 vid);
82static void ixgb_restore_vlan(struct ixgb_adapter *adapter); 82static void ixgb_restore_vlan(struct ixgb_adapter *adapter);
83 83
84#ifdef CONFIG_NET_POLL_CONTROLLER
85/* for netdump / net console */
86static void ixgb_netpoll(struct net_device *dev);
87#endif
88
89static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev, 84static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev,
90 enum pci_channel_state state); 85 enum pci_channel_state state);
91static pci_ers_result_t ixgb_io_slot_reset (struct pci_dev *pdev); 86static pci_ers_result_t ixgb_io_slot_reset (struct pci_dev *pdev);
@@ -348,9 +343,6 @@ static const struct net_device_ops ixgb_netdev_ops = {
348 .ndo_tx_timeout = ixgb_tx_timeout, 343 .ndo_tx_timeout = ixgb_tx_timeout,
349 .ndo_vlan_rx_add_vid = ixgb_vlan_rx_add_vid, 344 .ndo_vlan_rx_add_vid = ixgb_vlan_rx_add_vid,
350 .ndo_vlan_rx_kill_vid = ixgb_vlan_rx_kill_vid, 345 .ndo_vlan_rx_kill_vid = ixgb_vlan_rx_kill_vid,
351#ifdef CONFIG_NET_POLL_CONTROLLER
352 .ndo_poll_controller = ixgb_netpoll,
353#endif
354 .ndo_fix_features = ixgb_fix_features, 346 .ndo_fix_features = ixgb_fix_features,
355 .ndo_set_features = ixgb_set_features, 347 .ndo_set_features = ixgb_set_features,
356}; 348};
@@ -2195,23 +2187,6 @@ ixgb_restore_vlan(struct ixgb_adapter *adapter)
2195 ixgb_vlan_rx_add_vid(adapter->netdev, htons(ETH_P_8021Q), vid); 2187 ixgb_vlan_rx_add_vid(adapter->netdev, htons(ETH_P_8021Q), vid);
2196} 2188}
2197 2189
2198#ifdef CONFIG_NET_POLL_CONTROLLER
2199/*
2200 * Polling 'interrupt' - used by things like netconsole to send skbs
2201 * without having to re-enable interrupts. It's not called while
2202 * the interrupt routine is executing.
2203 */
2204
2205static void ixgb_netpoll(struct net_device *dev)
2206{
2207 struct ixgb_adapter *adapter = netdev_priv(dev);
2208
2209 disable_irq(adapter->pdev->irq);
2210 ixgb_intr(adapter->pdev->irq, dev);
2211 enable_irq(adapter->pdev->irq);
2212}
2213#endif
2214
2215/** 2190/**
2216 * ixgb_io_error_detected - called when PCI error is detected 2191 * ixgb_io_error_detected - called when PCI error is detected
2217 * @pdev: pointer to pci device with error 2192 * @pdev: pointer to pci device with error
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 9a23d33a47ed..6cdd58d9d461 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -3196,11 +3196,13 @@ int ixgbe_poll(struct napi_struct *napi, int budget)
3196 return budget; 3196 return budget;
3197 3197
3198 /* all work done, exit the polling mode */ 3198 /* all work done, exit the polling mode */
3199 napi_complete_done(napi, work_done); 3199 if (likely(napi_complete_done(napi, work_done))) {
3200 if (adapter->rx_itr_setting & 1) 3200 if (adapter->rx_itr_setting & 1)
3201 ixgbe_set_itr(q_vector); 3201 ixgbe_set_itr(q_vector);
3202 if (!test_bit(__IXGBE_DOWN, &adapter->state)) 3202 if (!test_bit(__IXGBE_DOWN, &adapter->state))
3203 ixgbe_irq_enable_queues(adapter, BIT_ULL(q_vector->v_idx)); 3203 ixgbe_irq_enable_queues(adapter,
3204 BIT_ULL(q_vector->v_idx));
3205 }
3204 3206
3205 return min(work_done, budget - 1); 3207 return min(work_done, budget - 1);
3206} 3208}
@@ -8768,28 +8770,6 @@ static int ixgbe_del_sanmac_netdev(struct net_device *dev)
8768 return err; 8770 return err;
8769} 8771}
8770 8772
8771#ifdef CONFIG_NET_POLL_CONTROLLER
8772/*
8773 * Polling 'interrupt' - used by things like netconsole to send skbs
8774 * without having to re-enable interrupts. It's not called while
8775 * the interrupt routine is executing.
8776 */
8777static void ixgbe_netpoll(struct net_device *netdev)
8778{
8779 struct ixgbe_adapter *adapter = netdev_priv(netdev);
8780 int i;
8781
8782 /* if interface is down do nothing */
8783 if (test_bit(__IXGBE_DOWN, &adapter->state))
8784 return;
8785
8786 /* loop through and schedule all active queues */
8787 for (i = 0; i < adapter->num_q_vectors; i++)
8788 ixgbe_msix_clean_rings(0, adapter->q_vector[i]);
8789}
8790
8791#endif
8792
8793static void ixgbe_get_ring_stats64(struct rtnl_link_stats64 *stats, 8773static void ixgbe_get_ring_stats64(struct rtnl_link_stats64 *stats,
8794 struct ixgbe_ring *ring) 8774 struct ixgbe_ring *ring)
8795{ 8775{
@@ -10251,9 +10231,6 @@ static const struct net_device_ops ixgbe_netdev_ops = {
10251 .ndo_get_vf_config = ixgbe_ndo_get_vf_config, 10231 .ndo_get_vf_config = ixgbe_ndo_get_vf_config,
10252 .ndo_get_stats64 = ixgbe_get_stats64, 10232 .ndo_get_stats64 = ixgbe_get_stats64,
10253 .ndo_setup_tc = __ixgbe_setup_tc, 10233 .ndo_setup_tc = __ixgbe_setup_tc,
10254#ifdef CONFIG_NET_POLL_CONTROLLER
10255 .ndo_poll_controller = ixgbe_netpoll,
10256#endif
10257#ifdef IXGBE_FCOE 10234#ifdef IXGBE_FCOE
10258 .ndo_select_queue = ixgbe_select_queue, 10235 .ndo_select_queue = ixgbe_select_queue,
10259 .ndo_fcoe_ddp_setup = ixgbe_fcoe_ddp_get, 10236 .ndo_fcoe_ddp_setup = ixgbe_fcoe_ddp_get,
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index d86446d202d5..5a228582423b 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -4233,24 +4233,6 @@ static int ixgbevf_change_mtu(struct net_device *netdev, int new_mtu)
4233 return 0; 4233 return 0;
4234} 4234}
4235 4235
4236#ifdef CONFIG_NET_POLL_CONTROLLER
4237/* Polling 'interrupt' - used by things like netconsole to send skbs
4238 * without having to re-enable interrupts. It's not called while
4239 * the interrupt routine is executing.
4240 */
4241static void ixgbevf_netpoll(struct net_device *netdev)
4242{
4243 struct ixgbevf_adapter *adapter = netdev_priv(netdev);
4244 int i;
4245
4246 /* if interface is down do nothing */
4247 if (test_bit(__IXGBEVF_DOWN, &adapter->state))
4248 return;
4249 for (i = 0; i < adapter->num_rx_queues; i++)
4250 ixgbevf_msix_clean_rings(0, adapter->q_vector[i]);
4251}
4252#endif /* CONFIG_NET_POLL_CONTROLLER */
4253
4254static int ixgbevf_suspend(struct pci_dev *pdev, pm_message_t state) 4236static int ixgbevf_suspend(struct pci_dev *pdev, pm_message_t state)
4255{ 4237{
4256 struct net_device *netdev = pci_get_drvdata(pdev); 4238 struct net_device *netdev = pci_get_drvdata(pdev);
@@ -4482,9 +4464,6 @@ static const struct net_device_ops ixgbevf_netdev_ops = {
4482 .ndo_tx_timeout = ixgbevf_tx_timeout, 4464 .ndo_tx_timeout = ixgbevf_tx_timeout,
4483 .ndo_vlan_rx_add_vid = ixgbevf_vlan_rx_add_vid, 4465 .ndo_vlan_rx_add_vid = ixgbevf_vlan_rx_add_vid,
4484 .ndo_vlan_rx_kill_vid = ixgbevf_vlan_rx_kill_vid, 4466 .ndo_vlan_rx_kill_vid = ixgbevf_vlan_rx_kill_vid,
4485#ifdef CONFIG_NET_POLL_CONTROLLER
4486 .ndo_poll_controller = ixgbevf_netpoll,
4487#endif
4488 .ndo_features_check = ixgbevf_features_check, 4467 .ndo_features_check = ixgbevf_features_check,
4489 .ndo_bpf = ixgbevf_xdp, 4468 .ndo_bpf = ixgbevf_xdp,
4490}; 4469};
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 7a637b51c7d2..e08301d833e2 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -274,6 +274,7 @@ ltq_etop_hw_init(struct net_device *dev)
274 struct ltq_etop_chan *ch = &priv->ch[i]; 274 struct ltq_etop_chan *ch = &priv->ch[i];
275 275
276 ch->idx = ch->dma.nr = i; 276 ch->idx = ch->dma.nr = i;
277 ch->dma.dev = &priv->pdev->dev;
277 278
278 if (IS_TX(i)) { 279 if (IS_TX(i)) {
279 ltq_dma_alloc_tx(&ch->dma); 280 ltq_dma_alloc_tx(&ch->dma);
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index bc80a678abc3..b4ed7d394d07 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -1890,8 +1890,8 @@ static void mvneta_rxq_drop_pkts(struct mvneta_port *pp,
1890 if (!data || !(rx_desc->buf_phys_addr)) 1890 if (!data || !(rx_desc->buf_phys_addr))
1891 continue; 1891 continue;
1892 1892
1893 dma_unmap_single(pp->dev->dev.parent, rx_desc->buf_phys_addr, 1893 dma_unmap_page(pp->dev->dev.parent, rx_desc->buf_phys_addr,
1894 MVNETA_RX_BUF_SIZE(pp->pkt_size), DMA_FROM_DEVICE); 1894 PAGE_SIZE, DMA_FROM_DEVICE);
1895 __free_page(data); 1895 __free_page(data);
1896 } 1896 }
1897} 1897}
@@ -2008,8 +2008,8 @@ static int mvneta_rx_swbm(struct napi_struct *napi,
2008 skb_add_rx_frag(rxq->skb, frag_num, page, 2008 skb_add_rx_frag(rxq->skb, frag_num, page,
2009 frag_offset, frag_size, 2009 frag_offset, frag_size,
2010 PAGE_SIZE); 2010 PAGE_SIZE);
2011 dma_unmap_single(dev->dev.parent, phys_addr, 2011 dma_unmap_page(dev->dev.parent, phys_addr,
2012 PAGE_SIZE, DMA_FROM_DEVICE); 2012 PAGE_SIZE, DMA_FROM_DEVICE);
2013 rxq->left_size -= frag_size; 2013 rxq->left_size -= frag_size;
2014 } 2014 }
2015 } else { 2015 } else {
@@ -2039,9 +2039,8 @@ static int mvneta_rx_swbm(struct napi_struct *napi,
2039 frag_offset, frag_size, 2039 frag_offset, frag_size,
2040 PAGE_SIZE); 2040 PAGE_SIZE);
2041 2041
2042 dma_unmap_single(dev->dev.parent, phys_addr, 2042 dma_unmap_page(dev->dev.parent, phys_addr,
2043 PAGE_SIZE, 2043 PAGE_SIZE, DMA_FROM_DEVICE);
2044 DMA_FROM_DEVICE);
2045 2044
2046 rxq->left_size -= frag_size; 2045 rxq->left_size -= frag_size;
2047 } 2046 }
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 28500417843e..a74002b43b51 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -58,6 +58,8 @@ static struct {
58 */ 58 */
59static void mvpp2_mac_config(struct net_device *dev, unsigned int mode, 59static void mvpp2_mac_config(struct net_device *dev, unsigned int mode,
60 const struct phylink_link_state *state); 60 const struct phylink_link_state *state);
61static void mvpp2_mac_link_up(struct net_device *dev, unsigned int mode,
62 phy_interface_t interface, struct phy_device *phy);
61 63
62/* Queue modes */ 64/* Queue modes */
63#define MVPP2_QDIST_SINGLE_MODE 0 65#define MVPP2_QDIST_SINGLE_MODE 0
@@ -1723,7 +1725,7 @@ static void mvpp2_txq_desc_put(struct mvpp2_tx_queue *txq)
1723} 1725}
1724 1726
1725/* Set Tx descriptors fields relevant for CSUM calculation */ 1727/* Set Tx descriptors fields relevant for CSUM calculation */
1726static u32 mvpp2_txq_desc_csum(int l3_offs, int l3_proto, 1728static u32 mvpp2_txq_desc_csum(int l3_offs, __be16 l3_proto,
1727 int ip_hdr_len, int l4_proto) 1729 int ip_hdr_len, int l4_proto)
1728{ 1730{
1729 u32 command; 1731 u32 command;
@@ -2598,14 +2600,15 @@ static u32 mvpp2_skb_tx_csum(struct mvpp2_port *port, struct sk_buff *skb)
2598 if (skb->ip_summed == CHECKSUM_PARTIAL) { 2600 if (skb->ip_summed == CHECKSUM_PARTIAL) {
2599 int ip_hdr_len = 0; 2601 int ip_hdr_len = 0;
2600 u8 l4_proto; 2602 u8 l4_proto;
2603 __be16 l3_proto = vlan_get_protocol(skb);
2601 2604
2602 if (skb->protocol == htons(ETH_P_IP)) { 2605 if (l3_proto == htons(ETH_P_IP)) {
2603 struct iphdr *ip4h = ip_hdr(skb); 2606 struct iphdr *ip4h = ip_hdr(skb);
2604 2607
2605 /* Calculate IPv4 checksum and L4 checksum */ 2608 /* Calculate IPv4 checksum and L4 checksum */
2606 ip_hdr_len = ip4h->ihl; 2609 ip_hdr_len = ip4h->ihl;
2607 l4_proto = ip4h->protocol; 2610 l4_proto = ip4h->protocol;
2608 } else if (skb->protocol == htons(ETH_P_IPV6)) { 2611 } else if (l3_proto == htons(ETH_P_IPV6)) {
2609 struct ipv6hdr *ip6h = ipv6_hdr(skb); 2612 struct ipv6hdr *ip6h = ipv6_hdr(skb);
2610 2613
2611 /* Read l4_protocol from one of IPv6 extra headers */ 2614 /* Read l4_protocol from one of IPv6 extra headers */
@@ -2617,7 +2620,7 @@ static u32 mvpp2_skb_tx_csum(struct mvpp2_port *port, struct sk_buff *skb)
2617 } 2620 }
2618 2621
2619 return mvpp2_txq_desc_csum(skb_network_offset(skb), 2622 return mvpp2_txq_desc_csum(skb_network_offset(skb),
2620 skb->protocol, ip_hdr_len, l4_proto); 2623 l3_proto, ip_hdr_len, l4_proto);
2621 } 2624 }
2622 2625
2623 return MVPP2_TXD_L4_CSUM_NOT | MVPP2_TXD_IP_CSUM_DISABLE; 2626 return MVPP2_TXD_L4_CSUM_NOT | MVPP2_TXD_IP_CSUM_DISABLE;
@@ -3053,10 +3056,12 @@ static int mvpp2_poll(struct napi_struct *napi, int budget)
3053 cause_rx_tx & ~MVPP2_CAUSE_MISC_SUM_MASK); 3056 cause_rx_tx & ~MVPP2_CAUSE_MISC_SUM_MASK);
3054 } 3057 }
3055 3058
3056 cause_tx = cause_rx_tx & MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK; 3059 if (port->has_tx_irqs) {
3057 if (cause_tx) { 3060 cause_tx = cause_rx_tx & MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK;
3058 cause_tx >>= MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_OFFSET; 3061 if (cause_tx) {
3059 mvpp2_tx_done(port, cause_tx, qv->sw_thread_id); 3062 cause_tx >>= MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_OFFSET;
3063 mvpp2_tx_done(port, cause_tx, qv->sw_thread_id);
3064 }
3060 } 3065 }
3061 3066
3062 /* Process RX packets */ 3067 /* Process RX packets */
@@ -3142,6 +3147,7 @@ static void mvpp2_start_dev(struct mvpp2_port *port)
3142 mvpp22_mode_reconfigure(port); 3147 mvpp22_mode_reconfigure(port);
3143 3148
3144 if (port->phylink) { 3149 if (port->phylink) {
3150 netif_carrier_off(port->dev);
3145 phylink_start(port->phylink); 3151 phylink_start(port->phylink);
3146 } else { 3152 } else {
3147 /* Phylink isn't used as of now for ACPI, so the MAC has to be 3153 /* Phylink isn't used as of now for ACPI, so the MAC has to be
@@ -3150,9 +3156,10 @@ static void mvpp2_start_dev(struct mvpp2_port *port)
3150 */ 3156 */
3151 struct phylink_link_state state = { 3157 struct phylink_link_state state = {
3152 .interface = port->phy_interface, 3158 .interface = port->phy_interface,
3153 .link = 1,
3154 }; 3159 };
3155 mvpp2_mac_config(port->dev, MLO_AN_INBAND, &state); 3160 mvpp2_mac_config(port->dev, MLO_AN_INBAND, &state);
3161 mvpp2_mac_link_up(port->dev, MLO_AN_INBAND, port->phy_interface,
3162 NULL);
3156 } 3163 }
3157 3164
3158 netif_tx_start_all_queues(port->dev); 3165 netif_tx_start_all_queues(port->dev);
@@ -4495,10 +4502,6 @@ static void mvpp2_mac_config(struct net_device *dev, unsigned int mode,
4495 return; 4502 return;
4496 } 4503 }
4497 4504
4498 netif_tx_stop_all_queues(port->dev);
4499 if (!port->has_phy)
4500 netif_carrier_off(port->dev);
4501
4502 /* Make sure the port is disabled when reconfiguring the mode */ 4505 /* Make sure the port is disabled when reconfiguring the mode */
4503 mvpp2_port_disable(port); 4506 mvpp2_port_disable(port);
4504 4507
@@ -4523,16 +4526,7 @@ static void mvpp2_mac_config(struct net_device *dev, unsigned int mode,
4523 if (port->priv->hw_version == MVPP21 && port->flags & MVPP2_F_LOOPBACK) 4526 if (port->priv->hw_version == MVPP21 && port->flags & MVPP2_F_LOOPBACK)
4524 mvpp2_port_loopback_set(port, state); 4527 mvpp2_port_loopback_set(port, state);
4525 4528
4526 /* If the port already was up, make sure it's still in the same state */ 4529 mvpp2_port_enable(port);
4527 if (state->link || !port->has_phy) {
4528 mvpp2_port_enable(port);
4529
4530 mvpp2_egress_enable(port);
4531 mvpp2_ingress_enable(port);
4532 if (!port->has_phy)
4533 netif_carrier_on(dev);
4534 netif_tx_wake_all_queues(dev);
4535 }
4536} 4530}
4537 4531
4538static void mvpp2_mac_link_up(struct net_device *dev, unsigned int mode, 4532static void mvpp2_mac_link_up(struct net_device *dev, unsigned int mode,
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 6785661d1a72..fe49384eba48 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1286,20 +1286,6 @@ out:
1286 mutex_unlock(&mdev->state_lock); 1286 mutex_unlock(&mdev->state_lock);
1287} 1287}
1288 1288
1289#ifdef CONFIG_NET_POLL_CONTROLLER
1290static void mlx4_en_netpoll(struct net_device *dev)
1291{
1292 struct mlx4_en_priv *priv = netdev_priv(dev);
1293 struct mlx4_en_cq *cq;
1294 int i;
1295
1296 for (i = 0; i < priv->tx_ring_num[TX]; i++) {
1297 cq = priv->tx_cq[TX][i];
1298 napi_schedule(&cq->napi);
1299 }
1300}
1301#endif
1302
1303static int mlx4_en_set_rss_steer_rules(struct mlx4_en_priv *priv) 1289static int mlx4_en_set_rss_steer_rules(struct mlx4_en_priv *priv)
1304{ 1290{
1305 u64 reg_id; 1291 u64 reg_id;
@@ -2946,9 +2932,6 @@ static const struct net_device_ops mlx4_netdev_ops = {
2946 .ndo_tx_timeout = mlx4_en_tx_timeout, 2932 .ndo_tx_timeout = mlx4_en_tx_timeout,
2947 .ndo_vlan_rx_add_vid = mlx4_en_vlan_rx_add_vid, 2933 .ndo_vlan_rx_add_vid = mlx4_en_vlan_rx_add_vid,
2948 .ndo_vlan_rx_kill_vid = mlx4_en_vlan_rx_kill_vid, 2934 .ndo_vlan_rx_kill_vid = mlx4_en_vlan_rx_kill_vid,
2949#ifdef CONFIG_NET_POLL_CONTROLLER
2950 .ndo_poll_controller = mlx4_en_netpoll,
2951#endif
2952 .ndo_set_features = mlx4_en_set_features, 2935 .ndo_set_features = mlx4_en_set_features,
2953 .ndo_fix_features = mlx4_en_fix_features, 2936 .ndo_fix_features = mlx4_en_fix_features,
2954 .ndo_setup_tc = __mlx4_en_setup_tc, 2937 .ndo_setup_tc = __mlx4_en_setup_tc,
@@ -2983,9 +2966,6 @@ static const struct net_device_ops mlx4_netdev_ops_master = {
2983 .ndo_set_vf_link_state = mlx4_en_set_vf_link_state, 2966 .ndo_set_vf_link_state = mlx4_en_set_vf_link_state,
2984 .ndo_get_vf_stats = mlx4_en_get_vf_stats, 2967 .ndo_get_vf_stats = mlx4_en_get_vf_stats,
2985 .ndo_get_vf_config = mlx4_en_get_vf_config, 2968 .ndo_get_vf_config = mlx4_en_get_vf_config,
2986#ifdef CONFIG_NET_POLL_CONTROLLER
2987 .ndo_poll_controller = mlx4_en_netpoll,
2988#endif
2989 .ndo_set_features = mlx4_en_set_features, 2969 .ndo_set_features = mlx4_en_set_features,
2990 .ndo_fix_features = mlx4_en_fix_features, 2970 .ndo_fix_features = mlx4_en_fix_features,
2991 .ndo_setup_tc = __mlx4_en_setup_tc, 2971 .ndo_setup_tc = __mlx4_en_setup_tc,
diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 1f3372c1802e..2df92dbd38e1 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -240,7 +240,8 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec)
240 struct mlx4_dev *dev = &priv->dev; 240 struct mlx4_dev *dev = &priv->dev;
241 struct mlx4_eq *eq = &priv->eq_table.eq[vec]; 241 struct mlx4_eq *eq = &priv->eq_table.eq[vec];
242 242
243 if (!eq->affinity_mask || cpumask_empty(eq->affinity_mask)) 243 if (!cpumask_available(eq->affinity_mask) ||
244 cpumask_empty(eq->affinity_mask))
244 return; 245 return;
245 246
246 hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask); 247 hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask);
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index d2d59444f562..6a046030e873 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -260,47 +260,34 @@ static const struct devlink_param mlx4_devlink_params[] = {
260 NULL, NULL, NULL), 260 NULL, NULL, NULL),
261}; 261};
262 262
263static void mlx4_devlink_set_init_value(struct devlink *devlink, u32 param_id,
264 union devlink_param_value init_val)
265{
266 struct mlx4_priv *priv = devlink_priv(devlink);
267 struct mlx4_dev *dev = &priv->dev;
268 int err;
269
270 err = devlink_param_driverinit_value_set(devlink, param_id, init_val);
271 if (err)
272 mlx4_warn(dev,
273 "devlink set parameter %u value failed (err = %d)",
274 param_id, err);
275}
276
277static void mlx4_devlink_set_params_init_values(struct devlink *devlink) 263static void mlx4_devlink_set_params_init_values(struct devlink *devlink)
278{ 264{
279 union devlink_param_value value; 265 union devlink_param_value value;
280 266
281 value.vbool = !!mlx4_internal_err_reset; 267 value.vbool = !!mlx4_internal_err_reset;
282 mlx4_devlink_set_init_value(devlink, 268 devlink_param_driverinit_value_set(devlink,
283 DEVLINK_PARAM_GENERIC_ID_INT_ERR_RESET, 269 DEVLINK_PARAM_GENERIC_ID_INT_ERR_RESET,
284 value); 270 value);
285 271
286 value.vu32 = 1UL << log_num_mac; 272 value.vu32 = 1UL << log_num_mac;
287 mlx4_devlink_set_init_value(devlink, 273 devlink_param_driverinit_value_set(devlink,
288 DEVLINK_PARAM_GENERIC_ID_MAX_MACS, value); 274 DEVLINK_PARAM_GENERIC_ID_MAX_MACS,
275 value);
289 276
290 value.vbool = enable_64b_cqe_eqe; 277 value.vbool = enable_64b_cqe_eqe;
291 mlx4_devlink_set_init_value(devlink, 278 devlink_param_driverinit_value_set(devlink,
292 MLX4_DEVLINK_PARAM_ID_ENABLE_64B_CQE_EQE, 279 MLX4_DEVLINK_PARAM_ID_ENABLE_64B_CQE_EQE,
293 value); 280 value);
294 281
295 value.vbool = enable_4k_uar; 282 value.vbool = enable_4k_uar;
296 mlx4_devlink_set_init_value(devlink, 283 devlink_param_driverinit_value_set(devlink,
297 MLX4_DEVLINK_PARAM_ID_ENABLE_4K_UAR, 284 MLX4_DEVLINK_PARAM_ID_ENABLE_4K_UAR,
298 value); 285 value);
299 286
300 value.vbool = false; 287 value.vbool = false;
301 mlx4_devlink_set_init_value(devlink, 288 devlink_param_driverinit_value_set(devlink,
302 DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT, 289 DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT,
303 value); 290 value);
304} 291}
305 292
306static inline void mlx4_set_num_reserved_uars(struct mlx4_dev *dev, 293static inline void mlx4_set_num_reserved_uars(struct mlx4_dev *dev,
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
index 3ce14d42ddc8..a53736c26c0c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
@@ -206,7 +206,7 @@ static void poll_timeout(struct mlx5_cmd_work_ent *ent)
206 u8 own; 206 u8 own;
207 207
208 do { 208 do {
209 own = ent->lay->status_own; 209 own = READ_ONCE(ent->lay->status_own);
210 if (!(own & CMD_OWNER_HW)) { 210 if (!(own & CMD_OWNER_HW)) {
211 ent->ret = 0; 211 ent->ret = 0;
212 return; 212 return;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/dev.c b/drivers/net/ethernet/mellanox/mlx5/core/dev.c
index b994b80d5714..37ba7c78859d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/dev.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/dev.c
@@ -132,11 +132,11 @@ void mlx5_add_device(struct mlx5_interface *intf, struct mlx5_priv *priv)
132 delayed_event_start(priv); 132 delayed_event_start(priv);
133 133
134 dev_ctx->context = intf->add(dev); 134 dev_ctx->context = intf->add(dev);
135 set_bit(MLX5_INTERFACE_ADDED, &dev_ctx->state);
136 if (intf->attach)
137 set_bit(MLX5_INTERFACE_ATTACHED, &dev_ctx->state);
138
139 if (dev_ctx->context) { 135 if (dev_ctx->context) {
136 set_bit(MLX5_INTERFACE_ADDED, &dev_ctx->state);
137 if (intf->attach)
138 set_bit(MLX5_INTERFACE_ATTACHED, &dev_ctx->state);
139
140 spin_lock_irq(&priv->ctx_lock); 140 spin_lock_irq(&priv->ctx_lock);
141 list_add_tail(&dev_ctx->list, &priv->ctx_list); 141 list_add_tail(&dev_ctx->list, &priv->ctx_list);
142 142
@@ -211,12 +211,17 @@ static void mlx5_attach_interface(struct mlx5_interface *intf, struct mlx5_priv
211 if (intf->attach) { 211 if (intf->attach) {
212 if (test_bit(MLX5_INTERFACE_ATTACHED, &dev_ctx->state)) 212 if (test_bit(MLX5_INTERFACE_ATTACHED, &dev_ctx->state))
213 goto out; 213 goto out;
214 intf->attach(dev, dev_ctx->context); 214 if (intf->attach(dev, dev_ctx->context))
215 goto out;
216
215 set_bit(MLX5_INTERFACE_ATTACHED, &dev_ctx->state); 217 set_bit(MLX5_INTERFACE_ATTACHED, &dev_ctx->state);
216 } else { 218 } else {
217 if (test_bit(MLX5_INTERFACE_ADDED, &dev_ctx->state)) 219 if (test_bit(MLX5_INTERFACE_ADDED, &dev_ctx->state))
218 goto out; 220 goto out;
219 dev_ctx->context = intf->add(dev); 221 dev_ctx->context = intf->add(dev);
222 if (!dev_ctx->context)
223 goto out;
224
220 set_bit(MLX5_INTERFACE_ADDED, &dev_ctx->state); 225 set_bit(MLX5_INTERFACE_ADDED, &dev_ctx->state);
221 } 226 }
222 227
@@ -391,16 +396,17 @@ void mlx5_remove_dev_by_protocol(struct mlx5_core_dev *dev, int protocol)
391 } 396 }
392} 397}
393 398
394static u16 mlx5_gen_pci_id(struct mlx5_core_dev *dev) 399static u32 mlx5_gen_pci_id(struct mlx5_core_dev *dev)
395{ 400{
396 return (u16)((dev->pdev->bus->number << 8) | 401 return (u32)((pci_domain_nr(dev->pdev->bus) << 16) |
402 (dev->pdev->bus->number << 8) |
397 PCI_SLOT(dev->pdev->devfn)); 403 PCI_SLOT(dev->pdev->devfn));
398} 404}
399 405
400/* Must be called with intf_mutex held */ 406/* Must be called with intf_mutex held */
401struct mlx5_core_dev *mlx5_get_next_phys_dev(struct mlx5_core_dev *dev) 407struct mlx5_core_dev *mlx5_get_next_phys_dev(struct mlx5_core_dev *dev)
402{ 408{
403 u16 pci_id = mlx5_gen_pci_id(dev); 409 u32 pci_id = mlx5_gen_pci_id(dev);
404 struct mlx5_core_dev *res = NULL; 410 struct mlx5_core_dev *res = NULL;
405 struct mlx5_core_dev *tmp_dev; 411 struct mlx5_core_dev *tmp_dev;
406 struct mlx5_priv *priv; 412 struct mlx5_priv *priv;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
index db2cfcd21d43..0f189f873859 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
@@ -54,6 +54,7 @@
54#include "en_stats.h" 54#include "en_stats.h"
55#include "en/fs.h" 55#include "en/fs.h"
56 56
57extern const struct net_device_ops mlx5e_netdev_ops;
57struct page_pool; 58struct page_pool;
58 59
59#define MLX5E_METADATA_ETHER_TYPE (0x8CE4) 60#define MLX5E_METADATA_ETHER_TYPE (0x8CE4)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h b/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h
index bbf69e859b78..1431232c9a09 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h
@@ -16,6 +16,8 @@ struct mlx5e_tc_table {
16 16
17 DECLARE_HASHTABLE(mod_hdr_tbl, 8); 17 DECLARE_HASHTABLE(mod_hdr_tbl, 8);
18 DECLARE_HASHTABLE(hairpin_tbl, 8); 18 DECLARE_HASHTABLE(hairpin_tbl, 8);
19
20 struct notifier_block netdevice_nb;
19}; 21};
20 22
21struct mlx5e_flow_table { 23struct mlx5e_flow_table {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
index eddd7702680b..e88340e196f7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
@@ -183,12 +183,13 @@ static const struct tlsdev_ops mlx5e_tls_ops = {
183 183
184void mlx5e_tls_build_netdev(struct mlx5e_priv *priv) 184void mlx5e_tls_build_netdev(struct mlx5e_priv *priv)
185{ 185{
186 u32 caps = mlx5_accel_tls_device_caps(priv->mdev);
187 struct net_device *netdev = priv->netdev; 186 struct net_device *netdev = priv->netdev;
187 u32 caps;
188 188
189 if (!mlx5_accel_is_tls_device(priv->mdev)) 189 if (!mlx5_accel_is_tls_device(priv->mdev))
190 return; 190 return;
191 191
192 caps = mlx5_accel_tls_device_caps(priv->mdev);
192 if (caps & MLX5_ACCEL_TLS_TX) { 193 if (caps & MLX5_ACCEL_TLS_TX) {
193 netdev->features |= NETIF_F_HW_TLS_TX; 194 netdev->features |= NETIF_F_HW_TLS_TX;
194 netdev->hw_features |= NETIF_F_HW_TLS_TX; 195 netdev->hw_features |= NETIF_F_HW_TLS_TX;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c
index 75bb981e00b7..41cde926cdab 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c
@@ -191,7 +191,7 @@ set_udp(void *headers_c, void *headers_v, __be16 psrc_m, __be16 psrc_v,
191{ 191{
192 if (psrc_m) { 192 if (psrc_m) {
193 MLX5E_FTE_SET(headers_c, udp_sport, 0xffff); 193 MLX5E_FTE_SET(headers_c, udp_sport, 0xffff);
194 MLX5E_FTE_SET(headers_c, udp_sport, ntohs(psrc_v)); 194 MLX5E_FTE_SET(headers_v, udp_sport, ntohs(psrc_v));
195 } 195 }
196 196
197 if (pdst_m) { 197 if (pdst_m) {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 5a7939e70190..f291d1bf1558 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -4315,23 +4315,7 @@ static int mlx5e_xdp(struct net_device *dev, struct netdev_bpf *xdp)
4315 } 4315 }
4316} 4316}
4317 4317
4318#ifdef CONFIG_NET_POLL_CONTROLLER 4318const struct net_device_ops mlx5e_netdev_ops = {
4319/* Fake "interrupt" called by netpoll (eg netconsole) to send skbs without
4320 * reenabling interrupts.
4321 */
4322static void mlx5e_netpoll(struct net_device *dev)
4323{
4324 struct mlx5e_priv *priv = netdev_priv(dev);
4325 struct mlx5e_channels *chs = &priv->channels;
4326
4327 int i;
4328
4329 for (i = 0; i < chs->num; i++)
4330 napi_schedule(&chs->c[i]->napi);
4331}
4332#endif
4333
4334static const struct net_device_ops mlx5e_netdev_ops = {
4335 .ndo_open = mlx5e_open, 4319 .ndo_open = mlx5e_open,
4336 .ndo_stop = mlx5e_close, 4320 .ndo_stop = mlx5e_close,
4337 .ndo_start_xmit = mlx5e_xmit, 4321 .ndo_start_xmit = mlx5e_xmit,
@@ -4356,9 +4340,6 @@ static const struct net_device_ops mlx5e_netdev_ops = {
4356#ifdef CONFIG_MLX5_EN_ARFS 4340#ifdef CONFIG_MLX5_EN_ARFS
4357 .ndo_rx_flow_steer = mlx5e_rx_flow_steer, 4341 .ndo_rx_flow_steer = mlx5e_rx_flow_steer,
4358#endif 4342#endif
4359#ifdef CONFIG_NET_POLL_CONTROLLER
4360 .ndo_poll_controller = mlx5e_netpoll,
4361#endif
4362#ifdef CONFIG_MLX5_ESWITCH 4343#ifdef CONFIG_MLX5_ESWITCH
4363 /* SRIOV E-Switch NDOs */ 4344 /* SRIOV E-Switch NDOs */
4364 .ndo_set_vf_mac = mlx5e_set_vf_mac, 4345 .ndo_set_vf_mac = mlx5e_set_vf_mac,
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 9fed54017659..85796727093e 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -1368,6 +1368,9 @@ static int __parse_cls_flower(struct mlx5e_priv *priv,
1368 1368
1369 *match_level = MLX5_MATCH_L2; 1369 *match_level = MLX5_MATCH_L2;
1370 } 1370 }
1371 } else {
1372 MLX5_SET(fte_match_set_lyr_2_4, headers_c, svlan_tag, 1);
1373 MLX5_SET(fte_match_set_lyr_2_4, headers_c, cvlan_tag, 1);
1371 } 1374 }
1372 1375
1373 if (dissector_uses_key(f->dissector, FLOW_DISSECTOR_KEY_CVLAN)) { 1376 if (dissector_uses_key(f->dissector, FLOW_DISSECTOR_KEY_CVLAN)) {
@@ -2946,14 +2949,71 @@ int mlx5e_stats_flower(struct mlx5e_priv *priv,
2946 return 0; 2949 return 0;
2947} 2950}
2948 2951
2952static void mlx5e_tc_hairpin_update_dead_peer(struct mlx5e_priv *priv,
2953 struct mlx5e_priv *peer_priv)
2954{
2955 struct mlx5_core_dev *peer_mdev = peer_priv->mdev;
2956 struct mlx5e_hairpin_entry *hpe;
2957 u16 peer_vhca_id;
2958 int bkt;
2959
2960 if (!same_hw_devs(priv, peer_priv))
2961 return;
2962
2963 peer_vhca_id = MLX5_CAP_GEN(peer_mdev, vhca_id);
2964
2965 hash_for_each(priv->fs.tc.hairpin_tbl, bkt, hpe, hairpin_hlist) {
2966 if (hpe->peer_vhca_id == peer_vhca_id)
2967 hpe->hp->pair->peer_gone = true;
2968 }
2969}
2970
2971static int mlx5e_tc_netdev_event(struct notifier_block *this,
2972 unsigned long event, void *ptr)
2973{
2974 struct net_device *ndev = netdev_notifier_info_to_dev(ptr);
2975 struct mlx5e_flow_steering *fs;
2976 struct mlx5e_priv *peer_priv;
2977 struct mlx5e_tc_table *tc;
2978 struct mlx5e_priv *priv;
2979
2980 if (ndev->netdev_ops != &mlx5e_netdev_ops ||
2981 event != NETDEV_UNREGISTER ||
2982 ndev->reg_state == NETREG_REGISTERED)
2983 return NOTIFY_DONE;
2984
2985 tc = container_of(this, struct mlx5e_tc_table, netdevice_nb);
2986 fs = container_of(tc, struct mlx5e_flow_steering, tc);
2987 priv = container_of(fs, struct mlx5e_priv, fs);
2988 peer_priv = netdev_priv(ndev);
2989 if (priv == peer_priv ||
2990 !(priv->netdev->features & NETIF_F_HW_TC))
2991 return NOTIFY_DONE;
2992
2993 mlx5e_tc_hairpin_update_dead_peer(priv, peer_priv);
2994
2995 return NOTIFY_DONE;
2996}
2997
2949int mlx5e_tc_nic_init(struct mlx5e_priv *priv) 2998int mlx5e_tc_nic_init(struct mlx5e_priv *priv)
2950{ 2999{
2951 struct mlx5e_tc_table *tc = &priv->fs.tc; 3000 struct mlx5e_tc_table *tc = &priv->fs.tc;
3001 int err;
2952 3002
2953 hash_init(tc->mod_hdr_tbl); 3003 hash_init(tc->mod_hdr_tbl);
2954 hash_init(tc->hairpin_tbl); 3004 hash_init(tc->hairpin_tbl);
2955 3005
2956 return rhashtable_init(&tc->ht, &tc_ht_params); 3006 err = rhashtable_init(&tc->ht, &tc_ht_params);
3007 if (err)
3008 return err;
3009
3010 tc->netdevice_nb.notifier_call = mlx5e_tc_netdev_event;
3011 if (register_netdevice_notifier(&tc->netdevice_nb)) {
3012 tc->netdevice_nb.notifier_call = NULL;
3013 mlx5_core_warn(priv->mdev, "Failed to register netdev notifier\n");
3014 }
3015
3016 return err;
2957} 3017}
2958 3018
2959static void _mlx5e_tc_del_flow(void *ptr, void *arg) 3019static void _mlx5e_tc_del_flow(void *ptr, void *arg)
@@ -2969,6 +3029,9 @@ void mlx5e_tc_nic_cleanup(struct mlx5e_priv *priv)
2969{ 3029{
2970 struct mlx5e_tc_table *tc = &priv->fs.tc; 3030 struct mlx5e_tc_table *tc = &priv->fs.tc;
2971 3031
3032 if (tc->netdevice_nb.notifier_call)
3033 unregister_netdevice_notifier(&tc->netdevice_nb);
3034
2972 rhashtable_free_and_destroy(&tc->ht, _mlx5e_tc_del_flow, NULL); 3035 rhashtable_free_and_destroy(&tc->ht, _mlx5e_tc_del_flow, NULL);
2973 3036
2974 if (!IS_ERR_OR_NULL(tc->t)) { 3037 if (!IS_ERR_OR_NULL(tc->t)) {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
index 2b252cde5cc2..ea7dedc2d5ad 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -2000,7 +2000,7 @@ static u32 calculate_vports_min_rate_divider(struct mlx5_eswitch *esw)
2000 u32 max_guarantee = 0; 2000 u32 max_guarantee = 0;
2001 int i; 2001 int i;
2002 2002
2003 for (i = 0; i <= esw->total_vports; i++) { 2003 for (i = 0; i < esw->total_vports; i++) {
2004 evport = &esw->vports[i]; 2004 evport = &esw->vports[i];
2005 if (!evport->enabled || evport->info.min_rate < max_guarantee) 2005 if (!evport->enabled || evport->info.min_rate < max_guarantee)
2006 continue; 2006 continue;
@@ -2020,7 +2020,7 @@ static int normalize_vports_min_rate(struct mlx5_eswitch *esw, u32 divider)
2020 int err; 2020 int err;
2021 int i; 2021 int i;
2022 2022
2023 for (i = 0; i <= esw->total_vports; i++) { 2023 for (i = 0; i < esw->total_vports; i++) {
2024 evport = &esw->vports[i]; 2024 evport = &esw->vports[i];
2025 if (!evport->enabled) 2025 if (!evport->enabled)
2026 continue; 2026 continue;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
index f72b5c9dcfe9..3028e8d90920 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -663,6 +663,7 @@ static int esw_create_offloads_fdb_tables(struct mlx5_eswitch *esw, int nvports)
663 if (err) 663 if (err)
664 goto miss_rule_err; 664 goto miss_rule_err;
665 665
666 kvfree(flow_group_in);
666 return 0; 667 return 0;
667 668
668miss_rule_err: 669miss_rule_err:
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index f418541af7cf..37d114c668b7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -1578,6 +1578,33 @@ static u64 matched_fgs_get_version(struct list_head *match_head)
1578 return version; 1578 return version;
1579} 1579}
1580 1580
1581static struct fs_fte *
1582lookup_fte_locked(struct mlx5_flow_group *g,
1583 u32 *match_value,
1584 bool take_write)
1585{
1586 struct fs_fte *fte_tmp;
1587
1588 if (take_write)
1589 nested_down_write_ref_node(&g->node, FS_LOCK_PARENT);
1590 else
1591 nested_down_read_ref_node(&g->node, FS_LOCK_PARENT);
1592 fte_tmp = rhashtable_lookup_fast(&g->ftes_hash, match_value,
1593 rhash_fte);
1594 if (!fte_tmp || !tree_get_node(&fte_tmp->node)) {
1595 fte_tmp = NULL;
1596 goto out;
1597 }
1598
1599 nested_down_write_ref_node(&fte_tmp->node, FS_LOCK_CHILD);
1600out:
1601 if (take_write)
1602 up_write_ref_node(&g->node);
1603 else
1604 up_read_ref_node(&g->node);
1605 return fte_tmp;
1606}
1607
1581static struct mlx5_flow_handle * 1608static struct mlx5_flow_handle *
1582try_add_to_existing_fg(struct mlx5_flow_table *ft, 1609try_add_to_existing_fg(struct mlx5_flow_table *ft,
1583 struct list_head *match_head, 1610 struct list_head *match_head,
@@ -1600,10 +1627,6 @@ try_add_to_existing_fg(struct mlx5_flow_table *ft,
1600 if (IS_ERR(fte)) 1627 if (IS_ERR(fte))
1601 return ERR_PTR(-ENOMEM); 1628 return ERR_PTR(-ENOMEM);
1602 1629
1603 list_for_each_entry(iter, match_head, list) {
1604 nested_down_read_ref_node(&iter->g->node, FS_LOCK_PARENT);
1605 }
1606
1607search_again_locked: 1630search_again_locked:
1608 version = matched_fgs_get_version(match_head); 1631 version = matched_fgs_get_version(match_head);
1609 /* Try to find a fg that already contains a matching fte */ 1632 /* Try to find a fg that already contains a matching fte */
@@ -1611,20 +1634,9 @@ search_again_locked:
1611 struct fs_fte *fte_tmp; 1634 struct fs_fte *fte_tmp;
1612 1635
1613 g = iter->g; 1636 g = iter->g;
1614 fte_tmp = rhashtable_lookup_fast(&g->ftes_hash, spec->match_value, 1637 fte_tmp = lookup_fte_locked(g, spec->match_value, take_write);
1615 rhash_fte); 1638 if (!fte_tmp)
1616 if (!fte_tmp || !tree_get_node(&fte_tmp->node))
1617 continue; 1639 continue;
1618
1619 nested_down_write_ref_node(&fte_tmp->node, FS_LOCK_CHILD);
1620 if (!take_write) {
1621 list_for_each_entry(iter, match_head, list)
1622 up_read_ref_node(&iter->g->node);
1623 } else {
1624 list_for_each_entry(iter, match_head, list)
1625 up_write_ref_node(&iter->g->node);
1626 }
1627
1628 rule = add_rule_fg(g, spec->match_value, 1640 rule = add_rule_fg(g, spec->match_value,
1629 flow_act, dest, dest_num, fte_tmp); 1641 flow_act, dest, dest_num, fte_tmp);
1630 up_write_ref_node(&fte_tmp->node); 1642 up_write_ref_node(&fte_tmp->node);
@@ -1633,19 +1645,6 @@ search_again_locked:
1633 return rule; 1645 return rule;
1634 } 1646 }
1635 1647
1636 /* No group with matching fte found. Try to add a new fte to any
1637 * matching fg.
1638 */
1639
1640 if (!take_write) {
1641 list_for_each_entry(iter, match_head, list)
1642 up_read_ref_node(&iter->g->node);
1643 list_for_each_entry(iter, match_head, list)
1644 nested_down_write_ref_node(&iter->g->node,
1645 FS_LOCK_PARENT);
1646 take_write = true;
1647 }
1648
1649 /* Check the ft version, for case that new flow group 1648 /* Check the ft version, for case that new flow group
1650 * was added while the fgs weren't locked 1649 * was added while the fgs weren't locked
1651 */ 1650 */
@@ -1657,27 +1656,30 @@ search_again_locked:
1657 /* Check the fgs version, for case the new FTE with the 1656 /* Check the fgs version, for case the new FTE with the
1658 * same values was added while the fgs weren't locked 1657 * same values was added while the fgs weren't locked
1659 */ 1658 */
1660 if (version != matched_fgs_get_version(match_head)) 1659 if (version != matched_fgs_get_version(match_head)) {
1660 take_write = true;
1661 goto search_again_locked; 1661 goto search_again_locked;
1662 }
1662 1663
1663 list_for_each_entry(iter, match_head, list) { 1664 list_for_each_entry(iter, match_head, list) {
1664 g = iter->g; 1665 g = iter->g;
1665 1666
1666 if (!g->node.active) 1667 if (!g->node.active)
1667 continue; 1668 continue;
1669
1670 nested_down_write_ref_node(&g->node, FS_LOCK_PARENT);
1671
1668 err = insert_fte(g, fte); 1672 err = insert_fte(g, fte);
1669 if (err) { 1673 if (err) {
1674 up_write_ref_node(&g->node);
1670 if (err == -ENOSPC) 1675 if (err == -ENOSPC)
1671 continue; 1676 continue;
1672 list_for_each_entry(iter, match_head, list)
1673 up_write_ref_node(&iter->g->node);
1674 kmem_cache_free(steering->ftes_cache, fte); 1677 kmem_cache_free(steering->ftes_cache, fte);
1675 return ERR_PTR(err); 1678 return ERR_PTR(err);
1676 } 1679 }
1677 1680
1678 nested_down_write_ref_node(&fte->node, FS_LOCK_CHILD); 1681 nested_down_write_ref_node(&fte->node, FS_LOCK_CHILD);
1679 list_for_each_entry(iter, match_head, list) 1682 up_write_ref_node(&g->node);
1680 up_write_ref_node(&iter->g->node);
1681 rule = add_rule_fg(g, spec->match_value, 1683 rule = add_rule_fg(g, spec->match_value,
1682 flow_act, dest, dest_num, fte); 1684 flow_act, dest, dest_num, fte);
1683 up_write_ref_node(&fte->node); 1685 up_write_ref_node(&fte->node);
@@ -1686,8 +1688,6 @@ search_again_locked:
1686 } 1688 }
1687 rule = ERR_PTR(-ENOENT); 1689 rule = ERR_PTR(-ENOENT);
1688out: 1690out:
1689 list_for_each_entry(iter, match_head, list)
1690 up_write_ref_node(&iter->g->node);
1691 kmem_cache_free(steering->ftes_cache, fte); 1691 kmem_cache_free(steering->ftes_cache, fte);
1692 return rule; 1692 return rule;
1693} 1693}
@@ -1726,6 +1726,8 @@ search_again_locked:
1726 if (err) { 1726 if (err) {
1727 if (take_write) 1727 if (take_write)
1728 up_write_ref_node(&ft->node); 1728 up_write_ref_node(&ft->node);
1729 else
1730 up_read_ref_node(&ft->node);
1729 return ERR_PTR(err); 1731 return ERR_PTR(err);
1730 } 1732 }
1731 1733
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index d39b0b7011b2..9f39aeca863f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -331,9 +331,17 @@ void mlx5_start_health_poll(struct mlx5_core_dev *dev)
331 add_timer(&health->timer); 331 add_timer(&health->timer);
332} 332}
333 333
334void mlx5_stop_health_poll(struct mlx5_core_dev *dev) 334void mlx5_stop_health_poll(struct mlx5_core_dev *dev, bool disable_health)
335{ 335{
336 struct mlx5_core_health *health = &dev->priv.health; 336 struct mlx5_core_health *health = &dev->priv.health;
337 unsigned long flags;
338
339 if (disable_health) {
340 spin_lock_irqsave(&health->wq_lock, flags);
341 set_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags);
342 set_bit(MLX5_DROP_NEW_RECOVERY_WORK, &health->flags);
343 spin_unlock_irqrestore(&health->wq_lock, flags);
344 }
337 345
338 del_timer_sync(&health->timer); 346 del_timer_sync(&health->timer);
339} 347}
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index cf3e4a659052..b5e9f664fc66 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -878,8 +878,10 @@ static int mlx5_pci_init(struct mlx5_core_dev *dev, struct mlx5_priv *priv)
878 priv->numa_node = dev_to_node(&dev->pdev->dev); 878 priv->numa_node = dev_to_node(&dev->pdev->dev);
879 879
880 priv->dbg_root = debugfs_create_dir(dev_name(&pdev->dev), mlx5_debugfs_root); 880 priv->dbg_root = debugfs_create_dir(dev_name(&pdev->dev), mlx5_debugfs_root);
881 if (!priv->dbg_root) 881 if (!priv->dbg_root) {
882 dev_err(&pdev->dev, "Cannot create debugfs dir, aborting\n");
882 return -ENOMEM; 883 return -ENOMEM;
884 }
883 885
884 err = mlx5_pci_enable_device(dev); 886 err = mlx5_pci_enable_device(dev);
885 if (err) { 887 if (err) {
@@ -928,7 +930,7 @@ static void mlx5_pci_close(struct mlx5_core_dev *dev, struct mlx5_priv *priv)
928 pci_clear_master(dev->pdev); 930 pci_clear_master(dev->pdev);
929 release_bar(dev->pdev); 931 release_bar(dev->pdev);
930 mlx5_pci_disable_device(dev); 932 mlx5_pci_disable_device(dev);
931 debugfs_remove(priv->dbg_root); 933 debugfs_remove_recursive(priv->dbg_root);
932} 934}
933 935
934static int mlx5_init_once(struct mlx5_core_dev *dev, struct mlx5_priv *priv) 936static int mlx5_init_once(struct mlx5_core_dev *dev, struct mlx5_priv *priv)
@@ -1286,7 +1288,7 @@ err_cleanup_once:
1286 mlx5_cleanup_once(dev); 1288 mlx5_cleanup_once(dev);
1287 1289
1288err_stop_poll: 1290err_stop_poll:
1289 mlx5_stop_health_poll(dev); 1291 mlx5_stop_health_poll(dev, boot);
1290 if (mlx5_cmd_teardown_hca(dev)) { 1292 if (mlx5_cmd_teardown_hca(dev)) {
1291 dev_err(&dev->pdev->dev, "tear_down_hca failed, skip cleanup\n"); 1293 dev_err(&dev->pdev->dev, "tear_down_hca failed, skip cleanup\n");
1292 goto out_err; 1294 goto out_err;
@@ -1346,7 +1348,7 @@ static int mlx5_unload_one(struct mlx5_core_dev *dev, struct mlx5_priv *priv,
1346 mlx5_free_irq_vectors(dev); 1348 mlx5_free_irq_vectors(dev);
1347 if (cleanup) 1349 if (cleanup)
1348 mlx5_cleanup_once(dev); 1350 mlx5_cleanup_once(dev);
1349 mlx5_stop_health_poll(dev); 1351 mlx5_stop_health_poll(dev, cleanup);
1350 err = mlx5_cmd_teardown_hca(dev); 1352 err = mlx5_cmd_teardown_hca(dev);
1351 if (err) { 1353 if (err) {
1352 dev_err(&dev->pdev->dev, "tear_down_hca failed, skip cleanup\n"); 1354 dev_err(&dev->pdev->dev, "tear_down_hca failed, skip cleanup\n");
@@ -1608,7 +1610,7 @@ static int mlx5_try_fast_unload(struct mlx5_core_dev *dev)
1608 * with the HCA, so the health polll is no longer needed. 1610 * with the HCA, so the health polll is no longer needed.
1609 */ 1611 */
1610 mlx5_drain_health_wq(dev); 1612 mlx5_drain_health_wq(dev);
1611 mlx5_stop_health_poll(dev); 1613 mlx5_stop_health_poll(dev, false);
1612 1614
1613 ret = mlx5_cmd_force_teardown_hca(dev); 1615 ret = mlx5_cmd_force_teardown_hca(dev);
1614 if (ret) { 1616 if (ret) {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/transobj.c b/drivers/net/ethernet/mellanox/mlx5/core/transobj.c
index dae1c5c5d27c..a1ee9a8a769e 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/transobj.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/transobj.c
@@ -475,7 +475,8 @@ static void mlx5_hairpin_destroy_queues(struct mlx5_hairpin *hp)
475 475
476 for (i = 0; i < hp->num_channels; i++) { 476 for (i = 0; i < hp->num_channels; i++) {
477 mlx5_core_destroy_rq(hp->func_mdev, hp->rqn[i]); 477 mlx5_core_destroy_rq(hp->func_mdev, hp->rqn[i]);
478 mlx5_core_destroy_sq(hp->peer_mdev, hp->sqn[i]); 478 if (!hp->peer_gone)
479 mlx5_core_destroy_sq(hp->peer_mdev, hp->sqn[i]);
479 } 480 }
480} 481}
481 482
@@ -509,7 +510,7 @@ static int mlx5_hairpin_modify_sq(struct mlx5_core_dev *peer_mdev, u32 sqn,
509 510
510 sqc = MLX5_ADDR_OF(modify_sq_in, in, ctx); 511 sqc = MLX5_ADDR_OF(modify_sq_in, in, ctx);
511 512
512 if (next_state == MLX5_RQC_STATE_RDY) { 513 if (next_state == MLX5_SQC_STATE_RDY) {
513 MLX5_SET(sqc, sqc, hairpin_peer_rq, peer_rq); 514 MLX5_SET(sqc, sqc, hairpin_peer_rq, peer_rq);
514 MLX5_SET(sqc, sqc, hairpin_peer_vhca, peer_vhca); 515 MLX5_SET(sqc, sqc, hairpin_peer_vhca, peer_vhca);
515 } 516 }
@@ -567,6 +568,8 @@ static void mlx5_hairpin_unpair_queues(struct mlx5_hairpin *hp)
567 MLX5_RQC_STATE_RST, 0, 0); 568 MLX5_RQC_STATE_RST, 0, 0);
568 569
569 /* unset peer SQs */ 570 /* unset peer SQs */
571 if (hp->peer_gone)
572 return;
570 for (i = 0; i < hp->num_channels; i++) 573 for (i = 0; i < hp->num_channels; i++)
571 mlx5_hairpin_modify_sq(hp->peer_mdev, hp->sqn[i], MLX5_SQC_STATE_RDY, 574 mlx5_hairpin_modify_sq(hp->peer_mdev, hp->sqn[i], MLX5_SQC_STATE_RDY,
572 MLX5_SQC_STATE_RST, 0, 0); 575 MLX5_SQC_STATE_RST, 0, 0);
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
index c8c315eb5128..68e7f8df2a6d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/wq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
@@ -39,9 +39,9 @@ u32 mlx5_wq_cyc_get_size(struct mlx5_wq_cyc *wq)
39 return (u32)wq->fbc.sz_m1 + 1; 39 return (u32)wq->fbc.sz_m1 + 1;
40} 40}
41 41
42u32 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq) 42u16 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq)
43{ 43{
44 return (u32)wq->fbc.frag_sz_m1 + 1; 44 return wq->fbc.frag_sz_m1 + 1;
45} 45}
46 46
47u32 mlx5_cqwq_get_size(struct mlx5_cqwq *wq) 47u32 mlx5_cqwq_get_size(struct mlx5_cqwq *wq)
@@ -138,7 +138,7 @@ int mlx5_wq_qp_create(struct mlx5_core_dev *mdev, struct mlx5_wq_param *param,
138 void *qpc, struct mlx5_wq_qp *wq, 138 void *qpc, struct mlx5_wq_qp *wq,
139 struct mlx5_wq_ctrl *wq_ctrl) 139 struct mlx5_wq_ctrl *wq_ctrl)
140{ 140{
141 u32 sq_strides_offset; 141 u16 sq_strides_offset;
142 u32 rq_pg_remainder; 142 u32 rq_pg_remainder;
143 int err; 143 int err;
144 144
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.h b/drivers/net/ethernet/mellanox/mlx5/core/wq.h
index 2bd4c3184eba..3a1a170bb2d7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/wq.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/wq.h
@@ -80,7 +80,7 @@ int mlx5_wq_cyc_create(struct mlx5_core_dev *mdev, struct mlx5_wq_param *param,
80 void *wqc, struct mlx5_wq_cyc *wq, 80 void *wqc, struct mlx5_wq_cyc *wq,
81 struct mlx5_wq_ctrl *wq_ctrl); 81 struct mlx5_wq_ctrl *wq_ctrl);
82u32 mlx5_wq_cyc_get_size(struct mlx5_wq_cyc *wq); 82u32 mlx5_wq_cyc_get_size(struct mlx5_wq_cyc *wq);
83u32 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq); 83u16 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq);
84 84
85int mlx5_wq_qp_create(struct mlx5_core_dev *mdev, struct mlx5_wq_param *param, 85int mlx5_wq_qp_create(struct mlx5_core_dev *mdev, struct mlx5_wq_param *param,
86 void *qpc, struct mlx5_wq_qp *wq, 86 void *qpc, struct mlx5_wq_qp *wq,
diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c
index 4d271fb3de3d..5890fdfd62c3 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/pci.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c
@@ -718,14 +718,17 @@ static void mlxsw_pci_eq_tasklet(unsigned long data)
718 memset(&active_cqns, 0, sizeof(active_cqns)); 718 memset(&active_cqns, 0, sizeof(active_cqns));
719 719
720 while ((eqe = mlxsw_pci_eq_sw_eqe_get(q))) { 720 while ((eqe = mlxsw_pci_eq_sw_eqe_get(q))) {
721 u8 event_type = mlxsw_pci_eqe_event_type_get(eqe);
722 721
723 switch (event_type) { 722 /* Command interface completion events are always received on
724 case MLXSW_PCI_EQE_EVENT_TYPE_CMD: 723 * queue MLXSW_PCI_EQ_ASYNC_NUM (EQ0) and completion events
724 * are mapped to queue MLXSW_PCI_EQ_COMP_NUM (EQ1).
725 */
726 switch (q->num) {
727 case MLXSW_PCI_EQ_ASYNC_NUM:
725 mlxsw_pci_eq_cmd_event(mlxsw_pci, eqe); 728 mlxsw_pci_eq_cmd_event(mlxsw_pci, eqe);
726 q->u.eq.ev_cmd_count++; 729 q->u.eq.ev_cmd_count++;
727 break; 730 break;
728 case MLXSW_PCI_EQE_EVENT_TYPE_COMP: 731 case MLXSW_PCI_EQ_COMP_NUM:
729 cqn = mlxsw_pci_eqe_cqn_get(eqe); 732 cqn = mlxsw_pci_eqe_cqn_get(eqe);
730 set_bit(cqn, active_cqns); 733 set_bit(cqn, active_cqns);
731 cq_handle = true; 734 cq_handle = true;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 930700413b1d..30bb2c533cec 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -44,8 +44,8 @@
44#define MLXSW_SP_FWREV_MINOR_TO_BRANCH(minor) ((minor) / 100) 44#define MLXSW_SP_FWREV_MINOR_TO_BRANCH(minor) ((minor) / 100)
45 45
46#define MLXSW_SP1_FWREV_MAJOR 13 46#define MLXSW_SP1_FWREV_MAJOR 13
47#define MLXSW_SP1_FWREV_MINOR 1702 47#define MLXSW_SP1_FWREV_MINOR 1703
48#define MLXSW_SP1_FWREV_SUBMINOR 6 48#define MLXSW_SP1_FWREV_SUBMINOR 4
49#define MLXSW_SP1_FWREV_CAN_RESET_MINOR 1702 49#define MLXSW_SP1_FWREV_CAN_RESET_MINOR 1702
50 50
51static const struct mlxsw_fw_rev mlxsw_sp1_fw_rev = { 51static const struct mlxsw_fw_rev mlxsw_sp1_fw_rev = {
@@ -4845,6 +4845,8 @@ static int mlxsw_sp_netdevice_bridge_event(struct net_device *br_dev,
4845 upper_dev = info->upper_dev; 4845 upper_dev = info->upper_dev;
4846 if (info->linking) 4846 if (info->linking)
4847 break; 4847 break;
4848 if (is_vlan_dev(upper_dev))
4849 mlxsw_sp_rif_destroy_by_dev(mlxsw_sp, upper_dev);
4848 if (netif_is_macvlan(upper_dev)) 4850 if (netif_is_macvlan(upper_dev))
4849 mlxsw_sp_rif_macvlan_del(mlxsw_sp, upper_dev); 4851 mlxsw_sp_rif_macvlan_del(mlxsw_sp, upper_dev);
4850 break; 4852 break;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c
index 4327487553c5..3589432d1643 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c
@@ -337,14 +337,14 @@ static const struct mlxsw_sp_sb_cm mlxsw_sp_sb_cms_egress[] = {
337 MLXSW_SP_SB_CM(1500, 9, 0), 337 MLXSW_SP_SB_CM(1500, 9, 0),
338 MLXSW_SP_SB_CM(1500, 9, 0), 338 MLXSW_SP_SB_CM(1500, 9, 0),
339 MLXSW_SP_SB_CM(1500, 9, 0), 339 MLXSW_SP_SB_CM(1500, 9, 0),
340 MLXSW_SP_SB_CM(0, 0, 0), 340 MLXSW_SP_SB_CM(0, 140000, 15),
341 MLXSW_SP_SB_CM(0, 0, 0), 341 MLXSW_SP_SB_CM(0, 140000, 15),
342 MLXSW_SP_SB_CM(0, 0, 0), 342 MLXSW_SP_SB_CM(0, 140000, 15),
343 MLXSW_SP_SB_CM(0, 0, 0), 343 MLXSW_SP_SB_CM(0, 140000, 15),
344 MLXSW_SP_SB_CM(0, 0, 0), 344 MLXSW_SP_SB_CM(0, 140000, 15),
345 MLXSW_SP_SB_CM(0, 0, 0), 345 MLXSW_SP_SB_CM(0, 140000, 15),
346 MLXSW_SP_SB_CM(0, 0, 0), 346 MLXSW_SP_SB_CM(0, 140000, 15),
347 MLXSW_SP_SB_CM(0, 0, 0), 347 MLXSW_SP_SB_CM(0, 140000, 15),
348 MLXSW_SP_SB_CM(1, 0xff, 0), 348 MLXSW_SP_SB_CM(1, 0xff, 0),
349}; 349};
350 350
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index e7dce79ff2c9..001b5f714c1b 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -2850,7 +2850,7 @@ static void lan743x_pcidev_shutdown(struct pci_dev *pdev)
2850 lan743x_hardware_cleanup(adapter); 2850 lan743x_hardware_cleanup(adapter);
2851} 2851}
2852 2852
2853#ifdef CONFIG_PM 2853#ifdef CONFIG_PM_SLEEP
2854static u16 lan743x_pm_wakeframe_crc16(const u8 *buf, int len) 2854static u16 lan743x_pm_wakeframe_crc16(const u8 *buf, int len)
2855{ 2855{
2856 return bitrev16(crc16(0xFFFF, buf, len)); 2856 return bitrev16(crc16(0xFFFF, buf, len));
@@ -3016,7 +3016,7 @@ static int lan743x_pm_resume(struct device *dev)
3016static const struct dev_pm_ops lan743x_pm_ops = { 3016static const struct dev_pm_ops lan743x_pm_ops = {
3017 SET_SYSTEM_SLEEP_PM_OPS(lan743x_pm_suspend, lan743x_pm_resume) 3017 SET_SYSTEM_SLEEP_PM_OPS(lan743x_pm_suspend, lan743x_pm_resume)
3018}; 3018};
3019#endif /*CONFIG_PM */ 3019#endif /* CONFIG_PM_SLEEP */
3020 3020
3021static const struct pci_device_id lan743x_pcidev_tbl[] = { 3021static const struct pci_device_id lan743x_pcidev_tbl[] = {
3022 { PCI_DEVICE(PCI_VENDOR_ID_SMSC, PCI_DEVICE_ID_SMSC_LAN7430) }, 3022 { PCI_DEVICE(PCI_VENDOR_ID_SMSC, PCI_DEVICE_ID_SMSC_LAN7430) },
@@ -3028,7 +3028,7 @@ static struct pci_driver lan743x_pcidev_driver = {
3028 .id_table = lan743x_pcidev_tbl, 3028 .id_table = lan743x_pcidev_tbl,
3029 .probe = lan743x_pcidev_probe, 3029 .probe = lan743x_pcidev_probe,
3030 .remove = lan743x_pcidev_remove, 3030 .remove = lan743x_pcidev_remove,
3031#ifdef CONFIG_PM 3031#ifdef CONFIG_PM_SLEEP
3032 .driver.pm = &lan743x_pm_ops, 3032 .driver.pm = &lan743x_pm_ops,
3033#endif 3033#endif
3034 .shutdown = lan743x_pcidev_shutdown, 3034 .shutdown = lan743x_pcidev_shutdown,
diff --git a/drivers/net/ethernet/mscc/ocelot_board.c b/drivers/net/ethernet/mscc/ocelot_board.c
index 26bb3b18f3be..3cdf63e35b53 100644
--- a/drivers/net/ethernet/mscc/ocelot_board.c
+++ b/drivers/net/ethernet/mscc/ocelot_board.c
@@ -91,7 +91,7 @@ static irqreturn_t ocelot_xtr_irq_handler(int irq, void *arg)
91 struct sk_buff *skb; 91 struct sk_buff *skb;
92 struct net_device *dev; 92 struct net_device *dev;
93 u32 *buf; 93 u32 *buf;
94 int sz, len; 94 int sz, len, buf_len;
95 u32 ifh[4]; 95 u32 ifh[4];
96 u32 val; 96 u32 val;
97 struct frame_info info; 97 struct frame_info info;
@@ -116,14 +116,20 @@ static irqreturn_t ocelot_xtr_irq_handler(int irq, void *arg)
116 err = -ENOMEM; 116 err = -ENOMEM;
117 break; 117 break;
118 } 118 }
119 buf = (u32 *)skb_put(skb, info.len); 119 buf_len = info.len - ETH_FCS_LEN;
120 buf = (u32 *)skb_put(skb, buf_len);
120 121
121 len = 0; 122 len = 0;
122 do { 123 do {
123 sz = ocelot_rx_frame_word(ocelot, grp, false, &val); 124 sz = ocelot_rx_frame_word(ocelot, grp, false, &val);
124 *buf++ = val; 125 *buf++ = val;
125 len += sz; 126 len += sz;
126 } while ((sz == 4) && (len < info.len)); 127 } while (len < buf_len);
128
129 /* Read the FCS and discard it */
130 sz = ocelot_rx_frame_word(ocelot, grp, false, &val);
131 /* Update the statistics if part of the FCS was read before */
132 len -= ETH_FCS_LEN - sz;
127 133
128 if (sz < 0) { 134 if (sz < 0) {
129 err = sz; 135 err = sz;
diff --git a/drivers/net/ethernet/netronome/nfp/flower/action.c b/drivers/net/ethernet/netronome/nfp/flower/action.c
index 9044496803e6..46ba0cf257c6 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/action.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/action.c
@@ -52,6 +52,7 @@
52#define NFP_FL_TUNNEL_CSUM cpu_to_be16(0x01) 52#define NFP_FL_TUNNEL_CSUM cpu_to_be16(0x01)
53#define NFP_FL_TUNNEL_KEY cpu_to_be16(0x04) 53#define NFP_FL_TUNNEL_KEY cpu_to_be16(0x04)
54#define NFP_FL_TUNNEL_GENEVE_OPT cpu_to_be16(0x0800) 54#define NFP_FL_TUNNEL_GENEVE_OPT cpu_to_be16(0x0800)
55#define NFP_FL_SUPPORTED_TUNNEL_INFO_FLAGS IP_TUNNEL_INFO_TX
55#define NFP_FL_SUPPORTED_IPV4_UDP_TUN_FLAGS (NFP_FL_TUNNEL_CSUM | \ 56#define NFP_FL_SUPPORTED_IPV4_UDP_TUN_FLAGS (NFP_FL_TUNNEL_CSUM | \
56 NFP_FL_TUNNEL_KEY | \ 57 NFP_FL_TUNNEL_KEY | \
57 NFP_FL_TUNNEL_GENEVE_OPT) 58 NFP_FL_TUNNEL_GENEVE_OPT)
@@ -741,11 +742,16 @@ nfp_flower_loop_action(struct nfp_app *app, const struct tc_action *a,
741 nfp_fl_push_vlan(psh_v, a); 742 nfp_fl_push_vlan(psh_v, a);
742 *a_len += sizeof(struct nfp_fl_push_vlan); 743 *a_len += sizeof(struct nfp_fl_push_vlan);
743 } else if (is_tcf_tunnel_set(a)) { 744 } else if (is_tcf_tunnel_set(a)) {
745 struct ip_tunnel_info *ip_tun = tcf_tunnel_info(a);
744 struct nfp_repr *repr = netdev_priv(netdev); 746 struct nfp_repr *repr = netdev_priv(netdev);
747
745 *tun_type = nfp_fl_get_tun_from_act_l4_port(repr->app, a); 748 *tun_type = nfp_fl_get_tun_from_act_l4_port(repr->app, a);
746 if (*tun_type == NFP_FL_TUNNEL_NONE) 749 if (*tun_type == NFP_FL_TUNNEL_NONE)
747 return -EOPNOTSUPP; 750 return -EOPNOTSUPP;
748 751
752 if (ip_tun->mode & ~NFP_FL_SUPPORTED_TUNNEL_INFO_FLAGS)
753 return -EOPNOTSUPP;
754
749 /* Pre-tunnel action is required for tunnel encap. 755 /* Pre-tunnel action is required for tunnel encap.
750 * This checks for next hop entries on NFP. 756 * This checks for next hop entries on NFP.
751 * If none, the packet falls back before applying other actions. 757 * If none, the packet falls back before applying other actions.
diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.h b/drivers/net/ethernet/netronome/nfp/flower/main.h
index 85f8209bf007..81d941ab895c 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/main.h
+++ b/drivers/net/ethernet/netronome/nfp/flower/main.h
@@ -70,6 +70,7 @@ struct nfp_app;
70#define NFP_FL_FEATS_GENEVE BIT(0) 70#define NFP_FL_FEATS_GENEVE BIT(0)
71#define NFP_FL_NBI_MTU_SETTING BIT(1) 71#define NFP_FL_NBI_MTU_SETTING BIT(1)
72#define NFP_FL_FEATS_GENEVE_OPT BIT(2) 72#define NFP_FL_FEATS_GENEVE_OPT BIT(2)
73#define NFP_FL_FEATS_VLAN_PCP BIT(3)
73#define NFP_FL_FEATS_LAG BIT(31) 74#define NFP_FL_FEATS_LAG BIT(31)
74 75
75struct nfp_fl_mask_id { 76struct nfp_fl_mask_id {
diff --git a/drivers/net/ethernet/netronome/nfp/flower/match.c b/drivers/net/ethernet/netronome/nfp/flower/match.c
index a0c72f277faa..17acb8cc6044 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/match.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/match.c
@@ -56,7 +56,7 @@ nfp_flower_compile_meta_tci(struct nfp_flower_meta_tci *frame,
56 FLOW_DISSECTOR_KEY_VLAN, 56 FLOW_DISSECTOR_KEY_VLAN,
57 target); 57 target);
58 /* Populate the tci field. */ 58 /* Populate the tci field. */
59 if (flow_vlan->vlan_id) { 59 if (flow_vlan->vlan_id || flow_vlan->vlan_priority) {
60 tmp_tci = FIELD_PREP(NFP_FLOWER_MASK_VLAN_PRIO, 60 tmp_tci = FIELD_PREP(NFP_FLOWER_MASK_VLAN_PRIO,
61 flow_vlan->vlan_priority) | 61 flow_vlan->vlan_priority) |
62 FIELD_PREP(NFP_FLOWER_MASK_VLAN_VID, 62 FIELD_PREP(NFP_FLOWER_MASK_VLAN_VID,
diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c
index 2edab01c3beb..bd19624f10cf 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
@@ -192,6 +192,17 @@ nfp_flower_calculate_key_layers(struct nfp_app *app,
192 key_size += sizeof(struct nfp_flower_mac_mpls); 192 key_size += sizeof(struct nfp_flower_mac_mpls);
193 } 193 }
194 194
195 if (dissector_uses_key(flow->dissector, FLOW_DISSECTOR_KEY_VLAN)) {
196 struct flow_dissector_key_vlan *flow_vlan;
197
198 flow_vlan = skb_flow_dissector_target(flow->dissector,
199 FLOW_DISSECTOR_KEY_VLAN,
200 flow->mask);
201 if (!(priv->flower_ext_feats & NFP_FL_FEATS_VLAN_PCP) &&
202 flow_vlan->vlan_priority)
203 return -EOPNOTSUPP;
204 }
205
195 if (dissector_uses_key(flow->dissector, 206 if (dissector_uses_key(flow->dissector,
196 FLOW_DISSECTOR_KEY_ENC_CONTROL)) { 207 FLOW_DISSECTOR_KEY_ENC_CONTROL)) {
197 struct flow_dissector_key_ipv4_addrs *mask_ipv4 = NULL; 208 struct flow_dissector_key_ipv4_addrs *mask_ipv4 = NULL;
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 253bdaef1505..c6d29fdbb880 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -2077,14 +2077,17 @@ nfp_ctrl_rx_one(struct nfp_net *nn, struct nfp_net_dp *dp,
2077 return true; 2077 return true;
2078} 2078}
2079 2079
2080static void nfp_ctrl_rx(struct nfp_net_r_vector *r_vec) 2080static bool nfp_ctrl_rx(struct nfp_net_r_vector *r_vec)
2081{ 2081{
2082 struct nfp_net_rx_ring *rx_ring = r_vec->rx_ring; 2082 struct nfp_net_rx_ring *rx_ring = r_vec->rx_ring;
2083 struct nfp_net *nn = r_vec->nfp_net; 2083 struct nfp_net *nn = r_vec->nfp_net;
2084 struct nfp_net_dp *dp = &nn->dp; 2084 struct nfp_net_dp *dp = &nn->dp;
2085 unsigned int budget = 512;
2085 2086
2086 while (nfp_ctrl_rx_one(nn, dp, r_vec, rx_ring)) 2087 while (nfp_ctrl_rx_one(nn, dp, r_vec, rx_ring) && budget--)
2087 continue; 2088 continue;
2089
2090 return budget;
2088} 2091}
2089 2092
2090static void nfp_ctrl_poll(unsigned long arg) 2093static void nfp_ctrl_poll(unsigned long arg)
@@ -2096,9 +2099,13 @@ static void nfp_ctrl_poll(unsigned long arg)
2096 __nfp_ctrl_tx_queued(r_vec); 2099 __nfp_ctrl_tx_queued(r_vec);
2097 spin_unlock_bh(&r_vec->lock); 2100 spin_unlock_bh(&r_vec->lock);
2098 2101
2099 nfp_ctrl_rx(r_vec); 2102 if (nfp_ctrl_rx(r_vec)) {
2100 2103 nfp_net_irq_unmask(r_vec->nfp_net, r_vec->irq_entry);
2101 nfp_net_irq_unmask(r_vec->nfp_net, r_vec->irq_entry); 2104 } else {
2105 tasklet_schedule(&r_vec->tasklet);
2106 nn_dp_warn(&r_vec->nfp_net->dp,
2107 "control message budget exceeded!\n");
2108 }
2102} 2109}
2103 2110
2104/* Setup and Configuration 2111/* Setup and Configuration
@@ -3146,21 +3153,6 @@ nfp_net_vlan_rx_kill_vid(struct net_device *netdev, __be16 proto, u16 vid)
3146 return nfp_net_reconfig_mbox(nn, NFP_NET_CFG_MBOX_CMD_CTAG_FILTER_KILL); 3153 return nfp_net_reconfig_mbox(nn, NFP_NET_CFG_MBOX_CMD_CTAG_FILTER_KILL);
3147} 3154}
3148 3155
3149#ifdef CONFIG_NET_POLL_CONTROLLER
3150static void nfp_net_netpoll(struct net_device *netdev)
3151{
3152 struct nfp_net *nn = netdev_priv(netdev);
3153 int i;
3154
3155 /* nfp_net's NAPIs are statically allocated so even if there is a race
3156 * with reconfig path this will simply try to schedule some disabled
3157 * NAPI instances.
3158 */
3159 for (i = 0; i < nn->dp.num_stack_tx_rings; i++)
3160 napi_schedule_irqoff(&nn->r_vecs[i].napi);
3161}
3162#endif
3163
3164static void nfp_net_stat64(struct net_device *netdev, 3156static void nfp_net_stat64(struct net_device *netdev,
3165 struct rtnl_link_stats64 *stats) 3157 struct rtnl_link_stats64 *stats)
3166{ 3158{
@@ -3519,9 +3511,6 @@ const struct net_device_ops nfp_net_netdev_ops = {
3519 .ndo_get_stats64 = nfp_net_stat64, 3511 .ndo_get_stats64 = nfp_net_stat64,
3520 .ndo_vlan_rx_add_vid = nfp_net_vlan_rx_add_vid, 3512 .ndo_vlan_rx_add_vid = nfp_net_vlan_rx_add_vid,
3521 .ndo_vlan_rx_kill_vid = nfp_net_vlan_rx_kill_vid, 3513 .ndo_vlan_rx_kill_vid = nfp_net_vlan_rx_kill_vid,
3522#ifdef CONFIG_NET_POLL_CONTROLLER
3523 .ndo_poll_controller = nfp_net_netpoll,
3524#endif
3525 .ndo_set_vf_mac = nfp_app_set_vf_mac, 3514 .ndo_set_vf_mac = nfp_app_set_vf_mac,
3526 .ndo_set_vf_vlan = nfp_app_set_vf_vlan, 3515 .ndo_set_vf_vlan = nfp_app_set_vf_vlan,
3527 .ndo_set_vf_spoofchk = nfp_app_set_vf_spoofchk, 3516 .ndo_set_vf_spoofchk = nfp_app_set_vf_spoofchk,
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 69aa7fc392c5..59c70be22a84 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -72,9 +72,6 @@ static void netxen_schedule_work(struct netxen_adapter *adapter,
72 work_func_t func, int delay); 72 work_func_t func, int delay);
73static void netxen_cancel_fw_work(struct netxen_adapter *adapter); 73static void netxen_cancel_fw_work(struct netxen_adapter *adapter);
74static int netxen_nic_poll(struct napi_struct *napi, int budget); 74static int netxen_nic_poll(struct napi_struct *napi, int budget);
75#ifdef CONFIG_NET_POLL_CONTROLLER
76static void netxen_nic_poll_controller(struct net_device *netdev);
77#endif
78 75
79static void netxen_create_sysfs_entries(struct netxen_adapter *adapter); 76static void netxen_create_sysfs_entries(struct netxen_adapter *adapter);
80static void netxen_remove_sysfs_entries(struct netxen_adapter *adapter); 77static void netxen_remove_sysfs_entries(struct netxen_adapter *adapter);
@@ -581,9 +578,6 @@ static const struct net_device_ops netxen_netdev_ops = {
581 .ndo_tx_timeout = netxen_tx_timeout, 578 .ndo_tx_timeout = netxen_tx_timeout,
582 .ndo_fix_features = netxen_fix_features, 579 .ndo_fix_features = netxen_fix_features,
583 .ndo_set_features = netxen_set_features, 580 .ndo_set_features = netxen_set_features,
584#ifdef CONFIG_NET_POLL_CONTROLLER
585 .ndo_poll_controller = netxen_nic_poll_controller,
586#endif
587}; 581};
588 582
589static inline bool netxen_function_zero(struct pci_dev *pdev) 583static inline bool netxen_function_zero(struct pci_dev *pdev)
@@ -2402,23 +2396,6 @@ static int netxen_nic_poll(struct napi_struct *napi, int budget)
2402 return work_done; 2396 return work_done;
2403} 2397}
2404 2398
2405#ifdef CONFIG_NET_POLL_CONTROLLER
2406static void netxen_nic_poll_controller(struct net_device *netdev)
2407{
2408 int ring;
2409 struct nx_host_sds_ring *sds_ring;
2410 struct netxen_adapter *adapter = netdev_priv(netdev);
2411 struct netxen_recv_context *recv_ctx = &adapter->recv_ctx;
2412
2413 disable_irq(adapter->irq);
2414 for (ring = 0; ring < adapter->max_sds_rings; ring++) {
2415 sds_ring = &recv_ctx->sds_rings[ring];
2416 netxen_intr(adapter->irq, sds_ring);
2417 }
2418 enable_irq(adapter->irq);
2419}
2420#endif
2421
2422static int 2399static int
2423nx_incr_dev_ref_cnt(struct netxen_adapter *adapter) 2400nx_incr_dev_ref_cnt(struct netxen_adapter *adapter)
2424{ 2401{
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index 6bb76e6d3c14..f5459de6d60a 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -190,10 +190,8 @@ qed_dcbx_dp_protocol(struct qed_hwfn *p_hwfn, struct qed_dcbx_results *p_data)
190 190
191static void 191static void
192qed_dcbx_set_params(struct qed_dcbx_results *p_data, 192qed_dcbx_set_params(struct qed_dcbx_results *p_data,
193 struct qed_hw_info *p_info, 193 struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
194 bool enable, 194 bool enable, u8 prio, u8 tc,
195 u8 prio,
196 u8 tc,
197 enum dcbx_protocol_type type, 195 enum dcbx_protocol_type type,
198 enum qed_pci_personality personality) 196 enum qed_pci_personality personality)
199{ 197{
@@ -206,19 +204,30 @@ qed_dcbx_set_params(struct qed_dcbx_results *p_data,
206 else 204 else
207 p_data->arr[type].update = DONT_UPDATE_DCB_DSCP; 205 p_data->arr[type].update = DONT_UPDATE_DCB_DSCP;
208 206
207 /* Do not add vlan tag 0 when DCB is enabled and port in UFP/OV mode */
208 if ((test_bit(QED_MF_8021Q_TAGGING, &p_hwfn->cdev->mf_bits) ||
209 test_bit(QED_MF_8021AD_TAGGING, &p_hwfn->cdev->mf_bits)))
210 p_data->arr[type].dont_add_vlan0 = true;
211
209 /* QM reconf data */ 212 /* QM reconf data */
210 if (p_info->personality == personality) 213 if (p_hwfn->hw_info.personality == personality)
211 qed_hw_info_set_offload_tc(p_info, tc); 214 qed_hw_info_set_offload_tc(&p_hwfn->hw_info, tc);
215
216 /* Configure dcbx vlan priority in doorbell block for roce EDPM */
217 if (test_bit(QED_MF_UFP_SPECIFIC, &p_hwfn->cdev->mf_bits) &&
218 type == DCBX_PROTOCOL_ROCE) {
219 qed_wr(p_hwfn, p_ptt, DORQ_REG_TAG1_OVRD_MODE, 1);
220 qed_wr(p_hwfn, p_ptt, DORQ_REG_PF_PCP_BB_K2, prio << 1);
221 }
212} 222}
213 223
214/* Update app protocol data and hw_info fields with the TLV info */ 224/* Update app protocol data and hw_info fields with the TLV info */
215static void 225static void
216qed_dcbx_update_app_info(struct qed_dcbx_results *p_data, 226qed_dcbx_update_app_info(struct qed_dcbx_results *p_data,
217 struct qed_hwfn *p_hwfn, 227 struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
218 bool enable, 228 bool enable, u8 prio, u8 tc,
219 u8 prio, u8 tc, enum dcbx_protocol_type type) 229 enum dcbx_protocol_type type)
220{ 230{
221 struct qed_hw_info *p_info = &p_hwfn->hw_info;
222 enum qed_pci_personality personality; 231 enum qed_pci_personality personality;
223 enum dcbx_protocol_type id; 232 enum dcbx_protocol_type id;
224 int i; 233 int i;
@@ -231,7 +240,7 @@ qed_dcbx_update_app_info(struct qed_dcbx_results *p_data,
231 240
232 personality = qed_dcbx_app_update[i].personality; 241 personality = qed_dcbx_app_update[i].personality;
233 242
234 qed_dcbx_set_params(p_data, p_info, enable, 243 qed_dcbx_set_params(p_data, p_hwfn, p_ptt, enable,
235 prio, tc, type, personality); 244 prio, tc, type, personality);
236 } 245 }
237} 246}
@@ -265,7 +274,7 @@ qed_dcbx_get_app_protocol_type(struct qed_hwfn *p_hwfn,
265 * reconfiguring QM. Get protocol specific data for PF update ramrod command. 274 * reconfiguring QM. Get protocol specific data for PF update ramrod command.
266 */ 275 */
267static int 276static int
268qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn, 277qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
269 struct qed_dcbx_results *p_data, 278 struct qed_dcbx_results *p_data,
270 struct dcbx_app_priority_entry *p_tbl, 279 struct dcbx_app_priority_entry *p_tbl,
271 u32 pri_tc_tbl, int count, u8 dcbx_version) 280 u32 pri_tc_tbl, int count, u8 dcbx_version)
@@ -309,7 +318,7 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
309 enable = true; 318 enable = true;
310 } 319 }
311 320
312 qed_dcbx_update_app_info(p_data, p_hwfn, enable, 321 qed_dcbx_update_app_info(p_data, p_hwfn, p_ptt, enable,
313 priority, tc, type); 322 priority, tc, type);
314 } 323 }
315 } 324 }
@@ -331,7 +340,7 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
331 continue; 340 continue;
332 341
333 enable = (type == DCBX_PROTOCOL_ETH) ? false : !!dcbx_version; 342 enable = (type == DCBX_PROTOCOL_ETH) ? false : !!dcbx_version;
334 qed_dcbx_update_app_info(p_data, p_hwfn, enable, 343 qed_dcbx_update_app_info(p_data, p_hwfn, p_ptt, enable,
335 priority, tc, type); 344 priority, tc, type);
336 } 345 }
337 346
@@ -341,7 +350,8 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
341/* Parse app TLV's to update TC information in hw_info structure for 350/* Parse app TLV's to update TC information in hw_info structure for
342 * reconfiguring QM. Get protocol specific data for PF update ramrod command. 351 * reconfiguring QM. Get protocol specific data for PF update ramrod command.
343 */ 352 */
344static int qed_dcbx_process_mib_info(struct qed_hwfn *p_hwfn) 353static int
354qed_dcbx_process_mib_info(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
345{ 355{
346 struct dcbx_app_priority_feature *p_app; 356 struct dcbx_app_priority_feature *p_app;
347 struct dcbx_app_priority_entry *p_tbl; 357 struct dcbx_app_priority_entry *p_tbl;
@@ -365,7 +375,7 @@ static int qed_dcbx_process_mib_info(struct qed_hwfn *p_hwfn)
365 p_info = &p_hwfn->hw_info; 375 p_info = &p_hwfn->hw_info;
366 num_entries = QED_MFW_GET_FIELD(p_app->flags, DCBX_APP_NUM_ENTRIES); 376 num_entries = QED_MFW_GET_FIELD(p_app->flags, DCBX_APP_NUM_ENTRIES);
367 377
368 rc = qed_dcbx_process_tlv(p_hwfn, &data, p_tbl, pri_tc_tbl, 378 rc = qed_dcbx_process_tlv(p_hwfn, p_ptt, &data, p_tbl, pri_tc_tbl,
369 num_entries, dcbx_version); 379 num_entries, dcbx_version);
370 if (rc) 380 if (rc)
371 return rc; 381 return rc;
@@ -891,7 +901,7 @@ qed_dcbx_mib_update_event(struct qed_hwfn *p_hwfn,
891 return rc; 901 return rc;
892 902
893 if (type == QED_DCBX_OPERATIONAL_MIB) { 903 if (type == QED_DCBX_OPERATIONAL_MIB) {
894 rc = qed_dcbx_process_mib_info(p_hwfn); 904 rc = qed_dcbx_process_mib_info(p_hwfn, p_ptt);
895 if (!rc) { 905 if (!rc) {
896 /* reconfigure tcs of QM queues according 906 /* reconfigure tcs of QM queues according
897 * to negotiation results 907 * to negotiation results
@@ -954,6 +964,7 @@ static void qed_dcbx_update_protocol_data(struct protocol_dcb_data *p_data,
954 p_data->dcb_enable_flag = p_src->arr[type].enable; 964 p_data->dcb_enable_flag = p_src->arr[type].enable;
955 p_data->dcb_priority = p_src->arr[type].priority; 965 p_data->dcb_priority = p_src->arr[type].priority;
956 p_data->dcb_tc = p_src->arr[type].tc; 966 p_data->dcb_tc = p_src->arr[type].tc;
967 p_data->dcb_dont_add_vlan0 = p_src->arr[type].dont_add_vlan0;
957} 968}
958 969
959/* Set pf update ramrod command params */ 970/* Set pf update ramrod command params */
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.h b/drivers/net/ethernet/qlogic/qed/qed_dcbx.h
index a4d688c04e18..01f253ea4b22 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.h
@@ -55,6 +55,7 @@ struct qed_dcbx_app_data {
55 u8 update; /* Update indication */ 55 u8 update; /* Update indication */
56 u8 priority; /* Priority */ 56 u8 priority; /* Priority */
57 u8 tc; /* Traffic Class */ 57 u8 tc; /* Traffic Class */
58 bool dont_add_vlan0; /* Do not insert a vlan tag with id 0 */
58}; 59};
59 60
60#define QED_DCBX_VERSION_DISABLED 0 61#define QED_DCBX_VERSION_DISABLED 0
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index 016ca8a7ec8a..97f073fd3725 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -1706,7 +1706,7 @@ static int qed_vf_start(struct qed_hwfn *p_hwfn,
1706int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params) 1706int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params)
1707{ 1707{
1708 struct qed_load_req_params load_req_params; 1708 struct qed_load_req_params load_req_params;
1709 u32 load_code, param, drv_mb_param; 1709 u32 load_code, resp, param, drv_mb_param;
1710 bool b_default_mtu = true; 1710 bool b_default_mtu = true;
1711 struct qed_hwfn *p_hwfn; 1711 struct qed_hwfn *p_hwfn;
1712 int rc = 0, mfw_rc, i; 1712 int rc = 0, mfw_rc, i;
@@ -1852,6 +1852,19 @@ int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params)
1852 1852
1853 if (IS_PF(cdev)) { 1853 if (IS_PF(cdev)) {
1854 p_hwfn = QED_LEADING_HWFN(cdev); 1854 p_hwfn = QED_LEADING_HWFN(cdev);
1855
1856 /* Get pre-negotiated values for stag, bandwidth etc. */
1857 DP_VERBOSE(p_hwfn,
1858 QED_MSG_SPQ,
1859 "Sending GET_OEM_UPDATES command to trigger stag/bandwidth attention handling\n");
1860 drv_mb_param = 1 << DRV_MB_PARAM_DUMMY_OEM_UPDATES_OFFSET;
1861 rc = qed_mcp_cmd(p_hwfn, p_hwfn->p_main_ptt,
1862 DRV_MSG_CODE_GET_OEM_UPDATES,
1863 drv_mb_param, &resp, &param);
1864 if (rc)
1865 DP_NOTICE(p_hwfn,
1866 "Failed to send GET_OEM_UPDATES attention request\n");
1867
1855 drv_mb_param = STORM_FW_VERSION; 1868 drv_mb_param = STORM_FW_VERSION;
1856 rc = qed_mcp_cmd(p_hwfn, p_hwfn->p_main_ptt, 1869 rc = qed_mcp_cmd(p_hwfn, p_hwfn->p_main_ptt,
1857 DRV_MSG_CODE_OV_UPDATE_STORM_FW_VER, 1870 DRV_MSG_CODE_OV_UPDATE_STORM_FW_VER,
diff --git a/drivers/net/ethernet/qlogic/qed/qed_hsi.h b/drivers/net/ethernet/qlogic/qed/qed_hsi.h
index 8faceb691657..a71382687ef2 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_hsi.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_hsi.h
@@ -11987,6 +11987,7 @@ struct public_global {
11987 u32 running_bundle_id; 11987 u32 running_bundle_id;
11988 s32 external_temperature; 11988 s32 external_temperature;
11989 u32 mdump_reason; 11989 u32 mdump_reason;
11990 u64 reserved;
11990 u32 data_ptr; 11991 u32 data_ptr;
11991 u32 data_size; 11992 u32 data_size;
11992}; 11993};
@@ -12414,6 +12415,7 @@ struct public_drv_mb {
12414#define DRV_MSG_SET_RESOURCE_VALUE_MSG 0x35000000 12415#define DRV_MSG_SET_RESOURCE_VALUE_MSG 0x35000000
12415#define DRV_MSG_CODE_OV_UPDATE_WOL 0x38000000 12416#define DRV_MSG_CODE_OV_UPDATE_WOL 0x38000000
12416#define DRV_MSG_CODE_OV_UPDATE_ESWITCH_MODE 0x39000000 12417#define DRV_MSG_CODE_OV_UPDATE_ESWITCH_MODE 0x39000000
12418#define DRV_MSG_CODE_GET_OEM_UPDATES 0x41000000
12417 12419
12418#define DRV_MSG_CODE_BW_UPDATE_ACK 0x32000000 12420#define DRV_MSG_CODE_BW_UPDATE_ACK 0x32000000
12419#define DRV_MSG_CODE_NIG_DRAIN 0x30000000 12421#define DRV_MSG_CODE_NIG_DRAIN 0x30000000
@@ -12541,6 +12543,9 @@ struct public_drv_mb {
12541#define DRV_MB_PARAM_ESWITCH_MODE_VEB 0x1 12543#define DRV_MB_PARAM_ESWITCH_MODE_VEB 0x1
12542#define DRV_MB_PARAM_ESWITCH_MODE_VEPA 0x2 12544#define DRV_MB_PARAM_ESWITCH_MODE_VEPA 0x2
12543 12545
12546#define DRV_MB_PARAM_DUMMY_OEM_UPDATES_MASK 0x1
12547#define DRV_MB_PARAM_DUMMY_OEM_UPDATES_OFFSET 0
12548
12544#define DRV_MB_PARAM_SET_LED_MODE_OPER 0x0 12549#define DRV_MB_PARAM_SET_LED_MODE_OPER 0x0
12545#define DRV_MB_PARAM_SET_LED_MODE_ON 0x1 12550#define DRV_MB_PARAM_SET_LED_MODE_ON 0x1
12546#define DRV_MB_PARAM_SET_LED_MODE_OFF 0x2 12551#define DRV_MB_PARAM_SET_LED_MODE_OFF 0x2
diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
index 17f3dfa2cc94..e860bdf0f752 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
@@ -1710,7 +1710,7 @@ qed_iwarp_parse_rx_pkt(struct qed_hwfn *p_hwfn,
1710 1710
1711 cm_info->local_ip[0] = ntohl(iph->daddr); 1711 cm_info->local_ip[0] = ntohl(iph->daddr);
1712 cm_info->remote_ip[0] = ntohl(iph->saddr); 1712 cm_info->remote_ip[0] = ntohl(iph->saddr);
1713 cm_info->ip_version = TCP_IPV4; 1713 cm_info->ip_version = QED_TCP_IPV4;
1714 1714
1715 ip_hlen = (iph->ihl) * sizeof(u32); 1715 ip_hlen = (iph->ihl) * sizeof(u32);
1716 *payload_len = ntohs(iph->tot_len) - ip_hlen; 1716 *payload_len = ntohs(iph->tot_len) - ip_hlen;
@@ -1730,7 +1730,7 @@ qed_iwarp_parse_rx_pkt(struct qed_hwfn *p_hwfn,
1730 cm_info->remote_ip[i] = 1730 cm_info->remote_ip[i] =
1731 ntohl(ip6h->saddr.in6_u.u6_addr32[i]); 1731 ntohl(ip6h->saddr.in6_u.u6_addr32[i]);
1732 } 1732 }
1733 cm_info->ip_version = TCP_IPV6; 1733 cm_info->ip_version = QED_TCP_IPV6;
1734 1734
1735 ip_hlen = sizeof(*ip6h); 1735 ip_hlen = sizeof(*ip6h);
1736 *payload_len = ntohs(ip6h->payload_len); 1736 *payload_len = ntohs(ip6h->payload_len);
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
index 5d37ec7e9b0b..58c7eb9d8e1b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
@@ -1581,13 +1581,29 @@ static void qed_mcp_update_stag(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
1581 p_hwfn->mcp_info->func_info.ovlan = (u16)shmem_info.ovlan_stag & 1581 p_hwfn->mcp_info->func_info.ovlan = (u16)shmem_info.ovlan_stag &
1582 FUNC_MF_CFG_OV_STAG_MASK; 1582 FUNC_MF_CFG_OV_STAG_MASK;
1583 p_hwfn->hw_info.ovlan = p_hwfn->mcp_info->func_info.ovlan; 1583 p_hwfn->hw_info.ovlan = p_hwfn->mcp_info->func_info.ovlan;
1584 if ((p_hwfn->hw_info.hw_mode & BIT(MODE_MF_SD)) && 1584 if (test_bit(QED_MF_OVLAN_CLSS, &p_hwfn->cdev->mf_bits)) {
1585 (p_hwfn->hw_info.ovlan != QED_MCP_VLAN_UNSET)) { 1585 if (p_hwfn->hw_info.ovlan != QED_MCP_VLAN_UNSET) {
1586 qed_wr(p_hwfn, p_ptt, 1586 qed_wr(p_hwfn, p_ptt, NIG_REG_LLH_FUNC_TAG_VALUE,
1587 NIG_REG_LLH_FUNC_TAG_VALUE, p_hwfn->hw_info.ovlan); 1587 p_hwfn->hw_info.ovlan);
1588 qed_wr(p_hwfn, p_ptt, NIG_REG_LLH_FUNC_TAG_EN, 1);
1589
1590 /* Configure DB to add external vlan to EDPM packets */
1591 qed_wr(p_hwfn, p_ptt, DORQ_REG_TAG1_OVRD_MODE, 1);
1592 qed_wr(p_hwfn, p_ptt, DORQ_REG_PF_EXT_VID_BB_K2,
1593 p_hwfn->hw_info.ovlan);
1594 } else {
1595 qed_wr(p_hwfn, p_ptt, NIG_REG_LLH_FUNC_TAG_EN, 0);
1596 qed_wr(p_hwfn, p_ptt, NIG_REG_LLH_FUNC_TAG_VALUE, 0);
1597 qed_wr(p_hwfn, p_ptt, DORQ_REG_TAG1_OVRD_MODE, 0);
1598 qed_wr(p_hwfn, p_ptt, DORQ_REG_PF_EXT_VID_BB_K2, 0);
1599 }
1600
1588 qed_sp_pf_update_stag(p_hwfn); 1601 qed_sp_pf_update_stag(p_hwfn);
1589 } 1602 }
1590 1603
1604 DP_VERBOSE(p_hwfn, QED_MSG_SP, "ovlan = %d hw_mode = 0x%x\n",
1605 p_hwfn->mcp_info->func_info.ovlan, p_hwfn->hw_info.hw_mode);
1606
1591 /* Acknowledge the MFW */ 1607 /* Acknowledge the MFW */
1592 qed_mcp_cmd(p_hwfn, p_ptt, DRV_MSG_CODE_S_TAG_UPDATE_ACK, 0, 1608 qed_mcp_cmd(p_hwfn, p_ptt, DRV_MSG_CODE_S_TAG_UPDATE_ACK, 0,
1593 &resp, &param); 1609 &resp, &param);
diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index be941cfaa2d4..c71391b9c757 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -228,7 +228,7 @@ static int qed_rdma_alloc(struct qed_hwfn *p_hwfn,
228 num_cons, "Toggle"); 228 num_cons, "Toggle");
229 if (rc) { 229 if (rc) {
230 DP_VERBOSE(p_hwfn, QED_MSG_RDMA, 230 DP_VERBOSE(p_hwfn, QED_MSG_RDMA,
231 "Failed to allocate toogle bits, rc = %d\n", rc); 231 "Failed to allocate toggle bits, rc = %d\n", rc);
232 goto free_cq_map; 232 goto free_cq_map;
233 } 233 }
234 234
diff --git a/drivers/net/ethernet/qlogic/qed/qed_reg_addr.h b/drivers/net/ethernet/qlogic/qed/qed_reg_addr.h
index f736f70956fd..2440970882c4 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_reg_addr.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_reg_addr.h
@@ -216,6 +216,12 @@
216 0x00c000UL 216 0x00c000UL
217#define DORQ_REG_IFEN \ 217#define DORQ_REG_IFEN \
218 0x100040UL 218 0x100040UL
219#define DORQ_REG_TAG1_OVRD_MODE \
220 0x1008b4UL
221#define DORQ_REG_PF_PCP_BB_K2 \
222 0x1008c4UL
223#define DORQ_REG_PF_EXT_VID_BB_K2 \
224 0x1008c8UL
219#define DORQ_REG_DB_DROP_REASON \ 225#define DORQ_REG_DB_DROP_REASON \
220 0x100a2cUL 226 0x100a2cUL
221#define DORQ_REG_DB_DROP_DETAILS \ 227#define DORQ_REG_DB_DROP_DETAILS \
diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c b/drivers/net/ethernet/qlogic/qed/qed_roce.c
index 7d7a64c55ff1..f9167d1354bb 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_roce.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c
@@ -140,23 +140,16 @@ static void qed_rdma_copy_gids(struct qed_rdma_qp *qp, __le32 *src_gid,
140 140
141static enum roce_flavor qed_roce_mode_to_flavor(enum roce_mode roce_mode) 141static enum roce_flavor qed_roce_mode_to_flavor(enum roce_mode roce_mode)
142{ 142{
143 enum roce_flavor flavor;
144
145 switch (roce_mode) { 143 switch (roce_mode) {
146 case ROCE_V1: 144 case ROCE_V1:
147 flavor = PLAIN_ROCE; 145 return PLAIN_ROCE;
148 break;
149 case ROCE_V2_IPV4: 146 case ROCE_V2_IPV4:
150 flavor = RROCE_IPV4; 147 return RROCE_IPV4;
151 break;
152 case ROCE_V2_IPV6: 148 case ROCE_V2_IPV6:
153 flavor = ROCE_V2_IPV6; 149 return RROCE_IPV6;
154 break;
155 default: 150 default:
156 flavor = MAX_ROCE_MODE; 151 return MAX_ROCE_FLAVOR;
157 break;
158 } 152 }
159 return flavor;
160} 153}
161 154
162static void qed_roce_free_cid_pair(struct qed_hwfn *p_hwfn, u16 cid) 155static void qed_roce_free_cid_pair(struct qed_hwfn *p_hwfn, u16 cid)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
index 8de644b4721e..77b6248ad3b9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
@@ -154,7 +154,7 @@ qed_set_pf_update_tunn_mode(struct qed_tunnel_info *p_tun,
154static void qed_set_tunn_cls_info(struct qed_tunnel_info *p_tun, 154static void qed_set_tunn_cls_info(struct qed_tunnel_info *p_tun,
155 struct qed_tunnel_info *p_src) 155 struct qed_tunnel_info *p_src)
156{ 156{
157 enum tunnel_clss type; 157 int type;
158 158
159 p_tun->b_update_rx_cls = p_src->b_update_rx_cls; 159 p_tun->b_update_rx_cls = p_src->b_update_rx_cls;
160 p_tun->b_update_tx_cls = p_src->b_update_tx_cls; 160 p_tun->b_update_tx_cls = p_src->b_update_tx_cls;
diff --git a/drivers/net/ethernet/qlogic/qed/qed_vf.c b/drivers/net/ethernet/qlogic/qed/qed_vf.c
index 3d4269659820..be118d057b92 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_vf.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c
@@ -413,7 +413,6 @@ static int qed_vf_pf_acquire(struct qed_hwfn *p_hwfn)
413 } 413 }
414 414
415 if (!p_iov->b_pre_fp_hsi && 415 if (!p_iov->b_pre_fp_hsi &&
416 ETH_HSI_VER_MINOR &&
417 (resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR)) { 416 (resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR)) {
418 DP_INFO(p_hwfn, 417 DP_INFO(p_hwfn,
419 "PF is using older fastpath HSI; %02x.%02x is configured\n", 418 "PF is using older fastpath HSI; %02x.%02x is configured\n",
@@ -572,7 +571,7 @@ free_p_iov:
572static void 571static void
573__qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req, 572__qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req,
574 struct qed_tunn_update_type *p_src, 573 struct qed_tunn_update_type *p_src,
575 enum qed_tunn_clss mask, u8 *p_cls) 574 enum qed_tunn_mode mask, u8 *p_cls)
576{ 575{
577 if (p_src->b_update_mode) { 576 if (p_src->b_update_mode) {
578 p_req->tun_mode_update_mask |= BIT(mask); 577 p_req->tun_mode_update_mask |= BIT(mask);
@@ -587,7 +586,7 @@ __qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req,
587static void 586static void
588qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req, 587qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req,
589 struct qed_tunn_update_type *p_src, 588 struct qed_tunn_update_type *p_src,
590 enum qed_tunn_clss mask, 589 enum qed_tunn_mode mask,
591 u8 *p_cls, struct qed_tunn_update_udp_port *p_port, 590 u8 *p_cls, struct qed_tunn_update_udp_port *p_port,
592 u8 *p_update_port, u16 *p_udp_port) 591 u8 *p_update_port, u16 *p_udp_port)
593{ 592{
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
index 81312924df14..0c443ea98479 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
@@ -1800,7 +1800,8 @@ struct qlcnic_hardware_ops {
1800 int (*config_loopback) (struct qlcnic_adapter *, u8); 1800 int (*config_loopback) (struct qlcnic_adapter *, u8);
1801 int (*clear_loopback) (struct qlcnic_adapter *, u8); 1801 int (*clear_loopback) (struct qlcnic_adapter *, u8);
1802 int (*config_promisc_mode) (struct qlcnic_adapter *, u32); 1802 int (*config_promisc_mode) (struct qlcnic_adapter *, u32);
1803 void (*change_l2_filter) (struct qlcnic_adapter *, u64 *, u16); 1803 void (*change_l2_filter)(struct qlcnic_adapter *adapter, u64 *addr,
1804 u16 vlan, struct qlcnic_host_tx_ring *tx_ring);
1804 int (*get_board_info) (struct qlcnic_adapter *); 1805 int (*get_board_info) (struct qlcnic_adapter *);
1805 void (*set_mac_filter_count) (struct qlcnic_adapter *); 1806 void (*set_mac_filter_count) (struct qlcnic_adapter *);
1806 void (*free_mac_list) (struct qlcnic_adapter *); 1807 void (*free_mac_list) (struct qlcnic_adapter *);
@@ -2064,9 +2065,10 @@ static inline int qlcnic_nic_set_promisc(struct qlcnic_adapter *adapter,
2064} 2065}
2065 2066
2066static inline void qlcnic_change_filter(struct qlcnic_adapter *adapter, 2067static inline void qlcnic_change_filter(struct qlcnic_adapter *adapter,
2067 u64 *addr, u16 id) 2068 u64 *addr, u16 vlan,
2069 struct qlcnic_host_tx_ring *tx_ring)
2068{ 2070{
2069 adapter->ahw->hw_ops->change_l2_filter(adapter, addr, id); 2071 adapter->ahw->hw_ops->change_l2_filter(adapter, addr, vlan, tx_ring);
2070} 2072}
2071 2073
2072static inline int qlcnic_get_board_info(struct qlcnic_adapter *adapter) 2074static inline int qlcnic_get_board_info(struct qlcnic_adapter *adapter)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index 569d54ededec..a79d84f99102 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -2135,7 +2135,8 @@ out:
2135} 2135}
2136 2136
2137void qlcnic_83xx_change_l2_filter(struct qlcnic_adapter *adapter, u64 *addr, 2137void qlcnic_83xx_change_l2_filter(struct qlcnic_adapter *adapter, u64 *addr,
2138 u16 vlan_id) 2138 u16 vlan_id,
2139 struct qlcnic_host_tx_ring *tx_ring)
2139{ 2140{
2140 u8 mac[ETH_ALEN]; 2141 u8 mac[ETH_ALEN];
2141 memcpy(&mac, addr, ETH_ALEN); 2142 memcpy(&mac, addr, ETH_ALEN);
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
index b75a81246856..73fe2f64491d 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
@@ -550,7 +550,8 @@ int qlcnic_83xx_wrt_reg_indirect(struct qlcnic_adapter *, ulong, u32);
550int qlcnic_83xx_nic_set_promisc(struct qlcnic_adapter *, u32); 550int qlcnic_83xx_nic_set_promisc(struct qlcnic_adapter *, u32);
551int qlcnic_83xx_config_hw_lro(struct qlcnic_adapter *, int); 551int qlcnic_83xx_config_hw_lro(struct qlcnic_adapter *, int);
552int qlcnic_83xx_config_rss(struct qlcnic_adapter *, int); 552int qlcnic_83xx_config_rss(struct qlcnic_adapter *, int);
553void qlcnic_83xx_change_l2_filter(struct qlcnic_adapter *, u64 *, u16); 553void qlcnic_83xx_change_l2_filter(struct qlcnic_adapter *adapter, u64 *addr,
554 u16 vlan, struct qlcnic_host_tx_ring *ring);
554int qlcnic_83xx_get_pci_info(struct qlcnic_adapter *, struct qlcnic_pci_info *); 555int qlcnic_83xx_get_pci_info(struct qlcnic_adapter *, struct qlcnic_pci_info *);
555int qlcnic_83xx_set_nic_info(struct qlcnic_adapter *, struct qlcnic_info *); 556int qlcnic_83xx_set_nic_info(struct qlcnic_adapter *, struct qlcnic_info *);
556void qlcnic_83xx_initialize_nic(struct qlcnic_adapter *, int); 557void qlcnic_83xx_initialize_nic(struct qlcnic_adapter *, int);
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.h
index 4bb33af8e2b3..56a3bd9e37dc 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.h
@@ -173,7 +173,8 @@ int qlcnic_82xx_napi_add(struct qlcnic_adapter *adapter,
173 struct net_device *netdev); 173 struct net_device *netdev);
174void qlcnic_82xx_get_beacon_state(struct qlcnic_adapter *); 174void qlcnic_82xx_get_beacon_state(struct qlcnic_adapter *);
175void qlcnic_82xx_change_filter(struct qlcnic_adapter *adapter, 175void qlcnic_82xx_change_filter(struct qlcnic_adapter *adapter,
176 u64 *uaddr, u16 vlan_id); 176 u64 *uaddr, u16 vlan_id,
177 struct qlcnic_host_tx_ring *tx_ring);
177int qlcnic_82xx_config_intr_coalesce(struct qlcnic_adapter *, 178int qlcnic_82xx_config_intr_coalesce(struct qlcnic_adapter *,
178 struct ethtool_coalesce *); 179 struct ethtool_coalesce *);
179int qlcnic_82xx_set_rx_coalesce(struct qlcnic_adapter *); 180int qlcnic_82xx_set_rx_coalesce(struct qlcnic_adapter *);
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
index 84dd83031a1b..9647578cbe6a 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
@@ -268,13 +268,12 @@ static void qlcnic_add_lb_filter(struct qlcnic_adapter *adapter,
268} 268}
269 269
270void qlcnic_82xx_change_filter(struct qlcnic_adapter *adapter, u64 *uaddr, 270void qlcnic_82xx_change_filter(struct qlcnic_adapter *adapter, u64 *uaddr,
271 u16 vlan_id) 271 u16 vlan_id, struct qlcnic_host_tx_ring *tx_ring)
272{ 272{
273 struct cmd_desc_type0 *hwdesc; 273 struct cmd_desc_type0 *hwdesc;
274 struct qlcnic_nic_req *req; 274 struct qlcnic_nic_req *req;
275 struct qlcnic_mac_req *mac_req; 275 struct qlcnic_mac_req *mac_req;
276 struct qlcnic_vlan_req *vlan_req; 276 struct qlcnic_vlan_req *vlan_req;
277 struct qlcnic_host_tx_ring *tx_ring = adapter->tx_ring;
278 u32 producer; 277 u32 producer;
279 u64 word; 278 u64 word;
280 279
@@ -301,7 +300,8 @@ void qlcnic_82xx_change_filter(struct qlcnic_adapter *adapter, u64 *uaddr,
301 300
302static void qlcnic_send_filter(struct qlcnic_adapter *adapter, 301static void qlcnic_send_filter(struct qlcnic_adapter *adapter,
303 struct cmd_desc_type0 *first_desc, 302 struct cmd_desc_type0 *first_desc,
304 struct sk_buff *skb) 303 struct sk_buff *skb,
304 struct qlcnic_host_tx_ring *tx_ring)
305{ 305{
306 struct vlan_ethhdr *vh = (struct vlan_ethhdr *)(skb->data); 306 struct vlan_ethhdr *vh = (struct vlan_ethhdr *)(skb->data);
307 struct ethhdr *phdr = (struct ethhdr *)(skb->data); 307 struct ethhdr *phdr = (struct ethhdr *)(skb->data);
@@ -335,7 +335,7 @@ static void qlcnic_send_filter(struct qlcnic_adapter *adapter,
335 tmp_fil->vlan_id == vlan_id) { 335 tmp_fil->vlan_id == vlan_id) {
336 if (jiffies > (QLCNIC_READD_AGE * HZ + tmp_fil->ftime)) 336 if (jiffies > (QLCNIC_READD_AGE * HZ + tmp_fil->ftime))
337 qlcnic_change_filter(adapter, &src_addr, 337 qlcnic_change_filter(adapter, &src_addr,
338 vlan_id); 338 vlan_id, tx_ring);
339 tmp_fil->ftime = jiffies; 339 tmp_fil->ftime = jiffies;
340 return; 340 return;
341 } 341 }
@@ -350,7 +350,7 @@ static void qlcnic_send_filter(struct qlcnic_adapter *adapter,
350 if (!fil) 350 if (!fil)
351 return; 351 return;
352 352
353 qlcnic_change_filter(adapter, &src_addr, vlan_id); 353 qlcnic_change_filter(adapter, &src_addr, vlan_id, tx_ring);
354 fil->ftime = jiffies; 354 fil->ftime = jiffies;
355 fil->vlan_id = vlan_id; 355 fil->vlan_id = vlan_id;
356 memcpy(fil->faddr, &src_addr, ETH_ALEN); 356 memcpy(fil->faddr, &src_addr, ETH_ALEN);
@@ -766,7 +766,7 @@ netdev_tx_t qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
766 } 766 }
767 767
768 if (adapter->drv_mac_learn) 768 if (adapter->drv_mac_learn)
769 qlcnic_send_filter(adapter, first_desc, skb); 769 qlcnic_send_filter(adapter, first_desc, skb, tx_ring);
770 770
771 tx_ring->tx_stats.tx_bytes += skb->len; 771 tx_ring->tx_stats.tx_bytes += skb->len;
772 tx_ring->tx_stats.xmit_called++; 772 tx_ring->tx_stats.xmit_called++;
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 2d38d1ac2aae..dbd48012224f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -59,9 +59,6 @@ static int qlcnic_close(struct net_device *netdev);
59static void qlcnic_tx_timeout(struct net_device *netdev); 59static void qlcnic_tx_timeout(struct net_device *netdev);
60static void qlcnic_attach_work(struct work_struct *work); 60static void qlcnic_attach_work(struct work_struct *work);
61static void qlcnic_fwinit_work(struct work_struct *work); 61static void qlcnic_fwinit_work(struct work_struct *work);
62#ifdef CONFIG_NET_POLL_CONTROLLER
63static void qlcnic_poll_controller(struct net_device *netdev);
64#endif
65 62
66static void qlcnic_idc_debug_info(struct qlcnic_adapter *adapter, u8 encoding); 63static void qlcnic_idc_debug_info(struct qlcnic_adapter *adapter, u8 encoding);
67static int qlcnic_can_start_firmware(struct qlcnic_adapter *adapter); 64static int qlcnic_can_start_firmware(struct qlcnic_adapter *adapter);
@@ -545,9 +542,6 @@ static const struct net_device_ops qlcnic_netdev_ops = {
545 .ndo_udp_tunnel_add = qlcnic_add_vxlan_port, 542 .ndo_udp_tunnel_add = qlcnic_add_vxlan_port,
546 .ndo_udp_tunnel_del = qlcnic_del_vxlan_port, 543 .ndo_udp_tunnel_del = qlcnic_del_vxlan_port,
547 .ndo_features_check = qlcnic_features_check, 544 .ndo_features_check = qlcnic_features_check,
548#ifdef CONFIG_NET_POLL_CONTROLLER
549 .ndo_poll_controller = qlcnic_poll_controller,
550#endif
551#ifdef CONFIG_QLCNIC_SRIOV 545#ifdef CONFIG_QLCNIC_SRIOV
552 .ndo_set_vf_mac = qlcnic_sriov_set_vf_mac, 546 .ndo_set_vf_mac = qlcnic_sriov_set_vf_mac,
553 .ndo_set_vf_rate = qlcnic_sriov_set_vf_tx_rate, 547 .ndo_set_vf_rate = qlcnic_sriov_set_vf_tx_rate,
@@ -3200,45 +3194,6 @@ static irqreturn_t qlcnic_msix_tx_intr(int irq, void *data)
3200 return IRQ_HANDLED; 3194 return IRQ_HANDLED;
3201} 3195}
3202 3196
3203#ifdef CONFIG_NET_POLL_CONTROLLER
3204static void qlcnic_poll_controller(struct net_device *netdev)
3205{
3206 struct qlcnic_adapter *adapter = netdev_priv(netdev);
3207 struct qlcnic_host_sds_ring *sds_ring;
3208 struct qlcnic_recv_context *recv_ctx;
3209 struct qlcnic_host_tx_ring *tx_ring;
3210 int ring;
3211
3212 if (!test_bit(__QLCNIC_DEV_UP, &adapter->state))
3213 return;
3214
3215 recv_ctx = adapter->recv_ctx;
3216
3217 for (ring = 0; ring < adapter->drv_sds_rings; ring++) {
3218 sds_ring = &recv_ctx->sds_rings[ring];
3219 qlcnic_disable_sds_intr(adapter, sds_ring);
3220 napi_schedule(&sds_ring->napi);
3221 }
3222
3223 if (adapter->flags & QLCNIC_MSIX_ENABLED) {
3224 /* Only Multi-Tx queue capable devices need to
3225 * schedule NAPI for TX rings
3226 */
3227 if ((qlcnic_83xx_check(adapter) &&
3228 (adapter->flags & QLCNIC_TX_INTR_SHARED)) ||
3229 (qlcnic_82xx_check(adapter) &&
3230 !qlcnic_check_multi_tx(adapter)))
3231 return;
3232
3233 for (ring = 0; ring < adapter->drv_tx_rings; ring++) {
3234 tx_ring = &adapter->tx_ring[ring];
3235 qlcnic_disable_tx_intr(adapter, tx_ring);
3236 napi_schedule(&tx_ring->napi);
3237 }
3238 }
3239}
3240#endif
3241
3242static void 3197static void
3243qlcnic_idc_debug_info(struct qlcnic_adapter *adapter, u8 encoding) 3198qlcnic_idc_debug_info(struct qlcnic_adapter *adapter, u8 encoding)
3244{ 3199{
diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c
index ffe7a16bdfc8..6c8543fb90c0 100644
--- a/drivers/net/ethernet/qualcomm/qca_7k.c
+++ b/drivers/net/ethernet/qualcomm/qca_7k.c
@@ -45,34 +45,33 @@ qcaspi_read_register(struct qcaspi *qca, u16 reg, u16 *result)
45{ 45{
46 __be16 rx_data; 46 __be16 rx_data;
47 __be16 tx_data; 47 __be16 tx_data;
48 struct spi_transfer *transfer; 48 struct spi_transfer transfer[2];
49 struct spi_message *msg; 49 struct spi_message msg;
50 int ret; 50 int ret;
51 51
52 memset(transfer, 0, sizeof(transfer));
53
54 spi_message_init(&msg);
55
52 tx_data = cpu_to_be16(QCA7K_SPI_READ | QCA7K_SPI_INTERNAL | reg); 56 tx_data = cpu_to_be16(QCA7K_SPI_READ | QCA7K_SPI_INTERNAL | reg);
57 *result = 0;
58
59 transfer[0].tx_buf = &tx_data;
60 transfer[0].len = QCASPI_CMD_LEN;
61 transfer[1].rx_buf = &rx_data;
62 transfer[1].len = QCASPI_CMD_LEN;
63
64 spi_message_add_tail(&transfer[0], &msg);
53 65
54 if (qca->legacy_mode) { 66 if (qca->legacy_mode) {
55 msg = &qca->spi_msg1; 67 spi_sync(qca->spi_dev, &msg);
56 transfer = &qca->spi_xfer1; 68 spi_message_init(&msg);
57 transfer->tx_buf = &tx_data;
58 transfer->rx_buf = NULL;
59 transfer->len = QCASPI_CMD_LEN;
60 spi_sync(qca->spi_dev, msg);
61 } else {
62 msg = &qca->spi_msg2;
63 transfer = &qca->spi_xfer2[0];
64 transfer->tx_buf = &tx_data;
65 transfer->rx_buf = NULL;
66 transfer->len = QCASPI_CMD_LEN;
67 transfer = &qca->spi_xfer2[1];
68 } 69 }
69 transfer->tx_buf = NULL; 70 spi_message_add_tail(&transfer[1], &msg);
70 transfer->rx_buf = &rx_data; 71 ret = spi_sync(qca->spi_dev, &msg);
71 transfer->len = QCASPI_CMD_LEN;
72 ret = spi_sync(qca->spi_dev, msg);
73 72
74 if (!ret) 73 if (!ret)
75 ret = msg->status; 74 ret = msg.status;
76 75
77 if (ret) 76 if (ret)
78 qcaspi_spi_error(qca); 77 qcaspi_spi_error(qca);
@@ -86,35 +85,32 @@ int
86qcaspi_write_register(struct qcaspi *qca, u16 reg, u16 value) 85qcaspi_write_register(struct qcaspi *qca, u16 reg, u16 value)
87{ 86{
88 __be16 tx_data[2]; 87 __be16 tx_data[2];
89 struct spi_transfer *transfer; 88 struct spi_transfer transfer[2];
90 struct spi_message *msg; 89 struct spi_message msg;
91 int ret; 90 int ret;
92 91
92 memset(&transfer, 0, sizeof(transfer));
93
94 spi_message_init(&msg);
95
93 tx_data[0] = cpu_to_be16(QCA7K_SPI_WRITE | QCA7K_SPI_INTERNAL | reg); 96 tx_data[0] = cpu_to_be16(QCA7K_SPI_WRITE | QCA7K_SPI_INTERNAL | reg);
94 tx_data[1] = cpu_to_be16(value); 97 tx_data[1] = cpu_to_be16(value);
95 98
99 transfer[0].tx_buf = &tx_data[0];
100 transfer[0].len = QCASPI_CMD_LEN;
101 transfer[1].tx_buf = &tx_data[1];
102 transfer[1].len = QCASPI_CMD_LEN;
103
104 spi_message_add_tail(&transfer[0], &msg);
96 if (qca->legacy_mode) { 105 if (qca->legacy_mode) {
97 msg = &qca->spi_msg1; 106 spi_sync(qca->spi_dev, &msg);
98 transfer = &qca->spi_xfer1; 107 spi_message_init(&msg);
99 transfer->tx_buf = &tx_data[0];
100 transfer->rx_buf = NULL;
101 transfer->len = QCASPI_CMD_LEN;
102 spi_sync(qca->spi_dev, msg);
103 } else {
104 msg = &qca->spi_msg2;
105 transfer = &qca->spi_xfer2[0];
106 transfer->tx_buf = &tx_data[0];
107 transfer->rx_buf = NULL;
108 transfer->len = QCASPI_CMD_LEN;
109 transfer = &qca->spi_xfer2[1];
110 } 108 }
111 transfer->tx_buf = &tx_data[1]; 109 spi_message_add_tail(&transfer[1], &msg);
112 transfer->rx_buf = NULL; 110 ret = spi_sync(qca->spi_dev, &msg);
113 transfer->len = QCASPI_CMD_LEN;
114 ret = spi_sync(qca->spi_dev, msg);
115 111
116 if (!ret) 112 if (!ret)
117 ret = msg->status; 113 ret = msg.status;
118 114
119 if (ret) 115 if (ret)
120 qcaspi_spi_error(qca); 116 qcaspi_spi_error(qca);
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index 206f0266463e..66b775d462fd 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -99,22 +99,24 @@ static u32
99qcaspi_write_burst(struct qcaspi *qca, u8 *src, u32 len) 99qcaspi_write_burst(struct qcaspi *qca, u8 *src, u32 len)
100{ 100{
101 __be16 cmd; 101 __be16 cmd;
102 struct spi_message *msg = &qca->spi_msg2; 102 struct spi_message msg;
103 struct spi_transfer *transfer = &qca->spi_xfer2[0]; 103 struct spi_transfer transfer[2];
104 int ret; 104 int ret;
105 105
106 memset(&transfer, 0, sizeof(transfer));
107 spi_message_init(&msg);
108
106 cmd = cpu_to_be16(QCA7K_SPI_WRITE | QCA7K_SPI_EXTERNAL); 109 cmd = cpu_to_be16(QCA7K_SPI_WRITE | QCA7K_SPI_EXTERNAL);
107 transfer->tx_buf = &cmd; 110 transfer[0].tx_buf = &cmd;
108 transfer->rx_buf = NULL; 111 transfer[0].len = QCASPI_CMD_LEN;
109 transfer->len = QCASPI_CMD_LEN; 112 transfer[1].tx_buf = src;
110 transfer = &qca->spi_xfer2[1]; 113 transfer[1].len = len;
111 transfer->tx_buf = src;
112 transfer->rx_buf = NULL;
113 transfer->len = len;
114 114
115 ret = spi_sync(qca->spi_dev, msg); 115 spi_message_add_tail(&transfer[0], &msg);
116 spi_message_add_tail(&transfer[1], &msg);
117 ret = spi_sync(qca->spi_dev, &msg);
116 118
117 if (ret || (msg->actual_length != QCASPI_CMD_LEN + len)) { 119 if (ret || (msg.actual_length != QCASPI_CMD_LEN + len)) {
118 qcaspi_spi_error(qca); 120 qcaspi_spi_error(qca);
119 return 0; 121 return 0;
120 } 122 }
@@ -125,17 +127,20 @@ qcaspi_write_burst(struct qcaspi *qca, u8 *src, u32 len)
125static u32 127static u32
126qcaspi_write_legacy(struct qcaspi *qca, u8 *src, u32 len) 128qcaspi_write_legacy(struct qcaspi *qca, u8 *src, u32 len)
127{ 129{
128 struct spi_message *msg = &qca->spi_msg1; 130 struct spi_message msg;
129 struct spi_transfer *transfer = &qca->spi_xfer1; 131 struct spi_transfer transfer;
130 int ret; 132 int ret;
131 133
132 transfer->tx_buf = src; 134 memset(&transfer, 0, sizeof(transfer));
133 transfer->rx_buf = NULL; 135 spi_message_init(&msg);
134 transfer->len = len; 136
137 transfer.tx_buf = src;
138 transfer.len = len;
135 139
136 ret = spi_sync(qca->spi_dev, msg); 140 spi_message_add_tail(&transfer, &msg);
141 ret = spi_sync(qca->spi_dev, &msg);
137 142
138 if (ret || (msg->actual_length != len)) { 143 if (ret || (msg.actual_length != len)) {
139 qcaspi_spi_error(qca); 144 qcaspi_spi_error(qca);
140 return 0; 145 return 0;
141 } 146 }
@@ -146,23 +151,25 @@ qcaspi_write_legacy(struct qcaspi *qca, u8 *src, u32 len)
146static u32 151static u32
147qcaspi_read_burst(struct qcaspi *qca, u8 *dst, u32 len) 152qcaspi_read_burst(struct qcaspi *qca, u8 *dst, u32 len)
148{ 153{
149 struct spi_message *msg = &qca->spi_msg2; 154 struct spi_message msg;
150 __be16 cmd; 155 __be16 cmd;
151 struct spi_transfer *transfer = &qca->spi_xfer2[0]; 156 struct spi_transfer transfer[2];
152 int ret; 157 int ret;
153 158
159 memset(&transfer, 0, sizeof(transfer));
160 spi_message_init(&msg);
161
154 cmd = cpu_to_be16(QCA7K_SPI_READ | QCA7K_SPI_EXTERNAL); 162 cmd = cpu_to_be16(QCA7K_SPI_READ | QCA7K_SPI_EXTERNAL);
155 transfer->tx_buf = &cmd; 163 transfer[0].tx_buf = &cmd;
156 transfer->rx_buf = NULL; 164 transfer[0].len = QCASPI_CMD_LEN;
157 transfer->len = QCASPI_CMD_LEN; 165 transfer[1].rx_buf = dst;
158 transfer = &qca->spi_xfer2[1]; 166 transfer[1].len = len;
159 transfer->tx_buf = NULL;
160 transfer->rx_buf = dst;
161 transfer->len = len;
162 167
163 ret = spi_sync(qca->spi_dev, msg); 168 spi_message_add_tail(&transfer[0], &msg);
169 spi_message_add_tail(&transfer[1], &msg);
170 ret = spi_sync(qca->spi_dev, &msg);
164 171
165 if (ret || (msg->actual_length != QCASPI_CMD_LEN + len)) { 172 if (ret || (msg.actual_length != QCASPI_CMD_LEN + len)) {
166 qcaspi_spi_error(qca); 173 qcaspi_spi_error(qca);
167 return 0; 174 return 0;
168 } 175 }
@@ -173,17 +180,20 @@ qcaspi_read_burst(struct qcaspi *qca, u8 *dst, u32 len)
173static u32 180static u32
174qcaspi_read_legacy(struct qcaspi *qca, u8 *dst, u32 len) 181qcaspi_read_legacy(struct qcaspi *qca, u8 *dst, u32 len)
175{ 182{
176 struct spi_message *msg = &qca->spi_msg1; 183 struct spi_message msg;
177 struct spi_transfer *transfer = &qca->spi_xfer1; 184 struct spi_transfer transfer;
178 int ret; 185 int ret;
179 186
180 transfer->tx_buf = NULL; 187 memset(&transfer, 0, sizeof(transfer));
181 transfer->rx_buf = dst; 188 spi_message_init(&msg);
182 transfer->len = len;
183 189
184 ret = spi_sync(qca->spi_dev, msg); 190 transfer.rx_buf = dst;
191 transfer.len = len;
185 192
186 if (ret || (msg->actual_length != len)) { 193 spi_message_add_tail(&transfer, &msg);
194 ret = spi_sync(qca->spi_dev, &msg);
195
196 if (ret || (msg.actual_length != len)) {
187 qcaspi_spi_error(qca); 197 qcaspi_spi_error(qca);
188 return 0; 198 return 0;
189 } 199 }
@@ -195,19 +205,23 @@ static int
195qcaspi_tx_cmd(struct qcaspi *qca, u16 cmd) 205qcaspi_tx_cmd(struct qcaspi *qca, u16 cmd)
196{ 206{
197 __be16 tx_data; 207 __be16 tx_data;
198 struct spi_message *msg = &qca->spi_msg1; 208 struct spi_message msg;
199 struct spi_transfer *transfer = &qca->spi_xfer1; 209 struct spi_transfer transfer;
200 int ret; 210 int ret;
201 211
212 memset(&transfer, 0, sizeof(transfer));
213
214 spi_message_init(&msg);
215
202 tx_data = cpu_to_be16(cmd); 216 tx_data = cpu_to_be16(cmd);
203 transfer->len = sizeof(tx_data); 217 transfer.len = sizeof(cmd);
204 transfer->tx_buf = &tx_data; 218 transfer.tx_buf = &tx_data;
205 transfer->rx_buf = NULL; 219 spi_message_add_tail(&transfer, &msg);
206 220
207 ret = spi_sync(qca->spi_dev, msg); 221 ret = spi_sync(qca->spi_dev, &msg);
208 222
209 if (!ret) 223 if (!ret)
210 ret = msg->status; 224 ret = msg.status;
211 225
212 if (ret) 226 if (ret)
213 qcaspi_spi_error(qca); 227 qcaspi_spi_error(qca);
@@ -835,16 +849,6 @@ qcaspi_netdev_setup(struct net_device *dev)
835 qca = netdev_priv(dev); 849 qca = netdev_priv(dev);
836 memset(qca, 0, sizeof(struct qcaspi)); 850 memset(qca, 0, sizeof(struct qcaspi));
837 851
838 memset(&qca->spi_xfer1, 0, sizeof(struct spi_transfer));
839 memset(&qca->spi_xfer2, 0, sizeof(struct spi_transfer) * 2);
840
841 spi_message_init(&qca->spi_msg1);
842 spi_message_add_tail(&qca->spi_xfer1, &qca->spi_msg1);
843
844 spi_message_init(&qca->spi_msg2);
845 spi_message_add_tail(&qca->spi_xfer2[0], &qca->spi_msg2);
846 spi_message_add_tail(&qca->spi_xfer2[1], &qca->spi_msg2);
847
848 memset(&qca->txr, 0, sizeof(qca->txr)); 852 memset(&qca->txr, 0, sizeof(qca->txr));
849 qca->txr.count = TX_RING_MAX_LEN; 853 qca->txr.count = TX_RING_MAX_LEN;
850} 854}
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h
index fc4beb1b32d1..fc0e98726b36 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.h
+++ b/drivers/net/ethernet/qualcomm/qca_spi.h
@@ -83,11 +83,6 @@ struct qcaspi {
83 struct tx_ring txr; 83 struct tx_ring txr;
84 struct qcaspi_stats stats; 84 struct qcaspi_stats stats;
85 85
86 struct spi_message spi_msg1;
87 struct spi_message spi_msg2;
88 struct spi_transfer spi_xfer1;
89 struct spi_transfer spi_xfer2[2];
90
91 u8 *rx_buffer; 86 u8 *rx_buffer;
92 u32 buffer_size; 87 u32 buffer_size;
93 u8 sync; 88 u8 sync;
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
index 7fd86d40a337..11167abe5934 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
@@ -113,7 +113,7 @@ rmnet_map_ingress_handler(struct sk_buff *skb,
113 struct sk_buff *skbn; 113 struct sk_buff *skbn;
114 114
115 if (skb->dev->type == ARPHRD_ETHER) { 115 if (skb->dev->type == ARPHRD_ETHER) {
116 if (pskb_expand_head(skb, ETH_HLEN, 0, GFP_KERNEL)) { 116 if (pskb_expand_head(skb, ETH_HLEN, 0, GFP_ATOMIC)) {
117 kfree_skb(skb); 117 kfree_skb(skb);
118 return; 118 return;
119 } 119 }
@@ -147,7 +147,7 @@ static int rmnet_map_egress_handler(struct sk_buff *skb,
147 } 147 }
148 148
149 if (skb_headroom(skb) < required_headroom) { 149 if (skb_headroom(skb) < required_headroom) {
150 if (pskb_expand_head(skb, required_headroom, 0, GFP_KERNEL)) 150 if (pskb_expand_head(skb, required_headroom, 0, GFP_ATOMIC))
151 return -ENOMEM; 151 return -ENOMEM;
152 } 152 }
153 153
@@ -189,6 +189,9 @@ rx_handler_result_t rmnet_rx_handler(struct sk_buff **pskb)
189 if (!skb) 189 if (!skb)
190 goto done; 190 goto done;
191 191
192 if (skb->pkt_type == PACKET_LOOPBACK)
193 return RX_HANDLER_PASS;
194
192 dev = skb->dev; 195 dev = skb->dev;
193 port = rmnet_get_port(dev); 196 port = rmnet_get_port(dev);
194 197
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index b08d51bf7a20..3a5e6160bf0d 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -13,6 +13,7 @@
13#include <linux/pci.h> 13#include <linux/pci.h>
14#include <linux/netdevice.h> 14#include <linux/netdevice.h>
15#include <linux/etherdevice.h> 15#include <linux/etherdevice.h>
16#include <linux/clk.h>
16#include <linux/delay.h> 17#include <linux/delay.h>
17#include <linux/ethtool.h> 18#include <linux/ethtool.h>
18#include <linux/phy.h> 19#include <linux/phy.h>
@@ -631,7 +632,7 @@ struct rtl8169_tc_offsets {
631}; 632};
632 633
633enum rtl_flag { 634enum rtl_flag {
634 RTL_FLAG_TASK_ENABLED, 635 RTL_FLAG_TASK_ENABLED = 0,
635 RTL_FLAG_TASK_SLOW_PENDING, 636 RTL_FLAG_TASK_SLOW_PENDING,
636 RTL_FLAG_TASK_RESET_PENDING, 637 RTL_FLAG_TASK_RESET_PENDING,
637 RTL_FLAG_MAX 638 RTL_FLAG_MAX
@@ -665,6 +666,7 @@ struct rtl8169_private {
665 666
666 u16 event_slow; 667 u16 event_slow;
667 const struct rtl_coalesce_info *coalesce_info; 668 const struct rtl_coalesce_info *coalesce_info;
669 struct clk *clk;
668 670
669 struct mdio_ops { 671 struct mdio_ops {
670 void (*write)(struct rtl8169_private *, int, int); 672 void (*write)(struct rtl8169_private *, int, int);
@@ -4069,6 +4071,14 @@ static void rtl8169_init_phy(struct net_device *dev, struct rtl8169_private *tp)
4069 phy_speed_up(dev->phydev); 4071 phy_speed_up(dev->phydev);
4070 4072
4071 genphy_soft_reset(dev->phydev); 4073 genphy_soft_reset(dev->phydev);
4074
4075 /* It was reported that several chips end up with 10MBit/Half on a
4076 * 1GBit link after resuming from S3. For whatever reason the PHY on
4077 * these chips doesn't properly start a renegotiation when soft-reset.
4078 * Explicitly requesting a renegotiation fixes this.
4079 */
4080 if (dev->phydev->autoneg == AUTONEG_ENABLE)
4081 phy_restart_aneg(dev->phydev);
4072} 4082}
4073 4083
4074static void rtl_rar_set(struct rtl8169_private *tp, u8 *addr) 4084static void rtl_rar_set(struct rtl8169_private *tp, u8 *addr)
@@ -4272,8 +4282,8 @@ static void rtl_init_rxcfg(struct rtl8169_private *tp)
4272 RTL_W32(tp, RxConfig, RX_FIFO_THRESH | RX_DMA_BURST); 4282 RTL_W32(tp, RxConfig, RX_FIFO_THRESH | RX_DMA_BURST);
4273 break; 4283 break;
4274 case RTL_GIGA_MAC_VER_18 ... RTL_GIGA_MAC_VER_24: 4284 case RTL_GIGA_MAC_VER_18 ... RTL_GIGA_MAC_VER_24:
4275 case RTL_GIGA_MAC_VER_34: 4285 case RTL_GIGA_MAC_VER_34 ... RTL_GIGA_MAC_VER_36:
4276 case RTL_GIGA_MAC_VER_35: 4286 case RTL_GIGA_MAC_VER_38:
4277 RTL_W32(tp, RxConfig, RX128_INT_EN | RX_MULTI_EN | RX_DMA_BURST); 4287 RTL_W32(tp, RxConfig, RX128_INT_EN | RX_MULTI_EN | RX_DMA_BURST);
4278 break; 4288 break;
4279 case RTL_GIGA_MAC_VER_40 ... RTL_GIGA_MAC_VER_51: 4289 case RTL_GIGA_MAC_VER_40 ... RTL_GIGA_MAC_VER_51:
@@ -4525,9 +4535,14 @@ static void rtl8169_hw_reset(struct rtl8169_private *tp)
4525 4535
4526static void rtl_set_tx_config_registers(struct rtl8169_private *tp) 4536static void rtl_set_tx_config_registers(struct rtl8169_private *tp)
4527{ 4537{
4528 /* Set DMA burst size and Interframe Gap Time */ 4538 u32 val = TX_DMA_BURST << TxDMAShift |
4529 RTL_W32(tp, TxConfig, (TX_DMA_BURST << TxDMAShift) | 4539 InterFrameGap << TxInterFrameGapShift;
4530 (InterFrameGap << TxInterFrameGapShift)); 4540
4541 if (tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
4542 tp->mac_version != RTL_GIGA_MAC_VER_39)
4543 val |= TXCFG_AUTO_FIFO;
4544
4545 RTL_W32(tp, TxConfig, val);
4531} 4546}
4532 4547
4533static void rtl_set_rx_max_size(struct rtl8169_private *tp) 4548static void rtl_set_rx_max_size(struct rtl8169_private *tp)
@@ -4634,13 +4649,13 @@ static void rtl_hw_start(struct rtl8169_private *tp)
4634 4649
4635 rtl_set_rx_max_size(tp); 4650 rtl_set_rx_max_size(tp);
4636 rtl_set_rx_tx_desc_registers(tp); 4651 rtl_set_rx_tx_desc_registers(tp);
4637 rtl_set_tx_config_registers(tp);
4638 RTL_W8(tp, Cfg9346, Cfg9346_Lock); 4652 RTL_W8(tp, Cfg9346, Cfg9346_Lock);
4639 4653
4640 /* Initially a 10 us delay. Turned it into a PCI commit. - FR */ 4654 /* Initially a 10 us delay. Turned it into a PCI commit. - FR */
4641 RTL_R8(tp, IntrMask); 4655 RTL_R8(tp, IntrMask);
4642 RTL_W8(tp, ChipCmd, CmdTxEnb | CmdRxEnb); 4656 RTL_W8(tp, ChipCmd, CmdTxEnb | CmdRxEnb);
4643 rtl_init_rxcfg(tp); 4657 rtl_init_rxcfg(tp);
4658 rtl_set_tx_config_registers(tp);
4644 4659
4645 rtl_set_rx_mode(tp->dev); 4660 rtl_set_rx_mode(tp->dev);
4646 /* no early-rx interrupts */ 4661 /* no early-rx interrupts */
@@ -4775,12 +4790,14 @@ static void rtl_pcie_state_l2l3_enable(struct rtl8169_private *tp, bool enable)
4775static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable) 4790static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable)
4776{ 4791{
4777 if (enable) { 4792 if (enable) {
4778 RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn);
4779 RTL_W8(tp, Config5, RTL_R8(tp, Config5) | ASPM_en); 4793 RTL_W8(tp, Config5, RTL_R8(tp, Config5) | ASPM_en);
4794 RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn);
4780 } else { 4795 } else {
4781 RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~ClkReqEn); 4796 RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~ClkReqEn);
4782 RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~ASPM_en); 4797 RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~ASPM_en);
4783 } 4798 }
4799
4800 udelay(10);
4784} 4801}
4785 4802
4786static void rtl_hw_start_8168bb(struct rtl8169_private *tp) 4803static void rtl_hw_start_8168bb(struct rtl8169_private *tp)
@@ -5020,7 +5037,6 @@ static void rtl_hw_start_8168e_2(struct rtl8169_private *tp)
5020 5037
5021 rtl_disable_clock_request(tp); 5038 rtl_disable_clock_request(tp);
5022 5039
5023 RTL_W32(tp, TxConfig, RTL_R32(tp, TxConfig) | TXCFG_AUTO_FIFO);
5024 RTL_W8(tp, MCU, RTL_R8(tp, MCU) & ~NOW_IS_OOB); 5040 RTL_W8(tp, MCU, RTL_R8(tp, MCU) & ~NOW_IS_OOB);
5025 5041
5026 /* Adjust EEE LED frequency */ 5042 /* Adjust EEE LED frequency */
@@ -5054,7 +5070,6 @@ static void rtl_hw_start_8168f(struct rtl8169_private *tp)
5054 5070
5055 rtl_disable_clock_request(tp); 5071 rtl_disable_clock_request(tp);
5056 5072
5057 RTL_W32(tp, TxConfig, RTL_R32(tp, TxConfig) | TXCFG_AUTO_FIFO);
5058 RTL_W8(tp, MCU, RTL_R8(tp, MCU) & ~NOW_IS_OOB); 5073 RTL_W8(tp, MCU, RTL_R8(tp, MCU) & ~NOW_IS_OOB);
5059 RTL_W8(tp, DLLPR, RTL_R8(tp, DLLPR) | PFM_EN); 5074 RTL_W8(tp, DLLPR, RTL_R8(tp, DLLPR) | PFM_EN);
5060 RTL_W32(tp, MISC, RTL_R32(tp, MISC) | PWM_EN); 5075 RTL_W32(tp, MISC, RTL_R32(tp, MISC) | PWM_EN);
@@ -5099,8 +5114,6 @@ static void rtl_hw_start_8411(struct rtl8169_private *tp)
5099 5114
5100static void rtl_hw_start_8168g(struct rtl8169_private *tp) 5115static void rtl_hw_start_8168g(struct rtl8169_private *tp)
5101{ 5116{
5102 RTL_W32(tp, TxConfig, RTL_R32(tp, TxConfig) | TXCFG_AUTO_FIFO);
5103
5104 rtl_eri_write(tp, 0xc8, ERIAR_MASK_0101, 0x080002, ERIAR_EXGMAC); 5117 rtl_eri_write(tp, 0xc8, ERIAR_MASK_0101, 0x080002, ERIAR_EXGMAC);
5105 rtl_eri_write(tp, 0xcc, ERIAR_MASK_0001, 0x38, ERIAR_EXGMAC); 5118 rtl_eri_write(tp, 0xcc, ERIAR_MASK_0001, 0x38, ERIAR_EXGMAC);
5106 rtl_eri_write(tp, 0xd0, ERIAR_MASK_0001, 0x48, ERIAR_EXGMAC); 5119 rtl_eri_write(tp, 0xd0, ERIAR_MASK_0001, 0x48, ERIAR_EXGMAC);
@@ -5198,8 +5211,6 @@ static void rtl_hw_start_8168h_1(struct rtl8169_private *tp)
5198 rtl_hw_aspm_clkreq_enable(tp, false); 5211 rtl_hw_aspm_clkreq_enable(tp, false);
5199 rtl_ephy_init(tp, e_info_8168h_1, ARRAY_SIZE(e_info_8168h_1)); 5212 rtl_ephy_init(tp, e_info_8168h_1, ARRAY_SIZE(e_info_8168h_1));
5200 5213
5201 RTL_W32(tp, TxConfig, RTL_R32(tp, TxConfig) | TXCFG_AUTO_FIFO);
5202
5203 rtl_eri_write(tp, 0xc8, ERIAR_MASK_0101, 0x00080002, ERIAR_EXGMAC); 5214 rtl_eri_write(tp, 0xc8, ERIAR_MASK_0101, 0x00080002, ERIAR_EXGMAC);
5204 rtl_eri_write(tp, 0xcc, ERIAR_MASK_0001, 0x38, ERIAR_EXGMAC); 5215 rtl_eri_write(tp, 0xcc, ERIAR_MASK_0001, 0x38, ERIAR_EXGMAC);
5205 rtl_eri_write(tp, 0xd0, ERIAR_MASK_0001, 0x48, ERIAR_EXGMAC); 5216 rtl_eri_write(tp, 0xd0, ERIAR_MASK_0001, 0x48, ERIAR_EXGMAC);
@@ -5282,8 +5293,6 @@ static void rtl_hw_start_8168ep(struct rtl8169_private *tp)
5282{ 5293{
5283 rtl8168ep_stop_cmac(tp); 5294 rtl8168ep_stop_cmac(tp);
5284 5295
5285 RTL_W32(tp, TxConfig, RTL_R32(tp, TxConfig) | TXCFG_AUTO_FIFO);
5286
5287 rtl_eri_write(tp, 0xc8, ERIAR_MASK_0101, 0x00080002, ERIAR_EXGMAC); 5296 rtl_eri_write(tp, 0xc8, ERIAR_MASK_0101, 0x00080002, ERIAR_EXGMAC);
5288 rtl_eri_write(tp, 0xcc, ERIAR_MASK_0001, 0x2f, ERIAR_EXGMAC); 5297 rtl_eri_write(tp, 0xcc, ERIAR_MASK_0001, 0x2f, ERIAR_EXGMAC);
5289 rtl_eri_write(tp, 0xd0, ERIAR_MASK_0001, 0x5f, ERIAR_EXGMAC); 5298 rtl_eri_write(tp, 0xd0, ERIAR_MASK_0001, 0x5f, ERIAR_EXGMAC);
@@ -5605,7 +5614,6 @@ static void rtl_hw_start_8402(struct rtl8169_private *tp)
5605 /* Force LAN exit from ASPM if Rx/Tx are not idle */ 5614 /* Force LAN exit from ASPM if Rx/Tx are not idle */
5606 RTL_W32(tp, FuncEvent, RTL_R32(tp, FuncEvent) | 0x002800); 5615 RTL_W32(tp, FuncEvent, RTL_R32(tp, FuncEvent) | 0x002800);
5607 5616
5608 RTL_W32(tp, TxConfig, RTL_R32(tp, TxConfig) | TXCFG_AUTO_FIFO);
5609 RTL_W8(tp, MCU, RTL_R8(tp, MCU) & ~NOW_IS_OOB); 5617 RTL_W8(tp, MCU, RTL_R8(tp, MCU) & ~NOW_IS_OOB);
5610 5618
5611 rtl_ephy_init(tp, e_info_8402, ARRAY_SIZE(e_info_8402)); 5619 rtl_ephy_init(tp, e_info_8402, ARRAY_SIZE(e_info_8402));
@@ -5625,6 +5633,8 @@ static void rtl_hw_start_8402(struct rtl8169_private *tp)
5625 5633
5626static void rtl_hw_start_8106(struct rtl8169_private *tp) 5634static void rtl_hw_start_8106(struct rtl8169_private *tp)
5627{ 5635{
5636 rtl_hw_aspm_clkreq_enable(tp, false);
5637
5628 /* Force LAN exit from ASPM if Rx/Tx are not idle */ 5638 /* Force LAN exit from ASPM if Rx/Tx are not idle */
5629 RTL_W32(tp, FuncEvent, RTL_R32(tp, FuncEvent) | 0x002800); 5639 RTL_W32(tp, FuncEvent, RTL_R32(tp, FuncEvent) | 0x002800);
5630 5640
@@ -5633,6 +5643,7 @@ static void rtl_hw_start_8106(struct rtl8169_private *tp)
5633 RTL_W8(tp, DLLPR, RTL_R8(tp, DLLPR) & ~PFM_EN); 5643 RTL_W8(tp, DLLPR, RTL_R8(tp, DLLPR) & ~PFM_EN);
5634 5644
5635 rtl_pcie_state_l2l3_enable(tp, false); 5645 rtl_pcie_state_l2l3_enable(tp, false);
5646 rtl_hw_aspm_clkreq_enable(tp, true);
5636} 5647}
5637 5648
5638static void rtl_hw_start_8101(struct rtl8169_private *tp) 5649static void rtl_hw_start_8101(struct rtl8169_private *tp)
@@ -6655,7 +6666,8 @@ static int rtl8169_close(struct net_device *dev)
6655 rtl8169_update_counters(tp); 6666 rtl8169_update_counters(tp);
6656 6667
6657 rtl_lock_work(tp); 6668 rtl_lock_work(tp);
6658 clear_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags); 6669 /* Clear all task flags */
6670 bitmap_zero(tp->wk.flags, RTL_FLAG_MAX);
6659 6671
6660 rtl8169_down(dev); 6672 rtl8169_down(dev);
6661 rtl_unlock_work(tp); 6673 rtl_unlock_work(tp);
@@ -6838,7 +6850,9 @@ static void rtl8169_net_suspend(struct net_device *dev)
6838 6850
6839 rtl_lock_work(tp); 6851 rtl_lock_work(tp);
6840 napi_disable(&tp->napi); 6852 napi_disable(&tp->napi);
6841 clear_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags); 6853 /* Clear all task flags */
6854 bitmap_zero(tp->wk.flags, RTL_FLAG_MAX);
6855
6842 rtl_unlock_work(tp); 6856 rtl_unlock_work(tp);
6843 6857
6844 rtl_pll_power_down(tp); 6858 rtl_pll_power_down(tp);
@@ -6850,8 +6864,10 @@ static int rtl8169_suspend(struct device *device)
6850{ 6864{
6851 struct pci_dev *pdev = to_pci_dev(device); 6865 struct pci_dev *pdev = to_pci_dev(device);
6852 struct net_device *dev = pci_get_drvdata(pdev); 6866 struct net_device *dev = pci_get_drvdata(pdev);
6867 struct rtl8169_private *tp = netdev_priv(dev);
6853 6868
6854 rtl8169_net_suspend(dev); 6869 rtl8169_net_suspend(dev);
6870 clk_disable_unprepare(tp->clk);
6855 6871
6856 return 0; 6872 return 0;
6857} 6873}
@@ -6879,6 +6895,9 @@ static int rtl8169_resume(struct device *device)
6879{ 6895{
6880 struct pci_dev *pdev = to_pci_dev(device); 6896 struct pci_dev *pdev = to_pci_dev(device);
6881 struct net_device *dev = pci_get_drvdata(pdev); 6897 struct net_device *dev = pci_get_drvdata(pdev);
6898 struct rtl8169_private *tp = netdev_priv(dev);
6899
6900 clk_prepare_enable(tp->clk);
6882 6901
6883 if (netif_running(dev)) 6902 if (netif_running(dev))
6884 __rtl8169_resume(dev); 6903 __rtl8169_resume(dev);
@@ -7254,6 +7273,11 @@ static int rtl_jumbo_max(struct rtl8169_private *tp)
7254 } 7273 }
7255} 7274}
7256 7275
7276static void rtl_disable_clk(void *data)
7277{
7278 clk_disable_unprepare(data);
7279}
7280
7257static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 7281static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
7258{ 7282{
7259 const struct rtl_cfg_info *cfg = rtl_cfg_infos + ent->driver_data; 7283 const struct rtl_cfg_info *cfg = rtl_cfg_infos + ent->driver_data;
@@ -7274,6 +7298,32 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
7274 tp->msg_enable = netif_msg_init(debug.msg_enable, R8169_MSG_DEFAULT); 7298 tp->msg_enable = netif_msg_init(debug.msg_enable, R8169_MSG_DEFAULT);
7275 tp->supports_gmii = cfg->has_gmii; 7299 tp->supports_gmii = cfg->has_gmii;
7276 7300
7301 /* Get the *optional* external "ether_clk" used on some boards */
7302 tp->clk = devm_clk_get(&pdev->dev, "ether_clk");
7303 if (IS_ERR(tp->clk)) {
7304 rc = PTR_ERR(tp->clk);
7305 if (rc == -ENOENT) {
7306 /* clk-core allows NULL (for suspend / resume) */
7307 tp->clk = NULL;
7308 } else if (rc == -EPROBE_DEFER) {
7309 return rc;
7310 } else {
7311 dev_err(&pdev->dev, "failed to get clk: %d\n", rc);
7312 return rc;
7313 }
7314 } else {
7315 rc = clk_prepare_enable(tp->clk);
7316 if (rc) {
7317 dev_err(&pdev->dev, "failed to enable clk: %d\n", rc);
7318 return rc;
7319 }
7320
7321 rc = devm_add_action_or_reset(&pdev->dev, rtl_disable_clk,
7322 tp->clk);
7323 if (rc)
7324 return rc;
7325 }
7326
7277 /* enable device (incl. PCI PM wakeup and hotplug setup) */ 7327 /* enable device (incl. PCI PM wakeup and hotplug setup) */
7278 rc = pcim_enable_device(pdev); 7328 rc = pcim_enable_device(pdev);
7279 if (rc < 0) { 7329 if (rc < 0) {
diff --git a/drivers/net/ethernet/renesas/Kconfig b/drivers/net/ethernet/renesas/Kconfig
index f3f7477043ce..bb0ebdfd4459 100644
--- a/drivers/net/ethernet/renesas/Kconfig
+++ b/drivers/net/ethernet/renesas/Kconfig
@@ -1,3 +1,4 @@
1# SPDX-License-Identifier: GPL-2.0
1# 2#
2# Renesas device configuration 3# Renesas device configuration
3# 4#
diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
index a05102a7df02..f21ab8c02af0 100644
--- a/drivers/net/ethernet/renesas/Makefile
+++ b/drivers/net/ethernet/renesas/Makefile
@@ -1,3 +1,4 @@
1# SPDX-License-Identifier: GPL-2.0
1# 2#
2# Makefile for the Renesas device drivers. 3# Makefile for the Renesas device drivers.
3# 4#
diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index 1470fc12282b..9b6bf557a2f5 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -428,6 +428,7 @@ enum EIS_BIT {
428 EIS_CULF1 = 0x00000080, 428 EIS_CULF1 = 0x00000080,
429 EIS_TFFF = 0x00000100, 429 EIS_TFFF = 0x00000100,
430 EIS_QFS = 0x00010000, 430 EIS_QFS = 0x00010000,
431 EIS_RESERVED = (GENMASK(31, 17) | GENMASK(15, 11)),
431}; 432};
432 433
433/* RIC0 */ 434/* RIC0 */
@@ -472,6 +473,7 @@ enum RIS0_BIT {
472 RIS0_FRF15 = 0x00008000, 473 RIS0_FRF15 = 0x00008000,
473 RIS0_FRF16 = 0x00010000, 474 RIS0_FRF16 = 0x00010000,
474 RIS0_FRF17 = 0x00020000, 475 RIS0_FRF17 = 0x00020000,
476 RIS0_RESERVED = GENMASK(31, 18),
475}; 477};
476 478
477/* RIC1 */ 479/* RIC1 */
@@ -528,6 +530,7 @@ enum RIS2_BIT {
528 RIS2_QFF16 = 0x00010000, 530 RIS2_QFF16 = 0x00010000,
529 RIS2_QFF17 = 0x00020000, 531 RIS2_QFF17 = 0x00020000,
530 RIS2_RFFF = 0x80000000, 532 RIS2_RFFF = 0x80000000,
533 RIS2_RESERVED = GENMASK(30, 18),
531}; 534};
532 535
533/* TIC */ 536/* TIC */
@@ -544,6 +547,7 @@ enum TIS_BIT {
544 TIS_FTF1 = 0x00000002, /* Undocumented? */ 547 TIS_FTF1 = 0x00000002, /* Undocumented? */
545 TIS_TFUF = 0x00000100, 548 TIS_TFUF = 0x00000100,
546 TIS_TFWF = 0x00000200, 549 TIS_TFWF = 0x00000200,
550 TIS_RESERVED = (GENMASK(31, 20) | GENMASK(15, 12) | GENMASK(7, 4))
547}; 551};
548 552
549/* ISS */ 553/* ISS */
@@ -617,6 +621,7 @@ enum GIC_BIT {
617enum GIS_BIT { 621enum GIS_BIT {
618 GIS_PTCF = 0x00000001, /* Undocumented? */ 622 GIS_PTCF = 0x00000001, /* Undocumented? */
619 GIS_PTMF = 0x00000004, 623 GIS_PTMF = 0x00000004,
624 GIS_RESERVED = GENMASK(15, 10),
620}; 625};
621 626
622/* GIE (R-Car Gen3 only) */ 627/* GIE (R-Car Gen3 only) */
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index aff5516b781e..d6f753925352 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -739,10 +739,11 @@ static void ravb_error_interrupt(struct net_device *ndev)
739 u32 eis, ris2; 739 u32 eis, ris2;
740 740
741 eis = ravb_read(ndev, EIS); 741 eis = ravb_read(ndev, EIS);
742 ravb_write(ndev, ~EIS_QFS, EIS); 742 ravb_write(ndev, ~(EIS_QFS | EIS_RESERVED), EIS);
743 if (eis & EIS_QFS) { 743 if (eis & EIS_QFS) {
744 ris2 = ravb_read(ndev, RIS2); 744 ris2 = ravb_read(ndev, RIS2);
745 ravb_write(ndev, ~(RIS2_QFF0 | RIS2_RFFF), RIS2); 745 ravb_write(ndev, ~(RIS2_QFF0 | RIS2_RFFF | RIS2_RESERVED),
746 RIS2);
746 747
747 /* Receive Descriptor Empty int */ 748 /* Receive Descriptor Empty int */
748 if (ris2 & RIS2_QFF0) 749 if (ris2 & RIS2_QFF0)
@@ -795,7 +796,7 @@ static bool ravb_timestamp_interrupt(struct net_device *ndev)
795 u32 tis = ravb_read(ndev, TIS); 796 u32 tis = ravb_read(ndev, TIS);
796 797
797 if (tis & TIS_TFUF) { 798 if (tis & TIS_TFUF) {
798 ravb_write(ndev, ~TIS_TFUF, TIS); 799 ravb_write(ndev, ~(TIS_TFUF | TIS_RESERVED), TIS);
799 ravb_get_tx_tstamp(ndev); 800 ravb_get_tx_tstamp(ndev);
800 return true; 801 return true;
801 } 802 }
@@ -930,7 +931,7 @@ static int ravb_poll(struct napi_struct *napi, int budget)
930 /* Processing RX Descriptor Ring */ 931 /* Processing RX Descriptor Ring */
931 if (ris0 & mask) { 932 if (ris0 & mask) {
932 /* Clear RX interrupt */ 933 /* Clear RX interrupt */
933 ravb_write(ndev, ~mask, RIS0); 934 ravb_write(ndev, ~(mask | RIS0_RESERVED), RIS0);
934 if (ravb_rx(ndev, &quota, q)) 935 if (ravb_rx(ndev, &quota, q))
935 goto out; 936 goto out;
936 } 937 }
@@ -938,7 +939,7 @@ static int ravb_poll(struct napi_struct *napi, int budget)
938 if (tis & mask) { 939 if (tis & mask) {
939 spin_lock_irqsave(&priv->lock, flags); 940 spin_lock_irqsave(&priv->lock, flags);
940 /* Clear TX interrupt */ 941 /* Clear TX interrupt */
941 ravb_write(ndev, ~mask, TIS); 942 ravb_write(ndev, ~(mask | TIS_RESERVED), TIS);
942 ravb_tx_free(ndev, q, true); 943 ravb_tx_free(ndev, q, true);
943 netif_wake_subqueue(ndev, q); 944 netif_wake_subqueue(ndev, q);
944 mmiowb(); 945 mmiowb();
diff --git a/drivers/net/ethernet/renesas/ravb_ptp.c b/drivers/net/ethernet/renesas/ravb_ptp.c
index eede70ec37f8..dce2a40a31e3 100644
--- a/drivers/net/ethernet/renesas/ravb_ptp.c
+++ b/drivers/net/ethernet/renesas/ravb_ptp.c
@@ -1,13 +1,9 @@
1// SPDX-License-Identifier: GPL-2.0+
1/* PTP 1588 clock using the Renesas Ethernet AVB 2/* PTP 1588 clock using the Renesas Ethernet AVB
2 * 3 *
3 * Copyright (C) 2013-2015 Renesas Electronics Corporation 4 * Copyright (C) 2013-2015 Renesas Electronics Corporation
4 * Copyright (C) 2015 Renesas Solutions Corp. 5 * Copyright (C) 2015 Renesas Solutions Corp.
5 * Copyright (C) 2015-2016 Cogent Embedded, Inc. <source@cogentembedded.com> 6 * Copyright (C) 2015-2016 Cogent Embedded, Inc. <source@cogentembedded.com>
6 *
7 * This program is free software; you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation; either version 2 of the License, or
10 * (at your option) any later version.
11 */ 7 */
12 8
13#include "ravb.h" 9#include "ravb.h"
@@ -319,7 +315,7 @@ void ravb_ptp_interrupt(struct net_device *ndev)
319 } 315 }
320 } 316 }
321 317
322 ravb_write(ndev, ~gis, GIS); 318 ravb_write(ndev, ~(gis | GIS_RESERVED), GIS);
323} 319}
324 320
325void ravb_ptp_init(struct net_device *ndev, struct platform_device *pdev) 321void ravb_ptp_init(struct net_device *ndev, struct platform_device *pdev)
diff --git a/drivers/net/ethernet/seeq/ether3.c b/drivers/net/ethernet/seeq/ether3.c
index c5bc124b41a9..d1bb73bf9914 100644
--- a/drivers/net/ethernet/seeq/ether3.c
+++ b/drivers/net/ethernet/seeq/ether3.c
@@ -77,7 +77,8 @@ static void ether3_setmulticastlist(struct net_device *dev);
77static int ether3_rx(struct net_device *dev, unsigned int maxcnt); 77static int ether3_rx(struct net_device *dev, unsigned int maxcnt);
78static void ether3_tx(struct net_device *dev); 78static void ether3_tx(struct net_device *dev);
79static int ether3_open (struct net_device *dev); 79static int ether3_open (struct net_device *dev);
80static int ether3_sendpacket (struct sk_buff *skb, struct net_device *dev); 80static netdev_tx_t ether3_sendpacket(struct sk_buff *skb,
81 struct net_device *dev);
81static irqreturn_t ether3_interrupt (int irq, void *dev_id); 82static irqreturn_t ether3_interrupt (int irq, void *dev_id);
82static int ether3_close (struct net_device *dev); 83static int ether3_close (struct net_device *dev);
83static void ether3_setmulticastlist (struct net_device *dev); 84static void ether3_setmulticastlist (struct net_device *dev);
@@ -481,7 +482,7 @@ static void ether3_timeout(struct net_device *dev)
481/* 482/*
482 * Transmit a packet 483 * Transmit a packet
483 */ 484 */
484static int 485static netdev_tx_t
485ether3_sendpacket(struct sk_buff *skb, struct net_device *dev) 486ether3_sendpacket(struct sk_buff *skb, struct net_device *dev)
486{ 487{
487 unsigned long flags; 488 unsigned long flags;
diff --git a/drivers/net/ethernet/seeq/sgiseeq.c b/drivers/net/ethernet/seeq/sgiseeq.c
index 573691bc3b71..70cce63a6081 100644
--- a/drivers/net/ethernet/seeq/sgiseeq.c
+++ b/drivers/net/ethernet/seeq/sgiseeq.c
@@ -578,7 +578,8 @@ static inline int sgiseeq_reset(struct net_device *dev)
578 return 0; 578 return 0;
579} 579}
580 580
581static int sgiseeq_start_xmit(struct sk_buff *skb, struct net_device *dev) 581static netdev_tx_t
582sgiseeq_start_xmit(struct sk_buff *skb, struct net_device *dev)
582{ 583{
583 struct sgiseeq_private *sp = netdev_priv(dev); 584 struct sgiseeq_private *sp = netdev_priv(dev);
584 struct hpc3_ethregs *hregs = sp->hregs; 585 struct hpc3_ethregs *hregs = sp->hregs;
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 330233286e78..3d0dd39c289e 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2208,29 +2208,6 @@ static void efx_fini_napi(struct efx_nic *efx)
2208 2208
2209/************************************************************************** 2209/**************************************************************************
2210 * 2210 *
2211 * Kernel netpoll interface
2212 *
2213 *************************************************************************/
2214
2215#ifdef CONFIG_NET_POLL_CONTROLLER
2216
2217/* Although in the common case interrupts will be disabled, this is not
2218 * guaranteed. However, all our work happens inside the NAPI callback,
2219 * so no locking is required.
2220 */
2221static void efx_netpoll(struct net_device *net_dev)
2222{
2223 struct efx_nic *efx = netdev_priv(net_dev);
2224 struct efx_channel *channel;
2225
2226 efx_for_each_channel(channel, efx)
2227 efx_schedule_channel(channel);
2228}
2229
2230#endif
2231
2232/**************************************************************************
2233 *
2234 * Kernel net device interface 2211 * Kernel net device interface
2235 * 2212 *
2236 *************************************************************************/ 2213 *************************************************************************/
@@ -2509,9 +2486,6 @@ static const struct net_device_ops efx_netdev_ops = {
2509#endif 2486#endif
2510 .ndo_get_phys_port_id = efx_get_phys_port_id, 2487 .ndo_get_phys_port_id = efx_get_phys_port_id,
2511 .ndo_get_phys_port_name = efx_get_phys_port_name, 2488 .ndo_get_phys_port_name = efx_get_phys_port_name,
2512#ifdef CONFIG_NET_POLL_CONTROLLER
2513 .ndo_poll_controller = efx_netpoll,
2514#endif
2515 .ndo_setup_tc = efx_setup_tc, 2489 .ndo_setup_tc = efx_setup_tc,
2516#ifdef CONFIG_RFS_ACCEL 2490#ifdef CONFIG_RFS_ACCEL
2517 .ndo_rx_flow_steer = efx_filter_rfs, 2491 .ndo_rx_flow_steer = efx_filter_rfs,
diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c
index dd5530a4f8c8..03e2455c502e 100644
--- a/drivers/net/ethernet/sfc/falcon/efx.c
+++ b/drivers/net/ethernet/sfc/falcon/efx.c
@@ -2054,29 +2054,6 @@ static void ef4_fini_napi(struct ef4_nic *efx)
2054 2054
2055/************************************************************************** 2055/**************************************************************************
2056 * 2056 *
2057 * Kernel netpoll interface
2058 *
2059 *************************************************************************/
2060
2061#ifdef CONFIG_NET_POLL_CONTROLLER
2062
2063/* Although in the common case interrupts will be disabled, this is not
2064 * guaranteed. However, all our work happens inside the NAPI callback,
2065 * so no locking is required.
2066 */
2067static void ef4_netpoll(struct net_device *net_dev)
2068{
2069 struct ef4_nic *efx = netdev_priv(net_dev);
2070 struct ef4_channel *channel;
2071
2072 ef4_for_each_channel(channel, efx)
2073 ef4_schedule_channel(channel);
2074}
2075
2076#endif
2077
2078/**************************************************************************
2079 *
2080 * Kernel net device interface 2057 * Kernel net device interface
2081 * 2058 *
2082 *************************************************************************/ 2059 *************************************************************************/
@@ -2250,9 +2227,6 @@ static const struct net_device_ops ef4_netdev_ops = {
2250 .ndo_set_mac_address = ef4_set_mac_address, 2227 .ndo_set_mac_address = ef4_set_mac_address,
2251 .ndo_set_rx_mode = ef4_set_rx_mode, 2228 .ndo_set_rx_mode = ef4_set_rx_mode,
2252 .ndo_set_features = ef4_set_features, 2229 .ndo_set_features = ef4_set_features,
2253#ifdef CONFIG_NET_POLL_CONTROLLER
2254 .ndo_poll_controller = ef4_netpoll,
2255#endif
2256 .ndo_setup_tc = ef4_setup_tc, 2230 .ndo_setup_tc = ef4_setup_tc,
2257#ifdef CONFIG_RFS_ACCEL 2231#ifdef CONFIG_RFS_ACCEL
2258 .ndo_rx_flow_steer = ef4_filter_rfs, 2232 .ndo_rx_flow_steer = ef4_filter_rfs,
diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c
index 18d533fdf14c..3140999642ba 100644
--- a/drivers/net/ethernet/sgi/ioc3-eth.c
+++ b/drivers/net/ethernet/sgi/ioc3-eth.c
@@ -99,7 +99,7 @@ struct ioc3_private {
99 99
100static int ioc3_ioctl(struct net_device *dev, struct ifreq *rq, int cmd); 100static int ioc3_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
101static void ioc3_set_multicast_list(struct net_device *dev); 101static void ioc3_set_multicast_list(struct net_device *dev);
102static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev); 102static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev);
103static void ioc3_timeout(struct net_device *dev); 103static void ioc3_timeout(struct net_device *dev);
104static inline unsigned int ioc3_hash(const unsigned char *addr); 104static inline unsigned int ioc3_hash(const unsigned char *addr);
105static inline void ioc3_stop(struct ioc3_private *ip); 105static inline void ioc3_stop(struct ioc3_private *ip);
@@ -1390,7 +1390,7 @@ static struct pci_driver ioc3_driver = {
1390 .remove = ioc3_remove_one, 1390 .remove = ioc3_remove_one,
1391}; 1391};
1392 1392
1393static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev) 1393static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev)
1394{ 1394{
1395 unsigned long data; 1395 unsigned long data;
1396 struct ioc3_private *ip = netdev_priv(dev); 1396 struct ioc3_private *ip = netdev_priv(dev);
diff --git a/drivers/net/ethernet/sgi/meth.c b/drivers/net/ethernet/sgi/meth.c
index ea55abd62ec7..703fbbefea44 100644
--- a/drivers/net/ethernet/sgi/meth.c
+++ b/drivers/net/ethernet/sgi/meth.c
@@ -697,7 +697,7 @@ static void meth_add_to_tx_ring(struct meth_private *priv, struct sk_buff *skb)
697/* 697/*
698 * Transmit a packet (called by the kernel) 698 * Transmit a packet (called by the kernel)
699 */ 699 */
700static int meth_tx(struct sk_buff *skb, struct net_device *dev) 700static netdev_tx_t meth_tx(struct sk_buff *skb, struct net_device *dev)
701{ 701{
702 struct meth_private *priv = netdev_priv(dev); 702 struct meth_private *priv = netdev_priv(dev);
703 unsigned long flags; 703 unsigned long flags;
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index 7aa5ebb6766c..4289ccb26e4e 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -735,8 +735,11 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
735 u16 idx = dring->tail; 735 u16 idx = dring->tail;
736 struct netsec_de *de = dring->vaddr + (DESC_SZ * idx); 736 struct netsec_de *de = dring->vaddr + (DESC_SZ * idx);
737 737
738 if (de->attr & (1U << NETSEC_RX_PKT_OWN_FIELD)) 738 if (de->attr & (1U << NETSEC_RX_PKT_OWN_FIELD)) {
739 /* reading the register clears the irq */
740 netsec_read(priv, NETSEC_REG_NRM_RX_PKTCNT);
739 break; 741 break;
742 }
740 743
741 /* This barrier is needed to keep us from reading 744 /* This barrier is needed to keep us from reading
742 * any other fields out of the netsec_de until we have 745 * any other fields out of the netsec_de until we have
diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
index 1854f270ad66..b1b305f8f414 100644
--- a/drivers/net/ethernet/stmicro/stmmac/common.h
+++ b/drivers/net/ethernet/stmicro/stmmac/common.h
@@ -258,10 +258,10 @@ struct stmmac_safety_stats {
258#define MAX_DMA_RIWT 0xff 258#define MAX_DMA_RIWT 0xff
259#define MIN_DMA_RIWT 0x20 259#define MIN_DMA_RIWT 0x20
260/* Tx coalesce parameters */ 260/* Tx coalesce parameters */
261#define STMMAC_COAL_TX_TIMER 40000 261#define STMMAC_COAL_TX_TIMER 1000
262#define STMMAC_MAX_COAL_TX_TICK 100000 262#define STMMAC_MAX_COAL_TX_TICK 100000
263#define STMMAC_TX_MAX_FRAMES 256 263#define STMMAC_TX_MAX_FRAMES 256
264#define STMMAC_TX_FRAMES 64 264#define STMMAC_TX_FRAMES 25
265 265
266/* Packets types */ 266/* Packets types */
267enum packets_types { 267enum packets_types {
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
index c0a855b7ab3b..63e1064b27a2 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
@@ -48,6 +48,8 @@ struct stmmac_tx_info {
48 48
49/* Frequently used values are kept adjacent for cache effect */ 49/* Frequently used values are kept adjacent for cache effect */
50struct stmmac_tx_queue { 50struct stmmac_tx_queue {
51 u32 tx_count_frames;
52 struct timer_list txtimer;
51 u32 queue_index; 53 u32 queue_index;
52 struct stmmac_priv *priv_data; 54 struct stmmac_priv *priv_data;
53 struct dma_extended_desc *dma_etx ____cacheline_aligned_in_smp; 55 struct dma_extended_desc *dma_etx ____cacheline_aligned_in_smp;
@@ -73,7 +75,14 @@ struct stmmac_rx_queue {
73 u32 rx_zeroc_thresh; 75 u32 rx_zeroc_thresh;
74 dma_addr_t dma_rx_phy; 76 dma_addr_t dma_rx_phy;
75 u32 rx_tail_addr; 77 u32 rx_tail_addr;
78};
79
80struct stmmac_channel {
76 struct napi_struct napi ____cacheline_aligned_in_smp; 81 struct napi_struct napi ____cacheline_aligned_in_smp;
82 struct stmmac_priv *priv_data;
83 u32 index;
84 int has_rx;
85 int has_tx;
77}; 86};
78 87
79struct stmmac_tc_entry { 88struct stmmac_tc_entry {
@@ -109,14 +118,12 @@ struct stmmac_pps_cfg {
109 118
110struct stmmac_priv { 119struct stmmac_priv {
111 /* Frequently used values are kept adjacent for cache effect */ 120 /* Frequently used values are kept adjacent for cache effect */
112 u32 tx_count_frames;
113 u32 tx_coal_frames; 121 u32 tx_coal_frames;
114 u32 tx_coal_timer; 122 u32 tx_coal_timer;
115 123
116 int tx_coalesce; 124 int tx_coalesce;
117 int hwts_tx_en; 125 int hwts_tx_en;
118 bool tx_path_in_lpi_mode; 126 bool tx_path_in_lpi_mode;
119 struct timer_list txtimer;
120 bool tso; 127 bool tso;
121 128
122 unsigned int dma_buf_sz; 129 unsigned int dma_buf_sz;
@@ -137,6 +144,9 @@ struct stmmac_priv {
137 /* TX Queue */ 144 /* TX Queue */
138 struct stmmac_tx_queue tx_queue[MTL_MAX_TX_QUEUES]; 145 struct stmmac_tx_queue tx_queue[MTL_MAX_TX_QUEUES];
139 146
147 /* Generic channel for NAPI */
148 struct stmmac_channel channel[STMMAC_CH_MAX];
149
140 bool oldlink; 150 bool oldlink;
141 int speed; 151 int speed;
142 int oldduplex; 152 int oldduplex;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 9f458bb16f2a..75896d6ba6e2 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -148,12 +148,14 @@ static void stmmac_verify_args(void)
148static void stmmac_disable_all_queues(struct stmmac_priv *priv) 148static void stmmac_disable_all_queues(struct stmmac_priv *priv)
149{ 149{
150 u32 rx_queues_cnt = priv->plat->rx_queues_to_use; 150 u32 rx_queues_cnt = priv->plat->rx_queues_to_use;
151 u32 tx_queues_cnt = priv->plat->tx_queues_to_use;
152 u32 maxq = max(rx_queues_cnt, tx_queues_cnt);
151 u32 queue; 153 u32 queue;
152 154
153 for (queue = 0; queue < rx_queues_cnt; queue++) { 155 for (queue = 0; queue < maxq; queue++) {
154 struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; 156 struct stmmac_channel *ch = &priv->channel[queue];
155 157
156 napi_disable(&rx_q->napi); 158 napi_disable(&ch->napi);
157 } 159 }
158} 160}
159 161
@@ -164,12 +166,14 @@ static void stmmac_disable_all_queues(struct stmmac_priv *priv)
164static void stmmac_enable_all_queues(struct stmmac_priv *priv) 166static void stmmac_enable_all_queues(struct stmmac_priv *priv)
165{ 167{
166 u32 rx_queues_cnt = priv->plat->rx_queues_to_use; 168 u32 rx_queues_cnt = priv->plat->rx_queues_to_use;
169 u32 tx_queues_cnt = priv->plat->tx_queues_to_use;
170 u32 maxq = max(rx_queues_cnt, tx_queues_cnt);
167 u32 queue; 171 u32 queue;
168 172
169 for (queue = 0; queue < rx_queues_cnt; queue++) { 173 for (queue = 0; queue < maxq; queue++) {
170 struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; 174 struct stmmac_channel *ch = &priv->channel[queue];
171 175
172 napi_enable(&rx_q->napi); 176 napi_enable(&ch->napi);
173 } 177 }
174} 178}
175 179
@@ -1843,18 +1847,18 @@ static void stmmac_dma_operation_mode(struct stmmac_priv *priv)
1843 * @queue: TX queue index 1847 * @queue: TX queue index
1844 * Description: it reclaims the transmit resources after transmission completes. 1848 * Description: it reclaims the transmit resources after transmission completes.
1845 */ 1849 */
1846static void stmmac_tx_clean(struct stmmac_priv *priv, u32 queue) 1850static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue)
1847{ 1851{
1848 struct stmmac_tx_queue *tx_q = &priv->tx_queue[queue]; 1852 struct stmmac_tx_queue *tx_q = &priv->tx_queue[queue];
1849 unsigned int bytes_compl = 0, pkts_compl = 0; 1853 unsigned int bytes_compl = 0, pkts_compl = 0;
1850 unsigned int entry; 1854 unsigned int entry, count = 0;
1851 1855
1852 netif_tx_lock(priv->dev); 1856 __netif_tx_lock_bh(netdev_get_tx_queue(priv->dev, queue));
1853 1857
1854 priv->xstats.tx_clean++; 1858 priv->xstats.tx_clean++;
1855 1859
1856 entry = tx_q->dirty_tx; 1860 entry = tx_q->dirty_tx;
1857 while (entry != tx_q->cur_tx) { 1861 while ((entry != tx_q->cur_tx) && (count < budget)) {
1858 struct sk_buff *skb = tx_q->tx_skbuff[entry]; 1862 struct sk_buff *skb = tx_q->tx_skbuff[entry];
1859 struct dma_desc *p; 1863 struct dma_desc *p;
1860 int status; 1864 int status;
@@ -1870,6 +1874,8 @@ static void stmmac_tx_clean(struct stmmac_priv *priv, u32 queue)
1870 if (unlikely(status & tx_dma_own)) 1874 if (unlikely(status & tx_dma_own))
1871 break; 1875 break;
1872 1876
1877 count++;
1878
1873 /* Make sure descriptor fields are read after reading 1879 /* Make sure descriptor fields are read after reading
1874 * the own bit. 1880 * the own bit.
1875 */ 1881 */
@@ -1937,7 +1943,10 @@ static void stmmac_tx_clean(struct stmmac_priv *priv, u32 queue)
1937 stmmac_enable_eee_mode(priv); 1943 stmmac_enable_eee_mode(priv);
1938 mod_timer(&priv->eee_ctrl_timer, STMMAC_LPI_T(eee_timer)); 1944 mod_timer(&priv->eee_ctrl_timer, STMMAC_LPI_T(eee_timer));
1939 } 1945 }
1940 netif_tx_unlock(priv->dev); 1946
1947 __netif_tx_unlock_bh(netdev_get_tx_queue(priv->dev, queue));
1948
1949 return count;
1941} 1950}
1942 1951
1943/** 1952/**
@@ -2020,6 +2029,33 @@ static bool stmmac_safety_feat_interrupt(struct stmmac_priv *priv)
2020 return false; 2029 return false;
2021} 2030}
2022 2031
2032static int stmmac_napi_check(struct stmmac_priv *priv, u32 chan)
2033{
2034 int status = stmmac_dma_interrupt_status(priv, priv->ioaddr,
2035 &priv->xstats, chan);
2036 struct stmmac_channel *ch = &priv->channel[chan];
2037 bool needs_work = false;
2038
2039 if ((status & handle_rx) && ch->has_rx) {
2040 needs_work = true;
2041 } else {
2042 status &= ~handle_rx;
2043 }
2044
2045 if ((status & handle_tx) && ch->has_tx) {
2046 needs_work = true;
2047 } else {
2048 status &= ~handle_tx;
2049 }
2050
2051 if (needs_work && napi_schedule_prep(&ch->napi)) {
2052 stmmac_disable_dma_irq(priv, priv->ioaddr, chan);
2053 __napi_schedule(&ch->napi);
2054 }
2055
2056 return status;
2057}
2058
2023/** 2059/**
2024 * stmmac_dma_interrupt - DMA ISR 2060 * stmmac_dma_interrupt - DMA ISR
2025 * @priv: driver private structure 2061 * @priv: driver private structure
@@ -2034,57 +2070,14 @@ static void stmmac_dma_interrupt(struct stmmac_priv *priv)
2034 u32 channels_to_check = tx_channel_count > rx_channel_count ? 2070 u32 channels_to_check = tx_channel_count > rx_channel_count ?
2035 tx_channel_count : rx_channel_count; 2071 tx_channel_count : rx_channel_count;
2036 u32 chan; 2072 u32 chan;
2037 bool poll_scheduled = false;
2038 int status[max_t(u32, MTL_MAX_TX_QUEUES, MTL_MAX_RX_QUEUES)]; 2073 int status[max_t(u32, MTL_MAX_TX_QUEUES, MTL_MAX_RX_QUEUES)];
2039 2074
2040 /* Make sure we never check beyond our status buffer. */ 2075 /* Make sure we never check beyond our status buffer. */
2041 if (WARN_ON_ONCE(channels_to_check > ARRAY_SIZE(status))) 2076 if (WARN_ON_ONCE(channels_to_check > ARRAY_SIZE(status)))
2042 channels_to_check = ARRAY_SIZE(status); 2077 channels_to_check = ARRAY_SIZE(status);
2043 2078
2044 /* Each DMA channel can be used for rx and tx simultaneously, yet
2045 * napi_struct is embedded in struct stmmac_rx_queue rather than in a
2046 * stmmac_channel struct.
2047 * Because of this, stmmac_poll currently checks (and possibly wakes)
2048 * all tx queues rather than just a single tx queue.
2049 */
2050 for (chan = 0; chan < channels_to_check; chan++) 2079 for (chan = 0; chan < channels_to_check; chan++)
2051 status[chan] = stmmac_dma_interrupt_status(priv, priv->ioaddr, 2080 status[chan] = stmmac_napi_check(priv, chan);
2052 &priv->xstats, chan);
2053
2054 for (chan = 0; chan < rx_channel_count; chan++) {
2055 if (likely(status[chan] & handle_rx)) {
2056 struct stmmac_rx_queue *rx_q = &priv->rx_queue[chan];
2057
2058 if (likely(napi_schedule_prep(&rx_q->napi))) {
2059 stmmac_disable_dma_irq(priv, priv->ioaddr, chan);
2060 __napi_schedule(&rx_q->napi);
2061 poll_scheduled = true;
2062 }
2063 }
2064 }
2065
2066 /* If we scheduled poll, we already know that tx queues will be checked.
2067 * If we didn't schedule poll, see if any DMA channel (used by tx) has a
2068 * completed transmission, if so, call stmmac_poll (once).
2069 */
2070 if (!poll_scheduled) {
2071 for (chan = 0; chan < tx_channel_count; chan++) {
2072 if (status[chan] & handle_tx) {
2073 /* It doesn't matter what rx queue we choose
2074 * here. We use 0 since it always exists.
2075 */
2076 struct stmmac_rx_queue *rx_q =
2077 &priv->rx_queue[0];
2078
2079 if (likely(napi_schedule_prep(&rx_q->napi))) {
2080 stmmac_disable_dma_irq(priv,
2081 priv->ioaddr, chan);
2082 __napi_schedule(&rx_q->napi);
2083 }
2084 break;
2085 }
2086 }
2087 }
2088 2081
2089 for (chan = 0; chan < tx_channel_count; chan++) { 2082 for (chan = 0; chan < tx_channel_count; chan++) {
2090 if (unlikely(status[chan] & tx_hard_error_bump_tc)) { 2083 if (unlikely(status[chan] & tx_hard_error_bump_tc)) {
@@ -2220,8 +2213,7 @@ static int stmmac_init_dma_engine(struct stmmac_priv *priv)
2220 stmmac_init_tx_chan(priv, priv->ioaddr, priv->plat->dma_cfg, 2213 stmmac_init_tx_chan(priv, priv->ioaddr, priv->plat->dma_cfg,
2221 tx_q->dma_tx_phy, chan); 2214 tx_q->dma_tx_phy, chan);
2222 2215
2223 tx_q->tx_tail_addr = tx_q->dma_tx_phy + 2216 tx_q->tx_tail_addr = tx_q->dma_tx_phy;
2224 (DMA_TX_SIZE * sizeof(struct dma_desc));
2225 stmmac_set_tx_tail_ptr(priv, priv->ioaddr, 2217 stmmac_set_tx_tail_ptr(priv, priv->ioaddr,
2226 tx_q->tx_tail_addr, chan); 2218 tx_q->tx_tail_addr, chan);
2227 } 2219 }
@@ -2233,6 +2225,13 @@ static int stmmac_init_dma_engine(struct stmmac_priv *priv)
2233 return ret; 2225 return ret;
2234} 2226}
2235 2227
2228static void stmmac_tx_timer_arm(struct stmmac_priv *priv, u32 queue)
2229{
2230 struct stmmac_tx_queue *tx_q = &priv->tx_queue[queue];
2231
2232 mod_timer(&tx_q->txtimer, STMMAC_COAL_TIMER(priv->tx_coal_timer));
2233}
2234
2236/** 2235/**
2237 * stmmac_tx_timer - mitigation sw timer for tx. 2236 * stmmac_tx_timer - mitigation sw timer for tx.
2238 * @data: data pointer 2237 * @data: data pointer
@@ -2241,13 +2240,14 @@ static int stmmac_init_dma_engine(struct stmmac_priv *priv)
2241 */ 2240 */
2242static void stmmac_tx_timer(struct timer_list *t) 2241static void stmmac_tx_timer(struct timer_list *t)
2243{ 2242{
2244 struct stmmac_priv *priv = from_timer(priv, t, txtimer); 2243 struct stmmac_tx_queue *tx_q = from_timer(tx_q, t, txtimer);
2245 u32 tx_queues_count = priv->plat->tx_queues_to_use; 2244 struct stmmac_priv *priv = tx_q->priv_data;
2246 u32 queue; 2245 struct stmmac_channel *ch;
2246
2247 ch = &priv->channel[tx_q->queue_index];
2247 2248
2248 /* let's scan all the tx queues */ 2249 if (likely(napi_schedule_prep(&ch->napi)))
2249 for (queue = 0; queue < tx_queues_count; queue++) 2250 __napi_schedule(&ch->napi);
2250 stmmac_tx_clean(priv, queue);
2251} 2251}
2252 2252
2253/** 2253/**
@@ -2260,11 +2260,17 @@ static void stmmac_tx_timer(struct timer_list *t)
2260 */ 2260 */
2261static void stmmac_init_tx_coalesce(struct stmmac_priv *priv) 2261static void stmmac_init_tx_coalesce(struct stmmac_priv *priv)
2262{ 2262{
2263 u32 tx_channel_count = priv->plat->tx_queues_to_use;
2264 u32 chan;
2265
2263 priv->tx_coal_frames = STMMAC_TX_FRAMES; 2266 priv->tx_coal_frames = STMMAC_TX_FRAMES;
2264 priv->tx_coal_timer = STMMAC_COAL_TX_TIMER; 2267 priv->tx_coal_timer = STMMAC_COAL_TX_TIMER;
2265 timer_setup(&priv->txtimer, stmmac_tx_timer, 0); 2268
2266 priv->txtimer.expires = STMMAC_COAL_TIMER(priv->tx_coal_timer); 2269 for (chan = 0; chan < tx_channel_count; chan++) {
2267 add_timer(&priv->txtimer); 2270 struct stmmac_tx_queue *tx_q = &priv->tx_queue[chan];
2271
2272 timer_setup(&tx_q->txtimer, stmmac_tx_timer, 0);
2273 }
2268} 2274}
2269 2275
2270static void stmmac_set_rings_length(struct stmmac_priv *priv) 2276static void stmmac_set_rings_length(struct stmmac_priv *priv)
@@ -2592,6 +2598,7 @@ static void stmmac_hw_teardown(struct net_device *dev)
2592static int stmmac_open(struct net_device *dev) 2598static int stmmac_open(struct net_device *dev)
2593{ 2599{
2594 struct stmmac_priv *priv = netdev_priv(dev); 2600 struct stmmac_priv *priv = netdev_priv(dev);
2601 u32 chan;
2595 int ret; 2602 int ret;
2596 2603
2597 stmmac_check_ether_addr(priv); 2604 stmmac_check_ether_addr(priv);
@@ -2688,7 +2695,9 @@ irq_error:
2688 if (dev->phydev) 2695 if (dev->phydev)
2689 phy_stop(dev->phydev); 2696 phy_stop(dev->phydev);
2690 2697
2691 del_timer_sync(&priv->txtimer); 2698 for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
2699 del_timer_sync(&priv->tx_queue[chan].txtimer);
2700
2692 stmmac_hw_teardown(dev); 2701 stmmac_hw_teardown(dev);
2693init_error: 2702init_error:
2694 free_dma_desc_resources(priv); 2703 free_dma_desc_resources(priv);
@@ -2708,6 +2717,7 @@ dma_desc_error:
2708static int stmmac_release(struct net_device *dev) 2717static int stmmac_release(struct net_device *dev)
2709{ 2718{
2710 struct stmmac_priv *priv = netdev_priv(dev); 2719 struct stmmac_priv *priv = netdev_priv(dev);
2720 u32 chan;
2711 2721
2712 if (priv->eee_enabled) 2722 if (priv->eee_enabled)
2713 del_timer_sync(&priv->eee_ctrl_timer); 2723 del_timer_sync(&priv->eee_ctrl_timer);
@@ -2722,7 +2732,8 @@ static int stmmac_release(struct net_device *dev)
2722 2732
2723 stmmac_disable_all_queues(priv); 2733 stmmac_disable_all_queues(priv);
2724 2734
2725 del_timer_sync(&priv->txtimer); 2735 for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
2736 del_timer_sync(&priv->tx_queue[chan].txtimer);
2726 2737
2727 /* Free the IRQ lines */ 2738 /* Free the IRQ lines */
2728 free_irq(dev->irq, dev); 2739 free_irq(dev->irq, dev);
@@ -2936,14 +2947,13 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
2936 priv->xstats.tx_tso_nfrags += nfrags; 2947 priv->xstats.tx_tso_nfrags += nfrags;
2937 2948
2938 /* Manage tx mitigation */ 2949 /* Manage tx mitigation */
2939 priv->tx_count_frames += nfrags + 1; 2950 tx_q->tx_count_frames += nfrags + 1;
2940 if (likely(priv->tx_coal_frames > priv->tx_count_frames)) { 2951 if (priv->tx_coal_frames <= tx_q->tx_count_frames) {
2941 mod_timer(&priv->txtimer,
2942 STMMAC_COAL_TIMER(priv->tx_coal_timer));
2943 } else {
2944 priv->tx_count_frames = 0;
2945 stmmac_set_tx_ic(priv, desc); 2952 stmmac_set_tx_ic(priv, desc);
2946 priv->xstats.tx_set_ic_bit++; 2953 priv->xstats.tx_set_ic_bit++;
2954 tx_q->tx_count_frames = 0;
2955 } else {
2956 stmmac_tx_timer_arm(priv, queue);
2947 } 2957 }
2948 2958
2949 skb_tx_timestamp(skb); 2959 skb_tx_timestamp(skb);
@@ -2992,6 +3002,7 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
2992 3002
2993 netdev_tx_sent_queue(netdev_get_tx_queue(dev, queue), skb->len); 3003 netdev_tx_sent_queue(netdev_get_tx_queue(dev, queue), skb->len);
2994 3004
3005 tx_q->tx_tail_addr = tx_q->dma_tx_phy + (tx_q->cur_tx * sizeof(*desc));
2995 stmmac_set_tx_tail_ptr(priv, priv->ioaddr, tx_q->tx_tail_addr, queue); 3006 stmmac_set_tx_tail_ptr(priv, priv->ioaddr, tx_q->tx_tail_addr, queue);
2996 3007
2997 return NETDEV_TX_OK; 3008 return NETDEV_TX_OK;
@@ -3146,14 +3157,13 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
3146 * This approach takes care about the fragments: desc is the first 3157 * This approach takes care about the fragments: desc is the first
3147 * element in case of no SG. 3158 * element in case of no SG.
3148 */ 3159 */
3149 priv->tx_count_frames += nfrags + 1; 3160 tx_q->tx_count_frames += nfrags + 1;
3150 if (likely(priv->tx_coal_frames > priv->tx_count_frames)) { 3161 if (priv->tx_coal_frames <= tx_q->tx_count_frames) {
3151 mod_timer(&priv->txtimer,
3152 STMMAC_COAL_TIMER(priv->tx_coal_timer));
3153 } else {
3154 priv->tx_count_frames = 0;
3155 stmmac_set_tx_ic(priv, desc); 3162 stmmac_set_tx_ic(priv, desc);
3156 priv->xstats.tx_set_ic_bit++; 3163 priv->xstats.tx_set_ic_bit++;
3164 tx_q->tx_count_frames = 0;
3165 } else {
3166 stmmac_tx_timer_arm(priv, queue);
3157 } 3167 }
3158 3168
3159 skb_tx_timestamp(skb); 3169 skb_tx_timestamp(skb);
@@ -3199,6 +3209,8 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
3199 netdev_tx_sent_queue(netdev_get_tx_queue(dev, queue), skb->len); 3209 netdev_tx_sent_queue(netdev_get_tx_queue(dev, queue), skb->len);
3200 3210
3201 stmmac_enable_dma_transmission(priv, priv->ioaddr); 3211 stmmac_enable_dma_transmission(priv, priv->ioaddr);
3212
3213 tx_q->tx_tail_addr = tx_q->dma_tx_phy + (tx_q->cur_tx * sizeof(*desc));
3202 stmmac_set_tx_tail_ptr(priv, priv->ioaddr, tx_q->tx_tail_addr, queue); 3214 stmmac_set_tx_tail_ptr(priv, priv->ioaddr, tx_q->tx_tail_addr, queue);
3203 3215
3204 return NETDEV_TX_OK; 3216 return NETDEV_TX_OK;
@@ -3319,6 +3331,7 @@ static inline void stmmac_rx_refill(struct stmmac_priv *priv, u32 queue)
3319static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) 3331static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
3320{ 3332{
3321 struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; 3333 struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue];
3334 struct stmmac_channel *ch = &priv->channel[queue];
3322 unsigned int entry = rx_q->cur_rx; 3335 unsigned int entry = rx_q->cur_rx;
3323 int coe = priv->hw->rx_csum; 3336 int coe = priv->hw->rx_csum;
3324 unsigned int next_entry; 3337 unsigned int next_entry;
@@ -3491,7 +3504,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
3491 else 3504 else
3492 skb->ip_summed = CHECKSUM_UNNECESSARY; 3505 skb->ip_summed = CHECKSUM_UNNECESSARY;
3493 3506
3494 napi_gro_receive(&rx_q->napi, skb); 3507 napi_gro_receive(&ch->napi, skb);
3495 3508
3496 priv->dev->stats.rx_packets++; 3509 priv->dev->stats.rx_packets++;
3497 priv->dev->stats.rx_bytes += frame_len; 3510 priv->dev->stats.rx_bytes += frame_len;
@@ -3514,27 +3527,33 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
3514 * Description : 3527 * Description :
3515 * To look at the incoming frames and clear the tx resources. 3528 * To look at the incoming frames and clear the tx resources.
3516 */ 3529 */
3517static int stmmac_poll(struct napi_struct *napi, int budget) 3530static int stmmac_napi_poll(struct napi_struct *napi, int budget)
3518{ 3531{
3519 struct stmmac_rx_queue *rx_q = 3532 struct stmmac_channel *ch =
3520 container_of(napi, struct stmmac_rx_queue, napi); 3533 container_of(napi, struct stmmac_channel, napi);
3521 struct stmmac_priv *priv = rx_q->priv_data; 3534 struct stmmac_priv *priv = ch->priv_data;
3522 u32 tx_count = priv->plat->tx_queues_to_use; 3535 int work_done = 0, work_rem = budget;
3523 u32 chan = rx_q->queue_index; 3536 u32 chan = ch->index;
3524 int work_done = 0;
3525 u32 queue;
3526 3537
3527 priv->xstats.napi_poll++; 3538 priv->xstats.napi_poll++;
3528 3539
3529 /* check all the queues */ 3540 if (ch->has_tx) {
3530 for (queue = 0; queue < tx_count; queue++) 3541 int done = stmmac_tx_clean(priv, work_rem, chan);
3531 stmmac_tx_clean(priv, queue);
3532 3542
3533 work_done = stmmac_rx(priv, budget, rx_q->queue_index); 3543 work_done += done;
3534 if (work_done < budget) { 3544 work_rem -= done;
3535 napi_complete_done(napi, work_done); 3545 }
3536 stmmac_enable_dma_irq(priv, priv->ioaddr, chan); 3546
3547 if (ch->has_rx) {
3548 int done = stmmac_rx(priv, work_rem, chan);
3549
3550 work_done += done;
3551 work_rem -= done;
3537 } 3552 }
3553
3554 if (work_done < budget && napi_complete_done(napi, work_done))
3555 stmmac_enable_dma_irq(priv, priv->ioaddr, chan);
3556
3538 return work_done; 3557 return work_done;
3539} 3558}
3540 3559
@@ -4198,8 +4217,8 @@ int stmmac_dvr_probe(struct device *device,
4198{ 4217{
4199 struct net_device *ndev = NULL; 4218 struct net_device *ndev = NULL;
4200 struct stmmac_priv *priv; 4219 struct stmmac_priv *priv;
4220 u32 queue, maxq;
4201 int ret = 0; 4221 int ret = 0;
4202 u32 queue;
4203 4222
4204 ndev = alloc_etherdev_mqs(sizeof(struct stmmac_priv), 4223 ndev = alloc_etherdev_mqs(sizeof(struct stmmac_priv),
4205 MTL_MAX_TX_QUEUES, 4224 MTL_MAX_TX_QUEUES,
@@ -4322,11 +4341,22 @@ int stmmac_dvr_probe(struct device *device,
4322 "Enable RX Mitigation via HW Watchdog Timer\n"); 4341 "Enable RX Mitigation via HW Watchdog Timer\n");
4323 } 4342 }
4324 4343
4325 for (queue = 0; queue < priv->plat->rx_queues_to_use; queue++) { 4344 /* Setup channels NAPI */
4326 struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; 4345 maxq = max(priv->plat->rx_queues_to_use, priv->plat->tx_queues_to_use);
4327 4346
4328 netif_napi_add(ndev, &rx_q->napi, stmmac_poll, 4347 for (queue = 0; queue < maxq; queue++) {
4329 (8 * priv->plat->rx_queues_to_use)); 4348 struct stmmac_channel *ch = &priv->channel[queue];
4349
4350 ch->priv_data = priv;
4351 ch->index = queue;
4352
4353 if (queue < priv->plat->rx_queues_to_use)
4354 ch->has_rx = true;
4355 if (queue < priv->plat->tx_queues_to_use)
4356 ch->has_tx = true;
4357
4358 netif_napi_add(ndev, &ch->napi, stmmac_napi_poll,
4359 NAPI_POLL_WEIGHT);
4330 } 4360 }
4331 4361
4332 mutex_init(&priv->lock); 4362 mutex_init(&priv->lock);
@@ -4372,10 +4402,10 @@ error_netdev_register:
4372 priv->hw->pcs != STMMAC_PCS_RTBI) 4402 priv->hw->pcs != STMMAC_PCS_RTBI)
4373 stmmac_mdio_unregister(ndev); 4403 stmmac_mdio_unregister(ndev);
4374error_mdio_register: 4404error_mdio_register:
4375 for (queue = 0; queue < priv->plat->rx_queues_to_use; queue++) { 4405 for (queue = 0; queue < maxq; queue++) {
4376 struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; 4406 struct stmmac_channel *ch = &priv->channel[queue];
4377 4407
4378 netif_napi_del(&rx_q->napi); 4408 netif_napi_del(&ch->napi);
4379 } 4409 }
4380error_hw_init: 4410error_hw_init:
4381 destroy_workqueue(priv->wq); 4411 destroy_workqueue(priv->wq);
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 3609c7b696c7..2b800ce1d5bf 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -67,7 +67,7 @@ static int dwmac1000_validate_mcast_bins(int mcast_bins)
67 * Description: 67 * Description:
68 * This function validates the number of Unicast address entries supported 68 * This function validates the number of Unicast address entries supported
69 * by a particular Synopsys 10/100/1000 controller. The Synopsys controller 69 * by a particular Synopsys 10/100/1000 controller. The Synopsys controller
70 * supports 1, 32, 64, or 128 Unicast filter entries for it's Unicast filter 70 * supports 1..32, 64, or 128 Unicast filter entries for it's Unicast filter
71 * logic. This function validates a valid, supported configuration is 71 * logic. This function validates a valid, supported configuration is
72 * selected, and defaults to 1 Unicast address if an unsupported 72 * selected, and defaults to 1 Unicast address if an unsupported
73 * configuration is selected. 73 * configuration is selected.
@@ -77,8 +77,7 @@ static int dwmac1000_validate_ucast_entries(int ucast_entries)
77 int x = ucast_entries; 77 int x = ucast_entries;
78 78
79 switch (x) { 79 switch (x) {
80 case 1: 80 case 1 ... 32:
81 case 32:
82 case 64: 81 case 64:
83 case 128: 82 case 128:
84 break; 83 break;
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 9263d638bd6d..f932923f7d56 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -41,6 +41,7 @@ config TI_DAVINCI_MDIO
41config TI_DAVINCI_CPDMA 41config TI_DAVINCI_CPDMA
42 tristate "TI DaVinci CPDMA Support" 42 tristate "TI DaVinci CPDMA Support"
43 depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST 43 depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
44 select GENERIC_ALLOCATOR
44 ---help--- 45 ---help---
45 This driver supports TI's DaVinci CPDMA dma engine. 46 This driver supports TI's DaVinci CPDMA dma engine.
46 47
diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c
index 2bdfb39215e9..d8ba512f166a 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -835,7 +835,7 @@ static void w5100_tx_work(struct work_struct *work)
835 w5100_tx_skb(priv->ndev, skb); 835 w5100_tx_skb(priv->ndev, skb);
836} 836}
837 837
838static int w5100_start_tx(struct sk_buff *skb, struct net_device *ndev) 838static netdev_tx_t w5100_start_tx(struct sk_buff *skb, struct net_device *ndev)
839{ 839{
840 struct w5100_priv *priv = netdev_priv(ndev); 840 struct w5100_priv *priv = netdev_priv(ndev);
841 841
diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c
index 56ae573001e8..80fdbff67d82 100644
--- a/drivers/net/ethernet/wiznet/w5300.c
+++ b/drivers/net/ethernet/wiznet/w5300.c
@@ -365,7 +365,7 @@ static void w5300_tx_timeout(struct net_device *ndev)
365 netif_wake_queue(ndev); 365 netif_wake_queue(ndev);
366} 366}
367 367
368static int w5300_start_tx(struct sk_buff *skb, struct net_device *ndev) 368static netdev_tx_t w5300_start_tx(struct sk_buff *skb, struct net_device *ndev)
369{ 369{
370 struct w5300_priv *priv = netdev_priv(ndev); 370 struct w5300_priv *priv = netdev_priv(ndev);
371 371
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 16ec7af6ab7b..ba9df430fca6 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -966,6 +966,8 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
966 sizeof(struct yamdrv_ioctl_mcs)); 966 sizeof(struct yamdrv_ioctl_mcs));
967 if (IS_ERR(ym)) 967 if (IS_ERR(ym))
968 return PTR_ERR(ym); 968 return PTR_ERR(ym);
969 if (ym->cmd != SIOCYAMSMCS)
970 return -EINVAL;
969 if (ym->bitrate > YAM_MAXBITRATE) { 971 if (ym->bitrate > YAM_MAXBITRATE) {
970 kfree(ym); 972 kfree(ym);
971 return -EINVAL; 973 return -EINVAL;
@@ -981,6 +983,8 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
981 if (copy_from_user(&yi, ifr->ifr_data, sizeof(struct yamdrv_ioctl_cfg))) 983 if (copy_from_user(&yi, ifr->ifr_data, sizeof(struct yamdrv_ioctl_cfg)))
982 return -EFAULT; 984 return -EFAULT;
983 985
986 if (yi.cmd != SIOCYAMSCFG)
987 return -EINVAL;
984 if ((yi.cfg.mask & YAM_IOBASE) && netif_running(dev)) 988 if ((yi.cfg.mask & YAM_IOBASE) && netif_running(dev))
985 return -EINVAL; /* Cannot change this parameter when up */ 989 return -EINVAL; /* Cannot change this parameter when up */
986 if ((yi.cfg.mask & YAM_IRQ) && netif_running(dev)) 990 if ((yi.cfg.mask & YAM_IRQ) && netif_running(dev))
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 31c3d77b4733..fe01e141c8f8 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1203,6 +1203,9 @@ static void netvsc_send_vf(struct net_device *ndev,
1203 1203
1204 net_device_ctx->vf_alloc = nvmsg->msg.v4_msg.vf_assoc.allocated; 1204 net_device_ctx->vf_alloc = nvmsg->msg.v4_msg.vf_assoc.allocated;
1205 net_device_ctx->vf_serial = nvmsg->msg.v4_msg.vf_assoc.serial; 1205 net_device_ctx->vf_serial = nvmsg->msg.v4_msg.vf_assoc.serial;
1206 netdev_info(ndev, "VF slot %u %s\n",
1207 net_device_ctx->vf_serial,
1208 net_device_ctx->vf_alloc ? "added" : "removed");
1206} 1209}
1207 1210
1208static void netvsc_receive_inband(struct net_device *ndev, 1211static void netvsc_receive_inband(struct net_device *ndev,
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 70921bbe0e28..3af6d8d15233 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1894,20 +1894,6 @@ out_unlock:
1894 rtnl_unlock(); 1894 rtnl_unlock();
1895} 1895}
1896 1896
1897static struct net_device *get_netvsc_bymac(const u8 *mac)
1898{
1899 struct net_device_context *ndev_ctx;
1900
1901 list_for_each_entry(ndev_ctx, &netvsc_dev_list, list) {
1902 struct net_device *dev = hv_get_drvdata(ndev_ctx->device_ctx);
1903
1904 if (ether_addr_equal(mac, dev->perm_addr))
1905 return dev;
1906 }
1907
1908 return NULL;
1909}
1910
1911static struct net_device *get_netvsc_byref(struct net_device *vf_netdev) 1897static struct net_device *get_netvsc_byref(struct net_device *vf_netdev)
1912{ 1898{
1913 struct net_device_context *net_device_ctx; 1899 struct net_device_context *net_device_ctx;
@@ -2036,26 +2022,48 @@ static void netvsc_vf_setup(struct work_struct *w)
2036 rtnl_unlock(); 2022 rtnl_unlock();
2037} 2023}
2038 2024
2025/* Find netvsc by VMBus serial number.
2026 * The PCI hyperv controller records the serial number as the slot.
2027 */
2028static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev)
2029{
2030 struct device *parent = vf_netdev->dev.parent;
2031 struct net_device_context *ndev_ctx;
2032 struct pci_dev *pdev;
2033
2034 if (!parent || !dev_is_pci(parent))
2035 return NULL; /* not a PCI device */
2036
2037 pdev = to_pci_dev(parent);
2038 if (!pdev->slot) {
2039 netdev_notice(vf_netdev, "no PCI slot information\n");
2040 return NULL;
2041 }
2042
2043 list_for_each_entry(ndev_ctx, &netvsc_dev_list, list) {
2044 if (!ndev_ctx->vf_alloc)
2045 continue;
2046
2047 if (ndev_ctx->vf_serial == pdev->slot->number)
2048 return hv_get_drvdata(ndev_ctx->device_ctx);
2049 }
2050
2051 netdev_notice(vf_netdev,
2052 "no netdev found for slot %u\n", pdev->slot->number);
2053 return NULL;
2054}
2055
2039static int netvsc_register_vf(struct net_device *vf_netdev) 2056static int netvsc_register_vf(struct net_device *vf_netdev)
2040{ 2057{
2041 struct net_device *ndev;
2042 struct net_device_context *net_device_ctx; 2058 struct net_device_context *net_device_ctx;
2043 struct device *pdev = vf_netdev->dev.parent;
2044 struct netvsc_device *netvsc_dev; 2059 struct netvsc_device *netvsc_dev;
2060 struct net_device *ndev;
2045 int ret; 2061 int ret;
2046 2062
2047 if (vf_netdev->addr_len != ETH_ALEN) 2063 if (vf_netdev->addr_len != ETH_ALEN)
2048 return NOTIFY_DONE; 2064 return NOTIFY_DONE;
2049 2065
2050 if (!pdev || !dev_is_pci(pdev) || dev_is_pf(pdev)) 2066 ndev = get_netvsc_byslot(vf_netdev);
2051 return NOTIFY_DONE;
2052
2053 /*
2054 * We will use the MAC address to locate the synthetic interface to
2055 * associate with the VF interface. If we don't find a matching
2056 * synthetic interface, move on.
2057 */
2058 ndev = get_netvsc_bymac(vf_netdev->perm_addr);
2059 if (!ndev) 2067 if (!ndev)
2060 return NOTIFY_DONE; 2068 return NOTIFY_DONE;
2061 2069
@@ -2272,17 +2280,15 @@ static int netvsc_remove(struct hv_device *dev)
2272 2280
2273 cancel_delayed_work_sync(&ndev_ctx->dwork); 2281 cancel_delayed_work_sync(&ndev_ctx->dwork);
2274 2282
2275 rcu_read_lock(); 2283 rtnl_lock();
2276 nvdev = rcu_dereference(ndev_ctx->nvdev); 2284 nvdev = rtnl_dereference(ndev_ctx->nvdev);
2277 2285 if (nvdev)
2278 if (nvdev)
2279 cancel_work_sync(&nvdev->subchan_work); 2286 cancel_work_sync(&nvdev->subchan_work);
2280 2287
2281 /* 2288 /*
2282 * Call to the vsc driver to let it know that the device is being 2289 * Call to the vsc driver to let it know that the device is being
2283 * removed. Also blocks mtu and channel changes. 2290 * removed. Also blocks mtu and channel changes.
2284 */ 2291 */
2285 rtnl_lock();
2286 vf_netdev = rtnl_dereference(ndev_ctx->vf_netdev); 2292 vf_netdev = rtnl_dereference(ndev_ctx->vf_netdev);
2287 if (vf_netdev) 2293 if (vf_netdev)
2288 netvsc_unregister_vf(vf_netdev); 2294 netvsc_unregister_vf(vf_netdev);
@@ -2294,7 +2300,6 @@ static int netvsc_remove(struct hv_device *dev)
2294 list_del(&ndev_ctx->list); 2300 list_del(&ndev_ctx->list);
2295 2301
2296 rtnl_unlock(); 2302 rtnl_unlock();
2297 rcu_read_unlock();
2298 2303
2299 hv_set_drvdata(dev, NULL); 2304 hv_set_drvdata(dev, NULL);
2300 2305
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index 23a52b9293f3..cd1d8faccca5 100644
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -1308,8 +1308,7 @@ static int adf7242_remove(struct spi_device *spi)
1308{ 1308{
1309 struct adf7242_local *lp = spi_get_drvdata(spi); 1309 struct adf7242_local *lp = spi_get_drvdata(spi);
1310 1310
1311 if (!IS_ERR_OR_NULL(lp->debugfs_root)) 1311 debugfs_remove_recursive(lp->debugfs_root);
1312 debugfs_remove_recursive(lp->debugfs_root);
1313 1312
1314 cancel_delayed_work_sync(&lp->work); 1313 cancel_delayed_work_sync(&lp->work);
1315 destroy_workqueue(lp->wqueue); 1314 destroy_workqueue(lp->wqueue);
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 58299fb666ed..0ff5a403a8dc 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -634,10 +634,9 @@ static int ca8210_test_int_driver_write(
634 for (i = 0; i < len; i++) 634 for (i = 0; i < len; i++)
635 dev_dbg(&priv->spi->dev, "%#03x\n", buf[i]); 635 dev_dbg(&priv->spi->dev, "%#03x\n", buf[i]);
636 636
637 fifo_buffer = kmalloc(len, GFP_KERNEL); 637 fifo_buffer = kmemdup(buf, len, GFP_KERNEL);
638 if (!fifo_buffer) 638 if (!fifo_buffer)
639 return -ENOMEM; 639 return -ENOMEM;
640 memcpy(fifo_buffer, buf, len);
641 kfifo_in(&test->up_fifo, &fifo_buffer, 4); 640 kfifo_in(&test->up_fifo, &fifo_buffer, 4);
642 wake_up_interruptible(&priv->test.readq); 641 wake_up_interruptible(&priv->test.readq);
643 642
@@ -3044,8 +3043,7 @@ static void ca8210_test_interface_clear(struct ca8210_priv *priv)
3044{ 3043{
3045 struct ca8210_test *test = &priv->test; 3044 struct ca8210_test *test = &priv->test;
3046 3045
3047 if (!IS_ERR(test->ca8210_dfs_spi_int)) 3046 debugfs_remove(test->ca8210_dfs_spi_int);
3048 debugfs_remove(test->ca8210_dfs_spi_int);
3049 kfifo_free(&test->up_fifo); 3047 kfifo_free(&test->up_fifo);
3050 dev_info(&priv->spi->dev, "Test interface removed\n"); 3048 dev_info(&priv->spi->dev, "Test interface removed\n");
3051} 3049}
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index e428277781ac..04891429a554 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -903,19 +903,19 @@ mcr20a_irq_clean_complete(void *context)
903 903
904 switch (seq_state) { 904 switch (seq_state) {
905 /* TX IRQ, RX IRQ and SEQ IRQ */ 905 /* TX IRQ, RX IRQ and SEQ IRQ */
906 case (0x03): 906 case (DAR_IRQSTS1_TXIRQ | DAR_IRQSTS1_SEQIRQ):
907 if (lp->is_tx) { 907 if (lp->is_tx) {
908 lp->is_tx = 0; 908 lp->is_tx = 0;
909 dev_dbg(printdev(lp), "TX is done. No ACK\n"); 909 dev_dbg(printdev(lp), "TX is done. No ACK\n");
910 mcr20a_handle_tx_complete(lp); 910 mcr20a_handle_tx_complete(lp);
911 } 911 }
912 break; 912 break;
913 case (0x05): 913 case (DAR_IRQSTS1_RXIRQ | DAR_IRQSTS1_SEQIRQ):
914 /* rx is starting */ 914 /* rx is starting */
915 dev_dbg(printdev(lp), "RX is starting\n"); 915 dev_dbg(printdev(lp), "RX is starting\n");
916 mcr20a_handle_rx(lp); 916 mcr20a_handle_rx(lp);
917 break; 917 break;
918 case (0x07): 918 case (DAR_IRQSTS1_RXIRQ | DAR_IRQSTS1_TXIRQ | DAR_IRQSTS1_SEQIRQ):
919 if (lp->is_tx) { 919 if (lp->is_tx) {
920 /* tx is done */ 920 /* tx is done */
921 lp->is_tx = 0; 921 lp->is_tx = 0;
@@ -927,7 +927,7 @@ mcr20a_irq_clean_complete(void *context)
927 mcr20a_handle_rx(lp); 927 mcr20a_handle_rx(lp);
928 } 928 }
929 break; 929 break;
930 case (0x01): 930 case (DAR_IRQSTS1_SEQIRQ):
931 if (lp->is_tx) { 931 if (lp->is_tx) {
932 dev_dbg(printdev(lp), "TX is starting\n"); 932 dev_dbg(printdev(lp), "TX is starting\n");
933 mcr20a_handle_tx(lp); 933 mcr20a_handle_tx(lp);
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index db1172db1e7c..19ab8a7d1e48 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -93,7 +93,12 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
93 if (!netdev) 93 if (!netdev)
94 return !phydev->suspended; 94 return !phydev->suspended;
95 95
96 /* Don't suspend PHY if the attached netdev parent may wakeup. 96 if (netdev->wol_enabled)
97 return false;
98
99 /* As long as not all affected network drivers support the
100 * wol_enabled flag, let's check for hints that WoL is enabled.
101 * Don't suspend PHY if the attached netdev parent may wake up.
97 * The parent may point to a PCI device, as in tg3 driver. 102 * The parent may point to a PCI device, as in tg3 driver.
98 */ 103 */
99 if (netdev->dev.parent && device_may_wakeup(netdev->dev.parent)) 104 if (netdev->dev.parent && device_may_wakeup(netdev->dev.parent))
@@ -1132,9 +1137,9 @@ void phy_detach(struct phy_device *phydev)
1132 sysfs_remove_link(&dev->dev.kobj, "phydev"); 1137 sysfs_remove_link(&dev->dev.kobj, "phydev");
1133 sysfs_remove_link(&phydev->mdio.dev.kobj, "attached_dev"); 1138 sysfs_remove_link(&phydev->mdio.dev.kobj, "attached_dev");
1134 } 1139 }
1140 phy_suspend(phydev);
1135 phydev->attached_dev->phydev = NULL; 1141 phydev->attached_dev->phydev = NULL;
1136 phydev->attached_dev = NULL; 1142 phydev->attached_dev = NULL;
1137 phy_suspend(phydev);
1138 phydev->phylink = NULL; 1143 phydev->phylink = NULL;
1139 1144
1140 phy_led_triggers_unregister(phydev); 1145 phy_led_triggers_unregister(phydev);
@@ -1168,12 +1173,13 @@ EXPORT_SYMBOL(phy_detach);
1168int phy_suspend(struct phy_device *phydev) 1173int phy_suspend(struct phy_device *phydev)
1169{ 1174{
1170 struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); 1175 struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver);
1176 struct net_device *netdev = phydev->attached_dev;
1171 struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL }; 1177 struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL };
1172 int ret = 0; 1178 int ret = 0;
1173 1179
1174 /* If the device has WOL enabled, we cannot suspend the PHY */ 1180 /* If the device has WOL enabled, we cannot suspend the PHY */
1175 phy_ethtool_get_wol(phydev, &wol); 1181 phy_ethtool_get_wol(phydev, &wol);
1176 if (wol.wolopts) 1182 if (wol.wolopts || (netdev && netdev->wol_enabled))
1177 return -EBUSY; 1183 return -EBUSY;
1178 1184
1179 if (phydev->drv && phydrv->suspend) 1185 if (phydev->drv && phydrv->suspend)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 3ba5cf2a8a5f..7abca86c3aa9 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -717,6 +717,30 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy)
717 return 0; 717 return 0;
718} 718}
719 719
720static int __phylink_connect_phy(struct phylink *pl, struct phy_device *phy,
721 phy_interface_t interface)
722{
723 int ret;
724
725 if (WARN_ON(pl->link_an_mode == MLO_AN_FIXED ||
726 (pl->link_an_mode == MLO_AN_INBAND &&
727 phy_interface_mode_is_8023z(interface))))
728 return -EINVAL;
729
730 if (pl->phydev)
731 return -EBUSY;
732
733 ret = phy_attach_direct(pl->netdev, phy, 0, interface);
734 if (ret)
735 return ret;
736
737 ret = phylink_bringup_phy(pl, phy);
738 if (ret)
739 phy_detach(phy);
740
741 return ret;
742}
743
720/** 744/**
721 * phylink_connect_phy() - connect a PHY to the phylink instance 745 * phylink_connect_phy() - connect a PHY to the phylink instance
722 * @pl: a pointer to a &struct phylink returned from phylink_create() 746 * @pl: a pointer to a &struct phylink returned from phylink_create()
@@ -734,31 +758,13 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy)
734 */ 758 */
735int phylink_connect_phy(struct phylink *pl, struct phy_device *phy) 759int phylink_connect_phy(struct phylink *pl, struct phy_device *phy)
736{ 760{
737 int ret;
738
739 if (WARN_ON(pl->link_an_mode == MLO_AN_FIXED ||
740 (pl->link_an_mode == MLO_AN_INBAND &&
741 phy_interface_mode_is_8023z(pl->link_interface))))
742 return -EINVAL;
743
744 if (pl->phydev)
745 return -EBUSY;
746
747 /* Use PHY device/driver interface */ 761 /* Use PHY device/driver interface */
748 if (pl->link_interface == PHY_INTERFACE_MODE_NA) { 762 if (pl->link_interface == PHY_INTERFACE_MODE_NA) {
749 pl->link_interface = phy->interface; 763 pl->link_interface = phy->interface;
750 pl->link_config.interface = pl->link_interface; 764 pl->link_config.interface = pl->link_interface;
751 } 765 }
752 766
753 ret = phy_attach_direct(pl->netdev, phy, 0, pl->link_interface); 767 return __phylink_connect_phy(pl, phy, pl->link_interface);
754 if (ret)
755 return ret;
756
757 ret = phylink_bringup_phy(pl, phy);
758 if (ret)
759 phy_detach(phy);
760
761 return ret;
762} 768}
763EXPORT_SYMBOL_GPL(phylink_connect_phy); 769EXPORT_SYMBOL_GPL(phylink_connect_phy);
764 770
@@ -1672,7 +1678,9 @@ static void phylink_sfp_link_up(void *upstream)
1672 1678
1673static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy) 1679static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy)
1674{ 1680{
1675 return phylink_connect_phy(upstream, phy); 1681 struct phylink *pl = upstream;
1682
1683 return __phylink_connect_phy(upstream, phy, pl->link_config.interface);
1676} 1684}
1677 1685
1678static void phylink_sfp_disconnect_phy(void *upstream) 1686static void phylink_sfp_disconnect_phy(void *upstream)
diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
index 740655261e5b..83060fb349f4 100644
--- a/drivers/net/phy/sfp-bus.c
+++ b/drivers/net/phy/sfp-bus.c
@@ -349,6 +349,7 @@ static int sfp_register_bus(struct sfp_bus *bus)
349 } 349 }
350 if (bus->started) 350 if (bus->started)
351 bus->socket_ops->start(bus->sfp); 351 bus->socket_ops->start(bus->sfp);
352 bus->netdev->sfp_bus = bus;
352 bus->registered = true; 353 bus->registered = true;
353 return 0; 354 return 0;
354} 355}
@@ -357,6 +358,7 @@ static void sfp_unregister_bus(struct sfp_bus *bus)
357{ 358{
358 const struct sfp_upstream_ops *ops = bus->upstream_ops; 359 const struct sfp_upstream_ops *ops = bus->upstream_ops;
359 360
361 bus->netdev->sfp_bus = NULL;
360 if (bus->registered) { 362 if (bus->registered) {
361 if (bus->started) 363 if (bus->started)
362 bus->socket_ops->stop(bus->sfp); 364 bus->socket_ops->stop(bus->sfp);
@@ -438,7 +440,6 @@ static void sfp_upstream_clear(struct sfp_bus *bus)
438{ 440{
439 bus->upstream_ops = NULL; 441 bus->upstream_ops = NULL;
440 bus->upstream = NULL; 442 bus->upstream = NULL;
441 bus->netdev->sfp_bus = NULL;
442 bus->netdev = NULL; 443 bus->netdev = NULL;
443} 444}
444 445
@@ -467,7 +468,6 @@ struct sfp_bus *sfp_register_upstream(struct fwnode_handle *fwnode,
467 bus->upstream_ops = ops; 468 bus->upstream_ops = ops;
468 bus->upstream = upstream; 469 bus->upstream = upstream;
469 bus->netdev = ndev; 470 bus->netdev = ndev;
470 ndev->sfp_bus = bus;
471 471
472 if (bus->sfp) { 472 if (bus->sfp) {
473 ret = sfp_register_bus(bus); 473 ret = sfp_register_bus(bus);
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 52fffb98fde9..fd8bb998ae52 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -163,8 +163,6 @@ static const enum gpiod_flags gpio_flags[] = {
163/* Give this long for the PHY to reset. */ 163/* Give this long for the PHY to reset. */
164#define T_PHY_RESET_MS 50 164#define T_PHY_RESET_MS 50
165 165
166static DEFINE_MUTEX(sfp_mutex);
167
168struct sff_data { 166struct sff_data {
169 unsigned int gpios; 167 unsigned int gpios;
170 bool (*module_supported)(const struct sfp_eeprom_id *id); 168 bool (*module_supported)(const struct sfp_eeprom_id *id);
@@ -1098,8 +1096,11 @@ static int sfp_hwmon_insert(struct sfp *sfp)
1098 1096
1099static void sfp_hwmon_remove(struct sfp *sfp) 1097static void sfp_hwmon_remove(struct sfp *sfp)
1100{ 1098{
1101 hwmon_device_unregister(sfp->hwmon_dev); 1099 if (!IS_ERR_OR_NULL(sfp->hwmon_dev)) {
1102 kfree(sfp->hwmon_name); 1100 hwmon_device_unregister(sfp->hwmon_dev);
1101 sfp->hwmon_dev = NULL;
1102 kfree(sfp->hwmon_name);
1103 }
1103} 1104}
1104#else 1105#else
1105static int sfp_hwmon_insert(struct sfp *sfp) 1106static int sfp_hwmon_insert(struct sfp *sfp)
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index ce61231e96ea..62dc564b251d 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -429,6 +429,9 @@ static int pppoe_rcv(struct sk_buff *skb, struct net_device *dev,
429 if (!skb) 429 if (!skb)
430 goto out; 430 goto out;
431 431
432 if (skb_mac_header_len(skb) < ETH_HLEN)
433 goto drop;
434
432 if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr))) 435 if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr)))
433 goto drop; 436 goto drop;
434 437
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 6a047d30e8c6..d887016e54b6 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1167,6 +1167,12 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
1167 return -EBUSY; 1167 return -EBUSY;
1168 } 1168 }
1169 1169
1170 if (dev == port_dev) {
1171 NL_SET_ERR_MSG(extack, "Cannot enslave team device to itself");
1172 netdev_err(dev, "Cannot enslave team device to itself\n");
1173 return -EINVAL;
1174 }
1175
1170 if (port_dev->features & NETIF_F_VLAN_CHALLENGED && 1176 if (port_dev->features & NETIF_F_VLAN_CHALLENGED &&
1171 vlan_uses_dev(dev)) { 1177 vlan_uses_dev(dev)) {
1172 NL_SET_ERR_MSG(extack, "Device is VLAN challenged and team device has VLAN set up"); 1178 NL_SET_ERR_MSG(extack, "Device is VLAN challenged and team device has VLAN set up");
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index ebd07ad82431..50e9cc19023a 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -181,6 +181,7 @@ struct tun_file {
181 }; 181 };
182 struct napi_struct napi; 182 struct napi_struct napi;
183 bool napi_enabled; 183 bool napi_enabled;
184 bool napi_frags_enabled;
184 struct mutex napi_mutex; /* Protects access to the above napi */ 185 struct mutex napi_mutex; /* Protects access to the above napi */
185 struct list_head next; 186 struct list_head next;
186 struct tun_struct *detached; 187 struct tun_struct *detached;
@@ -313,32 +314,32 @@ static int tun_napi_poll(struct napi_struct *napi, int budget)
313} 314}
314 315
315static void tun_napi_init(struct tun_struct *tun, struct tun_file *tfile, 316static void tun_napi_init(struct tun_struct *tun, struct tun_file *tfile,
316 bool napi_en) 317 bool napi_en, bool napi_frags)
317{ 318{
318 tfile->napi_enabled = napi_en; 319 tfile->napi_enabled = napi_en;
320 tfile->napi_frags_enabled = napi_en && napi_frags;
319 if (napi_en) { 321 if (napi_en) {
320 netif_napi_add(tun->dev, &tfile->napi, tun_napi_poll, 322 netif_napi_add(tun->dev, &tfile->napi, tun_napi_poll,
321 NAPI_POLL_WEIGHT); 323 NAPI_POLL_WEIGHT);
322 napi_enable(&tfile->napi); 324 napi_enable(&tfile->napi);
323 mutex_init(&tfile->napi_mutex);
324 } 325 }
325} 326}
326 327
327static void tun_napi_disable(struct tun_struct *tun, struct tun_file *tfile) 328static void tun_napi_disable(struct tun_file *tfile)
328{ 329{
329 if (tfile->napi_enabled) 330 if (tfile->napi_enabled)
330 napi_disable(&tfile->napi); 331 napi_disable(&tfile->napi);
331} 332}
332 333
333static void tun_napi_del(struct tun_struct *tun, struct tun_file *tfile) 334static void tun_napi_del(struct tun_file *tfile)
334{ 335{
335 if (tfile->napi_enabled) 336 if (tfile->napi_enabled)
336 netif_napi_del(&tfile->napi); 337 netif_napi_del(&tfile->napi);
337} 338}
338 339
339static bool tun_napi_frags_enabled(const struct tun_struct *tun) 340static bool tun_napi_frags_enabled(const struct tun_file *tfile)
340{ 341{
341 return READ_ONCE(tun->flags) & IFF_NAPI_FRAGS; 342 return tfile->napi_frags_enabled;
342} 343}
343 344
344#ifdef CONFIG_TUN_VNET_CROSS_LE 345#ifdef CONFIG_TUN_VNET_CROSS_LE
@@ -690,8 +691,8 @@ static void __tun_detach(struct tun_file *tfile, bool clean)
690 tun = rtnl_dereference(tfile->tun); 691 tun = rtnl_dereference(tfile->tun);
691 692
692 if (tun && clean) { 693 if (tun && clean) {
693 tun_napi_disable(tun, tfile); 694 tun_napi_disable(tfile);
694 tun_napi_del(tun, tfile); 695 tun_napi_del(tfile);
695 } 696 }
696 697
697 if (tun && !tfile->detached) { 698 if (tun && !tfile->detached) {
@@ -758,7 +759,7 @@ static void tun_detach_all(struct net_device *dev)
758 for (i = 0; i < n; i++) { 759 for (i = 0; i < n; i++) {
759 tfile = rtnl_dereference(tun->tfiles[i]); 760 tfile = rtnl_dereference(tun->tfiles[i]);
760 BUG_ON(!tfile); 761 BUG_ON(!tfile);
761 tun_napi_disable(tun, tfile); 762 tun_napi_disable(tfile);
762 tfile->socket.sk->sk_shutdown = RCV_SHUTDOWN; 763 tfile->socket.sk->sk_shutdown = RCV_SHUTDOWN;
763 tfile->socket.sk->sk_data_ready(tfile->socket.sk); 764 tfile->socket.sk->sk_data_ready(tfile->socket.sk);
764 RCU_INIT_POINTER(tfile->tun, NULL); 765 RCU_INIT_POINTER(tfile->tun, NULL);
@@ -774,7 +775,7 @@ static void tun_detach_all(struct net_device *dev)
774 synchronize_net(); 775 synchronize_net();
775 for (i = 0; i < n; i++) { 776 for (i = 0; i < n; i++) {
776 tfile = rtnl_dereference(tun->tfiles[i]); 777 tfile = rtnl_dereference(tun->tfiles[i]);
777 tun_napi_del(tun, tfile); 778 tun_napi_del(tfile);
778 /* Drop read queue */ 779 /* Drop read queue */
779 tun_queue_purge(tfile); 780 tun_queue_purge(tfile);
780 xdp_rxq_info_unreg(&tfile->xdp_rxq); 781 xdp_rxq_info_unreg(&tfile->xdp_rxq);
@@ -793,7 +794,7 @@ static void tun_detach_all(struct net_device *dev)
793} 794}
794 795
795static int tun_attach(struct tun_struct *tun, struct file *file, 796static int tun_attach(struct tun_struct *tun, struct file *file,
796 bool skip_filter, bool napi) 797 bool skip_filter, bool napi, bool napi_frags)
797{ 798{
798 struct tun_file *tfile = file->private_data; 799 struct tun_file *tfile = file->private_data;
799 struct net_device *dev = tun->dev; 800 struct net_device *dev = tun->dev;
@@ -866,7 +867,7 @@ static int tun_attach(struct tun_struct *tun, struct file *file,
866 tun_enable_queue(tfile); 867 tun_enable_queue(tfile);
867 } else { 868 } else {
868 sock_hold(&tfile->sk); 869 sock_hold(&tfile->sk);
869 tun_napi_init(tun, tfile, napi); 870 tun_napi_init(tun, tfile, napi, napi_frags);
870 } 871 }
871 872
872 tun_set_real_num_queues(tun); 873 tun_set_real_num_queues(tun);
@@ -1153,43 +1154,6 @@ static netdev_features_t tun_net_fix_features(struct net_device *dev,
1153 1154
1154 return (features & tun->set_features) | (features & ~TUN_USER_FEATURES); 1155 return (features & tun->set_features) | (features & ~TUN_USER_FEATURES);
1155} 1156}
1156#ifdef CONFIG_NET_POLL_CONTROLLER
1157static void tun_poll_controller(struct net_device *dev)
1158{
1159 /*
1160 * Tun only receives frames when:
1161 * 1) the char device endpoint gets data from user space
1162 * 2) the tun socket gets a sendmsg call from user space
1163 * If NAPI is not enabled, since both of those are synchronous
1164 * operations, we are guaranteed never to have pending data when we poll
1165 * for it so there is nothing to do here but return.
1166 * We need this though so netpoll recognizes us as an interface that
1167 * supports polling, which enables bridge devices in virt setups to
1168 * still use netconsole
1169 * If NAPI is enabled, however, we need to schedule polling for all
1170 * queues unless we are using napi_gro_frags(), which we call in
1171 * process context and not in NAPI context.
1172 */
1173 struct tun_struct *tun = netdev_priv(dev);
1174
1175 if (tun->flags & IFF_NAPI) {
1176 struct tun_file *tfile;
1177 int i;
1178
1179 if (tun_napi_frags_enabled(tun))
1180 return;
1181
1182 rcu_read_lock();
1183 for (i = 0; i < tun->numqueues; i++) {
1184 tfile = rcu_dereference(tun->tfiles[i]);
1185 if (tfile->napi_enabled)
1186 napi_schedule(&tfile->napi);
1187 }
1188 rcu_read_unlock();
1189 }
1190 return;
1191}
1192#endif
1193 1157
1194static void tun_set_headroom(struct net_device *dev, int new_hr) 1158static void tun_set_headroom(struct net_device *dev, int new_hr)
1195{ 1159{
@@ -1283,9 +1247,6 @@ static const struct net_device_ops tun_netdev_ops = {
1283 .ndo_start_xmit = tun_net_xmit, 1247 .ndo_start_xmit = tun_net_xmit,
1284 .ndo_fix_features = tun_net_fix_features, 1248 .ndo_fix_features = tun_net_fix_features,
1285 .ndo_select_queue = tun_select_queue, 1249 .ndo_select_queue = tun_select_queue,
1286#ifdef CONFIG_NET_POLL_CONTROLLER
1287 .ndo_poll_controller = tun_poll_controller,
1288#endif
1289 .ndo_set_rx_headroom = tun_set_headroom, 1250 .ndo_set_rx_headroom = tun_set_headroom,
1290 .ndo_get_stats64 = tun_net_get_stats64, 1251 .ndo_get_stats64 = tun_net_get_stats64,
1291}; 1252};
@@ -1365,9 +1326,6 @@ static const struct net_device_ops tap_netdev_ops = {
1365 .ndo_set_mac_address = eth_mac_addr, 1326 .ndo_set_mac_address = eth_mac_addr,
1366 .ndo_validate_addr = eth_validate_addr, 1327 .ndo_validate_addr = eth_validate_addr,
1367 .ndo_select_queue = tun_select_queue, 1328 .ndo_select_queue = tun_select_queue,
1368#ifdef CONFIG_NET_POLL_CONTROLLER
1369 .ndo_poll_controller = tun_poll_controller,
1370#endif
1371 .ndo_features_check = passthru_features_check, 1329 .ndo_features_check = passthru_features_check,
1372 .ndo_set_rx_headroom = tun_set_headroom, 1330 .ndo_set_rx_headroom = tun_set_headroom,
1373 .ndo_get_stats64 = tun_net_get_stats64, 1331 .ndo_get_stats64 = tun_net_get_stats64,
@@ -1752,7 +1710,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
1752 int err; 1710 int err;
1753 u32 rxhash = 0; 1711 u32 rxhash = 0;
1754 int skb_xdp = 1; 1712 int skb_xdp = 1;
1755 bool frags = tun_napi_frags_enabled(tun); 1713 bool frags = tun_napi_frags_enabled(tfile);
1756 1714
1757 if (!(tun->dev->flags & IFF_UP)) 1715 if (!(tun->dev->flags & IFF_UP))
1758 return -EIO; 1716 return -EIO;
@@ -2577,7 +2535,8 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
2577 return err; 2535 return err;
2578 2536
2579 err = tun_attach(tun, file, ifr->ifr_flags & IFF_NOFILTER, 2537 err = tun_attach(tun, file, ifr->ifr_flags & IFF_NOFILTER,
2580 ifr->ifr_flags & IFF_NAPI); 2538 ifr->ifr_flags & IFF_NAPI,
2539 ifr->ifr_flags & IFF_NAPI_FRAGS);
2581 if (err < 0) 2540 if (err < 0)
2582 return err; 2541 return err;
2583 2542
@@ -2675,7 +2634,8 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
2675 (ifr->ifr_flags & TUN_FEATURES); 2634 (ifr->ifr_flags & TUN_FEATURES);
2676 2635
2677 INIT_LIST_HEAD(&tun->disabled); 2636 INIT_LIST_HEAD(&tun->disabled);
2678 err = tun_attach(tun, file, false, ifr->ifr_flags & IFF_NAPI); 2637 err = tun_attach(tun, file, false, ifr->ifr_flags & IFF_NAPI,
2638 ifr->ifr_flags & IFF_NAPI_FRAGS);
2679 if (err < 0) 2639 if (err < 0)
2680 goto err_free_flow; 2640 goto err_free_flow;
2681 2641
@@ -2824,7 +2784,8 @@ static int tun_set_queue(struct file *file, struct ifreq *ifr)
2824 ret = security_tun_dev_attach_queue(tun->security); 2784 ret = security_tun_dev_attach_queue(tun->security);
2825 if (ret < 0) 2785 if (ret < 0)
2826 goto unlock; 2786 goto unlock;
2827 ret = tun_attach(tun, file, false, tun->flags & IFF_NAPI); 2787 ret = tun_attach(tun, file, false, tun->flags & IFF_NAPI,
2788 tun->flags & IFF_NAPI_FRAGS);
2828 } else if (ifr->ifr_flags & IFF_DETACH_QUEUE) { 2789 } else if (ifr->ifr_flags & IFF_DETACH_QUEUE) {
2829 tun = rtnl_dereference(tfile->tun); 2790 tun = rtnl_dereference(tfile->tun);
2830 if (!tun || !(tun->flags & IFF_MULTI_QUEUE) || tfile->detached) 2791 if (!tun || !(tun->flags & IFF_MULTI_QUEUE) || tfile->detached)
@@ -3242,6 +3203,7 @@ static int tun_chr_open(struct inode *inode, struct file * file)
3242 return -ENOMEM; 3203 return -ENOMEM;
3243 } 3204 }
3244 3205
3206 mutex_init(&tfile->napi_mutex);
3245 RCU_INIT_POINTER(tfile->tun, NULL); 3207 RCU_INIT_POINTER(tfile->tun, NULL);
3246 tfile->flags = 0; 3208 tfile->flags = 0;
3247 tfile->ifindex = 0; 3209 tfile->ifindex = 0;
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index e95dd12edec4..023b8d0bf175 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -607,6 +607,9 @@ int asix_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
607 struct usbnet *dev = netdev_priv(net); 607 struct usbnet *dev = netdev_priv(net);
608 u8 opt = 0; 608 u8 opt = 0;
609 609
610 if (wolinfo->wolopts & ~(WAKE_PHY | WAKE_MAGIC))
611 return -EINVAL;
612
610 if (wolinfo->wolopts & WAKE_PHY) 613 if (wolinfo->wolopts & WAKE_PHY)
611 opt |= AX_MONITOR_LINK; 614 opt |= AX_MONITOR_LINK;
612 if (wolinfo->wolopts & WAKE_MAGIC) 615 if (wolinfo->wolopts & WAKE_MAGIC)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 9e8ad372f419..2207f7a7d1ff 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -566,6 +566,9 @@ ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
566 struct usbnet *dev = netdev_priv(net); 566 struct usbnet *dev = netdev_priv(net);
567 u8 opt = 0; 567 u8 opt = 0;
568 568
569 if (wolinfo->wolopts & ~(WAKE_PHY | WAKE_MAGIC))
570 return -EINVAL;
571
569 if (wolinfo->wolopts & WAKE_PHY) 572 if (wolinfo->wolopts & WAKE_PHY)
570 opt |= AX_MONITOR_MODE_RWLC; 573 opt |= AX_MONITOR_MODE_RWLC;
571 if (wolinfo->wolopts & WAKE_MAGIC) 574 if (wolinfo->wolopts & WAKE_MAGIC)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index a9991c5f4736..c3c9ba44e2a1 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1401,19 +1401,10 @@ static int lan78xx_set_wol(struct net_device *netdev,
1401 if (ret < 0) 1401 if (ret < 0)
1402 return ret; 1402 return ret;
1403 1403
1404 pdata->wol = 0; 1404 if (wol->wolopts & ~WAKE_ALL)
1405 if (wol->wolopts & WAKE_UCAST) 1405 return -EINVAL;
1406 pdata->wol |= WAKE_UCAST; 1406
1407 if (wol->wolopts & WAKE_MCAST) 1407 pdata->wol = wol->wolopts;
1408 pdata->wol |= WAKE_MCAST;
1409 if (wol->wolopts & WAKE_BCAST)
1410 pdata->wol |= WAKE_BCAST;
1411 if (wol->wolopts & WAKE_MAGIC)
1412 pdata->wol |= WAKE_MAGIC;
1413 if (wol->wolopts & WAKE_PHY)
1414 pdata->wol |= WAKE_PHY;
1415 if (wol->wolopts & WAKE_ARP)
1416 pdata->wol |= WAKE_ARP;
1417 1408
1418 device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts); 1409 device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);
1419 1410
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index cb0cc30c3d6a..72a55b6b4211 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -967,6 +967,13 @@ static const struct usb_device_id products[] = {
967 USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x581d, USB_CLASS_VENDOR_SPEC, 1, 7), 967 USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x581d, USB_CLASS_VENDOR_SPEC, 1, 7),
968 .driver_info = (unsigned long)&qmi_wwan_info, 968 .driver_info = (unsigned long)&qmi_wwan_info,
969 }, 969 },
970 { /* Quectel EP06/EG06/EM06 */
971 USB_DEVICE_AND_INTERFACE_INFO(0x2c7c, 0x0306,
972 USB_CLASS_VENDOR_SPEC,
973 USB_SUBCLASS_VENDOR_SPEC,
974 0xff),
975 .driver_info = (unsigned long)&qmi_wwan_info_quirk_dtr,
976 },
970 977
971 /* 3. Combined interface devices matching on interface number */ 978 /* 3. Combined interface devices matching on interface number */
972 {QMI_FIXED_INTF(0x0408, 0xea42, 4)}, /* Yota / Megafon M100-1 */ 979 {QMI_FIXED_INTF(0x0408, 0xea42, 4)}, /* Yota / Megafon M100-1 */
@@ -1206,13 +1213,13 @@ static const struct usb_device_id products[] = {
1206 {QMI_FIXED_INTF(0x1199, 0x9061, 8)}, /* Sierra Wireless Modem */ 1213 {QMI_FIXED_INTF(0x1199, 0x9061, 8)}, /* Sierra Wireless Modem */
1207 {QMI_FIXED_INTF(0x1199, 0x9063, 8)}, /* Sierra Wireless EM7305 */ 1214 {QMI_FIXED_INTF(0x1199, 0x9063, 8)}, /* Sierra Wireless EM7305 */
1208 {QMI_FIXED_INTF(0x1199, 0x9063, 10)}, /* Sierra Wireless EM7305 */ 1215 {QMI_FIXED_INTF(0x1199, 0x9063, 10)}, /* Sierra Wireless EM7305 */
1209 {QMI_FIXED_INTF(0x1199, 0x9071, 8)}, /* Sierra Wireless MC74xx */ 1216 {QMI_QUIRK_SET_DTR(0x1199, 0x9071, 8)}, /* Sierra Wireless MC74xx */
1210 {QMI_FIXED_INTF(0x1199, 0x9071, 10)}, /* Sierra Wireless MC74xx */ 1217 {QMI_QUIRK_SET_DTR(0x1199, 0x9071, 10)},/* Sierra Wireless MC74xx */
1211 {QMI_FIXED_INTF(0x1199, 0x9079, 8)}, /* Sierra Wireless EM74xx */ 1218 {QMI_QUIRK_SET_DTR(0x1199, 0x9079, 8)}, /* Sierra Wireless EM74xx */
1212 {QMI_FIXED_INTF(0x1199, 0x9079, 10)}, /* Sierra Wireless EM74xx */ 1219 {QMI_QUIRK_SET_DTR(0x1199, 0x9079, 10)},/* Sierra Wireless EM74xx */
1213 {QMI_FIXED_INTF(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */ 1220 {QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */
1214 {QMI_FIXED_INTF(0x1199, 0x907b, 10)}, /* Sierra Wireless EM74xx */ 1221 {QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
1215 {QMI_FIXED_INTF(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */ 1222 {QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */
1216 {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */ 1223 {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
1217 {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */ 1224 {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
1218 {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */ 1225 {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
@@ -1234,6 +1241,7 @@ static const struct usb_device_id products[] = {
1234 {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */ 1241 {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
1235 {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */ 1242 {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
1236 {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */ 1243 {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
1244 {QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet) */
1237 {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */ 1245 {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */
1238 {QMI_FIXED_INTF(0x1e2d, 0x0082, 5)}, /* Cinterion PHxx,PXxx (2 RmNet) */ 1246 {QMI_FIXED_INTF(0x1e2d, 0x0082, 5)}, /* Cinterion PHxx,PXxx (2 RmNet) */
1239 {QMI_FIXED_INTF(0x1e2d, 0x0083, 4)}, /* Cinterion PHxx,PXxx (1 RmNet + USB Audio)*/ 1247 {QMI_FIXED_INTF(0x1e2d, 0x0083, 4)}, /* Cinterion PHxx,PXxx (1 RmNet + USB Audio)*/
@@ -1255,7 +1263,6 @@ static const struct usb_device_id products[] = {
1255 {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */ 1263 {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
1256 {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */ 1264 {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
1257 {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */ 1265 {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
1258 {QMI_QUIRK_SET_DTR(0x2c7c, 0x0306, 4)}, /* Quectel EP06 Mini PCIe */
1259 1266
1260 /* 4. Gobi 1000 devices */ 1267 /* 4. Gobi 1000 devices */
1261 {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */ 1268 {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
@@ -1331,6 +1338,19 @@ static bool quectel_ec20_detected(struct usb_interface *intf)
1331 return false; 1338 return false;
1332} 1339}
1333 1340
1341static bool quectel_ep06_diag_detected(struct usb_interface *intf)
1342{
1343 struct usb_device *dev = interface_to_usbdev(intf);
1344 struct usb_interface_descriptor intf_desc = intf->cur_altsetting->desc;
1345
1346 if (le16_to_cpu(dev->descriptor.idVendor) == 0x2c7c &&
1347 le16_to_cpu(dev->descriptor.idProduct) == 0x0306 &&
1348 intf_desc.bNumEndpoints == 2)
1349 return true;
1350
1351 return false;
1352}
1353
1334static int qmi_wwan_probe(struct usb_interface *intf, 1354static int qmi_wwan_probe(struct usb_interface *intf,
1335 const struct usb_device_id *prod) 1355 const struct usb_device_id *prod)
1336{ 1356{
@@ -1365,6 +1385,15 @@ static int qmi_wwan_probe(struct usb_interface *intf,
1365 return -ENODEV; 1385 return -ENODEV;
1366 } 1386 }
1367 1387
1388 /* Quectel EP06/EM06/EG06 supports dynamic interface configuration, so
1389 * we need to match on class/subclass/protocol. These values are
1390 * identical for the diagnostic- and QMI-interface, but bNumEndpoints is
1391 * different. Ignore the current interface if the number of endpoints
1392 * the number for the diag interface (two).
1393 */
1394 if (quectel_ep06_diag_detected(intf))
1395 return -ENODEV;
1396
1368 return usbnet_probe(intf, id); 1397 return usbnet_probe(intf, id);
1369} 1398}
1370 1399
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 2cd71bdb6484..f1b5201cc320 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -4506,6 +4506,9 @@ static int rtl8152_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
4506 if (!rtl_can_wakeup(tp)) 4506 if (!rtl_can_wakeup(tp))
4507 return -EOPNOTSUPP; 4507 return -EOPNOTSUPP;
4508 4508
4509 if (wol->wolopts & ~WAKE_ANY)
4510 return -EINVAL;
4511
4509 ret = usb_autopm_get_interface(tp->intf); 4512 ret = usb_autopm_get_interface(tp->intf);
4510 if (ret < 0) 4513 if (ret < 0)
4511 goto out_set_wol; 4514 goto out_set_wol;
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index 05553d252446..ec287c9741e8 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -731,6 +731,9 @@ static int smsc75xx_ethtool_set_wol(struct net_device *net,
731 struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]); 731 struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
732 int ret; 732 int ret;
733 733
734 if (wolinfo->wolopts & ~SUPPORTED_WAKE)
735 return -EINVAL;
736
734 pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE; 737 pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE;
735 738
736 ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts); 739 ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts);
@@ -1517,6 +1520,7 @@ static void smsc75xx_unbind(struct usbnet *dev, struct usb_interface *intf)
1517{ 1520{
1518 struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]); 1521 struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
1519 if (pdata) { 1522 if (pdata) {
1523 cancel_work_sync(&pdata->set_multicast);
1520 netif_dbg(dev, ifdown, dev->net, "free pdata\n"); 1524 netif_dbg(dev, ifdown, dev->net, "free pdata\n");
1521 kfree(pdata); 1525 kfree(pdata);
1522 pdata = NULL; 1526 pdata = NULL;
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 06b4d290784d..262e7a3c23cb 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -774,6 +774,9 @@ static int smsc95xx_ethtool_set_wol(struct net_device *net,
774 struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]); 774 struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
775 int ret; 775 int ret;
776 776
777 if (wolinfo->wolopts & ~SUPPORTED_WAKE)
778 return -EINVAL;
779
777 pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE; 780 pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE;
778 781
779 ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts); 782 ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts);
diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
index 9277a0f228df..35f39f23d881 100644
--- a/drivers/net/usb/sr9800.c
+++ b/drivers/net/usb/sr9800.c
@@ -421,6 +421,9 @@ sr_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
421 struct usbnet *dev = netdev_priv(net); 421 struct usbnet *dev = netdev_priv(net);
422 u8 opt = 0; 422 u8 opt = 0;
423 423
424 if (wolinfo->wolopts & ~(WAKE_PHY | WAKE_MAGIC))
425 return -EINVAL;
426
424 if (wolinfo->wolopts & WAKE_PHY) 427 if (wolinfo->wolopts & WAKE_PHY)
425 opt |= SR_MONITOR_LINK; 428 opt |= SR_MONITOR_LINK;
426 if (wolinfo->wolopts & WAKE_MAGIC) 429 if (wolinfo->wolopts & WAKE_MAGIC)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 8d679c8b7f25..41a00cd76955 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -463,6 +463,8 @@ static struct sk_buff *veth_xdp_rcv_skb(struct veth_rq *rq, struct sk_buff *skb,
463 int mac_len, delta, off; 463 int mac_len, delta, off;
464 struct xdp_buff xdp; 464 struct xdp_buff xdp;
465 465
466 skb_orphan(skb);
467
466 rcu_read_lock(); 468 rcu_read_lock();
467 xdp_prog = rcu_dereference(rq->xdp_prog); 469 xdp_prog = rcu_dereference(rq->xdp_prog);
468 if (unlikely(!xdp_prog)) { 470 if (unlikely(!xdp_prog)) {
@@ -508,8 +510,6 @@ static struct sk_buff *veth_xdp_rcv_skb(struct veth_rq *rq, struct sk_buff *skb,
508 skb_copy_header(nskb, skb); 510 skb_copy_header(nskb, skb);
509 head_off = skb_headroom(nskb) - skb_headroom(skb); 511 head_off = skb_headroom(nskb) - skb_headroom(skb);
510 skb_headers_offset_update(nskb, head_off); 512 skb_headers_offset_update(nskb, head_off);
511 if (skb->sk)
512 skb_set_owner_w(nskb, skb->sk);
513 consume_skb(skb); 513 consume_skb(skb);
514 skb = nskb; 514 skb = nskb;
515 } 515 }
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 765920905226..dab504ec5e50 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1699,17 +1699,6 @@ static void virtnet_stats(struct net_device *dev,
1699 tot->rx_frame_errors = dev->stats.rx_frame_errors; 1699 tot->rx_frame_errors = dev->stats.rx_frame_errors;
1700} 1700}
1701 1701
1702#ifdef CONFIG_NET_POLL_CONTROLLER
1703static void virtnet_netpoll(struct net_device *dev)
1704{
1705 struct virtnet_info *vi = netdev_priv(dev);
1706 int i;
1707
1708 for (i = 0; i < vi->curr_queue_pairs; i++)
1709 napi_schedule(&vi->rq[i].napi);
1710}
1711#endif
1712
1713static void virtnet_ack_link_announce(struct virtnet_info *vi) 1702static void virtnet_ack_link_announce(struct virtnet_info *vi)
1714{ 1703{
1715 rtnl_lock(); 1704 rtnl_lock();
@@ -2447,9 +2436,6 @@ static const struct net_device_ops virtnet_netdev = {
2447 .ndo_get_stats64 = virtnet_stats, 2436 .ndo_get_stats64 = virtnet_stats,
2448 .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, 2437 .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid,
2449 .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, 2438 .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid,
2450#ifdef CONFIG_NET_POLL_CONTROLLER
2451 .ndo_poll_controller = virtnet_netpoll,
2452#endif
2453 .ndo_bpf = virtnet_xdp, 2439 .ndo_bpf = virtnet_xdp,
2454 .ndo_xdp_xmit = virtnet_xdp_xmit, 2440 .ndo_xdp_xmit = virtnet_xdp_xmit,
2455 .ndo_features_check = passthru_features_check, 2441 .ndo_features_check = passthru_features_check,
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index ababba37d735..2b8da2b7e721 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -3539,6 +3539,7 @@ static size_t vxlan_get_size(const struct net_device *dev)
3539 nla_total_size(sizeof(__u32)) + /* IFLA_VXLAN_LINK */ 3539 nla_total_size(sizeof(__u32)) + /* IFLA_VXLAN_LINK */
3540 nla_total_size(sizeof(struct in6_addr)) + /* IFLA_VXLAN_LOCAL{6} */ 3540 nla_total_size(sizeof(struct in6_addr)) + /* IFLA_VXLAN_LOCAL{6} */
3541 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_TTL */ 3541 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_TTL */
3542 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_TTL_INHERIT */
3542 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_TOS */ 3543 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_TOS */
3543 nla_total_size(sizeof(__be32)) + /* IFLA_VXLAN_LABEL */ 3544 nla_total_size(sizeof(__be32)) + /* IFLA_VXLAN_LABEL */
3544 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_LEARNING */ 3545 nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_LEARNING */
@@ -3603,6 +3604,8 @@ static int vxlan_fill_info(struct sk_buff *skb, const struct net_device *dev)
3603 } 3604 }
3604 3605
3605 if (nla_put_u8(skb, IFLA_VXLAN_TTL, vxlan->cfg.ttl) || 3606 if (nla_put_u8(skb, IFLA_VXLAN_TTL, vxlan->cfg.ttl) ||
3607 nla_put_u8(skb, IFLA_VXLAN_TTL_INHERIT,
3608 !!(vxlan->cfg.flags & VXLAN_F_TTL_INHERIT)) ||
3606 nla_put_u8(skb, IFLA_VXLAN_TOS, vxlan->cfg.tos) || 3609 nla_put_u8(skb, IFLA_VXLAN_TOS, vxlan->cfg.tos) ||
3607 nla_put_be32(skb, IFLA_VXLAN_LABEL, vxlan->cfg.label) || 3610 nla_put_be32(skb, IFLA_VXLAN_LABEL, vxlan->cfg.label) ||
3608 nla_put_u8(skb, IFLA_VXLAN_LEARNING, 3611 nla_put_u8(skb, IFLA_VXLAN_LEARNING,
diff --git a/drivers/net/wimax/i2400m/control.c b/drivers/net/wimax/i2400m/control.c
index 094cea775d0c..ef298d8525c5 100644
--- a/drivers/net/wimax/i2400m/control.c
+++ b/drivers/net/wimax/i2400m/control.c
@@ -257,7 +257,7 @@ static const struct
257 [I2400M_MS_ACCESSIBILITY_ERROR] = { "accesibility error", -EIO }, 257 [I2400M_MS_ACCESSIBILITY_ERROR] = { "accesibility error", -EIO },
258 [I2400M_MS_BUSY] = { "busy", -EBUSY }, 258 [I2400M_MS_BUSY] = { "busy", -EBUSY },
259 [I2400M_MS_CORRUPTED_TLV] = { "corrupted TLV", -EILSEQ }, 259 [I2400M_MS_CORRUPTED_TLV] = { "corrupted TLV", -EILSEQ },
260 [I2400M_MS_UNINITIALIZED] = { "not unitialized", -EILSEQ }, 260 [I2400M_MS_UNINITIALIZED] = { "uninitialized", -EILSEQ },
261 [I2400M_MS_UNKNOWN_ERROR] = { "unknown error", -EIO }, 261 [I2400M_MS_UNKNOWN_ERROR] = { "unknown error", -EIO },
262 [I2400M_MS_PRODUCTION_ERROR] = { "production error", -EIO }, 262 [I2400M_MS_PRODUCTION_ERROR] = { "production error", -EIO },
263 [I2400M_MS_NO_RF] = { "no RF", -EIO }, 263 [I2400M_MS_NO_RF] = { "no RF", -EIO },
diff --git a/drivers/net/wireless/broadcom/b43/dma.c b/drivers/net/wireless/broadcom/b43/dma.c
index 6b0e1ec346cb..d46d57b989ae 100644
--- a/drivers/net/wireless/broadcom/b43/dma.c
+++ b/drivers/net/wireless/broadcom/b43/dma.c
@@ -1518,13 +1518,15 @@ void b43_dma_handle_txstatus(struct b43_wldev *dev,
1518 } 1518 }
1519 } else { 1519 } else {
1520 /* More than a single header/data pair were missed. 1520 /* More than a single header/data pair were missed.
1521 * Report this error, and reset the controller to 1521 * Report this error. If running with open-source
1522 * firmware, then reset the controller to
1522 * revive operation. 1523 * revive operation.
1523 */ 1524 */
1524 b43dbg(dev->wl, 1525 b43dbg(dev->wl,
1525 "Out of order TX status report on DMA ring %d. Expected %d, but got %d\n", 1526 "Out of order TX status report on DMA ring %d. Expected %d, but got %d\n",
1526 ring->index, firstused, slot); 1527 ring->index, firstused, slot);
1527 b43_controller_restart(dev, "Out of order TX"); 1528 if (dev->fw.opensource)
1529 b43_controller_restart(dev, "Out of order TX");
1528 return; 1530 return;
1529 } 1531 }
1530 } 1532 }
diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/1000.c b/drivers/net/wireless/intel/iwlwifi/cfg/1000.c
index 591687984962..497fd766d87c 100644
--- a/drivers/net/wireless/intel/iwlwifi/cfg/1000.c
+++ b/drivers/net/wireless/intel/iwlwifi/cfg/1000.c
@@ -51,6 +51,7 @@
51 51
52static const struct iwl_base_params iwl1000_base_params = { 52static const struct iwl_base_params iwl1000_base_params = {
53 .num_of_queues = IWLAGN_NUM_QUEUES, 53 .num_of_queues = IWLAGN_NUM_QUEUES,
54 .max_tfd_queue_size = 256,
54 .eeprom_size = OTP_LOW_IMAGE_SIZE, 55 .eeprom_size = OTP_LOW_IMAGE_SIZE,
55 .pll_cfg = true, 56 .pll_cfg = true,
56 .max_ll_items = OTP_MAX_LL_ITEMS_1000, 57 .max_ll_items = OTP_MAX_LL_ITEMS_1000,
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 1068757ec42e..07442ada6dd0 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -520,7 +520,6 @@ struct mac80211_hwsim_data {
520 int channels, idx; 520 int channels, idx;
521 bool use_chanctx; 521 bool use_chanctx;
522 bool destroy_on_close; 522 bool destroy_on_close;
523 struct work_struct destroy_work;
524 u32 portid; 523 u32 portid;
525 char alpha2[2]; 524 char alpha2[2];
526 const struct ieee80211_regdomain *regd; 525 const struct ieee80211_regdomain *regd;
@@ -2935,8 +2934,7 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
2935 hwsim_radios_generation++; 2934 hwsim_radios_generation++;
2936 spin_unlock_bh(&hwsim_radio_lock); 2935 spin_unlock_bh(&hwsim_radio_lock);
2937 2936
2938 if (idx > 0) 2937 hwsim_mcast_new_radio(idx, info, param);
2939 hwsim_mcast_new_radio(idx, info, param);
2940 2938
2941 return idx; 2939 return idx;
2942 2940
@@ -3565,30 +3563,27 @@ static struct genl_family hwsim_genl_family __ro_after_init = {
3565 .n_mcgrps = ARRAY_SIZE(hwsim_mcgrps), 3563 .n_mcgrps = ARRAY_SIZE(hwsim_mcgrps),
3566}; 3564};
3567 3565
3568static void destroy_radio(struct work_struct *work)
3569{
3570 struct mac80211_hwsim_data *data =
3571 container_of(work, struct mac80211_hwsim_data, destroy_work);
3572
3573 hwsim_radios_generation++;
3574 mac80211_hwsim_del_radio(data, wiphy_name(data->hw->wiphy), NULL);
3575}
3576
3577static void remove_user_radios(u32 portid) 3566static void remove_user_radios(u32 portid)
3578{ 3567{
3579 struct mac80211_hwsim_data *entry, *tmp; 3568 struct mac80211_hwsim_data *entry, *tmp;
3569 LIST_HEAD(list);
3580 3570
3581 spin_lock_bh(&hwsim_radio_lock); 3571 spin_lock_bh(&hwsim_radio_lock);
3582 list_for_each_entry_safe(entry, tmp, &hwsim_radios, list) { 3572 list_for_each_entry_safe(entry, tmp, &hwsim_radios, list) {
3583 if (entry->destroy_on_close && entry->portid == portid) { 3573 if (entry->destroy_on_close && entry->portid == portid) {
3584 list_del(&entry->list); 3574 list_move(&entry->list, &list);
3585 rhashtable_remove_fast(&hwsim_radios_rht, &entry->rht, 3575 rhashtable_remove_fast(&hwsim_radios_rht, &entry->rht,
3586 hwsim_rht_params); 3576 hwsim_rht_params);
3587 INIT_WORK(&entry->destroy_work, destroy_radio); 3577 hwsim_radios_generation++;
3588 queue_work(hwsim_wq, &entry->destroy_work);
3589 } 3578 }
3590 } 3579 }
3591 spin_unlock_bh(&hwsim_radio_lock); 3580 spin_unlock_bh(&hwsim_radio_lock);
3581
3582 list_for_each_entry_safe(entry, tmp, &list, list) {
3583 list_del(&entry->list);
3584 mac80211_hwsim_del_radio(entry, wiphy_name(entry->hw->wiphy),
3585 NULL);
3586 }
3592} 3587}
3593 3588
3594static int mac80211_hwsim_netlink_notify(struct notifier_block *nb, 3589static int mac80211_hwsim_netlink_notify(struct notifier_block *nb,
@@ -3646,6 +3641,7 @@ static __net_init int hwsim_init_net(struct net *net)
3646static void __net_exit hwsim_exit_net(struct net *net) 3641static void __net_exit hwsim_exit_net(struct net *net)
3647{ 3642{
3648 struct mac80211_hwsim_data *data, *tmp; 3643 struct mac80211_hwsim_data *data, *tmp;
3644 LIST_HEAD(list);
3649 3645
3650 spin_lock_bh(&hwsim_radio_lock); 3646 spin_lock_bh(&hwsim_radio_lock);
3651 list_for_each_entry_safe(data, tmp, &hwsim_radios, list) { 3647 list_for_each_entry_safe(data, tmp, &hwsim_radios, list) {
@@ -3656,17 +3652,19 @@ static void __net_exit hwsim_exit_net(struct net *net)
3656 if (data->netgroup == hwsim_net_get_netgroup(&init_net)) 3652 if (data->netgroup == hwsim_net_get_netgroup(&init_net))
3657 continue; 3653 continue;
3658 3654
3659 list_del(&data->list); 3655 list_move(&data->list, &list);
3660 rhashtable_remove_fast(&hwsim_radios_rht, &data->rht, 3656 rhashtable_remove_fast(&hwsim_radios_rht, &data->rht,
3661 hwsim_rht_params); 3657 hwsim_rht_params);
3662 hwsim_radios_generation++; 3658 hwsim_radios_generation++;
3663 spin_unlock_bh(&hwsim_radio_lock); 3659 }
3660 spin_unlock_bh(&hwsim_radio_lock);
3661
3662 list_for_each_entry_safe(data, tmp, &list, list) {
3663 list_del(&data->list);
3664 mac80211_hwsim_del_radio(data, 3664 mac80211_hwsim_del_radio(data,
3665 wiphy_name(data->hw->wiphy), 3665 wiphy_name(data->hw->wiphy),
3666 NULL); 3666 NULL);
3667 spin_lock_bh(&hwsim_radio_lock);
3668 } 3667 }
3669 spin_unlock_bh(&hwsim_radio_lock);
3670 3668
3671 ida_simple_remove(&hwsim_netgroup_ida, hwsim_net_get_netgroup(net)); 3669 ida_simple_remove(&hwsim_netgroup_ida, hwsim_net_get_netgroup(net));
3672} 3670}
diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c
index 43743c26c071..39bf85d0ade0 100644
--- a/drivers/net/wireless/marvell/libertas/if_sdio.c
+++ b/drivers/net/wireless/marvell/libertas/if_sdio.c
@@ -1317,6 +1317,10 @@ static int if_sdio_suspend(struct device *dev)
1317 if (priv->wol_criteria == EHS_REMOVE_WAKEUP) { 1317 if (priv->wol_criteria == EHS_REMOVE_WAKEUP) {
1318 dev_info(dev, "Suspend without wake params -- powering down card\n"); 1318 dev_info(dev, "Suspend without wake params -- powering down card\n");
1319 if (priv->fw_ready) { 1319 if (priv->fw_ready) {
1320 ret = lbs_suspend(priv);
1321 if (ret)
1322 return ret;
1323
1320 priv->power_up_on_resume = true; 1324 priv->power_up_on_resume = true;
1321 if_sdio_power_off(card); 1325 if_sdio_power_off(card);
1322 } 1326 }
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/main.c b/drivers/net/wireless/mediatek/mt76/mt76x0/main.c
index cf6ffb1ba4a2..22bc9d368728 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/main.c
@@ -77,9 +77,8 @@ static void mt76x0_remove_interface(struct ieee80211_hw *hw,
77{ 77{
78 struct mt76x0_dev *dev = hw->priv; 78 struct mt76x0_dev *dev = hw->priv;
79 struct mt76_vif *mvif = (struct mt76_vif *) vif->drv_priv; 79 struct mt76_vif *mvif = (struct mt76_vif *) vif->drv_priv;
80 unsigned int wcid = mvif->group_wcid.idx;
81 80
82 dev->wcid_mask[wcid / BITS_PER_LONG] &= ~BIT(wcid % BITS_PER_LONG); 81 dev->vif_mask &= ~BIT(mvif->idx);
83} 82}
84 83
85static int mt76x0_config(struct ieee80211_hw *hw, u32 changed) 84static int mt76x0_config(struct ieee80211_hw *hw, u32 changed)
diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
index 7780b07543bb..79e59f2379a2 100644
--- a/drivers/net/wireless/mediatek/mt76/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/usb.c
@@ -258,7 +258,7 @@ int mt76u_buf_alloc(struct mt76_dev *dev, struct mt76u_buf *buf,
258 if (!buf->urb) 258 if (!buf->urb)
259 return -ENOMEM; 259 return -ENOMEM;
260 260
261 buf->urb->sg = devm_kzalloc(dev->dev, nsgs * sizeof(*buf->urb->sg), 261 buf->urb->sg = devm_kcalloc(dev->dev, nsgs, sizeof(*buf->urb->sg),
262 gfp); 262 gfp);
263 if (!buf->urb->sg) 263 if (!buf->urb->sg)
264 return -ENOMEM; 264 return -ENOMEM;
@@ -464,8 +464,8 @@ static int mt76u_alloc_rx(struct mt76_dev *dev)
464 int i, err, nsgs; 464 int i, err, nsgs;
465 465
466 spin_lock_init(&q->lock); 466 spin_lock_init(&q->lock);
467 q->entry = devm_kzalloc(dev->dev, 467 q->entry = devm_kcalloc(dev->dev,
468 MT_NUM_RX_ENTRIES * sizeof(*q->entry), 468 MT_NUM_RX_ENTRIES, sizeof(*q->entry),
469 GFP_KERNEL); 469 GFP_KERNEL);
470 if (!q->entry) 470 if (!q->entry)
471 return -ENOMEM; 471 return -ENOMEM;
@@ -717,8 +717,8 @@ static int mt76u_alloc_tx(struct mt76_dev *dev)
717 INIT_LIST_HEAD(&q->swq); 717 INIT_LIST_HEAD(&q->swq);
718 q->hw_idx = q2hwq(i); 718 q->hw_idx = q2hwq(i);
719 719
720 q->entry = devm_kzalloc(dev->dev, 720 q->entry = devm_kcalloc(dev->dev,
721 MT_NUM_TX_ENTRIES * sizeof(*q->entry), 721 MT_NUM_TX_ENTRIES, sizeof(*q->entry),
722 GFP_KERNEL); 722 GFP_KERNEL);
723 if (!q->entry) 723 if (!q->entry)
724 return -ENOMEM; 724 return -ENOMEM;
diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h
index a46a1e94505d..936c0b3e0ba2 100644
--- a/drivers/net/xen-netback/common.h
+++ b/drivers/net/xen-netback/common.h
@@ -241,8 +241,9 @@ struct xenvif_hash_cache {
241struct xenvif_hash { 241struct xenvif_hash {
242 unsigned int alg; 242 unsigned int alg;
243 u32 flags; 243 u32 flags;
244 bool mapping_sel;
244 u8 key[XEN_NETBK_MAX_HASH_KEY_SIZE]; 245 u8 key[XEN_NETBK_MAX_HASH_KEY_SIZE];
245 u32 mapping[XEN_NETBK_MAX_HASH_MAPPING_SIZE]; 246 u32 mapping[2][XEN_NETBK_MAX_HASH_MAPPING_SIZE];
246 unsigned int size; 247 unsigned int size;
247 struct xenvif_hash_cache cache; 248 struct xenvif_hash_cache cache;
248}; 249};
diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-netback/hash.c
index 3c4c58b9fe76..0ccb021f1e78 100644
--- a/drivers/net/xen-netback/hash.c
+++ b/drivers/net/xen-netback/hash.c
@@ -324,7 +324,8 @@ u32 xenvif_set_hash_mapping_size(struct xenvif *vif, u32 size)
324 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER; 324 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER;
325 325
326 vif->hash.size = size; 326 vif->hash.size = size;
327 memset(vif->hash.mapping, 0, sizeof(u32) * size); 327 memset(vif->hash.mapping[vif->hash.mapping_sel], 0,
328 sizeof(u32) * size);
328 329
329 return XEN_NETIF_CTRL_STATUS_SUCCESS; 330 return XEN_NETIF_CTRL_STATUS_SUCCESS;
330} 331}
@@ -332,31 +333,49 @@ u32 xenvif_set_hash_mapping_size(struct xenvif *vif, u32 size)
332u32 xenvif_set_hash_mapping(struct xenvif *vif, u32 gref, u32 len, 333u32 xenvif_set_hash_mapping(struct xenvif *vif, u32 gref, u32 len,
333 u32 off) 334 u32 off)
334{ 335{
335 u32 *mapping = &vif->hash.mapping[off]; 336 u32 *mapping = vif->hash.mapping[!vif->hash.mapping_sel];
336 struct gnttab_copy copy_op = { 337 unsigned int nr = 1;
338 struct gnttab_copy copy_op[2] = {{
337 .source.u.ref = gref, 339 .source.u.ref = gref,
338 .source.domid = vif->domid, 340 .source.domid = vif->domid,
339 .dest.u.gmfn = virt_to_gfn(mapping),
340 .dest.domid = DOMID_SELF, 341 .dest.domid = DOMID_SELF,
341 .dest.offset = xen_offset_in_page(mapping), 342 .len = len * sizeof(*mapping),
342 .len = len * sizeof(u32),
343 .flags = GNTCOPY_source_gref 343 .flags = GNTCOPY_source_gref
344 }; 344 }};
345 345
346 if ((off + len > vif->hash.size) || copy_op.len > XEN_PAGE_SIZE) 346 if ((off + len < off) || (off + len > vif->hash.size) ||
347 len > XEN_PAGE_SIZE / sizeof(*mapping))
347 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER; 348 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER;
348 349
349 while (len-- != 0) 350 copy_op[0].dest.u.gmfn = virt_to_gfn(mapping + off);
350 if (mapping[off++] >= vif->num_queues) 351 copy_op[0].dest.offset = xen_offset_in_page(mapping + off);
351 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER; 352 if (copy_op[0].dest.offset + copy_op[0].len > XEN_PAGE_SIZE) {
353 copy_op[1] = copy_op[0];
354 copy_op[1].source.offset = XEN_PAGE_SIZE - copy_op[0].dest.offset;
355 copy_op[1].dest.u.gmfn = virt_to_gfn(mapping + off + len);
356 copy_op[1].dest.offset = 0;
357 copy_op[1].len = copy_op[0].len - copy_op[1].source.offset;
358 copy_op[0].len = copy_op[1].source.offset;
359 nr = 2;
360 }
352 361
353 if (copy_op.len != 0) { 362 memcpy(mapping, vif->hash.mapping[vif->hash.mapping_sel],
354 gnttab_batch_copy(&copy_op, 1); 363 vif->hash.size * sizeof(*mapping));
355 364
356 if (copy_op.status != GNTST_okay) 365 if (copy_op[0].len != 0) {
366 gnttab_batch_copy(copy_op, nr);
367
368 if (copy_op[0].status != GNTST_okay ||
369 copy_op[nr - 1].status != GNTST_okay)
357 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER; 370 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER;
358 } 371 }
359 372
373 while (len-- != 0)
374 if (mapping[off++] >= vif->num_queues)
375 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER;
376
377 vif->hash.mapping_sel = !vif->hash.mapping_sel;
378
360 return XEN_NETIF_CTRL_STATUS_SUCCESS; 379 return XEN_NETIF_CTRL_STATUS_SUCCESS;
361} 380}
362 381
@@ -408,6 +427,8 @@ void xenvif_dump_hash_info(struct xenvif *vif, struct seq_file *m)
408 } 427 }
409 428
410 if (vif->hash.size != 0) { 429 if (vif->hash.size != 0) {
430 const u32 *mapping = vif->hash.mapping[vif->hash.mapping_sel];
431
411 seq_puts(m, "\nHash Mapping:\n"); 432 seq_puts(m, "\nHash Mapping:\n");
412 433
413 for (i = 0; i < vif->hash.size; ) { 434 for (i = 0; i < vif->hash.size; ) {
@@ -420,7 +441,7 @@ void xenvif_dump_hash_info(struct xenvif *vif, struct seq_file *m)
420 seq_printf(m, "[%4u - %4u]: ", i, i + n - 1); 441 seq_printf(m, "[%4u - %4u]: ", i, i + n - 1);
421 442
422 for (j = 0; j < n; j++, i++) 443 for (j = 0; j < n; j++, i++)
423 seq_printf(m, "%4u ", vif->hash.mapping[i]); 444 seq_printf(m, "%4u ", mapping[i]);
424 445
425 seq_puts(m, "\n"); 446 seq_puts(m, "\n");
426 } 447 }
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 92274c237200..f6ae23fc3f6b 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -162,7 +162,8 @@ static u16 xenvif_select_queue(struct net_device *dev, struct sk_buff *skb,
162 if (size == 0) 162 if (size == 0)
163 return skb_get_hash_raw(skb) % dev->real_num_tx_queues; 163 return skb_get_hash_raw(skb) % dev->real_num_tx_queues;
164 164
165 return vif->hash.mapping[skb_get_hash_raw(skb) % size]; 165 return vif->hash.mapping[vif->hash.mapping_sel]
166 [skb_get_hash_raw(skb) % size];
166} 167}
167 168
168static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev) 169static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 73f596a90c69..f17f602e6171 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -87,8 +87,7 @@ struct netfront_cb {
87/* IRQ name is queue name with "-tx" or "-rx" appended */ 87/* IRQ name is queue name with "-tx" or "-rx" appended */
88#define IRQ_NAME_SIZE (QUEUE_NAME_SIZE + 3) 88#define IRQ_NAME_SIZE (QUEUE_NAME_SIZE + 3)
89 89
90static DECLARE_WAIT_QUEUE_HEAD(module_load_q); 90static DECLARE_WAIT_QUEUE_HEAD(module_wq);
91static DECLARE_WAIT_QUEUE_HEAD(module_unload_q);
92 91
93struct netfront_stats { 92struct netfront_stats {
94 u64 packets; 93 u64 packets;
@@ -909,7 +908,11 @@ static RING_IDX xennet_fill_frags(struct netfront_queue *queue,
909 BUG_ON(pull_to <= skb_headlen(skb)); 908 BUG_ON(pull_to <= skb_headlen(skb));
910 __pskb_pull_tail(skb, pull_to - skb_headlen(skb)); 909 __pskb_pull_tail(skb, pull_to - skb_headlen(skb));
911 } 910 }
912 BUG_ON(skb_shinfo(skb)->nr_frags >= MAX_SKB_FRAGS); 911 if (unlikely(skb_shinfo(skb)->nr_frags >= MAX_SKB_FRAGS)) {
912 queue->rx.rsp_cons = ++cons;
913 kfree_skb(nskb);
914 return ~0U;
915 }
913 916
914 skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, 917 skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
915 skb_frag_page(nfrag), 918 skb_frag_page(nfrag),
@@ -1046,6 +1049,8 @@ err:
1046 skb->len += rx->status; 1049 skb->len += rx->status;
1047 1050
1048 i = xennet_fill_frags(queue, skb, &tmpq); 1051 i = xennet_fill_frags(queue, skb, &tmpq);
1052 if (unlikely(i == ~0U))
1053 goto err;
1049 1054
1050 if (rx->flags & XEN_NETRXF_csum_blank) 1055 if (rx->flags & XEN_NETRXF_csum_blank)
1051 skb->ip_summed = CHECKSUM_PARTIAL; 1056 skb->ip_summed = CHECKSUM_PARTIAL;
@@ -1332,11 +1337,11 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
1332 netif_carrier_off(netdev); 1337 netif_carrier_off(netdev);
1333 1338
1334 xenbus_switch_state(dev, XenbusStateInitialising); 1339 xenbus_switch_state(dev, XenbusStateInitialising);
1335 wait_event(module_load_q, 1340 wait_event(module_wq,
1336 xenbus_read_driver_state(dev->otherend) != 1341 xenbus_read_driver_state(dev->otherend) !=
1337 XenbusStateClosed && 1342 XenbusStateClosed &&
1338 xenbus_read_driver_state(dev->otherend) != 1343 xenbus_read_driver_state(dev->otherend) !=
1339 XenbusStateUnknown); 1344 XenbusStateUnknown);
1340 return netdev; 1345 return netdev;
1341 1346
1342 exit: 1347 exit:
@@ -2010,15 +2015,14 @@ static void netback_changed(struct xenbus_device *dev,
2010 2015
2011 dev_dbg(&dev->dev, "%s\n", xenbus_strstate(backend_state)); 2016 dev_dbg(&dev->dev, "%s\n", xenbus_strstate(backend_state));
2012 2017
2018 wake_up_all(&module_wq);
2019
2013 switch (backend_state) { 2020 switch (backend_state) {
2014 case XenbusStateInitialising: 2021 case XenbusStateInitialising:
2015 case XenbusStateInitialised: 2022 case XenbusStateInitialised:
2016 case XenbusStateReconfiguring: 2023 case XenbusStateReconfiguring:
2017 case XenbusStateReconfigured: 2024 case XenbusStateReconfigured:
2018 break;
2019
2020 case XenbusStateUnknown: 2025 case XenbusStateUnknown:
2021 wake_up_all(&module_unload_q);
2022 break; 2026 break;
2023 2027
2024 case XenbusStateInitWait: 2028 case XenbusStateInitWait:
@@ -2034,12 +2038,10 @@ static void netback_changed(struct xenbus_device *dev,
2034 break; 2038 break;
2035 2039
2036 case XenbusStateClosed: 2040 case XenbusStateClosed:
2037 wake_up_all(&module_unload_q);
2038 if (dev->state == XenbusStateClosed) 2041 if (dev->state == XenbusStateClosed)
2039 break; 2042 break;
2040 /* Missed the backend's CLOSING state -- fallthrough */ 2043 /* Missed the backend's CLOSING state -- fallthrough */
2041 case XenbusStateClosing: 2044 case XenbusStateClosing:
2042 wake_up_all(&module_unload_q);
2043 xenbus_frontend_closed(dev); 2045 xenbus_frontend_closed(dev);
2044 break; 2046 break;
2045 } 2047 }
@@ -2147,14 +2149,14 @@ static int xennet_remove(struct xenbus_device *dev)
2147 2149
2148 if (xenbus_read_driver_state(dev->otherend) != XenbusStateClosed) { 2150 if (xenbus_read_driver_state(dev->otherend) != XenbusStateClosed) {
2149 xenbus_switch_state(dev, XenbusStateClosing); 2151 xenbus_switch_state(dev, XenbusStateClosing);
2150 wait_event(module_unload_q, 2152 wait_event(module_wq,
2151 xenbus_read_driver_state(dev->otherend) == 2153 xenbus_read_driver_state(dev->otherend) ==
2152 XenbusStateClosing || 2154 XenbusStateClosing ||
2153 xenbus_read_driver_state(dev->otherend) == 2155 xenbus_read_driver_state(dev->otherend) ==
2154 XenbusStateUnknown); 2156 XenbusStateUnknown);
2155 2157
2156 xenbus_switch_state(dev, XenbusStateClosed); 2158 xenbus_switch_state(dev, XenbusStateClosed);
2157 wait_event(module_unload_q, 2159 wait_event(module_wq,
2158 xenbus_read_driver_state(dev->otherend) == 2160 xenbus_read_driver_state(dev->otherend) ==
2159 XenbusStateClosed || 2161 XenbusStateClosed ||
2160 xenbus_read_driver_state(dev->otherend) == 2162 xenbus_read_driver_state(dev->otherend) ==
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 5a9562881d4e..9fe3fff818b8 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -537,8 +537,10 @@ int nvme_mpath_init(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
537 537
538 INIT_WORK(&ctrl->ana_work, nvme_ana_work); 538 INIT_WORK(&ctrl->ana_work, nvme_ana_work);
539 ctrl->ana_log_buf = kmalloc(ctrl->ana_log_size, GFP_KERNEL); 539 ctrl->ana_log_buf = kmalloc(ctrl->ana_log_size, GFP_KERNEL);
540 if (!ctrl->ana_log_buf) 540 if (!ctrl->ana_log_buf) {
541 error = -ENOMEM;
541 goto out; 542 goto out;
543 }
542 544
543 error = nvme_read_ana_log(ctrl, true); 545 error = nvme_read_ana_log(ctrl, true);
544 if (error) 546 if (error)
@@ -547,7 +549,7 @@ int nvme_mpath_init(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
547out_free_ana_log_buf: 549out_free_ana_log_buf:
548 kfree(ctrl->ana_log_buf); 550 kfree(ctrl->ana_log_buf);
549out: 551out:
550 return -ENOMEM; 552 return error;
551} 553}
552 554
553void nvme_mpath_uninit(struct nvme_ctrl *ctrl) 555void nvme_mpath_uninit(struct nvme_ctrl *ctrl)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index a21caea1e080..2008fa62a373 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -245,6 +245,10 @@ static void nvmet_execute_get_log_page_ana(struct nvmet_req *req)
245 offset += len; 245 offset += len;
246 ngrps++; 246 ngrps++;
247 } 247 }
248 for ( ; grpid <= NVMET_MAX_ANAGRPS; grpid++) {
249 if (nvmet_ana_group_enabled[grpid])
250 ngrps++;
251 }
248 252
249 hdr.chgcnt = cpu_to_le64(nvmet_ana_chgcnt); 253 hdr.chgcnt = cpu_to_le64(nvmet_ana_chgcnt);
250 hdr.ngrps = cpu_to_le16(ngrps); 254 hdr.ngrps = cpu_to_le16(ngrps);
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 3533e918ea37..bfc4da660bb4 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -66,6 +66,7 @@ struct nvmet_rdma_rsp {
66 66
67 struct nvmet_req req; 67 struct nvmet_req req;
68 68
69 bool allocated;
69 u8 n_rdma; 70 u8 n_rdma;
70 u32 flags; 71 u32 flags;
71 u32 invalidate_rkey; 72 u32 invalidate_rkey;
@@ -174,11 +175,19 @@ nvmet_rdma_get_rsp(struct nvmet_rdma_queue *queue)
174 unsigned long flags; 175 unsigned long flags;
175 176
176 spin_lock_irqsave(&queue->rsps_lock, flags); 177 spin_lock_irqsave(&queue->rsps_lock, flags);
177 rsp = list_first_entry(&queue->free_rsps, 178 rsp = list_first_entry_or_null(&queue->free_rsps,
178 struct nvmet_rdma_rsp, free_list); 179 struct nvmet_rdma_rsp, free_list);
179 list_del(&rsp->free_list); 180 if (likely(rsp))
181 list_del(&rsp->free_list);
180 spin_unlock_irqrestore(&queue->rsps_lock, flags); 182 spin_unlock_irqrestore(&queue->rsps_lock, flags);
181 183
184 if (unlikely(!rsp)) {
185 rsp = kmalloc(sizeof(*rsp), GFP_KERNEL);
186 if (unlikely(!rsp))
187 return NULL;
188 rsp->allocated = true;
189 }
190
182 return rsp; 191 return rsp;
183} 192}
184 193
@@ -187,6 +196,11 @@ nvmet_rdma_put_rsp(struct nvmet_rdma_rsp *rsp)
187{ 196{
188 unsigned long flags; 197 unsigned long flags;
189 198
199 if (rsp->allocated) {
200 kfree(rsp);
201 return;
202 }
203
190 spin_lock_irqsave(&rsp->queue->rsps_lock, flags); 204 spin_lock_irqsave(&rsp->queue->rsps_lock, flags);
191 list_add_tail(&rsp->free_list, &rsp->queue->free_rsps); 205 list_add_tail(&rsp->free_list, &rsp->queue->free_rsps);
192 spin_unlock_irqrestore(&rsp->queue->rsps_lock, flags); 206 spin_unlock_irqrestore(&rsp->queue->rsps_lock, flags);
@@ -776,6 +790,15 @@ static void nvmet_rdma_recv_done(struct ib_cq *cq, struct ib_wc *wc)
776 790
777 cmd->queue = queue; 791 cmd->queue = queue;
778 rsp = nvmet_rdma_get_rsp(queue); 792 rsp = nvmet_rdma_get_rsp(queue);
793 if (unlikely(!rsp)) {
794 /*
795 * we get here only under memory pressure,
796 * silently drop and have the host retry
797 * as we can't even fail it.
798 */
799 nvmet_rdma_post_recv(queue->dev, cmd);
800 return;
801 }
779 rsp->queue = queue; 802 rsp->queue = queue;
780 rsp->cmd = cmd; 803 rsp->cmd = cmd;
781 rsp->flags = 0; 804 rsp->flags = 0;
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 9095b8290150..74eaedd5b860 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -140,6 +140,9 @@ void of_populate_phandle_cache(void)
140 if (np->phandle && np->phandle != OF_PHANDLE_ILLEGAL) 140 if (np->phandle && np->phandle != OF_PHANDLE_ILLEGAL)
141 phandles++; 141 phandles++;
142 142
143 if (!phandles)
144 goto out;
145
143 cache_entries = roundup_pow_of_two(phandles); 146 cache_entries = roundup_pow_of_two(phandles);
144 phandle_cache_mask = cache_entries - 1; 147 phandle_cache_mask = cache_entries - 1;
145 148
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 722537e14848..41b49716ac75 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -771,6 +771,9 @@ static void __init of_unittest_parse_interrupts(void)
771 struct of_phandle_args args; 771 struct of_phandle_args args;
772 int i, rc; 772 int i, rc;
773 773
774 if (of_irq_workarounds & OF_IMAP_OLDWORLD_MAC)
775 return;
776
774 np = of_find_node_by_path("/testcase-data/interrupts/interrupts0"); 777 np = of_find_node_by_path("/testcase-data/interrupts/interrupts0");
775 if (!np) { 778 if (!np) {
776 pr_err("missing testcase data\n"); 779 pr_err("missing testcase data\n");
@@ -845,6 +848,9 @@ static void __init of_unittest_parse_interrupts_extended(void)
845 struct of_phandle_args args; 848 struct of_phandle_args args;
846 int i, rc; 849 int i, rc;
847 850
851 if (of_irq_workarounds & OF_IMAP_OLDWORLD_MAC)
852 return;
853
848 np = of_find_node_by_path("/testcase-data/interrupts/interrupts-extended0"); 854 np = of_find_node_by_path("/testcase-data/interrupts/interrupts-extended0");
849 if (!np) { 855 if (!np) {
850 pr_err("missing testcase data\n"); 856 pr_err("missing testcase data\n");
@@ -1001,15 +1007,19 @@ static void __init of_unittest_platform_populate(void)
1001 pdev = of_find_device_by_node(np); 1007 pdev = of_find_device_by_node(np);
1002 unittest(pdev, "device 1 creation failed\n"); 1008 unittest(pdev, "device 1 creation failed\n");
1003 1009
1004 irq = platform_get_irq(pdev, 0); 1010 if (!(of_irq_workarounds & OF_IMAP_OLDWORLD_MAC)) {
1005 unittest(irq == -EPROBE_DEFER, "device deferred probe failed - %d\n", irq); 1011 irq = platform_get_irq(pdev, 0);
1012 unittest(irq == -EPROBE_DEFER,
1013 "device deferred probe failed - %d\n", irq);
1006 1014
1007 /* Test that a parsing failure does not return -EPROBE_DEFER */ 1015 /* Test that a parsing failure does not return -EPROBE_DEFER */
1008 np = of_find_node_by_path("/testcase-data/testcase-device2"); 1016 np = of_find_node_by_path("/testcase-data/testcase-device2");
1009 pdev = of_find_device_by_node(np); 1017 pdev = of_find_device_by_node(np);
1010 unittest(pdev, "device 2 creation failed\n"); 1018 unittest(pdev, "device 2 creation failed\n");
1011 irq = platform_get_irq(pdev, 0); 1019 irq = platform_get_irq(pdev, 0);
1012 unittest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); 1020 unittest(irq < 0 && irq != -EPROBE_DEFER,
1021 "device parsing error failed - %d\n", irq);
1022 }
1013 1023
1014 np = of_find_node_by_path("/testcase-data/platform-tests"); 1024 np = of_find_node_by_path("/testcase-data/platform-tests");
1015 unittest(np, "No testcase data in device tree\n"); 1025 unittest(np, "No testcase data in device tree\n");
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 778c4f76a884..2153956a0b20 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -135,7 +135,7 @@ static void dw_pcie_prog_outbound_atu_unroll(struct dw_pcie *pci, int index,
135 if (val & PCIE_ATU_ENABLE) 135 if (val & PCIE_ATU_ENABLE)
136 return; 136 return;
137 137
138 usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX); 138 mdelay(LINK_WAIT_IATU);
139 } 139 }
140 dev_err(pci->dev, "Outbound iATU is not being enabled\n"); 140 dev_err(pci->dev, "Outbound iATU is not being enabled\n");
141} 141}
@@ -178,7 +178,7 @@ void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type,
178 if (val & PCIE_ATU_ENABLE) 178 if (val & PCIE_ATU_ENABLE)
179 return; 179 return;
180 180
181 usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX); 181 mdelay(LINK_WAIT_IATU);
182 } 182 }
183 dev_err(pci->dev, "Outbound iATU is not being enabled\n"); 183 dev_err(pci->dev, "Outbound iATU is not being enabled\n");
184} 184}
@@ -236,7 +236,7 @@ static int dw_pcie_prog_inbound_atu_unroll(struct dw_pcie *pci, int index,
236 if (val & PCIE_ATU_ENABLE) 236 if (val & PCIE_ATU_ENABLE)
237 return 0; 237 return 0;
238 238
239 usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX); 239 mdelay(LINK_WAIT_IATU);
240 } 240 }
241 dev_err(pci->dev, "Inbound iATU is not being enabled\n"); 241 dev_err(pci->dev, "Inbound iATU is not being enabled\n");
242 242
@@ -282,7 +282,7 @@ int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, int index, int bar,
282 if (val & PCIE_ATU_ENABLE) 282 if (val & PCIE_ATU_ENABLE)
283 return 0; 283 return 0;
284 284
285 usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX); 285 mdelay(LINK_WAIT_IATU);
286 } 286 }
287 dev_err(pci->dev, "Inbound iATU is not being enabled\n"); 287 dev_err(pci->dev, "Inbound iATU is not being enabled\n");
288 288
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index 96126fd8403c..9f1a5e399b70 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -26,8 +26,7 @@
26 26
27/* Parameters for the waiting for iATU enabled routine */ 27/* Parameters for the waiting for iATU enabled routine */
28#define LINK_WAIT_MAX_IATU_RETRIES 5 28#define LINK_WAIT_MAX_IATU_RETRIES 5
29#define LINK_WAIT_IATU_MIN 9000 29#define LINK_WAIT_IATU 9
30#define LINK_WAIT_IATU_MAX 10000
31 30
32/* Synopsys-specific PCIe configuration registers */ 31/* Synopsys-specific PCIe configuration registers */
33#define PCIE_PORT_LINK_CONTROL 0x710 32#define PCIE_PORT_LINK_CONTROL 0x710
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index c00f82cc54aa..9ba4d12c179c 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -89,6 +89,9 @@ static enum pci_protocol_version_t pci_protocol_version;
89 89
90#define STATUS_REVISION_MISMATCH 0xC0000059 90#define STATUS_REVISION_MISMATCH 0xC0000059
91 91
92/* space for 32bit serial number as string */
93#define SLOT_NAME_SIZE 11
94
92/* 95/*
93 * Message Types 96 * Message Types
94 */ 97 */
@@ -494,6 +497,7 @@ struct hv_pci_dev {
494 struct list_head list_entry; 497 struct list_head list_entry;
495 refcount_t refs; 498 refcount_t refs;
496 enum hv_pcichild_state state; 499 enum hv_pcichild_state state;
500 struct pci_slot *pci_slot;
497 struct pci_function_description desc; 501 struct pci_function_description desc;
498 bool reported_missing; 502 bool reported_missing;
499 struct hv_pcibus_device *hbus; 503 struct hv_pcibus_device *hbus;
@@ -1457,6 +1461,36 @@ static void prepopulate_bars(struct hv_pcibus_device *hbus)
1457 spin_unlock_irqrestore(&hbus->device_list_lock, flags); 1461 spin_unlock_irqrestore(&hbus->device_list_lock, flags);
1458} 1462}
1459 1463
1464/*
1465 * Assign entries in sysfs pci slot directory.
1466 *
1467 * Note that this function does not need to lock the children list
1468 * because it is called from pci_devices_present_work which
1469 * is serialized with hv_eject_device_work because they are on the
1470 * same ordered workqueue. Therefore hbus->children list will not change
1471 * even when pci_create_slot sleeps.
1472 */
1473static void hv_pci_assign_slots(struct hv_pcibus_device *hbus)
1474{
1475 struct hv_pci_dev *hpdev;
1476 char name[SLOT_NAME_SIZE];
1477 int slot_nr;
1478
1479 list_for_each_entry(hpdev, &hbus->children, list_entry) {
1480 if (hpdev->pci_slot)
1481 continue;
1482
1483 slot_nr = PCI_SLOT(wslot_to_devfn(hpdev->desc.win_slot.slot));
1484 snprintf(name, SLOT_NAME_SIZE, "%u", hpdev->desc.ser);
1485 hpdev->pci_slot = pci_create_slot(hbus->pci_bus, slot_nr,
1486 name, NULL);
1487 if (IS_ERR(hpdev->pci_slot)) {
1488 pr_warn("pci_create slot %s failed\n", name);
1489 hpdev->pci_slot = NULL;
1490 }
1491 }
1492}
1493
1460/** 1494/**
1461 * create_root_hv_pci_bus() - Expose a new root PCI bus 1495 * create_root_hv_pci_bus() - Expose a new root PCI bus
1462 * @hbus: Root PCI bus, as understood by this driver 1496 * @hbus: Root PCI bus, as understood by this driver
@@ -1480,6 +1514,7 @@ static int create_root_hv_pci_bus(struct hv_pcibus_device *hbus)
1480 pci_lock_rescan_remove(); 1514 pci_lock_rescan_remove();
1481 pci_scan_child_bus(hbus->pci_bus); 1515 pci_scan_child_bus(hbus->pci_bus);
1482 pci_bus_assign_resources(hbus->pci_bus); 1516 pci_bus_assign_resources(hbus->pci_bus);
1517 hv_pci_assign_slots(hbus);
1483 pci_bus_add_devices(hbus->pci_bus); 1518 pci_bus_add_devices(hbus->pci_bus);
1484 pci_unlock_rescan_remove(); 1519 pci_unlock_rescan_remove();
1485 hbus->state = hv_pcibus_installed; 1520 hbus->state = hv_pcibus_installed;
@@ -1742,6 +1777,7 @@ static void pci_devices_present_work(struct work_struct *work)
1742 */ 1777 */
1743 pci_lock_rescan_remove(); 1778 pci_lock_rescan_remove();
1744 pci_scan_child_bus(hbus->pci_bus); 1779 pci_scan_child_bus(hbus->pci_bus);
1780 hv_pci_assign_slots(hbus);
1745 pci_unlock_rescan_remove(); 1781 pci_unlock_rescan_remove();
1746 break; 1782 break;
1747 1783
@@ -1858,6 +1894,9 @@ static void hv_eject_device_work(struct work_struct *work)
1858 list_del(&hpdev->list_entry); 1894 list_del(&hpdev->list_entry);
1859 spin_unlock_irqrestore(&hpdev->hbus->device_list_lock, flags); 1895 spin_unlock_irqrestore(&hpdev->hbus->device_list_lock, flags);
1860 1896
1897 if (hpdev->pci_slot)
1898 pci_destroy_slot(hpdev->pci_slot);
1899
1861 memset(&ctxt, 0, sizeof(ctxt)); 1900 memset(&ctxt, 0, sizeof(ctxt));
1862 ejct_pkt = (struct pci_eject_response *)&ctxt.pkt.message; 1901 ejct_pkt = (struct pci_eject_response *)&ctxt.pkt.message;
1863 ejct_pkt->message_type.type = PCI_EJECTION_COMPLETE; 1902 ejct_pkt->message_type.type = PCI_EJECTION_COMPLETE;
diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
index 50eb0729385b..a41d79b8d46a 100644
--- a/drivers/pci/controller/pci-mvebu.c
+++ b/drivers/pci/controller/pci-mvebu.c
@@ -1145,7 +1145,6 @@ static int mvebu_pcie_parse_request_resources(struct mvebu_pcie *pcie)
1145{ 1145{
1146 struct device *dev = &pcie->pdev->dev; 1146 struct device *dev = &pcie->pdev->dev;
1147 struct device_node *np = dev->of_node; 1147 struct device_node *np = dev->of_node;
1148 unsigned int i;
1149 int ret; 1148 int ret;
1150 1149
1151 INIT_LIST_HEAD(&pcie->resources); 1150 INIT_LIST_HEAD(&pcie->resources);
@@ -1179,13 +1178,58 @@ static int mvebu_pcie_parse_request_resources(struct mvebu_pcie *pcie)
1179 resource_size(&pcie->io) - 1); 1178 resource_size(&pcie->io) - 1);
1180 pcie->realio.name = "PCI I/O"; 1179 pcie->realio.name = "PCI I/O";
1181 1180
1181 pci_add_resource(&pcie->resources, &pcie->realio);
1182 }
1183
1184 return devm_request_pci_bus_resources(dev, &pcie->resources);
1185}
1186
1187/*
1188 * This is a copy of pci_host_probe(), except that it does the I/O
1189 * remap as the last step, once we are sure we won't fail.
1190 *
1191 * It should be removed once the I/O remap error handling issue has
1192 * been sorted out.
1193 */
1194static int mvebu_pci_host_probe(struct pci_host_bridge *bridge)
1195{
1196 struct mvebu_pcie *pcie;
1197 struct pci_bus *bus, *child;
1198 int ret;
1199
1200 ret = pci_scan_root_bus_bridge(bridge);
1201 if (ret < 0) {
1202 dev_err(bridge->dev.parent, "Scanning root bridge failed");
1203 return ret;
1204 }
1205
1206 pcie = pci_host_bridge_priv(bridge);
1207 if (resource_size(&pcie->io) != 0) {
1208 unsigned int i;
1209
1182 for (i = 0; i < resource_size(&pcie->realio); i += SZ_64K) 1210 for (i = 0; i < resource_size(&pcie->realio); i += SZ_64K)
1183 pci_ioremap_io(i, pcie->io.start + i); 1211 pci_ioremap_io(i, pcie->io.start + i);
1212 }
1184 1213
1185 pci_add_resource(&pcie->resources, &pcie->realio); 1214 bus = bridge->bus;
1215
1216 /*
1217 * We insert PCI resources into the iomem_resource and
1218 * ioport_resource trees in either pci_bus_claim_resources()
1219 * or pci_bus_assign_resources().
1220 */
1221 if (pci_has_flag(PCI_PROBE_ONLY)) {
1222 pci_bus_claim_resources(bus);
1223 } else {
1224 pci_bus_size_bridges(bus);
1225 pci_bus_assign_resources(bus);
1226
1227 list_for_each_entry(child, &bus->children, node)
1228 pcie_bus_configure_settings(child);
1186 } 1229 }
1187 1230
1188 return devm_request_pci_bus_resources(dev, &pcie->resources); 1231 pci_bus_add_devices(bus);
1232 return 0;
1189} 1233}
1190 1234
1191static int mvebu_pcie_probe(struct platform_device *pdev) 1235static int mvebu_pcie_probe(struct platform_device *pdev)
@@ -1268,7 +1312,7 @@ static int mvebu_pcie_probe(struct platform_device *pdev)
1268 bridge->align_resource = mvebu_pcie_align_resource; 1312 bridge->align_resource = mvebu_pcie_align_resource;
1269 bridge->msi = pcie->msi; 1313 bridge->msi = pcie->msi;
1270 1314
1271 return pci_host_probe(bridge); 1315 return mvebu_pci_host_probe(bridge);
1272} 1316}
1273 1317
1274static const struct of_device_id mvebu_pcie_of_match_table[] = { 1318static const struct of_device_id mvebu_pcie_of_match_table[] = {
diff --git a/drivers/pci/controller/pcie-cadence.c b/drivers/pci/controller/pcie-cadence.c
index 86f1b002c846..975bcdd6b5c0 100644
--- a/drivers/pci/controller/pcie-cadence.c
+++ b/drivers/pci/controller/pcie-cadence.c
@@ -180,11 +180,11 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie)
180 return 0; 180 return 0;
181 } 181 }
182 182
183 phy = devm_kzalloc(dev, sizeof(*phy) * phy_count, GFP_KERNEL); 183 phy = devm_kcalloc(dev, phy_count, sizeof(*phy), GFP_KERNEL);
184 if (!phy) 184 if (!phy)
185 return -ENOMEM; 185 return -ENOMEM;
186 186
187 link = devm_kzalloc(dev, sizeof(*link) * phy_count, GFP_KERNEL); 187 link = devm_kcalloc(dev, phy_count, sizeof(*link), GFP_KERNEL);
188 if (!link) 188 if (!link)
189 return -ENOMEM; 189 return -ENOMEM;
190 190
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index ef0b1b6ba86f..12afa7fdf77e 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -457,17 +457,18 @@ static void acpiphp_native_scan_bridge(struct pci_dev *bridge)
457/** 457/**
458 * enable_slot - enable, configure a slot 458 * enable_slot - enable, configure a slot
459 * @slot: slot to be enabled 459 * @slot: slot to be enabled
460 * @bridge: true if enable is for the whole bridge (not a single slot)
460 * 461 *
461 * This function should be called per *physical slot*, 462 * This function should be called per *physical slot*,
462 * not per each slot object in ACPI namespace. 463 * not per each slot object in ACPI namespace.
463 */ 464 */
464static void enable_slot(struct acpiphp_slot *slot) 465static void enable_slot(struct acpiphp_slot *slot, bool bridge)
465{ 466{
466 struct pci_dev *dev; 467 struct pci_dev *dev;
467 struct pci_bus *bus = slot->bus; 468 struct pci_bus *bus = slot->bus;
468 struct acpiphp_func *func; 469 struct acpiphp_func *func;
469 470
470 if (bus->self && hotplug_is_native(bus->self)) { 471 if (bridge && bus->self && hotplug_is_native(bus->self)) {
471 /* 472 /*
472 * If native hotplug is used, it will take care of hotplug 473 * If native hotplug is used, it will take care of hotplug
473 * slot management and resource allocation for hotplug 474 * slot management and resource allocation for hotplug
@@ -701,7 +702,7 @@ static void acpiphp_check_bridge(struct acpiphp_bridge *bridge)
701 trim_stale_devices(dev); 702 trim_stale_devices(dev);
702 703
703 /* configure all functions */ 704 /* configure all functions */
704 enable_slot(slot); 705 enable_slot(slot, true);
705 } else { 706 } else {
706 disable_slot(slot); 707 disable_slot(slot);
707 } 708 }
@@ -785,7 +786,7 @@ static void hotplug_event(u32 type, struct acpiphp_context *context)
785 if (bridge) 786 if (bridge)
786 acpiphp_check_bridge(bridge); 787 acpiphp_check_bridge(bridge);
787 else if (!(slot->flags & SLOT_IS_GOING_AWAY)) 788 else if (!(slot->flags & SLOT_IS_GOING_AWAY))
788 enable_slot(slot); 789 enable_slot(slot, false);
789 790
790 break; 791 break;
791 792
@@ -973,7 +974,7 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot)
973 974
974 /* configure all functions */ 975 /* configure all functions */
975 if (!(slot->flags & SLOT_ENABLED)) 976 if (!(slot->flags & SLOT_ENABLED))
976 enable_slot(slot); 977 enable_slot(slot, false);
977 978
978 pci_unlock_rescan_remove(); 979 pci_unlock_rescan_remove();
979 return 0; 980 return 0;
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
index 7136e3430925..a938abdb41ce 100644
--- a/drivers/pci/hotplug/pciehp_hpc.c
+++ b/drivers/pci/hotplug/pciehp_hpc.c
@@ -496,7 +496,7 @@ int pciehp_power_on_slot(struct slot *slot)
496 u16 slot_status; 496 u16 slot_status;
497 int retval; 497 int retval;
498 498
499 /* Clear sticky power-fault bit from previous power failures */ 499 /* Clear power-fault bit from previous power failures */
500 pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); 500 pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status);
501 if (slot_status & PCI_EXP_SLTSTA_PFD) 501 if (slot_status & PCI_EXP_SLTSTA_PFD)
502 pcie_capability_write_word(pdev, PCI_EXP_SLTSTA, 502 pcie_capability_write_word(pdev, PCI_EXP_SLTSTA,
@@ -646,6 +646,14 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id)
646 pciehp_handle_button_press(slot); 646 pciehp_handle_button_press(slot);
647 } 647 }
648 648
649 /* Check Power Fault Detected */
650 if ((events & PCI_EXP_SLTSTA_PFD) && !ctrl->power_fault_detected) {
651 ctrl->power_fault_detected = 1;
652 ctrl_err(ctrl, "Slot(%s): Power fault\n", slot_name(slot));
653 pciehp_set_attention_status(slot, 1);
654 pciehp_green_led_off(slot);
655 }
656
649 /* 657 /*
650 * Disable requests have higher priority than Presence Detect Changed 658 * Disable requests have higher priority than Presence Detect Changed
651 * or Data Link Layer State Changed events. 659 * or Data Link Layer State Changed events.
@@ -657,14 +665,6 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id)
657 pciehp_handle_presence_or_link_change(slot, events); 665 pciehp_handle_presence_or_link_change(slot, events);
658 up_read(&ctrl->reset_lock); 666 up_read(&ctrl->reset_lock);
659 667
660 /* Check Power Fault Detected */
661 if ((events & PCI_EXP_SLTSTA_PFD) && !ctrl->power_fault_detected) {
662 ctrl->power_fault_detected = 1;
663 ctrl_err(ctrl, "Slot(%s): Power fault\n", slot_name(slot));
664 pciehp_set_attention_status(slot, 1);
665 pciehp_green_led_off(slot);
666 }
667
668 pci_config_pm_runtime_put(pdev); 668 pci_config_pm_runtime_put(pdev);
669 wake_up(&ctrl->requester); 669 wake_up(&ctrl->requester);
670 return IRQ_HANDLED; 670 return IRQ_HANDLED;
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 29ff9619b5fa..51b6c81671c1 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1289,12 +1289,12 @@ int pci_save_state(struct pci_dev *dev)
1289EXPORT_SYMBOL(pci_save_state); 1289EXPORT_SYMBOL(pci_save_state);
1290 1290
1291static void pci_restore_config_dword(struct pci_dev *pdev, int offset, 1291static void pci_restore_config_dword(struct pci_dev *pdev, int offset,
1292 u32 saved_val, int retry) 1292 u32 saved_val, int retry, bool force)
1293{ 1293{
1294 u32 val; 1294 u32 val;
1295 1295
1296 pci_read_config_dword(pdev, offset, &val); 1296 pci_read_config_dword(pdev, offset, &val);
1297 if (val == saved_val) 1297 if (!force && val == saved_val)
1298 return; 1298 return;
1299 1299
1300 for (;;) { 1300 for (;;) {
@@ -1313,25 +1313,36 @@ static void pci_restore_config_dword(struct pci_dev *pdev, int offset,
1313} 1313}
1314 1314
1315static void pci_restore_config_space_range(struct pci_dev *pdev, 1315static void pci_restore_config_space_range(struct pci_dev *pdev,
1316 int start, int end, int retry) 1316 int start, int end, int retry,
1317 bool force)
1317{ 1318{
1318 int index; 1319 int index;
1319 1320
1320 for (index = end; index >= start; index--) 1321 for (index = end; index >= start; index--)
1321 pci_restore_config_dword(pdev, 4 * index, 1322 pci_restore_config_dword(pdev, 4 * index,
1322 pdev->saved_config_space[index], 1323 pdev->saved_config_space[index],
1323 retry); 1324 retry, force);
1324} 1325}
1325 1326
1326static void pci_restore_config_space(struct pci_dev *pdev) 1327static void pci_restore_config_space(struct pci_dev *pdev)
1327{ 1328{
1328 if (pdev->hdr_type == PCI_HEADER_TYPE_NORMAL) { 1329 if (pdev->hdr_type == PCI_HEADER_TYPE_NORMAL) {
1329 pci_restore_config_space_range(pdev, 10, 15, 0); 1330 pci_restore_config_space_range(pdev, 10, 15, 0, false);
1330 /* Restore BARs before the command register. */ 1331 /* Restore BARs before the command register. */
1331 pci_restore_config_space_range(pdev, 4, 9, 10); 1332 pci_restore_config_space_range(pdev, 4, 9, 10, false);
1332 pci_restore_config_space_range(pdev, 0, 3, 0); 1333 pci_restore_config_space_range(pdev, 0, 3, 0, false);
1334 } else if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
1335 pci_restore_config_space_range(pdev, 12, 15, 0, false);
1336
1337 /*
1338 * Force rewriting of prefetch registers to avoid S3 resume
1339 * issues on Intel PCI bridges that occur when these
1340 * registers are not explicitly written.
1341 */
1342 pci_restore_config_space_range(pdev, 9, 11, 0, true);
1343 pci_restore_config_space_range(pdev, 0, 8, 0, false);
1333 } else { 1344 } else {
1334 pci_restore_config_space_range(pdev, 0, 15, 0); 1345 pci_restore_config_space_range(pdev, 0, 15, 0, false);
1335 } 1346 }
1336} 1347}
1337 1348
@@ -4547,6 +4558,7 @@ int pci_bridge_secondary_bus_reset(struct pci_dev *dev)
4547 4558
4548 return pci_dev_wait(dev, "bus reset", PCIE_RESET_READY_POLL_MS); 4559 return pci_dev_wait(dev, "bus reset", PCIE_RESET_READY_POLL_MS);
4549} 4560}
4561EXPORT_SYMBOL_GPL(pci_bridge_secondary_bus_reset);
4550 4562
4551static int pci_parent_bus_reset(struct pci_dev *dev, int probe) 4563static int pci_parent_bus_reset(struct pci_dev *dev, int probe)
4552{ 4564{
@@ -5200,7 +5212,7 @@ static int __pci_reset_bus(struct pci_bus *bus)
5200 */ 5212 */
5201int pci_reset_bus(struct pci_dev *pdev) 5213int pci_reset_bus(struct pci_dev *pdev)
5202{ 5214{
5203 return pci_probe_reset_slot(pdev->slot) ? 5215 return (!pci_probe_reset_slot(pdev->slot)) ?
5204 __pci_reset_slot(pdev->slot) : __pci_reset_bus(pdev->bus); 5216 __pci_reset_slot(pdev->slot) : __pci_reset_bus(pdev->bus);
5205} 5217}
5206EXPORT_SYMBOL_GPL(pci_reset_bus); 5218EXPORT_SYMBOL_GPL(pci_reset_bus);
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index ec784009a36b..201f9e5ff55c 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -2074,6 +2074,7 @@ static void pci_configure_eetlp_prefix(struct pci_dev *dev)
2074{ 2074{
2075#ifdef CONFIG_PCI_PASID 2075#ifdef CONFIG_PCI_PASID
2076 struct pci_dev *bridge; 2076 struct pci_dev *bridge;
2077 int pcie_type;
2077 u32 cap; 2078 u32 cap;
2078 2079
2079 if (!pci_is_pcie(dev)) 2080 if (!pci_is_pcie(dev))
@@ -2083,7 +2084,9 @@ static void pci_configure_eetlp_prefix(struct pci_dev *dev)
2083 if (!(cap & PCI_EXP_DEVCAP2_EE_PREFIX)) 2084 if (!(cap & PCI_EXP_DEVCAP2_EE_PREFIX))
2084 return; 2085 return;
2085 2086
2086 if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) 2087 pcie_type = pci_pcie_type(dev);
2088 if (pcie_type == PCI_EXP_TYPE_ROOT_PORT ||
2089 pcie_type == PCI_EXP_TYPE_RC_END)
2087 dev->eetlp_prefix_path = 1; 2090 dev->eetlp_prefix_path = 1;
2088 else { 2091 else {
2089 bridge = pci_upstream_bridge(dev); 2092 bridge = pci_upstream_bridge(dev);
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index ef7143a274e0..6bc27b7fd452 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4355,11 +4355,6 @@ static int pci_quirk_qcom_rp_acs(struct pci_dev *dev, u16 acs_flags)
4355 * 4355 *
4356 * 0x9d10-0x9d1b PCI Express Root port #{1-12} 4356 * 0x9d10-0x9d1b PCI Express Root port #{1-12}
4357 * 4357 *
4358 * The 300 series chipset suffers from the same bug so include those root
4359 * ports here as well.
4360 *
4361 * 0xa32c-0xa343 PCI Express Root port #{0-24}
4362 *
4363 * [1] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-2.html 4358 * [1] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-2.html
4364 * [2] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-1.html 4359 * [2] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-1.html
4365 * [3] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-spec-update.html 4360 * [3] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-spec-update.html
@@ -4377,7 +4372,6 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
4377 case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */ 4372 case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
4378 case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */ 4373 case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
4379 case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */ 4374 case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
4380 case 0xa32c ... 0xa343: /* 300 series */
4381 return true; 4375 return true;
4382 } 4376 }
4383 4377
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 9940cc70f38b..54a8b30dda38 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -14,6 +14,8 @@
14#include <linux/poll.h> 14#include <linux/poll.h>
15#include <linux/wait.h> 15#include <linux/wait.h>
16 16
17#include <linux/nospec.h>
18
17MODULE_DESCRIPTION("Microsemi Switchtec(tm) PCIe Management Driver"); 19MODULE_DESCRIPTION("Microsemi Switchtec(tm) PCIe Management Driver");
18MODULE_VERSION("0.1"); 20MODULE_VERSION("0.1");
19MODULE_LICENSE("GPL"); 21MODULE_LICENSE("GPL");
@@ -909,6 +911,8 @@ static int ioctl_port_to_pff(struct switchtec_dev *stdev,
909 default: 911 default:
910 if (p.port > ARRAY_SIZE(pcfg->dsp_pff_inst_id)) 912 if (p.port > ARRAY_SIZE(pcfg->dsp_pff_inst_id))
911 return -EINVAL; 913 return -EINVAL;
914 p.port = array_index_nospec(p.port,
915 ARRAY_SIZE(pcfg->dsp_pff_inst_id) + 1);
912 p.pff = ioread32(&pcfg->dsp_pff_inst_id[p.port - 1]); 916 p.pff = ioread32(&pcfg->dsp_pff_inst_id[p.port - 1]);
913 break; 917 break;
914 } 918 }
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 7f01f6f60b87..d0b7dd8fb184 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -485,7 +485,13 @@ static int armpmu_filter_match(struct perf_event *event)
485{ 485{
486 struct arm_pmu *armpmu = to_arm_pmu(event->pmu); 486 struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
487 unsigned int cpu = smp_processor_id(); 487 unsigned int cpu = smp_processor_id();
488 return cpumask_test_cpu(cpu, &armpmu->supported_cpus); 488 int ret;
489
490 ret = cpumask_test_cpu(cpu, &armpmu->supported_cpus);
491 if (ret && armpmu->filter_match)
492 return armpmu->filter_match(event);
493
494 return ret;
489} 495}
490 496
491static ssize_t armpmu_cpumask_show(struct device *dev, 497static ssize_t armpmu_cpumask_show(struct device *dev,
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
index ece41fb2848f..c4f4d904e4a6 100644
--- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c
+++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
@@ -1040,7 +1040,7 @@ static int madera_pin_probe(struct platform_device *pdev)
1040 } 1040 }
1041 1041
1042 /* if the configuration is provided through pdata, apply it */ 1042 /* if the configuration is provided through pdata, apply it */
1043 if (pdata) { 1043 if (pdata && pdata->gpio_configs) {
1044 ret = pinctrl_register_mappings(pdata->gpio_configs, 1044 ret = pinctrl_register_mappings(pdata->gpio_configs,
1045 pdata->n_gpio_configs); 1045 pdata->n_gpio_configs);
1046 if (ret) { 1046 if (ret) {
diff --git a/drivers/pinctrl/intel/pinctrl-cannonlake.c b/drivers/pinctrl/intel/pinctrl-cannonlake.c
index fb1afe55bf53..e7f45d96b0cb 100644
--- a/drivers/pinctrl/intel/pinctrl-cannonlake.c
+++ b/drivers/pinctrl/intel/pinctrl-cannonlake.c
@@ -15,10 +15,11 @@
15 15
16#include "pinctrl-intel.h" 16#include "pinctrl-intel.h"
17 17
18#define CNL_PAD_OWN 0x020 18#define CNL_PAD_OWN 0x020
19#define CNL_PADCFGLOCK 0x080 19#define CNL_PADCFGLOCK 0x080
20#define CNL_HOSTSW_OWN 0x0b0 20#define CNL_LP_HOSTSW_OWN 0x0b0
21#define CNL_GPI_IE 0x120 21#define CNL_H_HOSTSW_OWN 0x0c0
22#define CNL_GPI_IE 0x120
22 23
23#define CNL_GPP(r, s, e, g) \ 24#define CNL_GPP(r, s, e, g) \
24 { \ 25 { \
@@ -30,12 +31,12 @@
30 31
31#define CNL_NO_GPIO -1 32#define CNL_NO_GPIO -1
32 33
33#define CNL_COMMUNITY(b, s, e, g) \ 34#define CNL_COMMUNITY(b, s, e, o, g) \
34 { \ 35 { \
35 .barno = (b), \ 36 .barno = (b), \
36 .padown_offset = CNL_PAD_OWN, \ 37 .padown_offset = CNL_PAD_OWN, \
37 .padcfglock_offset = CNL_PADCFGLOCK, \ 38 .padcfglock_offset = CNL_PADCFGLOCK, \
38 .hostown_offset = CNL_HOSTSW_OWN, \ 39 .hostown_offset = (o), \
39 .ie_offset = CNL_GPI_IE, \ 40 .ie_offset = CNL_GPI_IE, \
40 .pin_base = (s), \ 41 .pin_base = (s), \
41 .npins = ((e) - (s) + 1), \ 42 .npins = ((e) - (s) + 1), \
@@ -43,6 +44,12 @@
43 .ngpps = ARRAY_SIZE(g), \ 44 .ngpps = ARRAY_SIZE(g), \
44 } 45 }
45 46
47#define CNLLP_COMMUNITY(b, s, e, g) \
48 CNL_COMMUNITY(b, s, e, CNL_LP_HOSTSW_OWN, g)
49
50#define CNLH_COMMUNITY(b, s, e, g) \
51 CNL_COMMUNITY(b, s, e, CNL_H_HOSTSW_OWN, g)
52
46/* Cannon Lake-H */ 53/* Cannon Lake-H */
47static const struct pinctrl_pin_desc cnlh_pins[] = { 54static const struct pinctrl_pin_desc cnlh_pins[] = {
48 /* GPP_A */ 55 /* GPP_A */
@@ -379,7 +386,7 @@ static const struct intel_padgroup cnlh_community1_gpps[] = {
379static const struct intel_padgroup cnlh_community3_gpps[] = { 386static const struct intel_padgroup cnlh_community3_gpps[] = {
380 CNL_GPP(0, 155, 178, 192), /* GPP_K */ 387 CNL_GPP(0, 155, 178, 192), /* GPP_K */
381 CNL_GPP(1, 179, 202, 224), /* GPP_H */ 388 CNL_GPP(1, 179, 202, 224), /* GPP_H */
382 CNL_GPP(2, 203, 215, 258), /* GPP_E */ 389 CNL_GPP(2, 203, 215, 256), /* GPP_E */
383 CNL_GPP(3, 216, 239, 288), /* GPP_F */ 390 CNL_GPP(3, 216, 239, 288), /* GPP_F */
384 CNL_GPP(4, 240, 248, CNL_NO_GPIO), /* SPI */ 391 CNL_GPP(4, 240, 248, CNL_NO_GPIO), /* SPI */
385}; 392};
@@ -442,10 +449,10 @@ static const struct intel_function cnlh_functions[] = {
442}; 449};
443 450
444static const struct intel_community cnlh_communities[] = { 451static const struct intel_community cnlh_communities[] = {
445 CNL_COMMUNITY(0, 0, 50, cnlh_community0_gpps), 452 CNLH_COMMUNITY(0, 0, 50, cnlh_community0_gpps),
446 CNL_COMMUNITY(1, 51, 154, cnlh_community1_gpps), 453 CNLH_COMMUNITY(1, 51, 154, cnlh_community1_gpps),
447 CNL_COMMUNITY(2, 155, 248, cnlh_community3_gpps), 454 CNLH_COMMUNITY(2, 155, 248, cnlh_community3_gpps),
448 CNL_COMMUNITY(3, 249, 298, cnlh_community4_gpps), 455 CNLH_COMMUNITY(3, 249, 298, cnlh_community4_gpps),
449}; 456};
450 457
451static const struct intel_pinctrl_soc_data cnlh_soc_data = { 458static const struct intel_pinctrl_soc_data cnlh_soc_data = {
@@ -803,9 +810,9 @@ static const struct intel_padgroup cnllp_community4_gpps[] = {
803}; 810};
804 811
805static const struct intel_community cnllp_communities[] = { 812static const struct intel_community cnllp_communities[] = {
806 CNL_COMMUNITY(0, 0, 67, cnllp_community0_gpps), 813 CNLLP_COMMUNITY(0, 0, 67, cnllp_community0_gpps),
807 CNL_COMMUNITY(1, 68, 180, cnllp_community1_gpps), 814 CNLLP_COMMUNITY(1, 68, 180, cnllp_community1_gpps),
808 CNL_COMMUNITY(2, 181, 243, cnllp_community4_gpps), 815 CNLLP_COMMUNITY(2, 181, 243, cnllp_community4_gpps),
809}; 816};
810 817
811static const struct intel_pinctrl_soc_data cnllp_soc_data = { 818static const struct intel_pinctrl_soc_data cnllp_soc_data = {
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 62b009b27eda..1ea3438ea67e 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -747,13 +747,63 @@ static const struct pinctrl_desc intel_pinctrl_desc = {
747 .owner = THIS_MODULE, 747 .owner = THIS_MODULE,
748}; 748};
749 749
750/**
751 * intel_gpio_to_pin() - Translate from GPIO offset to pin number
752 * @pctrl: Pinctrl structure
753 * @offset: GPIO offset from gpiolib
754 * @commmunity: Community is filled here if not %NULL
755 * @padgrp: Pad group is filled here if not %NULL
756 *
757 * When coming through gpiolib irqchip, the GPIO offset is not
758 * automatically translated to pinctrl pin number. This function can be
759 * used to find out the corresponding pinctrl pin.
760 */
761static int intel_gpio_to_pin(struct intel_pinctrl *pctrl, unsigned offset,
762 const struct intel_community **community,
763 const struct intel_padgroup **padgrp)
764{
765 int i;
766
767 for (i = 0; i < pctrl->ncommunities; i++) {
768 const struct intel_community *comm = &pctrl->communities[i];
769 int j;
770
771 for (j = 0; j < comm->ngpps; j++) {
772 const struct intel_padgroup *pgrp = &comm->gpps[j];
773
774 if (pgrp->gpio_base < 0)
775 continue;
776
777 if (offset >= pgrp->gpio_base &&
778 offset < pgrp->gpio_base + pgrp->size) {
779 int pin;
780
781 pin = pgrp->base + offset - pgrp->gpio_base;
782 if (community)
783 *community = comm;
784 if (padgrp)
785 *padgrp = pgrp;
786
787 return pin;
788 }
789 }
790 }
791
792 return -EINVAL;
793}
794
750static int intel_gpio_get(struct gpio_chip *chip, unsigned offset) 795static int intel_gpio_get(struct gpio_chip *chip, unsigned offset)
751{ 796{
752 struct intel_pinctrl *pctrl = gpiochip_get_data(chip); 797 struct intel_pinctrl *pctrl = gpiochip_get_data(chip);
753 void __iomem *reg; 798 void __iomem *reg;
754 u32 padcfg0; 799 u32 padcfg0;
800 int pin;
755 801
756 reg = intel_get_padcfg(pctrl, offset, PADCFG0); 802 pin = intel_gpio_to_pin(pctrl, offset, NULL, NULL);
803 if (pin < 0)
804 return -EINVAL;
805
806 reg = intel_get_padcfg(pctrl, pin, PADCFG0);
757 if (!reg) 807 if (!reg)
758 return -EINVAL; 808 return -EINVAL;
759 809
@@ -770,8 +820,13 @@ static void intel_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
770 unsigned long flags; 820 unsigned long flags;
771 void __iomem *reg; 821 void __iomem *reg;
772 u32 padcfg0; 822 u32 padcfg0;
823 int pin;
773 824
774 reg = intel_get_padcfg(pctrl, offset, PADCFG0); 825 pin = intel_gpio_to_pin(pctrl, offset, NULL, NULL);
826 if (pin < 0)
827 return;
828
829 reg = intel_get_padcfg(pctrl, pin, PADCFG0);
775 if (!reg) 830 if (!reg)
776 return; 831 return;
777 832
@@ -790,8 +845,13 @@ static int intel_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
790 struct intel_pinctrl *pctrl = gpiochip_get_data(chip); 845 struct intel_pinctrl *pctrl = gpiochip_get_data(chip);
791 void __iomem *reg; 846 void __iomem *reg;
792 u32 padcfg0; 847 u32 padcfg0;
848 int pin;
793 849
794 reg = intel_get_padcfg(pctrl, offset, PADCFG0); 850 pin = intel_gpio_to_pin(pctrl, offset, NULL, NULL);
851 if (pin < 0)
852 return -EINVAL;
853
854 reg = intel_get_padcfg(pctrl, pin, PADCFG0);
795 if (!reg) 855 if (!reg)
796 return -EINVAL; 856 return -EINVAL;
797 857
@@ -827,81 +887,6 @@ static const struct gpio_chip intel_gpio_chip = {
827 .set_config = gpiochip_generic_config, 887 .set_config = gpiochip_generic_config,
828}; 888};
829 889
830/**
831 * intel_gpio_to_pin() - Translate from GPIO offset to pin number
832 * @pctrl: Pinctrl structure
833 * @offset: GPIO offset from gpiolib
834 * @commmunity: Community is filled here if not %NULL
835 * @padgrp: Pad group is filled here if not %NULL
836 *
837 * When coming through gpiolib irqchip, the GPIO offset is not
838 * automatically translated to pinctrl pin number. This function can be
839 * used to find out the corresponding pinctrl pin.
840 */
841static int intel_gpio_to_pin(struct intel_pinctrl *pctrl, unsigned offset,
842 const struct intel_community **community,
843 const struct intel_padgroup **padgrp)
844{
845 int i;
846
847 for (i = 0; i < pctrl->ncommunities; i++) {
848 const struct intel_community *comm = &pctrl->communities[i];
849 int j;
850
851 for (j = 0; j < comm->ngpps; j++) {
852 const struct intel_padgroup *pgrp = &comm->gpps[j];
853
854 if (pgrp->gpio_base < 0)
855 continue;
856
857 if (offset >= pgrp->gpio_base &&
858 offset < pgrp->gpio_base + pgrp->size) {
859 int pin;
860
861 pin = pgrp->base + offset - pgrp->gpio_base;
862 if (community)
863 *community = comm;
864 if (padgrp)
865 *padgrp = pgrp;
866
867 return pin;
868 }
869 }
870 }
871
872 return -EINVAL;
873}
874
875static int intel_gpio_irq_reqres(struct irq_data *d)
876{
877 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
878 struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
879 int pin;
880 int ret;
881
882 pin = intel_gpio_to_pin(pctrl, irqd_to_hwirq(d), NULL, NULL);
883 if (pin >= 0) {
884 ret = gpiochip_lock_as_irq(gc, pin);
885 if (ret) {
886 dev_err(pctrl->dev, "unable to lock HW IRQ %d for IRQ\n",
887 pin);
888 return ret;
889 }
890 }
891 return 0;
892}
893
894static void intel_gpio_irq_relres(struct irq_data *d)
895{
896 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
897 struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
898 int pin;
899
900 pin = intel_gpio_to_pin(pctrl, irqd_to_hwirq(d), NULL, NULL);
901 if (pin >= 0)
902 gpiochip_unlock_as_irq(gc, pin);
903}
904
905static void intel_gpio_irq_ack(struct irq_data *d) 890static void intel_gpio_irq_ack(struct irq_data *d)
906{ 891{
907 struct gpio_chip *gc = irq_data_get_irq_chip_data(d); 892 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
@@ -1117,8 +1102,6 @@ static irqreturn_t intel_gpio_irq(int irq, void *data)
1117 1102
1118static struct irq_chip intel_gpio_irqchip = { 1103static struct irq_chip intel_gpio_irqchip = {
1119 .name = "intel-gpio", 1104 .name = "intel-gpio",
1120 .irq_request_resources = intel_gpio_irq_reqres,
1121 .irq_release_resources = intel_gpio_irq_relres,
1122 .irq_enable = intel_gpio_irq_enable, 1105 .irq_enable = intel_gpio_irq_enable,
1123 .irq_ack = intel_gpio_irq_ack, 1106 .irq_ack = intel_gpio_irq_ack,
1124 .irq_mask = intel_gpio_irq_mask, 1107 .irq_mask = intel_gpio_irq_mask,
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 41ccc759b8b8..1425c2874d40 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -348,21 +348,12 @@ static void amd_gpio_irq_enable(struct irq_data *d)
348 unsigned long flags; 348 unsigned long flags;
349 struct gpio_chip *gc = irq_data_get_irq_chip_data(d); 349 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
350 struct amd_gpio *gpio_dev = gpiochip_get_data(gc); 350 struct amd_gpio *gpio_dev = gpiochip_get_data(gc);
351 u32 mask = BIT(INTERRUPT_ENABLE_OFF) | BIT(INTERRUPT_MASK_OFF);
352 351
353 raw_spin_lock_irqsave(&gpio_dev->lock, flags); 352 raw_spin_lock_irqsave(&gpio_dev->lock, flags);
354 pin_reg = readl(gpio_dev->base + (d->hwirq)*4); 353 pin_reg = readl(gpio_dev->base + (d->hwirq)*4);
355 pin_reg |= BIT(INTERRUPT_ENABLE_OFF); 354 pin_reg |= BIT(INTERRUPT_ENABLE_OFF);
356 pin_reg |= BIT(INTERRUPT_MASK_OFF); 355 pin_reg |= BIT(INTERRUPT_MASK_OFF);
357 writel(pin_reg, gpio_dev->base + (d->hwirq)*4); 356 writel(pin_reg, gpio_dev->base + (d->hwirq)*4);
358 /*
359 * When debounce logic is enabled it takes ~900 us before interrupts
360 * can be enabled. During this "debounce warm up" period the
361 * "INTERRUPT_ENABLE" bit will read as 0. Poll the bit here until it
362 * reads back as 1, signaling that interrupts are now enabled.
363 */
364 while ((readl(gpio_dev->base + (d->hwirq)*4) & mask) != mask)
365 continue;
366 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags); 357 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
367} 358}
368 359
@@ -426,7 +417,7 @@ static void amd_gpio_irq_eoi(struct irq_data *d)
426static int amd_gpio_irq_set_type(struct irq_data *d, unsigned int type) 417static int amd_gpio_irq_set_type(struct irq_data *d, unsigned int type)
427{ 418{
428 int ret = 0; 419 int ret = 0;
429 u32 pin_reg; 420 u32 pin_reg, pin_reg_irq_en, mask;
430 unsigned long flags, irq_flags; 421 unsigned long flags, irq_flags;
431 struct gpio_chip *gc = irq_data_get_irq_chip_data(d); 422 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
432 struct amd_gpio *gpio_dev = gpiochip_get_data(gc); 423 struct amd_gpio *gpio_dev = gpiochip_get_data(gc);
@@ -495,6 +486,28 @@ static int amd_gpio_irq_set_type(struct irq_data *d, unsigned int type)
495 } 486 }
496 487
497 pin_reg |= CLR_INTR_STAT << INTERRUPT_STS_OFF; 488 pin_reg |= CLR_INTR_STAT << INTERRUPT_STS_OFF;
489 /*
490 * If WAKE_INT_MASTER_REG.MaskStsEn is set, a software write to the
491 * debounce registers of any GPIO will block wake/interrupt status
492 * generation for *all* GPIOs for a lenght of time that depends on
493 * WAKE_INT_MASTER_REG.MaskStsLength[11:0]. During this period the
494 * INTERRUPT_ENABLE bit will read as 0.
495 *
496 * We temporarily enable irq for the GPIO whose configuration is
497 * changing, and then wait for it to read back as 1 to know when
498 * debounce has settled and then disable the irq again.
499 * We do this polling with the spinlock held to ensure other GPIO
500 * access routines do not read an incorrect value for the irq enable
501 * bit of other GPIOs. We keep the GPIO masked while polling to avoid
502 * spurious irqs, and disable the irq again after polling.
503 */
504 mask = BIT(INTERRUPT_ENABLE_OFF);
505 pin_reg_irq_en = pin_reg;
506 pin_reg_irq_en |= mask;
507 pin_reg_irq_en &= ~BIT(INTERRUPT_MASK_OFF);
508 writel(pin_reg_irq_en, gpio_dev->base + (d->hwirq)*4);
509 while ((readl(gpio_dev->base + (d->hwirq)*4) & mask) != mask)
510 continue;
498 writel(pin_reg, gpio_dev->base + (d->hwirq)*4); 511 writel(pin_reg, gpio_dev->base + (d->hwirq)*4);
499 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags); 512 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
500 513
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index 6a1b6058b991..628817c40e3b 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -793,7 +793,7 @@ static int ingenic_pinctrl_probe(struct platform_device *pdev)
793 793
794 err = pinctrl_generic_add_group(jzpc->pctl, group->name, 794 err = pinctrl_generic_add_group(jzpc->pctl, group->name,
795 group->pins, group->num_pins, group->data); 795 group->pins, group->num_pins, group->data);
796 if (err) { 796 if (err < 0) {
797 dev_err(dev, "Failed to register group %s\n", 797 dev_err(dev, "Failed to register group %s\n",
798 group->name); 798 group->name);
799 return err; 799 return err;
@@ -806,7 +806,7 @@ static int ingenic_pinctrl_probe(struct platform_device *pdev)
806 err = pinmux_generic_add_function(jzpc->pctl, func->name, 806 err = pinmux_generic_add_function(jzpc->pctl, func->name,
807 func->group_names, func->num_group_names, 807 func->group_names, func->num_group_names,
808 func->data); 808 func->data);
809 if (err) { 809 if (err < 0) {
810 dev_err(dev, "Failed to register function %s\n", 810 dev_err(dev, "Failed to register function %s\n",
811 func->name); 811 func->name);
812 return err; 812 return err;
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index 4a8a8efadefa..cf73a403d22d 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -636,6 +636,14 @@ static int mcp23s08_irq_setup(struct mcp23s08 *mcp)
636 return err; 636 return err;
637 } 637 }
638 638
639 return 0;
640}
641
642static int mcp23s08_irqchip_setup(struct mcp23s08 *mcp)
643{
644 struct gpio_chip *chip = &mcp->chip;
645 int err;
646
639 err = gpiochip_irqchip_add_nested(chip, 647 err = gpiochip_irqchip_add_nested(chip,
640 &mcp23s08_irq_chip, 648 &mcp23s08_irq_chip,
641 0, 649 0,
@@ -912,7 +920,7 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
912 } 920 }
913 921
914 if (mcp->irq && mcp->irq_controller) { 922 if (mcp->irq && mcp->irq_controller) {
915 ret = mcp23s08_irq_setup(mcp); 923 ret = mcp23s08_irqchip_setup(mcp);
916 if (ret) 924 if (ret)
917 goto fail; 925 goto fail;
918 } 926 }
@@ -944,6 +952,9 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
944 goto fail; 952 goto fail;
945 } 953 }
946 954
955 if (mcp->irq)
956 ret = mcp23s08_irq_setup(mcp);
957
947fail: 958fail:
948 if (ret < 0) 959 if (ret < 0)
949 dev_dbg(dev, "can't setup chip %d, --> %d\n", addr, ret); 960 dev_dbg(dev, "can't setup chip %d, --> %d\n", addr, ret);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 2155a30c282b..5d72ffad32c2 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -634,6 +634,29 @@ static void msm_gpio_irq_mask(struct irq_data *d)
634 raw_spin_lock_irqsave(&pctrl->lock, flags); 634 raw_spin_lock_irqsave(&pctrl->lock, flags);
635 635
636 val = readl(pctrl->regs + g->intr_cfg_reg); 636 val = readl(pctrl->regs + g->intr_cfg_reg);
637 /*
638 * There are two bits that control interrupt forwarding to the CPU. The
639 * RAW_STATUS_EN bit causes the level or edge sensed on the line to be
640 * latched into the interrupt status register when the hardware detects
641 * an irq that it's configured for (either edge for edge type or level
642 * for level type irq). The 'non-raw' status enable bit causes the
643 * hardware to assert the summary interrupt to the CPU if the latched
644 * status bit is set. There's a bug though, the edge detection logic
645 * seems to have a problem where toggling the RAW_STATUS_EN bit may
646 * cause the status bit to latch spuriously when there isn't any edge
647 * so we can't touch that bit for edge type irqs and we have to keep
648 * the bit set anyway so that edges are latched while the line is masked.
649 *
650 * To make matters more complicated, leaving the RAW_STATUS_EN bit
651 * enabled all the time causes level interrupts to re-latch into the
652 * status register because the level is still present on the line after
653 * we ack it. We clear the raw status enable bit during mask here and
654 * set the bit on unmask so the interrupt can't latch into the hardware
655 * while it's masked.
656 */
657 if (irqd_get_trigger_type(d) & IRQ_TYPE_LEVEL_MASK)
658 val &= ~BIT(g->intr_raw_status_bit);
659
637 val &= ~BIT(g->intr_enable_bit); 660 val &= ~BIT(g->intr_enable_bit);
638 writel(val, pctrl->regs + g->intr_cfg_reg); 661 writel(val, pctrl->regs + g->intr_cfg_reg);
639 662
@@ -655,6 +678,7 @@ static void msm_gpio_irq_unmask(struct irq_data *d)
655 raw_spin_lock_irqsave(&pctrl->lock, flags); 678 raw_spin_lock_irqsave(&pctrl->lock, flags);
656 679
657 val = readl(pctrl->regs + g->intr_cfg_reg); 680 val = readl(pctrl->regs + g->intr_cfg_reg);
681 val |= BIT(g->intr_raw_status_bit);
658 val |= BIT(g->intr_enable_bit); 682 val |= BIT(g->intr_enable_bit);
659 writel(val, pctrl->regs + g->intr_cfg_reg); 683 writel(val, pctrl->regs + g->intr_cfg_reg);
660 684
diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index 398393ab5df8..b6fd4838f60f 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -520,7 +520,7 @@ static int get_next_event_xfer(struct cros_ec_device *ec_dev,
520 ret = cros_ec_cmd_xfer(ec_dev, msg); 520 ret = cros_ec_cmd_xfer(ec_dev, msg);
521 if (ret > 0) { 521 if (ret > 0) {
522 ec_dev->event_size = ret - 1; 522 ec_dev->event_size = ret - 1;
523 memcpy(&ec_dev->event_data, msg->data, ec_dev->event_size); 523 memcpy(&ec_dev->event_data, msg->data, ret);
524 } 524 }
525 525
526 return ret; 526 return ret;
diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
index d975462a4c57..f10af5c383c5 100644
--- a/drivers/platform/x86/alienware-wmi.c
+++ b/drivers/platform/x86/alienware-wmi.c
@@ -536,6 +536,7 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args,
536 if (obj && obj->type == ACPI_TYPE_INTEGER) 536 if (obj && obj->type == ACPI_TYPE_INTEGER)
537 *out_data = (u32) obj->integer.value; 537 *out_data = (u32) obj->integer.value;
538 } 538 }
539 kfree(output.pointer);
539 return status; 540 return status;
540 541
541} 542}
diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-smbios-wmi.c
index 88afe5651d24..cf2229ece9ff 100644
--- a/drivers/platform/x86/dell-smbios-wmi.c
+++ b/drivers/platform/x86/dell-smbios-wmi.c
@@ -78,6 +78,7 @@ static int run_smbios_call(struct wmi_device *wdev)
78 dev_dbg(&wdev->dev, "result: [%08x,%08x,%08x,%08x]\n", 78 dev_dbg(&wdev->dev, "result: [%08x,%08x,%08x,%08x]\n",
79 priv->buf->std.output[0], priv->buf->std.output[1], 79 priv->buf->std.output[0], priv->buf->std.output[1],
80 priv->buf->std.output[2], priv->buf->std.output[3]); 80 priv->buf->std.output[2], priv->buf->std.output[3]);
81 kfree(output.pointer);
81 82
82 return 0; 83 return 0;
83} 84}
diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
index 39d4100c60a2..7166f1cf8a1d 100644
--- a/drivers/platform/x86/intel_cht_int33fe.c
+++ b/drivers/platform/x86/intel_cht_int33fe.c
@@ -24,6 +24,7 @@
24#include <linux/i2c.h> 24#include <linux/i2c.h>
25#include <linux/interrupt.h> 25#include <linux/interrupt.h>
26#include <linux/module.h> 26#include <linux/module.h>
27#include <linux/platform_device.h>
27#include <linux/regulator/consumer.h> 28#include <linux/regulator/consumer.h>
28#include <linux/slab.h> 29#include <linux/slab.h>
29 30
@@ -88,9 +89,9 @@ static const struct property_entry fusb302_props[] = {
88 { } 89 { }
89}; 90};
90 91
91static int cht_int33fe_probe(struct i2c_client *client) 92static int cht_int33fe_probe(struct platform_device *pdev)
92{ 93{
93 struct device *dev = &client->dev; 94 struct device *dev = &pdev->dev;
94 struct i2c_board_info board_info; 95 struct i2c_board_info board_info;
95 struct cht_int33fe_data *data; 96 struct cht_int33fe_data *data;
96 struct i2c_client *max17047; 97 struct i2c_client *max17047;
@@ -206,7 +207,7 @@ static int cht_int33fe_probe(struct i2c_client *client)
206 if (!data->pi3usb30532) 207 if (!data->pi3usb30532)
207 goto out_unregister_fusb302; 208 goto out_unregister_fusb302;
208 209
209 i2c_set_clientdata(client, data); 210 platform_set_drvdata(pdev, data);
210 211
211 return 0; 212 return 0;
212 213
@@ -224,9 +225,9 @@ out_unregister_max17047:
224 return -EPROBE_DEFER; /* Wait for the i2c-adapter to load */ 225 return -EPROBE_DEFER; /* Wait for the i2c-adapter to load */
225} 226}
226 227
227static int cht_int33fe_remove(struct i2c_client *i2c) 228static int cht_int33fe_remove(struct platform_device *pdev)
228{ 229{
229 struct cht_int33fe_data *data = i2c_get_clientdata(i2c); 230 struct cht_int33fe_data *data = platform_get_drvdata(pdev);
230 231
231 i2c_unregister_device(data->pi3usb30532); 232 i2c_unregister_device(data->pi3usb30532);
232 i2c_unregister_device(data->fusb302); 233 i2c_unregister_device(data->fusb302);
@@ -240,29 +241,22 @@ static int cht_int33fe_remove(struct i2c_client *i2c)
240 return 0; 241 return 0;
241} 242}
242 243
243static const struct i2c_device_id cht_int33fe_i2c_id[] = {
244 { }
245};
246MODULE_DEVICE_TABLE(i2c, cht_int33fe_i2c_id);
247
248static const struct acpi_device_id cht_int33fe_acpi_ids[] = { 244static const struct acpi_device_id cht_int33fe_acpi_ids[] = {
249 { "INT33FE", }, 245 { "INT33FE", },
250 { } 246 { }
251}; 247};
252MODULE_DEVICE_TABLE(acpi, cht_int33fe_acpi_ids); 248MODULE_DEVICE_TABLE(acpi, cht_int33fe_acpi_ids);
253 249
254static struct i2c_driver cht_int33fe_driver = { 250static struct platform_driver cht_int33fe_driver = {
255 .driver = { 251 .driver = {
256 .name = "Intel Cherry Trail ACPI INT33FE driver", 252 .name = "Intel Cherry Trail ACPI INT33FE driver",
257 .acpi_match_table = ACPI_PTR(cht_int33fe_acpi_ids), 253 .acpi_match_table = ACPI_PTR(cht_int33fe_acpi_ids),
258 }, 254 },
259 .probe_new = cht_int33fe_probe, 255 .probe = cht_int33fe_probe,
260 .remove = cht_int33fe_remove, 256 .remove = cht_int33fe_remove,
261 .id_table = cht_int33fe_i2c_id,
262 .disable_i2c_core_irq_mapping = true,
263}; 257};
264 258
265module_i2c_driver(cht_int33fe_driver); 259module_platform_driver(cht_int33fe_driver);
266 260
267MODULE_DESCRIPTION("Intel Cherry Trail ACPI INT33FE pseudo device driver"); 261MODULE_DESCRIPTION("Intel Cherry Trail ACPI INT33FE pseudo device driver");
268MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); 262MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
diff --git a/drivers/regulator/bd71837-regulator.c b/drivers/regulator/bd71837-regulator.c
index 0f8ac8dec3e1..a1bd8aaf4d98 100644
--- a/drivers/regulator/bd71837-regulator.c
+++ b/drivers/regulator/bd71837-regulator.c
@@ -569,6 +569,25 @@ static int bd71837_probe(struct platform_device *pdev)
569 BD71837_REG_REGLOCK); 569 BD71837_REG_REGLOCK);
570 } 570 }
571 571
572 /*
573 * There is a HW quirk in BD71837. The shutdown sequence timings for
574 * bucks/LDOs which are controlled via register interface are changed.
575 * At PMIC poweroff the voltage for BUCK6/7 is cut immediately at the
576 * beginning of shut-down sequence. As bucks 6 and 7 are parent
577 * supplies for LDO5 and LDO6 - this causes LDO5/6 voltage
578 * monitoring to errorneously detect under voltage and force PMIC to
579 * emergency state instead of poweroff. In order to avoid this we
580 * disable voltage monitoring for LDO5 and LDO6
581 */
582 err = regmap_update_bits(pmic->mfd->regmap, BD718XX_REG_MVRFLTMASK2,
583 BD718XX_LDO5_VRMON80 | BD718XX_LDO6_VRMON80,
584 BD718XX_LDO5_VRMON80 | BD718XX_LDO6_VRMON80);
585 if (err) {
586 dev_err(&pmic->pdev->dev,
587 "Failed to disable voltage monitoring\n");
588 goto err;
589 }
590
572 for (i = 0; i < ARRAY_SIZE(pmic_regulator_inits); i++) { 591 for (i = 0; i < ARRAY_SIZE(pmic_regulator_inits); i++) {
573 592
574 struct regulator_desc *desc; 593 struct regulator_desc *desc;
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index bb1324f93143..9577d8941846 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3161,7 +3161,7 @@ static inline int regulator_suspend_toggle(struct regulator_dev *rdev,
3161 if (!rstate->changeable) 3161 if (!rstate->changeable)
3162 return -EPERM; 3162 return -EPERM;
3163 3163
3164 rstate->enabled = en; 3164 rstate->enabled = (en) ? ENABLE_IN_SUSPEND : DISABLE_IN_SUSPEND;
3165 3165
3166 return 0; 3166 return 0;
3167} 3167}
@@ -4395,13 +4395,13 @@ regulator_register(const struct regulator_desc *regulator_desc,
4395 !rdev->desc->fixed_uV) 4395 !rdev->desc->fixed_uV)
4396 rdev->is_switch = true; 4396 rdev->is_switch = true;
4397 4397
4398 dev_set_drvdata(&rdev->dev, rdev);
4398 ret = device_register(&rdev->dev); 4399 ret = device_register(&rdev->dev);
4399 if (ret != 0) { 4400 if (ret != 0) {
4400 put_device(&rdev->dev); 4401 put_device(&rdev->dev);
4401 goto unset_supplies; 4402 goto unset_supplies;
4402 } 4403 }
4403 4404
4404 dev_set_drvdata(&rdev->dev, rdev);
4405 rdev_init_debugfs(rdev); 4405 rdev_init_debugfs(rdev);
4406 4406
4407 /* try to resolve regulators supply since a new one was registered */ 4407 /* try to resolve regulators supply since a new one was registered */
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 638f17d4c848..210fc20f7de7 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -213,8 +213,6 @@ static void of_get_regulation_constraints(struct device_node *np,
213 else if (of_property_read_bool(suspend_np, 213 else if (of_property_read_bool(suspend_np,
214 "regulator-off-in-suspend")) 214 "regulator-off-in-suspend"))
215 suspend_state->enabled = DISABLE_IN_SUSPEND; 215 suspend_state->enabled = DISABLE_IN_SUSPEND;
216 else
217 suspend_state->enabled = DO_NOTHING_IN_SUSPEND;
218 216
219 if (!of_property_read_u32(np, "regulator-suspend-min-microvolt", 217 if (!of_property_read_u32(np, "regulator-suspend-min-microvolt",
220 &pval)) 218 &pval))
diff --git a/drivers/s390/char/sclp_early_core.c b/drivers/s390/char/sclp_early_core.c
index eceba3858cef..2f61f5579aa5 100644
--- a/drivers/s390/char/sclp_early_core.c
+++ b/drivers/s390/char/sclp_early_core.c
@@ -210,11 +210,11 @@ static int sclp_early_setup(int disable, int *have_linemode, int *have_vt220)
210 * Output one or more lines of text on the SCLP console (VT220 and / 210 * Output one or more lines of text on the SCLP console (VT220 and /
211 * or line-mode). 211 * or line-mode).
212 */ 212 */
213void __sclp_early_printk(const char *str, unsigned int len) 213void __sclp_early_printk(const char *str, unsigned int len, unsigned int force)
214{ 214{
215 int have_linemode, have_vt220; 215 int have_linemode, have_vt220;
216 216
217 if (sclp_init_state != sclp_init_state_uninitialized) 217 if (!force && sclp_init_state != sclp_init_state_uninitialized)
218 return; 218 return;
219 if (sclp_early_setup(0, &have_linemode, &have_vt220) != 0) 219 if (sclp_early_setup(0, &have_linemode, &have_vt220) != 0)
220 return; 220 return;
@@ -227,5 +227,10 @@ void __sclp_early_printk(const char *str, unsigned int len)
227 227
228void sclp_early_printk(const char *str) 228void sclp_early_printk(const char *str)
229{ 229{
230 __sclp_early_printk(str, strlen(str)); 230 __sclp_early_printk(str, strlen(str), 0);
231}
232
233void sclp_early_printk_force(const char *str)
234{
235 __sclp_early_printk(str, strlen(str), 1);
231} 236}
diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
index dbe7c7ac9ac8..fd77e46eb3b2 100644
--- a/drivers/s390/cio/vfio_ccw_cp.c
+++ b/drivers/s390/cio/vfio_ccw_cp.c
@@ -163,7 +163,7 @@ static bool pfn_array_table_iova_pinned(struct pfn_array_table *pat,
163 163
164 for (i = 0; i < pat->pat_nr; i++, pa++) 164 for (i = 0; i < pat->pat_nr; i++, pa++)
165 for (j = 0; j < pa->pa_nr; j++) 165 for (j = 0; j < pa->pa_nr; j++)
166 if (pa->pa_iova_pfn[i] == iova_pfn) 166 if (pa->pa_iova_pfn[j] == iova_pfn)
167 return true; 167 return true;
168 168
169 return false; 169 return false;
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 770fa9cfc310..f47d16b5810b 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -22,6 +22,7 @@
22#include "vfio_ccw_private.h" 22#include "vfio_ccw_private.h"
23 23
24struct workqueue_struct *vfio_ccw_work_q; 24struct workqueue_struct *vfio_ccw_work_q;
25struct kmem_cache *vfio_ccw_io_region;
25 26
26/* 27/*
27 * Helpers 28 * Helpers
@@ -79,7 +80,7 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work)
79 cp_update_scsw(&private->cp, &irb->scsw); 80 cp_update_scsw(&private->cp, &irb->scsw);
80 cp_free(&private->cp); 81 cp_free(&private->cp);
81 } 82 }
82 memcpy(private->io_region.irb_area, irb, sizeof(*irb)); 83 memcpy(private->io_region->irb_area, irb, sizeof(*irb));
83 84
84 if (private->io_trigger) 85 if (private->io_trigger)
85 eventfd_signal(private->io_trigger, 1); 86 eventfd_signal(private->io_trigger, 1);
@@ -114,6 +115,14 @@ static int vfio_ccw_sch_probe(struct subchannel *sch)
114 private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); 115 private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA);
115 if (!private) 116 if (!private)
116 return -ENOMEM; 117 return -ENOMEM;
118
119 private->io_region = kmem_cache_zalloc(vfio_ccw_io_region,
120 GFP_KERNEL | GFP_DMA);
121 if (!private->io_region) {
122 kfree(private);
123 return -ENOMEM;
124 }
125
117 private->sch = sch; 126 private->sch = sch;
118 dev_set_drvdata(&sch->dev, private); 127 dev_set_drvdata(&sch->dev, private);
119 128
@@ -139,6 +148,7 @@ out_disable:
139 cio_disable_subchannel(sch); 148 cio_disable_subchannel(sch);
140out_free: 149out_free:
141 dev_set_drvdata(&sch->dev, NULL); 150 dev_set_drvdata(&sch->dev, NULL);
151 kmem_cache_free(vfio_ccw_io_region, private->io_region);
142 kfree(private); 152 kfree(private);
143 return ret; 153 return ret;
144} 154}
@@ -153,6 +163,7 @@ static int vfio_ccw_sch_remove(struct subchannel *sch)
153 163
154 dev_set_drvdata(&sch->dev, NULL); 164 dev_set_drvdata(&sch->dev, NULL);
155 165
166 kmem_cache_free(vfio_ccw_io_region, private->io_region);
156 kfree(private); 167 kfree(private);
157 168
158 return 0; 169 return 0;
@@ -232,10 +243,20 @@ static int __init vfio_ccw_sch_init(void)
232 if (!vfio_ccw_work_q) 243 if (!vfio_ccw_work_q)
233 return -ENOMEM; 244 return -ENOMEM;
234 245
246 vfio_ccw_io_region = kmem_cache_create_usercopy("vfio_ccw_io_region",
247 sizeof(struct ccw_io_region), 0,
248 SLAB_ACCOUNT, 0,
249 sizeof(struct ccw_io_region), NULL);
250 if (!vfio_ccw_io_region) {
251 destroy_workqueue(vfio_ccw_work_q);
252 return -ENOMEM;
253 }
254
235 isc_register(VFIO_CCW_ISC); 255 isc_register(VFIO_CCW_ISC);
236 ret = css_driver_register(&vfio_ccw_sch_driver); 256 ret = css_driver_register(&vfio_ccw_sch_driver);
237 if (ret) { 257 if (ret) {
238 isc_unregister(VFIO_CCW_ISC); 258 isc_unregister(VFIO_CCW_ISC);
259 kmem_cache_destroy(vfio_ccw_io_region);
239 destroy_workqueue(vfio_ccw_work_q); 260 destroy_workqueue(vfio_ccw_work_q);
240 } 261 }
241 262
@@ -246,6 +267,7 @@ static void __exit vfio_ccw_sch_exit(void)
246{ 267{
247 css_driver_unregister(&vfio_ccw_sch_driver); 268 css_driver_unregister(&vfio_ccw_sch_driver);
248 isc_unregister(VFIO_CCW_ISC); 269 isc_unregister(VFIO_CCW_ISC);
270 kmem_cache_destroy(vfio_ccw_io_region);
249 destroy_workqueue(vfio_ccw_work_q); 271 destroy_workqueue(vfio_ccw_work_q);
250} 272}
251module_init(vfio_ccw_sch_init); 273module_init(vfio_ccw_sch_init);
diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c
index 797a82731159..f94aa01f9c36 100644
--- a/drivers/s390/cio/vfio_ccw_fsm.c
+++ b/drivers/s390/cio/vfio_ccw_fsm.c
@@ -93,13 +93,13 @@ static void fsm_io_error(struct vfio_ccw_private *private,
93 enum vfio_ccw_event event) 93 enum vfio_ccw_event event)
94{ 94{
95 pr_err("vfio-ccw: FSM: I/O request from state:%d\n", private->state); 95 pr_err("vfio-ccw: FSM: I/O request from state:%d\n", private->state);
96 private->io_region.ret_code = -EIO; 96 private->io_region->ret_code = -EIO;
97} 97}
98 98
99static void fsm_io_busy(struct vfio_ccw_private *private, 99static void fsm_io_busy(struct vfio_ccw_private *private,
100 enum vfio_ccw_event event) 100 enum vfio_ccw_event event)
101{ 101{
102 private->io_region.ret_code = -EBUSY; 102 private->io_region->ret_code = -EBUSY;
103} 103}
104 104
105static void fsm_disabled_irq(struct vfio_ccw_private *private, 105static void fsm_disabled_irq(struct vfio_ccw_private *private,
@@ -126,7 +126,7 @@ static void fsm_io_request(struct vfio_ccw_private *private,
126{ 126{
127 union orb *orb; 127 union orb *orb;
128 union scsw *scsw = &private->scsw; 128 union scsw *scsw = &private->scsw;
129 struct ccw_io_region *io_region = &private->io_region; 129 struct ccw_io_region *io_region = private->io_region;
130 struct mdev_device *mdev = private->mdev; 130 struct mdev_device *mdev = private->mdev;
131 char *errstr = "request"; 131 char *errstr = "request";
132 132
diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c
index 41eeb57d68a3..f673e106c041 100644
--- a/drivers/s390/cio/vfio_ccw_ops.c
+++ b/drivers/s390/cio/vfio_ccw_ops.c
@@ -174,7 +174,7 @@ static ssize_t vfio_ccw_mdev_read(struct mdev_device *mdev,
174 return -EINVAL; 174 return -EINVAL;
175 175
176 private = dev_get_drvdata(mdev_parent_dev(mdev)); 176 private = dev_get_drvdata(mdev_parent_dev(mdev));
177 region = &private->io_region; 177 region = private->io_region;
178 if (copy_to_user(buf, (void *)region + *ppos, count)) 178 if (copy_to_user(buf, (void *)region + *ppos, count))
179 return -EFAULT; 179 return -EFAULT;
180 180
@@ -196,7 +196,7 @@ static ssize_t vfio_ccw_mdev_write(struct mdev_device *mdev,
196 if (private->state != VFIO_CCW_STATE_IDLE) 196 if (private->state != VFIO_CCW_STATE_IDLE)
197 return -EACCES; 197 return -EACCES;
198 198
199 region = &private->io_region; 199 region = private->io_region;
200 if (copy_from_user((void *)region + *ppos, buf, count)) 200 if (copy_from_user((void *)region + *ppos, buf, count))
201 return -EFAULT; 201 return -EFAULT;
202 202
diff --git a/drivers/s390/cio/vfio_ccw_private.h b/drivers/s390/cio/vfio_ccw_private.h
index 78a66d96756b..078e46f9623d 100644
--- a/drivers/s390/cio/vfio_ccw_private.h
+++ b/drivers/s390/cio/vfio_ccw_private.h
@@ -41,7 +41,7 @@ struct vfio_ccw_private {
41 atomic_t avail; 41 atomic_t avail;
42 struct mdev_device *mdev; 42 struct mdev_device *mdev;
43 struct notifier_block nb; 43 struct notifier_block nb;
44 struct ccw_io_region io_region; 44 struct ccw_io_region *io_region;
45 45
46 struct channel_program cp; 46 struct channel_program cp;
47 struct irb irb; 47 struct irb irb;
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index ec891bc7d10a..f039266b275d 100644
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -872,8 +872,6 @@ static int hex2bitmap(const char *str, unsigned long *bitmap, int bits)
872 if (bits & 0x07) 872 if (bits & 0x07)
873 return -EINVAL; 873 return -EINVAL;
874 874
875 memset(bitmap, 0, bits / 8);
876
877 if (str[0] == '0' && str[1] == 'x') 875 if (str[0] == '0' && str[1] == 'x')
878 str++; 876 str++;
879 if (*str == 'x') 877 if (*str == 'x')
@@ -895,25 +893,23 @@ static int hex2bitmap(const char *str, unsigned long *bitmap, int bits)
895} 893}
896 894
897/* 895/*
898 * str2clrsetmasks() - parse bitmask argument and set the clear and 896 * modify_bitmap() - parse bitmask argument and modify an existing
899 * the set bitmap mask. A concatenation (done with ',') of these terms 897 * bit mask accordingly. A concatenation (done with ',') of these
900 * is recognized: 898 * terms is recognized:
901 * +<bitnr>[-<bitnr>] or -<bitnr>[-<bitnr>] 899 * +<bitnr>[-<bitnr>] or -<bitnr>[-<bitnr>]
902 * <bitnr> may be any valid number (hex, decimal or octal) in the range 900 * <bitnr> may be any valid number (hex, decimal or octal) in the range
903 * 0...bits-1; the leading + or - is required. Here are some examples: 901 * 0...bits-1; the leading + or - is required. Here are some examples:
904 * +0-15,+32,-128,-0xFF 902 * +0-15,+32,-128,-0xFF
905 * -0-255,+1-16,+0x128 903 * -0-255,+1-16,+0x128
906 * +1,+2,+3,+4,-5,-7-10 904 * +1,+2,+3,+4,-5,-7-10
907 * Returns a clear and a set bitmask. Every positive value in the string 905 * Returns the new bitmap after all changes have been applied. Every
908 * results in a bit set in the set mask and every negative value in the 906 * positive value in the string will set a bit and every negative value
909 * string results in a bit SET in the clear mask. As a bit may be touched 907 * in the string will clear a bit. As a bit may be touched more than once,
910 * more than once, the last 'operation' wins: +0-255,-128 = all but bit 908 * the last 'operation' wins:
911 * 128 set in the set mask, only bit 128 set in the clear mask. 909 * +0-255,-128 = first bits 0-255 will be set, then bit 128 will be
910 * cleared again. All other bits are unmodified.
912 */ 911 */
913static int str2clrsetmasks(const char *str, 912static int modify_bitmap(const char *str, unsigned long *bitmap, int bits)
914 unsigned long *clrmap,
915 unsigned long *setmap,
916 int bits)
917{ 913{
918 int a, i, z; 914 int a, i, z;
919 char *np, sign; 915 char *np, sign;
@@ -922,9 +918,6 @@ static int str2clrsetmasks(const char *str,
922 if (bits & 0x07) 918 if (bits & 0x07)
923 return -EINVAL; 919 return -EINVAL;
924 920
925 memset(clrmap, 0, bits / 8);
926 memset(setmap, 0, bits / 8);
927
928 while (*str) { 921 while (*str) {
929 sign = *str++; 922 sign = *str++;
930 if (sign != '+' && sign != '-') 923 if (sign != '+' && sign != '-')
@@ -940,13 +933,10 @@ static int str2clrsetmasks(const char *str,
940 str = np; 933 str = np;
941 } 934 }
942 for (i = a; i <= z; i++) 935 for (i = a; i <= z; i++)
943 if (sign == '+') { 936 if (sign == '+')
944 set_bit_inv(i, setmap); 937 set_bit_inv(i, bitmap);
945 clear_bit_inv(i, clrmap); 938 else
946 } else { 939 clear_bit_inv(i, bitmap);
947 clear_bit_inv(i, setmap);
948 set_bit_inv(i, clrmap);
949 }
950 while (*str == ',' || *str == '\n') 940 while (*str == ',' || *str == '\n')
951 str++; 941 str++;
952 } 942 }
@@ -970,44 +960,34 @@ static int process_mask_arg(const char *str,
970 unsigned long *bitmap, int bits, 960 unsigned long *bitmap, int bits,
971 struct mutex *lock) 961 struct mutex *lock)
972{ 962{
973 int i; 963 unsigned long *newmap, size;
964 int rc;
974 965
975 /* bits needs to be a multiple of 8 */ 966 /* bits needs to be a multiple of 8 */
976 if (bits & 0x07) 967 if (bits & 0x07)
977 return -EINVAL; 968 return -EINVAL;
978 969
970 size = BITS_TO_LONGS(bits)*sizeof(unsigned long);
971 newmap = kmalloc(size, GFP_KERNEL);
972 if (!newmap)
973 return -ENOMEM;
974 if (mutex_lock_interruptible(lock)) {
975 kfree(newmap);
976 return -ERESTARTSYS;
977 }
978
979 if (*str == '+' || *str == '-') { 979 if (*str == '+' || *str == '-') {
980 DECLARE_BITMAP(clrm, bits); 980 memcpy(newmap, bitmap, size);
981 DECLARE_BITMAP(setm, bits); 981 rc = modify_bitmap(str, newmap, bits);
982
983 i = str2clrsetmasks(str, clrm, setm, bits);
984 if (i)
985 return i;
986 if (mutex_lock_interruptible(lock))
987 return -ERESTARTSYS;
988 for (i = 0; i < bits; i++) {
989 if (test_bit_inv(i, clrm))
990 clear_bit_inv(i, bitmap);
991 if (test_bit_inv(i, setm))
992 set_bit_inv(i, bitmap);
993 }
994 } else { 982 } else {
995 DECLARE_BITMAP(setm, bits); 983 memset(newmap, 0, size);
996 984 rc = hex2bitmap(str, newmap, bits);
997 i = hex2bitmap(str, setm, bits);
998 if (i)
999 return i;
1000 if (mutex_lock_interruptible(lock))
1001 return -ERESTARTSYS;
1002 for (i = 0; i < bits; i++)
1003 if (test_bit_inv(i, setm))
1004 set_bit_inv(i, bitmap);
1005 else
1006 clear_bit_inv(i, bitmap);
1007 } 985 }
986 if (rc == 0)
987 memcpy(bitmap, newmap, size);
1008 mutex_unlock(lock); 988 mutex_unlock(lock);
1009 989 kfree(newmap);
1010 return 0; 990 return rc;
1011} 991}
1012 992
1013/* 993/*
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 49f64eb3eab0..ffce6f39828a 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -25,6 +25,7 @@
25#include <linux/netdevice.h> 25#include <linux/netdevice.h>
26#include <linux/netdev_features.h> 26#include <linux/netdev_features.h>
27#include <linux/skbuff.h> 27#include <linux/skbuff.h>
28#include <linux/vmalloc.h>
28 29
29#include <net/iucv/af_iucv.h> 30#include <net/iucv/af_iucv.h>
30#include <net/dsfield.h> 31#include <net/dsfield.h>
@@ -609,7 +610,7 @@ static void qeth_put_reply(struct qeth_reply *reply)
609static void qeth_issue_ipa_msg(struct qeth_ipa_cmd *cmd, int rc, 610static void qeth_issue_ipa_msg(struct qeth_ipa_cmd *cmd, int rc,
610 struct qeth_card *card) 611 struct qeth_card *card)
611{ 612{
612 char *ipa_name; 613 const char *ipa_name;
613 int com = cmd->hdr.command; 614 int com = cmd->hdr.command;
614 ipa_name = qeth_get_ipa_cmd_name(com); 615 ipa_name = qeth_get_ipa_cmd_name(com);
615 if (rc) 616 if (rc)
@@ -4699,7 +4700,7 @@ static int qeth_query_oat_command(struct qeth_card *card, char __user *udata)
4699 4700
4700 priv.buffer_len = oat_data.buffer_len; 4701 priv.buffer_len = oat_data.buffer_len;
4701 priv.response_len = 0; 4702 priv.response_len = 0;
4702 priv.buffer = kzalloc(oat_data.buffer_len, GFP_KERNEL); 4703 priv.buffer = vzalloc(oat_data.buffer_len);
4703 if (!priv.buffer) { 4704 if (!priv.buffer) {
4704 rc = -ENOMEM; 4705 rc = -ENOMEM;
4705 goto out; 4706 goto out;
@@ -4740,7 +4741,7 @@ static int qeth_query_oat_command(struct qeth_card *card, char __user *udata)
4740 rc = -EFAULT; 4741 rc = -EFAULT;
4741 4742
4742out_free: 4743out_free:
4743 kfree(priv.buffer); 4744 vfree(priv.buffer);
4744out: 4745out:
4745 return rc; 4746 return rc;
4746} 4747}
@@ -5706,6 +5707,8 @@ static struct net_device *qeth_alloc_netdev(struct qeth_card *card)
5706 dev->priv_flags &= ~IFF_TX_SKB_SHARING; 5707 dev->priv_flags &= ~IFF_TX_SKB_SHARING;
5707 dev->hw_features |= NETIF_F_SG; 5708 dev->hw_features |= NETIF_F_SG;
5708 dev->vlan_features |= NETIF_F_SG; 5709 dev->vlan_features |= NETIF_F_SG;
5710 if (IS_IQD(card))
5711 dev->features |= NETIF_F_SG;
5709 } 5712 }
5710 5713
5711 return dev; 5714 return dev;
@@ -5768,8 +5771,10 @@ static int qeth_core_probe_device(struct ccwgroup_device *gdev)
5768 qeth_update_from_chp_desc(card); 5771 qeth_update_from_chp_desc(card);
5769 5772
5770 card->dev = qeth_alloc_netdev(card); 5773 card->dev = qeth_alloc_netdev(card);
5771 if (!card->dev) 5774 if (!card->dev) {
5775 rc = -ENOMEM;
5772 goto err_card; 5776 goto err_card;
5777 }
5773 5778
5774 qeth_determine_capabilities(card); 5779 qeth_determine_capabilities(card);
5775 enforced_disc = qeth_enforce_discipline(card); 5780 enforced_disc = qeth_enforce_discipline(card);
diff --git a/drivers/s390/net/qeth_core_mpc.c b/drivers/s390/net/qeth_core_mpc.c
index 5bcb8dafc3ee..e891c0b52f4c 100644
--- a/drivers/s390/net/qeth_core_mpc.c
+++ b/drivers/s390/net/qeth_core_mpc.c
@@ -148,10 +148,10 @@ EXPORT_SYMBOL_GPL(IPA_PDU_HEADER);
148 148
149struct ipa_rc_msg { 149struct ipa_rc_msg {
150 enum qeth_ipa_return_codes rc; 150 enum qeth_ipa_return_codes rc;
151 char *msg; 151 const char *msg;
152}; 152};
153 153
154static struct ipa_rc_msg qeth_ipa_rc_msg[] = { 154static const struct ipa_rc_msg qeth_ipa_rc_msg[] = {
155 {IPA_RC_SUCCESS, "success"}, 155 {IPA_RC_SUCCESS, "success"},
156 {IPA_RC_NOTSUPP, "Command not supported"}, 156 {IPA_RC_NOTSUPP, "Command not supported"},
157 {IPA_RC_IP_TABLE_FULL, "Add Addr IP Table Full - ipv6"}, 157 {IPA_RC_IP_TABLE_FULL, "Add Addr IP Table Full - ipv6"},
@@ -219,23 +219,23 @@ static struct ipa_rc_msg qeth_ipa_rc_msg[] = {
219 219
220 220
221 221
222char *qeth_get_ipa_msg(enum qeth_ipa_return_codes rc) 222const char *qeth_get_ipa_msg(enum qeth_ipa_return_codes rc)
223{ 223{
224 int x = 0; 224 int x;
225 qeth_ipa_rc_msg[sizeof(qeth_ipa_rc_msg) / 225
226 sizeof(struct ipa_rc_msg) - 1].rc = rc; 226 for (x = 0; x < ARRAY_SIZE(qeth_ipa_rc_msg) - 1; x++)
227 while (qeth_ipa_rc_msg[x].rc != rc) 227 if (qeth_ipa_rc_msg[x].rc == rc)
228 x++; 228 return qeth_ipa_rc_msg[x].msg;
229 return qeth_ipa_rc_msg[x].msg; 229 return qeth_ipa_rc_msg[x].msg;
230} 230}
231 231
232 232
233struct ipa_cmd_names { 233struct ipa_cmd_names {
234 enum qeth_ipa_cmds cmd; 234 enum qeth_ipa_cmds cmd;
235 char *name; 235 const char *name;
236}; 236};
237 237
238static struct ipa_cmd_names qeth_ipa_cmd_names[] = { 238static const struct ipa_cmd_names qeth_ipa_cmd_names[] = {
239 {IPA_CMD_STARTLAN, "startlan"}, 239 {IPA_CMD_STARTLAN, "startlan"},
240 {IPA_CMD_STOPLAN, "stoplan"}, 240 {IPA_CMD_STOPLAN, "stoplan"},
241 {IPA_CMD_SETVMAC, "setvmac"}, 241 {IPA_CMD_SETVMAC, "setvmac"},
@@ -267,13 +267,12 @@ static struct ipa_cmd_names qeth_ipa_cmd_names[] = {
267 {IPA_CMD_UNKNOWN, "unknown"}, 267 {IPA_CMD_UNKNOWN, "unknown"},
268}; 268};
269 269
270char *qeth_get_ipa_cmd_name(enum qeth_ipa_cmds cmd) 270const char *qeth_get_ipa_cmd_name(enum qeth_ipa_cmds cmd)
271{ 271{
272 int x = 0; 272 int x;
273 qeth_ipa_cmd_names[ 273
274 sizeof(qeth_ipa_cmd_names) / 274 for (x = 0; x < ARRAY_SIZE(qeth_ipa_cmd_names) - 1; x++)
275 sizeof(struct ipa_cmd_names)-1].cmd = cmd; 275 if (qeth_ipa_cmd_names[x].cmd == cmd)
276 while (qeth_ipa_cmd_names[x].cmd != cmd) 276 return qeth_ipa_cmd_names[x].name;
277 x++;
278 return qeth_ipa_cmd_names[x].name; 277 return qeth_ipa_cmd_names[x].name;
279} 278}
diff --git a/drivers/s390/net/qeth_core_mpc.h b/drivers/s390/net/qeth_core_mpc.h
index aa8b9196b089..aa5de1fe01e1 100644
--- a/drivers/s390/net/qeth_core_mpc.h
+++ b/drivers/s390/net/qeth_core_mpc.h
@@ -797,8 +797,8 @@ enum qeth_ipa_arp_return_codes {
797 QETH_IPA_ARP_RC_Q_NO_DATA = 0x0008, 797 QETH_IPA_ARP_RC_Q_NO_DATA = 0x0008,
798}; 798};
799 799
800extern char *qeth_get_ipa_msg(enum qeth_ipa_return_codes rc); 800extern const char *qeth_get_ipa_msg(enum qeth_ipa_return_codes rc);
801extern char *qeth_get_ipa_cmd_name(enum qeth_ipa_cmds cmd); 801extern const char *qeth_get_ipa_cmd_name(enum qeth_ipa_cmds cmd);
802 802
803#define QETH_SETASS_BASE_LEN (sizeof(struct qeth_ipacmd_hdr) + \ 803#define QETH_SETASS_BASE_LEN (sizeof(struct qeth_ipacmd_hdr) + \
804 sizeof(struct qeth_ipacmd_setassparms_hdr)) 804 sizeof(struct qeth_ipacmd_setassparms_hdr))
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 710fa74892ae..b5e38531733f 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -423,7 +423,7 @@ static int qeth_l2_process_inbound_buffer(struct qeth_card *card,
423 default: 423 default:
424 dev_kfree_skb_any(skb); 424 dev_kfree_skb_any(skb);
425 QETH_CARD_TEXT(card, 3, "inbunkno"); 425 QETH_CARD_TEXT(card, 3, "inbunkno");
426 QETH_DBF_HEX(CTRL, 3, hdr, QETH_DBF_CTRL_LEN); 426 QETH_DBF_HEX(CTRL, 3, hdr, sizeof(*hdr));
427 continue; 427 continue;
428 } 428 }
429 work_done++; 429 work_done++;
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 7175086677fb..ada258c01a08 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -1390,7 +1390,7 @@ static int qeth_l3_process_inbound_buffer(struct qeth_card *card,
1390 default: 1390 default:
1391 dev_kfree_skb_any(skb); 1391 dev_kfree_skb_any(skb);
1392 QETH_CARD_TEXT(card, 3, "inbunkno"); 1392 QETH_CARD_TEXT(card, 3, "inbunkno");
1393 QETH_DBF_HEX(CTRL, 3, hdr, QETH_DBF_CTRL_LEN); 1393 QETH_DBF_HEX(CTRL, 3, hdr, sizeof(*hdr));
1394 continue; 1394 continue;
1395 } 1395 }
1396 work_done++; 1396 work_done++;
diff --git a/drivers/sbus/char/openprom.c b/drivers/sbus/char/openprom.c
index 7b31f19ade83..050879a2ddef 100644
--- a/drivers/sbus/char/openprom.c
+++ b/drivers/sbus/char/openprom.c
@@ -715,22 +715,13 @@ static struct miscdevice openprom_dev = {
715 715
716static int __init openprom_init(void) 716static int __init openprom_init(void)
717{ 717{
718 struct device_node *dp;
719 int err; 718 int err;
720 719
721 err = misc_register(&openprom_dev); 720 err = misc_register(&openprom_dev);
722 if (err) 721 if (err)
723 return err; 722 return err;
724 723
725 dp = of_find_node_by_path("/"); 724 options_node = of_get_child_by_name(of_find_node_by_path("/"), "options");
726 dp = dp->child;
727 while (dp) {
728 if (!strcmp(dp->name, "options"))
729 break;
730 dp = dp->sibling;
731 }
732 options_node = dp;
733
734 if (!options_node) { 725 if (!options_node) {
735 misc_deregister(&openprom_dev); 726 misc_deregister(&openprom_dev);
736 return -EIO; 727 return -EIO;
diff --git a/drivers/sbus/char/oradax.c b/drivers/sbus/char/oradax.c
index 524f9ea62e52..6516bc3cb58b 100644
--- a/drivers/sbus/char/oradax.c
+++ b/drivers/sbus/char/oradax.c
@@ -689,8 +689,7 @@ static int dax_open(struct inode *inode, struct file *f)
689alloc_error: 689alloc_error:
690 kfree(ctx->ccb_buf); 690 kfree(ctx->ccb_buf);
691done: 691done:
692 if (ctx != NULL) 692 kfree(ctx);
693 kfree(ctx);
694 return -ENOMEM; 693 return -ENOMEM;
695} 694}
696 695
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index fac377320158..f42a619198c4 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3474,11 +3474,10 @@ static int ibmvscsis_probe(struct vio_dev *vdev,
3474 vscsi->dds.window[LOCAL].liobn, 3474 vscsi->dds.window[LOCAL].liobn,
3475 vscsi->dds.window[REMOTE].liobn); 3475 vscsi->dds.window[REMOTE].liobn);
3476 3476
3477 strcpy(vscsi->eye, "VSCSI "); 3477 snprintf(vscsi->eye, sizeof(vscsi->eye), "VSCSI %s", vdev->name);
3478 strncat(vscsi->eye, vdev->name, MAX_EYE);
3479 3478
3480 vscsi->dds.unit_id = vdev->unit_address; 3479 vscsi->dds.unit_id = vdev->unit_address;
3481 strncpy(vscsi->dds.partition_name, partition_name, 3480 strscpy(vscsi->dds.partition_name, partition_name,
3482 sizeof(vscsi->dds.partition_name)); 3481 sizeof(vscsi->dds.partition_name));
3483 vscsi->dds.partition_num = partition_number; 3482 vscsi->dds.partition_num = partition_number;
3484 3483
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index f2ec80b0ffc0..271990bc065b 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -3335,6 +3335,65 @@ static void ipr_release_dump(struct kref *kref)
3335 LEAVE; 3335 LEAVE;
3336} 3336}
3337 3337
3338static void ipr_add_remove_thread(struct work_struct *work)
3339{
3340 unsigned long lock_flags;
3341 struct ipr_resource_entry *res;
3342 struct scsi_device *sdev;
3343 struct ipr_ioa_cfg *ioa_cfg =
3344 container_of(work, struct ipr_ioa_cfg, scsi_add_work_q);
3345 u8 bus, target, lun;
3346 int did_work;
3347
3348 ENTER;
3349 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
3350
3351restart:
3352 do {
3353 did_work = 0;
3354 if (!ioa_cfg->hrrq[IPR_INIT_HRRQ].allow_cmds) {
3355 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3356 return;
3357 }
3358
3359 list_for_each_entry(res, &ioa_cfg->used_res_q, queue) {
3360 if (res->del_from_ml && res->sdev) {
3361 did_work = 1;
3362 sdev = res->sdev;
3363 if (!scsi_device_get(sdev)) {
3364 if (!res->add_to_ml)
3365 list_move_tail(&res->queue, &ioa_cfg->free_res_q);
3366 else
3367 res->del_from_ml = 0;
3368 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3369 scsi_remove_device(sdev);
3370 scsi_device_put(sdev);
3371 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
3372 }
3373 break;
3374 }
3375 }
3376 } while (did_work);
3377
3378 list_for_each_entry(res, &ioa_cfg->used_res_q, queue) {
3379 if (res->add_to_ml) {
3380 bus = res->bus;
3381 target = res->target;
3382 lun = res->lun;
3383 res->add_to_ml = 0;
3384 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3385 scsi_add_device(ioa_cfg->host, bus, target, lun);
3386 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
3387 goto restart;
3388 }
3389 }
3390
3391 ioa_cfg->scan_done = 1;
3392 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3393 kobject_uevent(&ioa_cfg->host->shost_dev.kobj, KOBJ_CHANGE);
3394 LEAVE;
3395}
3396
3338/** 3397/**
3339 * ipr_worker_thread - Worker thread 3398 * ipr_worker_thread - Worker thread
3340 * @work: ioa config struct 3399 * @work: ioa config struct
@@ -3349,13 +3408,9 @@ static void ipr_release_dump(struct kref *kref)
3349static void ipr_worker_thread(struct work_struct *work) 3408static void ipr_worker_thread(struct work_struct *work)
3350{ 3409{
3351 unsigned long lock_flags; 3410 unsigned long lock_flags;
3352 struct ipr_resource_entry *res;
3353 struct scsi_device *sdev;
3354 struct ipr_dump *dump; 3411 struct ipr_dump *dump;
3355 struct ipr_ioa_cfg *ioa_cfg = 3412 struct ipr_ioa_cfg *ioa_cfg =
3356 container_of(work, struct ipr_ioa_cfg, work_q); 3413 container_of(work, struct ipr_ioa_cfg, work_q);
3357 u8 bus, target, lun;
3358 int did_work;
3359 3414
3360 ENTER; 3415 ENTER;
3361 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags); 3416 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
@@ -3393,49 +3448,9 @@ static void ipr_worker_thread(struct work_struct *work)
3393 return; 3448 return;
3394 } 3449 }
3395 3450
3396restart: 3451 schedule_work(&ioa_cfg->scsi_add_work_q);
3397 do {
3398 did_work = 0;
3399 if (!ioa_cfg->hrrq[IPR_INIT_HRRQ].allow_cmds) {
3400 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3401 return;
3402 }
3403 3452
3404 list_for_each_entry(res, &ioa_cfg->used_res_q, queue) {
3405 if (res->del_from_ml && res->sdev) {
3406 did_work = 1;
3407 sdev = res->sdev;
3408 if (!scsi_device_get(sdev)) {
3409 if (!res->add_to_ml)
3410 list_move_tail(&res->queue, &ioa_cfg->free_res_q);
3411 else
3412 res->del_from_ml = 0;
3413 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3414 scsi_remove_device(sdev);
3415 scsi_device_put(sdev);
3416 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
3417 }
3418 break;
3419 }
3420 }
3421 } while (did_work);
3422
3423 list_for_each_entry(res, &ioa_cfg->used_res_q, queue) {
3424 if (res->add_to_ml) {
3425 bus = res->bus;
3426 target = res->target;
3427 lun = res->lun;
3428 res->add_to_ml = 0;
3429 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3430 scsi_add_device(ioa_cfg->host, bus, target, lun);
3431 spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
3432 goto restart;
3433 }
3434 }
3435
3436 ioa_cfg->scan_done = 1;
3437 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); 3453 spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
3438 kobject_uevent(&ioa_cfg->host->shost_dev.kobj, KOBJ_CHANGE);
3439 LEAVE; 3454 LEAVE;
3440} 3455}
3441 3456
@@ -9933,6 +9948,7 @@ static void ipr_init_ioa_cfg(struct ipr_ioa_cfg *ioa_cfg,
9933 INIT_LIST_HEAD(&ioa_cfg->free_res_q); 9948 INIT_LIST_HEAD(&ioa_cfg->free_res_q);
9934 INIT_LIST_HEAD(&ioa_cfg->used_res_q); 9949 INIT_LIST_HEAD(&ioa_cfg->used_res_q);
9935 INIT_WORK(&ioa_cfg->work_q, ipr_worker_thread); 9950 INIT_WORK(&ioa_cfg->work_q, ipr_worker_thread);
9951 INIT_WORK(&ioa_cfg->scsi_add_work_q, ipr_add_remove_thread);
9936 init_waitqueue_head(&ioa_cfg->reset_wait_q); 9952 init_waitqueue_head(&ioa_cfg->reset_wait_q);
9937 init_waitqueue_head(&ioa_cfg->msi_wait_q); 9953 init_waitqueue_head(&ioa_cfg->msi_wait_q);
9938 init_waitqueue_head(&ioa_cfg->eeh_wait_q); 9954 init_waitqueue_head(&ioa_cfg->eeh_wait_q);
diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h
index 68afbbde54d3..f6baa2351313 100644
--- a/drivers/scsi/ipr.h
+++ b/drivers/scsi/ipr.h
@@ -1575,6 +1575,7 @@ struct ipr_ioa_cfg {
1575 u8 saved_mode_page_len; 1575 u8 saved_mode_page_len;
1576 1576
1577 struct work_struct work_q; 1577 struct work_struct work_q;
1578 struct work_struct scsi_add_work_q;
1578 struct workqueue_struct *reset_work_q; 1579 struct workqueue_struct *reset_work_q;
1579 1580
1580 wait_queue_head_t reset_wait_q; 1581 wait_queue_head_t reset_wait_q;
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 057a60abe664..1a6ed9b0a249 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -360,12 +360,12 @@ lpfc_nvme_info_show(struct device *dev, struct device_attribute *attr,
360 goto buffer_done; 360 goto buffer_done;
361 361
362 list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) { 362 list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
363 nrport = NULL;
364 spin_lock(&vport->phba->hbalock);
363 rport = lpfc_ndlp_get_nrport(ndlp); 365 rport = lpfc_ndlp_get_nrport(ndlp);
364 if (!rport) 366 if (rport)
365 continue; 367 nrport = rport->remoteport;
366 368 spin_unlock(&vport->phba->hbalock);
367 /* local short-hand pointer. */
368 nrport = rport->remoteport;
369 if (!nrport) 369 if (!nrport)
370 continue; 370 continue;
371 371
@@ -3386,6 +3386,7 @@ lpfc_update_rport_devloss_tmo(struct lpfc_vport *vport)
3386 struct lpfc_nodelist *ndlp; 3386 struct lpfc_nodelist *ndlp;
3387#if (IS_ENABLED(CONFIG_NVME_FC)) 3387#if (IS_ENABLED(CONFIG_NVME_FC))
3388 struct lpfc_nvme_rport *rport; 3388 struct lpfc_nvme_rport *rport;
3389 struct nvme_fc_remote_port *remoteport = NULL;
3389#endif 3390#endif
3390 3391
3391 shost = lpfc_shost_from_vport(vport); 3392 shost = lpfc_shost_from_vport(vport);
@@ -3396,8 +3397,12 @@ lpfc_update_rport_devloss_tmo(struct lpfc_vport *vport)
3396 if (ndlp->rport) 3397 if (ndlp->rport)
3397 ndlp->rport->dev_loss_tmo = vport->cfg_devloss_tmo; 3398 ndlp->rport->dev_loss_tmo = vport->cfg_devloss_tmo;
3398#if (IS_ENABLED(CONFIG_NVME_FC)) 3399#if (IS_ENABLED(CONFIG_NVME_FC))
3400 spin_lock(&vport->phba->hbalock);
3399 rport = lpfc_ndlp_get_nrport(ndlp); 3401 rport = lpfc_ndlp_get_nrport(ndlp);
3400 if (rport) 3402 if (rport)
3403 remoteport = rport->remoteport;
3404 spin_unlock(&vport->phba->hbalock);
3405 if (remoteport)
3401 nvme_fc_set_remoteport_devloss(rport->remoteport, 3406 nvme_fc_set_remoteport_devloss(rport->remoteport,
3402 vport->cfg_devloss_tmo); 3407 vport->cfg_devloss_tmo);
3403#endif 3408#endif
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index 9df0c051349f..aec5b10a8c85 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -551,7 +551,7 @@ lpfc_debugfs_nodelist_data(struct lpfc_vport *vport, char *buf, int size)
551 unsigned char *statep; 551 unsigned char *statep;
552 struct nvme_fc_local_port *localport; 552 struct nvme_fc_local_port *localport;
553 struct lpfc_nvmet_tgtport *tgtp; 553 struct lpfc_nvmet_tgtport *tgtp;
554 struct nvme_fc_remote_port *nrport; 554 struct nvme_fc_remote_port *nrport = NULL;
555 struct lpfc_nvme_rport *rport; 555 struct lpfc_nvme_rport *rport;
556 556
557 cnt = (LPFC_NODELIST_SIZE / LPFC_NODELIST_ENTRY_SIZE); 557 cnt = (LPFC_NODELIST_SIZE / LPFC_NODELIST_ENTRY_SIZE);
@@ -696,11 +696,11 @@ lpfc_debugfs_nodelist_data(struct lpfc_vport *vport, char *buf, int size)
696 len += snprintf(buf + len, size - len, "\tRport List:\n"); 696 len += snprintf(buf + len, size - len, "\tRport List:\n");
697 list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) { 697 list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
698 /* local short-hand pointer. */ 698 /* local short-hand pointer. */
699 spin_lock(&phba->hbalock);
699 rport = lpfc_ndlp_get_nrport(ndlp); 700 rport = lpfc_ndlp_get_nrport(ndlp);
700 if (!rport) 701 if (rport)
701 continue; 702 nrport = rport->remoteport;
702 703 spin_unlock(&phba->hbalock);
703 nrport = rport->remoteport;
704 if (!nrport) 704 if (!nrport)
705 continue; 705 continue;
706 706
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
index 028462e5994d..918ae18ef8a8 100644
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scsi/lpfc/lpfc_nvme.c
@@ -2725,7 +2725,9 @@ lpfc_nvme_register_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
2725 rpinfo.port_name = wwn_to_u64(ndlp->nlp_portname.u.wwn); 2725 rpinfo.port_name = wwn_to_u64(ndlp->nlp_portname.u.wwn);
2726 rpinfo.node_name = wwn_to_u64(ndlp->nlp_nodename.u.wwn); 2726 rpinfo.node_name = wwn_to_u64(ndlp->nlp_nodename.u.wwn);
2727 2727
2728 spin_lock_irq(&vport->phba->hbalock);
2728 oldrport = lpfc_ndlp_get_nrport(ndlp); 2729 oldrport = lpfc_ndlp_get_nrport(ndlp);
2730 spin_unlock_irq(&vport->phba->hbalock);
2729 if (!oldrport) 2731 if (!oldrport)
2730 lpfc_nlp_get(ndlp); 2732 lpfc_nlp_get(ndlp);
2731 2733
@@ -2840,7 +2842,7 @@ lpfc_nvme_unregister_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
2840 struct nvme_fc_local_port *localport; 2842 struct nvme_fc_local_port *localport;
2841 struct lpfc_nvme_lport *lport; 2843 struct lpfc_nvme_lport *lport;
2842 struct lpfc_nvme_rport *rport; 2844 struct lpfc_nvme_rport *rport;
2843 struct nvme_fc_remote_port *remoteport; 2845 struct nvme_fc_remote_port *remoteport = NULL;
2844 2846
2845 localport = vport->localport; 2847 localport = vport->localport;
2846 2848
@@ -2854,11 +2856,14 @@ lpfc_nvme_unregister_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
2854 if (!lport) 2856 if (!lport)
2855 goto input_err; 2857 goto input_err;
2856 2858
2859 spin_lock_irq(&vport->phba->hbalock);
2857 rport = lpfc_ndlp_get_nrport(ndlp); 2860 rport = lpfc_ndlp_get_nrport(ndlp);
2858 if (!rport) 2861 if (rport)
2862 remoteport = rport->remoteport;
2863 spin_unlock_irq(&vport->phba->hbalock);
2864 if (!remoteport)
2859 goto input_err; 2865 goto input_err;
2860 2866
2861 remoteport = rport->remoteport;
2862 lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_DISC, 2867 lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_DISC,
2863 "6033 Unreg nvme remoteport %p, portname x%llx, " 2868 "6033 Unreg nvme remoteport %p, portname x%llx, "
2864 "port_id x%06x, portstate x%x port type x%x\n", 2869 "port_id x%06x, portstate x%x port type x%x\n",
diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
index fc3babc15fa3..a6f96b35e971 100644
--- a/drivers/scsi/qedi/qedi.h
+++ b/drivers/scsi/qedi/qedi.h
@@ -77,6 +77,11 @@ enum qedi_nvm_tgts {
77 QEDI_NVM_TGT_SEC, 77 QEDI_NVM_TGT_SEC,
78}; 78};
79 79
80struct qedi_nvm_iscsi_image {
81 struct nvm_iscsi_cfg iscsi_cfg;
82 u32 crc;
83};
84
80struct qedi_uio_ctrl { 85struct qedi_uio_ctrl {
81 /* meta data */ 86 /* meta data */
82 u32 uio_hsi_version; 87 u32 uio_hsi_version;
@@ -294,7 +299,7 @@ struct qedi_ctx {
294 void *bdq_pbl_list; 299 void *bdq_pbl_list;
295 dma_addr_t bdq_pbl_list_dma; 300 dma_addr_t bdq_pbl_list_dma;
296 u8 bdq_pbl_list_num_entries; 301 u8 bdq_pbl_list_num_entries;
297 struct nvm_iscsi_cfg *iscsi_cfg; 302 struct qedi_nvm_iscsi_image *iscsi_image;
298 dma_addr_t nvm_buf_dma; 303 dma_addr_t nvm_buf_dma;
299 void __iomem *bdq_primary_prod; 304 void __iomem *bdq_primary_prod;
300 void __iomem *bdq_secondary_prod; 305 void __iomem *bdq_secondary_prod;
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index aa96bccb5a96..e5bd035ebad0 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1346,23 +1346,26 @@ exit_setup_int:
1346 1346
1347static void qedi_free_nvm_iscsi_cfg(struct qedi_ctx *qedi) 1347static void qedi_free_nvm_iscsi_cfg(struct qedi_ctx *qedi)
1348{ 1348{
1349 if (qedi->iscsi_cfg) 1349 if (qedi->iscsi_image)
1350 dma_free_coherent(&qedi->pdev->dev, 1350 dma_free_coherent(&qedi->pdev->dev,
1351 sizeof(struct nvm_iscsi_cfg), 1351 sizeof(struct qedi_nvm_iscsi_image),
1352 qedi->iscsi_cfg, qedi->nvm_buf_dma); 1352 qedi->iscsi_image, qedi->nvm_buf_dma);
1353} 1353}
1354 1354
1355static int qedi_alloc_nvm_iscsi_cfg(struct qedi_ctx *qedi) 1355static int qedi_alloc_nvm_iscsi_cfg(struct qedi_ctx *qedi)
1356{ 1356{
1357 qedi->iscsi_cfg = dma_zalloc_coherent(&qedi->pdev->dev, 1357 struct qedi_nvm_iscsi_image nvm_image;
1358 sizeof(struct nvm_iscsi_cfg), 1358
1359 &qedi->nvm_buf_dma, GFP_KERNEL); 1359 qedi->iscsi_image = dma_zalloc_coherent(&qedi->pdev->dev,
1360 if (!qedi->iscsi_cfg) { 1360 sizeof(nvm_image),
1361 &qedi->nvm_buf_dma,
1362 GFP_KERNEL);
1363 if (!qedi->iscsi_image) {
1361 QEDI_ERR(&qedi->dbg_ctx, "Could not allocate NVM BUF.\n"); 1364 QEDI_ERR(&qedi->dbg_ctx, "Could not allocate NVM BUF.\n");
1362 return -ENOMEM; 1365 return -ENOMEM;
1363 } 1366 }
1364 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO, 1367 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO,
1365 "NVM BUF addr=0x%p dma=0x%llx.\n", qedi->iscsi_cfg, 1368 "NVM BUF addr=0x%p dma=0x%llx.\n", qedi->iscsi_image,
1366 qedi->nvm_buf_dma); 1369 qedi->nvm_buf_dma);
1367 1370
1368 return 0; 1371 return 0;
@@ -1905,7 +1908,7 @@ qedi_get_nvram_block(struct qedi_ctx *qedi)
1905 struct nvm_iscsi_block *block; 1908 struct nvm_iscsi_block *block;
1906 1909
1907 pf = qedi->dev_info.common.abs_pf_id; 1910 pf = qedi->dev_info.common.abs_pf_id;
1908 block = &qedi->iscsi_cfg->block[0]; 1911 block = &qedi->iscsi_image->iscsi_cfg.block[0];
1909 for (i = 0; i < NUM_OF_ISCSI_PF_SUPPORTED; i++, block++) { 1912 for (i = 0; i < NUM_OF_ISCSI_PF_SUPPORTED; i++, block++) {
1910 flags = ((block->id) & NVM_ISCSI_CFG_BLK_CTRL_FLAG_MASK) >> 1913 flags = ((block->id) & NVM_ISCSI_CFG_BLK_CTRL_FLAG_MASK) >>
1911 NVM_ISCSI_CFG_BLK_CTRL_FLAG_OFFSET; 1914 NVM_ISCSI_CFG_BLK_CTRL_FLAG_OFFSET;
@@ -2194,15 +2197,14 @@ static void qedi_boot_release(void *data)
2194static int qedi_get_boot_info(struct qedi_ctx *qedi) 2197static int qedi_get_boot_info(struct qedi_ctx *qedi)
2195{ 2198{
2196 int ret = 1; 2199 int ret = 1;
2197 u16 len; 2200 struct qedi_nvm_iscsi_image nvm_image;
2198
2199 len = sizeof(struct nvm_iscsi_cfg);
2200 2201
2201 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO, 2202 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO,
2202 "Get NVM iSCSI CFG image\n"); 2203 "Get NVM iSCSI CFG image\n");
2203 ret = qedi_ops->common->nvm_get_image(qedi->cdev, 2204 ret = qedi_ops->common->nvm_get_image(qedi->cdev,
2204 QED_NVM_IMAGE_ISCSI_CFG, 2205 QED_NVM_IMAGE_ISCSI_CFG,
2205 (char *)qedi->iscsi_cfg, len); 2206 (char *)qedi->iscsi_image,
2207 sizeof(nvm_image));
2206 if (ret) 2208 if (ret)
2207 QEDI_ERR(&qedi->dbg_ctx, 2209 QEDI_ERR(&qedi->dbg_ctx,
2208 "Could not get NVM image. ret = %d\n", ret); 2210 "Could not get NVM image. ret = %d\n", ret);
@@ -2470,6 +2472,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
2470 /* start qedi context */ 2472 /* start qedi context */
2471 spin_lock_init(&qedi->hba_lock); 2473 spin_lock_init(&qedi->hba_lock);
2472 spin_lock_init(&qedi->task_idx_lock); 2474 spin_lock_init(&qedi->task_idx_lock);
2475 mutex_init(&qedi->stats_lock);
2473 } 2476 }
2474 qedi_ops->ll2->register_cb_ops(qedi->cdev, &qedi_ll2_cb_ops, qedi); 2477 qedi_ops->ll2->register_cb_ops(qedi->cdev, &qedi_ll2_cb_ops, qedi);
2475 qedi_ops->ll2->start(qedi->cdev, &params); 2478 qedi_ops->ll2->start(qedi->cdev, &params);
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
index fecf96f0225c..199d3ba1916d 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -374,8 +374,8 @@ struct atio_from_isp {
374static inline int fcpcmd_is_corrupted(struct atio *atio) 374static inline int fcpcmd_is_corrupted(struct atio *atio)
375{ 375{
376 if (atio->entry_type == ATIO_TYPE7 && 376 if (atio->entry_type == ATIO_TYPE7 &&
377 (le16_to_cpu(atio->attr_n_length & FCP_CMD_LENGTH_MASK) < 377 ((le16_to_cpu(atio->attr_n_length) & FCP_CMD_LENGTH_MASK) <
378 FCP_CMD_LENGTH_MIN)) 378 FCP_CMD_LENGTH_MIN))
379 return 1; 379 return 1;
380 else 380 else
381 return 0; 381 return 0;
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index b79b366a94f7..4a57ffecc7e6 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1276,7 +1276,8 @@ static int sd_init_command(struct scsi_cmnd *cmd)
1276 case REQ_OP_ZONE_RESET: 1276 case REQ_OP_ZONE_RESET:
1277 return sd_zbc_setup_reset_cmnd(cmd); 1277 return sd_zbc_setup_reset_cmnd(cmd);
1278 default: 1278 default:
1279 BUG(); 1279 WARN_ON_ONCE(1);
1280 return BLKPREP_KILL;
1280 } 1281 }
1281} 1282}
1282 1283
@@ -2959,6 +2960,9 @@ static void sd_read_block_characteristics(struct scsi_disk *sdkp)
2959 if (rot == 1) { 2960 if (rot == 1) {
2960 blk_queue_flag_set(QUEUE_FLAG_NONROT, q); 2961 blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
2961 blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, q); 2962 blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, q);
2963 } else {
2964 blk_queue_flag_clear(QUEUE_FLAG_NONROT, q);
2965 blk_queue_flag_set(QUEUE_FLAG_ADD_RANDOM, q);
2962 } 2966 }
2963 2967
2964 if (sdkp->device->type == TYPE_ZBC) { 2968 if (sdkp->device->type == TYPE_ZBC) {
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9d5d2ca7fc4f..c55f38ec391c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7940,6 +7940,13 @@ int ufshcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle)
7940 err = -ENOMEM; 7940 err = -ENOMEM;
7941 goto out_error; 7941 goto out_error;
7942 } 7942 }
7943
7944 /*
7945 * Do not use blk-mq at this time because blk-mq does not support
7946 * runtime pm.
7947 */
7948 host->use_blk_mq = false;
7949
7943 hba = shost_priv(host); 7950 hba = shost_priv(host);
7944 hba->host = host; 7951 hba->host = host;
7945 hba->dev = dev; 7952 hba->dev = dev;
diff --git a/drivers/soc/fsl/qbman/bman_ccsr.c b/drivers/soc/fsl/qbman/bman_ccsr.c
index 05c42235dd41..7c3cc968053c 100644
--- a/drivers/soc/fsl/qbman/bman_ccsr.c
+++ b/drivers/soc/fsl/qbman/bman_ccsr.c
@@ -120,6 +120,7 @@ static void bm_set_memory(u64 ba, u32 size)
120 */ 120 */
121static dma_addr_t fbpr_a; 121static dma_addr_t fbpr_a;
122static size_t fbpr_sz; 122static size_t fbpr_sz;
123static int __bman_probed;
123 124
124static int bman_fbpr(struct reserved_mem *rmem) 125static int bman_fbpr(struct reserved_mem *rmem)
125{ 126{
@@ -166,6 +167,12 @@ static irqreturn_t bman_isr(int irq, void *ptr)
166 return IRQ_HANDLED; 167 return IRQ_HANDLED;
167} 168}
168 169
170int bman_is_probed(void)
171{
172 return __bman_probed;
173}
174EXPORT_SYMBOL_GPL(bman_is_probed);
175
169static int fsl_bman_probe(struct platform_device *pdev) 176static int fsl_bman_probe(struct platform_device *pdev)
170{ 177{
171 int ret, err_irq; 178 int ret, err_irq;
@@ -175,6 +182,8 @@ static int fsl_bman_probe(struct platform_device *pdev)
175 u16 id, bm_pool_cnt; 182 u16 id, bm_pool_cnt;
176 u8 major, minor; 183 u8 major, minor;
177 184
185 __bman_probed = -1;
186
178 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 187 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
179 if (!res) { 188 if (!res) {
180 dev_err(dev, "Can't get %pOF property 'IORESOURCE_MEM'\n", 189 dev_err(dev, "Can't get %pOF property 'IORESOURCE_MEM'\n",
@@ -255,6 +264,8 @@ static int fsl_bman_probe(struct platform_device *pdev)
255 return ret; 264 return ret;
256 } 265 }
257 266
267 __bman_probed = 1;
268
258 return 0; 269 return 0;
259}; 270};
260 271
diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index ecb22749df0b..8cc015183043 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -2729,6 +2729,9 @@ static int qman_alloc_range(struct gen_pool *p, u32 *result, u32 cnt)
2729{ 2729{
2730 unsigned long addr; 2730 unsigned long addr;
2731 2731
2732 if (!p)
2733 return -ENODEV;
2734
2732 addr = gen_pool_alloc(p, cnt); 2735 addr = gen_pool_alloc(p, cnt);
2733 if (!addr) 2736 if (!addr)
2734 return -ENOMEM; 2737 return -ENOMEM;
diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c
index 79cba58387a5..6fd5fef5f39b 100644
--- a/drivers/soc/fsl/qbman/qman_ccsr.c
+++ b/drivers/soc/fsl/qbman/qman_ccsr.c
@@ -273,6 +273,7 @@ static const struct qman_error_info_mdata error_mdata[] = {
273static u32 __iomem *qm_ccsr_start; 273static u32 __iomem *qm_ccsr_start;
274/* A SDQCR mask comprising all the available/visible pool channels */ 274/* A SDQCR mask comprising all the available/visible pool channels */
275static u32 qm_pools_sdqcr; 275static u32 qm_pools_sdqcr;
276static int __qman_probed;
276 277
277static inline u32 qm_ccsr_in(u32 offset) 278static inline u32 qm_ccsr_in(u32 offset)
278{ 279{
@@ -686,6 +687,12 @@ static int qman_resource_init(struct device *dev)
686 return 0; 687 return 0;
687} 688}
688 689
690int qman_is_probed(void)
691{
692 return __qman_probed;
693}
694EXPORT_SYMBOL_GPL(qman_is_probed);
695
689static int fsl_qman_probe(struct platform_device *pdev) 696static int fsl_qman_probe(struct platform_device *pdev)
690{ 697{
691 struct device *dev = &pdev->dev; 698 struct device *dev = &pdev->dev;
@@ -695,6 +702,8 @@ static int fsl_qman_probe(struct platform_device *pdev)
695 u16 id; 702 u16 id;
696 u8 major, minor; 703 u8 major, minor;
697 704
705 __qman_probed = -1;
706
698 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 707 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
699 if (!res) { 708 if (!res) {
700 dev_err(dev, "Can't get %pOF property 'IORESOURCE_MEM'\n", 709 dev_err(dev, "Can't get %pOF property 'IORESOURCE_MEM'\n",
@@ -828,6 +837,8 @@ static int fsl_qman_probe(struct platform_device *pdev)
828 if (ret) 837 if (ret)
829 return ret; 838 return ret;
830 839
840 __qman_probed = 1;
841
831 return 0; 842 return 0;
832} 843}
833 844
diff --git a/drivers/soc/fsl/qbman/qman_portal.c b/drivers/soc/fsl/qbman/qman_portal.c
index a120002b630e..3e9391d117c5 100644
--- a/drivers/soc/fsl/qbman/qman_portal.c
+++ b/drivers/soc/fsl/qbman/qman_portal.c
@@ -227,6 +227,14 @@ static int qman_portal_probe(struct platform_device *pdev)
227 int irq, cpu, err; 227 int irq, cpu, err;
228 u32 val; 228 u32 val;
229 229
230 err = qman_is_probed();
231 if (!err)
232 return -EPROBE_DEFER;
233 if (err < 0) {
234 dev_err(&pdev->dev, "failing probe due to qman probe error\n");
235 return -ENODEV;
236 }
237
230 pcfg = devm_kmalloc(dev, sizeof(*pcfg), GFP_KERNEL); 238 pcfg = devm_kmalloc(dev, sizeof(*pcfg), GFP_KERNEL);
231 if (!pcfg) 239 if (!pcfg)
232 return -ENOMEM; 240 return -ENOMEM;
diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c
index c646d8713861..681f7d4b7724 100644
--- a/drivers/soc/fsl/qe/ucc.c
+++ b/drivers/soc/fsl/qe/ucc.c
@@ -626,7 +626,7 @@ static u32 ucc_get_tdm_sync_shift(enum comm_dir mode, u32 tdm_num)
626{ 626{
627 u32 shift; 627 u32 shift;
628 628
629 shift = (mode == COMM_DIR_RX) ? RX_SYNC_SHIFT_BASE : RX_SYNC_SHIFT_BASE; 629 shift = (mode == COMM_DIR_RX) ? RX_SYNC_SHIFT_BASE : TX_SYNC_SHIFT_BASE;
630 shift -= tdm_num * 2; 630 shift -= tdm_num * 2;
631 631
632 return shift; 632 return shift;
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 4b5e250e8615..e5c7e1ef6318 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -899,9 +899,10 @@ static void sdw_release_master_stream(struct sdw_stream_runtime *stream)
899 struct sdw_master_runtime *m_rt = stream->m_rt; 899 struct sdw_master_runtime *m_rt = stream->m_rt;
900 struct sdw_slave_runtime *s_rt, *_s_rt; 900 struct sdw_slave_runtime *s_rt, *_s_rt;
901 901
902 list_for_each_entry_safe(s_rt, _s_rt, 902 list_for_each_entry_safe(s_rt, _s_rt, &m_rt->slave_rt_list, m_rt_node) {
903 &m_rt->slave_rt_list, m_rt_node) 903 sdw_slave_port_release(s_rt->slave->bus, s_rt->slave, stream);
904 sdw_stream_remove_slave(s_rt->slave, stream); 904 sdw_release_slave_stream(s_rt->slave, stream);
905 }
905 906
906 list_del(&m_rt->bus_node); 907 list_del(&m_rt->bus_node);
907} 908}
@@ -1112,7 +1113,7 @@ int sdw_stream_add_master(struct sdw_bus *bus,
1112 "Master runtime config failed for stream:%s", 1113 "Master runtime config failed for stream:%s",
1113 stream->name); 1114 stream->name);
1114 ret = -ENOMEM; 1115 ret = -ENOMEM;
1115 goto error; 1116 goto unlock;
1116 } 1117 }
1117 1118
1118 ret = sdw_config_stream(bus->dev, stream, stream_config, false); 1119 ret = sdw_config_stream(bus->dev, stream, stream_config, false);
@@ -1123,11 +1124,11 @@ int sdw_stream_add_master(struct sdw_bus *bus,
1123 if (ret) 1124 if (ret)
1124 goto stream_error; 1125 goto stream_error;
1125 1126
1126 stream->state = SDW_STREAM_CONFIGURED; 1127 goto unlock;
1127 1128
1128stream_error: 1129stream_error:
1129 sdw_release_master_stream(stream); 1130 sdw_release_master_stream(stream);
1130error: 1131unlock:
1131 mutex_unlock(&bus->bus_lock); 1132 mutex_unlock(&bus->bus_lock);
1132 return ret; 1133 return ret;
1133} 1134}
@@ -1141,6 +1142,10 @@ EXPORT_SYMBOL(sdw_stream_add_master);
1141 * @stream: SoundWire stream 1142 * @stream: SoundWire stream
1142 * @port_config: Port configuration for audio stream 1143 * @port_config: Port configuration for audio stream
1143 * @num_ports: Number of ports 1144 * @num_ports: Number of ports
1145 *
1146 * It is expected that Slave is added before adding Master
1147 * to the Stream.
1148 *
1144 */ 1149 */
1145int sdw_stream_add_slave(struct sdw_slave *slave, 1150int sdw_stream_add_slave(struct sdw_slave *slave,
1146 struct sdw_stream_config *stream_config, 1151 struct sdw_stream_config *stream_config,
@@ -1186,6 +1191,12 @@ int sdw_stream_add_slave(struct sdw_slave *slave,
1186 if (ret) 1191 if (ret)
1187 goto stream_error; 1192 goto stream_error;
1188 1193
1194 /*
1195 * Change stream state to CONFIGURED on first Slave add.
1196 * Bus is not aware of number of Slave(s) in a stream at this
1197 * point so cannot depend on all Slave(s) to be added in order to
1198 * change stream state to CONFIGURED.
1199 */
1189 stream->state = SDW_STREAM_CONFIGURED; 1200 stream->state = SDW_STREAM_CONFIGURED;
1190 goto error; 1201 goto error;
1191 1202
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 7cb3ab0a35a0..3082e72e4f6c 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -30,7 +30,11 @@
30 30
31#define DRIVER_NAME "fsl-dspi" 31#define DRIVER_NAME "fsl-dspi"
32 32
33#ifdef CONFIG_M5441x
34#define DSPI_FIFO_SIZE 16
35#else
33#define DSPI_FIFO_SIZE 4 36#define DSPI_FIFO_SIZE 4
37#endif
34#define DSPI_DMA_BUFSIZE (DSPI_FIFO_SIZE * 1024) 38#define DSPI_DMA_BUFSIZE (DSPI_FIFO_SIZE * 1024)
35 39
36#define SPI_MCR 0x00 40#define SPI_MCR 0x00
@@ -623,9 +627,11 @@ static void dspi_tcfq_read(struct fsl_dspi *dspi)
623static void dspi_eoq_write(struct fsl_dspi *dspi) 627static void dspi_eoq_write(struct fsl_dspi *dspi)
624{ 628{
625 int fifo_size = DSPI_FIFO_SIZE; 629 int fifo_size = DSPI_FIFO_SIZE;
630 u16 xfer_cmd = dspi->tx_cmd;
626 631
627 /* Fill TX FIFO with as many transfers as possible */ 632 /* Fill TX FIFO with as many transfers as possible */
628 while (dspi->len && fifo_size--) { 633 while (dspi->len && fifo_size--) {
634 dspi->tx_cmd = xfer_cmd;
629 /* Request EOQF for last transfer in FIFO */ 635 /* Request EOQF for last transfer in FIFO */
630 if (dspi->len == dspi->bytes_per_word || fifo_size == 0) 636 if (dspi->len == dspi->bytes_per_word || fifo_size == 0)
631 dspi->tx_cmd |= SPI_PUSHR_CMD_EOQ; 637 dspi->tx_cmd |= SPI_PUSHR_CMD_EOQ;
diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index 0626e6e3ea0c..421bfc7dda67 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -300,8 +300,8 @@ static int spi_gpio_request(struct device *dev,
300 *mflags |= SPI_MASTER_NO_RX; 300 *mflags |= SPI_MASTER_NO_RX;
301 301
302 spi_gpio->sck = devm_gpiod_get(dev, "sck", GPIOD_OUT_LOW); 302 spi_gpio->sck = devm_gpiod_get(dev, "sck", GPIOD_OUT_LOW);
303 if (IS_ERR(spi_gpio->mosi)) 303 if (IS_ERR(spi_gpio->sck))
304 return PTR_ERR(spi_gpio->mosi); 304 return PTR_ERR(spi_gpio->sck);
305 305
306 for (i = 0; i < num_chipselects; i++) { 306 for (i = 0; i < num_chipselects; i++) {
307 spi_gpio->cs_gpios[i] = devm_gpiod_get_index(dev, "cs", 307 spi_gpio->cs_gpios[i] = devm_gpiod_get_index(dev, "cs",
diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index 95dc4d78618d..b37de1d991d6 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -598,11 +598,13 @@ static int rspi_dma_transfer(struct rspi_data *rspi, struct sg_table *tx,
598 598
599 ret = wait_event_interruptible_timeout(rspi->wait, 599 ret = wait_event_interruptible_timeout(rspi->wait,
600 rspi->dma_callbacked, HZ); 600 rspi->dma_callbacked, HZ);
601 if (ret > 0 && rspi->dma_callbacked) 601 if (ret > 0 && rspi->dma_callbacked) {
602 ret = 0; 602 ret = 0;
603 else if (!ret) { 603 } else {
604 dev_err(&rspi->master->dev, "DMA timeout\n"); 604 if (!ret) {
605 ret = -ETIMEDOUT; 605 dev_err(&rspi->master->dev, "DMA timeout\n");
606 ret = -ETIMEDOUT;
607 }
606 if (tx) 608 if (tx)
607 dmaengine_terminate_all(rspi->master->dma_tx); 609 dmaengine_terminate_all(rspi->master->dma_tx);
608 if (rx) 610 if (rx)
@@ -1350,12 +1352,36 @@ static const struct platform_device_id spi_driver_ids[] = {
1350 1352
1351MODULE_DEVICE_TABLE(platform, spi_driver_ids); 1353MODULE_DEVICE_TABLE(platform, spi_driver_ids);
1352 1354
1355#ifdef CONFIG_PM_SLEEP
1356static int rspi_suspend(struct device *dev)
1357{
1358 struct platform_device *pdev = to_platform_device(dev);
1359 struct rspi_data *rspi = platform_get_drvdata(pdev);
1360
1361 return spi_master_suspend(rspi->master);
1362}
1363
1364static int rspi_resume(struct device *dev)
1365{
1366 struct platform_device *pdev = to_platform_device(dev);
1367 struct rspi_data *rspi = platform_get_drvdata(pdev);
1368
1369 return spi_master_resume(rspi->master);
1370}
1371
1372static SIMPLE_DEV_PM_OPS(rspi_pm_ops, rspi_suspend, rspi_resume);
1373#define DEV_PM_OPS &rspi_pm_ops
1374#else
1375#define DEV_PM_OPS NULL
1376#endif /* CONFIG_PM_SLEEP */
1377
1353static struct platform_driver rspi_driver = { 1378static struct platform_driver rspi_driver = {
1354 .probe = rspi_probe, 1379 .probe = rspi_probe,
1355 .remove = rspi_remove, 1380 .remove = rspi_remove,
1356 .id_table = spi_driver_ids, 1381 .id_table = spi_driver_ids,
1357 .driver = { 1382 .driver = {
1358 .name = "renesas_spi", 1383 .name = "renesas_spi",
1384 .pm = DEV_PM_OPS,
1359 .of_match_table = of_match_ptr(rspi_of_match), 1385 .of_match_table = of_match_ptr(rspi_of_match),
1360 }, 1386 },
1361}; 1387};
diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 539d6d1a277a..101cd6aae2ea 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -397,7 +397,8 @@ static void sh_msiof_spi_set_mode_regs(struct sh_msiof_spi_priv *p,
397 397
398static void sh_msiof_reset_str(struct sh_msiof_spi_priv *p) 398static void sh_msiof_reset_str(struct sh_msiof_spi_priv *p)
399{ 399{
400 sh_msiof_write(p, STR, sh_msiof_read(p, STR)); 400 sh_msiof_write(p, STR,
401 sh_msiof_read(p, STR) & ~(STR_TDREQ | STR_RDREQ));
401} 402}
402 403
403static void sh_msiof_spi_write_fifo_8(struct sh_msiof_spi_priv *p, 404static void sh_msiof_spi_write_fifo_8(struct sh_msiof_spi_priv *p,
@@ -1426,12 +1427,37 @@ static const struct platform_device_id spi_driver_ids[] = {
1426}; 1427};
1427MODULE_DEVICE_TABLE(platform, spi_driver_ids); 1428MODULE_DEVICE_TABLE(platform, spi_driver_ids);
1428 1429
1430#ifdef CONFIG_PM_SLEEP
1431static int sh_msiof_spi_suspend(struct device *dev)
1432{
1433 struct platform_device *pdev = to_platform_device(dev);
1434 struct sh_msiof_spi_priv *p = platform_get_drvdata(pdev);
1435
1436 return spi_master_suspend(p->master);
1437}
1438
1439static int sh_msiof_spi_resume(struct device *dev)
1440{
1441 struct platform_device *pdev = to_platform_device(dev);
1442 struct sh_msiof_spi_priv *p = platform_get_drvdata(pdev);
1443
1444 return spi_master_resume(p->master);
1445}
1446
1447static SIMPLE_DEV_PM_OPS(sh_msiof_spi_pm_ops, sh_msiof_spi_suspend,
1448 sh_msiof_spi_resume);
1449#define DEV_PM_OPS &sh_msiof_spi_pm_ops
1450#else
1451#define DEV_PM_OPS NULL
1452#endif /* CONFIG_PM_SLEEP */
1453
1429static struct platform_driver sh_msiof_spi_drv = { 1454static struct platform_driver sh_msiof_spi_drv = {
1430 .probe = sh_msiof_spi_probe, 1455 .probe = sh_msiof_spi_probe,
1431 .remove = sh_msiof_spi_remove, 1456 .remove = sh_msiof_spi_remove,
1432 .id_table = spi_driver_ids, 1457 .id_table = spi_driver_ids,
1433 .driver = { 1458 .driver = {
1434 .name = "spi_sh_msiof", 1459 .name = "spi_sh_msiof",
1460 .pm = DEV_PM_OPS,
1435 .of_match_table = of_match_ptr(sh_msiof_match), 1461 .of_match_table = of_match_ptr(sh_msiof_match),
1436 }, 1462 },
1437}; 1463};
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 6f7b946b5ced..1427f343b39a 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1063,6 +1063,24 @@ static int tegra_slink_probe(struct platform_device *pdev)
1063 goto exit_free_master; 1063 goto exit_free_master;
1064 } 1064 }
1065 1065
1066 /* disabled clock may cause interrupt storm upon request */
1067 tspi->clk = devm_clk_get(&pdev->dev, NULL);
1068 if (IS_ERR(tspi->clk)) {
1069 ret = PTR_ERR(tspi->clk);
1070 dev_err(&pdev->dev, "Can not get clock %d\n", ret);
1071 goto exit_free_master;
1072 }
1073 ret = clk_prepare(tspi->clk);
1074 if (ret < 0) {
1075 dev_err(&pdev->dev, "Clock prepare failed %d\n", ret);
1076 goto exit_free_master;
1077 }
1078 ret = clk_enable(tspi->clk);
1079 if (ret < 0) {
1080 dev_err(&pdev->dev, "Clock enable failed %d\n", ret);
1081 goto exit_free_master;
1082 }
1083
1066 spi_irq = platform_get_irq(pdev, 0); 1084 spi_irq = platform_get_irq(pdev, 0);
1067 tspi->irq = spi_irq; 1085 tspi->irq = spi_irq;
1068 ret = request_threaded_irq(tspi->irq, tegra_slink_isr, 1086 ret = request_threaded_irq(tspi->irq, tegra_slink_isr,
@@ -1071,14 +1089,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
1071 if (ret < 0) { 1089 if (ret < 0) {
1072 dev_err(&pdev->dev, "Failed to register ISR for IRQ %d\n", 1090 dev_err(&pdev->dev, "Failed to register ISR for IRQ %d\n",
1073 tspi->irq); 1091 tspi->irq);
1074 goto exit_free_master; 1092 goto exit_clk_disable;
1075 }
1076
1077 tspi->clk = devm_clk_get(&pdev->dev, NULL);
1078 if (IS_ERR(tspi->clk)) {
1079 dev_err(&pdev->dev, "can not get clock\n");
1080 ret = PTR_ERR(tspi->clk);
1081 goto exit_free_irq;
1082 } 1093 }
1083 1094
1084 tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi"); 1095 tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
@@ -1138,6 +1149,8 @@ exit_rx_dma_free:
1138 tegra_slink_deinit_dma_param(tspi, true); 1149 tegra_slink_deinit_dma_param(tspi, true);
1139exit_free_irq: 1150exit_free_irq:
1140 free_irq(spi_irq, tspi); 1151 free_irq(spi_irq, tspi);
1152exit_clk_disable:
1153 clk_disable(tspi->clk);
1141exit_free_master: 1154exit_free_master:
1142 spi_master_put(master); 1155 spi_master_put(master);
1143 return ret; 1156 return ret;
@@ -1150,6 +1163,8 @@ static int tegra_slink_remove(struct platform_device *pdev)
1150 1163
1151 free_irq(tspi->irq, tspi); 1164 free_irq(tspi->irq, tspi);
1152 1165
1166 clk_disable(tspi->clk);
1167
1153 if (tspi->tx_dma_chan) 1168 if (tspi->tx_dma_chan)
1154 tegra_slink_deinit_dma_param(tspi, false); 1169 tegra_slink_deinit_dma_param(tspi, false);
1155 1170
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index ec395a6baf9c..9da0bc5a036c 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2143,8 +2143,17 @@ int spi_register_controller(struct spi_controller *ctlr)
2143 */ 2143 */
2144 if (ctlr->num_chipselect == 0) 2144 if (ctlr->num_chipselect == 0)
2145 return -EINVAL; 2145 return -EINVAL;
2146 /* allocate dynamic bus number using Linux idr */ 2146 if (ctlr->bus_num >= 0) {
2147 if ((ctlr->bus_num < 0) && ctlr->dev.of_node) { 2147 /* devices with a fixed bus num must check-in with the num */
2148 mutex_lock(&board_lock);
2149 id = idr_alloc(&spi_master_idr, ctlr, ctlr->bus_num,
2150 ctlr->bus_num + 1, GFP_KERNEL);
2151 mutex_unlock(&board_lock);
2152 if (WARN(id < 0, "couldn't get idr"))
2153 return id == -ENOSPC ? -EBUSY : id;
2154 ctlr->bus_num = id;
2155 } else if (ctlr->dev.of_node) {
2156 /* allocate dynamic bus number using Linux idr */
2148 id = of_alias_get_id(ctlr->dev.of_node, "spi"); 2157 id = of_alias_get_id(ctlr->dev.of_node, "spi");
2149 if (id >= 0) { 2158 if (id >= 0) {
2150 ctlr->bus_num = id; 2159 ctlr->bus_num = id;
diff --git a/drivers/staging/erofs/Kconfig b/drivers/staging/erofs/Kconfig
index 96f614934df1..663b755bf2fb 100644
--- a/drivers/staging/erofs/Kconfig
+++ b/drivers/staging/erofs/Kconfig
@@ -2,7 +2,7 @@
2 2
3config EROFS_FS 3config EROFS_FS
4 tristate "EROFS filesystem support" 4 tristate "EROFS filesystem support"
5 depends on BROKEN 5 depends on BLOCK
6 help 6 help
7 EROFS(Enhanced Read-Only File System) is a lightweight 7 EROFS(Enhanced Read-Only File System) is a lightweight
8 read-only file system with modern designs (eg. page-sized 8 read-only file system with modern designs (eg. page-sized
diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
index 1aec509c805f..2df9768edac9 100644
--- a/drivers/staging/erofs/super.c
+++ b/drivers/staging/erofs/super.c
@@ -340,7 +340,7 @@ static int erofs_read_super(struct super_block *sb,
340 goto err_sbread; 340 goto err_sbread;
341 341
342 sb->s_magic = EROFS_SUPER_MAGIC; 342 sb->s_magic = EROFS_SUPER_MAGIC;
343 sb->s_flags |= MS_RDONLY | MS_NOATIME; 343 sb->s_flags |= SB_RDONLY | SB_NOATIME;
344 sb->s_maxbytes = MAX_LFS_FILESIZE; 344 sb->s_maxbytes = MAX_LFS_FILESIZE;
345 sb->s_time_gran = 1; 345 sb->s_time_gran = 1;
346 346
@@ -627,7 +627,7 @@ static int erofs_remount(struct super_block *sb, int *flags, char *data)
627{ 627{
628 BUG_ON(!sb_rdonly(sb)); 628 BUG_ON(!sb_rdonly(sb));
629 629
630 *flags |= MS_RDONLY; 630 *flags |= SB_RDONLY;
631 return 0; 631 return 0;
632} 632}
633 633
diff --git a/drivers/staging/fbtft/TODO b/drivers/staging/fbtft/TODO
index 7e64c7e438f0..a9f4802bb6be 100644
--- a/drivers/staging/fbtft/TODO
+++ b/drivers/staging/fbtft/TODO
@@ -2,3 +2,7 @@
2 GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO 2 GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
3 lines from device tree, ACPI or board files, board files should 3 lines from device tree, ACPI or board files, board files should
4 use <linux/gpio/machine.h> 4 use <linux/gpio/machine.h>
5
6* convert all these over to drm_simple_display_pipe and submit for inclusion
7 into the DRM subsystem under drivers/gpu/drm - fbdev doesn't take any new
8 drivers anymore.
diff --git a/drivers/staging/gasket/TODO b/drivers/staging/gasket/TODO
index 6ff8e01b04cc..5b1865f8af2d 100644
--- a/drivers/staging/gasket/TODO
+++ b/drivers/staging/gasket/TODO
@@ -1,9 +1,22 @@
1This is a list of things that need to be done to get this driver out of the 1This is a list of things that need to be done to get this driver out of the
2staging directory. 2staging directory.
3
4- Implement the gasket framework's functionality through UIO instead of
5 introducing a new user-space drivers framework that is quite similar.
6
7 UIO provides the necessary bits to implement user-space drivers. Meanwhile
8 the gasket APIs adds some extra conveniences like PCI BAR mapping, and
9 MSI interrupts. Add these features to the UIO subsystem, then re-implement
10 the Apex driver as a basic UIO driver instead (include/linux/uio_driver.h)
11
3- Document sysfs files with Documentation/ABI/ entries. 12- Document sysfs files with Documentation/ABI/ entries.
13
4- Use misc interface instead of major number for driver version description. 14- Use misc interface instead of major number for driver version description.
15
5- Add descriptions of module_param's 16- Add descriptions of module_param's
17
6- apex_get_status() should actually check status. 18- apex_get_status() should actually check status.
19
7- "drivers" should never be dealing with "raw" sysfs calls or mess around with 20- "drivers" should never be dealing with "raw" sysfs calls or mess around with
8 kobjects at all. The driver core should handle all of this for you 21 kobjects at all. The driver core should handle all of this for you
9 automaically. There should not be a need for raw attribute macros. 22 automaically. There should not be a need for raw attribute macros.
diff --git a/drivers/staging/media/mt9t031/Kconfig b/drivers/staging/media/mt9t031/Kconfig
index f48e06a03cdb..9a58aaf72edd 100644
--- a/drivers/staging/media/mt9t031/Kconfig
+++ b/drivers/staging/media/mt9t031/Kconfig
@@ -1,9 +1,3 @@
1config SOC_CAMERA_IMX074
2 tristate "imx074 support (DEPRECATED)"
3 depends on SOC_CAMERA && I2C
4 help
5 This driver supports IMX074 cameras from Sony
6
7config SOC_CAMERA_MT9T031 1config SOC_CAMERA_MT9T031
8 tristate "mt9t031 support (DEPRECATED)" 2 tristate "mt9t031 support (DEPRECATED)"
9 depends on SOC_CAMERA && I2C 3 depends on SOC_CAMERA && I2C
diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c
index da92c493f157..69cc508af1bc 100644
--- a/drivers/staging/vboxvideo/vbox_drv.c
+++ b/drivers/staging/vboxvideo/vbox_drv.c
@@ -59,6 +59,11 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
59 ret = PTR_ERR(dev); 59 ret = PTR_ERR(dev);
60 goto err_drv_alloc; 60 goto err_drv_alloc;
61 } 61 }
62
63 ret = pci_enable_device(pdev);
64 if (ret)
65 goto err_pci_enable;
66
62 dev->pdev = pdev; 67 dev->pdev = pdev;
63 pci_set_drvdata(pdev, dev); 68 pci_set_drvdata(pdev, dev);
64 69
@@ -75,6 +80,8 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
75 err_drv_dev_register: 80 err_drv_dev_register:
76 vbox_driver_unload(dev); 81 vbox_driver_unload(dev);
77 err_vbox_driver_load: 82 err_vbox_driver_load:
83 pci_disable_device(pdev);
84 err_pci_enable:
78 drm_dev_put(dev); 85 drm_dev_put(dev);
79 err_drv_alloc: 86 err_drv_alloc:
80 return ret; 87 return ret;
diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index a83eac8668d0..79836c8fb909 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -323,6 +323,11 @@ static int vbox_crtc_page_flip(struct drm_crtc *crtc,
323 if (rc) 323 if (rc)
324 return rc; 324 return rc;
325 325
326 mutex_lock(&vbox->hw_mutex);
327 vbox_set_view(crtc);
328 vbox_do_modeset(crtc, &crtc->mode);
329 mutex_unlock(&vbox->hw_mutex);
330
326 spin_lock_irqsave(&drm->event_lock, flags); 331 spin_lock_irqsave(&drm->event_lock, flags);
327 332
328 if (event) 333 if (event)
diff --git a/drivers/staging/wilc1000/Makefile b/drivers/staging/wilc1000/Makefile
index f7b07c0b5ce2..ee7e26b886a5 100644
--- a/drivers/staging/wilc1000/Makefile
+++ b/drivers/staging/wilc1000/Makefile
@@ -1,4 +1,5 @@
1# SPDX-License-Identifier: GPL-2.0 1# SPDX-License-Identifier: GPL-2.0
2obj-$(CONFIG_WILC1000) += wilc1000.o
2 3
3ccflags-y += -DFIRMWARE_1002=\"atmel/wilc1002_firmware.bin\" \ 4ccflags-y += -DFIRMWARE_1002=\"atmel/wilc1002_firmware.bin\" \
4 -DFIRMWARE_1003=\"atmel/wilc1003_firmware.bin\" 5 -DFIRMWARE_1003=\"atmel/wilc1003_firmware.bin\"
@@ -11,9 +12,7 @@ wilc1000-objs := wilc_wfi_cfgoperations.o linux_wlan.o linux_mon.o \
11 wilc_wlan.o 12 wilc_wlan.o
12 13
13obj-$(CONFIG_WILC1000_SDIO) += wilc1000-sdio.o 14obj-$(CONFIG_WILC1000_SDIO) += wilc1000-sdio.o
14wilc1000-sdio-objs += $(wilc1000-objs)
15wilc1000-sdio-objs += wilc_sdio.o 15wilc1000-sdio-objs += wilc_sdio.o
16 16
17obj-$(CONFIG_WILC1000_SPI) += wilc1000-spi.o 17obj-$(CONFIG_WILC1000_SPI) += wilc1000-spi.o
18wilc1000-spi-objs += $(wilc1000-objs)
19wilc1000-spi-objs += wilc_spi.o 18wilc1000-spi-objs += wilc_spi.o
diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 01cf4bd2e192..3b8d237decbf 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -1038,8 +1038,8 @@ void wilc_netdev_cleanup(struct wilc *wilc)
1038 } 1038 }
1039 1039
1040 kfree(wilc); 1040 kfree(wilc);
1041 wilc_debugfs_remove();
1042} 1041}
1042EXPORT_SYMBOL_GPL(wilc_netdev_cleanup);
1043 1043
1044static const struct net_device_ops wilc_netdev_ops = { 1044static const struct net_device_ops wilc_netdev_ops = {
1045 .ndo_init = mac_init_fn, 1045 .ndo_init = mac_init_fn,
@@ -1062,7 +1062,6 @@ int wilc_netdev_init(struct wilc **wilc, struct device *dev, int io_type,
1062 if (!wl) 1062 if (!wl)
1063 return -ENOMEM; 1063 return -ENOMEM;
1064 1064
1065 wilc_debugfs_init();
1066 *wilc = wl; 1065 *wilc = wl;
1067 wl->io_type = io_type; 1066 wl->io_type = io_type;
1068 wl->hif_func = ops; 1067 wl->hif_func = ops;
@@ -1124,3 +1123,6 @@ int wilc_netdev_init(struct wilc **wilc, struct device *dev, int io_type,
1124 1123
1125 return 0; 1124 return 0;
1126} 1125}
1126EXPORT_SYMBOL_GPL(wilc_netdev_init);
1127
1128MODULE_LICENSE("GPL");
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index edc72876458d..8001df66b8c2 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -19,6 +19,7 @@ static struct dentry *wilc_dir;
19 19
20#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR) 20#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
21static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR); 21static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
22EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
22 23
23static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf, 24static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
24 size_t count, loff_t *ppos) 25 size_t count, loff_t *ppos)
@@ -87,7 +88,7 @@ static struct wilc_debugfs_info_t debugfs_info[] = {
87 }, 88 },
88}; 89};
89 90
90int wilc_debugfs_init(void) 91static int __init wilc_debugfs_init(void)
91{ 92{
92 int i; 93 int i;
93 struct wilc_debugfs_info_t *info; 94 struct wilc_debugfs_info_t *info;
@@ -103,10 +104,12 @@ int wilc_debugfs_init(void)
103 } 104 }
104 return 0; 105 return 0;
105} 106}
107module_init(wilc_debugfs_init);
106 108
107void wilc_debugfs_remove(void) 109static void __exit wilc_debugfs_remove(void)
108{ 110{
109 debugfs_remove_recursive(wilc_dir); 111 debugfs_remove_recursive(wilc_dir);
110} 112}
113module_exit(wilc_debugfs_remove);
111 114
112#endif 115#endif
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
index 6787b6e9f124..8b184aa30d25 100644
--- a/drivers/staging/wilc1000/wilc_wlan.c
+++ b/drivers/staging/wilc1000/wilc_wlan.c
@@ -417,6 +417,7 @@ void chip_allow_sleep(struct wilc *wilc)
417 wilc->hif_func->hif_write_reg(wilc, 0xf0, reg & ~BIT(0)); 417 wilc->hif_func->hif_write_reg(wilc, 0xf0, reg & ~BIT(0));
418 wilc->hif_func->hif_write_reg(wilc, 0xfa, 0); 418 wilc->hif_func->hif_write_reg(wilc, 0xfa, 0);
419} 419}
420EXPORT_SYMBOL_GPL(chip_allow_sleep);
420 421
421void chip_wakeup(struct wilc *wilc) 422void chip_wakeup(struct wilc *wilc)
422{ 423{
@@ -471,6 +472,7 @@ void chip_wakeup(struct wilc *wilc)
471 } 472 }
472 chip_ps_state = CHIP_WAKEDUP; 473 chip_ps_state = CHIP_WAKEDUP;
473} 474}
475EXPORT_SYMBOL_GPL(chip_wakeup);
474 476
475void wilc_chip_sleep_manually(struct wilc *wilc) 477void wilc_chip_sleep_manually(struct wilc *wilc)
476{ 478{
@@ -484,6 +486,7 @@ void wilc_chip_sleep_manually(struct wilc *wilc)
484 chip_ps_state = CHIP_SLEEPING_MANUAL; 486 chip_ps_state = CHIP_SLEEPING_MANUAL;
485 release_bus(wilc, RELEASE_ONLY); 487 release_bus(wilc, RELEASE_ONLY);
486} 488}
489EXPORT_SYMBOL_GPL(wilc_chip_sleep_manually);
487 490
488void host_wakeup_notify(struct wilc *wilc) 491void host_wakeup_notify(struct wilc *wilc)
489{ 492{
@@ -491,6 +494,7 @@ void host_wakeup_notify(struct wilc *wilc)
491 wilc->hif_func->hif_write_reg(wilc, 0x10b0, 1); 494 wilc->hif_func->hif_write_reg(wilc, 0x10b0, 1);
492 release_bus(wilc, RELEASE_ONLY); 495 release_bus(wilc, RELEASE_ONLY);
493} 496}
497EXPORT_SYMBOL_GPL(host_wakeup_notify);
494 498
495void host_sleep_notify(struct wilc *wilc) 499void host_sleep_notify(struct wilc *wilc)
496{ 500{
@@ -498,6 +502,7 @@ void host_sleep_notify(struct wilc *wilc)
498 wilc->hif_func->hif_write_reg(wilc, 0x10ac, 1); 502 wilc->hif_func->hif_write_reg(wilc, 0x10ac, 1);
499 release_bus(wilc, RELEASE_ONLY); 503 release_bus(wilc, RELEASE_ONLY);
500} 504}
505EXPORT_SYMBOL_GPL(host_sleep_notify);
501 506
502int wilc_wlan_handle_txq(struct net_device *dev, u32 *txq_count) 507int wilc_wlan_handle_txq(struct net_device *dev, u32 *txq_count)
503{ 508{
@@ -871,6 +876,7 @@ void wilc_handle_isr(struct wilc *wilc)
871 876
872 release_bus(wilc, RELEASE_ALLOW_SLEEP); 877 release_bus(wilc, RELEASE_ALLOW_SLEEP);
873} 878}
879EXPORT_SYMBOL_GPL(wilc_handle_isr);
874 880
875int wilc_wlan_firmware_download(struct wilc *wilc, const u8 *buffer, 881int wilc_wlan_firmware_download(struct wilc *wilc, const u8 *buffer,
876 u32 buffer_size) 882 u32 buffer_size)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wilc_wlan_if.h
index 00d13b153f80..b81a73b9bd67 100644
--- a/drivers/staging/wilc1000/wilc_wlan_if.h
+++ b/drivers/staging/wilc1000/wilc_wlan_if.h
@@ -831,6 +831,4 @@ struct wilc;
831int wilc_wlan_init(struct net_device *dev); 831int wilc_wlan_init(struct net_device *dev);
832u32 wilc_get_chipid(struct wilc *wilc, bool update); 832u32 wilc_get_chipid(struct wilc *wilc, bool update);
833 833
834int wilc_debugfs_init(void);
835void wilc_debugfs_remove(void);
836#endif 834#endif
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 94bad43c41ff..cc756a123fd8 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -1416,7 +1416,8 @@ static void iscsit_do_crypto_hash_buf(struct ahash_request *hash,
1416 1416
1417 sg_init_table(sg, ARRAY_SIZE(sg)); 1417 sg_init_table(sg, ARRAY_SIZE(sg));
1418 sg_set_buf(sg, buf, payload_length); 1418 sg_set_buf(sg, buf, payload_length);
1419 sg_set_buf(sg + 1, pad_bytes, padding); 1419 if (padding)
1420 sg_set_buf(sg + 1, pad_bytes, padding);
1420 1421
1421 ahash_request_set_crypt(hash, sg, data_crc, payload_length + padding); 1422 ahash_request_set_crypt(hash, sg, data_crc, payload_length + padding);
1422 1423
@@ -3910,10 +3911,14 @@ static bool iscsi_target_check_conn_state(struct iscsi_conn *conn)
3910static void iscsit_get_rx_pdu(struct iscsi_conn *conn) 3911static void iscsit_get_rx_pdu(struct iscsi_conn *conn)
3911{ 3912{
3912 int ret; 3913 int ret;
3913 u8 buffer[ISCSI_HDR_LEN], opcode; 3914 u8 *buffer, opcode;
3914 u32 checksum = 0, digest = 0; 3915 u32 checksum = 0, digest = 0;
3915 struct kvec iov; 3916 struct kvec iov;
3916 3917
3918 buffer = kcalloc(ISCSI_HDR_LEN, sizeof(*buffer), GFP_KERNEL);
3919 if (!buffer)
3920 return;
3921
3917 while (!kthread_should_stop()) { 3922 while (!kthread_should_stop()) {
3918 /* 3923 /*
3919 * Ensure that both TX and RX per connection kthreads 3924 * Ensure that both TX and RX per connection kthreads
@@ -3921,7 +3926,6 @@ static void iscsit_get_rx_pdu(struct iscsi_conn *conn)
3921 */ 3926 */
3922 iscsit_thread_check_cpumask(conn, current, 0); 3927 iscsit_thread_check_cpumask(conn, current, 0);
3923 3928
3924 memset(buffer, 0, ISCSI_HDR_LEN);
3925 memset(&iov, 0, sizeof(struct kvec)); 3929 memset(&iov, 0, sizeof(struct kvec));
3926 3930
3927 iov.iov_base = buffer; 3931 iov.iov_base = buffer;
@@ -3930,7 +3934,7 @@ static void iscsit_get_rx_pdu(struct iscsi_conn *conn)
3930 ret = rx_data(conn, &iov, 1, ISCSI_HDR_LEN); 3934 ret = rx_data(conn, &iov, 1, ISCSI_HDR_LEN);
3931 if (ret != ISCSI_HDR_LEN) { 3935 if (ret != ISCSI_HDR_LEN) {
3932 iscsit_rx_thread_wait_for_tcp(conn); 3936 iscsit_rx_thread_wait_for_tcp(conn);
3933 return; 3937 break;
3934 } 3938 }
3935 3939
3936 if (conn->conn_ops->HeaderDigest) { 3940 if (conn->conn_ops->HeaderDigest) {
@@ -3940,7 +3944,7 @@ static void iscsit_get_rx_pdu(struct iscsi_conn *conn)
3940 ret = rx_data(conn, &iov, 1, ISCSI_CRC_LEN); 3944 ret = rx_data(conn, &iov, 1, ISCSI_CRC_LEN);
3941 if (ret != ISCSI_CRC_LEN) { 3945 if (ret != ISCSI_CRC_LEN) {
3942 iscsit_rx_thread_wait_for_tcp(conn); 3946 iscsit_rx_thread_wait_for_tcp(conn);
3943 return; 3947 break;
3944 } 3948 }
3945 3949
3946 iscsit_do_crypto_hash_buf(conn->conn_rx_hash, buffer, 3950 iscsit_do_crypto_hash_buf(conn->conn_rx_hash, buffer,
@@ -3964,7 +3968,7 @@ static void iscsit_get_rx_pdu(struct iscsi_conn *conn)
3964 } 3968 }
3965 3969
3966 if (conn->conn_state == TARG_CONN_STATE_IN_LOGOUT) 3970 if (conn->conn_state == TARG_CONN_STATE_IN_LOGOUT)
3967 return; 3971 break;
3968 3972
3969 opcode = buffer[0] & ISCSI_OPCODE_MASK; 3973 opcode = buffer[0] & ISCSI_OPCODE_MASK;
3970 3974
@@ -3975,13 +3979,15 @@ static void iscsit_get_rx_pdu(struct iscsi_conn *conn)
3975 " while in Discovery Session, rejecting.\n", opcode); 3979 " while in Discovery Session, rejecting.\n", opcode);
3976 iscsit_add_reject(conn, ISCSI_REASON_PROTOCOL_ERROR, 3980 iscsit_add_reject(conn, ISCSI_REASON_PROTOCOL_ERROR,
3977 buffer); 3981 buffer);
3978 return; 3982 break;
3979 } 3983 }
3980 3984
3981 ret = iscsi_target_rx_opcode(conn, buffer); 3985 ret = iscsi_target_rx_opcode(conn, buffer);
3982 if (ret < 0) 3986 if (ret < 0)
3983 return; 3987 break;
3984 } 3988 }
3989
3990 kfree(buffer);
3985} 3991}
3986 3992
3987int iscsi_target_rx_thread(void *arg) 3993int iscsi_target_rx_thread(void *arg)
@@ -4208,22 +4214,15 @@ int iscsit_close_connection(
4208 crypto_free_ahash(tfm); 4214 crypto_free_ahash(tfm);
4209 } 4215 }
4210 4216
4211 free_cpumask_var(conn->conn_cpumask);
4212
4213 kfree(conn->conn_ops);
4214 conn->conn_ops = NULL;
4215
4216 if (conn->sock) 4217 if (conn->sock)
4217 sock_release(conn->sock); 4218 sock_release(conn->sock);
4218 4219
4219 if (conn->conn_transport->iscsit_free_conn) 4220 if (conn->conn_transport->iscsit_free_conn)
4220 conn->conn_transport->iscsit_free_conn(conn); 4221 conn->conn_transport->iscsit_free_conn(conn);
4221 4222
4222 iscsit_put_transport(conn->conn_transport);
4223
4224 pr_debug("Moving to TARG_CONN_STATE_FREE.\n"); 4223 pr_debug("Moving to TARG_CONN_STATE_FREE.\n");
4225 conn->conn_state = TARG_CONN_STATE_FREE; 4224 conn->conn_state = TARG_CONN_STATE_FREE;
4226 kfree(conn); 4225 iscsit_free_conn(conn);
4227 4226
4228 spin_lock_bh(&sess->conn_lock); 4227 spin_lock_bh(&sess->conn_lock);
4229 atomic_dec(&sess->nconn); 4228 atomic_dec(&sess->nconn);
diff --git a/drivers/target/iscsi/iscsi_target_auth.c b/drivers/target/iscsi/iscsi_target_auth.c
index 9518ffd8b8ba..4e680d753941 100644
--- a/drivers/target/iscsi/iscsi_target_auth.c
+++ b/drivers/target/iscsi/iscsi_target_auth.c
@@ -26,27 +26,6 @@
26#include "iscsi_target_nego.h" 26#include "iscsi_target_nego.h"
27#include "iscsi_target_auth.h" 27#include "iscsi_target_auth.h"
28 28
29static int chap_string_to_hex(unsigned char *dst, unsigned char *src, int len)
30{
31 int j = DIV_ROUND_UP(len, 2), rc;
32
33 rc = hex2bin(dst, src, j);
34 if (rc < 0)
35 pr_debug("CHAP string contains non hex digit symbols\n");
36
37 dst[j] = '\0';
38 return j;
39}
40
41static void chap_binaryhex_to_asciihex(char *dst, char *src, int src_len)
42{
43 int i;
44
45 for (i = 0; i < src_len; i++) {
46 sprintf(&dst[i*2], "%02x", (int) src[i] & 0xff);
47 }
48}
49
50static int chap_gen_challenge( 29static int chap_gen_challenge(
51 struct iscsi_conn *conn, 30 struct iscsi_conn *conn,
52 int caller, 31 int caller,
@@ -62,7 +41,7 @@ static int chap_gen_challenge(
62 ret = get_random_bytes_wait(chap->challenge, CHAP_CHALLENGE_LENGTH); 41 ret = get_random_bytes_wait(chap->challenge, CHAP_CHALLENGE_LENGTH);
63 if (unlikely(ret)) 42 if (unlikely(ret))
64 return ret; 43 return ret;
65 chap_binaryhex_to_asciihex(challenge_asciihex, chap->challenge, 44 bin2hex(challenge_asciihex, chap->challenge,
66 CHAP_CHALLENGE_LENGTH); 45 CHAP_CHALLENGE_LENGTH);
67 /* 46 /*
68 * Set CHAP_C, and copy the generated challenge into c_str. 47 * Set CHAP_C, and copy the generated challenge into c_str.
@@ -248,9 +227,16 @@ static int chap_server_compute_md5(
248 pr_err("Could not find CHAP_R.\n"); 227 pr_err("Could not find CHAP_R.\n");
249 goto out; 228 goto out;
250 } 229 }
230 if (strlen(chap_r) != MD5_SIGNATURE_SIZE * 2) {
231 pr_err("Malformed CHAP_R\n");
232 goto out;
233 }
234 if (hex2bin(client_digest, chap_r, MD5_SIGNATURE_SIZE) < 0) {
235 pr_err("Malformed CHAP_R\n");
236 goto out;
237 }
251 238
252 pr_debug("[server] Got CHAP_R=%s\n", chap_r); 239 pr_debug("[server] Got CHAP_R=%s\n", chap_r);
253 chap_string_to_hex(client_digest, chap_r, strlen(chap_r));
254 240
255 tfm = crypto_alloc_shash("md5", 0, 0); 241 tfm = crypto_alloc_shash("md5", 0, 0);
256 if (IS_ERR(tfm)) { 242 if (IS_ERR(tfm)) {
@@ -294,7 +280,7 @@ static int chap_server_compute_md5(
294 goto out; 280 goto out;
295 } 281 }
296 282
297 chap_binaryhex_to_asciihex(response, server_digest, MD5_SIGNATURE_SIZE); 283 bin2hex(response, server_digest, MD5_SIGNATURE_SIZE);
298 pr_debug("[server] MD5 Server Digest: %s\n", response); 284 pr_debug("[server] MD5 Server Digest: %s\n", response);
299 285
300 if (memcmp(server_digest, client_digest, MD5_SIGNATURE_SIZE) != 0) { 286 if (memcmp(server_digest, client_digest, MD5_SIGNATURE_SIZE) != 0) {
@@ -349,9 +335,7 @@ static int chap_server_compute_md5(
349 pr_err("Could not find CHAP_C.\n"); 335 pr_err("Could not find CHAP_C.\n");
350 goto out; 336 goto out;
351 } 337 }
352 pr_debug("[server] Got CHAP_C=%s\n", challenge); 338 challenge_len = DIV_ROUND_UP(strlen(challenge), 2);
353 challenge_len = chap_string_to_hex(challenge_binhex, challenge,
354 strlen(challenge));
355 if (!challenge_len) { 339 if (!challenge_len) {
356 pr_err("Unable to convert incoming challenge\n"); 340 pr_err("Unable to convert incoming challenge\n");
357 goto out; 341 goto out;
@@ -360,6 +344,11 @@ static int chap_server_compute_md5(
360 pr_err("CHAP_C exceeds maximum binary size of 1024 bytes\n"); 344 pr_err("CHAP_C exceeds maximum binary size of 1024 bytes\n");
361 goto out; 345 goto out;
362 } 346 }
347 if (hex2bin(challenge_binhex, challenge, challenge_len) < 0) {
348 pr_err("Malformed CHAP_C\n");
349 goto out;
350 }
351 pr_debug("[server] Got CHAP_C=%s\n", challenge);
363 /* 352 /*
364 * During mutual authentication, the CHAP_C generated by the 353 * During mutual authentication, the CHAP_C generated by the
365 * initiator must not match the original CHAP_C generated by 354 * initiator must not match the original CHAP_C generated by
@@ -413,7 +402,7 @@ static int chap_server_compute_md5(
413 /* 402 /*
414 * Convert response from binary hex to ascii hext. 403 * Convert response from binary hex to ascii hext.
415 */ 404 */
416 chap_binaryhex_to_asciihex(response, digest, MD5_SIGNATURE_SIZE); 405 bin2hex(response, digest, MD5_SIGNATURE_SIZE);
417 *nr_out_len += sprintf(nr_out_ptr + *nr_out_len, "CHAP_R=0x%s", 406 *nr_out_len += sprintf(nr_out_ptr + *nr_out_len, "CHAP_R=0x%s",
418 response); 407 response);
419 *nr_out_len += 1; 408 *nr_out_len += 1;
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index 9e74f8bc2963..bb90c80ff388 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -67,45 +67,10 @@ static struct iscsi_login *iscsi_login_init_conn(struct iscsi_conn *conn)
67 goto out_req_buf; 67 goto out_req_buf;
68 } 68 }
69 69
70 conn->conn_ops = kzalloc(sizeof(struct iscsi_conn_ops), GFP_KERNEL);
71 if (!conn->conn_ops) {
72 pr_err("Unable to allocate memory for"
73 " struct iscsi_conn_ops.\n");
74 goto out_rsp_buf;
75 }
76
77 init_waitqueue_head(&conn->queues_wq);
78 INIT_LIST_HEAD(&conn->conn_list);
79 INIT_LIST_HEAD(&conn->conn_cmd_list);
80 INIT_LIST_HEAD(&conn->immed_queue_list);
81 INIT_LIST_HEAD(&conn->response_queue_list);
82 init_completion(&conn->conn_post_wait_comp);
83 init_completion(&conn->conn_wait_comp);
84 init_completion(&conn->conn_wait_rcfr_comp);
85 init_completion(&conn->conn_waiting_on_uc_comp);
86 init_completion(&conn->conn_logout_comp);
87 init_completion(&conn->rx_half_close_comp);
88 init_completion(&conn->tx_half_close_comp);
89 init_completion(&conn->rx_login_comp);
90 spin_lock_init(&conn->cmd_lock);
91 spin_lock_init(&conn->conn_usage_lock);
92 spin_lock_init(&conn->immed_queue_lock);
93 spin_lock_init(&conn->nopin_timer_lock);
94 spin_lock_init(&conn->response_queue_lock);
95 spin_lock_init(&conn->state_lock);
96
97 if (!zalloc_cpumask_var(&conn->conn_cpumask, GFP_KERNEL)) {
98 pr_err("Unable to allocate conn->conn_cpumask\n");
99 goto out_conn_ops;
100 }
101 conn->conn_login = login; 70 conn->conn_login = login;
102 71
103 return login; 72 return login;
104 73
105out_conn_ops:
106 kfree(conn->conn_ops);
107out_rsp_buf:
108 kfree(login->rsp_buf);
109out_req_buf: 74out_req_buf:
110 kfree(login->req_buf); 75 kfree(login->req_buf);
111out_login: 76out_login:
@@ -310,11 +275,9 @@ static int iscsi_login_zero_tsih_s1(
310 return -ENOMEM; 275 return -ENOMEM;
311 } 276 }
312 277
313 ret = iscsi_login_set_conn_values(sess, conn, pdu->cid); 278 if (iscsi_login_set_conn_values(sess, conn, pdu->cid))
314 if (unlikely(ret)) { 279 goto free_sess;
315 kfree(sess); 280
316 return ret;
317 }
318 sess->init_task_tag = pdu->itt; 281 sess->init_task_tag = pdu->itt;
319 memcpy(&sess->isid, pdu->isid, 6); 282 memcpy(&sess->isid, pdu->isid, 6);
320 sess->exp_cmd_sn = be32_to_cpu(pdu->cmdsn); 283 sess->exp_cmd_sn = be32_to_cpu(pdu->cmdsn);
@@ -1149,6 +1112,75 @@ iscsit_conn_set_transport(struct iscsi_conn *conn, struct iscsit_transport *t)
1149 return 0; 1112 return 0;
1150} 1113}
1151 1114
1115static struct iscsi_conn *iscsit_alloc_conn(struct iscsi_np *np)
1116{
1117 struct iscsi_conn *conn;
1118
1119 conn = kzalloc(sizeof(struct iscsi_conn), GFP_KERNEL);
1120 if (!conn) {
1121 pr_err("Could not allocate memory for new connection\n");
1122 return NULL;
1123 }
1124 pr_debug("Moving to TARG_CONN_STATE_FREE.\n");
1125 conn->conn_state = TARG_CONN_STATE_FREE;
1126
1127 init_waitqueue_head(&conn->queues_wq);
1128 INIT_LIST_HEAD(&conn->conn_list);
1129 INIT_LIST_HEAD(&conn->conn_cmd_list);
1130 INIT_LIST_HEAD(&conn->immed_queue_list);
1131 INIT_LIST_HEAD(&conn->response_queue_list);
1132 init_completion(&conn->conn_post_wait_comp);
1133 init_completion(&conn->conn_wait_comp);
1134 init_completion(&conn->conn_wait_rcfr_comp);
1135 init_completion(&conn->conn_waiting_on_uc_comp);
1136 init_completion(&conn->conn_logout_comp);
1137 init_completion(&conn->rx_half_close_comp);
1138 init_completion(&conn->tx_half_close_comp);
1139 init_completion(&conn->rx_login_comp);
1140 spin_lock_init(&conn->cmd_lock);
1141 spin_lock_init(&conn->conn_usage_lock);
1142 spin_lock_init(&conn->immed_queue_lock);
1143 spin_lock_init(&conn->nopin_timer_lock);
1144 spin_lock_init(&conn->response_queue_lock);
1145 spin_lock_init(&conn->state_lock);
1146
1147 timer_setup(&conn->nopin_response_timer,
1148 iscsit_handle_nopin_response_timeout, 0);
1149 timer_setup(&conn->nopin_timer, iscsit_handle_nopin_timeout, 0);
1150
1151 if (iscsit_conn_set_transport(conn, np->np_transport) < 0)
1152 goto free_conn;
1153
1154 conn->conn_ops = kzalloc(sizeof(struct iscsi_conn_ops), GFP_KERNEL);
1155 if (!conn->conn_ops) {
1156 pr_err("Unable to allocate memory for struct iscsi_conn_ops.\n");
1157 goto put_transport;
1158 }
1159
1160 if (!zalloc_cpumask_var(&conn->conn_cpumask, GFP_KERNEL)) {
1161 pr_err("Unable to allocate conn->conn_cpumask\n");
1162 goto free_mask;
1163 }
1164
1165 return conn;
1166
1167free_mask:
1168 free_cpumask_var(conn->conn_cpumask);
1169put_transport:
1170 iscsit_put_transport(conn->conn_transport);
1171free_conn:
1172 kfree(conn);
1173 return NULL;
1174}
1175
1176void iscsit_free_conn(struct iscsi_conn *conn)
1177{
1178 free_cpumask_var(conn->conn_cpumask);
1179 kfree(conn->conn_ops);
1180 iscsit_put_transport(conn->conn_transport);
1181 kfree(conn);
1182}
1183
1152void iscsi_target_login_sess_out(struct iscsi_conn *conn, 1184void iscsi_target_login_sess_out(struct iscsi_conn *conn,
1153 struct iscsi_np *np, bool zero_tsih, bool new_sess) 1185 struct iscsi_np *np, bool zero_tsih, bool new_sess)
1154{ 1186{
@@ -1198,10 +1230,6 @@ old_sess_out:
1198 crypto_free_ahash(tfm); 1230 crypto_free_ahash(tfm);
1199 } 1231 }
1200 1232
1201 free_cpumask_var(conn->conn_cpumask);
1202
1203 kfree(conn->conn_ops);
1204
1205 if (conn->param_list) { 1233 if (conn->param_list) {
1206 iscsi_release_param_list(conn->param_list); 1234 iscsi_release_param_list(conn->param_list);
1207 conn->param_list = NULL; 1235 conn->param_list = NULL;
@@ -1219,8 +1247,7 @@ old_sess_out:
1219 if (conn->conn_transport->iscsit_free_conn) 1247 if (conn->conn_transport->iscsit_free_conn)
1220 conn->conn_transport->iscsit_free_conn(conn); 1248 conn->conn_transport->iscsit_free_conn(conn);
1221 1249
1222 iscsit_put_transport(conn->conn_transport); 1250 iscsit_free_conn(conn);
1223 kfree(conn);
1224} 1251}
1225 1252
1226static int __iscsi_target_login_thread(struct iscsi_np *np) 1253static int __iscsi_target_login_thread(struct iscsi_np *np)
@@ -1250,31 +1277,16 @@ static int __iscsi_target_login_thread(struct iscsi_np *np)
1250 } 1277 }
1251 spin_unlock_bh(&np->np_thread_lock); 1278 spin_unlock_bh(&np->np_thread_lock);
1252 1279
1253 conn = kzalloc(sizeof(struct iscsi_conn), GFP_KERNEL); 1280 conn = iscsit_alloc_conn(np);
1254 if (!conn) { 1281 if (!conn) {
1255 pr_err("Could not allocate memory for"
1256 " new connection\n");
1257 /* Get another socket */ 1282 /* Get another socket */
1258 return 1; 1283 return 1;
1259 } 1284 }
1260 pr_debug("Moving to TARG_CONN_STATE_FREE.\n");
1261 conn->conn_state = TARG_CONN_STATE_FREE;
1262
1263 timer_setup(&conn->nopin_response_timer,
1264 iscsit_handle_nopin_response_timeout, 0);
1265 timer_setup(&conn->nopin_timer, iscsit_handle_nopin_timeout, 0);
1266
1267 if (iscsit_conn_set_transport(conn, np->np_transport) < 0) {
1268 kfree(conn);
1269 return 1;
1270 }
1271 1285
1272 rc = np->np_transport->iscsit_accept_np(np, conn); 1286 rc = np->np_transport->iscsit_accept_np(np, conn);
1273 if (rc == -ENOSYS) { 1287 if (rc == -ENOSYS) {
1274 complete(&np->np_restart_comp); 1288 complete(&np->np_restart_comp);
1275 iscsit_put_transport(conn->conn_transport); 1289 iscsit_free_conn(conn);
1276 kfree(conn);
1277 conn = NULL;
1278 goto exit; 1290 goto exit;
1279 } else if (rc < 0) { 1291 } else if (rc < 0) {
1280 spin_lock_bh(&np->np_thread_lock); 1292 spin_lock_bh(&np->np_thread_lock);
@@ -1282,17 +1294,13 @@ static int __iscsi_target_login_thread(struct iscsi_np *np)
1282 np->np_thread_state = ISCSI_NP_THREAD_ACTIVE; 1294 np->np_thread_state = ISCSI_NP_THREAD_ACTIVE;
1283 spin_unlock_bh(&np->np_thread_lock); 1295 spin_unlock_bh(&np->np_thread_lock);
1284 complete(&np->np_restart_comp); 1296 complete(&np->np_restart_comp);
1285 iscsit_put_transport(conn->conn_transport); 1297 iscsit_free_conn(conn);
1286 kfree(conn);
1287 conn = NULL;
1288 /* Get another socket */ 1298 /* Get another socket */
1289 return 1; 1299 return 1;
1290 } 1300 }
1291 spin_unlock_bh(&np->np_thread_lock); 1301 spin_unlock_bh(&np->np_thread_lock);
1292 iscsit_put_transport(conn->conn_transport); 1302 iscsit_free_conn(conn);
1293 kfree(conn); 1303 return 1;
1294 conn = NULL;
1295 goto out;
1296 } 1304 }
1297 /* 1305 /*
1298 * Perform the remaining iSCSI connection initialization items.. 1306 * Perform the remaining iSCSI connection initialization items..
@@ -1442,7 +1450,6 @@ old_sess_out:
1442 tpg_np = NULL; 1450 tpg_np = NULL;
1443 } 1451 }
1444 1452
1445out:
1446 return 1; 1453 return 1;
1447 1454
1448exit: 1455exit:
diff --git a/drivers/target/iscsi/iscsi_target_login.h b/drivers/target/iscsi/iscsi_target_login.h
index 74ac3abc44a0..3b8e3639ff5d 100644
--- a/drivers/target/iscsi/iscsi_target_login.h
+++ b/drivers/target/iscsi/iscsi_target_login.h
@@ -19,7 +19,7 @@ extern int iscsi_target_setup_login_socket(struct iscsi_np *,
19extern int iscsit_accept_np(struct iscsi_np *, struct iscsi_conn *); 19extern int iscsit_accept_np(struct iscsi_np *, struct iscsi_conn *);
20extern int iscsit_get_login_rx(struct iscsi_conn *, struct iscsi_login *); 20extern int iscsit_get_login_rx(struct iscsi_conn *, struct iscsi_login *);
21extern int iscsit_put_login_tx(struct iscsi_conn *, struct iscsi_login *, u32); 21extern int iscsit_put_login_tx(struct iscsi_conn *, struct iscsi_login *, u32);
22extern void iscsit_free_conn(struct iscsi_np *, struct iscsi_conn *); 22extern void iscsit_free_conn(struct iscsi_conn *);
23extern int iscsit_start_kthreads(struct iscsi_conn *); 23extern int iscsit_start_kthreads(struct iscsi_conn *);
24extern void iscsi_post_login_handler(struct iscsi_np *, struct iscsi_conn *, u8); 24extern void iscsi_post_login_handler(struct iscsi_np *, struct iscsi_conn *, u8);
25extern void iscsi_target_login_sess_out(struct iscsi_conn *, struct iscsi_np *, 25extern void iscsi_target_login_sess_out(struct iscsi_conn *, struct iscsi_np *,
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index e1e264a9a4c7..28fc4ce75edb 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -738,14 +738,6 @@ icm_fr_xdomain_connected(struct tb *tb, const struct icm_pkg_header *hdr)
738 u8 link, depth; 738 u8 link, depth;
739 u64 route; 739 u64 route;
740 740
741 /*
742 * After NVM upgrade adding root switch device fails because we
743 * initiated reset. During that time ICM might still send
744 * XDomain connected message which we ignore here.
745 */
746 if (!tb->root_switch)
747 return;
748
749 link = pkg->link_info & ICM_LINK_INFO_LINK_MASK; 741 link = pkg->link_info & ICM_LINK_INFO_LINK_MASK;
750 depth = (pkg->link_info & ICM_LINK_INFO_DEPTH_MASK) >> 742 depth = (pkg->link_info & ICM_LINK_INFO_DEPTH_MASK) >>
751 ICM_LINK_INFO_DEPTH_SHIFT; 743 ICM_LINK_INFO_DEPTH_SHIFT;
@@ -1037,14 +1029,6 @@ icm_tr_device_connected(struct tb *tb, const struct icm_pkg_header *hdr)
1037 if (pkg->hdr.packet_id) 1029 if (pkg->hdr.packet_id)
1038 return; 1030 return;
1039 1031
1040 /*
1041 * After NVM upgrade adding root switch device fails because we
1042 * initiated reset. During that time ICM might still send device
1043 * connected message which we ignore here.
1044 */
1045 if (!tb->root_switch)
1046 return;
1047
1048 route = get_route(pkg->route_hi, pkg->route_lo); 1032 route = get_route(pkg->route_hi, pkg->route_lo);
1049 authorized = pkg->link_info & ICM_LINK_INFO_APPROVED; 1033 authorized = pkg->link_info & ICM_LINK_INFO_APPROVED;
1050 security_level = (pkg->hdr.flags & ICM_FLAGS_SLEVEL_MASK) >> 1034 security_level = (pkg->hdr.flags & ICM_FLAGS_SLEVEL_MASK) >>
@@ -1408,19 +1392,26 @@ static void icm_handle_notification(struct work_struct *work)
1408 1392
1409 mutex_lock(&tb->lock); 1393 mutex_lock(&tb->lock);
1410 1394
1411 switch (n->pkg->code) { 1395 /*
1412 case ICM_EVENT_DEVICE_CONNECTED: 1396 * When the domain is stopped we flush its workqueue but before
1413 icm->device_connected(tb, n->pkg); 1397 * that the root switch is removed. In that case we should treat
1414 break; 1398 * the queued events as being canceled.
1415 case ICM_EVENT_DEVICE_DISCONNECTED: 1399 */
1416 icm->device_disconnected(tb, n->pkg); 1400 if (tb->root_switch) {
1417 break; 1401 switch (n->pkg->code) {
1418 case ICM_EVENT_XDOMAIN_CONNECTED: 1402 case ICM_EVENT_DEVICE_CONNECTED:
1419 icm->xdomain_connected(tb, n->pkg); 1403 icm->device_connected(tb, n->pkg);
1420 break; 1404 break;
1421 case ICM_EVENT_XDOMAIN_DISCONNECTED: 1405 case ICM_EVENT_DEVICE_DISCONNECTED:
1422 icm->xdomain_disconnected(tb, n->pkg); 1406 icm->device_disconnected(tb, n->pkg);
1423 break; 1407 break;
1408 case ICM_EVENT_XDOMAIN_CONNECTED:
1409 icm->xdomain_connected(tb, n->pkg);
1410 break;
1411 case ICM_EVENT_XDOMAIN_DISCONNECTED:
1412 icm->xdomain_disconnected(tb, n->pkg);
1413 break;
1414 }
1424 } 1415 }
1425 1416
1426 mutex_unlock(&tb->lock); 1417 mutex_unlock(&tb->lock);
diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
index 88cff05a1808..5cd6bdfa068f 100644
--- a/drivers/thunderbolt/nhi.c
+++ b/drivers/thunderbolt/nhi.c
@@ -1191,5 +1191,5 @@ static void __exit nhi_unload(void)
1191 tb_domain_exit(); 1191 tb_domain_exit();
1192} 1192}
1193 1193
1194fs_initcall(nhi_init); 1194rootfs_initcall(nhi_init);
1195module_exit(nhi_unload); 1195module_exit(nhi_unload);
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 5414c4a87bea..27284a2dcd2b 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -522,6 +522,8 @@ static int hvc_write(struct tty_struct *tty, const unsigned char *buf, int count
522 return -EIO; 522 return -EIO;
523 523
524 while (count > 0) { 524 while (count > 0) {
525 int ret = 0;
526
525 spin_lock_irqsave(&hp->lock, flags); 527 spin_lock_irqsave(&hp->lock, flags);
526 528
527 rsize = hp->outbuf_size - hp->n_outbuf; 529 rsize = hp->outbuf_size - hp->n_outbuf;
@@ -537,10 +539,13 @@ static int hvc_write(struct tty_struct *tty, const unsigned char *buf, int count
537 } 539 }
538 540
539 if (hp->n_outbuf > 0) 541 if (hp->n_outbuf > 0)
540 hvc_push(hp); 542 ret = hvc_push(hp);
541 543
542 spin_unlock_irqrestore(&hp->lock, flags); 544 spin_unlock_irqrestore(&hp->lock, flags);
543 545
546 if (!ret)
547 break;
548
544 if (count) { 549 if (count) {
545 if (hp->n_outbuf > 0) 550 if (hp->n_outbuf > 0)
546 hvc_flush(hp); 551 hvc_flush(hp);
@@ -623,6 +628,15 @@ static int hvc_chars_in_buffer(struct tty_struct *tty)
623#define MAX_TIMEOUT (2000) 628#define MAX_TIMEOUT (2000)
624static u32 timeout = MIN_TIMEOUT; 629static u32 timeout = MIN_TIMEOUT;
625 630
631/*
632 * Maximum number of bytes to get from the console driver if hvc_poll is
633 * called from driver (and can't sleep). Any more than this and we break
634 * and start polling with khvcd. This value was derived from from an OpenBMC
635 * console with the OPAL driver that results in about 0.25ms interrupts off
636 * latency.
637 */
638#define HVC_ATOMIC_READ_MAX 128
639
626#define HVC_POLL_READ 0x00000001 640#define HVC_POLL_READ 0x00000001
627#define HVC_POLL_WRITE 0x00000002 641#define HVC_POLL_WRITE 0x00000002
628 642
@@ -669,8 +683,8 @@ static int __hvc_poll(struct hvc_struct *hp, bool may_sleep)
669 if (!hp->irq_requested) 683 if (!hp->irq_requested)
670 poll_mask |= HVC_POLL_READ; 684 poll_mask |= HVC_POLL_READ;
671 685
686 read_again:
672 /* Read data if any */ 687 /* Read data if any */
673
674 count = tty_buffer_request_room(&hp->port, N_INBUF); 688 count = tty_buffer_request_room(&hp->port, N_INBUF);
675 689
676 /* If flip is full, just reschedule a later read */ 690 /* If flip is full, just reschedule a later read */
@@ -717,9 +731,23 @@ static int __hvc_poll(struct hvc_struct *hp, bool may_sleep)
717#endif /* CONFIG_MAGIC_SYSRQ */ 731#endif /* CONFIG_MAGIC_SYSRQ */
718 tty_insert_flip_char(&hp->port, buf[i], 0); 732 tty_insert_flip_char(&hp->port, buf[i], 0);
719 } 733 }
720 if (n == count) 734 read_total += n;
721 poll_mask |= HVC_POLL_READ; 735
722 read_total = n; 736 if (may_sleep) {
737 /* Keep going until the flip is full */
738 spin_unlock_irqrestore(&hp->lock, flags);
739 cond_resched();
740 spin_lock_irqsave(&hp->lock, flags);
741 goto read_again;
742 } else if (read_total < HVC_ATOMIC_READ_MAX) {
743 /* Break and defer if it's a large read in atomic */
744 goto read_again;
745 }
746
747 /*
748 * Latency break, schedule another poll immediately.
749 */
750 poll_mask |= HVC_POLL_READ;
723 751
724 out: 752 out:
725 /* Wakeup write queue if necessary */ 753 /* Wakeup write queue if necessary */
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index fa8dcb470640..d31b975dd3fd 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -630,10 +630,6 @@ static int dw8250_probe(struct platform_device *pdev)
630 if (!data->skip_autocfg) 630 if (!data->skip_autocfg)
631 dw8250_setup_port(p); 631 dw8250_setup_port(p);
632 632
633#ifdef CONFIG_PM
634 uart.capabilities |= UART_CAP_RPM;
635#endif
636
637 /* If we have a valid fifosize, try hooking up DMA */ 633 /* If we have a valid fifosize, try hooking up DMA */
638 if (p->fifosize) { 634 if (p->fifosize) {
639 data->dma.rxconf.src_maxburst = p->fifosize / 4; 635 data->dma.rxconf.src_maxburst = p->fifosize / 4;
diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_core.c b/drivers/tty/serial/cpm_uart/cpm_uart_core.c
index 24a5f05e769b..e5389591bb4f 100644
--- a/drivers/tty/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/tty/serial/cpm_uart/cpm_uart_core.c
@@ -1054,8 +1054,8 @@ static int poll_wait_key(char *obuf, struct uart_cpm_port *pinfo)
1054 /* Get the address of the host memory buffer. 1054 /* Get the address of the host memory buffer.
1055 */ 1055 */
1056 bdp = pinfo->rx_cur; 1056 bdp = pinfo->rx_cur;
1057 while (bdp->cbd_sc & BD_SC_EMPTY) 1057 if (bdp->cbd_sc & BD_SC_EMPTY)
1058 ; 1058 return NO_POLL_CHAR;
1059 1059
1060 /* If the buffer address is in the CPM DPRAM, don't 1060 /* If the buffer address is in the CPM DPRAM, don't
1061 * convert it. 1061 * convert it.
@@ -1090,7 +1090,11 @@ static int cpm_get_poll_char(struct uart_port *port)
1090 poll_chars = 0; 1090 poll_chars = 0;
1091 } 1091 }
1092 if (poll_chars <= 0) { 1092 if (poll_chars <= 0) {
1093 poll_chars = poll_wait_key(poll_buf, pinfo); 1093 int ret = poll_wait_key(poll_buf, pinfo);
1094
1095 if (ret == NO_POLL_CHAR)
1096 return ret;
1097 poll_chars = ret;
1094 pollp = poll_buf; 1098 pollp = poll_buf;
1095 } 1099 }
1096 poll_chars--; 1100 poll_chars--;
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 51e47a63d61a..3f8d1274fc85 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -979,7 +979,8 @@ static inline int lpuart_start_rx_dma(struct lpuart_port *sport)
979 struct circ_buf *ring = &sport->rx_ring; 979 struct circ_buf *ring = &sport->rx_ring;
980 int ret, nent; 980 int ret, nent;
981 int bits, baud; 981 int bits, baud;
982 struct tty_struct *tty = tty_port_tty_get(&sport->port.state->port); 982 struct tty_port *port = &sport->port.state->port;
983 struct tty_struct *tty = port->tty;
983 struct ktermios *termios = &tty->termios; 984 struct ktermios *termios = &tty->termios;
984 985
985 baud = tty_get_baud_rate(tty); 986 baud = tty_get_baud_rate(tty);
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 239c0fa2e981..0f67197a3783 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2351,6 +2351,14 @@ static int imx_uart_probe(struct platform_device *pdev)
2351 ret); 2351 ret);
2352 return ret; 2352 return ret;
2353 } 2353 }
2354
2355 ret = devm_request_irq(&pdev->dev, rtsirq, imx_uart_rtsint, 0,
2356 dev_name(&pdev->dev), sport);
2357 if (ret) {
2358 dev_err(&pdev->dev, "failed to request rts irq: %d\n",
2359 ret);
2360 return ret;
2361 }
2354 } else { 2362 } else {
2355 ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_int, 0, 2363 ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_int, 0,
2356 dev_name(&pdev->dev), sport); 2364 dev_name(&pdev->dev), sport);
diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
index d04b5eeea3c6..170e446a2f62 100644
--- a/drivers/tty/serial/mvebu-uart.c
+++ b/drivers/tty/serial/mvebu-uart.c
@@ -511,6 +511,7 @@ static void mvebu_uart_set_termios(struct uart_port *port,
511 termios->c_iflag |= old->c_iflag & ~(INPCK | IGNPAR); 511 termios->c_iflag |= old->c_iflag & ~(INPCK | IGNPAR);
512 termios->c_cflag &= CREAD | CBAUD; 512 termios->c_cflag &= CREAD | CBAUD;
513 termios->c_cflag |= old->c_cflag & ~(CREAD | CBAUD); 513 termios->c_cflag |= old->c_cflag & ~(CREAD | CBAUD);
514 termios->c_cflag |= CS8;
514 } 515 }
515 516
516 spin_unlock_irqrestore(&port->lock, flags); 517 spin_unlock_irqrestore(&port->lock, flags);
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 29ec34387246..1515074e18fb 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -868,8 +868,8 @@ static int qcom_geni_serial_port_setup(struct uart_port *uport)
868 geni_se_init(&port->se, port->rx_wm, port->rx_rfr); 868 geni_se_init(&port->se, port->rx_wm, port->rx_rfr);
869 geni_se_select_mode(&port->se, port->xfer_mode); 869 geni_se_select_mode(&port->se, port->xfer_mode);
870 if (!uart_console(uport)) { 870 if (!uart_console(uport)) {
871 port->rx_fifo = devm_kzalloc(uport->dev, 871 port->rx_fifo = devm_kcalloc(uport->dev,
872 port->rx_fifo_depth * sizeof(u32), GFP_KERNEL); 872 port->rx_fifo_depth, sizeof(u32), GFP_KERNEL);
873 if (!port->rx_fifo) 873 if (!port->rx_fifo)
874 return -ENOMEM; 874 return -ENOMEM;
875 } 875 }
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index ac4424bf6b13..ab3f6e91853d 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -292,6 +292,33 @@ static const struct sci_port_params sci_port_params[SCIx_NR_REGTYPES] = {
292 }, 292 },
293 293
294 /* 294 /*
295 * The "SCIFA" that is in RZ/T and RZ/A2.
296 * It looks like a normal SCIF with FIFO data, but with a
297 * compressed address space. Also, the break out of interrupts
298 * are different: ERI/BRI, RXI, TXI, TEI, DRI.
299 */
300 [SCIx_RZ_SCIFA_REGTYPE] = {
301 .regs = {
302 [SCSMR] = { 0x00, 16 },
303 [SCBRR] = { 0x02, 8 },
304 [SCSCR] = { 0x04, 16 },
305 [SCxTDR] = { 0x06, 8 },
306 [SCxSR] = { 0x08, 16 },
307 [SCxRDR] = { 0x0A, 8 },
308 [SCFCR] = { 0x0C, 16 },
309 [SCFDR] = { 0x0E, 16 },
310 [SCSPTR] = { 0x10, 16 },
311 [SCLSR] = { 0x12, 16 },
312 },
313 .fifosize = 16,
314 .overrun_reg = SCLSR,
315 .overrun_mask = SCLSR_ORER,
316 .sampling_rate_mask = SCI_SR(32),
317 .error_mask = SCIF_DEFAULT_ERROR_MASK,
318 .error_clear = SCIF_ERROR_CLEAR,
319 },
320
321 /*
295 * Common SH-3 SCIF definitions. 322 * Common SH-3 SCIF definitions.
296 */ 323 */
297 [SCIx_SH3_SCIF_REGTYPE] = { 324 [SCIx_SH3_SCIF_REGTYPE] = {
@@ -319,15 +346,15 @@ static const struct sci_port_params sci_port_params[SCIx_NR_REGTYPES] = {
319 [SCIx_SH4_SCIF_REGTYPE] = { 346 [SCIx_SH4_SCIF_REGTYPE] = {
320 .regs = { 347 .regs = {
321 [SCSMR] = { 0x00, 16 }, 348 [SCSMR] = { 0x00, 16 },
322 [SCBRR] = { 0x02, 8 }, 349 [SCBRR] = { 0x04, 8 },
323 [SCSCR] = { 0x04, 16 }, 350 [SCSCR] = { 0x08, 16 },
324 [SCxTDR] = { 0x06, 8 }, 351 [SCxTDR] = { 0x0c, 8 },
325 [SCxSR] = { 0x08, 16 }, 352 [SCxSR] = { 0x10, 16 },
326 [SCxRDR] = { 0x0a, 8 }, 353 [SCxRDR] = { 0x14, 8 },
327 [SCFCR] = { 0x0c, 16 }, 354 [SCFCR] = { 0x18, 16 },
328 [SCFDR] = { 0x0e, 16 }, 355 [SCFDR] = { 0x1c, 16 },
329 [SCSPTR] = { 0x10, 16 }, 356 [SCSPTR] = { 0x20, 16 },
330 [SCLSR] = { 0x12, 16 }, 357 [SCLSR] = { 0x24, 16 },
331 }, 358 },
332 .fifosize = 16, 359 .fifosize = 16,
333 .overrun_reg = SCLSR, 360 .overrun_reg = SCLSR,
@@ -2810,7 +2837,7 @@ static int sci_init_single(struct platform_device *dev,
2810{ 2837{
2811 struct uart_port *port = &sci_port->port; 2838 struct uart_port *port = &sci_port->port;
2812 const struct resource *res; 2839 const struct resource *res;
2813 unsigned int i, regtype; 2840 unsigned int i;
2814 int ret; 2841 int ret;
2815 2842
2816 sci_port->cfg = p; 2843 sci_port->cfg = p;
@@ -2847,7 +2874,6 @@ static int sci_init_single(struct platform_device *dev,
2847 if (unlikely(sci_port->params == NULL)) 2874 if (unlikely(sci_port->params == NULL))
2848 return -EINVAL; 2875 return -EINVAL;
2849 2876
2850 regtype = sci_port->params - sci_port_params;
2851 switch (p->type) { 2877 switch (p->type) {
2852 case PORT_SCIFB: 2878 case PORT_SCIFB:
2853 sci_port->rx_trigger = 48; 2879 sci_port->rx_trigger = 48;
@@ -2902,10 +2928,6 @@ static int sci_init_single(struct platform_device *dev,
2902 port->regshift = 1; 2928 port->regshift = 1;
2903 } 2929 }
2904 2930
2905 if (regtype == SCIx_SH4_SCIF_REGTYPE)
2906 if (sci_port->reg_size >= 0x20)
2907 port->regshift = 1;
2908
2909 /* 2931 /*
2910 * The UART port needs an IRQ value, so we peg this to the RX IRQ 2932 * The UART port needs an IRQ value, so we peg this to the RX IRQ
2911 * for the multi-IRQ ports, which is where we are primarily 2933 * for the multi-IRQ ports, which is where we are primarily
@@ -3110,6 +3132,10 @@ static const struct of_device_id of_sci_match[] = {
3110 .compatible = "renesas,scif-r7s72100", 3132 .compatible = "renesas,scif-r7s72100",
3111 .data = SCI_OF_DATA(PORT_SCIF, SCIx_SH2_SCIF_FIFODATA_REGTYPE), 3133 .data = SCI_OF_DATA(PORT_SCIF, SCIx_SH2_SCIF_FIFODATA_REGTYPE),
3112 }, 3134 },
3135 {
3136 .compatible = "renesas,scif-r7s9210",
3137 .data = SCI_OF_DATA(PORT_SCIF, SCIx_RZ_SCIFA_REGTYPE),
3138 },
3113 /* Family-specific types */ 3139 /* Family-specific types */
3114 { 3140 {
3115 .compatible = "renesas,rcar-gen1-scif", 3141 .compatible = "renesas,rcar-gen1-scif",
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 32bc3e3fe4d3..5e5da9acaf0a 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1255,6 +1255,7 @@ static void tty_driver_remove_tty(struct tty_driver *driver, struct tty_struct *
1255static int tty_reopen(struct tty_struct *tty) 1255static int tty_reopen(struct tty_struct *tty)
1256{ 1256{
1257 struct tty_driver *driver = tty->driver; 1257 struct tty_driver *driver = tty->driver;
1258 int retval;
1258 1259
1259 if (driver->type == TTY_DRIVER_TYPE_PTY && 1260 if (driver->type == TTY_DRIVER_TYPE_PTY &&
1260 driver->subtype == PTY_TYPE_MASTER) 1261 driver->subtype == PTY_TYPE_MASTER)
@@ -1268,10 +1269,14 @@ static int tty_reopen(struct tty_struct *tty)
1268 1269
1269 tty->count++; 1270 tty->count++;
1270 1271
1271 if (!tty->ldisc) 1272 if (tty->ldisc)
1272 return tty_ldisc_reinit(tty, tty->termios.c_line); 1273 return 0;
1273 1274
1274 return 0; 1275 retval = tty_ldisc_reinit(tty, tty->termios.c_line);
1276 if (retval)
1277 tty->count--;
1278
1279 return retval;
1275} 1280}
1276 1281
1277/** 1282/**
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index a78ad10a119b..73cdc0d633dd 100644
--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c
@@ -32,6 +32,8 @@
32#include <asm/io.h> 32#include <asm/io.h>
33#include <linux/uaccess.h> 33#include <linux/uaccess.h>
34 34
35#include <linux/nospec.h>
36
35#include <linux/kbd_kern.h> 37#include <linux/kbd_kern.h>
36#include <linux/vt_kern.h> 38#include <linux/vt_kern.h>
37#include <linux/kbd_diacr.h> 39#include <linux/kbd_diacr.h>
@@ -700,6 +702,8 @@ int vt_ioctl(struct tty_struct *tty,
700 if (vsa.console == 0 || vsa.console > MAX_NR_CONSOLES) 702 if (vsa.console == 0 || vsa.console > MAX_NR_CONSOLES)
701 ret = -ENXIO; 703 ret = -ENXIO;
702 else { 704 else {
705 vsa.console = array_index_nospec(vsa.console,
706 MAX_NR_CONSOLES + 1);
703 vsa.console--; 707 vsa.console--;
704 console_lock(); 708 console_lock();
705 ret = vc_allocate(vsa.console); 709 ret = vc_allocate(vsa.console);
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 27346d69f393..bc03b0a690b4 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -780,20 +780,9 @@ static int acm_tty_write(struct tty_struct *tty,
780 } 780 }
781 781
782 if (acm->susp_count) { 782 if (acm->susp_count) {
783 if (acm->putbuffer) {
784 /* now to preserve order */
785 usb_anchor_urb(acm->putbuffer->urb, &acm->delayed);
786 acm->putbuffer = NULL;
787 }
788 usb_anchor_urb(wb->urb, &acm->delayed); 783 usb_anchor_urb(wb->urb, &acm->delayed);
789 spin_unlock_irqrestore(&acm->write_lock, flags); 784 spin_unlock_irqrestore(&acm->write_lock, flags);
790 return count; 785 return count;
791 } else {
792 if (acm->putbuffer) {
793 /* at this point there is no good way to handle errors */
794 acm_start_wb(acm, acm->putbuffer);
795 acm->putbuffer = NULL;
796 }
797 } 786 }
798 787
799 stat = acm_start_wb(acm, wb); 788 stat = acm_start_wb(acm, wb);
@@ -804,66 +793,6 @@ static int acm_tty_write(struct tty_struct *tty,
804 return count; 793 return count;
805} 794}
806 795
807static void acm_tty_flush_chars(struct tty_struct *tty)
808{
809 struct acm *acm = tty->driver_data;
810 struct acm_wb *cur;
811 int err;
812 unsigned long flags;
813
814 spin_lock_irqsave(&acm->write_lock, flags);
815
816 cur = acm->putbuffer;
817 if (!cur) /* nothing to do */
818 goto out;
819
820 acm->putbuffer = NULL;
821 err = usb_autopm_get_interface_async(acm->control);
822 if (err < 0) {
823 cur->use = 0;
824 acm->putbuffer = cur;
825 goto out;
826 }
827
828 if (acm->susp_count)
829 usb_anchor_urb(cur->urb, &acm->delayed);
830 else
831 acm_start_wb(acm, cur);
832out:
833 spin_unlock_irqrestore(&acm->write_lock, flags);
834 return;
835}
836
837static int acm_tty_put_char(struct tty_struct *tty, unsigned char ch)
838{
839 struct acm *acm = tty->driver_data;
840 struct acm_wb *cur;
841 int wbn;
842 unsigned long flags;
843
844overflow:
845 cur = acm->putbuffer;
846 if (!cur) {
847 spin_lock_irqsave(&acm->write_lock, flags);
848 wbn = acm_wb_alloc(acm);
849 if (wbn >= 0) {
850 cur = &acm->wb[wbn];
851 acm->putbuffer = cur;
852 }
853 spin_unlock_irqrestore(&acm->write_lock, flags);
854 if (!cur)
855 return 0;
856 }
857
858 if (cur->len == acm->writesize) {
859 acm_tty_flush_chars(tty);
860 goto overflow;
861 }
862
863 cur->buf[cur->len++] = ch;
864 return 1;
865}
866
867static int acm_tty_write_room(struct tty_struct *tty) 796static int acm_tty_write_room(struct tty_struct *tty)
868{ 797{
869 struct acm *acm = tty->driver_data; 798 struct acm *acm = tty->driver_data;
@@ -1585,6 +1514,7 @@ static void acm_disconnect(struct usb_interface *intf)
1585{ 1514{
1586 struct acm *acm = usb_get_intfdata(intf); 1515 struct acm *acm = usb_get_intfdata(intf);
1587 struct tty_struct *tty; 1516 struct tty_struct *tty;
1517 int i;
1588 1518
1589 /* sibling interface is already cleaning up */ 1519 /* sibling interface is already cleaning up */
1590 if (!acm) 1520 if (!acm)
@@ -1615,6 +1545,11 @@ static void acm_disconnect(struct usb_interface *intf)
1615 1545
1616 tty_unregister_device(acm_tty_driver, acm->minor); 1546 tty_unregister_device(acm_tty_driver, acm->minor);
1617 1547
1548 usb_free_urb(acm->ctrlurb);
1549 for (i = 0; i < ACM_NW; i++)
1550 usb_free_urb(acm->wb[i].urb);
1551 for (i = 0; i < acm->rx_buflimit; i++)
1552 usb_free_urb(acm->read_urbs[i]);
1618 acm_write_buffers_free(acm); 1553 acm_write_buffers_free(acm);
1619 usb_free_coherent(acm->dev, acm->ctrlsize, acm->ctrl_buffer, acm->ctrl_dma); 1554 usb_free_coherent(acm->dev, acm->ctrlsize, acm->ctrl_buffer, acm->ctrl_dma);
1620 acm_read_buffers_free(acm); 1555 acm_read_buffers_free(acm);
@@ -1987,8 +1922,6 @@ static const struct tty_operations acm_ops = {
1987 .cleanup = acm_tty_cleanup, 1922 .cleanup = acm_tty_cleanup,
1988 .hangup = acm_tty_hangup, 1923 .hangup = acm_tty_hangup,
1989 .write = acm_tty_write, 1924 .write = acm_tty_write,
1990 .put_char = acm_tty_put_char,
1991 .flush_chars = acm_tty_flush_chars,
1992 .write_room = acm_tty_write_room, 1925 .write_room = acm_tty_write_room,
1993 .ioctl = acm_tty_ioctl, 1926 .ioctl = acm_tty_ioctl,
1994 .throttle = acm_tty_throttle, 1927 .throttle = acm_tty_throttle,
diff --git a/drivers/usb/class/cdc-acm.h b/drivers/usb/class/cdc-acm.h
index eacc116e83da..ca06b20d7af9 100644
--- a/drivers/usb/class/cdc-acm.h
+++ b/drivers/usb/class/cdc-acm.h
@@ -96,7 +96,6 @@ struct acm {
96 unsigned long read_urbs_free; 96 unsigned long read_urbs_free;
97 struct urb *read_urbs[ACM_NR]; 97 struct urb *read_urbs[ACM_NR];
98 struct acm_rb read_buffers[ACM_NR]; 98 struct acm_rb read_buffers[ACM_NR];
99 struct acm_wb *putbuffer; /* for acm_tty_put_char() */
100 int rx_buflimit; 99 int rx_buflimit;
101 spinlock_t read_lock; 100 spinlock_t read_lock;
102 u8 *notification_buffer; /* to reassemble fragmented notifications */ 101 u8 *notification_buffer; /* to reassemble fragmented notifications */
diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c
index 50a2362ed3ea..48277bbc15e4 100644
--- a/drivers/usb/common/common.c
+++ b/drivers/usb/common/common.c
@@ -246,6 +246,31 @@ int of_usb_update_otg_caps(struct device_node *np,
246} 246}
247EXPORT_SYMBOL_GPL(of_usb_update_otg_caps); 247EXPORT_SYMBOL_GPL(of_usb_update_otg_caps);
248 248
249/**
250 * usb_of_get_companion_dev - Find the companion device
251 * @dev: the device pointer to find a companion
252 *
253 * Find the companion device from platform bus.
254 *
255 * Takes a reference to the returned struct device which needs to be dropped
256 * after use.
257 *
258 * Return: On success, a pointer to the companion device, %NULL on failure.
259 */
260struct device *usb_of_get_companion_dev(struct device *dev)
261{
262 struct device_node *node;
263 struct platform_device *pdev = NULL;
264
265 node = of_parse_phandle(dev->of_node, "companion", 0);
266 if (node)
267 pdev = of_find_device_by_node(node);
268
269 of_node_put(node);
270
271 return pdev ? &pdev->dev : NULL;
272}
273EXPORT_SYMBOL_GPL(usb_of_get_companion_dev);
249#endif 274#endif
250 275
251MODULE_LICENSE("GPL"); 276MODULE_LICENSE("GPL");
diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
index 15cc76e22123..99116af07f1d 100644
--- a/drivers/usb/common/roles.c
+++ b/drivers/usb/common/roles.c
@@ -109,8 +109,15 @@ static void *usb_role_switch_match(struct device_connection *con, int ep,
109 */ 109 */
110struct usb_role_switch *usb_role_switch_get(struct device *dev) 110struct usb_role_switch *usb_role_switch_get(struct device *dev)
111{ 111{
112 return device_connection_find_match(dev, "usb-role-switch", NULL, 112 struct usb_role_switch *sw;
113 usb_role_switch_match); 113
114 sw = device_connection_find_match(dev, "usb-role-switch", NULL,
115 usb_role_switch_match);
116
117 if (!IS_ERR_OR_NULL(sw))
118 WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
119
120 return sw;
114} 121}
115EXPORT_SYMBOL_GPL(usb_role_switch_get); 122EXPORT_SYMBOL_GPL(usb_role_switch_get);
116 123
@@ -122,8 +129,10 @@ EXPORT_SYMBOL_GPL(usb_role_switch_get);
122 */ 129 */
123void usb_role_switch_put(struct usb_role_switch *sw) 130void usb_role_switch_put(struct usb_role_switch *sw)
124{ 131{
125 if (!IS_ERR_OR_NULL(sw)) 132 if (!IS_ERR_OR_NULL(sw)) {
126 put_device(&sw->dev); 133 put_device(&sw->dev);
134 module_put(sw->dev.parent->driver->owner);
135 }
127} 136}
128EXPORT_SYMBOL_GPL(usb_role_switch_put); 137EXPORT_SYMBOL_GPL(usb_role_switch_put);
129 138
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 6ce77b33da61..244417d0dfd1 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -1434,10 +1434,13 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
1434 struct async *as = NULL; 1434 struct async *as = NULL;
1435 struct usb_ctrlrequest *dr = NULL; 1435 struct usb_ctrlrequest *dr = NULL;
1436 unsigned int u, totlen, isofrmlen; 1436 unsigned int u, totlen, isofrmlen;
1437 int i, ret, is_in, num_sgs = 0, ifnum = -1; 1437 int i, ret, num_sgs = 0, ifnum = -1;
1438 int number_of_packets = 0; 1438 int number_of_packets = 0;
1439 unsigned int stream_id = 0; 1439 unsigned int stream_id = 0;
1440 void *buf; 1440 void *buf;
1441 bool is_in;
1442 bool allow_short = false;
1443 bool allow_zero = false;
1441 unsigned long mask = USBDEVFS_URB_SHORT_NOT_OK | 1444 unsigned long mask = USBDEVFS_URB_SHORT_NOT_OK |
1442 USBDEVFS_URB_BULK_CONTINUATION | 1445 USBDEVFS_URB_BULK_CONTINUATION |
1443 USBDEVFS_URB_NO_FSBR | 1446 USBDEVFS_URB_NO_FSBR |
@@ -1471,6 +1474,8 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
1471 u = 0; 1474 u = 0;
1472 switch (uurb->type) { 1475 switch (uurb->type) {
1473 case USBDEVFS_URB_TYPE_CONTROL: 1476 case USBDEVFS_URB_TYPE_CONTROL:
1477 if (is_in)
1478 allow_short = true;
1474 if (!usb_endpoint_xfer_control(&ep->desc)) 1479 if (!usb_endpoint_xfer_control(&ep->desc))
1475 return -EINVAL; 1480 return -EINVAL;
1476 /* min 8 byte setup packet */ 1481 /* min 8 byte setup packet */
@@ -1511,6 +1516,10 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
1511 break; 1516 break;
1512 1517
1513 case USBDEVFS_URB_TYPE_BULK: 1518 case USBDEVFS_URB_TYPE_BULK:
1519 if (!is_in)
1520 allow_zero = true;
1521 else
1522 allow_short = true;
1514 switch (usb_endpoint_type(&ep->desc)) { 1523 switch (usb_endpoint_type(&ep->desc)) {
1515 case USB_ENDPOINT_XFER_CONTROL: 1524 case USB_ENDPOINT_XFER_CONTROL:
1516 case USB_ENDPOINT_XFER_ISOC: 1525 case USB_ENDPOINT_XFER_ISOC:
@@ -1531,6 +1540,10 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
1531 if (!usb_endpoint_xfer_int(&ep->desc)) 1540 if (!usb_endpoint_xfer_int(&ep->desc))
1532 return -EINVAL; 1541 return -EINVAL;
1533 interrupt_urb: 1542 interrupt_urb:
1543 if (!is_in)
1544 allow_zero = true;
1545 else
1546 allow_short = true;
1534 break; 1547 break;
1535 1548
1536 case USBDEVFS_URB_TYPE_ISO: 1549 case USBDEVFS_URB_TYPE_ISO:
@@ -1676,14 +1689,19 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
1676 u = (is_in ? URB_DIR_IN : URB_DIR_OUT); 1689 u = (is_in ? URB_DIR_IN : URB_DIR_OUT);
1677 if (uurb->flags & USBDEVFS_URB_ISO_ASAP) 1690 if (uurb->flags & USBDEVFS_URB_ISO_ASAP)
1678 u |= URB_ISO_ASAP; 1691 u |= URB_ISO_ASAP;
1679 if (uurb->flags & USBDEVFS_URB_SHORT_NOT_OK && is_in) 1692 if (allow_short && uurb->flags & USBDEVFS_URB_SHORT_NOT_OK)
1680 u |= URB_SHORT_NOT_OK; 1693 u |= URB_SHORT_NOT_OK;
1681 if (uurb->flags & USBDEVFS_URB_ZERO_PACKET) 1694 if (allow_zero && uurb->flags & USBDEVFS_URB_ZERO_PACKET)
1682 u |= URB_ZERO_PACKET; 1695 u |= URB_ZERO_PACKET;
1683 if (uurb->flags & USBDEVFS_URB_NO_INTERRUPT) 1696 if (uurb->flags & USBDEVFS_URB_NO_INTERRUPT)
1684 u |= URB_NO_INTERRUPT; 1697 u |= URB_NO_INTERRUPT;
1685 as->urb->transfer_flags = u; 1698 as->urb->transfer_flags = u;
1686 1699
1700 if (!allow_short && uurb->flags & USBDEVFS_URB_SHORT_NOT_OK)
1701 dev_warn(&ps->dev->dev, "Requested nonsensical USBDEVFS_URB_SHORT_NOT_OK.\n");
1702 if (!allow_zero && uurb->flags & USBDEVFS_URB_ZERO_PACKET)
1703 dev_warn(&ps->dev->dev, "Requested nonsensical USBDEVFS_URB_ZERO_PACKET.\n");
1704
1687 as->urb->transfer_buffer_length = uurb->buffer_length; 1705 as->urb->transfer_buffer_length = uurb->buffer_length;
1688 as->urb->setup_packet = (unsigned char *)dr; 1706 as->urb->setup_packet = (unsigned char *)dr;
1689 dr = NULL; 1707 dr = NULL;
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index e76e95f62f76..a1f225f077cd 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -512,7 +512,6 @@ int usb_driver_claim_interface(struct usb_driver *driver,
512 struct device *dev; 512 struct device *dev;
513 struct usb_device *udev; 513 struct usb_device *udev;
514 int retval = 0; 514 int retval = 0;
515 int lpm_disable_error = -ENODEV;
516 515
517 if (!iface) 516 if (!iface)
518 return -ENODEV; 517 return -ENODEV;
@@ -533,16 +532,6 @@ int usb_driver_claim_interface(struct usb_driver *driver,
533 532
534 iface->condition = USB_INTERFACE_BOUND; 533 iface->condition = USB_INTERFACE_BOUND;
535 534
536 /* See the comment about disabling LPM in usb_probe_interface(). */
537 if (driver->disable_hub_initiated_lpm) {
538 lpm_disable_error = usb_unlocked_disable_lpm(udev);
539 if (lpm_disable_error) {
540 dev_err(&iface->dev, "%s Failed to disable LPM for driver %s\n",
541 __func__, driver->name);
542 return -ENOMEM;
543 }
544 }
545
546 /* Claimed interfaces are initially inactive (suspended) and 535 /* Claimed interfaces are initially inactive (suspended) and
547 * runtime-PM-enabled, but only if the driver has autosuspend 536 * runtime-PM-enabled, but only if the driver has autosuspend
548 * support. Otherwise they are marked active, to prevent the 537 * support. Otherwise they are marked active, to prevent the
@@ -561,9 +550,20 @@ int usb_driver_claim_interface(struct usb_driver *driver,
561 if (device_is_registered(dev)) 550 if (device_is_registered(dev))
562 retval = device_bind_driver(dev); 551 retval = device_bind_driver(dev);
563 552
564 /* Attempt to re-enable USB3 LPM, if the disable was successful. */ 553 if (retval) {
565 if (!lpm_disable_error) 554 dev->driver = NULL;
566 usb_unlocked_enable_lpm(udev); 555 usb_set_intfdata(iface, NULL);
556 iface->needs_remote_wakeup = 0;
557 iface->condition = USB_INTERFACE_UNBOUND;
558
559 /*
560 * Unbound interfaces are always runtime-PM-disabled
561 * and runtime-PM-suspended
562 */
563 if (driver->supports_autosuspend)
564 pm_runtime_disable(dev);
565 pm_runtime_set_suspended(dev);
566 }
567 567
568 return retval; 568 return retval;
569} 569}
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 66fe1b78d952..03432467b05f 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -515,8 +515,6 @@ static int resume_common(struct device *dev, int event)
515 event == PM_EVENT_RESTORE); 515 event == PM_EVENT_RESTORE);
516 if (retval) { 516 if (retval) {
517 dev_err(dev, "PCI post-resume error %d!\n", retval); 517 dev_err(dev, "PCI post-resume error %d!\n", retval);
518 if (hcd->shared_hcd)
519 usb_hc_died(hcd->shared_hcd);
520 usb_hc_died(hcd); 518 usb_hc_died(hcd);
521 } 519 }
522 } 520 }
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 228672f2c4a1..bfa5eda0cc26 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -1341,6 +1341,11 @@ void usb_enable_interface(struct usb_device *dev,
1341 * is submitted that needs that bandwidth. Some other operating systems 1341 * is submitted that needs that bandwidth. Some other operating systems
1342 * allocate bandwidth early, when a configuration is chosen. 1342 * allocate bandwidth early, when a configuration is chosen.
1343 * 1343 *
1344 * xHCI reserves bandwidth and configures the alternate setting in
1345 * usb_hcd_alloc_bandwidth(). If it fails the original interface altsetting
1346 * may be disabled. Drivers cannot rely on any particular alternate
1347 * setting being in effect after a failure.
1348 *
1344 * This call is synchronous, and may not be used in an interrupt context. 1349 * This call is synchronous, and may not be used in an interrupt context.
1345 * Also, drivers must not change altsettings while urbs are scheduled for 1350 * Also, drivers must not change altsettings while urbs are scheduled for
1346 * endpoints in that interface; all such urbs must first be completed 1351 * endpoints in that interface; all such urbs must first be completed
@@ -1376,6 +1381,12 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
1376 alternate); 1381 alternate);
1377 return -EINVAL; 1382 return -EINVAL;
1378 } 1383 }
1384 /*
1385 * usb3 hosts configure the interface in usb_hcd_alloc_bandwidth,
1386 * including freeing dropped endpoint ring buffers.
1387 * Make sure the interface endpoints are flushed before that
1388 */
1389 usb_disable_interface(dev, iface, false);
1379 1390
1380 /* Make sure we have enough bandwidth for this alternate interface. 1391 /* Make sure we have enough bandwidth for this alternate interface.
1381 * Remove the current alt setting and add the new alt setting. 1392 * Remove the current alt setting and add the new alt setting.
diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c
index fd77442c2d12..651708d8c908 100644
--- a/drivers/usb/core/of.c
+++ b/drivers/usb/core/of.c
@@ -105,29 +105,3 @@ usb_of_get_interface_node(struct usb_device *udev, u8 config, u8 ifnum)
105 return NULL; 105 return NULL;
106} 106}
107EXPORT_SYMBOL_GPL(usb_of_get_interface_node); 107EXPORT_SYMBOL_GPL(usb_of_get_interface_node);
108
109/**
110 * usb_of_get_companion_dev - Find the companion device
111 * @dev: the device pointer to find a companion
112 *
113 * Find the companion device from platform bus.
114 *
115 * Takes a reference to the returned struct device which needs to be dropped
116 * after use.
117 *
118 * Return: On success, a pointer to the companion device, %NULL on failure.
119 */
120struct device *usb_of_get_companion_dev(struct device *dev)
121{
122 struct device_node *node;
123 struct platform_device *pdev = NULL;
124
125 node = of_parse_phandle(dev->of_node, "companion", 0);
126 if (node)
127 pdev = of_find_device_by_node(node);
128
129 of_node_put(node);
130
131 return pdev ? &pdev->dev : NULL;
132}
133EXPORT_SYMBOL_GPL(usb_of_get_companion_dev);
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 097057d2eacf..178d6c6063c0 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -58,6 +58,7 @@ static int quirks_param_set(const char *val, const struct kernel_param *kp)
58 quirk_list = kcalloc(quirk_count, sizeof(struct quirk_entry), 58 quirk_list = kcalloc(quirk_count, sizeof(struct quirk_entry),
59 GFP_KERNEL); 59 GFP_KERNEL);
60 if (!quirk_list) { 60 if (!quirk_list) {
61 quirk_count = 0;
61 mutex_unlock(&quirk_mutex); 62 mutex_unlock(&quirk_mutex);
62 return -ENOMEM; 63 return -ENOMEM;
63 } 64 }
@@ -154,7 +155,7 @@ static struct kparam_string quirks_param_string = {
154 .string = quirks_param, 155 .string = quirks_param,
155}; 156};
156 157
157module_param_cb(quirks, &quirks_param_ops, &quirks_param_string, 0644); 158device_param_cb(quirks, &quirks_param_ops, &quirks_param_string, 0644);
158MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks"); 159MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks");
159 160
160/* Lists of quirky USB devices, split in device quirks and interface quirks. 161/* Lists of quirky USB devices, split in device quirks and interface quirks.
@@ -178,6 +179,10 @@ static const struct usb_device_id usb_quirk_list[] = {
178 /* CBM - Flash disk */ 179 /* CBM - Flash disk */
179 { USB_DEVICE(0x0204, 0x6025), .driver_info = USB_QUIRK_RESET_RESUME }, 180 { USB_DEVICE(0x0204, 0x6025), .driver_info = USB_QUIRK_RESET_RESUME },
180 181
182 /* WORLDE Controller KS49 or Prodipe MIDI 49C USB controller */
183 { USB_DEVICE(0x0218, 0x0201), .driver_info =
184 USB_QUIRK_CONFIG_INTF_STRINGS },
185
181 /* WORLDE easy key (easykey.25) MIDI controller */ 186 /* WORLDE easy key (easykey.25) MIDI controller */
182 { USB_DEVICE(0x0218, 0x0401), .driver_info = 187 { USB_DEVICE(0x0218, 0x0401), .driver_info =
183 USB_QUIRK_CONFIG_INTF_STRINGS }, 188 USB_QUIRK_CONFIG_INTF_STRINGS },
@@ -406,6 +411,9 @@ static const struct usb_device_id usb_quirk_list[] = {
406 { USB_DEVICE(0x2040, 0x7200), .driver_info = 411 { USB_DEVICE(0x2040, 0x7200), .driver_info =
407 USB_QUIRK_CONFIG_INTF_STRINGS }, 412 USB_QUIRK_CONFIG_INTF_STRINGS },
408 413
414 /* DJI CineSSD */
415 { USB_DEVICE(0x2ca3, 0x0031), .driver_info = USB_QUIRK_NO_LPM },
416
409 /* INTEL VALUE SSD */ 417 /* INTEL VALUE SSD */
410 { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, 418 { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
411 419
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 623be3174fb3..79d8bd7a612e 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -228,6 +228,8 @@ struct usb_host_interface *usb_find_alt_setting(
228 struct usb_interface_cache *intf_cache = NULL; 228 struct usb_interface_cache *intf_cache = NULL;
229 int i; 229 int i;
230 230
231 if (!config)
232 return NULL;
231 for (i = 0; i < config->desc.bNumInterfaces; i++) { 233 for (i = 0; i < config->desc.bNumInterfaces; i++) {
232 if (config->intf_cache[i]->altsetting[0].desc.bInterfaceNumber 234 if (config->intf_cache[i]->altsetting[0].desc.bInterfaceNumber
233 == iface_num) { 235 == iface_num) {
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 9a53a58e676e..577642895b57 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -412,8 +412,6 @@ static int dwc2_driver_probe(struct platform_device *dev)
412 dev_dbg(&dev->dev, "mapped PA %08lx to VA %p\n", 412 dev_dbg(&dev->dev, "mapped PA %08lx to VA %p\n",
413 (unsigned long)res->start, hsotg->regs); 413 (unsigned long)res->start, hsotg->regs);
414 414
415 hsotg->needs_byte_swap = dwc2_check_core_endianness(hsotg);
416
417 retval = dwc2_lowlevel_hw_init(hsotg); 415 retval = dwc2_lowlevel_hw_init(hsotg);
418 if (retval) 416 if (retval)
419 return retval; 417 return retval;
@@ -438,6 +436,8 @@ static int dwc2_driver_probe(struct platform_device *dev)
438 if (retval) 436 if (retval)
439 return retval; 437 return retval;
440 438
439 hsotg->needs_byte_swap = dwc2_check_core_endianness(hsotg);
440
441 retval = dwc2_get_dr_mode(hsotg); 441 retval = dwc2_get_dr_mode(hsotg);
442 if (retval) 442 if (retval)
443 goto error; 443 goto error;
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index 40bf9e0bbc59..4c2771c5e727 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -180,8 +180,7 @@ static int dwc3_of_simple_remove(struct platform_device *pdev)
180 return 0; 180 return 0;
181} 181}
182 182
183#ifdef CONFIG_PM 183static int __maybe_unused dwc3_of_simple_runtime_suspend(struct device *dev)
184static int dwc3_of_simple_runtime_suspend(struct device *dev)
185{ 184{
186 struct dwc3_of_simple *simple = dev_get_drvdata(dev); 185 struct dwc3_of_simple *simple = dev_get_drvdata(dev);
187 int i; 186 int i;
@@ -192,7 +191,7 @@ static int dwc3_of_simple_runtime_suspend(struct device *dev)
192 return 0; 191 return 0;
193} 192}
194 193
195static int dwc3_of_simple_runtime_resume(struct device *dev) 194static int __maybe_unused dwc3_of_simple_runtime_resume(struct device *dev)
196{ 195{
197 struct dwc3_of_simple *simple = dev_get_drvdata(dev); 196 struct dwc3_of_simple *simple = dev_get_drvdata(dev);
198 int ret; 197 int ret;
@@ -210,7 +209,7 @@ static int dwc3_of_simple_runtime_resume(struct device *dev)
210 return 0; 209 return 0;
211} 210}
212 211
213static int dwc3_of_simple_suspend(struct device *dev) 212static int __maybe_unused dwc3_of_simple_suspend(struct device *dev)
214{ 213{
215 struct dwc3_of_simple *simple = dev_get_drvdata(dev); 214 struct dwc3_of_simple *simple = dev_get_drvdata(dev);
216 215
@@ -220,7 +219,7 @@ static int dwc3_of_simple_suspend(struct device *dev)
220 return 0; 219 return 0;
221} 220}
222 221
223static int dwc3_of_simple_resume(struct device *dev) 222static int __maybe_unused dwc3_of_simple_resume(struct device *dev)
224{ 223{
225 struct dwc3_of_simple *simple = dev_get_drvdata(dev); 224 struct dwc3_of_simple *simple = dev_get_drvdata(dev);
226 225
@@ -229,7 +228,6 @@ static int dwc3_of_simple_resume(struct device *dev)
229 228
230 return 0; 229 return 0;
231} 230}
232#endif
233 231
234static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { 232static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
235 SET_SYSTEM_SLEEP_PM_OPS(dwc3_of_simple_suspend, dwc3_of_simple_resume) 233 SET_SYSTEM_SLEEP_PM_OPS(dwc3_of_simple_suspend, dwc3_of_simple_resume)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 5edd79470368..1286076a8890 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -85,8 +85,8 @@ static int dwc3_byt_enable_ulpi_refclock(struct pci_dev *pci)
85 u32 value; 85 u32 value;
86 86
87 reg = pcim_iomap(pci, GP_RWBAR, 0); 87 reg = pcim_iomap(pci, GP_RWBAR, 0);
88 if (IS_ERR(reg)) 88 if (!reg)
89 return PTR_ERR(reg); 89 return -ENOMEM;
90 90
91 value = readl(reg + GP_RWREG1); 91 value = readl(reg + GP_RWREG1);
92 if (!(value & GP_RWREG1_ULPI_REFCLK_DISABLE)) 92 if (!(value & GP_RWREG1_ULPI_REFCLK_DISABLE))
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 032ea7d709ba..2b53194081ba 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -473,7 +473,6 @@ static int dwc3_gadget_set_xfer_resource(struct dwc3_ep *dep)
473 473
474/** 474/**
475 * dwc3_gadget_start_config - configure ep resources 475 * dwc3_gadget_start_config - configure ep resources
476 * @dwc: pointer to our controller context structure
477 * @dep: endpoint that is being enabled 476 * @dep: endpoint that is being enabled
478 * 477 *
479 * Issue a %DWC3_DEPCMD_DEPSTARTCFG command to @dep. After the command's 478 * Issue a %DWC3_DEPCMD_DEPSTARTCFG command to @dep. After the command's
diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c
index 53a48f561458..587c5037ff07 100644
--- a/drivers/usb/gadget/udc/fotg210-udc.c
+++ b/drivers/usb/gadget/udc/fotg210-udc.c
@@ -1063,12 +1063,15 @@ static const struct usb_gadget_ops fotg210_gadget_ops = {
1063static int fotg210_udc_remove(struct platform_device *pdev) 1063static int fotg210_udc_remove(struct platform_device *pdev)
1064{ 1064{
1065 struct fotg210_udc *fotg210 = platform_get_drvdata(pdev); 1065 struct fotg210_udc *fotg210 = platform_get_drvdata(pdev);
1066 int i;
1066 1067
1067 usb_del_gadget_udc(&fotg210->gadget); 1068 usb_del_gadget_udc(&fotg210->gadget);
1068 iounmap(fotg210->reg); 1069 iounmap(fotg210->reg);
1069 free_irq(platform_get_irq(pdev, 0), fotg210); 1070 free_irq(platform_get_irq(pdev, 0), fotg210);
1070 1071
1071 fotg210_ep_free_request(&fotg210->ep[0]->ep, fotg210->ep0_req); 1072 fotg210_ep_free_request(&fotg210->ep[0]->ep, fotg210->ep0_req);
1073 for (i = 0; i < FOTG210_MAX_NUM_EP; i++)
1074 kfree(fotg210->ep[i]);
1072 kfree(fotg210); 1075 kfree(fotg210);
1073 1076
1074 return 0; 1077 return 0;
@@ -1099,7 +1102,7 @@ static int fotg210_udc_probe(struct platform_device *pdev)
1099 /* initialize udc */ 1102 /* initialize udc */
1100 fotg210 = kzalloc(sizeof(struct fotg210_udc), GFP_KERNEL); 1103 fotg210 = kzalloc(sizeof(struct fotg210_udc), GFP_KERNEL);
1101 if (fotg210 == NULL) 1104 if (fotg210 == NULL)
1102 goto err_alloc; 1105 goto err;
1103 1106
1104 for (i = 0; i < FOTG210_MAX_NUM_EP; i++) { 1107 for (i = 0; i < FOTG210_MAX_NUM_EP; i++) {
1105 _ep[i] = kzalloc(sizeof(struct fotg210_ep), GFP_KERNEL); 1108 _ep[i] = kzalloc(sizeof(struct fotg210_ep), GFP_KERNEL);
@@ -1111,7 +1114,7 @@ static int fotg210_udc_probe(struct platform_device *pdev)
1111 fotg210->reg = ioremap(res->start, resource_size(res)); 1114 fotg210->reg = ioremap(res->start, resource_size(res));
1112 if (fotg210->reg == NULL) { 1115 if (fotg210->reg == NULL) {
1113 pr_err("ioremap error.\n"); 1116 pr_err("ioremap error.\n");
1114 goto err_map; 1117 goto err_alloc;
1115 } 1118 }
1116 1119
1117 spin_lock_init(&fotg210->lock); 1120 spin_lock_init(&fotg210->lock);
@@ -1159,7 +1162,7 @@ static int fotg210_udc_probe(struct platform_device *pdev)
1159 fotg210->ep0_req = fotg210_ep_alloc_request(&fotg210->ep[0]->ep, 1162 fotg210->ep0_req = fotg210_ep_alloc_request(&fotg210->ep[0]->ep,
1160 GFP_KERNEL); 1163 GFP_KERNEL);
1161 if (fotg210->ep0_req == NULL) 1164 if (fotg210->ep0_req == NULL)
1162 goto err_req; 1165 goto err_map;
1163 1166
1164 fotg210_init(fotg210); 1167 fotg210_init(fotg210);
1165 1168
@@ -1187,12 +1190,14 @@ err_req:
1187 fotg210_ep_free_request(&fotg210->ep[0]->ep, fotg210->ep0_req); 1190 fotg210_ep_free_request(&fotg210->ep[0]->ep, fotg210->ep0_req);
1188 1191
1189err_map: 1192err_map:
1190 if (fotg210->reg) 1193 iounmap(fotg210->reg);
1191 iounmap(fotg210->reg);
1192 1194
1193err_alloc: 1195err_alloc:
1196 for (i = 0; i < FOTG210_MAX_NUM_EP; i++)
1197 kfree(fotg210->ep[i]);
1194 kfree(fotg210); 1198 kfree(fotg210);
1195 1199
1200err:
1196 return ret; 1201 return ret;
1197} 1202}
1198 1203
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 318246d8b2e2..b02ab2a8d927 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -1545,11 +1545,14 @@ static int net2280_pullup(struct usb_gadget *_gadget, int is_on)
1545 writel(tmp | BIT(USB_DETECT_ENABLE), &dev->usb->usbctl); 1545 writel(tmp | BIT(USB_DETECT_ENABLE), &dev->usb->usbctl);
1546 } else { 1546 } else {
1547 writel(tmp & ~BIT(USB_DETECT_ENABLE), &dev->usb->usbctl); 1547 writel(tmp & ~BIT(USB_DETECT_ENABLE), &dev->usb->usbctl);
1548 stop_activity(dev, dev->driver); 1548 stop_activity(dev, NULL);
1549 } 1549 }
1550 1550
1551 spin_unlock_irqrestore(&dev->lock, flags); 1551 spin_unlock_irqrestore(&dev->lock, flags);
1552 1552
1553 if (!is_on && dev->driver)
1554 dev->driver->disconnect(&dev->gadget);
1555
1553 return 0; 1556 return 0;
1554} 1557}
1555 1558
@@ -2466,8 +2469,11 @@ static void stop_activity(struct net2280 *dev, struct usb_gadget_driver *driver)
2466 nuke(&dev->ep[i]); 2469 nuke(&dev->ep[i]);
2467 2470
2468 /* report disconnect; the driver is already quiesced */ 2471 /* report disconnect; the driver is already quiesced */
2469 if (driver) 2472 if (driver) {
2473 spin_unlock(&dev->lock);
2470 driver->disconnect(&dev->gadget); 2474 driver->disconnect(&dev->gadget);
2475 spin_lock(&dev->lock);
2476 }
2471 2477
2472 usb_reinit(dev); 2478 usb_reinit(dev);
2473} 2479}
@@ -3341,6 +3347,8 @@ next_endpoints:
3341 BIT(PCI_RETRY_ABORT_INTERRUPT)) 3347 BIT(PCI_RETRY_ABORT_INTERRUPT))
3342 3348
3343static void handle_stat1_irqs(struct net2280 *dev, u32 stat) 3349static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
3350__releases(dev->lock)
3351__acquires(dev->lock)
3344{ 3352{
3345 struct net2280_ep *ep; 3353 struct net2280_ep *ep;
3346 u32 tmp, num, mask, scratch; 3354 u32 tmp, num, mask, scratch;
@@ -3381,12 +3389,14 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
3381 if (disconnect || reset) { 3389 if (disconnect || reset) {
3382 stop_activity(dev, dev->driver); 3390 stop_activity(dev, dev->driver);
3383 ep0_start(dev); 3391 ep0_start(dev);
3392 spin_unlock(&dev->lock);
3384 if (reset) 3393 if (reset)
3385 usb_gadget_udc_reset 3394 usb_gadget_udc_reset
3386 (&dev->gadget, dev->driver); 3395 (&dev->gadget, dev->driver);
3387 else 3396 else
3388 (dev->driver->disconnect) 3397 (dev->driver->disconnect)
3389 (&dev->gadget); 3398 (&dev->gadget);
3399 spin_lock(&dev->lock);
3390 return; 3400 return;
3391 } 3401 }
3392 } 3402 }
@@ -3405,6 +3415,7 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
3405 tmp = BIT(SUSPEND_REQUEST_CHANGE_INTERRUPT); 3415 tmp = BIT(SUSPEND_REQUEST_CHANGE_INTERRUPT);
3406 if (stat & tmp) { 3416 if (stat & tmp) {
3407 writel(tmp, &dev->regs->irqstat1); 3417 writel(tmp, &dev->regs->irqstat1);
3418 spin_unlock(&dev->lock);
3408 if (stat & BIT(SUSPEND_REQUEST_INTERRUPT)) { 3419 if (stat & BIT(SUSPEND_REQUEST_INTERRUPT)) {
3409 if (dev->driver->suspend) 3420 if (dev->driver->suspend)
3410 dev->driver->suspend(&dev->gadget); 3421 dev->driver->suspend(&dev->gadget);
@@ -3415,6 +3426,7 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
3415 dev->driver->resume(&dev->gadget); 3426 dev->driver->resume(&dev->gadget);
3416 /* at high speed, note erratum 0133 */ 3427 /* at high speed, note erratum 0133 */
3417 } 3428 }
3429 spin_lock(&dev->lock);
3418 stat &= ~tmp; 3430 stat &= ~tmp;
3419 } 3431 }
3420 3432
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index 1f879b3f2c96..e1656f361e08 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -812,12 +812,15 @@ static void usb3_irq_epc_int_1_speed(struct renesas_usb3 *usb3)
812 switch (speed) { 812 switch (speed) {
813 case USB_STA_SPEED_SS: 813 case USB_STA_SPEED_SS:
814 usb3->gadget.speed = USB_SPEED_SUPER; 814 usb3->gadget.speed = USB_SPEED_SUPER;
815 usb3->gadget.ep0->maxpacket = USB3_EP0_SS_MAX_PACKET_SIZE;
815 break; 816 break;
816 case USB_STA_SPEED_HS: 817 case USB_STA_SPEED_HS:
817 usb3->gadget.speed = USB_SPEED_HIGH; 818 usb3->gadget.speed = USB_SPEED_HIGH;
819 usb3->gadget.ep0->maxpacket = USB3_EP0_HSFS_MAX_PACKET_SIZE;
818 break; 820 break;
819 case USB_STA_SPEED_FS: 821 case USB_STA_SPEED_FS:
820 usb3->gadget.speed = USB_SPEED_FULL; 822 usb3->gadget.speed = USB_SPEED_FULL;
823 usb3->gadget.ep0->maxpacket = USB3_EP0_HSFS_MAX_PACKET_SIZE;
821 break; 824 break;
822 default: 825 default:
823 usb3->gadget.speed = USB_SPEED_UNKNOWN; 826 usb3->gadget.speed = USB_SPEED_UNKNOWN;
@@ -2513,7 +2516,7 @@ static int renesas_usb3_init_ep(struct renesas_usb3 *usb3, struct device *dev,
2513 /* for control pipe */ 2516 /* for control pipe */
2514 usb3->gadget.ep0 = &usb3_ep->ep; 2517 usb3->gadget.ep0 = &usb3_ep->ep;
2515 usb_ep_set_maxpacket_limit(&usb3_ep->ep, 2518 usb_ep_set_maxpacket_limit(&usb3_ep->ep,
2516 USB3_EP0_HSFS_MAX_PACKET_SIZE); 2519 USB3_EP0_SS_MAX_PACKET_SIZE);
2517 usb3_ep->ep.caps.type_control = true; 2520 usb3_ep->ep.caps.type_control = true;
2518 usb3_ep->ep.caps.dir_in = true; 2521 usb3_ep->ep.caps.dir_in = true;
2519 usb3_ep->ep.caps.dir_out = true; 2522 usb3_ep->ep.caps.dir_out = true;
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
index 072bd5d5738e..5b8a3d9530c4 100644
--- a/drivers/usb/host/u132-hcd.c
+++ b/drivers/usb/host/u132-hcd.c
@@ -2555,7 +2555,7 @@ static int u132_get_frame(struct usb_hcd *hcd)
2555 } else { 2555 } else {
2556 int frame = 0; 2556 int frame = 0;
2557 dev_err(&u132->platform_dev->dev, "TODO: u132_get_frame\n"); 2557 dev_err(&u132->platform_dev->dev, "TODO: u132_get_frame\n");
2558 msleep(100); 2558 mdelay(100);
2559 return frame; 2559 return frame;
2560 } 2560 }
2561} 2561}
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index ef350c33dc4a..b1f27aa38b10 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1613,6 +1613,10 @@ void xhci_endpoint_copy(struct xhci_hcd *xhci,
1613 in_ep_ctx->ep_info2 = out_ep_ctx->ep_info2; 1613 in_ep_ctx->ep_info2 = out_ep_ctx->ep_info2;
1614 in_ep_ctx->deq = out_ep_ctx->deq; 1614 in_ep_ctx->deq = out_ep_ctx->deq;
1615 in_ep_ctx->tx_info = out_ep_ctx->tx_info; 1615 in_ep_ctx->tx_info = out_ep_ctx->tx_info;
1616 if (xhci->quirks & XHCI_MTK_HOST) {
1617 in_ep_ctx->reserved[0] = out_ep_ctx->reserved[0];
1618 in_ep_ctx->reserved[1] = out_ep_ctx->reserved[1];
1619 }
1616} 1620}
1617 1621
1618/* Copy output xhci_slot_ctx to the input xhci_slot_ctx. 1622/* Copy output xhci_slot_ctx to the input xhci_slot_ctx.
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 7334da9e9779..71d0d33c3286 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -642,10 +642,10 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev)
642 xhci_mtk_host_enable(mtk); 642 xhci_mtk_host_enable(mtk);
643 643
644 xhci_dbg(xhci, "%s: restart port polling\n", __func__); 644 xhci_dbg(xhci, "%s: restart port polling\n", __func__);
645 set_bit(HCD_FLAG_POLL_RH, &hcd->flags);
646 usb_hcd_poll_rh_status(hcd);
647 set_bit(HCD_FLAG_POLL_RH, &xhci->shared_hcd->flags); 645 set_bit(HCD_FLAG_POLL_RH, &xhci->shared_hcd->flags);
648 usb_hcd_poll_rh_status(xhci->shared_hcd); 646 usb_hcd_poll_rh_status(xhci->shared_hcd);
647 set_bit(HCD_FLAG_POLL_RH, &hcd->flags);
648 usb_hcd_poll_rh_status(hcd);
649 return 0; 649 return 0;
650} 650}
651 651
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 6372edf339d9..722860eb5a91 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -185,6 +185,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
185 } 185 }
186 if (pdev->vendor == PCI_VENDOR_ID_INTEL && 186 if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
187 (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI || 187 (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
188 pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
189 pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_XHCI ||
188 pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI || 190 pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI ||
189 pdev->device == PCI_DEVICE_ID_INTEL_DNV_XHCI)) 191 pdev->device == PCI_DEVICE_ID_INTEL_DNV_XHCI))
190 xhci->quirks |= XHCI_MISSING_CAS; 192 xhci->quirks |= XHCI_MISSING_CAS;
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 8dc77e34a859..94e939249b2b 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -153,7 +153,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
153{ 153{
154 const struct xhci_plat_priv *priv_match; 154 const struct xhci_plat_priv *priv_match;
155 const struct hc_driver *driver; 155 const struct hc_driver *driver;
156 struct device *sysdev; 156 struct device *sysdev, *tmpdev;
157 struct xhci_hcd *xhci; 157 struct xhci_hcd *xhci;
158 struct resource *res; 158 struct resource *res;
159 struct usb_hcd *hcd; 159 struct usb_hcd *hcd;
@@ -273,19 +273,24 @@ static int xhci_plat_probe(struct platform_device *pdev)
273 goto disable_clk; 273 goto disable_clk;
274 } 274 }
275 275
276 if (device_property_read_bool(sysdev, "usb2-lpm-disable")) 276 /* imod_interval is the interrupt moderation value in nanoseconds. */
277 xhci->quirks |= XHCI_HW_LPM_DISABLE; 277 xhci->imod_interval = 40000;
278 278
279 if (device_property_read_bool(sysdev, "usb3-lpm-capable")) 279 /* Iterate over all parent nodes for finding quirks */
280 xhci->quirks |= XHCI_LPM_SUPPORT; 280 for (tmpdev = &pdev->dev; tmpdev; tmpdev = tmpdev->parent) {
281 281
282 if (device_property_read_bool(&pdev->dev, "quirk-broken-port-ped")) 282 if (device_property_read_bool(tmpdev, "usb2-lpm-disable"))
283 xhci->quirks |= XHCI_BROKEN_PORT_PED; 283 xhci->quirks |= XHCI_HW_LPM_DISABLE;
284 284
285 /* imod_interval is the interrupt moderation value in nanoseconds. */ 285 if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
286 xhci->imod_interval = 40000; 286 xhci->quirks |= XHCI_LPM_SUPPORT;
287 device_property_read_u32(sysdev, "imod-interval-ns", 287
288 &xhci->imod_interval); 288 if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
289 xhci->quirks |= XHCI_BROKEN_PORT_PED;
290
291 device_property_read_u32(tmpdev, "imod-interval-ns",
292 &xhci->imod_interval);
293 }
289 294
290 hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev, "usb-phy", 0); 295 hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev, "usb-phy", 0);
291 if (IS_ERR(hcd->usb_phy)) { 296 if (IS_ERR(hcd->usb_phy)) {
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 61f48b17e57b..0420eefa647a 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -37,6 +37,21 @@ static unsigned long long quirks;
37module_param(quirks, ullong, S_IRUGO); 37module_param(quirks, ullong, S_IRUGO);
38MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default"); 38MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");
39 39
40static bool td_on_ring(struct xhci_td *td, struct xhci_ring *ring)
41{
42 struct xhci_segment *seg = ring->first_seg;
43
44 if (!td || !td->start_seg)
45 return false;
46 do {
47 if (seg == td->start_seg)
48 return true;
49 seg = seg->next;
50 } while (seg && seg != ring->first_seg);
51
52 return false;
53}
54
40/* TODO: copied from ehci-hcd.c - can this be refactored? */ 55/* TODO: copied from ehci-hcd.c - can this be refactored? */
41/* 56/*
42 * xhci_handshake - spin reading hc until handshake completes or fails 57 * xhci_handshake - spin reading hc until handshake completes or fails
@@ -1571,6 +1586,21 @@ static int xhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
1571 goto done; 1586 goto done;
1572 } 1587 }
1573 1588
1589 /*
1590 * check ring is not re-allocated since URB was enqueued. If it is, then
1591 * make sure none of the ring related pointers in this URB private data
1592 * are touched, such as td_list, otherwise we overwrite freed data
1593 */
1594 if (!td_on_ring(&urb_priv->td[0], ep_ring)) {
1595 xhci_err(xhci, "Canceled URB td not found on endpoint ring");
1596 for (i = urb_priv->num_tds_done; i < urb_priv->num_tds; i++) {
1597 td = &urb_priv->td[i];
1598 if (!list_empty(&td->cancelled_td_list))
1599 list_del_init(&td->cancelled_td_list);
1600 }
1601 goto err_giveback;
1602 }
1603
1574 if (xhci->xhc_state & XHCI_STATE_HALTED) { 1604 if (xhci->xhc_state & XHCI_STATE_HALTED) {
1575 xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb, 1605 xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb,
1576 "HC halted, freeing TD manually."); 1606 "HC halted, freeing TD manually.");
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 82f220631bd7..b5d661644263 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -369,7 +369,7 @@ static unsigned char parport_uss720_frob_control(struct parport *pp, unsigned ch
369 mask &= 0x0f; 369 mask &= 0x0f;
370 val &= 0x0f; 370 val &= 0x0f;
371 d = (priv->reg[1] & (~mask)) ^ val; 371 d = (priv->reg[1] & (~mask)) ^ val;
372 if (set_1284_register(pp, 2, d, GFP_KERNEL)) 372 if (set_1284_register(pp, 2, d, GFP_ATOMIC))
373 return 0; 373 return 0;
374 priv->reg[1] = d; 374 priv->reg[1] = d;
375 return d & 0xf; 375 return d & 0xf;
@@ -379,7 +379,7 @@ static unsigned char parport_uss720_read_status(struct parport *pp)
379{ 379{
380 unsigned char ret; 380 unsigned char ret;
381 381
382 if (get_1284_register(pp, 1, &ret, GFP_KERNEL)) 382 if (get_1284_register(pp, 1, &ret, GFP_ATOMIC))
383 return 0; 383 return 0;
384 return ret & 0xf8; 384 return ret & 0xf8;
385} 385}
diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c
index 3be40eaa1ac9..6d9fd5f64903 100644
--- a/drivers/usb/misc/yurex.c
+++ b/drivers/usb/misc/yurex.c
@@ -413,6 +413,9 @@ static ssize_t yurex_read(struct file *file, char __user *buffer, size_t count,
413 spin_unlock_irqrestore(&dev->lock, flags); 413 spin_unlock_irqrestore(&dev->lock, flags);
414 mutex_unlock(&dev->io_mutex); 414 mutex_unlock(&dev->io_mutex);
415 415
416 if (WARN_ON_ONCE(len >= sizeof(in_buffer)))
417 return -EIO;
418
416 return simple_read_from_buffer(buffer, count, ppos, in_buffer, len); 419 return simple_read_from_buffer(buffer, count, ppos, in_buffer, len);
417} 420}
418 421
@@ -421,13 +424,13 @@ static ssize_t yurex_write(struct file *file, const char __user *user_buffer,
421{ 424{
422 struct usb_yurex *dev; 425 struct usb_yurex *dev;
423 int i, set = 0, retval = 0; 426 int i, set = 0, retval = 0;
424 char buffer[16]; 427 char buffer[16 + 1];
425 char *data = buffer; 428 char *data = buffer;
426 unsigned long long c, c2 = 0; 429 unsigned long long c, c2 = 0;
427 signed long timeout = 0; 430 signed long timeout = 0;
428 DEFINE_WAIT(wait); 431 DEFINE_WAIT(wait);
429 432
430 count = min(sizeof(buffer), count); 433 count = min(sizeof(buffer) - 1, count);
431 dev = file->private_data; 434 dev = file->private_data;
432 435
433 /* verify that we actually have some data to write */ 436 /* verify that we actually have some data to write */
@@ -446,6 +449,7 @@ static ssize_t yurex_write(struct file *file, const char __user *user_buffer,
446 retval = -EFAULT; 449 retval = -EFAULT;
447 goto error; 450 goto error;
448 } 451 }
452 buffer[count] = 0;
449 memset(dev->cntl_buffer, CMD_PADDING, YUREX_BUF_SIZE); 453 memset(dev->cntl_buffer, CMD_PADDING, YUREX_BUF_SIZE);
450 454
451 switch (buffer[0]) { 455 switch (buffer[0]) {
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
index eecfd0671362..d045d8458f81 100644
--- a/drivers/usb/mtu3/mtu3_core.c
+++ b/drivers/usb/mtu3/mtu3_core.c
@@ -107,8 +107,12 @@ static int mtu3_device_enable(struct mtu3 *mtu)
107 (SSUSB_U2_PORT_DIS | SSUSB_U2_PORT_PDN | 107 (SSUSB_U2_PORT_DIS | SSUSB_U2_PORT_PDN |
108 SSUSB_U2_PORT_HOST_SEL)); 108 SSUSB_U2_PORT_HOST_SEL));
109 109
110 if (mtu->ssusb->dr_mode == USB_DR_MODE_OTG) 110 if (mtu->ssusb->dr_mode == USB_DR_MODE_OTG) {
111 mtu3_setbits(ibase, SSUSB_U2_CTRL(0), SSUSB_U2_PORT_OTG_SEL); 111 mtu3_setbits(ibase, SSUSB_U2_CTRL(0), SSUSB_U2_PORT_OTG_SEL);
112 if (mtu->is_u3_ip)
113 mtu3_setbits(ibase, SSUSB_U3_CTRL(0),
114 SSUSB_U3_PORT_DUAL_MODE);
115 }
112 116
113 return ssusb_check_clocks(mtu->ssusb, check_clk); 117 return ssusb_check_clocks(mtu->ssusb, check_clk);
114} 118}
diff --git a/drivers/usb/mtu3/mtu3_hw_regs.h b/drivers/usb/mtu3/mtu3_hw_regs.h
index 6ee371478d89..a45bb253939f 100644
--- a/drivers/usb/mtu3/mtu3_hw_regs.h
+++ b/drivers/usb/mtu3/mtu3_hw_regs.h
@@ -459,6 +459,7 @@
459 459
460/* U3D_SSUSB_U3_CTRL_0P */ 460/* U3D_SSUSB_U3_CTRL_0P */
461#define SSUSB_U3_PORT_SSP_SPEED BIT(9) 461#define SSUSB_U3_PORT_SSP_SPEED BIT(9)
462#define SSUSB_U3_PORT_DUAL_MODE BIT(7)
462#define SSUSB_U3_PORT_HOST_SEL BIT(2) 463#define SSUSB_U3_PORT_HOST_SEL BIT(2)
463#define SSUSB_U3_PORT_PDN BIT(1) 464#define SSUSB_U3_PORT_PDN BIT(1)
464#define SSUSB_U3_PORT_DIS BIT(0) 465#define SSUSB_U3_PORT_DIS BIT(0)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index df827ff57b0d..23a0df79ef21 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -658,16 +658,6 @@ dsps_dma_controller_create(struct musb *musb, void __iomem *base)
658 return controller; 658 return controller;
659} 659}
660 660
661static void dsps_dma_controller_destroy(struct dma_controller *c)
662{
663 struct musb *musb = c->musb;
664 struct dsps_glue *glue = dev_get_drvdata(musb->controller->parent);
665 void __iomem *usbss_base = glue->usbss_base;
666
667 musb_writel(usbss_base, USBSS_IRQ_CLEARR, USBSS_IRQ_PD_COMP);
668 cppi41_dma_controller_destroy(c);
669}
670
671#ifdef CONFIG_PM_SLEEP 661#ifdef CONFIG_PM_SLEEP
672static void dsps_dma_controller_suspend(struct dsps_glue *glue) 662static void dsps_dma_controller_suspend(struct dsps_glue *glue)
673{ 663{
@@ -697,7 +687,7 @@ static struct musb_platform_ops dsps_ops = {
697 687
698#ifdef CONFIG_USB_TI_CPPI41_DMA 688#ifdef CONFIG_USB_TI_CPPI41_DMA
699 .dma_init = dsps_dma_controller_create, 689 .dma_init = dsps_dma_controller_create,
700 .dma_exit = dsps_dma_controller_destroy, 690 .dma_exit = cppi41_dma_controller_destroy,
701#endif 691#endif
702 .enable = dsps_musb_enable, 692 .enable = dsps_musb_enable,
703 .disable = dsps_musb_disable, 693 .disable = dsps_musb_disable,
diff --git a/drivers/usb/serial/io_ti.h b/drivers/usb/serial/io_ti.h
index e53c68261017..9bbcee37524e 100644
--- a/drivers/usb/serial/io_ti.h
+++ b/drivers/usb/serial/io_ti.h
@@ -173,7 +173,7 @@ struct ump_interrupt {
173} __attribute__((packed)); 173} __attribute__((packed));
174 174
175 175
176#define TIUMP_GET_PORT_FROM_CODE(c) (((c) >> 4) - 3) 176#define TIUMP_GET_PORT_FROM_CODE(c) (((c) >> 6) & 0x01)
177#define TIUMP_GET_FUNC_FROM_CODE(c) ((c) & 0x0f) 177#define TIUMP_GET_FUNC_FROM_CODE(c) ((c) & 0x0f)
178#define TIUMP_INTERRUPT_CODE_LSR 0x03 178#define TIUMP_INTERRUPT_CODE_LSR 0x03
179#define TIUMP_INTERRUPT_CODE_MSR 0x04 179#define TIUMP_INTERRUPT_CODE_MSR 0x04
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 0215b70c4efc..e72ad9f81c73 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -561,6 +561,9 @@ static void option_instat_callback(struct urb *urb);
561/* Interface is reserved */ 561/* Interface is reserved */
562#define RSVD(ifnum) ((BIT(ifnum) & 0xff) << 0) 562#define RSVD(ifnum) ((BIT(ifnum) & 0xff) << 0)
563 563
564/* Interface must have two endpoints */
565#define NUMEP2 BIT(16)
566
564 567
565static const struct usb_device_id option_ids[] = { 568static const struct usb_device_id option_ids[] = {
566 { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) }, 569 { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },
@@ -1081,8 +1084,9 @@ static const struct usb_device_id option_ids[] = {
1081 .driver_info = RSVD(4) }, 1084 .driver_info = RSVD(4) },
1082 { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96), 1085 { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
1083 .driver_info = RSVD(4) }, 1086 .driver_info = RSVD(4) },
1084 { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06), 1087 { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06, 0xff, 0xff, 0xff),
1085 .driver_info = RSVD(4) | RSVD(5) }, 1088 .driver_info = RSVD(1) | RSVD(2) | RSVD(3) | RSVD(4) | NUMEP2 },
1089 { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06, 0xff, 0, 0) },
1086 { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) }, 1090 { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
1087 { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) }, 1091 { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
1088 { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003), 1092 { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
@@ -1999,6 +2003,13 @@ static int option_probe(struct usb_serial *serial,
1999 if (device_flags & RSVD(iface_desc->bInterfaceNumber)) 2003 if (device_flags & RSVD(iface_desc->bInterfaceNumber))
2000 return -ENODEV; 2004 return -ENODEV;
2001 2005
2006 /*
2007 * Allow matching on bNumEndpoints for devices whose interface numbers
2008 * can change (e.g. Quectel EP06).
2009 */
2010 if (device_flags & NUMEP2 && iface_desc->bNumEndpoints != 2)
2011 return -ENODEV;
2012
2002 /* Store the device flags so we can use them during attach. */ 2013 /* Store the device flags so we can use them during attach. */
2003 usb_set_serial_data(serial, (void *)device_flags); 2014 usb_set_serial_data(serial, (void *)device_flags);
2004 2015
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index 3010878f7f8e..e3c5832337e0 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -1119,7 +1119,7 @@ static void ti_break(struct tty_struct *tty, int break_state)
1119 1119
1120static int ti_get_port_from_code(unsigned char code) 1120static int ti_get_port_from_code(unsigned char code)
1121{ 1121{
1122 return (code >> 4) - 3; 1122 return (code >> 6) & 0x01;
1123} 1123}
1124 1124
1125static int ti_get_func_from_code(unsigned char code) 1125static int ti_get_func_from_code(unsigned char code)
diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index 40864c2bd9dc..4d0273508043 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -84,7 +84,8 @@ DEVICE(moto_modem, MOTO_IDS);
84 84
85/* Motorola Tetra driver */ 85/* Motorola Tetra driver */
86#define MOTOROLA_TETRA_IDS() \ 86#define MOTOROLA_TETRA_IDS() \
87 { USB_DEVICE(0x0cad, 0x9011) } /* Motorola Solutions TETRA PEI */ 87 { USB_DEVICE(0x0cad, 0x9011) }, /* Motorola Solutions TETRA PEI */ \
88 { USB_DEVICE(0x0cad, 0x9012) } /* MTP6550 */
88DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS); 89DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);
89 90
90/* Novatel Wireless GPS driver */ 91/* Novatel Wireless GPS driver */
diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index c267f2812a04..e227bb5b794f 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -376,6 +376,15 @@ static int queuecommand_lck(struct scsi_cmnd *srb,
376 return 0; 376 return 0;
377 } 377 }
378 378
379 if ((us->fflags & US_FL_NO_ATA_1X) &&
380 (srb->cmnd[0] == ATA_12 || srb->cmnd[0] == ATA_16)) {
381 memcpy(srb->sense_buffer, usb_stor_sense_invalidCDB,
382 sizeof(usb_stor_sense_invalidCDB));
383 srb->result = SAM_STAT_CHECK_CONDITION;
384 done(srb);
385 return 0;
386 }
387
379 /* enqueue the command and wake up the control thread */ 388 /* enqueue the command and wake up the control thread */
380 srb->scsi_done = done; 389 srb->scsi_done = done;
381 us->srb = srb; 390 us->srb = srb;
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 9e9de5452860..1f7b401c4d04 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -842,6 +842,27 @@ static int uas_slave_configure(struct scsi_device *sdev)
842 sdev->skip_ms_page_8 = 1; 842 sdev->skip_ms_page_8 = 1;
843 sdev->wce_default_on = 1; 843 sdev->wce_default_on = 1;
844 } 844 }
845
846 /*
847 * Some disks return the total number of blocks in response
848 * to READ CAPACITY rather than the highest block number.
849 * If this device makes that mistake, tell the sd driver.
850 */
851 if (devinfo->flags & US_FL_FIX_CAPACITY)
852 sdev->fix_capacity = 1;
853
854 /*
855 * Some devices don't like MODE SENSE with page=0x3f,
856 * which is the command used for checking if a device
857 * is write-protected. Now that we tell the sd driver
858 * to do a 192-byte transfer with this command the
859 * majority of devices work fine, but a few still can't
860 * handle it. The sd driver will simply assume those
861 * devices are write-enabled.
862 */
863 if (devinfo->flags & US_FL_NO_WP_DETECT)
864 sdev->skip_ms_page_3f = 1;
865
845 scsi_change_queue_depth(sdev, devinfo->qdepth - 2); 866 scsi_change_queue_depth(sdev, devinfo->qdepth - 2);
846 return 0; 867 return 0;
847} 868}
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 22fcfccf453a..f7f83b21dc74 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2288,6 +2288,13 @@ UNUSUAL_DEV( 0x2735, 0x100b, 0x0000, 0x9999,
2288 USB_SC_DEVICE, USB_PR_DEVICE, NULL, 2288 USB_SC_DEVICE, USB_PR_DEVICE, NULL,
2289 US_FL_GO_SLOW ), 2289 US_FL_GO_SLOW ),
2290 2290
2291/* Reported-by: Tim Anderson <tsa@biglakesoftware.com> */
2292UNUSUAL_DEV( 0x2ca3, 0x0031, 0x0000, 0x9999,
2293 "DJI",
2294 "CineSSD",
2295 USB_SC_DEVICE, USB_PR_DEVICE, NULL,
2296 US_FL_NO_ATA_1X),
2297
2291/* 2298/*
2292 * Reported by Frederic Marchal <frederic.marchal@wowcompany.com> 2299 * Reported by Frederic Marchal <frederic.marchal@wowcompany.com>
2293 * Mio Moov 330 2300 * Mio Moov 330
diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c
index 95a2b10127db..76299b6ff06d 100644
--- a/drivers/usb/typec/bus.c
+++ b/drivers/usb/typec/bus.c
@@ -255,12 +255,13 @@ EXPORT_SYMBOL_GPL(typec_altmode_unregister_driver);
255/* API for the port drivers */ 255/* API for the port drivers */
256 256
257/** 257/**
258 * typec_match_altmode - Match SVID to an array of alternate modes 258 * typec_match_altmode - Match SVID and mode to an array of alternate modes
259 * @altmodes: Array of alternate modes 259 * @altmodes: Array of alternate modes
260 * @n: Number of elements in the array, or -1 for NULL termiated arrays 260 * @n: Number of elements in the array, or -1 for NULL terminated arrays
261 * @svid: Standard or Vendor ID to match with 261 * @svid: Standard or Vendor ID to match with
262 * @mode: Mode to match with
262 * 263 *
263 * Return pointer to an alternate mode with SVID mathing @svid, or NULL when no 264 * Return pointer to an alternate mode with SVID matching @svid, or NULL when no
264 * match is found. 265 * match is found.
265 */ 266 */
266struct typec_altmode *typec_match_altmode(struct typec_altmode **altmodes, 267struct typec_altmode *typec_match_altmode(struct typec_altmode **altmodes,
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index c202975f8097..e61dffb27a0c 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -1484,7 +1484,6 @@ EXPORT_SYMBOL_GPL(typec_set_mode);
1484 * typec_port_register_altmode - Register USB Type-C Port Alternate Mode 1484 * typec_port_register_altmode - Register USB Type-C Port Alternate Mode
1485 * @port: USB Type-C Port that supports the alternate mode 1485 * @port: USB Type-C Port that supports the alternate mode
1486 * @desc: Description of the alternate mode 1486 * @desc: Description of the alternate mode
1487 * @drvdata: Private pointer to driver specific info
1488 * 1487 *
1489 * This routine is used to register an alternate mode that @port is capable of 1488 * This routine is used to register an alternate mode that @port is capable of
1490 * supporting. 1489 * supporting.
diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
index ddaac63ecf12..d990aa510fab 100644
--- a/drivers/usb/typec/mux.c
+++ b/drivers/usb/typec/mux.c
@@ -9,6 +9,7 @@
9 9
10#include <linux/device.h> 10#include <linux/device.h>
11#include <linux/list.h> 11#include <linux/list.h>
12#include <linux/module.h>
12#include <linux/mutex.h> 13#include <linux/mutex.h>
13#include <linux/usb/typec_mux.h> 14#include <linux/usb/typec_mux.h>
14 15
@@ -49,8 +50,10 @@ struct typec_switch *typec_switch_get(struct device *dev)
49 mutex_lock(&switch_lock); 50 mutex_lock(&switch_lock);
50 sw = device_connection_find_match(dev, "typec-switch", NULL, 51 sw = device_connection_find_match(dev, "typec-switch", NULL,
51 typec_switch_match); 52 typec_switch_match);
52 if (!IS_ERR_OR_NULL(sw)) 53 if (!IS_ERR_OR_NULL(sw)) {
54 WARN_ON(!try_module_get(sw->dev->driver->owner));
53 get_device(sw->dev); 55 get_device(sw->dev);
56 }
54 mutex_unlock(&switch_lock); 57 mutex_unlock(&switch_lock);
55 58
56 return sw; 59 return sw;
@@ -65,8 +68,10 @@ EXPORT_SYMBOL_GPL(typec_switch_get);
65 */ 68 */
66void typec_switch_put(struct typec_switch *sw) 69void typec_switch_put(struct typec_switch *sw)
67{ 70{
68 if (!IS_ERR_OR_NULL(sw)) 71 if (!IS_ERR_OR_NULL(sw)) {
72 module_put(sw->dev->driver->owner);
69 put_device(sw->dev); 73 put_device(sw->dev);
74 }
70} 75}
71EXPORT_SYMBOL_GPL(typec_switch_put); 76EXPORT_SYMBOL_GPL(typec_switch_put);
72 77
@@ -136,8 +141,10 @@ struct typec_mux *typec_mux_get(struct device *dev, const char *name)
136 141
137 mutex_lock(&mux_lock); 142 mutex_lock(&mux_lock);
138 mux = device_connection_find_match(dev, name, NULL, typec_mux_match); 143 mux = device_connection_find_match(dev, name, NULL, typec_mux_match);
139 if (!IS_ERR_OR_NULL(mux)) 144 if (!IS_ERR_OR_NULL(mux)) {
145 WARN_ON(!try_module_get(mux->dev->driver->owner));
140 get_device(mux->dev); 146 get_device(mux->dev);
147 }
141 mutex_unlock(&mux_lock); 148 mutex_unlock(&mux_lock);
142 149
143 return mux; 150 return mux;
@@ -152,8 +159,10 @@ EXPORT_SYMBOL_GPL(typec_mux_get);
152 */ 159 */
153void typec_mux_put(struct typec_mux *mux) 160void typec_mux_put(struct typec_mux *mux)
154{ 161{
155 if (!IS_ERR_OR_NULL(mux)) 162 if (!IS_ERR_OR_NULL(mux)) {
163 module_put(mux->dev->driver->owner);
156 put_device(mux->dev); 164 put_device(mux->dev);
165 }
157} 166}
158EXPORT_SYMBOL_GPL(typec_mux_put); 167EXPORT_SYMBOL_GPL(typec_mux_put);
159 168
diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h
index 8235b285dbb2..d09bab3bf224 100644
--- a/drivers/video/fbdev/aty/atyfb.h
+++ b/drivers/video/fbdev/aty/atyfb.h
@@ -333,6 +333,8 @@ extern const struct aty_pll_ops aty_pll_ct; /* Integrated */
333extern void aty_set_pll_ct(const struct fb_info *info, const union aty_pll *pll); 333extern void aty_set_pll_ct(const struct fb_info *info, const union aty_pll *pll);
334extern u8 aty_ld_pll_ct(int offset, const struct atyfb_par *par); 334extern u8 aty_ld_pll_ct(int offset, const struct atyfb_par *par);
335 335
336extern const u8 aty_postdividers[8];
337
336 338
337 /* 339 /*
338 * Hardware cursor support 340 * Hardware cursor support
@@ -359,7 +361,6 @@ static inline void wait_for_idle(struct atyfb_par *par)
359 361
360extern void aty_reset_engine(const struct atyfb_par *par); 362extern void aty_reset_engine(const struct atyfb_par *par);
361extern void aty_init_engine(struct atyfb_par *par, struct fb_info *info); 363extern void aty_init_engine(struct atyfb_par *par, struct fb_info *info);
362extern u8 aty_ld_pll_ct(int offset, const struct atyfb_par *par);
363 364
364void atyfb_copyarea(struct fb_info *info, const struct fb_copyarea *area); 365void atyfb_copyarea(struct fb_info *info, const struct fb_copyarea *area);
365void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect); 366void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index a9a8272f7a6e..05111e90f168 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -3087,17 +3087,18 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
3087 /* 3087 /*
3088 * PLL Reference Divider M: 3088 * PLL Reference Divider M:
3089 */ 3089 */
3090 M = pll_regs[2]; 3090 M = pll_regs[PLL_REF_DIV];
3091 3091
3092 /* 3092 /*
3093 * PLL Feedback Divider N (Dependent on CLOCK_CNTL): 3093 * PLL Feedback Divider N (Dependent on CLOCK_CNTL):
3094 */ 3094 */
3095 N = pll_regs[7 + (clock_cntl & 3)]; 3095 N = pll_regs[VCLK0_FB_DIV + (clock_cntl & 3)];
3096 3096
3097 /* 3097 /*
3098 * PLL Post Divider P (Dependent on CLOCK_CNTL): 3098 * PLL Post Divider P (Dependent on CLOCK_CNTL):
3099 */ 3099 */
3100 P = 1 << (pll_regs[6] >> ((clock_cntl & 3) << 1)); 3100 P = aty_postdividers[((pll_regs[VCLK_POST_DIV] >> ((clock_cntl & 3) << 1)) & 3) |
3101 ((pll_regs[PLL_EXT_CNTL] >> (2 + (clock_cntl & 3))) & 4)];
3101 3102
3102 /* 3103 /*
3103 * PLL Divider Q: 3104 * PLL Divider Q:
diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c
index 74a62aa193c0..f87cc81f4fa2 100644
--- a/drivers/video/fbdev/aty/mach64_ct.c
+++ b/drivers/video/fbdev/aty/mach64_ct.c
@@ -115,7 +115,7 @@ static void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par)
115 */ 115 */
116 116
117#define Maximum_DSP_PRECISION 7 117#define Maximum_DSP_PRECISION 7
118static u8 postdividers[] = {1,2,4,8,3}; 118const u8 aty_postdividers[8] = {1,2,4,8,3,5,6,12};
119 119
120static int aty_dsp_gt(const struct fb_info *info, u32 bpp, struct pll_ct *pll) 120static int aty_dsp_gt(const struct fb_info *info, u32 bpp, struct pll_ct *pll)
121{ 121{
@@ -222,7 +222,7 @@ static int aty_valid_pll_ct(const struct fb_info *info, u32 vclk_per, struct pll
222 pll->vclk_post_div += (q < 64*8); 222 pll->vclk_post_div += (q < 64*8);
223 pll->vclk_post_div += (q < 32*8); 223 pll->vclk_post_div += (q < 32*8);
224 } 224 }
225 pll->vclk_post_div_real = postdividers[pll->vclk_post_div]; 225 pll->vclk_post_div_real = aty_postdividers[pll->vclk_post_div];
226 // pll->vclk_post_div <<= 6; 226 // pll->vclk_post_div <<= 6;
227 pll->vclk_fb_div = q * pll->vclk_post_div_real / 8; 227 pll->vclk_fb_div = q * pll->vclk_post_div_real / 8;
228 pllvclk = (1000000 * 2 * pll->vclk_fb_div) / 228 pllvclk = (1000000 * 2 * pll->vclk_fb_div) /
@@ -513,7 +513,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
513 u8 mclk_fb_div, pll_ext_cntl; 513 u8 mclk_fb_div, pll_ext_cntl;
514 pll->ct.pll_ref_div = aty_ld_pll_ct(PLL_REF_DIV, par); 514 pll->ct.pll_ref_div = aty_ld_pll_ct(PLL_REF_DIV, par);
515 pll_ext_cntl = aty_ld_pll_ct(PLL_EXT_CNTL, par); 515 pll_ext_cntl = aty_ld_pll_ct(PLL_EXT_CNTL, par);
516 pll->ct.xclk_post_div_real = postdividers[pll_ext_cntl & 0x07]; 516 pll->ct.xclk_post_div_real = aty_postdividers[pll_ext_cntl & 0x07];
517 mclk_fb_div = aty_ld_pll_ct(MCLK_FB_DIV, par); 517 mclk_fb_div = aty_ld_pll_ct(MCLK_FB_DIV, par);
518 if (pll_ext_cntl & PLL_MFB_TIMES_4_2B) 518 if (pll_ext_cntl & PLL_MFB_TIMES_4_2B)
519 mclk_fb_div <<= 1; 519 mclk_fb_div <<= 1;
@@ -535,7 +535,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
535 xpost_div += (q < 64*8); 535 xpost_div += (q < 64*8);
536 xpost_div += (q < 32*8); 536 xpost_div += (q < 32*8);
537 } 537 }
538 pll->ct.xclk_post_div_real = postdividers[xpost_div]; 538 pll->ct.xclk_post_div_real = aty_postdividers[xpost_div];
539 pll->ct.mclk_fb_div = q * pll->ct.xclk_post_div_real / 8; 539 pll->ct.mclk_fb_div = q * pll->ct.xclk_post_div_real / 8;
540 540
541#ifdef CONFIG_PPC 541#ifdef CONFIG_PPC
@@ -584,7 +584,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
584 mpost_div += (q < 64*8); 584 mpost_div += (q < 64*8);
585 mpost_div += (q < 32*8); 585 mpost_div += (q < 32*8);
586 } 586 }
587 sclk_post_div_real = postdividers[mpost_div]; 587 sclk_post_div_real = aty_postdividers[mpost_div];
588 pll->ct.sclk_fb_div = q * sclk_post_div_real / 8; 588 pll->ct.sclk_fb_div = q * sclk_post_div_real / 8;
589 pll->ct.spll_cntl2 = mpost_div << 4; 589 pll->ct.spll_cntl2 = mpost_div << 4;
590#ifdef DEBUG 590#ifdef DEBUG
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 3946649b85c8..ba906876cc45 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -42,6 +42,7 @@ struct bmp_dib_header {
42 u32 colors_important; 42 u32 colors_important;
43} __packed; 43} __packed;
44 44
45static bool use_bgrt = true;
45static bool request_mem_succeeded = false; 46static bool request_mem_succeeded = false;
46static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC; 47static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC;
47 48
@@ -160,6 +161,9 @@ static void efifb_show_boot_graphics(struct fb_info *info)
160 void *bgrt_image = NULL; 161 void *bgrt_image = NULL;
161 u8 *dst = info->screen_base; 162 u8 *dst = info->screen_base;
162 163
164 if (!use_bgrt)
165 return;
166
163 if (!bgrt_tab.image_address) { 167 if (!bgrt_tab.image_address) {
164 pr_info("efifb: No BGRT, not showing boot graphics\n"); 168 pr_info("efifb: No BGRT, not showing boot graphics\n");
165 return; 169 return;
@@ -290,6 +294,8 @@ static int efifb_setup(char *options)
290 screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0); 294 screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
291 else if (!strcmp(this_opt, "nowc")) 295 else if (!strcmp(this_opt, "nowc"))
292 mem_flags &= ~EFI_MEMORY_WC; 296 mem_flags &= ~EFI_MEMORY_WC;
297 else if (!strcmp(this_opt, "nobgrt"))
298 use_bgrt = false;
293 } 299 }
294 } 300 }
295 301
diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
index ef69273074ba..a3edb20ea4c3 100644
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
@@ -496,6 +496,9 @@ static int omapfb_memory_read(struct fb_info *fbi,
496 if (!access_ok(VERIFY_WRITE, mr->buffer, mr->buffer_size)) 496 if (!access_ok(VERIFY_WRITE, mr->buffer, mr->buffer_size))
497 return -EFAULT; 497 return -EFAULT;
498 498
499 if (mr->w > 4096 || mr->h > 4096)
500 return -EINVAL;
501
499 if (mr->w * mr->h * 3 > mr->buffer_size) 502 if (mr->w * mr->h * 3 > mr->buffer_size)
500 return -EINVAL; 503 return -EINVAL;
501 504
@@ -509,7 +512,7 @@ static int omapfb_memory_read(struct fb_info *fbi,
509 mr->x, mr->y, mr->w, mr->h); 512 mr->x, mr->y, mr->w, mr->h);
510 513
511 if (r > 0) { 514 if (r > 0) {
512 if (copy_to_user(mr->buffer, buf, mr->buffer_size)) 515 if (copy_to_user(mr->buffer, buf, r))
513 r = -EFAULT; 516 r = -EFAULT;
514 } 517 }
515 518
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index def3a501acd6..d059d04c63ac 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -712,7 +712,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
712 /* 712 /*
713 * enable controller clock 713 * enable controller clock
714 */ 714 */
715 clk_enable(fbi->clk); 715 clk_prepare_enable(fbi->clk);
716 716
717 pxa168fb_set_par(info); 717 pxa168fb_set_par(info);
718 718
@@ -767,7 +767,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
767failed_free_cmap: 767failed_free_cmap:
768 fb_dealloc_cmap(&info->cmap); 768 fb_dealloc_cmap(&info->cmap);
769failed_free_clk: 769failed_free_clk:
770 clk_disable(fbi->clk); 770 clk_disable_unprepare(fbi->clk);
771failed_free_fbmem: 771failed_free_fbmem:
772 dma_free_coherent(fbi->dev, info->fix.smem_len, 772 dma_free_coherent(fbi->dev, info->fix.smem_len,
773 info->screen_base, fbi->fb_start_dma); 773 info->screen_base, fbi->fb_start_dma);
@@ -807,7 +807,7 @@ static int pxa168fb_remove(struct platform_device *pdev)
807 dma_free_wc(fbi->dev, PAGE_ALIGN(info->fix.smem_len), 807 dma_free_wc(fbi->dev, PAGE_ALIGN(info->fix.smem_len),
808 info->screen_base, info->fix.smem_start); 808 info->screen_base, info->fix.smem_start);
809 809
810 clk_disable(fbi->clk); 810 clk_disable_unprepare(fbi->clk);
811 811
812 framebuffer_release(info); 812 framebuffer_release(info);
813 813
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 045e8afe398b..9e88e3f594c2 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1157,7 +1157,7 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
1157 dev_name); 1157 dev_name);
1158 goto out_err0; 1158 goto out_err0;
1159 } 1159 }
1160 /* fall though */ 1160 /* fall through */
1161 case S9000_ID_ARTIST: 1161 case S9000_ID_ARTIST:
1162 case S9000_ID_HCRX: 1162 case S9000_ID_HCRX:
1163 case S9000_ID_TIMBER: 1163 case S9000_ID_TIMBER:
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index b459edfacff3..90d387b50ab7 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -79,15 +79,19 @@ config XEN_BALLOON_MEMORY_HOTPLUG_LIMIT
79 This value is used to allocate enough space in internal 79 This value is used to allocate enough space in internal
80 tables needed for physical memory administration. 80 tables needed for physical memory administration.
81 81
82config XEN_SCRUB_PAGES 82config XEN_SCRUB_PAGES_DEFAULT
83 bool "Scrub pages before returning them to system" 83 bool "Scrub pages before returning them to system by default"
84 depends on XEN_BALLOON 84 depends on XEN_BALLOON
85 default y 85 default y
86 help 86 help
87 Scrub pages before returning them to the system for reuse by 87 Scrub pages before returning them to the system for reuse by
88 other domains. This makes sure that any confidential data 88 other domains. This makes sure that any confidential data
89 is not accidentally visible to other domains. Is it more 89 is not accidentally visible to other domains. Is it more
90 secure, but slightly less efficient. 90 secure, but slightly less efficient. This can be controlled with
91 xen_scrub_pages=0 parameter and
92 /sys/devices/system/xen_memory/xen_memory0/scrub_pages.
93 This option only sets the default value.
94
91 If in doubt, say yes. 95 If in doubt, say yes.
92 96
93config XEN_DEV_EVTCHN 97config XEN_DEV_EVTCHN
diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
index d4265c8ebb22..b1357aa4bc55 100644
--- a/drivers/xen/cpu_hotplug.c
+++ b/drivers/xen/cpu_hotplug.c
@@ -19,15 +19,16 @@ static void enable_hotplug_cpu(int cpu)
19 19
20static void disable_hotplug_cpu(int cpu) 20static void disable_hotplug_cpu(int cpu)
21{ 21{
22 if (cpu_online(cpu)) { 22 if (!cpu_is_hotpluggable(cpu))
23 lock_device_hotplug(); 23 return;
24 lock_device_hotplug();
25 if (cpu_online(cpu))
24 device_offline(get_cpu_device(cpu)); 26 device_offline(get_cpu_device(cpu));
25 unlock_device_hotplug(); 27 if (!cpu_online(cpu) && cpu_present(cpu)) {
26 }
27 if (cpu_present(cpu))
28 xen_arch_unregister_cpu(cpu); 28 xen_arch_unregister_cpu(cpu);
29 29 set_cpu_present(cpu, false);
30 set_cpu_present(cpu, false); 30 }
31 unlock_device_hotplug();
31} 32}
32 33
33static int vcpu_online(unsigned int cpu) 34static int vcpu_online(unsigned int cpu)
diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 08e4af04d6f2..e6c1934734b7 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -138,7 +138,7 @@ static int set_evtchn_to_irq(unsigned evtchn, unsigned irq)
138 clear_evtchn_to_irq_row(row); 138 clear_evtchn_to_irq_row(row);
139 } 139 }
140 140
141 evtchn_to_irq[EVTCHN_ROW(evtchn)][EVTCHN_COL(evtchn)] = irq; 141 evtchn_to_irq[row][col] = irq;
142 return 0; 142 return 0;
143} 143}
144 144
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 57390c7666e5..b0b02a501167 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -492,12 +492,19 @@ static bool in_range(struct gntdev_grant_map *map,
492 return true; 492 return true;
493} 493}
494 494
495static void unmap_if_in_range(struct gntdev_grant_map *map, 495static int unmap_if_in_range(struct gntdev_grant_map *map,
496 unsigned long start, unsigned long end) 496 unsigned long start, unsigned long end,
497 bool blockable)
497{ 498{
498 unsigned long mstart, mend; 499 unsigned long mstart, mend;
499 int err; 500 int err;
500 501
502 if (!in_range(map, start, end))
503 return 0;
504
505 if (!blockable)
506 return -EAGAIN;
507
501 mstart = max(start, map->vma->vm_start); 508 mstart = max(start, map->vma->vm_start);
502 mend = min(end, map->vma->vm_end); 509 mend = min(end, map->vma->vm_end);
503 pr_debug("map %d+%d (%lx %lx), range %lx %lx, mrange %lx %lx\n", 510 pr_debug("map %d+%d (%lx %lx), range %lx %lx, mrange %lx %lx\n",
@@ -508,6 +515,8 @@ static void unmap_if_in_range(struct gntdev_grant_map *map,
508 (mstart - map->vma->vm_start) >> PAGE_SHIFT, 515 (mstart - map->vma->vm_start) >> PAGE_SHIFT,
509 (mend - mstart) >> PAGE_SHIFT); 516 (mend - mstart) >> PAGE_SHIFT);
510 WARN_ON(err); 517 WARN_ON(err);
518
519 return 0;
511} 520}
512 521
513static int mn_invl_range_start(struct mmu_notifier *mn, 522static int mn_invl_range_start(struct mmu_notifier *mn,
@@ -519,25 +528,20 @@ static int mn_invl_range_start(struct mmu_notifier *mn,
519 struct gntdev_grant_map *map; 528 struct gntdev_grant_map *map;
520 int ret = 0; 529 int ret = 0;
521 530
522 /* TODO do we really need a mutex here? */
523 if (blockable) 531 if (blockable)
524 mutex_lock(&priv->lock); 532 mutex_lock(&priv->lock);
525 else if (!mutex_trylock(&priv->lock)) 533 else if (!mutex_trylock(&priv->lock))
526 return -EAGAIN; 534 return -EAGAIN;
527 535
528 list_for_each_entry(map, &priv->maps, next) { 536 list_for_each_entry(map, &priv->maps, next) {
529 if (in_range(map, start, end)) { 537 ret = unmap_if_in_range(map, start, end, blockable);
530 ret = -EAGAIN; 538 if (ret)
531 goto out_unlock; 539 goto out_unlock;
532 }
533 unmap_if_in_range(map, start, end);
534 } 540 }
535 list_for_each_entry(map, &priv->freeable_maps, next) { 541 list_for_each_entry(map, &priv->freeable_maps, next) {
536 if (in_range(map, start, end)) { 542 ret = unmap_if_in_range(map, start, end, blockable);
537 ret = -EAGAIN; 543 if (ret)
538 goto out_unlock; 544 goto out_unlock;
539 }
540 unmap_if_in_range(map, start, end);
541 } 545 }
542 546
543out_unlock: 547out_unlock:
diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 7bafa703a992..84575baceebc 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -1040,18 +1040,33 @@ int gnttab_map_refs(struct gnttab_map_grant_ref *map_ops,
1040 return ret; 1040 return ret;
1041 1041
1042 for (i = 0; i < count; i++) { 1042 for (i = 0; i < count; i++) {
1043 /* Retry eagain maps */ 1043 switch (map_ops[i].status) {
1044 if (map_ops[i].status == GNTST_eagain) 1044 case GNTST_okay:
1045 gnttab_retry_eagain_gop(GNTTABOP_map_grant_ref, map_ops + i, 1045 {
1046 &map_ops[i].status, __func__);
1047
1048 if (map_ops[i].status == GNTST_okay) {
1049 struct xen_page_foreign *foreign; 1046 struct xen_page_foreign *foreign;
1050 1047
1051 SetPageForeign(pages[i]); 1048 SetPageForeign(pages[i]);
1052 foreign = xen_page_foreign(pages[i]); 1049 foreign = xen_page_foreign(pages[i]);
1053 foreign->domid = map_ops[i].dom; 1050 foreign->domid = map_ops[i].dom;
1054 foreign->gref = map_ops[i].ref; 1051 foreign->gref = map_ops[i].ref;
1052 break;
1053 }
1054
1055 case GNTST_no_device_space:
1056 pr_warn_ratelimited("maptrack limit reached, can't map all guest pages\n");
1057 break;
1058
1059 case GNTST_eagain:
1060 /* Retry eagain maps */
1061 gnttab_retry_eagain_gop(GNTTABOP_map_grant_ref,
1062 map_ops + i,
1063 &map_ops[i].status, __func__);
1064 /* Test status in next loop iteration. */
1065 i--;
1066 break;
1067
1068 default:
1069 break;
1055 } 1070 }
1056 } 1071 }
1057 1072
diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index c93d8ef8df34..5bb01a62f214 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -280,9 +280,11 @@ static void sysrq_handler(struct xenbus_watch *watch, const char *path,
280 /* 280 /*
281 * The Xenstore watch fires directly after registering it and 281 * The Xenstore watch fires directly after registering it and
282 * after a suspend/resume cycle. So ENOENT is no error but 282 * after a suspend/resume cycle. So ENOENT is no error but
283 * might happen in those cases. 283 * might happen in those cases. ERANGE is observed when we get
284 * an empty value (''), this happens when we acknowledge the
285 * request by writing '\0' below.
284 */ 286 */
285 if (err != -ENOENT) 287 if (err != -ENOENT && err != -ERANGE)
286 pr_err("Error %d reading sysrq code in control/sysrq\n", 288 pr_err("Error %d reading sysrq code in control/sysrq\n",
287 err); 289 err);
288 xenbus_transaction_end(xbt, 1); 290 xenbus_transaction_end(xbt, 1);
diff --git a/drivers/xen/mem-reservation.c b/drivers/xen/mem-reservation.c
index 084799c6180e..3782cf070338 100644
--- a/drivers/xen/mem-reservation.c
+++ b/drivers/xen/mem-reservation.c
@@ -14,6 +14,10 @@
14 14
15#include <xen/interface/memory.h> 15#include <xen/interface/memory.h>
16#include <xen/mem-reservation.h> 16#include <xen/mem-reservation.h>
17#include <linux/moduleparam.h>
18
19bool __read_mostly xen_scrub_pages = IS_ENABLED(CONFIG_XEN_SCRUB_PAGES_DEFAULT);
20core_param(xen_scrub_pages, xen_scrub_pages, bool, 0);
17 21
18/* 22/*
19 * Use one extent per PAGE_SIZE to avoid to break down the page into 23 * Use one extent per PAGE_SIZE to avoid to break down the page into
diff --git a/drivers/xen/xen-balloon.c b/drivers/xen/xen-balloon.c
index 294f35ce9e46..63c1494a8d73 100644
--- a/drivers/xen/xen-balloon.c
+++ b/drivers/xen/xen-balloon.c
@@ -44,6 +44,7 @@
44#include <xen/xenbus.h> 44#include <xen/xenbus.h>
45#include <xen/features.h> 45#include <xen/features.h>
46#include <xen/page.h> 46#include <xen/page.h>
47#include <xen/mem-reservation.h>
47 48
48#define PAGES2KB(_p) ((_p)<<(PAGE_SHIFT-10)) 49#define PAGES2KB(_p) ((_p)<<(PAGE_SHIFT-10))
49 50
@@ -137,6 +138,7 @@ static DEVICE_ULONG_ATTR(schedule_delay, 0444, balloon_stats.schedule_delay);
137static DEVICE_ULONG_ATTR(max_schedule_delay, 0644, balloon_stats.max_schedule_delay); 138static DEVICE_ULONG_ATTR(max_schedule_delay, 0644, balloon_stats.max_schedule_delay);
138static DEVICE_ULONG_ATTR(retry_count, 0444, balloon_stats.retry_count); 139static DEVICE_ULONG_ATTR(retry_count, 0444, balloon_stats.retry_count);
139static DEVICE_ULONG_ATTR(max_retry_count, 0644, balloon_stats.max_retry_count); 140static DEVICE_ULONG_ATTR(max_retry_count, 0644, balloon_stats.max_retry_count);
141static DEVICE_BOOL_ATTR(scrub_pages, 0644, xen_scrub_pages);
140 142
141static ssize_t show_target_kb(struct device *dev, struct device_attribute *attr, 143static ssize_t show_target_kb(struct device *dev, struct device_attribute *attr,
142 char *buf) 144 char *buf)
@@ -203,6 +205,7 @@ static struct attribute *balloon_attrs[] = {
203 &dev_attr_max_schedule_delay.attr.attr, 205 &dev_attr_max_schedule_delay.attr.attr,
204 &dev_attr_retry_count.attr.attr, 206 &dev_attr_retry_count.attr.attr,
205 &dev_attr_max_retry_count.attr.attr, 207 &dev_attr_max_retry_count.attr.attr,
208 &dev_attr_scrub_pages.attr.attr,
206 NULL 209 NULL
207}; 210};
208 211
diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index f3d0bef16d78..6127f0fcd62c 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -514,6 +514,8 @@ static int afs_alloc_anon_key(struct afs_cell *cell)
514 */ 514 */
515static int afs_activate_cell(struct afs_net *net, struct afs_cell *cell) 515static int afs_activate_cell(struct afs_net *net, struct afs_cell *cell)
516{ 516{
517 struct hlist_node **p;
518 struct afs_cell *pcell;
517 int ret; 519 int ret;
518 520
519 if (!cell->anonymous_key) { 521 if (!cell->anonymous_key) {
@@ -534,7 +536,18 @@ static int afs_activate_cell(struct afs_net *net, struct afs_cell *cell)
534 return ret; 536 return ret;
535 537
536 mutex_lock(&net->proc_cells_lock); 538 mutex_lock(&net->proc_cells_lock);
537 list_add_tail(&cell->proc_link, &net->proc_cells); 539 for (p = &net->proc_cells.first; *p; p = &(*p)->next) {
540 pcell = hlist_entry(*p, struct afs_cell, proc_link);
541 if (strcmp(cell->name, pcell->name) < 0)
542 break;
543 }
544
545 cell->proc_link.pprev = p;
546 cell->proc_link.next = *p;
547 rcu_assign_pointer(*p, &cell->proc_link.next);
548 if (cell->proc_link.next)
549 cell->proc_link.next->pprev = &cell->proc_link.next;
550
538 afs_dynroot_mkdir(net, cell); 551 afs_dynroot_mkdir(net, cell);
539 mutex_unlock(&net->proc_cells_lock); 552 mutex_unlock(&net->proc_cells_lock);
540 return 0; 553 return 0;
@@ -550,7 +563,7 @@ static void afs_deactivate_cell(struct afs_net *net, struct afs_cell *cell)
550 afs_proc_cell_remove(cell); 563 afs_proc_cell_remove(cell);
551 564
552 mutex_lock(&net->proc_cells_lock); 565 mutex_lock(&net->proc_cells_lock);
553 list_del_init(&cell->proc_link); 566 hlist_del_rcu(&cell->proc_link);
554 afs_dynroot_rmdir(net, cell); 567 afs_dynroot_rmdir(net, cell);
555 mutex_unlock(&net->proc_cells_lock); 568 mutex_unlock(&net->proc_cells_lock);
556 569
diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c
index 1cde710a8013..f29c6dade7f6 100644
--- a/fs/afs/dynroot.c
+++ b/fs/afs/dynroot.c
@@ -265,7 +265,7 @@ int afs_dynroot_populate(struct super_block *sb)
265 return -ERESTARTSYS; 265 return -ERESTARTSYS;
266 266
267 net->dynroot_sb = sb; 267 net->dynroot_sb = sb;
268 list_for_each_entry(cell, &net->proc_cells, proc_link) { 268 hlist_for_each_entry(cell, &net->proc_cells, proc_link) {
269 ret = afs_dynroot_mkdir(net, cell); 269 ret = afs_dynroot_mkdir(net, cell);
270 if (ret < 0) 270 if (ret < 0)
271 goto error; 271 goto error;
diff --git a/fs/afs/internal.h b/fs/afs/internal.h
index 871a228d7f37..34c02fdcc25f 100644
--- a/fs/afs/internal.h
+++ b/fs/afs/internal.h
@@ -242,7 +242,7 @@ struct afs_net {
242 seqlock_t cells_lock; 242 seqlock_t cells_lock;
243 243
244 struct mutex proc_cells_lock; 244 struct mutex proc_cells_lock;
245 struct list_head proc_cells; 245 struct hlist_head proc_cells;
246 246
247 /* Known servers. Theoretically each fileserver can only be in one 247 /* Known servers. Theoretically each fileserver can only be in one
248 * cell, but in practice, people create aliases and subsets and there's 248 * cell, but in practice, people create aliases and subsets and there's
@@ -320,7 +320,7 @@ struct afs_cell {
320 struct afs_net *net; 320 struct afs_net *net;
321 struct key *anonymous_key; /* anonymous user key for this cell */ 321 struct key *anonymous_key; /* anonymous user key for this cell */
322 struct work_struct manager; /* Manager for init/deinit/dns */ 322 struct work_struct manager; /* Manager for init/deinit/dns */
323 struct list_head proc_link; /* /proc cell list link */ 323 struct hlist_node proc_link; /* /proc cell list link */
324#ifdef CONFIG_AFS_FSCACHE 324#ifdef CONFIG_AFS_FSCACHE
325 struct fscache_cookie *cache; /* caching cookie */ 325 struct fscache_cookie *cache; /* caching cookie */
326#endif 326#endif
diff --git a/fs/afs/main.c b/fs/afs/main.c
index e84fe822a960..107427688edd 100644
--- a/fs/afs/main.c
+++ b/fs/afs/main.c
@@ -87,7 +87,7 @@ static int __net_init afs_net_init(struct net *net_ns)
87 timer_setup(&net->cells_timer, afs_cells_timer, 0); 87 timer_setup(&net->cells_timer, afs_cells_timer, 0);
88 88
89 mutex_init(&net->proc_cells_lock); 89 mutex_init(&net->proc_cells_lock);
90 INIT_LIST_HEAD(&net->proc_cells); 90 INIT_HLIST_HEAD(&net->proc_cells);
91 91
92 seqlock_init(&net->fs_lock); 92 seqlock_init(&net->fs_lock);
93 net->fs_servers = RB_ROOT; 93 net->fs_servers = RB_ROOT;
diff --git a/fs/afs/proc.c b/fs/afs/proc.c
index 476dcbb79713..9101f62707af 100644
--- a/fs/afs/proc.c
+++ b/fs/afs/proc.c
@@ -33,9 +33,8 @@ static inline struct afs_net *afs_seq2net_single(struct seq_file *m)
33static int afs_proc_cells_show(struct seq_file *m, void *v) 33static int afs_proc_cells_show(struct seq_file *m, void *v)
34{ 34{
35 struct afs_cell *cell = list_entry(v, struct afs_cell, proc_link); 35 struct afs_cell *cell = list_entry(v, struct afs_cell, proc_link);
36 struct afs_net *net = afs_seq2net(m);
37 36
38 if (v == &net->proc_cells) { 37 if (v == SEQ_START_TOKEN) {
39 /* display header on line 1 */ 38 /* display header on line 1 */
40 seq_puts(m, "USE NAME\n"); 39 seq_puts(m, "USE NAME\n");
41 return 0; 40 return 0;
@@ -50,12 +49,12 @@ static void *afs_proc_cells_start(struct seq_file *m, loff_t *_pos)
50 __acquires(rcu) 49 __acquires(rcu)
51{ 50{
52 rcu_read_lock(); 51 rcu_read_lock();
53 return seq_list_start_head(&afs_seq2net(m)->proc_cells, *_pos); 52 return seq_hlist_start_head_rcu(&afs_seq2net(m)->proc_cells, *_pos);
54} 53}
55 54
56static void *afs_proc_cells_next(struct seq_file *m, void *v, loff_t *pos) 55static void *afs_proc_cells_next(struct seq_file *m, void *v, loff_t *pos)
57{ 56{
58 return seq_list_next(v, &afs_seq2net(m)->proc_cells, pos); 57 return seq_hlist_next_rcu(v, &afs_seq2net(m)->proc_cells, pos);
59} 58}
60 59
61static void afs_proc_cells_stop(struct seq_file *m, void *v) 60static void afs_proc_cells_stop(struct seq_file *m, void *v)
diff --git a/fs/afs/server.c b/fs/afs/server.c
index 1d329e6981d5..2f306c0cc4ee 100644
--- a/fs/afs/server.c
+++ b/fs/afs/server.c
@@ -199,9 +199,11 @@ static struct afs_server *afs_install_server(struct afs_net *net,
199 199
200 write_sequnlock(&net->fs_addr_lock); 200 write_sequnlock(&net->fs_addr_lock);
201 ret = 0; 201 ret = 0;
202 goto out;
202 203
203exists: 204exists:
204 afs_get_server(server); 205 afs_get_server(server);
206out:
205 write_sequnlock(&net->fs_lock); 207 write_sequnlock(&net->fs_lock);
206 return server; 208 return server;
207} 209}
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
index 35c83fe7dba0..abcd78e332fe 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -6,6 +6,7 @@ config CIFS
6 select CRYPTO_MD4 6 select CRYPTO_MD4
7 select CRYPTO_MD5 7 select CRYPTO_MD5
8 select CRYPTO_SHA256 8 select CRYPTO_SHA256
9 select CRYPTO_SHA512
9 select CRYPTO_CMAC 10 select CRYPTO_CMAC
10 select CRYPTO_HMAC 11 select CRYPTO_HMAC
11 select CRYPTO_ARC4 12 select CRYPTO_ARC4
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 0c9ab62c3df4..9dcaed031843 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1553,6 +1553,7 @@ static inline void free_dfs_info_array(struct dfs_info3_param *param,
1553 1553
1554/* Flags */ 1554/* Flags */
1555#define MID_WAIT_CANCELLED 1 /* Cancelled while waiting for response */ 1555#define MID_WAIT_CANCELLED 1 /* Cancelled while waiting for response */
1556#define MID_DELETED 2 /* Mid has been dequeued/deleted */
1556 1557
1557/* Types of response buffer returned from SendReceive2 */ 1558/* Types of response buffer returned from SendReceive2 */
1558#define CIFS_NO_BUFFER 0 /* Response buffer not returned */ 1559#define CIFS_NO_BUFFER 0 /* Response buffer not returned */
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index dc2f4cf08fe9..5657b79dbc99 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -601,10 +601,15 @@ CIFSSMBNegotiate(const unsigned int xid, struct cifs_ses *ses)
601 } 601 }
602 602
603 count = 0; 603 count = 0;
604 /*
605 * We know that all the name entries in the protocols array
606 * are short (< 16 bytes anyway) and are NUL terminated.
607 */
604 for (i = 0; i < CIFS_NUM_PROT; i++) { 608 for (i = 0; i < CIFS_NUM_PROT; i++) {
605 strncpy(pSMB->DialectsArray+count, protocols[i].name, 16); 609 size_t len = strlen(protocols[i].name) + 1;
606 count += strlen(protocols[i].name) + 1; 610
607 /* null at end of source and target buffers anyway */ 611 memcpy(pSMB->DialectsArray+count, protocols[i].name, len);
612 count += len;
608 } 613 }
609 inc_rfc1001_len(pSMB, count); 614 inc_rfc1001_len(pSMB, count);
610 pSMB->ByteCount = cpu_to_le16(count); 615 pSMB->ByteCount = cpu_to_le16(count);
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 7aa08dba4719..52d71b64c0c6 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -659,7 +659,15 @@ dequeue_mid(struct mid_q_entry *mid, bool malformed)
659 mid->mid_state = MID_RESPONSE_RECEIVED; 659 mid->mid_state = MID_RESPONSE_RECEIVED;
660 else 660 else
661 mid->mid_state = MID_RESPONSE_MALFORMED; 661 mid->mid_state = MID_RESPONSE_MALFORMED;
662 list_del_init(&mid->qhead); 662 /*
663 * Trying to handle/dequeue a mid after the send_recv()
664 * function has finished processing it is a bug.
665 */
666 if (mid->mid_flags & MID_DELETED)
667 printk_once(KERN_WARNING
668 "trying to dequeue a deleted mid\n");
669 else
670 list_del_init(&mid->qhead);
663 spin_unlock(&GlobalMid_Lock); 671 spin_unlock(&GlobalMid_Lock);
664} 672}
665 673
@@ -938,8 +946,7 @@ next_pdu:
938 } else { 946 } else {
939 mids[0] = server->ops->find_mid(server, buf); 947 mids[0] = server->ops->find_mid(server, buf);
940 bufs[0] = buf; 948 bufs[0] = buf;
941 if (mids[0]) 949 num_mids = 1;
942 num_mids = 1;
943 950
944 if (!mids[0] || !mids[0]->receive) 951 if (!mids[0] || !mids[0]->receive)
945 length = standard_receive3(server, mids[0]); 952 length = standard_receive3(server, mids[0]);
diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index dacb2c05674c..6926685e513c 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -402,9 +402,17 @@ is_valid_oplock_break(char *buffer, struct TCP_Server_Info *srv)
402 (struct smb_com_transaction_change_notify_rsp *)buf; 402 (struct smb_com_transaction_change_notify_rsp *)buf;
403 struct file_notify_information *pnotify; 403 struct file_notify_information *pnotify;
404 __u32 data_offset = 0; 404 __u32 data_offset = 0;
405 size_t len = srv->total_read - sizeof(pSMBr->hdr.smb_buf_length);
406
405 if (get_bcc(buf) > sizeof(struct file_notify_information)) { 407 if (get_bcc(buf) > sizeof(struct file_notify_information)) {
406 data_offset = le32_to_cpu(pSMBr->DataOffset); 408 data_offset = le32_to_cpu(pSMBr->DataOffset);
407 409
410 if (data_offset >
411 len - sizeof(struct file_notify_information)) {
412 cifs_dbg(FYI, "invalid data_offset %u\n",
413 data_offset);
414 return true;
415 }
408 pnotify = (struct file_notify_information *) 416 pnotify = (struct file_notify_information *)
409 ((char *)&pSMBr->hdr.Protocol + data_offset); 417 ((char *)&pSMBr->hdr.Protocol + data_offset);
410 cifs_dbg(FYI, "dnotify on %s Action: 0x%x\n", 418 cifs_dbg(FYI, "dnotify on %s Action: 0x%x\n",
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
index eeab81c9452f..e169e1a5fd35 100644
--- a/fs/cifs/readdir.c
+++ b/fs/cifs/readdir.c
@@ -376,8 +376,15 @@ static char *nxt_dir_entry(char *old_entry, char *end_of_smb, int level)
376 376
377 new_entry = old_entry + sizeof(FIND_FILE_STANDARD_INFO) + 377 new_entry = old_entry + sizeof(FIND_FILE_STANDARD_INFO) +
378 pfData->FileNameLength; 378 pfData->FileNameLength;
379 } else 379 } else {
380 new_entry = old_entry + le32_to_cpu(pDirInfo->NextEntryOffset); 380 u32 next_offset = le32_to_cpu(pDirInfo->NextEntryOffset);
381
382 if (old_entry + next_offset < old_entry) {
383 cifs_dbg(VFS, "invalid offset %u\n", next_offset);
384 return NULL;
385 }
386 new_entry = old_entry + next_offset;
387 }
381 cifs_dbg(FYI, "new entry %p old entry %p\n", new_entry, old_entry); 388 cifs_dbg(FYI, "new entry %p old entry %p\n", new_entry, old_entry);
382 /* validate that new_entry is not past end of SMB */ 389 /* validate that new_entry is not past end of SMB */
383 if (new_entry >= end_of_smb) { 390 if (new_entry >= end_of_smb) {
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index d954ce36b473..89985a0a6819 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -1477,7 +1477,7 @@ smb2_query_dir_first(const unsigned int xid, struct cifs_tcon *tcon,
1477 } 1477 }
1478 1478
1479 srch_inf->entries_in_buffer = 0; 1479 srch_inf->entries_in_buffer = 0;
1480 srch_inf->index_of_last_entry = 0; 1480 srch_inf->index_of_last_entry = 2;
1481 1481
1482 rc = SMB2_query_directory(xid, tcon, fid->persistent_fid, 1482 rc = SMB2_query_directory(xid, tcon, fid->persistent_fid,
1483 fid->volatile_fid, 0, srch_inf); 1483 fid->volatile_fid, 0, srch_inf);
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index c08acfc77abc..f54d07bda067 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -2459,14 +2459,14 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,
2459 /* We check for obvious errors in the output buffer length and offset */ 2459 /* We check for obvious errors in the output buffer length and offset */
2460 if (*plen == 0) 2460 if (*plen == 0)
2461 goto ioctl_exit; /* server returned no data */ 2461 goto ioctl_exit; /* server returned no data */
2462 else if (*plen > 0xFF00) { 2462 else if (*plen > rsp_iov.iov_len || *plen > 0xFF00) {
2463 cifs_dbg(VFS, "srv returned invalid ioctl length: %d\n", *plen); 2463 cifs_dbg(VFS, "srv returned invalid ioctl length: %d\n", *plen);
2464 *plen = 0; 2464 *plen = 0;
2465 rc = -EIO; 2465 rc = -EIO;
2466 goto ioctl_exit; 2466 goto ioctl_exit;
2467 } 2467 }
2468 2468
2469 if (rsp_iov.iov_len < le32_to_cpu(rsp->OutputOffset) + *plen) { 2469 if (rsp_iov.iov_len - *plen < le32_to_cpu(rsp->OutputOffset)) {
2470 cifs_dbg(VFS, "Malformed ioctl resp: len %d offset %d\n", *plen, 2470 cifs_dbg(VFS, "Malformed ioctl resp: len %d offset %d\n", *plen,
2471 le32_to_cpu(rsp->OutputOffset)); 2471 le32_to_cpu(rsp->OutputOffset));
2472 *plen = 0; 2472 *plen = 0;
@@ -3577,33 +3577,38 @@ num_entries(char *bufstart, char *end_of_buf, char **lastentry, size_t size)
3577 int len; 3577 int len;
3578 unsigned int entrycount = 0; 3578 unsigned int entrycount = 0;
3579 unsigned int next_offset = 0; 3579 unsigned int next_offset = 0;
3580 FILE_DIRECTORY_INFO *entryptr; 3580 char *entryptr;
3581 FILE_DIRECTORY_INFO *dir_info;
3581 3582
3582 if (bufstart == NULL) 3583 if (bufstart == NULL)
3583 return 0; 3584 return 0;
3584 3585
3585 entryptr = (FILE_DIRECTORY_INFO *)bufstart; 3586 entryptr = bufstart;
3586 3587
3587 while (1) { 3588 while (1) {
3588 entryptr = (FILE_DIRECTORY_INFO *) 3589 if (entryptr + next_offset < entryptr ||
3589 ((char *)entryptr + next_offset); 3590 entryptr + next_offset > end_of_buf ||
3590 3591 entryptr + next_offset + size > end_of_buf) {
3591 if ((char *)entryptr + size > end_of_buf) {
3592 cifs_dbg(VFS, "malformed search entry would overflow\n"); 3592 cifs_dbg(VFS, "malformed search entry would overflow\n");
3593 break; 3593 break;
3594 } 3594 }
3595 3595
3596 len = le32_to_cpu(entryptr->FileNameLength); 3596 entryptr = entryptr + next_offset;
3597 if ((char *)entryptr + len + size > end_of_buf) { 3597 dir_info = (FILE_DIRECTORY_INFO *)entryptr;
3598
3599 len = le32_to_cpu(dir_info->FileNameLength);
3600 if (entryptr + len < entryptr ||
3601 entryptr + len > end_of_buf ||
3602 entryptr + len + size > end_of_buf) {
3598 cifs_dbg(VFS, "directory entry name would overflow frame end of buf %p\n", 3603 cifs_dbg(VFS, "directory entry name would overflow frame end of buf %p\n",
3599 end_of_buf); 3604 end_of_buf);
3600 break; 3605 break;
3601 } 3606 }
3602 3607
3603 *lastentry = (char *)entryptr; 3608 *lastentry = entryptr;
3604 entrycount++; 3609 entrycount++;
3605 3610
3606 next_offset = le32_to_cpu(entryptr->NextEntryOffset); 3611 next_offset = le32_to_cpu(dir_info->NextEntryOffset);
3607 if (!next_offset) 3612 if (!next_offset)
3608 break; 3613 break;
3609 } 3614 }
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index 78f96fa3d7d9..b48f43963da6 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -142,7 +142,8 @@ void
142cifs_delete_mid(struct mid_q_entry *mid) 142cifs_delete_mid(struct mid_q_entry *mid)
143{ 143{
144 spin_lock(&GlobalMid_Lock); 144 spin_lock(&GlobalMid_Lock);
145 list_del(&mid->qhead); 145 list_del_init(&mid->qhead);
146 mid->mid_flags |= MID_DELETED;
146 spin_unlock(&GlobalMid_Lock); 147 spin_unlock(&GlobalMid_Lock);
147 148
148 DeleteMidQEntry(mid); 149 DeleteMidQEntry(mid);
@@ -772,6 +773,11 @@ cifs_setup_request(struct cifs_ses *ses, struct smb_rqst *rqst)
772 return mid; 773 return mid;
773} 774}
774 775
776static void
777cifs_noop_callback(struct mid_q_entry *mid)
778{
779}
780
775int 781int
776compound_send_recv(const unsigned int xid, struct cifs_ses *ses, 782compound_send_recv(const unsigned int xid, struct cifs_ses *ses,
777 const int flags, const int num_rqst, struct smb_rqst *rqst, 783 const int flags, const int num_rqst, struct smb_rqst *rqst,
@@ -826,8 +832,13 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses,
826 } 832 }
827 833
828 midQ[i]->mid_state = MID_REQUEST_SUBMITTED; 834 midQ[i]->mid_state = MID_REQUEST_SUBMITTED;
835 /*
836 * We don't invoke the callback compounds unless it is the last
837 * request.
838 */
839 if (i < num_rqst - 1)
840 midQ[i]->callback = cifs_noop_callback;
829 } 841 }
830
831 cifs_in_send_inc(ses->server); 842 cifs_in_send_inc(ses->server);
832 rc = smb_send_rqst(ses->server, num_rqst, rqst, flags); 843 rc = smb_send_rqst(ses->server, num_rqst, rqst, flags);
833 cifs_in_send_dec(ses->server); 844 cifs_in_send_dec(ses->server);
@@ -908,6 +919,12 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses,
908 midQ[i]->resp_buf = NULL; 919 midQ[i]->resp_buf = NULL;
909 } 920 }
910out: 921out:
922 /*
923 * This will dequeue all mids. After this it is important that the
924 * demultiplex_thread will not process any of these mids any futher.
925 * This is prevented above by using a noop callback that will not
926 * wake this thread except for the very last PDU.
927 */
911 for (i = 0; i < num_rqst; i++) 928 for (i = 0; i < num_rqst; i++)
912 cifs_delete_mid(midQ[i]); 929 cifs_delete_mid(midQ[i]);
913 add_credits(ses->server, credits, optype); 930 add_credits(ses->server, credits, optype);
diff --git a/fs/dax.c b/fs/dax.c
index f32d7125ad0f..0fb270f0a0ef 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -447,6 +447,7 @@ bool dax_lock_mapping_entry(struct page *page)
447 xa_unlock_irq(&mapping->i_pages); 447 xa_unlock_irq(&mapping->i_pages);
448 break; 448 break;
449 } else if (IS_ERR(entry)) { 449 } else if (IS_ERR(entry)) {
450 xa_unlock_irq(&mapping->i_pages);
450 WARN_ON_ONCE(PTR_ERR(entry) != -EAGAIN); 451 WARN_ON_ONCE(PTR_ERR(entry) != -EAGAIN);
451 continue; 452 continue;
452 } 453 }
@@ -665,6 +666,8 @@ struct page *dax_layout_busy_page(struct address_space *mapping)
665 while (index < end && pagevec_lookup_entries(&pvec, mapping, index, 666 while (index < end && pagevec_lookup_entries(&pvec, mapping, index,
666 min(end - index, (pgoff_t)PAGEVEC_SIZE), 667 min(end - index, (pgoff_t)PAGEVEC_SIZE),
667 indices)) { 668 indices)) {
669 pgoff_t nr_pages = 1;
670
668 for (i = 0; i < pagevec_count(&pvec); i++) { 671 for (i = 0; i < pagevec_count(&pvec); i++) {
669 struct page *pvec_ent = pvec.pages[i]; 672 struct page *pvec_ent = pvec.pages[i];
670 void *entry; 673 void *entry;
@@ -679,8 +682,15 @@ struct page *dax_layout_busy_page(struct address_space *mapping)
679 682
680 xa_lock_irq(&mapping->i_pages); 683 xa_lock_irq(&mapping->i_pages);
681 entry = get_unlocked_mapping_entry(mapping, index, NULL); 684 entry = get_unlocked_mapping_entry(mapping, index, NULL);
682 if (entry) 685 if (entry) {
683 page = dax_busy_page(entry); 686 page = dax_busy_page(entry);
687 /*
688 * Account for multi-order entries at
689 * the end of the pagevec.
690 */
691 if (i + 1 >= pagevec_count(&pvec))
692 nr_pages = 1UL << dax_radix_order(entry);
693 }
684 put_unlocked_mapping_entry(mapping, index, entry); 694 put_unlocked_mapping_entry(mapping, index, entry);
685 xa_unlock_irq(&mapping->i_pages); 695 xa_unlock_irq(&mapping->i_pages);
686 if (page) 696 if (page)
@@ -695,7 +705,7 @@ struct page *dax_layout_busy_page(struct address_space *mapping)
695 */ 705 */
696 pagevec_remove_exceptionals(&pvec); 706 pagevec_remove_exceptionals(&pvec);
697 pagevec_release(&pvec); 707 pagevec_release(&pvec);
698 index++; 708 index += nr_pages;
699 709
700 if (page) 710 if (page)
701 break; 711 break;
@@ -1120,21 +1130,12 @@ static vm_fault_t dax_load_hole(struct address_space *mapping, void *entry,
1120{ 1130{
1121 struct inode *inode = mapping->host; 1131 struct inode *inode = mapping->host;
1122 unsigned long vaddr = vmf->address; 1132 unsigned long vaddr = vmf->address;
1123 vm_fault_t ret = VM_FAULT_NOPAGE; 1133 pfn_t pfn = pfn_to_pfn_t(my_zero_pfn(vaddr));
1124 struct page *zero_page; 1134 vm_fault_t ret;
1125 pfn_t pfn;
1126
1127 zero_page = ZERO_PAGE(0);
1128 if (unlikely(!zero_page)) {
1129 ret = VM_FAULT_OOM;
1130 goto out;
1131 }
1132 1135
1133 pfn = page_to_pfn_t(zero_page);
1134 dax_insert_mapping_entry(mapping, vmf, entry, pfn, RADIX_DAX_ZERO_PAGE, 1136 dax_insert_mapping_entry(mapping, vmf, entry, pfn, RADIX_DAX_ZERO_PAGE,
1135 false); 1137 false);
1136 ret = vmf_insert_mixed(vmf->vma, vaddr, pfn); 1138 ret = vmf_insert_mixed(vmf->vma, vaddr, pfn);
1137out:
1138 trace_dax_load_hole(inode, vmf, ret); 1139 trace_dax_load_hole(inode, vmf, ret);
1139 return ret; 1140 return ret;
1140} 1141}
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 7f7ee18fe179..e4bb9386c045 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -1448,6 +1448,7 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
1448 } 1448 }
1449 inode->i_blocks = le32_to_cpu(raw_inode->i_blocks); 1449 inode->i_blocks = le32_to_cpu(raw_inode->i_blocks);
1450 ei->i_flags = le32_to_cpu(raw_inode->i_flags); 1450 ei->i_flags = le32_to_cpu(raw_inode->i_flags);
1451 ext2_set_inode_flags(inode);
1451 ei->i_faddr = le32_to_cpu(raw_inode->i_faddr); 1452 ei->i_faddr = le32_to_cpu(raw_inode->i_faddr);
1452 ei->i_frag_no = raw_inode->i_frag; 1453 ei->i_frag_no = raw_inode->i_frag;
1453 ei->i_frag_size = raw_inode->i_fsize; 1454 ei->i_frag_size = raw_inode->i_fsize;
@@ -1517,7 +1518,6 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
1517 new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); 1518 new_decode_dev(le32_to_cpu(raw_inode->i_block[1])));
1518 } 1519 }
1519 brelse (bh); 1520 brelse (bh);
1520 ext2_set_inode_flags(inode);
1521 unlock_new_inode(inode); 1521 unlock_new_inode(inode);
1522 return inode; 1522 return inode;
1523 1523
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index e2902d394f1b..f93f9881ec18 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -76,7 +76,7 @@ int __ext4_check_dir_entry(const char *function, unsigned int line,
76 else if (unlikely(rlen < EXT4_DIR_REC_LEN(de->name_len))) 76 else if (unlikely(rlen < EXT4_DIR_REC_LEN(de->name_len)))
77 error_msg = "rec_len is too small for name_len"; 77 error_msg = "rec_len is too small for name_len";
78 else if (unlikely(((char *) de - buf) + rlen > size)) 78 else if (unlikely(((char *) de - buf) + rlen > size))
79 error_msg = "directory entry across range"; 79 error_msg = "directory entry overrun";
80 else if (unlikely(le32_to_cpu(de->inode) > 80 else if (unlikely(le32_to_cpu(de->inode) >
81 le32_to_cpu(EXT4_SB(dir->i_sb)->s_es->s_inodes_count))) 81 le32_to_cpu(EXT4_SB(dir->i_sb)->s_es->s_inodes_count)))
82 error_msg = "inode out of bounds"; 82 error_msg = "inode out of bounds";
@@ -85,18 +85,16 @@ int __ext4_check_dir_entry(const char *function, unsigned int line,
85 85
86 if (filp) 86 if (filp)
87 ext4_error_file(filp, function, line, bh->b_blocknr, 87 ext4_error_file(filp, function, line, bh->b_blocknr,
88 "bad entry in directory: %s - offset=%u(%u), " 88 "bad entry in directory: %s - offset=%u, "
89 "inode=%u, rec_len=%d, name_len=%d", 89 "inode=%u, rec_len=%d, name_len=%d, size=%d",
90 error_msg, (unsigned) (offset % size), 90 error_msg, offset, le32_to_cpu(de->inode),
91 offset, le32_to_cpu(de->inode), 91 rlen, de->name_len, size);
92 rlen, de->name_len);
93 else 92 else
94 ext4_error_inode(dir, function, line, bh->b_blocknr, 93 ext4_error_inode(dir, function, line, bh->b_blocknr,
95 "bad entry in directory: %s - offset=%u(%u), " 94 "bad entry in directory: %s - offset=%u, "
96 "inode=%u, rec_len=%d, name_len=%d", 95 "inode=%u, rec_len=%d, name_len=%d, size=%d",
97 error_msg, (unsigned) (offset % size), 96 error_msg, offset, le32_to_cpu(de->inode),
98 offset, le32_to_cpu(de->inode), 97 rlen, de->name_len, size);
99 rlen, de->name_len);
100 98
101 return 1; 99 return 1;
102} 100}
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 0f0edd1cd0cd..caff935fbeb8 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -43,6 +43,17 @@
43#define __FS_HAS_ENCRYPTION IS_ENABLED(CONFIG_EXT4_FS_ENCRYPTION) 43#define __FS_HAS_ENCRYPTION IS_ENABLED(CONFIG_EXT4_FS_ENCRYPTION)
44#include <linux/fscrypt.h> 44#include <linux/fscrypt.h>
45 45
46#include <linux/compiler.h>
47
48/* Until this gets included into linux/compiler-gcc.h */
49#ifndef __nonstring
50#if defined(GCC_VERSION) && (GCC_VERSION >= 80000)
51#define __nonstring __attribute__((nonstring))
52#else
53#define __nonstring
54#endif
55#endif
56
46/* 57/*
47 * The fourth extended filesystem constants/structures 58 * The fourth extended filesystem constants/structures
48 */ 59 */
@@ -675,6 +686,9 @@ enum {
675/* Max physical block we can address w/o extents */ 686/* Max physical block we can address w/o extents */
676#define EXT4_MAX_BLOCK_FILE_PHYS 0xFFFFFFFF 687#define EXT4_MAX_BLOCK_FILE_PHYS 0xFFFFFFFF
677 688
689/* Max logical block we can support */
690#define EXT4_MAX_LOGICAL_BLOCK 0xFFFFFFFF
691
678/* 692/*
679 * Structure of an inode on the disk 693 * Structure of an inode on the disk
680 */ 694 */
@@ -1226,7 +1240,7 @@ struct ext4_super_block {
1226 __le32 s_feature_ro_compat; /* readonly-compatible feature set */ 1240 __le32 s_feature_ro_compat; /* readonly-compatible feature set */
1227/*68*/ __u8 s_uuid[16]; /* 128-bit uuid for volume */ 1241/*68*/ __u8 s_uuid[16]; /* 128-bit uuid for volume */
1228/*78*/ char s_volume_name[16]; /* volume name */ 1242/*78*/ char s_volume_name[16]; /* volume name */
1229/*88*/ char s_last_mounted[64]; /* directory where last mounted */ 1243/*88*/ char s_last_mounted[64] __nonstring; /* directory where last mounted */
1230/*C8*/ __le32 s_algorithm_usage_bitmap; /* For compression */ 1244/*C8*/ __le32 s_algorithm_usage_bitmap; /* For compression */
1231 /* 1245 /*
1232 * Performance hints. Directory preallocation should only 1246 * Performance hints. Directory preallocation should only
@@ -1277,13 +1291,13 @@ struct ext4_super_block {
1277 __le32 s_first_error_time; /* first time an error happened */ 1291 __le32 s_first_error_time; /* first time an error happened */
1278 __le32 s_first_error_ino; /* inode involved in first error */ 1292 __le32 s_first_error_ino; /* inode involved in first error */
1279 __le64 s_first_error_block; /* block involved of first error */ 1293 __le64 s_first_error_block; /* block involved of first error */
1280 __u8 s_first_error_func[32]; /* function where the error happened */ 1294 __u8 s_first_error_func[32] __nonstring; /* function where the error happened */
1281 __le32 s_first_error_line; /* line number where error happened */ 1295 __le32 s_first_error_line; /* line number where error happened */
1282 __le32 s_last_error_time; /* most recent time of an error */ 1296 __le32 s_last_error_time; /* most recent time of an error */
1283 __le32 s_last_error_ino; /* inode involved in last error */ 1297 __le32 s_last_error_ino; /* inode involved in last error */
1284 __le32 s_last_error_line; /* line number where error happened */ 1298 __le32 s_last_error_line; /* line number where error happened */
1285 __le64 s_last_error_block; /* block involved of last error */ 1299 __le64 s_last_error_block; /* block involved of last error */
1286 __u8 s_last_error_func[32]; /* function where the error happened */ 1300 __u8 s_last_error_func[32] __nonstring; /* function where the error happened */
1287#define EXT4_S_ERR_END offsetof(struct ext4_super_block, s_mount_opts) 1301#define EXT4_S_ERR_END offsetof(struct ext4_super_block, s_mount_opts)
1288 __u8 s_mount_opts[64]; 1302 __u8 s_mount_opts[64];
1289 __le32 s_usr_quota_inum; /* inode for tracking user quota */ 1303 __le32 s_usr_quota_inum; /* inode for tracking user quota */
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 3543fe80a3c4..7b4736022761 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1753,6 +1753,7 @@ bool empty_inline_dir(struct inode *dir, int *has_inline_data)
1753{ 1753{
1754 int err, inline_size; 1754 int err, inline_size;
1755 struct ext4_iloc iloc; 1755 struct ext4_iloc iloc;
1756 size_t inline_len;
1756 void *inline_pos; 1757 void *inline_pos;
1757 unsigned int offset; 1758 unsigned int offset;
1758 struct ext4_dir_entry_2 *de; 1759 struct ext4_dir_entry_2 *de;
@@ -1780,8 +1781,9 @@ bool empty_inline_dir(struct inode *dir, int *has_inline_data)
1780 goto out; 1781 goto out;
1781 } 1782 }
1782 1783
1784 inline_len = ext4_get_inline_size(dir);
1783 offset = EXT4_INLINE_DOTDOT_SIZE; 1785 offset = EXT4_INLINE_DOTDOT_SIZE;
1784 while (offset < dir->i_size) { 1786 while (offset < inline_len) {
1785 de = ext4_get_inline_entry(dir, &iloc, offset, 1787 de = ext4_get_inline_entry(dir, &iloc, offset,
1786 &inline_pos, &inline_size); 1788 &inline_pos, &inline_size);
1787 if (ext4_check_dir_entry(dir, NULL, de, 1789 if (ext4_check_dir_entry(dir, NULL, de,
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index d0dd585add6a..d767e993591d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3413,12 +3413,16 @@ static int ext4_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
3413{ 3413{
3414 struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); 3414 struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
3415 unsigned int blkbits = inode->i_blkbits; 3415 unsigned int blkbits = inode->i_blkbits;
3416 unsigned long first_block = offset >> blkbits; 3416 unsigned long first_block, last_block;
3417 unsigned long last_block = (offset + length - 1) >> blkbits;
3418 struct ext4_map_blocks map; 3417 struct ext4_map_blocks map;
3419 bool delalloc = false; 3418 bool delalloc = false;
3420 int ret; 3419 int ret;
3421 3420
3421 if ((offset >> blkbits) > EXT4_MAX_LOGICAL_BLOCK)
3422 return -EINVAL;
3423 first_block = offset >> blkbits;
3424 last_block = min_t(loff_t, (offset + length - 1) >> blkbits,
3425 EXT4_MAX_LOGICAL_BLOCK);
3422 3426
3423 if (flags & IOMAP_REPORT) { 3427 if (flags & IOMAP_REPORT) {
3424 if (ext4_has_inline_data(inode)) { 3428 if (ext4_has_inline_data(inode)) {
@@ -3948,6 +3952,7 @@ static const struct address_space_operations ext4_dax_aops = {
3948 .writepages = ext4_dax_writepages, 3952 .writepages = ext4_dax_writepages,
3949 .direct_IO = noop_direct_IO, 3953 .direct_IO = noop_direct_IO,
3950 .set_page_dirty = noop_set_page_dirty, 3954 .set_page_dirty = noop_set_page_dirty,
3955 .bmap = ext4_bmap,
3951 .invalidatepage = noop_invalidatepage, 3956 .invalidatepage = noop_invalidatepage,
3952}; 3957};
3953 3958
@@ -4192,9 +4197,8 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset,
4192 return 0; 4197 return 0;
4193} 4198}
4194 4199
4195static void ext4_wait_dax_page(struct ext4_inode_info *ei, bool *did_unlock) 4200static void ext4_wait_dax_page(struct ext4_inode_info *ei)
4196{ 4201{
4197 *did_unlock = true;
4198 up_write(&ei->i_mmap_sem); 4202 up_write(&ei->i_mmap_sem);
4199 schedule(); 4203 schedule();
4200 down_write(&ei->i_mmap_sem); 4204 down_write(&ei->i_mmap_sem);
@@ -4204,14 +4208,12 @@ int ext4_break_layouts(struct inode *inode)
4204{ 4208{
4205 struct ext4_inode_info *ei = EXT4_I(inode); 4209 struct ext4_inode_info *ei = EXT4_I(inode);
4206 struct page *page; 4210 struct page *page;
4207 bool retry;
4208 int error; 4211 int error;
4209 4212
4210 if (WARN_ON_ONCE(!rwsem_is_locked(&ei->i_mmap_sem))) 4213 if (WARN_ON_ONCE(!rwsem_is_locked(&ei->i_mmap_sem)))
4211 return -EINVAL; 4214 return -EINVAL;
4212 4215
4213 do { 4216 do {
4214 retry = false;
4215 page = dax_layout_busy_page(inode->i_mapping); 4217 page = dax_layout_busy_page(inode->i_mapping);
4216 if (!page) 4218 if (!page)
4217 return 0; 4219 return 0;
@@ -4219,8 +4221,8 @@ int ext4_break_layouts(struct inode *inode)
4219 error = ___wait_var_event(&page->_refcount, 4221 error = ___wait_var_event(&page->_refcount,
4220 atomic_read(&page->_refcount) == 1, 4222 atomic_read(&page->_refcount) == 1,
4221 TASK_INTERRUPTIBLE, 0, 0, 4223 TASK_INTERRUPTIBLE, 0, 0,
4222 ext4_wait_dax_page(ei, &retry)); 4224 ext4_wait_dax_page(ei));
4223 } while (error == 0 && retry); 4225 } while (error == 0);
4224 4226
4225 return error; 4227 return error;
4226} 4228}
@@ -4895,6 +4897,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino)
4895 * not initialized on a new filesystem. */ 4897 * not initialized on a new filesystem. */
4896 } 4898 }
4897 ei->i_flags = le32_to_cpu(raw_inode->i_flags); 4899 ei->i_flags = le32_to_cpu(raw_inode->i_flags);
4900 ext4_set_inode_flags(inode);
4898 inode->i_blocks = ext4_inode_blocks(raw_inode, ei); 4901 inode->i_blocks = ext4_inode_blocks(raw_inode, ei);
4899 ei->i_file_acl = le32_to_cpu(raw_inode->i_file_acl_lo); 4902 ei->i_file_acl = le32_to_cpu(raw_inode->i_file_acl_lo);
4900 if (ext4_has_feature_64bit(sb)) 4903 if (ext4_has_feature_64bit(sb))
@@ -5041,7 +5044,6 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino)
5041 goto bad_inode; 5044 goto bad_inode;
5042 } 5045 }
5043 brelse(iloc.bh); 5046 brelse(iloc.bh);
5044 ext4_set_inode_flags(inode);
5045 5047
5046 unlock_new_inode(inode); 5048 unlock_new_inode(inode);
5047 return inode; 5049 return inode;
diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 39b07c2d3384..2305b4374fd3 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -49,7 +49,6 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
49 */ 49 */
50 sb_start_write(sb); 50 sb_start_write(sb);
51 ext4_mmp_csum_set(sb, mmp); 51 ext4_mmp_csum_set(sb, mmp);
52 mark_buffer_dirty(bh);
53 lock_buffer(bh); 52 lock_buffer(bh);
54 bh->b_end_io = end_buffer_write_sync; 53 bh->b_end_io = end_buffer_write_sync;
55 get_bh(bh); 54 get_bh(bh);
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 116ff68c5bd4..377d516c475f 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -3478,6 +3478,12 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,
3478 int credits; 3478 int credits;
3479 u8 old_file_type; 3479 u8 old_file_type;
3480 3480
3481 if (new.inode && new.inode->i_nlink == 0) {
3482 EXT4_ERROR_INODE(new.inode,
3483 "target of rename is already freed");
3484 return -EFSCORRUPTED;
3485 }
3486
3481 if ((ext4_test_inode_flag(new_dir, EXT4_INODE_PROJINHERIT)) && 3487 if ((ext4_test_inode_flag(new_dir, EXT4_INODE_PROJINHERIT)) &&
3482 (!projid_eq(EXT4_I(new_dir)->i_projid, 3488 (!projid_eq(EXT4_I(new_dir)->i_projid,
3483 EXT4_I(old_dentry->d_inode)->i_projid))) 3489 EXT4_I(old_dentry->d_inode)->i_projid)))
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index e5fb38451a73..ebbc663d0798 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -19,6 +19,7 @@
19 19
20int ext4_resize_begin(struct super_block *sb) 20int ext4_resize_begin(struct super_block *sb)
21{ 21{
22 struct ext4_sb_info *sbi = EXT4_SB(sb);
22 int ret = 0; 23 int ret = 0;
23 24
24 if (!capable(CAP_SYS_RESOURCE)) 25 if (!capable(CAP_SYS_RESOURCE))
@@ -29,7 +30,7 @@ int ext4_resize_begin(struct super_block *sb)
29 * because the user tools have no way of handling this. Probably a 30 * because the user tools have no way of handling this. Probably a
30 * bad time to do it anyways. 31 * bad time to do it anyways.
31 */ 32 */
32 if (EXT4_SB(sb)->s_sbh->b_blocknr != 33 if (EXT4_B2C(sbi, sbi->s_sbh->b_blocknr) !=
33 le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) { 34 le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) {
34 ext4_warning(sb, "won't resize using backup superblock at %llu", 35 ext4_warning(sb, "won't resize using backup superblock at %llu",
35 (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr); 36 (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr);
@@ -1986,6 +1987,26 @@ retry:
1986 } 1987 }
1987 } 1988 }
1988 1989
1990 /*
1991 * Make sure the last group has enough space so that it's
1992 * guaranteed to have enough space for all metadata blocks
1993 * that it might need to hold. (We might not need to store
1994 * the inode table blocks in the last block group, but there
1995 * will be cases where this might be needed.)
1996 */
1997 if ((ext4_group_first_block_no(sb, n_group) +
1998 ext4_group_overhead_blocks(sb, n_group) + 2 +
1999 sbi->s_itb_per_group + sbi->s_cluster_ratio) >= n_blocks_count) {
2000 n_blocks_count = ext4_group_first_block_no(sb, n_group);
2001 n_group--;
2002 n_blocks_count_retry = 0;
2003 if (resize_inode) {
2004 iput(resize_inode);
2005 resize_inode = NULL;
2006 }
2007 goto retry;
2008 }
2009
1989 /* extend the last group */ 2010 /* extend the last group */
1990 if (n_group == o_group) 2011 if (n_group == o_group)
1991 add = n_blocks_count - o_blocks_count; 2012 add = n_blocks_count - o_blocks_count;
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 5863fd22e90b..1145109968ef 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2145,6 +2145,8 @@ static int _ext4_show_options(struct seq_file *seq, struct super_block *sb,
2145 SEQ_OPTS_PRINT("max_dir_size_kb=%u", sbi->s_max_dir_size_kb); 2145 SEQ_OPTS_PRINT("max_dir_size_kb=%u", sbi->s_max_dir_size_kb);
2146 if (test_opt(sb, DATA_ERR_ABORT)) 2146 if (test_opt(sb, DATA_ERR_ABORT))
2147 SEQ_OPTS_PUTS("data_err=abort"); 2147 SEQ_OPTS_PUTS("data_err=abort");
2148 if (DUMMY_ENCRYPTION_ENABLED(sbi))
2149 SEQ_OPTS_PUTS("test_dummy_encryption");
2148 2150
2149 ext4_show_quota_options(seq, sb); 2151 ext4_show_quota_options(seq, sb);
2150 return 0; 2152 return 0;
@@ -4378,11 +4380,13 @@ no_journal:
4378 block = ext4_count_free_clusters(sb); 4380 block = ext4_count_free_clusters(sb);
4379 ext4_free_blocks_count_set(sbi->s_es, 4381 ext4_free_blocks_count_set(sbi->s_es,
4380 EXT4_C2B(sbi, block)); 4382 EXT4_C2B(sbi, block));
4383 ext4_superblock_csum_set(sb);
4381 err = percpu_counter_init(&sbi->s_freeclusters_counter, block, 4384 err = percpu_counter_init(&sbi->s_freeclusters_counter, block,
4382 GFP_KERNEL); 4385 GFP_KERNEL);
4383 if (!err) { 4386 if (!err) {
4384 unsigned long freei = ext4_count_free_inodes(sb); 4387 unsigned long freei = ext4_count_free_inodes(sb);
4385 sbi->s_es->s_free_inodes_count = cpu_to_le32(freei); 4388 sbi->s_es->s_free_inodes_count = cpu_to_le32(freei);
4389 ext4_superblock_csum_set(sb);
4386 err = percpu_counter_init(&sbi->s_freeinodes_counter, freei, 4390 err = percpu_counter_init(&sbi->s_freeinodes_counter, freei,
4387 GFP_KERNEL); 4391 GFP_KERNEL);
4388 } 4392 }
diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
index defc2168de91..f58c0cacc531 100644
--- a/fs/fat/fatent.c
+++ b/fs/fat/fatent.c
@@ -682,6 +682,7 @@ int fat_count_free_clusters(struct super_block *sb)
682 if (ops->ent_get(&fatent) == FAT_ENT_FREE) 682 if (ops->ent_get(&fatent) == FAT_ENT_FREE)
683 free++; 683 free++;
684 } while (fat_ent_next(sbi, &fatent)); 684 } while (fat_ent_next(sbi, &fatent));
685 cond_resched();
685 } 686 }
686 sbi->free_clusters = free; 687 sbi->free_clusters = free;
687 sbi->free_clus_valid = 1; 688 sbi->free_clus_valid = 1;
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index 03128ed1f34e..84544a4f012d 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -1057,7 +1057,7 @@ static int gfs2_iomap_begin_write(struct inode *inode, loff_t pos,
1057 } 1057 }
1058 } 1058 }
1059 release_metapath(&mp); 1059 release_metapath(&mp);
1060 if (gfs2_is_jdata(ip)) 1060 if (!gfs2_is_stuffed(ip) && gfs2_is_jdata(ip))
1061 iomap->page_done = gfs2_iomap_journaled_page_done; 1061 iomap->page_done = gfs2_iomap_journaled_page_done;
1062 return 0; 1062 return 0;
1063 1063
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 3212c29235ce..2005529af560 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -230,7 +230,7 @@ static long ioctl_file_clone(struct file *dst_file, unsigned long srcfd,
230 ret = -EXDEV; 230 ret = -EXDEV;
231 if (src_file.file->f_path.mnt != dst_file->f_path.mnt) 231 if (src_file.file->f_path.mnt != dst_file->f_path.mnt)
232 goto fdput; 232 goto fdput;
233 ret = do_clone_file_range(src_file.file, off, dst_file, destoff, olen); 233 ret = vfs_clone_file_range(src_file.file, off, dst_file, destoff, olen);
234fdput: 234fdput:
235 fdput(src_file); 235 fdput(src_file);
236 return ret; 236 return ret;
diff --git a/fs/iomap.c b/fs/iomap.c
index 74762b1ec233..ec15cf2ec696 100644
--- a/fs/iomap.c
+++ b/fs/iomap.c
@@ -1051,6 +1051,7 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length,
1051 } else { 1051 } else {
1052 WARN_ON_ONCE(!PageUptodate(page)); 1052 WARN_ON_ONCE(!PageUptodate(page));
1053 iomap_page_create(inode, page); 1053 iomap_page_create(inode, page);
1054 set_page_dirty(page);
1054 } 1055 }
1055 1056
1056 return length; 1057 return length;
@@ -1090,7 +1091,6 @@ int iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops)
1090 length -= ret; 1091 length -= ret;
1091 } 1092 }
1092 1093
1093 set_page_dirty(page);
1094 wait_for_stable_page(page); 1094 wait_for_stable_page(page);
1095 return VM_FAULT_LOCKED; 1095 return VM_FAULT_LOCKED;
1096out_unlock: 1096out_unlock:
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 34830f6457ea..8220a168282e 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1637,6 +1637,14 @@ static void nfs_state_set_delegation(struct nfs4_state *state,
1637 write_sequnlock(&state->seqlock); 1637 write_sequnlock(&state->seqlock);
1638} 1638}
1639 1639
1640static void nfs_state_clear_delegation(struct nfs4_state *state)
1641{
1642 write_seqlock(&state->seqlock);
1643 nfs4_stateid_copy(&state->stateid, &state->open_stateid);
1644 clear_bit(NFS_DELEGATED_STATE, &state->flags);
1645 write_sequnlock(&state->seqlock);
1646}
1647
1640static int update_open_stateid(struct nfs4_state *state, 1648static int update_open_stateid(struct nfs4_state *state,
1641 const nfs4_stateid *open_stateid, 1649 const nfs4_stateid *open_stateid,
1642 const nfs4_stateid *delegation, 1650 const nfs4_stateid *delegation,
@@ -2145,10 +2153,7 @@ int nfs4_open_delegation_recall(struct nfs_open_context *ctx,
2145 if (IS_ERR(opendata)) 2153 if (IS_ERR(opendata))
2146 return PTR_ERR(opendata); 2154 return PTR_ERR(opendata);
2147 nfs4_stateid_copy(&opendata->o_arg.u.delegation, stateid); 2155 nfs4_stateid_copy(&opendata->o_arg.u.delegation, stateid);
2148 write_seqlock(&state->seqlock); 2156 nfs_state_clear_delegation(state);
2149 nfs4_stateid_copy(&state->stateid, &state->open_stateid);
2150 write_sequnlock(&state->seqlock);
2151 clear_bit(NFS_DELEGATED_STATE, &state->flags);
2152 switch (type & (FMODE_READ|FMODE_WRITE)) { 2157 switch (type & (FMODE_READ|FMODE_WRITE)) {
2153 case FMODE_READ|FMODE_WRITE: 2158 case FMODE_READ|FMODE_WRITE:
2154 case FMODE_WRITE: 2159 case FMODE_WRITE:
@@ -2601,10 +2606,7 @@ static void nfs_finish_clear_delegation_stateid(struct nfs4_state *state,
2601 const nfs4_stateid *stateid) 2606 const nfs4_stateid *stateid)
2602{ 2607{
2603 nfs_remove_bad_delegation(state->inode, stateid); 2608 nfs_remove_bad_delegation(state->inode, stateid);
2604 write_seqlock(&state->seqlock); 2609 nfs_state_clear_delegation(state);
2605 nfs4_stateid_copy(&state->stateid, &state->open_stateid);
2606 write_sequnlock(&state->seqlock);
2607 clear_bit(NFS_DELEGATED_STATE, &state->flags);
2608} 2610}
2609 2611
2610static void nfs40_clear_delegation_stateid(struct nfs4_state *state) 2612static void nfs40_clear_delegation_stateid(struct nfs4_state *state)
@@ -2672,15 +2674,20 @@ static void nfs41_check_delegation_stateid(struct nfs4_state *state)
2672 delegation = rcu_dereference(NFS_I(state->inode)->delegation); 2674 delegation = rcu_dereference(NFS_I(state->inode)->delegation);
2673 if (delegation == NULL) { 2675 if (delegation == NULL) {
2674 rcu_read_unlock(); 2676 rcu_read_unlock();
2677 nfs_state_clear_delegation(state);
2675 return; 2678 return;
2676 } 2679 }
2677 2680
2678 nfs4_stateid_copy(&stateid, &delegation->stateid); 2681 nfs4_stateid_copy(&stateid, &delegation->stateid);
2679 if (test_bit(NFS_DELEGATION_REVOKED, &delegation->flags) || 2682 if (test_bit(NFS_DELEGATION_REVOKED, &delegation->flags)) {
2680 !test_and_clear_bit(NFS_DELEGATION_TEST_EXPIRED, 2683 rcu_read_unlock();
2681 &delegation->flags)) { 2684 nfs_state_clear_delegation(state);
2685 return;
2686 }
2687
2688 if (!test_and_clear_bit(NFS_DELEGATION_TEST_EXPIRED,
2689 &delegation->flags)) {
2682 rcu_read_unlock(); 2690 rcu_read_unlock();
2683 nfs_finish_clear_delegation_stateid(state, &stateid);
2684 return; 2691 return;
2685 } 2692 }
2686 2693
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 3df0eb52da1c..40a08cd483f0 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -1390,6 +1390,8 @@ int nfs4_schedule_stateid_recovery(const struct nfs_server *server, struct nfs4_
1390 1390
1391 if (!nfs4_state_mark_reclaim_nograce(clp, state)) 1391 if (!nfs4_state_mark_reclaim_nograce(clp, state))
1392 return -EBADF; 1392 return -EBADF;
1393 nfs_inode_find_delegation_state_and_recover(state->inode,
1394 &state->stateid);
1393 dprintk("%s: scheduling stateid recovery for server %s\n", __func__, 1395 dprintk("%s: scheduling stateid recovery for server %s\n", __func__,
1394 clp->cl_hostname); 1396 clp->cl_hostname);
1395 nfs4_schedule_state_manager(clp); 1397 nfs4_schedule_state_manager(clp);
diff --git a/fs/nfs/nfs4trace.h b/fs/nfs/nfs4trace.h
index a275fba93170..b1483b303e0b 100644
--- a/fs/nfs/nfs4trace.h
+++ b/fs/nfs/nfs4trace.h
@@ -1137,7 +1137,7 @@ DECLARE_EVENT_CLASS(nfs4_inode_callback_event,
1137 TP_fast_assign( 1137 TP_fast_assign(
1138 __entry->error = error; 1138 __entry->error = error;
1139 __entry->fhandle = nfs_fhandle_hash(fhandle); 1139 __entry->fhandle = nfs_fhandle_hash(fhandle);
1140 if (inode != NULL) { 1140 if (!IS_ERR_OR_NULL(inode)) {
1141 __entry->fileid = NFS_FILEID(inode); 1141 __entry->fileid = NFS_FILEID(inode);
1142 __entry->dev = inode->i_sb->s_dev; 1142 __entry->dev = inode->i_sb->s_dev;
1143 } else { 1143 } else {
@@ -1194,7 +1194,7 @@ DECLARE_EVENT_CLASS(nfs4_inode_stateid_callback_event,
1194 TP_fast_assign( 1194 TP_fast_assign(
1195 __entry->error = error; 1195 __entry->error = error;
1196 __entry->fhandle = nfs_fhandle_hash(fhandle); 1196 __entry->fhandle = nfs_fhandle_hash(fhandle);
1197 if (inode != NULL) { 1197 if (!IS_ERR_OR_NULL(inode)) {
1198 __entry->fileid = NFS_FILEID(inode); 1198 __entry->fileid = NFS_FILEID(inode);
1199 __entry->dev = inode->i_sb->s_dev; 1199 __entry->dev = inode->i_sb->s_dev;
1200 } else { 1200 } else {
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index e8f232de484f..7d9a51e6b847 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1740,16 +1740,16 @@ static bool pnfs_within_mdsthreshold(struct nfs_open_context *ctx,
1740 return ret; 1740 return ret;
1741} 1741}
1742 1742
1743static bool pnfs_prepare_to_retry_layoutget(struct pnfs_layout_hdr *lo) 1743static int pnfs_prepare_to_retry_layoutget(struct pnfs_layout_hdr *lo)
1744{ 1744{
1745 /* 1745 /*
1746 * send layoutcommit as it can hold up layoutreturn due to lseg 1746 * send layoutcommit as it can hold up layoutreturn due to lseg
1747 * reference 1747 * reference
1748 */ 1748 */
1749 pnfs_layoutcommit_inode(lo->plh_inode, false); 1749 pnfs_layoutcommit_inode(lo->plh_inode, false);
1750 return !wait_on_bit_action(&lo->plh_flags, NFS_LAYOUT_RETURN, 1750 return wait_on_bit_action(&lo->plh_flags, NFS_LAYOUT_RETURN,
1751 nfs_wait_bit_killable, 1751 nfs_wait_bit_killable,
1752 TASK_UNINTERRUPTIBLE); 1752 TASK_KILLABLE);
1753} 1753}
1754 1754
1755static void nfs_layoutget_begin(struct pnfs_layout_hdr *lo) 1755static void nfs_layoutget_begin(struct pnfs_layout_hdr *lo)
@@ -1830,7 +1830,9 @@ pnfs_update_layout(struct inode *ino,
1830 } 1830 }
1831 1831
1832lookup_again: 1832lookup_again:
1833 nfs4_client_recover_expired_lease(clp); 1833 lseg = ERR_PTR(nfs4_client_recover_expired_lease(clp));
1834 if (IS_ERR(lseg))
1835 goto out;
1834 first = false; 1836 first = false;
1835 spin_lock(&ino->i_lock); 1837 spin_lock(&ino->i_lock);
1836 lo = pnfs_find_alloc_layout(ino, ctx, gfp_flags); 1838 lo = pnfs_find_alloc_layout(ino, ctx, gfp_flags);
@@ -1863,9 +1865,9 @@ lookup_again:
1863 if (list_empty(&lo->plh_segs) && 1865 if (list_empty(&lo->plh_segs) &&
1864 atomic_read(&lo->plh_outstanding) != 0) { 1866 atomic_read(&lo->plh_outstanding) != 0) {
1865 spin_unlock(&ino->i_lock); 1867 spin_unlock(&ino->i_lock);
1866 if (wait_var_event_killable(&lo->plh_outstanding, 1868 lseg = ERR_PTR(wait_var_event_killable(&lo->plh_outstanding,
1867 atomic_read(&lo->plh_outstanding) == 0 1869 atomic_read(&lo->plh_outstanding)));
1868 || !list_empty(&lo->plh_segs))) 1870 if (IS_ERR(lseg) || !list_empty(&lo->plh_segs))
1869 goto out_put_layout_hdr; 1871 goto out_put_layout_hdr;
1870 pnfs_put_layout_hdr(lo); 1872 pnfs_put_layout_hdr(lo);
1871 goto lookup_again; 1873 goto lookup_again;
@@ -1898,8 +1900,11 @@ lookup_again:
1898 if (test_and_set_bit(NFS_LAYOUT_FIRST_LAYOUTGET, 1900 if (test_and_set_bit(NFS_LAYOUT_FIRST_LAYOUTGET,
1899 &lo->plh_flags)) { 1901 &lo->plh_flags)) {
1900 spin_unlock(&ino->i_lock); 1902 spin_unlock(&ino->i_lock);
1901 wait_on_bit(&lo->plh_flags, NFS_LAYOUT_FIRST_LAYOUTGET, 1903 lseg = ERR_PTR(wait_on_bit(&lo->plh_flags,
1902 TASK_UNINTERRUPTIBLE); 1904 NFS_LAYOUT_FIRST_LAYOUTGET,
1905 TASK_KILLABLE));
1906 if (IS_ERR(lseg))
1907 goto out_put_layout_hdr;
1903 pnfs_put_layout_hdr(lo); 1908 pnfs_put_layout_hdr(lo);
1904 dprintk("%s retrying\n", __func__); 1909 dprintk("%s retrying\n", __func__);
1905 goto lookup_again; 1910 goto lookup_again;
@@ -1925,7 +1930,8 @@ lookup_again:
1925 if (test_bit(NFS_LAYOUT_RETURN, &lo->plh_flags)) { 1930 if (test_bit(NFS_LAYOUT_RETURN, &lo->plh_flags)) {
1926 spin_unlock(&ino->i_lock); 1931 spin_unlock(&ino->i_lock);
1927 dprintk("%s wait for layoutreturn\n", __func__); 1932 dprintk("%s wait for layoutreturn\n", __func__);
1928 if (pnfs_prepare_to_retry_layoutget(lo)) { 1933 lseg = ERR_PTR(pnfs_prepare_to_retry_layoutget(lo));
1934 if (!IS_ERR(lseg)) {
1929 if (first) 1935 if (first)
1930 pnfs_clear_first_layoutget(lo); 1936 pnfs_clear_first_layoutget(lo);
1931 pnfs_put_layout_hdr(lo); 1937 pnfs_put_layout_hdr(lo);
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 55a099e47ba2..b53e76391e52 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -541,7 +541,8 @@ __be32 nfsd4_set_nfs4_label(struct svc_rqst *rqstp, struct svc_fh *fhp,
541__be32 nfsd4_clone_file_range(struct file *src, u64 src_pos, struct file *dst, 541__be32 nfsd4_clone_file_range(struct file *src, u64 src_pos, struct file *dst,
542 u64 dst_pos, u64 count) 542 u64 dst_pos, u64 count)
543{ 543{
544 return nfserrno(do_clone_file_range(src, src_pos, dst, dst_pos, count)); 544 return nfserrno(vfs_clone_file_range(src, src_pos, dst, dst_pos,
545 count));
545} 546}
546 547
547ssize_t nfsd_copy_file_range(struct file *src, u64 src_pos, struct file *dst, 548ssize_t nfsd_copy_file_range(struct file *src, u64 src_pos, struct file *dst,
diff --git a/fs/ocfs2/buffer_head_io.c b/fs/ocfs2/buffer_head_io.c
index d9ebe11c8990..1d098c3c00e0 100644
--- a/fs/ocfs2/buffer_head_io.c
+++ b/fs/ocfs2/buffer_head_io.c
@@ -342,6 +342,7 @@ int ocfs2_read_blocks(struct ocfs2_caching_info *ci, u64 block, int nr,
342 * for this bh as it's not marked locally 342 * for this bh as it's not marked locally
343 * uptodate. */ 343 * uptodate. */
344 status = -EIO; 344 status = -EIO;
345 clear_buffer_needs_validate(bh);
345 put_bh(bh); 346 put_bh(bh);
346 bhs[i] = NULL; 347 bhs[i] = NULL;
347 continue; 348 continue;
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index aaca0949fe53..826f0567ec43 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -584,9 +584,9 @@ static void dlm_init_lockres(struct dlm_ctxt *dlm,
584 584
585 res->last_used = 0; 585 res->last_used = 0;
586 586
587 spin_lock(&dlm->spinlock); 587 spin_lock(&dlm->track_lock);
588 list_add_tail(&res->tracking, &dlm->tracking_list); 588 list_add_tail(&res->tracking, &dlm->tracking_list);
589 spin_unlock(&dlm->spinlock); 589 spin_unlock(&dlm->track_lock);
590 590
591 memset(res->lvb, 0, DLM_LVB_LEN); 591 memset(res->lvb, 0, DLM_LVB_LEN);
592 memset(res->refmap, 0, sizeof(res->refmap)); 592 memset(res->refmap, 0, sizeof(res->refmap));
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 8e712b614e6e..933aac5da193 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -96,7 +96,9 @@ struct ocfs2_unblock_ctl {
96}; 96};
97 97
98/* Lockdep class keys */ 98/* Lockdep class keys */
99#ifdef CONFIG_DEBUG_LOCK_ALLOC
99static struct lock_class_key lockdep_keys[OCFS2_NUM_LOCK_TYPES]; 100static struct lock_class_key lockdep_keys[OCFS2_NUM_LOCK_TYPES];
101#endif
100 102
101static int ocfs2_check_meta_downconvert(struct ocfs2_lock_res *lockres, 103static int ocfs2_check_meta_downconvert(struct ocfs2_lock_res *lockres,
102 int new_level); 104 int new_level);
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
index 7869622af22a..7a5ee145c733 100644
--- a/fs/ocfs2/refcounttree.c
+++ b/fs/ocfs2/refcounttree.c
@@ -2946,6 +2946,7 @@ int ocfs2_duplicate_clusters_by_page(handle_t *handle,
2946 if (map_end & (PAGE_SIZE - 1)) 2946 if (map_end & (PAGE_SIZE - 1))
2947 to = map_end & (PAGE_SIZE - 1); 2947 to = map_end & (PAGE_SIZE - 1);
2948 2948
2949retry:
2949 page = find_or_create_page(mapping, page_index, GFP_NOFS); 2950 page = find_or_create_page(mapping, page_index, GFP_NOFS);
2950 if (!page) { 2951 if (!page) {
2951 ret = -ENOMEM; 2952 ret = -ENOMEM;
@@ -2954,11 +2955,18 @@ int ocfs2_duplicate_clusters_by_page(handle_t *handle,
2954 } 2955 }
2955 2956
2956 /* 2957 /*
2957 * In case PAGE_SIZE <= CLUSTER_SIZE, This page 2958 * In case PAGE_SIZE <= CLUSTER_SIZE, we do not expect a dirty
2958 * can't be dirtied before we CoW it out. 2959 * page, so write it back.
2959 */ 2960 */
2960 if (PAGE_SIZE <= OCFS2_SB(sb)->s_clustersize) 2961 if (PAGE_SIZE <= OCFS2_SB(sb)->s_clustersize) {
2961 BUG_ON(PageDirty(page)); 2962 if (PageDirty(page)) {
2963 /*
2964 * write_on_page will unlock the page on return
2965 */
2966 ret = write_one_page(page);
2967 goto retry;
2968 }
2969 }
2962 2970
2963 if (!PageUptodate(page)) { 2971 if (!PageUptodate(page)) {
2964 ret = block_read_full_page(page, ocfs2_get_block); 2972 ret = block_read_full_page(page, ocfs2_get_block);
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 296037afecdb..1cc797a08a5b 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -141,7 +141,7 @@ static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
141 } 141 }
142 142
143 /* Try to use clone_file_range to clone up within the same fs */ 143 /* Try to use clone_file_range to clone up within the same fs */
144 error = vfs_clone_file_range(old_file, 0, new_file, 0, len); 144 error = do_clone_file_range(old_file, 0, new_file, 0, len);
145 if (!error) 145 if (!error)
146 goto out; 146 goto out;
147 /* Couldn't clone, so now we try to copy the data */ 147 /* Couldn't clone, so now we try to copy the data */
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 32e9282893c9..986313da0c88 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -131,9 +131,6 @@ static int ovl_open(struct inode *inode, struct file *file)
131 if (IS_ERR(realfile)) 131 if (IS_ERR(realfile))
132 return PTR_ERR(realfile); 132 return PTR_ERR(realfile);
133 133
134 /* For O_DIRECT dentry_open() checks f_mapping->a_ops->direct_IO */
135 file->f_mapping = realfile->f_mapping;
136
137 file->private_data = realfile; 134 file->private_data = realfile;
138 135
139 return 0; 136 return 0;
@@ -243,8 +240,10 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
243 goto out_unlock; 240 goto out_unlock;
244 241
245 old_cred = ovl_override_creds(file_inode(file)->i_sb); 242 old_cred = ovl_override_creds(file_inode(file)->i_sb);
243 file_start_write(real.file);
246 ret = vfs_iter_write(real.file, iter, &iocb->ki_pos, 244 ret = vfs_iter_write(real.file, iter, &iocb->ki_pos,
247 ovl_iocb_to_rwf(iocb)); 245 ovl_iocb_to_rwf(iocb));
246 file_end_write(real.file);
248 revert_creds(old_cred); 247 revert_creds(old_cred);
249 248
250 /* Update size */ 249 /* Update size */
@@ -334,6 +333,25 @@ static long ovl_fallocate(struct file *file, int mode, loff_t offset, loff_t len
334 return ret; 333 return ret;
335} 334}
336 335
336static int ovl_fadvise(struct file *file, loff_t offset, loff_t len, int advice)
337{
338 struct fd real;
339 const struct cred *old_cred;
340 int ret;
341
342 ret = ovl_real_fdget(file, &real);
343 if (ret)
344 return ret;
345
346 old_cred = ovl_override_creds(file_inode(file)->i_sb);
347 ret = vfs_fadvise(real.file, offset, len, advice);
348 revert_creds(old_cred);
349
350 fdput(real);
351
352 return ret;
353}
354
337static long ovl_real_ioctl(struct file *file, unsigned int cmd, 355static long ovl_real_ioctl(struct file *file, unsigned int cmd,
338 unsigned long arg) 356 unsigned long arg)
339{ 357{
@@ -502,6 +520,7 @@ const struct file_operations ovl_file_operations = {
502 .fsync = ovl_fsync, 520 .fsync = ovl_fsync,
503 .mmap = ovl_mmap, 521 .mmap = ovl_mmap,
504 .fallocate = ovl_fallocate, 522 .fallocate = ovl_fallocate,
523 .fadvise = ovl_fadvise,
505 .unlocked_ioctl = ovl_ioctl, 524 .unlocked_ioctl = ovl_ioctl,
506 .compat_ioctl = ovl_compat_ioctl, 525 .compat_ioctl = ovl_compat_ioctl,
507 526
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index e0bb217c01e2..3b7ed5d2279c 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -467,6 +467,10 @@ static int ovl_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
467 return -EOPNOTSUPP; 467 return -EOPNOTSUPP;
468 468
469 old_cred = ovl_override_creds(inode->i_sb); 469 old_cred = ovl_override_creds(inode->i_sb);
470
471 if (fieinfo->fi_flags & FIEMAP_FLAG_SYNC)
472 filemap_write_and_wait(realinode->i_mapping);
473
470 err = realinode->i_op->fiemap(realinode, fieinfo, start, len); 474 err = realinode->i_op->fiemap(realinode, fieinfo, start, len);
471 revert_creds(old_cred); 475 revert_creds(old_cred);
472 476
@@ -500,6 +504,11 @@ static const struct inode_operations ovl_special_inode_operations = {
500 .update_time = ovl_update_time, 504 .update_time = ovl_update_time,
501}; 505};
502 506
507static const struct address_space_operations ovl_aops = {
508 /* For O_DIRECT dentry_open() checks f_mapping->a_ops->direct_IO */
509 .direct_IO = noop_direct_IO,
510};
511
503/* 512/*
504 * It is possible to stack overlayfs instance on top of another 513 * It is possible to stack overlayfs instance on top of another
505 * overlayfs instance as lower layer. We need to annonate the 514 * overlayfs instance as lower layer. We need to annonate the
@@ -571,6 +580,7 @@ static void ovl_fill_inode(struct inode *inode, umode_t mode, dev_t rdev,
571 case S_IFREG: 580 case S_IFREG:
572 inode->i_op = &ovl_file_inode_operations; 581 inode->i_op = &ovl_file_inode_operations;
573 inode->i_fop = &ovl_file_operations; 582 inode->i_fop = &ovl_file_operations;
583 inode->i_mapping->a_ops = &ovl_aops;
574 break; 584 break;
575 585
576 case S_IFDIR: 586 case S_IFDIR:
diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
index f28711846dd6..9c0ca6a7becf 100644
--- a/fs/overlayfs/namei.c
+++ b/fs/overlayfs/namei.c
@@ -686,7 +686,7 @@ struct dentry *ovl_lookup_index(struct ovl_fs *ofs, struct dentry *upper,
686 index = NULL; 686 index = NULL;
687 goto out; 687 goto out;
688 } 688 }
689 pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%*s, err=%i);\n" 689 pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%.*s, err=%i);\n"
690 "overlayfs: mount with '-o index=off' to disable inodes index.\n", 690 "overlayfs: mount with '-o index=off' to disable inodes index.\n",
691 d_inode(origin)->i_ino, name.len, name.name, 691 d_inode(origin)->i_ino, name.len, name.name,
692 err); 692 err);
diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h
index f61839e1054c..a3c0d9584312 100644
--- a/fs/overlayfs/overlayfs.h
+++ b/fs/overlayfs/overlayfs.h
@@ -152,8 +152,8 @@ static inline int ovl_do_setxattr(struct dentry *dentry, const char *name,
152 const void *value, size_t size, int flags) 152 const void *value, size_t size, int flags)
153{ 153{
154 int err = vfs_setxattr(dentry, name, value, size, flags); 154 int err = vfs_setxattr(dentry, name, value, size, flags);
155 pr_debug("setxattr(%pd2, \"%s\", \"%*s\", 0x%x) = %i\n", 155 pr_debug("setxattr(%pd2, \"%s\", \"%*pE\", %zu, 0x%x) = %i\n",
156 dentry, name, (int) size, (char *) value, flags, err); 156 dentry, name, min((int)size, 48), value, size, flags, err);
157 return err; 157 return err;
158} 158}
159 159
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 2e0fc93c2c06..30adc9d408a0 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -982,16 +982,6 @@ static int ovl_get_upper(struct ovl_fs *ofs, struct path *upperpath)
982 if (err) 982 if (err)
983 goto out; 983 goto out;
984 984
985 err = -EBUSY;
986 if (ovl_inuse_trylock(upperpath->dentry)) {
987 ofs->upperdir_locked = true;
988 } else if (ofs->config.index) {
989 pr_err("overlayfs: upperdir is in-use by another mount, mount with '-o index=off' to override exclusive upperdir protection.\n");
990 goto out;
991 } else {
992 pr_warn("overlayfs: upperdir is in-use by another mount, accessing files from both mounts will result in undefined behavior.\n");
993 }
994
995 upper_mnt = clone_private_mount(upperpath); 985 upper_mnt = clone_private_mount(upperpath);
996 err = PTR_ERR(upper_mnt); 986 err = PTR_ERR(upper_mnt);
997 if (IS_ERR(upper_mnt)) { 987 if (IS_ERR(upper_mnt)) {
@@ -1002,6 +992,17 @@ static int ovl_get_upper(struct ovl_fs *ofs, struct path *upperpath)
1002 /* Don't inherit atime flags */ 992 /* Don't inherit atime flags */
1003 upper_mnt->mnt_flags &= ~(MNT_NOATIME | MNT_NODIRATIME | MNT_RELATIME); 993 upper_mnt->mnt_flags &= ~(MNT_NOATIME | MNT_NODIRATIME | MNT_RELATIME);
1004 ofs->upper_mnt = upper_mnt; 994 ofs->upper_mnt = upper_mnt;
995
996 err = -EBUSY;
997 if (ovl_inuse_trylock(ofs->upper_mnt->mnt_root)) {
998 ofs->upperdir_locked = true;
999 } else if (ofs->config.index) {
1000 pr_err("overlayfs: upperdir is in-use by another mount, mount with '-o index=off' to override exclusive upperdir protection.\n");
1001 goto out;
1002 } else {
1003 pr_warn("overlayfs: upperdir is in-use by another mount, accessing files from both mounts will result in undefined behavior.\n");
1004 }
1005
1005 err = 0; 1006 err = 0;
1006out: 1007out:
1007 return err; 1008 return err;
@@ -1101,8 +1102,10 @@ static int ovl_get_workdir(struct ovl_fs *ofs, struct path *upperpath)
1101 goto out; 1102 goto out;
1102 } 1103 }
1103 1104
1105 ofs->workbasedir = dget(workpath.dentry);
1106
1104 err = -EBUSY; 1107 err = -EBUSY;
1105 if (ovl_inuse_trylock(workpath.dentry)) { 1108 if (ovl_inuse_trylock(ofs->workbasedir)) {
1106 ofs->workdir_locked = true; 1109 ofs->workdir_locked = true;
1107 } else if (ofs->config.index) { 1110 } else if (ofs->config.index) {
1108 pr_err("overlayfs: workdir is in-use by another mount, mount with '-o index=off' to override exclusive workdir protection.\n"); 1111 pr_err("overlayfs: workdir is in-use by another mount, mount with '-o index=off' to override exclusive workdir protection.\n");
@@ -1111,7 +1114,6 @@ static int ovl_get_workdir(struct ovl_fs *ofs, struct path *upperpath)
1111 pr_warn("overlayfs: workdir is in-use by another mount, accessing files from both mounts will result in undefined behavior.\n"); 1114 pr_warn("overlayfs: workdir is in-use by another mount, accessing files from both mounts will result in undefined behavior.\n");
1112 } 1115 }
1113 1116
1114 ofs->workbasedir = dget(workpath.dentry);
1115 err = ovl_make_workdir(ofs, &workpath); 1117 err = ovl_make_workdir(ofs, &workpath);
1116 if (err) 1118 if (err)
1117 goto out; 1119 goto out;
diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
index 8cfb62cc8672..ace4fe4c39a9 100644
--- a/fs/overlayfs/util.c
+++ b/fs/overlayfs/util.c
@@ -683,7 +683,7 @@ static void ovl_cleanup_index(struct dentry *dentry)
683 struct dentry *upperdentry = ovl_dentry_upper(dentry); 683 struct dentry *upperdentry = ovl_dentry_upper(dentry);
684 struct dentry *index = NULL; 684 struct dentry *index = NULL;
685 struct inode *inode; 685 struct inode *inode;
686 struct qstr name; 686 struct qstr name = { };
687 int err; 687 int err;
688 688
689 err = ovl_get_index_name(lowerdentry, &name); 689 err = ovl_get_index_name(lowerdentry, &name);
@@ -726,6 +726,7 @@ static void ovl_cleanup_index(struct dentry *dentry)
726 goto fail; 726 goto fail;
727 727
728out: 728out:
729 kfree(name.name);
729 dput(index); 730 dput(index);
730 return; 731 return;
731 732
diff --git a/fs/proc/base.c b/fs/proc/base.c
index ccf86f16d9f0..7e9f07bf260d 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -407,6 +407,20 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns,
407 unsigned long *entries; 407 unsigned long *entries;
408 int err; 408 int err;
409 409
410 /*
411 * The ability to racily run the kernel stack unwinder on a running task
412 * and then observe the unwinder output is scary; while it is useful for
413 * debugging kernel issues, it can also allow an attacker to leak kernel
414 * stack contents.
415 * Doing this in a manner that is at least safe from races would require
416 * some work to ensure that the remote task can not be scheduled; and
417 * even then, this would still expose the unwinder as local attack
418 * surface.
419 * Therefore, this interface is restricted to root.
420 */
421 if (!file_ns_capable(m->file, &init_user_ns, CAP_SYS_ADMIN))
422 return -EACCES;
423
410 entries = kmalloc_array(MAX_STACK_TRACE_DEPTH, sizeof(*entries), 424 entries = kmalloc_array(MAX_STACK_TRACE_DEPTH, sizeof(*entries),
411 GFP_KERNEL); 425 GFP_KERNEL);
412 if (!entries) 426 if (!entries)
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index ad72261ee3fe..d297fe4472a9 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -464,6 +464,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos)
464 ret = -EFAULT; 464 ret = -EFAULT;
465 goto out; 465 goto out;
466 } 466 }
467 m = NULL; /* skip the list anchor */
467 } else if (m->type == KCORE_VMALLOC) { 468 } else if (m->type == KCORE_VMALLOC) {
468 vread(buf, (char *)start, tsz); 469 vread(buf, (char *)start, tsz);
469 /* we have to zero-fill user buffer even if no read */ 470 /* we have to zero-fill user buffer even if no read */
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index bbd1e357c23d..f4fd2e72add4 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -898,8 +898,22 @@ static struct platform_driver ramoops_driver = {
898 }, 898 },
899}; 899};
900 900
901static void ramoops_register_dummy(void) 901static inline void ramoops_unregister_dummy(void)
902{ 902{
903 platform_device_unregister(dummy);
904 dummy = NULL;
905
906 kfree(dummy_data);
907 dummy_data = NULL;
908}
909
910static void __init ramoops_register_dummy(void)
911{
912 /*
913 * Prepare a dummy platform data structure to carry the module
914 * parameters. If mem_size isn't set, then there are no module
915 * parameters, and we can skip this.
916 */
903 if (!mem_size) 917 if (!mem_size)
904 return; 918 return;
905 919
@@ -932,21 +946,28 @@ static void ramoops_register_dummy(void)
932 if (IS_ERR(dummy)) { 946 if (IS_ERR(dummy)) {
933 pr_info("could not create platform device: %ld\n", 947 pr_info("could not create platform device: %ld\n",
934 PTR_ERR(dummy)); 948 PTR_ERR(dummy));
949 dummy = NULL;
950 ramoops_unregister_dummy();
935 } 951 }
936} 952}
937 953
938static int __init ramoops_init(void) 954static int __init ramoops_init(void)
939{ 955{
956 int ret;
957
940 ramoops_register_dummy(); 958 ramoops_register_dummy();
941 return platform_driver_register(&ramoops_driver); 959 ret = platform_driver_register(&ramoops_driver);
960 if (ret != 0)
961 ramoops_unregister_dummy();
962
963 return ret;
942} 964}
943late_initcall(ramoops_init); 965late_initcall(ramoops_init);
944 966
945static void __exit ramoops_exit(void) 967static void __exit ramoops_exit(void)
946{ 968{
947 platform_driver_unregister(&ramoops_driver); 969 platform_driver_unregister(&ramoops_driver);
948 platform_device_unregister(dummy); 970 ramoops_unregister_dummy();
949 kfree(dummy_data);
950} 971}
951module_exit(ramoops_exit); 972module_exit(ramoops_exit);
952 973
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 951a14edcf51..0792595ebcfb 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -429,7 +429,12 @@ static void *persistent_ram_vmap(phys_addr_t start, size_t size,
429 vaddr = vmap(pages, page_count, VM_MAP, prot); 429 vaddr = vmap(pages, page_count, VM_MAP, prot);
430 kfree(pages); 430 kfree(pages);
431 431
432 return vaddr; 432 /*
433 * Since vmap() uses page granularity, we must add the offset
434 * into the page here, to get the byte granularity address
435 * into the mapping to represent the actual "start" location.
436 */
437 return vaddr + offset_in_page(start);
433} 438}
434 439
435static void *persistent_ram_iomap(phys_addr_t start, size_t size, 440static void *persistent_ram_iomap(phys_addr_t start, size_t size,
@@ -448,6 +453,11 @@ static void *persistent_ram_iomap(phys_addr_t start, size_t size,
448 else 453 else
449 va = ioremap_wc(start, size); 454 va = ioremap_wc(start, size);
450 455
456 /*
457 * Since request_mem_region() and ioremap() are byte-granularity
458 * there is no need handle anything special like we do when the
459 * vmap() case in persistent_ram_vmap() above.
460 */
451 return va; 461 return va;
452} 462}
453 463
@@ -468,7 +478,7 @@ static int persistent_ram_buffer_map(phys_addr_t start, phys_addr_t size,
468 return -ENOMEM; 478 return -ENOMEM;
469 } 479 }
470 480
471 prz->buffer = prz->vaddr + offset_in_page(start); 481 prz->buffer = prz->vaddr;
472 prz->buffer_size = size - sizeof(struct persistent_ram_buffer); 482 prz->buffer_size = size - sizeof(struct persistent_ram_buffer);
473 483
474 return 0; 484 return 0;
@@ -515,7 +525,8 @@ void persistent_ram_free(struct persistent_ram_zone *prz)
515 525
516 if (prz->vaddr) { 526 if (prz->vaddr) {
517 if (pfn_valid(prz->paddr >> PAGE_SHIFT)) { 527 if (pfn_valid(prz->paddr >> PAGE_SHIFT)) {
518 vunmap(prz->vaddr); 528 /* We must vunmap() at page-granularity. */
529 vunmap(prz->vaddr - offset_in_page(prz->paddr));
519 } else { 530 } else {
520 iounmap(prz->vaddr); 531 iounmap(prz->vaddr);
521 release_mem_region(prz->paddr, prz->size); 532 release_mem_region(prz->paddr, prz->size);
diff --git a/fs/read_write.c b/fs/read_write.c
index 39b4a21dd933..8a2737f0d61d 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1818,8 +1818,8 @@ int vfs_clone_file_prep_inodes(struct inode *inode_in, loff_t pos_in,
1818} 1818}
1819EXPORT_SYMBOL(vfs_clone_file_prep_inodes); 1819EXPORT_SYMBOL(vfs_clone_file_prep_inodes);
1820 1820
1821int vfs_clone_file_range(struct file *file_in, loff_t pos_in, 1821int do_clone_file_range(struct file *file_in, loff_t pos_in,
1822 struct file *file_out, loff_t pos_out, u64 len) 1822 struct file *file_out, loff_t pos_out, u64 len)
1823{ 1823{
1824 struct inode *inode_in = file_inode(file_in); 1824 struct inode *inode_in = file_inode(file_in);
1825 struct inode *inode_out = file_inode(file_out); 1825 struct inode *inode_out = file_inode(file_out);
@@ -1866,6 +1866,19 @@ int vfs_clone_file_range(struct file *file_in, loff_t pos_in,
1866 1866
1867 return ret; 1867 return ret;
1868} 1868}
1869EXPORT_SYMBOL(do_clone_file_range);
1870
1871int vfs_clone_file_range(struct file *file_in, loff_t pos_in,
1872 struct file *file_out, loff_t pos_out, u64 len)
1873{
1874 int ret;
1875
1876 file_start_write(file_out);
1877 ret = do_clone_file_range(file_in, pos_in, file_out, pos_out, len);
1878 file_end_write(file_out);
1879
1880 return ret;
1881}
1869EXPORT_SYMBOL(vfs_clone_file_range); 1882EXPORT_SYMBOL(vfs_clone_file_range);
1870 1883
1871/* 1884/*
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 23e7042666a7..fec62e9dfbe6 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1912,7 +1912,9 @@ static int ubifs_remount_fs(struct super_block *sb, int *flags, char *data)
1912 mutex_unlock(&c->bu_mutex); 1912 mutex_unlock(&c->bu_mutex);
1913 } 1913 }
1914 1914
1915 ubifs_assert(c, c->lst.taken_empty_lebs > 0); 1915 if (!c->need_recovery)
1916 ubifs_assert(c, c->lst.taken_empty_lebs > 0);
1917
1916 return 0; 1918 return 0;
1917} 1919}
1918 1920
@@ -1954,6 +1956,9 @@ static struct ubi_volume_desc *open_ubi(const char *name, int mode)
1954 int dev, vol; 1956 int dev, vol;
1955 char *endptr; 1957 char *endptr;
1956 1958
1959 if (!name || !*name)
1960 return ERR_PTR(-EINVAL);
1961
1957 /* First, try to open using the device node path method */ 1962 /* First, try to open using the device node path method */
1958 ubi = ubi_open_volume_path(name, mode); 1963 ubi = ubi_open_volume_path(name, mode);
1959 if (!IS_ERR(ubi)) 1964 if (!IS_ERR(ubi))
@@ -2332,8 +2337,8 @@ late_initcall(ubifs_init);
2332 2337
2333static void __exit ubifs_exit(void) 2338static void __exit ubifs_exit(void)
2334{ 2339{
2335 WARN_ON(list_empty(&ubifs_infos)); 2340 WARN_ON(!list_empty(&ubifs_infos));
2336 WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0); 2341 WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) != 0);
2337 2342
2338 dbg_debugfs_exit(); 2343 dbg_debugfs_exit();
2339 ubifs_compressors_exit(); 2344 ubifs_compressors_exit();
diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
index 61afdfee4b28..f5ad1ede7990 100644
--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -152,12 +152,6 @@ static int create_xattr(struct ubifs_info *c, struct inode *host,
152 ui->data_len = size; 152 ui->data_len = size;
153 153
154 mutex_lock(&host_ui->ui_mutex); 154 mutex_lock(&host_ui->ui_mutex);
155
156 if (!host->i_nlink) {
157 err = -ENOENT;
158 goto out_noent;
159 }
160
161 host->i_ctime = current_time(host); 155 host->i_ctime = current_time(host);
162 host_ui->xattr_cnt += 1; 156 host_ui->xattr_cnt += 1;
163 host_ui->xattr_size += CALC_DENT_SIZE(fname_len(nm)); 157 host_ui->xattr_size += CALC_DENT_SIZE(fname_len(nm));
@@ -190,7 +184,6 @@ out_cancel:
190 host_ui->xattr_size -= CALC_XATTR_BYTES(size); 184 host_ui->xattr_size -= CALC_XATTR_BYTES(size);
191 host_ui->xattr_names -= fname_len(nm); 185 host_ui->xattr_names -= fname_len(nm);
192 host_ui->flags &= ~UBIFS_CRYPT_FL; 186 host_ui->flags &= ~UBIFS_CRYPT_FL;
193out_noent:
194 mutex_unlock(&host_ui->ui_mutex); 187 mutex_unlock(&host_ui->ui_mutex);
195out_free: 188out_free:
196 make_bad_inode(inode); 189 make_bad_inode(inode);
@@ -242,12 +235,6 @@ static int change_xattr(struct ubifs_info *c, struct inode *host,
242 mutex_unlock(&ui->ui_mutex); 235 mutex_unlock(&ui->ui_mutex);
243 236
244 mutex_lock(&host_ui->ui_mutex); 237 mutex_lock(&host_ui->ui_mutex);
245
246 if (!host->i_nlink) {
247 err = -ENOENT;
248 goto out_noent;
249 }
250
251 host->i_ctime = current_time(host); 238 host->i_ctime = current_time(host);
252 host_ui->xattr_size -= CALC_XATTR_BYTES(old_size); 239 host_ui->xattr_size -= CALC_XATTR_BYTES(old_size);
253 host_ui->xattr_size += CALC_XATTR_BYTES(size); 240 host_ui->xattr_size += CALC_XATTR_BYTES(size);
@@ -269,7 +256,6 @@ static int change_xattr(struct ubifs_info *c, struct inode *host,
269out_cancel: 256out_cancel:
270 host_ui->xattr_size -= CALC_XATTR_BYTES(size); 257 host_ui->xattr_size -= CALC_XATTR_BYTES(size);
271 host_ui->xattr_size += CALC_XATTR_BYTES(old_size); 258 host_ui->xattr_size += CALC_XATTR_BYTES(old_size);
272out_noent:
273 mutex_unlock(&host_ui->ui_mutex); 259 mutex_unlock(&host_ui->ui_mutex);
274 make_bad_inode(inode); 260 make_bad_inode(inode);
275out_free: 261out_free:
@@ -496,12 +482,6 @@ static int remove_xattr(struct ubifs_info *c, struct inode *host,
496 return err; 482 return err;
497 483
498 mutex_lock(&host_ui->ui_mutex); 484 mutex_lock(&host_ui->ui_mutex);
499
500 if (!host->i_nlink) {
501 err = -ENOENT;
502 goto out_noent;
503 }
504
505 host->i_ctime = current_time(host); 485 host->i_ctime = current_time(host);
506 host_ui->xattr_cnt -= 1; 486 host_ui->xattr_cnt -= 1;
507 host_ui->xattr_size -= CALC_DENT_SIZE(fname_len(nm)); 487 host_ui->xattr_size -= CALC_DENT_SIZE(fname_len(nm));
@@ -521,7 +501,6 @@ out_cancel:
521 host_ui->xattr_size += CALC_DENT_SIZE(fname_len(nm)); 501 host_ui->xattr_size += CALC_DENT_SIZE(fname_len(nm));
522 host_ui->xattr_size += CALC_XATTR_BYTES(ui->data_len); 502 host_ui->xattr_size += CALC_XATTR_BYTES(ui->data_len);
523 host_ui->xattr_names += fname_len(nm); 503 host_ui->xattr_names += fname_len(nm);
524out_noent:
525 mutex_unlock(&host_ui->ui_mutex); 504 mutex_unlock(&host_ui->ui_mutex);
526 ubifs_release_budget(c, &req); 505 ubifs_release_budget(c, &req);
527 make_bad_inode(inode); 506 make_bad_inode(inode);
@@ -561,9 +540,6 @@ static int ubifs_xattr_remove(struct inode *host, const char *name)
561 540
562 ubifs_assert(c, inode_is_locked(host)); 541 ubifs_assert(c, inode_is_locked(host));
563 542
564 if (!host->i_nlink)
565 return -ENOENT;
566
567 if (fname_len(&nm) > UBIFS_MAX_NLEN) 543 if (fname_len(&nm) > UBIFS_MAX_NLEN)
568 return -ENAMETOOLONG; 544 return -ENAMETOOLONG;
569 545
diff --git a/fs/xattr.c b/fs/xattr.c
index daa732550088..0d6a6a4af861 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -948,17 +948,19 @@ ssize_t simple_xattr_list(struct inode *inode, struct simple_xattrs *xattrs,
948 int err = 0; 948 int err = 0;
949 949
950#ifdef CONFIG_FS_POSIX_ACL 950#ifdef CONFIG_FS_POSIX_ACL
951 if (inode->i_acl) { 951 if (IS_POSIXACL(inode)) {
952 err = xattr_list_one(&buffer, &remaining_size, 952 if (inode->i_acl) {
953 XATTR_NAME_POSIX_ACL_ACCESS); 953 err = xattr_list_one(&buffer, &remaining_size,
954 if (err) 954 XATTR_NAME_POSIX_ACL_ACCESS);
955 return err; 955 if (err)
956 } 956 return err;
957 if (inode->i_default_acl) { 957 }
958 err = xattr_list_one(&buffer, &remaining_size, 958 if (inode->i_default_acl) {
959 XATTR_NAME_POSIX_ACL_DEFAULT); 959 err = xattr_list_one(&buffer, &remaining_size,
960 if (err) 960 XATTR_NAME_POSIX_ACL_DEFAULT);
961 return err; 961 if (err)
962 return err;
963 }
962 } 964 }
963#endif 965#endif
964 966
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index 1e671d4eb6fa..c6299f82a6e4 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -587,7 +587,7 @@ xfs_attr_leaf_addname(
587 */ 587 */
588 error = xfs_attr3_leaf_to_node(args); 588 error = xfs_attr3_leaf_to_node(args);
589 if (error) 589 if (error)
590 goto out_defer_cancel; 590 return error;
591 error = xfs_defer_finish(&args->trans); 591 error = xfs_defer_finish(&args->trans);
592 if (error) 592 if (error)
593 return error; 593 return error;
@@ -675,7 +675,7 @@ xfs_attr_leaf_addname(
675 error = xfs_attr3_leaf_to_shortform(bp, args, forkoff); 675 error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
676 /* bp is gone due to xfs_da_shrink_inode */ 676 /* bp is gone due to xfs_da_shrink_inode */
677 if (error) 677 if (error)
678 goto out_defer_cancel; 678 return error;
679 error = xfs_defer_finish(&args->trans); 679 error = xfs_defer_finish(&args->trans);
680 if (error) 680 if (error)
681 return error; 681 return error;
@@ -693,9 +693,6 @@ xfs_attr_leaf_addname(
693 error = xfs_attr3_leaf_clearflag(args); 693 error = xfs_attr3_leaf_clearflag(args);
694 } 694 }
695 return error; 695 return error;
696out_defer_cancel:
697 xfs_defer_cancel(args->trans);
698 return error;
699} 696}
700 697
701/* 698/*
@@ -738,15 +735,12 @@ xfs_attr_leaf_removename(
738 error = xfs_attr3_leaf_to_shortform(bp, args, forkoff); 735 error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
739 /* bp is gone due to xfs_da_shrink_inode */ 736 /* bp is gone due to xfs_da_shrink_inode */
740 if (error) 737 if (error)
741 goto out_defer_cancel; 738 return error;
742 error = xfs_defer_finish(&args->trans); 739 error = xfs_defer_finish(&args->trans);
743 if (error) 740 if (error)
744 return error; 741 return error;
745 } 742 }
746 return 0; 743 return 0;
747out_defer_cancel:
748 xfs_defer_cancel(args->trans);
749 return error;
750} 744}
751 745
752/* 746/*
@@ -864,7 +858,7 @@ restart:
864 state = NULL; 858 state = NULL;
865 error = xfs_attr3_leaf_to_node(args); 859 error = xfs_attr3_leaf_to_node(args);
866 if (error) 860 if (error)
867 goto out_defer_cancel; 861 goto out;
868 error = xfs_defer_finish(&args->trans); 862 error = xfs_defer_finish(&args->trans);
869 if (error) 863 if (error)
870 goto out; 864 goto out;
@@ -888,7 +882,7 @@ restart:
888 */ 882 */
889 error = xfs_da3_split(state); 883 error = xfs_da3_split(state);
890 if (error) 884 if (error)
891 goto out_defer_cancel; 885 goto out;
892 error = xfs_defer_finish(&args->trans); 886 error = xfs_defer_finish(&args->trans);
893 if (error) 887 if (error)
894 goto out; 888 goto out;
@@ -984,7 +978,7 @@ restart:
984 if (retval && (state->path.active > 1)) { 978 if (retval && (state->path.active > 1)) {
985 error = xfs_da3_join(state); 979 error = xfs_da3_join(state);
986 if (error) 980 if (error)
987 goto out_defer_cancel; 981 goto out;
988 error = xfs_defer_finish(&args->trans); 982 error = xfs_defer_finish(&args->trans);
989 if (error) 983 if (error)
990 goto out; 984 goto out;
@@ -1013,9 +1007,6 @@ out:
1013 if (error) 1007 if (error)
1014 return error; 1008 return error;
1015 return retval; 1009 return retval;
1016out_defer_cancel:
1017 xfs_defer_cancel(args->trans);
1018 goto out;
1019} 1010}
1020 1011
1021/* 1012/*
@@ -1107,7 +1098,7 @@ xfs_attr_node_removename(
1107 if (retval && (state->path.active > 1)) { 1098 if (retval && (state->path.active > 1)) {
1108 error = xfs_da3_join(state); 1099 error = xfs_da3_join(state);
1109 if (error) 1100 if (error)
1110 goto out_defer_cancel; 1101 goto out;
1111 error = xfs_defer_finish(&args->trans); 1102 error = xfs_defer_finish(&args->trans);
1112 if (error) 1103 if (error)
1113 goto out; 1104 goto out;
@@ -1138,7 +1129,7 @@ xfs_attr_node_removename(
1138 error = xfs_attr3_leaf_to_shortform(bp, args, forkoff); 1129 error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
1139 /* bp is gone due to xfs_da_shrink_inode */ 1130 /* bp is gone due to xfs_da_shrink_inode */
1140 if (error) 1131 if (error)
1141 goto out_defer_cancel; 1132 goto out;
1142 error = xfs_defer_finish(&args->trans); 1133 error = xfs_defer_finish(&args->trans);
1143 if (error) 1134 if (error)
1144 goto out; 1135 goto out;
@@ -1150,9 +1141,6 @@ xfs_attr_node_removename(
1150out: 1141out:
1151 xfs_da_state_free(state); 1142 xfs_da_state_free(state);
1152 return error; 1143 return error;
1153out_defer_cancel:
1154 xfs_defer_cancel(args->trans);
1155 goto out;
1156} 1144}
1157 1145
1158/* 1146/*
diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c
index af094063e402..d89363c6b523 100644
--- a/fs/xfs/libxfs/xfs_attr_remote.c
+++ b/fs/xfs/libxfs/xfs_attr_remote.c
@@ -485,7 +485,7 @@ xfs_attr_rmtval_set(
485 blkcnt, XFS_BMAPI_ATTRFORK, args->total, &map, 485 blkcnt, XFS_BMAPI_ATTRFORK, args->total, &map,
486 &nmap); 486 &nmap);
487 if (error) 487 if (error)
488 goto out_defer_cancel; 488 return error;
489 error = xfs_defer_finish(&args->trans); 489 error = xfs_defer_finish(&args->trans);
490 if (error) 490 if (error)
491 return error; 491 return error;
@@ -553,9 +553,6 @@ xfs_attr_rmtval_set(
553 } 553 }
554 ASSERT(valuelen == 0); 554 ASSERT(valuelen == 0);
555 return 0; 555 return 0;
556out_defer_cancel:
557 xfs_defer_cancel(args->trans);
558 return error;
559} 556}
560 557
561/* 558/*
@@ -625,7 +622,7 @@ xfs_attr_rmtval_remove(
625 error = xfs_bunmapi(args->trans, args->dp, lblkno, blkcnt, 622 error = xfs_bunmapi(args->trans, args->dp, lblkno, blkcnt,
626 XFS_BMAPI_ATTRFORK, 1, &done); 623 XFS_BMAPI_ATTRFORK, 1, &done);
627 if (error) 624 if (error)
628 goto out_defer_cancel; 625 return error;
629 error = xfs_defer_finish(&args->trans); 626 error = xfs_defer_finish(&args->trans);
630 if (error) 627 if (error)
631 return error; 628 return error;
@@ -638,7 +635,4 @@ xfs_attr_rmtval_remove(
638 return error; 635 return error;
639 } 636 }
640 return 0; 637 return 0;
641out_defer_cancel:
642 xfs_defer_cancel(args->trans);
643 return error;
644} 638}
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 2760314fdf7f..a47670332326 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -673,7 +673,8 @@ xfs_bmap_extents_to_btree(
673 ASSERT(XFS_IFORK_FORMAT(ip, whichfork) == XFS_DINODE_FMT_EXTENTS); 673 ASSERT(XFS_IFORK_FORMAT(ip, whichfork) == XFS_DINODE_FMT_EXTENTS);
674 674
675 /* 675 /*
676 * Make space in the inode incore. 676 * Make space in the inode incore. This needs to be undone if we fail
677 * to expand the root.
677 */ 678 */
678 xfs_iroot_realloc(ip, 1, whichfork); 679 xfs_iroot_realloc(ip, 1, whichfork);
679 ifp->if_flags |= XFS_IFBROOT; 680 ifp->if_flags |= XFS_IFBROOT;
@@ -711,16 +712,15 @@ xfs_bmap_extents_to_btree(
711 args.minlen = args.maxlen = args.prod = 1; 712 args.minlen = args.maxlen = args.prod = 1;
712 args.wasdel = wasdel; 713 args.wasdel = wasdel;
713 *logflagsp = 0; 714 *logflagsp = 0;
714 if ((error = xfs_alloc_vextent(&args))) { 715 error = xfs_alloc_vextent(&args);
715 ASSERT(ifp->if_broot == NULL); 716 if (error)
716 goto err1; 717 goto out_root_realloc;
717 }
718 718
719 if (WARN_ON_ONCE(args.fsbno == NULLFSBLOCK)) { 719 if (WARN_ON_ONCE(args.fsbno == NULLFSBLOCK)) {
720 ASSERT(ifp->if_broot == NULL);
721 error = -ENOSPC; 720 error = -ENOSPC;
722 goto err1; 721 goto out_root_realloc;
723 } 722 }
723
724 /* 724 /*
725 * Allocation can't fail, the space was reserved. 725 * Allocation can't fail, the space was reserved.
726 */ 726 */
@@ -732,9 +732,10 @@ xfs_bmap_extents_to_btree(
732 xfs_trans_mod_dquot_byino(tp, ip, XFS_TRANS_DQ_BCOUNT, 1L); 732 xfs_trans_mod_dquot_byino(tp, ip, XFS_TRANS_DQ_BCOUNT, 1L);
733 abp = xfs_btree_get_bufl(mp, tp, args.fsbno, 0); 733 abp = xfs_btree_get_bufl(mp, tp, args.fsbno, 0);
734 if (!abp) { 734 if (!abp) {
735 error = -ENOSPC; 735 error = -EFSCORRUPTED;
736 goto err2; 736 goto out_unreserve_dquot;
737 } 737 }
738
738 /* 739 /*
739 * Fill in the child block. 740 * Fill in the child block.
740 */ 741 */
@@ -775,11 +776,12 @@ xfs_bmap_extents_to_btree(
775 *logflagsp = XFS_ILOG_CORE | xfs_ilog_fbroot(whichfork); 776 *logflagsp = XFS_ILOG_CORE | xfs_ilog_fbroot(whichfork);
776 return 0; 777 return 0;
777 778
778err2: 779out_unreserve_dquot:
779 xfs_trans_mod_dquot_byino(tp, ip, XFS_TRANS_DQ_BCOUNT, -1L); 780 xfs_trans_mod_dquot_byino(tp, ip, XFS_TRANS_DQ_BCOUNT, -1L);
780err1: 781out_root_realloc:
781 xfs_iroot_realloc(ip, -1, whichfork); 782 xfs_iroot_realloc(ip, -1, whichfork);
782 XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_EXTENTS); 783 XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_EXTENTS);
784 ASSERT(ifp->if_broot == NULL);
783 xfs_btree_del_cursor(cur, XFS_BTREE_ERROR); 785 xfs_btree_del_cursor(cur, XFS_BTREE_ERROR);
784 786
785 return error; 787 return error;
diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
index 059bc44c27e8..afbe336600e1 100644
--- a/fs/xfs/libxfs/xfs_format.h
+++ b/fs/xfs/libxfs/xfs_format.h
@@ -1016,6 +1016,8 @@ static inline void xfs_dinode_put_rdev(struct xfs_dinode *dip, xfs_dev_t rdev)
1016#define XFS_DIFLAG_EXTSZINHERIT_BIT 12 /* inherit inode extent size */ 1016#define XFS_DIFLAG_EXTSZINHERIT_BIT 12 /* inherit inode extent size */
1017#define XFS_DIFLAG_NODEFRAG_BIT 13 /* do not reorganize/defragment */ 1017#define XFS_DIFLAG_NODEFRAG_BIT 13 /* do not reorganize/defragment */
1018#define XFS_DIFLAG_FILESTREAM_BIT 14 /* use filestream allocator */ 1018#define XFS_DIFLAG_FILESTREAM_BIT 14 /* use filestream allocator */
1019/* Do not use bit 15, di_flags is legacy and unchanging now */
1020
1019#define XFS_DIFLAG_REALTIME (1 << XFS_DIFLAG_REALTIME_BIT) 1021#define XFS_DIFLAG_REALTIME (1 << XFS_DIFLAG_REALTIME_BIT)
1020#define XFS_DIFLAG_PREALLOC (1 << XFS_DIFLAG_PREALLOC_BIT) 1022#define XFS_DIFLAG_PREALLOC (1 << XFS_DIFLAG_PREALLOC_BIT)
1021#define XFS_DIFLAG_NEWRTBM (1 << XFS_DIFLAG_NEWRTBM_BIT) 1023#define XFS_DIFLAG_NEWRTBM (1 << XFS_DIFLAG_NEWRTBM_BIT)
diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
index 30d1d60f1d46..09d9c8cfa4a0 100644
--- a/fs/xfs/libxfs/xfs_inode_buf.c
+++ b/fs/xfs/libxfs/xfs_inode_buf.c
@@ -415,6 +415,31 @@ xfs_dinode_verify_fork(
415 return NULL; 415 return NULL;
416} 416}
417 417
418static xfs_failaddr_t
419xfs_dinode_verify_forkoff(
420 struct xfs_dinode *dip,
421 struct xfs_mount *mp)
422{
423 if (!XFS_DFORK_Q(dip))
424 return NULL;
425
426 switch (dip->di_format) {
427 case XFS_DINODE_FMT_DEV:
428 if (dip->di_forkoff != (roundup(sizeof(xfs_dev_t), 8) >> 3))
429 return __this_address;
430 break;
431 case XFS_DINODE_FMT_LOCAL: /* fall through ... */
432 case XFS_DINODE_FMT_EXTENTS: /* fall through ... */
433 case XFS_DINODE_FMT_BTREE:
434 if (dip->di_forkoff >= (XFS_LITINO(mp, dip->di_version) >> 3))
435 return __this_address;
436 break;
437 default:
438 return __this_address;
439 }
440 return NULL;
441}
442
418xfs_failaddr_t 443xfs_failaddr_t
419xfs_dinode_verify( 444xfs_dinode_verify(
420 struct xfs_mount *mp, 445 struct xfs_mount *mp,
@@ -470,6 +495,11 @@ xfs_dinode_verify(
470 if (mode && (flags & XFS_DIFLAG_REALTIME) && !mp->m_rtdev_targp) 495 if (mode && (flags & XFS_DIFLAG_REALTIME) && !mp->m_rtdev_targp)
471 return __this_address; 496 return __this_address;
472 497
498 /* check for illegal values of forkoff */
499 fa = xfs_dinode_verify_forkoff(dip, mp);
500 if (fa)
501 return fa;
502
473 /* Do we have appropriate data fork formats for the mode? */ 503 /* Do we have appropriate data fork formats for the mode? */
474 switch (mode & S_IFMT) { 504 switch (mode & S_IFMT) {
475 case S_IFIFO: 505 case S_IFIFO:
diff --git a/fs/xfs/scrub/alloc.c b/fs/xfs/scrub/alloc.c
index 036b5c7021eb..376bcb585ae6 100644
--- a/fs/xfs/scrub/alloc.c
+++ b/fs/xfs/scrub/alloc.c
@@ -17,7 +17,6 @@
17#include "xfs_sb.h" 17#include "xfs_sb.h"
18#include "xfs_alloc.h" 18#include "xfs_alloc.h"
19#include "xfs_rmap.h" 19#include "xfs_rmap.h"
20#include "xfs_alloc.h"
21#include "scrub/xfs_scrub.h" 20#include "scrub/xfs_scrub.h"
22#include "scrub/scrub.h" 21#include "scrub/scrub.h"
23#include "scrub/common.h" 22#include "scrub/common.h"
diff --git a/fs/xfs/scrub/inode.c b/fs/xfs/scrub/inode.c
index 5b3b177c0fc9..e386c9b0b4ab 100644
--- a/fs/xfs/scrub/inode.c
+++ b/fs/xfs/scrub/inode.c
@@ -126,6 +126,7 @@ xchk_inode_flags(
126{ 126{
127 struct xfs_mount *mp = sc->mp; 127 struct xfs_mount *mp = sc->mp;
128 128
129 /* di_flags are all taken, last bit cannot be used */
129 if (flags & ~XFS_DIFLAG_ANY) 130 if (flags & ~XFS_DIFLAG_ANY)
130 goto bad; 131 goto bad;
131 132
@@ -172,8 +173,9 @@ xchk_inode_flags2(
172{ 173{
173 struct xfs_mount *mp = sc->mp; 174 struct xfs_mount *mp = sc->mp;
174 175
176 /* Unknown di_flags2 could be from a future kernel */
175 if (flags2 & ~XFS_DIFLAG2_ANY) 177 if (flags2 & ~XFS_DIFLAG2_ANY)
176 goto bad; 178 xchk_ino_set_warning(sc, ino);
177 179
178 /* reflink flag requires reflink feature */ 180 /* reflink flag requires reflink feature */
179 if ((flags2 & XFS_DIFLAG2_REFLINK) && 181 if ((flags2 & XFS_DIFLAG2_REFLINK) &&
diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
index addbd74ecd8e..6de8d90041ff 100644
--- a/fs/xfs/xfs_bmap_util.c
+++ b/fs/xfs/xfs_bmap_util.c
@@ -702,13 +702,9 @@ xfs_bmap_punch_delalloc_range(
702 struct xfs_iext_cursor icur; 702 struct xfs_iext_cursor icur;
703 int error = 0; 703 int error = 0;
704 704
705 xfs_ilock(ip, XFS_ILOCK_EXCL); 705 ASSERT(ifp->if_flags & XFS_IFEXTENTS);
706 if (!(ifp->if_flags & XFS_IFEXTENTS)) {
707 error = xfs_iread_extents(NULL, ip, XFS_DATA_FORK);
708 if (error)
709 goto out_unlock;
710 }
711 706
707 xfs_ilock(ip, XFS_ILOCK_EXCL);
712 if (!xfs_iext_lookup_extent_before(ip, ifp, &end_fsb, &icur, &got)) 708 if (!xfs_iext_lookup_extent_before(ip, ifp, &end_fsb, &icur, &got))
713 goto out_unlock; 709 goto out_unlock;
714 710
@@ -1584,7 +1580,7 @@ xfs_swap_extent_rmap(
1584 tirec.br_blockcount, &irec, 1580 tirec.br_blockcount, &irec,
1585 &nimaps, 0); 1581 &nimaps, 0);
1586 if (error) 1582 if (error)
1587 goto out_defer; 1583 goto out;
1588 ASSERT(nimaps == 1); 1584 ASSERT(nimaps == 1);
1589 ASSERT(tirec.br_startoff == irec.br_startoff); 1585 ASSERT(tirec.br_startoff == irec.br_startoff);
1590 trace_xfs_swap_extent_rmap_remap_piece(ip, &irec); 1586 trace_xfs_swap_extent_rmap_remap_piece(ip, &irec);
@@ -1599,22 +1595,22 @@ xfs_swap_extent_rmap(
1599 /* Remove the mapping from the donor file. */ 1595 /* Remove the mapping from the donor file. */
1600 error = xfs_bmap_unmap_extent(tp, tip, &uirec); 1596 error = xfs_bmap_unmap_extent(tp, tip, &uirec);
1601 if (error) 1597 if (error)
1602 goto out_defer; 1598 goto out;
1603 1599
1604 /* Remove the mapping from the source file. */ 1600 /* Remove the mapping from the source file. */
1605 error = xfs_bmap_unmap_extent(tp, ip, &irec); 1601 error = xfs_bmap_unmap_extent(tp, ip, &irec);
1606 if (error) 1602 if (error)
1607 goto out_defer; 1603 goto out;
1608 1604
1609 /* Map the donor file's blocks into the source file. */ 1605 /* Map the donor file's blocks into the source file. */
1610 error = xfs_bmap_map_extent(tp, ip, &uirec); 1606 error = xfs_bmap_map_extent(tp, ip, &uirec);
1611 if (error) 1607 if (error)
1612 goto out_defer; 1608 goto out;
1613 1609
1614 /* Map the source file's blocks into the donor file. */ 1610 /* Map the source file's blocks into the donor file. */
1615 error = xfs_bmap_map_extent(tp, tip, &irec); 1611 error = xfs_bmap_map_extent(tp, tip, &irec);
1616 if (error) 1612 if (error)
1617 goto out_defer; 1613 goto out;
1618 1614
1619 error = xfs_defer_finish(tpp); 1615 error = xfs_defer_finish(tpp);
1620 tp = *tpp; 1616 tp = *tpp;
@@ -1636,8 +1632,6 @@ xfs_swap_extent_rmap(
1636 tip->i_d.di_flags2 = tip_flags2; 1632 tip->i_d.di_flags2 = tip_flags2;
1637 return 0; 1633 return 0;
1638 1634
1639out_defer:
1640 xfs_defer_cancel(tp);
1641out: 1635out:
1642 trace_xfs_swap_extent_rmap_error(ip, error, _RET_IP_); 1636 trace_xfs_swap_extent_rmap_error(ip, error, _RET_IP_);
1643 tip->i_d.di_flags2 = tip_flags2; 1637 tip->i_d.di_flags2 = tip_flags2;
diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
index 1c9d1398980b..12d8455bfbb2 100644
--- a/fs/xfs/xfs_buf_item.c
+++ b/fs/xfs/xfs_buf_item.c
@@ -532,6 +532,49 @@ xfs_buf_item_push(
532} 532}
533 533
534/* 534/*
535 * Drop the buffer log item refcount and take appropriate action. This helper
536 * determines whether the bli must be freed or not, since a decrement to zero
537 * does not necessarily mean the bli is unused.
538 *
539 * Return true if the bli is freed, false otherwise.
540 */
541bool
542xfs_buf_item_put(
543 struct xfs_buf_log_item *bip)
544{
545 struct xfs_log_item *lip = &bip->bli_item;
546 bool aborted;
547 bool dirty;
548
549 /* drop the bli ref and return if it wasn't the last one */
550 if (!atomic_dec_and_test(&bip->bli_refcount))
551 return false;
552
553 /*
554 * We dropped the last ref and must free the item if clean or aborted.
555 * If the bli is dirty and non-aborted, the buffer was clean in the
556 * transaction but still awaiting writeback from previous changes. In
557 * that case, the bli is freed on buffer writeback completion.
558 */
559 aborted = test_bit(XFS_LI_ABORTED, &lip->li_flags) ||
560 XFS_FORCED_SHUTDOWN(lip->li_mountp);
561 dirty = bip->bli_flags & XFS_BLI_DIRTY;
562 if (dirty && !aborted)
563 return false;
564
565 /*
566 * The bli is aborted or clean. An aborted item may be in the AIL
567 * regardless of dirty state. For example, consider an aborted
568 * transaction that invalidated a dirty bli and cleared the dirty
569 * state.
570 */
571 if (aborted)
572 xfs_trans_ail_remove(lip, SHUTDOWN_LOG_IO_ERROR);
573 xfs_buf_item_relse(bip->bli_buf);
574 return true;
575}
576
577/*
535 * Release the buffer associated with the buf log item. If there is no dirty 578 * Release the buffer associated with the buf log item. If there is no dirty
536 * logged data associated with the buffer recorded in the buf log item, then 579 * logged data associated with the buffer recorded in the buf log item, then
537 * free the buf log item and remove the reference to it in the buffer. 580 * free the buf log item and remove the reference to it in the buffer.
@@ -556,76 +599,42 @@ xfs_buf_item_unlock(
556{ 599{
557 struct xfs_buf_log_item *bip = BUF_ITEM(lip); 600 struct xfs_buf_log_item *bip = BUF_ITEM(lip);
558 struct xfs_buf *bp = bip->bli_buf; 601 struct xfs_buf *bp = bip->bli_buf;
559 bool aborted; 602 bool released;
560 bool hold = !!(bip->bli_flags & XFS_BLI_HOLD); 603 bool hold = bip->bli_flags & XFS_BLI_HOLD;
561 bool dirty = !!(bip->bli_flags & XFS_BLI_DIRTY); 604 bool stale = bip->bli_flags & XFS_BLI_STALE;
562#if defined(DEBUG) || defined(XFS_WARN) 605#if defined(DEBUG) || defined(XFS_WARN)
563 bool ordered = !!(bip->bli_flags & XFS_BLI_ORDERED); 606 bool ordered = bip->bli_flags & XFS_BLI_ORDERED;
607 bool dirty = bip->bli_flags & XFS_BLI_DIRTY;
564#endif 608#endif
565 609
566 aborted = test_bit(XFS_LI_ABORTED, &lip->li_flags);
567
568 /* Clear the buffer's association with this transaction. */
569 bp->b_transp = NULL;
570
571 /*
572 * The per-transaction state has been copied above so clear it from the
573 * bli.
574 */
575 bip->bli_flags &= ~(XFS_BLI_LOGGED | XFS_BLI_HOLD | XFS_BLI_ORDERED);
576
577 /*
578 * If the buf item is marked stale, then don't do anything. We'll
579 * unlock the buffer and free the buf item when the buffer is unpinned
580 * for the last time.
581 */
582 if (bip->bli_flags & XFS_BLI_STALE) {
583 trace_xfs_buf_item_unlock_stale(bip);
584 ASSERT(bip->__bli_format.blf_flags & XFS_BLF_CANCEL);
585 if (!aborted) {
586 atomic_dec(&bip->bli_refcount);
587 return;
588 }
589 }
590
591 trace_xfs_buf_item_unlock(bip); 610 trace_xfs_buf_item_unlock(bip);
592 611
593 /* 612 /*
594 * If the buf item isn't tracking any data, free it, otherwise drop the
595 * reference we hold to it. If we are aborting the transaction, this may
596 * be the only reference to the buf item, so we free it anyway
597 * regardless of whether it is dirty or not. A dirty abort implies a
598 * shutdown, anyway.
599 *
600 * The bli dirty state should match whether the blf has logged segments 613 * The bli dirty state should match whether the blf has logged segments
601 * except for ordered buffers, where only the bli should be dirty. 614 * except for ordered buffers, where only the bli should be dirty.
602 */ 615 */
603 ASSERT((!ordered && dirty == xfs_buf_item_dirty_format(bip)) || 616 ASSERT((!ordered && dirty == xfs_buf_item_dirty_format(bip)) ||
604 (ordered && dirty && !xfs_buf_item_dirty_format(bip))); 617 (ordered && dirty && !xfs_buf_item_dirty_format(bip)));
618 ASSERT(!stale || (bip->__bli_format.blf_flags & XFS_BLF_CANCEL));
605 619
606 /* 620 /*
607 * Clean buffers, by definition, cannot be in the AIL. However, aborted 621 * Clear the buffer's association with this transaction and
608 * buffers may be in the AIL regardless of dirty state. An aborted 622 * per-transaction state from the bli, which has been copied above.
609 * transaction that invalidates a buffer already in the AIL may have
610 * marked it stale and cleared the dirty state, for example.
611 *
612 * Therefore if we are aborting a buffer and we've just taken the last
613 * reference away, we have to check if it is in the AIL before freeing
614 * it. We need to free it in this case, because an aborted transaction
615 * has already shut the filesystem down and this is the last chance we
616 * will have to do so.
617 */ 623 */
618 if (atomic_dec_and_test(&bip->bli_refcount)) { 624 bp->b_transp = NULL;
619 if (aborted) { 625 bip->bli_flags &= ~(XFS_BLI_LOGGED | XFS_BLI_HOLD | XFS_BLI_ORDERED);
620 ASSERT(XFS_FORCED_SHUTDOWN(lip->li_mountp));
621 xfs_trans_ail_remove(lip, SHUTDOWN_LOG_IO_ERROR);
622 xfs_buf_item_relse(bp);
623 } else if (!dirty)
624 xfs_buf_item_relse(bp);
625 }
626 626
627 if (!hold) 627 /*
628 xfs_buf_relse(bp); 628 * Unref the item and unlock the buffer unless held or stale. Stale
629 * buffers remain locked until final unpin unless the bli is freed by
630 * the unref call. The latter implies shutdown because buffer
631 * invalidation dirties the bli and transaction.
632 */
633 released = xfs_buf_item_put(bip);
634 if (hold || (stale && !released))
635 return;
636 ASSERT(!stale || test_bit(XFS_LI_ABORTED, &lip->li_flags));
637 xfs_buf_relse(bp);
629} 638}
630 639
631/* 640/*
diff --git a/fs/xfs/xfs_buf_item.h b/fs/xfs/xfs_buf_item.h
index 3f7d7b72e7e6..90f65f891fab 100644
--- a/fs/xfs/xfs_buf_item.h
+++ b/fs/xfs/xfs_buf_item.h
@@ -51,6 +51,7 @@ struct xfs_buf_log_item {
51 51
52int xfs_buf_item_init(struct xfs_buf *, struct xfs_mount *); 52int xfs_buf_item_init(struct xfs_buf *, struct xfs_mount *);
53void xfs_buf_item_relse(struct xfs_buf *); 53void xfs_buf_item_relse(struct xfs_buf *);
54bool xfs_buf_item_put(struct xfs_buf_log_item *);
54void xfs_buf_item_log(struct xfs_buf_log_item *, uint, uint); 55void xfs_buf_item_log(struct xfs_buf_log_item *, uint, uint);
55bool xfs_buf_item_dirty_format(struct xfs_buf_log_item *); 56bool xfs_buf_item_dirty_format(struct xfs_buf_log_item *);
56void xfs_buf_attach_iodone(struct xfs_buf *, 57void xfs_buf_attach_iodone(struct xfs_buf *,
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index d957a46dc1cb..05db9540e459 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1563,7 +1563,7 @@ xfs_itruncate_extents_flags(
1563 error = xfs_bunmapi(tp, ip, first_unmap_block, unmap_len, flags, 1563 error = xfs_bunmapi(tp, ip, first_unmap_block, unmap_len, flags,
1564 XFS_ITRUNC_MAX_EXTENTS, &done); 1564 XFS_ITRUNC_MAX_EXTENTS, &done);
1565 if (error) 1565 if (error)
1566 goto out_bmap_cancel; 1566 goto out;
1567 1567
1568 /* 1568 /*
1569 * Duplicate the transaction that has the permanent 1569 * Duplicate the transaction that has the permanent
@@ -1599,14 +1599,6 @@ xfs_itruncate_extents_flags(
1599out: 1599out:
1600 *tpp = tp; 1600 *tpp = tp;
1601 return error; 1601 return error;
1602out_bmap_cancel:
1603 /*
1604 * If the bunmapi call encounters an error, return to the caller where
1605 * the transaction can be properly aborted. We just need to make sure
1606 * we're not holding any resources that we were not when we came in.
1607 */
1608 xfs_defer_cancel(tp);
1609 goto out;
1610} 1602}
1611 1603
1612int 1604int
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index c3e74f9128e8..f48ffd7a8d3e 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -471,8 +471,18 @@ xfs_vn_get_link_inline(
471 struct inode *inode, 471 struct inode *inode,
472 struct delayed_call *done) 472 struct delayed_call *done)
473{ 473{
474 char *link;
475
474 ASSERT(XFS_I(inode)->i_df.if_flags & XFS_IFINLINE); 476 ASSERT(XFS_I(inode)->i_df.if_flags & XFS_IFINLINE);
475 return XFS_I(inode)->i_df.if_u1.if_data; 477
478 /*
479 * The VFS crashes on a NULL pointer, so return -EFSCORRUPTED if
480 * if_data is junk.
481 */
482 link = XFS_I(inode)->i_df.if_u1.if_data;
483 if (!link)
484 return ERR_PTR(-EFSCORRUPTED);
485 return link;
476} 486}
477 487
478STATIC int 488STATIC int
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index a21dc61ec09e..1fc9e9042e0e 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1570,16 +1570,6 @@ xlog_find_zeroed(
1570 if (last_cycle != 0) { /* log completely written to */ 1570 if (last_cycle != 0) { /* log completely written to */
1571 xlog_put_bp(bp); 1571 xlog_put_bp(bp);
1572 return 0; 1572 return 0;
1573 } else if (first_cycle != 1) {
1574 /*
1575 * If the cycle of the last block is zero, the cycle of
1576 * the first block must be 1. If it's not, maybe we're
1577 * not looking at a log... Bail out.
1578 */
1579 xfs_warn(log->l_mp,
1580 "Log inconsistent or not a log (last==0, first!=1)");
1581 error = -EINVAL;
1582 goto bp_err;
1583 } 1573 }
1584 1574
1585 /* we have a partially zeroed log */ 1575 /* we have a partially zeroed log */
diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
index 38f405415b88..42ea7bab9144 100644
--- a/fs/xfs/xfs_reflink.c
+++ b/fs/xfs/xfs_reflink.c
@@ -352,6 +352,47 @@ xfs_reflink_convert_cow(
352 return error; 352 return error;
353} 353}
354 354
355/*
356 * Find the extent that maps the given range in the COW fork. Even if the extent
357 * is not shared we might have a preallocation for it in the COW fork. If so we
358 * use it that rather than trigger a new allocation.
359 */
360static int
361xfs_find_trim_cow_extent(
362 struct xfs_inode *ip,
363 struct xfs_bmbt_irec *imap,
364 bool *shared,
365 bool *found)
366{
367 xfs_fileoff_t offset_fsb = imap->br_startoff;
368 xfs_filblks_t count_fsb = imap->br_blockcount;
369 struct xfs_iext_cursor icur;
370 struct xfs_bmbt_irec got;
371 bool trimmed;
372
373 *found = false;
374
375 /*
376 * If we don't find an overlapping extent, trim the range we need to
377 * allocate to fit the hole we found.
378 */
379 if (!xfs_iext_lookup_extent(ip, ip->i_cowfp, offset_fsb, &icur, &got) ||
380 got.br_startoff > offset_fsb)
381 return xfs_reflink_trim_around_shared(ip, imap, shared, &trimmed);
382
383 *shared = true;
384 if (isnullstartblock(got.br_startblock)) {
385 xfs_trim_extent(imap, got.br_startoff, got.br_blockcount);
386 return 0;
387 }
388
389 /* real extent found - no need to allocate */
390 xfs_trim_extent(&got, offset_fsb, count_fsb);
391 *imap = got;
392 *found = true;
393 return 0;
394}
395
355/* Allocate all CoW reservations covering a range of blocks in a file. */ 396/* Allocate all CoW reservations covering a range of blocks in a file. */
356int 397int
357xfs_reflink_allocate_cow( 398xfs_reflink_allocate_cow(
@@ -363,78 +404,64 @@ xfs_reflink_allocate_cow(
363 struct xfs_mount *mp = ip->i_mount; 404 struct xfs_mount *mp = ip->i_mount;
364 xfs_fileoff_t offset_fsb = imap->br_startoff; 405 xfs_fileoff_t offset_fsb = imap->br_startoff;
365 xfs_filblks_t count_fsb = imap->br_blockcount; 406 xfs_filblks_t count_fsb = imap->br_blockcount;
366 struct xfs_bmbt_irec got; 407 struct xfs_trans *tp;
367 struct xfs_trans *tp = NULL;
368 int nimaps, error = 0; 408 int nimaps, error = 0;
369 bool trimmed; 409 bool found;
370 xfs_filblks_t resaligned; 410 xfs_filblks_t resaligned;
371 xfs_extlen_t resblks = 0; 411 xfs_extlen_t resblks = 0;
372 struct xfs_iext_cursor icur;
373 412
374retry:
375 ASSERT(xfs_is_reflink_inode(ip));
376 ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); 413 ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
414 ASSERT(xfs_is_reflink_inode(ip));
377 415
378 /* 416 error = xfs_find_trim_cow_extent(ip, imap, shared, &found);
379 * Even if the extent is not shared we might have a preallocation for 417 if (error || !*shared)
380 * it in the COW fork. If so use it. 418 return error;
381 */ 419 if (found)
382 if (xfs_iext_lookup_extent(ip, ip->i_cowfp, offset_fsb, &icur, &got) && 420 goto convert;
383 got.br_startoff <= offset_fsb) {
384 *shared = true;
385
386 /* If we have a real allocation in the COW fork we're done. */
387 if (!isnullstartblock(got.br_startblock)) {
388 xfs_trim_extent(&got, offset_fsb, count_fsb);
389 *imap = got;
390 goto convert;
391 }
392 421
393 xfs_trim_extent(imap, got.br_startoff, got.br_blockcount); 422 resaligned = xfs_aligned_fsb_count(imap->br_startoff,
394 } else { 423 imap->br_blockcount, xfs_get_cowextsz_hint(ip));
395 error = xfs_reflink_trim_around_shared(ip, imap, shared, &trimmed); 424 resblks = XFS_DIOSTRAT_SPACE_RES(mp, resaligned);
396 if (error || !*shared)
397 goto out;
398 }
399 425
400 if (!tp) { 426 xfs_iunlock(ip, *lockmode);
401 resaligned = xfs_aligned_fsb_count(imap->br_startoff, 427 error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write, resblks, 0, 0, &tp);
402 imap->br_blockcount, xfs_get_cowextsz_hint(ip)); 428 *lockmode = XFS_ILOCK_EXCL;
403 resblks = XFS_DIOSTRAT_SPACE_RES(mp, resaligned); 429 xfs_ilock(ip, *lockmode);
404 430
405 xfs_iunlock(ip, *lockmode); 431 if (error)
406 error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write, resblks, 0, 0, &tp); 432 return error;
407 *lockmode = XFS_ILOCK_EXCL;
408 xfs_ilock(ip, *lockmode);
409 433
410 if (error) 434 error = xfs_qm_dqattach_locked(ip, false);
411 return error; 435 if (error)
436 goto out_trans_cancel;
412 437
413 error = xfs_qm_dqattach_locked(ip, false); 438 /*
414 if (error) 439 * Check for an overlapping extent again now that we dropped the ilock.
415 goto out; 440 */
416 goto retry; 441 error = xfs_find_trim_cow_extent(ip, imap, shared, &found);
442 if (error || !*shared)
443 goto out_trans_cancel;
444 if (found) {
445 xfs_trans_cancel(tp);
446 goto convert;
417 } 447 }
418 448
419 error = xfs_trans_reserve_quota_nblks(tp, ip, resblks, 0, 449 error = xfs_trans_reserve_quota_nblks(tp, ip, resblks, 0,
420 XFS_QMOPT_RES_REGBLKS); 450 XFS_QMOPT_RES_REGBLKS);
421 if (error) 451 if (error)
422 goto out; 452 goto out_trans_cancel;
423 453
424 xfs_trans_ijoin(tp, ip, 0); 454 xfs_trans_ijoin(tp, ip, 0);
425 455
426 nimaps = 1;
427
428 /* Allocate the entire reservation as unwritten blocks. */ 456 /* Allocate the entire reservation as unwritten blocks. */
457 nimaps = 1;
429 error = xfs_bmapi_write(tp, ip, imap->br_startoff, imap->br_blockcount, 458 error = xfs_bmapi_write(tp, ip, imap->br_startoff, imap->br_blockcount,
430 XFS_BMAPI_COWFORK | XFS_BMAPI_PREALLOC, 459 XFS_BMAPI_COWFORK | XFS_BMAPI_PREALLOC,
431 resblks, imap, &nimaps); 460 resblks, imap, &nimaps);
432 if (error) 461 if (error)
433 goto out_trans_cancel; 462 goto out_unreserve;
434 463
435 xfs_inode_set_cowblocks_tag(ip); 464 xfs_inode_set_cowblocks_tag(ip);
436
437 /* Finish up. */
438 error = xfs_trans_commit(tp); 465 error = xfs_trans_commit(tp);
439 if (error) 466 if (error)
440 return error; 467 return error;
@@ -447,12 +474,12 @@ retry:
447 return -ENOSPC; 474 return -ENOSPC;
448convert: 475convert:
449 return xfs_reflink_convert_cow_extent(ip, imap, offset_fsb, count_fsb); 476 return xfs_reflink_convert_cow_extent(ip, imap, offset_fsb, count_fsb);
450out_trans_cancel: 477
478out_unreserve:
451 xfs_trans_unreserve_quota_nblks(tp, ip, (long)resblks, 0, 479 xfs_trans_unreserve_quota_nblks(tp, ip, (long)resblks, 0,
452 XFS_QMOPT_RES_REGBLKS); 480 XFS_QMOPT_RES_REGBLKS);
453out: 481out_trans_cancel:
454 if (tp) 482 xfs_trans_cancel(tp);
455 xfs_trans_cancel(tp);
456 return error; 483 return error;
457} 484}
458 485
@@ -666,14 +693,12 @@ xfs_reflink_end_cow(
666 if (!del.br_blockcount) 693 if (!del.br_blockcount)
667 goto prev_extent; 694 goto prev_extent;
668 695
669 ASSERT(!isnullstartblock(got.br_startblock));
670
671 /* 696 /*
672 * Don't remap unwritten extents; these are 697 * Only remap real extent that contain data. With AIO
673 * speculatively preallocated CoW extents that have been 698 * speculatively preallocations can leak into the range we
674 * allocated but have not yet been involved in a write. 699 * are called upon, and we need to skip them.
675 */ 700 */
676 if (got.br_state == XFS_EXT_UNWRITTEN) 701 if (!xfs_bmap_is_real_extent(&got))
677 goto prev_extent; 702 goto prev_extent;
678 703
679 /* Unmap the old blocks in the data fork. */ 704 /* Unmap the old blocks in the data fork. */
@@ -1195,35 +1220,92 @@ retry:
1195 return 0; 1220 return 0;
1196} 1221}
1197 1222
1223/* Unlock both inodes after they've been prepped for a range clone. */
1224STATIC void
1225xfs_reflink_remap_unlock(
1226 struct file *file_in,
1227 struct file *file_out)
1228{
1229 struct inode *inode_in = file_inode(file_in);
1230 struct xfs_inode *src = XFS_I(inode_in);
1231 struct inode *inode_out = file_inode(file_out);
1232 struct xfs_inode *dest = XFS_I(inode_out);
1233 bool same_inode = (inode_in == inode_out);
1234
1235 xfs_iunlock(dest, XFS_MMAPLOCK_EXCL);
1236 if (!same_inode)
1237 xfs_iunlock(src, XFS_MMAPLOCK_SHARED);
1238 inode_unlock(inode_out);
1239 if (!same_inode)
1240 inode_unlock_shared(inode_in);
1241}
1242
1198/* 1243/*
1199 * Link a range of blocks from one file to another. 1244 * If we're reflinking to a point past the destination file's EOF, we must
1245 * zero any speculative post-EOF preallocations that sit between the old EOF
1246 * and the destination file offset.
1200 */ 1247 */
1201int 1248static int
1202xfs_reflink_remap_range( 1249xfs_reflink_zero_posteof(
1250 struct xfs_inode *ip,
1251 loff_t pos)
1252{
1253 loff_t isize = i_size_read(VFS_I(ip));
1254
1255 if (pos <= isize)
1256 return 0;
1257
1258 trace_xfs_zero_eof(ip, isize, pos - isize);
1259 return iomap_zero_range(VFS_I(ip), isize, pos - isize, NULL,
1260 &xfs_iomap_ops);
1261}
1262
1263/*
1264 * Prepare two files for range cloning. Upon a successful return both inodes
1265 * will have the iolock and mmaplock held, the page cache of the out file will
1266 * be truncated, and any leases on the out file will have been broken. This
1267 * function borrows heavily from xfs_file_aio_write_checks.
1268 *
1269 * The VFS allows partial EOF blocks to "match" for dedupe even though it hasn't
1270 * checked that the bytes beyond EOF physically match. Hence we cannot use the
1271 * EOF block in the source dedupe range because it's not a complete block match,
1272 * hence can introduce a corruption into the file that has it's block replaced.
1273 *
1274 * In similar fashion, the VFS file cloning also allows partial EOF blocks to be
1275 * "block aligned" for the purposes of cloning entire files. However, if the
1276 * source file range includes the EOF block and it lands within the existing EOF
1277 * of the destination file, then we can expose stale data from beyond the source
1278 * file EOF in the destination file.
1279 *
1280 * XFS doesn't support partial block sharing, so in both cases we have check
1281 * these cases ourselves. For dedupe, we can simply round the length to dedupe
1282 * down to the previous whole block and ignore the partial EOF block. While this
1283 * means we can't dedupe the last block of a file, this is an acceptible
1284 * tradeoff for simplicity on implementation.
1285 *
1286 * For cloning, we want to share the partial EOF block if it is also the new EOF
1287 * block of the destination file. If the partial EOF block lies inside the
1288 * existing destination EOF, then we have to abort the clone to avoid exposing
1289 * stale data in the destination file. Hence we reject these clone attempts with
1290 * -EINVAL in this case.
1291 */
1292STATIC int
1293xfs_reflink_remap_prep(
1203 struct file *file_in, 1294 struct file *file_in,
1204 loff_t pos_in, 1295 loff_t pos_in,
1205 struct file *file_out, 1296 struct file *file_out,
1206 loff_t pos_out, 1297 loff_t pos_out,
1207 u64 len, 1298 u64 *len,
1208 bool is_dedupe) 1299 bool is_dedupe)
1209{ 1300{
1210 struct inode *inode_in = file_inode(file_in); 1301 struct inode *inode_in = file_inode(file_in);
1211 struct xfs_inode *src = XFS_I(inode_in); 1302 struct xfs_inode *src = XFS_I(inode_in);
1212 struct inode *inode_out = file_inode(file_out); 1303 struct inode *inode_out = file_inode(file_out);
1213 struct xfs_inode *dest = XFS_I(inode_out); 1304 struct xfs_inode *dest = XFS_I(inode_out);
1214 struct xfs_mount *mp = src->i_mount;
1215 bool same_inode = (inode_in == inode_out); 1305 bool same_inode = (inode_in == inode_out);
1216 xfs_fileoff_t sfsbno, dfsbno; 1306 u64 blkmask = i_blocksize(inode_in) - 1;
1217 xfs_filblks_t fsblen;
1218 xfs_extlen_t cowextsize;
1219 ssize_t ret; 1307 ssize_t ret;
1220 1308
1221 if (!xfs_sb_version_hasreflink(&mp->m_sb))
1222 return -EOPNOTSUPP;
1223
1224 if (XFS_FORCED_SHUTDOWN(mp))
1225 return -EIO;
1226
1227 /* Lock both files against IO */ 1309 /* Lock both files against IO */
1228 ret = xfs_iolock_two_inodes_and_break_layout(inode_in, inode_out); 1310 ret = xfs_iolock_two_inodes_and_break_layout(inode_in, inode_out);
1229 if (ret) 1311 if (ret)
@@ -1245,33 +1327,115 @@ xfs_reflink_remap_range(
1245 goto out_unlock; 1327 goto out_unlock;
1246 1328
1247 ret = vfs_clone_file_prep_inodes(inode_in, pos_in, inode_out, pos_out, 1329 ret = vfs_clone_file_prep_inodes(inode_in, pos_in, inode_out, pos_out,
1248 &len, is_dedupe); 1330 len, is_dedupe);
1249 if (ret <= 0) 1331 if (ret <= 0)
1250 goto out_unlock; 1332 goto out_unlock;
1251 1333
1334 /*
1335 * If the dedupe data matches, chop off the partial EOF block
1336 * from the source file so we don't try to dedupe the partial
1337 * EOF block.
1338 */
1339 if (is_dedupe) {
1340 *len &= ~blkmask;
1341 } else if (*len & blkmask) {
1342 /*
1343 * The user is attempting to share a partial EOF block,
1344 * if it's inside the destination EOF then reject it.
1345 */
1346 if (pos_out + *len < i_size_read(inode_out)) {
1347 ret = -EINVAL;
1348 goto out_unlock;
1349 }
1350 }
1351
1252 /* Attach dquots to dest inode before changing block map */ 1352 /* Attach dquots to dest inode before changing block map */
1253 ret = xfs_qm_dqattach(dest); 1353 ret = xfs_qm_dqattach(dest);
1254 if (ret) 1354 if (ret)
1255 goto out_unlock; 1355 goto out_unlock;
1256 1356
1257 trace_xfs_reflink_remap_range(src, pos_in, len, dest, pos_out);
1258
1259 /* 1357 /*
1260 * Clear out post-eof preallocations because we don't have page cache 1358 * Zero existing post-eof speculative preallocations in the destination
1261 * backing the delayed allocations and they'll never get freed on 1359 * file.
1262 * their own.
1263 */ 1360 */
1264 if (xfs_can_free_eofblocks(dest, true)) { 1361 ret = xfs_reflink_zero_posteof(dest, pos_out);
1265 ret = xfs_free_eofblocks(dest); 1362 if (ret)
1266 if (ret) 1363 goto out_unlock;
1267 goto out_unlock;
1268 }
1269 1364
1270 /* Set flags and remap blocks. */ 1365 /* Set flags and remap blocks. */
1271 ret = xfs_reflink_set_inode_flag(src, dest); 1366 ret = xfs_reflink_set_inode_flag(src, dest);
1272 if (ret) 1367 if (ret)
1273 goto out_unlock; 1368 goto out_unlock;
1274 1369
1370 /* Zap any page cache for the destination file's range. */
1371 truncate_inode_pages_range(&inode_out->i_data, pos_out,
1372 PAGE_ALIGN(pos_out + *len) - 1);
1373
1374 /* If we're altering the file contents... */
1375 if (!is_dedupe) {
1376 /*
1377 * ...update the timestamps (which will grab the ilock again
1378 * from xfs_fs_dirty_inode, so we have to call it before we
1379 * take the ilock).
1380 */
1381 if (!(file_out->f_mode & FMODE_NOCMTIME)) {
1382 ret = file_update_time(file_out);
1383 if (ret)
1384 goto out_unlock;
1385 }
1386
1387 /*
1388 * ...clear the security bits if the process is not being run
1389 * by root. This keeps people from modifying setuid and setgid
1390 * binaries.
1391 */
1392 ret = file_remove_privs(file_out);
1393 if (ret)
1394 goto out_unlock;
1395 }
1396
1397 return 1;
1398out_unlock:
1399 xfs_reflink_remap_unlock(file_in, file_out);
1400 return ret;
1401}
1402
1403/*
1404 * Link a range of blocks from one file to another.
1405 */
1406int
1407xfs_reflink_remap_range(
1408 struct file *file_in,
1409 loff_t pos_in,
1410 struct file *file_out,
1411 loff_t pos_out,
1412 u64 len,
1413 bool is_dedupe)
1414{
1415 struct inode *inode_in = file_inode(file_in);
1416 struct xfs_inode *src = XFS_I(inode_in);
1417 struct inode *inode_out = file_inode(file_out);
1418 struct xfs_inode *dest = XFS_I(inode_out);
1419 struct xfs_mount *mp = src->i_mount;
1420 xfs_fileoff_t sfsbno, dfsbno;
1421 xfs_filblks_t fsblen;
1422 xfs_extlen_t cowextsize;
1423 ssize_t ret;
1424
1425 if (!xfs_sb_version_hasreflink(&mp->m_sb))
1426 return -EOPNOTSUPP;
1427
1428 if (XFS_FORCED_SHUTDOWN(mp))
1429 return -EIO;
1430
1431 /* Prepare and then clone file data. */
1432 ret = xfs_reflink_remap_prep(file_in, pos_in, file_out, pos_out,
1433 &len, is_dedupe);
1434 if (ret <= 0)
1435 return ret;
1436
1437 trace_xfs_reflink_remap_range(src, pos_in, len, dest, pos_out);
1438
1275 dfsbno = XFS_B_TO_FSBT(mp, pos_out); 1439 dfsbno = XFS_B_TO_FSBT(mp, pos_out);
1276 sfsbno = XFS_B_TO_FSBT(mp, pos_in); 1440 sfsbno = XFS_B_TO_FSBT(mp, pos_in);
1277 fsblen = XFS_B_TO_FSB(mp, len); 1441 fsblen = XFS_B_TO_FSB(mp, len);
@@ -1280,10 +1444,6 @@ xfs_reflink_remap_range(
1280 if (ret) 1444 if (ret)
1281 goto out_unlock; 1445 goto out_unlock;
1282 1446
1283 /* Zap any page cache for the destination file's range. */
1284 truncate_inode_pages_range(&inode_out->i_data, pos_out,
1285 PAGE_ALIGN(pos_out + len) - 1);
1286
1287 /* 1447 /*
1288 * Carry the cowextsize hint from src to dest if we're sharing the 1448 * Carry the cowextsize hint from src to dest if we're sharing the
1289 * entire source file to the entire destination file, the source file 1449 * entire source file to the entire destination file, the source file
@@ -1300,12 +1460,7 @@ xfs_reflink_remap_range(
1300 is_dedupe); 1460 is_dedupe);
1301 1461
1302out_unlock: 1462out_unlock:
1303 xfs_iunlock(dest, XFS_MMAPLOCK_EXCL); 1463 xfs_reflink_remap_unlock(file_in, file_out);
1304 if (!same_inode)
1305 xfs_iunlock(src, XFS_MMAPLOCK_SHARED);
1306 inode_unlock(inode_out);
1307 if (!same_inode)
1308 inode_unlock_shared(inode_in);
1309 if (ret) 1464 if (ret)
1310 trace_xfs_reflink_remap_range_error(dest, ret, _RET_IP_); 1465 trace_xfs_reflink_remap_range_error(dest, ret, _RET_IP_);
1311 return ret; 1466 return ret;
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index ad315e83bc02..3043e5ed6495 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -473,7 +473,6 @@ DEFINE_BUF_ITEM_EVENT(xfs_buf_item_pin);
473DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unpin); 473DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unpin);
474DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unpin_stale); 474DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unpin_stale);
475DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unlock); 475DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unlock);
476DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unlock_stale);
477DEFINE_BUF_ITEM_EVENT(xfs_buf_item_committed); 476DEFINE_BUF_ITEM_EVENT(xfs_buf_item_committed);
478DEFINE_BUF_ITEM_EVENT(xfs_buf_item_push); 477DEFINE_BUF_ITEM_EVENT(xfs_buf_item_push);
479DEFINE_BUF_ITEM_EVENT(xfs_trans_get_buf); 478DEFINE_BUF_ITEM_EVENT(xfs_trans_get_buf);
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
index bedc5a5133a5..912b42f5fe4a 100644
--- a/fs/xfs/xfs_trans.c
+++ b/fs/xfs/xfs_trans.c
@@ -259,6 +259,14 @@ xfs_trans_alloc(
259 struct xfs_trans *tp; 259 struct xfs_trans *tp;
260 int error; 260 int error;
261 261
262 /*
263 * Allocate the handle before we do our freeze accounting and setting up
264 * GFP_NOFS allocation context so that we avoid lockdep false positives
265 * by doing GFP_KERNEL allocations inside sb_start_intwrite().
266 */
267 tp = kmem_zone_zalloc(xfs_trans_zone,
268 (flags & XFS_TRANS_NOFS) ? KM_NOFS : KM_SLEEP);
269
262 if (!(flags & XFS_TRANS_NO_WRITECOUNT)) 270 if (!(flags & XFS_TRANS_NO_WRITECOUNT))
263 sb_start_intwrite(mp->m_super); 271 sb_start_intwrite(mp->m_super);
264 272
@@ -270,8 +278,6 @@ xfs_trans_alloc(
270 mp->m_super->s_writers.frozen == SB_FREEZE_COMPLETE); 278 mp->m_super->s_writers.frozen == SB_FREEZE_COMPLETE);
271 atomic_inc(&mp->m_active_trans); 279 atomic_inc(&mp->m_active_trans);
272 280
273 tp = kmem_zone_zalloc(xfs_trans_zone,
274 (flags & XFS_TRANS_NOFS) ? KM_NOFS : KM_SLEEP);
275 tp->t_magic = XFS_TRANS_HEADER_MAGIC; 281 tp->t_magic = XFS_TRANS_HEADER_MAGIC;
276 tp->t_flags = flags; 282 tp->t_flags = flags;
277 tp->t_mountp = mp; 283 tp->t_mountp = mp;
diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c
index 15919f67a88f..286a287ac57a 100644
--- a/fs/xfs/xfs_trans_buf.c
+++ b/fs/xfs/xfs_trans_buf.c
@@ -322,49 +322,38 @@ xfs_trans_read_buf_map(
322} 322}
323 323
324/* 324/*
325 * Release the buffer bp which was previously acquired with one of the 325 * Release a buffer previously joined to the transaction. If the buffer is
326 * xfs_trans_... buffer allocation routines if the buffer has not 326 * modified within this transaction, decrement the recursion count but do not
327 * been modified within this transaction. If the buffer is modified 327 * release the buffer even if the count goes to 0. If the buffer is not modified
328 * within this transaction, do decrement the recursion count but do 328 * within the transaction, decrement the recursion count and release the buffer
329 * not release the buffer even if the count goes to 0. If the buffer is not 329 * if the recursion count goes to 0.
330 * modified within the transaction, decrement the recursion count and
331 * release the buffer if the recursion count goes to 0.
332 * 330 *
333 * If the buffer is to be released and it was not modified before 331 * If the buffer is to be released and it was not already dirty before this
334 * this transaction began, then free the buf_log_item associated with it. 332 * transaction began, then also free the buf_log_item associated with it.
335 * 333 *
336 * If the transaction pointer is NULL, make this just a normal 334 * If the transaction pointer is NULL, this is a normal xfs_buf_relse() call.
337 * brelse() call.
338 */ 335 */
339void 336void
340xfs_trans_brelse( 337xfs_trans_brelse(
341 xfs_trans_t *tp, 338 struct xfs_trans *tp,
342 xfs_buf_t *bp) 339 struct xfs_buf *bp)
343{ 340{
344 struct xfs_buf_log_item *bip; 341 struct xfs_buf_log_item *bip = bp->b_log_item;
345 int freed;
346 342
347 /* 343 ASSERT(bp->b_transp == tp);
348 * Default to a normal brelse() call if the tp is NULL. 344
349 */ 345 if (!tp) {
350 if (tp == NULL) {
351 ASSERT(bp->b_transp == NULL);
352 xfs_buf_relse(bp); 346 xfs_buf_relse(bp);
353 return; 347 return;
354 } 348 }
355 349
356 ASSERT(bp->b_transp == tp); 350 trace_xfs_trans_brelse(bip);
357 bip = bp->b_log_item;
358 ASSERT(bip->bli_item.li_type == XFS_LI_BUF); 351 ASSERT(bip->bli_item.li_type == XFS_LI_BUF);
359 ASSERT(!(bip->bli_flags & XFS_BLI_STALE));
360 ASSERT(!(bip->__bli_format.blf_flags & XFS_BLF_CANCEL));
361 ASSERT(atomic_read(&bip->bli_refcount) > 0); 352 ASSERT(atomic_read(&bip->bli_refcount) > 0);
362 353
363 trace_xfs_trans_brelse(bip);
364
365 /* 354 /*
366 * If the release is just for a recursive lock, 355 * If the release is for a recursive lookup, then decrement the count
367 * then decrement the count and return. 356 * and return.
368 */ 357 */
369 if (bip->bli_recur > 0) { 358 if (bip->bli_recur > 0) {
370 bip->bli_recur--; 359 bip->bli_recur--;
@@ -372,64 +361,24 @@ xfs_trans_brelse(
372 } 361 }
373 362
374 /* 363 /*
375 * If the buffer is dirty within this transaction, we can't 364 * If the buffer is invalidated or dirty in this transaction, we can't
376 * release it until we commit. 365 * release it until we commit.
377 */ 366 */
378 if (test_bit(XFS_LI_DIRTY, &bip->bli_item.li_flags)) 367 if (test_bit(XFS_LI_DIRTY, &bip->bli_item.li_flags))
379 return; 368 return;
380
381 /*
382 * If the buffer has been invalidated, then we can't release
383 * it until the transaction commits to disk unless it is re-dirtied
384 * as part of this transaction. This prevents us from pulling
385 * the item from the AIL before we should.
386 */
387 if (bip->bli_flags & XFS_BLI_STALE) 369 if (bip->bli_flags & XFS_BLI_STALE)
388 return; 370 return;
389 371
390 ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED));
391
392 /* 372 /*
393 * Free up the log item descriptor tracking the released item. 373 * Unlink the log item from the transaction and clear the hold flag, if
374 * set. We wouldn't want the next user of the buffer to get confused.
394 */ 375 */
376 ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED));
395 xfs_trans_del_item(&bip->bli_item); 377 xfs_trans_del_item(&bip->bli_item);
378 bip->bli_flags &= ~XFS_BLI_HOLD;
396 379
397 /* 380 /* drop the reference to the bli */
398 * Clear the hold flag in the buf log item if it is set. 381 xfs_buf_item_put(bip);
399 * We wouldn't want the next user of the buffer to
400 * get confused.
401 */
402 if (bip->bli_flags & XFS_BLI_HOLD) {
403 bip->bli_flags &= ~XFS_BLI_HOLD;
404 }
405
406 /*
407 * Drop our reference to the buf log item.
408 */
409 freed = atomic_dec_and_test(&bip->bli_refcount);
410
411 /*
412 * If the buf item is not tracking data in the log, then we must free it
413 * before releasing the buffer back to the free pool.
414 *
415 * If the fs has shutdown and we dropped the last reference, it may fall
416 * on us to release a (possibly dirty) bli if it never made it to the
417 * AIL (e.g., the aborted unpin already happened and didn't release it
418 * due to our reference). Since we're already shutdown and need
419 * ail_lock, just force remove from the AIL and release the bli here.
420 */
421 if (XFS_FORCED_SHUTDOWN(tp->t_mountp) && freed) {
422 xfs_trans_ail_remove(&bip->bli_item, SHUTDOWN_LOG_IO_ERROR);
423 xfs_buf_item_relse(bp);
424 } else if (!(bip->bli_flags & XFS_BLI_DIRTY)) {
425/***
426 ASSERT(bp->b_pincount == 0);
427***/
428 ASSERT(atomic_read(&bip->bli_refcount) == 0);
429 ASSERT(!test_bit(XFS_LI_IN_AIL, &bip->bli_item.li_flags));
430 ASSERT(!(bip->bli_flags & XFS_BLI_INODE_ALLOC_BUF));
431 xfs_buf_item_relse(bp);
432 }
433 382
434 bp->b_transp = NULL; 383 bp->b_transp = NULL;
435 xfs_buf_relse(bp); 384 xfs_buf_relse(bp);
diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h
index e6964e97acdd..53c088247d36 100644
--- a/include/acpi/acconfig.h
+++ b/include/acpi/acconfig.h
@@ -173,11 +173,20 @@
173#define ACPI_RSDP_CHECKSUM_LENGTH 20 173#define ACPI_RSDP_CHECKSUM_LENGTH 20
174#define ACPI_RSDP_XCHECKSUM_LENGTH 36 174#define ACPI_RSDP_XCHECKSUM_LENGTH 36
175 175
176/* SMBus, GSBus and IPMI bidirectional buffer size */ 176/*
177 * SMBus, GSBus and IPMI buffer sizes. All have a 2-byte header,
178 * containing both Status and Length.
179 */
180#define ACPI_SERIAL_HEADER_SIZE 2 /* Common for below. Status and Length fields */
181
182#define ACPI_SMBUS_DATA_SIZE 32
183#define ACPI_SMBUS_BUFFER_SIZE ACPI_SERIAL_HEADER_SIZE + ACPI_SMBUS_DATA_SIZE
184
185#define ACPI_IPMI_DATA_SIZE 64
186#define ACPI_IPMI_BUFFER_SIZE ACPI_SERIAL_HEADER_SIZE + ACPI_IPMI_DATA_SIZE
177 187
178#define ACPI_SMBUS_BUFFER_SIZE 34 188#define ACPI_MAX_GSBUS_DATA_SIZE 255
179#define ACPI_GSBUS_BUFFER_SIZE 34 189#define ACPI_MAX_GSBUS_BUFFER_SIZE ACPI_SERIAL_HEADER_SIZE + ACPI_MAX_GSBUS_DATA_SIZE
180#define ACPI_IPMI_BUFFER_SIZE 66
181 190
182/* _sx_d and _sx_w control methods */ 191/* _sx_d and _sx_w control methods */
183 192
diff --git a/include/acpi/acexcep.h b/include/acpi/acexcep.h
index 856c56ef0143..09f46050961f 100644
--- a/include/acpi/acexcep.h
+++ b/include/acpi/acexcep.h
@@ -171,8 +171,10 @@ struct acpi_exception_info {
171#define AE_AML_LOOP_TIMEOUT EXCEP_AML (0x0021) 171#define AE_AML_LOOP_TIMEOUT EXCEP_AML (0x0021)
172#define AE_AML_UNINITIALIZED_NODE EXCEP_AML (0x0022) 172#define AE_AML_UNINITIALIZED_NODE EXCEP_AML (0x0022)
173#define AE_AML_TARGET_TYPE EXCEP_AML (0x0023) 173#define AE_AML_TARGET_TYPE EXCEP_AML (0x0023)
174#define AE_AML_PROTOCOL EXCEP_AML (0x0024)
175#define AE_AML_BUFFER_LENGTH EXCEP_AML (0x0025)
174 176
175#define AE_CODE_AML_MAX 0x0023 177#define AE_CODE_AML_MAX 0x0025
176 178
177/* 179/*
178 * Internal exceptions used for control 180 * Internal exceptions used for control
@@ -347,7 +349,10 @@ static const struct acpi_exception_info acpi_gbl_exception_names_aml[] = {
347 EXCEP_TXT("AE_AML_UNINITIALIZED_NODE", 349 EXCEP_TXT("AE_AML_UNINITIALIZED_NODE",
348 "A namespace node is uninitialized or unresolved"), 350 "A namespace node is uninitialized or unresolved"),
349 EXCEP_TXT("AE_AML_TARGET_TYPE", 351 EXCEP_TXT("AE_AML_TARGET_TYPE",
350 "A target operand of an incorrect type was encountered") 352 "A target operand of an incorrect type was encountered"),
353 EXCEP_TXT("AE_AML_PROTOCOL", "Violation of a fixed ACPI protocol"),
354 EXCEP_TXT("AE_AML_BUFFER_LENGTH",
355 "The length of the buffer is invalid/incorrect")
351}; 356};
352 357
353static const struct acpi_exception_info acpi_gbl_exception_names_ctrl[] = { 358static const struct acpi_exception_info acpi_gbl_exception_names_ctrl[] = {
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 9566f99cc3c0..0c19b68bf060 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -12,7 +12,7 @@
12 12
13/* Current ACPICA subsystem version in YYYYMMDD format */ 13/* Current ACPICA subsystem version in YYYYMMDD format */
14 14
15#define ACPI_CA_VERSION 0x20180810 15#define ACPI_CA_VERSION 0x20181003
16 16
17#include <acpi/acconfig.h> 17#include <acpi/acconfig.h>
18#include <acpi/actypes.h> 18#include <acpi/actypes.h>
@@ -157,13 +157,6 @@ ACPI_INIT_GLOBAL(u8, acpi_gbl_copy_dsdt_locally, FALSE);
157ACPI_INIT_GLOBAL(u8, acpi_gbl_do_not_use_xsdt, FALSE); 157ACPI_INIT_GLOBAL(u8, acpi_gbl_do_not_use_xsdt, FALSE);
158 158
159/* 159/*
160 * Optionally support group module level code.
161 * NOTE, this is essentially obsolete and will be removed soon
162 * (01/2018).
163 */
164ACPI_INIT_GLOBAL(u8, acpi_gbl_group_module_level_code, FALSE);
165
166/*
167 * Optionally support module level code by parsing an entire table as 160 * Optionally support module level code by parsing an entire table as
168 * a method as it is loaded. Default is TRUE. 161 * a method as it is loaded. Default is TRUE.
169 * NOTE, this is essentially obsolete and will be removed soon 162 * NOTE, this is essentially obsolete and will be removed soon
diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
index 66d1d45fa2e1..d356f802945a 100644
--- a/include/asm-generic/io.h
+++ b/include/asm-generic/io.h
@@ -1026,7 +1026,8 @@ static inline void __iomem *ioremap_wt(phys_addr_t offset, size_t size)
1026#define ioport_map ioport_map 1026#define ioport_map ioport_map
1027static inline void __iomem *ioport_map(unsigned long port, unsigned int nr) 1027static inline void __iomem *ioport_map(unsigned long port, unsigned int nr)
1028{ 1028{
1029 return PCI_IOBASE + (port & MMIO_UPPER_LIMIT); 1029 port &= IO_SPACE_LIMIT;
1030 return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
1030} 1031}
1031#endif 1032#endif
1032 1033
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 7b75ff6e2fce..d7701d466b60 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -68,7 +68,7 @@
68 */ 68 */
69#ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION 69#ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION
70#define TEXT_MAIN .text .text.[0-9a-zA-Z_]* 70#define TEXT_MAIN .text .text.[0-9a-zA-Z_]*
71#define DATA_MAIN .data .data.[0-9a-zA-Z_]* 71#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..LPBX*
72#define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]* 72#define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]*
73#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* 73#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]*
74#define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* 74#define BSS_MAIN .bss .bss.[0-9a-zA-Z_]*
@@ -613,8 +613,8 @@
613 613
614#define EXIT_DATA \ 614#define EXIT_DATA \
615 *(.exit.data .exit.data.*) \ 615 *(.exit.data .exit.data.*) \
616 *(.fini_array) \ 616 *(.fini_array .fini_array.*) \
617 *(.dtors) \ 617 *(.dtors .dtors.*) \
618 MEM_DISCARD(exit.data*) \ 618 MEM_DISCARD(exit.data*) \
619 MEM_DISCARD(exit.rodata*) 619 MEM_DISCARD(exit.rodata*)
620 620
diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index 989f8e52864d..971bb7853776 100644
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -87,9 +87,10 @@ struct drm_client_dev {
87 struct drm_file *file; 87 struct drm_file *file;
88}; 88};
89 89
90int drm_client_new(struct drm_device *dev, struct drm_client_dev *client, 90int drm_client_init(struct drm_device *dev, struct drm_client_dev *client,
91 const char *name, const struct drm_client_funcs *funcs); 91 const char *name, const struct drm_client_funcs *funcs);
92void drm_client_release(struct drm_client_dev *client); 92void drm_client_release(struct drm_client_dev *client);
93void drm_client_add(struct drm_client_dev *client);
93 94
94void drm_client_dev_unregister(struct drm_device *dev); 95void drm_client_dev_unregister(struct drm_device *dev);
95void drm_client_dev_hotplug(struct drm_device *dev); 96void drm_client_dev_hotplug(struct drm_device *dev);
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 46a8009784df..152b3055e9e1 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -675,7 +675,7 @@ static inline bool drm_core_check_feature(struct drm_device *dev, int feature)
675static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev) 675static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev)
676{ 676{
677 return drm_core_check_feature(dev, DRIVER_ATOMIC) || 677 return drm_core_check_feature(dev, DRIVER_ATOMIC) ||
678 dev->mode_config.funcs->atomic_commit != NULL; 678 (dev->mode_config.funcs && dev->mode_config.funcs->atomic_commit != NULL);
679} 679}
680 680
681 681
diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
index 582a0ec0aa70..777814755fa6 100644
--- a/include/drm/drm_panel.h
+++ b/include/drm/drm_panel.h
@@ -89,7 +89,6 @@ struct drm_panel {
89 struct drm_device *drm; 89 struct drm_device *drm;
90 struct drm_connector *connector; 90 struct drm_connector *connector;
91 struct device *dev; 91 struct device *dev;
92 struct device_link *link;
93 92
94 const struct drm_panel_funcs *funcs; 93 const struct drm_panel_funcs *funcs;
95 94
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index d6869e0e2b64..6980014357d4 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -54,7 +54,7 @@ struct blk_stat_callback;
54 * Maximum number of blkcg policies allowed to be registered concurrently. 54 * Maximum number of blkcg policies allowed to be registered concurrently.
55 * Defined here to simplify include dependency. 55 * Defined here to simplify include dependency.
56 */ 56 */
57#define BLKCG_MAX_POLS 3 57#define BLKCG_MAX_POLS 5
58 58
59typedef void (rq_end_io_fn)(struct request *, blk_status_t); 59typedef void (rq_end_io_fn)(struct request *, blk_status_t);
60 60
diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
index ff20b677fb9f..22254c1fe1c5 100644
--- a/include/linux/cgroup-defs.h
+++ b/include/linux/cgroup-defs.h
@@ -412,6 +412,7 @@ struct cgroup {
412 * specific task are charged to the dom_cgrp. 412 * specific task are charged to the dom_cgrp.
413 */ 413 */
414 struct cgroup *dom_cgrp; 414 struct cgroup *dom_cgrp;
415 struct cgroup *old_dom_cgrp; /* used while enabling threaded */
415 416
416 /* per-cpu recursive resource statistics */ 417 /* per-cpu recursive resource statistics */
417 struct cgroup_rstat_cpu __percpu *rstat_cpu; 418 struct cgroup_rstat_cpu __percpu *rstat_cpu;
diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 763bbad1e258..4d36b27214fd 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -79,20 +79,6 @@
79#define __noretpoline __attribute__((indirect_branch("keep"))) 79#define __noretpoline __attribute__((indirect_branch("keep")))
80#endif 80#endif
81 81
82/*
83 * it doesn't make sense on ARM (currently the only user of __naked)
84 * to trace naked functions because then mcount is called without
85 * stack and frame pointer being set up and there is no chance to
86 * restore the lr register to the value before mcount was called.
87 *
88 * The asm() bodies of naked functions often depend on standard calling
89 * conventions, therefore they must be noinline and noclone.
90 *
91 * GCC 4.[56] currently fail to enforce this, so we must do so ourselves.
92 * See GCC PR44290.
93 */
94#define __naked __attribute__((naked)) noinline __noclone notrace
95
96#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) 82#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
97 83
98#define __optimize(level) __attribute__((__optimize__(level))) 84#define __optimize(level) __attribute__((__optimize__(level)))
diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h
index 3525c179698c..db192becfec4 100644
--- a/include/linux/compiler_types.h
+++ b/include/linux/compiler_types.h
@@ -226,6 +226,14 @@ struct ftrace_likely_data {
226#define notrace __attribute__((no_instrument_function)) 226#define notrace __attribute__((no_instrument_function))
227#endif 227#endif
228 228
229/*
230 * it doesn't make sense on ARM (currently the only user of __naked)
231 * to trace naked functions because then mcount is called without
232 * stack and frame pointer being set up and there is no chance to
233 * restore the lr register to the value before mcount was called.
234 */
235#define __naked __attribute__((naked)) notrace
236
229#define __compiler_offsetof(a, b) __builtin_offsetof(a, b) 237#define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
230 238
231/* 239/*
diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
index 8942e61f0028..8ab5df769923 100644
--- a/include/linux/fpga/fpga-mgr.h
+++ b/include/linux/fpga/fpga-mgr.h
@@ -53,12 +53,20 @@ enum fpga_mgr_states {
53 FPGA_MGR_STATE_OPERATING, 53 FPGA_MGR_STATE_OPERATING,
54}; 54};
55 55
56/* 56/**
57 * FPGA Manager flags 57 * DOC: FPGA Manager flags
58 * FPGA_MGR_PARTIAL_RECONFIG: do partial reconfiguration if supported 58 *
59 * FPGA_MGR_EXTERNAL_CONFIG: FPGA has been configured prior to Linux booting 59 * Flags used in the &fpga_image_info->flags field
60 * FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first 60 *
61 * FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed 61 * %FPGA_MGR_PARTIAL_RECONFIG: do partial reconfiguration if supported
62 *
63 * %FPGA_MGR_EXTERNAL_CONFIG: FPGA has been configured prior to Linux booting
64 *
65 * %FPGA_MGR_ENCRYPTED_BITSTREAM: indicates bitstream is encrypted
66 *
67 * %FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first
68 *
69 * %FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed
62 */ 70 */
63#define FPGA_MGR_PARTIAL_RECONFIG BIT(0) 71#define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
64#define FPGA_MGR_EXTERNAL_CONFIG BIT(1) 72#define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 33322702c910..897eae8faee1 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1763,6 +1763,7 @@ struct file_operations {
1763 u64); 1763 u64);
1764 int (*dedupe_file_range)(struct file *, loff_t, struct file *, loff_t, 1764 int (*dedupe_file_range)(struct file *, loff_t, struct file *, loff_t,
1765 u64); 1765 u64);
1766 int (*fadvise)(struct file *, loff_t, loff_t, int);
1766} __randomize_layout; 1767} __randomize_layout;
1767 1768
1768struct inode_operations { 1769struct inode_operations {
@@ -1827,8 +1828,10 @@ extern ssize_t vfs_copy_file_range(struct file *, loff_t , struct file *,
1827extern int vfs_clone_file_prep_inodes(struct inode *inode_in, loff_t pos_in, 1828extern int vfs_clone_file_prep_inodes(struct inode *inode_in, loff_t pos_in,
1828 struct inode *inode_out, loff_t pos_out, 1829 struct inode *inode_out, loff_t pos_out,
1829 u64 *len, bool is_dedupe); 1830 u64 *len, bool is_dedupe);
1831extern int do_clone_file_range(struct file *file_in, loff_t pos_in,
1832 struct file *file_out, loff_t pos_out, u64 len);
1830extern int vfs_clone_file_range(struct file *file_in, loff_t pos_in, 1833extern int vfs_clone_file_range(struct file *file_in, loff_t pos_in,
1831 struct file *file_out, loff_t pos_out, u64 len); 1834 struct file *file_out, loff_t pos_out, u64 len);
1832extern int vfs_dedupe_file_range_compare(struct inode *src, loff_t srcoff, 1835extern int vfs_dedupe_file_range_compare(struct inode *src, loff_t srcoff,
1833 struct inode *dest, loff_t destoff, 1836 struct inode *dest, loff_t destoff,
1834 loff_t len, bool *is_same); 1837 loff_t len, bool *is_same);
@@ -2772,19 +2775,6 @@ static inline void file_end_write(struct file *file)
2772 __sb_end_write(file_inode(file)->i_sb, SB_FREEZE_WRITE); 2775 __sb_end_write(file_inode(file)->i_sb, SB_FREEZE_WRITE);
2773} 2776}
2774 2777
2775static inline int do_clone_file_range(struct file *file_in, loff_t pos_in,
2776 struct file *file_out, loff_t pos_out,
2777 u64 len)
2778{
2779 int ret;
2780
2781 file_start_write(file_out);
2782 ret = vfs_clone_file_range(file_in, pos_in, file_out, pos_out, len);
2783 file_end_write(file_out);
2784
2785 return ret;
2786}
2787
2788/* 2778/*
2789 * get_write_access() gets write permission for a file. 2779 * get_write_access() gets write permission for a file.
2790 * put_write_access() releases this write permission. 2780 * put_write_access() releases this write permission.
@@ -3459,4 +3449,8 @@ static inline bool dir_relax_shared(struct inode *inode)
3459extern bool path_noexec(const struct path *path); 3449extern bool path_noexec(const struct path *path);
3460extern void inode_nohighmem(struct inode *inode); 3450extern void inode_nohighmem(struct inode *inode);
3461 3451
3452/* mm/fadvise.c */
3453extern int vfs_fadvise(struct file *file, loff_t offset, loff_t len,
3454 int advice);
3455
3462#endif /* _LINUX_FS_H */ 3456#endif /* _LINUX_FS_H */
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index 57864422a2c8..25c08c6c7f99 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -83,10 +83,10 @@ struct partition {
83} __attribute__((packed)); 83} __attribute__((packed));
84 84
85struct disk_stats { 85struct disk_stats {
86 u64 nsecs[NR_STAT_GROUPS];
86 unsigned long sectors[NR_STAT_GROUPS]; 87 unsigned long sectors[NR_STAT_GROUPS];
87 unsigned long ios[NR_STAT_GROUPS]; 88 unsigned long ios[NR_STAT_GROUPS];
88 unsigned long merges[NR_STAT_GROUPS]; 89 unsigned long merges[NR_STAT_GROUPS];
89 unsigned long ticks[NR_STAT_GROUPS];
90 unsigned long io_ticks; 90 unsigned long io_ticks;
91 unsigned long time_in_queue; 91 unsigned long time_in_queue;
92}; 92};
@@ -354,6 +354,9 @@ static inline void free_part_stats(struct hd_struct *part)
354 354
355#endif /* CONFIG_SMP */ 355#endif /* CONFIG_SMP */
356 356
357#define part_stat_read_msecs(part, which) \
358 div_u64(part_stat_read(part, nsecs[which]), NSEC_PER_MSEC)
359
357#define part_stat_read_accum(part, field) \ 360#define part_stat_read_accum(part, field) \
358 (part_stat_read(part, field[STAT_READ]) + \ 361 (part_stat_read(part, field[STAT_READ]) + \
359 part_stat_read(part, field[STAT_WRITE]) + \ 362 part_stat_read(part, field[STAT_WRITE]) + \
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 0ea328e71ec9..a4d5eb37744a 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -95,6 +95,13 @@ struct gpio_irq_chip {
95 unsigned int num_parents; 95 unsigned int num_parents;
96 96
97 /** 97 /**
98 * @parent_irq:
99 *
100 * For use by gpiochip_set_cascaded_irqchip()
101 */
102 unsigned int parent_irq;
103
104 /**
98 * @parents: 105 * @parents:
99 * 106 *
100 * A list of interrupt parents of a GPIO chip. This is owned by the 107 * A list of interrupt parents of a GPIO chip. This is owned by the
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 834e6461a690..d44a78362942 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -526,6 +526,7 @@ struct hid_input {
526 const char *name; 526 const char *name;
527 bool registered; 527 bool registered;
528 struct list_head reports; /* the list of reports */ 528 struct list_head reports; /* the list of reports */
529 unsigned int application; /* application usage for this input */
529}; 530};
530 531
531enum hid_type { 532enum hid_type {
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 6b68e345f0ca..087fd5f48c91 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -140,6 +140,8 @@ pte_t *huge_pte_alloc(struct mm_struct *mm,
140pte_t *huge_pte_offset(struct mm_struct *mm, 140pte_t *huge_pte_offset(struct mm_struct *mm,
141 unsigned long addr, unsigned long sz); 141 unsigned long addr, unsigned long sz);
142int huge_pmd_unshare(struct mm_struct *mm, unsigned long *addr, pte_t *ptep); 142int huge_pmd_unshare(struct mm_struct *mm, unsigned long *addr, pte_t *ptep);
143void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
144 unsigned long *start, unsigned long *end);
143struct page *follow_huge_addr(struct mm_struct *mm, unsigned long address, 145struct page *follow_huge_addr(struct mm_struct *mm, unsigned long address,
144 int write); 146 int write);
145struct page *follow_huge_pd(struct vm_area_struct *vma, 147struct page *follow_huge_pd(struct vm_area_struct *vma,
@@ -170,6 +172,18 @@ static inline unsigned long hugetlb_total_pages(void)
170 return 0; 172 return 0;
171} 173}
172 174
175static inline int huge_pmd_unshare(struct mm_struct *mm, unsigned long *addr,
176 pte_t *ptep)
177{
178 return 0;
179}
180
181static inline void adjust_range_if_pmd_sharing_possible(
182 struct vm_area_struct *vma,
183 unsigned long *start, unsigned long *end)
184{
185}
186
173#define follow_hugetlb_page(m,v,p,vs,a,b,i,w,n) ({ BUG(); 0; }) 187#define follow_hugetlb_page(m,v,p,vs,a,b,i,w,n) ({ BUG(); 0; })
174#define follow_huge_addr(mm, addr, write) ERR_PTR(-EINVAL) 188#define follow_huge_addr(mm, addr, write) ERR_PTR(-EINVAL)
175#define copy_hugetlb_page_range(src, dst, vma) ({ BUG(); 0; }) 189#define copy_hugetlb_page_range(src, dst, vma) ({ BUG(); 0; })
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 0205aee44ded..c926698040e0 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -733,8 +733,6 @@ bool kvm_vcpu_wake_up(struct kvm_vcpu *vcpu);
733void kvm_vcpu_kick(struct kvm_vcpu *vcpu); 733void kvm_vcpu_kick(struct kvm_vcpu *vcpu);
734int kvm_vcpu_yield_to(struct kvm_vcpu *target); 734int kvm_vcpu_yield_to(struct kvm_vcpu *target);
735void kvm_vcpu_on_spin(struct kvm_vcpu *vcpu, bool usermode_vcpu_not_eligible); 735void kvm_vcpu_on_spin(struct kvm_vcpu *vcpu, bool usermode_vcpu_not_eligible);
736void kvm_load_guest_fpu(struct kvm_vcpu *vcpu);
737void kvm_put_guest_fpu(struct kvm_vcpu *vcpu);
738 736
739void kvm_flush_remote_tlbs(struct kvm *kvm); 737void kvm_flush_remote_tlbs(struct kvm *kvm);
740void kvm_reload_remote_mmus(struct kvm *kvm); 738void kvm_reload_remote_mmus(struct kvm *kvm);
diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
index 8a125701ef7b..50bed4f89c1a 100644
--- a/include/linux/mfd/da9063/pdata.h
+++ b/include/linux/mfd/da9063/pdata.h
@@ -21,7 +21,7 @@
21/* 21/*
22 * Regulator configuration 22 * Regulator configuration
23 */ 23 */
24/* DA9063 regulator IDs */ 24/* DA9063 and DA9063L regulator IDs */
25enum { 25enum {
26 /* BUCKs */ 26 /* BUCKs */
27 DA9063_ID_BCORE1, 27 DA9063_ID_BCORE1,
@@ -37,18 +37,20 @@ enum {
37 DA9063_ID_BMEM_BIO_MERGED, 37 DA9063_ID_BMEM_BIO_MERGED,
38 /* When two BUCKs are merged, they cannot be reused separately */ 38 /* When two BUCKs are merged, they cannot be reused separately */
39 39
40 /* LDOs */ 40 /* LDOs on both DA9063 and DA9063L */
41 DA9063_ID_LDO3,
42 DA9063_ID_LDO7,
43 DA9063_ID_LDO8,
44 DA9063_ID_LDO9,
45 DA9063_ID_LDO11,
46
47 /* DA9063-only LDOs */
41 DA9063_ID_LDO1, 48 DA9063_ID_LDO1,
42 DA9063_ID_LDO2, 49 DA9063_ID_LDO2,
43 DA9063_ID_LDO3,
44 DA9063_ID_LDO4, 50 DA9063_ID_LDO4,
45 DA9063_ID_LDO5, 51 DA9063_ID_LDO5,
46 DA9063_ID_LDO6, 52 DA9063_ID_LDO6,
47 DA9063_ID_LDO7,
48 DA9063_ID_LDO8,
49 DA9063_ID_LDO9,
50 DA9063_ID_LDO10, 53 DA9063_ID_LDO10,
51 DA9063_ID_LDO11,
52}; 54};
53 55
54/* Regulators platform data */ 56/* Regulators platform data */
diff --git a/include/linux/mfd/rohm-bd718x7.h b/include/linux/mfd/rohm-bd718x7.h
index a528747f8aed..e8338e5dc10b 100644
--- a/include/linux/mfd/rohm-bd718x7.h
+++ b/include/linux/mfd/rohm-bd718x7.h
@@ -78,9 +78,9 @@ enum {
78 BD71837_REG_TRANS_COND0 = 0x1F, 78 BD71837_REG_TRANS_COND0 = 0x1F,
79 BD71837_REG_TRANS_COND1 = 0x20, 79 BD71837_REG_TRANS_COND1 = 0x20,
80 BD71837_REG_VRFAULTEN = 0x21, 80 BD71837_REG_VRFAULTEN = 0x21,
81 BD71837_REG_MVRFLTMASK0 = 0x22, 81 BD718XX_REG_MVRFLTMASK0 = 0x22,
82 BD71837_REG_MVRFLTMASK1 = 0x23, 82 BD718XX_REG_MVRFLTMASK1 = 0x23,
83 BD71837_REG_MVRFLTMASK2 = 0x24, 83 BD718XX_REG_MVRFLTMASK2 = 0x24,
84 BD71837_REG_RCVCFG = 0x25, 84 BD71837_REG_RCVCFG = 0x25,
85 BD71837_REG_RCVNUM = 0x26, 85 BD71837_REG_RCVNUM = 0x26,
86 BD71837_REG_PWRONCONFIG0 = 0x27, 86 BD71837_REG_PWRONCONFIG0 = 0x27,
@@ -159,6 +159,33 @@ enum {
159#define BUCK8_MASK 0x3F 159#define BUCK8_MASK 0x3F
160#define BUCK8_DEFAULT 0x1E 160#define BUCK8_DEFAULT 0x1E
161 161
162/* BD718XX Voltage monitoring masks */
163#define BD718XX_BUCK1_VRMON80 0x1
164#define BD718XX_BUCK1_VRMON130 0x2
165#define BD718XX_BUCK2_VRMON80 0x4
166#define BD718XX_BUCK2_VRMON130 0x8
167#define BD718XX_1ST_NODVS_BUCK_VRMON80 0x1
168#define BD718XX_1ST_NODVS_BUCK_VRMON130 0x2
169#define BD718XX_2ND_NODVS_BUCK_VRMON80 0x4
170#define BD718XX_2ND_NODVS_BUCK_VRMON130 0x8
171#define BD718XX_3RD_NODVS_BUCK_VRMON80 0x10
172#define BD718XX_3RD_NODVS_BUCK_VRMON130 0x20
173#define BD718XX_4TH_NODVS_BUCK_VRMON80 0x40
174#define BD718XX_4TH_NODVS_BUCK_VRMON130 0x80
175#define BD718XX_LDO1_VRMON80 0x1
176#define BD718XX_LDO2_VRMON80 0x2
177#define BD718XX_LDO3_VRMON80 0x4
178#define BD718XX_LDO4_VRMON80 0x8
179#define BD718XX_LDO5_VRMON80 0x10
180#define BD718XX_LDO6_VRMON80 0x20
181
182/* BD71837 specific voltage monitoring masks */
183#define BD71837_BUCK3_VRMON80 0x10
184#define BD71837_BUCK3_VRMON130 0x20
185#define BD71837_BUCK4_VRMON80 0x40
186#define BD71837_BUCK4_VRMON130 0x80
187#define BD71837_LDO7_VRMON80 0x40
188
162/* BD71837_REG_IRQ bits */ 189/* BD71837_REG_IRQ bits */
163#define IRQ_SWRST 0x40 190#define IRQ_SWRST 0x40
164#define IRQ_PWRON_S 0x20 191#define IRQ_PWRON_S 0x20
diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
index 7a452716de4b..66d94b4557cf 100644
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@ -362,8 +362,8 @@ struct mlx5_frag_buf {
362struct mlx5_frag_buf_ctrl { 362struct mlx5_frag_buf_ctrl {
363 struct mlx5_frag_buf frag_buf; 363 struct mlx5_frag_buf frag_buf;
364 u32 sz_m1; 364 u32 sz_m1;
365 u32 frag_sz_m1; 365 u16 frag_sz_m1;
366 u32 strides_offset; 366 u16 strides_offset;
367 u8 log_sz; 367 u8 log_sz;
368 u8 log_stride; 368 u8 log_stride;
369 u8 log_frag_strides; 369 u8 log_frag_strides;
@@ -995,7 +995,7 @@ static inline u32 mlx5_base_mkey(const u32 key)
995} 995}
996 996
997static inline void mlx5_fill_fbc_offset(u8 log_stride, u8 log_sz, 997static inline void mlx5_fill_fbc_offset(u8 log_stride, u8 log_sz,
998 u32 strides_offset, 998 u16 strides_offset,
999 struct mlx5_frag_buf_ctrl *fbc) 999 struct mlx5_frag_buf_ctrl *fbc)
1000{ 1000{
1001 fbc->log_stride = log_stride; 1001 fbc->log_stride = log_stride;
@@ -1052,7 +1052,7 @@ int mlx5_cmd_free_uar(struct mlx5_core_dev *dev, u32 uarn);
1052void mlx5_health_cleanup(struct mlx5_core_dev *dev); 1052void mlx5_health_cleanup(struct mlx5_core_dev *dev);
1053int mlx5_health_init(struct mlx5_core_dev *dev); 1053int mlx5_health_init(struct mlx5_core_dev *dev);
1054void mlx5_start_health_poll(struct mlx5_core_dev *dev); 1054void mlx5_start_health_poll(struct mlx5_core_dev *dev);
1055void mlx5_stop_health_poll(struct mlx5_core_dev *dev); 1055void mlx5_stop_health_poll(struct mlx5_core_dev *dev, bool disable_health);
1056void mlx5_drain_health_wq(struct mlx5_core_dev *dev); 1056void mlx5_drain_health_wq(struct mlx5_core_dev *dev);
1057void mlx5_trigger_health_work(struct mlx5_core_dev *dev); 1057void mlx5_trigger_health_work(struct mlx5_core_dev *dev);
1058void mlx5_drain_health_recovery(struct mlx5_core_dev *dev); 1058void mlx5_drain_health_recovery(struct mlx5_core_dev *dev);
diff --git a/include/linux/mlx5/transobj.h b/include/linux/mlx5/transobj.h
index 83a33a1873a6..7f5ca2cd3a32 100644
--- a/include/linux/mlx5/transobj.h
+++ b/include/linux/mlx5/transobj.h
@@ -90,6 +90,8 @@ struct mlx5_hairpin {
90 90
91 u32 *rqn; 91 u32 *rqn;
92 u32 *sqn; 92 u32 *sqn;
93
94 bool peer_gone;
93}; 95};
94 96
95struct mlx5_hairpin * 97struct mlx5_hairpin *
diff --git a/include/linux/mm.h b/include/linux/mm.h
index a61ebe8ad4ca..0416a7204be3 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2455,6 +2455,12 @@ static inline struct vm_area_struct *find_exact_vma(struct mm_struct *mm,
2455 return vma; 2455 return vma;
2456} 2456}
2457 2457
2458static inline bool range_in_vma(struct vm_area_struct *vma,
2459 unsigned long start, unsigned long end)
2460{
2461 return (vma && vma->vm_start <= start && end <= vma->vm_end);
2462}
2463
2458#ifdef CONFIG_MMU 2464#ifdef CONFIG_MMU
2459pgprot_t vm_get_page_prot(unsigned long vm_flags); 2465pgprot_t vm_get_page_prot(unsigned long vm_flags);
2460void vma_set_page_prot(struct vm_area_struct *vma); 2466void vma_set_page_prot(struct vm_area_struct *vma);
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index cd2bc939efd0..5ed8f6292a53 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -341,7 +341,7 @@ struct mm_struct {
341 struct { 341 struct {
342 struct vm_area_struct *mmap; /* list of VMAs */ 342 struct vm_area_struct *mmap; /* list of VMAs */
343 struct rb_root mm_rb; 343 struct rb_root mm_rb;
344 u32 vmacache_seqnum; /* per-thread vmacache */ 344 u64 vmacache_seqnum; /* per-thread vmacache */
345#ifdef CONFIG_MMU 345#ifdef CONFIG_MMU
346 unsigned long (*get_unmapped_area) (struct file *filp, 346 unsigned long (*get_unmapped_area) (struct file *filp,
347 unsigned long addr, unsigned long len, 347 unsigned long addr, unsigned long len,
diff --git a/include/linux/mm_types_task.h b/include/linux/mm_types_task.h
index 5fe87687664c..d7016dcb245e 100644
--- a/include/linux/mm_types_task.h
+++ b/include/linux/mm_types_task.h
@@ -32,7 +32,7 @@
32#define VMACACHE_MASK (VMACACHE_SIZE - 1) 32#define VMACACHE_MASK (VMACACHE_SIZE - 1)
33 33
34struct vmacache { 34struct vmacache {
35 u32 seqnum; 35 u64 seqnum;
36 struct vm_area_struct *vmas[VMACACHE_SIZE]; 36 struct vm_area_struct *vmas[VMACACHE_SIZE];
37}; 37};
38 38
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 1e22d96734e0..d4b0c79d2924 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -668,16 +668,6 @@ typedef struct pglist_data {
668 wait_queue_head_t kcompactd_wait; 668 wait_queue_head_t kcompactd_wait;
669 struct task_struct *kcompactd; 669 struct task_struct *kcompactd;
670#endif 670#endif
671#ifdef CONFIG_NUMA_BALANCING
672 /* Lock serializing the migrate rate limiting window */
673 spinlock_t numabalancing_migrate_lock;
674
675 /* Rate limiting time interval */
676 unsigned long numabalancing_migrate_next_window;
677
678 /* Number of pages migrated during the rate limiting time interval */
679 unsigned long numabalancing_migrate_nr_pages;
680#endif
681 /* 671 /*
682 * This is a per-node reserve of pages that are not available 672 * This is a per-node reserve of pages that are not available
683 * to userspace allocations. 673 * to userspace allocations.
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 1298a7daa57d..01797cb4587e 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -754,6 +754,7 @@ struct tb_service_id {
754 * struct typec_device_id - USB Type-C alternate mode identifiers 754 * struct typec_device_id - USB Type-C alternate mode identifiers
755 * @svid: Standard or Vendor ID 755 * @svid: Standard or Vendor ID
756 * @mode: Mode index 756 * @mode: Mode index
757 * @driver_data: Driver specific data
757 */ 758 */
758struct typec_device_id { 759struct typec_device_id {
759 __u16 svid; 760 __u16 svid;
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index ca5ab98053c8..d837dad24b4c 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1730,6 +1730,8 @@ enum netdev_priv_flags {
1730 * switch driver and used to set the phys state of the 1730 * switch driver and used to set the phys state of the
1731 * switch port. 1731 * switch port.
1732 * 1732 *
1733 * @wol_enabled: Wake-on-LAN is enabled
1734 *
1733 * FIXME: cleanup struct net_device such that network protocol info 1735 * FIXME: cleanup struct net_device such that network protocol info
1734 * moves out. 1736 * moves out.
1735 */ 1737 */
@@ -2014,6 +2016,7 @@ struct net_device {
2014 struct lock_class_key *qdisc_tx_busylock; 2016 struct lock_class_key *qdisc_tx_busylock;
2015 struct lock_class_key *qdisc_running_key; 2017 struct lock_class_key *qdisc_running_key;
2016 bool proto_down; 2018 bool proto_down;
2019 unsigned wol_enabled:1;
2017}; 2020};
2018#define to_net_dev(d) container_of(d, struct net_device, dev) 2021#define to_net_dev(d) container_of(d, struct net_device, dev)
2019 2022
@@ -2455,6 +2458,13 @@ struct netdev_notifier_info {
2455 struct netlink_ext_ack *extack; 2458 struct netlink_ext_ack *extack;
2456}; 2459};
2457 2460
2461struct netdev_notifier_info_ext {
2462 struct netdev_notifier_info info; /* must be first */
2463 union {
2464 u32 mtu;
2465 } ext;
2466};
2467
2458struct netdev_notifier_change_info { 2468struct netdev_notifier_change_info {
2459 struct netdev_notifier_info info; /* must be first */ 2469 struct netdev_notifier_info info; /* must be first */
2460 unsigned int flags_changed; 2470 unsigned int flags_changed;
diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h
index 07efffd0c759..bbe99d2b28b4 100644
--- a/include/linux/netfilter.h
+++ b/include/linux/netfilter.h
@@ -215,6 +215,8 @@ static inline int nf_hook(u_int8_t pf, unsigned int hook, struct net *net,
215 break; 215 break;
216 case NFPROTO_ARP: 216 case NFPROTO_ARP:
217#ifdef CONFIG_NETFILTER_FAMILY_ARP 217#ifdef CONFIG_NETFILTER_FAMILY_ARP
218 if (WARN_ON_ONCE(hook >= ARRAY_SIZE(net->nf.hooks_arp)))
219 break;
218 hook_head = rcu_dereference(net->nf.hooks_arp[hook]); 220 hook_head = rcu_dereference(net->nf.hooks_arp[hook]);
219#endif 221#endif
220 break; 222 break;
diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h
index 67662d01130a..3ef82d3a78db 100644
--- a/include/linux/netpoll.h
+++ b/include/linux/netpoll.h
@@ -49,8 +49,9 @@ struct netpoll_info {
49}; 49};
50 50
51#ifdef CONFIG_NETPOLL 51#ifdef CONFIG_NETPOLL
52extern void netpoll_poll_disable(struct net_device *dev); 52void netpoll_poll_dev(struct net_device *dev);
53extern void netpoll_poll_enable(struct net_device *dev); 53void netpoll_poll_disable(struct net_device *dev);
54void netpoll_poll_enable(struct net_device *dev);
54#else 55#else
55static inline void netpoll_poll_disable(struct net_device *dev) { return; } 56static inline void netpoll_poll_disable(struct net_device *dev) { return; }
56static inline void netpoll_poll_enable(struct net_device *dev) { return; } 57static inline void netpoll_poll_enable(struct net_device *dev) { return; }
diff --git a/include/linux/pci.h b/include/linux/pci.h
index e72ca8dd6241..6925828f9f25 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1235,6 +1235,9 @@ void pci_bus_remove_resources(struct pci_bus *bus);
1235int devm_request_pci_bus_resources(struct device *dev, 1235int devm_request_pci_bus_resources(struct device *dev,
1236 struct list_head *resources); 1236 struct list_head *resources);
1237 1237
1238/* Temporary until new and working PCI SBR API in place */
1239int pci_bridge_secondary_bus_reset(struct pci_dev *dev);
1240
1238#define pci_bus_for_each_resource(bus, res, i) \ 1241#define pci_bus_for_each_resource(bus, res, i) \
1239 for (i = 0; \ 1242 for (i = 0; \
1240 (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \ 1243 (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \
diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h
index 10f92e1d8e7b..bf309ff6f244 100644
--- a/include/linux/perf/arm_pmu.h
+++ b/include/linux/perf/arm_pmu.h
@@ -99,6 +99,7 @@ struct arm_pmu {
99 void (*stop)(struct arm_pmu *); 99 void (*stop)(struct arm_pmu *);
100 void (*reset)(void *); 100 void (*reset)(void *);
101 int (*map_event)(struct perf_event *event); 101 int (*map_event)(struct perf_event *event);
102 int (*filter_match)(struct perf_event *event);
102 int num_events; 103 int num_events;
103 bool secure_access; /* 32-bit ARM only */ 104 bool secure_access; /* 32-bit ARM only */
104#define ARMV8_PMUV3_MAX_COMMON_EVENTS 0x40 105#define ARMV8_PMUV3_MAX_COMMON_EVENTS 0x40
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 1a9f38f27f65..c7c081dc6034 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -40,6 +40,7 @@ struct platform_device {
40 40
41#define platform_get_device_id(pdev) ((pdev)->id_entry) 41#define platform_get_device_id(pdev) ((pdev)->id_entry)
42 42
43#define dev_is_platform(dev) ((dev)->bus == &platform_bus_type)
43#define to_platform_device(x) container_of((x), struct platform_device, dev) 44#define to_platform_device(x) container_of((x), struct platform_device, dev)
44 45
45extern int platform_device_register(struct platform_device *); 46extern int platform_device_register(struct platform_device *);
diff --git a/include/linux/regulator/machine.h b/include/linux/regulator/machine.h
index 3468703d663a..a459a5e973a7 100644
--- a/include/linux/regulator/machine.h
+++ b/include/linux/regulator/machine.h
@@ -48,9 +48,9 @@ struct regulator;
48 * DISABLE_IN_SUSPEND - turn off regulator in suspend states 48 * DISABLE_IN_SUSPEND - turn off regulator in suspend states
49 * ENABLE_IN_SUSPEND - keep regulator on in suspend states 49 * ENABLE_IN_SUSPEND - keep regulator on in suspend states
50 */ 50 */
51#define DO_NOTHING_IN_SUSPEND (-1) 51#define DO_NOTHING_IN_SUSPEND 0
52#define DISABLE_IN_SUSPEND 0 52#define DISABLE_IN_SUSPEND 1
53#define ENABLE_IN_SUSPEND 1 53#define ENABLE_IN_SUSPEND 2
54 54
55/* Regulator active discharge flags */ 55/* Regulator active discharge flags */
56enum regulator_active_discharge { 56enum regulator_active_discharge {
diff --git a/include/linux/serial_sci.h b/include/linux/serial_sci.h
index c0e795d95477..1c89611e0e06 100644
--- a/include/linux/serial_sci.h
+++ b/include/linux/serial_sci.h
@@ -36,6 +36,7 @@ enum {
36 SCIx_SH4_SCIF_FIFODATA_REGTYPE, 36 SCIx_SH4_SCIF_FIFODATA_REGTYPE,
37 SCIx_SH7705_SCIF_REGTYPE, 37 SCIx_SH7705_SCIF_REGTYPE,
38 SCIx_HSCIF_REGTYPE, 38 SCIx_HSCIF_REGTYPE,
39 SCIx_RZ_SCIFA_REGTYPE,
39 40
40 SCIx_NR_REGTYPES, 41 SCIx_NR_REGTYPES,
41}; 42};
diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
index b2bd4b4127c4..69ee30456864 100644
--- a/include/linux/spi/spi-mem.h
+++ b/include/linux/spi/spi-mem.h
@@ -81,8 +81,10 @@ enum spi_mem_data_dir {
81 * @dummy.buswidth: number of IO lanes used to transmit the dummy bytes 81 * @dummy.buswidth: number of IO lanes used to transmit the dummy bytes
82 * @data.buswidth: number of IO lanes used to send/receive the data 82 * @data.buswidth: number of IO lanes used to send/receive the data
83 * @data.dir: direction of the transfer 83 * @data.dir: direction of the transfer
84 * @data.buf.in: input buffer 84 * @data.nbytes: number of data bytes to send/receive. Can be zero if the
85 * @data.buf.out: output buffer 85 * operation does not involve transferring data
86 * @data.buf.in: input buffer (must be DMA-able)
87 * @data.buf.out: output buffer (must be DMA-able)
86 */ 88 */
87struct spi_mem_op { 89struct spi_mem_op {
88 struct { 90 struct {
@@ -105,7 +107,6 @@ struct spi_mem_op {
105 u8 buswidth; 107 u8 buswidth;
106 enum spi_mem_data_dir dir; 108 enum spi_mem_data_dir dir;
107 unsigned int nbytes; 109 unsigned int nbytes;
108 /* buf.{in,out} must be DMA-able. */
109 union { 110 union {
110 void *in; 111 void *in;
111 const void *out; 112 const void *out;
diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
index c43e9a01b892..7ddfc65586b0 100644
--- a/include/linux/stmmac.h
+++ b/include/linux/stmmac.h
@@ -30,6 +30,7 @@
30 30
31#define MTL_MAX_RX_QUEUES 8 31#define MTL_MAX_RX_QUEUES 8
32#define MTL_MAX_TX_QUEUES 8 32#define MTL_MAX_TX_QUEUES 8
33#define STMMAC_CH_MAX 8
33 34
34#define STMMAC_RX_COE_NONE 0 35#define STMMAC_RX_COE_NONE 0
35#define STMMAC_RX_COE_TYPE1 1 36#define STMMAC_RX_COE_TYPE1 1
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index 5a28ac9284f0..3f529ad9a9d2 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -251,6 +251,7 @@ static inline bool idle_should_enter_s2idle(void)
251 return unlikely(s2idle_state == S2IDLE_STATE_ENTER); 251 return unlikely(s2idle_state == S2IDLE_STATE_ENTER);
252} 252}
253 253
254extern bool pm_suspend_via_s2idle(void);
254extern void __init pm_states_init(void); 255extern void __init pm_states_init(void);
255extern void s2idle_set_ops(const struct platform_s2idle_ops *ops); 256extern void s2idle_set_ops(const struct platform_s2idle_ops *ops);
256extern void s2idle_wake(void); 257extern void s2idle_wake(void);
@@ -282,6 +283,7 @@ static inline void pm_set_suspend_via_firmware(void) {}
282static inline void pm_set_resume_via_firmware(void) {} 283static inline void pm_set_resume_via_firmware(void) {}
283static inline bool pm_suspend_via_firmware(void) { return false; } 284static inline bool pm_suspend_via_firmware(void) { return false; }
284static inline bool pm_resume_via_firmware(void) { return false; } 285static inline bool pm_resume_via_firmware(void) { return false; }
286static inline bool pm_suspend_via_s2idle(void) { return false; }
285 287
286static inline void suspend_set_ops(const struct platform_suspend_ops *ops) {} 288static inline void suspend_set_ops(const struct platform_suspend_ops *ops) {}
287static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; } 289static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
diff --git a/include/linux/uio.h b/include/linux/uio.h
index 409c845d4cd3..422b1c01ee0d 100644
--- a/include/linux/uio.h
+++ b/include/linux/uio.h
@@ -172,7 +172,7 @@ size_t copy_from_iter_flushcache(void *addr, size_t bytes, struct iov_iter *i)
172static __always_inline __must_check 172static __always_inline __must_check
173size_t copy_to_iter_mcsafe(void *addr, size_t bytes, struct iov_iter *i) 173size_t copy_to_iter_mcsafe(void *addr, size_t bytes, struct iov_iter *i)
174{ 174{
175 if (unlikely(!check_copy_size(addr, bytes, false))) 175 if (unlikely(!check_copy_size(addr, bytes, true)))
176 return 0; 176 return 0;
177 else 177 else
178 return _copy_to_iter_mcsafe(addr, bytes, i); 178 return _copy_to_iter_mcsafe(addr, bytes, i);
diff --git a/include/linux/vga_switcheroo.h b/include/linux/vga_switcheroo.h
index a34539b7f750..7e6ac0114d55 100644
--- a/include/linux/vga_switcheroo.h
+++ b/include/linux/vga_switcheroo.h
@@ -133,15 +133,18 @@ struct vga_switcheroo_handler {
133 * @can_switch: check if the device is in a position to switch now. 133 * @can_switch: check if the device is in a position to switch now.
134 * Mandatory. The client should return false if a user space process 134 * Mandatory. The client should return false if a user space process
135 * has one of its device files open 135 * has one of its device files open
136 * @gpu_bound: notify the client id to audio client when the GPU is bound.
136 * 137 *
137 * Client callbacks. A client can be either a GPU or an audio device on a GPU. 138 * Client callbacks. A client can be either a GPU or an audio device on a GPU.
138 * The @set_gpu_state and @can_switch methods are mandatory, @reprobe may be 139 * The @set_gpu_state and @can_switch methods are mandatory, @reprobe may be
139 * set to NULL. For audio clients, the @reprobe member is bogus. 140 * set to NULL. For audio clients, the @reprobe member is bogus.
141 * OTOH, @gpu_bound is only for audio clients, and not used for GPU clients.
140 */ 142 */
141struct vga_switcheroo_client_ops { 143struct vga_switcheroo_client_ops {
142 void (*set_gpu_state)(struct pci_dev *dev, enum vga_switcheroo_state); 144 void (*set_gpu_state)(struct pci_dev *dev, enum vga_switcheroo_state);
143 void (*reprobe)(struct pci_dev *dev); 145 void (*reprobe)(struct pci_dev *dev);
144 bool (*can_switch)(struct pci_dev *dev); 146 bool (*can_switch)(struct pci_dev *dev);
147 void (*gpu_bound)(struct pci_dev *dev, enum vga_switcheroo_client_id);
145}; 148};
146 149
147#if defined(CONFIG_VGA_SWITCHEROO) 150#if defined(CONFIG_VGA_SWITCHEROO)
diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
index 9397628a1967..cb462f9ab7dd 100644
--- a/include/linux/virtio_net.h
+++ b/include/linux/virtio_net.h
@@ -5,6 +5,24 @@
5#include <linux/if_vlan.h> 5#include <linux/if_vlan.h>
6#include <uapi/linux/virtio_net.h> 6#include <uapi/linux/virtio_net.h>
7 7
8static inline int virtio_net_hdr_set_proto(struct sk_buff *skb,
9 const struct virtio_net_hdr *hdr)
10{
11 switch (hdr->gso_type & ~VIRTIO_NET_HDR_GSO_ECN) {
12 case VIRTIO_NET_HDR_GSO_TCPV4:
13 case VIRTIO_NET_HDR_GSO_UDP:
14 skb->protocol = cpu_to_be16(ETH_P_IP);
15 break;
16 case VIRTIO_NET_HDR_GSO_TCPV6:
17 skb->protocol = cpu_to_be16(ETH_P_IPV6);
18 break;
19 default:
20 return -EINVAL;
21 }
22
23 return 0;
24}
25
8static inline int virtio_net_hdr_to_skb(struct sk_buff *skb, 26static inline int virtio_net_hdr_to_skb(struct sk_buff *skb,
9 const struct virtio_net_hdr *hdr, 27 const struct virtio_net_hdr *hdr,
10 bool little_endian) 28 bool little_endian)
diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 5c7f010676a7..47a3441cf4c4 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -105,7 +105,6 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
105#ifdef CONFIG_DEBUG_VM_VMACACHE 105#ifdef CONFIG_DEBUG_VM_VMACACHE
106 VMACACHE_FIND_CALLS, 106 VMACACHE_FIND_CALLS,
107 VMACACHE_FIND_HITS, 107 VMACACHE_FIND_HITS,
108 VMACACHE_FULL_FLUSHES,
109#endif 108#endif
110#ifdef CONFIG_SWAP 109#ifdef CONFIG_SWAP
111 SWAP_RA, 110 SWAP_RA,
diff --git a/include/linux/vmacache.h b/include/linux/vmacache.h
index 3e9a963edd6a..6fce268a4588 100644
--- a/include/linux/vmacache.h
+++ b/include/linux/vmacache.h
@@ -10,7 +10,6 @@ static inline void vmacache_flush(struct task_struct *tsk)
10 memset(tsk->vmacache.vmas, 0, sizeof(tsk->vmacache.vmas)); 10 memset(tsk->vmacache.vmas, 0, sizeof(tsk->vmacache.vmas));
11} 11}
12 12
13extern void vmacache_flush_all(struct mm_struct *mm);
14extern void vmacache_update(unsigned long addr, struct vm_area_struct *newvma); 13extern void vmacache_update(unsigned long addr, struct vm_area_struct *newvma);
15extern struct vm_area_struct *vmacache_find(struct mm_struct *mm, 14extern struct vm_area_struct *vmacache_find(struct mm_struct *mm,
16 unsigned long addr); 15 unsigned long addr);
@@ -24,10 +23,6 @@ extern struct vm_area_struct *vmacache_find_exact(struct mm_struct *mm,
24static inline void vmacache_invalidate(struct mm_struct *mm) 23static inline void vmacache_invalidate(struct mm_struct *mm)
25{ 24{
26 mm->vmacache_seqnum++; 25 mm->vmacache_seqnum++;
27
28 /* deal with overflows */
29 if (unlikely(mm->vmacache_seqnum == 0))
30 vmacache_flush_all(mm);
31} 26}
32 27
33#endif /* __LINUX_VMACACHE_H */ 28#endif /* __LINUX_VMACACHE_H */
diff --git a/include/media/v4l2-fh.h b/include/media/v4l2-fh.h
index ea73fef8bdc0..8586cfb49828 100644
--- a/include/media/v4l2-fh.h
+++ b/include/media/v4l2-fh.h
@@ -38,10 +38,13 @@ struct v4l2_ctrl_handler;
38 * @prio: priority of the file handler, as defined by &enum v4l2_priority 38 * @prio: priority of the file handler, as defined by &enum v4l2_priority
39 * 39 *
40 * @wait: event' s wait queue 40 * @wait: event' s wait queue
41 * @subscribe_lock: serialise changes to the subscribed list; guarantee that
42 * the add and del event callbacks are orderly called
41 * @subscribed: list of subscribed events 43 * @subscribed: list of subscribed events
42 * @available: list of events waiting to be dequeued 44 * @available: list of events waiting to be dequeued
43 * @navailable: number of available events at @available list 45 * @navailable: number of available events at @available list
44 * @sequence: event sequence number 46 * @sequence: event sequence number
47 *
45 * @m2m_ctx: pointer to &struct v4l2_m2m_ctx 48 * @m2m_ctx: pointer to &struct v4l2_m2m_ctx
46 */ 49 */
47struct v4l2_fh { 50struct v4l2_fh {
@@ -52,6 +55,7 @@ struct v4l2_fh {
52 55
53 /* Events */ 56 /* Events */
54 wait_queue_head_t wait; 57 wait_queue_head_t wait;
58 struct mutex subscribe_lock;
55 struct list_head subscribed; 59 struct list_head subscribed;
56 struct list_head available; 60 struct list_head available;
57 unsigned int navailable; 61 unsigned int navailable;
diff --git a/include/net/bonding.h b/include/net/bonding.h
index a2d058170ea3..b46d68acf701 100644
--- a/include/net/bonding.h
+++ b/include/net/bonding.h
@@ -139,12 +139,6 @@ struct bond_parm_tbl {
139 int mode; 139 int mode;
140}; 140};
141 141
142struct netdev_notify_work {
143 struct delayed_work work;
144 struct net_device *dev;
145 struct netdev_bonding_info bonding_info;
146};
147
148struct slave { 142struct slave {
149 struct net_device *dev; /* first - useful for panic debug */ 143 struct net_device *dev; /* first - useful for panic debug */
150 struct bonding *bond; /* our master */ 144 struct bonding *bond; /* our master */
@@ -172,6 +166,7 @@ struct slave {
172#ifdef CONFIG_NET_POLL_CONTROLLER 166#ifdef CONFIG_NET_POLL_CONTROLLER
173 struct netpoll *np; 167 struct netpoll *np;
174#endif 168#endif
169 struct delayed_work notify_work;
175 struct kobject kobj; 170 struct kobject kobj;
176 struct rtnl_link_stats64 slave_stats; 171 struct rtnl_link_stats64 slave_stats;
177}; 172};
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 8ebabc9873d1..4de121e24ce5 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -4852,8 +4852,6 @@ const char *reg_initiator_name(enum nl80211_reg_initiator initiator);
4852 * 4852 *
4853 * @alpha2: the ISO/IEC 3166 alpha2 wmm rule to be queried. 4853 * @alpha2: the ISO/IEC 3166 alpha2 wmm rule to be queried.
4854 * @freq: the freqency(in MHz) to be queried. 4854 * @freq: the freqency(in MHz) to be queried.
4855 * @ptr: pointer where the regdb wmm data is to be stored (or %NULL if
4856 * irrelevant). This can be used later for deduplication.
4857 * @rule: pointer to store the wmm rule from the regulatory db. 4855 * @rule: pointer to store the wmm rule from the regulatory db.
4858 * 4856 *
4859 * Self-managed wireless drivers can use this function to query 4857 * Self-managed wireless drivers can use this function to query
diff --git a/include/net/devlink.h b/include/net/devlink.h
index b9b89d6604d4..99efc156a309 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -298,7 +298,7 @@ struct devlink_resource {
298 298
299#define DEVLINK_RESOURCE_ID_PARENT_TOP 0 299#define DEVLINK_RESOURCE_ID_PARENT_TOP 0
300 300
301#define DEVLINK_PARAM_MAX_STRING_VALUE 32 301#define __DEVLINK_PARAM_MAX_STRING_VALUE 32
302enum devlink_param_type { 302enum devlink_param_type {
303 DEVLINK_PARAM_TYPE_U8, 303 DEVLINK_PARAM_TYPE_U8,
304 DEVLINK_PARAM_TYPE_U16, 304 DEVLINK_PARAM_TYPE_U16,
@@ -311,7 +311,7 @@ union devlink_param_value {
311 u8 vu8; 311 u8 vu8;
312 u16 vu16; 312 u16 vu16;
313 u32 vu32; 313 u32 vu32;
314 const char *vstr; 314 char vstr[__DEVLINK_PARAM_MAX_STRING_VALUE];
315 bool vbool; 315 bool vbool;
316}; 316};
317 317
@@ -553,6 +553,8 @@ int devlink_param_driverinit_value_get(struct devlink *devlink, u32 param_id,
553int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id, 553int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
554 union devlink_param_value init_val); 554 union devlink_param_value init_val);
555void devlink_param_value_changed(struct devlink *devlink, u32 param_id); 555void devlink_param_value_changed(struct devlink *devlink, u32 param_id);
556void devlink_param_value_str_fill(union devlink_param_value *dst_val,
557 const char *src);
556struct devlink_region *devlink_region_create(struct devlink *devlink, 558struct devlink_region *devlink_region_create(struct devlink *devlink,
557 const char *region_name, 559 const char *region_name,
558 u32 region_max_snapshots, 560 u32 region_max_snapshots,
@@ -789,6 +791,12 @@ devlink_param_value_changed(struct devlink *devlink, u32 param_id)
789{ 791{
790} 792}
791 793
794static inline void
795devlink_param_value_str_fill(union devlink_param_value *dst_val,
796 const char *src)
797{
798}
799
792static inline struct devlink_region * 800static inline struct devlink_region *
793devlink_region_create(struct devlink *devlink, 801devlink_region_create(struct devlink *devlink,
794 const char *region_name, 802 const char *region_name,
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h
index e03b93360f33..a80fd0ac4563 100644
--- a/include/net/inet_sock.h
+++ b/include/net/inet_sock.h
@@ -130,12 +130,6 @@ static inline int inet_request_bound_dev_if(const struct sock *sk,
130 return sk->sk_bound_dev_if; 130 return sk->sk_bound_dev_if;
131} 131}
132 132
133static inline struct ip_options_rcu *ireq_opt_deref(const struct inet_request_sock *ireq)
134{
135 return rcu_dereference_check(ireq->ireq_opt,
136 refcount_read(&ireq->req.rsk_refcnt) > 0);
137}
138
139struct inet_cork { 133struct inet_cork {
140 unsigned int flags; 134 unsigned int flags;
141 __be32 addr; 135 __be32 addr;
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 69c91d1934c1..c9b7b136939d 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -394,6 +394,7 @@ int ip_fib_check_default(__be32 gw, struct net_device *dev);
394int fib_sync_down_dev(struct net_device *dev, unsigned long event, bool force); 394int fib_sync_down_dev(struct net_device *dev, unsigned long event, bool force);
395int fib_sync_down_addr(struct net_device *dev, __be32 local); 395int fib_sync_down_addr(struct net_device *dev, __be32 local);
396int fib_sync_up(struct net_device *dev, unsigned int nh_flags); 396int fib_sync_up(struct net_device *dev, unsigned int nh_flags);
397void fib_sync_mtu(struct net_device *dev, u32 orig_mtu);
397 398
398#ifdef CONFIG_IP_ROUTE_MULTIPATH 399#ifdef CONFIG_IP_ROUTE_MULTIPATH
399int fib_multipath_hash(const struct net *net, const struct flowi4 *fl4, 400int fib_multipath_hash(const struct net *net, const struct flowi4 *fl4,
diff --git a/include/net/netfilter/nf_conntrack_timeout.h b/include/net/netfilter/nf_conntrack_timeout.h
index d5f62cc6c2ae..3394d75e1c80 100644
--- a/include/net/netfilter/nf_conntrack_timeout.h
+++ b/include/net/netfilter/nf_conntrack_timeout.h
@@ -30,7 +30,7 @@ struct nf_conn_timeout {
30}; 30};
31 31
32static inline unsigned int * 32static inline unsigned int *
33nf_ct_timeout_data(struct nf_conn_timeout *t) 33nf_ct_timeout_data(const struct nf_conn_timeout *t)
34{ 34{
35 struct nf_ct_timeout *timeout; 35 struct nf_ct_timeout *timeout;
36 36
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 0c154f98e987..39e1d875d507 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -153,7 +153,7 @@
153 * nla_find() find attribute in stream of attributes 153 * nla_find() find attribute in stream of attributes
154 * nla_find_nested() find attribute in nested attributes 154 * nla_find_nested() find attribute in nested attributes
155 * nla_parse() parse and validate stream of attrs 155 * nla_parse() parse and validate stream of attrs
156 * nla_parse_nested() parse nested attribuets 156 * nla_parse_nested() parse nested attributes
157 * nla_for_each_attr() loop over all attributes 157 * nla_for_each_attr() loop over all attributes
158 * nla_for_each_nested() loop over the nested attributes 158 * nla_for_each_nested() loop over the nested attributes
159 *========================================================================= 159 *=========================================================================
diff --git a/include/net/nfc/hci.h b/include/net/nfc/hci.h
index 316694dafa5b..008f466d1da7 100644
--- a/include/net/nfc/hci.h
+++ b/include/net/nfc/hci.h
@@ -87,7 +87,7 @@ struct nfc_hci_pipe {
87 * According to specification 102 622 chapter 4.4 Pipes, 87 * According to specification 102 622 chapter 4.4 Pipes,
88 * the pipe identifier is 7 bits long. 88 * the pipe identifier is 7 bits long.
89 */ 89 */
90#define NFC_HCI_MAX_PIPES 127 90#define NFC_HCI_MAX_PIPES 128
91struct nfc_hci_init_data { 91struct nfc_hci_init_data {
92 u8 gate_count; 92 u8 gate_count;
93 struct nfc_hci_gate gates[NFC_HCI_MAX_CUSTOM_GATES]; 93 struct nfc_hci_gate gates[NFC_HCI_MAX_CUSTOM_GATES];
diff --git a/include/net/tls.h b/include/net/tls.h
index d5c683e8bb22..0a769cf2f5f3 100644
--- a/include/net/tls.h
+++ b/include/net/tls.h
@@ -171,15 +171,14 @@ struct cipher_context {
171 char *rec_seq; 171 char *rec_seq;
172}; 172};
173 173
174union tls_crypto_context {
175 struct tls_crypto_info info;
176 struct tls12_crypto_info_aes_gcm_128 aes_gcm_128;
177};
178
174struct tls_context { 179struct tls_context {
175 union { 180 union tls_crypto_context crypto_send;
176 struct tls_crypto_info crypto_send; 181 union tls_crypto_context crypto_recv;
177 struct tls12_crypto_info_aes_gcm_128 crypto_send_aes_gcm_128;
178 };
179 union {
180 struct tls_crypto_info crypto_recv;
181 struct tls12_crypto_info_aes_gcm_128 crypto_recv_aes_gcm_128;
182 };
183 182
184 struct list_head list; 183 struct list_head list;
185 struct net_device *netdev; 184 struct net_device *netdev;
@@ -367,8 +366,8 @@ static inline void tls_fill_prepend(struct tls_context *ctx,
367 * size KTLS_DTLS_HEADER_SIZE + KTLS_DTLS_NONCE_EXPLICIT_SIZE 366 * size KTLS_DTLS_HEADER_SIZE + KTLS_DTLS_NONCE_EXPLICIT_SIZE
368 */ 367 */
369 buf[0] = record_type; 368 buf[0] = record_type;
370 buf[1] = TLS_VERSION_MINOR(ctx->crypto_send.version); 369 buf[1] = TLS_VERSION_MINOR(ctx->crypto_send.info.version);
371 buf[2] = TLS_VERSION_MAJOR(ctx->crypto_send.version); 370 buf[2] = TLS_VERSION_MAJOR(ctx->crypto_send.info.version);
372 /* we can use IV for nonce explicit according to spec */ 371 /* we can use IV for nonce explicit according to spec */
373 buf[3] = pkt_len >> 8; 372 buf[3] = pkt_len >> 8;
374 buf[4] = pkt_len & 0xFF; 373 buf[4] = pkt_len & 0xFF;
diff --git a/include/soc/fsl/bman.h b/include/soc/fsl/bman.h
index eaaf56df4086..5b99cb2ea5ef 100644
--- a/include/soc/fsl/bman.h
+++ b/include/soc/fsl/bman.h
@@ -126,4 +126,12 @@ int bman_release(struct bman_pool *pool, const struct bm_buffer *bufs, u8 num);
126 */ 126 */
127int bman_acquire(struct bman_pool *pool, struct bm_buffer *bufs, u8 num); 127int bman_acquire(struct bman_pool *pool, struct bm_buffer *bufs, u8 num);
128 128
129/**
130 * bman_is_probed - Check if bman is probed
131 *
132 * Returns 1 if the bman driver successfully probed, -1 if the bman driver
133 * failed to probe or 0 if the bman driver did not probed yet.
134 */
135int bman_is_probed(void);
136
129#endif /* __FSL_BMAN_H */ 137#endif /* __FSL_BMAN_H */
diff --git a/include/soc/fsl/qman.h b/include/soc/fsl/qman.h
index d4dfefdee6c1..597783b8a3a0 100644
--- a/include/soc/fsl/qman.h
+++ b/include/soc/fsl/qman.h
@@ -1186,4 +1186,12 @@ int qman_alloc_cgrid_range(u32 *result, u32 count);
1186 */ 1186 */
1187int qman_release_cgrid(u32 id); 1187int qman_release_cgrid(u32 id);
1188 1188
1189/**
1190 * qman_is_probed - Check if qman is probed
1191 *
1192 * Returns 1 if the qman driver successfully probed, -1 if the qman driver
1193 * failed to probe or 0 if the qman driver did not probed yet.
1194 */
1195int qman_is_probed(void);
1196
1189#endif /* __FSL_QMAN_H */ 1197#endif /* __FSL_QMAN_H */
diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
index 6f1e1f3b3063..cd1773d0e08f 100644
--- a/include/sound/hdaudio.h
+++ b/include/sound/hdaudio.h
@@ -412,6 +412,7 @@ void snd_hdac_bus_init_cmd_io(struct hdac_bus *bus);
412void snd_hdac_bus_stop_cmd_io(struct hdac_bus *bus); 412void snd_hdac_bus_stop_cmd_io(struct hdac_bus *bus);
413void snd_hdac_bus_enter_link_reset(struct hdac_bus *bus); 413void snd_hdac_bus_enter_link_reset(struct hdac_bus *bus);
414void snd_hdac_bus_exit_link_reset(struct hdac_bus *bus); 414void snd_hdac_bus_exit_link_reset(struct hdac_bus *bus);
415int snd_hdac_bus_reset_link(struct hdac_bus *bus, bool full_reset);
415 416
416void snd_hdac_bus_update_rirb(struct hdac_bus *bus); 417void snd_hdac_bus_update_rirb(struct hdac_bus *bus);
417int snd_hdac_bus_handle_stream_irq(struct hdac_bus *bus, unsigned int status, 418int snd_hdac_bus_handle_stream_irq(struct hdac_bus *bus, unsigned int status,
diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index af9ef16cc34d..fdaaafdc7a00 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -407,6 +407,7 @@ int snd_soc_dapm_new_dai_widgets(struct snd_soc_dapm_context *dapm,
407int snd_soc_dapm_link_dai_widgets(struct snd_soc_card *card); 407int snd_soc_dapm_link_dai_widgets(struct snd_soc_card *card);
408void snd_soc_dapm_connect_dai_link_widgets(struct snd_soc_card *card); 408void snd_soc_dapm_connect_dai_link_widgets(struct snd_soc_card *card);
409int snd_soc_dapm_new_pcm(struct snd_soc_card *card, 409int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
410 struct snd_soc_pcm_runtime *rtd,
410 const struct snd_soc_pcm_stream *params, 411 const struct snd_soc_pcm_stream *params,
411 unsigned int num_params, 412 unsigned int num_params,
412 struct snd_soc_dapm_widget *source, 413 struct snd_soc_dapm_widget *source,
diff --git a/include/trace/events/migrate.h b/include/trace/events/migrate.h
index 711372845945..705b33d1e395 100644
--- a/include/trace/events/migrate.h
+++ b/include/trace/events/migrate.h
@@ -70,33 +70,6 @@ TRACE_EVENT(mm_migrate_pages,
70 __print_symbolic(__entry->mode, MIGRATE_MODE), 70 __print_symbolic(__entry->mode, MIGRATE_MODE),
71 __print_symbolic(__entry->reason, MIGRATE_REASON)) 71 __print_symbolic(__entry->reason, MIGRATE_REASON))
72); 72);
73
74TRACE_EVENT(mm_numa_migrate_ratelimit,
75
76 TP_PROTO(struct task_struct *p, int dst_nid, unsigned long nr_pages),
77
78 TP_ARGS(p, dst_nid, nr_pages),
79
80 TP_STRUCT__entry(
81 __array( char, comm, TASK_COMM_LEN)
82 __field( pid_t, pid)
83 __field( int, dst_nid)
84 __field( unsigned long, nr_pages)
85 ),
86
87 TP_fast_assign(
88 memcpy(__entry->comm, p->comm, TASK_COMM_LEN);
89 __entry->pid = p->pid;
90 __entry->dst_nid = dst_nid;
91 __entry->nr_pages = nr_pages;
92 ),
93
94 TP_printk("comm=%s pid=%d dst_nid=%d nr_pages=%lu",
95 __entry->comm,
96 __entry->pid,
97 __entry->dst_nid,
98 __entry->nr_pages)
99);
100#endif /* _TRACE_MIGRATE_H */ 73#endif /* _TRACE_MIGRATE_H */
101 74
102/* This part must be outside protection */ 75/* This part must be outside protection */
diff --git a/include/trace/events/rxrpc.h b/include/trace/events/rxrpc.h
index 196587b8f204..573d5b901fb1 100644
--- a/include/trace/events/rxrpc.h
+++ b/include/trace/events/rxrpc.h
@@ -56,7 +56,6 @@ enum rxrpc_peer_trace {
56 rxrpc_peer_new, 56 rxrpc_peer_new,
57 rxrpc_peer_processing, 57 rxrpc_peer_processing,
58 rxrpc_peer_put, 58 rxrpc_peer_put,
59 rxrpc_peer_queued_error,
60}; 59};
61 60
62enum rxrpc_conn_trace { 61enum rxrpc_conn_trace {
@@ -257,8 +256,7 @@ enum rxrpc_tx_point {
257 EM(rxrpc_peer_got, "GOT") \ 256 EM(rxrpc_peer_got, "GOT") \
258 EM(rxrpc_peer_new, "NEW") \ 257 EM(rxrpc_peer_new, "NEW") \
259 EM(rxrpc_peer_processing, "PRO") \ 258 EM(rxrpc_peer_processing, "PRO") \
260 EM(rxrpc_peer_put, "PUT") \ 259 E_(rxrpc_peer_put, "PUT")
261 E_(rxrpc_peer_queued_error, "QER")
262 260
263#define rxrpc_conn_traces \ 261#define rxrpc_conn_traces \
264 EM(rxrpc_conn_got, "GOT") \ 262 EM(rxrpc_conn_got, "GOT") \
@@ -933,6 +931,7 @@ TRACE_EVENT(rxrpc_tx_packet,
933 TP_fast_assign( 931 TP_fast_assign(
934 __entry->call = call_id; 932 __entry->call = call_id;
935 memcpy(&__entry->whdr, whdr, sizeof(__entry->whdr)); 933 memcpy(&__entry->whdr, whdr, sizeof(__entry->whdr));
934 __entry->where = where;
936 ), 935 ),
937 936
938 TP_printk("c=%08x %08x:%08x:%08x:%04x %08x %08x %02x %02x %s %s", 937 TP_printk("c=%08x %08x:%08x:%08x:%04x %08x %08x %02x %02x %s %s",
diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
index e4732d3c2998..b0f8e87235bd 100644
--- a/include/uapi/asm-generic/hugetlb_encode.h
+++ b/include/uapi/asm-generic/hugetlb_encode.h
@@ -26,7 +26,9 @@
26#define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT) 26#define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT)
27#define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT) 27#define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT)
28#define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT) 28#define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT)
29#define HUGETLB_FLAG_ENCODE_32MB (25 << HUGETLB_FLAG_ENCODE_SHIFT)
29#define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT) 30#define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT)
31#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
30#define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT) 32#define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
31#define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT) 33#define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
32#define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT) 34#define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
diff --git a/include/uapi/linux/keyctl.h b/include/uapi/linux/keyctl.h
index 910cc4334b21..7b8c9e19bad1 100644
--- a/include/uapi/linux/keyctl.h
+++ b/include/uapi/linux/keyctl.h
@@ -65,7 +65,7 @@
65 65
66/* keyctl structures */ 66/* keyctl structures */
67struct keyctl_dh_params { 67struct keyctl_dh_params {
68 __s32 dh_private; 68 __s32 private;
69 __s32 prime; 69 __s32 prime;
70 __s32 base; 70 __s32 base;
71}; 71};
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 07548de5c988..251be353f950 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -952,6 +952,7 @@ struct kvm_ppc_resize_hpt {
952#define KVM_CAP_S390_HPAGE_1M 156 952#define KVM_CAP_S390_HPAGE_1M 156
953#define KVM_CAP_NESTED_STATE 157 953#define KVM_CAP_NESTED_STATE 157
954#define KVM_CAP_ARM_INJECT_SERROR_ESR 158 954#define KVM_CAP_ARM_INJECT_SERROR_ESR 158
955#define KVM_CAP_MSR_PLATFORM_INFO 159
955 956
956#ifdef KVM_CAP_IRQ_ROUTING 957#ifdef KVM_CAP_IRQ_ROUTING
957 958
diff --git a/include/uapi/linux/memfd.h b/include/uapi/linux/memfd.h
index 015a4c0bbb47..7a8a26751c23 100644
--- a/include/uapi/linux/memfd.h
+++ b/include/uapi/linux/memfd.h
@@ -25,7 +25,9 @@
25#define MFD_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB 25#define MFD_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
26#define MFD_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB 26#define MFD_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
27#define MFD_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB 27#define MFD_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
28#define MFD_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
28#define MFD_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB 29#define MFD_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
30#define MFD_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
29#define MFD_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB 31#define MFD_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
30#define MFD_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB 32#define MFD_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
31#define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB 33#define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
index bfd5938fede6..d0f515d53299 100644
--- a/include/uapi/linux/mman.h
+++ b/include/uapi/linux/mman.h
@@ -28,7 +28,9 @@
28#define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB 28#define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
29#define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB 29#define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
30#define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB 30#define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
31#define MAP_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
31#define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB 32#define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
33#define MAP_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
32#define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB 34#define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
33#define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB 35#define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
34#define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB 36#define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index eeb787b1c53c..f35eb72739c0 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -144,7 +144,7 @@ enum perf_event_sample_format {
144 144
145 PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */ 145 PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */
146 146
147 __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, 147 __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, /* non-ABI; internal use */
148}; 148};
149 149
150/* 150/*
diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h
index dde1344f047c..6507ad0afc81 100644
--- a/include/uapi/linux/shm.h
+++ b/include/uapi/linux/shm.h
@@ -65,7 +65,9 @@ struct shmid_ds {
65#define SHM_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB 65#define SHM_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
66#define SHM_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB 66#define SHM_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
67#define SHM_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB 67#define SHM_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
68#define SHM_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
68#define SHM_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB 69#define SHM_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
70#define SHM_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
69#define SHM_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB 71#define SHM_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
70#define SHM_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB 72#define SHM_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
71#define SHM_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB 73#define SHM_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
diff --git a/include/uapi/linux/smc_diag.h b/include/uapi/linux/smc_diag.h
index ac9e8c96d9bd..8cb3a6fef553 100644
--- a/include/uapi/linux/smc_diag.h
+++ b/include/uapi/linux/smc_diag.h
@@ -18,14 +18,17 @@ struct smc_diag_req {
18 * on the internal clcsock, and more SMC-related socket data 18 * on the internal clcsock, and more SMC-related socket data
19 */ 19 */
20struct smc_diag_msg { 20struct smc_diag_msg {
21 __u8 diag_family; 21 __u8 diag_family;
22 __u8 diag_state; 22 __u8 diag_state;
23 __u8 diag_mode; 23 union {
24 __u8 diag_shutdown; 24 __u8 diag_mode;
25 __u8 diag_fallback; /* the old name of the field */
26 };
27 __u8 diag_shutdown;
25 struct inet_diag_sockid id; 28 struct inet_diag_sockid id;
26 29
27 __u32 diag_uid; 30 __u32 diag_uid;
28 __u64 diag_inode; 31 __aligned_u64 diag_inode;
29}; 32};
30 33
31/* Mode of a connection */ 34/* Mode of a connection */
@@ -99,11 +102,11 @@ struct smc_diag_fallback {
99}; 102};
100 103
101struct smcd_diag_dmbinfo { /* SMC-D Socket internals */ 104struct smcd_diag_dmbinfo { /* SMC-D Socket internals */
102 __u32 linkid; /* Link identifier */ 105 __u32 linkid; /* Link identifier */
103 __u64 peer_gid; /* Peer GID */ 106 __aligned_u64 peer_gid; /* Peer GID */
104 __u64 my_gid; /* My GID */ 107 __aligned_u64 my_gid; /* My GID */
105 __u64 token; /* Token of DMB */ 108 __aligned_u64 token; /* Token of DMB */
106 __u64 peer_token; /* Token of remote DMBE */ 109 __aligned_u64 peer_token; /* Token of remote DMBE */
107}; 110};
108 111
109#endif /* _UAPI_SMC_DIAG_H_ */ 112#endif /* _UAPI_SMC_DIAG_H_ */
diff --git a/include/uapi/linux/udp.h b/include/uapi/linux/udp.h
index 09d00f8c442b..09502de447f5 100644
--- a/include/uapi/linux/udp.h
+++ b/include/uapi/linux/udp.h
@@ -40,5 +40,6 @@ struct udphdr {
40#define UDP_ENCAP_L2TPINUDP 3 /* rfc2661 */ 40#define UDP_ENCAP_L2TPINUDP 3 /* rfc2661 */
41#define UDP_ENCAP_GTP0 4 /* GSM TS 09.60 */ 41#define UDP_ENCAP_GTP0 4 /* GSM TS 09.60 */
42#define UDP_ENCAP_GTP1U 5 /* 3GPP TS 29.060 */ 42#define UDP_ENCAP_GTP1U 5 /* 3GPP TS 29.060 */
43#define UDP_ENCAP_RXRPC 6
43 44
44#endif /* _UAPI_LINUX_UDP_H */ 45#endif /* _UAPI_LINUX_UDP_H */
diff --git a/include/uapi/sound/skl-tplg-interface.h b/include/uapi/sound/skl-tplg-interface.h
index f58cafa42f18..f39352cef382 100644
--- a/include/uapi/sound/skl-tplg-interface.h
+++ b/include/uapi/sound/skl-tplg-interface.h
@@ -10,6 +10,8 @@
10#ifndef __HDA_TPLG_INTERFACE_H__ 10#ifndef __HDA_TPLG_INTERFACE_H__
11#define __HDA_TPLG_INTERFACE_H__ 11#define __HDA_TPLG_INTERFACE_H__
12 12
13#include <linux/types.h>
14
13/* 15/*
14 * Default types range from 0~12. type can range from 0 to 0xff 16 * Default types range from 0~12. type can range from 0 to 0xff
15 * SST types start at higher to avoid any overlapping in future 17 * SST types start at higher to avoid any overlapping in future
@@ -143,10 +145,10 @@ enum skl_module_param_type {
143}; 145};
144 146
145struct skl_dfw_algo_data { 147struct skl_dfw_algo_data {
146 u32 set_params:2; 148 __u32 set_params:2;
147 u32 rsvd:30; 149 __u32 rsvd:30;
148 u32 param_id; 150 __u32 param_id;
149 u32 max; 151 __u32 max;
150 char params[0]; 152 char params[0];
151} __packed; 153} __packed;
152 154
@@ -163,68 +165,68 @@ enum skl_tuple_type {
163/* v4 configuration data */ 165/* v4 configuration data */
164 166
165struct skl_dfw_v4_module_pin { 167struct skl_dfw_v4_module_pin {
166 u16 module_id; 168 __u16 module_id;
167 u16 instance_id; 169 __u16 instance_id;
168} __packed; 170} __packed;
169 171
170struct skl_dfw_v4_module_fmt { 172struct skl_dfw_v4_module_fmt {
171 u32 channels; 173 __u32 channels;
172 u32 freq; 174 __u32 freq;
173 u32 bit_depth; 175 __u32 bit_depth;
174 u32 valid_bit_depth; 176 __u32 valid_bit_depth;
175 u32 ch_cfg; 177 __u32 ch_cfg;
176 u32 interleaving_style; 178 __u32 interleaving_style;
177 u32 sample_type; 179 __u32 sample_type;
178 u32 ch_map; 180 __u32 ch_map;
179} __packed; 181} __packed;
180 182
181struct skl_dfw_v4_module_caps { 183struct skl_dfw_v4_module_caps {
182 u32 set_params:2; 184 __u32 set_params:2;
183 u32 rsvd:30; 185 __u32 rsvd:30;
184 u32 param_id; 186 __u32 param_id;
185 u32 caps_size; 187 __u32 caps_size;
186 u32 caps[HDA_SST_CFG_MAX]; 188 __u32 caps[HDA_SST_CFG_MAX];
187} __packed; 189} __packed;
188 190
189struct skl_dfw_v4_pipe { 191struct skl_dfw_v4_pipe {
190 u8 pipe_id; 192 __u8 pipe_id;
191 u8 pipe_priority; 193 __u8 pipe_priority;
192 u16 conn_type:4; 194 __u16 conn_type:4;
193 u16 rsvd:4; 195 __u16 rsvd:4;
194 u16 memory_pages:8; 196 __u16 memory_pages:8;
195} __packed; 197} __packed;
196 198
197struct skl_dfw_v4_module { 199struct skl_dfw_v4_module {
198 char uuid[SKL_UUID_STR_SZ]; 200 char uuid[SKL_UUID_STR_SZ];
199 201
200 u16 module_id; 202 __u16 module_id;
201 u16 instance_id; 203 __u16 instance_id;
202 u32 max_mcps; 204 __u32 max_mcps;
203 u32 mem_pages; 205 __u32 mem_pages;
204 u32 obs; 206 __u32 obs;
205 u32 ibs; 207 __u32 ibs;
206 u32 vbus_id; 208 __u32 vbus_id;
207 209
208 u32 max_in_queue:8; 210 __u32 max_in_queue:8;
209 u32 max_out_queue:8; 211 __u32 max_out_queue:8;
210 u32 time_slot:8; 212 __u32 time_slot:8;
211 u32 core_id:4; 213 __u32 core_id:4;
212 u32 rsvd1:4; 214 __u32 rsvd1:4;
213 215
214 u32 module_type:8; 216 __u32 module_type:8;
215 u32 conn_type:4; 217 __u32 conn_type:4;
216 u32 dev_type:4; 218 __u32 dev_type:4;
217 u32 hw_conn_type:4; 219 __u32 hw_conn_type:4;
218 u32 rsvd2:12; 220 __u32 rsvd2:12;
219 221
220 u32 params_fixup:8; 222 __u32 params_fixup:8;
221 u32 converter:8; 223 __u32 converter:8;
222 u32 input_pin_type:1; 224 __u32 input_pin_type:1;
223 u32 output_pin_type:1; 225 __u32 output_pin_type:1;
224 u32 is_dynamic_in_pin:1; 226 __u32 is_dynamic_in_pin:1;
225 u32 is_dynamic_out_pin:1; 227 __u32 is_dynamic_out_pin:1;
226 u32 is_loadable:1; 228 __u32 is_loadable:1;
227 u32 rsvd3:11; 229 __u32 rsvd3:11;
228 230
229 struct skl_dfw_v4_pipe pipe; 231 struct skl_dfw_v4_pipe pipe;
230 struct skl_dfw_v4_module_fmt in_fmt[MAX_IN_QUEUE]; 232 struct skl_dfw_v4_module_fmt in_fmt[MAX_IN_QUEUE];
diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h
index 80b52b4945e9..a2ab516fcd2c 100644
--- a/include/xen/mem-reservation.h
+++ b/include/xen/mem-reservation.h
@@ -17,11 +17,12 @@
17 17
18#include <xen/page.h> 18#include <xen/page.h>
19 19
20extern bool xen_scrub_pages;
21
20static inline void xenmem_reservation_scrub_page(struct page *page) 22static inline void xenmem_reservation_scrub_page(struct page *page)
21{ 23{
22#ifdef CONFIG_XEN_SCRUB_PAGES 24 if (xen_scrub_pages)
23 clear_highpage(page); 25 clear_highpage(page);
24#endif
25} 26}
26 27
27#ifdef CONFIG_XEN_HAVE_PVMMU 28#ifdef CONFIG_XEN_HAVE_PVMMU
diff --git a/ipc/shm.c b/ipc/shm.c
index 4cd402e4cfeb..1c65fb357395 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -206,7 +206,7 @@ err:
206 * Callers of shm_lock() must validate the status of the returned ipc 206 * Callers of shm_lock() must validate the status of the returned ipc
207 * object pointer and error out as appropriate. 207 * object pointer and error out as appropriate.
208 */ 208 */
209 return (void *)ipcp; 209 return ERR_CAST(ipcp);
210} 210}
211 211
212static inline void shm_lock_by_ptr(struct shmid_kernel *ipcp) 212static inline void shm_lock_by_ptr(struct shmid_kernel *ipcp)
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 2590700237c1..138f0302692e 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -1844,7 +1844,7 @@ static int btf_check_all_metas(struct btf_verifier_env *env)
1844 1844
1845 hdr = &btf->hdr; 1845 hdr = &btf->hdr;
1846 cur = btf->nohdr_data + hdr->type_off; 1846 cur = btf->nohdr_data + hdr->type_off;
1847 end = btf->nohdr_data + hdr->type_len; 1847 end = cur + hdr->type_len;
1848 1848
1849 env->log_type_id = 1; 1849 env->log_type_id = 1;
1850 while (cur < end) { 1850 while (cur < end) {
diff --git a/kernel/bpf/local_storage.c b/kernel/bpf/local_storage.c
index 22ad967d1e5f..830d7f095748 100644
--- a/kernel/bpf/local_storage.c
+++ b/kernel/bpf/local_storage.c
@@ -129,7 +129,7 @@ static int cgroup_storage_update_elem(struct bpf_map *map, void *_key,
129 struct bpf_cgroup_storage *storage; 129 struct bpf_cgroup_storage *storage;
130 struct bpf_storage_buffer *new; 130 struct bpf_storage_buffer *new;
131 131
132 if (flags & BPF_NOEXIST) 132 if (flags != BPF_ANY && flags != BPF_EXIST)
133 return -EINVAL; 133 return -EINVAL;
134 134
135 storage = cgroup_storage_lookup((struct bpf_cgroup_storage_map *)map, 135 storage = cgroup_storage_lookup((struct bpf_cgroup_storage_map *)map,
@@ -195,6 +195,9 @@ static struct bpf_map *cgroup_storage_map_alloc(union bpf_attr *attr)
195 if (attr->key_size != sizeof(struct bpf_cgroup_storage_key)) 195 if (attr->key_size != sizeof(struct bpf_cgroup_storage_key))
196 return ERR_PTR(-EINVAL); 196 return ERR_PTR(-EINVAL);
197 197
198 if (attr->value_size == 0)
199 return ERR_PTR(-EINVAL);
200
198 if (attr->value_size > PAGE_SIZE) 201 if (attr->value_size > PAGE_SIZE)
199 return ERR_PTR(-E2BIG); 202 return ERR_PTR(-E2BIG);
200 203
diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c
index 488ef9663c01..0a0f2ec75370 100644
--- a/kernel/bpf/sockmap.c
+++ b/kernel/bpf/sockmap.c
@@ -132,6 +132,7 @@ struct smap_psock {
132 struct work_struct gc_work; 132 struct work_struct gc_work;
133 133
134 struct proto *sk_proto; 134 struct proto *sk_proto;
135 void (*save_unhash)(struct sock *sk);
135 void (*save_close)(struct sock *sk, long timeout); 136 void (*save_close)(struct sock *sk, long timeout);
136 void (*save_data_ready)(struct sock *sk); 137 void (*save_data_ready)(struct sock *sk);
137 void (*save_write_space)(struct sock *sk); 138 void (*save_write_space)(struct sock *sk);
@@ -143,6 +144,7 @@ static int bpf_tcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
143static int bpf_tcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t size); 144static int bpf_tcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t size);
144static int bpf_tcp_sendpage(struct sock *sk, struct page *page, 145static int bpf_tcp_sendpage(struct sock *sk, struct page *page,
145 int offset, size_t size, int flags); 146 int offset, size_t size, int flags);
147static void bpf_tcp_unhash(struct sock *sk);
146static void bpf_tcp_close(struct sock *sk, long timeout); 148static void bpf_tcp_close(struct sock *sk, long timeout);
147 149
148static inline struct smap_psock *smap_psock_sk(const struct sock *sk) 150static inline struct smap_psock *smap_psock_sk(const struct sock *sk)
@@ -184,6 +186,7 @@ static void build_protos(struct proto prot[SOCKMAP_NUM_CONFIGS],
184 struct proto *base) 186 struct proto *base)
185{ 187{
186 prot[SOCKMAP_BASE] = *base; 188 prot[SOCKMAP_BASE] = *base;
189 prot[SOCKMAP_BASE].unhash = bpf_tcp_unhash;
187 prot[SOCKMAP_BASE].close = bpf_tcp_close; 190 prot[SOCKMAP_BASE].close = bpf_tcp_close;
188 prot[SOCKMAP_BASE].recvmsg = bpf_tcp_recvmsg; 191 prot[SOCKMAP_BASE].recvmsg = bpf_tcp_recvmsg;
189 prot[SOCKMAP_BASE].stream_memory_read = bpf_tcp_stream_read; 192 prot[SOCKMAP_BASE].stream_memory_read = bpf_tcp_stream_read;
@@ -217,6 +220,7 @@ static int bpf_tcp_init(struct sock *sk)
217 return -EBUSY; 220 return -EBUSY;
218 } 221 }
219 222
223 psock->save_unhash = sk->sk_prot->unhash;
220 psock->save_close = sk->sk_prot->close; 224 psock->save_close = sk->sk_prot->close;
221 psock->sk_proto = sk->sk_prot; 225 psock->sk_proto = sk->sk_prot;
222 226
@@ -305,30 +309,12 @@ static struct smap_psock_map_entry *psock_map_pop(struct sock *sk,
305 return e; 309 return e;
306} 310}
307 311
308static void bpf_tcp_close(struct sock *sk, long timeout) 312static void bpf_tcp_remove(struct sock *sk, struct smap_psock *psock)
309{ 313{
310 void (*close_fun)(struct sock *sk, long timeout);
311 struct smap_psock_map_entry *e; 314 struct smap_psock_map_entry *e;
312 struct sk_msg_buff *md, *mtmp; 315 struct sk_msg_buff *md, *mtmp;
313 struct smap_psock *psock;
314 struct sock *osk; 316 struct sock *osk;
315 317
316 lock_sock(sk);
317 rcu_read_lock();
318 psock = smap_psock_sk(sk);
319 if (unlikely(!psock)) {
320 rcu_read_unlock();
321 release_sock(sk);
322 return sk->sk_prot->close(sk, timeout);
323 }
324
325 /* The psock may be destroyed anytime after exiting the RCU critial
326 * section so by the time we use close_fun the psock may no longer
327 * be valid. However, bpf_tcp_close is called with the sock lock
328 * held so the close hook and sk are still valid.
329 */
330 close_fun = psock->save_close;
331
332 if (psock->cork) { 318 if (psock->cork) {
333 free_start_sg(psock->sock, psock->cork, true); 319 free_start_sg(psock->sock, psock->cork, true);
334 kfree(psock->cork); 320 kfree(psock->cork);
@@ -379,6 +365,42 @@ static void bpf_tcp_close(struct sock *sk, long timeout)
379 kfree(e); 365 kfree(e);
380 e = psock_map_pop(sk, psock); 366 e = psock_map_pop(sk, psock);
381 } 367 }
368}
369
370static void bpf_tcp_unhash(struct sock *sk)
371{
372 void (*unhash_fun)(struct sock *sk);
373 struct smap_psock *psock;
374
375 rcu_read_lock();
376 psock = smap_psock_sk(sk);
377 if (unlikely(!psock)) {
378 rcu_read_unlock();
379 if (sk->sk_prot->unhash)
380 sk->sk_prot->unhash(sk);
381 return;
382 }
383 unhash_fun = psock->save_unhash;
384 bpf_tcp_remove(sk, psock);
385 rcu_read_unlock();
386 unhash_fun(sk);
387}
388
389static void bpf_tcp_close(struct sock *sk, long timeout)
390{
391 void (*close_fun)(struct sock *sk, long timeout);
392 struct smap_psock *psock;
393
394 lock_sock(sk);
395 rcu_read_lock();
396 psock = smap_psock_sk(sk);
397 if (unlikely(!psock)) {
398 rcu_read_unlock();
399 release_sock(sk);
400 return sk->sk_prot->close(sk, timeout);
401 }
402 close_fun = psock->save_close;
403 bpf_tcp_remove(sk, psock);
382 rcu_read_unlock(); 404 rcu_read_unlock();
383 release_sock(sk); 405 release_sock(sk);
384 close_fun(sk, timeout); 406 close_fun(sk, timeout);
@@ -2097,8 +2119,12 @@ static int sock_map_update_elem(struct bpf_map *map,
2097 return -EINVAL; 2119 return -EINVAL;
2098 } 2120 }
2099 2121
2122 /* ULPs are currently supported only for TCP sockets in ESTABLISHED
2123 * state.
2124 */
2100 if (skops.sk->sk_type != SOCK_STREAM || 2125 if (skops.sk->sk_type != SOCK_STREAM ||
2101 skops.sk->sk_protocol != IPPROTO_TCP) { 2126 skops.sk->sk_protocol != IPPROTO_TCP ||
2127 skops.sk->sk_state != TCP_ESTABLISHED) {
2102 fput(socket->file); 2128 fput(socket->file);
2103 return -EOPNOTSUPP; 2129 return -EOPNOTSUPP;
2104 } 2130 }
@@ -2453,6 +2479,16 @@ static int sock_hash_update_elem(struct bpf_map *map,
2453 return -EINVAL; 2479 return -EINVAL;
2454 } 2480 }
2455 2481
2482 /* ULPs are currently supported only for TCP sockets in ESTABLISHED
2483 * state.
2484 */
2485 if (skops.sk->sk_type != SOCK_STREAM ||
2486 skops.sk->sk_protocol != IPPROTO_TCP ||
2487 skops.sk->sk_state != TCP_ESTABLISHED) {
2488 fput(socket->file);
2489 return -EOPNOTSUPP;
2490 }
2491
2456 lock_sock(skops.sk); 2492 lock_sock(skops.sk);
2457 preempt_disable(); 2493 preempt_disable();
2458 rcu_read_lock(); 2494 rcu_read_lock();
@@ -2543,10 +2579,22 @@ const struct bpf_map_ops sock_hash_ops = {
2543 .map_check_btf = map_check_no_btf, 2579 .map_check_btf = map_check_no_btf,
2544}; 2580};
2545 2581
2582static bool bpf_is_valid_sock_op(struct bpf_sock_ops_kern *ops)
2583{
2584 return ops->op == BPF_SOCK_OPS_PASSIVE_ESTABLISHED_CB ||
2585 ops->op == BPF_SOCK_OPS_ACTIVE_ESTABLISHED_CB;
2586}
2546BPF_CALL_4(bpf_sock_map_update, struct bpf_sock_ops_kern *, bpf_sock, 2587BPF_CALL_4(bpf_sock_map_update, struct bpf_sock_ops_kern *, bpf_sock,
2547 struct bpf_map *, map, void *, key, u64, flags) 2588 struct bpf_map *, map, void *, key, u64, flags)
2548{ 2589{
2549 WARN_ON_ONCE(!rcu_read_lock_held()); 2590 WARN_ON_ONCE(!rcu_read_lock_held());
2591
2592 /* ULPs are currently supported only for TCP sockets in ESTABLISHED
2593 * state. This checks that the sock ops triggering the update is
2594 * one indicating we are (or will be soon) in an ESTABLISHED state.
2595 */
2596 if (!bpf_is_valid_sock_op(bpf_sock))
2597 return -EOPNOTSUPP;
2550 return sock_map_ctx_update_elem(bpf_sock, map, key, flags); 2598 return sock_map_ctx_update_elem(bpf_sock, map, key, flags);
2551} 2599}
2552 2600
@@ -2565,6 +2613,9 @@ BPF_CALL_4(bpf_sock_hash_update, struct bpf_sock_ops_kern *, bpf_sock,
2565 struct bpf_map *, map, void *, key, u64, flags) 2613 struct bpf_map *, map, void *, key, u64, flags)
2566{ 2614{
2567 WARN_ON_ONCE(!rcu_read_lock_held()); 2615 WARN_ON_ONCE(!rcu_read_lock_held());
2616
2617 if (!bpf_is_valid_sock_op(bpf_sock))
2618 return -EOPNOTSUPP;
2568 return sock_hash_ctx_update_elem(bpf_sock, map, key, flags); 2619 return sock_hash_ctx_update_elem(bpf_sock, map, key, flags);
2569} 2620}
2570 2621
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 92246117d2b0..465952a8e465 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -2896,6 +2896,15 @@ static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
2896 u64 umin_val, umax_val; 2896 u64 umin_val, umax_val;
2897 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32; 2897 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
2898 2898
2899 if (insn_bitness == 32) {
2900 /* Relevant for 32-bit RSH: Information can propagate towards
2901 * LSB, so it isn't sufficient to only truncate the output to
2902 * 32 bits.
2903 */
2904 coerce_reg_to_size(dst_reg, 4);
2905 coerce_reg_to_size(&src_reg, 4);
2906 }
2907
2899 smin_val = src_reg.smin_value; 2908 smin_val = src_reg.smin_value;
2900 smax_val = src_reg.smax_value; 2909 smax_val = src_reg.smax_value;
2901 umin_val = src_reg.umin_value; 2910 umin_val = src_reg.umin_value;
@@ -3131,7 +3140,6 @@ static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
3131 if (BPF_CLASS(insn->code) != BPF_ALU64) { 3140 if (BPF_CLASS(insn->code) != BPF_ALU64) {
3132 /* 32-bit ALU ops are (32,32)->32 */ 3141 /* 32-bit ALU ops are (32,32)->32 */
3133 coerce_reg_to_size(dst_reg, 4); 3142 coerce_reg_to_size(dst_reg, 4);
3134 coerce_reg_to_size(&src_reg, 4);
3135 } 3143 }
3136 3144
3137 __reg_deduce_bounds(dst_reg); 3145 __reg_deduce_bounds(dst_reg);
@@ -3163,7 +3171,7 @@ static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
3163 * an arbitrary scalar. Disallow all math except 3171 * an arbitrary scalar. Disallow all math except
3164 * pointer subtraction 3172 * pointer subtraction
3165 */ 3173 */
3166 if (opcode == BPF_SUB){ 3174 if (opcode == BPF_SUB && env->allow_ptr_leaks) {
3167 mark_reg_unknown(env, regs, insn->dst_reg); 3175 mark_reg_unknown(env, regs, insn->dst_reg);
3168 return 0; 3176 return 0;
3169 } 3177 }
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index aae10baf1902..4a3dae2a8283 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2836,11 +2836,12 @@ restart:
2836} 2836}
2837 2837
2838/** 2838/**
2839 * cgroup_save_control - save control masks of a subtree 2839 * cgroup_save_control - save control masks and dom_cgrp of a subtree
2840 * @cgrp: root of the target subtree 2840 * @cgrp: root of the target subtree
2841 * 2841 *
2842 * Save ->subtree_control and ->subtree_ss_mask to the respective old_ 2842 * Save ->subtree_control, ->subtree_ss_mask and ->dom_cgrp to the
2843 * prefixed fields for @cgrp's subtree including @cgrp itself. 2843 * respective old_ prefixed fields for @cgrp's subtree including @cgrp
2844 * itself.
2844 */ 2845 */
2845static void cgroup_save_control(struct cgroup *cgrp) 2846static void cgroup_save_control(struct cgroup *cgrp)
2846{ 2847{
@@ -2850,6 +2851,7 @@ static void cgroup_save_control(struct cgroup *cgrp)
2850 cgroup_for_each_live_descendant_pre(dsct, d_css, cgrp) { 2851 cgroup_for_each_live_descendant_pre(dsct, d_css, cgrp) {
2851 dsct->old_subtree_control = dsct->subtree_control; 2852 dsct->old_subtree_control = dsct->subtree_control;
2852 dsct->old_subtree_ss_mask = dsct->subtree_ss_mask; 2853 dsct->old_subtree_ss_mask = dsct->subtree_ss_mask;
2854 dsct->old_dom_cgrp = dsct->dom_cgrp;
2853 } 2855 }
2854} 2856}
2855 2857
@@ -2875,11 +2877,12 @@ static void cgroup_propagate_control(struct cgroup *cgrp)
2875} 2877}
2876 2878
2877/** 2879/**
2878 * cgroup_restore_control - restore control masks of a subtree 2880 * cgroup_restore_control - restore control masks and dom_cgrp of a subtree
2879 * @cgrp: root of the target subtree 2881 * @cgrp: root of the target subtree
2880 * 2882 *
2881 * Restore ->subtree_control and ->subtree_ss_mask from the respective old_ 2883 * Restore ->subtree_control, ->subtree_ss_mask and ->dom_cgrp from the
2882 * prefixed fields for @cgrp's subtree including @cgrp itself. 2884 * respective old_ prefixed fields for @cgrp's subtree including @cgrp
2885 * itself.
2883 */ 2886 */
2884static void cgroup_restore_control(struct cgroup *cgrp) 2887static void cgroup_restore_control(struct cgroup *cgrp)
2885{ 2888{
@@ -2889,6 +2892,7 @@ static void cgroup_restore_control(struct cgroup *cgrp)
2889 cgroup_for_each_live_descendant_post(dsct, d_css, cgrp) { 2892 cgroup_for_each_live_descendant_post(dsct, d_css, cgrp) {
2890 dsct->subtree_control = dsct->old_subtree_control; 2893 dsct->subtree_control = dsct->old_subtree_control;
2891 dsct->subtree_ss_mask = dsct->old_subtree_ss_mask; 2894 dsct->subtree_ss_mask = dsct->old_subtree_ss_mask;
2895 dsct->dom_cgrp = dsct->old_dom_cgrp;
2892 } 2896 }
2893} 2897}
2894 2898
@@ -3196,6 +3200,8 @@ static int cgroup_enable_threaded(struct cgroup *cgrp)
3196{ 3200{
3197 struct cgroup *parent = cgroup_parent(cgrp); 3201 struct cgroup *parent = cgroup_parent(cgrp);
3198 struct cgroup *dom_cgrp = parent->dom_cgrp; 3202 struct cgroup *dom_cgrp = parent->dom_cgrp;
3203 struct cgroup *dsct;
3204 struct cgroup_subsys_state *d_css;
3199 int ret; 3205 int ret;
3200 3206
3201 lockdep_assert_held(&cgroup_mutex); 3207 lockdep_assert_held(&cgroup_mutex);
@@ -3225,12 +3231,13 @@ static int cgroup_enable_threaded(struct cgroup *cgrp)
3225 */ 3231 */
3226 cgroup_save_control(cgrp); 3232 cgroup_save_control(cgrp);
3227 3233
3228 cgrp->dom_cgrp = dom_cgrp; 3234 cgroup_for_each_live_descendant_pre(dsct, d_css, cgrp)
3235 if (dsct == cgrp || cgroup_is_threaded(dsct))
3236 dsct->dom_cgrp = dom_cgrp;
3237
3229 ret = cgroup_apply_control(cgrp); 3238 ret = cgroup_apply_control(cgrp);
3230 if (!ret) 3239 if (!ret)
3231 parent->nr_threaded_children++; 3240 parent->nr_threaded_children++;
3232 else
3233 cgrp->dom_cgrp = cgrp;
3234 3241
3235 cgroup_finalize_control(cgrp, ret); 3242 cgroup_finalize_control(cgrp, ret);
3236 return ret; 3243 return ret;
diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
index 9bd54304446f..1b1d63b3634b 100644
--- a/kernel/dma/Kconfig
+++ b/kernel/dma/Kconfig
@@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU
23 bool 23 bool
24 select NEED_DMA_MAP_STATE 24 select NEED_DMA_MAP_STATE
25 25
26config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL
27 bool
28
26config DMA_DIRECT_OPS 29config DMA_DIRECT_OPS
27 bool 30 bool
28 depends on HAS_DMA 31 depends on HAS_DMA
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 2a62b96600ad..5a97f34bc14c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2867,16 +2867,11 @@ static int perf_event_modify_breakpoint(struct perf_event *bp,
2867 _perf_event_disable(bp); 2867 _perf_event_disable(bp);
2868 2868
2869 err = modify_user_hw_breakpoint_check(bp, attr, true); 2869 err = modify_user_hw_breakpoint_check(bp, attr, true);
2870 if (err) {
2871 if (!bp->attr.disabled)
2872 _perf_event_enable(bp);
2873 2870
2874 return err; 2871 if (!bp->attr.disabled)
2875 }
2876
2877 if (!attr->disabled)
2878 _perf_event_enable(bp); 2872 _perf_event_enable(bp);
2879 return 0; 2873
2874 return err;
2880} 2875}
2881 2876
2882static int perf_event_modify_attr(struct perf_event *event, 2877static int perf_event_modify_attr(struct perf_event *event,
@@ -3940,6 +3935,12 @@ int perf_event_read_local(struct perf_event *event, u64 *value,
3940 goto out; 3935 goto out;
3941 } 3936 }
3942 3937
3938 /* If this is a pinned event it must be running on this CPU */
3939 if (event->attr.pinned && event->oncpu != smp_processor_id()) {
3940 ret = -EBUSY;
3941 goto out;
3942 }
3943
3943 /* 3944 /*
3944 * If the event is currently on this CPU, its either a per-task event, 3945 * If the event is currently on this CPU, its either a per-task event,
3945 * or local to this CPU. Furthermore it means its ACTIVE (otherwise 3946 * or local to this CPU. Furthermore it means its ACTIVE (otherwise
@@ -5948,6 +5949,7 @@ perf_output_sample_ustack(struct perf_output_handle *handle, u64 dump_size,
5948 unsigned long sp; 5949 unsigned long sp;
5949 unsigned int rem; 5950 unsigned int rem;
5950 u64 dyn_size; 5951 u64 dyn_size;
5952 mm_segment_t fs;
5951 5953
5952 /* 5954 /*
5953 * We dump: 5955 * We dump:
@@ -5965,7 +5967,10 @@ perf_output_sample_ustack(struct perf_output_handle *handle, u64 dump_size,
5965 5967
5966 /* Data. */ 5968 /* Data. */
5967 sp = perf_user_stack_pointer(regs); 5969 sp = perf_user_stack_pointer(regs);
5970 fs = get_fs();
5971 set_fs(USER_DS);
5968 rem = __output_copy_user(handle, (void *) sp, dump_size); 5972 rem = __output_copy_user(handle, (void *) sp, dump_size);
5973 set_fs(fs);
5969 dyn_size = dump_size - rem; 5974 dyn_size = dump_size - rem;
5970 5975
5971 perf_output_skip(handle, rem); 5976 perf_output_skip(handle, rem);
@@ -8309,6 +8314,8 @@ void perf_tp_event(u16 event_type, u64 count, void *record, int entry_size,
8309 goto unlock; 8314 goto unlock;
8310 8315
8311 list_for_each_entry_rcu(event, &ctx->event_list, event_entry) { 8316 list_for_each_entry_rcu(event, &ctx->event_list, event_entry) {
8317 if (event->cpu != smp_processor_id())
8318 continue;
8312 if (event->attr.type != PERF_TYPE_TRACEPOINT) 8319 if (event->attr.type != PERF_TYPE_TRACEPOINT)
8313 continue; 8320 continue;
8314 if (event->attr.config != entry->type) 8321 if (event->attr.config != entry->type)
@@ -9426,9 +9433,7 @@ static void free_pmu_context(struct pmu *pmu)
9426 if (pmu->task_ctx_nr > perf_invalid_context) 9433 if (pmu->task_ctx_nr > perf_invalid_context)
9427 return; 9434 return;
9428 9435
9429 mutex_lock(&pmus_lock);
9430 free_percpu(pmu->pmu_cpu_context); 9436 free_percpu(pmu->pmu_cpu_context);
9431 mutex_unlock(&pmus_lock);
9432} 9437}
9433 9438
9434/* 9439/*
@@ -9684,12 +9689,8 @@ EXPORT_SYMBOL_GPL(perf_pmu_register);
9684 9689
9685void perf_pmu_unregister(struct pmu *pmu) 9690void perf_pmu_unregister(struct pmu *pmu)
9686{ 9691{
9687 int remove_device;
9688
9689 mutex_lock(&pmus_lock); 9692 mutex_lock(&pmus_lock);
9690 remove_device = pmu_bus_running;
9691 list_del_rcu(&pmu->entry); 9693 list_del_rcu(&pmu->entry);
9692 mutex_unlock(&pmus_lock);
9693 9694
9694 /* 9695 /*
9695 * We dereference the pmu list under both SRCU and regular RCU, so 9696 * We dereference the pmu list under both SRCU and regular RCU, so
@@ -9701,13 +9702,14 @@ void perf_pmu_unregister(struct pmu *pmu)
9701 free_percpu(pmu->pmu_disable_count); 9702 free_percpu(pmu->pmu_disable_count);
9702 if (pmu->type >= PERF_TYPE_MAX) 9703 if (pmu->type >= PERF_TYPE_MAX)
9703 idr_remove(&pmu_idr, pmu->type); 9704 idr_remove(&pmu_idr, pmu->type);
9704 if (remove_device) { 9705 if (pmu_bus_running) {
9705 if (pmu->nr_addr_filters) 9706 if (pmu->nr_addr_filters)
9706 device_remove_file(pmu->dev, &dev_attr_nr_addr_filters); 9707 device_remove_file(pmu->dev, &dev_attr_nr_addr_filters);
9707 device_del(pmu->dev); 9708 device_del(pmu->dev);
9708 put_device(pmu->dev); 9709 put_device(pmu->dev);
9709 } 9710 }
9710 free_pmu_context(pmu); 9711 free_pmu_context(pmu);
9712 mutex_unlock(&pmus_lock);
9711} 9713}
9712EXPORT_SYMBOL_GPL(perf_pmu_unregister); 9714EXPORT_SYMBOL_GPL(perf_pmu_unregister);
9713 9715
diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index b3814fce5ecb..d6b56180827c 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -509,6 +509,8 @@ modify_user_hw_breakpoint_check(struct perf_event *bp, struct perf_event_attr *a
509 */ 509 */
510int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *attr) 510int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *attr)
511{ 511{
512 int err;
513
512 /* 514 /*
513 * modify_user_hw_breakpoint can be invoked with IRQs disabled and hence it 515 * modify_user_hw_breakpoint can be invoked with IRQs disabled and hence it
514 * will not be possible to raise IPIs that invoke __perf_event_disable. 516 * will not be possible to raise IPIs that invoke __perf_event_disable.
@@ -520,15 +522,12 @@ int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *att
520 else 522 else
521 perf_event_disable(bp); 523 perf_event_disable(bp);
522 524
523 if (!attr->disabled) { 525 err = modify_user_hw_breakpoint_check(bp, attr, false);
524 int err = modify_user_hw_breakpoint_check(bp, attr, false);
525 526
526 if (err) 527 if (!bp->attr.disabled)
527 return err;
528 perf_event_enable(bp); 528 perf_event_enable(bp);
529 bp->attr.disabled = 0; 529
530 } 530 return err;
531 return 0;
532} 531}
533EXPORT_SYMBOL_GPL(modify_user_hw_breakpoint); 532EXPORT_SYMBOL_GPL(modify_user_hw_breakpoint);
534 533
diff --git a/kernel/jump_label.c b/kernel/jump_label.c
index 01ebdf1f9f40..2e62503bea0d 100644
--- a/kernel/jump_label.c
+++ b/kernel/jump_label.c
@@ -678,7 +678,7 @@ jump_label_module_notify(struct notifier_block *self, unsigned long val,
678 case MODULE_STATE_COMING: 678 case MODULE_STATE_COMING:
679 ret = jump_label_add_module(mod); 679 ret = jump_label_add_module(mod);
680 if (ret) { 680 if (ret) {
681 WARN(1, "Failed to allocatote memory: jump_label may not work properly.\n"); 681 WARN(1, "Failed to allocate memory: jump_label may not work properly.\n");
682 jump_label_del_module(mod); 682 jump_label_del_module(mod);
683 } 683 }
684 break; 684 break;
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index e406c5fdb41e..dd13f865ad40 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -55,7 +55,6 @@
55 55
56#include "lockdep_internals.h" 56#include "lockdep_internals.h"
57 57
58#include <trace/events/preemptirq.h>
59#define CREATE_TRACE_POINTS 58#define CREATE_TRACE_POINTS
60#include <trace/events/lock.h> 59#include <trace/events/lock.h>
61 60
diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
index 1a81a1257b3f..3f8a35104285 100644
--- a/kernel/locking/mutex.c
+++ b/kernel/locking/mutex.c
@@ -389,7 +389,7 @@ static bool __ww_mutex_wound(struct mutex *lock,
389 /* 389 /*
390 * wake_up_process() paired with set_current_state() 390 * wake_up_process() paired with set_current_state()
391 * inserts sufficient barriers to make sure @owner either sees 391 * inserts sufficient barriers to make sure @owner either sees
392 * it's wounded in __ww_mutex_lock_check_stamp() or has a 392 * it's wounded in __ww_mutex_check_kill() or has a
393 * wakeup pending to re-read the wounded state. 393 * wakeup pending to re-read the wounded state.
394 */ 394 */
395 if (owner != current) 395 if (owner != current)
@@ -946,7 +946,6 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
946 } 946 }
947 947
948 debug_mutex_lock_common(lock, &waiter); 948 debug_mutex_lock_common(lock, &waiter);
949 debug_mutex_add_waiter(lock, &waiter, current);
950 949
951 lock_contended(&lock->dep_map, ip); 950 lock_contended(&lock->dep_map, ip);
952 951
diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
index 5b915b370d5a..65a3b7e55b9f 100644
--- a/kernel/locking/test-ww_mutex.c
+++ b/kernel/locking/test-ww_mutex.c
@@ -260,7 +260,7 @@ static void test_cycle_work(struct work_struct *work)
260{ 260{
261 struct test_cycle *cycle = container_of(work, typeof(*cycle), work); 261 struct test_cycle *cycle = container_of(work, typeof(*cycle), work);
262 struct ww_acquire_ctx ctx; 262 struct ww_acquire_ctx ctx;
263 int err; 263 int err, erra = 0;
264 264
265 ww_acquire_init(&ctx, &ww_class); 265 ww_acquire_init(&ctx, &ww_class);
266 ww_mutex_lock(&cycle->a_mutex, &ctx); 266 ww_mutex_lock(&cycle->a_mutex, &ctx);
@@ -270,17 +270,19 @@ static void test_cycle_work(struct work_struct *work)
270 270
271 err = ww_mutex_lock(cycle->b_mutex, &ctx); 271 err = ww_mutex_lock(cycle->b_mutex, &ctx);
272 if (err == -EDEADLK) { 272 if (err == -EDEADLK) {
273 err = 0;
273 ww_mutex_unlock(&cycle->a_mutex); 274 ww_mutex_unlock(&cycle->a_mutex);
274 ww_mutex_lock_slow(cycle->b_mutex, &ctx); 275 ww_mutex_lock_slow(cycle->b_mutex, &ctx);
275 err = ww_mutex_lock(&cycle->a_mutex, &ctx); 276 erra = ww_mutex_lock(&cycle->a_mutex, &ctx);
276 } 277 }
277 278
278 if (!err) 279 if (!err)
279 ww_mutex_unlock(cycle->b_mutex); 280 ww_mutex_unlock(cycle->b_mutex);
280 ww_mutex_unlock(&cycle->a_mutex); 281 if (!erra)
282 ww_mutex_unlock(&cycle->a_mutex);
281 ww_acquire_fini(&ctx); 283 ww_acquire_fini(&ctx);
282 284
283 cycle->result = err; 285 cycle->result = err ?: erra;
284} 286}
285 287
286static int __test_cycle(unsigned int nthreads) 288static int __test_cycle(unsigned int nthreads)
@@ -324,7 +326,7 @@ static int __test_cycle(unsigned int nthreads)
324 if (!cycle->result) 326 if (!cycle->result)
325 continue; 327 continue;
326 328
327 pr_err("cylic deadlock not resolved, ret[%d/%d] = %d\n", 329 pr_err("cyclic deadlock not resolved, ret[%d/%d] = %d\n",
328 n, nthreads, cycle->result); 330 n, nthreads, cycle->result);
329 ret = -EINVAL; 331 ret = -EINVAL;
330 break; 332 break;
diff --git a/kernel/pid.c b/kernel/pid.c
index de1cfc4f75a2..cdf63e53a014 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -195,7 +195,7 @@ struct pid *alloc_pid(struct pid_namespace *ns)
195 idr_preload_end(); 195 idr_preload_end();
196 196
197 if (nr < 0) { 197 if (nr < 0) {
198 retval = nr; 198 retval = (nr == -ENOSPC) ? -EAGAIN : nr;
199 goto out_free; 199 goto out_free;
200 } 200 }
201 201
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 5342f6fc022e..0bd595a0b610 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -63,6 +63,12 @@ static DECLARE_SWAIT_QUEUE_HEAD(s2idle_wait_head);
63enum s2idle_states __read_mostly s2idle_state; 63enum s2idle_states __read_mostly s2idle_state;
64static DEFINE_RAW_SPINLOCK(s2idle_lock); 64static DEFINE_RAW_SPINLOCK(s2idle_lock);
65 65
66bool pm_suspend_via_s2idle(void)
67{
68 return mem_sleep_current == PM_SUSPEND_TO_IDLE;
69}
70EXPORT_SYMBOL_GPL(pm_suspend_via_s2idle);
71
66void s2idle_set_ops(const struct platform_s2idle_ops *ops) 72void s2idle_set_ops(const struct platform_s2idle_ops *ops)
67{ 73{
68 lock_system_sleep(); 74 lock_system_sleep();
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index fd6f8ed28e01..9bf5404397e0 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -351,7 +351,6 @@ static int console_msg_format = MSG_FORMAT_DEFAULT;
351 */ 351 */
352 352
353enum log_flags { 353enum log_flags {
354 LOG_NOCONS = 1, /* suppress print, do not print to console */
355 LOG_NEWLINE = 2, /* text ended with a newline */ 354 LOG_NEWLINE = 2, /* text ended with a newline */
356 LOG_PREFIX = 4, /* text started with a prefix */ 355 LOG_PREFIX = 4, /* text started with a prefix */
357 LOG_CONT = 8, /* text is a fragment of a continuation line */ 356 LOG_CONT = 8, /* text is a fragment of a continuation line */
@@ -1881,9 +1880,6 @@ int vprintk_store(int facility, int level,
1881 if (dict) 1880 if (dict)
1882 lflags |= LOG_PREFIX|LOG_NEWLINE; 1881 lflags |= LOG_PREFIX|LOG_NEWLINE;
1883 1882
1884 if (suppress_message_printing(level))
1885 lflags |= LOG_NOCONS;
1886
1887 return log_output(facility, level, lflags, 1883 return log_output(facility, level, lflags,
1888 dict, dictlen, text, text_len); 1884 dict, dictlen, text, text_len);
1889} 1885}
@@ -2032,6 +2028,7 @@ static void call_console_drivers(const char *ext_text, size_t ext_len,
2032 const char *text, size_t len) {} 2028 const char *text, size_t len) {}
2033static size_t msg_print_text(const struct printk_log *msg, 2029static size_t msg_print_text(const struct printk_log *msg,
2034 bool syslog, char *buf, size_t size) { return 0; } 2030 bool syslog, char *buf, size_t size) { return 0; }
2031static bool suppress_message_printing(int level) { return false; }
2035 2032
2036#endif /* CONFIG_PRINTK */ 2033#endif /* CONFIG_PRINTK */
2037 2034
@@ -2368,10 +2365,11 @@ skip:
2368 break; 2365 break;
2369 2366
2370 msg = log_from_idx(console_idx); 2367 msg = log_from_idx(console_idx);
2371 if (msg->flags & LOG_NOCONS) { 2368 if (suppress_message_printing(msg->level)) {
2372 /* 2369 /*
2373 * Skip record if !ignore_loglevel, and 2370 * Skip record we have buffered and already printed
2374 * record has level above the console loglevel. 2371 * directly to the console when we received it, and
2372 * record that has level above the console loglevel.
2375 */ 2373 */
2376 console_idx = log_next(console_idx); 2374 console_idx = log_next(console_idx);
2377 console_seq++; 2375 console_seq++;
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 625bc9897f62..ad97f3ba5ec5 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1167,7 +1167,7 @@ void set_task_cpu(struct task_struct *p, unsigned int new_cpu)
1167 1167
1168 if (task_cpu(p) != new_cpu) { 1168 if (task_cpu(p) != new_cpu) {
1169 if (p->sched_class->migrate_task_rq) 1169 if (p->sched_class->migrate_task_rq)
1170 p->sched_class->migrate_task_rq(p); 1170 p->sched_class->migrate_task_rq(p, new_cpu);
1171 p->se.nr_migrations++; 1171 p->se.nr_migrations++;
1172 rseq_migrate(p); 1172 rseq_migrate(p);
1173 perf_event_task_migrate(p); 1173 perf_event_task_migrate(p);
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 997ea7b839fa..91e4202b0634 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1607,7 +1607,7 @@ out:
1607 return cpu; 1607 return cpu;
1608} 1608}
1609 1609
1610static void migrate_task_rq_dl(struct task_struct *p) 1610static void migrate_task_rq_dl(struct task_struct *p, int new_cpu __maybe_unused)
1611{ 1611{
1612 struct rq *rq; 1612 struct rq *rq;
1613 1613
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 60caf1fb94e0..6383aa6a60ca 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -89,12 +89,12 @@ struct static_key sched_feat_keys[__SCHED_FEAT_NR] = {
89 89
90static void sched_feat_disable(int i) 90static void sched_feat_disable(int i)
91{ 91{
92 static_key_disable(&sched_feat_keys[i]); 92 static_key_disable_cpuslocked(&sched_feat_keys[i]);
93} 93}
94 94
95static void sched_feat_enable(int i) 95static void sched_feat_enable(int i)
96{ 96{
97 static_key_enable(&sched_feat_keys[i]); 97 static_key_enable_cpuslocked(&sched_feat_keys[i]);
98} 98}
99#else 99#else
100static void sched_feat_disable(int i) { }; 100static void sched_feat_disable(int i) { };
@@ -146,9 +146,11 @@ sched_feat_write(struct file *filp, const char __user *ubuf,
146 146
147 /* Ensure the static_key remains in a consistent state */ 147 /* Ensure the static_key remains in a consistent state */
148 inode = file_inode(filp); 148 inode = file_inode(filp);
149 cpus_read_lock();
149 inode_lock(inode); 150 inode_lock(inode);
150 ret = sched_feat_set(cmp); 151 ret = sched_feat_set(cmp);
151 inode_unlock(inode); 152 inode_unlock(inode);
153 cpus_read_unlock();
152 if (ret < 0) 154 if (ret < 0)
153 return ret; 155 return ret;
154 156
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b39fb596f6c1..7fc4a371bdd2 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1392,6 +1392,17 @@ bool should_numa_migrate_memory(struct task_struct *p, struct page * page,
1392 int last_cpupid, this_cpupid; 1392 int last_cpupid, this_cpupid;
1393 1393
1394 this_cpupid = cpu_pid_to_cpupid(dst_cpu, current->pid); 1394 this_cpupid = cpu_pid_to_cpupid(dst_cpu, current->pid);
1395 last_cpupid = page_cpupid_xchg_last(page, this_cpupid);
1396
1397 /*
1398 * Allow first faults or private faults to migrate immediately early in
1399 * the lifetime of a task. The magic number 4 is based on waiting for
1400 * two full passes of the "multi-stage node selection" test that is
1401 * executed below.
1402 */
1403 if ((p->numa_preferred_nid == -1 || p->numa_scan_seq <= 4) &&
1404 (cpupid_pid_unset(last_cpupid) || cpupid_match_pid(p, last_cpupid)))
1405 return true;
1395 1406
1396 /* 1407 /*
1397 * Multi-stage node selection is used in conjunction with a periodic 1408 * Multi-stage node selection is used in conjunction with a periodic
@@ -1410,7 +1421,6 @@ bool should_numa_migrate_memory(struct task_struct *p, struct page * page,
1410 * This quadric squishes small probabilities, making it less likely we 1421 * This quadric squishes small probabilities, making it less likely we
1411 * act on an unlikely task<->page relation. 1422 * act on an unlikely task<->page relation.
1412 */ 1423 */
1413 last_cpupid = page_cpupid_xchg_last(page, this_cpupid);
1414 if (!cpupid_pid_unset(last_cpupid) && 1424 if (!cpupid_pid_unset(last_cpupid) &&
1415 cpupid_to_nid(last_cpupid) != dst_nid) 1425 cpupid_to_nid(last_cpupid) != dst_nid)
1416 return false; 1426 return false;
@@ -1514,6 +1524,21 @@ struct task_numa_env {
1514static void task_numa_assign(struct task_numa_env *env, 1524static void task_numa_assign(struct task_numa_env *env,
1515 struct task_struct *p, long imp) 1525 struct task_struct *p, long imp)
1516{ 1526{
1527 struct rq *rq = cpu_rq(env->dst_cpu);
1528
1529 /* Bail out if run-queue part of active NUMA balance. */
1530 if (xchg(&rq->numa_migrate_on, 1))
1531 return;
1532
1533 /*
1534 * Clear previous best_cpu/rq numa-migrate flag, since task now
1535 * found a better CPU to move/swap.
1536 */
1537 if (env->best_cpu != -1) {
1538 rq = cpu_rq(env->best_cpu);
1539 WRITE_ONCE(rq->numa_migrate_on, 0);
1540 }
1541
1517 if (env->best_task) 1542 if (env->best_task)
1518 put_task_struct(env->best_task); 1543 put_task_struct(env->best_task);
1519 if (p) 1544 if (p)
@@ -1553,6 +1578,13 @@ static bool load_too_imbalanced(long src_load, long dst_load,
1553} 1578}
1554 1579
1555/* 1580/*
1581 * Maximum NUMA importance can be 1998 (2*999);
1582 * SMALLIMP @ 30 would be close to 1998/64.
1583 * Used to deter task migration.
1584 */
1585#define SMALLIMP 30
1586
1587/*
1556 * This checks if the overall compute and NUMA accesses of the system would 1588 * This checks if the overall compute and NUMA accesses of the system would
1557 * be improved if the source tasks was migrated to the target dst_cpu taking 1589 * be improved if the source tasks was migrated to the target dst_cpu taking
1558 * into account that it might be best if task running on the dst_cpu should 1590 * into account that it might be best if task running on the dst_cpu should
@@ -1569,6 +1601,9 @@ static void task_numa_compare(struct task_numa_env *env,
1569 long moveimp = imp; 1601 long moveimp = imp;
1570 int dist = env->dist; 1602 int dist = env->dist;
1571 1603
1604 if (READ_ONCE(dst_rq->numa_migrate_on))
1605 return;
1606
1572 rcu_read_lock(); 1607 rcu_read_lock();
1573 cur = task_rcu_dereference(&dst_rq->curr); 1608 cur = task_rcu_dereference(&dst_rq->curr);
1574 if (cur && ((cur->flags & PF_EXITING) || is_idle_task(cur))) 1609 if (cur && ((cur->flags & PF_EXITING) || is_idle_task(cur)))
@@ -1582,7 +1617,7 @@ static void task_numa_compare(struct task_numa_env *env,
1582 goto unlock; 1617 goto unlock;
1583 1618
1584 if (!cur) { 1619 if (!cur) {
1585 if (maymove || imp > env->best_imp) 1620 if (maymove && moveimp >= env->best_imp)
1586 goto assign; 1621 goto assign;
1587 else 1622 else
1588 goto unlock; 1623 goto unlock;
@@ -1625,16 +1660,22 @@ static void task_numa_compare(struct task_numa_env *env,
1625 task_weight(cur, env->dst_nid, dist); 1660 task_weight(cur, env->dst_nid, dist);
1626 } 1661 }
1627 1662
1628 if (imp <= env->best_imp)
1629 goto unlock;
1630
1631 if (maymove && moveimp > imp && moveimp > env->best_imp) { 1663 if (maymove && moveimp > imp && moveimp > env->best_imp) {
1632 imp = moveimp - 1; 1664 imp = moveimp;
1633 cur = NULL; 1665 cur = NULL;
1634 goto assign; 1666 goto assign;
1635 } 1667 }
1636 1668
1637 /* 1669 /*
1670 * If the NUMA importance is less than SMALLIMP,
1671 * task migration might only result in ping pong
1672 * of tasks and also hurt performance due to cache
1673 * misses.
1674 */
1675 if (imp < SMALLIMP || imp <= env->best_imp + SMALLIMP / 2)
1676 goto unlock;
1677
1678 /*
1638 * In the overloaded case, try and keep the load balanced. 1679 * In the overloaded case, try and keep the load balanced.
1639 */ 1680 */
1640 load = task_h_load(env->p) - task_h_load(cur); 1681 load = task_h_load(env->p) - task_h_load(cur);
@@ -1710,6 +1751,7 @@ static int task_numa_migrate(struct task_struct *p)
1710 .best_cpu = -1, 1751 .best_cpu = -1,
1711 }; 1752 };
1712 struct sched_domain *sd; 1753 struct sched_domain *sd;
1754 struct rq *best_rq;
1713 unsigned long taskweight, groupweight; 1755 unsigned long taskweight, groupweight;
1714 int nid, ret, dist; 1756 int nid, ret, dist;
1715 long taskimp, groupimp; 1757 long taskimp, groupimp;
@@ -1805,20 +1847,17 @@ static int task_numa_migrate(struct task_struct *p)
1805 if (env.best_cpu == -1) 1847 if (env.best_cpu == -1)
1806 return -EAGAIN; 1848 return -EAGAIN;
1807 1849
1808 /* 1850 best_rq = cpu_rq(env.best_cpu);
1809 * Reset the scan period if the task is being rescheduled on an
1810 * alternative node to recheck if the tasks is now properly placed.
1811 */
1812 p->numa_scan_period = task_scan_start(p);
1813
1814 if (env.best_task == NULL) { 1851 if (env.best_task == NULL) {
1815 ret = migrate_task_to(p, env.best_cpu); 1852 ret = migrate_task_to(p, env.best_cpu);
1853 WRITE_ONCE(best_rq->numa_migrate_on, 0);
1816 if (ret != 0) 1854 if (ret != 0)
1817 trace_sched_stick_numa(p, env.src_cpu, env.best_cpu); 1855 trace_sched_stick_numa(p, env.src_cpu, env.best_cpu);
1818 return ret; 1856 return ret;
1819 } 1857 }
1820 1858
1821 ret = migrate_swap(p, env.best_task, env.best_cpu, env.src_cpu); 1859 ret = migrate_swap(p, env.best_task, env.best_cpu, env.src_cpu);
1860 WRITE_ONCE(best_rq->numa_migrate_on, 0);
1822 1861
1823 if (ret != 0) 1862 if (ret != 0)
1824 trace_sched_stick_numa(p, env.src_cpu, task_cpu(env.best_task)); 1863 trace_sched_stick_numa(p, env.src_cpu, task_cpu(env.best_task));
@@ -2596,6 +2635,39 @@ void task_tick_numa(struct rq *rq, struct task_struct *curr)
2596 } 2635 }
2597} 2636}
2598 2637
2638static void update_scan_period(struct task_struct *p, int new_cpu)
2639{
2640 int src_nid = cpu_to_node(task_cpu(p));
2641 int dst_nid = cpu_to_node(new_cpu);
2642
2643 if (!static_branch_likely(&sched_numa_balancing))
2644 return;
2645
2646 if (!p->mm || !p->numa_faults || (p->flags & PF_EXITING))
2647 return;
2648
2649 if (src_nid == dst_nid)
2650 return;
2651
2652 /*
2653 * Allow resets if faults have been trapped before one scan
2654 * has completed. This is most likely due to a new task that
2655 * is pulled cross-node due to wakeups or load balancing.
2656 */
2657 if (p->numa_scan_seq) {
2658 /*
2659 * Avoid scan adjustments if moving to the preferred
2660 * node or if the task was not previously running on
2661 * the preferred node.
2662 */
2663 if (dst_nid == p->numa_preferred_nid ||
2664 (p->numa_preferred_nid != -1 && src_nid != p->numa_preferred_nid))
2665 return;
2666 }
2667
2668 p->numa_scan_period = task_scan_start(p);
2669}
2670
2599#else 2671#else
2600static void task_tick_numa(struct rq *rq, struct task_struct *curr) 2672static void task_tick_numa(struct rq *rq, struct task_struct *curr)
2601{ 2673{
@@ -2609,6 +2681,10 @@ static inline void account_numa_dequeue(struct rq *rq, struct task_struct *p)
2609{ 2681{
2610} 2682}
2611 2683
2684static inline void update_scan_period(struct task_struct *p, int new_cpu)
2685{
2686}
2687
2612#endif /* CONFIG_NUMA_BALANCING */ 2688#endif /* CONFIG_NUMA_BALANCING */
2613 2689
2614static void 2690static void
@@ -3362,6 +3438,7 @@ update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq)
3362 * attach_entity_load_avg - attach this entity to its cfs_rq load avg 3438 * attach_entity_load_avg - attach this entity to its cfs_rq load avg
3363 * @cfs_rq: cfs_rq to attach to 3439 * @cfs_rq: cfs_rq to attach to
3364 * @se: sched_entity to attach 3440 * @se: sched_entity to attach
3441 * @flags: migration hints
3365 * 3442 *
3366 * Must call update_cfs_rq_load_avg() before this, since we rely on 3443 * Must call update_cfs_rq_load_avg() before this, since we rely on
3367 * cfs_rq->avg.last_update_time being current. 3444 * cfs_rq->avg.last_update_time being current.
@@ -6274,7 +6351,7 @@ static void detach_entity_cfs_rq(struct sched_entity *se);
6274 * cfs_rq_of(p) references at time of call are still valid and identify the 6351 * cfs_rq_of(p) references at time of call are still valid and identify the
6275 * previous CPU. The caller guarantees p->pi_lock or task_rq(p)->lock is held. 6352 * previous CPU. The caller guarantees p->pi_lock or task_rq(p)->lock is held.
6276 */ 6353 */
6277static void migrate_task_rq_fair(struct task_struct *p) 6354static void migrate_task_rq_fair(struct task_struct *p, int new_cpu)
6278{ 6355{
6279 /* 6356 /*
6280 * As blocked tasks retain absolute vruntime the migration needs to 6357 * As blocked tasks retain absolute vruntime the migration needs to
@@ -6327,6 +6404,8 @@ static void migrate_task_rq_fair(struct task_struct *p)
6327 6404
6328 /* We have migrated, no longer consider this task hot */ 6405 /* We have migrated, no longer consider this task hot */
6329 p->se.exec_start = 0; 6406 p->se.exec_start = 0;
6407
6408 update_scan_period(p, new_cpu);
6330} 6409}
6331 6410
6332static void task_dead_fair(struct task_struct *p) 6411static void task_dead_fair(struct task_struct *p)
@@ -7263,6 +7342,7 @@ static void update_blocked_averages(int cpu)
7263{ 7342{
7264 struct rq *rq = cpu_rq(cpu); 7343 struct rq *rq = cpu_rq(cpu);
7265 struct cfs_rq *cfs_rq, *pos; 7344 struct cfs_rq *cfs_rq, *pos;
7345 const struct sched_class *curr_class;
7266 struct rq_flags rf; 7346 struct rq_flags rf;
7267 bool done = true; 7347 bool done = true;
7268 7348
@@ -7299,8 +7379,10 @@ static void update_blocked_averages(int cpu)
7299 if (cfs_rq_has_blocked(cfs_rq)) 7379 if (cfs_rq_has_blocked(cfs_rq))
7300 done = false; 7380 done = false;
7301 } 7381 }
7302 update_rt_rq_load_avg(rq_clock_task(rq), rq, 0); 7382
7303 update_dl_rq_load_avg(rq_clock_task(rq), rq, 0); 7383 curr_class = rq->curr->sched_class;
7384 update_rt_rq_load_avg(rq_clock_task(rq), rq, curr_class == &rt_sched_class);
7385 update_dl_rq_load_avg(rq_clock_task(rq), rq, curr_class == &dl_sched_class);
7304 update_irq_load_avg(rq, 0); 7386 update_irq_load_avg(rq, 0);
7305 /* Don't need periodic decay once load/util_avg are null */ 7387 /* Don't need periodic decay once load/util_avg are null */
7306 if (others_have_blocked(rq)) 7388 if (others_have_blocked(rq))
@@ -7365,13 +7447,16 @@ static inline void update_blocked_averages(int cpu)
7365{ 7447{
7366 struct rq *rq = cpu_rq(cpu); 7448 struct rq *rq = cpu_rq(cpu);
7367 struct cfs_rq *cfs_rq = &rq->cfs; 7449 struct cfs_rq *cfs_rq = &rq->cfs;
7450 const struct sched_class *curr_class;
7368 struct rq_flags rf; 7451 struct rq_flags rf;
7369 7452
7370 rq_lock_irqsave(rq, &rf); 7453 rq_lock_irqsave(rq, &rf);
7371 update_rq_clock(rq); 7454 update_rq_clock(rq);
7372 update_cfs_rq_load_avg(cfs_rq_clock_task(cfs_rq), cfs_rq); 7455 update_cfs_rq_load_avg(cfs_rq_clock_task(cfs_rq), cfs_rq);
7373 update_rt_rq_load_avg(rq_clock_task(rq), rq, 0); 7456
7374 update_dl_rq_load_avg(rq_clock_task(rq), rq, 0); 7457 curr_class = rq->curr->sched_class;
7458 update_rt_rq_load_avg(rq_clock_task(rq), rq, curr_class == &rt_sched_class);
7459 update_dl_rq_load_avg(rq_clock_task(rq), rq, curr_class == &dl_sched_class);
7375 update_irq_load_avg(rq, 0); 7460 update_irq_load_avg(rq, 0);
7376#ifdef CONFIG_NO_HZ_COMMON 7461#ifdef CONFIG_NO_HZ_COMMON
7377 rq->last_blocked_load_update_tick = jiffies; 7462 rq->last_blocked_load_update_tick = jiffies;
@@ -7482,10 +7567,10 @@ static inline int get_sd_load_idx(struct sched_domain *sd,
7482 return load_idx; 7567 return load_idx;
7483} 7568}
7484 7569
7485static unsigned long scale_rt_capacity(int cpu) 7570static unsigned long scale_rt_capacity(struct sched_domain *sd, int cpu)
7486{ 7571{
7487 struct rq *rq = cpu_rq(cpu); 7572 struct rq *rq = cpu_rq(cpu);
7488 unsigned long max = arch_scale_cpu_capacity(NULL, cpu); 7573 unsigned long max = arch_scale_cpu_capacity(sd, cpu);
7489 unsigned long used, free; 7574 unsigned long used, free;
7490 unsigned long irq; 7575 unsigned long irq;
7491 7576
@@ -7507,7 +7592,7 @@ static unsigned long scale_rt_capacity(int cpu)
7507 7592
7508static void update_cpu_capacity(struct sched_domain *sd, int cpu) 7593static void update_cpu_capacity(struct sched_domain *sd, int cpu)
7509{ 7594{
7510 unsigned long capacity = scale_rt_capacity(cpu); 7595 unsigned long capacity = scale_rt_capacity(sd, cpu);
7511 struct sched_group *sdg = sd->groups; 7596 struct sched_group *sdg = sd->groups;
7512 7597
7513 cpu_rq(cpu)->cpu_capacity_orig = arch_scale_cpu_capacity(sd, cpu); 7598 cpu_rq(cpu)->cpu_capacity_orig = arch_scale_cpu_capacity(sd, cpu);
@@ -8269,7 +8354,7 @@ static struct sched_group *find_busiest_group(struct lb_env *env)
8269force_balance: 8354force_balance:
8270 /* Looks like there is an imbalance. Compute it */ 8355 /* Looks like there is an imbalance. Compute it */
8271 calculate_imbalance(env, &sds); 8356 calculate_imbalance(env, &sds);
8272 return sds.busiest; 8357 return env->imbalance ? sds.busiest : NULL;
8273 8358
8274out_balanced: 8359out_balanced:
8275 env->imbalance = 0; 8360 env->imbalance = 0;
@@ -9638,7 +9723,8 @@ static inline bool vruntime_normalized(struct task_struct *p)
9638 * - A task which has been woken up by try_to_wake_up() and 9723 * - A task which has been woken up by try_to_wake_up() and
9639 * waiting for actually being woken up by sched_ttwu_pending(). 9724 * waiting for actually being woken up by sched_ttwu_pending().
9640 */ 9725 */
9641 if (!se->sum_exec_runtime || p->state == TASK_WAKING) 9726 if (!se->sum_exec_runtime ||
9727 (p->state == TASK_WAKING && p->sched_remote_wakeup))
9642 return true; 9728 return true;
9643 9729
9644 return false; 9730 return false;
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 4a2e8cae63c4..455fa330de04 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -783,6 +783,7 @@ struct rq {
783#ifdef CONFIG_NUMA_BALANCING 783#ifdef CONFIG_NUMA_BALANCING
784 unsigned int nr_numa_running; 784 unsigned int nr_numa_running;
785 unsigned int nr_preferred_running; 785 unsigned int nr_preferred_running;
786 unsigned int numa_migrate_on;
786#endif 787#endif
787 #define CPU_LOAD_IDX_MAX 5 788 #define CPU_LOAD_IDX_MAX 5
788 unsigned long cpu_load[CPU_LOAD_IDX_MAX]; 789 unsigned long cpu_load[CPU_LOAD_IDX_MAX];
@@ -1523,7 +1524,7 @@ struct sched_class {
1523 1524
1524#ifdef CONFIG_SMP 1525#ifdef CONFIG_SMP
1525 int (*select_task_rq)(struct task_struct *p, int task_cpu, int sd_flag, int flags); 1526 int (*select_task_rq)(struct task_struct *p, int task_cpu, int sd_flag, int flags);
1526 void (*migrate_task_rq)(struct task_struct *p); 1527 void (*migrate_task_rq)(struct task_struct *p, int new_cpu);
1527 1528
1528 void (*task_woken)(struct rq *this_rq, struct task_struct *task); 1529 void (*task_woken)(struct rq *this_rq, struct task_struct *task);
1529 1530
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 56a0fed30c0a..505a41c42b96 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1295,7 +1295,7 @@ static void init_numa_topology_type(void)
1295 1295
1296 n = sched_max_numa_distance; 1296 n = sched_max_numa_distance;
1297 1297
1298 if (sched_domains_numa_levels <= 1) { 1298 if (sched_domains_numa_levels <= 2) {
1299 sched_numa_topology_type = NUMA_DIRECT; 1299 sched_numa_topology_type = NUMA_DIRECT;
1300 return; 1300 return;
1301 } 1301 }
@@ -1380,9 +1380,6 @@ void sched_init_numa(void)
1380 break; 1380 break;
1381 } 1381 }
1382 1382
1383 if (!level)
1384 return;
1385
1386 /* 1383 /*
1387 * 'level' contains the number of unique distances 1384 * 'level' contains the number of unique distances
1388 * 1385 *
diff --git a/kernel/sys.c b/kernel/sys.c
index cf5c67533ff1..123bd73046ec 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -71,9 +71,6 @@
71#include <asm/io.h> 71#include <asm/io.h>
72#include <asm/unistd.h> 72#include <asm/unistd.h>
73 73
74/* Hardening for Spectre-v1 */
75#include <linux/nospec.h>
76
77#include "uid16.h" 74#include "uid16.h"
78 75
79#ifndef SET_UNALIGN_CTL 76#ifndef SET_UNALIGN_CTL
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 1d92d4a982fd..65bd4616220d 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1546,6 +1546,8 @@ rb_remove_pages(struct ring_buffer_per_cpu *cpu_buffer, unsigned long nr_pages)
1546 tmp_iter_page = first_page; 1546 tmp_iter_page = first_page;
1547 1547
1548 do { 1548 do {
1549 cond_resched();
1550
1549 to_remove_page = tmp_iter_page; 1551 to_remove_page = tmp_iter_page;
1550 rb_inc_page(cpu_buffer, &tmp_iter_page); 1552 rb_inc_page(cpu_buffer, &tmp_iter_page);
1551 1553
diff --git a/lib/Makefile b/lib/Makefile
index ca3f7ebb900d..423876446810 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -119,7 +119,6 @@ obj-$(CONFIG_ZLIB_INFLATE) += zlib_inflate/
119obj-$(CONFIG_ZLIB_DEFLATE) += zlib_deflate/ 119obj-$(CONFIG_ZLIB_DEFLATE) += zlib_deflate/
120obj-$(CONFIG_REED_SOLOMON) += reed_solomon/ 120obj-$(CONFIG_REED_SOLOMON) += reed_solomon/
121obj-$(CONFIG_BCH) += bch.o 121obj-$(CONFIG_BCH) += bch.o
122CFLAGS_bch.o := $(call cc-option,-Wframe-larger-than=4500)
123obj-$(CONFIG_LZO_COMPRESS) += lzo/ 122obj-$(CONFIG_LZO_COMPRESS) += lzo/
124obj-$(CONFIG_LZO_DECOMPRESS) += lzo/ 123obj-$(CONFIG_LZO_DECOMPRESS) += lzo/
125obj-$(CONFIG_LZ4_COMPRESS) += lz4/ 124obj-$(CONFIG_LZ4_COMPRESS) += lz4/
diff --git a/lib/bch.c b/lib/bch.c
index 7b0f2006698b..5db6d3a4c8a6 100644
--- a/lib/bch.c
+++ b/lib/bch.c
@@ -79,20 +79,19 @@
79#define GF_T(_p) (CONFIG_BCH_CONST_T) 79#define GF_T(_p) (CONFIG_BCH_CONST_T)
80#define GF_N(_p) ((1 << (CONFIG_BCH_CONST_M))-1) 80#define GF_N(_p) ((1 << (CONFIG_BCH_CONST_M))-1)
81#define BCH_MAX_M (CONFIG_BCH_CONST_M) 81#define BCH_MAX_M (CONFIG_BCH_CONST_M)
82#define BCH_MAX_T (CONFIG_BCH_CONST_T)
82#else 83#else
83#define GF_M(_p) ((_p)->m) 84#define GF_M(_p) ((_p)->m)
84#define GF_T(_p) ((_p)->t) 85#define GF_T(_p) ((_p)->t)
85#define GF_N(_p) ((_p)->n) 86#define GF_N(_p) ((_p)->n)
86#define BCH_MAX_M 15 87#define BCH_MAX_M 15 /* 2KB */
88#define BCH_MAX_T 64 /* 64 bit correction */
87#endif 89#endif
88 90
89#define BCH_MAX_T (((1 << BCH_MAX_M) - 1) / BCH_MAX_M)
90
91#define BCH_ECC_WORDS(_p) DIV_ROUND_UP(GF_M(_p)*GF_T(_p), 32) 91#define BCH_ECC_WORDS(_p) DIV_ROUND_UP(GF_M(_p)*GF_T(_p), 32)
92#define BCH_ECC_BYTES(_p) DIV_ROUND_UP(GF_M(_p)*GF_T(_p), 8) 92#define BCH_ECC_BYTES(_p) DIV_ROUND_UP(GF_M(_p)*GF_T(_p), 8)
93 93
94#define BCH_ECC_MAX_WORDS DIV_ROUND_UP(BCH_MAX_M * BCH_MAX_T, 32) 94#define BCH_ECC_MAX_WORDS DIV_ROUND_UP(BCH_MAX_M * BCH_MAX_T, 32)
95#define BCH_ECC_MAX_BYTES DIV_ROUND_UP(BCH_MAX_M * BCH_MAX_T, 8)
96 95
97#ifndef dbg 96#ifndef dbg
98#define dbg(_fmt, args...) do {} while (0) 97#define dbg(_fmt, args...) do {} while (0)
@@ -202,6 +201,9 @@ void encode_bch(struct bch_control *bch, const uint8_t *data,
202 const uint32_t * const tab3 = tab2 + 256*(l+1); 201 const uint32_t * const tab3 = tab2 + 256*(l+1);
203 const uint32_t *pdata, *p0, *p1, *p2, *p3; 202 const uint32_t *pdata, *p0, *p1, *p2, *p3;
204 203
204 if (WARN_ON(r_bytes > sizeof(r)))
205 return;
206
205 if (ecc) { 207 if (ecc) {
206 /* load ecc parity bytes into internal 32-bit buffer */ 208 /* load ecc parity bytes into internal 32-bit buffer */
207 load_ecc8(bch, bch->ecc_buf, ecc); 209 load_ecc8(bch, bch->ecc_buf, ecc);
@@ -1285,6 +1287,13 @@ struct bch_control *init_bch(int m, int t, unsigned int prim_poly)
1285 */ 1287 */
1286 goto fail; 1288 goto fail;
1287 1289
1290 if (t > BCH_MAX_T)
1291 /*
1292 * we can support larger than 64 bits if necessary, at the
1293 * cost of higher stack usage.
1294 */
1295 goto fail;
1296
1288 /* sanity checks */ 1297 /* sanity checks */
1289 if ((t < 1) || (m*t >= ((1 << m)-1))) 1298 if ((t < 1) || (m*t >= ((1 << m)-1)))
1290 /* invalid t value */ 1299 /* invalid t value */
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index d5b3a3f95c01..812e59e13fe6 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -2794,7 +2794,7 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
2794 copy = end - str; 2794 copy = end - str;
2795 memcpy(str, args, copy); 2795 memcpy(str, args, copy);
2796 str += len; 2796 str += len;
2797 args += len; 2797 args += len + 1;
2798 } 2798 }
2799 } 2799 }
2800 if (process) 2800 if (process)
diff --git a/lib/xz/xz_crc32.c b/lib/xz/xz_crc32.c
index 25a5d87e2e4c..912aae5fa09e 100644
--- a/lib/xz/xz_crc32.c
+++ b/lib/xz/xz_crc32.c
@@ -15,7 +15,6 @@
15 * but they are bigger and use more memory for the lookup table. 15 * but they are bigger and use more memory for the lookup table.
16 */ 16 */
17 17
18#include <linux/crc32poly.h>
19#include "xz_private.h" 18#include "xz_private.h"
20 19
21/* 20/*
diff --git a/lib/xz/xz_private.h b/lib/xz/xz_private.h
index 482b90f363fe..09360ebb510e 100644
--- a/lib/xz/xz_private.h
+++ b/lib/xz/xz_private.h
@@ -102,6 +102,10 @@
102# endif 102# endif
103#endif 103#endif
104 104
105#ifndef CRC32_POLY_LE
106#define CRC32_POLY_LE 0xedb88320
107#endif
108
105/* 109/*
106 * Allocate memory for LZMA2 decoder. xz_dec_lzma2_reset() must be used 110 * Allocate memory for LZMA2 decoder. xz_dec_lzma2_reset() must be used
107 * before calling xz_dec_lzma2_run(). 111 * before calling xz_dec_lzma2_run().
diff --git a/mm/Kconfig b/mm/Kconfig
index a550635ea5c3..de64ea658716 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -637,6 +637,7 @@ config DEFERRED_STRUCT_PAGE_INIT
637 depends on NO_BOOTMEM 637 depends on NO_BOOTMEM
638 depends on SPARSEMEM 638 depends on SPARSEMEM
639 depends on !NEED_PER_CPU_KM 639 depends on !NEED_PER_CPU_KM
640 depends on 64BIT
640 help 641 help
641 Ordinarily all struct pages are initialised during early boot in a 642 Ordinarily all struct pages are initialised during early boot in a
642 single thread. On very large machines this can take a considerable 643 single thread. On very large machines this can take a considerable
diff --git a/mm/Makefile b/mm/Makefile
index 8716bdabe1e6..26ef77a3883b 100644
--- a/mm/Makefile
+++ b/mm/Makefile
@@ -32,7 +32,7 @@ ifdef CONFIG_CROSS_MEMORY_ATTACH
32mmu-$(CONFIG_MMU) += process_vm_access.o 32mmu-$(CONFIG_MMU) += process_vm_access.o
33endif 33endif
34 34
35obj-y := filemap.o mempool.o oom_kill.o \ 35obj-y := filemap.o mempool.o oom_kill.o fadvise.o \
36 maccess.o page_alloc.o page-writeback.o \ 36 maccess.o page_alloc.o page-writeback.o \
37 readahead.o swap.o truncate.o vmscan.o shmem.o \ 37 readahead.o swap.o truncate.o vmscan.o shmem.o \
38 util.o mmzone.o vmstat.o backing-dev.o \ 38 util.o mmzone.o vmstat.o backing-dev.o \
@@ -49,7 +49,6 @@ else
49 obj-y += bootmem.o 49 obj-y += bootmem.o
50endif 50endif
51 51
52obj-$(CONFIG_ADVISE_SYSCALLS) += fadvise.o
53ifdef CONFIG_MMU 52ifdef CONFIG_MMU
54 obj-$(CONFIG_ADVISE_SYSCALLS) += madvise.o 53 obj-$(CONFIG_ADVISE_SYSCALLS) += madvise.o
55endif 54endif
diff --git a/mm/debug.c b/mm/debug.c
index 38c926520c97..bd10aad8539a 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -114,7 +114,7 @@ EXPORT_SYMBOL(dump_vma);
114 114
115void dump_mm(const struct mm_struct *mm) 115void dump_mm(const struct mm_struct *mm)
116{ 116{
117 pr_emerg("mm %px mmap %px seqnum %d task_size %lu\n" 117 pr_emerg("mm %px mmap %px seqnum %llu task_size %lu\n"
118#ifdef CONFIG_MMU 118#ifdef CONFIG_MMU
119 "get_unmapped_area %px\n" 119 "get_unmapped_area %px\n"
120#endif 120#endif
@@ -142,7 +142,7 @@ void dump_mm(const struct mm_struct *mm)
142 "tlb_flush_pending %d\n" 142 "tlb_flush_pending %d\n"
143 "def_flags: %#lx(%pGv)\n", 143 "def_flags: %#lx(%pGv)\n",
144 144
145 mm, mm->mmap, mm->vmacache_seqnum, mm->task_size, 145 mm, mm->mmap, (long long) mm->vmacache_seqnum, mm->task_size,
146#ifdef CONFIG_MMU 146#ifdef CONFIG_MMU
147 mm->get_unmapped_area, 147 mm->get_unmapped_area,
148#endif 148#endif
diff --git a/mm/fadvise.c b/mm/fadvise.c
index 2d8376e3c640..467bcd032037 100644
--- a/mm/fadvise.c
+++ b/mm/fadvise.c
@@ -27,9 +27,9 @@
27 * deactivate the pages and clear PG_Referenced. 27 * deactivate the pages and clear PG_Referenced.
28 */ 28 */
29 29
30int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice) 30static int generic_fadvise(struct file *file, loff_t offset, loff_t len,
31 int advice)
31{ 32{
32 struct fd f = fdget(fd);
33 struct inode *inode; 33 struct inode *inode;
34 struct address_space *mapping; 34 struct address_space *mapping;
35 struct backing_dev_info *bdi; 35 struct backing_dev_info *bdi;
@@ -37,22 +37,14 @@ int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice)
37 pgoff_t start_index; 37 pgoff_t start_index;
38 pgoff_t end_index; 38 pgoff_t end_index;
39 unsigned long nrpages; 39 unsigned long nrpages;
40 int ret = 0;
41
42 if (!f.file)
43 return -EBADF;
44 40
45 inode = file_inode(f.file); 41 inode = file_inode(file);
46 if (S_ISFIFO(inode->i_mode)) { 42 if (S_ISFIFO(inode->i_mode))
47 ret = -ESPIPE; 43 return -ESPIPE;
48 goto out;
49 }
50 44
51 mapping = f.file->f_mapping; 45 mapping = file->f_mapping;
52 if (!mapping || len < 0) { 46 if (!mapping || len < 0)
53 ret = -EINVAL; 47 return -EINVAL;
54 goto out;
55 }
56 48
57 bdi = inode_to_bdi(mapping->host); 49 bdi = inode_to_bdi(mapping->host);
58 50
@@ -67,9 +59,9 @@ int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice)
67 /* no bad return value, but ignore advice */ 59 /* no bad return value, but ignore advice */
68 break; 60 break;
69 default: 61 default:
70 ret = -EINVAL; 62 return -EINVAL;
71 } 63 }
72 goto out; 64 return 0;
73 } 65 }
74 66
75 /* 67 /*
@@ -85,21 +77,21 @@ int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice)
85 77
86 switch (advice) { 78 switch (advice) {
87 case POSIX_FADV_NORMAL: 79 case POSIX_FADV_NORMAL:
88 f.file->f_ra.ra_pages = bdi->ra_pages; 80 file->f_ra.ra_pages = bdi->ra_pages;
89 spin_lock(&f.file->f_lock); 81 spin_lock(&file->f_lock);
90 f.file->f_mode &= ~FMODE_RANDOM; 82 file->f_mode &= ~FMODE_RANDOM;
91 spin_unlock(&f.file->f_lock); 83 spin_unlock(&file->f_lock);
92 break; 84 break;
93 case POSIX_FADV_RANDOM: 85 case POSIX_FADV_RANDOM:
94 spin_lock(&f.file->f_lock); 86 spin_lock(&file->f_lock);
95 f.file->f_mode |= FMODE_RANDOM; 87 file->f_mode |= FMODE_RANDOM;
96 spin_unlock(&f.file->f_lock); 88 spin_unlock(&file->f_lock);
97 break; 89 break;
98 case POSIX_FADV_SEQUENTIAL: 90 case POSIX_FADV_SEQUENTIAL:
99 f.file->f_ra.ra_pages = bdi->ra_pages * 2; 91 file->f_ra.ra_pages = bdi->ra_pages * 2;
100 spin_lock(&f.file->f_lock); 92 spin_lock(&file->f_lock);
101 f.file->f_mode &= ~FMODE_RANDOM; 93 file->f_mode &= ~FMODE_RANDOM;
102 spin_unlock(&f.file->f_lock); 94 spin_unlock(&file->f_lock);
103 break; 95 break;
104 case POSIX_FADV_WILLNEED: 96 case POSIX_FADV_WILLNEED:
105 /* First and last PARTIAL page! */ 97 /* First and last PARTIAL page! */
@@ -115,8 +107,7 @@ int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice)
115 * Ignore return value because fadvise() shall return 107 * Ignore return value because fadvise() shall return
116 * success even if filesystem can't retrieve a hint, 108 * success even if filesystem can't retrieve a hint,
117 */ 109 */
118 force_page_cache_readahead(mapping, f.file, start_index, 110 force_page_cache_readahead(mapping, file, start_index, nrpages);
119 nrpages);
120 break; 111 break;
121 case POSIX_FADV_NOREUSE: 112 case POSIX_FADV_NOREUSE:
122 break; 113 break;
@@ -183,9 +174,32 @@ int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice)
183 } 174 }
184 break; 175 break;
185 default: 176 default:
186 ret = -EINVAL; 177 return -EINVAL;
187 } 178 }
188out: 179 return 0;
180}
181
182int vfs_fadvise(struct file *file, loff_t offset, loff_t len, int advice)
183{
184 if (file->f_op->fadvise)
185 return file->f_op->fadvise(file, offset, len, advice);
186
187 return generic_fadvise(file, offset, len, advice);
188}
189EXPORT_SYMBOL(vfs_fadvise);
190
191#ifdef CONFIG_ADVISE_SYSCALLS
192
193int ksys_fadvise64_64(int fd, loff_t offset, loff_t len, int advice)
194{
195 struct fd f = fdget(fd);
196 int ret;
197
198 if (!f.file)
199 return -EBADF;
200
201 ret = vfs_fadvise(f.file, offset, len, advice);
202
189 fdput(f); 203 fdput(f);
190 return ret; 204 return ret;
191} 205}
@@ -203,3 +217,4 @@ SYSCALL_DEFINE4(fadvise64, int, fd, loff_t, offset, size_t, len, int, advice)
203} 217}
204 218
205#endif 219#endif
220#endif
diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c
index 6a473709e9b6..7405c9d89d65 100644
--- a/mm/gup_benchmark.c
+++ b/mm/gup_benchmark.c
@@ -19,7 +19,8 @@ static int __gup_benchmark_ioctl(unsigned int cmd,
19 struct gup_benchmark *gup) 19 struct gup_benchmark *gup)
20{ 20{
21 ktime_t start_time, end_time; 21 ktime_t start_time, end_time;
22 unsigned long i, nr, nr_pages, addr, next; 22 unsigned long i, nr_pages, addr, next;
23 int nr;
23 struct page **pages; 24 struct page **pages;
24 25
25 nr_pages = gup->size / PAGE_SIZE; 26 nr_pages = gup->size / PAGE_SIZE;
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 533f9b00147d..58269f8ba7c4 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2885,9 +2885,6 @@ void set_pmd_migration_entry(struct page_vma_mapped_walk *pvmw,
2885 if (!(pvmw->pmd && !pvmw->pte)) 2885 if (!(pvmw->pmd && !pvmw->pte))
2886 return; 2886 return;
2887 2887
2888 mmu_notifier_invalidate_range_start(mm, address,
2889 address + HPAGE_PMD_SIZE);
2890
2891 flush_cache_range(vma, address, address + HPAGE_PMD_SIZE); 2888 flush_cache_range(vma, address, address + HPAGE_PMD_SIZE);
2892 pmdval = *pvmw->pmd; 2889 pmdval = *pvmw->pmd;
2893 pmdp_invalidate(vma, address, pvmw->pmd); 2890 pmdp_invalidate(vma, address, pvmw->pmd);
@@ -2900,9 +2897,6 @@ void set_pmd_migration_entry(struct page_vma_mapped_walk *pvmw,
2900 set_pmd_at(mm, address, pvmw->pmd, pmdswp); 2897 set_pmd_at(mm, address, pvmw->pmd, pmdswp);
2901 page_remove_rmap(page, true); 2898 page_remove_rmap(page, true);
2902 put_page(page); 2899 put_page(page);
2903
2904 mmu_notifier_invalidate_range_end(mm, address,
2905 address + HPAGE_PMD_SIZE);
2906} 2900}
2907 2901
2908void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new) 2902void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
@@ -2931,7 +2925,7 @@ void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
2931 else 2925 else
2932 page_add_file_rmap(new, true); 2926 page_add_file_rmap(new, true);
2933 set_pmd_at(mm, mmun_start, pvmw->pmd, pmde); 2927 set_pmd_at(mm, mmun_start, pvmw->pmd, pmde);
2934 if (vma->vm_flags & VM_LOCKED) 2928 if ((vma->vm_flags & VM_LOCKED) && !PageDoubleMap(new))
2935 mlock_vma_page(new); 2929 mlock_vma_page(new);
2936 update_mmu_cache_pmd(vma, address, pvmw->pmd); 2930 update_mmu_cache_pmd(vma, address, pvmw->pmd);
2937} 2931}
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3c21775f196b..5c390f5a5207 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3326,8 +3326,8 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
3326 struct page *page; 3326 struct page *page;
3327 struct hstate *h = hstate_vma(vma); 3327 struct hstate *h = hstate_vma(vma);
3328 unsigned long sz = huge_page_size(h); 3328 unsigned long sz = huge_page_size(h);
3329 const unsigned long mmun_start = start; /* For mmu_notifiers */ 3329 unsigned long mmun_start = start; /* For mmu_notifiers */
3330 const unsigned long mmun_end = end; /* For mmu_notifiers */ 3330 unsigned long mmun_end = end; /* For mmu_notifiers */
3331 3331
3332 WARN_ON(!is_vm_hugetlb_page(vma)); 3332 WARN_ON(!is_vm_hugetlb_page(vma));
3333 BUG_ON(start & ~huge_page_mask(h)); 3333 BUG_ON(start & ~huge_page_mask(h));
@@ -3339,6 +3339,11 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
3339 */ 3339 */
3340 tlb_remove_check_page_size_change(tlb, sz); 3340 tlb_remove_check_page_size_change(tlb, sz);
3341 tlb_start_vma(tlb, vma); 3341 tlb_start_vma(tlb, vma);
3342
3343 /*
3344 * If sharing possible, alert mmu notifiers of worst case.
3345 */
3346 adjust_range_if_pmd_sharing_possible(vma, &mmun_start, &mmun_end);
3342 mmu_notifier_invalidate_range_start(mm, mmun_start, mmun_end); 3347 mmu_notifier_invalidate_range_start(mm, mmun_start, mmun_end);
3343 address = start; 3348 address = start;
3344 for (; address < end; address += sz) { 3349 for (; address < end; address += sz) {
@@ -3349,6 +3354,10 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
3349 ptl = huge_pte_lock(h, mm, ptep); 3354 ptl = huge_pte_lock(h, mm, ptep);
3350 if (huge_pmd_unshare(mm, &address, ptep)) { 3355 if (huge_pmd_unshare(mm, &address, ptep)) {
3351 spin_unlock(ptl); 3356 spin_unlock(ptl);
3357 /*
3358 * We just unmapped a page of PMDs by clearing a PUD.
3359 * The caller's TLB flush range should cover this area.
3360 */
3352 continue; 3361 continue;
3353 } 3362 }
3354 3363
@@ -3431,12 +3440,23 @@ void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,
3431{ 3440{
3432 struct mm_struct *mm; 3441 struct mm_struct *mm;
3433 struct mmu_gather tlb; 3442 struct mmu_gather tlb;
3443 unsigned long tlb_start = start;
3444 unsigned long tlb_end = end;
3445
3446 /*
3447 * If shared PMDs were possibly used within this vma range, adjust
3448 * start/end for worst case tlb flushing.
3449 * Note that we can not be sure if PMDs are shared until we try to
3450 * unmap pages. However, we want to make sure TLB flushing covers
3451 * the largest possible range.
3452 */
3453 adjust_range_if_pmd_sharing_possible(vma, &tlb_start, &tlb_end);
3434 3454
3435 mm = vma->vm_mm; 3455 mm = vma->vm_mm;
3436 3456
3437 tlb_gather_mmu(&tlb, mm, start, end); 3457 tlb_gather_mmu(&tlb, mm, tlb_start, tlb_end);
3438 __unmap_hugepage_range(&tlb, vma, start, end, ref_page); 3458 __unmap_hugepage_range(&tlb, vma, start, end, ref_page);
3439 tlb_finish_mmu(&tlb, start, end); 3459 tlb_finish_mmu(&tlb, tlb_start, tlb_end);
3440} 3460}
3441 3461
3442/* 3462/*
@@ -4298,11 +4318,21 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
4298 pte_t pte; 4318 pte_t pte;
4299 struct hstate *h = hstate_vma(vma); 4319 struct hstate *h = hstate_vma(vma);
4300 unsigned long pages = 0; 4320 unsigned long pages = 0;
4321 unsigned long f_start = start;
4322 unsigned long f_end = end;
4323 bool shared_pmd = false;
4324
4325 /*
4326 * In the case of shared PMDs, the area to flush could be beyond
4327 * start/end. Set f_start/f_end to cover the maximum possible
4328 * range if PMD sharing is possible.
4329 */
4330 adjust_range_if_pmd_sharing_possible(vma, &f_start, &f_end);
4301 4331
4302 BUG_ON(address >= end); 4332 BUG_ON(address >= end);
4303 flush_cache_range(vma, address, end); 4333 flush_cache_range(vma, f_start, f_end);
4304 4334
4305 mmu_notifier_invalidate_range_start(mm, start, end); 4335 mmu_notifier_invalidate_range_start(mm, f_start, f_end);
4306 i_mmap_lock_write(vma->vm_file->f_mapping); 4336 i_mmap_lock_write(vma->vm_file->f_mapping);
4307 for (; address < end; address += huge_page_size(h)) { 4337 for (; address < end; address += huge_page_size(h)) {
4308 spinlock_t *ptl; 4338 spinlock_t *ptl;
@@ -4313,6 +4343,7 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
4313 if (huge_pmd_unshare(mm, &address, ptep)) { 4343 if (huge_pmd_unshare(mm, &address, ptep)) {
4314 pages++; 4344 pages++;
4315 spin_unlock(ptl); 4345 spin_unlock(ptl);
4346 shared_pmd = true;
4316 continue; 4347 continue;
4317 } 4348 }
4318 pte = huge_ptep_get(ptep); 4349 pte = huge_ptep_get(ptep);
@@ -4348,9 +4379,13 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
4348 * Must flush TLB before releasing i_mmap_rwsem: x86's huge_pmd_unshare 4379 * Must flush TLB before releasing i_mmap_rwsem: x86's huge_pmd_unshare
4349 * may have cleared our pud entry and done put_page on the page table: 4380 * may have cleared our pud entry and done put_page on the page table:
4350 * once we release i_mmap_rwsem, another task can do the final put_page 4381 * once we release i_mmap_rwsem, another task can do the final put_page
4351 * and that page table be reused and filled with junk. 4382 * and that page table be reused and filled with junk. If we actually
4383 * did unshare a page of pmds, flush the range corresponding to the pud.
4352 */ 4384 */
4353 flush_hugetlb_tlb_range(vma, start, end); 4385 if (shared_pmd)
4386 flush_hugetlb_tlb_range(vma, f_start, f_end);
4387 else
4388 flush_hugetlb_tlb_range(vma, start, end);
4354 /* 4389 /*
4355 * No need to call mmu_notifier_invalidate_range() we are downgrading 4390 * No need to call mmu_notifier_invalidate_range() we are downgrading
4356 * page table protection not changing it to point to a new page. 4391 * page table protection not changing it to point to a new page.
@@ -4358,7 +4393,7 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
4358 * See Documentation/vm/mmu_notifier.rst 4393 * See Documentation/vm/mmu_notifier.rst
4359 */ 4394 */
4360 i_mmap_unlock_write(vma->vm_file->f_mapping); 4395 i_mmap_unlock_write(vma->vm_file->f_mapping);
4361 mmu_notifier_invalidate_range_end(mm, start, end); 4396 mmu_notifier_invalidate_range_end(mm, f_start, f_end);
4362 4397
4363 return pages << h->order; 4398 return pages << h->order;
4364} 4399}
@@ -4545,13 +4580,41 @@ static bool vma_shareable(struct vm_area_struct *vma, unsigned long addr)
4545 /* 4580 /*
4546 * check on proper vm_flags and page table alignment 4581 * check on proper vm_flags and page table alignment
4547 */ 4582 */
4548 if (vma->vm_flags & VM_MAYSHARE && 4583 if (vma->vm_flags & VM_MAYSHARE && range_in_vma(vma, base, end))
4549 vma->vm_start <= base && end <= vma->vm_end)
4550 return true; 4584 return true;
4551 return false; 4585 return false;
4552} 4586}
4553 4587
4554/* 4588/*
4589 * Determine if start,end range within vma could be mapped by shared pmd.
4590 * If yes, adjust start and end to cover range associated with possible
4591 * shared pmd mappings.
4592 */
4593void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
4594 unsigned long *start, unsigned long *end)
4595{
4596 unsigned long check_addr = *start;
4597
4598 if (!(vma->vm_flags & VM_MAYSHARE))
4599 return;
4600
4601 for (check_addr = *start; check_addr < *end; check_addr += PUD_SIZE) {
4602 unsigned long a_start = check_addr & PUD_MASK;
4603 unsigned long a_end = a_start + PUD_SIZE;
4604
4605 /*
4606 * If sharing is possible, adjust start/end if necessary.
4607 */
4608 if (range_in_vma(vma, a_start, a_end)) {
4609 if (a_start < *start)
4610 *start = a_start;
4611 if (a_end > *end)
4612 *end = a_end;
4613 }
4614 }
4615}
4616
4617/*
4555 * Search for a shareable pmd page for hugetlb. In any case calls pmd_alloc() 4618 * Search for a shareable pmd page for hugetlb. In any case calls pmd_alloc()
4556 * and returns the corresponding pte. While this is not necessary for the 4619 * and returns the corresponding pte. While this is not necessary for the
4557 * !shared pmd case because we can allocate the pmd later as well, it makes the 4620 * !shared pmd case because we can allocate the pmd later as well, it makes the
@@ -4648,6 +4711,11 @@ int huge_pmd_unshare(struct mm_struct *mm, unsigned long *addr, pte_t *ptep)
4648{ 4711{
4649 return 0; 4712 return 0;
4650} 4713}
4714
4715void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
4716 unsigned long *start, unsigned long *end)
4717{
4718}
4651#define want_pmd_share() (0) 4719#define want_pmd_share() (0)
4652#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ 4720#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */
4653 4721
diff --git a/mm/madvise.c b/mm/madvise.c
index 972a9eaa898b..71d21df2a3f3 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -96,7 +96,7 @@ static long madvise_behavior(struct vm_area_struct *vma,
96 new_flags |= VM_DONTDUMP; 96 new_flags |= VM_DONTDUMP;
97 break; 97 break;
98 case MADV_DODUMP: 98 case MADV_DODUMP:
99 if (new_flags & VM_SPECIAL) { 99 if (!is_vm_hugetlb_page(vma) && new_flags & VM_SPECIAL) {
100 error = -EINVAL; 100 error = -EINVAL;
101 goto out; 101 goto out;
102 } 102 }
diff --git a/mm/migrate.c b/mm/migrate.c
index d6a2e89b086a..84381b55b2bd 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -275,6 +275,9 @@ static bool remove_migration_pte(struct page *page, struct vm_area_struct *vma,
275 if (vma->vm_flags & VM_LOCKED && !PageTransCompound(new)) 275 if (vma->vm_flags & VM_LOCKED && !PageTransCompound(new))
276 mlock_vma_page(new); 276 mlock_vma_page(new);
277 277
278 if (PageTransHuge(page) && PageMlocked(page))
279 clear_page_mlock(page);
280
278 /* No need to invalidate - it was non-present before */ 281 /* No need to invalidate - it was non-present before */
279 update_mmu_cache(vma, pvmw.address, pvmw.pte); 282 update_mmu_cache(vma, pvmw.address, pvmw.pte);
280 } 283 }
@@ -1411,7 +1414,7 @@ retry:
1411 * we encounter them after the rest of the list 1414 * we encounter them after the rest of the list
1412 * is processed. 1415 * is processed.
1413 */ 1416 */
1414 if (PageTransHuge(page)) { 1417 if (PageTransHuge(page) && !PageHuge(page)) {
1415 lock_page(page); 1418 lock_page(page);
1416 rc = split_huge_page_to_list(page, from); 1419 rc = split_huge_page_to_list(page, from);
1417 unlock_page(page); 1420 unlock_page(page);
@@ -1855,46 +1858,6 @@ static struct page *alloc_misplaced_dst_page(struct page *page,
1855 return newpage; 1858 return newpage;
1856} 1859}
1857 1860
1858/*
1859 * page migration rate limiting control.
1860 * Do not migrate more than @pages_to_migrate in a @migrate_interval_millisecs
1861 * window of time. Default here says do not migrate more than 1280M per second.
1862 */
1863static unsigned int migrate_interval_millisecs __read_mostly = 100;
1864static unsigned int ratelimit_pages __read_mostly = 128 << (20 - PAGE_SHIFT);
1865
1866/* Returns true if the node is migrate rate-limited after the update */
1867static bool numamigrate_update_ratelimit(pg_data_t *pgdat,
1868 unsigned long nr_pages)
1869{
1870 /*
1871 * Rate-limit the amount of data that is being migrated to a node.
1872 * Optimal placement is no good if the memory bus is saturated and
1873 * all the time is being spent migrating!
1874 */
1875 if (time_after(jiffies, pgdat->numabalancing_migrate_next_window)) {
1876 spin_lock(&pgdat->numabalancing_migrate_lock);
1877 pgdat->numabalancing_migrate_nr_pages = 0;
1878 pgdat->numabalancing_migrate_next_window = jiffies +
1879 msecs_to_jiffies(migrate_interval_millisecs);
1880 spin_unlock(&pgdat->numabalancing_migrate_lock);
1881 }
1882 if (pgdat->numabalancing_migrate_nr_pages > ratelimit_pages) {
1883 trace_mm_numa_migrate_ratelimit(current, pgdat->node_id,
1884 nr_pages);
1885 return true;
1886 }
1887
1888 /*
1889 * This is an unlocked non-atomic update so errors are possible.
1890 * The consequences are failing to migrate when we potentiall should
1891 * have which is not severe enough to warrant locking. If it is ever
1892 * a problem, it can be converted to a per-cpu counter.
1893 */
1894 pgdat->numabalancing_migrate_nr_pages += nr_pages;
1895 return false;
1896}
1897
1898static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) 1861static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
1899{ 1862{
1900 int page_lru; 1863 int page_lru;
@@ -1967,14 +1930,6 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
1967 if (page_is_file_cache(page) && PageDirty(page)) 1930 if (page_is_file_cache(page) && PageDirty(page))
1968 goto out; 1931 goto out;
1969 1932
1970 /*
1971 * Rate-limit the amount of data that is being migrated to a node.
1972 * Optimal placement is no good if the memory bus is saturated and
1973 * all the time is being spent migrating!
1974 */
1975 if (numamigrate_update_ratelimit(pgdat, 1))
1976 goto out;
1977
1978 isolated = numamigrate_isolate_page(pgdat, page); 1933 isolated = numamigrate_isolate_page(pgdat, page);
1979 if (!isolated) 1934 if (!isolated)
1980 goto out; 1935 goto out;
@@ -2021,14 +1976,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
2021 unsigned long mmun_start = address & HPAGE_PMD_MASK; 1976 unsigned long mmun_start = address & HPAGE_PMD_MASK;
2022 unsigned long mmun_end = mmun_start + HPAGE_PMD_SIZE; 1977 unsigned long mmun_end = mmun_start + HPAGE_PMD_SIZE;
2023 1978
2024 /*
2025 * Rate-limit the amount of data that is being migrated to a node.
2026 * Optimal placement is no good if the memory bus is saturated and
2027 * all the time is being spent migrating!
2028 */
2029 if (numamigrate_update_ratelimit(pgdat, HPAGE_PMD_NR))
2030 goto out_dropref;
2031
2032 new_page = alloc_pages_node(node, 1979 new_page = alloc_pages_node(node,
2033 (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE), 1980 (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE),
2034 HPAGE_PMD_ORDER); 1981 HPAGE_PMD_ORDER);
@@ -2125,7 +2072,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
2125 2072
2126out_fail: 2073out_fail:
2127 count_vm_events(PGMIGRATE_FAIL, HPAGE_PMD_NR); 2074 count_vm_events(PGMIGRATE_FAIL, HPAGE_PMD_NR);
2128out_dropref:
2129 ptl = pmd_lock(mm, pmd); 2075 ptl = pmd_lock(mm, pmd);
2130 if (pmd_same(*pmd, entry)) { 2076 if (pmd_same(*pmd, entry)) {
2131 entry = pmd_modify(entry, vma->vm_page_prot); 2077 entry = pmd_modify(entry, vma->vm_page_prot);
diff --git a/mm/mmap.c b/mm/mmap.c
index 5f2b2b184c60..f7cd9cb966c0 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1410,7 +1410,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr,
1410 if (flags & MAP_FIXED_NOREPLACE) { 1410 if (flags & MAP_FIXED_NOREPLACE) {
1411 struct vm_area_struct *vma = find_vma(mm, addr); 1411 struct vm_area_struct *vma = find_vma(mm, addr);
1412 1412
1413 if (vma && vma->vm_start <= addr) 1413 if (vma && vma->vm_start < addr + len)
1414 return -EEXIST; 1414 return -EEXIST;
1415 } 1415 }
1416 1416
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 89d2a2ab3fe6..e2ef1c17942f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6193,17 +6193,6 @@ static unsigned long __init calc_memmap_size(unsigned long spanned_pages,
6193 return PAGE_ALIGN(pages * sizeof(struct page)) >> PAGE_SHIFT; 6193 return PAGE_ALIGN(pages * sizeof(struct page)) >> PAGE_SHIFT;
6194} 6194}
6195 6195
6196#ifdef CONFIG_NUMA_BALANCING
6197static void pgdat_init_numabalancing(struct pglist_data *pgdat)
6198{
6199 spin_lock_init(&pgdat->numabalancing_migrate_lock);
6200 pgdat->numabalancing_migrate_nr_pages = 0;
6201 pgdat->numabalancing_migrate_next_window = jiffies;
6202}
6203#else
6204static void pgdat_init_numabalancing(struct pglist_data *pgdat) {}
6205#endif
6206
6207#ifdef CONFIG_TRANSPARENT_HUGEPAGE 6196#ifdef CONFIG_TRANSPARENT_HUGEPAGE
6208static void pgdat_init_split_queue(struct pglist_data *pgdat) 6197static void pgdat_init_split_queue(struct pglist_data *pgdat)
6209{ 6198{
@@ -6228,7 +6217,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat)
6228{ 6217{
6229 pgdat_resize_init(pgdat); 6218 pgdat_resize_init(pgdat);
6230 6219
6231 pgdat_init_numabalancing(pgdat);
6232 pgdat_init_split_queue(pgdat); 6220 pgdat_init_split_queue(pgdat);
6233 pgdat_init_kcompactd(pgdat); 6221 pgdat_init_kcompactd(pgdat);
6234 6222
diff --git a/mm/percpu.c b/mm/percpu.c
index a749d4d96e3e..4b90682623e9 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1212,6 +1212,7 @@ static void pcpu_free_chunk(struct pcpu_chunk *chunk)
1212{ 1212{
1213 if (!chunk) 1213 if (!chunk)
1214 return; 1214 return;
1215 pcpu_mem_free(chunk->md_blocks);
1215 pcpu_mem_free(chunk->bound_map); 1216 pcpu_mem_free(chunk->bound_map);
1216 pcpu_mem_free(chunk->alloc_map); 1217 pcpu_mem_free(chunk->alloc_map);
1217 pcpu_mem_free(chunk); 1218 pcpu_mem_free(chunk);
diff --git a/mm/readahead.c b/mm/readahead.c
index a59ea70527b9..4e630143a0ba 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -20,6 +20,7 @@
20#include <linux/file.h> 20#include <linux/file.h>
21#include <linux/mm_inline.h> 21#include <linux/mm_inline.h>
22#include <linux/blk-cgroup.h> 22#include <linux/blk-cgroup.h>
23#include <linux/fadvise.h>
23 24
24#include "internal.h" 25#include "internal.h"
25 26
@@ -575,24 +576,6 @@ page_cache_async_readahead(struct address_space *mapping,
575} 576}
576EXPORT_SYMBOL_GPL(page_cache_async_readahead); 577EXPORT_SYMBOL_GPL(page_cache_async_readahead);
577 578
578static ssize_t
579do_readahead(struct address_space *mapping, struct file *filp,
580 pgoff_t index, unsigned long nr)
581{
582 if (!mapping || !mapping->a_ops)
583 return -EINVAL;
584
585 /*
586 * Readahead doesn't make sense for DAX inodes, but we don't want it
587 * to report a failure either. Instead, we just return success and
588 * don't do any work.
589 */
590 if (dax_mapping(mapping))
591 return 0;
592
593 return force_page_cache_readahead(mapping, filp, index, nr);
594}
595
596ssize_t ksys_readahead(int fd, loff_t offset, size_t count) 579ssize_t ksys_readahead(int fd, loff_t offset, size_t count)
597{ 580{
598 ssize_t ret; 581 ssize_t ret;
@@ -600,16 +583,22 @@ ssize_t ksys_readahead(int fd, loff_t offset, size_t count)
600 583
601 ret = -EBADF; 584 ret = -EBADF;
602 f = fdget(fd); 585 f = fdget(fd);
603 if (f.file) { 586 if (!f.file || !(f.file->f_mode & FMODE_READ))
604 if (f.file->f_mode & FMODE_READ) { 587 goto out;
605 struct address_space *mapping = f.file->f_mapping; 588
606 pgoff_t start = offset >> PAGE_SHIFT; 589 /*
607 pgoff_t end = (offset + count - 1) >> PAGE_SHIFT; 590 * The readahead() syscall is intended to run only on files
608 unsigned long len = end - start + 1; 591 * that can execute readahead. If readahead is not possible
609 ret = do_readahead(mapping, f.file, start, len); 592 * on this file, then we must return -EINVAL.
610 } 593 */
611 fdput(f); 594 ret = -EINVAL;
612 } 595 if (!f.file->f_mapping || !f.file->f_mapping->a_ops ||
596 !S_ISREG(file_inode(f.file)->i_mode))
597 goto out;
598
599 ret = vfs_fadvise(f.file, offset, count, POSIX_FADV_WILLNEED);
600out:
601 fdput(f);
613 return ret; 602 return ret;
614} 603}
615 604
diff --git a/mm/rmap.c b/mm/rmap.c
index eb477809a5c0..1e79fac3186b 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1362,11 +1362,21 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
1362 } 1362 }
1363 1363
1364 /* 1364 /*
1365 * We have to assume the worse case ie pmd for invalidation. Note that 1365 * For THP, we have to assume the worse case ie pmd for invalidation.
1366 * the page can not be free in this function as call of try_to_unmap() 1366 * For hugetlb, it could be much worse if we need to do pud
1367 * must hold a reference on the page. 1367 * invalidation in the case of pmd sharing.
1368 *
1369 * Note that the page can not be free in this function as call of
1370 * try_to_unmap() must hold a reference on the page.
1368 */ 1371 */
1369 end = min(vma->vm_end, start + (PAGE_SIZE << compound_order(page))); 1372 end = min(vma->vm_end, start + (PAGE_SIZE << compound_order(page)));
1373 if (PageHuge(page)) {
1374 /*
1375 * If sharing is possible, start and end will be adjusted
1376 * accordingly.
1377 */
1378 adjust_range_if_pmd_sharing_possible(vma, &start, &end);
1379 }
1370 mmu_notifier_invalidate_range_start(vma->vm_mm, start, end); 1380 mmu_notifier_invalidate_range_start(vma->vm_mm, start, end);
1371 1381
1372 while (page_vma_mapped_walk(&pvmw)) { 1382 while (page_vma_mapped_walk(&pvmw)) {
@@ -1409,6 +1419,32 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
1409 subpage = page - page_to_pfn(page) + pte_pfn(*pvmw.pte); 1419 subpage = page - page_to_pfn(page) + pte_pfn(*pvmw.pte);
1410 address = pvmw.address; 1420 address = pvmw.address;
1411 1421
1422 if (PageHuge(page)) {
1423 if (huge_pmd_unshare(mm, &address, pvmw.pte)) {
1424 /*
1425 * huge_pmd_unshare unmapped an entire PMD
1426 * page. There is no way of knowing exactly
1427 * which PMDs may be cached for this mm, so
1428 * we must flush them all. start/end were
1429 * already adjusted above to cover this range.
1430 */
1431 flush_cache_range(vma, start, end);
1432 flush_tlb_range(vma, start, end);
1433 mmu_notifier_invalidate_range(mm, start, end);
1434
1435 /*
1436 * The ref count of the PMD page was dropped
1437 * which is part of the way map counting
1438 * is done for shared PMDs. Return 'true'
1439 * here. When there is no other sharing,
1440 * huge_pmd_unshare returns false and we will
1441 * unmap the actual page and drop map count
1442 * to zero.
1443 */
1444 page_vma_mapped_walk_done(&pvmw);
1445 break;
1446 }
1447 }
1412 1448
1413 if (IS_ENABLED(CONFIG_MIGRATION) && 1449 if (IS_ENABLED(CONFIG_MIGRATION) &&
1414 (flags & TTU_MIGRATION) && 1450 (flags & TTU_MIGRATION) &&
diff --git a/mm/shmem.c b/mm/shmem.c
index 0376c124b043..446942677cd4 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2227,6 +2227,8 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode
2227 mpol_shared_policy_init(&info->policy, NULL); 2227 mpol_shared_policy_init(&info->policy, NULL);
2228 break; 2228 break;
2229 } 2229 }
2230
2231 lockdep_annotate_inode_mutex_key(inode);
2230 } else 2232 } else
2231 shmem_free_inode(sb); 2233 shmem_free_inode(sb);
2232 return inode; 2234 return inode;
diff --git a/mm/vmacache.c b/mm/vmacache.c
index ea517bef7dc5..cdc32a3b02fa 100644
--- a/mm/vmacache.c
+++ b/mm/vmacache.c
@@ -20,44 +20,6 @@
20#define VMACACHE_HASH(addr) ((addr >> VMACACHE_SHIFT) & VMACACHE_MASK) 20#define VMACACHE_HASH(addr) ((addr >> VMACACHE_SHIFT) & VMACACHE_MASK)
21 21
22/* 22/*
23 * Flush vma caches for threads that share a given mm.
24 *
25 * The operation is safe because the caller holds the mmap_sem
26 * exclusively and other threads accessing the vma cache will
27 * have mmap_sem held at least for read, so no extra locking
28 * is required to maintain the vma cache.
29 */
30void vmacache_flush_all(struct mm_struct *mm)
31{
32 struct task_struct *g, *p;
33
34 count_vm_vmacache_event(VMACACHE_FULL_FLUSHES);
35
36 /*
37 * Single threaded tasks need not iterate the entire
38 * list of process. We can avoid the flushing as well
39 * since the mm's seqnum was increased and don't have
40 * to worry about other threads' seqnum. Current's
41 * flush will occur upon the next lookup.
42 */
43 if (atomic_read(&mm->mm_users) == 1)
44 return;
45
46 rcu_read_lock();
47 for_each_process_thread(g, p) {
48 /*
49 * Only flush the vmacache pointers as the
50 * mm seqnum is already set and curr's will
51 * be set upon invalidation when the next
52 * lookup is done.
53 */
54 if (mm == p->mm)
55 vmacache_flush(p);
56 }
57 rcu_read_unlock();
58}
59
60/*
61 * This task may be accessing a foreign mm via (for example) 23 * This task may be accessing a foreign mm via (for example)
62 * get_user_pages()->find_vma(). The vmacache is task-local and this 24 * get_user_pages()->find_vma(). The vmacache is task-local and this
63 * task's vmacache pertains to a different mm (ie, its own). There is 25 * task's vmacache pertains to a different mm (ie, its own). There is
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 7e7d25504651..c5ef7240cbcb 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -476,6 +476,17 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl,
476 delta = freeable >> priority; 476 delta = freeable >> priority;
477 delta *= 4; 477 delta *= 4;
478 do_div(delta, shrinker->seeks); 478 do_div(delta, shrinker->seeks);
479
480 /*
481 * Make sure we apply some minimal pressure on default priority
482 * even on small cgroups. Stale objects are not only consuming memory
483 * by themselves, but can also hold a reference to a dying cgroup,
484 * preventing it from being reclaimed. A dying cgroup with all
485 * corresponding structures like per-cpu stats and kmem caches
486 * can be really big, so it may lead to a significant waste of memory.
487 */
488 delta = max_t(unsigned long long, delta, min(freeable, batch_size));
489
479 total_scan += delta; 490 total_scan += delta;
480 if (total_scan < 0) { 491 if (total_scan < 0) {
481 pr_err("shrink_slab: %pF negative objects to delete nr=%ld\n", 492 pr_err("shrink_slab: %pF negative objects to delete nr=%ld\n",
@@ -569,8 +580,8 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid,
569 struct mem_cgroup *memcg, int priority) 580 struct mem_cgroup *memcg, int priority)
570{ 581{
571 struct memcg_shrinker_map *map; 582 struct memcg_shrinker_map *map;
572 unsigned long freed = 0; 583 unsigned long ret, freed = 0;
573 int ret, i; 584 int i;
574 585
575 if (!memcg_kmem_enabled() || !mem_cgroup_online(memcg)) 586 if (!memcg_kmem_enabled() || !mem_cgroup_online(memcg))
576 return 0; 587 return 0;
@@ -666,9 +677,8 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
666 struct mem_cgroup *memcg, 677 struct mem_cgroup *memcg,
667 int priority) 678 int priority)
668{ 679{
680 unsigned long ret, freed = 0;
669 struct shrinker *shrinker; 681 struct shrinker *shrinker;
670 unsigned long freed = 0;
671 int ret;
672 682
673 if (!mem_cgroup_is_root(memcg)) 683 if (!mem_cgroup_is_root(memcg))
674 return shrink_slab_memcg(gfp_mask, nid, memcg, priority); 684 return shrink_slab_memcg(gfp_mask, nid, memcg, priority);
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 8ba0870ecddd..7878da76abf2 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1275,6 +1275,9 @@ const char * const vmstat_text[] = {
1275#ifdef CONFIG_SMP 1275#ifdef CONFIG_SMP
1276 "nr_tlb_remote_flush", 1276 "nr_tlb_remote_flush",
1277 "nr_tlb_remote_flush_received", 1277 "nr_tlb_remote_flush_received",
1278#else
1279 "", /* nr_tlb_remote_flush */
1280 "", /* nr_tlb_remote_flush_received */
1278#endif /* CONFIG_SMP */ 1281#endif /* CONFIG_SMP */
1279 "nr_tlb_local_flush_all", 1282 "nr_tlb_local_flush_all",
1280 "nr_tlb_local_flush_one", 1283 "nr_tlb_local_flush_one",
@@ -1283,7 +1286,6 @@ const char * const vmstat_text[] = {
1283#ifdef CONFIG_DEBUG_VM_VMACACHE 1286#ifdef CONFIG_DEBUG_VM_VMACACHE
1284 "vmacache_find_calls", 1287 "vmacache_find_calls",
1285 "vmacache_find_hits", 1288 "vmacache_find_hits",
1286 "vmacache_full_flushes",
1287#endif 1289#endif
1288#ifdef CONFIG_SWAP 1290#ifdef CONFIG_SWAP
1289 "swap_ra", 1291 "swap_ra",
diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c
index 71c20c1d4002..9f481cfdf77d 100644
--- a/net/batman-adv/bat_v_elp.c
+++ b/net/batman-adv/bat_v_elp.c
@@ -241,7 +241,7 @@ batadv_v_elp_wifi_neigh_probe(struct batadv_hardif_neigh_node *neigh)
241 * the packet to be exactly of that size to make the link 241 * the packet to be exactly of that size to make the link
242 * throughput estimation effective. 242 * throughput estimation effective.
243 */ 243 */
244 skb_put(skb, probe_len - hard_iface->bat_v.elp_skb->len); 244 skb_put_zero(skb, probe_len - hard_iface->bat_v.elp_skb->len);
245 245
246 batadv_dbg(BATADV_DBG_BATMAN, bat_priv, 246 batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
247 "Sending unicast (probe) ELP packet on interface %s to %pM\n", 247 "Sending unicast (probe) ELP packet on interface %s to %pM\n",
@@ -268,6 +268,7 @@ static void batadv_v_elp_periodic_work(struct work_struct *work)
268 struct batadv_priv *bat_priv; 268 struct batadv_priv *bat_priv;
269 struct sk_buff *skb; 269 struct sk_buff *skb;
270 u32 elp_interval; 270 u32 elp_interval;
271 bool ret;
271 272
272 bat_v = container_of(work, struct batadv_hard_iface_bat_v, elp_wq.work); 273 bat_v = container_of(work, struct batadv_hard_iface_bat_v, elp_wq.work);
273 hard_iface = container_of(bat_v, struct batadv_hard_iface, bat_v); 274 hard_iface = container_of(bat_v, struct batadv_hard_iface, bat_v);
@@ -329,8 +330,11 @@ static void batadv_v_elp_periodic_work(struct work_struct *work)
329 * may sleep and that is not allowed in an rcu protected 330 * may sleep and that is not allowed in an rcu protected
330 * context. Therefore schedule a task for that. 331 * context. Therefore schedule a task for that.
331 */ 332 */
332 queue_work(batadv_event_workqueue, 333 ret = queue_work(batadv_event_workqueue,
333 &hardif_neigh->bat_v.metric_work); 334 &hardif_neigh->bat_v.metric_work);
335
336 if (!ret)
337 batadv_hardif_neigh_put(hardif_neigh);
334 } 338 }
335 rcu_read_unlock(); 339 rcu_read_unlock();
336 340
diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index ff9659af6b91..5f1aeeded0e3 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -1772,6 +1772,7 @@ batadv_bla_loopdetect_check(struct batadv_priv *bat_priv, struct sk_buff *skb,
1772{ 1772{
1773 struct batadv_bla_backbone_gw *backbone_gw; 1773 struct batadv_bla_backbone_gw *backbone_gw;
1774 struct ethhdr *ethhdr; 1774 struct ethhdr *ethhdr;
1775 bool ret;
1775 1776
1776 ethhdr = eth_hdr(skb); 1777 ethhdr = eth_hdr(skb);
1777 1778
@@ -1795,8 +1796,13 @@ batadv_bla_loopdetect_check(struct batadv_priv *bat_priv, struct sk_buff *skb,
1795 if (unlikely(!backbone_gw)) 1796 if (unlikely(!backbone_gw))
1796 return true; 1797 return true;
1797 1798
1798 queue_work(batadv_event_workqueue, &backbone_gw->report_work); 1799 ret = queue_work(batadv_event_workqueue, &backbone_gw->report_work);
1799 /* backbone_gw is unreferenced in the report work function function */ 1800
1801 /* backbone_gw is unreferenced in the report work function function
1802 * if queue_work() call was successful
1803 */
1804 if (!ret)
1805 batadv_backbone_gw_put(backbone_gw);
1800 1806
1801 return true; 1807 return true;
1802} 1808}
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 8b198ee798c9..140c61a3f1ec 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -32,6 +32,7 @@
32#include <linux/kernel.h> 32#include <linux/kernel.h>
33#include <linux/kref.h> 33#include <linux/kref.h>
34#include <linux/list.h> 34#include <linux/list.h>
35#include <linux/lockdep.h>
35#include <linux/netdevice.h> 36#include <linux/netdevice.h>
36#include <linux/netlink.h> 37#include <linux/netlink.h>
37#include <linux/rculist.h> 38#include <linux/rculist.h>
@@ -348,6 +349,9 @@ out:
348 * @bat_priv: the bat priv with all the soft interface information 349 * @bat_priv: the bat priv with all the soft interface information
349 * @orig_node: originator announcing gateway capabilities 350 * @orig_node: originator announcing gateway capabilities
350 * @gateway: announced bandwidth information 351 * @gateway: announced bandwidth information
352 *
353 * Has to be called with the appropriate locks being acquired
354 * (gw.list_lock).
351 */ 355 */
352static void batadv_gw_node_add(struct batadv_priv *bat_priv, 356static void batadv_gw_node_add(struct batadv_priv *bat_priv,
353 struct batadv_orig_node *orig_node, 357 struct batadv_orig_node *orig_node,
@@ -355,6 +359,8 @@ static void batadv_gw_node_add(struct batadv_priv *bat_priv,
355{ 359{
356 struct batadv_gw_node *gw_node; 360 struct batadv_gw_node *gw_node;
357 361
362 lockdep_assert_held(&bat_priv->gw.list_lock);
363
358 if (gateway->bandwidth_down == 0) 364 if (gateway->bandwidth_down == 0)
359 return; 365 return;
360 366
@@ -369,10 +375,8 @@ static void batadv_gw_node_add(struct batadv_priv *bat_priv,
369 gw_node->bandwidth_down = ntohl(gateway->bandwidth_down); 375 gw_node->bandwidth_down = ntohl(gateway->bandwidth_down);
370 gw_node->bandwidth_up = ntohl(gateway->bandwidth_up); 376 gw_node->bandwidth_up = ntohl(gateway->bandwidth_up);
371 377
372 spin_lock_bh(&bat_priv->gw.list_lock);
373 kref_get(&gw_node->refcount); 378 kref_get(&gw_node->refcount);
374 hlist_add_head_rcu(&gw_node->list, &bat_priv->gw.gateway_list); 379 hlist_add_head_rcu(&gw_node->list, &bat_priv->gw.gateway_list);
375 spin_unlock_bh(&bat_priv->gw.list_lock);
376 380
377 batadv_dbg(BATADV_DBG_BATMAN, bat_priv, 381 batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
378 "Found new gateway %pM -> gw bandwidth: %u.%u/%u.%u MBit\n", 382 "Found new gateway %pM -> gw bandwidth: %u.%u/%u.%u MBit\n",
@@ -428,11 +432,14 @@ void batadv_gw_node_update(struct batadv_priv *bat_priv,
428{ 432{
429 struct batadv_gw_node *gw_node, *curr_gw = NULL; 433 struct batadv_gw_node *gw_node, *curr_gw = NULL;
430 434
435 spin_lock_bh(&bat_priv->gw.list_lock);
431 gw_node = batadv_gw_node_get(bat_priv, orig_node); 436 gw_node = batadv_gw_node_get(bat_priv, orig_node);
432 if (!gw_node) { 437 if (!gw_node) {
433 batadv_gw_node_add(bat_priv, orig_node, gateway); 438 batadv_gw_node_add(bat_priv, orig_node, gateway);
439 spin_unlock_bh(&bat_priv->gw.list_lock);
434 goto out; 440 goto out;
435 } 441 }
442 spin_unlock_bh(&bat_priv->gw.list_lock);
436 443
437 if (gw_node->bandwidth_down == ntohl(gateway->bandwidth_down) && 444 if (gw_node->bandwidth_down == ntohl(gateway->bandwidth_down) &&
438 gw_node->bandwidth_up == ntohl(gateway->bandwidth_up)) 445 gw_node->bandwidth_up == ntohl(gateway->bandwidth_up))
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 8da3c9336111..3ccc75ee719c 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -25,7 +25,7 @@
25#define BATADV_DRIVER_DEVICE "batman-adv" 25#define BATADV_DRIVER_DEVICE "batman-adv"
26 26
27#ifndef BATADV_SOURCE_VERSION 27#ifndef BATADV_SOURCE_VERSION
28#define BATADV_SOURCE_VERSION "2018.2" 28#define BATADV_SOURCE_VERSION "2018.3"
29#endif 29#endif
30 30
31/* B.A.T.M.A.N. parameters */ 31/* B.A.T.M.A.N. parameters */
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index c3578444f3cb..34caf129a9bf 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -854,16 +854,27 @@ batadv_nc_get_nc_node(struct batadv_priv *bat_priv,
854 spinlock_t *lock; /* Used to lock list selected by "int in_coding" */ 854 spinlock_t *lock; /* Used to lock list selected by "int in_coding" */
855 struct list_head *list; 855 struct list_head *list;
856 856
857 /* Select ingoing or outgoing coding node */
858 if (in_coding) {
859 lock = &orig_neigh_node->in_coding_list_lock;
860 list = &orig_neigh_node->in_coding_list;
861 } else {
862 lock = &orig_neigh_node->out_coding_list_lock;
863 list = &orig_neigh_node->out_coding_list;
864 }
865
866 spin_lock_bh(lock);
867
857 /* Check if nc_node is already added */ 868 /* Check if nc_node is already added */
858 nc_node = batadv_nc_find_nc_node(orig_node, orig_neigh_node, in_coding); 869 nc_node = batadv_nc_find_nc_node(orig_node, orig_neigh_node, in_coding);
859 870
860 /* Node found */ 871 /* Node found */
861 if (nc_node) 872 if (nc_node)
862 return nc_node; 873 goto unlock;
863 874
864 nc_node = kzalloc(sizeof(*nc_node), GFP_ATOMIC); 875 nc_node = kzalloc(sizeof(*nc_node), GFP_ATOMIC);
865 if (!nc_node) 876 if (!nc_node)
866 return NULL; 877 goto unlock;
867 878
868 /* Initialize nc_node */ 879 /* Initialize nc_node */
869 INIT_LIST_HEAD(&nc_node->list); 880 INIT_LIST_HEAD(&nc_node->list);
@@ -872,22 +883,14 @@ batadv_nc_get_nc_node(struct batadv_priv *bat_priv,
872 kref_get(&orig_neigh_node->refcount); 883 kref_get(&orig_neigh_node->refcount);
873 nc_node->orig_node = orig_neigh_node; 884 nc_node->orig_node = orig_neigh_node;
874 885
875 /* Select ingoing or outgoing coding node */
876 if (in_coding) {
877 lock = &orig_neigh_node->in_coding_list_lock;
878 list = &orig_neigh_node->in_coding_list;
879 } else {
880 lock = &orig_neigh_node->out_coding_list_lock;
881 list = &orig_neigh_node->out_coding_list;
882 }
883
884 batadv_dbg(BATADV_DBG_NC, bat_priv, "Adding nc_node %pM -> %pM\n", 886 batadv_dbg(BATADV_DBG_NC, bat_priv, "Adding nc_node %pM -> %pM\n",
885 nc_node->addr, nc_node->orig_node->orig); 887 nc_node->addr, nc_node->orig_node->orig);
886 888
887 /* Add nc_node to orig_node */ 889 /* Add nc_node to orig_node */
888 spin_lock_bh(lock);
889 kref_get(&nc_node->refcount); 890 kref_get(&nc_node->refcount);
890 list_add_tail_rcu(&nc_node->list, list); 891 list_add_tail_rcu(&nc_node->list, list);
892
893unlock:
891 spin_unlock_bh(lock); 894 spin_unlock_bh(lock);
892 895
893 return nc_node; 896 return nc_node;
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 1485263a348b..626ddca332db 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -574,15 +574,20 @@ int batadv_softif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid)
574 struct batadv_softif_vlan *vlan; 574 struct batadv_softif_vlan *vlan;
575 int err; 575 int err;
576 576
577 spin_lock_bh(&bat_priv->softif_vlan_list_lock);
578
577 vlan = batadv_softif_vlan_get(bat_priv, vid); 579 vlan = batadv_softif_vlan_get(bat_priv, vid);
578 if (vlan) { 580 if (vlan) {
579 batadv_softif_vlan_put(vlan); 581 batadv_softif_vlan_put(vlan);
582 spin_unlock_bh(&bat_priv->softif_vlan_list_lock);
580 return -EEXIST; 583 return -EEXIST;
581 } 584 }
582 585
583 vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC); 586 vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC);
584 if (!vlan) 587 if (!vlan) {
588 spin_unlock_bh(&bat_priv->softif_vlan_list_lock);
585 return -ENOMEM; 589 return -ENOMEM;
590 }
586 591
587 vlan->bat_priv = bat_priv; 592 vlan->bat_priv = bat_priv;
588 vlan->vid = vid; 593 vlan->vid = vid;
@@ -590,17 +595,23 @@ int batadv_softif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid)
590 595
591 atomic_set(&vlan->ap_isolation, 0); 596 atomic_set(&vlan->ap_isolation, 0);
592 597
598 kref_get(&vlan->refcount);
599 hlist_add_head_rcu(&vlan->list, &bat_priv->softif_vlan_list);
600 spin_unlock_bh(&bat_priv->softif_vlan_list_lock);
601
602 /* batadv_sysfs_add_vlan cannot be in the spinlock section due to the
603 * sleeping behavior of the sysfs functions and the fs_reclaim lock
604 */
593 err = batadv_sysfs_add_vlan(bat_priv->soft_iface, vlan); 605 err = batadv_sysfs_add_vlan(bat_priv->soft_iface, vlan);
594 if (err) { 606 if (err) {
595 kfree(vlan); 607 /* ref for the function */
608 batadv_softif_vlan_put(vlan);
609
610 /* ref for the list */
611 batadv_softif_vlan_put(vlan);
596 return err; 612 return err;
597 } 613 }
598 614
599 spin_lock_bh(&bat_priv->softif_vlan_list_lock);
600 kref_get(&vlan->refcount);
601 hlist_add_head_rcu(&vlan->list, &bat_priv->softif_vlan_list);
602 spin_unlock_bh(&bat_priv->softif_vlan_list_lock);
603
604 /* add a new TT local entry. This one will be marked with the NOPURGE 615 /* add a new TT local entry. This one will be marked with the NOPURGE
605 * flag 616 * flag
606 */ 617 */
diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c
index f2eef43bd2ec..09427fc6494a 100644
--- a/net/batman-adv/sysfs.c
+++ b/net/batman-adv/sysfs.c
@@ -188,7 +188,8 @@ ssize_t batadv_store_##_name(struct kobject *kobj, \
188 \ 188 \
189 return __batadv_store_uint_attr(buff, count, _min, _max, \ 189 return __batadv_store_uint_attr(buff, count, _min, _max, \
190 _post_func, attr, \ 190 _post_func, attr, \
191 &bat_priv->_var, net_dev); \ 191 &bat_priv->_var, net_dev, \
192 NULL); \
192} 193}
193 194
194#define BATADV_ATTR_SIF_SHOW_UINT(_name, _var) \ 195#define BATADV_ATTR_SIF_SHOW_UINT(_name, _var) \
@@ -262,7 +263,9 @@ ssize_t batadv_store_##_name(struct kobject *kobj, \
262 \ 263 \
263 length = __batadv_store_uint_attr(buff, count, _min, _max, \ 264 length = __batadv_store_uint_attr(buff, count, _min, _max, \
264 _post_func, attr, \ 265 _post_func, attr, \
265 &hard_iface->_var, net_dev); \ 266 &hard_iface->_var, \
267 hard_iface->soft_iface, \
268 net_dev); \
266 \ 269 \
267 batadv_hardif_put(hard_iface); \ 270 batadv_hardif_put(hard_iface); \
268 return length; \ 271 return length; \
@@ -356,10 +359,12 @@ __batadv_store_bool_attr(char *buff, size_t count,
356 359
357static int batadv_store_uint_attr(const char *buff, size_t count, 360static int batadv_store_uint_attr(const char *buff, size_t count,
358 struct net_device *net_dev, 361 struct net_device *net_dev,
362 struct net_device *slave_dev,
359 const char *attr_name, 363 const char *attr_name,
360 unsigned int min, unsigned int max, 364 unsigned int min, unsigned int max,
361 atomic_t *attr) 365 atomic_t *attr)
362{ 366{
367 char ifname[IFNAMSIZ + 3] = "";
363 unsigned long uint_val; 368 unsigned long uint_val;
364 int ret; 369 int ret;
365 370
@@ -385,8 +390,11 @@ static int batadv_store_uint_attr(const char *buff, size_t count,
385 if (atomic_read(attr) == uint_val) 390 if (atomic_read(attr) == uint_val)
386 return count; 391 return count;
387 392
388 batadv_info(net_dev, "%s: Changing from: %i to: %lu\n", 393 if (slave_dev)
389 attr_name, atomic_read(attr), uint_val); 394 snprintf(ifname, sizeof(ifname), "%s: ", slave_dev->name);
395
396 batadv_info(net_dev, "%s: %sChanging from: %i to: %lu\n",
397 attr_name, ifname, atomic_read(attr), uint_val);
390 398
391 atomic_set(attr, uint_val); 399 atomic_set(attr, uint_val);
392 return count; 400 return count;
@@ -397,12 +405,13 @@ static ssize_t __batadv_store_uint_attr(const char *buff, size_t count,
397 void (*post_func)(struct net_device *), 405 void (*post_func)(struct net_device *),
398 const struct attribute *attr, 406 const struct attribute *attr,
399 atomic_t *attr_store, 407 atomic_t *attr_store,
400 struct net_device *net_dev) 408 struct net_device *net_dev,
409 struct net_device *slave_dev)
401{ 410{
402 int ret; 411 int ret;
403 412
404 ret = batadv_store_uint_attr(buff, count, net_dev, attr->name, min, max, 413 ret = batadv_store_uint_attr(buff, count, net_dev, slave_dev,
405 attr_store); 414 attr->name, min, max, attr_store);
406 if (post_func && ret) 415 if (post_func && ret)
407 post_func(net_dev); 416 post_func(net_dev);
408 417
@@ -571,7 +580,7 @@ static ssize_t batadv_store_gw_sel_class(struct kobject *kobj,
571 return __batadv_store_uint_attr(buff, count, 1, BATADV_TQ_MAX_VALUE, 580 return __batadv_store_uint_attr(buff, count, 1, BATADV_TQ_MAX_VALUE,
572 batadv_post_gw_reselect, attr, 581 batadv_post_gw_reselect, attr,
573 &bat_priv->gw.sel_class, 582 &bat_priv->gw.sel_class,
574 bat_priv->soft_iface); 583 bat_priv->soft_iface, NULL);
575} 584}
576 585
577static ssize_t batadv_show_gw_bwidth(struct kobject *kobj, 586static ssize_t batadv_show_gw_bwidth(struct kobject *kobj,
@@ -1090,8 +1099,9 @@ static ssize_t batadv_store_throughput_override(struct kobject *kobj,
1090 if (old_tp_override == tp_override) 1099 if (old_tp_override == tp_override)
1091 goto out; 1100 goto out;
1092 1101
1093 batadv_info(net_dev, "%s: Changing from: %u.%u MBit to: %u.%u MBit\n", 1102 batadv_info(hard_iface->soft_iface,
1094 "throughput_override", 1103 "%s: %s: Changing from: %u.%u MBit to: %u.%u MBit\n",
1104 "throughput_override", net_dev->name,
1095 old_tp_override / 10, old_tp_override % 10, 1105 old_tp_override / 10, old_tp_override % 10,
1096 tp_override / 10, tp_override % 10); 1106 tp_override / 10, tp_override % 10);
1097 1107
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 12a2b7d21376..d21624c44665 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -1613,6 +1613,8 @@ batadv_tt_global_orig_entry_add(struct batadv_tt_global_entry *tt_global,
1613{ 1613{
1614 struct batadv_tt_orig_list_entry *orig_entry; 1614 struct batadv_tt_orig_list_entry *orig_entry;
1615 1615
1616 spin_lock_bh(&tt_global->list_lock);
1617
1616 orig_entry = batadv_tt_global_orig_entry_find(tt_global, orig_node); 1618 orig_entry = batadv_tt_global_orig_entry_find(tt_global, orig_node);
1617 if (orig_entry) { 1619 if (orig_entry) {
1618 /* refresh the ttvn: the current value could be a bogus one that 1620 /* refresh the ttvn: the current value could be a bogus one that
@@ -1635,11 +1637,9 @@ batadv_tt_global_orig_entry_add(struct batadv_tt_global_entry *tt_global,
1635 orig_entry->flags = flags; 1637 orig_entry->flags = flags;
1636 kref_init(&orig_entry->refcount); 1638 kref_init(&orig_entry->refcount);
1637 1639
1638 spin_lock_bh(&tt_global->list_lock);
1639 kref_get(&orig_entry->refcount); 1640 kref_get(&orig_entry->refcount);
1640 hlist_add_head_rcu(&orig_entry->list, 1641 hlist_add_head_rcu(&orig_entry->list,
1641 &tt_global->orig_list); 1642 &tt_global->orig_list);
1642 spin_unlock_bh(&tt_global->list_lock);
1643 atomic_inc(&tt_global->orig_list_count); 1643 atomic_inc(&tt_global->orig_list_count);
1644 1644
1645sync_flags: 1645sync_flags:
@@ -1647,6 +1647,8 @@ sync_flags:
1647out: 1647out:
1648 if (orig_entry) 1648 if (orig_entry)
1649 batadv_tt_orig_list_entry_put(orig_entry); 1649 batadv_tt_orig_list_entry_put(orig_entry);
1650
1651 spin_unlock_bh(&tt_global->list_lock);
1650} 1652}
1651 1653
1652/** 1654/**
diff --git a/net/batman-adv/tvlv.c b/net/batman-adv/tvlv.c
index a637458205d1..40e69c9346d2 100644
--- a/net/batman-adv/tvlv.c
+++ b/net/batman-adv/tvlv.c
@@ -529,15 +529,20 @@ void batadv_tvlv_handler_register(struct batadv_priv *bat_priv,
529{ 529{
530 struct batadv_tvlv_handler *tvlv_handler; 530 struct batadv_tvlv_handler *tvlv_handler;
531 531
532 spin_lock_bh(&bat_priv->tvlv.handler_list_lock);
533
532 tvlv_handler = batadv_tvlv_handler_get(bat_priv, type, version); 534 tvlv_handler = batadv_tvlv_handler_get(bat_priv, type, version);
533 if (tvlv_handler) { 535 if (tvlv_handler) {
536 spin_unlock_bh(&bat_priv->tvlv.handler_list_lock);
534 batadv_tvlv_handler_put(tvlv_handler); 537 batadv_tvlv_handler_put(tvlv_handler);
535 return; 538 return;
536 } 539 }
537 540
538 tvlv_handler = kzalloc(sizeof(*tvlv_handler), GFP_ATOMIC); 541 tvlv_handler = kzalloc(sizeof(*tvlv_handler), GFP_ATOMIC);
539 if (!tvlv_handler) 542 if (!tvlv_handler) {
543 spin_unlock_bh(&bat_priv->tvlv.handler_list_lock);
540 return; 544 return;
545 }
541 546
542 tvlv_handler->ogm_handler = optr; 547 tvlv_handler->ogm_handler = optr;
543 tvlv_handler->unicast_handler = uptr; 548 tvlv_handler->unicast_handler = uptr;
@@ -547,7 +552,6 @@ void batadv_tvlv_handler_register(struct batadv_priv *bat_priv,
547 kref_init(&tvlv_handler->refcount); 552 kref_init(&tvlv_handler->refcount);
548 INIT_HLIST_NODE(&tvlv_handler->list); 553 INIT_HLIST_NODE(&tvlv_handler->list);
549 554
550 spin_lock_bh(&bat_priv->tvlv.handler_list_lock);
551 kref_get(&tvlv_handler->refcount); 555 kref_get(&tvlv_handler->refcount);
552 hlist_add_head_rcu(&tvlv_handler->list, &bat_priv->tvlv.handler_list); 556 hlist_add_head_rcu(&tvlv_handler->list, &bat_priv->tvlv.handler_list);
553 spin_unlock_bh(&bat_priv->tvlv.handler_list_lock); 557 spin_unlock_bh(&bat_priv->tvlv.handler_list_lock);
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 3bdc8f3ca259..ccce954f8146 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2434,9 +2434,8 @@ static int unpair_device(struct sock *sk, struct hci_dev *hdev, void *data,
2434 /* LE address type */ 2434 /* LE address type */
2435 addr_type = le_addr_type(cp->addr.type); 2435 addr_type = le_addr_type(cp->addr.type);
2436 2436
2437 hci_remove_irk(hdev, &cp->addr.bdaddr, addr_type); 2437 /* Abort any ongoing SMP pairing. Removes ltk and irk if they exist. */
2438 2438 err = smp_cancel_and_remove_pairing(hdev, &cp->addr.bdaddr, addr_type);
2439 err = hci_remove_ltk(hdev, &cp->addr.bdaddr, addr_type);
2440 if (err < 0) { 2439 if (err < 0) {
2441 err = mgmt_cmd_complete(sk, hdev->id, MGMT_OP_UNPAIR_DEVICE, 2440 err = mgmt_cmd_complete(sk, hdev->id, MGMT_OP_UNPAIR_DEVICE,
2442 MGMT_STATUS_NOT_PAIRED, &rp, 2441 MGMT_STATUS_NOT_PAIRED, &rp,
@@ -2450,8 +2449,6 @@ static int unpair_device(struct sock *sk, struct hci_dev *hdev, void *data,
2450 goto done; 2449 goto done;
2451 } 2450 }
2452 2451
2453 /* Abort any ongoing SMP pairing */
2454 smp_cancel_pairing(conn);
2455 2452
2456 /* Defer clearing up the connection parameters until closing to 2453 /* Defer clearing up the connection parameters until closing to
2457 * give a chance of keeping them if a repairing happens. 2454 * give a chance of keeping them if a repairing happens.
diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
index ae91e2d40056..73f7211d0431 100644
--- a/net/bluetooth/smp.c
+++ b/net/bluetooth/smp.c
@@ -83,6 +83,7 @@ enum {
83 83
84struct smp_dev { 84struct smp_dev {
85 /* Secure Connections OOB data */ 85 /* Secure Connections OOB data */
86 bool local_oob;
86 u8 local_pk[64]; 87 u8 local_pk[64];
87 u8 local_rand[16]; 88 u8 local_rand[16];
88 bool debug_key; 89 bool debug_key;
@@ -599,6 +600,8 @@ int smp_generate_oob(struct hci_dev *hdev, u8 hash[16], u8 rand[16])
599 600
600 memcpy(rand, smp->local_rand, 16); 601 memcpy(rand, smp->local_rand, 16);
601 602
603 smp->local_oob = true;
604
602 return 0; 605 return 0;
603} 606}
604 607
@@ -1785,7 +1788,7 @@ static u8 smp_cmd_pairing_req(struct l2cap_conn *conn, struct sk_buff *skb)
1785 * successfully received our local OOB data - therefore set the 1788 * successfully received our local OOB data - therefore set the
1786 * flag to indicate that local OOB is in use. 1789 * flag to indicate that local OOB is in use.
1787 */ 1790 */
1788 if (req->oob_flag == SMP_OOB_PRESENT) 1791 if (req->oob_flag == SMP_OOB_PRESENT && SMP_DEV(hdev)->local_oob)
1789 set_bit(SMP_FLAG_LOCAL_OOB, &smp->flags); 1792 set_bit(SMP_FLAG_LOCAL_OOB, &smp->flags);
1790 1793
1791 /* SMP over BR/EDR requires special treatment */ 1794 /* SMP over BR/EDR requires special treatment */
@@ -1967,7 +1970,7 @@ static u8 smp_cmd_pairing_rsp(struct l2cap_conn *conn, struct sk_buff *skb)
1967 * successfully received our local OOB data - therefore set the 1970 * successfully received our local OOB data - therefore set the
1968 * flag to indicate that local OOB is in use. 1971 * flag to indicate that local OOB is in use.
1969 */ 1972 */
1970 if (rsp->oob_flag == SMP_OOB_PRESENT) 1973 if (rsp->oob_flag == SMP_OOB_PRESENT && SMP_DEV(hdev)->local_oob)
1971 set_bit(SMP_FLAG_LOCAL_OOB, &smp->flags); 1974 set_bit(SMP_FLAG_LOCAL_OOB, &smp->flags);
1972 1975
1973 smp->prsp[0] = SMP_CMD_PAIRING_RSP; 1976 smp->prsp[0] = SMP_CMD_PAIRING_RSP;
@@ -2419,30 +2422,51 @@ unlock:
2419 return ret; 2422 return ret;
2420} 2423}
2421 2424
2422void smp_cancel_pairing(struct hci_conn *hcon) 2425int smp_cancel_and_remove_pairing(struct hci_dev *hdev, bdaddr_t *bdaddr,
2426 u8 addr_type)
2423{ 2427{
2424 struct l2cap_conn *conn = hcon->l2cap_data; 2428 struct hci_conn *hcon;
2429 struct l2cap_conn *conn;
2425 struct l2cap_chan *chan; 2430 struct l2cap_chan *chan;
2426 struct smp_chan *smp; 2431 struct smp_chan *smp;
2432 int err;
2433
2434 err = hci_remove_ltk(hdev, bdaddr, addr_type);
2435 hci_remove_irk(hdev, bdaddr, addr_type);
2436
2437 hcon = hci_conn_hash_lookup_le(hdev, bdaddr, addr_type);
2438 if (!hcon)
2439 goto done;
2427 2440
2441 conn = hcon->l2cap_data;
2428 if (!conn) 2442 if (!conn)
2429 return; 2443 goto done;
2430 2444
2431 chan = conn->smp; 2445 chan = conn->smp;
2432 if (!chan) 2446 if (!chan)
2433 return; 2447 goto done;
2434 2448
2435 l2cap_chan_lock(chan); 2449 l2cap_chan_lock(chan);
2436 2450
2437 smp = chan->data; 2451 smp = chan->data;
2438 if (smp) { 2452 if (smp) {
2453 /* Set keys to NULL to make sure smp_failure() does not try to
2454 * remove and free already invalidated rcu list entries. */
2455 smp->ltk = NULL;
2456 smp->slave_ltk = NULL;
2457 smp->remote_irk = NULL;
2458
2439 if (test_bit(SMP_FLAG_COMPLETE, &smp->flags)) 2459 if (test_bit(SMP_FLAG_COMPLETE, &smp->flags))
2440 smp_failure(conn, 0); 2460 smp_failure(conn, 0);
2441 else 2461 else
2442 smp_failure(conn, SMP_UNSPECIFIED); 2462 smp_failure(conn, SMP_UNSPECIFIED);
2463 err = 0;
2443 } 2464 }
2444 2465
2445 l2cap_chan_unlock(chan); 2466 l2cap_chan_unlock(chan);
2467
2468done:
2469 return err;
2446} 2470}
2447 2471
2448static int smp_cmd_encrypt_info(struct l2cap_conn *conn, struct sk_buff *skb) 2472static int smp_cmd_encrypt_info(struct l2cap_conn *conn, struct sk_buff *skb)
@@ -2697,7 +2721,13 @@ static int smp_cmd_public_key(struct l2cap_conn *conn, struct sk_buff *skb)
2697 * key was set/generated. 2721 * key was set/generated.
2698 */ 2722 */
2699 if (test_bit(SMP_FLAG_LOCAL_OOB, &smp->flags)) { 2723 if (test_bit(SMP_FLAG_LOCAL_OOB, &smp->flags)) {
2700 struct smp_dev *smp_dev = chan->data; 2724 struct l2cap_chan *hchan = hdev->smp_data;
2725 struct smp_dev *smp_dev;
2726
2727 if (!hchan || !hchan->data)
2728 return SMP_UNSPECIFIED;
2729
2730 smp_dev = hchan->data;
2701 2731
2702 tfm_ecdh = smp_dev->tfm_ecdh; 2732 tfm_ecdh = smp_dev->tfm_ecdh;
2703 } else { 2733 } else {
@@ -3230,6 +3260,7 @@ static struct l2cap_chan *smp_add_cid(struct hci_dev *hdev, u16 cid)
3230 return ERR_CAST(tfm_ecdh); 3260 return ERR_CAST(tfm_ecdh);
3231 } 3261 }
3232 3262
3263 smp->local_oob = false;
3233 smp->tfm_aes = tfm_aes; 3264 smp->tfm_aes = tfm_aes;
3234 smp->tfm_cmac = tfm_cmac; 3265 smp->tfm_cmac = tfm_cmac;
3235 smp->tfm_ecdh = tfm_ecdh; 3266 smp->tfm_ecdh = tfm_ecdh;
diff --git a/net/bluetooth/smp.h b/net/bluetooth/smp.h
index 0ff6247eaa6c..121edadd5f8d 100644
--- a/net/bluetooth/smp.h
+++ b/net/bluetooth/smp.h
@@ -181,7 +181,8 @@ enum smp_key_pref {
181}; 181};
182 182
183/* SMP Commands */ 183/* SMP Commands */
184void smp_cancel_pairing(struct hci_conn *hcon); 184int smp_cancel_and_remove_pairing(struct hci_dev *hdev, bdaddr_t *bdaddr,
185 u8 addr_type);
185bool smp_sufficient_security(struct hci_conn *hcon, u8 sec_level, 186bool smp_sufficient_security(struct hci_conn *hcon, u8 sec_level,
186 enum smp_key_pref key_pref); 187 enum smp_key_pref key_pref);
187int smp_conn_security(struct hci_conn *hcon, __u8 sec_level); 188int smp_conn_security(struct hci_conn *hcon, __u8 sec_level);
diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c
index f0fc182d3db7..b64e1649993b 100644
--- a/net/bpfilter/bpfilter_kern.c
+++ b/net/bpfilter/bpfilter_kern.c
@@ -59,7 +59,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname,
59 req.is_set = is_set; 59 req.is_set = is_set;
60 req.pid = current->pid; 60 req.pid = current->pid;
61 req.cmd = optname; 61 req.cmd = optname;
62 req.addr = (long)optval; 62 req.addr = (long __force __user)optval;
63 req.len = optlen; 63 req.len = optlen;
64 mutex_lock(&bpfilter_lock); 64 mutex_lock(&bpfilter_lock);
65 if (!info.pid) 65 if (!info.pid)
@@ -98,7 +98,7 @@ static int __init load_umh(void)
98 pr_info("Loaded bpfilter_umh pid %d\n", info.pid); 98 pr_info("Loaded bpfilter_umh pid %d\n", info.pid);
99 99
100 /* health check that usermode process started correctly */ 100 /* health check that usermode process started correctly */
101 if (__bpfilter_process_sockopt(NULL, 0, 0, 0, 0) != 0) { 101 if (__bpfilter_process_sockopt(NULL, 0, NULL, 0, 0) != 0) {
102 stop_umh(); 102 stop_umh();
103 return -EFAULT; 103 return -EFAULT;
104 } 104 }
diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index 6e0dc6bcd32a..37278dc280eb 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -835,7 +835,8 @@ static unsigned int ip_sabotage_in(void *priv,
835 struct sk_buff *skb, 835 struct sk_buff *skb,
836 const struct nf_hook_state *state) 836 const struct nf_hook_state *state)
837{ 837{
838 if (skb->nf_bridge && !skb->nf_bridge->in_prerouting) { 838 if (skb->nf_bridge && !skb->nf_bridge->in_prerouting &&
839 !netif_is_l3_master(skb->dev)) {
839 state->okfn(state->net, state->sk, skb); 840 state->okfn(state->net, state->sk, skb);
840 return NF_STOLEN; 841 return NF_STOLEN;
841 } 842 }
diff --git a/net/core/dev.c b/net/core/dev.c
index 82114e1111e6..93243479085f 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1752,6 +1752,28 @@ int call_netdevice_notifiers(unsigned long val, struct net_device *dev)
1752} 1752}
1753EXPORT_SYMBOL(call_netdevice_notifiers); 1753EXPORT_SYMBOL(call_netdevice_notifiers);
1754 1754
1755/**
1756 * call_netdevice_notifiers_mtu - call all network notifier blocks
1757 * @val: value passed unmodified to notifier function
1758 * @dev: net_device pointer passed unmodified to notifier function
1759 * @arg: additional u32 argument passed to the notifier function
1760 *
1761 * Call all network notifier blocks. Parameters and return value
1762 * are as for raw_notifier_call_chain().
1763 */
1764static int call_netdevice_notifiers_mtu(unsigned long val,
1765 struct net_device *dev, u32 arg)
1766{
1767 struct netdev_notifier_info_ext info = {
1768 .info.dev = dev,
1769 .ext.mtu = arg,
1770 };
1771
1772 BUILD_BUG_ON(offsetof(struct netdev_notifier_info_ext, info) != 0);
1773
1774 return call_netdevice_notifiers_info(val, &info.info);
1775}
1776
1755#ifdef CONFIG_NET_INGRESS 1777#ifdef CONFIG_NET_INGRESS
1756static DEFINE_STATIC_KEY_FALSE(ingress_needed_key); 1778static DEFINE_STATIC_KEY_FALSE(ingress_needed_key);
1757 1779
@@ -7574,14 +7596,16 @@ int dev_set_mtu_ext(struct net_device *dev, int new_mtu,
7574 err = __dev_set_mtu(dev, new_mtu); 7596 err = __dev_set_mtu(dev, new_mtu);
7575 7597
7576 if (!err) { 7598 if (!err) {
7577 err = call_netdevice_notifiers(NETDEV_CHANGEMTU, dev); 7599 err = call_netdevice_notifiers_mtu(NETDEV_CHANGEMTU, dev,
7600 orig_mtu);
7578 err = notifier_to_errno(err); 7601 err = notifier_to_errno(err);
7579 if (err) { 7602 if (err) {
7580 /* setting mtu back and notifying everyone again, 7603 /* setting mtu back and notifying everyone again,
7581 * so that they have a chance to revert changes. 7604 * so that they have a chance to revert changes.
7582 */ 7605 */
7583 __dev_set_mtu(dev, orig_mtu); 7606 __dev_set_mtu(dev, orig_mtu);
7584 call_netdevice_notifiers(NETDEV_CHANGEMTU, dev); 7607 call_netdevice_notifiers_mtu(NETDEV_CHANGEMTU, dev,
7608 new_mtu);
7585 } 7609 }
7586 } 7610 }
7587 return err; 7611 return err;
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 65fc366a78a4..6bc42933be4a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2592,7 +2592,7 @@ send_done:
2592 if (!nlh) { 2592 if (!nlh) {
2593 err = devlink_dpipe_send_and_alloc_skb(&skb, info); 2593 err = devlink_dpipe_send_and_alloc_skb(&skb, info);
2594 if (err) 2594 if (err)
2595 goto err_skb_send_alloc; 2595 return err;
2596 goto send_done; 2596 goto send_done;
2597 } 2597 }
2598 return genlmsg_reply(skb, info); 2598 return genlmsg_reply(skb, info);
@@ -2600,7 +2600,6 @@ send_done:
2600nla_put_failure: 2600nla_put_failure:
2601 err = -EMSGSIZE; 2601 err = -EMSGSIZE;
2602err_resource_put: 2602err_resource_put:
2603err_skb_send_alloc:
2604 nlmsg_free(skb); 2603 nlmsg_free(skb);
2605 return err; 2604 return err;
2606} 2605}
@@ -2996,6 +2995,8 @@ devlink_param_value_get_from_info(const struct devlink_param *param,
2996 struct genl_info *info, 2995 struct genl_info *info,
2997 union devlink_param_value *value) 2996 union devlink_param_value *value)
2998{ 2997{
2998 int len;
2999
2999 if (param->type != DEVLINK_PARAM_TYPE_BOOL && 3000 if (param->type != DEVLINK_PARAM_TYPE_BOOL &&
3000 !info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]) 3001 !info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA])
3001 return -EINVAL; 3002 return -EINVAL;
@@ -3011,10 +3012,13 @@ devlink_param_value_get_from_info(const struct devlink_param *param,
3011 value->vu32 = nla_get_u32(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]); 3012 value->vu32 = nla_get_u32(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]);
3012 break; 3013 break;
3013 case DEVLINK_PARAM_TYPE_STRING: 3014 case DEVLINK_PARAM_TYPE_STRING:
3014 if (nla_len(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]) > 3015 len = strnlen(nla_data(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]),
3015 DEVLINK_PARAM_MAX_STRING_VALUE) 3016 nla_len(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]));
3017 if (len == nla_len(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]) ||
3018 len >= __DEVLINK_PARAM_MAX_STRING_VALUE)
3016 return -EINVAL; 3019 return -EINVAL;
3017 value->vstr = nla_data(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]); 3020 strcpy(value->vstr,
3021 nla_data(info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]));
3018 break; 3022 break;
3019 case DEVLINK_PARAM_TYPE_BOOL: 3023 case DEVLINK_PARAM_TYPE_BOOL:
3020 value->vbool = info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA] ? 3024 value->vbool = info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA] ?
@@ -3101,7 +3105,10 @@ static int devlink_nl_cmd_param_set_doit(struct sk_buff *skb,
3101 return -EOPNOTSUPP; 3105 return -EOPNOTSUPP;
3102 3106
3103 if (cmode == DEVLINK_PARAM_CMODE_DRIVERINIT) { 3107 if (cmode == DEVLINK_PARAM_CMODE_DRIVERINIT) {
3104 param_item->driverinit_value = value; 3108 if (param->type == DEVLINK_PARAM_TYPE_STRING)
3109 strcpy(param_item->driverinit_value.vstr, value.vstr);
3110 else
3111 param_item->driverinit_value = value;
3105 param_item->driverinit_value_valid = true; 3112 param_item->driverinit_value_valid = true;
3106 } else { 3113 } else {
3107 if (!param->set) 3114 if (!param->set)
@@ -4541,7 +4548,10 @@ int devlink_param_driverinit_value_get(struct devlink *devlink, u32 param_id,
4541 DEVLINK_PARAM_CMODE_DRIVERINIT)) 4548 DEVLINK_PARAM_CMODE_DRIVERINIT))
4542 return -EOPNOTSUPP; 4549 return -EOPNOTSUPP;
4543 4550
4544 *init_val = param_item->driverinit_value; 4551 if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)
4552 strcpy(init_val->vstr, param_item->driverinit_value.vstr);
4553 else
4554 *init_val = param_item->driverinit_value;
4545 4555
4546 return 0; 4556 return 0;
4547} 4557}
@@ -4572,7 +4582,10 @@ int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
4572 DEVLINK_PARAM_CMODE_DRIVERINIT)) 4582 DEVLINK_PARAM_CMODE_DRIVERINIT))
4573 return -EOPNOTSUPP; 4583 return -EOPNOTSUPP;
4574 4584
4575 param_item->driverinit_value = init_val; 4585 if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)
4586 strcpy(param_item->driverinit_value.vstr, init_val.vstr);
4587 else
4588 param_item->driverinit_value = init_val;
4576 param_item->driverinit_value_valid = true; 4589 param_item->driverinit_value_valid = true;
4577 4590
4578 devlink_param_notify(devlink, param_item, DEVLINK_CMD_PARAM_NEW); 4591 devlink_param_notify(devlink, param_item, DEVLINK_CMD_PARAM_NEW);
@@ -4605,6 +4618,23 @@ void devlink_param_value_changed(struct devlink *devlink, u32 param_id)
4605EXPORT_SYMBOL_GPL(devlink_param_value_changed); 4618EXPORT_SYMBOL_GPL(devlink_param_value_changed);
4606 4619
4607/** 4620/**
4621 * devlink_param_value_str_fill - Safely fill-up the string preventing
4622 * from overflow of the preallocated buffer
4623 *
4624 * @dst_val: destination devlink_param_value
4625 * @src: source buffer
4626 */
4627void devlink_param_value_str_fill(union devlink_param_value *dst_val,
4628 const char *src)
4629{
4630 size_t len;
4631
4632 len = strlcpy(dst_val->vstr, src, __DEVLINK_PARAM_MAX_STRING_VALUE);
4633 WARN_ON(len >= __DEVLINK_PARAM_MAX_STRING_VALUE);
4634}
4635EXPORT_SYMBOL_GPL(devlink_param_value_str_fill);
4636
4637/**
4608 * devlink_region_create - create a new address region 4638 * devlink_region_create - create a new address region
4609 * 4639 *
4610 * @devlink: devlink 4640 * @devlink: devlink
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index c9993c6c2fd4..0762aaf8e964 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1483,6 +1483,7 @@ static int ethtool_get_wol(struct net_device *dev, char __user *useraddr)
1483static int ethtool_set_wol(struct net_device *dev, char __user *useraddr) 1483static int ethtool_set_wol(struct net_device *dev, char __user *useraddr)
1484{ 1484{
1485 struct ethtool_wolinfo wol; 1485 struct ethtool_wolinfo wol;
1486 int ret;
1486 1487
1487 if (!dev->ethtool_ops->set_wol) 1488 if (!dev->ethtool_ops->set_wol)
1488 return -EOPNOTSUPP; 1489 return -EOPNOTSUPP;
@@ -1490,7 +1491,13 @@ static int ethtool_set_wol(struct net_device *dev, char __user *useraddr)
1490 if (copy_from_user(&wol, useraddr, sizeof(wol))) 1491 if (copy_from_user(&wol, useraddr, sizeof(wol)))
1491 return -EFAULT; 1492 return -EFAULT;
1492 1493
1493 return dev->ethtool_ops->set_wol(dev, &wol); 1494 ret = dev->ethtool_ops->set_wol(dev, &wol);
1495 if (ret)
1496 return ret;
1497
1498 dev->wol_enabled = !!wol.wolopts;
1499
1500 return 0;
1494} 1501}
1495 1502
1496static int ethtool_get_eee(struct net_device *dev, char __user *useraddr) 1503static int ethtool_get_eee(struct net_device *dev, char __user *useraddr)
@@ -2624,6 +2631,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
2624 case ETHTOOL_GPHYSTATS: 2631 case ETHTOOL_GPHYSTATS:
2625 case ETHTOOL_GTSO: 2632 case ETHTOOL_GTSO:
2626 case ETHTOOL_GPERMADDR: 2633 case ETHTOOL_GPERMADDR:
2634 case ETHTOOL_GUFO:
2627 case ETHTOOL_GGSO: 2635 case ETHTOOL_GGSO:
2628 case ETHTOOL_GGRO: 2636 case ETHTOOL_GGRO:
2629 case ETHTOOL_GFLAGS: 2637 case ETHTOOL_GFLAGS:
diff --git a/net/core/filter.c b/net/core/filter.c
index aecdeba052d3..5e00f2b85a56 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2344,7 +2344,8 @@ BPF_CALL_4(bpf_msg_pull_data,
2344 if (unlikely(bytes_sg_total > copy)) 2344 if (unlikely(bytes_sg_total > copy))
2345 return -EINVAL; 2345 return -EINVAL;
2346 2346
2347 page = alloc_pages(__GFP_NOWARN | GFP_ATOMIC, get_order(copy)); 2347 page = alloc_pages(__GFP_NOWARN | GFP_ATOMIC | __GFP_COMP,
2348 get_order(copy));
2348 if (unlikely(!page)) 2349 if (unlikely(!page))
2349 return -ENOMEM; 2350 return -ENOMEM;
2350 p = page_address(page); 2351 p = page_address(page);
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index aa19d86937af..91592fceeaad 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1180,6 +1180,12 @@ int neigh_update(struct neighbour *neigh, const u8 *lladdr, u8 new,
1180 lladdr = neigh->ha; 1180 lladdr = neigh->ha;
1181 } 1181 }
1182 1182
1183 /* Update confirmed timestamp for neighbour entry after we
1184 * received ARP packet even if it doesn't change IP to MAC binding.
1185 */
1186 if (new & NUD_CONNECTED)
1187 neigh->confirmed = jiffies;
1188
1183 /* If entry was valid and address is not changed, 1189 /* If entry was valid and address is not changed,
1184 do not change entry state, if new one is STALE. 1190 do not change entry state, if new one is STALE.
1185 */ 1191 */
@@ -1201,15 +1207,12 @@ int neigh_update(struct neighbour *neigh, const u8 *lladdr, u8 new,
1201 } 1207 }
1202 } 1208 }
1203 1209
1204 /* Update timestamps only once we know we will make a change to the 1210 /* Update timestamp only once we know we will make a change to the
1205 * neighbour entry. Otherwise we risk to move the locktime window with 1211 * neighbour entry. Otherwise we risk to move the locktime window with
1206 * noop updates and ignore relevant ARP updates. 1212 * noop updates and ignore relevant ARP updates.
1207 */ 1213 */
1208 if (new != old || lladdr != neigh->ha) { 1214 if (new != old || lladdr != neigh->ha)
1209 if (new & NUD_CONNECTED)
1210 neigh->confirmed = jiffies;
1211 neigh->updated = jiffies; 1215 neigh->updated = jiffies;
1212 }
1213 1216
1214 if (new != old) { 1217 if (new != old) {
1215 neigh_del_timer(neigh); 1218 neigh_del_timer(neigh);
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 57557a6a950c..de1d1ba92f2d 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -135,27 +135,9 @@ static void queue_process(struct work_struct *work)
135 } 135 }
136} 136}
137 137
138/*
139 * Check whether delayed processing was scheduled for our NIC. If so,
140 * we attempt to grab the poll lock and use ->poll() to pump the card.
141 * If this fails, either we've recursed in ->poll() or it's already
142 * running on another CPU.
143 *
144 * Note: we don't mask interrupts with this lock because we're using
145 * trylock here and interrupts are already disabled in the softirq
146 * case. Further, we test the poll_owner to avoid recursion on UP
147 * systems where the lock doesn't exist.
148 */
149static void poll_one_napi(struct napi_struct *napi) 138static void poll_one_napi(struct napi_struct *napi)
150{ 139{
151 int work = 0; 140 int work;
152
153 /* net_rx_action's ->poll() invocations and our's are
154 * synchronized by this test which is only made while
155 * holding the napi->poll_lock.
156 */
157 if (!test_bit(NAPI_STATE_SCHED, &napi->state))
158 return;
159 141
160 /* If we set this bit but see that it has already been set, 142 /* If we set this bit but see that it has already been set,
161 * that indicates that napi has been disabled and we need 143 * that indicates that napi has been disabled and we need
@@ -187,16 +169,16 @@ static void poll_napi(struct net_device *dev)
187 } 169 }
188} 170}
189 171
190static void netpoll_poll_dev(struct net_device *dev) 172void netpoll_poll_dev(struct net_device *dev)
191{ 173{
192 const struct net_device_ops *ops;
193 struct netpoll_info *ni = rcu_dereference_bh(dev->npinfo); 174 struct netpoll_info *ni = rcu_dereference_bh(dev->npinfo);
175 const struct net_device_ops *ops;
194 176
195 /* Don't do any rx activity if the dev_lock mutex is held 177 /* Don't do any rx activity if the dev_lock mutex is held
196 * the dev_open/close paths use this to block netpoll activity 178 * the dev_open/close paths use this to block netpoll activity
197 * while changing device state 179 * while changing device state
198 */ 180 */
199 if (down_trylock(&ni->dev_lock)) 181 if (!ni || down_trylock(&ni->dev_lock))
200 return; 182 return;
201 183
202 if (!netif_running(dev)) { 184 if (!netif_running(dev)) {
@@ -205,13 +187,8 @@ static void netpoll_poll_dev(struct net_device *dev)
205 } 187 }
206 188
207 ops = dev->netdev_ops; 189 ops = dev->netdev_ops;
208 if (!ops->ndo_poll_controller) { 190 if (ops->ndo_poll_controller)
209 up(&ni->dev_lock); 191 ops->ndo_poll_controller(dev);
210 return;
211 }
212
213 /* Process pending work on NIC */
214 ops->ndo_poll_controller(dev);
215 192
216 poll_napi(dev); 193 poll_napi(dev);
217 194
@@ -219,6 +196,7 @@ static void netpoll_poll_dev(struct net_device *dev)
219 196
220 zap_completion_queue(); 197 zap_completion_queue();
221} 198}
199EXPORT_SYMBOL(netpoll_poll_dev);
222 200
223void netpoll_poll_disable(struct net_device *dev) 201void netpoll_poll_disable(struct net_device *dev)
224{ 202{
@@ -334,6 +312,7 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
334 /* It is up to the caller to keep npinfo alive. */ 312 /* It is up to the caller to keep npinfo alive. */
335 struct netpoll_info *npinfo; 313 struct netpoll_info *npinfo;
336 314
315 rcu_read_lock_bh();
337 lockdep_assert_irqs_disabled(); 316 lockdep_assert_irqs_disabled();
338 317
339 npinfo = rcu_dereference_bh(np->dev->npinfo); 318 npinfo = rcu_dereference_bh(np->dev->npinfo);
@@ -378,6 +357,7 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
378 skb_queue_tail(&npinfo->txq, skb); 357 skb_queue_tail(&npinfo->txq, skb);
379 schedule_delayed_work(&npinfo->tx_work,0); 358 schedule_delayed_work(&npinfo->tx_work,0);
380 } 359 }
360 rcu_read_unlock_bh();
381} 361}
382EXPORT_SYMBOL(netpoll_send_skb_on_dev); 362EXPORT_SYMBOL(netpoll_send_skb_on_dev);
383 363
@@ -613,8 +593,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev)
613 strlcpy(np->dev_name, ndev->name, IFNAMSIZ); 593 strlcpy(np->dev_name, ndev->name, IFNAMSIZ);
614 INIT_WORK(&np->cleanup_work, netpoll_async_cleanup); 594 INIT_WORK(&np->cleanup_work, netpoll_async_cleanup);
615 595
616 if ((ndev->priv_flags & IFF_DISABLE_NETPOLL) || 596 if (ndev->priv_flags & IFF_DISABLE_NETPOLL) {
617 !ndev->netdev_ops->ndo_poll_controller) {
618 np_err(np, "%s doesn't support polling, aborting\n", 597 np_err(np, "%s doesn't support polling, aborting\n",
619 np->dev_name); 598 np->dev_name);
620 err = -ENOTSUPP; 599 err = -ENOTSUPP;
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 60c928894a78..37c7936124e6 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1898,10 +1898,8 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
1898 if (tb[IFLA_IF_NETNSID]) { 1898 if (tb[IFLA_IF_NETNSID]) {
1899 netnsid = nla_get_s32(tb[IFLA_IF_NETNSID]); 1899 netnsid = nla_get_s32(tb[IFLA_IF_NETNSID]);
1900 tgt_net = get_target_net(skb->sk, netnsid); 1900 tgt_net = get_target_net(skb->sk, netnsid);
1901 if (IS_ERR(tgt_net)) { 1901 if (IS_ERR(tgt_net))
1902 tgt_net = net; 1902 return PTR_ERR(tgt_net);
1903 netnsid = -1;
1904 }
1905 } 1903 }
1906 1904
1907 if (tb[IFLA_EXT_MASK]) 1905 if (tb[IFLA_EXT_MASK])
@@ -2810,7 +2808,7 @@ int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm)
2810 } 2808 }
2811 2809
2812 if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) { 2810 if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) {
2813 __dev_notify_flags(dev, old_flags, 0U); 2811 __dev_notify_flags(dev, old_flags, (old_flags ^ dev->flags));
2814 } else { 2812 } else {
2815 dev->rtnl_link_state = RTNL_LINK_INITIALIZED; 2813 dev->rtnl_link_state = RTNL_LINK_INITIALIZED;
2816 __dev_notify_flags(dev, old_flags, ~0U); 2814 __dev_notify_flags(dev, old_flags, ~0U);
@@ -2837,6 +2835,12 @@ struct net_device *rtnl_create_link(struct net *net,
2837 else if (ops->get_num_rx_queues) 2835 else if (ops->get_num_rx_queues)
2838 num_rx_queues = ops->get_num_rx_queues(); 2836 num_rx_queues = ops->get_num_rx_queues();
2839 2837
2838 if (num_tx_queues < 1 || num_tx_queues > 4096)
2839 return ERR_PTR(-EINVAL);
2840
2841 if (num_rx_queues < 1 || num_rx_queues > 4096)
2842 return ERR_PTR(-EINVAL);
2843
2840 dev = alloc_netdev_mqs(ops->priv_size, ifname, name_assign_type, 2844 dev = alloc_netdev_mqs(ops->priv_size, ifname, name_assign_type,
2841 ops->setup, num_tx_queues, num_rx_queues); 2845 ops->setup, num_tx_queues, num_rx_queues);
2842 if (!dev) 2846 if (!dev)
@@ -3744,16 +3748,27 @@ static int rtnl_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb)
3744 int err = 0; 3748 int err = 0;
3745 int fidx = 0; 3749 int fidx = 0;
3746 3750
3747 err = nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, 3751 /* A hack to preserve kernel<->userspace interface.
3748 IFLA_MAX, ifla_policy, NULL); 3752 * Before Linux v4.12 this code accepted ndmsg since iproute2 v3.3.0.
3749 if (err < 0) { 3753 * However, ndmsg is shorter than ifinfomsg thus nlmsg_parse() bails.
3750 return -EINVAL; 3754 * So, check for ndmsg with an optional u32 attribute (not used here).
3751 } else if (err == 0) { 3755 * Fortunately these sizes don't conflict with the size of ifinfomsg
3752 if (tb[IFLA_MASTER]) 3756 * with an optional attribute.
3753 br_idx = nla_get_u32(tb[IFLA_MASTER]); 3757 */
3754 } 3758 if (nlmsg_len(cb->nlh) != sizeof(struct ndmsg) &&
3759 (nlmsg_len(cb->nlh) != sizeof(struct ndmsg) +
3760 nla_attr_size(sizeof(u32)))) {
3761 err = nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb,
3762 IFLA_MAX, ifla_policy, NULL);
3763 if (err < 0) {
3764 return -EINVAL;
3765 } else if (err == 0) {
3766 if (tb[IFLA_MASTER])
3767 br_idx = nla_get_u32(tb[IFLA_MASTER]);
3768 }
3755 3769
3756 brport_idx = ifm->ifi_index; 3770 brport_idx = ifm->ifi_index;
3771 }
3757 3772
3758 if (br_idx) { 3773 if (br_idx) {
3759 br_dev = __dev_get_by_index(net, br_idx); 3774 br_dev = __dev_get_by_index(net, br_idx);
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index c996c09d095f..428094b577fc 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -939,9 +939,6 @@ struct ubuf_info *sock_zerocopy_alloc(struct sock *sk, size_t size)
939 939
940 WARN_ON_ONCE(!in_task()); 940 WARN_ON_ONCE(!in_task());
941 941
942 if (!sock_flag(sk, SOCK_ZEROCOPY))
943 return NULL;
944
945 skb = sock_omalloc(sk, 0, GFP_KERNEL); 942 skb = sock_omalloc(sk, 0, GFP_KERNEL);
946 if (!skb) 943 if (!skb)
947 return NULL; 944 return NULL;
@@ -4455,14 +4452,16 @@ EXPORT_SYMBOL_GPL(skb_complete_wifi_ack);
4455 */ 4452 */
4456bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off) 4453bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off)
4457{ 4454{
4458 if (unlikely(start > skb_headlen(skb)) || 4455 u32 csum_end = (u32)start + (u32)off + sizeof(__sum16);
4459 unlikely((int)start + off > skb_headlen(skb) - 2)) { 4456 u32 csum_start = skb_headroom(skb) + (u32)start;
4460 net_warn_ratelimited("bad partial csum: csum=%u/%u len=%u\n", 4457
4461 start, off, skb_headlen(skb)); 4458 if (unlikely(csum_start > U16_MAX || csum_end > skb_headlen(skb))) {
4459 net_warn_ratelimited("bad partial csum: csum=%u/%u headroom=%u headlen=%u\n",
4460 start, off, skb_headroom(skb), skb_headlen(skb));
4462 return false; 4461 return false;
4463 } 4462 }
4464 skb->ip_summed = CHECKSUM_PARTIAL; 4463 skb->ip_summed = CHECKSUM_PARTIAL;
4465 skb->csum_start = skb_headroom(skb) + start; 4464 skb->csum_start = csum_start;
4466 skb->csum_offset = off; 4465 skb->csum_offset = off;
4467 skb_set_transport_header(skb, start); 4466 skb_set_transport_header(skb, start);
4468 return true; 4467 return true;
diff --git a/net/dccp/input.c b/net/dccp/input.c
index d28d46bff6ab..85d6c879383d 100644
--- a/net/dccp/input.c
+++ b/net/dccp/input.c
@@ -606,11 +606,13 @@ int dccp_rcv_state_process(struct sock *sk, struct sk_buff *skb,
606 if (sk->sk_state == DCCP_LISTEN) { 606 if (sk->sk_state == DCCP_LISTEN) {
607 if (dh->dccph_type == DCCP_PKT_REQUEST) { 607 if (dh->dccph_type == DCCP_PKT_REQUEST) {
608 /* It is possible that we process SYN packets from backlog, 608 /* It is possible that we process SYN packets from backlog,
609 * so we need to make sure to disable BH right there. 609 * so we need to make sure to disable BH and RCU right there.
610 */ 610 */
611 rcu_read_lock();
611 local_bh_disable(); 612 local_bh_disable();
612 acceptable = inet_csk(sk)->icsk_af_ops->conn_request(sk, skb) >= 0; 613 acceptable = inet_csk(sk)->icsk_af_ops->conn_request(sk, skb) >= 0;
613 local_bh_enable(); 614 local_bh_enable();
615 rcu_read_unlock();
614 if (!acceptable) 616 if (!acceptable)
615 return 1; 617 return 1;
616 consume_skb(skb); 618 consume_skb(skb);
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index b08feb219b44..8e08cea6f178 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -493,9 +493,11 @@ static int dccp_v4_send_response(const struct sock *sk, struct request_sock *req
493 493
494 dh->dccph_checksum = dccp_v4_csum_finish(skb, ireq->ir_loc_addr, 494 dh->dccph_checksum = dccp_v4_csum_finish(skb, ireq->ir_loc_addr,
495 ireq->ir_rmt_addr); 495 ireq->ir_rmt_addr);
496 rcu_read_lock();
496 err = ip_build_and_send_pkt(skb, sk, ireq->ir_loc_addr, 497 err = ip_build_and_send_pkt(skb, sk, ireq->ir_loc_addr,
497 ireq->ir_rmt_addr, 498 ireq->ir_rmt_addr,
498 ireq_opt_deref(ireq)); 499 rcu_dereference(ireq->ireq_opt));
500 rcu_read_unlock();
499 err = net_xmit_eval(err); 501 err = net_xmit_eval(err);
500 } 502 }
501 503
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 20fda8fb8ffd..1fbe2f815474 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1377,6 +1377,7 @@ struct sk_buff *inet_gso_segment(struct sk_buff *skb,
1377 if (encap) 1377 if (encap)
1378 skb_reset_inner_headers(skb); 1378 skb_reset_inner_headers(skb);
1379 skb->network_header = (u8 *)iph - skb->head; 1379 skb->network_header = (u8 *)iph - skb->head;
1380 skb_reset_mac_len(skb);
1380 } while ((skb = skb->next)); 1381 } while ((skb = skb->next));
1381 1382
1382out: 1383out:
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 2998b0e47d4b..0113993e9b2c 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -1243,7 +1243,8 @@ static int fib_inetaddr_event(struct notifier_block *this, unsigned long event,
1243static int fib_netdev_event(struct notifier_block *this, unsigned long event, void *ptr) 1243static int fib_netdev_event(struct notifier_block *this, unsigned long event, void *ptr)
1244{ 1244{
1245 struct net_device *dev = netdev_notifier_info_to_dev(ptr); 1245 struct net_device *dev = netdev_notifier_info_to_dev(ptr);
1246 struct netdev_notifier_changeupper_info *info; 1246 struct netdev_notifier_changeupper_info *upper_info = ptr;
1247 struct netdev_notifier_info_ext *info_ext = ptr;
1247 struct in_device *in_dev; 1248 struct in_device *in_dev;
1248 struct net *net = dev_net(dev); 1249 struct net *net = dev_net(dev);
1249 unsigned int flags; 1250 unsigned int flags;
@@ -1278,16 +1279,19 @@ static int fib_netdev_event(struct notifier_block *this, unsigned long event, vo
1278 fib_sync_up(dev, RTNH_F_LINKDOWN); 1279 fib_sync_up(dev, RTNH_F_LINKDOWN);
1279 else 1280 else
1280 fib_sync_down_dev(dev, event, false); 1281 fib_sync_down_dev(dev, event, false);
1281 /* fall through */ 1282 rt_cache_flush(net);
1283 break;
1282 case NETDEV_CHANGEMTU: 1284 case NETDEV_CHANGEMTU:
1285 fib_sync_mtu(dev, info_ext->ext.mtu);
1283 rt_cache_flush(net); 1286 rt_cache_flush(net);
1284 break; 1287 break;
1285 case NETDEV_CHANGEUPPER: 1288 case NETDEV_CHANGEUPPER:
1286 info = ptr; 1289 upper_info = ptr;
1287 /* flush all routes if dev is linked to or unlinked from 1290 /* flush all routes if dev is linked to or unlinked from
1288 * an L3 master device (e.g., VRF) 1291 * an L3 master device (e.g., VRF)
1289 */ 1292 */
1290 if (info->upper_dev && netif_is_l3_master(info->upper_dev)) 1293 if (upper_info->upper_dev &&
1294 netif_is_l3_master(upper_info->upper_dev))
1291 fib_disable_ip(dev, NETDEV_DOWN, true); 1295 fib_disable_ip(dev, NETDEV_DOWN, true);
1292 break; 1296 break;
1293 } 1297 }
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index f3c89ccf14c5..446204ca7406 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -1470,6 +1470,56 @@ static int call_fib_nh_notifiers(struct fib_nh *fib_nh,
1470 return NOTIFY_DONE; 1470 return NOTIFY_DONE;
1471} 1471}
1472 1472
1473/* Update the PMTU of exceptions when:
1474 * - the new MTU of the first hop becomes smaller than the PMTU
1475 * - the old MTU was the same as the PMTU, and it limited discovery of
1476 * larger MTUs on the path. With that limit raised, we can now
1477 * discover larger MTUs
1478 * A special case is locked exceptions, for which the PMTU is smaller
1479 * than the minimal accepted PMTU:
1480 * - if the new MTU is greater than the PMTU, don't make any change
1481 * - otherwise, unlock and set PMTU
1482 */
1483static void nh_update_mtu(struct fib_nh *nh, u32 new, u32 orig)
1484{
1485 struct fnhe_hash_bucket *bucket;
1486 int i;
1487
1488 bucket = rcu_dereference_protected(nh->nh_exceptions, 1);
1489 if (!bucket)
1490 return;
1491
1492 for (i = 0; i < FNHE_HASH_SIZE; i++) {
1493 struct fib_nh_exception *fnhe;
1494
1495 for (fnhe = rcu_dereference_protected(bucket[i].chain, 1);
1496 fnhe;
1497 fnhe = rcu_dereference_protected(fnhe->fnhe_next, 1)) {
1498 if (fnhe->fnhe_mtu_locked) {
1499 if (new <= fnhe->fnhe_pmtu) {
1500 fnhe->fnhe_pmtu = new;
1501 fnhe->fnhe_mtu_locked = false;
1502 }
1503 } else if (new < fnhe->fnhe_pmtu ||
1504 orig == fnhe->fnhe_pmtu) {
1505 fnhe->fnhe_pmtu = new;
1506 }
1507 }
1508 }
1509}
1510
1511void fib_sync_mtu(struct net_device *dev, u32 orig_mtu)
1512{
1513 unsigned int hash = fib_devindex_hashfn(dev->ifindex);
1514 struct hlist_head *head = &fib_info_devhash[hash];
1515 struct fib_nh *nh;
1516
1517 hlist_for_each_entry(nh, head, nh_hash) {
1518 if (nh->nh_dev == dev)
1519 nh_update_mtu(nh, dev->mtu, orig_mtu);
1520 }
1521}
1522
1473/* Event force Flags Description 1523/* Event force Flags Description
1474 * NETDEV_CHANGE 0 LINKDOWN Carrier OFF, not for scope host 1524 * NETDEV_CHANGE 0 LINKDOWN Carrier OFF, not for scope host
1475 * NETDEV_DOWN 0 LINKDOWN|DEAD Link down, not for scope host 1525 * NETDEV_DOWN 0 LINKDOWN|DEAD Link down, not for scope host
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index dfd5009f96ef..15e7f7915a21 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -544,7 +544,8 @@ struct dst_entry *inet_csk_route_req(const struct sock *sk,
544 struct ip_options_rcu *opt; 544 struct ip_options_rcu *opt;
545 struct rtable *rt; 545 struct rtable *rt;
546 546
547 opt = ireq_opt_deref(ireq); 547 rcu_read_lock();
548 opt = rcu_dereference(ireq->ireq_opt);
548 549
549 flowi4_init_output(fl4, ireq->ir_iif, ireq->ir_mark, 550 flowi4_init_output(fl4, ireq->ir_iif, ireq->ir_mark,
550 RT_CONN_FLAGS(sk), RT_SCOPE_UNIVERSE, 551 RT_CONN_FLAGS(sk), RT_SCOPE_UNIVERSE,
@@ -558,11 +559,13 @@ struct dst_entry *inet_csk_route_req(const struct sock *sk,
558 goto no_route; 559 goto no_route;
559 if (opt && opt->opt.is_strictroute && rt->rt_uses_gateway) 560 if (opt && opt->opt.is_strictroute && rt->rt_uses_gateway)
560 goto route_err; 561 goto route_err;
562 rcu_read_unlock();
561 return &rt->dst; 563 return &rt->dst;
562 564
563route_err: 565route_err:
564 ip_rt_put(rt); 566 ip_rt_put(rt);
565no_route: 567no_route:
568 rcu_read_unlock();
566 __IP_INC_STATS(net, IPSTATS_MIB_OUTNOROUTES); 569 __IP_INC_STATS(net, IPSTATS_MIB_OUTNOROUTES);
567 return NULL; 570 return NULL;
568} 571}
diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c
index 88281fbce88c..e7227128df2c 100644
--- a/net/ipv4/ip_fragment.c
+++ b/net/ipv4/ip_fragment.c
@@ -599,6 +599,7 @@ static int ip_frag_reasm(struct ipq *qp, struct sk_buff *skb,
599 nextp = &fp->next; 599 nextp = &fp->next;
600 fp->prev = NULL; 600 fp->prev = NULL;
601 memset(&fp->rbnode, 0, sizeof(fp->rbnode)); 601 memset(&fp->rbnode, 0, sizeof(fp->rbnode));
602 fp->sk = NULL;
602 head->data_len += fp->len; 603 head->data_len += fp->len;
603 head->len += fp->len; 604 head->len += fp->len;
604 if (head->ip_summed != fp->ip_summed) 605 if (head->ip_summed != fp->ip_summed)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index ae714aecc31c..8cce0e9ea08c 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -178,6 +178,9 @@ static void ipgre_err(struct sk_buff *skb, u32 info,
178 178
179 if (tpi->proto == htons(ETH_P_TEB)) 179 if (tpi->proto == htons(ETH_P_TEB))
180 itn = net_generic(net, gre_tap_net_id); 180 itn = net_generic(net, gre_tap_net_id);
181 else if (tpi->proto == htons(ETH_P_ERSPAN) ||
182 tpi->proto == htons(ETH_P_ERSPAN2))
183 itn = net_generic(net, erspan_net_id);
181 else 184 else
182 itn = net_generic(net, ipgre_net_id); 185 itn = net_generic(net, ipgre_net_id);
183 186
@@ -328,6 +331,8 @@ static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi,
328 ip_tunnel_rcv(tunnel, skb, tpi, tun_dst, log_ecn_error); 331 ip_tunnel_rcv(tunnel, skb, tpi, tun_dst, log_ecn_error);
329 return PACKET_RCVD; 332 return PACKET_RCVD;
330 } 333 }
334 return PACKET_REJECT;
335
331drop: 336drop:
332 kfree_skb(skb); 337 kfree_skb(skb);
333 return PACKET_RCVD; 338 return PACKET_RCVD;
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index c0fe5ad996f2..26c36cccabdc 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -149,7 +149,6 @@ static void ip_cmsg_recv_security(struct msghdr *msg, struct sk_buff *skb)
149static void ip_cmsg_recv_dstaddr(struct msghdr *msg, struct sk_buff *skb) 149static void ip_cmsg_recv_dstaddr(struct msghdr *msg, struct sk_buff *skb)
150{ 150{
151 struct sockaddr_in sin; 151 struct sockaddr_in sin;
152 const struct iphdr *iph = ip_hdr(skb);
153 __be16 *ports; 152 __be16 *ports;
154 int end; 153 int end;
155 154
@@ -164,7 +163,7 @@ static void ip_cmsg_recv_dstaddr(struct msghdr *msg, struct sk_buff *skb)
164 ports = (__be16 *)skb_transport_header(skb); 163 ports = (__be16 *)skb_transport_header(skb);
165 164
166 sin.sin_family = AF_INET; 165 sin.sin_family = AF_INET;
167 sin.sin_addr.s_addr = iph->daddr; 166 sin.sin_addr.s_addr = ip_hdr(skb)->daddr;
168 sin.sin_port = ports[1]; 167 sin.sin_port = ports[1];
169 memset(sin.sin_zero, 0, sizeof(sin.sin_zero)); 168 memset(sin.sin_zero, 0, sizeof(sin.sin_zero));
170 169
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index c4f5602308ed..284a22154b4e 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -627,6 +627,7 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev,
627 const struct iphdr *tnl_params, u8 protocol) 627 const struct iphdr *tnl_params, u8 protocol)
628{ 628{
629 struct ip_tunnel *tunnel = netdev_priv(dev); 629 struct ip_tunnel *tunnel = netdev_priv(dev);
630 unsigned int inner_nhdr_len = 0;
630 const struct iphdr *inner_iph; 631 const struct iphdr *inner_iph;
631 struct flowi4 fl4; 632 struct flowi4 fl4;
632 u8 tos, ttl; 633 u8 tos, ttl;
@@ -636,6 +637,14 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev,
636 __be32 dst; 637 __be32 dst;
637 bool connected; 638 bool connected;
638 639
640 /* ensure we can access the inner net header, for several users below */
641 if (skb->protocol == htons(ETH_P_IP))
642 inner_nhdr_len = sizeof(struct iphdr);
643 else if (skb->protocol == htons(ETH_P_IPV6))
644 inner_nhdr_len = sizeof(struct ipv6hdr);
645 if (unlikely(!pskb_may_pull(skb, inner_nhdr_len)))
646 goto tx_error;
647
639 inner_iph = (const struct iphdr *)skb_inner_network_header(skb); 648 inner_iph = (const struct iphdr *)skb_inner_network_header(skb);
640 connected = (tunnel->parms.iph.daddr != 0); 649 connected = (tunnel->parms.iph.daddr != 0);
641 650
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index d9504adc47b3..184bf2e0a1ed 100644
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -106,6 +106,10 @@ config NF_NAT_IPV4
106 106
107if NF_NAT_IPV4 107if NF_NAT_IPV4
108 108
109config NF_NAT_MASQUERADE_IPV4
110 bool
111
112if NF_TABLES
109config NFT_CHAIN_NAT_IPV4 113config NFT_CHAIN_NAT_IPV4
110 depends on NF_TABLES_IPV4 114 depends on NF_TABLES_IPV4
111 tristate "IPv4 nf_tables nat chain support" 115 tristate "IPv4 nf_tables nat chain support"
@@ -115,9 +119,6 @@ config NFT_CHAIN_NAT_IPV4
115 packet transformations such as the source, destination address and 119 packet transformations such as the source, destination address and
116 source and destination ports. 120 source and destination ports.
117 121
118config NF_NAT_MASQUERADE_IPV4
119 bool
120
121config NFT_MASQ_IPV4 122config NFT_MASQ_IPV4
122 tristate "IPv4 masquerading support for nf_tables" 123 tristate "IPv4 masquerading support for nf_tables"
123 depends on NF_TABLES_IPV4 124 depends on NF_TABLES_IPV4
@@ -135,6 +136,7 @@ config NFT_REDIR_IPV4
135 help 136 help
136 This is the expression that provides IPv4 redirect support for 137 This is the expression that provides IPv4 redirect support for
137 nf_tables. 138 nf_tables.
139endif # NF_TABLES
138 140
139config NF_NAT_SNMP_BASIC 141config NF_NAT_SNMP_BASIC
140 tristate "Basic SNMP-ALG support" 142 tristate "Basic SNMP-ALG support"
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index b678466da451..8501554e96a4 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1001,21 +1001,22 @@ out: kfree_skb(skb);
1001static void __ip_rt_update_pmtu(struct rtable *rt, struct flowi4 *fl4, u32 mtu) 1001static void __ip_rt_update_pmtu(struct rtable *rt, struct flowi4 *fl4, u32 mtu)
1002{ 1002{
1003 struct dst_entry *dst = &rt->dst; 1003 struct dst_entry *dst = &rt->dst;
1004 u32 old_mtu = ipv4_mtu(dst);
1004 struct fib_result res; 1005 struct fib_result res;
1005 bool lock = false; 1006 bool lock = false;
1006 1007
1007 if (ip_mtu_locked(dst)) 1008 if (ip_mtu_locked(dst))
1008 return; 1009 return;
1009 1010
1010 if (ipv4_mtu(dst) < mtu) 1011 if (old_mtu < mtu)
1011 return; 1012 return;
1012 1013
1013 if (mtu < ip_rt_min_pmtu) { 1014 if (mtu < ip_rt_min_pmtu) {
1014 lock = true; 1015 lock = true;
1015 mtu = ip_rt_min_pmtu; 1016 mtu = min(old_mtu, ip_rt_min_pmtu);
1016 } 1017 }
1017 1018
1018 if (rt->rt_pmtu == mtu && 1019 if (rt->rt_pmtu == mtu && !lock &&
1019 time_before(jiffies, dst->expires - ip_rt_mtu_expires / 2)) 1020 time_before(jiffies, dst->expires - ip_rt_mtu_expires / 2))
1020 return; 1021 return;
1021 1022
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index b92f422f2fa8..891ed2f91467 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -48,6 +48,7 @@ static int tcp_syn_retries_max = MAX_TCP_SYNCNT;
48static int ip_ping_group_range_min[] = { 0, 0 }; 48static int ip_ping_group_range_min[] = { 0, 0 };
49static int ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX }; 49static int ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX };
50static int comp_sack_nr_max = 255; 50static int comp_sack_nr_max = 255;
51static u32 u32_max_div_HZ = UINT_MAX / HZ;
51 52
52/* obsolete */ 53/* obsolete */
53static int sysctl_tcp_low_latency __read_mostly; 54static int sysctl_tcp_low_latency __read_mostly;
@@ -745,9 +746,10 @@ static struct ctl_table ipv4_net_table[] = {
745 { 746 {
746 .procname = "tcp_probe_interval", 747 .procname = "tcp_probe_interval",
747 .data = &init_net.ipv4.sysctl_tcp_probe_interval, 748 .data = &init_net.ipv4.sysctl_tcp_probe_interval,
748 .maxlen = sizeof(int), 749 .maxlen = sizeof(u32),
749 .mode = 0644, 750 .mode = 0644,
750 .proc_handler = proc_dointvec, 751 .proc_handler = proc_douintvec_minmax,
752 .extra2 = &u32_max_div_HZ,
751 }, 753 },
752 { 754 {
753 .procname = "igmp_link_local_mcast_reports", 755 .procname = "igmp_link_local_mcast_reports",
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index b8af2fec5ad5..10c6246396cc 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1185,7 +1185,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
1185 1185
1186 flags = msg->msg_flags; 1186 flags = msg->msg_flags;
1187 1187
1188 if (flags & MSG_ZEROCOPY && size) { 1188 if (flags & MSG_ZEROCOPY && size && sock_flag(sk, SOCK_ZEROCOPY)) {
1189 if (sk->sk_state != TCP_ESTABLISHED) { 1189 if (sk->sk_state != TCP_ESTABLISHED) {
1190 err = -EINVAL; 1190 err = -EINVAL;
1191 goto out_err; 1191 goto out_err;
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 4c2dd9f863f7..47e08c1b5bc3 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -6009,11 +6009,13 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb)
6009 if (th->fin) 6009 if (th->fin)
6010 goto discard; 6010 goto discard;
6011 /* It is possible that we process SYN packets from backlog, 6011 /* It is possible that we process SYN packets from backlog,
6012 * so we need to make sure to disable BH right there. 6012 * so we need to make sure to disable BH and RCU right there.
6013 */ 6013 */
6014 rcu_read_lock();
6014 local_bh_disable(); 6015 local_bh_disable();
6015 acceptable = icsk->icsk_af_ops->conn_request(sk, skb) >= 0; 6016 acceptable = icsk->icsk_af_ops->conn_request(sk, skb) >= 0;
6016 local_bh_enable(); 6017 local_bh_enable();
6018 rcu_read_unlock();
6017 6019
6018 if (!acceptable) 6020 if (!acceptable)
6019 return 1; 6021 return 1;
@@ -6367,8 +6369,8 @@ static bool tcp_syn_flood_action(const struct sock *sk,
6367 if (!queue->synflood_warned && 6369 if (!queue->synflood_warned &&
6368 net->ipv4.sysctl_tcp_syncookies != 2 && 6370 net->ipv4.sysctl_tcp_syncookies != 2 &&
6369 xchg(&queue->synflood_warned, 1) == 0) 6371 xchg(&queue->synflood_warned, 1) == 0)
6370 pr_info("%s: Possible SYN flooding on port %d. %s. Check SNMP counters.\n", 6372 net_info_ratelimited("%s: Possible SYN flooding on port %d. %s. Check SNMP counters.\n",
6371 proto, ntohs(tcp_hdr(skb)->dest), msg); 6373 proto, ntohs(tcp_hdr(skb)->dest), msg);
6372 6374
6373 return want_cookie; 6375 return want_cookie;
6374} 6376}
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 44c09eddbb78..cd426313a298 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -943,9 +943,11 @@ static int tcp_v4_send_synack(const struct sock *sk, struct dst_entry *dst,
943 if (skb) { 943 if (skb) {
944 __tcp_v4_send_check(skb, ireq->ir_loc_addr, ireq->ir_rmt_addr); 944 __tcp_v4_send_check(skb, ireq->ir_loc_addr, ireq->ir_rmt_addr);
945 945
946 rcu_read_lock();
946 err = ip_build_and_send_pkt(skb, sk, ireq->ir_loc_addr, 947 err = ip_build_and_send_pkt(skb, sk, ireq->ir_loc_addr,
947 ireq->ir_rmt_addr, 948 ireq->ir_rmt_addr,
948 ireq_opt_deref(ireq)); 949 rcu_dereference(ireq->ireq_opt));
950 rcu_read_unlock();
949 err = net_xmit_eval(err); 951 err = net_xmit_eval(err);
950 } 952 }
951 953
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index f4e35b2ff8b8..c32a4c16b7ff 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1627,7 +1627,7 @@ busy_check:
1627 *err = error; 1627 *err = error;
1628 return NULL; 1628 return NULL;
1629} 1629}
1630EXPORT_SYMBOL_GPL(__skb_recv_udp); 1630EXPORT_SYMBOL(__skb_recv_udp);
1631 1631
1632/* 1632/*
1633 * This should be easy, if there is something there we 1633 * This should be easy, if there is something there we
@@ -2124,6 +2124,28 @@ static inline int udp4_csum_init(struct sk_buff *skb, struct udphdr *uh,
2124 inet_compute_pseudo); 2124 inet_compute_pseudo);
2125} 2125}
2126 2126
2127/* wrapper for udp_queue_rcv_skb tacking care of csum conversion and
2128 * return code conversion for ip layer consumption
2129 */
2130static int udp_unicast_rcv_skb(struct sock *sk, struct sk_buff *skb,
2131 struct udphdr *uh)
2132{
2133 int ret;
2134
2135 if (inet_get_convert_csum(sk) && uh->check && !IS_UDPLITE(sk))
2136 skb_checksum_try_convert(skb, IPPROTO_UDP, uh->check,
2137 inet_compute_pseudo);
2138
2139 ret = udp_queue_rcv_skb(sk, skb);
2140
2141 /* a return value > 0 means to resubmit the input, but
2142 * it wants the return to be -protocol, or 0
2143 */
2144 if (ret > 0)
2145 return -ret;
2146 return 0;
2147}
2148
2127/* 2149/*
2128 * All we need to do is get the socket, and then do a checksum. 2150 * All we need to do is get the socket, and then do a checksum.
2129 */ 2151 */
@@ -2170,14 +2192,9 @@ int __udp4_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
2170 if (unlikely(sk->sk_rx_dst != dst)) 2192 if (unlikely(sk->sk_rx_dst != dst))
2171 udp_sk_rx_dst_set(sk, dst); 2193 udp_sk_rx_dst_set(sk, dst);
2172 2194
2173 ret = udp_queue_rcv_skb(sk, skb); 2195 ret = udp_unicast_rcv_skb(sk, skb, uh);
2174 sock_put(sk); 2196 sock_put(sk);
2175 /* a return value > 0 means to resubmit the input, but 2197 return ret;
2176 * it wants the return to be -protocol, or 0
2177 */
2178 if (ret > 0)
2179 return -ret;
2180 return 0;
2181 } 2198 }
2182 2199
2183 if (rt->rt_flags & (RTCF_BROADCAST|RTCF_MULTICAST)) 2200 if (rt->rt_flags & (RTCF_BROADCAST|RTCF_MULTICAST))
@@ -2185,22 +2202,8 @@ int __udp4_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
2185 saddr, daddr, udptable, proto); 2202 saddr, daddr, udptable, proto);
2186 2203
2187 sk = __udp4_lib_lookup_skb(skb, uh->source, uh->dest, udptable); 2204 sk = __udp4_lib_lookup_skb(skb, uh->source, uh->dest, udptable);
2188 if (sk) { 2205 if (sk)
2189 int ret; 2206 return udp_unicast_rcv_skb(sk, skb, uh);
2190
2191 if (inet_get_convert_csum(sk) && uh->check && !IS_UDPLITE(sk))
2192 skb_checksum_try_convert(skb, IPPROTO_UDP, uh->check,
2193 inet_compute_pseudo);
2194
2195 ret = udp_queue_rcv_skb(sk, skb);
2196
2197 /* a return value > 0 means to resubmit the input, but
2198 * it wants the return to be -protocol, or 0
2199 */
2200 if (ret > 0)
2201 return -ret;
2202 return 0;
2203 }
2204 2207
2205 if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb)) 2208 if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb))
2206 goto drop; 2209 goto drop;
diff --git a/net/ipv4/xfrm4_input.c b/net/ipv4/xfrm4_input.c
index bcfc00e88756..f8de2482a529 100644
--- a/net/ipv4/xfrm4_input.c
+++ b/net/ipv4/xfrm4_input.c
@@ -67,6 +67,7 @@ int xfrm4_transport_finish(struct sk_buff *skb, int async)
67 67
68 if (xo && (xo->flags & XFRM_GRO)) { 68 if (xo && (xo->flags & XFRM_GRO)) {
69 skb_mac_header_rebuild(skb); 69 skb_mac_header_rebuild(skb);
70 skb_reset_transport_header(skb);
70 return 0; 71 return 0;
71 } 72 }
72 73
diff --git a/net/ipv4/xfrm4_mode_transport.c b/net/ipv4/xfrm4_mode_transport.c
index 3d36644890bb..1ad2c2c4e250 100644
--- a/net/ipv4/xfrm4_mode_transport.c
+++ b/net/ipv4/xfrm4_mode_transport.c
@@ -46,7 +46,6 @@ static int xfrm4_transport_output(struct xfrm_state *x, struct sk_buff *skb)
46static int xfrm4_transport_input(struct xfrm_state *x, struct sk_buff *skb) 46static int xfrm4_transport_input(struct xfrm_state *x, struct sk_buff *skb)
47{ 47{
48 int ihl = skb->data - skb_transport_header(skb); 48 int ihl = skb->data - skb_transport_header(skb);
49 struct xfrm_offload *xo = xfrm_offload(skb);
50 49
51 if (skb->transport_header != skb->network_header) { 50 if (skb->transport_header != skb->network_header) {
52 memmove(skb_transport_header(skb), 51 memmove(skb_transport_header(skb),
@@ -54,8 +53,7 @@ static int xfrm4_transport_input(struct xfrm_state *x, struct sk_buff *skb)
54 skb->network_header = skb->transport_header; 53 skb->network_header = skb->transport_header;
55 } 54 }
56 ip_hdr(skb)->tot_len = htons(skb->len + ihl); 55 ip_hdr(skb)->tot_len = htons(skb->len + ihl);
57 if (!xo || !(xo->flags & XFRM_GRO)) 56 skb_reset_transport_header(skb);
58 skb_reset_transport_header(skb);
59 return 0; 57 return 0;
60} 58}
61 59
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index d51a8c0b3372..c63ccce6425f 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -4201,7 +4201,6 @@ static struct inet6_ifaddr *if6_get_first(struct seq_file *seq, loff_t pos)
4201 p++; 4201 p++;
4202 continue; 4202 continue;
4203 } 4203 }
4204 state->offset++;
4205 return ifa; 4204 return ifa;
4206 } 4205 }
4207 4206
@@ -4225,13 +4224,12 @@ static struct inet6_ifaddr *if6_get_next(struct seq_file *seq,
4225 return ifa; 4224 return ifa;
4226 } 4225 }
4227 4226
4227 state->offset = 0;
4228 while (++state->bucket < IN6_ADDR_HSIZE) { 4228 while (++state->bucket < IN6_ADDR_HSIZE) {
4229 state->offset = 0;
4230 hlist_for_each_entry_rcu(ifa, 4229 hlist_for_each_entry_rcu(ifa,
4231 &inet6_addr_lst[state->bucket], addr_lst) { 4230 &inet6_addr_lst[state->bucket], addr_lst) {
4232 if (!net_eq(dev_net(ifa->idev->dev), net)) 4231 if (!net_eq(dev_net(ifa->idev->dev), net))
4233 continue; 4232 continue;
4234 state->offset++;
4235 return ifa; 4233 return ifa;
4236 } 4234 }
4237 } 4235 }
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 5516f55e214b..cbe46175bb59 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -196,6 +196,8 @@ void fib6_info_destroy_rcu(struct rcu_head *head)
196 *ppcpu_rt = NULL; 196 *ppcpu_rt = NULL;
197 } 197 }
198 } 198 }
199
200 free_percpu(f6i->rt6i_pcpu);
199 } 201 }
200 202
201 lwtstate_put(f6i->fib6_nh.nh_lwtstate); 203 lwtstate_put(f6i->fib6_nh.nh_lwtstate);
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index 37ff4805b20c..c7e495f12011 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -115,6 +115,7 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb,
115 payload_len = skb->len - nhoff - sizeof(*ipv6h); 115 payload_len = skb->len - nhoff - sizeof(*ipv6h);
116 ipv6h->payload_len = htons(payload_len); 116 ipv6h->payload_len = htons(payload_len);
117 skb->network_header = (u8 *)ipv6h - skb->head; 117 skb->network_header = (u8 *)ipv6h - skb->head;
118 skb_reset_mac_len(skb);
118 119
119 if (udpfrag) { 120 if (udpfrag) {
120 int err = ip6_find_1stfragopt(skb, &prevhdr); 121 int err = ip6_find_1stfragopt(skb, &prevhdr);
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 16f200f06500..f9f8f554d141 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -219,12 +219,10 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
219 kfree_skb(skb); 219 kfree_skb(skb);
220 return -ENOBUFS; 220 return -ENOBUFS;
221 } 221 }
222 if (skb->sk)
223 skb_set_owner_w(skb2, skb->sk);
222 consume_skb(skb); 224 consume_skb(skb);
223 skb = skb2; 225 skb = skb2;
224 /* skb_set_owner_w() changes sk->sk_wmem_alloc atomically,
225 * it is safe to call in our context (socket lock not held)
226 */
227 skb_set_owner_w(skb, (struct sock *)sk);
228 } 226 }
229 if (opt->opt_flen) 227 if (opt->opt_flen)
230 ipv6_push_frag_opts(skb, opt, &proto); 228 ipv6_push_frag_opts(skb, opt, &proto);
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index 419960b0ba16..a0b6932c3afd 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -1234,7 +1234,7 @@ static inline int
1234ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev) 1234ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
1235{ 1235{
1236 struct ip6_tnl *t = netdev_priv(dev); 1236 struct ip6_tnl *t = netdev_priv(dev);
1237 const struct iphdr *iph = ip_hdr(skb); 1237 const struct iphdr *iph;
1238 int encap_limit = -1; 1238 int encap_limit = -1;
1239 struct flowi6 fl6; 1239 struct flowi6 fl6;
1240 __u8 dsfield; 1240 __u8 dsfield;
@@ -1242,6 +1242,11 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
1242 u8 tproto; 1242 u8 tproto;
1243 int err; 1243 int err;
1244 1244
1245 /* ensure we can access the full inner ip header */
1246 if (!pskb_may_pull(skb, sizeof(struct iphdr)))
1247 return -1;
1248
1249 iph = ip_hdr(skb);
1245 memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt)); 1250 memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
1246 1251
1247 tproto = READ_ONCE(t->parms.proto); 1252 tproto = READ_ONCE(t->parms.proto);
@@ -1306,7 +1311,7 @@ static inline int
1306ip6ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev) 1311ip6ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
1307{ 1312{
1308 struct ip6_tnl *t = netdev_priv(dev); 1313 struct ip6_tnl *t = netdev_priv(dev);
1309 struct ipv6hdr *ipv6h = ipv6_hdr(skb); 1314 struct ipv6hdr *ipv6h;
1310 int encap_limit = -1; 1315 int encap_limit = -1;
1311 __u16 offset; 1316 __u16 offset;
1312 struct flowi6 fl6; 1317 struct flowi6 fl6;
@@ -1315,6 +1320,10 @@ ip6ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
1315 u8 tproto; 1320 u8 tproto;
1316 int err; 1321 int err;
1317 1322
1323 if (unlikely(!pskb_may_pull(skb, sizeof(*ipv6h))))
1324 return -1;
1325
1326 ipv6h = ipv6_hdr(skb);
1318 tproto = READ_ONCE(t->parms.proto); 1327 tproto = READ_ONCE(t->parms.proto);
1319 if ((tproto != IPPROTO_IPV6 && tproto != 0) || 1328 if ((tproto != IPPROTO_IPV6 && tproto != 0) ||
1320 ip6_tnl_addr_conflict(t, ipv6h)) 1329 ip6_tnl_addr_conflict(t, ipv6h))
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c
index 2a14d8b65924..8f68a518d9db 100644
--- a/net/ipv6/netfilter/nf_conntrack_reasm.c
+++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
@@ -445,6 +445,7 @@ nf_ct_frag6_reasm(struct frag_queue *fq, struct sk_buff *prev, struct net_devic
445 else if (head->ip_summed == CHECKSUM_COMPLETE) 445 else if (head->ip_summed == CHECKSUM_COMPLETE)
446 head->csum = csum_add(head->csum, fp->csum); 446 head->csum = csum_add(head->csum, fp->csum);
447 head->truesize += fp->truesize; 447 head->truesize += fp->truesize;
448 fp->sk = NULL;
448 } 449 }
449 sub_frag_mem_limit(fq->q.net, head->truesize); 450 sub_frag_mem_limit(fq->q.net, head->truesize);
450 451
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 413d98bf24f4..5e0efd3954e9 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -651,8 +651,6 @@ static int rawv6_send_hdrinc(struct sock *sk, struct msghdr *msg, int length,
651 skb->priority = sk->sk_priority; 651 skb->priority = sk->sk_priority;
652 skb->mark = sk->sk_mark; 652 skb->mark = sk->sk_mark;
653 skb->tstamp = sockc->transmit_time; 653 skb->tstamp = sockc->transmit_time;
654 skb_dst_set(skb, &rt->dst);
655 *dstp = NULL;
656 654
657 skb_put(skb, length); 655 skb_put(skb, length);
658 skb_reset_network_header(skb); 656 skb_reset_network_header(skb);
@@ -665,8 +663,14 @@ static int rawv6_send_hdrinc(struct sock *sk, struct msghdr *msg, int length,
665 663
666 skb->transport_header = skb->network_header; 664 skb->transport_header = skb->network_header;
667 err = memcpy_from_msg(iph, msg, length); 665 err = memcpy_from_msg(iph, msg, length);
668 if (err) 666 if (err) {
669 goto error_fault; 667 err = -EFAULT;
668 kfree_skb(skb);
669 goto error;
670 }
671
672 skb_dst_set(skb, &rt->dst);
673 *dstp = NULL;
670 674
671 /* if egress device is enslaved to an L3 master device pass the 675 /* if egress device is enslaved to an L3 master device pass the
672 * skb to its handler for processing 676 * skb to its handler for processing
@@ -675,21 +679,28 @@ static int rawv6_send_hdrinc(struct sock *sk, struct msghdr *msg, int length,
675 if (unlikely(!skb)) 679 if (unlikely(!skb))
676 return 0; 680 return 0;
677 681
682 /* Acquire rcu_read_lock() in case we need to use rt->rt6i_idev
683 * in the error path. Since skb has been freed, the dst could
684 * have been queued for deletion.
685 */
686 rcu_read_lock();
678 IP6_UPD_PO_STATS(net, rt->rt6i_idev, IPSTATS_MIB_OUT, skb->len); 687 IP6_UPD_PO_STATS(net, rt->rt6i_idev, IPSTATS_MIB_OUT, skb->len);
679 err = NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_OUT, net, sk, skb, 688 err = NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_OUT, net, sk, skb,
680 NULL, rt->dst.dev, dst_output); 689 NULL, rt->dst.dev, dst_output);
681 if (err > 0) 690 if (err > 0)
682 err = net_xmit_errno(err); 691 err = net_xmit_errno(err);
683 if (err) 692 if (err) {
684 goto error; 693 IP6_INC_STATS(net, rt->rt6i_idev, IPSTATS_MIB_OUTDISCARDS);
694 rcu_read_unlock();
695 goto error_check;
696 }
697 rcu_read_unlock();
685out: 698out:
686 return 0; 699 return 0;
687 700
688error_fault:
689 err = -EFAULT;
690 kfree_skb(skb);
691error: 701error:
692 IP6_INC_STATS(net, rt->rt6i_idev, IPSTATS_MIB_OUTDISCARDS); 702 IP6_INC_STATS(net, rt->rt6i_idev, IPSTATS_MIB_OUTDISCARDS);
703error_check:
693 if (err == -ENOBUFS && !np->recverr) 704 if (err == -ENOBUFS && !np->recverr)
694 err = 0; 705 err = 0;
695 return err; 706 return err;
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 18e00ce1719a..a366c05a239d 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -364,11 +364,14 @@ EXPORT_SYMBOL(ip6_dst_alloc);
364 364
365static void ip6_dst_destroy(struct dst_entry *dst) 365static void ip6_dst_destroy(struct dst_entry *dst)
366{ 366{
367 struct dst_metrics *p = (struct dst_metrics *)DST_METRICS_PTR(dst);
367 struct rt6_info *rt = (struct rt6_info *)dst; 368 struct rt6_info *rt = (struct rt6_info *)dst;
368 struct fib6_info *from; 369 struct fib6_info *from;
369 struct inet6_dev *idev; 370 struct inet6_dev *idev;
370 371
371 dst_destroy_metrics_generic(dst); 372 if (p != &dst_default_metrics && refcount_dec_and_test(&p->refcnt))
373 kfree(p);
374
372 rt6_uncached_list_del(rt); 375 rt6_uncached_list_del(rt);
373 376
374 idev = rt->rt6i_idev; 377 idev = rt->rt6i_idev;
@@ -946,8 +949,6 @@ static void ip6_rt_init_dst_reject(struct rt6_info *rt, struct fib6_info *ort)
946 949
947static void ip6_rt_init_dst(struct rt6_info *rt, struct fib6_info *ort) 950static void ip6_rt_init_dst(struct rt6_info *rt, struct fib6_info *ort)
948{ 951{
949 rt->dst.flags |= fib6_info_dst_flags(ort);
950
951 if (ort->fib6_flags & RTF_REJECT) { 952 if (ort->fib6_flags & RTF_REJECT) {
952 ip6_rt_init_dst_reject(rt, ort); 953 ip6_rt_init_dst_reject(rt, ort);
953 return; 954 return;
@@ -978,6 +979,10 @@ static void rt6_set_from(struct rt6_info *rt, struct fib6_info *from)
978 rt->rt6i_flags &= ~RTF_EXPIRES; 979 rt->rt6i_flags &= ~RTF_EXPIRES;
979 rcu_assign_pointer(rt->from, from); 980 rcu_assign_pointer(rt->from, from);
980 dst_init_metrics(&rt->dst, from->fib6_metrics->metrics, true); 981 dst_init_metrics(&rt->dst, from->fib6_metrics->metrics, true);
982 if (from->fib6_metrics != &dst_default_metrics) {
983 rt->dst._metrics |= DST_METRICS_REFCOUNTED;
984 refcount_inc(&from->fib6_metrics->refcnt);
985 }
981} 986}
982 987
983/* Caller must already hold reference to @ort */ 988/* Caller must already hold reference to @ort */
@@ -4316,11 +4321,6 @@ static int ip6_route_info_append(struct net *net,
4316 if (!nh) 4321 if (!nh)
4317 return -ENOMEM; 4322 return -ENOMEM;
4318 nh->fib6_info = rt; 4323 nh->fib6_info = rt;
4319 err = ip6_convert_metrics(net, rt, r_cfg);
4320 if (err) {
4321 kfree(nh);
4322 return err;
4323 }
4324 memcpy(&nh->r_cfg, r_cfg, sizeof(*r_cfg)); 4324 memcpy(&nh->r_cfg, r_cfg, sizeof(*r_cfg));
4325 list_add_tail(&nh->next, rt6_nh_list); 4325 list_add_tail(&nh->next, rt6_nh_list);
4326 4326
@@ -4670,20 +4670,31 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4670 int iif, int type, u32 portid, u32 seq, 4670 int iif, int type, u32 portid, u32 seq,
4671 unsigned int flags) 4671 unsigned int flags)
4672{ 4672{
4673 struct rtmsg *rtm; 4673 struct rt6_info *rt6 = (struct rt6_info *)dst;
4674 struct rt6key *rt6_dst, *rt6_src;
4675 u32 *pmetrics, table, rt6_flags;
4674 struct nlmsghdr *nlh; 4676 struct nlmsghdr *nlh;
4677 struct rtmsg *rtm;
4675 long expires = 0; 4678 long expires = 0;
4676 u32 *pmetrics;
4677 u32 table;
4678 4679
4679 nlh = nlmsg_put(skb, portid, seq, type, sizeof(*rtm), flags); 4680 nlh = nlmsg_put(skb, portid, seq, type, sizeof(*rtm), flags);
4680 if (!nlh) 4681 if (!nlh)
4681 return -EMSGSIZE; 4682 return -EMSGSIZE;
4682 4683
4684 if (rt6) {
4685 rt6_dst = &rt6->rt6i_dst;
4686 rt6_src = &rt6->rt6i_src;
4687 rt6_flags = rt6->rt6i_flags;
4688 } else {
4689 rt6_dst = &rt->fib6_dst;
4690 rt6_src = &rt->fib6_src;
4691 rt6_flags = rt->fib6_flags;
4692 }
4693
4683 rtm = nlmsg_data(nlh); 4694 rtm = nlmsg_data(nlh);
4684 rtm->rtm_family = AF_INET6; 4695 rtm->rtm_family = AF_INET6;
4685 rtm->rtm_dst_len = rt->fib6_dst.plen; 4696 rtm->rtm_dst_len = rt6_dst->plen;
4686 rtm->rtm_src_len = rt->fib6_src.plen; 4697 rtm->rtm_src_len = rt6_src->plen;
4687 rtm->rtm_tos = 0; 4698 rtm->rtm_tos = 0;
4688 if (rt->fib6_table) 4699 if (rt->fib6_table)
4689 table = rt->fib6_table->tb6_id; 4700 table = rt->fib6_table->tb6_id;
@@ -4698,7 +4709,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4698 rtm->rtm_scope = RT_SCOPE_UNIVERSE; 4709 rtm->rtm_scope = RT_SCOPE_UNIVERSE;
4699 rtm->rtm_protocol = rt->fib6_protocol; 4710 rtm->rtm_protocol = rt->fib6_protocol;
4700 4711
4701 if (rt->fib6_flags & RTF_CACHE) 4712 if (rt6_flags & RTF_CACHE)
4702 rtm->rtm_flags |= RTM_F_CLONED; 4713 rtm->rtm_flags |= RTM_F_CLONED;
4703 4714
4704 if (dest) { 4715 if (dest) {
@@ -4706,7 +4717,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4706 goto nla_put_failure; 4717 goto nla_put_failure;
4707 rtm->rtm_dst_len = 128; 4718 rtm->rtm_dst_len = 128;
4708 } else if (rtm->rtm_dst_len) 4719 } else if (rtm->rtm_dst_len)
4709 if (nla_put_in6_addr(skb, RTA_DST, &rt->fib6_dst.addr)) 4720 if (nla_put_in6_addr(skb, RTA_DST, &rt6_dst->addr))
4710 goto nla_put_failure; 4721 goto nla_put_failure;
4711#ifdef CONFIG_IPV6_SUBTREES 4722#ifdef CONFIG_IPV6_SUBTREES
4712 if (src) { 4723 if (src) {
@@ -4714,12 +4725,12 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4714 goto nla_put_failure; 4725 goto nla_put_failure;
4715 rtm->rtm_src_len = 128; 4726 rtm->rtm_src_len = 128;
4716 } else if (rtm->rtm_src_len && 4727 } else if (rtm->rtm_src_len &&
4717 nla_put_in6_addr(skb, RTA_SRC, &rt->fib6_src.addr)) 4728 nla_put_in6_addr(skb, RTA_SRC, &rt6_src->addr))
4718 goto nla_put_failure; 4729 goto nla_put_failure;
4719#endif 4730#endif
4720 if (iif) { 4731 if (iif) {
4721#ifdef CONFIG_IPV6_MROUTE 4732#ifdef CONFIG_IPV6_MROUTE
4722 if (ipv6_addr_is_multicast(&rt->fib6_dst.addr)) { 4733 if (ipv6_addr_is_multicast(&rt6_dst->addr)) {
4723 int err = ip6mr_get_route(net, skb, rtm, portid); 4734 int err = ip6mr_get_route(net, skb, rtm, portid);
4724 4735
4725 if (err == 0) 4736 if (err == 0)
@@ -4754,7 +4765,14 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4754 /* For multipath routes, walk the siblings list and add 4765 /* For multipath routes, walk the siblings list and add
4755 * each as a nexthop within RTA_MULTIPATH. 4766 * each as a nexthop within RTA_MULTIPATH.
4756 */ 4767 */
4757 if (rt->fib6_nsiblings) { 4768 if (rt6) {
4769 if (rt6_flags & RTF_GATEWAY &&
4770 nla_put_in6_addr(skb, RTA_GATEWAY, &rt6->rt6i_gateway))
4771 goto nla_put_failure;
4772
4773 if (dst->dev && nla_put_u32(skb, RTA_OIF, dst->dev->ifindex))
4774 goto nla_put_failure;
4775 } else if (rt->fib6_nsiblings) {
4758 struct fib6_info *sibling, *next_sibling; 4776 struct fib6_info *sibling, *next_sibling;
4759 struct nlattr *mp; 4777 struct nlattr *mp;
4760 4778
@@ -4777,7 +4795,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4777 goto nla_put_failure; 4795 goto nla_put_failure;
4778 } 4796 }
4779 4797
4780 if (rt->fib6_flags & RTF_EXPIRES) { 4798 if (rt6_flags & RTF_EXPIRES) {
4781 expires = dst ? dst->expires : rt->expires; 4799 expires = dst ? dst->expires : rt->expires;
4782 expires -= jiffies; 4800 expires -= jiffies;
4783 } 4801 }
@@ -4785,7 +4803,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
4785 if (rtnl_put_cacheinfo(skb, dst, 0, expires, dst ? dst->error : 0) < 0) 4803 if (rtnl_put_cacheinfo(skb, dst, 0, expires, dst ? dst->error : 0) < 0)
4786 goto nla_put_failure; 4804 goto nla_put_failure;
4787 4805
4788 if (nla_put_u8(skb, RTA_PREF, IPV6_EXTRACT_PREF(rt->fib6_flags))) 4806 if (nla_put_u8(skb, RTA_PREF, IPV6_EXTRACT_PREF(rt6_flags)))
4789 goto nla_put_failure; 4807 goto nla_put_failure;
4790 4808
4791 4809
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 83f4c77c79d8..28c4aa5078fc 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -752,6 +752,28 @@ static void udp6_sk_rx_dst_set(struct sock *sk, struct dst_entry *dst)
752 } 752 }
753} 753}
754 754
755/* wrapper for udp_queue_rcv_skb tacking care of csum conversion and
756 * return code conversion for ip layer consumption
757 */
758static int udp6_unicast_rcv_skb(struct sock *sk, struct sk_buff *skb,
759 struct udphdr *uh)
760{
761 int ret;
762
763 if (inet_get_convert_csum(sk) && uh->check && !IS_UDPLITE(sk))
764 skb_checksum_try_convert(skb, IPPROTO_UDP, uh->check,
765 ip6_compute_pseudo);
766
767 ret = udpv6_queue_rcv_skb(sk, skb);
768
769 /* a return value > 0 means to resubmit the input, but
770 * it wants the return to be -protocol, or 0
771 */
772 if (ret > 0)
773 return -ret;
774 return 0;
775}
776
755int __udp6_lib_rcv(struct sk_buff *skb, struct udp_table *udptable, 777int __udp6_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
756 int proto) 778 int proto)
757{ 779{
@@ -803,13 +825,14 @@ int __udp6_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
803 if (unlikely(sk->sk_rx_dst != dst)) 825 if (unlikely(sk->sk_rx_dst != dst))
804 udp6_sk_rx_dst_set(sk, dst); 826 udp6_sk_rx_dst_set(sk, dst);
805 827
806 ret = udpv6_queue_rcv_skb(sk, skb); 828 if (!uh->check && !udp_sk(sk)->no_check6_rx) {
807 sock_put(sk); 829 sock_put(sk);
830 goto report_csum_error;
831 }
808 832
809 /* a return value > 0 means to resubmit the input */ 833 ret = udp6_unicast_rcv_skb(sk, skb, uh);
810 if (ret > 0) 834 sock_put(sk);
811 return ret; 835 return ret;
812 return 0;
813 } 836 }
814 837
815 /* 838 /*
@@ -822,30 +845,13 @@ int __udp6_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
822 /* Unicast */ 845 /* Unicast */
823 sk = __udp6_lib_lookup_skb(skb, uh->source, uh->dest, udptable); 846 sk = __udp6_lib_lookup_skb(skb, uh->source, uh->dest, udptable);
824 if (sk) { 847 if (sk) {
825 int ret; 848 if (!uh->check && !udp_sk(sk)->no_check6_rx)
826 849 goto report_csum_error;
827 if (!uh->check && !udp_sk(sk)->no_check6_rx) { 850 return udp6_unicast_rcv_skb(sk, skb, uh);
828 udp6_csum_zero_error(skb);
829 goto csum_error;
830 }
831
832 if (inet_get_convert_csum(sk) && uh->check && !IS_UDPLITE(sk))
833 skb_checksum_try_convert(skb, IPPROTO_UDP, uh->check,
834 ip6_compute_pseudo);
835
836 ret = udpv6_queue_rcv_skb(sk, skb);
837
838 /* a return value > 0 means to resubmit the input */
839 if (ret > 0)
840 return ret;
841
842 return 0;
843 } 851 }
844 852
845 if (!uh->check) { 853 if (!uh->check)
846 udp6_csum_zero_error(skb); 854 goto report_csum_error;
847 goto csum_error;
848 }
849 855
850 if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) 856 if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb))
851 goto discard; 857 goto discard;
@@ -866,6 +872,9 @@ short_packet:
866 ulen, skb->len, 872 ulen, skb->len,
867 daddr, ntohs(uh->dest)); 873 daddr, ntohs(uh->dest));
868 goto discard; 874 goto discard;
875
876report_csum_error:
877 udp6_csum_zero_error(skb);
869csum_error: 878csum_error:
870 __UDP6_INC_STATS(net, UDP_MIB_CSUMERRORS, proto == IPPROTO_UDPLITE); 879 __UDP6_INC_STATS(net, UDP_MIB_CSUMERRORS, proto == IPPROTO_UDPLITE);
871discard: 880discard:
diff --git a/net/ipv6/xfrm6_input.c b/net/ipv6/xfrm6_input.c
index 841f4a07438e..9ef490dddcea 100644
--- a/net/ipv6/xfrm6_input.c
+++ b/net/ipv6/xfrm6_input.c
@@ -59,6 +59,7 @@ int xfrm6_transport_finish(struct sk_buff *skb, int async)
59 59
60 if (xo && (xo->flags & XFRM_GRO)) { 60 if (xo && (xo->flags & XFRM_GRO)) {
61 skb_mac_header_rebuild(skb); 61 skb_mac_header_rebuild(skb);
62 skb_reset_transport_header(skb);
62 return -1; 63 return -1;
63 } 64 }
64 65
diff --git a/net/ipv6/xfrm6_mode_transport.c b/net/ipv6/xfrm6_mode_transport.c
index 9ad07a91708e..3c29da5defe6 100644
--- a/net/ipv6/xfrm6_mode_transport.c
+++ b/net/ipv6/xfrm6_mode_transport.c
@@ -51,7 +51,6 @@ static int xfrm6_transport_output(struct xfrm_state *x, struct sk_buff *skb)
51static int xfrm6_transport_input(struct xfrm_state *x, struct sk_buff *skb) 51static int xfrm6_transport_input(struct xfrm_state *x, struct sk_buff *skb)
52{ 52{
53 int ihl = skb->data - skb_transport_header(skb); 53 int ihl = skb->data - skb_transport_header(skb);
54 struct xfrm_offload *xo = xfrm_offload(skb);
55 54
56 if (skb->transport_header != skb->network_header) { 55 if (skb->transport_header != skb->network_header) {
57 memmove(skb_transport_header(skb), 56 memmove(skb_transport_header(skb),
@@ -60,8 +59,7 @@ static int xfrm6_transport_input(struct xfrm_state *x, struct sk_buff *skb)
60 } 59 }
61 ipv6_hdr(skb)->payload_len = htons(skb->len + ihl - 60 ipv6_hdr(skb)->payload_len = htons(skb->len + ihl -
62 sizeof(struct ipv6hdr)); 61 sizeof(struct ipv6hdr));
63 if (!xo || !(xo->flags & XFRM_GRO)) 62 skb_reset_transport_header(skb);
64 skb_reset_transport_header(skb);
65 return 0; 63 return 0;
66} 64}
67 65
diff --git a/net/ipv6/xfrm6_output.c b/net/ipv6/xfrm6_output.c
index 5959ce9620eb..6a74080005cf 100644
--- a/net/ipv6/xfrm6_output.c
+++ b/net/ipv6/xfrm6_output.c
@@ -170,9 +170,11 @@ static int __xfrm6_output(struct net *net, struct sock *sk, struct sk_buff *skb)
170 170
171 if (toobig && xfrm6_local_dontfrag(skb)) { 171 if (toobig && xfrm6_local_dontfrag(skb)) {
172 xfrm6_local_rxpmtu(skb, mtu); 172 xfrm6_local_rxpmtu(skb, mtu);
173 kfree_skb(skb);
173 return -EMSGSIZE; 174 return -EMSGSIZE;
174 } else if (!skb->ignore_df && toobig && skb->sk) { 175 } else if (!skb->ignore_df && toobig && skb->sk) {
175 xfrm_local_error(skb, mtu); 176 xfrm_local_error(skb, mtu);
177 kfree_skb(skb);
176 return -EMSGSIZE; 178 return -EMSGSIZE;
177 } 179 }
178 180
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index a21d8ed0a325..e2f16a0173a9 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -351,20 +351,28 @@ static int afiucv_hs_send(struct iucv_message *imsg, struct sock *sock,
351 memcpy(&phs_hdr->iucv_hdr, imsg, sizeof(struct iucv_message)); 351 memcpy(&phs_hdr->iucv_hdr, imsg, sizeof(struct iucv_message));
352 352
353 skb->dev = iucv->hs_dev; 353 skb->dev = iucv->hs_dev;
354 if (!skb->dev) 354 if (!skb->dev) {
355 return -ENODEV; 355 err = -ENODEV;
356 if (!(skb->dev->flags & IFF_UP) || !netif_carrier_ok(skb->dev)) 356 goto err_free;
357 return -ENETDOWN; 357 }
358 if (!(skb->dev->flags & IFF_UP) || !netif_carrier_ok(skb->dev)) {
359 err = -ENETDOWN;
360 goto err_free;
361 }
358 if (skb->len > skb->dev->mtu) { 362 if (skb->len > skb->dev->mtu) {
359 if (sock->sk_type == SOCK_SEQPACKET) 363 if (sock->sk_type == SOCK_SEQPACKET) {
360 return -EMSGSIZE; 364 err = -EMSGSIZE;
361 else 365 goto err_free;
362 skb_trim(skb, skb->dev->mtu); 366 }
367 skb_trim(skb, skb->dev->mtu);
363 } 368 }
364 skb->protocol = cpu_to_be16(ETH_P_AF_IUCV); 369 skb->protocol = cpu_to_be16(ETH_P_AF_IUCV);
365 nskb = skb_clone(skb, GFP_ATOMIC); 370 nskb = skb_clone(skb, GFP_ATOMIC);
366 if (!nskb) 371 if (!nskb) {
367 return -ENOMEM; 372 err = -ENOMEM;
373 goto err_free;
374 }
375
368 skb_queue_tail(&iucv->send_skb_q, nskb); 376 skb_queue_tail(&iucv->send_skb_q, nskb);
369 err = dev_queue_xmit(skb); 377 err = dev_queue_xmit(skb);
370 if (net_xmit_eval(err)) { 378 if (net_xmit_eval(err)) {
@@ -375,6 +383,10 @@ static int afiucv_hs_send(struct iucv_message *imsg, struct sock *sock,
375 WARN_ON(atomic_read(&iucv->msg_recv) < 0); 383 WARN_ON(atomic_read(&iucv->msg_recv) < 0);
376 } 384 }
377 return net_xmit_eval(err); 385 return net_xmit_eval(err);
386
387err_free:
388 kfree_skb(skb);
389 return err;
378} 390}
379 391
380static struct sock *__iucv_get_sock_by_name(char *nm) 392static struct sock *__iucv_get_sock_by_name(char *nm)
@@ -1167,7 +1179,7 @@ static int iucv_sock_sendmsg(struct socket *sock, struct msghdr *msg,
1167 err = afiucv_hs_send(&txmsg, sk, skb, 0); 1179 err = afiucv_hs_send(&txmsg, sk, skb, 0);
1168 if (err) { 1180 if (err) {
1169 atomic_dec(&iucv->msg_sent); 1181 atomic_dec(&iucv->msg_sent);
1170 goto fail; 1182 goto out;
1171 } 1183 }
1172 } else { /* Classic VM IUCV transport */ 1184 } else { /* Classic VM IUCV transport */
1173 skb_queue_tail(&iucv->send_skb_q, skb); 1185 skb_queue_tail(&iucv->send_skb_q, skb);
@@ -2155,8 +2167,8 @@ static int afiucv_hs_rcv(struct sk_buff *skb, struct net_device *dev,
2155 struct sock *sk; 2167 struct sock *sk;
2156 struct iucv_sock *iucv; 2168 struct iucv_sock *iucv;
2157 struct af_iucv_trans_hdr *trans_hdr; 2169 struct af_iucv_trans_hdr *trans_hdr;
2170 int err = NET_RX_SUCCESS;
2158 char nullstring[8]; 2171 char nullstring[8];
2159 int err = 0;
2160 2172
2161 if (skb->len < (ETH_HLEN + sizeof(struct af_iucv_trans_hdr))) { 2173 if (skb->len < (ETH_HLEN + sizeof(struct af_iucv_trans_hdr))) {
2162 WARN_ONCE(1, "AF_IUCV too short skb, len=%d, min=%d", 2174 WARN_ONCE(1, "AF_IUCV too short skb, len=%d, min=%d",
@@ -2254,7 +2266,7 @@ static int afiucv_hs_rcv(struct sk_buff *skb, struct net_device *dev,
2254 err = afiucv_hs_callback_rx(sk, skb); 2266 err = afiucv_hs_callback_rx(sk, skb);
2255 break; 2267 break;
2256 default: 2268 default:
2257 ; 2269 kfree_skb(skb);
2258 } 2270 }
2259 2271
2260 return err; 2272 return err;
diff --git a/net/iucv/iucv.c b/net/iucv/iucv.c
index 8f7ef167c45a..eb502c6290c2 100644
--- a/net/iucv/iucv.c
+++ b/net/iucv/iucv.c
@@ -1874,7 +1874,7 @@ static void iucv_pm_complete(struct device *dev)
1874 * Returns 0 if there are still iucv pathes defined 1874 * Returns 0 if there are still iucv pathes defined
1875 * 1 if there are no iucv pathes defined 1875 * 1 if there are no iucv pathes defined
1876 */ 1876 */
1877int iucv_path_table_empty(void) 1877static int iucv_path_table_empty(void)
1878{ 1878{
1879 int i; 1879 int i;
1880 1880
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index d25da0e66da1..5d22eda8a6b1 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -427,7 +427,7 @@ static int ieee80211_add_key(struct wiphy *wiphy, struct net_device *dev,
427 case NL80211_IFTYPE_AP: 427 case NL80211_IFTYPE_AP:
428 case NL80211_IFTYPE_AP_VLAN: 428 case NL80211_IFTYPE_AP_VLAN:
429 /* Keys without a station are used for TX only */ 429 /* Keys without a station are used for TX only */
430 if (key->sta && test_sta_flag(key->sta, WLAN_STA_MFP)) 430 if (sta && test_sta_flag(sta, WLAN_STA_MFP))
431 key->conf.flags |= IEEE80211_KEY_FLAG_RX_MGMT; 431 key->conf.flags |= IEEE80211_KEY_FLAG_RX_MGMT;
432 break; 432 break;
433 case NL80211_IFTYPE_ADHOC: 433 case NL80211_IFTYPE_ADHOC:
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 5e6cf2cee965..5836ddeac9e3 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1756,7 +1756,8 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,
1756 1756
1757 if (local->ops->wake_tx_queue && 1757 if (local->ops->wake_tx_queue &&
1758 type != NL80211_IFTYPE_AP_VLAN && 1758 type != NL80211_IFTYPE_AP_VLAN &&
1759 type != NL80211_IFTYPE_MONITOR) 1759 (type != NL80211_IFTYPE_MONITOR ||
1760 (params->flags & MONITOR_FLAG_ACTIVE)))
1760 txq_size += sizeof(struct txq_info) + 1761 txq_size += sizeof(struct txq_info) +
1761 local->hw.txq_data_size; 1762 local->hw.txq_data_size;
1762 1763
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index ee56f18cad3f..21526630bf65 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -217,7 +217,8 @@ void mesh_rmc_free(struct ieee80211_sub_if_data *sdata);
217int mesh_rmc_init(struct ieee80211_sub_if_data *sdata); 217int mesh_rmc_init(struct ieee80211_sub_if_data *sdata);
218void ieee80211s_init(void); 218void ieee80211s_init(void);
219void ieee80211s_update_metric(struct ieee80211_local *local, 219void ieee80211s_update_metric(struct ieee80211_local *local,
220 struct sta_info *sta, struct sk_buff *skb); 220 struct sta_info *sta,
221 struct ieee80211_tx_status *st);
221void ieee80211_mesh_init_sdata(struct ieee80211_sub_if_data *sdata); 222void ieee80211_mesh_init_sdata(struct ieee80211_sub_if_data *sdata);
222void ieee80211_mesh_teardown_sdata(struct ieee80211_sub_if_data *sdata); 223void ieee80211_mesh_teardown_sdata(struct ieee80211_sub_if_data *sdata);
223int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata); 224int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata);
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index daf9db3c8f24..6950cd0bf594 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -295,15 +295,12 @@ int mesh_path_error_tx(struct ieee80211_sub_if_data *sdata,
295} 295}
296 296
297void ieee80211s_update_metric(struct ieee80211_local *local, 297void ieee80211s_update_metric(struct ieee80211_local *local,
298 struct sta_info *sta, struct sk_buff *skb) 298 struct sta_info *sta,
299 struct ieee80211_tx_status *st)
299{ 300{
300 struct ieee80211_tx_info *txinfo = IEEE80211_SKB_CB(skb); 301 struct ieee80211_tx_info *txinfo = st->info;
301 struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
302 int failed; 302 int failed;
303 303
304 if (!ieee80211_is_data(hdr->frame_control))
305 return;
306
307 failed = !(txinfo->flags & IEEE80211_TX_STAT_ACK); 304 failed = !(txinfo->flags & IEEE80211_TX_STAT_ACK);
308 305
309 /* moving average, scaled to 100. 306 /* moving average, scaled to 100.
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index 9a6d7208bf4f..91d7c0cd1882 100644
--- a/net/mac80211/status.c
+++ b/net/mac80211/status.c
@@ -479,11 +479,6 @@ static void ieee80211_report_ack_skb(struct ieee80211_local *local,
479 if (!skb) 479 if (!skb)
480 return; 480 return;
481 481
482 if (dropped) {
483 dev_kfree_skb_any(skb);
484 return;
485 }
486
487 if (info->flags & IEEE80211_TX_INTFL_NL80211_FRAME_TX) { 482 if (info->flags & IEEE80211_TX_INTFL_NL80211_FRAME_TX) {
488 u64 cookie = IEEE80211_SKB_CB(skb)->ack.cookie; 483 u64 cookie = IEEE80211_SKB_CB(skb)->ack.cookie;
489 struct ieee80211_sub_if_data *sdata; 484 struct ieee80211_sub_if_data *sdata;
@@ -507,6 +502,8 @@ static void ieee80211_report_ack_skb(struct ieee80211_local *local,
507 rcu_read_unlock(); 502 rcu_read_unlock();
508 503
509 dev_kfree_skb_any(skb); 504 dev_kfree_skb_any(skb);
505 } else if (dropped) {
506 dev_kfree_skb_any(skb);
510 } else { 507 } else {
511 /* consumes skb */ 508 /* consumes skb */
512 skb_complete_wifi_ack(skb, acked); 509 skb_complete_wifi_ack(skb, acked);
@@ -811,7 +808,7 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,
811 808
812 rate_control_tx_status(local, sband, status); 809 rate_control_tx_status(local, sband, status);
813 if (ieee80211_vif_is_mesh(&sta->sdata->vif)) 810 if (ieee80211_vif_is_mesh(&sta->sdata->vif))
814 ieee80211s_update_metric(local, sta, skb); 811 ieee80211s_update_metric(local, sta, status);
815 812
816 if (!(info->flags & IEEE80211_TX_CTL_INJECTED) && acked) 813 if (!(info->flags & IEEE80211_TX_CTL_INJECTED) && acked)
817 ieee80211_frame_acked(sta, skb); 814 ieee80211_frame_acked(sta, skb);
@@ -972,6 +969,8 @@ void ieee80211_tx_status_ext(struct ieee80211_hw *hw,
972 } 969 }
973 970
974 rate_control_tx_status(local, sband, status); 971 rate_control_tx_status(local, sband, status);
972 if (ieee80211_vif_is_mesh(&sta->sdata->vif))
973 ieee80211s_update_metric(local, sta, status);
975 } 974 }
976 975
977 if (acked || noack_success) { 976 if (acked || noack_success) {
diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
index 5cd5e6e5834e..6c647f425e05 100644
--- a/net/mac80211/tdls.c
+++ b/net/mac80211/tdls.c
@@ -16,6 +16,7 @@
16#include "ieee80211_i.h" 16#include "ieee80211_i.h"
17#include "driver-ops.h" 17#include "driver-ops.h"
18#include "rate.h" 18#include "rate.h"
19#include "wme.h"
19 20
20/* give usermode some time for retries in setting up the TDLS session */ 21/* give usermode some time for retries in setting up the TDLS session */
21#define TDLS_PEER_SETUP_TIMEOUT (15 * HZ) 22#define TDLS_PEER_SETUP_TIMEOUT (15 * HZ)
@@ -1010,14 +1011,13 @@ ieee80211_tdls_prep_mgmt_packet(struct wiphy *wiphy, struct net_device *dev,
1010 switch (action_code) { 1011 switch (action_code) {
1011 case WLAN_TDLS_SETUP_REQUEST: 1012 case WLAN_TDLS_SETUP_REQUEST:
1012 case WLAN_TDLS_SETUP_RESPONSE: 1013 case WLAN_TDLS_SETUP_RESPONSE:
1013 skb_set_queue_mapping(skb, IEEE80211_AC_BK); 1014 skb->priority = 256 + 2;
1014 skb->priority = 2;
1015 break; 1015 break;
1016 default: 1016 default:
1017 skb_set_queue_mapping(skb, IEEE80211_AC_VI); 1017 skb->priority = 256 + 5;
1018 skb->priority = 5;
1019 break; 1018 break;
1020 } 1019 }
1020 skb_set_queue_mapping(skb, ieee80211_select_queue(sdata, skb));
1021 1021
1022 /* 1022 /*
1023 * Set the WLAN_TDLS_TEARDOWN flag to indicate a teardown in progress. 1023 * Set the WLAN_TDLS_TEARDOWN flag to indicate a teardown in progress.
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index f353d9db54bc..25ba24bef8f5 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -214,6 +214,7 @@ ieee80211_tx_h_dynamic_ps(struct ieee80211_tx_data *tx)
214{ 214{
215 struct ieee80211_local *local = tx->local; 215 struct ieee80211_local *local = tx->local;
216 struct ieee80211_if_managed *ifmgd; 216 struct ieee80211_if_managed *ifmgd;
217 struct ieee80211_tx_info *info = IEEE80211_SKB_CB(tx->skb);
217 218
218 /* driver doesn't support power save */ 219 /* driver doesn't support power save */
219 if (!ieee80211_hw_check(&local->hw, SUPPORTS_PS)) 220 if (!ieee80211_hw_check(&local->hw, SUPPORTS_PS))
@@ -242,6 +243,9 @@ ieee80211_tx_h_dynamic_ps(struct ieee80211_tx_data *tx)
242 if (tx->sdata->vif.type != NL80211_IFTYPE_STATION) 243 if (tx->sdata->vif.type != NL80211_IFTYPE_STATION)
243 return TX_CONTINUE; 244 return TX_CONTINUE;
244 245
246 if (unlikely(info->flags & IEEE80211_TX_INTFL_OFFCHAN_TX_OK))
247 return TX_CONTINUE;
248
245 ifmgd = &tx->sdata->u.mgd; 249 ifmgd = &tx->sdata->u.mgd;
246 250
247 /* 251 /*
@@ -1890,7 +1894,7 @@ static bool ieee80211_tx(struct ieee80211_sub_if_data *sdata,
1890 sdata->vif.hw_queue[skb_get_queue_mapping(skb)]; 1894 sdata->vif.hw_queue[skb_get_queue_mapping(skb)];
1891 1895
1892 if (invoke_tx_handlers_early(&tx)) 1896 if (invoke_tx_handlers_early(&tx))
1893 return false; 1897 return true;
1894 1898
1895 if (ieee80211_queue_skb(local, sdata, tx.sta, tx.skb)) 1899 if (ieee80211_queue_skb(local, sdata, tx.sta, tx.skb))
1896 return true; 1900 return true;
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 7a4de6d618b1..8fbe6cdbe255 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1533,10 +1533,14 @@ static int mpls_dev_notify(struct notifier_block *this, unsigned long event,
1533 unsigned int flags; 1533 unsigned int flags;
1534 1534
1535 if (event == NETDEV_REGISTER) { 1535 if (event == NETDEV_REGISTER) {
1536 /* For now just support Ethernet, IPGRE, SIT and IPIP devices */ 1536
1537 /* For now just support Ethernet, IPGRE, IP6GRE, SIT and
1538 * IPIP devices
1539 */
1537 if (dev->type == ARPHRD_ETHER || 1540 if (dev->type == ARPHRD_ETHER ||
1538 dev->type == ARPHRD_LOOPBACK || 1541 dev->type == ARPHRD_LOOPBACK ||
1539 dev->type == ARPHRD_IPGRE || 1542 dev->type == ARPHRD_IPGRE ||
1543 dev->type == ARPHRD_IP6GRE ||
1540 dev->type == ARPHRD_SIT || 1544 dev->type == ARPHRD_SIT ||
1541 dev->type == ARPHRD_TUNNEL) { 1545 dev->type == ARPHRD_TUNNEL) {
1542 mdev = mpls_add_dev(dev); 1546 mdev = mpls_add_dev(dev);
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 71709c104081..f61c306de1d0 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -771,13 +771,13 @@ config NETFILTER_XT_TARGET_CHECKSUM
771 depends on NETFILTER_ADVANCED 771 depends on NETFILTER_ADVANCED
772 ---help--- 772 ---help---
773 This option adds a `CHECKSUM' target, which can be used in the iptables mangle 773 This option adds a `CHECKSUM' target, which can be used in the iptables mangle
774 table. 774 table to work around buggy DHCP clients in virtualized environments.
775 775
776 You can use this target to compute and fill in the checksum in 776 Some old DHCP clients drop packets because they are not aware
777 a packet that lacks a checksum. This is particularly useful, 777 that the checksum would normally be offloaded to hardware and
778 if you need to work around old applications such as dhcp clients, 778 thus should be considered valid.
779 that do not work well with checksum offloads, but don't want to disable 779 This target can be used to fill in the checksum using iptables
780 checksum offload in your device. 780 when such packets are sent via a virtual network device.
781 781
782 To compile it as a module, choose M here. If unsure, say N. 782 To compile it as a module, choose M here. If unsure, say N.
783 783
diff --git a/net/netfilter/nf_conntrack_proto.c b/net/netfilter/nf_conntrack_proto.c
index 9f14b0df6960..51c5d7eec0a3 100644
--- a/net/netfilter/nf_conntrack_proto.c
+++ b/net/netfilter/nf_conntrack_proto.c
@@ -776,9 +776,26 @@ static const struct nf_hook_ops ipv6_conntrack_ops[] = {
776}; 776};
777#endif 777#endif
778 778
779static int nf_ct_tcp_fixup(struct nf_conn *ct, void *_nfproto)
780{
781 u8 nfproto = (unsigned long)_nfproto;
782
783 if (nf_ct_l3num(ct) != nfproto)
784 return 0;
785
786 if (nf_ct_protonum(ct) == IPPROTO_TCP &&
787 ct->proto.tcp.state == TCP_CONNTRACK_ESTABLISHED) {
788 ct->proto.tcp.seen[0].td_maxwin = 0;
789 ct->proto.tcp.seen[1].td_maxwin = 0;
790 }
791
792 return 0;
793}
794
779static int nf_ct_netns_do_get(struct net *net, u8 nfproto) 795static int nf_ct_netns_do_get(struct net *net, u8 nfproto)
780{ 796{
781 struct nf_conntrack_net *cnet = net_generic(net, nf_conntrack_net_id); 797 struct nf_conntrack_net *cnet = net_generic(net, nf_conntrack_net_id);
798 bool fixup_needed = false;
782 int err = 0; 799 int err = 0;
783 800
784 mutex_lock(&nf_ct_proto_mutex); 801 mutex_lock(&nf_ct_proto_mutex);
@@ -798,6 +815,8 @@ static int nf_ct_netns_do_get(struct net *net, u8 nfproto)
798 ARRAY_SIZE(ipv4_conntrack_ops)); 815 ARRAY_SIZE(ipv4_conntrack_ops));
799 if (err) 816 if (err)
800 cnet->users4 = 0; 817 cnet->users4 = 0;
818 else
819 fixup_needed = true;
801 break; 820 break;
802#if IS_ENABLED(CONFIG_IPV6) 821#if IS_ENABLED(CONFIG_IPV6)
803 case NFPROTO_IPV6: 822 case NFPROTO_IPV6:
@@ -814,6 +833,8 @@ static int nf_ct_netns_do_get(struct net *net, u8 nfproto)
814 ARRAY_SIZE(ipv6_conntrack_ops)); 833 ARRAY_SIZE(ipv6_conntrack_ops));
815 if (err) 834 if (err)
816 cnet->users6 = 0; 835 cnet->users6 = 0;
836 else
837 fixup_needed = true;
817 break; 838 break;
818#endif 839#endif
819 default: 840 default:
@@ -822,6 +843,11 @@ static int nf_ct_netns_do_get(struct net *net, u8 nfproto)
822 } 843 }
823 out_unlock: 844 out_unlock:
824 mutex_unlock(&nf_ct_proto_mutex); 845 mutex_unlock(&nf_ct_proto_mutex);
846
847 if (fixup_needed)
848 nf_ct_iterate_cleanup_net(net, nf_ct_tcp_fixup,
849 (void *)(unsigned long)nfproto, 0, 0);
850
825 return err; 851 return err;
826} 852}
827 853
diff --git a/net/netfilter/nf_conntrack_proto_dccp.c b/net/netfilter/nf_conntrack_proto_dccp.c
index 8c58f96b59e7..f3f91ed2c21a 100644
--- a/net/netfilter/nf_conntrack_proto_dccp.c
+++ b/net/netfilter/nf_conntrack_proto_dccp.c
@@ -675,7 +675,7 @@ static int nlattr_to_dccp(struct nlattr *cda[], struct nf_conn *ct)
675} 675}
676#endif 676#endif
677 677
678#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 678#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
679 679
680#include <linux/netfilter/nfnetlink.h> 680#include <linux/netfilter/nfnetlink.h>
681#include <linux/netfilter/nfnetlink_cttimeout.h> 681#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -697,6 +697,8 @@ static int dccp_timeout_nlattr_to_obj(struct nlattr *tb[],
697 timeouts[i] = ntohl(nla_get_be32(tb[i])) * HZ; 697 timeouts[i] = ntohl(nla_get_be32(tb[i])) * HZ;
698 } 698 }
699 } 699 }
700
701 timeouts[CTA_TIMEOUT_DCCP_UNSPEC] = timeouts[CTA_TIMEOUT_DCCP_REQUEST];
700 return 0; 702 return 0;
701} 703}
702 704
@@ -726,7 +728,7 @@ dccp_timeout_nla_policy[CTA_TIMEOUT_DCCP_MAX+1] = {
726 [CTA_TIMEOUT_DCCP_CLOSING] = { .type = NLA_U32 }, 728 [CTA_TIMEOUT_DCCP_CLOSING] = { .type = NLA_U32 },
727 [CTA_TIMEOUT_DCCP_TIMEWAIT] = { .type = NLA_U32 }, 729 [CTA_TIMEOUT_DCCP_TIMEWAIT] = { .type = NLA_U32 },
728}; 730};
729#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 731#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
730 732
731#ifdef CONFIG_SYSCTL 733#ifdef CONFIG_SYSCTL
732/* template, data assigned later */ 734/* template, data assigned later */
@@ -827,6 +829,11 @@ static int dccp_init_net(struct net *net, u_int16_t proto)
827 dn->dccp_timeout[CT_DCCP_CLOSEREQ] = 64 * HZ; 829 dn->dccp_timeout[CT_DCCP_CLOSEREQ] = 64 * HZ;
828 dn->dccp_timeout[CT_DCCP_CLOSING] = 64 * HZ; 830 dn->dccp_timeout[CT_DCCP_CLOSING] = 64 * HZ;
829 dn->dccp_timeout[CT_DCCP_TIMEWAIT] = 2 * DCCP_MSL; 831 dn->dccp_timeout[CT_DCCP_TIMEWAIT] = 2 * DCCP_MSL;
832
833 /* timeouts[0] is unused, make it same as SYN_SENT so
834 * ->timeouts[0] contains 'new' timeout, like udp or icmp.
835 */
836 dn->dccp_timeout[CT_DCCP_NONE] = dn->dccp_timeout[CT_DCCP_REQUEST];
830 } 837 }
831 838
832 return dccp_kmemdup_sysctl_table(net, pn, dn); 839 return dccp_kmemdup_sysctl_table(net, pn, dn);
@@ -856,7 +863,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_dccp4 = {
856 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple, 863 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple,
857 .nla_policy = nf_ct_port_nla_policy, 864 .nla_policy = nf_ct_port_nla_policy,
858#endif 865#endif
859#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 866#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
860 .ctnl_timeout = { 867 .ctnl_timeout = {
861 .nlattr_to_obj = dccp_timeout_nlattr_to_obj, 868 .nlattr_to_obj = dccp_timeout_nlattr_to_obj,
862 .obj_to_nlattr = dccp_timeout_obj_to_nlattr, 869 .obj_to_nlattr = dccp_timeout_obj_to_nlattr,
@@ -864,7 +871,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_dccp4 = {
864 .obj_size = sizeof(unsigned int) * CT_DCCP_MAX, 871 .obj_size = sizeof(unsigned int) * CT_DCCP_MAX,
865 .nla_policy = dccp_timeout_nla_policy, 872 .nla_policy = dccp_timeout_nla_policy,
866 }, 873 },
867#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 874#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
868 .init_net = dccp_init_net, 875 .init_net = dccp_init_net,
869 .get_net_proto = dccp_get_net_proto, 876 .get_net_proto = dccp_get_net_proto,
870}; 877};
@@ -889,7 +896,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_dccp6 = {
889 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple, 896 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple,
890 .nla_policy = nf_ct_port_nla_policy, 897 .nla_policy = nf_ct_port_nla_policy,
891#endif 898#endif
892#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 899#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
893 .ctnl_timeout = { 900 .ctnl_timeout = {
894 .nlattr_to_obj = dccp_timeout_nlattr_to_obj, 901 .nlattr_to_obj = dccp_timeout_nlattr_to_obj,
895 .obj_to_nlattr = dccp_timeout_obj_to_nlattr, 902 .obj_to_nlattr = dccp_timeout_obj_to_nlattr,
@@ -897,7 +904,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_dccp6 = {
897 .obj_size = sizeof(unsigned int) * CT_DCCP_MAX, 904 .obj_size = sizeof(unsigned int) * CT_DCCP_MAX,
898 .nla_policy = dccp_timeout_nla_policy, 905 .nla_policy = dccp_timeout_nla_policy,
899 }, 906 },
900#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 907#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
901 .init_net = dccp_init_net, 908 .init_net = dccp_init_net,
902 .get_net_proto = dccp_get_net_proto, 909 .get_net_proto = dccp_get_net_proto,
903}; 910};
diff --git a/net/netfilter/nf_conntrack_proto_generic.c b/net/netfilter/nf_conntrack_proto_generic.c
index ac4a0b296dcd..1df3244ecd07 100644
--- a/net/netfilter/nf_conntrack_proto_generic.c
+++ b/net/netfilter/nf_conntrack_proto_generic.c
@@ -70,7 +70,7 @@ static bool generic_new(struct nf_conn *ct, const struct sk_buff *skb,
70 return ret; 70 return ret;
71} 71}
72 72
73#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 73#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
74 74
75#include <linux/netfilter/nfnetlink.h> 75#include <linux/netfilter/nfnetlink.h>
76#include <linux/netfilter/nfnetlink_cttimeout.h> 76#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -113,7 +113,7 @@ static const struct nla_policy
113generic_timeout_nla_policy[CTA_TIMEOUT_GENERIC_MAX+1] = { 113generic_timeout_nla_policy[CTA_TIMEOUT_GENERIC_MAX+1] = {
114 [CTA_TIMEOUT_GENERIC_TIMEOUT] = { .type = NLA_U32 }, 114 [CTA_TIMEOUT_GENERIC_TIMEOUT] = { .type = NLA_U32 },
115}; 115};
116#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 116#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
117 117
118#ifdef CONFIG_SYSCTL 118#ifdef CONFIG_SYSCTL
119static struct ctl_table generic_sysctl_table[] = { 119static struct ctl_table generic_sysctl_table[] = {
@@ -164,7 +164,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_generic =
164 .pkt_to_tuple = generic_pkt_to_tuple, 164 .pkt_to_tuple = generic_pkt_to_tuple,
165 .packet = generic_packet, 165 .packet = generic_packet,
166 .new = generic_new, 166 .new = generic_new,
167#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 167#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
168 .ctnl_timeout = { 168 .ctnl_timeout = {
169 .nlattr_to_obj = generic_timeout_nlattr_to_obj, 169 .nlattr_to_obj = generic_timeout_nlattr_to_obj,
170 .obj_to_nlattr = generic_timeout_obj_to_nlattr, 170 .obj_to_nlattr = generic_timeout_obj_to_nlattr,
@@ -172,7 +172,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_generic =
172 .obj_size = sizeof(unsigned int), 172 .obj_size = sizeof(unsigned int),
173 .nla_policy = generic_timeout_nla_policy, 173 .nla_policy = generic_timeout_nla_policy,
174 }, 174 },
175#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 175#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
176 .init_net = generic_init_net, 176 .init_net = generic_init_net,
177 .get_net_proto = generic_get_net_proto, 177 .get_net_proto = generic_get_net_proto,
178}; 178};
diff --git a/net/netfilter/nf_conntrack_proto_gre.c b/net/netfilter/nf_conntrack_proto_gre.c
index d1632252bf5b..650eb4fba2c5 100644
--- a/net/netfilter/nf_conntrack_proto_gre.c
+++ b/net/netfilter/nf_conntrack_proto_gre.c
@@ -285,7 +285,7 @@ static void gre_destroy(struct nf_conn *ct)
285 nf_ct_gre_keymap_destroy(master); 285 nf_ct_gre_keymap_destroy(master);
286} 286}
287 287
288#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 288#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
289 289
290#include <linux/netfilter/nfnetlink.h> 290#include <linux/netfilter/nfnetlink.h>
291#include <linux/netfilter/nfnetlink_cttimeout.h> 291#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -334,7 +334,7 @@ gre_timeout_nla_policy[CTA_TIMEOUT_GRE_MAX+1] = {
334 [CTA_TIMEOUT_GRE_UNREPLIED] = { .type = NLA_U32 }, 334 [CTA_TIMEOUT_GRE_UNREPLIED] = { .type = NLA_U32 },
335 [CTA_TIMEOUT_GRE_REPLIED] = { .type = NLA_U32 }, 335 [CTA_TIMEOUT_GRE_REPLIED] = { .type = NLA_U32 },
336}; 336};
337#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 337#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
338 338
339static int gre_init_net(struct net *net, u_int16_t proto) 339static int gre_init_net(struct net *net, u_int16_t proto)
340{ 340{
@@ -367,7 +367,7 @@ static const struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
367 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple, 367 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple,
368 .nla_policy = nf_ct_port_nla_policy, 368 .nla_policy = nf_ct_port_nla_policy,
369#endif 369#endif
370#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 370#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
371 .ctnl_timeout = { 371 .ctnl_timeout = {
372 .nlattr_to_obj = gre_timeout_nlattr_to_obj, 372 .nlattr_to_obj = gre_timeout_nlattr_to_obj,
373 .obj_to_nlattr = gre_timeout_obj_to_nlattr, 373 .obj_to_nlattr = gre_timeout_obj_to_nlattr,
@@ -375,7 +375,7 @@ static const struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
375 .obj_size = sizeof(unsigned int) * GRE_CT_MAX, 375 .obj_size = sizeof(unsigned int) * GRE_CT_MAX,
376 .nla_policy = gre_timeout_nla_policy, 376 .nla_policy = gre_timeout_nla_policy,
377 }, 377 },
378#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 378#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
379 .net_id = &proto_gre_net_id, 379 .net_id = &proto_gre_net_id,
380 .init_net = gre_init_net, 380 .init_net = gre_init_net,
381}; 381};
diff --git a/net/netfilter/nf_conntrack_proto_icmp.c b/net/netfilter/nf_conntrack_proto_icmp.c
index 036670b38282..43c7e1a217b9 100644
--- a/net/netfilter/nf_conntrack_proto_icmp.c
+++ b/net/netfilter/nf_conntrack_proto_icmp.c
@@ -273,7 +273,7 @@ static unsigned int icmp_nlattr_tuple_size(void)
273} 273}
274#endif 274#endif
275 275
276#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 276#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
277 277
278#include <linux/netfilter/nfnetlink.h> 278#include <linux/netfilter/nfnetlink.h>
279#include <linux/netfilter/nfnetlink_cttimeout.h> 279#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -313,7 +313,7 @@ static const struct nla_policy
313icmp_timeout_nla_policy[CTA_TIMEOUT_ICMP_MAX+1] = { 313icmp_timeout_nla_policy[CTA_TIMEOUT_ICMP_MAX+1] = {
314 [CTA_TIMEOUT_ICMP_TIMEOUT] = { .type = NLA_U32 }, 314 [CTA_TIMEOUT_ICMP_TIMEOUT] = { .type = NLA_U32 },
315}; 315};
316#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 316#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
317 317
318#ifdef CONFIG_SYSCTL 318#ifdef CONFIG_SYSCTL
319static struct ctl_table icmp_sysctl_table[] = { 319static struct ctl_table icmp_sysctl_table[] = {
@@ -374,7 +374,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_icmp =
374 .nlattr_to_tuple = icmp_nlattr_to_tuple, 374 .nlattr_to_tuple = icmp_nlattr_to_tuple,
375 .nla_policy = icmp_nla_policy, 375 .nla_policy = icmp_nla_policy,
376#endif 376#endif
377#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 377#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
378 .ctnl_timeout = { 378 .ctnl_timeout = {
379 .nlattr_to_obj = icmp_timeout_nlattr_to_obj, 379 .nlattr_to_obj = icmp_timeout_nlattr_to_obj,
380 .obj_to_nlattr = icmp_timeout_obj_to_nlattr, 380 .obj_to_nlattr = icmp_timeout_obj_to_nlattr,
@@ -382,7 +382,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_icmp =
382 .obj_size = sizeof(unsigned int), 382 .obj_size = sizeof(unsigned int),
383 .nla_policy = icmp_timeout_nla_policy, 383 .nla_policy = icmp_timeout_nla_policy,
384 }, 384 },
385#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 385#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
386 .init_net = icmp_init_net, 386 .init_net = icmp_init_net,
387 .get_net_proto = icmp_get_net_proto, 387 .get_net_proto = icmp_get_net_proto,
388}; 388};
diff --git a/net/netfilter/nf_conntrack_proto_icmpv6.c b/net/netfilter/nf_conntrack_proto_icmpv6.c
index bed07b998a10..97e40f77d678 100644
--- a/net/netfilter/nf_conntrack_proto_icmpv6.c
+++ b/net/netfilter/nf_conntrack_proto_icmpv6.c
@@ -274,7 +274,7 @@ static unsigned int icmpv6_nlattr_tuple_size(void)
274} 274}
275#endif 275#endif
276 276
277#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 277#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
278 278
279#include <linux/netfilter/nfnetlink.h> 279#include <linux/netfilter/nfnetlink.h>
280#include <linux/netfilter/nfnetlink_cttimeout.h> 280#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -314,7 +314,7 @@ static const struct nla_policy
314icmpv6_timeout_nla_policy[CTA_TIMEOUT_ICMPV6_MAX+1] = { 314icmpv6_timeout_nla_policy[CTA_TIMEOUT_ICMPV6_MAX+1] = {
315 [CTA_TIMEOUT_ICMPV6_TIMEOUT] = { .type = NLA_U32 }, 315 [CTA_TIMEOUT_ICMPV6_TIMEOUT] = { .type = NLA_U32 },
316}; 316};
317#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 317#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
318 318
319#ifdef CONFIG_SYSCTL 319#ifdef CONFIG_SYSCTL
320static struct ctl_table icmpv6_sysctl_table[] = { 320static struct ctl_table icmpv6_sysctl_table[] = {
@@ -373,7 +373,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_icmpv6 =
373 .nlattr_to_tuple = icmpv6_nlattr_to_tuple, 373 .nlattr_to_tuple = icmpv6_nlattr_to_tuple,
374 .nla_policy = icmpv6_nla_policy, 374 .nla_policy = icmpv6_nla_policy,
375#endif 375#endif
376#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 376#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
377 .ctnl_timeout = { 377 .ctnl_timeout = {
378 .nlattr_to_obj = icmpv6_timeout_nlattr_to_obj, 378 .nlattr_to_obj = icmpv6_timeout_nlattr_to_obj,
379 .obj_to_nlattr = icmpv6_timeout_obj_to_nlattr, 379 .obj_to_nlattr = icmpv6_timeout_obj_to_nlattr,
@@ -381,7 +381,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_icmpv6 =
381 .obj_size = sizeof(unsigned int), 381 .obj_size = sizeof(unsigned int),
382 .nla_policy = icmpv6_timeout_nla_policy, 382 .nla_policy = icmpv6_timeout_nla_policy,
383 }, 383 },
384#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 384#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
385 .init_net = icmpv6_init_net, 385 .init_net = icmpv6_init_net,
386 .get_net_proto = icmpv6_get_net_proto, 386 .get_net_proto = icmpv6_get_net_proto,
387}; 387};
diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c
index 8d1e085fc14a..e4d738d34cd0 100644
--- a/net/netfilter/nf_conntrack_proto_sctp.c
+++ b/net/netfilter/nf_conntrack_proto_sctp.c
@@ -591,7 +591,7 @@ static int nlattr_to_sctp(struct nlattr *cda[], struct nf_conn *ct)
591} 591}
592#endif 592#endif
593 593
594#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 594#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
595 595
596#include <linux/netfilter/nfnetlink.h> 596#include <linux/netfilter/nfnetlink.h>
597#include <linux/netfilter/nfnetlink_cttimeout.h> 597#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -613,6 +613,8 @@ static int sctp_timeout_nlattr_to_obj(struct nlattr *tb[],
613 timeouts[i] = ntohl(nla_get_be32(tb[i])) * HZ; 613 timeouts[i] = ntohl(nla_get_be32(tb[i])) * HZ;
614 } 614 }
615 } 615 }
616
617 timeouts[CTA_TIMEOUT_SCTP_UNSPEC] = timeouts[CTA_TIMEOUT_SCTP_CLOSED];
616 return 0; 618 return 0;
617} 619}
618 620
@@ -644,7 +646,7 @@ sctp_timeout_nla_policy[CTA_TIMEOUT_SCTP_MAX+1] = {
644 [CTA_TIMEOUT_SCTP_HEARTBEAT_SENT] = { .type = NLA_U32 }, 646 [CTA_TIMEOUT_SCTP_HEARTBEAT_SENT] = { .type = NLA_U32 },
645 [CTA_TIMEOUT_SCTP_HEARTBEAT_ACKED] = { .type = NLA_U32 }, 647 [CTA_TIMEOUT_SCTP_HEARTBEAT_ACKED] = { .type = NLA_U32 },
646}; 648};
647#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 649#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
648 650
649 651
650#ifdef CONFIG_SYSCTL 652#ifdef CONFIG_SYSCTL
@@ -743,6 +745,11 @@ static int sctp_init_net(struct net *net, u_int16_t proto)
743 745
744 for (i = 0; i < SCTP_CONNTRACK_MAX; i++) 746 for (i = 0; i < SCTP_CONNTRACK_MAX; i++)
745 sn->timeouts[i] = sctp_timeouts[i]; 747 sn->timeouts[i] = sctp_timeouts[i];
748
749 /* timeouts[0] is unused, init it so ->timeouts[0] contains
750 * 'new' timeout, like udp or icmp.
751 */
752 sn->timeouts[0] = sctp_timeouts[SCTP_CONNTRACK_CLOSED];
746 } 753 }
747 754
748 return sctp_kmemdup_sysctl_table(pn, sn); 755 return sctp_kmemdup_sysctl_table(pn, sn);
@@ -773,7 +780,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_sctp4 = {
773 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple, 780 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple,
774 .nla_policy = nf_ct_port_nla_policy, 781 .nla_policy = nf_ct_port_nla_policy,
775#endif 782#endif
776#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 783#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
777 .ctnl_timeout = { 784 .ctnl_timeout = {
778 .nlattr_to_obj = sctp_timeout_nlattr_to_obj, 785 .nlattr_to_obj = sctp_timeout_nlattr_to_obj,
779 .obj_to_nlattr = sctp_timeout_obj_to_nlattr, 786 .obj_to_nlattr = sctp_timeout_obj_to_nlattr,
@@ -781,7 +788,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_sctp4 = {
781 .obj_size = sizeof(unsigned int) * SCTP_CONNTRACK_MAX, 788 .obj_size = sizeof(unsigned int) * SCTP_CONNTRACK_MAX,
782 .nla_policy = sctp_timeout_nla_policy, 789 .nla_policy = sctp_timeout_nla_policy,
783 }, 790 },
784#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 791#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
785 .init_net = sctp_init_net, 792 .init_net = sctp_init_net,
786 .get_net_proto = sctp_get_net_proto, 793 .get_net_proto = sctp_get_net_proto,
787}; 794};
@@ -806,7 +813,8 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_sctp6 = {
806 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size, 813 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size,
807 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple, 814 .nlattr_to_tuple = nf_ct_port_nlattr_to_tuple,
808 .nla_policy = nf_ct_port_nla_policy, 815 .nla_policy = nf_ct_port_nla_policy,
809#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 816#endif
817#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
810 .ctnl_timeout = { 818 .ctnl_timeout = {
811 .nlattr_to_obj = sctp_timeout_nlattr_to_obj, 819 .nlattr_to_obj = sctp_timeout_nlattr_to_obj,
812 .obj_to_nlattr = sctp_timeout_obj_to_nlattr, 820 .obj_to_nlattr = sctp_timeout_obj_to_nlattr,
@@ -814,8 +822,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_sctp6 = {
814 .obj_size = sizeof(unsigned int) * SCTP_CONNTRACK_MAX, 822 .obj_size = sizeof(unsigned int) * SCTP_CONNTRACK_MAX,
815 .nla_policy = sctp_timeout_nla_policy, 823 .nla_policy = sctp_timeout_nla_policy,
816 }, 824 },
817#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 825#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
818#endif
819 .init_net = sctp_init_net, 826 .init_net = sctp_init_net,
820 .get_net_proto = sctp_get_net_proto, 827 .get_net_proto = sctp_get_net_proto,
821}; 828};
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c b/net/netfilter/nf_conntrack_proto_tcp.c
index d80d322b9d8b..247b89784a6f 100644
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b/net/netfilter/nf_conntrack_proto_tcp.c
@@ -1213,8 +1213,8 @@ static const struct nla_policy tcp_nla_policy[CTA_PROTOINFO_TCP_MAX+1] = {
1213#define TCP_NLATTR_SIZE ( \ 1213#define TCP_NLATTR_SIZE ( \
1214 NLA_ALIGN(NLA_HDRLEN + 1) + \ 1214 NLA_ALIGN(NLA_HDRLEN + 1) + \
1215 NLA_ALIGN(NLA_HDRLEN + 1) + \ 1215 NLA_ALIGN(NLA_HDRLEN + 1) + \
1216 NLA_ALIGN(NLA_HDRLEN + sizeof(sizeof(struct nf_ct_tcp_flags))) + \ 1216 NLA_ALIGN(NLA_HDRLEN + sizeof(struct nf_ct_tcp_flags)) + \
1217 NLA_ALIGN(NLA_HDRLEN + sizeof(sizeof(struct nf_ct_tcp_flags)))) 1217 NLA_ALIGN(NLA_HDRLEN + sizeof(struct nf_ct_tcp_flags)))
1218 1218
1219static int nlattr_to_tcp(struct nlattr *cda[], struct nf_conn *ct) 1219static int nlattr_to_tcp(struct nlattr *cda[], struct nf_conn *ct)
1220{ 1220{
@@ -1279,7 +1279,7 @@ static unsigned int tcp_nlattr_tuple_size(void)
1279} 1279}
1280#endif 1280#endif
1281 1281
1282#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 1282#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
1283 1283
1284#include <linux/netfilter/nfnetlink.h> 1284#include <linux/netfilter/nfnetlink.h>
1285#include <linux/netfilter/nfnetlink_cttimeout.h> 1285#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -1301,6 +1301,7 @@ static int tcp_timeout_nlattr_to_obj(struct nlattr *tb[],
1301 timeouts[TCP_CONNTRACK_SYN_SENT] = 1301 timeouts[TCP_CONNTRACK_SYN_SENT] =
1302 ntohl(nla_get_be32(tb[CTA_TIMEOUT_TCP_SYN_SENT]))*HZ; 1302 ntohl(nla_get_be32(tb[CTA_TIMEOUT_TCP_SYN_SENT]))*HZ;
1303 } 1303 }
1304
1304 if (tb[CTA_TIMEOUT_TCP_SYN_RECV]) { 1305 if (tb[CTA_TIMEOUT_TCP_SYN_RECV]) {
1305 timeouts[TCP_CONNTRACK_SYN_RECV] = 1306 timeouts[TCP_CONNTRACK_SYN_RECV] =
1306 ntohl(nla_get_be32(tb[CTA_TIMEOUT_TCP_SYN_RECV]))*HZ; 1307 ntohl(nla_get_be32(tb[CTA_TIMEOUT_TCP_SYN_RECV]))*HZ;
@@ -1341,6 +1342,8 @@ static int tcp_timeout_nlattr_to_obj(struct nlattr *tb[],
1341 timeouts[TCP_CONNTRACK_UNACK] = 1342 timeouts[TCP_CONNTRACK_UNACK] =
1342 ntohl(nla_get_be32(tb[CTA_TIMEOUT_TCP_UNACK]))*HZ; 1343 ntohl(nla_get_be32(tb[CTA_TIMEOUT_TCP_UNACK]))*HZ;
1343 } 1344 }
1345
1346 timeouts[CTA_TIMEOUT_TCP_UNSPEC] = timeouts[CTA_TIMEOUT_TCP_SYN_SENT];
1344 return 0; 1347 return 0;
1345} 1348}
1346 1349
@@ -1391,7 +1394,7 @@ static const struct nla_policy tcp_timeout_nla_policy[CTA_TIMEOUT_TCP_MAX+1] = {
1391 [CTA_TIMEOUT_TCP_RETRANS] = { .type = NLA_U32 }, 1394 [CTA_TIMEOUT_TCP_RETRANS] = { .type = NLA_U32 },
1392 [CTA_TIMEOUT_TCP_UNACK] = { .type = NLA_U32 }, 1395 [CTA_TIMEOUT_TCP_UNACK] = { .type = NLA_U32 },
1393}; 1396};
1394#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 1397#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
1395 1398
1396#ifdef CONFIG_SYSCTL 1399#ifdef CONFIG_SYSCTL
1397static struct ctl_table tcp_sysctl_table[] = { 1400static struct ctl_table tcp_sysctl_table[] = {
@@ -1518,6 +1521,10 @@ static int tcp_init_net(struct net *net, u_int16_t proto)
1518 for (i = 0; i < TCP_CONNTRACK_TIMEOUT_MAX; i++) 1521 for (i = 0; i < TCP_CONNTRACK_TIMEOUT_MAX; i++)
1519 tn->timeouts[i] = tcp_timeouts[i]; 1522 tn->timeouts[i] = tcp_timeouts[i];
1520 1523
1524 /* timeouts[0] is unused, make it same as SYN_SENT so
1525 * ->timeouts[0] contains 'new' timeout, like udp or icmp.
1526 */
1527 tn->timeouts[0] = tcp_timeouts[TCP_CONNTRACK_SYN_SENT];
1521 tn->tcp_loose = nf_ct_tcp_loose; 1528 tn->tcp_loose = nf_ct_tcp_loose;
1522 tn->tcp_be_liberal = nf_ct_tcp_be_liberal; 1529 tn->tcp_be_liberal = nf_ct_tcp_be_liberal;
1523 tn->tcp_max_retrans = nf_ct_tcp_max_retrans; 1530 tn->tcp_max_retrans = nf_ct_tcp_max_retrans;
@@ -1551,7 +1558,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_tcp4 =
1551 .nlattr_size = TCP_NLATTR_SIZE, 1558 .nlattr_size = TCP_NLATTR_SIZE,
1552 .nla_policy = nf_ct_port_nla_policy, 1559 .nla_policy = nf_ct_port_nla_policy,
1553#endif 1560#endif
1554#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 1561#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
1555 .ctnl_timeout = { 1562 .ctnl_timeout = {
1556 .nlattr_to_obj = tcp_timeout_nlattr_to_obj, 1563 .nlattr_to_obj = tcp_timeout_nlattr_to_obj,
1557 .obj_to_nlattr = tcp_timeout_obj_to_nlattr, 1564 .obj_to_nlattr = tcp_timeout_obj_to_nlattr,
@@ -1560,7 +1567,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_tcp4 =
1560 TCP_CONNTRACK_TIMEOUT_MAX, 1567 TCP_CONNTRACK_TIMEOUT_MAX,
1561 .nla_policy = tcp_timeout_nla_policy, 1568 .nla_policy = tcp_timeout_nla_policy,
1562 }, 1569 },
1563#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 1570#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
1564 .init_net = tcp_init_net, 1571 .init_net = tcp_init_net,
1565 .get_net_proto = tcp_get_net_proto, 1572 .get_net_proto = tcp_get_net_proto,
1566}; 1573};
@@ -1586,7 +1593,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_tcp6 =
1586 .nlattr_tuple_size = tcp_nlattr_tuple_size, 1593 .nlattr_tuple_size = tcp_nlattr_tuple_size,
1587 .nla_policy = nf_ct_port_nla_policy, 1594 .nla_policy = nf_ct_port_nla_policy,
1588#endif 1595#endif
1589#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 1596#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
1590 .ctnl_timeout = { 1597 .ctnl_timeout = {
1591 .nlattr_to_obj = tcp_timeout_nlattr_to_obj, 1598 .nlattr_to_obj = tcp_timeout_nlattr_to_obj,
1592 .obj_to_nlattr = tcp_timeout_obj_to_nlattr, 1599 .obj_to_nlattr = tcp_timeout_obj_to_nlattr,
@@ -1595,7 +1602,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_tcp6 =
1595 TCP_CONNTRACK_TIMEOUT_MAX, 1602 TCP_CONNTRACK_TIMEOUT_MAX,
1596 .nla_policy = tcp_timeout_nla_policy, 1603 .nla_policy = tcp_timeout_nla_policy,
1597 }, 1604 },
1598#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 1605#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
1599 .init_net = tcp_init_net, 1606 .init_net = tcp_init_net,
1600 .get_net_proto = tcp_get_net_proto, 1607 .get_net_proto = tcp_get_net_proto,
1601}; 1608};
diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c
index 7a1b8988a931..3065fb8ef91b 100644
--- a/net/netfilter/nf_conntrack_proto_udp.c
+++ b/net/netfilter/nf_conntrack_proto_udp.c
@@ -171,7 +171,7 @@ static int udp_error(struct net *net, struct nf_conn *tmpl, struct sk_buff *skb,
171 return NF_ACCEPT; 171 return NF_ACCEPT;
172} 172}
173 173
174#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 174#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
175 175
176#include <linux/netfilter/nfnetlink.h> 176#include <linux/netfilter/nfnetlink.h>
177#include <linux/netfilter/nfnetlink_cttimeout.h> 177#include <linux/netfilter/nfnetlink_cttimeout.h>
@@ -221,7 +221,7 @@ udp_timeout_nla_policy[CTA_TIMEOUT_UDP_MAX+1] = {
221 [CTA_TIMEOUT_UDP_UNREPLIED] = { .type = NLA_U32 }, 221 [CTA_TIMEOUT_UDP_UNREPLIED] = { .type = NLA_U32 },
222 [CTA_TIMEOUT_UDP_REPLIED] = { .type = NLA_U32 }, 222 [CTA_TIMEOUT_UDP_REPLIED] = { .type = NLA_U32 },
223}; 223};
224#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 224#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
225 225
226#ifdef CONFIG_SYSCTL 226#ifdef CONFIG_SYSCTL
227static struct ctl_table udp_sysctl_table[] = { 227static struct ctl_table udp_sysctl_table[] = {
@@ -292,7 +292,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udp4 =
292 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size, 292 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size,
293 .nla_policy = nf_ct_port_nla_policy, 293 .nla_policy = nf_ct_port_nla_policy,
294#endif 294#endif
295#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 295#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
296 .ctnl_timeout = { 296 .ctnl_timeout = {
297 .nlattr_to_obj = udp_timeout_nlattr_to_obj, 297 .nlattr_to_obj = udp_timeout_nlattr_to_obj,
298 .obj_to_nlattr = udp_timeout_obj_to_nlattr, 298 .obj_to_nlattr = udp_timeout_obj_to_nlattr,
@@ -300,7 +300,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udp4 =
300 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX, 300 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX,
301 .nla_policy = udp_timeout_nla_policy, 301 .nla_policy = udp_timeout_nla_policy,
302 }, 302 },
303#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 303#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
304 .init_net = udp_init_net, 304 .init_net = udp_init_net,
305 .get_net_proto = udp_get_net_proto, 305 .get_net_proto = udp_get_net_proto,
306}; 306};
@@ -321,7 +321,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udplite4 =
321 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size, 321 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size,
322 .nla_policy = nf_ct_port_nla_policy, 322 .nla_policy = nf_ct_port_nla_policy,
323#endif 323#endif
324#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 324#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
325 .ctnl_timeout = { 325 .ctnl_timeout = {
326 .nlattr_to_obj = udp_timeout_nlattr_to_obj, 326 .nlattr_to_obj = udp_timeout_nlattr_to_obj,
327 .obj_to_nlattr = udp_timeout_obj_to_nlattr, 327 .obj_to_nlattr = udp_timeout_obj_to_nlattr,
@@ -329,7 +329,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udplite4 =
329 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX, 329 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX,
330 .nla_policy = udp_timeout_nla_policy, 330 .nla_policy = udp_timeout_nla_policy,
331 }, 331 },
332#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 332#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
333 .init_net = udp_init_net, 333 .init_net = udp_init_net,
334 .get_net_proto = udp_get_net_proto, 334 .get_net_proto = udp_get_net_proto,
335}; 335};
@@ -350,7 +350,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udp6 =
350 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size, 350 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size,
351 .nla_policy = nf_ct_port_nla_policy, 351 .nla_policy = nf_ct_port_nla_policy,
352#endif 352#endif
353#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 353#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
354 .ctnl_timeout = { 354 .ctnl_timeout = {
355 .nlattr_to_obj = udp_timeout_nlattr_to_obj, 355 .nlattr_to_obj = udp_timeout_nlattr_to_obj,
356 .obj_to_nlattr = udp_timeout_obj_to_nlattr, 356 .obj_to_nlattr = udp_timeout_obj_to_nlattr,
@@ -358,7 +358,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udp6 =
358 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX, 358 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX,
359 .nla_policy = udp_timeout_nla_policy, 359 .nla_policy = udp_timeout_nla_policy,
360 }, 360 },
361#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 361#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
362 .init_net = udp_init_net, 362 .init_net = udp_init_net,
363 .get_net_proto = udp_get_net_proto, 363 .get_net_proto = udp_get_net_proto,
364}; 364};
@@ -379,7 +379,7 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udplite6 =
379 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size, 379 .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size,
380 .nla_policy = nf_ct_port_nla_policy, 380 .nla_policy = nf_ct_port_nla_policy,
381#endif 381#endif
382#if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT) 382#ifdef CONFIG_NF_CONNTRACK_TIMEOUT
383 .ctnl_timeout = { 383 .ctnl_timeout = {
384 .nlattr_to_obj = udp_timeout_nlattr_to_obj, 384 .nlattr_to_obj = udp_timeout_nlattr_to_obj,
385 .obj_to_nlattr = udp_timeout_obj_to_nlattr, 385 .obj_to_nlattr = udp_timeout_obj_to_nlattr,
@@ -387,10 +387,9 @@ const struct nf_conntrack_l4proto nf_conntrack_l4proto_udplite6 =
387 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX, 387 .obj_size = sizeof(unsigned int) * CTA_TIMEOUT_UDP_MAX,
388 .nla_policy = udp_timeout_nla_policy, 388 .nla_policy = udp_timeout_nla_policy,
389 }, 389 },
390#endif /* CONFIG_NF_CT_NETLINK_TIMEOUT */ 390#endif /* CONFIG_NF_CONNTRACK_TIMEOUT */
391 .init_net = udp_init_net, 391 .init_net = udp_init_net,
392 .get_net_proto = udp_get_net_proto, 392 .get_net_proto = udp_get_net_proto,
393}; 393};
394EXPORT_SYMBOL_GPL(nf_conntrack_l4proto_udplite6); 394EXPORT_SYMBOL_GPL(nf_conntrack_l4proto_udplite6);
395#endif 395#endif
396#include <net/netfilter/nf_conntrack_timeout.h>
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 1dca5683f59f..2cfb173cd0b2 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -4637,6 +4637,7 @@ static int nft_flush_set(const struct nft_ctx *ctx,
4637 } 4637 }
4638 set->ndeact++; 4638 set->ndeact++;
4639 4639
4640 nft_set_elem_deactivate(ctx->net, set, elem);
4640 nft_trans_elem_set(trans) = set; 4641 nft_trans_elem_set(trans) = set;
4641 nft_trans_elem(trans) = *elem; 4642 nft_trans_elem(trans) = *elem;
4642 list_add_tail(&trans->list, &ctx->net->nft.commit_list); 4643 list_add_tail(&trans->list, &ctx->net->nft.commit_list);
diff --git a/net/netfilter/nfnetlink_cttimeout.c b/net/netfilter/nfnetlink_cttimeout.c
index d46a236cdf31..a30f8ba4b89a 100644
--- a/net/netfilter/nfnetlink_cttimeout.c
+++ b/net/netfilter/nfnetlink_cttimeout.c
@@ -489,8 +489,8 @@ err:
489 return err; 489 return err;
490} 490}
491 491
492static struct ctnl_timeout * 492static struct nf_ct_timeout *ctnl_timeout_find_get(struct net *net,
493ctnl_timeout_find_get(struct net *net, const char *name) 493 const char *name)
494{ 494{
495 struct ctnl_timeout *timeout, *matching = NULL; 495 struct ctnl_timeout *timeout, *matching = NULL;
496 496
@@ -509,7 +509,7 @@ ctnl_timeout_find_get(struct net *net, const char *name)
509 break; 509 break;
510 } 510 }
511err: 511err:
512 return matching; 512 return matching ? &matching->timeout : NULL;
513} 513}
514 514
515static void ctnl_timeout_put(struct nf_ct_timeout *t) 515static void ctnl_timeout_put(struct nf_ct_timeout *t)
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index ea4ba551abb2..d33094f4ec41 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -233,6 +233,7 @@ static void nfqnl_reinject(struct nf_queue_entry *entry, unsigned int verdict)
233 int err; 233 int err;
234 234
235 if (verdict == NF_ACCEPT || 235 if (verdict == NF_ACCEPT ||
236 verdict == NF_REPEAT ||
236 verdict == NF_STOP) { 237 verdict == NF_STOP) {
237 rcu_read_lock(); 238 rcu_read_lock();
238 ct_hook = rcu_dereference(nf_ct_hook); 239 ct_hook = rcu_dereference(nf_ct_hook);
diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
index 26a8baebd072..5dd87748afa8 100644
--- a/net/netfilter/nft_ct.c
+++ b/net/netfilter/nft_ct.c
@@ -799,7 +799,7 @@ err:
799} 799}
800 800
801struct nft_ct_timeout_obj { 801struct nft_ct_timeout_obj {
802 struct nf_conn *tmpl; 802 struct nf_ct_timeout *timeout;
803 u8 l4proto; 803 u8 l4proto;
804}; 804};
805 805
@@ -809,26 +809,42 @@ static void nft_ct_timeout_obj_eval(struct nft_object *obj,
809{ 809{
810 const struct nft_ct_timeout_obj *priv = nft_obj_data(obj); 810 const struct nft_ct_timeout_obj *priv = nft_obj_data(obj);
811 struct nf_conn *ct = (struct nf_conn *)skb_nfct(pkt->skb); 811 struct nf_conn *ct = (struct nf_conn *)skb_nfct(pkt->skb);
812 struct sk_buff *skb = pkt->skb; 812 struct nf_conn_timeout *timeout;
813 const unsigned int *values;
814
815 if (priv->l4proto != pkt->tprot)
816 return;
813 817
814 if (ct || 818 if (!ct || nf_ct_is_template(ct) || nf_ct_is_confirmed(ct))
815 priv->l4proto != pkt->tprot)
816 return; 819 return;
817 820
818 nf_ct_set(skb, priv->tmpl, IP_CT_NEW); 821 timeout = nf_ct_timeout_find(ct);
822 if (!timeout) {
823 timeout = nf_ct_timeout_ext_add(ct, priv->timeout, GFP_ATOMIC);
824 if (!timeout) {
825 regs->verdict.code = NF_DROP;
826 return;
827 }
828 }
829
830 rcu_assign_pointer(timeout->timeout, priv->timeout);
831
832 /* adjust the timeout as per 'new' state. ct is unconfirmed,
833 * so the current timestamp must not be added.
834 */
835 values = nf_ct_timeout_data(timeout);
836 if (values)
837 nf_ct_refresh(ct, pkt->skb, values[0]);
819} 838}
820 839
821static int nft_ct_timeout_obj_init(const struct nft_ctx *ctx, 840static int nft_ct_timeout_obj_init(const struct nft_ctx *ctx,
822 const struct nlattr * const tb[], 841 const struct nlattr * const tb[],
823 struct nft_object *obj) 842 struct nft_object *obj)
824{ 843{
825 const struct nf_conntrack_zone *zone = &nf_ct_zone_dflt;
826 struct nft_ct_timeout_obj *priv = nft_obj_data(obj); 844 struct nft_ct_timeout_obj *priv = nft_obj_data(obj);
827 const struct nf_conntrack_l4proto *l4proto; 845 const struct nf_conntrack_l4proto *l4proto;
828 struct nf_conn_timeout *timeout_ext;
829 struct nf_ct_timeout *timeout; 846 struct nf_ct_timeout *timeout;
830 int l3num = ctx->family; 847 int l3num = ctx->family;
831 struct nf_conn *tmpl;
832 __u8 l4num; 848 __u8 l4num;
833 int ret; 849 int ret;
834 850
@@ -863,28 +879,14 @@ static int nft_ct_timeout_obj_init(const struct nft_ctx *ctx,
863 879
864 timeout->l3num = l3num; 880 timeout->l3num = l3num;
865 timeout->l4proto = l4proto; 881 timeout->l4proto = l4proto;
866 tmpl = nf_ct_tmpl_alloc(ctx->net, zone, GFP_ATOMIC);
867 if (!tmpl) {
868 ret = -ENOMEM;
869 goto err_free_timeout;
870 }
871
872 timeout_ext = nf_ct_timeout_ext_add(tmpl, timeout, GFP_ATOMIC);
873 if (!timeout_ext) {
874 ret = -ENOMEM;
875 goto err_free_tmpl;
876 }
877 882
878 ret = nf_ct_netns_get(ctx->net, ctx->family); 883 ret = nf_ct_netns_get(ctx->net, ctx->family);
879 if (ret < 0) 884 if (ret < 0)
880 goto err_free_tmpl; 885 goto err_free_timeout;
881
882 priv->tmpl = tmpl;
883 886
887 priv->timeout = timeout;
884 return 0; 888 return 0;
885 889
886err_free_tmpl:
887 nf_ct_tmpl_free(tmpl);
888err_free_timeout: 890err_free_timeout:
889 kfree(timeout); 891 kfree(timeout);
890err_proto_put: 892err_proto_put:
@@ -896,22 +898,19 @@ static void nft_ct_timeout_obj_destroy(const struct nft_ctx *ctx,
896 struct nft_object *obj) 898 struct nft_object *obj)
897{ 899{
898 struct nft_ct_timeout_obj *priv = nft_obj_data(obj); 900 struct nft_ct_timeout_obj *priv = nft_obj_data(obj);
899 struct nf_conn_timeout *t = nf_ct_timeout_find(priv->tmpl); 901 struct nf_ct_timeout *timeout = priv->timeout;
900 struct nf_ct_timeout *timeout;
901 902
902 timeout = rcu_dereference_raw(t->timeout);
903 nf_ct_untimeout(ctx->net, timeout); 903 nf_ct_untimeout(ctx->net, timeout);
904 nf_ct_l4proto_put(timeout->l4proto); 904 nf_ct_l4proto_put(timeout->l4proto);
905 nf_ct_netns_put(ctx->net, ctx->family); 905 nf_ct_netns_put(ctx->net, ctx->family);
906 nf_ct_tmpl_free(priv->tmpl); 906 kfree(priv->timeout);
907} 907}
908 908
909static int nft_ct_timeout_obj_dump(struct sk_buff *skb, 909static int nft_ct_timeout_obj_dump(struct sk_buff *skb,
910 struct nft_object *obj, bool reset) 910 struct nft_object *obj, bool reset)
911{ 911{
912 const struct nft_ct_timeout_obj *priv = nft_obj_data(obj); 912 const struct nft_ct_timeout_obj *priv = nft_obj_data(obj);
913 const struct nf_conn_timeout *t = nf_ct_timeout_find(priv->tmpl); 913 const struct nf_ct_timeout *timeout = priv->timeout;
914 const struct nf_ct_timeout *timeout = rcu_dereference_raw(t->timeout);
915 struct nlattr *nest_params; 914 struct nlattr *nest_params;
916 int ret; 915 int ret;
917 916
diff --git a/net/netfilter/nft_osf.c b/net/netfilter/nft_osf.c
index 5af74b37f423..a35fb59ace73 100644
--- a/net/netfilter/nft_osf.c
+++ b/net/netfilter/nft_osf.c
@@ -49,7 +49,7 @@ static int nft_osf_init(const struct nft_ctx *ctx,
49 49
50 priv->dreg = nft_parse_register(tb[NFTA_OSF_DREG]); 50 priv->dreg = nft_parse_register(tb[NFTA_OSF_DREG]);
51 err = nft_validate_register_store(ctx, priv->dreg, NULL, 51 err = nft_validate_register_store(ctx, priv->dreg, NULL,
52 NFTA_DATA_VALUE, NFT_OSF_MAXGENRELEN); 52 NFT_DATA_VALUE, NFT_OSF_MAXGENRELEN);
53 if (err < 0) 53 if (err < 0)
54 return err; 54 return err;
55 55
diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c
index 55e2d9215c0d..0e5ec126f6ad 100644
--- a/net/netfilter/nft_set_rbtree.c
+++ b/net/netfilter/nft_set_rbtree.c
@@ -355,12 +355,11 @@ cont:
355 355
356static void nft_rbtree_gc(struct work_struct *work) 356static void nft_rbtree_gc(struct work_struct *work)
357{ 357{
358 struct nft_rbtree_elem *rbe, *rbe_end = NULL, *rbe_prev = NULL;
358 struct nft_set_gc_batch *gcb = NULL; 359 struct nft_set_gc_batch *gcb = NULL;
359 struct rb_node *node, *prev = NULL;
360 struct nft_rbtree_elem *rbe;
361 struct nft_rbtree *priv; 360 struct nft_rbtree *priv;
361 struct rb_node *node;
362 struct nft_set *set; 362 struct nft_set *set;
363 int i;
364 363
365 priv = container_of(work, struct nft_rbtree, gc_work.work); 364 priv = container_of(work, struct nft_rbtree, gc_work.work);
366 set = nft_set_container_of(priv); 365 set = nft_set_container_of(priv);
@@ -371,7 +370,7 @@ static void nft_rbtree_gc(struct work_struct *work)
371 rbe = rb_entry(node, struct nft_rbtree_elem, node); 370 rbe = rb_entry(node, struct nft_rbtree_elem, node);
372 371
373 if (nft_rbtree_interval_end(rbe)) { 372 if (nft_rbtree_interval_end(rbe)) {
374 prev = node; 373 rbe_end = rbe;
375 continue; 374 continue;
376 } 375 }
377 if (!nft_set_elem_expired(&rbe->ext)) 376 if (!nft_set_elem_expired(&rbe->ext))
@@ -379,29 +378,30 @@ static void nft_rbtree_gc(struct work_struct *work)
379 if (nft_set_elem_mark_busy(&rbe->ext)) 378 if (nft_set_elem_mark_busy(&rbe->ext))
380 continue; 379 continue;
381 380
381 if (rbe_prev) {
382 rb_erase(&rbe_prev->node, &priv->root);
383 rbe_prev = NULL;
384 }
382 gcb = nft_set_gc_batch_check(set, gcb, GFP_ATOMIC); 385 gcb = nft_set_gc_batch_check(set, gcb, GFP_ATOMIC);
383 if (!gcb) 386 if (!gcb)
384 break; 387 break;
385 388
386 atomic_dec(&set->nelems); 389 atomic_dec(&set->nelems);
387 nft_set_gc_batch_add(gcb, rbe); 390 nft_set_gc_batch_add(gcb, rbe);
391 rbe_prev = rbe;
388 392
389 if (prev) { 393 if (rbe_end) {
390 rbe = rb_entry(prev, struct nft_rbtree_elem, node);
391 atomic_dec(&set->nelems); 394 atomic_dec(&set->nelems);
392 nft_set_gc_batch_add(gcb, rbe); 395 nft_set_gc_batch_add(gcb, rbe_end);
393 prev = NULL; 396 rb_erase(&rbe_end->node, &priv->root);
397 rbe_end = NULL;
394 } 398 }
395 node = rb_next(node); 399 node = rb_next(node);
396 if (!node) 400 if (!node)
397 break; 401 break;
398 } 402 }
399 if (gcb) { 403 if (rbe_prev)
400 for (i = 0; i < gcb->head.cnt; i++) { 404 rb_erase(&rbe_prev->node, &priv->root);
401 rbe = gcb->elems[i];
402 rb_erase(&rbe->node, &priv->root);
403 }
404 }
405 write_seqcount_end(&priv->count); 405 write_seqcount_end(&priv->count);
406 write_unlock_bh(&priv->lock); 406 write_unlock_bh(&priv->lock);
407 407
diff --git a/net/netfilter/xt_CHECKSUM.c b/net/netfilter/xt_CHECKSUM.c
index 9f4151ec3e06..6c7aa6a0a0d2 100644
--- a/net/netfilter/xt_CHECKSUM.c
+++ b/net/netfilter/xt_CHECKSUM.c
@@ -16,6 +16,9 @@
16#include <linux/netfilter/x_tables.h> 16#include <linux/netfilter/x_tables.h>
17#include <linux/netfilter/xt_CHECKSUM.h> 17#include <linux/netfilter/xt_CHECKSUM.h>
18 18
19#include <linux/netfilter_ipv4/ip_tables.h>
20#include <linux/netfilter_ipv6/ip6_tables.h>
21
19MODULE_LICENSE("GPL"); 22MODULE_LICENSE("GPL");
20MODULE_AUTHOR("Michael S. Tsirkin <mst@redhat.com>"); 23MODULE_AUTHOR("Michael S. Tsirkin <mst@redhat.com>");
21MODULE_DESCRIPTION("Xtables: checksum modification"); 24MODULE_DESCRIPTION("Xtables: checksum modification");
@@ -25,7 +28,7 @@ MODULE_ALIAS("ip6t_CHECKSUM");
25static unsigned int 28static unsigned int
26checksum_tg(struct sk_buff *skb, const struct xt_action_param *par) 29checksum_tg(struct sk_buff *skb, const struct xt_action_param *par)
27{ 30{
28 if (skb->ip_summed == CHECKSUM_PARTIAL) 31 if (skb->ip_summed == CHECKSUM_PARTIAL && !skb_is_gso(skb))
29 skb_checksum_help(skb); 32 skb_checksum_help(skb);
30 33
31 return XT_CONTINUE; 34 return XT_CONTINUE;
@@ -34,6 +37,8 @@ checksum_tg(struct sk_buff *skb, const struct xt_action_param *par)
34static int checksum_tg_check(const struct xt_tgchk_param *par) 37static int checksum_tg_check(const struct xt_tgchk_param *par)
35{ 38{
36 const struct xt_CHECKSUM_info *einfo = par->targinfo; 39 const struct xt_CHECKSUM_info *einfo = par->targinfo;
40 const struct ip6t_ip6 *i6 = par->entryinfo;
41 const struct ipt_ip *i4 = par->entryinfo;
37 42
38 if (einfo->operation & ~XT_CHECKSUM_OP_FILL) { 43 if (einfo->operation & ~XT_CHECKSUM_OP_FILL) {
39 pr_info_ratelimited("unsupported CHECKSUM operation %x\n", 44 pr_info_ratelimited("unsupported CHECKSUM operation %x\n",
@@ -43,6 +48,21 @@ static int checksum_tg_check(const struct xt_tgchk_param *par)
43 if (!einfo->operation) 48 if (!einfo->operation)
44 return -EINVAL; 49 return -EINVAL;
45 50
51 switch (par->family) {
52 case NFPROTO_IPV4:
53 if (i4->proto == IPPROTO_UDP &&
54 (i4->invflags & XT_INV_PROTO) == 0)
55 return 0;
56 break;
57 case NFPROTO_IPV6:
58 if ((i6->flags & IP6T_F_PROTO) &&
59 i6->proto == IPPROTO_UDP &&
60 (i6->invflags & XT_INV_PROTO) == 0)
61 return 0;
62 break;
63 }
64
65 pr_warn_once("CHECKSUM should be avoided. If really needed, restrict with \"-p udp\" and only use in OUTPUT\n");
46 return 0; 66 return 0;
47} 67}
48 68
diff --git a/net/netfilter/xt_cluster.c b/net/netfilter/xt_cluster.c
index dfbdbb2fc0ed..51d0c257e7a5 100644
--- a/net/netfilter/xt_cluster.c
+++ b/net/netfilter/xt_cluster.c
@@ -125,6 +125,7 @@ xt_cluster_mt(const struct sk_buff *skb, struct xt_action_param *par)
125static int xt_cluster_mt_checkentry(const struct xt_mtchk_param *par) 125static int xt_cluster_mt_checkentry(const struct xt_mtchk_param *par)
126{ 126{
127 struct xt_cluster_match_info *info = par->matchinfo; 127 struct xt_cluster_match_info *info = par->matchinfo;
128 int ret;
128 129
129 if (info->total_nodes > XT_CLUSTER_NODES_MAX) { 130 if (info->total_nodes > XT_CLUSTER_NODES_MAX) {
130 pr_info_ratelimited("you have exceeded the maximum number of cluster nodes (%u > %u)\n", 131 pr_info_ratelimited("you have exceeded the maximum number of cluster nodes (%u > %u)\n",
@@ -135,7 +136,17 @@ static int xt_cluster_mt_checkentry(const struct xt_mtchk_param *par)
135 pr_info_ratelimited("node mask cannot exceed total number of nodes\n"); 136 pr_info_ratelimited("node mask cannot exceed total number of nodes\n");
136 return -EDOM; 137 return -EDOM;
137 } 138 }
138 return 0; 139
140 ret = nf_ct_netns_get(par->net, par->family);
141 if (ret < 0)
142 pr_info_ratelimited("cannot load conntrack support for proto=%u\n",
143 par->family);
144 return ret;
145}
146
147static void xt_cluster_mt_destroy(const struct xt_mtdtor_param *par)
148{
149 nf_ct_netns_put(par->net, par->family);
139} 150}
140 151
141static struct xt_match xt_cluster_match __read_mostly = { 152static struct xt_match xt_cluster_match __read_mostly = {
@@ -144,6 +155,7 @@ static struct xt_match xt_cluster_match __read_mostly = {
144 .match = xt_cluster_mt, 155 .match = xt_cluster_mt,
145 .checkentry = xt_cluster_mt_checkentry, 156 .checkentry = xt_cluster_mt_checkentry,
146 .matchsize = sizeof(struct xt_cluster_match_info), 157 .matchsize = sizeof(struct xt_cluster_match_info),
158 .destroy = xt_cluster_mt_destroy,
147 .me = THIS_MODULE, 159 .me = THIS_MODULE,
148}; 160};
149 161
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index 9b16402f29af..3e7d259e5d8d 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -1057,7 +1057,7 @@ static struct xt_match hashlimit_mt_reg[] __read_mostly = {
1057static void *dl_seq_start(struct seq_file *s, loff_t *pos) 1057static void *dl_seq_start(struct seq_file *s, loff_t *pos)
1058 __acquires(htable->lock) 1058 __acquires(htable->lock)
1059{ 1059{
1060 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->private)); 1060 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->file));
1061 unsigned int *bucket; 1061 unsigned int *bucket;
1062 1062
1063 spin_lock_bh(&htable->lock); 1063 spin_lock_bh(&htable->lock);
@@ -1074,7 +1074,7 @@ static void *dl_seq_start(struct seq_file *s, loff_t *pos)
1074 1074
1075static void *dl_seq_next(struct seq_file *s, void *v, loff_t *pos) 1075static void *dl_seq_next(struct seq_file *s, void *v, loff_t *pos)
1076{ 1076{
1077 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->private)); 1077 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->file));
1078 unsigned int *bucket = v; 1078 unsigned int *bucket = v;
1079 1079
1080 *pos = ++(*bucket); 1080 *pos = ++(*bucket);
@@ -1088,7 +1088,7 @@ static void *dl_seq_next(struct seq_file *s, void *v, loff_t *pos)
1088static void dl_seq_stop(struct seq_file *s, void *v) 1088static void dl_seq_stop(struct seq_file *s, void *v)
1089 __releases(htable->lock) 1089 __releases(htable->lock)
1090{ 1090{
1091 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->private)); 1091 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->file));
1092 unsigned int *bucket = v; 1092 unsigned int *bucket = v;
1093 1093
1094 if (!IS_ERR(bucket)) 1094 if (!IS_ERR(bucket))
@@ -1130,7 +1130,7 @@ static void dl_seq_print(struct dsthash_ent *ent, u_int8_t family,
1130static int dl_seq_real_show_v2(struct dsthash_ent *ent, u_int8_t family, 1130static int dl_seq_real_show_v2(struct dsthash_ent *ent, u_int8_t family,
1131 struct seq_file *s) 1131 struct seq_file *s)
1132{ 1132{
1133 struct xt_hashlimit_htable *ht = PDE_DATA(file_inode(s->private)); 1133 struct xt_hashlimit_htable *ht = PDE_DATA(file_inode(s->file));
1134 1134
1135 spin_lock(&ent->lock); 1135 spin_lock(&ent->lock);
1136 /* recalculate to show accurate numbers */ 1136 /* recalculate to show accurate numbers */
@@ -1145,7 +1145,7 @@ static int dl_seq_real_show_v2(struct dsthash_ent *ent, u_int8_t family,
1145static int dl_seq_real_show_v1(struct dsthash_ent *ent, u_int8_t family, 1145static int dl_seq_real_show_v1(struct dsthash_ent *ent, u_int8_t family,
1146 struct seq_file *s) 1146 struct seq_file *s)
1147{ 1147{
1148 struct xt_hashlimit_htable *ht = PDE_DATA(file_inode(s->private)); 1148 struct xt_hashlimit_htable *ht = PDE_DATA(file_inode(s->file));
1149 1149
1150 spin_lock(&ent->lock); 1150 spin_lock(&ent->lock);
1151 /* recalculate to show accurate numbers */ 1151 /* recalculate to show accurate numbers */
@@ -1160,7 +1160,7 @@ static int dl_seq_real_show_v1(struct dsthash_ent *ent, u_int8_t family,
1160static int dl_seq_real_show(struct dsthash_ent *ent, u_int8_t family, 1160static int dl_seq_real_show(struct dsthash_ent *ent, u_int8_t family,
1161 struct seq_file *s) 1161 struct seq_file *s)
1162{ 1162{
1163 struct xt_hashlimit_htable *ht = PDE_DATA(file_inode(s->private)); 1163 struct xt_hashlimit_htable *ht = PDE_DATA(file_inode(s->file));
1164 1164
1165 spin_lock(&ent->lock); 1165 spin_lock(&ent->lock);
1166 /* recalculate to show accurate numbers */ 1166 /* recalculate to show accurate numbers */
@@ -1174,7 +1174,7 @@ static int dl_seq_real_show(struct dsthash_ent *ent, u_int8_t family,
1174 1174
1175static int dl_seq_show_v2(struct seq_file *s, void *v) 1175static int dl_seq_show_v2(struct seq_file *s, void *v)
1176{ 1176{
1177 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->private)); 1177 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->file));
1178 unsigned int *bucket = (unsigned int *)v; 1178 unsigned int *bucket = (unsigned int *)v;
1179 struct dsthash_ent *ent; 1179 struct dsthash_ent *ent;
1180 1180
@@ -1188,7 +1188,7 @@ static int dl_seq_show_v2(struct seq_file *s, void *v)
1188 1188
1189static int dl_seq_show_v1(struct seq_file *s, void *v) 1189static int dl_seq_show_v1(struct seq_file *s, void *v)
1190{ 1190{
1191 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->private)); 1191 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->file));
1192 unsigned int *bucket = v; 1192 unsigned int *bucket = v;
1193 struct dsthash_ent *ent; 1193 struct dsthash_ent *ent;
1194 1194
@@ -1202,7 +1202,7 @@ static int dl_seq_show_v1(struct seq_file *s, void *v)
1202 1202
1203static int dl_seq_show(struct seq_file *s, void *v) 1203static int dl_seq_show(struct seq_file *s, void *v)
1204{ 1204{
1205 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->private)); 1205 struct xt_hashlimit_htable *htable = PDE_DATA(file_inode(s->file));
1206 unsigned int *bucket = v; 1206 unsigned int *bucket = v;
1207 struct dsthash_ent *ent; 1207 struct dsthash_ent *ent;
1208 1208
diff --git a/net/netfilter/xt_socket.c b/net/netfilter/xt_socket.c
index 0472f3472842..ada144e5645b 100644
--- a/net/netfilter/xt_socket.c
+++ b/net/netfilter/xt_socket.c
@@ -56,7 +56,7 @@ socket_match(const struct sk_buff *skb, struct xt_action_param *par,
56 struct sk_buff *pskb = (struct sk_buff *)skb; 56 struct sk_buff *pskb = (struct sk_buff *)skb;
57 struct sock *sk = skb->sk; 57 struct sock *sk = skb->sk;
58 58
59 if (!net_eq(xt_net(par), sock_net(sk))) 59 if (sk && !net_eq(xt_net(par), sock_net(sk)))
60 sk = NULL; 60 sk = NULL;
61 61
62 if (!sk) 62 if (!sk)
@@ -117,7 +117,7 @@ socket_mt6_v1_v2_v3(const struct sk_buff *skb, struct xt_action_param *par)
117 struct sk_buff *pskb = (struct sk_buff *)skb; 117 struct sk_buff *pskb = (struct sk_buff *)skb;
118 struct sock *sk = skb->sk; 118 struct sock *sk = skb->sk;
119 119
120 if (!net_eq(xt_net(par), sock_net(sk))) 120 if (sk && !net_eq(xt_net(par), sock_net(sk)))
121 sk = NULL; 121 sk = NULL;
122 122
123 if (!sk) 123 if (!sk)
diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
index c070dfc0190a..c92894c3e40a 100644
--- a/net/netlabel/netlabel_unlabeled.c
+++ b/net/netlabel/netlabel_unlabeled.c
@@ -781,7 +781,8 @@ static int netlbl_unlabel_addrinfo_get(struct genl_info *info,
781{ 781{
782 u32 addr_len; 782 u32 addr_len;
783 783
784 if (info->attrs[NLBL_UNLABEL_A_IPV4ADDR]) { 784 if (info->attrs[NLBL_UNLABEL_A_IPV4ADDR] &&
785 info->attrs[NLBL_UNLABEL_A_IPV4MASK]) {
785 addr_len = nla_len(info->attrs[NLBL_UNLABEL_A_IPV4ADDR]); 786 addr_len = nla_len(info->attrs[NLBL_UNLABEL_A_IPV4ADDR]);
786 if (addr_len != sizeof(struct in_addr) && 787 if (addr_len != sizeof(struct in_addr) &&
787 addr_len != nla_len(info->attrs[NLBL_UNLABEL_A_IPV4MASK])) 788 addr_len != nla_len(info->attrs[NLBL_UNLABEL_A_IPV4MASK]))
diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c
index ac8030c4bcf8..19cb2e473ea6 100644
--- a/net/nfc/hci/core.c
+++ b/net/nfc/hci/core.c
@@ -209,6 +209,11 @@ void nfc_hci_cmd_received(struct nfc_hci_dev *hdev, u8 pipe, u8 cmd,
209 } 209 }
210 create_info = (struct hci_create_pipe_resp *)skb->data; 210 create_info = (struct hci_create_pipe_resp *)skb->data;
211 211
212 if (create_info->pipe >= NFC_HCI_MAX_PIPES) {
213 status = NFC_HCI_ANY_E_NOK;
214 goto exit;
215 }
216
212 /* Save the new created pipe and bind with local gate, 217 /* Save the new created pipe and bind with local gate,
213 * the description for skb->data[3] is destination gate id 218 * the description for skb->data[3] is destination gate id
214 * but since we received this cmd from host controller, we 219 * but since we received this cmd from host controller, we
@@ -232,6 +237,11 @@ void nfc_hci_cmd_received(struct nfc_hci_dev *hdev, u8 pipe, u8 cmd,
232 } 237 }
233 delete_info = (struct hci_delete_pipe_noti *)skb->data; 238 delete_info = (struct hci_delete_pipe_noti *)skb->data;
234 239
240 if (delete_info->pipe >= NFC_HCI_MAX_PIPES) {
241 status = NFC_HCI_ANY_E_NOK;
242 goto exit;
243 }
244
235 hdev->pipes[delete_info->pipe].gate = NFC_HCI_INVALID_GATE; 245 hdev->pipes[delete_info->pipe].gate = NFC_HCI_INVALID_GATE;
236 hdev->pipes[delete_info->pipe].dest_host = NFC_HCI_INVALID_HOST; 246 hdev->pipes[delete_info->pipe].dest_host = NFC_HCI_INVALID_HOST;
237 break; 247 break;
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index 86a75105af1a..35ae64cbef33 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -1312,6 +1312,10 @@ static int ovs_ct_add_helper(struct ovs_conntrack_info *info, const char *name,
1312 1312
1313 rcu_assign_pointer(help->helper, helper); 1313 rcu_assign_pointer(help->helper, helper);
1314 info->helper = helper; 1314 info->helper = helper;
1315
1316 if (info->nat)
1317 request_module("ip_nat_%s", name);
1318
1315 return 0; 1319 return 0;
1316} 1320}
1317 1321
@@ -1624,10 +1628,6 @@ int ovs_ct_copy_action(struct net *net, const struct nlattr *attr,
1624 OVS_NLERR(log, "Failed to allocate conntrack template"); 1628 OVS_NLERR(log, "Failed to allocate conntrack template");
1625 return -ENOMEM; 1629 return -ENOMEM;
1626 } 1630 }
1627
1628 __set_bit(IPS_CONFIRMED_BIT, &ct_info.ct->status);
1629 nf_conntrack_get(&ct_info.ct->ct_general);
1630
1631 if (helper) { 1631 if (helper) {
1632 err = ovs_ct_add_helper(&ct_info, helper, key, log); 1632 err = ovs_ct_add_helper(&ct_info, helper, key, log);
1633 if (err) 1633 if (err)
@@ -1639,6 +1639,8 @@ int ovs_ct_copy_action(struct net *net, const struct nlattr *attr,
1639 if (err) 1639 if (err)
1640 goto err_free_ct; 1640 goto err_free_ct;
1641 1641
1642 __set_bit(IPS_CONFIRMED_BIT, &ct_info.ct->status);
1643 nf_conntrack_get(&ct_info.ct->ct_general);
1642 return 0; 1644 return 0;
1643err_free_ct: 1645err_free_ct:
1644 __ovs_ct_free_action(&ct_info); 1646 __ovs_ct_free_action(&ct_info);
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 75c92a87e7b2..d6e94dc7e290 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -2715,10 +2715,12 @@ tpacket_error:
2715 } 2715 }
2716 } 2716 }
2717 2717
2718 if (po->has_vnet_hdr && virtio_net_hdr_to_skb(skb, vnet_hdr, 2718 if (po->has_vnet_hdr) {
2719 vio_le())) { 2719 if (virtio_net_hdr_to_skb(skb, vnet_hdr, vio_le())) {
2720 tp_len = -EINVAL; 2720 tp_len = -EINVAL;
2721 goto tpacket_error; 2721 goto tpacket_error;
2722 }
2723 virtio_net_hdr_set_proto(skb, vnet_hdr);
2722 } 2724 }
2723 2725
2724 skb->destructor = tpacket_destruct_skb; 2726 skb->destructor = tpacket_destruct_skb;
@@ -2915,6 +2917,7 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len)
2915 if (err) 2917 if (err)
2916 goto out_free; 2918 goto out_free;
2917 len += sizeof(vnet_hdr); 2919 len += sizeof(vnet_hdr);
2920 virtio_net_hdr_set_proto(skb, &vnet_hdr);
2918 } 2921 }
2919 2922
2920 skb_probe_transport_header(skb, reserve); 2923 skb_probe_transport_header(skb, reserve);
diff --git a/net/rds/bind.c b/net/rds/bind.c
index 3ab55784b637..762d2c6788a3 100644
--- a/net/rds/bind.c
+++ b/net/rds/bind.c
@@ -76,11 +76,13 @@ struct rds_sock *rds_find_bound(const struct in6_addr *addr, __be16 port,
76 struct rds_sock *rs; 76 struct rds_sock *rs;
77 77
78 __rds_create_bind_key(key, addr, port, scope_id); 78 __rds_create_bind_key(key, addr, port, scope_id);
79 rs = rhashtable_lookup_fast(&bind_hash_table, key, ht_parms); 79 rcu_read_lock();
80 rs = rhashtable_lookup(&bind_hash_table, key, ht_parms);
80 if (rs && !sock_flag(rds_rs_to_sk(rs), SOCK_DEAD)) 81 if (rs && !sock_flag(rds_rs_to_sk(rs), SOCK_DEAD))
81 rds_sock_addref(rs); 82 rds_sock_addref(rs);
82 else 83 else
83 rs = NULL; 84 rs = NULL;
85 rcu_read_unlock();
84 86
85 rdsdebug("returning rs %p for %pI6c:%u\n", rs, addr, 87 rdsdebug("returning rs %p for %pI6c:%u\n", rs, addr,
86 ntohs(port)); 88 ntohs(port));
@@ -235,6 +237,7 @@ int rds_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
235 goto out; 237 goto out;
236 } 238 }
237 239
240 sock_set_flag(sk, SOCK_RCU_FREE);
238 ret = rds_add_bound(rs, binding_addr, &port, scope_id); 241 ret = rds_add_bound(rs, binding_addr, &port, scope_id);
239 if (ret) 242 if (ret)
240 goto out; 243 goto out;
diff --git a/net/rds/ib.h b/net/rds/ib.h
index 73427ff439f9..71ff356ee702 100644
--- a/net/rds/ib.h
+++ b/net/rds/ib.h
@@ -443,7 +443,7 @@ int rds_ib_send_grab_credits(struct rds_ib_connection *ic, u32 wanted,
443int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op); 443int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op);
444 444
445/* ib_stats.c */ 445/* ib_stats.c */
446DECLARE_PER_CPU(struct rds_ib_statistics, rds_ib_stats); 446DECLARE_PER_CPU_SHARED_ALIGNED(struct rds_ib_statistics, rds_ib_stats);
447#define rds_ib_stats_inc(member) rds_stats_inc_which(rds_ib_stats, member) 447#define rds_ib_stats_inc(member) rds_stats_inc_which(rds_ib_stats, member)
448#define rds_ib_stats_add(member, count) \ 448#define rds_ib_stats_add(member, count) \
449 rds_stats_add_which(rds_ib_stats, member, count) 449 rds_stats_add_which(rds_ib_stats, member, count)
diff --git a/net/rds/send.c b/net/rds/send.c
index 57b3d5a8b2db..fe785ee819dd 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -1007,7 +1007,8 @@ static int rds_cmsg_send(struct rds_sock *rs, struct rds_message *rm,
1007 return ret; 1007 return ret;
1008} 1008}
1009 1009
1010static int rds_send_mprds_hash(struct rds_sock *rs, struct rds_connection *conn) 1010static int rds_send_mprds_hash(struct rds_sock *rs,
1011 struct rds_connection *conn, int nonblock)
1011{ 1012{
1012 int hash; 1013 int hash;
1013 1014
@@ -1023,10 +1024,16 @@ static int rds_send_mprds_hash(struct rds_sock *rs, struct rds_connection *conn)
1023 * used. But if we are interrupted, we have to use the zero 1024 * used. But if we are interrupted, we have to use the zero
1024 * c_path in case the connection ends up being non-MP capable. 1025 * c_path in case the connection ends up being non-MP capable.
1025 */ 1026 */
1026 if (conn->c_npaths == 0) 1027 if (conn->c_npaths == 0) {
1028 /* Cannot wait for the connection be made, so just use
1029 * the base c_path.
1030 */
1031 if (nonblock)
1032 return 0;
1027 if (wait_event_interruptible(conn->c_hs_waitq, 1033 if (wait_event_interruptible(conn->c_hs_waitq,
1028 conn->c_npaths != 0)) 1034 conn->c_npaths != 0))
1029 hash = 0; 1035 hash = 0;
1036 }
1030 if (conn->c_npaths == 1) 1037 if (conn->c_npaths == 1)
1031 hash = 0; 1038 hash = 0;
1032 } 1039 }
@@ -1256,7 +1263,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
1256 } 1263 }
1257 1264
1258 if (conn->c_trans->t_mp_capable) 1265 if (conn->c_trans->t_mp_capable)
1259 cpath = &conn->c_path[rds_send_mprds_hash(rs, conn)]; 1266 cpath = &conn->c_path[rds_send_mprds_hash(rs, conn, nonblock)];
1260 else 1267 else
1261 cpath = &conn->c_path[0]; 1268 cpath = &conn->c_path[0];
1262 1269
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h
index c97558710421..a6e6cae82c30 100644
--- a/net/rxrpc/ar-internal.h
+++ b/net/rxrpc/ar-internal.h
@@ -40,17 +40,12 @@ struct rxrpc_crypt {
40struct rxrpc_connection; 40struct rxrpc_connection;
41 41
42/* 42/*
43 * Mark applied to socket buffers. 43 * Mark applied to socket buffers in skb->mark. skb->priority is used
44 * to pass supplementary information.
44 */ 45 */
45enum rxrpc_skb_mark { 46enum rxrpc_skb_mark {
46 RXRPC_SKB_MARK_DATA, /* data message */ 47 RXRPC_SKB_MARK_REJECT_BUSY, /* Reject with BUSY */
47 RXRPC_SKB_MARK_FINAL_ACK, /* final ACK received message */ 48 RXRPC_SKB_MARK_REJECT_ABORT, /* Reject with ABORT (code in skb->priority) */
48 RXRPC_SKB_MARK_BUSY, /* server busy message */
49 RXRPC_SKB_MARK_REMOTE_ABORT, /* remote abort message */
50 RXRPC_SKB_MARK_LOCAL_ABORT, /* local abort message */
51 RXRPC_SKB_MARK_NET_ERROR, /* network error message */
52 RXRPC_SKB_MARK_LOCAL_ERROR, /* local error message */
53 RXRPC_SKB_MARK_NEW_CALL, /* local error message */
54}; 49};
55 50
56/* 51/*
@@ -293,7 +288,6 @@ struct rxrpc_peer {
293 struct hlist_node hash_link; 288 struct hlist_node hash_link;
294 struct rxrpc_local *local; 289 struct rxrpc_local *local;
295 struct hlist_head error_targets; /* targets for net error distribution */ 290 struct hlist_head error_targets; /* targets for net error distribution */
296 struct work_struct error_distributor;
297 struct rb_root service_conns; /* Service connections */ 291 struct rb_root service_conns; /* Service connections */
298 struct list_head keepalive_link; /* Link in net->peer_keepalive[] */ 292 struct list_head keepalive_link; /* Link in net->peer_keepalive[] */
299 time64_t last_tx_at; /* Last time packet sent here */ 293 time64_t last_tx_at; /* Last time packet sent here */
@@ -304,12 +298,11 @@ struct rxrpc_peer {
304 unsigned int maxdata; /* data size (MTU - hdrsize) */ 298 unsigned int maxdata; /* data size (MTU - hdrsize) */
305 unsigned short hdrsize; /* header size (IP + UDP + RxRPC) */ 299 unsigned short hdrsize; /* header size (IP + UDP + RxRPC) */
306 int debug_id; /* debug ID for printks */ 300 int debug_id; /* debug ID for printks */
307 int error_report; /* Net (+0) or local (+1000000) to distribute */
308#define RXRPC_LOCAL_ERROR_OFFSET 1000000
309 struct sockaddr_rxrpc srx; /* remote address */ 301 struct sockaddr_rxrpc srx; /* remote address */
310 302
311 /* calculated RTT cache */ 303 /* calculated RTT cache */
312#define RXRPC_RTT_CACHE_SIZE 32 304#define RXRPC_RTT_CACHE_SIZE 32
305 spinlock_t rtt_input_lock; /* RTT lock for input routine */
313 ktime_t rtt_last_req; /* Time of last RTT request */ 306 ktime_t rtt_last_req; /* Time of last RTT request */
314 u64 rtt; /* Current RTT estimate (in nS) */ 307 u64 rtt; /* Current RTT estimate (in nS) */
315 u64 rtt_sum; /* Sum of cache contents */ 308 u64 rtt_sum; /* Sum of cache contents */
@@ -450,19 +443,29 @@ struct rxrpc_connection {
450 spinlock_t state_lock; /* state-change lock */ 443 spinlock_t state_lock; /* state-change lock */
451 enum rxrpc_conn_cache_state cache_state; 444 enum rxrpc_conn_cache_state cache_state;
452 enum rxrpc_conn_proto_state state; /* current state of connection */ 445 enum rxrpc_conn_proto_state state; /* current state of connection */
453 u32 local_abort; /* local abort code */ 446 u32 abort_code; /* Abort code of connection abort */
454 u32 remote_abort; /* remote abort code */
455 int debug_id; /* debug ID for printks */ 447 int debug_id; /* debug ID for printks */
456 atomic_t serial; /* packet serial number counter */ 448 atomic_t serial; /* packet serial number counter */
457 unsigned int hi_serial; /* highest serial number received */ 449 unsigned int hi_serial; /* highest serial number received */
458 u32 security_nonce; /* response re-use preventer */ 450 u32 security_nonce; /* response re-use preventer */
459 u16 service_id; /* Service ID, possibly upgraded */ 451 u32 service_id; /* Service ID, possibly upgraded */
460 u8 size_align; /* data size alignment (for security) */ 452 u8 size_align; /* data size alignment (for security) */
461 u8 security_size; /* security header size */ 453 u8 security_size; /* security header size */
462 u8 security_ix; /* security type */ 454 u8 security_ix; /* security type */
463 u8 out_clientflag; /* RXRPC_CLIENT_INITIATED if we are client */ 455 u8 out_clientflag; /* RXRPC_CLIENT_INITIATED if we are client */
456 short error; /* Local error code */
464}; 457};
465 458
459static inline bool rxrpc_to_server(const struct rxrpc_skb_priv *sp)
460{
461 return sp->hdr.flags & RXRPC_CLIENT_INITIATED;
462}
463
464static inline bool rxrpc_to_client(const struct rxrpc_skb_priv *sp)
465{
466 return !rxrpc_to_server(sp);
467}
468
466/* 469/*
467 * Flags in call->flags. 470 * Flags in call->flags.
468 */ 471 */
@@ -633,6 +636,8 @@ struct rxrpc_call {
633 bool tx_phase; /* T if transmission phase, F if receive phase */ 636 bool tx_phase; /* T if transmission phase, F if receive phase */
634 u8 nr_jumbo_bad; /* Number of jumbo dups/exceeds-windows */ 637 u8 nr_jumbo_bad; /* Number of jumbo dups/exceeds-windows */
635 638
639 spinlock_t input_lock; /* Lock for packet input to this call */
640
636 /* receive-phase ACK management */ 641 /* receive-phase ACK management */
637 u8 ackr_reason; /* reason to ACK */ 642 u8 ackr_reason; /* reason to ACK */
638 u16 ackr_skew; /* skew on packet being ACK'd */ 643 u16 ackr_skew; /* skew on packet being ACK'd */
@@ -717,7 +722,7 @@ extern struct workqueue_struct *rxrpc_workqueue;
717int rxrpc_service_prealloc(struct rxrpc_sock *, gfp_t); 722int rxrpc_service_prealloc(struct rxrpc_sock *, gfp_t);
718void rxrpc_discard_prealloc(struct rxrpc_sock *); 723void rxrpc_discard_prealloc(struct rxrpc_sock *);
719struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *, 724struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *,
720 struct rxrpc_connection *, 725 struct rxrpc_sock *,
721 struct sk_buff *); 726 struct sk_buff *);
722void rxrpc_accept_incoming_calls(struct rxrpc_local *); 727void rxrpc_accept_incoming_calls(struct rxrpc_local *);
723struct rxrpc_call *rxrpc_accept_call(struct rxrpc_sock *, unsigned long, 728struct rxrpc_call *rxrpc_accept_call(struct rxrpc_sock *, unsigned long,
@@ -887,8 +892,9 @@ extern unsigned long rxrpc_conn_idle_client_fast_expiry;
887extern struct idr rxrpc_client_conn_ids; 892extern struct idr rxrpc_client_conn_ids;
888 893
889void rxrpc_destroy_client_conn_ids(void); 894void rxrpc_destroy_client_conn_ids(void);
890int rxrpc_connect_call(struct rxrpc_call *, struct rxrpc_conn_parameters *, 895int rxrpc_connect_call(struct rxrpc_sock *, struct rxrpc_call *,
891 struct sockaddr_rxrpc *, gfp_t); 896 struct rxrpc_conn_parameters *, struct sockaddr_rxrpc *,
897 gfp_t);
892void rxrpc_expose_client_call(struct rxrpc_call *); 898void rxrpc_expose_client_call(struct rxrpc_call *);
893void rxrpc_disconnect_client_call(struct rxrpc_call *); 899void rxrpc_disconnect_client_call(struct rxrpc_call *);
894void rxrpc_put_client_conn(struct rxrpc_connection *); 900void rxrpc_put_client_conn(struct rxrpc_connection *);
@@ -908,7 +914,8 @@ extern unsigned int rxrpc_closed_conn_expiry;
908 914
909struct rxrpc_connection *rxrpc_alloc_connection(gfp_t); 915struct rxrpc_connection *rxrpc_alloc_connection(gfp_t);
910struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *, 916struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *,
911 struct sk_buff *); 917 struct sk_buff *,
918 struct rxrpc_peer **);
912void __rxrpc_disconnect_call(struct rxrpc_connection *, struct rxrpc_call *); 919void __rxrpc_disconnect_call(struct rxrpc_connection *, struct rxrpc_call *);
913void rxrpc_disconnect_call(struct rxrpc_call *); 920void rxrpc_disconnect_call(struct rxrpc_call *);
914void rxrpc_kill_connection(struct rxrpc_connection *); 921void rxrpc_kill_connection(struct rxrpc_connection *);
@@ -960,7 +967,7 @@ void rxrpc_unpublish_service_conn(struct rxrpc_connection *);
960/* 967/*
961 * input.c 968 * input.c
962 */ 969 */
963void rxrpc_data_ready(struct sock *); 970int rxrpc_input_packet(struct sock *, struct sk_buff *);
964 971
965/* 972/*
966 * insecure.c 973 * insecure.c
@@ -1031,7 +1038,6 @@ void rxrpc_send_keepalive(struct rxrpc_peer *);
1031 * peer_event.c 1038 * peer_event.c
1032 */ 1039 */
1033void rxrpc_error_report(struct sock *); 1040void rxrpc_error_report(struct sock *);
1034void rxrpc_peer_error_distributor(struct work_struct *);
1035void rxrpc_peer_add_rtt(struct rxrpc_call *, enum rxrpc_rtt_rx_trace, 1041void rxrpc_peer_add_rtt(struct rxrpc_call *, enum rxrpc_rtt_rx_trace,
1036 rxrpc_serial_t, rxrpc_serial_t, ktime_t, ktime_t); 1042 rxrpc_serial_t, rxrpc_serial_t, ktime_t, ktime_t);
1037void rxrpc_peer_keepalive_worker(struct work_struct *); 1043void rxrpc_peer_keepalive_worker(struct work_struct *);
@@ -1041,16 +1047,15 @@ void rxrpc_peer_keepalive_worker(struct work_struct *);
1041 */ 1047 */
1042struct rxrpc_peer *rxrpc_lookup_peer_rcu(struct rxrpc_local *, 1048struct rxrpc_peer *rxrpc_lookup_peer_rcu(struct rxrpc_local *,
1043 const struct sockaddr_rxrpc *); 1049 const struct sockaddr_rxrpc *);
1044struct rxrpc_peer *rxrpc_lookup_peer(struct rxrpc_local *, 1050struct rxrpc_peer *rxrpc_lookup_peer(struct rxrpc_sock *, struct rxrpc_local *,
1045 struct sockaddr_rxrpc *, gfp_t); 1051 struct sockaddr_rxrpc *, gfp_t);
1046struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *, gfp_t); 1052struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *, gfp_t);
1047struct rxrpc_peer *rxrpc_lookup_incoming_peer(struct rxrpc_local *, 1053void rxrpc_new_incoming_peer(struct rxrpc_sock *, struct rxrpc_local *,
1048 struct rxrpc_peer *); 1054 struct rxrpc_peer *);
1049void rxrpc_destroy_all_peers(struct rxrpc_net *); 1055void rxrpc_destroy_all_peers(struct rxrpc_net *);
1050struct rxrpc_peer *rxrpc_get_peer(struct rxrpc_peer *); 1056struct rxrpc_peer *rxrpc_get_peer(struct rxrpc_peer *);
1051struct rxrpc_peer *rxrpc_get_peer_maybe(struct rxrpc_peer *); 1057struct rxrpc_peer *rxrpc_get_peer_maybe(struct rxrpc_peer *);
1052void rxrpc_put_peer(struct rxrpc_peer *); 1058void rxrpc_put_peer(struct rxrpc_peer *);
1053void __rxrpc_queue_peer_error(struct rxrpc_peer *);
1054 1059
1055/* 1060/*
1056 * proc.c 1061 * proc.c
diff --git a/net/rxrpc/call_accept.c b/net/rxrpc/call_accept.c
index 9d1e298b784c..652e314de38e 100644
--- a/net/rxrpc/call_accept.c
+++ b/net/rxrpc/call_accept.c
@@ -249,11 +249,11 @@ void rxrpc_discard_prealloc(struct rxrpc_sock *rx)
249 */ 249 */
250static struct rxrpc_call *rxrpc_alloc_incoming_call(struct rxrpc_sock *rx, 250static struct rxrpc_call *rxrpc_alloc_incoming_call(struct rxrpc_sock *rx,
251 struct rxrpc_local *local, 251 struct rxrpc_local *local,
252 struct rxrpc_peer *peer,
252 struct rxrpc_connection *conn, 253 struct rxrpc_connection *conn,
253 struct sk_buff *skb) 254 struct sk_buff *skb)
254{ 255{
255 struct rxrpc_backlog *b = rx->backlog; 256 struct rxrpc_backlog *b = rx->backlog;
256 struct rxrpc_peer *peer, *xpeer;
257 struct rxrpc_call *call; 257 struct rxrpc_call *call;
258 unsigned short call_head, conn_head, peer_head; 258 unsigned short call_head, conn_head, peer_head;
259 unsigned short call_tail, conn_tail, peer_tail; 259 unsigned short call_tail, conn_tail, peer_tail;
@@ -276,21 +276,18 @@ static struct rxrpc_call *rxrpc_alloc_incoming_call(struct rxrpc_sock *rx,
276 return NULL; 276 return NULL;
277 277
278 if (!conn) { 278 if (!conn) {
279 /* No connection. We're going to need a peer to start off 279 if (peer && !rxrpc_get_peer_maybe(peer))
280 * with. If one doesn't yet exist, use a spare from the 280 peer = NULL;
281 * preallocation set. We dump the address into the spare in 281 if (!peer) {
282 * anticipation - and to save on stack space. 282 peer = b->peer_backlog[peer_tail];
283 */ 283 if (rxrpc_extract_addr_from_skb(local, &peer->srx, skb) < 0)
284 xpeer = b->peer_backlog[peer_tail]; 284 return NULL;
285 if (rxrpc_extract_addr_from_skb(local, &xpeer->srx, skb) < 0)
286 return NULL;
287
288 peer = rxrpc_lookup_incoming_peer(local, xpeer);
289 if (peer == xpeer) {
290 b->peer_backlog[peer_tail] = NULL; 285 b->peer_backlog[peer_tail] = NULL;
291 smp_store_release(&b->peer_backlog_tail, 286 smp_store_release(&b->peer_backlog_tail,
292 (peer_tail + 1) & 287 (peer_tail + 1) &
293 (RXRPC_BACKLOG_MAX - 1)); 288 (RXRPC_BACKLOG_MAX - 1));
289
290 rxrpc_new_incoming_peer(rx, local, peer);
294 } 291 }
295 292
296 /* Now allocate and set up the connection */ 293 /* Now allocate and set up the connection */
@@ -335,45 +332,38 @@ static struct rxrpc_call *rxrpc_alloc_incoming_call(struct rxrpc_sock *rx,
335 * The call is returned with the user access mutex held. 332 * The call is returned with the user access mutex held.
336 */ 333 */
337struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *local, 334struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *local,
338 struct rxrpc_connection *conn, 335 struct rxrpc_sock *rx,
339 struct sk_buff *skb) 336 struct sk_buff *skb)
340{ 337{
341 struct rxrpc_skb_priv *sp = rxrpc_skb(skb); 338 struct rxrpc_skb_priv *sp = rxrpc_skb(skb);
342 struct rxrpc_sock *rx; 339 struct rxrpc_connection *conn;
340 struct rxrpc_peer *peer;
343 struct rxrpc_call *call; 341 struct rxrpc_call *call;
344 u16 service_id = sp->hdr.serviceId;
345 342
346 _enter(""); 343 _enter("");
347 344
348 /* Get the socket providing the service */
349 rx = rcu_dereference(local->service);
350 if (rx && (service_id == rx->srx.srx_service ||
351 service_id == rx->second_service))
352 goto found_service;
353
354 trace_rxrpc_abort(0, "INV", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq,
355 RX_INVALID_OPERATION, EOPNOTSUPP);
356 skb->mark = RXRPC_SKB_MARK_LOCAL_ABORT;
357 skb->priority = RX_INVALID_OPERATION;
358 _leave(" = NULL [service]");
359 return NULL;
360
361found_service:
362 spin_lock(&rx->incoming_lock); 345 spin_lock(&rx->incoming_lock);
363 if (rx->sk.sk_state == RXRPC_SERVER_LISTEN_DISABLED || 346 if (rx->sk.sk_state == RXRPC_SERVER_LISTEN_DISABLED ||
364 rx->sk.sk_state == RXRPC_CLOSE) { 347 rx->sk.sk_state == RXRPC_CLOSE) {
365 trace_rxrpc_abort(0, "CLS", sp->hdr.cid, sp->hdr.callNumber, 348 trace_rxrpc_abort(0, "CLS", sp->hdr.cid, sp->hdr.callNumber,
366 sp->hdr.seq, RX_INVALID_OPERATION, ESHUTDOWN); 349 sp->hdr.seq, RX_INVALID_OPERATION, ESHUTDOWN);
367 skb->mark = RXRPC_SKB_MARK_LOCAL_ABORT; 350 skb->mark = RXRPC_SKB_MARK_REJECT_ABORT;
368 skb->priority = RX_INVALID_OPERATION; 351 skb->priority = RX_INVALID_OPERATION;
369 _leave(" = NULL [close]"); 352 _leave(" = NULL [close]");
370 call = NULL; 353 call = NULL;
371 goto out; 354 goto out;
372 } 355 }
373 356
374 call = rxrpc_alloc_incoming_call(rx, local, conn, skb); 357 /* The peer, connection and call may all have sprung into existence due
358 * to a duplicate packet being handled on another CPU in parallel, so
359 * we have to recheck the routing. However, we're now holding
360 * rx->incoming_lock, so the values should remain stable.
361 */
362 conn = rxrpc_find_connection_rcu(local, skb, &peer);
363
364 call = rxrpc_alloc_incoming_call(rx, local, peer, conn, skb);
375 if (!call) { 365 if (!call) {
376 skb->mark = RXRPC_SKB_MARK_BUSY; 366 skb->mark = RXRPC_SKB_MARK_REJECT_BUSY;
377 _leave(" = NULL [busy]"); 367 _leave(" = NULL [busy]");
378 call = NULL; 368 call = NULL;
379 goto out; 369 goto out;
@@ -413,20 +403,22 @@ found_service:
413 403
414 case RXRPC_CONN_SERVICE: 404 case RXRPC_CONN_SERVICE:
415 write_lock(&call->state_lock); 405 write_lock(&call->state_lock);
416 if (rx->discard_new_call) 406 if (call->state < RXRPC_CALL_COMPLETE) {
417 call->state = RXRPC_CALL_SERVER_RECV_REQUEST; 407 if (rx->discard_new_call)
418 else 408 call->state = RXRPC_CALL_SERVER_RECV_REQUEST;
419 call->state = RXRPC_CALL_SERVER_ACCEPTING; 409 else
410 call->state = RXRPC_CALL_SERVER_ACCEPTING;
411 }
420 write_unlock(&call->state_lock); 412 write_unlock(&call->state_lock);
421 break; 413 break;
422 414
423 case RXRPC_CONN_REMOTELY_ABORTED: 415 case RXRPC_CONN_REMOTELY_ABORTED:
424 rxrpc_set_call_completion(call, RXRPC_CALL_REMOTELY_ABORTED, 416 rxrpc_set_call_completion(call, RXRPC_CALL_REMOTELY_ABORTED,
425 conn->remote_abort, -ECONNABORTED); 417 conn->abort_code, conn->error);
426 break; 418 break;
427 case RXRPC_CONN_LOCALLY_ABORTED: 419 case RXRPC_CONN_LOCALLY_ABORTED:
428 rxrpc_abort_call("CON", call, sp->hdr.seq, 420 rxrpc_abort_call("CON", call, sp->hdr.seq,
429 conn->local_abort, -ECONNABORTED); 421 conn->abort_code, conn->error);
430 break; 422 break;
431 default: 423 default:
432 BUG(); 424 BUG();
diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c
index 9486293fef5c..8f1a8f85b1f9 100644
--- a/net/rxrpc/call_object.c
+++ b/net/rxrpc/call_object.c
@@ -138,6 +138,7 @@ struct rxrpc_call *rxrpc_alloc_call(struct rxrpc_sock *rx, gfp_t gfp,
138 init_waitqueue_head(&call->waitq); 138 init_waitqueue_head(&call->waitq);
139 spin_lock_init(&call->lock); 139 spin_lock_init(&call->lock);
140 spin_lock_init(&call->notify_lock); 140 spin_lock_init(&call->notify_lock);
141 spin_lock_init(&call->input_lock);
141 rwlock_init(&call->state_lock); 142 rwlock_init(&call->state_lock);
142 atomic_set(&call->usage, 1); 143 atomic_set(&call->usage, 1);
143 call->debug_id = debug_id; 144 call->debug_id = debug_id;
@@ -287,7 +288,7 @@ struct rxrpc_call *rxrpc_new_client_call(struct rxrpc_sock *rx,
287 /* Set up or get a connection record and set the protocol parameters, 288 /* Set up or get a connection record and set the protocol parameters,
288 * including channel number and call ID. 289 * including channel number and call ID.
289 */ 290 */
290 ret = rxrpc_connect_call(call, cp, srx, gfp); 291 ret = rxrpc_connect_call(rx, call, cp, srx, gfp);
291 if (ret < 0) 292 if (ret < 0)
292 goto error; 293 goto error;
293 294
@@ -339,7 +340,7 @@ int rxrpc_retry_client_call(struct rxrpc_sock *rx,
339 /* Set up or get a connection record and set the protocol parameters, 340 /* Set up or get a connection record and set the protocol parameters,
340 * including channel number and call ID. 341 * including channel number and call ID.
341 */ 342 */
342 ret = rxrpc_connect_call(call, cp, srx, gfp); 343 ret = rxrpc_connect_call(rx, call, cp, srx, gfp);
343 if (ret < 0) 344 if (ret < 0)
344 goto error; 345 goto error;
345 346
@@ -400,7 +401,7 @@ void rxrpc_incoming_call(struct rxrpc_sock *rx,
400 rcu_assign_pointer(conn->channels[chan].call, call); 401 rcu_assign_pointer(conn->channels[chan].call, call);
401 402
402 spin_lock(&conn->params.peer->lock); 403 spin_lock(&conn->params.peer->lock);
403 hlist_add_head(&call->error_link, &conn->params.peer->error_targets); 404 hlist_add_head_rcu(&call->error_link, &conn->params.peer->error_targets);
404 spin_unlock(&conn->params.peer->lock); 405 spin_unlock(&conn->params.peer->lock);
405 406
406 _net("CALL incoming %d on CONN %d", call->debug_id, call->conn->debug_id); 407 _net("CALL incoming %d on CONN %d", call->debug_id, call->conn->debug_id);
diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c
index f8f37188a932..521189f4b666 100644
--- a/net/rxrpc/conn_client.c
+++ b/net/rxrpc/conn_client.c
@@ -276,7 +276,8 @@ dont_reuse:
276 * If we return with a connection, the call will be on its waiting list. It's 276 * If we return with a connection, the call will be on its waiting list. It's
277 * left to the caller to assign a channel and wake up the call. 277 * left to the caller to assign a channel and wake up the call.
278 */ 278 */
279static int rxrpc_get_client_conn(struct rxrpc_call *call, 279static int rxrpc_get_client_conn(struct rxrpc_sock *rx,
280 struct rxrpc_call *call,
280 struct rxrpc_conn_parameters *cp, 281 struct rxrpc_conn_parameters *cp,
281 struct sockaddr_rxrpc *srx, 282 struct sockaddr_rxrpc *srx,
282 gfp_t gfp) 283 gfp_t gfp)
@@ -289,7 +290,7 @@ static int rxrpc_get_client_conn(struct rxrpc_call *call,
289 290
290 _enter("{%d,%lx},", call->debug_id, call->user_call_ID); 291 _enter("{%d,%lx},", call->debug_id, call->user_call_ID);
291 292
292 cp->peer = rxrpc_lookup_peer(cp->local, srx, gfp); 293 cp->peer = rxrpc_lookup_peer(rx, cp->local, srx, gfp);
293 if (!cp->peer) 294 if (!cp->peer)
294 goto error; 295 goto error;
295 296
@@ -683,7 +684,8 @@ out:
683 * find a connection for a call 684 * find a connection for a call
684 * - called in process context with IRQs enabled 685 * - called in process context with IRQs enabled
685 */ 686 */
686int rxrpc_connect_call(struct rxrpc_call *call, 687int rxrpc_connect_call(struct rxrpc_sock *rx,
688 struct rxrpc_call *call,
687 struct rxrpc_conn_parameters *cp, 689 struct rxrpc_conn_parameters *cp,
688 struct sockaddr_rxrpc *srx, 690 struct sockaddr_rxrpc *srx,
689 gfp_t gfp) 691 gfp_t gfp)
@@ -696,7 +698,7 @@ int rxrpc_connect_call(struct rxrpc_call *call,
696 rxrpc_discard_expired_client_conns(&rxnet->client_conn_reaper); 698 rxrpc_discard_expired_client_conns(&rxnet->client_conn_reaper);
697 rxrpc_cull_active_client_conns(rxnet); 699 rxrpc_cull_active_client_conns(rxnet);
698 700
699 ret = rxrpc_get_client_conn(call, cp, srx, gfp); 701 ret = rxrpc_get_client_conn(rx, call, cp, srx, gfp);
700 if (ret < 0) 702 if (ret < 0)
701 goto out; 703 goto out;
702 704
@@ -710,8 +712,8 @@ int rxrpc_connect_call(struct rxrpc_call *call,
710 } 712 }
711 713
712 spin_lock_bh(&call->conn->params.peer->lock); 714 spin_lock_bh(&call->conn->params.peer->lock);
713 hlist_add_head(&call->error_link, 715 hlist_add_head_rcu(&call->error_link,
714 &call->conn->params.peer->error_targets); 716 &call->conn->params.peer->error_targets);
715 spin_unlock_bh(&call->conn->params.peer->lock); 717 spin_unlock_bh(&call->conn->params.peer->lock);
716 718
717out: 719out:
diff --git a/net/rxrpc/conn_event.c b/net/rxrpc/conn_event.c
index 6df56ce68861..b6fca8ebb117 100644
--- a/net/rxrpc/conn_event.c
+++ b/net/rxrpc/conn_event.c
@@ -126,7 +126,7 @@ static void rxrpc_conn_retransmit_call(struct rxrpc_connection *conn,
126 126
127 switch (chan->last_type) { 127 switch (chan->last_type) {
128 case RXRPC_PACKET_TYPE_ABORT: 128 case RXRPC_PACKET_TYPE_ABORT:
129 _proto("Tx ABORT %%%u { %d } [re]", serial, conn->local_abort); 129 _proto("Tx ABORT %%%u { %d } [re]", serial, conn->abort_code);
130 break; 130 break;
131 case RXRPC_PACKET_TYPE_ACK: 131 case RXRPC_PACKET_TYPE_ACK:
132 trace_rxrpc_tx_ack(chan->call_debug_id, serial, 132 trace_rxrpc_tx_ack(chan->call_debug_id, serial,
@@ -153,13 +153,12 @@ static void rxrpc_conn_retransmit_call(struct rxrpc_connection *conn,
153 * pass a connection-level abort onto all calls on that connection 153 * pass a connection-level abort onto all calls on that connection
154 */ 154 */
155static void rxrpc_abort_calls(struct rxrpc_connection *conn, 155static void rxrpc_abort_calls(struct rxrpc_connection *conn,
156 enum rxrpc_call_completion compl, 156 enum rxrpc_call_completion compl)
157 u32 abort_code, int error)
158{ 157{
159 struct rxrpc_call *call; 158 struct rxrpc_call *call;
160 int i; 159 int i;
161 160
162 _enter("{%d},%x", conn->debug_id, abort_code); 161 _enter("{%d},%x", conn->debug_id, conn->abort_code);
163 162
164 spin_lock(&conn->channel_lock); 163 spin_lock(&conn->channel_lock);
165 164
@@ -172,9 +171,11 @@ static void rxrpc_abort_calls(struct rxrpc_connection *conn,
172 trace_rxrpc_abort(call->debug_id, 171 trace_rxrpc_abort(call->debug_id,
173 "CON", call->cid, 172 "CON", call->cid,
174 call->call_id, 0, 173 call->call_id, 0,
175 abort_code, error); 174 conn->abort_code,
175 conn->error);
176 if (rxrpc_set_call_completion(call, compl, 176 if (rxrpc_set_call_completion(call, compl,
177 abort_code, error)) 177 conn->abort_code,
178 conn->error))
178 rxrpc_notify_socket(call); 179 rxrpc_notify_socket(call);
179 } 180 }
180 } 181 }
@@ -207,10 +208,12 @@ static int rxrpc_abort_connection(struct rxrpc_connection *conn,
207 return 0; 208 return 0;
208 } 209 }
209 210
211 conn->error = error;
212 conn->abort_code = abort_code;
210 conn->state = RXRPC_CONN_LOCALLY_ABORTED; 213 conn->state = RXRPC_CONN_LOCALLY_ABORTED;
211 spin_unlock_bh(&conn->state_lock); 214 spin_unlock_bh(&conn->state_lock);
212 215
213 rxrpc_abort_calls(conn, RXRPC_CALL_LOCALLY_ABORTED, abort_code, error); 216 rxrpc_abort_calls(conn, RXRPC_CALL_LOCALLY_ABORTED);
214 217
215 msg.msg_name = &conn->params.peer->srx.transport; 218 msg.msg_name = &conn->params.peer->srx.transport;
216 msg.msg_namelen = conn->params.peer->srx.transport_len; 219 msg.msg_namelen = conn->params.peer->srx.transport_len;
@@ -229,7 +232,7 @@ static int rxrpc_abort_connection(struct rxrpc_connection *conn,
229 whdr._rsvd = 0; 232 whdr._rsvd = 0;
230 whdr.serviceId = htons(conn->service_id); 233 whdr.serviceId = htons(conn->service_id);
231 234
232 word = htonl(conn->local_abort); 235 word = htonl(conn->abort_code);
233 236
234 iov[0].iov_base = &whdr; 237 iov[0].iov_base = &whdr;
235 iov[0].iov_len = sizeof(whdr); 238 iov[0].iov_len = sizeof(whdr);
@@ -240,7 +243,7 @@ static int rxrpc_abort_connection(struct rxrpc_connection *conn,
240 243
241 serial = atomic_inc_return(&conn->serial); 244 serial = atomic_inc_return(&conn->serial);
242 whdr.serial = htonl(serial); 245 whdr.serial = htonl(serial);
243 _proto("Tx CONN ABORT %%%u { %d }", serial, conn->local_abort); 246 _proto("Tx CONN ABORT %%%u { %d }", serial, conn->abort_code);
244 247
245 ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len); 248 ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len);
246 if (ret < 0) { 249 if (ret < 0) {
@@ -315,9 +318,10 @@ static int rxrpc_process_event(struct rxrpc_connection *conn,
315 abort_code = ntohl(wtmp); 318 abort_code = ntohl(wtmp);
316 _proto("Rx ABORT %%%u { ac=%d }", sp->hdr.serial, abort_code); 319 _proto("Rx ABORT %%%u { ac=%d }", sp->hdr.serial, abort_code);
317 320
321 conn->error = -ECONNABORTED;
322 conn->abort_code = abort_code;
318 conn->state = RXRPC_CONN_REMOTELY_ABORTED; 323 conn->state = RXRPC_CONN_REMOTELY_ABORTED;
319 rxrpc_abort_calls(conn, RXRPC_CALL_REMOTELY_ABORTED, 324 rxrpc_abort_calls(conn, RXRPC_CALL_REMOTELY_ABORTED);
320 abort_code, -ECONNABORTED);
321 return -ECONNABORTED; 325 return -ECONNABORTED;
322 326
323 case RXRPC_PACKET_TYPE_CHALLENGE: 327 case RXRPC_PACKET_TYPE_CHALLENGE:
diff --git a/net/rxrpc/conn_object.c b/net/rxrpc/conn_object.c
index 77440a356b14..885dae829f4a 100644
--- a/net/rxrpc/conn_object.c
+++ b/net/rxrpc/conn_object.c
@@ -69,10 +69,14 @@ struct rxrpc_connection *rxrpc_alloc_connection(gfp_t gfp)
69 * If successful, a pointer to the connection is returned, but no ref is taken. 69 * If successful, a pointer to the connection is returned, but no ref is taken.
70 * NULL is returned if there is no match. 70 * NULL is returned if there is no match.
71 * 71 *
72 * When searching for a service call, if we find a peer but no connection, we
73 * return that through *_peer in case we need to create a new service call.
74 *
72 * The caller must be holding the RCU read lock. 75 * The caller must be holding the RCU read lock.
73 */ 76 */
74struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *local, 77struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *local,
75 struct sk_buff *skb) 78 struct sk_buff *skb,
79 struct rxrpc_peer **_peer)
76{ 80{
77 struct rxrpc_connection *conn; 81 struct rxrpc_connection *conn;
78 struct rxrpc_conn_proto k; 82 struct rxrpc_conn_proto k;
@@ -85,9 +89,6 @@ struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *local,
85 if (rxrpc_extract_addr_from_skb(local, &srx, skb) < 0) 89 if (rxrpc_extract_addr_from_skb(local, &srx, skb) < 0)
86 goto not_found; 90 goto not_found;
87 91
88 k.epoch = sp->hdr.epoch;
89 k.cid = sp->hdr.cid & RXRPC_CIDMASK;
90
91 /* We may have to handle mixing IPv4 and IPv6 */ 92 /* We may have to handle mixing IPv4 and IPv6 */
92 if (srx.transport.family != local->srx.transport.family) { 93 if (srx.transport.family != local->srx.transport.family) {
93 pr_warn_ratelimited("AF_RXRPC: Protocol mismatch %u not %u\n", 94 pr_warn_ratelimited("AF_RXRPC: Protocol mismatch %u not %u\n",
@@ -99,7 +100,7 @@ struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *local,
99 k.epoch = sp->hdr.epoch; 100 k.epoch = sp->hdr.epoch;
100 k.cid = sp->hdr.cid & RXRPC_CIDMASK; 101 k.cid = sp->hdr.cid & RXRPC_CIDMASK;
101 102
102 if (sp->hdr.flags & RXRPC_CLIENT_INITIATED) { 103 if (rxrpc_to_server(sp)) {
103 /* We need to look up service connections by the full protocol 104 /* We need to look up service connections by the full protocol
104 * parameter set. We look up the peer first as an intermediate 105 * parameter set. We look up the peer first as an intermediate
105 * step and then the connection from the peer's tree. 106 * step and then the connection from the peer's tree.
@@ -107,6 +108,7 @@ struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *local,
107 peer = rxrpc_lookup_peer_rcu(local, &srx); 108 peer = rxrpc_lookup_peer_rcu(local, &srx);
108 if (!peer) 109 if (!peer)
109 goto not_found; 110 goto not_found;
111 *_peer = peer;
110 conn = rxrpc_find_service_conn_rcu(peer, skb); 112 conn = rxrpc_find_service_conn_rcu(peer, skb);
111 if (!conn || atomic_read(&conn->usage) == 0) 113 if (!conn || atomic_read(&conn->usage) == 0)
112 goto not_found; 114 goto not_found;
@@ -214,7 +216,7 @@ void rxrpc_disconnect_call(struct rxrpc_call *call)
214 call->peer->cong_cwnd = call->cong_cwnd; 216 call->peer->cong_cwnd = call->cong_cwnd;
215 217
216 spin_lock_bh(&conn->params.peer->lock); 218 spin_lock_bh(&conn->params.peer->lock);
217 hlist_del_init(&call->error_link); 219 hlist_del_rcu(&call->error_link);
218 spin_unlock_bh(&conn->params.peer->lock); 220 spin_unlock_bh(&conn->params.peer->lock);
219 221
220 if (rxrpc_is_client_call(call)) 222 if (rxrpc_is_client_call(call))
diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index cfdc199c6351..570b49d2da42 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -216,10 +216,11 @@ static void rxrpc_send_ping(struct rxrpc_call *call, struct sk_buff *skb,
216/* 216/*
217 * Apply a hard ACK by advancing the Tx window. 217 * Apply a hard ACK by advancing the Tx window.
218 */ 218 */
219static void rxrpc_rotate_tx_window(struct rxrpc_call *call, rxrpc_seq_t to, 219static bool rxrpc_rotate_tx_window(struct rxrpc_call *call, rxrpc_seq_t to,
220 struct rxrpc_ack_summary *summary) 220 struct rxrpc_ack_summary *summary)
221{ 221{
222 struct sk_buff *skb, *list = NULL; 222 struct sk_buff *skb, *list = NULL;
223 bool rot_last = false;
223 int ix; 224 int ix;
224 u8 annotation; 225 u8 annotation;
225 226
@@ -243,15 +244,17 @@ static void rxrpc_rotate_tx_window(struct rxrpc_call *call, rxrpc_seq_t to,
243 skb->next = list; 244 skb->next = list;
244 list = skb; 245 list = skb;
245 246
246 if (annotation & RXRPC_TX_ANNO_LAST) 247 if (annotation & RXRPC_TX_ANNO_LAST) {
247 set_bit(RXRPC_CALL_TX_LAST, &call->flags); 248 set_bit(RXRPC_CALL_TX_LAST, &call->flags);
249 rot_last = true;
250 }
248 if ((annotation & RXRPC_TX_ANNO_MASK) != RXRPC_TX_ANNO_ACK) 251 if ((annotation & RXRPC_TX_ANNO_MASK) != RXRPC_TX_ANNO_ACK)
249 summary->nr_rot_new_acks++; 252 summary->nr_rot_new_acks++;
250 } 253 }
251 254
252 spin_unlock(&call->lock); 255 spin_unlock(&call->lock);
253 256
254 trace_rxrpc_transmit(call, (test_bit(RXRPC_CALL_TX_LAST, &call->flags) ? 257 trace_rxrpc_transmit(call, (rot_last ?
255 rxrpc_transmit_rotate_last : 258 rxrpc_transmit_rotate_last :
256 rxrpc_transmit_rotate)); 259 rxrpc_transmit_rotate));
257 wake_up(&call->waitq); 260 wake_up(&call->waitq);
@@ -262,6 +265,8 @@ static void rxrpc_rotate_tx_window(struct rxrpc_call *call, rxrpc_seq_t to,
262 skb->next = NULL; 265 skb->next = NULL;
263 rxrpc_free_skb(skb, rxrpc_skb_tx_freed); 266 rxrpc_free_skb(skb, rxrpc_skb_tx_freed);
264 } 267 }
268
269 return rot_last;
265} 270}
266 271
267/* 272/*
@@ -273,23 +278,26 @@ static void rxrpc_rotate_tx_window(struct rxrpc_call *call, rxrpc_seq_t to,
273static bool rxrpc_end_tx_phase(struct rxrpc_call *call, bool reply_begun, 278static bool rxrpc_end_tx_phase(struct rxrpc_call *call, bool reply_begun,
274 const char *abort_why) 279 const char *abort_why)
275{ 280{
281 unsigned int state;
276 282
277 ASSERT(test_bit(RXRPC_CALL_TX_LAST, &call->flags)); 283 ASSERT(test_bit(RXRPC_CALL_TX_LAST, &call->flags));
278 284
279 write_lock(&call->state_lock); 285 write_lock(&call->state_lock);
280 286
281 switch (call->state) { 287 state = call->state;
288 switch (state) {
282 case RXRPC_CALL_CLIENT_SEND_REQUEST: 289 case RXRPC_CALL_CLIENT_SEND_REQUEST:
283 case RXRPC_CALL_CLIENT_AWAIT_REPLY: 290 case RXRPC_CALL_CLIENT_AWAIT_REPLY:
284 if (reply_begun) 291 if (reply_begun)
285 call->state = RXRPC_CALL_CLIENT_RECV_REPLY; 292 call->state = state = RXRPC_CALL_CLIENT_RECV_REPLY;
286 else 293 else
287 call->state = RXRPC_CALL_CLIENT_AWAIT_REPLY; 294 call->state = state = RXRPC_CALL_CLIENT_AWAIT_REPLY;
288 break; 295 break;
289 296
290 case RXRPC_CALL_SERVER_AWAIT_ACK: 297 case RXRPC_CALL_SERVER_AWAIT_ACK:
291 __rxrpc_call_completed(call); 298 __rxrpc_call_completed(call);
292 rxrpc_notify_socket(call); 299 rxrpc_notify_socket(call);
300 state = call->state;
293 break; 301 break;
294 302
295 default: 303 default:
@@ -297,11 +305,10 @@ static bool rxrpc_end_tx_phase(struct rxrpc_call *call, bool reply_begun,
297 } 305 }
298 306
299 write_unlock(&call->state_lock); 307 write_unlock(&call->state_lock);
300 if (call->state == RXRPC_CALL_CLIENT_AWAIT_REPLY) { 308 if (state == RXRPC_CALL_CLIENT_AWAIT_REPLY)
301 trace_rxrpc_transmit(call, rxrpc_transmit_await_reply); 309 trace_rxrpc_transmit(call, rxrpc_transmit_await_reply);
302 } else { 310 else
303 trace_rxrpc_transmit(call, rxrpc_transmit_end); 311 trace_rxrpc_transmit(call, rxrpc_transmit_end);
304 }
305 _leave(" = ok"); 312 _leave(" = ok");
306 return true; 313 return true;
307 314
@@ -332,11 +339,11 @@ static bool rxrpc_receiving_reply(struct rxrpc_call *call)
332 trace_rxrpc_timer(call, rxrpc_timer_init_for_reply, now); 339 trace_rxrpc_timer(call, rxrpc_timer_init_for_reply, now);
333 } 340 }
334 341
335 if (!test_bit(RXRPC_CALL_TX_LAST, &call->flags))
336 rxrpc_rotate_tx_window(call, top, &summary);
337 if (!test_bit(RXRPC_CALL_TX_LAST, &call->flags)) { 342 if (!test_bit(RXRPC_CALL_TX_LAST, &call->flags)) {
338 rxrpc_proto_abort("TXL", call, top); 343 if (!rxrpc_rotate_tx_window(call, top, &summary)) {
339 return false; 344 rxrpc_proto_abort("TXL", call, top);
345 return false;
346 }
340 } 347 }
341 if (!rxrpc_end_tx_phase(call, true, "ETD")) 348 if (!rxrpc_end_tx_phase(call, true, "ETD"))
342 return false; 349 return false;
@@ -452,13 +459,15 @@ static void rxrpc_input_data(struct rxrpc_call *call, struct sk_buff *skb,
452 } 459 }
453 } 460 }
454 461
462 spin_lock(&call->input_lock);
463
455 /* Received data implicitly ACKs all of the request packets we sent 464 /* Received data implicitly ACKs all of the request packets we sent
456 * when we're acting as a client. 465 * when we're acting as a client.
457 */ 466 */
458 if ((state == RXRPC_CALL_CLIENT_SEND_REQUEST || 467 if ((state == RXRPC_CALL_CLIENT_SEND_REQUEST ||
459 state == RXRPC_CALL_CLIENT_AWAIT_REPLY) && 468 state == RXRPC_CALL_CLIENT_AWAIT_REPLY) &&
460 !rxrpc_receiving_reply(call)) 469 !rxrpc_receiving_reply(call))
461 return; 470 goto unlock;
462 471
463 call->ackr_prev_seq = seq; 472 call->ackr_prev_seq = seq;
464 473
@@ -488,12 +497,16 @@ next_subpacket:
488 497
489 if (flags & RXRPC_LAST_PACKET) { 498 if (flags & RXRPC_LAST_PACKET) {
490 if (test_bit(RXRPC_CALL_RX_LAST, &call->flags) && 499 if (test_bit(RXRPC_CALL_RX_LAST, &call->flags) &&
491 seq != call->rx_top) 500 seq != call->rx_top) {
492 return rxrpc_proto_abort("LSN", call, seq); 501 rxrpc_proto_abort("LSN", call, seq);
502 goto unlock;
503 }
493 } else { 504 } else {
494 if (test_bit(RXRPC_CALL_RX_LAST, &call->flags) && 505 if (test_bit(RXRPC_CALL_RX_LAST, &call->flags) &&
495 after_eq(seq, call->rx_top)) 506 after_eq(seq, call->rx_top)) {
496 return rxrpc_proto_abort("LSA", call, seq); 507 rxrpc_proto_abort("LSA", call, seq);
508 goto unlock;
509 }
497 } 510 }
498 511
499 trace_rxrpc_rx_data(call->debug_id, seq, serial, flags, annotation); 512 trace_rxrpc_rx_data(call->debug_id, seq, serial, flags, annotation);
@@ -560,8 +573,10 @@ next_subpacket:
560skip: 573skip:
561 offset += len; 574 offset += len;
562 if (flags & RXRPC_JUMBO_PACKET) { 575 if (flags & RXRPC_JUMBO_PACKET) {
563 if (skb_copy_bits(skb, offset, &flags, 1) < 0) 576 if (skb_copy_bits(skb, offset, &flags, 1) < 0) {
564 return rxrpc_proto_abort("XJF", call, seq); 577 rxrpc_proto_abort("XJF", call, seq);
578 goto unlock;
579 }
565 offset += sizeof(struct rxrpc_jumbo_header); 580 offset += sizeof(struct rxrpc_jumbo_header);
566 seq++; 581 seq++;
567 serial++; 582 serial++;
@@ -601,6 +616,9 @@ ack:
601 trace_rxrpc_notify_socket(call->debug_id, serial); 616 trace_rxrpc_notify_socket(call->debug_id, serial);
602 rxrpc_notify_socket(call); 617 rxrpc_notify_socket(call);
603 } 618 }
619
620unlock:
621 spin_unlock(&call->input_lock);
604 _leave(" [queued]"); 622 _leave(" [queued]");
605} 623}
606 624
@@ -622,13 +640,14 @@ static void rxrpc_input_requested_ack(struct rxrpc_call *call,
622 if (!skb) 640 if (!skb)
623 continue; 641 continue;
624 642
643 sent_at = skb->tstamp;
644 smp_rmb(); /* Read timestamp before serial. */
625 sp = rxrpc_skb(skb); 645 sp = rxrpc_skb(skb);
626 if (sp->hdr.serial != orig_serial) 646 if (sp->hdr.serial != orig_serial)
627 continue; 647 continue;
628 smp_rmb();
629 sent_at = skb->tstamp;
630 goto found; 648 goto found;
631 } 649 }
650
632 return; 651 return;
633 652
634found: 653found:
@@ -686,15 +705,14 @@ static void rxrpc_input_ping_response(struct rxrpc_call *call,
686 705
687 ping_time = call->ping_time; 706 ping_time = call->ping_time;
688 smp_rmb(); 707 smp_rmb();
689 ping_serial = call->ping_serial; 708 ping_serial = READ_ONCE(call->ping_serial);
690 709
691 if (orig_serial == call->acks_lost_ping) 710 if (orig_serial == call->acks_lost_ping)
692 rxrpc_input_check_for_lost_ack(call); 711 rxrpc_input_check_for_lost_ack(call);
693 712
694 if (!test_bit(RXRPC_CALL_PINGING, &call->flags) || 713 if (before(orig_serial, ping_serial) ||
695 before(orig_serial, ping_serial)) 714 !test_and_clear_bit(RXRPC_CALL_PINGING, &call->flags))
696 return; 715 return;
697 clear_bit(RXRPC_CALL_PINGING, &call->flags);
698 if (after(orig_serial, ping_serial)) 716 if (after(orig_serial, ping_serial))
699 return; 717 return;
700 718
@@ -860,15 +878,32 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb,
860 rxrpc_propose_ack_respond_to_ack); 878 rxrpc_propose_ack_respond_to_ack);
861 } 879 }
862 880
881 /* Discard any out-of-order or duplicate ACKs. */
882 if (before_eq(sp->hdr.serial, call->acks_latest))
883 return;
884
885 buf.info.rxMTU = 0;
863 ioffset = offset + nr_acks + 3; 886 ioffset = offset + nr_acks + 3;
864 if (skb->len >= ioffset + sizeof(buf.info)) { 887 if (skb->len >= ioffset + sizeof(buf.info) &&
865 if (skb_copy_bits(skb, ioffset, &buf.info, sizeof(buf.info)) < 0) 888 skb_copy_bits(skb, ioffset, &buf.info, sizeof(buf.info)) < 0)
866 return rxrpc_proto_abort("XAI", call, 0); 889 return rxrpc_proto_abort("XAI", call, 0);
890
891 spin_lock(&call->input_lock);
892
893 /* Discard any out-of-order or duplicate ACKs. */
894 if (before_eq(sp->hdr.serial, call->acks_latest))
895 goto out;
896 call->acks_latest_ts = skb->tstamp;
897 call->acks_latest = sp->hdr.serial;
898
899 /* Parse rwind and mtu sizes if provided. */
900 if (buf.info.rxMTU)
867 rxrpc_input_ackinfo(call, skb, &buf.info); 901 rxrpc_input_ackinfo(call, skb, &buf.info);
868 }
869 902
870 if (first_soft_ack == 0) 903 if (first_soft_ack == 0) {
871 return rxrpc_proto_abort("AK0", call, 0); 904 rxrpc_proto_abort("AK0", call, 0);
905 goto out;
906 }
872 907
873 /* Ignore ACKs unless we are or have just been transmitting. */ 908 /* Ignore ACKs unless we are or have just been transmitting. */
874 switch (READ_ONCE(call->state)) { 909 switch (READ_ONCE(call->state)) {
@@ -878,39 +913,35 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb,
878 case RXRPC_CALL_SERVER_AWAIT_ACK: 913 case RXRPC_CALL_SERVER_AWAIT_ACK:
879 break; 914 break;
880 default: 915 default:
881 return; 916 goto out;
882 }
883
884 /* Discard any out-of-order or duplicate ACKs. */
885 if (before_eq(sp->hdr.serial, call->acks_latest)) {
886 _debug("discard ACK %d <= %d",
887 sp->hdr.serial, call->acks_latest);
888 return;
889 } 917 }
890 call->acks_latest_ts = skb->tstamp;
891 call->acks_latest = sp->hdr.serial;
892 918
893 if (before(hard_ack, call->tx_hard_ack) || 919 if (before(hard_ack, call->tx_hard_ack) ||
894 after(hard_ack, call->tx_top)) 920 after(hard_ack, call->tx_top)) {
895 return rxrpc_proto_abort("AKW", call, 0); 921 rxrpc_proto_abort("AKW", call, 0);
896 if (nr_acks > call->tx_top - hard_ack) 922 goto out;
897 return rxrpc_proto_abort("AKN", call, 0); 923 }
924 if (nr_acks > call->tx_top - hard_ack) {
925 rxrpc_proto_abort("AKN", call, 0);
926 goto out;
927 }
898 928
899 if (after(hard_ack, call->tx_hard_ack)) 929 if (after(hard_ack, call->tx_hard_ack)) {
900 rxrpc_rotate_tx_window(call, hard_ack, &summary); 930 if (rxrpc_rotate_tx_window(call, hard_ack, &summary)) {
931 rxrpc_end_tx_phase(call, false, "ETA");
932 goto out;
933 }
934 }
901 935
902 if (nr_acks > 0) { 936 if (nr_acks > 0) {
903 if (skb_copy_bits(skb, offset, buf.acks, nr_acks) < 0) 937 if (skb_copy_bits(skb, offset, buf.acks, nr_acks) < 0) {
904 return rxrpc_proto_abort("XSA", call, 0); 938 rxrpc_proto_abort("XSA", call, 0);
939 goto out;
940 }
905 rxrpc_input_soft_acks(call, buf.acks, first_soft_ack, nr_acks, 941 rxrpc_input_soft_acks(call, buf.acks, first_soft_ack, nr_acks,
906 &summary); 942 &summary);
907 } 943 }
908 944
909 if (test_bit(RXRPC_CALL_TX_LAST, &call->flags)) {
910 rxrpc_end_tx_phase(call, false, "ETA");
911 return;
912 }
913
914 if (call->rxtx_annotations[call->tx_top & RXRPC_RXTX_BUFF_MASK] & 945 if (call->rxtx_annotations[call->tx_top & RXRPC_RXTX_BUFF_MASK] &
915 RXRPC_TX_ANNO_LAST && 946 RXRPC_TX_ANNO_LAST &&
916 summary.nr_acks == call->tx_top - hard_ack && 947 summary.nr_acks == call->tx_top - hard_ack &&
@@ -919,7 +950,9 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb,
919 false, true, 950 false, true,
920 rxrpc_propose_ack_ping_for_lost_reply); 951 rxrpc_propose_ack_ping_for_lost_reply);
921 952
922 return rxrpc_congestion_management(call, skb, &summary, acked_serial); 953 rxrpc_congestion_management(call, skb, &summary, acked_serial);
954out:
955 spin_unlock(&call->input_lock);
923} 956}
924 957
925/* 958/*
@@ -932,9 +965,12 @@ static void rxrpc_input_ackall(struct rxrpc_call *call, struct sk_buff *skb)
932 965
933 _proto("Rx ACKALL %%%u", sp->hdr.serial); 966 _proto("Rx ACKALL %%%u", sp->hdr.serial);
934 967
935 rxrpc_rotate_tx_window(call, call->tx_top, &summary); 968 spin_lock(&call->input_lock);
936 if (test_bit(RXRPC_CALL_TX_LAST, &call->flags)) 969
970 if (rxrpc_rotate_tx_window(call, call->tx_top, &summary))
937 rxrpc_end_tx_phase(call, false, "ETL"); 971 rxrpc_end_tx_phase(call, false, "ETL");
972
973 spin_unlock(&call->input_lock);
938} 974}
939 975
940/* 976/*
@@ -1017,18 +1053,19 @@ static void rxrpc_input_call_packet(struct rxrpc_call *call,
1017} 1053}
1018 1054
1019/* 1055/*
1020 * Handle a new call on a channel implicitly completing the preceding call on 1056 * Handle a new service call on a channel implicitly completing the preceding
1021 * that channel. 1057 * call on that channel. This does not apply to client conns.
1022 * 1058 *
1023 * TODO: If callNumber > call_id + 1, renegotiate security. 1059 * TODO: If callNumber > call_id + 1, renegotiate security.
1024 */ 1060 */
1025static void rxrpc_input_implicit_end_call(struct rxrpc_connection *conn, 1061static void rxrpc_input_implicit_end_call(struct rxrpc_sock *rx,
1062 struct rxrpc_connection *conn,
1026 struct rxrpc_call *call) 1063 struct rxrpc_call *call)
1027{ 1064{
1028 switch (READ_ONCE(call->state)) { 1065 switch (READ_ONCE(call->state)) {
1029 case RXRPC_CALL_SERVER_AWAIT_ACK: 1066 case RXRPC_CALL_SERVER_AWAIT_ACK:
1030 rxrpc_call_completed(call); 1067 rxrpc_call_completed(call);
1031 break; 1068 /* Fall through */
1032 case RXRPC_CALL_COMPLETE: 1069 case RXRPC_CALL_COMPLETE:
1033 break; 1070 break;
1034 default: 1071 default:
@@ -1036,11 +1073,13 @@ static void rxrpc_input_implicit_end_call(struct rxrpc_connection *conn,
1036 set_bit(RXRPC_CALL_EV_ABORT, &call->events); 1073 set_bit(RXRPC_CALL_EV_ABORT, &call->events);
1037 rxrpc_queue_call(call); 1074 rxrpc_queue_call(call);
1038 } 1075 }
1076 trace_rxrpc_improper_term(call);
1039 break; 1077 break;
1040 } 1078 }
1041 1079
1042 trace_rxrpc_improper_term(call); 1080 spin_lock(&rx->incoming_lock);
1043 __rxrpc_disconnect_call(conn, call); 1081 __rxrpc_disconnect_call(conn, call);
1082 spin_unlock(&rx->incoming_lock);
1044 rxrpc_notify_socket(call); 1083 rxrpc_notify_socket(call);
1045} 1084}
1046 1085
@@ -1119,43 +1158,29 @@ int rxrpc_extract_header(struct rxrpc_skb_priv *sp, struct sk_buff *skb)
1119 * The socket is locked by the caller and this prevents the socket from being 1158 * The socket is locked by the caller and this prevents the socket from being
1120 * shut down and the local endpoint from going away, thus sk_user_data will not 1159 * shut down and the local endpoint from going away, thus sk_user_data will not
1121 * be cleared until this function returns. 1160 * be cleared until this function returns.
1161 *
1162 * Called with the RCU read lock held from the IP layer via UDP.
1122 */ 1163 */
1123void rxrpc_data_ready(struct sock *udp_sk) 1164int rxrpc_input_packet(struct sock *udp_sk, struct sk_buff *skb)
1124{ 1165{
1125 struct rxrpc_connection *conn; 1166 struct rxrpc_connection *conn;
1126 struct rxrpc_channel *chan; 1167 struct rxrpc_channel *chan;
1127 struct rxrpc_call *call; 1168 struct rxrpc_call *call = NULL;
1128 struct rxrpc_skb_priv *sp; 1169 struct rxrpc_skb_priv *sp;
1129 struct rxrpc_local *local = udp_sk->sk_user_data; 1170 struct rxrpc_local *local = udp_sk->sk_user_data;
1130 struct sk_buff *skb; 1171 struct rxrpc_peer *peer = NULL;
1172 struct rxrpc_sock *rx = NULL;
1131 unsigned int channel; 1173 unsigned int channel;
1132 int ret, skew; 1174 int skew = 0;
1133 1175
1134 _enter("%p", udp_sk); 1176 _enter("%p", udp_sk);
1135 1177
1136 ASSERT(!irqs_disabled()); 1178 if (skb->tstamp == 0)
1137 1179 skb->tstamp = ktime_get_real();
1138 skb = skb_recv_udp(udp_sk, 0, 1, &ret);
1139 if (!skb) {
1140 if (ret == -EAGAIN)
1141 return;
1142 _debug("UDP socket error %d", ret);
1143 return;
1144 }
1145 1180
1146 rxrpc_new_skb(skb, rxrpc_skb_rx_received); 1181 rxrpc_new_skb(skb, rxrpc_skb_rx_received);
1147 1182
1148 _net("recv skb %p", skb); 1183 skb_pull(skb, sizeof(struct udphdr));
1149
1150 /* we'll probably need to checksum it (didn't call sock_recvmsg) */
1151 if (skb_checksum_complete(skb)) {
1152 rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
1153 __UDP_INC_STATS(&init_net, UDP_MIB_INERRORS, 0);
1154 _leave(" [CSUM failed]");
1155 return;
1156 }
1157
1158 __UDP_INC_STATS(&init_net, UDP_MIB_INDATAGRAMS, 0);
1159 1184
1160 /* The UDP protocol already released all skb resources; 1185 /* The UDP protocol already released all skb resources;
1161 * we are free to add our own data there. 1186 * we are free to add our own data there.
@@ -1170,69 +1195,104 @@ void rxrpc_data_ready(struct sock *udp_sk)
1170 static int lose; 1195 static int lose;
1171 if ((lose++ & 7) == 7) { 1196 if ((lose++ & 7) == 7) {
1172 trace_rxrpc_rx_lose(sp); 1197 trace_rxrpc_rx_lose(sp);
1173 rxrpc_lose_skb(skb, rxrpc_skb_rx_lost); 1198 rxrpc_free_skb(skb, rxrpc_skb_rx_lost);
1174 return; 1199 return 0;
1175 } 1200 }
1176 } 1201 }
1177 1202
1203 if (skb->tstamp == 0)
1204 skb->tstamp = ktime_get_real();
1178 trace_rxrpc_rx_packet(sp); 1205 trace_rxrpc_rx_packet(sp);
1179 1206
1180 _net("Rx RxRPC %s ep=%x call=%x:%x",
1181 sp->hdr.flags & RXRPC_CLIENT_INITIATED ? "ToServer" : "ToClient",
1182 sp->hdr.epoch, sp->hdr.cid, sp->hdr.callNumber);
1183
1184 if (sp->hdr.type >= RXRPC_N_PACKET_TYPES ||
1185 !((RXRPC_SUPPORTED_PACKET_TYPES >> sp->hdr.type) & 1)) {
1186 _proto("Rx Bad Packet Type %u", sp->hdr.type);
1187 goto bad_message;
1188 }
1189
1190 switch (sp->hdr.type) { 1207 switch (sp->hdr.type) {
1191 case RXRPC_PACKET_TYPE_VERSION: 1208 case RXRPC_PACKET_TYPE_VERSION:
1192 if (!(sp->hdr.flags & RXRPC_CLIENT_INITIATED)) 1209 if (rxrpc_to_client(sp))
1193 goto discard; 1210 goto discard;
1194 rxrpc_post_packet_to_local(local, skb); 1211 rxrpc_post_packet_to_local(local, skb);
1195 goto out; 1212 goto out;
1196 1213
1197 case RXRPC_PACKET_TYPE_BUSY: 1214 case RXRPC_PACKET_TYPE_BUSY:
1198 if (sp->hdr.flags & RXRPC_CLIENT_INITIATED) 1215 if (rxrpc_to_server(sp))
1199 goto discard; 1216 goto discard;
1200 /* Fall through */ 1217 /* Fall through */
1218 case RXRPC_PACKET_TYPE_ACK:
1219 case RXRPC_PACKET_TYPE_ACKALL:
1220 if (sp->hdr.callNumber == 0)
1221 goto bad_message;
1222 /* Fall through */
1223 case RXRPC_PACKET_TYPE_ABORT:
1224 break;
1201 1225
1202 case RXRPC_PACKET_TYPE_DATA: 1226 case RXRPC_PACKET_TYPE_DATA:
1203 if (sp->hdr.callNumber == 0) 1227 if (sp->hdr.callNumber == 0 ||
1228 sp->hdr.seq == 0)
1204 goto bad_message; 1229 goto bad_message;
1205 if (sp->hdr.flags & RXRPC_JUMBO_PACKET && 1230 if (sp->hdr.flags & RXRPC_JUMBO_PACKET &&
1206 !rxrpc_validate_jumbo(skb)) 1231 !rxrpc_validate_jumbo(skb))
1207 goto bad_message; 1232 goto bad_message;
1208 break; 1233 break;
1209 1234
1235 case RXRPC_PACKET_TYPE_CHALLENGE:
1236 if (rxrpc_to_server(sp))
1237 goto discard;
1238 break;
1239 case RXRPC_PACKET_TYPE_RESPONSE:
1240 if (rxrpc_to_client(sp))
1241 goto discard;
1242 break;
1243
1210 /* Packet types 9-11 should just be ignored. */ 1244 /* Packet types 9-11 should just be ignored. */
1211 case RXRPC_PACKET_TYPE_PARAMS: 1245 case RXRPC_PACKET_TYPE_PARAMS:
1212 case RXRPC_PACKET_TYPE_10: 1246 case RXRPC_PACKET_TYPE_10:
1213 case RXRPC_PACKET_TYPE_11: 1247 case RXRPC_PACKET_TYPE_11:
1214 goto discard; 1248 goto discard;
1249
1250 default:
1251 _proto("Rx Bad Packet Type %u", sp->hdr.type);
1252 goto bad_message;
1215 } 1253 }
1216 1254
1217 rcu_read_lock(); 1255 if (sp->hdr.serviceId == 0)
1256 goto bad_message;
1257
1258 if (rxrpc_to_server(sp)) {
1259 /* Weed out packets to services we're not offering. Packets
1260 * that would begin a call are explicitly rejected and the rest
1261 * are just discarded.
1262 */
1263 rx = rcu_dereference(local->service);
1264 if (!rx || (sp->hdr.serviceId != rx->srx.srx_service &&
1265 sp->hdr.serviceId != rx->second_service)) {
1266 if (sp->hdr.type == RXRPC_PACKET_TYPE_DATA &&
1267 sp->hdr.seq == 1)
1268 goto unsupported_service;
1269 goto discard;
1270 }
1271 }
1218 1272
1219 conn = rxrpc_find_connection_rcu(local, skb); 1273 conn = rxrpc_find_connection_rcu(local, skb, &peer);
1220 if (conn) { 1274 if (conn) {
1221 if (sp->hdr.securityIndex != conn->security_ix) 1275 if (sp->hdr.securityIndex != conn->security_ix)
1222 goto wrong_security; 1276 goto wrong_security;
1223 1277
1224 if (sp->hdr.serviceId != conn->service_id) { 1278 if (sp->hdr.serviceId != conn->service_id) {
1225 if (!test_bit(RXRPC_CONN_PROBING_FOR_UPGRADE, &conn->flags) || 1279 int old_id;
1226 conn->service_id != conn->params.service_id) 1280
1281 if (!test_bit(RXRPC_CONN_PROBING_FOR_UPGRADE, &conn->flags))
1282 goto reupgrade;
1283 old_id = cmpxchg(&conn->service_id, conn->params.service_id,
1284 sp->hdr.serviceId);
1285
1286 if (old_id != conn->params.service_id &&
1287 old_id != sp->hdr.serviceId)
1227 goto reupgrade; 1288 goto reupgrade;
1228 conn->service_id = sp->hdr.serviceId;
1229 } 1289 }
1230 1290
1231 if (sp->hdr.callNumber == 0) { 1291 if (sp->hdr.callNumber == 0) {
1232 /* Connection-level packet */ 1292 /* Connection-level packet */
1233 _debug("CONN %p {%d}", conn, conn->debug_id); 1293 _debug("CONN %p {%d}", conn, conn->debug_id);
1234 rxrpc_post_packet_to_conn(conn, skb); 1294 rxrpc_post_packet_to_conn(conn, skb);
1235 goto out_unlock; 1295 goto out;
1236 } 1296 }
1237 1297
1238 /* Note the serial number skew here */ 1298 /* Note the serial number skew here */
@@ -1251,19 +1311,19 @@ void rxrpc_data_ready(struct sock *udp_sk)
1251 1311
1252 /* Ignore really old calls */ 1312 /* Ignore really old calls */
1253 if (sp->hdr.callNumber < chan->last_call) 1313 if (sp->hdr.callNumber < chan->last_call)
1254 goto discard_unlock; 1314 goto discard;
1255 1315
1256 if (sp->hdr.callNumber == chan->last_call) { 1316 if (sp->hdr.callNumber == chan->last_call) {
1257 if (chan->call || 1317 if (chan->call ||
1258 sp->hdr.type == RXRPC_PACKET_TYPE_ABORT) 1318 sp->hdr.type == RXRPC_PACKET_TYPE_ABORT)
1259 goto discard_unlock; 1319 goto discard;
1260 1320
1261 /* For the previous service call, if completed 1321 /* For the previous service call, if completed
1262 * successfully, we discard all further packets. 1322 * successfully, we discard all further packets.
1263 */ 1323 */
1264 if (rxrpc_conn_is_service(conn) && 1324 if (rxrpc_conn_is_service(conn) &&
1265 chan->last_type == RXRPC_PACKET_TYPE_ACK) 1325 chan->last_type == RXRPC_PACKET_TYPE_ACK)
1266 goto discard_unlock; 1326 goto discard;
1267 1327
1268 /* But otherwise we need to retransmit the final packet 1328 /* But otherwise we need to retransmit the final packet
1269 * from data cached in the connection record. 1329 * from data cached in the connection record.
@@ -1274,18 +1334,16 @@ void rxrpc_data_ready(struct sock *udp_sk)
1274 sp->hdr.serial, 1334 sp->hdr.serial,
1275 sp->hdr.flags, 0); 1335 sp->hdr.flags, 0);
1276 rxrpc_post_packet_to_conn(conn, skb); 1336 rxrpc_post_packet_to_conn(conn, skb);
1277 goto out_unlock; 1337 goto out;
1278 } 1338 }
1279 1339
1280 call = rcu_dereference(chan->call); 1340 call = rcu_dereference(chan->call);
1281 1341
1282 if (sp->hdr.callNumber > chan->call_id) { 1342 if (sp->hdr.callNumber > chan->call_id) {
1283 if (!(sp->hdr.flags & RXRPC_CLIENT_INITIATED)) { 1343 if (rxrpc_to_client(sp))
1284 rcu_read_unlock();
1285 goto reject_packet; 1344 goto reject_packet;
1286 }
1287 if (call) 1345 if (call)
1288 rxrpc_input_implicit_end_call(conn, call); 1346 rxrpc_input_implicit_end_call(rx, conn, call);
1289 call = NULL; 1347 call = NULL;
1290 } 1348 }
1291 1349
@@ -1297,66 +1355,57 @@ void rxrpc_data_ready(struct sock *udp_sk)
1297 if (!test_bit(RXRPC_CALL_RX_HEARD, &call->flags)) 1355 if (!test_bit(RXRPC_CALL_RX_HEARD, &call->flags))
1298 set_bit(RXRPC_CALL_RX_HEARD, &call->flags); 1356 set_bit(RXRPC_CALL_RX_HEARD, &call->flags);
1299 } 1357 }
1300 } else {
1301 skew = 0;
1302 call = NULL;
1303 } 1358 }
1304 1359
1305 if (!call || atomic_read(&call->usage) == 0) { 1360 if (!call || atomic_read(&call->usage) == 0) {
1306 if (!(sp->hdr.type & RXRPC_CLIENT_INITIATED) || 1361 if (rxrpc_to_client(sp) ||
1307 sp->hdr.callNumber == 0 ||
1308 sp->hdr.type != RXRPC_PACKET_TYPE_DATA) 1362 sp->hdr.type != RXRPC_PACKET_TYPE_DATA)
1309 goto bad_message_unlock; 1363 goto bad_message;
1310 if (sp->hdr.seq != 1) 1364 if (sp->hdr.seq != 1)
1311 goto discard_unlock; 1365 goto discard;
1312 call = rxrpc_new_incoming_call(local, conn, skb); 1366 call = rxrpc_new_incoming_call(local, rx, skb);
1313 if (!call) { 1367 if (!call)
1314 rcu_read_unlock();
1315 goto reject_packet; 1368 goto reject_packet;
1316 }
1317 rxrpc_send_ping(call, skb, skew); 1369 rxrpc_send_ping(call, skb, skew);
1318 mutex_unlock(&call->user_mutex); 1370 mutex_unlock(&call->user_mutex);
1319 } 1371 }
1320 1372
1321 rxrpc_input_call_packet(call, skb, skew); 1373 rxrpc_input_call_packet(call, skb, skew);
1322 goto discard_unlock; 1374 goto discard;
1323 1375
1324discard_unlock:
1325 rcu_read_unlock();
1326discard: 1376discard:
1327 rxrpc_free_skb(skb, rxrpc_skb_rx_freed); 1377 rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
1328out: 1378out:
1329 trace_rxrpc_rx_done(0, 0); 1379 trace_rxrpc_rx_done(0, 0);
1330 return; 1380 return 0;
1331
1332out_unlock:
1333 rcu_read_unlock();
1334 goto out;
1335 1381
1336wrong_security: 1382wrong_security:
1337 rcu_read_unlock();
1338 trace_rxrpc_abort(0, "SEC", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq, 1383 trace_rxrpc_abort(0, "SEC", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq,
1339 RXKADINCONSISTENCY, EBADMSG); 1384 RXKADINCONSISTENCY, EBADMSG);
1340 skb->priority = RXKADINCONSISTENCY; 1385 skb->priority = RXKADINCONSISTENCY;
1341 goto post_abort; 1386 goto post_abort;
1342 1387
1388unsupported_service:
1389 trace_rxrpc_abort(0, "INV", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq,
1390 RX_INVALID_OPERATION, EOPNOTSUPP);
1391 skb->priority = RX_INVALID_OPERATION;
1392 goto post_abort;
1393
1343reupgrade: 1394reupgrade:
1344 rcu_read_unlock();
1345 trace_rxrpc_abort(0, "UPG", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq, 1395 trace_rxrpc_abort(0, "UPG", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq,
1346 RX_PROTOCOL_ERROR, EBADMSG); 1396 RX_PROTOCOL_ERROR, EBADMSG);
1347 goto protocol_error; 1397 goto protocol_error;
1348 1398
1349bad_message_unlock:
1350 rcu_read_unlock();
1351bad_message: 1399bad_message:
1352 trace_rxrpc_abort(0, "BAD", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq, 1400 trace_rxrpc_abort(0, "BAD", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq,
1353 RX_PROTOCOL_ERROR, EBADMSG); 1401 RX_PROTOCOL_ERROR, EBADMSG);
1354protocol_error: 1402protocol_error:
1355 skb->priority = RX_PROTOCOL_ERROR; 1403 skb->priority = RX_PROTOCOL_ERROR;
1356post_abort: 1404post_abort:
1357 skb->mark = RXRPC_SKB_MARK_LOCAL_ABORT; 1405 skb->mark = RXRPC_SKB_MARK_REJECT_ABORT;
1358reject_packet: 1406reject_packet:
1359 trace_rxrpc_rx_done(skb->mark, skb->priority); 1407 trace_rxrpc_rx_done(skb->mark, skb->priority);
1360 rxrpc_reject_packet(local, skb); 1408 rxrpc_reject_packet(local, skb);
1361 _leave(" [badmsg]"); 1409 _leave(" [badmsg]");
1410 return 0;
1362} 1411}
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index 777c3ed4cfc0..cad0691c2bb4 100644
--- a/net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -19,6 +19,7 @@
19#include <linux/ip.h> 19#include <linux/ip.h>
20#include <linux/hashtable.h> 20#include <linux/hashtable.h>
21#include <net/sock.h> 21#include <net/sock.h>
22#include <net/udp.h>
22#include <net/af_rxrpc.h> 23#include <net/af_rxrpc.h>
23#include "ar-internal.h" 24#include "ar-internal.h"
24 25
@@ -108,7 +109,7 @@ static struct rxrpc_local *rxrpc_alloc_local(struct rxrpc_net *rxnet,
108 */ 109 */
109static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net) 110static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
110{ 111{
111 struct sock *sock; 112 struct sock *usk;
112 int ret, opt; 113 int ret, opt;
113 114
114 _enter("%p{%d,%d}", 115 _enter("%p{%d,%d}",
@@ -122,6 +123,28 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
122 return ret; 123 return ret;
123 } 124 }
124 125
126 /* set the socket up */
127 usk = local->socket->sk;
128 inet_sk(usk)->mc_loop = 0;
129
130 /* Enable CHECKSUM_UNNECESSARY to CHECKSUM_COMPLETE conversion */
131 inet_inc_convert_csum(usk);
132
133 rcu_assign_sk_user_data(usk, local);
134
135 udp_sk(usk)->encap_type = UDP_ENCAP_RXRPC;
136 udp_sk(usk)->encap_rcv = rxrpc_input_packet;
137 udp_sk(usk)->encap_destroy = NULL;
138 udp_sk(usk)->gro_receive = NULL;
139 udp_sk(usk)->gro_complete = NULL;
140
141 udp_encap_enable();
142#if IS_ENABLED(CONFIG_IPV6)
143 if (local->srx.transport.family == AF_INET6)
144 udpv6_encap_enable();
145#endif
146 usk->sk_error_report = rxrpc_error_report;
147
125 /* if a local address was supplied then bind it */ 148 /* if a local address was supplied then bind it */
126 if (local->srx.transport_len > sizeof(sa_family_t)) { 149 if (local->srx.transport_len > sizeof(sa_family_t)) {
127 _debug("bind"); 150 _debug("bind");
@@ -135,10 +158,10 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
135 } 158 }
136 159
137 switch (local->srx.transport.family) { 160 switch (local->srx.transport.family) {
138 case AF_INET: 161 case AF_INET6:
139 /* we want to receive ICMP errors */ 162 /* we want to receive ICMPv6 errors */
140 opt = 1; 163 opt = 1;
141 ret = kernel_setsockopt(local->socket, SOL_IP, IP_RECVERR, 164 ret = kernel_setsockopt(local->socket, SOL_IPV6, IPV6_RECVERR,
142 (char *) &opt, sizeof(opt)); 165 (char *) &opt, sizeof(opt));
143 if (ret < 0) { 166 if (ret < 0) {
144 _debug("setsockopt failed"); 167 _debug("setsockopt failed");
@@ -146,19 +169,22 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
146 } 169 }
147 170
148 /* we want to set the don't fragment bit */ 171 /* we want to set the don't fragment bit */
149 opt = IP_PMTUDISC_DO; 172 opt = IPV6_PMTUDISC_DO;
150 ret = kernel_setsockopt(local->socket, SOL_IP, IP_MTU_DISCOVER, 173 ret = kernel_setsockopt(local->socket, SOL_IPV6, IPV6_MTU_DISCOVER,
151 (char *) &opt, sizeof(opt)); 174 (char *) &opt, sizeof(opt));
152 if (ret < 0) { 175 if (ret < 0) {
153 _debug("setsockopt failed"); 176 _debug("setsockopt failed");
154 goto error; 177 goto error;
155 } 178 }
156 break;
157 179
158 case AF_INET6: 180 /* Fall through and set IPv4 options too otherwise we don't get
181 * errors from IPv4 packets sent through the IPv6 socket.
182 */
183
184 case AF_INET:
159 /* we want to receive ICMP errors */ 185 /* we want to receive ICMP errors */
160 opt = 1; 186 opt = 1;
161 ret = kernel_setsockopt(local->socket, SOL_IPV6, IPV6_RECVERR, 187 ret = kernel_setsockopt(local->socket, SOL_IP, IP_RECVERR,
162 (char *) &opt, sizeof(opt)); 188 (char *) &opt, sizeof(opt));
163 if (ret < 0) { 189 if (ret < 0) {
164 _debug("setsockopt failed"); 190 _debug("setsockopt failed");
@@ -166,24 +192,28 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
166 } 192 }
167 193
168 /* we want to set the don't fragment bit */ 194 /* we want to set the don't fragment bit */
169 opt = IPV6_PMTUDISC_DO; 195 opt = IP_PMTUDISC_DO;
170 ret = kernel_setsockopt(local->socket, SOL_IPV6, IPV6_MTU_DISCOVER, 196 ret = kernel_setsockopt(local->socket, SOL_IP, IP_MTU_DISCOVER,
171 (char *) &opt, sizeof(opt)); 197 (char *) &opt, sizeof(opt));
172 if (ret < 0) { 198 if (ret < 0) {
173 _debug("setsockopt failed"); 199 _debug("setsockopt failed");
174 goto error; 200 goto error;
175 } 201 }
202
203 /* We want receive timestamps. */
204 opt = 1;
205 ret = kernel_setsockopt(local->socket, SOL_SOCKET, SO_TIMESTAMPNS,
206 (char *)&opt, sizeof(opt));
207 if (ret < 0) {
208 _debug("setsockopt failed");
209 goto error;
210 }
176 break; 211 break;
177 212
178 default: 213 default:
179 BUG(); 214 BUG();
180 } 215 }
181 216
182 /* set the socket up */
183 sock = local->socket->sk;
184 sock->sk_user_data = local;
185 sock->sk_data_ready = rxrpc_data_ready;
186 sock->sk_error_report = rxrpc_error_report;
187 _leave(" = 0"); 217 _leave(" = 0");
188 return 0; 218 return 0;
189 219
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index ccf5de160444..e8fb8922bca8 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -124,7 +124,6 @@ int rxrpc_send_ack_packet(struct rxrpc_call *call, bool ping,
124 struct kvec iov[2]; 124 struct kvec iov[2];
125 rxrpc_serial_t serial; 125 rxrpc_serial_t serial;
126 rxrpc_seq_t hard_ack, top; 126 rxrpc_seq_t hard_ack, top;
127 ktime_t now;
128 size_t len, n; 127 size_t len, n;
129 int ret; 128 int ret;
130 u8 reason; 129 u8 reason;
@@ -196,9 +195,7 @@ int rxrpc_send_ack_packet(struct rxrpc_call *call, bool ping,
196 /* We need to stick a time in before we send the packet in case 195 /* We need to stick a time in before we send the packet in case
197 * the reply gets back before kernel_sendmsg() completes - but 196 * the reply gets back before kernel_sendmsg() completes - but
198 * asking UDP to send the packet can take a relatively long 197 * asking UDP to send the packet can take a relatively long
199 * time, so we update the time after, on the assumption that 198 * time.
200 * the packet transmission is more likely to happen towards the
201 * end of the kernel_sendmsg() call.
202 */ 199 */
203 call->ping_time = ktime_get_real(); 200 call->ping_time = ktime_get_real();
204 set_bit(RXRPC_CALL_PINGING, &call->flags); 201 set_bit(RXRPC_CALL_PINGING, &call->flags);
@@ -206,9 +203,6 @@ int rxrpc_send_ack_packet(struct rxrpc_call *call, bool ping,
206 } 203 }
207 204
208 ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len); 205 ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len);
209 now = ktime_get_real();
210 if (ping)
211 call->ping_time = now;
212 conn->params.peer->last_tx_at = ktime_get_seconds(); 206 conn->params.peer->last_tx_at = ktime_get_seconds();
213 if (ret < 0) 207 if (ret < 0)
214 trace_rxrpc_tx_fail(call->debug_id, serial, ret, 208 trace_rxrpc_tx_fail(call->debug_id, serial, ret,
@@ -363,8 +357,14 @@ int rxrpc_send_data_packet(struct rxrpc_call *call, struct sk_buff *skb,
363 357
364 /* If our RTT cache needs working on, request an ACK. Also request 358 /* If our RTT cache needs working on, request an ACK. Also request
365 * ACKs if a DATA packet appears to have been lost. 359 * ACKs if a DATA packet appears to have been lost.
360 *
361 * However, we mustn't request an ACK on the last reply packet of a
362 * service call, lest OpenAFS incorrectly send us an ACK with some
363 * soft-ACKs in it and then never follow up with a proper hard ACK.
366 */ 364 */
367 if (!(sp->hdr.flags & RXRPC_LAST_PACKET) && 365 if ((!(sp->hdr.flags & RXRPC_LAST_PACKET) ||
366 rxrpc_to_server(sp)
367 ) &&
368 (test_and_clear_bit(RXRPC_CALL_EV_ACK_LOST, &call->events) || 368 (test_and_clear_bit(RXRPC_CALL_EV_ACK_LOST, &call->events) ||
369 retrans || 369 retrans ||
370 call->cong_mode == RXRPC_CALL_SLOW_START || 370 call->cong_mode == RXRPC_CALL_SLOW_START ||
@@ -390,6 +390,11 @@ int rxrpc_send_data_packet(struct rxrpc_call *call, struct sk_buff *skb,
390 goto send_fragmentable; 390 goto send_fragmentable;
391 391
392 down_read(&conn->params.local->defrag_sem); 392 down_read(&conn->params.local->defrag_sem);
393
394 sp->hdr.serial = serial;
395 smp_wmb(); /* Set serial before timestamp */
396 skb->tstamp = ktime_get_real();
397
393 /* send the packet by UDP 398 /* send the packet by UDP
394 * - returns -EMSGSIZE if UDP would have to fragment the packet 399 * - returns -EMSGSIZE if UDP would have to fragment the packet
395 * to go out of the interface 400 * to go out of the interface
@@ -413,12 +418,8 @@ done:
413 trace_rxrpc_tx_data(call, sp->hdr.seq, serial, whdr.flags, 418 trace_rxrpc_tx_data(call, sp->hdr.seq, serial, whdr.flags,
414 retrans, lost); 419 retrans, lost);
415 if (ret >= 0) { 420 if (ret >= 0) {
416 ktime_t now = ktime_get_real();
417 skb->tstamp = now;
418 smp_wmb();
419 sp->hdr.serial = serial;
420 if (whdr.flags & RXRPC_REQUEST_ACK) { 421 if (whdr.flags & RXRPC_REQUEST_ACK) {
421 call->peer->rtt_last_req = now; 422 call->peer->rtt_last_req = skb->tstamp;
422 trace_rxrpc_rtt_tx(call, rxrpc_rtt_tx_data, serial); 423 trace_rxrpc_rtt_tx(call, rxrpc_rtt_tx_data, serial);
423 if (call->peer->rtt_usage > 1) { 424 if (call->peer->rtt_usage > 1) {
424 unsigned long nowj = jiffies, ack_lost_at; 425 unsigned long nowj = jiffies, ack_lost_at;
@@ -457,6 +458,10 @@ send_fragmentable:
457 458
458 down_write(&conn->params.local->defrag_sem); 459 down_write(&conn->params.local->defrag_sem);
459 460
461 sp->hdr.serial = serial;
462 smp_wmb(); /* Set serial before timestamp */
463 skb->tstamp = ktime_get_real();
464
460 switch (conn->params.local->srx.transport.family) { 465 switch (conn->params.local->srx.transport.family) {
461 case AF_INET: 466 case AF_INET:
462 opt = IP_PMTUDISC_DONT; 467 opt = IP_PMTUDISC_DONT;
@@ -519,7 +524,7 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
519 struct kvec iov[2]; 524 struct kvec iov[2];
520 size_t size; 525 size_t size;
521 __be32 code; 526 __be32 code;
522 int ret; 527 int ret, ioc;
523 528
524 _enter("%d", local->debug_id); 529 _enter("%d", local->debug_id);
525 530
@@ -527,7 +532,6 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
527 iov[0].iov_len = sizeof(whdr); 532 iov[0].iov_len = sizeof(whdr);
528 iov[1].iov_base = &code; 533 iov[1].iov_base = &code;
529 iov[1].iov_len = sizeof(code); 534 iov[1].iov_len = sizeof(code);
530 size = sizeof(whdr) + sizeof(code);
531 535
532 msg.msg_name = &srx.transport; 536 msg.msg_name = &srx.transport;
533 msg.msg_control = NULL; 537 msg.msg_control = NULL;
@@ -535,17 +539,31 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
535 msg.msg_flags = 0; 539 msg.msg_flags = 0;
536 540
537 memset(&whdr, 0, sizeof(whdr)); 541 memset(&whdr, 0, sizeof(whdr));
538 whdr.type = RXRPC_PACKET_TYPE_ABORT;
539 542
540 while ((skb = skb_dequeue(&local->reject_queue))) { 543 while ((skb = skb_dequeue(&local->reject_queue))) {
541 rxrpc_see_skb(skb, rxrpc_skb_rx_seen); 544 rxrpc_see_skb(skb, rxrpc_skb_rx_seen);
542 sp = rxrpc_skb(skb); 545 sp = rxrpc_skb(skb);
543 546
547 switch (skb->mark) {
548 case RXRPC_SKB_MARK_REJECT_BUSY:
549 whdr.type = RXRPC_PACKET_TYPE_BUSY;
550 size = sizeof(whdr);
551 ioc = 1;
552 break;
553 case RXRPC_SKB_MARK_REJECT_ABORT:
554 whdr.type = RXRPC_PACKET_TYPE_ABORT;
555 code = htonl(skb->priority);
556 size = sizeof(whdr) + sizeof(code);
557 ioc = 2;
558 break;
559 default:
560 rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
561 continue;
562 }
563
544 if (rxrpc_extract_addr_from_skb(local, &srx, skb) == 0) { 564 if (rxrpc_extract_addr_from_skb(local, &srx, skb) == 0) {
545 msg.msg_namelen = srx.transport_len; 565 msg.msg_namelen = srx.transport_len;
546 566
547 code = htonl(skb->priority);
548
549 whdr.epoch = htonl(sp->hdr.epoch); 567 whdr.epoch = htonl(sp->hdr.epoch);
550 whdr.cid = htonl(sp->hdr.cid); 568 whdr.cid = htonl(sp->hdr.cid);
551 whdr.callNumber = htonl(sp->hdr.callNumber); 569 whdr.callNumber = htonl(sp->hdr.callNumber);
diff --git a/net/rxrpc/peer_event.c b/net/rxrpc/peer_event.c
index 4f9da2f51c69..05b51bdbdd41 100644
--- a/net/rxrpc/peer_event.c
+++ b/net/rxrpc/peer_event.c
@@ -23,6 +23,8 @@
23#include "ar-internal.h" 23#include "ar-internal.h"
24 24
25static void rxrpc_store_error(struct rxrpc_peer *, struct sock_exterr_skb *); 25static void rxrpc_store_error(struct rxrpc_peer *, struct sock_exterr_skb *);
26static void rxrpc_distribute_error(struct rxrpc_peer *, int,
27 enum rxrpc_call_completion);
26 28
27/* 29/*
28 * Find the peer associated with an ICMP packet. 30 * Find the peer associated with an ICMP packet.
@@ -194,8 +196,6 @@ void rxrpc_error_report(struct sock *sk)
194 rcu_read_unlock(); 196 rcu_read_unlock();
195 rxrpc_free_skb(skb, rxrpc_skb_rx_freed); 197 rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
196 198
197 /* The ref we obtained is passed off to the work item */
198 __rxrpc_queue_peer_error(peer);
199 _leave(""); 199 _leave("");
200} 200}
201 201
@@ -205,6 +205,7 @@ void rxrpc_error_report(struct sock *sk)
205static void rxrpc_store_error(struct rxrpc_peer *peer, 205static void rxrpc_store_error(struct rxrpc_peer *peer,
206 struct sock_exterr_skb *serr) 206 struct sock_exterr_skb *serr)
207{ 207{
208 enum rxrpc_call_completion compl = RXRPC_CALL_NETWORK_ERROR;
208 struct sock_extended_err *ee; 209 struct sock_extended_err *ee;
209 int err; 210 int err;
210 211
@@ -255,7 +256,7 @@ static void rxrpc_store_error(struct rxrpc_peer *peer,
255 case SO_EE_ORIGIN_NONE: 256 case SO_EE_ORIGIN_NONE:
256 case SO_EE_ORIGIN_LOCAL: 257 case SO_EE_ORIGIN_LOCAL:
257 _proto("Rx Received local error { error=%d }", err); 258 _proto("Rx Received local error { error=%d }", err);
258 err += RXRPC_LOCAL_ERROR_OFFSET; 259 compl = RXRPC_CALL_LOCAL_ERROR;
259 break; 260 break;
260 261
261 case SO_EE_ORIGIN_ICMP6: 262 case SO_EE_ORIGIN_ICMP6:
@@ -264,48 +265,23 @@ static void rxrpc_store_error(struct rxrpc_peer *peer,
264 break; 265 break;
265 } 266 }
266 267
267 peer->error_report = err; 268 rxrpc_distribute_error(peer, err, compl);
268} 269}
269 270
270/* 271/*
271 * Distribute an error that occurred on a peer 272 * Distribute an error that occurred on a peer.
272 */ 273 */
273void rxrpc_peer_error_distributor(struct work_struct *work) 274static void rxrpc_distribute_error(struct rxrpc_peer *peer, int error,
275 enum rxrpc_call_completion compl)
274{ 276{
275 struct rxrpc_peer *peer =
276 container_of(work, struct rxrpc_peer, error_distributor);
277 struct rxrpc_call *call; 277 struct rxrpc_call *call;
278 enum rxrpc_call_completion compl;
279 int error;
280
281 _enter("");
282
283 error = READ_ONCE(peer->error_report);
284 if (error < RXRPC_LOCAL_ERROR_OFFSET) {
285 compl = RXRPC_CALL_NETWORK_ERROR;
286 } else {
287 compl = RXRPC_CALL_LOCAL_ERROR;
288 error -= RXRPC_LOCAL_ERROR_OFFSET;
289 }
290
291 _debug("ISSUE ERROR %s %d", rxrpc_call_completions[compl], error);
292 278
293 spin_lock_bh(&peer->lock); 279 hlist_for_each_entry_rcu(call, &peer->error_targets, error_link) {
294
295 while (!hlist_empty(&peer->error_targets)) {
296 call = hlist_entry(peer->error_targets.first,
297 struct rxrpc_call, error_link);
298 hlist_del_init(&call->error_link);
299 rxrpc_see_call(call); 280 rxrpc_see_call(call);
300 281 if (call->state < RXRPC_CALL_COMPLETE &&
301 if (rxrpc_set_call_completion(call, compl, 0, -error)) 282 rxrpc_set_call_completion(call, compl, 0, -error))
302 rxrpc_notify_socket(call); 283 rxrpc_notify_socket(call);
303 } 284 }
304
305 spin_unlock_bh(&peer->lock);
306
307 rxrpc_put_peer(peer);
308 _leave("");
309} 285}
310 286
311/* 287/*
@@ -325,6 +301,8 @@ void rxrpc_peer_add_rtt(struct rxrpc_call *call, enum rxrpc_rtt_rx_trace why,
325 if (rtt < 0) 301 if (rtt < 0)
326 return; 302 return;
327 303
304 spin_lock(&peer->rtt_input_lock);
305
328 /* Replace the oldest datum in the RTT buffer */ 306 /* Replace the oldest datum in the RTT buffer */
329 sum -= peer->rtt_cache[cursor]; 307 sum -= peer->rtt_cache[cursor];
330 sum += rtt; 308 sum += rtt;
@@ -336,6 +314,8 @@ void rxrpc_peer_add_rtt(struct rxrpc_call *call, enum rxrpc_rtt_rx_trace why,
336 peer->rtt_usage = usage; 314 peer->rtt_usage = usage;
337 } 315 }
338 316
317 spin_unlock(&peer->rtt_input_lock);
318
339 /* Now recalculate the average */ 319 /* Now recalculate the average */
340 if (usage == RXRPC_RTT_CACHE_SIZE) { 320 if (usage == RXRPC_RTT_CACHE_SIZE) {
341 avg = sum / RXRPC_RTT_CACHE_SIZE; 321 avg = sum / RXRPC_RTT_CACHE_SIZE;
@@ -344,6 +324,7 @@ void rxrpc_peer_add_rtt(struct rxrpc_call *call, enum rxrpc_rtt_rx_trace why,
344 do_div(avg, usage); 324 do_div(avg, usage);
345 } 325 }
346 326
327 /* Don't need to update this under lock */
347 peer->rtt = avg; 328 peer->rtt = avg;
348 trace_rxrpc_rtt_rx(call, why, send_serial, resp_serial, rtt, 329 trace_rxrpc_rtt_rx(call, why, send_serial, resp_serial, rtt,
349 usage, avg); 330 usage, avg);
diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c
index 1dc7648e3eff..5691b7d266ca 100644
--- a/net/rxrpc/peer_object.c
+++ b/net/rxrpc/peer_object.c
@@ -124,11 +124,9 @@ static struct rxrpc_peer *__rxrpc_lookup_peer_rcu(
124 struct rxrpc_net *rxnet = local->rxnet; 124 struct rxrpc_net *rxnet = local->rxnet;
125 125
126 hash_for_each_possible_rcu(rxnet->peer_hash, peer, hash_link, hash_key) { 126 hash_for_each_possible_rcu(rxnet->peer_hash, peer, hash_link, hash_key) {
127 if (rxrpc_peer_cmp_key(peer, local, srx, hash_key) == 0) { 127 if (rxrpc_peer_cmp_key(peer, local, srx, hash_key) == 0 &&
128 if (atomic_read(&peer->usage) == 0) 128 atomic_read(&peer->usage) > 0)
129 return NULL;
130 return peer; 129 return peer;
131 }
132 } 130 }
133 131
134 return NULL; 132 return NULL;
@@ -155,8 +153,10 @@ struct rxrpc_peer *rxrpc_lookup_peer_rcu(struct rxrpc_local *local,
155 * assess the MTU size for the network interface through which this peer is 153 * assess the MTU size for the network interface through which this peer is
156 * reached 154 * reached
157 */ 155 */
158static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer) 156static void rxrpc_assess_MTU_size(struct rxrpc_sock *rx,
157 struct rxrpc_peer *peer)
159{ 158{
159 struct net *net = sock_net(&rx->sk);
160 struct dst_entry *dst; 160 struct dst_entry *dst;
161 struct rtable *rt; 161 struct rtable *rt;
162 struct flowi fl; 162 struct flowi fl;
@@ -171,7 +171,7 @@ static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer)
171 switch (peer->srx.transport.family) { 171 switch (peer->srx.transport.family) {
172 case AF_INET: 172 case AF_INET:
173 rt = ip_route_output_ports( 173 rt = ip_route_output_ports(
174 &init_net, fl4, NULL, 174 net, fl4, NULL,
175 peer->srx.transport.sin.sin_addr.s_addr, 0, 175 peer->srx.transport.sin.sin_addr.s_addr, 0,
176 htons(7000), htons(7001), IPPROTO_UDP, 0, 0); 176 htons(7000), htons(7001), IPPROTO_UDP, 0, 0);
177 if (IS_ERR(rt)) { 177 if (IS_ERR(rt)) {
@@ -190,7 +190,7 @@ static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer)
190 sizeof(struct in6_addr)); 190 sizeof(struct in6_addr));
191 fl6->fl6_dport = htons(7001); 191 fl6->fl6_dport = htons(7001);
192 fl6->fl6_sport = htons(7000); 192 fl6->fl6_sport = htons(7000);
193 dst = ip6_route_output(&init_net, NULL, fl6); 193 dst = ip6_route_output(net, NULL, fl6);
194 if (dst->error) { 194 if (dst->error) {
195 _leave(" [route err %d]", dst->error); 195 _leave(" [route err %d]", dst->error);
196 return; 196 return;
@@ -222,11 +222,10 @@ struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *local, gfp_t gfp)
222 atomic_set(&peer->usage, 1); 222 atomic_set(&peer->usage, 1);
223 peer->local = local; 223 peer->local = local;
224 INIT_HLIST_HEAD(&peer->error_targets); 224 INIT_HLIST_HEAD(&peer->error_targets);
225 INIT_WORK(&peer->error_distributor,
226 &rxrpc_peer_error_distributor);
227 peer->service_conns = RB_ROOT; 225 peer->service_conns = RB_ROOT;
228 seqlock_init(&peer->service_conn_lock); 226 seqlock_init(&peer->service_conn_lock);
229 spin_lock_init(&peer->lock); 227 spin_lock_init(&peer->lock);
228 spin_lock_init(&peer->rtt_input_lock);
230 peer->debug_id = atomic_inc_return(&rxrpc_debug_id); 229 peer->debug_id = atomic_inc_return(&rxrpc_debug_id);
231 230
232 if (RXRPC_TX_SMSS > 2190) 231 if (RXRPC_TX_SMSS > 2190)
@@ -244,10 +243,11 @@ struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *local, gfp_t gfp)
244/* 243/*
245 * Initialise peer record. 244 * Initialise peer record.
246 */ 245 */
247static void rxrpc_init_peer(struct rxrpc_peer *peer, unsigned long hash_key) 246static void rxrpc_init_peer(struct rxrpc_sock *rx, struct rxrpc_peer *peer,
247 unsigned long hash_key)
248{ 248{
249 peer->hash_key = hash_key; 249 peer->hash_key = hash_key;
250 rxrpc_assess_MTU_size(peer); 250 rxrpc_assess_MTU_size(rx, peer);
251 peer->mtu = peer->if_mtu; 251 peer->mtu = peer->if_mtu;
252 peer->rtt_last_req = ktime_get_real(); 252 peer->rtt_last_req = ktime_get_real();
253 253
@@ -279,7 +279,8 @@ static void rxrpc_init_peer(struct rxrpc_peer *peer, unsigned long hash_key)
279/* 279/*
280 * Set up a new peer. 280 * Set up a new peer.
281 */ 281 */
282static struct rxrpc_peer *rxrpc_create_peer(struct rxrpc_local *local, 282static struct rxrpc_peer *rxrpc_create_peer(struct rxrpc_sock *rx,
283 struct rxrpc_local *local,
283 struct sockaddr_rxrpc *srx, 284 struct sockaddr_rxrpc *srx,
284 unsigned long hash_key, 285 unsigned long hash_key,
285 gfp_t gfp) 286 gfp_t gfp)
@@ -291,7 +292,7 @@ static struct rxrpc_peer *rxrpc_create_peer(struct rxrpc_local *local,
291 peer = rxrpc_alloc_peer(local, gfp); 292 peer = rxrpc_alloc_peer(local, gfp);
292 if (peer) { 293 if (peer) {
293 memcpy(&peer->srx, srx, sizeof(*srx)); 294 memcpy(&peer->srx, srx, sizeof(*srx));
294 rxrpc_init_peer(peer, hash_key); 295 rxrpc_init_peer(rx, peer, hash_key);
295 } 296 }
296 297
297 _leave(" = %p", peer); 298 _leave(" = %p", peer);
@@ -299,40 +300,31 @@ static struct rxrpc_peer *rxrpc_create_peer(struct rxrpc_local *local,
299} 300}
300 301
301/* 302/*
302 * Set up a new incoming peer. The address is prestored in the preallocated 303 * Set up a new incoming peer. There shouldn't be any other matching peers
303 * peer. 304 * since we've already done a search in the list from the non-reentrant context
305 * (the data_ready handler) that is the only place we can add new peers.
304 */ 306 */
305struct rxrpc_peer *rxrpc_lookup_incoming_peer(struct rxrpc_local *local, 307void rxrpc_new_incoming_peer(struct rxrpc_sock *rx, struct rxrpc_local *local,
306 struct rxrpc_peer *prealloc) 308 struct rxrpc_peer *peer)
307{ 309{
308 struct rxrpc_peer *peer;
309 struct rxrpc_net *rxnet = local->rxnet; 310 struct rxrpc_net *rxnet = local->rxnet;
310 unsigned long hash_key; 311 unsigned long hash_key;
311 312
312 hash_key = rxrpc_peer_hash_key(local, &prealloc->srx); 313 hash_key = rxrpc_peer_hash_key(local, &peer->srx);
313 prealloc->local = local; 314 peer->local = local;
314 rxrpc_init_peer(prealloc, hash_key); 315 rxrpc_init_peer(rx, peer, hash_key);
315 316
316 spin_lock(&rxnet->peer_hash_lock); 317 spin_lock(&rxnet->peer_hash_lock);
317 318 hash_add_rcu(rxnet->peer_hash, &peer->hash_link, hash_key);
318 /* Need to check that we aren't racing with someone else */ 319 list_add_tail(&peer->keepalive_link, &rxnet->peer_keepalive_new);
319 peer = __rxrpc_lookup_peer_rcu(local, &prealloc->srx, hash_key);
320 if (peer && !rxrpc_get_peer_maybe(peer))
321 peer = NULL;
322 if (!peer) {
323 peer = prealloc;
324 hash_add_rcu(rxnet->peer_hash, &peer->hash_link, hash_key);
325 list_add_tail(&peer->keepalive_link, &rxnet->peer_keepalive_new);
326 }
327
328 spin_unlock(&rxnet->peer_hash_lock); 320 spin_unlock(&rxnet->peer_hash_lock);
329 return peer;
330} 321}
331 322
332/* 323/*
333 * obtain a remote transport endpoint for the specified address 324 * obtain a remote transport endpoint for the specified address
334 */ 325 */
335struct rxrpc_peer *rxrpc_lookup_peer(struct rxrpc_local *local, 326struct rxrpc_peer *rxrpc_lookup_peer(struct rxrpc_sock *rx,
327 struct rxrpc_local *local,
336 struct sockaddr_rxrpc *srx, gfp_t gfp) 328 struct sockaddr_rxrpc *srx, gfp_t gfp)
337{ 329{
338 struct rxrpc_peer *peer, *candidate; 330 struct rxrpc_peer *peer, *candidate;
@@ -352,7 +344,7 @@ struct rxrpc_peer *rxrpc_lookup_peer(struct rxrpc_local *local,
352 /* The peer is not yet present in hash - create a candidate 344 /* The peer is not yet present in hash - create a candidate
353 * for a new record and then redo the search. 345 * for a new record and then redo the search.
354 */ 346 */
355 candidate = rxrpc_create_peer(local, srx, hash_key, gfp); 347 candidate = rxrpc_create_peer(rx, local, srx, hash_key, gfp);
356 if (!candidate) { 348 if (!candidate) {
357 _leave(" = NULL [nomem]"); 349 _leave(" = NULL [nomem]");
358 return NULL; 350 return NULL;
@@ -416,21 +408,6 @@ struct rxrpc_peer *rxrpc_get_peer_maybe(struct rxrpc_peer *peer)
416} 408}
417 409
418/* 410/*
419 * Queue a peer record. This passes the caller's ref to the workqueue.
420 */
421void __rxrpc_queue_peer_error(struct rxrpc_peer *peer)
422{
423 const void *here = __builtin_return_address(0);
424 int n;
425
426 n = atomic_read(&peer->usage);
427 if (rxrpc_queue_work(&peer->error_distributor))
428 trace_rxrpc_peer(peer, rxrpc_peer_queued_error, n, here);
429 else
430 rxrpc_put_peer(peer);
431}
432
433/*
434 * Discard a peer record. 411 * Discard a peer record.
435 */ 412 */
436static void __rxrpc_put_peer(struct rxrpc_peer *peer) 413static void __rxrpc_put_peer(struct rxrpc_peer *peer)
diff --git a/net/rxrpc/protocol.h b/net/rxrpc/protocol.h
index 93da73bf7098..f9cb83c938f3 100644
--- a/net/rxrpc/protocol.h
+++ b/net/rxrpc/protocol.h
@@ -50,7 +50,6 @@ struct rxrpc_wire_header {
50#define RXRPC_PACKET_TYPE_10 10 /* Ignored */ 50#define RXRPC_PACKET_TYPE_10 10 /* Ignored */
51#define RXRPC_PACKET_TYPE_11 11 /* Ignored */ 51#define RXRPC_PACKET_TYPE_11 11 /* Ignored */
52#define RXRPC_PACKET_TYPE_VERSION 13 /* version string request */ 52#define RXRPC_PACKET_TYPE_VERSION 13 /* version string request */
53#define RXRPC_N_PACKET_TYPES 14 /* number of packet types (incl type 0) */
54 53
55 uint8_t flags; /* packet flags */ 54 uint8_t flags; /* packet flags */
56#define RXRPC_CLIENT_INITIATED 0x01 /* signifies a packet generated by a client */ 55#define RXRPC_CLIENT_INITIATED 0x01 /* signifies a packet generated by a client */
@@ -72,20 +71,6 @@ struct rxrpc_wire_header {
72 71
73} __packed; 72} __packed;
74 73
75#define RXRPC_SUPPORTED_PACKET_TYPES ( \
76 (1 << RXRPC_PACKET_TYPE_DATA) | \
77 (1 << RXRPC_PACKET_TYPE_ACK) | \
78 (1 << RXRPC_PACKET_TYPE_BUSY) | \
79 (1 << RXRPC_PACKET_TYPE_ABORT) | \
80 (1 << RXRPC_PACKET_TYPE_ACKALL) | \
81 (1 << RXRPC_PACKET_TYPE_CHALLENGE) | \
82 (1 << RXRPC_PACKET_TYPE_RESPONSE) | \
83 /*(1 << RXRPC_PACKET_TYPE_DEBUG) | */ \
84 (1 << RXRPC_PACKET_TYPE_PARAMS) | \
85 (1 << RXRPC_PACKET_TYPE_10) | \
86 (1 << RXRPC_PACKET_TYPE_11) | \
87 (1 << RXRPC_PACKET_TYPE_VERSION))
88
89/*****************************************************************************/ 74/*****************************************************************************/
90/* 75/*
91 * jumbo packet secondary header 76 * jumbo packet secondary header
diff --git a/net/sched/act_ipt.c b/net/sched/act_ipt.c
index 23273b5303fd..8525de811616 100644
--- a/net/sched/act_ipt.c
+++ b/net/sched/act_ipt.c
@@ -135,7 +135,7 @@ static int __tcf_ipt_init(struct net *net, unsigned int id, struct nlattr *nla,
135 } 135 }
136 136
137 td = (struct xt_entry_target *)nla_data(tb[TCA_IPT_TARG]); 137 td = (struct xt_entry_target *)nla_data(tb[TCA_IPT_TARG]);
138 if (nla_len(tb[TCA_IPT_TARG]) < td->u.target_size) { 138 if (nla_len(tb[TCA_IPT_TARG]) != td->u.target_size) {
139 if (exists) 139 if (exists)
140 tcf_idr_release(*a, bind); 140 tcf_idr_release(*a, bind);
141 else 141 else
diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
index 44e9c00657bc..6b67aa13d2dd 100644
--- a/net/sched/act_sample.c
+++ b/net/sched/act_sample.c
@@ -69,7 +69,7 @@ static int tcf_sample_init(struct net *net, struct nlattr *nla,
69 69
70 if (!exists) { 70 if (!exists) {
71 ret = tcf_idr_create(tn, parm->index, est, a, 71 ret = tcf_idr_create(tn, parm->index, est, a,
72 &act_sample_ops, bind, false); 72 &act_sample_ops, bind, true);
73 if (ret) { 73 if (ret) {
74 tcf_idr_cleanup(tn, parm->index); 74 tcf_idr_cleanup(tn, parm->index);
75 return ret; 75 return ret;
diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c
index 420759153d5f..681f6f04e7da 100644
--- a/net/sched/act_tunnel_key.c
+++ b/net/sched/act_tunnel_key.c
@@ -317,7 +317,7 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
317 &metadata->u.tun_info, 317 &metadata->u.tun_info,
318 opts_len, extack); 318 opts_len, extack);
319 if (ret < 0) 319 if (ret < 0)
320 goto err_out; 320 goto release_tun_meta;
321 } 321 }
322 322
323 metadata->u.tun_info.mode |= IP_TUNNEL_INFO_TX; 323 metadata->u.tun_info.mode |= IP_TUNNEL_INFO_TX;
@@ -333,23 +333,24 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
333 &act_tunnel_key_ops, bind, true); 333 &act_tunnel_key_ops, bind, true);
334 if (ret) { 334 if (ret) {
335 NL_SET_ERR_MSG(extack, "Cannot create TC IDR"); 335 NL_SET_ERR_MSG(extack, "Cannot create TC IDR");
336 goto err_out; 336 goto release_tun_meta;
337 } 337 }
338 338
339 ret = ACT_P_CREATED; 339 ret = ACT_P_CREATED;
340 } else if (!ovr) { 340 } else if (!ovr) {
341 tcf_idr_release(*a, bind);
342 NL_SET_ERR_MSG(extack, "TC IDR already exists"); 341 NL_SET_ERR_MSG(extack, "TC IDR already exists");
343 return -EEXIST; 342 ret = -EEXIST;
343 goto release_tun_meta;
344 } 344 }
345 345
346 t = to_tunnel_key(*a); 346 t = to_tunnel_key(*a);
347 347
348 params_new = kzalloc(sizeof(*params_new), GFP_KERNEL); 348 params_new = kzalloc(sizeof(*params_new), GFP_KERNEL);
349 if (unlikely(!params_new)) { 349 if (unlikely(!params_new)) {
350 tcf_idr_release(*a, bind);
351 NL_SET_ERR_MSG(extack, "Cannot allocate tunnel key parameters"); 350 NL_SET_ERR_MSG(extack, "Cannot allocate tunnel key parameters");
352 return -ENOMEM; 351 ret = -ENOMEM;
352 exists = true;
353 goto release_tun_meta;
353 } 354 }
354 params_new->tcft_action = parm->t_action; 355 params_new->tcft_action = parm->t_action;
355 params_new->tcft_enc_metadata = metadata; 356 params_new->tcft_enc_metadata = metadata;
@@ -367,6 +368,9 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
367 368
368 return ret; 369 return ret;
369 370
371release_tun_meta:
372 dst_release(&metadata->dst);
373
370err_out: 374err_out:
371 if (exists) 375 if (exists)
372 tcf_idr_release(*a, bind); 376 tcf_idr_release(*a, bind);
@@ -408,8 +412,10 @@ static int tunnel_key_geneve_opts_dump(struct sk_buff *skb,
408 nla_put_u8(skb, TCA_TUNNEL_KEY_ENC_OPT_GENEVE_TYPE, 412 nla_put_u8(skb, TCA_TUNNEL_KEY_ENC_OPT_GENEVE_TYPE,
409 opt->type) || 413 opt->type) ||
410 nla_put(skb, TCA_TUNNEL_KEY_ENC_OPT_GENEVE_DATA, 414 nla_put(skb, TCA_TUNNEL_KEY_ENC_OPT_GENEVE_DATA,
411 opt->length * 4, opt + 1)) 415 opt->length * 4, opt + 1)) {
416 nla_nest_cancel(skb, start);
412 return -EMSGSIZE; 417 return -EMSGSIZE;
418 }
413 419
414 len -= sizeof(struct geneve_opt) + opt->length * 4; 420 len -= sizeof(struct geneve_opt) + opt->length * 4;
415 src += sizeof(struct geneve_opt) + opt->length * 4; 421 src += sizeof(struct geneve_opt) + opt->length * 4;
@@ -423,7 +429,7 @@ static int tunnel_key_opts_dump(struct sk_buff *skb,
423 const struct ip_tunnel_info *info) 429 const struct ip_tunnel_info *info)
424{ 430{
425 struct nlattr *start; 431 struct nlattr *start;
426 int err; 432 int err = -EINVAL;
427 433
428 if (!info->options_len) 434 if (!info->options_len)
429 return 0; 435 return 0;
@@ -435,9 +441,11 @@ static int tunnel_key_opts_dump(struct sk_buff *skb,
435 if (info->key.tun_flags & TUNNEL_GENEVE_OPT) { 441 if (info->key.tun_flags & TUNNEL_GENEVE_OPT) {
436 err = tunnel_key_geneve_opts_dump(skb, info); 442 err = tunnel_key_geneve_opts_dump(skb, info);
437 if (err) 443 if (err)
438 return err; 444 goto err_out;
439 } else { 445 } else {
440 return -EINVAL; 446err_out:
447 nla_nest_cancel(skb, start);
448 return err;
441 } 449 }
442 450
443 nla_nest_end(skb, start); 451 nla_nest_end(skb, start);
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 1a67af8a6e8c..0a75cb2e5e7b 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -1902,6 +1902,8 @@ replay:
1902 RTM_NEWCHAIN, false); 1902 RTM_NEWCHAIN, false);
1903 break; 1903 break;
1904 case RTM_DELCHAIN: 1904 case RTM_DELCHAIN:
1905 tfilter_notify_chain(net, skb, block, q, parent, n,
1906 chain, RTM_DELTFILTER);
1905 /* Flush the chain first as the user requested chain removal. */ 1907 /* Flush the chain first as the user requested chain removal. */
1906 tcf_chain_flush(chain); 1908 tcf_chain_flush(chain);
1907 /* In case the chain was successfully deleted, put a reference 1909 /* In case the chain was successfully deleted, put a reference
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index f218ccf1e2d9..b2c3406a2cf2 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -398,6 +398,7 @@ static int u32_init(struct tcf_proto *tp)
398 rcu_assign_pointer(tp_c->hlist, root_ht); 398 rcu_assign_pointer(tp_c->hlist, root_ht);
399 root_ht->tp_c = tp_c; 399 root_ht->tp_c = tp_c;
400 400
401 root_ht->refcnt++;
401 rcu_assign_pointer(tp->root, root_ht); 402 rcu_assign_pointer(tp->root, root_ht);
402 tp->data = tp_c; 403 tp->data = tp_c;
403 return 0; 404 return 0;
@@ -610,7 +611,7 @@ static int u32_destroy_hnode(struct tcf_proto *tp, struct tc_u_hnode *ht,
610 struct tc_u_hnode __rcu **hn; 611 struct tc_u_hnode __rcu **hn;
611 struct tc_u_hnode *phn; 612 struct tc_u_hnode *phn;
612 613
613 WARN_ON(ht->refcnt); 614 WARN_ON(--ht->refcnt);
614 615
615 u32_clear_hnode(tp, ht, extack); 616 u32_clear_hnode(tp, ht, extack);
616 617
@@ -649,7 +650,7 @@ static void u32_destroy(struct tcf_proto *tp, struct netlink_ext_ack *extack)
649 650
650 WARN_ON(root_ht == NULL); 651 WARN_ON(root_ht == NULL);
651 652
652 if (root_ht && --root_ht->refcnt == 0) 653 if (root_ht && --root_ht->refcnt == 1)
653 u32_destroy_hnode(tp, root_ht, extack); 654 u32_destroy_hnode(tp, root_ht, extack);
654 655
655 if (--tp_c->refcnt == 0) { 656 if (--tp_c->refcnt == 0) {
@@ -698,7 +699,6 @@ static int u32_delete(struct tcf_proto *tp, void *arg, bool *last,
698 } 699 }
699 700
700 if (ht->refcnt == 1) { 701 if (ht->refcnt == 1) {
701 ht->refcnt--;
702 u32_destroy_hnode(tp, ht, extack); 702 u32_destroy_hnode(tp, ht, extack);
703 } else { 703 } else {
704 NL_SET_ERR_MSG_MOD(extack, "Can not delete in-use filter"); 704 NL_SET_ERR_MSG_MOD(extack, "Can not delete in-use filter");
@@ -708,11 +708,11 @@ static int u32_delete(struct tcf_proto *tp, void *arg, bool *last,
708out: 708out:
709 *last = true; 709 *last = true;
710 if (root_ht) { 710 if (root_ht) {
711 if (root_ht->refcnt > 1) { 711 if (root_ht->refcnt > 2) {
712 *last = false; 712 *last = false;
713 goto ret; 713 goto ret;
714 } 714 }
715 if (root_ht->refcnt == 1) { 715 if (root_ht->refcnt == 2) {
716 if (!ht_empty(root_ht)) { 716 if (!ht_empty(root_ht)) {
717 *last = false; 717 *last = false;
718 goto ret; 718 goto ret;
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 98541c6399db..85e73f48e48f 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1311,6 +1311,18 @@ check_loop_fn(struct Qdisc *q, unsigned long cl, struct qdisc_walker *w)
1311 * Delete/get qdisc. 1311 * Delete/get qdisc.
1312 */ 1312 */
1313 1313
1314const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = {
1315 [TCA_KIND] = { .type = NLA_STRING },
1316 [TCA_OPTIONS] = { .type = NLA_NESTED },
1317 [TCA_RATE] = { .type = NLA_BINARY,
1318 .len = sizeof(struct tc_estimator) },
1319 [TCA_STAB] = { .type = NLA_NESTED },
1320 [TCA_DUMP_INVISIBLE] = { .type = NLA_FLAG },
1321 [TCA_CHAIN] = { .type = NLA_U32 },
1322 [TCA_INGRESS_BLOCK] = { .type = NLA_U32 },
1323 [TCA_EGRESS_BLOCK] = { .type = NLA_U32 },
1324};
1325
1314static int tc_get_qdisc(struct sk_buff *skb, struct nlmsghdr *n, 1326static int tc_get_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
1315 struct netlink_ext_ack *extack) 1327 struct netlink_ext_ack *extack)
1316{ 1328{
@@ -1327,7 +1339,8 @@ static int tc_get_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
1327 !netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) 1339 !netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN))
1328 return -EPERM; 1340 return -EPERM;
1329 1341
1330 err = nlmsg_parse(n, sizeof(*tcm), tca, TCA_MAX, NULL, extack); 1342 err = nlmsg_parse(n, sizeof(*tcm), tca, TCA_MAX, rtm_tca_policy,
1343 extack);
1331 if (err < 0) 1344 if (err < 0)
1332 return err; 1345 return err;
1333 1346
@@ -1411,7 +1424,8 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
1411 1424
1412replay: 1425replay:
1413 /* Reinit, just in case something touches this. */ 1426 /* Reinit, just in case something touches this. */
1414 err = nlmsg_parse(n, sizeof(*tcm), tca, TCA_MAX, NULL, extack); 1427 err = nlmsg_parse(n, sizeof(*tcm), tca, TCA_MAX, rtm_tca_policy,
1428 extack);
1415 if (err < 0) 1429 if (err < 0)
1416 return err; 1430 return err;
1417 1431
@@ -1645,7 +1659,8 @@ static int tc_dump_qdisc(struct sk_buff *skb, struct netlink_callback *cb)
1645 idx = 0; 1659 idx = 0;
1646 ASSERT_RTNL(); 1660 ASSERT_RTNL();
1647 1661
1648 err = nlmsg_parse(nlh, sizeof(struct tcmsg), tca, TCA_MAX, NULL, NULL); 1662 err = nlmsg_parse(nlh, sizeof(struct tcmsg), tca, TCA_MAX,
1663 rtm_tca_policy, NULL);
1649 if (err < 0) 1664 if (err < 0)
1650 return err; 1665 return err;
1651 1666
@@ -1864,7 +1879,8 @@ static int tc_ctl_tclass(struct sk_buff *skb, struct nlmsghdr *n,
1864 !netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) 1879 !netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN))
1865 return -EPERM; 1880 return -EPERM;
1866 1881
1867 err = nlmsg_parse(n, sizeof(*tcm), tca, TCA_MAX, NULL, extack); 1882 err = nlmsg_parse(n, sizeof(*tcm), tca, TCA_MAX, rtm_tca_policy,
1883 extack);
1868 if (err < 0) 1884 if (err < 0)
1869 return err; 1885 return err;
1870 1886
diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index c07c30b916d5..793016d722ec 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -2644,7 +2644,7 @@ static int cake_init(struct Qdisc *sch, struct nlattr *opt,
2644 for (i = 1; i <= CAKE_QUEUES; i++) 2644 for (i = 1; i <= CAKE_QUEUES; i++)
2645 quantum_div[i] = 65535 / i; 2645 quantum_div[i] = 65535 / i;
2646 2646
2647 q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data), 2647 q->tins = kvcalloc(CAKE_MAX_TINS, sizeof(struct cake_tin_data),
2648 GFP_KERNEL); 2648 GFP_KERNEL);
2649 if (!q->tins) 2649 if (!q->tins)
2650 goto nomem; 2650 goto nomem;
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
index d74d00b29942..42191ed9902b 100644
--- a/net/sctp/outqueue.c
+++ b/net/sctp/outqueue.c
@@ -1048,7 +1048,7 @@ static void sctp_outq_flush_data(struct sctp_flush_ctx *ctx,
1048 if (!ctx->packet || !ctx->packet->has_cookie_echo) 1048 if (!ctx->packet || !ctx->packet->has_cookie_echo)
1049 return; 1049 return;
1050 1050
1051 /* fallthru */ 1051 /* fall through */
1052 case SCTP_STATE_ESTABLISHED: 1052 case SCTP_STATE_ESTABLISHED:
1053 case SCTP_STATE_SHUTDOWN_PENDING: 1053 case SCTP_STATE_SHUTDOWN_PENDING:
1054 case SCTP_STATE_SHUTDOWN_RECEIVED: 1054 case SCTP_STATE_SHUTDOWN_RECEIVED:
diff --git a/net/sctp/transport.c b/net/sctp/transport.c
index 12cac85da994..033696e6f74f 100644
--- a/net/sctp/transport.c
+++ b/net/sctp/transport.c
@@ -260,6 +260,7 @@ void sctp_transport_pmtu(struct sctp_transport *transport, struct sock *sk)
260bool sctp_transport_update_pmtu(struct sctp_transport *t, u32 pmtu) 260bool sctp_transport_update_pmtu(struct sctp_transport *t, u32 pmtu)
261{ 261{
262 struct dst_entry *dst = sctp_transport_dst_check(t); 262 struct dst_entry *dst = sctp_transport_dst_check(t);
263 struct sock *sk = t->asoc->base.sk;
263 bool change = true; 264 bool change = true;
264 265
265 if (unlikely(pmtu < SCTP_DEFAULT_MINSEGMENT)) { 266 if (unlikely(pmtu < SCTP_DEFAULT_MINSEGMENT)) {
@@ -271,12 +272,19 @@ bool sctp_transport_update_pmtu(struct sctp_transport *t, u32 pmtu)
271 pmtu = SCTP_TRUNC4(pmtu); 272 pmtu = SCTP_TRUNC4(pmtu);
272 273
273 if (dst) { 274 if (dst) {
274 dst->ops->update_pmtu(dst, t->asoc->base.sk, NULL, pmtu); 275 struct sctp_pf *pf = sctp_get_pf_specific(dst->ops->family);
276 union sctp_addr addr;
277
278 pf->af->from_sk(&addr, sk);
279 pf->to_sk_daddr(&t->ipaddr, sk);
280 dst->ops->update_pmtu(dst, sk, NULL, pmtu);
281 pf->to_sk_daddr(&addr, sk);
282
275 dst = sctp_transport_dst_check(t); 283 dst = sctp_transport_dst_check(t);
276 } 284 }
277 285
278 if (!dst) { 286 if (!dst) {
279 t->af_specific->get_dst(t, &t->saddr, &t->fl, t->asoc->base.sk); 287 t->af_specific->get_dst(t, &t->saddr, &t->fl, sk);
280 dst = t->dst; 288 dst = t->dst;
281 } 289 }
282 290
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 2d8a1e15e4f9..015231789ed2 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -742,7 +742,10 @@ static void smc_connect_work(struct work_struct *work)
742 smc->sk.sk_err = -rc; 742 smc->sk.sk_err = -rc;
743 743
744out: 744out:
745 smc->sk.sk_state_change(&smc->sk); 745 if (smc->sk.sk_err)
746 smc->sk.sk_state_change(&smc->sk);
747 else
748 smc->sk.sk_write_space(&smc->sk);
746 kfree(smc->connect_info); 749 kfree(smc->connect_info);
747 smc->connect_info = NULL; 750 smc->connect_info = NULL;
748 release_sock(&smc->sk); 751 release_sock(&smc->sk);
@@ -1150,9 +1153,9 @@ static int smc_listen_rdma_reg(struct smc_sock *new_smc, int local_contact)
1150} 1153}
1151 1154
1152/* listen worker: finish RDMA setup */ 1155/* listen worker: finish RDMA setup */
1153static void smc_listen_rdma_finish(struct smc_sock *new_smc, 1156static int smc_listen_rdma_finish(struct smc_sock *new_smc,
1154 struct smc_clc_msg_accept_confirm *cclc, 1157 struct smc_clc_msg_accept_confirm *cclc,
1155 int local_contact) 1158 int local_contact)
1156{ 1159{
1157 struct smc_link *link = &new_smc->conn.lgr->lnk[SMC_SINGLE_LINK]; 1160 struct smc_link *link = &new_smc->conn.lgr->lnk[SMC_SINGLE_LINK];
1158 int reason_code = 0; 1161 int reason_code = 0;
@@ -1175,11 +1178,12 @@ static void smc_listen_rdma_finish(struct smc_sock *new_smc,
1175 if (reason_code) 1178 if (reason_code)
1176 goto decline; 1179 goto decline;
1177 } 1180 }
1178 return; 1181 return 0;
1179 1182
1180decline: 1183decline:
1181 mutex_unlock(&smc_create_lgr_pending); 1184 mutex_unlock(&smc_create_lgr_pending);
1182 smc_listen_decline(new_smc, reason_code, local_contact); 1185 smc_listen_decline(new_smc, reason_code, local_contact);
1186 return reason_code;
1183} 1187}
1184 1188
1185/* setup for RDMA connection of server */ 1189/* setup for RDMA connection of server */
@@ -1276,8 +1280,10 @@ static void smc_listen_work(struct work_struct *work)
1276 } 1280 }
1277 1281
1278 /* finish worker */ 1282 /* finish worker */
1279 if (!ism_supported) 1283 if (!ism_supported) {
1280 smc_listen_rdma_finish(new_smc, &cclc, local_contact); 1284 if (smc_listen_rdma_finish(new_smc, &cclc, local_contact))
1285 return;
1286 }
1281 smc_conn_save_peer_info(new_smc, &cclc); 1287 smc_conn_save_peer_info(new_smc, &cclc);
1282 mutex_unlock(&smc_create_lgr_pending); 1288 mutex_unlock(&smc_create_lgr_pending);
1283 smc_listen_out_connected(new_smc); 1289 smc_listen_out_connected(new_smc);
@@ -1529,7 +1535,7 @@ static __poll_t smc_poll(struct file *file, struct socket *sock,
1529 return EPOLLNVAL; 1535 return EPOLLNVAL;
1530 1536
1531 smc = smc_sk(sock->sk); 1537 smc = smc_sk(sock->sk);
1532 if ((sk->sk_state == SMC_INIT) || smc->use_fallback) { 1538 if (smc->use_fallback) {
1533 /* delegate to CLC child sock */ 1539 /* delegate to CLC child sock */
1534 mask = smc->clcsock->ops->poll(file, smc->clcsock, wait); 1540 mask = smc->clcsock->ops->poll(file, smc->clcsock, wait);
1535 sk->sk_err = smc->clcsock->sk->sk_err; 1541 sk->sk_err = smc->clcsock->sk->sk_err;
@@ -1560,9 +1566,9 @@ static __poll_t smc_poll(struct file *file, struct socket *sock,
1560 mask |= EPOLLIN | EPOLLRDNORM | EPOLLRDHUP; 1566 mask |= EPOLLIN | EPOLLRDNORM | EPOLLRDHUP;
1561 if (sk->sk_state == SMC_APPCLOSEWAIT1) 1567 if (sk->sk_state == SMC_APPCLOSEWAIT1)
1562 mask |= EPOLLIN; 1568 mask |= EPOLLIN;
1569 if (smc->conn.urg_state == SMC_URG_VALID)
1570 mask |= EPOLLPRI;
1563 } 1571 }
1564 if (smc->conn.urg_state == SMC_URG_VALID)
1565 mask |= EPOLLPRI;
1566 } 1572 }
1567 1573
1568 return mask; 1574 return mask;
diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
index 83aba9ade060..52241d679cc9 100644
--- a/net/smc/smc_clc.c
+++ b/net/smc/smc_clc.c
@@ -446,14 +446,12 @@ int smc_clc_send_proposal(struct smc_sock *smc, int smc_type,
446 vec[i++].iov_len = sizeof(trl); 446 vec[i++].iov_len = sizeof(trl);
447 /* due to the few bytes needed for clc-handshake this cannot block */ 447 /* due to the few bytes needed for clc-handshake this cannot block */
448 len = kernel_sendmsg(smc->clcsock, &msg, vec, i, plen); 448 len = kernel_sendmsg(smc->clcsock, &msg, vec, i, plen);
449 if (len < sizeof(pclc)) { 449 if (len < 0) {
450 if (len >= 0) { 450 smc->sk.sk_err = smc->clcsock->sk->sk_err;
451 reason_code = -ENETUNREACH; 451 reason_code = -smc->sk.sk_err;
452 smc->sk.sk_err = -reason_code; 452 } else if (len < (int)sizeof(pclc)) {
453 } else { 453 reason_code = -ENETUNREACH;
454 smc->sk.sk_err = smc->clcsock->sk->sk_err; 454 smc->sk.sk_err = -reason_code;
455 reason_code = -smc->sk.sk_err;
456 }
457 } 455 }
458 456
459 return reason_code; 457 return reason_code;
diff --git a/net/smc/smc_close.c b/net/smc/smc_close.c
index ac961dfb1ea1..ea2b87f29469 100644
--- a/net/smc/smc_close.c
+++ b/net/smc/smc_close.c
@@ -100,15 +100,14 @@ static void smc_close_active_abort(struct smc_sock *smc)
100 struct smc_cdc_conn_state_flags *txflags = 100 struct smc_cdc_conn_state_flags *txflags =
101 &smc->conn.local_tx_ctrl.conn_state_flags; 101 &smc->conn.local_tx_ctrl.conn_state_flags;
102 102
103 sk->sk_err = ECONNABORTED; 103 if (sk->sk_state != SMC_INIT && smc->clcsock && smc->clcsock->sk) {
104 if (smc->clcsock && smc->clcsock->sk) { 104 sk->sk_err = ECONNABORTED;
105 smc->clcsock->sk->sk_err = ECONNABORTED; 105 if (smc->clcsock && smc->clcsock->sk) {
106 smc->clcsock->sk->sk_state_change(smc->clcsock->sk); 106 smc->clcsock->sk->sk_err = ECONNABORTED;
107 smc->clcsock->sk->sk_state_change(smc->clcsock->sk);
108 }
107 } 109 }
108 switch (sk->sk_state) { 110 switch (sk->sk_state) {
109 case SMC_INIT:
110 sk->sk_state = SMC_PEERABORTWAIT;
111 break;
112 case SMC_ACTIVE: 111 case SMC_ACTIVE:
113 sk->sk_state = SMC_PEERABORTWAIT; 112 sk->sk_state = SMC_PEERABORTWAIT;
114 release_sock(sk); 113 release_sock(sk);
@@ -143,6 +142,7 @@ static void smc_close_active_abort(struct smc_sock *smc)
143 case SMC_PEERFINCLOSEWAIT: 142 case SMC_PEERFINCLOSEWAIT:
144 sock_put(sk); /* passive closing */ 143 sock_put(sk); /* passive closing */
145 break; 144 break;
145 case SMC_INIT:
146 case SMC_PEERABORTWAIT: 146 case SMC_PEERABORTWAIT:
147 case SMC_CLOSED: 147 case SMC_CLOSED:
148 break; 148 break;
diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
index 01c6ce042a1c..7cb3e4f07c10 100644
--- a/net/smc/smc_pnet.c
+++ b/net/smc/smc_pnet.c
@@ -461,7 +461,7 @@ static const struct genl_ops smc_pnet_ops[] = {
461}; 461};
462 462
463/* SMC_PNETID family definition */ 463/* SMC_PNETID family definition */
464static struct genl_family smc_pnet_nl_family = { 464static struct genl_family smc_pnet_nl_family __ro_after_init = {
465 .hdrsize = 0, 465 .hdrsize = 0,
466 .name = SMCR_GENL_FAMILY_NAME, 466 .name = SMCR_GENL_FAMILY_NAME,
467 .version = SMCR_GENL_FAMILY_VERSION, 467 .version = SMCR_GENL_FAMILY_VERSION,
diff --git a/net/socket.c b/net/socket.c
index e6945e318f02..01f3f8f32d6f 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -941,7 +941,8 @@ void dlci_ioctl_set(int (*hook) (unsigned int, void __user *))
941EXPORT_SYMBOL(dlci_ioctl_set); 941EXPORT_SYMBOL(dlci_ioctl_set);
942 942
943static long sock_do_ioctl(struct net *net, struct socket *sock, 943static long sock_do_ioctl(struct net *net, struct socket *sock,
944 unsigned int cmd, unsigned long arg) 944 unsigned int cmd, unsigned long arg,
945 unsigned int ifreq_size)
945{ 946{
946 int err; 947 int err;
947 void __user *argp = (void __user *)arg; 948 void __user *argp = (void __user *)arg;
@@ -967,11 +968,11 @@ static long sock_do_ioctl(struct net *net, struct socket *sock,
967 } else { 968 } else {
968 struct ifreq ifr; 969 struct ifreq ifr;
969 bool need_copyout; 970 bool need_copyout;
970 if (copy_from_user(&ifr, argp, sizeof(struct ifreq))) 971 if (copy_from_user(&ifr, argp, ifreq_size))
971 return -EFAULT; 972 return -EFAULT;
972 err = dev_ioctl(net, cmd, &ifr, &need_copyout); 973 err = dev_ioctl(net, cmd, &ifr, &need_copyout);
973 if (!err && need_copyout) 974 if (!err && need_copyout)
974 if (copy_to_user(argp, &ifr, sizeof(struct ifreq))) 975 if (copy_to_user(argp, &ifr, ifreq_size))
975 return -EFAULT; 976 return -EFAULT;
976 } 977 }
977 return err; 978 return err;
@@ -1070,7 +1071,8 @@ static long sock_ioctl(struct file *file, unsigned cmd, unsigned long arg)
1070 err = open_related_ns(&net->ns, get_net_ns); 1071 err = open_related_ns(&net->ns, get_net_ns);
1071 break; 1072 break;
1072 default: 1073 default:
1073 err = sock_do_ioctl(net, sock, cmd, arg); 1074 err = sock_do_ioctl(net, sock, cmd, arg,
1075 sizeof(struct ifreq));
1074 break; 1076 break;
1075 } 1077 }
1076 return err; 1078 return err;
@@ -2750,7 +2752,8 @@ static int do_siocgstamp(struct net *net, struct socket *sock,
2750 int err; 2752 int err;
2751 2753
2752 set_fs(KERNEL_DS); 2754 set_fs(KERNEL_DS);
2753 err = sock_do_ioctl(net, sock, cmd, (unsigned long)&ktv); 2755 err = sock_do_ioctl(net, sock, cmd, (unsigned long)&ktv,
2756 sizeof(struct compat_ifreq));
2754 set_fs(old_fs); 2757 set_fs(old_fs);
2755 if (!err) 2758 if (!err)
2756 err = compat_put_timeval(&ktv, up); 2759 err = compat_put_timeval(&ktv, up);
@@ -2766,7 +2769,8 @@ static int do_siocgstampns(struct net *net, struct socket *sock,
2766 int err; 2769 int err;
2767 2770
2768 set_fs(KERNEL_DS); 2771 set_fs(KERNEL_DS);
2769 err = sock_do_ioctl(net, sock, cmd, (unsigned long)&kts); 2772 err = sock_do_ioctl(net, sock, cmd, (unsigned long)&kts,
2773 sizeof(struct compat_ifreq));
2770 set_fs(old_fs); 2774 set_fs(old_fs);
2771 if (!err) 2775 if (!err)
2772 err = compat_put_timespec(&kts, up); 2776 err = compat_put_timespec(&kts, up);
@@ -3072,7 +3076,8 @@ static int routing_ioctl(struct net *net, struct socket *sock,
3072 } 3076 }
3073 3077
3074 set_fs(KERNEL_DS); 3078 set_fs(KERNEL_DS);
3075 ret = sock_do_ioctl(net, sock, cmd, (unsigned long) r); 3079 ret = sock_do_ioctl(net, sock, cmd, (unsigned long) r,
3080 sizeof(struct compat_ifreq));
3076 set_fs(old_fs); 3081 set_fs(old_fs);
3077 3082
3078out: 3083out:
@@ -3185,7 +3190,8 @@ static int compat_sock_ioctl_trans(struct file *file, struct socket *sock,
3185 case SIOCBONDSETHWADDR: 3190 case SIOCBONDSETHWADDR:
3186 case SIOCBONDCHANGEACTIVE: 3191 case SIOCBONDCHANGEACTIVE:
3187 case SIOCGIFNAME: 3192 case SIOCGIFNAME:
3188 return sock_do_ioctl(net, sock, cmd, arg); 3193 return sock_do_ioctl(net, sock, cmd, arg,
3194 sizeof(struct compat_ifreq));
3189 } 3195 }
3190 3196
3191 return -ENOIOCTLCMD; 3197 return -ENOIOCTLCMD;
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 418f03d0be90..645c16052052 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -609,16 +609,18 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
609 609
610 switch (evt) { 610 switch (evt) {
611 case NETDEV_CHANGE: 611 case NETDEV_CHANGE:
612 if (netif_carrier_ok(dev)) 612 if (netif_carrier_ok(dev) && netif_oper_up(dev)) {
613 test_and_set_bit_lock(0, &b->up);
613 break; 614 break;
614 /* else: fall through */ 615 }
615 case NETDEV_UP: 616 /* fall through */
616 test_and_set_bit_lock(0, &b->up);
617 break;
618 case NETDEV_GOING_DOWN: 617 case NETDEV_GOING_DOWN:
619 clear_bit_unlock(0, &b->up); 618 clear_bit_unlock(0, &b->up);
620 tipc_reset_bearer(net, b); 619 tipc_reset_bearer(net, b);
621 break; 620 break;
621 case NETDEV_UP:
622 test_and_set_bit_lock(0, &b->up);
623 break;
622 case NETDEV_CHANGEMTU: 624 case NETDEV_CHANGEMTU:
623 if (tipc_mtu_bad(dev, 0)) { 625 if (tipc_mtu_bad(dev, 0)) {
624 bearer_disable(net, b); 626 bearer_disable(net, b);
diff --git a/net/tipc/link.c b/net/tipc/link.c
index b1f0bee54eac..f6552e4f4b43 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -410,6 +410,11 @@ char *tipc_link_name(struct tipc_link *l)
410 return l->name; 410 return l->name;
411} 411}
412 412
413u32 tipc_link_state(struct tipc_link *l)
414{
415 return l->state;
416}
417
413/** 418/**
414 * tipc_link_create - create a new link 419 * tipc_link_create - create a new link
415 * @n: pointer to associated node 420 * @n: pointer to associated node
@@ -472,6 +477,8 @@ bool tipc_link_create(struct net *net, char *if_name, int bearer_id,
472 l->in_session = false; 477 l->in_session = false;
473 l->bearer_id = bearer_id; 478 l->bearer_id = bearer_id;
474 l->tolerance = tolerance; 479 l->tolerance = tolerance;
480 if (bc_rcvlink)
481 bc_rcvlink->tolerance = tolerance;
475 l->net_plane = net_plane; 482 l->net_plane = net_plane;
476 l->advertised_mtu = mtu; 483 l->advertised_mtu = mtu;
477 l->mtu = mtu; 484 l->mtu = mtu;
@@ -838,12 +845,24 @@ static void link_prepare_wakeup(struct tipc_link *l)
838 845
839void tipc_link_reset(struct tipc_link *l) 846void tipc_link_reset(struct tipc_link *l)
840{ 847{
848 struct sk_buff_head list;
849
850 __skb_queue_head_init(&list);
851
841 l->in_session = false; 852 l->in_session = false;
842 l->session++; 853 l->session++;
843 l->mtu = l->advertised_mtu; 854 l->mtu = l->advertised_mtu;
855
856 spin_lock_bh(&l->wakeupq.lock);
857 skb_queue_splice_init(&l->wakeupq, &list);
858 spin_unlock_bh(&l->wakeupq.lock);
859
860 spin_lock_bh(&l->inputq->lock);
861 skb_queue_splice_init(&list, l->inputq);
862 spin_unlock_bh(&l->inputq->lock);
863
844 __skb_queue_purge(&l->transmq); 864 __skb_queue_purge(&l->transmq);
845 __skb_queue_purge(&l->deferdq); 865 __skb_queue_purge(&l->deferdq);
846 skb_queue_splice_init(&l->wakeupq, l->inputq);
847 __skb_queue_purge(&l->backlogq); 866 __skb_queue_purge(&l->backlogq);
848 l->backlog[TIPC_LOW_IMPORTANCE].len = 0; 867 l->backlog[TIPC_LOW_IMPORTANCE].len = 0;
849 l->backlog[TIPC_MEDIUM_IMPORTANCE].len = 0; 868 l->backlog[TIPC_MEDIUM_IMPORTANCE].len = 0;
@@ -1021,7 +1040,7 @@ static int tipc_link_retrans(struct tipc_link *l, struct tipc_link *r,
1021 /* Detect repeated retransmit failures on same packet */ 1040 /* Detect repeated retransmit failures on same packet */
1022 if (r->last_retransm != buf_seqno(skb)) { 1041 if (r->last_retransm != buf_seqno(skb)) {
1023 r->last_retransm = buf_seqno(skb); 1042 r->last_retransm = buf_seqno(skb);
1024 r->stale_limit = jiffies + msecs_to_jiffies(l->tolerance); 1043 r->stale_limit = jiffies + msecs_to_jiffies(r->tolerance);
1025 } else if (++r->stale_cnt > 99 && time_after(jiffies, r->stale_limit)) { 1044 } else if (++r->stale_cnt > 99 && time_after(jiffies, r->stale_limit)) {
1026 link_retransmit_failure(l, skb); 1045 link_retransmit_failure(l, skb);
1027 if (link_is_bc_sndlink(l)) 1046 if (link_is_bc_sndlink(l))
@@ -1380,6 +1399,36 @@ static void tipc_link_build_proto_msg(struct tipc_link *l, int mtyp, bool probe,
1380 __skb_queue_tail(xmitq, skb); 1399 __skb_queue_tail(xmitq, skb);
1381} 1400}
1382 1401
1402void tipc_link_create_dummy_tnl_msg(struct tipc_link *l,
1403 struct sk_buff_head *xmitq)
1404{
1405 u32 onode = tipc_own_addr(l->net);
1406 struct tipc_msg *hdr, *ihdr;
1407 struct sk_buff_head tnlq;
1408 struct sk_buff *skb;
1409 u32 dnode = l->addr;
1410
1411 skb_queue_head_init(&tnlq);
1412 skb = tipc_msg_create(TUNNEL_PROTOCOL, FAILOVER_MSG,
1413 INT_H_SIZE, BASIC_H_SIZE,
1414 dnode, onode, 0, 0, 0);
1415 if (!skb) {
1416 pr_warn("%sunable to create tunnel packet\n", link_co_err);
1417 return;
1418 }
1419
1420 hdr = buf_msg(skb);
1421 msg_set_msgcnt(hdr, 1);
1422 msg_set_bearer_id(hdr, l->peer_bearer_id);
1423
1424 ihdr = (struct tipc_msg *)msg_data(hdr);
1425 tipc_msg_init(onode, ihdr, TIPC_LOW_IMPORTANCE, TIPC_DIRECT_MSG,
1426 BASIC_H_SIZE, dnode);
1427 msg_set_errcode(ihdr, TIPC_ERR_NO_PORT);
1428 __skb_queue_tail(&tnlq, skb);
1429 tipc_link_xmit(l, &tnlq, xmitq);
1430}
1431
1383/* tipc_link_tnl_prepare(): prepare and return a list of tunnel packets 1432/* tipc_link_tnl_prepare(): prepare and return a list of tunnel packets
1384 * with contents of the link's transmit and backlog queues. 1433 * with contents of the link's transmit and backlog queues.
1385 */ 1434 */
@@ -1476,6 +1525,9 @@ bool tipc_link_validate_msg(struct tipc_link *l, struct tipc_msg *hdr)
1476 return false; 1525 return false;
1477 if (session != curr_session) 1526 if (session != curr_session)
1478 return false; 1527 return false;
1528 /* Extra sanity check */
1529 if (!link_is_up(l) && msg_ack(hdr))
1530 return false;
1479 if (!(l->peer_caps & TIPC_LINK_PROTO_SEQNO)) 1531 if (!(l->peer_caps & TIPC_LINK_PROTO_SEQNO))
1480 return true; 1532 return true;
1481 /* Accept only STATE with new sequence number */ 1533 /* Accept only STATE with new sequence number */
@@ -1533,9 +1585,10 @@ static int tipc_link_proto_rcv(struct tipc_link *l, struct sk_buff *skb,
1533 strncpy(if_name, data, TIPC_MAX_IF_NAME); 1585 strncpy(if_name, data, TIPC_MAX_IF_NAME);
1534 1586
1535 /* Update own tolerance if peer indicates a non-zero value */ 1587 /* Update own tolerance if peer indicates a non-zero value */
1536 if (in_range(peers_tol, TIPC_MIN_LINK_TOL, TIPC_MAX_LINK_TOL)) 1588 if (in_range(peers_tol, TIPC_MIN_LINK_TOL, TIPC_MAX_LINK_TOL)) {
1537 l->tolerance = peers_tol; 1589 l->tolerance = peers_tol;
1538 1590 l->bc_rcvlink->tolerance = peers_tol;
1591 }
1539 /* Update own priority if peer's priority is higher */ 1592 /* Update own priority if peer's priority is higher */
1540 if (in_range(peers_prio, l->priority + 1, TIPC_MAX_LINK_PRI)) 1593 if (in_range(peers_prio, l->priority + 1, TIPC_MAX_LINK_PRI))
1541 l->priority = peers_prio; 1594 l->priority = peers_prio;
@@ -1561,9 +1614,10 @@ static int tipc_link_proto_rcv(struct tipc_link *l, struct sk_buff *skb,
1561 l->rcv_nxt_state = msg_seqno(hdr) + 1; 1614 l->rcv_nxt_state = msg_seqno(hdr) + 1;
1562 1615
1563 /* Update own tolerance if peer indicates a non-zero value */ 1616 /* Update own tolerance if peer indicates a non-zero value */
1564 if (in_range(peers_tol, TIPC_MIN_LINK_TOL, TIPC_MAX_LINK_TOL)) 1617 if (in_range(peers_tol, TIPC_MIN_LINK_TOL, TIPC_MAX_LINK_TOL)) {
1565 l->tolerance = peers_tol; 1618 l->tolerance = peers_tol;
1566 1619 l->bc_rcvlink->tolerance = peers_tol;
1620 }
1567 /* Update own prio if peer indicates a different value */ 1621 /* Update own prio if peer indicates a different value */
1568 if ((peers_prio != l->priority) && 1622 if ((peers_prio != l->priority) &&
1569 in_range(peers_prio, 1, TIPC_MAX_LINK_PRI)) { 1623 in_range(peers_prio, 1, TIPC_MAX_LINK_PRI)) {
@@ -2180,6 +2234,8 @@ void tipc_link_set_tolerance(struct tipc_link *l, u32 tol,
2180 struct sk_buff_head *xmitq) 2234 struct sk_buff_head *xmitq)
2181{ 2235{
2182 l->tolerance = tol; 2236 l->tolerance = tol;
2237 if (l->bc_rcvlink)
2238 l->bc_rcvlink->tolerance = tol;
2183 if (link_is_up(l)) 2239 if (link_is_up(l))
2184 tipc_link_build_proto_msg(l, STATE_MSG, 0, 0, 0, tol, 0, xmitq); 2240 tipc_link_build_proto_msg(l, STATE_MSG, 0, 0, 0, tol, 0, xmitq);
2185} 2241}
diff --git a/net/tipc/link.h b/net/tipc/link.h
index 7bc494a33fdf..90488c538a4e 100644
--- a/net/tipc/link.h
+++ b/net/tipc/link.h
@@ -88,6 +88,8 @@ bool tipc_link_bc_create(struct net *net, u32 ownnode, u32 peer,
88 struct tipc_link **link); 88 struct tipc_link **link);
89void tipc_link_tnl_prepare(struct tipc_link *l, struct tipc_link *tnl, 89void tipc_link_tnl_prepare(struct tipc_link *l, struct tipc_link *tnl,
90 int mtyp, struct sk_buff_head *xmitq); 90 int mtyp, struct sk_buff_head *xmitq);
91void tipc_link_create_dummy_tnl_msg(struct tipc_link *tnl,
92 struct sk_buff_head *xmitq);
91void tipc_link_build_reset_msg(struct tipc_link *l, struct sk_buff_head *xmitq); 93void tipc_link_build_reset_msg(struct tipc_link *l, struct sk_buff_head *xmitq);
92int tipc_link_fsm_evt(struct tipc_link *l, int evt); 94int tipc_link_fsm_evt(struct tipc_link *l, int evt);
93bool tipc_link_is_up(struct tipc_link *l); 95bool tipc_link_is_up(struct tipc_link *l);
@@ -107,6 +109,7 @@ u16 tipc_link_rcv_nxt(struct tipc_link *l);
107u16 tipc_link_acked(struct tipc_link *l); 109u16 tipc_link_acked(struct tipc_link *l);
108u32 tipc_link_id(struct tipc_link *l); 110u32 tipc_link_id(struct tipc_link *l);
109char *tipc_link_name(struct tipc_link *l); 111char *tipc_link_name(struct tipc_link *l);
112u32 tipc_link_state(struct tipc_link *l);
110char tipc_link_plane(struct tipc_link *l); 113char tipc_link_plane(struct tipc_link *l);
111int tipc_link_prio(struct tipc_link *l); 114int tipc_link_prio(struct tipc_link *l);
112int tipc_link_window(struct tipc_link *l); 115int tipc_link_window(struct tipc_link *l);
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index a2f76743c73a..6376467e78f8 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -185,6 +185,10 @@ static int __tipc_nl_compat_dumpit(struct tipc_nl_compat_cmd_dump *cmd,
185 return -ENOMEM; 185 return -ENOMEM;
186 186
187 buf->sk = msg->dst_sk; 187 buf->sk = msg->dst_sk;
188 if (__tipc_dump_start(&cb, msg->net)) {
189 kfree_skb(buf);
190 return -ENOMEM;
191 }
188 192
189 do { 193 do {
190 int rem; 194 int rem;
@@ -216,6 +220,7 @@ static int __tipc_nl_compat_dumpit(struct tipc_nl_compat_cmd_dump *cmd,
216 err = 0; 220 err = 0;
217 221
218err_out: 222err_out:
223 tipc_dump_done(&cb);
219 kfree_skb(buf); 224 kfree_skb(buf);
220 225
221 if (err == -EMSGSIZE) { 226 if (err == -EMSGSIZE) {
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 68014f1b6976..2afc4f8c37a7 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -111,6 +111,7 @@ struct tipc_node {
111 int action_flags; 111 int action_flags;
112 struct list_head list; 112 struct list_head list;
113 int state; 113 int state;
114 bool failover_sent;
114 u16 sync_point; 115 u16 sync_point;
115 int link_cnt; 116 int link_cnt;
116 u16 working_links; 117 u16 working_links;
@@ -680,6 +681,7 @@ static void __tipc_node_link_up(struct tipc_node *n, int bearer_id,
680 *slot0 = bearer_id; 681 *slot0 = bearer_id;
681 *slot1 = bearer_id; 682 *slot1 = bearer_id;
682 tipc_node_fsm_evt(n, SELF_ESTABL_CONTACT_EVT); 683 tipc_node_fsm_evt(n, SELF_ESTABL_CONTACT_EVT);
684 n->failover_sent = false;
683 n->action_flags |= TIPC_NOTIFY_NODE_UP; 685 n->action_flags |= TIPC_NOTIFY_NODE_UP;
684 tipc_link_set_active(nl, true); 686 tipc_link_set_active(nl, true);
685 tipc_bcast_add_peer(n->net, nl, xmitq); 687 tipc_bcast_add_peer(n->net, nl, xmitq);
@@ -911,6 +913,7 @@ void tipc_node_check_dest(struct net *net, u32 addr,
911 bool reset = true; 913 bool reset = true;
912 char *if_name; 914 char *if_name;
913 unsigned long intv; 915 unsigned long intv;
916 u16 session;
914 917
915 *dupl_addr = false; 918 *dupl_addr = false;
916 *respond = false; 919 *respond = false;
@@ -997,9 +1000,10 @@ void tipc_node_check_dest(struct net *net, u32 addr,
997 goto exit; 1000 goto exit;
998 1001
999 if_name = strchr(b->name, ':') + 1; 1002 if_name = strchr(b->name, ':') + 1;
1003 get_random_bytes(&session, sizeof(u16));
1000 if (!tipc_link_create(net, if_name, b->identity, b->tolerance, 1004 if (!tipc_link_create(net, if_name, b->identity, b->tolerance,
1001 b->net_plane, b->mtu, b->priority, 1005 b->net_plane, b->mtu, b->priority,
1002 b->window, mod(tipc_net(net)->random), 1006 b->window, session,
1003 tipc_own_addr(net), addr, peer_id, 1007 tipc_own_addr(net), addr, peer_id,
1004 n->capabilities, 1008 n->capabilities,
1005 tipc_bc_sndlink(n->net), n->bc_entry.link, 1009 tipc_bc_sndlink(n->net), n->bc_entry.link,
@@ -1615,6 +1619,14 @@ static bool tipc_node_check_state(struct tipc_node *n, struct sk_buff *skb,
1615 tipc_skb_queue_splice_tail_init(tipc_link_inputq(pl), 1619 tipc_skb_queue_splice_tail_init(tipc_link_inputq(pl),
1616 tipc_link_inputq(l)); 1620 tipc_link_inputq(l));
1617 } 1621 }
1622 /* If parallel link was already down, and this happened before
1623 * the tunnel link came up, FAILOVER was never sent. Ensure that
1624 * FAILOVER is sent to get peer out of NODE_FAILINGOVER state.
1625 */
1626 if (n->state != NODE_FAILINGOVER && !n->failover_sent) {
1627 tipc_link_create_dummy_tnl_msg(l, xmitq);
1628 n->failover_sent = true;
1629 }
1618 /* If pkts arrive out of order, use lowest calculated syncpt */ 1630 /* If pkts arrive out of order, use lowest calculated syncpt */
1619 if (less(syncpt, n->sync_point)) 1631 if (less(syncpt, n->sync_point))
1620 n->sync_point = syncpt; 1632 n->sync_point = syncpt;
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index ab7a2a7178f7..49810fdff4c5 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -576,6 +576,7 @@ static int tipc_release(struct socket *sock)
576 sk_stop_timer(sk, &sk->sk_timer); 576 sk_stop_timer(sk, &sk->sk_timer);
577 tipc_sk_remove(tsk); 577 tipc_sk_remove(tsk);
578 578
579 sock_orphan(sk);
579 /* Reject any messages that accumulated in backlog queue */ 580 /* Reject any messages that accumulated in backlog queue */
580 release_sock(sk); 581 release_sock(sk);
581 tipc_dest_list_purge(&tsk->cong_links); 582 tipc_dest_list_purge(&tsk->cong_links);
@@ -1195,6 +1196,7 @@ void tipc_sk_mcast_rcv(struct net *net, struct sk_buff_head *arrvq,
1195 * @skb: pointer to message buffer. 1196 * @skb: pointer to message buffer.
1196 */ 1197 */
1197static void tipc_sk_conn_proto_rcv(struct tipc_sock *tsk, struct sk_buff *skb, 1198static void tipc_sk_conn_proto_rcv(struct tipc_sock *tsk, struct sk_buff *skb,
1199 struct sk_buff_head *inputq,
1198 struct sk_buff_head *xmitq) 1200 struct sk_buff_head *xmitq)
1199{ 1201{
1200 struct tipc_msg *hdr = buf_msg(skb); 1202 struct tipc_msg *hdr = buf_msg(skb);
@@ -1212,7 +1214,16 @@ static void tipc_sk_conn_proto_rcv(struct tipc_sock *tsk, struct sk_buff *skb,
1212 tipc_node_remove_conn(sock_net(sk), tsk_peer_node(tsk), 1214 tipc_node_remove_conn(sock_net(sk), tsk_peer_node(tsk),
1213 tsk_peer_port(tsk)); 1215 tsk_peer_port(tsk));
1214 sk->sk_state_change(sk); 1216 sk->sk_state_change(sk);
1215 goto exit; 1217
1218 /* State change is ignored if socket already awake,
1219 * - convert msg to abort msg and add to inqueue
1220 */
1221 msg_set_user(hdr, TIPC_CRITICAL_IMPORTANCE);
1222 msg_set_type(hdr, TIPC_CONN_MSG);
1223 msg_set_size(hdr, BASIC_H_SIZE);
1224 msg_set_hdr_sz(hdr, BASIC_H_SIZE);
1225 __skb_queue_tail(inputq, skb);
1226 return;
1216 } 1227 }
1217 1228
1218 tsk->probe_unacked = false; 1229 tsk->probe_unacked = false;
@@ -1418,8 +1429,10 @@ static int __tipc_sendstream(struct socket *sock, struct msghdr *m, size_t dlen)
1418 /* Handle implicit connection setup */ 1429 /* Handle implicit connection setup */
1419 if (unlikely(dest)) { 1430 if (unlikely(dest)) {
1420 rc = __tipc_sendmsg(sock, m, dlen); 1431 rc = __tipc_sendmsg(sock, m, dlen);
1421 if (dlen && (dlen == rc)) 1432 if (dlen && dlen == rc) {
1433 tsk->peer_caps = tipc_node_get_capabilities(net, dnode);
1422 tsk->snt_unacked = tsk_inc(tsk, dlen + msg_hdr_sz(hdr)); 1434 tsk->snt_unacked = tsk_inc(tsk, dlen + msg_hdr_sz(hdr));
1435 }
1423 return rc; 1436 return rc;
1424 } 1437 }
1425 1438
@@ -1933,7 +1946,7 @@ static void tipc_sk_proto_rcv(struct sock *sk,
1933 1946
1934 switch (msg_user(hdr)) { 1947 switch (msg_user(hdr)) {
1935 case CONN_MANAGER: 1948 case CONN_MANAGER:
1936 tipc_sk_conn_proto_rcv(tsk, skb, xmitq); 1949 tipc_sk_conn_proto_rcv(tsk, skb, inputq, xmitq);
1937 return; 1950 return;
1938 case SOCK_WAKEUP: 1951 case SOCK_WAKEUP:
1939 tipc_dest_del(&tsk->cong_links, msg_orignode(hdr), 0); 1952 tipc_dest_del(&tsk->cong_links, msg_orignode(hdr), 0);
@@ -3229,7 +3242,7 @@ int tipc_nl_sk_walk(struct sk_buff *skb, struct netlink_callback *cb,
3229 struct netlink_callback *cb, 3242 struct netlink_callback *cb,
3230 struct tipc_sock *tsk)) 3243 struct tipc_sock *tsk))
3231{ 3244{
3232 struct rhashtable_iter *iter = (void *)cb->args[0]; 3245 struct rhashtable_iter *iter = (void *)cb->args[4];
3233 struct tipc_sock *tsk; 3246 struct tipc_sock *tsk;
3234 int err; 3247 int err;
3235 3248
@@ -3265,8 +3278,14 @@ EXPORT_SYMBOL(tipc_nl_sk_walk);
3265 3278
3266int tipc_dump_start(struct netlink_callback *cb) 3279int tipc_dump_start(struct netlink_callback *cb)
3267{ 3280{
3268 struct rhashtable_iter *iter = (void *)cb->args[0]; 3281 return __tipc_dump_start(cb, sock_net(cb->skb->sk));
3269 struct net *net = sock_net(cb->skb->sk); 3282}
3283EXPORT_SYMBOL(tipc_dump_start);
3284
3285int __tipc_dump_start(struct netlink_callback *cb, struct net *net)
3286{
3287 /* tipc_nl_name_table_dump() uses cb->args[0...3]. */
3288 struct rhashtable_iter *iter = (void *)cb->args[4];
3270 struct tipc_net *tn = tipc_net(net); 3289 struct tipc_net *tn = tipc_net(net);
3271 3290
3272 if (!iter) { 3291 if (!iter) {
@@ -3274,17 +3293,16 @@ int tipc_dump_start(struct netlink_callback *cb)
3274 if (!iter) 3293 if (!iter)
3275 return -ENOMEM; 3294 return -ENOMEM;
3276 3295
3277 cb->args[0] = (long)iter; 3296 cb->args[4] = (long)iter;
3278 } 3297 }
3279 3298
3280 rhashtable_walk_enter(&tn->sk_rht, iter); 3299 rhashtable_walk_enter(&tn->sk_rht, iter);
3281 return 0; 3300 return 0;
3282} 3301}
3283EXPORT_SYMBOL(tipc_dump_start);
3284 3302
3285int tipc_dump_done(struct netlink_callback *cb) 3303int tipc_dump_done(struct netlink_callback *cb)
3286{ 3304{
3287 struct rhashtable_iter *hti = (void *)cb->args[0]; 3305 struct rhashtable_iter *hti = (void *)cb->args[4];
3288 3306
3289 rhashtable_walk_exit(hti); 3307 rhashtable_walk_exit(hti);
3290 kfree(hti); 3308 kfree(hti);
diff --git a/net/tipc/socket.h b/net/tipc/socket.h
index d43032e26532..5e575f205afe 100644
--- a/net/tipc/socket.h
+++ b/net/tipc/socket.h
@@ -69,5 +69,6 @@ int tipc_nl_sk_walk(struct sk_buff *skb, struct netlink_callback *cb,
69 struct netlink_callback *cb, 69 struct netlink_callback *cb,
70 struct tipc_sock *tsk)); 70 struct tipc_sock *tsk));
71int tipc_dump_start(struct netlink_callback *cb); 71int tipc_dump_start(struct netlink_callback *cb);
72int __tipc_dump_start(struct netlink_callback *cb, struct net *net);
72int tipc_dump_done(struct netlink_callback *cb); 73int tipc_dump_done(struct netlink_callback *cb);
73#endif 74#endif
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index 292742e50bfa..961b07d4d41c 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -686,7 +686,7 @@ int tls_set_device_offload(struct sock *sk, struct tls_context *ctx)
686 goto free_marker_record; 686 goto free_marker_record;
687 } 687 }
688 688
689 crypto_info = &ctx->crypto_send; 689 crypto_info = &ctx->crypto_send.info;
690 switch (crypto_info->cipher_type) { 690 switch (crypto_info->cipher_type) {
691 case TLS_CIPHER_AES_GCM_128: 691 case TLS_CIPHER_AES_GCM_128:
692 nonce_size = TLS_CIPHER_AES_GCM_128_IV_SIZE; 692 nonce_size = TLS_CIPHER_AES_GCM_128_IV_SIZE;
@@ -780,7 +780,7 @@ int tls_set_device_offload(struct sock *sk, struct tls_context *ctx)
780 780
781 ctx->priv_ctx_tx = offload_ctx; 781 ctx->priv_ctx_tx = offload_ctx;
782 rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_TX, 782 rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_TX,
783 &ctx->crypto_send, 783 &ctx->crypto_send.info,
784 tcp_sk(sk)->write_seq); 784 tcp_sk(sk)->write_seq);
785 if (rc) 785 if (rc)
786 goto release_netdev; 786 goto release_netdev;
@@ -862,7 +862,7 @@ int tls_set_device_offload_rx(struct sock *sk, struct tls_context *ctx)
862 goto release_ctx; 862 goto release_ctx;
863 863
864 rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_RX, 864 rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_RX,
865 &ctx->crypto_recv, 865 &ctx->crypto_recv.info,
866 tcp_sk(sk)->copied_seq); 866 tcp_sk(sk)->copied_seq);
867 if (rc) { 867 if (rc) {
868 pr_err_ratelimited("%s: The netdev has refused to offload this socket\n", 868 pr_err_ratelimited("%s: The netdev has refused to offload this socket\n",
diff --git a/net/tls/tls_device_fallback.c b/net/tls/tls_device_fallback.c
index 6102169239d1..450a6dbc5a88 100644
--- a/net/tls/tls_device_fallback.c
+++ b/net/tls/tls_device_fallback.c
@@ -320,7 +320,7 @@ static struct sk_buff *tls_enc_skb(struct tls_context *tls_ctx,
320 goto free_req; 320 goto free_req;
321 321
322 iv = buf; 322 iv = buf;
323 memcpy(iv, tls_ctx->crypto_send_aes_gcm_128.salt, 323 memcpy(iv, tls_ctx->crypto_send.aes_gcm_128.salt,
324 TLS_CIPHER_AES_GCM_128_SALT_SIZE); 324 TLS_CIPHER_AES_GCM_128_SALT_SIZE);
325 aad = buf + TLS_CIPHER_AES_GCM_128_SALT_SIZE + 325 aad = buf + TLS_CIPHER_AES_GCM_128_SALT_SIZE +
326 TLS_CIPHER_AES_GCM_128_IV_SIZE; 326 TLS_CIPHER_AES_GCM_128_IV_SIZE;
diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
index 180b6640e531..523622dc74f8 100644
--- a/net/tls/tls_main.c
+++ b/net/tls/tls_main.c
@@ -241,6 +241,16 @@ static void tls_write_space(struct sock *sk)
241 ctx->sk_write_space(sk); 241 ctx->sk_write_space(sk);
242} 242}
243 243
244static void tls_ctx_free(struct tls_context *ctx)
245{
246 if (!ctx)
247 return;
248
249 memzero_explicit(&ctx->crypto_send, sizeof(ctx->crypto_send));
250 memzero_explicit(&ctx->crypto_recv, sizeof(ctx->crypto_recv));
251 kfree(ctx);
252}
253
244static void tls_sk_proto_close(struct sock *sk, long timeout) 254static void tls_sk_proto_close(struct sock *sk, long timeout)
245{ 255{
246 struct tls_context *ctx = tls_get_ctx(sk); 256 struct tls_context *ctx = tls_get_ctx(sk);
@@ -294,7 +304,7 @@ static void tls_sk_proto_close(struct sock *sk, long timeout)
294#else 304#else
295 { 305 {
296#endif 306#endif
297 kfree(ctx); 307 tls_ctx_free(ctx);
298 ctx = NULL; 308 ctx = NULL;
299 } 309 }
300 310
@@ -305,7 +315,7 @@ skip_tx_cleanup:
305 * for sk->sk_prot->unhash [tls_hw_unhash] 315 * for sk->sk_prot->unhash [tls_hw_unhash]
306 */ 316 */
307 if (free_ctx) 317 if (free_ctx)
308 kfree(ctx); 318 tls_ctx_free(ctx);
309} 319}
310 320
311static int do_tls_getsockopt_tx(struct sock *sk, char __user *optval, 321static int do_tls_getsockopt_tx(struct sock *sk, char __user *optval,
@@ -330,7 +340,7 @@ static int do_tls_getsockopt_tx(struct sock *sk, char __user *optval,
330 } 340 }
331 341
332 /* get user crypto info */ 342 /* get user crypto info */
333 crypto_info = &ctx->crypto_send; 343 crypto_info = &ctx->crypto_send.info;
334 344
335 if (!TLS_CRYPTO_INFO_READY(crypto_info)) { 345 if (!TLS_CRYPTO_INFO_READY(crypto_info)) {
336 rc = -EBUSY; 346 rc = -EBUSY;
@@ -417,9 +427,9 @@ static int do_tls_setsockopt_conf(struct sock *sk, char __user *optval,
417 } 427 }
418 428
419 if (tx) 429 if (tx)
420 crypto_info = &ctx->crypto_send; 430 crypto_info = &ctx->crypto_send.info;
421 else 431 else
422 crypto_info = &ctx->crypto_recv; 432 crypto_info = &ctx->crypto_recv.info;
423 433
424 /* Currently we don't support set crypto info more than one time */ 434 /* Currently we don't support set crypto info more than one time */
425 if (TLS_CRYPTO_INFO_READY(crypto_info)) { 435 if (TLS_CRYPTO_INFO_READY(crypto_info)) {
@@ -499,7 +509,7 @@ static int do_tls_setsockopt_conf(struct sock *sk, char __user *optval,
499 goto out; 509 goto out;
500 510
501err_crypto_info: 511err_crypto_info:
502 memset(crypto_info, 0, sizeof(*crypto_info)); 512 memzero_explicit(crypto_info, sizeof(union tls_crypto_context));
503out: 513out:
504 return rc; 514 return rc;
505} 515}
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 52fbe727d7c1..b9c6ecfbcfea 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -125,6 +125,9 @@ static int alloc_encrypted_sg(struct sock *sk, int len)
125 &ctx->sg_encrypted_num_elem, 125 &ctx->sg_encrypted_num_elem,
126 &ctx->sg_encrypted_size, 0); 126 &ctx->sg_encrypted_size, 0);
127 127
128 if (rc == -ENOSPC)
129 ctx->sg_encrypted_num_elem = ARRAY_SIZE(ctx->sg_encrypted_data);
130
128 return rc; 131 return rc;
129} 132}
130 133
@@ -138,6 +141,9 @@ static int alloc_plaintext_sg(struct sock *sk, int len)
138 &ctx->sg_plaintext_num_elem, &ctx->sg_plaintext_size, 141 &ctx->sg_plaintext_num_elem, &ctx->sg_plaintext_size,
139 tls_ctx->pending_open_record_frags); 142 tls_ctx->pending_open_record_frags);
140 143
144 if (rc == -ENOSPC)
145 ctx->sg_plaintext_num_elem = ARRAY_SIZE(ctx->sg_plaintext_data);
146
141 return rc; 147 return rc;
142} 148}
143 149
@@ -925,7 +931,15 @@ int tls_sw_recvmsg(struct sock *sk,
925 if (control != TLS_RECORD_TYPE_DATA) 931 if (control != TLS_RECORD_TYPE_DATA)
926 goto recv_end; 932 goto recv_end;
927 } 933 }
934 } else {
935 /* MSG_PEEK right now cannot look beyond current skb
936 * from strparser, meaning we cannot advance skb here
937 * and thus unpause strparser since we'd loose original
938 * one.
939 */
940 break;
928 } 941 }
942
929 /* If we have a new message from strparser, continue now. */ 943 /* If we have a new message from strparser, continue now. */
930 if (copied >= target && !ctx->recv_pkt) 944 if (copied >= target && !ctx->recv_pkt)
931 break; 945 break;
@@ -1049,8 +1063,8 @@ static int tls_read_size(struct strparser *strp, struct sk_buff *skb)
1049 goto read_failure; 1063 goto read_failure;
1050 } 1064 }
1051 1065
1052 if (header[1] != TLS_VERSION_MINOR(tls_ctx->crypto_recv.version) || 1066 if (header[1] != TLS_VERSION_MINOR(tls_ctx->crypto_recv.info.version) ||
1053 header[2] != TLS_VERSION_MAJOR(tls_ctx->crypto_recv.version)) { 1067 header[2] != TLS_VERSION_MAJOR(tls_ctx->crypto_recv.info.version)) {
1054 ret = -EINVAL; 1068 ret = -EINVAL;
1055 goto read_failure; 1069 goto read_failure;
1056 } 1070 }
@@ -1130,7 +1144,6 @@ void tls_sw_free_resources_rx(struct sock *sk)
1130 1144
1131int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx, int tx) 1145int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx, int tx)
1132{ 1146{
1133 char keyval[TLS_CIPHER_AES_GCM_128_KEY_SIZE];
1134 struct tls_crypto_info *crypto_info; 1147 struct tls_crypto_info *crypto_info;
1135 struct tls12_crypto_info_aes_gcm_128 *gcm_128_info; 1148 struct tls12_crypto_info_aes_gcm_128 *gcm_128_info;
1136 struct tls_sw_context_tx *sw_ctx_tx = NULL; 1149 struct tls_sw_context_tx *sw_ctx_tx = NULL;
@@ -1175,12 +1188,12 @@ int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx, int tx)
1175 1188
1176 if (tx) { 1189 if (tx) {
1177 crypto_init_wait(&sw_ctx_tx->async_wait); 1190 crypto_init_wait(&sw_ctx_tx->async_wait);
1178 crypto_info = &ctx->crypto_send; 1191 crypto_info = &ctx->crypto_send.info;
1179 cctx = &ctx->tx; 1192 cctx = &ctx->tx;
1180 aead = &sw_ctx_tx->aead_send; 1193 aead = &sw_ctx_tx->aead_send;
1181 } else { 1194 } else {
1182 crypto_init_wait(&sw_ctx_rx->async_wait); 1195 crypto_init_wait(&sw_ctx_rx->async_wait);
1183 crypto_info = &ctx->crypto_recv; 1196 crypto_info = &ctx->crypto_recv.info;
1184 cctx = &ctx->rx; 1197 cctx = &ctx->rx;
1185 aead = &sw_ctx_rx->aead_recv; 1198 aead = &sw_ctx_rx->aead_recv;
1186 } 1199 }
@@ -1259,9 +1272,7 @@ int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx, int tx)
1259 1272
1260 ctx->push_pending_record = tls_sw_push_pending_record; 1273 ctx->push_pending_record = tls_sw_push_pending_record;
1261 1274
1262 memcpy(keyval, gcm_128_info->key, TLS_CIPHER_AES_GCM_128_KEY_SIZE); 1275 rc = crypto_aead_setkey(*aead, gcm_128_info->key,
1263
1264 rc = crypto_aead_setkey(*aead, keyval,
1265 TLS_CIPHER_AES_GCM_128_KEY_SIZE); 1276 TLS_CIPHER_AES_GCM_128_KEY_SIZE);
1266 if (rc) 1277 if (rc)
1267 goto free_aead; 1278 goto free_aead;
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 4b8ec659e797..176edfefcbaa 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -3756,6 +3756,7 @@ static bool ht_rateset_to_mask(struct ieee80211_supported_band *sband,
3756 return false; 3756 return false;
3757 3757
3758 /* check availability */ 3758 /* check availability */
3759 ridx = array_index_nospec(ridx, IEEE80211_HT_MCS_MASK_LEN);
3759 if (sband->ht_cap.mcs.rx_mask[ridx] & rbit) 3760 if (sband->ht_cap.mcs.rx_mask[ridx] & rbit)
3760 mcs[ridx] |= rbit; 3761 mcs[ridx] |= rbit;
3761 else 3762 else
@@ -10230,7 +10231,7 @@ static int cfg80211_cqm_rssi_update(struct cfg80211_registered_device *rdev,
10230 struct wireless_dev *wdev = dev->ieee80211_ptr; 10231 struct wireless_dev *wdev = dev->ieee80211_ptr;
10231 s32 last, low, high; 10232 s32 last, low, high;
10232 u32 hyst; 10233 u32 hyst;
10233 int i, n; 10234 int i, n, low_index;
10234 int err; 10235 int err;
10235 10236
10236 /* RSSI reporting disabled? */ 10237 /* RSSI reporting disabled? */
@@ -10267,10 +10268,19 @@ static int cfg80211_cqm_rssi_update(struct cfg80211_registered_device *rdev,
10267 if (last < wdev->cqm_config->rssi_thresholds[i]) 10268 if (last < wdev->cqm_config->rssi_thresholds[i])
10268 break; 10269 break;
10269 10270
10270 low = i > 0 ? 10271 low_index = i - 1;
10271 (wdev->cqm_config->rssi_thresholds[i - 1] - hyst) : S32_MIN; 10272 if (low_index >= 0) {
10272 high = i < n ? 10273 low_index = array_index_nospec(low_index, n);
10273 (wdev->cqm_config->rssi_thresholds[i] + hyst - 1) : S32_MAX; 10274 low = wdev->cqm_config->rssi_thresholds[low_index] - hyst;
10275 } else {
10276 low = S32_MIN;
10277 }
10278 if (i < n) {
10279 i = array_index_nospec(i, n);
10280 high = wdev->cqm_config->rssi_thresholds[i] + hyst - 1;
10281 } else {
10282 high = S32_MAX;
10283 }
10274 10284
10275 return rdev_set_cqm_rssi_range_config(rdev, dev, low, high); 10285 return rdev_set_cqm_rssi_range_config(rdev, dev, low, high);
10276} 10286}
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 2f702adf2912..24cfa2776f50 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -2661,11 +2661,12 @@ static void reg_process_hint(struct regulatory_request *reg_request)
2661{ 2661{
2662 struct wiphy *wiphy = NULL; 2662 struct wiphy *wiphy = NULL;
2663 enum reg_request_treatment treatment; 2663 enum reg_request_treatment treatment;
2664 enum nl80211_reg_initiator initiator = reg_request->initiator;
2664 2665
2665 if (reg_request->wiphy_idx != WIPHY_IDX_INVALID) 2666 if (reg_request->wiphy_idx != WIPHY_IDX_INVALID)
2666 wiphy = wiphy_idx_to_wiphy(reg_request->wiphy_idx); 2667 wiphy = wiphy_idx_to_wiphy(reg_request->wiphy_idx);
2667 2668
2668 switch (reg_request->initiator) { 2669 switch (initiator) {
2669 case NL80211_REGDOM_SET_BY_CORE: 2670 case NL80211_REGDOM_SET_BY_CORE:
2670 treatment = reg_process_hint_core(reg_request); 2671 treatment = reg_process_hint_core(reg_request);
2671 break; 2672 break;
@@ -2683,7 +2684,7 @@ static void reg_process_hint(struct regulatory_request *reg_request)
2683 treatment = reg_process_hint_country_ie(wiphy, reg_request); 2684 treatment = reg_process_hint_country_ie(wiphy, reg_request);
2684 break; 2685 break;
2685 default: 2686 default:
2686 WARN(1, "invalid initiator %d\n", reg_request->initiator); 2687 WARN(1, "invalid initiator %d\n", initiator);
2687 goto out_free; 2688 goto out_free;
2688 } 2689 }
2689 2690
@@ -2698,7 +2699,7 @@ static void reg_process_hint(struct regulatory_request *reg_request)
2698 */ 2699 */
2699 if (treatment == REG_REQ_ALREADY_SET && wiphy && 2700 if (treatment == REG_REQ_ALREADY_SET && wiphy &&
2700 wiphy->regulatory_flags & REGULATORY_STRICT_REG) { 2701 wiphy->regulatory_flags & REGULATORY_STRICT_REG) {
2701 wiphy_update_regulatory(wiphy, reg_request->initiator); 2702 wiphy_update_regulatory(wiphy, initiator);
2702 wiphy_all_share_dfs_chan_state(wiphy); 2703 wiphy_all_share_dfs_chan_state(wiphy);
2703 reg_check_channels(); 2704 reg_check_channels();
2704 } 2705 }
@@ -2867,6 +2868,7 @@ static int regulatory_hint_core(const char *alpha2)
2867 request->alpha2[0] = alpha2[0]; 2868 request->alpha2[0] = alpha2[0];
2868 request->alpha2[1] = alpha2[1]; 2869 request->alpha2[1] = alpha2[1];
2869 request->initiator = NL80211_REGDOM_SET_BY_CORE; 2870 request->initiator = NL80211_REGDOM_SET_BY_CORE;
2871 request->wiphy_idx = WIPHY_IDX_INVALID;
2870 2872
2871 queue_regulatory_request(request); 2873 queue_regulatory_request(request);
2872 2874
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index d36c3eb7b931..d0e7472dd9fd 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1058,13 +1058,23 @@ cfg80211_bss_update(struct cfg80211_registered_device *rdev,
1058 return NULL; 1058 return NULL;
1059} 1059}
1060 1060
1061/*
1062 * Update RX channel information based on the available frame payload
1063 * information. This is mainly for the 2.4 GHz band where frames can be received
1064 * from neighboring channels and the Beacon frames use the DSSS Parameter Set
1065 * element to indicate the current (transmitting) channel, but this might also
1066 * be needed on other bands if RX frequency does not match with the actual
1067 * operating channel of a BSS.
1068 */
1061static struct ieee80211_channel * 1069static struct ieee80211_channel *
1062cfg80211_get_bss_channel(struct wiphy *wiphy, const u8 *ie, size_t ielen, 1070cfg80211_get_bss_channel(struct wiphy *wiphy, const u8 *ie, size_t ielen,
1063 struct ieee80211_channel *channel) 1071 struct ieee80211_channel *channel,
1072 enum nl80211_bss_scan_width scan_width)
1064{ 1073{
1065 const u8 *tmp; 1074 const u8 *tmp;
1066 u32 freq; 1075 u32 freq;
1067 int channel_number = -1; 1076 int channel_number = -1;
1077 struct ieee80211_channel *alt_channel;
1068 1078
1069 tmp = cfg80211_find_ie(WLAN_EID_DS_PARAMS, ie, ielen); 1079 tmp = cfg80211_find_ie(WLAN_EID_DS_PARAMS, ie, ielen);
1070 if (tmp && tmp[1] == 1) { 1080 if (tmp && tmp[1] == 1) {
@@ -1078,16 +1088,45 @@ cfg80211_get_bss_channel(struct wiphy *wiphy, const u8 *ie, size_t ielen,
1078 } 1088 }
1079 } 1089 }
1080 1090
1081 if (channel_number < 0) 1091 if (channel_number < 0) {
1092 /* No channel information in frame payload */
1082 return channel; 1093 return channel;
1094 }
1083 1095
1084 freq = ieee80211_channel_to_frequency(channel_number, channel->band); 1096 freq = ieee80211_channel_to_frequency(channel_number, channel->band);
1085 channel = ieee80211_get_channel(wiphy, freq); 1097 alt_channel = ieee80211_get_channel(wiphy, freq);
1086 if (!channel) 1098 if (!alt_channel) {
1087 return NULL; 1099 if (channel->band == NL80211_BAND_2GHZ) {
1088 if (channel->flags & IEEE80211_CHAN_DISABLED) 1100 /*
1101 * Better not allow unexpected channels when that could
1102 * be going beyond the 1-11 range (e.g., discovering
1103 * BSS on channel 12 when radio is configured for
1104 * channel 11.
1105 */
1106 return NULL;
1107 }
1108
1109 /* No match for the payload channel number - ignore it */
1110 return channel;
1111 }
1112
1113 if (scan_width == NL80211_BSS_CHAN_WIDTH_10 ||
1114 scan_width == NL80211_BSS_CHAN_WIDTH_5) {
1115 /*
1116 * Ignore channel number in 5 and 10 MHz channels where there
1117 * may not be an n:1 or 1:n mapping between frequencies and
1118 * channel numbers.
1119 */
1120 return channel;
1121 }
1122
1123 /*
1124 * Use the channel determined through the payload channel number
1125 * instead of the RX channel reported by the driver.
1126 */
1127 if (alt_channel->flags & IEEE80211_CHAN_DISABLED)
1089 return NULL; 1128 return NULL;
1090 return channel; 1129 return alt_channel;
1091} 1130}
1092 1131
1093/* Returned bss is reference counted and must be cleaned up appropriately. */ 1132/* Returned bss is reference counted and must be cleaned up appropriately. */
@@ -1112,7 +1151,8 @@ cfg80211_inform_bss_data(struct wiphy *wiphy,
1112 (data->signal < 0 || data->signal > 100))) 1151 (data->signal < 0 || data->signal > 100)))
1113 return NULL; 1152 return NULL;
1114 1153
1115 channel = cfg80211_get_bss_channel(wiphy, ie, ielen, data->chan); 1154 channel = cfg80211_get_bss_channel(wiphy, ie, ielen, data->chan,
1155 data->scan_width);
1116 if (!channel) 1156 if (!channel)
1117 return NULL; 1157 return NULL;
1118 1158
@@ -1210,7 +1250,7 @@ cfg80211_inform_bss_frame_data(struct wiphy *wiphy,
1210 return NULL; 1250 return NULL;
1211 1251
1212 channel = cfg80211_get_bss_channel(wiphy, mgmt->u.beacon.variable, 1252 channel = cfg80211_get_bss_channel(wiphy, mgmt->u.beacon.variable,
1213 ielen, data->chan); 1253 ielen, data->chan, data->scan_width);
1214 if (!channel) 1254 if (!channel)
1215 return NULL; 1255 return NULL;
1216 1256
diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c
index 167f7025ac98..06943d9c9835 100644
--- a/net/wireless/wext-compat.c
+++ b/net/wireless/wext-compat.c
@@ -1278,12 +1278,16 @@ static int cfg80211_wext_giwrate(struct net_device *dev,
1278 if (err) 1278 if (err)
1279 return err; 1279 return err;
1280 1280
1281 if (!(sinfo.filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE))) 1281 if (!(sinfo.filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE))) {
1282 return -EOPNOTSUPP; 1282 err = -EOPNOTSUPP;
1283 goto free;
1284 }
1283 1285
1284 rate->value = 100000 * cfg80211_calculate_bitrate(&sinfo.txrate); 1286 rate->value = 100000 * cfg80211_calculate_bitrate(&sinfo.txrate);
1285 1287
1286 return 0; 1288free:
1289 cfg80211_sinfo_release_content(&sinfo);
1290 return err;
1287} 1291}
1288 1292
1289/* Get wireless statistics. Called by /proc/net/wireless and by SIOCGIWSTATS */ 1293/* Get wireless statistics. Called by /proc/net/wireless and by SIOCGIWSTATS */
@@ -1293,7 +1297,7 @@ static struct iw_statistics *cfg80211_wireless_stats(struct net_device *dev)
1293 struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy); 1297 struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy);
1294 /* we are under RTNL - globally locked - so can use static structs */ 1298 /* we are under RTNL - globally locked - so can use static structs */
1295 static struct iw_statistics wstats; 1299 static struct iw_statistics wstats;
1296 static struct station_info sinfo; 1300 static struct station_info sinfo = {};
1297 u8 bssid[ETH_ALEN]; 1301 u8 bssid[ETH_ALEN];
1298 1302
1299 if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_STATION) 1303 if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_STATION)
@@ -1352,6 +1356,8 @@ static struct iw_statistics *cfg80211_wireless_stats(struct net_device *dev)
1352 if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_TX_FAILED)) 1356 if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_TX_FAILED))
1353 wstats.discard.retries = sinfo.tx_failed; 1357 wstats.discard.retries = sinfo.tx_failed;
1354 1358
1359 cfg80211_sinfo_release_content(&sinfo);
1360
1355 return &wstats; 1361 return &wstats;
1356} 1362}
1357 1363
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index b89c9c7f8c5c..be3520e429c9 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -458,6 +458,7 @@ resume:
458 XFRM_INC_STATS(net, LINUX_MIB_XFRMINHDRERROR); 458 XFRM_INC_STATS(net, LINUX_MIB_XFRMINHDRERROR);
459 goto drop; 459 goto drop;
460 } 460 }
461 crypto_done = false;
461 } while (!err); 462 } while (!err);
462 463
463 err = xfrm_rcv_cb(skb, family, x->type->proto, 0); 464 err = xfrm_rcv_cb(skb, family, x->type->proto, 0);
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 45ba07ab3e4f..261995d37ced 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -100,6 +100,10 @@ static int xfrm_output_one(struct sk_buff *skb, int err)
100 spin_unlock_bh(&x->lock); 100 spin_unlock_bh(&x->lock);
101 101
102 skb_dst_force(skb); 102 skb_dst_force(skb);
103 if (!skb_dst(skb)) {
104 XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTERROR);
105 goto error_nolock;
106 }
103 107
104 if (xfrm_offload(skb)) { 108 if (xfrm_offload(skb)) {
105 x->type_offload->encap(x, skb); 109 x->type_offload->encap(x, skb);
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 3110c3fbee20..f094d4b3520d 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -2491,6 +2491,10 @@ int __xfrm_route_forward(struct sk_buff *skb, unsigned short family)
2491 } 2491 }
2492 2492
2493 skb_dst_force(skb); 2493 skb_dst_force(skb);
2494 if (!skb_dst(skb)) {
2495 XFRM_INC_STATS(net, LINUX_MIB_XFRMFWDHDRERROR);
2496 return 0;
2497 }
2494 2498
2495 dst = xfrm_lookup(net, skb_dst(skb), &fl, NULL, XFRM_LOOKUP_QUEUE); 2499 dst = xfrm_lookup(net, skb_dst(skb), &fl, NULL, XFRM_LOOKUP_QUEUE);
2496 if (IS_ERR(dst)) { 2500 if (IS_ERR(dst)) {
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 4791aa8b8185..df7ca2dabc48 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -151,10 +151,16 @@ static int verify_newsa_info(struct xfrm_usersa_info *p,
151 err = -EINVAL; 151 err = -EINVAL;
152 switch (p->family) { 152 switch (p->family) {
153 case AF_INET: 153 case AF_INET:
154 if (p->sel.prefixlen_d > 32 || p->sel.prefixlen_s > 32)
155 goto out;
156
154 break; 157 break;
155 158
156 case AF_INET6: 159 case AF_INET6:
157#if IS_ENABLED(CONFIG_IPV6) 160#if IS_ENABLED(CONFIG_IPV6)
161 if (p->sel.prefixlen_d > 128 || p->sel.prefixlen_s > 128)
162 goto out;
163
158 break; 164 break;
159#else 165#else
160 err = -EAFNOSUPPORT; 166 err = -EAFNOSUPPORT;
@@ -1396,10 +1402,16 @@ static int verify_newpolicy_info(struct xfrm_userpolicy_info *p)
1396 1402
1397 switch (p->sel.family) { 1403 switch (p->sel.family) {
1398 case AF_INET: 1404 case AF_INET:
1405 if (p->sel.prefixlen_d > 32 || p->sel.prefixlen_s > 32)
1406 return -EINVAL;
1407
1399 break; 1408 break;
1400 1409
1401 case AF_INET6: 1410 case AF_INET6:
1402#if IS_ENABLED(CONFIG_IPV6) 1411#if IS_ENABLED(CONFIG_IPV6)
1412 if (p->sel.prefixlen_d > 128 || p->sel.prefixlen_s > 128)
1413 return -EINVAL;
1414
1403 break; 1415 break;
1404#else 1416#else
1405 return -EAFNOSUPPORT; 1417 return -EAFNOSUPPORT;
@@ -1480,6 +1492,9 @@ static int validate_tmpl(int nr, struct xfrm_user_tmpl *ut, u16 family)
1480 (ut[i].family != prev_family)) 1492 (ut[i].family != prev_family))
1481 return -EINVAL; 1493 return -EINVAL;
1482 1494
1495 if (ut[i].mode >= XFRM_MODE_MAX)
1496 return -EINVAL;
1497
1483 prev_family = ut[i].family; 1498 prev_family = ut[i].family;
1484 1499
1485 switch (ut[i].family) { 1500 switch (ut[i].family) {
diff --git a/samples/Kconfig b/samples/Kconfig
index bd133efc1a56..ad1ec7016d4c 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -1,5 +1,6 @@
1menuconfig SAMPLES 1menuconfig SAMPLES
2 bool "Sample kernel code" 2 bool "Sample kernel code"
3 depends on !UML
3 help 4 help
4 You can build and test sample kernel code here. 5 You can build and test sample kernel code here.
5 6
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 5a2d1c9578a0..54da4b070db3 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -219,7 +219,7 @@ else
219sub_cmd_record_mcount = set -e ; perl $(srctree)/scripts/recordmcount.pl "$(ARCH)" \ 219sub_cmd_record_mcount = set -e ; perl $(srctree)/scripts/recordmcount.pl "$(ARCH)" \
220 "$(if $(CONFIG_CPU_BIG_ENDIAN),big,little)" \ 220 "$(if $(CONFIG_CPU_BIG_ENDIAN),big,little)" \
221 "$(if $(CONFIG_64BIT),64,32)" \ 221 "$(if $(CONFIG_64BIT),64,32)" \
222 "$(OBJDUMP)" "$(OBJCOPY)" "$(CC) $(KBUILD_CFLAGS)" \ 222 "$(OBJDUMP)" "$(OBJCOPY)" "$(CC) $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS)" \
223 "$(LD) $(KBUILD_LDFLAGS)" "$(NM)" "$(RM)" "$(MV)" \ 223 "$(LD) $(KBUILD_LDFLAGS)" "$(NM)" "$(RM)" "$(MV)" \
224 "$(if $(part-of-module),1,0)" "$(@)"; 224 "$(if $(part-of-module),1,0)" "$(@)";
225recordmcount_source := $(srctree)/scripts/recordmcount.pl 225recordmcount_source := $(srctree)/scripts/recordmcount.pl
diff --git a/scripts/subarch.include b/scripts/subarch.include
new file mode 100644
index 000000000000..650682821126
--- /dev/null
+++ b/scripts/subarch.include
@@ -0,0 +1,13 @@
1# SUBARCH tells the usermode build what the underlying arch is. That is set
2# first, and if a usermode build is happening, the "ARCH=um" on the command
3# line overrides the setting of ARCH below. If a native build is happening,
4# then ARCH is assigned, getting whatever value it gets normally, and
5# SUBARCH is subsequently ignored.
6
7SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
8 -e s/sun4u/sparc64/ \
9 -e s/arm.*/arm/ -e s/sa110/arm/ \
10 -e s/s390x/s390/ -e s/parisc64/parisc/ \
11 -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
12 -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
13 -e s/riscv.*/riscv/)
diff --git a/security/Kconfig b/security/Kconfig
index 27d8b2688f75..d9aa521b5206 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -57,7 +57,7 @@ config SECURITY_NETWORK
57config PAGE_TABLE_ISOLATION 57config PAGE_TABLE_ISOLATION
58 bool "Remove the kernel mapping in user mode" 58 bool "Remove the kernel mapping in user mode"
59 default y 59 default y
60 depends on X86 && !UML 60 depends on (X86_64 || X86_PAE) && !UML
61 help 61 help
62 This feature reduces the number of hardware side channels by 62 This feature reduces the number of hardware side channels by
63 ensuring that the majority of kernel addresses are not mapped 63 ensuring that the majority of kernel addresses are not mapped
diff --git a/security/keys/dh.c b/security/keys/dh.c
index 3b602a1e27fa..711e89d8c415 100644
--- a/security/keys/dh.c
+++ b/security/keys/dh.c
@@ -300,7 +300,7 @@ long __keyctl_dh_compute(struct keyctl_dh_params __user *params,
300 } 300 }
301 dh_inputs.g_size = dlen; 301 dh_inputs.g_size = dlen;
302 302
303 dlen = dh_data_from_key(pcopy.dh_private, &dh_inputs.key); 303 dlen = dh_data_from_key(pcopy.private, &dh_inputs.key);
304 if (dlen < 0) { 304 if (dlen < 0) {
305 ret = dlen; 305 ret = dlen;
306 goto out2; 306 goto out2;
diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c
index 730ea91d9be8..93676354f87f 100644
--- a/sound/firewire/bebob/bebob.c
+++ b/sound/firewire/bebob/bebob.c
@@ -263,6 +263,8 @@ do_registration(struct work_struct *work)
263error: 263error:
264 mutex_unlock(&devices_mutex); 264 mutex_unlock(&devices_mutex);
265 snd_bebob_stream_destroy_duplex(bebob); 265 snd_bebob_stream_destroy_duplex(bebob);
266 kfree(bebob->maudio_special_quirk);
267 bebob->maudio_special_quirk = NULL;
266 snd_card_free(bebob->card); 268 snd_card_free(bebob->card);
267 dev_info(&bebob->unit->device, 269 dev_info(&bebob->unit->device,
268 "Sound card registration failed: %d\n", err); 270 "Sound card registration failed: %d\n", err);
diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c
index bd55620c6a47..c266997ad299 100644
--- a/sound/firewire/bebob/bebob_maudio.c
+++ b/sound/firewire/bebob/bebob_maudio.c
@@ -96,17 +96,13 @@ int snd_bebob_maudio_load_firmware(struct fw_unit *unit)
96 struct fw_device *device = fw_parent_device(unit); 96 struct fw_device *device = fw_parent_device(unit);
97 int err, rcode; 97 int err, rcode;
98 u64 date; 98 u64 date;
99 __le32 cues[3] = { 99 __le32 *cues;
100 cpu_to_le32(MAUDIO_BOOTLOADER_CUE1),
101 cpu_to_le32(MAUDIO_BOOTLOADER_CUE2),
102 cpu_to_le32(MAUDIO_BOOTLOADER_CUE3)
103 };
104 100
105 /* check date of software used to build */ 101 /* check date of software used to build */
106 err = snd_bebob_read_block(unit, INFO_OFFSET_SW_DATE, 102 err = snd_bebob_read_block(unit, INFO_OFFSET_SW_DATE,
107 &date, sizeof(u64)); 103 &date, sizeof(u64));
108 if (err < 0) 104 if (err < 0)
109 goto end; 105 return err;
110 /* 106 /*
111 * firmware version 5058 or later has date later than "20070401", but 107 * firmware version 5058 or later has date later than "20070401", but
112 * 'date' is not null-terminated. 108 * 'date' is not null-terminated.
@@ -114,20 +110,28 @@ int snd_bebob_maudio_load_firmware(struct fw_unit *unit)
114 if (date < 0x3230303730343031LL) { 110 if (date < 0x3230303730343031LL) {
115 dev_err(&unit->device, 111 dev_err(&unit->device,
116 "Use firmware version 5058 or later\n"); 112 "Use firmware version 5058 or later\n");
117 err = -ENOSYS; 113 return -ENXIO;
118 goto end;
119 } 114 }
120 115
116 cues = kmalloc_array(3, sizeof(*cues), GFP_KERNEL);
117 if (!cues)
118 return -ENOMEM;
119
120 cues[0] = cpu_to_le32(MAUDIO_BOOTLOADER_CUE1);
121 cues[1] = cpu_to_le32(MAUDIO_BOOTLOADER_CUE2);
122 cues[2] = cpu_to_le32(MAUDIO_BOOTLOADER_CUE3);
123
121 rcode = fw_run_transaction(device->card, TCODE_WRITE_BLOCK_REQUEST, 124 rcode = fw_run_transaction(device->card, TCODE_WRITE_BLOCK_REQUEST,
122 device->node_id, device->generation, 125 device->node_id, device->generation,
123 device->max_speed, BEBOB_ADDR_REG_REQ, 126 device->max_speed, BEBOB_ADDR_REG_REQ,
124 cues, sizeof(cues)); 127 cues, 3 * sizeof(*cues));
128 kfree(cues);
125 if (rcode != RCODE_COMPLETE) { 129 if (rcode != RCODE_COMPLETE) {
126 dev_err(&unit->device, 130 dev_err(&unit->device,
127 "Failed to send a cue to load firmware\n"); 131 "Failed to send a cue to load firmware\n");
128 err = -EIO; 132 err = -EIO;
129 } 133 }
130end: 134
131 return err; 135 return err;
132} 136}
133 137
@@ -290,10 +294,6 @@ snd_bebob_maudio_special_discover(struct snd_bebob *bebob, bool is1814)
290 bebob->midi_output_ports = 2; 294 bebob->midi_output_ports = 2;
291 } 295 }
292end: 296end:
293 if (err < 0) {
294 kfree(params);
295 bebob->maudio_special_quirk = NULL;
296 }
297 mutex_unlock(&bebob->mutex); 297 mutex_unlock(&bebob->mutex);
298 return err; 298 return err;
299} 299}
diff --git a/sound/firewire/digi00x/digi00x.c b/sound/firewire/digi00x/digi00x.c
index 1f5e1d23f31a..ef689997d6a5 100644
--- a/sound/firewire/digi00x/digi00x.c
+++ b/sound/firewire/digi00x/digi00x.c
@@ -49,6 +49,7 @@ static void dg00x_free(struct snd_dg00x *dg00x)
49 fw_unit_put(dg00x->unit); 49 fw_unit_put(dg00x->unit);
50 50
51 mutex_destroy(&dg00x->mutex); 51 mutex_destroy(&dg00x->mutex);
52 kfree(dg00x);
52} 53}
53 54
54static void dg00x_card_free(struct snd_card *card) 55static void dg00x_card_free(struct snd_card *card)
diff --git a/sound/firewire/fireface/ff-protocol-ff400.c b/sound/firewire/fireface/ff-protocol-ff400.c
index ad7a0a32557d..64c3cb0fb926 100644
--- a/sound/firewire/fireface/ff-protocol-ff400.c
+++ b/sound/firewire/fireface/ff-protocol-ff400.c
@@ -146,6 +146,7 @@ static int ff400_switch_fetching_mode(struct snd_ff *ff, bool enable)
146{ 146{
147 __le32 *reg; 147 __le32 *reg;
148 int i; 148 int i;
149 int err;
149 150
150 reg = kcalloc(18, sizeof(__le32), GFP_KERNEL); 151 reg = kcalloc(18, sizeof(__le32), GFP_KERNEL);
151 if (reg == NULL) 152 if (reg == NULL)
@@ -163,9 +164,11 @@ static int ff400_switch_fetching_mode(struct snd_ff *ff, bool enable)
163 reg[i] = cpu_to_le32(0x00000001); 164 reg[i] = cpu_to_le32(0x00000001);
164 } 165 }
165 166
166 return snd_fw_transaction(ff->unit, TCODE_WRITE_BLOCK_REQUEST, 167 err = snd_fw_transaction(ff->unit, TCODE_WRITE_BLOCK_REQUEST,
167 FF400_FETCH_PCM_FRAMES, reg, 168 FF400_FETCH_PCM_FRAMES, reg,
168 sizeof(__le32) * 18, 0); 169 sizeof(__le32) * 18, 0);
170 kfree(reg);
171 return err;
169} 172}
170 173
171static void ff400_dump_sync_status(struct snd_ff *ff, 174static void ff400_dump_sync_status(struct snd_ff *ff,
diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
index 71a0613d3da0..f2d073365cf6 100644
--- a/sound/firewire/fireworks/fireworks.c
+++ b/sound/firewire/fireworks/fireworks.c
@@ -301,6 +301,8 @@ error:
301 snd_efw_transaction_remove_instance(efw); 301 snd_efw_transaction_remove_instance(efw);
302 snd_efw_stream_destroy_duplex(efw); 302 snd_efw_stream_destroy_duplex(efw);
303 snd_card_free(efw->card); 303 snd_card_free(efw->card);
304 kfree(efw->resp_buf);
305 efw->resp_buf = NULL;
304 dev_info(&efw->unit->device, 306 dev_info(&efw->unit->device,
305 "Sound card registration failed: %d\n", err); 307 "Sound card registration failed: %d\n", err);
306} 308}
diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c
index 1e5b2c802635..2ea8be6c8584 100644
--- a/sound/firewire/oxfw/oxfw.c
+++ b/sound/firewire/oxfw/oxfw.c
@@ -130,6 +130,7 @@ static void oxfw_free(struct snd_oxfw *oxfw)
130 130
131 kfree(oxfw->spec); 131 kfree(oxfw->spec);
132 mutex_destroy(&oxfw->mutex); 132 mutex_destroy(&oxfw->mutex);
133 kfree(oxfw);
133} 134}
134 135
135/* 136/*
@@ -207,6 +208,7 @@ static int detect_quirks(struct snd_oxfw *oxfw)
207static void do_registration(struct work_struct *work) 208static void do_registration(struct work_struct *work)
208{ 209{
209 struct snd_oxfw *oxfw = container_of(work, struct snd_oxfw, dwork.work); 210 struct snd_oxfw *oxfw = container_of(work, struct snd_oxfw, dwork.work);
211 int i;
210 int err; 212 int err;
211 213
212 if (oxfw->registered) 214 if (oxfw->registered)
@@ -269,7 +271,15 @@ error:
269 snd_oxfw_stream_destroy_simplex(oxfw, &oxfw->rx_stream); 271 snd_oxfw_stream_destroy_simplex(oxfw, &oxfw->rx_stream);
270 if (oxfw->has_output) 272 if (oxfw->has_output)
271 snd_oxfw_stream_destroy_simplex(oxfw, &oxfw->tx_stream); 273 snd_oxfw_stream_destroy_simplex(oxfw, &oxfw->tx_stream);
274 for (i = 0; i < SND_OXFW_STREAM_FORMAT_ENTRIES; ++i) {
275 kfree(oxfw->tx_stream_formats[i]);
276 oxfw->tx_stream_formats[i] = NULL;
277 kfree(oxfw->rx_stream_formats[i]);
278 oxfw->rx_stream_formats[i] = NULL;
279 }
272 snd_card_free(oxfw->card); 280 snd_card_free(oxfw->card);
281 kfree(oxfw->spec);
282 oxfw->spec = NULL;
273 dev_info(&oxfw->unit->device, 283 dev_info(&oxfw->unit->device,
274 "Sound card registration failed: %d\n", err); 284 "Sound card registration failed: %d\n", err);
275} 285}
diff --git a/sound/firewire/tascam/tascam.c b/sound/firewire/tascam/tascam.c
index 44ad41fb7374..d3fdc463a884 100644
--- a/sound/firewire/tascam/tascam.c
+++ b/sound/firewire/tascam/tascam.c
@@ -93,6 +93,7 @@ static void tscm_free(struct snd_tscm *tscm)
93 fw_unit_put(tscm->unit); 93 fw_unit_put(tscm->unit);
94 94
95 mutex_destroy(&tscm->mutex); 95 mutex_destroy(&tscm->mutex);
96 kfree(tscm);
96} 97}
97 98
98static void tscm_card_free(struct snd_card *card) 99static void tscm_card_free(struct snd_card *card)
diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
index 560ec0986e1a..74244d8e2909 100644
--- a/sound/hda/hdac_controller.c
+++ b/sound/hda/hdac_controller.c
@@ -40,6 +40,8 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
40 */ 40 */
41void snd_hdac_bus_init_cmd_io(struct hdac_bus *bus) 41void snd_hdac_bus_init_cmd_io(struct hdac_bus *bus)
42{ 42{
43 WARN_ON_ONCE(!bus->rb.area);
44
43 spin_lock_irq(&bus->reg_lock); 45 spin_lock_irq(&bus->reg_lock);
44 /* CORB set up */ 46 /* CORB set up */
45 bus->corb.addr = bus->rb.addr; 47 bus->corb.addr = bus->rb.addr;
@@ -383,7 +385,7 @@ void snd_hdac_bus_exit_link_reset(struct hdac_bus *bus)
383EXPORT_SYMBOL_GPL(snd_hdac_bus_exit_link_reset); 385EXPORT_SYMBOL_GPL(snd_hdac_bus_exit_link_reset);
384 386
385/* reset codec link */ 387/* reset codec link */
386static int azx_reset(struct hdac_bus *bus, bool full_reset) 388int snd_hdac_bus_reset_link(struct hdac_bus *bus, bool full_reset)
387{ 389{
388 if (!full_reset) 390 if (!full_reset)
389 goto skip_reset; 391 goto skip_reset;
@@ -408,7 +410,7 @@ static int azx_reset(struct hdac_bus *bus, bool full_reset)
408 skip_reset: 410 skip_reset:
409 /* check to see if controller is ready */ 411 /* check to see if controller is ready */
410 if (!snd_hdac_chip_readb(bus, GCTL)) { 412 if (!snd_hdac_chip_readb(bus, GCTL)) {
411 dev_dbg(bus->dev, "azx_reset: controller not ready!\n"); 413 dev_dbg(bus->dev, "controller not ready!\n");
412 return -EBUSY; 414 return -EBUSY;
413 } 415 }
414 416
@@ -423,6 +425,7 @@ static int azx_reset(struct hdac_bus *bus, bool full_reset)
423 425
424 return 0; 426 return 0;
425} 427}
428EXPORT_SYMBOL_GPL(snd_hdac_bus_reset_link);
426 429
427/* enable interrupts */ 430/* enable interrupts */
428static void azx_int_enable(struct hdac_bus *bus) 431static void azx_int_enable(struct hdac_bus *bus)
@@ -477,15 +480,17 @@ bool snd_hdac_bus_init_chip(struct hdac_bus *bus, bool full_reset)
477 return false; 480 return false;
478 481
479 /* reset controller */ 482 /* reset controller */
480 azx_reset(bus, full_reset); 483 snd_hdac_bus_reset_link(bus, full_reset);
481 484
482 /* initialize interrupts */ 485 /* clear interrupts */
483 azx_int_clear(bus); 486 azx_int_clear(bus);
484 azx_int_enable(bus);
485 487
486 /* initialize the codec command I/O */ 488 /* initialize the codec command I/O */
487 snd_hdac_bus_init_cmd_io(bus); 489 snd_hdac_bus_init_cmd_io(bus);
488 490
491 /* enable interrupts after CORB/RIRB buffers are initialized above */
492 azx_int_enable(bus);
493
489 /* program the position buffer */ 494 /* program the position buffer */
490 if (bus->use_posbuf && bus->posbuf.addr) { 495 if (bus->use_posbuf && bus->posbuf.addr) {
491 snd_hdac_chip_writel(bus, DPLBASE, (u32)bus->posbuf.addr); 496 snd_hdac_chip_writel(bus, DPLBASE, (u32)bus->posbuf.addr);
diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index b5282cbbe489..617ff1aa818f 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -145,9 +145,11 @@ int snd_hdac_i915_init(struct hdac_bus *bus)
145 if (!acomp->ops) { 145 if (!acomp->ops) {
146 request_module("i915"); 146 request_module("i915");
147 /* 10s timeout */ 147 /* 10s timeout */
148 wait_for_completion_timeout(&bind_complete, 10 * 1000); 148 wait_for_completion_timeout(&bind_complete,
149 msecs_to_jiffies(10 * 1000));
149 } 150 }
150 if (!acomp->ops) { 151 if (!acomp->ops) {
152 dev_info(bus->dev, "couldn't bind with audio component\n");
151 snd_hdac_acomp_exit(bus); 153 snd_hdac_acomp_exit(bus);
152 return -ENODEV; 154 return -ENODEV;
153 } 155 }
diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
index 90713741c2dc..6ebe817801ea 100644
--- a/sound/pci/emu10k1/emufx.c
+++ b/sound/pci/emu10k1/emufx.c
@@ -2540,7 +2540,7 @@ static int snd_emu10k1_fx8010_ioctl(struct snd_hwdep * hw, struct file *file, un
2540 emu->support_tlv = 1; 2540 emu->support_tlv = 1;
2541 return put_user(SNDRV_EMU10K1_VERSION, (int __user *)argp); 2541 return put_user(SNDRV_EMU10K1_VERSION, (int __user *)argp);
2542 case SNDRV_EMU10K1_IOCTL_INFO: 2542 case SNDRV_EMU10K1_IOCTL_INFO:
2543 info = kmalloc(sizeof(*info), GFP_KERNEL); 2543 info = kzalloc(sizeof(*info), GFP_KERNEL);
2544 if (!info) 2544 if (!info)
2545 return -ENOMEM; 2545 return -ENOMEM;
2546 snd_emu10k1_fx8010_info(emu, info); 2546 snd_emu10k1_fx8010_info(emu, info);
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 1b2ce304152a..aa4c672dbaf7 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -365,8 +365,10 @@ enum {
365 */ 365 */
366#ifdef SUPPORT_VGA_SWITCHEROO 366#ifdef SUPPORT_VGA_SWITCHEROO
367#define use_vga_switcheroo(chip) ((chip)->use_vga_switcheroo) 367#define use_vga_switcheroo(chip) ((chip)->use_vga_switcheroo)
368#define needs_eld_notify_link(chip) ((chip)->need_eld_notify_link)
368#else 369#else
369#define use_vga_switcheroo(chip) 0 370#define use_vga_switcheroo(chip) 0
371#define needs_eld_notify_link(chip) false
370#endif 372#endif
371 373
372#define CONTROLLER_IN_GPU(pci) (((pci)->device == 0x0a0c) || \ 374#define CONTROLLER_IN_GPU(pci) (((pci)->device == 0x0a0c) || \
@@ -453,6 +455,7 @@ static inline void mark_runtime_wc(struct azx *chip, struct azx_dev *azx_dev,
453#endif 455#endif
454 456
455static int azx_acquire_irq(struct azx *chip, int do_disconnect); 457static int azx_acquire_irq(struct azx *chip, int do_disconnect);
458static void set_default_power_save(struct azx *chip);
456 459
457/* 460/*
458 * initialize the PCI registers 461 * initialize the PCI registers
@@ -1201,6 +1204,10 @@ static int azx_runtime_idle(struct device *dev)
1201 azx_bus(chip)->codec_powered || !chip->running) 1204 azx_bus(chip)->codec_powered || !chip->running)
1202 return -EBUSY; 1205 return -EBUSY;
1203 1206
1207 /* ELD notification gets broken when HD-audio bus is off */
1208 if (needs_eld_notify_link(hda))
1209 return -EBUSY;
1210
1204 return 0; 1211 return 0;
1205} 1212}
1206 1213
@@ -1298,6 +1305,36 @@ static bool azx_vs_can_switch(struct pci_dev *pci)
1298 return true; 1305 return true;
1299} 1306}
1300 1307
1308/*
1309 * The discrete GPU cannot power down unless the HDA controller runtime
1310 * suspends, so activate runtime PM on codecs even if power_save == 0.
1311 */
1312static void setup_vga_switcheroo_runtime_pm(struct azx *chip)
1313{
1314 struct hda_intel *hda = container_of(chip, struct hda_intel, chip);
1315 struct hda_codec *codec;
1316
1317 if (hda->use_vga_switcheroo && !hda->need_eld_notify_link) {
1318 list_for_each_codec(codec, &chip->bus)
1319 codec->auto_runtime_pm = 1;
1320 /* reset the power save setup */
1321 if (chip->running)
1322 set_default_power_save(chip);
1323 }
1324}
1325
1326static void azx_vs_gpu_bound(struct pci_dev *pci,
1327 enum vga_switcheroo_client_id client_id)
1328{
1329 struct snd_card *card = pci_get_drvdata(pci);
1330 struct azx *chip = card->private_data;
1331 struct hda_intel *hda = container_of(chip, struct hda_intel, chip);
1332
1333 if (client_id == VGA_SWITCHEROO_DIS)
1334 hda->need_eld_notify_link = 0;
1335 setup_vga_switcheroo_runtime_pm(chip);
1336}
1337
1301static void init_vga_switcheroo(struct azx *chip) 1338static void init_vga_switcheroo(struct azx *chip)
1302{ 1339{
1303 struct hda_intel *hda = container_of(chip, struct hda_intel, chip); 1340 struct hda_intel *hda = container_of(chip, struct hda_intel, chip);
@@ -1306,6 +1343,7 @@ static void init_vga_switcheroo(struct azx *chip)
1306 dev_info(chip->card->dev, 1343 dev_info(chip->card->dev,
1307 "Handle vga_switcheroo audio client\n"); 1344 "Handle vga_switcheroo audio client\n");
1308 hda->use_vga_switcheroo = 1; 1345 hda->use_vga_switcheroo = 1;
1346 hda->need_eld_notify_link = 1; /* cleared in gpu_bound op */
1309 chip->driver_caps |= AZX_DCAPS_PM_RUNTIME; 1347 chip->driver_caps |= AZX_DCAPS_PM_RUNTIME;
1310 pci_dev_put(p); 1348 pci_dev_put(p);
1311 } 1349 }
@@ -1314,6 +1352,7 @@ static void init_vga_switcheroo(struct azx *chip)
1314static const struct vga_switcheroo_client_ops azx_vs_ops = { 1352static const struct vga_switcheroo_client_ops azx_vs_ops = {
1315 .set_gpu_state = azx_vs_set_state, 1353 .set_gpu_state = azx_vs_set_state,
1316 .can_switch = azx_vs_can_switch, 1354 .can_switch = azx_vs_can_switch,
1355 .gpu_bound = azx_vs_gpu_bound,
1317}; 1356};
1318 1357
1319static int register_vga_switcheroo(struct azx *chip) 1358static int register_vga_switcheroo(struct azx *chip)
@@ -1339,6 +1378,7 @@ static int register_vga_switcheroo(struct azx *chip)
1339#define init_vga_switcheroo(chip) /* NOP */ 1378#define init_vga_switcheroo(chip) /* NOP */
1340#define register_vga_switcheroo(chip) 0 1379#define register_vga_switcheroo(chip) 0
1341#define check_hdmi_disabled(pci) false 1380#define check_hdmi_disabled(pci) false
1381#define setup_vga_switcheroo_runtime_pm(chip) /* NOP */
1342#endif /* SUPPORT_VGA_SWITCHER */ 1382#endif /* SUPPORT_VGA_SWITCHER */
1343 1383
1344/* 1384/*
@@ -1352,6 +1392,7 @@ static int azx_free(struct azx *chip)
1352 1392
1353 if (azx_has_pm_runtime(chip) && chip->running) 1393 if (azx_has_pm_runtime(chip) && chip->running)
1354 pm_runtime_get_noresume(&pci->dev); 1394 pm_runtime_get_noresume(&pci->dev);
1395 chip->running = 0;
1355 1396
1356 azx_del_card_list(chip); 1397 azx_del_card_list(chip);
1357 1398
@@ -2230,6 +2271,25 @@ static struct snd_pci_quirk power_save_blacklist[] = {
2230}; 2271};
2231#endif /* CONFIG_PM */ 2272#endif /* CONFIG_PM */
2232 2273
2274static void set_default_power_save(struct azx *chip)
2275{
2276 int val = power_save;
2277
2278#ifdef CONFIG_PM
2279 if (pm_blacklist) {
2280 const struct snd_pci_quirk *q;
2281
2282 q = snd_pci_quirk_lookup(chip->pci, power_save_blacklist);
2283 if (q && val) {
2284 dev_info(chip->card->dev, "device %04x:%04x is on the power_save blacklist, forcing power_save to 0\n",
2285 q->subvendor, q->subdevice);
2286 val = 0;
2287 }
2288 }
2289#endif /* CONFIG_PM */
2290 snd_hda_set_power_save(&chip->bus, val * 1000);
2291}
2292
2233/* number of codec slots for each chipset: 0 = default slots (i.e. 4) */ 2293/* number of codec slots for each chipset: 0 = default slots (i.e. 4) */
2234static unsigned int azx_max_codecs[AZX_NUM_DRIVERS] = { 2294static unsigned int azx_max_codecs[AZX_NUM_DRIVERS] = {
2235 [AZX_DRIVER_NVIDIA] = 8, 2295 [AZX_DRIVER_NVIDIA] = 8,
@@ -2241,9 +2301,7 @@ static int azx_probe_continue(struct azx *chip)
2241 struct hda_intel *hda = container_of(chip, struct hda_intel, chip); 2301 struct hda_intel *hda = container_of(chip, struct hda_intel, chip);
2242 struct hdac_bus *bus = azx_bus(chip); 2302 struct hdac_bus *bus = azx_bus(chip);
2243 struct pci_dev *pci = chip->pci; 2303 struct pci_dev *pci = chip->pci;
2244 struct hda_codec *codec;
2245 int dev = chip->dev_index; 2304 int dev = chip->dev_index;
2246 int val;
2247 int err; 2305 int err;
2248 2306
2249 hda->probe_continued = 1; 2307 hda->probe_continued = 1;
@@ -2322,31 +2380,13 @@ static int azx_probe_continue(struct azx *chip)
2322 if (err < 0) 2380 if (err < 0)
2323 goto out_free; 2381 goto out_free;
2324 2382
2383 setup_vga_switcheroo_runtime_pm(chip);
2384
2325 chip->running = 1; 2385 chip->running = 1;
2326 azx_add_card_list(chip); 2386 azx_add_card_list(chip);
2327 2387
2328 val = power_save; 2388 set_default_power_save(chip);
2329#ifdef CONFIG_PM
2330 if (pm_blacklist) {
2331 const struct snd_pci_quirk *q;
2332
2333 q = snd_pci_quirk_lookup(chip->pci, power_save_blacklist);
2334 if (q && val) {
2335 dev_info(chip->card->dev, "device %04x:%04x is on the power_save blacklist, forcing power_save to 0\n",
2336 q->subvendor, q->subdevice);
2337 val = 0;
2338 }
2339 }
2340#endif /* CONFIG_PM */
2341 /*
2342 * The discrete GPU cannot power down unless the HDA controller runtime
2343 * suspends, so activate runtime PM on codecs even if power_save == 0.
2344 */
2345 if (use_vga_switcheroo(hda))
2346 list_for_each_codec(codec, &chip->bus)
2347 codec->auto_runtime_pm = 1;
2348 2389
2349 snd_hda_set_power_save(&chip->bus, val * 1000);
2350 if (azx_has_pm_runtime(chip)) 2390 if (azx_has_pm_runtime(chip))
2351 pm_runtime_put_autosuspend(&pci->dev); 2391 pm_runtime_put_autosuspend(&pci->dev);
2352 2392
diff --git a/sound/pci/hda/hda_intel.h b/sound/pci/hda/hda_intel.h
index e3a3d318d2e5..f59719e06b91 100644
--- a/sound/pci/hda/hda_intel.h
+++ b/sound/pci/hda/hda_intel.h
@@ -37,6 +37,7 @@ struct hda_intel {
37 37
38 /* vga_switcheroo setup */ 38 /* vga_switcheroo setup */
39 unsigned int use_vga_switcheroo:1; 39 unsigned int use_vga_switcheroo:1;
40 unsigned int need_eld_notify_link:1;
40 unsigned int vga_switcheroo_registered:1; 41 unsigned int vga_switcheroo_registered:1;
41 unsigned int init_failed:1; /* delayed init failed */ 42 unsigned int init_failed:1; /* delayed init failed */
42 43
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1d117f00d04d..3ac7ba9b342d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6409,6 +6409,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
6409 SND_PCI_QUIRK(0x1028, 0x0706, "Dell Inspiron 7559", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER), 6409 SND_PCI_QUIRK(0x1028, 0x0706, "Dell Inspiron 7559", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER),
6410 SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE), 6410 SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE),
6411 SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), 6411 SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
6412 SND_PCI_QUIRK(0x1028, 0x075c, "Dell XPS 27 7760", ALC298_FIXUP_SPK_VOLUME),
6412 SND_PCI_QUIRK(0x1028, 0x075d, "Dell AIO", ALC298_FIXUP_SPK_VOLUME), 6413 SND_PCI_QUIRK(0x1028, 0x075d, "Dell AIO", ALC298_FIXUP_SPK_VOLUME),
6413 SND_PCI_QUIRK(0x1028, 0x07b0, "Dell Precision 7520", ALC295_FIXUP_DISABLE_DAC3), 6414 SND_PCI_QUIRK(0x1028, 0x07b0, "Dell Precision 7520", ALC295_FIXUP_DISABLE_DAC3),
6414 SND_PCI_QUIRK(0x1028, 0x0798, "Dell Inspiron 17 7000 Gaming", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER), 6415 SND_PCI_QUIRK(0x1028, 0x0798, "Dell Inspiron 17 7000 Gaming", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER),
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index e359938e3d7e..77b265bd0505 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -16,6 +16,7 @@
16#include <linux/module.h> 16#include <linux/module.h>
17#include <linux/delay.h> 17#include <linux/delay.h>
18#include <linux/io.h> 18#include <linux/io.h>
19#include <linux/iopoll.h>
19#include <linux/sizes.h> 20#include <linux/sizes.h>
20#include <linux/pm_runtime.h> 21#include <linux/pm_runtime.h>
21 22
@@ -184,6 +185,24 @@ static void config_dma_descriptor_in_sram(void __iomem *acp_mmio,
184 acp_reg_write(descr_info->xfer_val, acp_mmio, mmACP_SRBM_Targ_Idx_Data); 185 acp_reg_write(descr_info->xfer_val, acp_mmio, mmACP_SRBM_Targ_Idx_Data);
185} 186}
186 187
188static void pre_config_reset(void __iomem *acp_mmio, u16 ch_num)
189{
190 u32 dma_ctrl;
191 int ret;
192
193 /* clear the reset bit */
194 dma_ctrl = acp_reg_read(acp_mmio, mmACP_DMA_CNTL_0 + ch_num);
195 dma_ctrl &= ~ACP_DMA_CNTL_0__DMAChRst_MASK;
196 acp_reg_write(dma_ctrl, acp_mmio, mmACP_DMA_CNTL_0 + ch_num);
197 /* check the reset bit before programming configuration registers */
198 ret = readl_poll_timeout(acp_mmio + ((mmACP_DMA_CNTL_0 + ch_num) * 4),
199 dma_ctrl,
200 !(dma_ctrl & ACP_DMA_CNTL_0__DMAChRst_MASK),
201 100, ACP_DMA_RESET_TIME);
202 if (ret < 0)
203 pr_err("Failed to clear reset of channel : %d\n", ch_num);
204}
205
187/* 206/*
188 * Initialize the DMA descriptor information for transfer between 207 * Initialize the DMA descriptor information for transfer between
189 * system memory <-> ACP SRAM 208 * system memory <-> ACP SRAM
@@ -236,6 +255,7 @@ static void set_acp_sysmem_dma_descriptors(void __iomem *acp_mmio,
236 config_dma_descriptor_in_sram(acp_mmio, dma_dscr_idx, 255 config_dma_descriptor_in_sram(acp_mmio, dma_dscr_idx,
237 &dmadscr[i]); 256 &dmadscr[i]);
238 } 257 }
258 pre_config_reset(acp_mmio, ch);
239 config_acp_dma_channel(acp_mmio, ch, 259 config_acp_dma_channel(acp_mmio, ch,
240 dma_dscr_idx - 1, 260 dma_dscr_idx - 1,
241 NUM_DSCRS_PER_CHANNEL, 261 NUM_DSCRS_PER_CHANNEL,
@@ -275,6 +295,7 @@ static void set_acp_to_i2s_dma_descriptors(void __iomem *acp_mmio, u32 size,
275 config_dma_descriptor_in_sram(acp_mmio, dma_dscr_idx, 295 config_dma_descriptor_in_sram(acp_mmio, dma_dscr_idx,
276 &dmadscr[i]); 296 &dmadscr[i]);
277 } 297 }
298 pre_config_reset(acp_mmio, ch);
278 /* Configure the DMA channel with the above descriptore */ 299 /* Configure the DMA channel with the above descriptore */
279 config_acp_dma_channel(acp_mmio, ch, dma_dscr_idx - 1, 300 config_acp_dma_channel(acp_mmio, ch, dma_dscr_idx - 1,
280 NUM_DSCRS_PER_CHANNEL, 301 NUM_DSCRS_PER_CHANNEL,
diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index 275677de669f..407554175282 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -157,8 +157,8 @@ static const struct snd_kcontrol_new cs4265_snd_controls[] = {
157 SOC_SINGLE("Validity Bit Control Switch", CS4265_SPDIF_CTL2, 157 SOC_SINGLE("Validity Bit Control Switch", CS4265_SPDIF_CTL2,
158 3, 1, 0), 158 3, 1, 0),
159 SOC_ENUM("SPDIF Mono/Stereo", spdif_mono_stereo_enum), 159 SOC_ENUM("SPDIF Mono/Stereo", spdif_mono_stereo_enum),
160 SOC_SINGLE("MMTLR Data Switch", 0, 160 SOC_SINGLE("MMTLR Data Switch", CS4265_SPDIF_CTL2,
161 1, 1, 0), 161 0, 1, 0),
162 SOC_ENUM("Mono Channel Select", spdif_mono_select_enum), 162 SOC_ENUM("Mono Channel Select", spdif_mono_select_enum),
163 SND_SOC_BYTES("C Data Buffer", CS4265_C_DATA_BUFF, 24), 163 SND_SOC_BYTES("C Data Buffer", CS4265_C_DATA_BUFF, 24),
164}; 164};
diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c
index 92b7125ea169..1093f766d0d2 100644
--- a/sound/soc/codecs/max98373.c
+++ b/sound/soc/codecs/max98373.c
@@ -520,6 +520,7 @@ static bool max98373_volatile_reg(struct device *dev, unsigned int reg)
520{ 520{
521 switch (reg) { 521 switch (reg) {
522 case MAX98373_R2000_SW_RESET ... MAX98373_R2009_INT_FLAG3: 522 case MAX98373_R2000_SW_RESET ... MAX98373_R2009_INT_FLAG3:
523 case MAX98373_R203E_AMP_PATH_GAIN:
523 case MAX98373_R2054_MEAS_ADC_PVDD_CH_READBACK: 524 case MAX98373_R2054_MEAS_ADC_PVDD_CH_READBACK:
524 case MAX98373_R2055_MEAS_ADC_THERM_CH_READBACK: 525 case MAX98373_R2055_MEAS_ADC_THERM_CH_READBACK:
525 case MAX98373_R20B6_BDE_CUR_STATE_READBACK: 526 case MAX98373_R20B6_BDE_CUR_STATE_READBACK:
@@ -729,6 +730,7 @@ static int max98373_probe(struct snd_soc_component *component)
729 /* Software Reset */ 730 /* Software Reset */
730 regmap_write(max98373->regmap, 731 regmap_write(max98373->regmap,
731 MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET); 732 MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET);
733 usleep_range(10000, 11000);
732 734
733 /* IV default slot configuration */ 735 /* IV default slot configuration */
734 regmap_write(max98373->regmap, 736 regmap_write(max98373->regmap,
@@ -817,6 +819,7 @@ static int max98373_resume(struct device *dev)
817 819
818 regmap_write(max98373->regmap, 820 regmap_write(max98373->regmap,
819 MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET); 821 MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET);
822 usleep_range(10000, 11000);
820 regcache_cache_only(max98373->regmap, false); 823 regcache_cache_only(max98373->regmap, false);
821 regcache_sync(max98373->regmap); 824 regcache_sync(max98373->regmap);
822 return 0; 825 return 0;
diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c
index dca82dd6e3bf..32fe76c3134a 100644
--- a/sound/soc/codecs/rt5514.c
+++ b/sound/soc/codecs/rt5514.c
@@ -64,8 +64,8 @@ static const struct reg_sequence rt5514_patch[] = {
64 {RT5514_ANA_CTRL_LDO10, 0x00028604}, 64 {RT5514_ANA_CTRL_LDO10, 0x00028604},
65 {RT5514_ANA_CTRL_ADCFED, 0x00000800}, 65 {RT5514_ANA_CTRL_ADCFED, 0x00000800},
66 {RT5514_ASRC_IN_CTRL1, 0x00000003}, 66 {RT5514_ASRC_IN_CTRL1, 0x00000003},
67 {RT5514_DOWNFILTER0_CTRL3, 0x10000352}, 67 {RT5514_DOWNFILTER0_CTRL3, 0x10000342},
68 {RT5514_DOWNFILTER1_CTRL3, 0x10000352}, 68 {RT5514_DOWNFILTER1_CTRL3, 0x10000342},
69}; 69};
70 70
71static const struct reg_default rt5514_reg[] = { 71static const struct reg_default rt5514_reg[] = {
@@ -92,10 +92,10 @@ static const struct reg_default rt5514_reg[] = {
92 {RT5514_ASRC_IN_CTRL1, 0x00000003}, 92 {RT5514_ASRC_IN_CTRL1, 0x00000003},
93 {RT5514_DOWNFILTER0_CTRL1, 0x00020c2f}, 93 {RT5514_DOWNFILTER0_CTRL1, 0x00020c2f},
94 {RT5514_DOWNFILTER0_CTRL2, 0x00020c2f}, 94 {RT5514_DOWNFILTER0_CTRL2, 0x00020c2f},
95 {RT5514_DOWNFILTER0_CTRL3, 0x10000352}, 95 {RT5514_DOWNFILTER0_CTRL3, 0x10000342},
96 {RT5514_DOWNFILTER1_CTRL1, 0x00020c2f}, 96 {RT5514_DOWNFILTER1_CTRL1, 0x00020c2f},
97 {RT5514_DOWNFILTER1_CTRL2, 0x00020c2f}, 97 {RT5514_DOWNFILTER1_CTRL2, 0x00020c2f},
98 {RT5514_DOWNFILTER1_CTRL3, 0x10000352}, 98 {RT5514_DOWNFILTER1_CTRL3, 0x10000342},
99 {RT5514_ANA_CTRL_LDO10, 0x00028604}, 99 {RT5514_ANA_CTRL_LDO10, 0x00028604},
100 {RT5514_ANA_CTRL_LDO18_16, 0x02000345}, 100 {RT5514_ANA_CTRL_LDO18_16, 0x02000345},
101 {RT5514_ANA_CTRL_ADC12, 0x0000a2a8}, 101 {RT5514_ANA_CTRL_ADC12, 0x0000a2a8},
diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 640d400ca013..afe7d5b19313 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -750,8 +750,8 @@ static bool rt5682_readable_register(struct device *dev, unsigned int reg)
750} 750}
751 751
752static const DECLARE_TLV_DB_SCALE(hp_vol_tlv, -2250, 150, 0); 752static const DECLARE_TLV_DB_SCALE(hp_vol_tlv, -2250, 150, 0);
753static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -65625, 375, 0); 753static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -6525, 75, 0);
754static const DECLARE_TLV_DB_SCALE(adc_vol_tlv, -17625, 375, 0); 754static const DECLARE_TLV_DB_SCALE(adc_vol_tlv, -1725, 75, 0);
755static const DECLARE_TLV_DB_SCALE(adc_bst_tlv, 0, 1200, 0); 755static const DECLARE_TLV_DB_SCALE(adc_bst_tlv, 0, 1200, 0);
756 756
757/* {0, +20, +24, +30, +35, +40, +44, +50, +52} dB */ 757/* {0, +20, +24, +30, +35, +40, +44, +50, +52} dB */
@@ -1114,7 +1114,7 @@ static const struct snd_kcontrol_new rt5682_snd_controls[] = {
1114 1114
1115 /* DAC Digital Volume */ 1115 /* DAC Digital Volume */
1116 SOC_DOUBLE_TLV("DAC1 Playback Volume", RT5682_DAC1_DIG_VOL, 1116 SOC_DOUBLE_TLV("DAC1 Playback Volume", RT5682_DAC1_DIG_VOL,
1117 RT5682_L_VOL_SFT, RT5682_R_VOL_SFT, 175, 0, dac_vol_tlv), 1117 RT5682_L_VOL_SFT + 1, RT5682_R_VOL_SFT + 1, 86, 0, dac_vol_tlv),
1118 1118
1119 /* IN Boost Volume */ 1119 /* IN Boost Volume */
1120 SOC_SINGLE_TLV("CBJ Boost Volume", RT5682_CBJ_BST_CTRL, 1120 SOC_SINGLE_TLV("CBJ Boost Volume", RT5682_CBJ_BST_CTRL,
@@ -1124,7 +1124,7 @@ static const struct snd_kcontrol_new rt5682_snd_controls[] = {
1124 SOC_DOUBLE("STO1 ADC Capture Switch", RT5682_STO1_ADC_DIG_VOL, 1124 SOC_DOUBLE("STO1 ADC Capture Switch", RT5682_STO1_ADC_DIG_VOL,
1125 RT5682_L_MUTE_SFT, RT5682_R_MUTE_SFT, 1, 1), 1125 RT5682_L_MUTE_SFT, RT5682_R_MUTE_SFT, 1, 1),
1126 SOC_DOUBLE_TLV("STO1 ADC Capture Volume", RT5682_STO1_ADC_DIG_VOL, 1126 SOC_DOUBLE_TLV("STO1 ADC Capture Volume", RT5682_STO1_ADC_DIG_VOL,
1127 RT5682_L_VOL_SFT, RT5682_R_VOL_SFT, 127, 0, adc_vol_tlv), 1127 RT5682_L_VOL_SFT + 1, RT5682_R_VOL_SFT + 1, 63, 0, adc_vol_tlv),
1128 1128
1129 /* ADC Boost Volume Control */ 1129 /* ADC Boost Volume Control */
1130 SOC_DOUBLE_TLV("STO1 ADC Boost Gain Volume", RT5682_STO1_ADC_BOOST, 1130 SOC_DOUBLE_TLV("STO1 ADC Boost Gain Volume", RT5682_STO1_ADC_BOOST,
diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index d53680ac78e4..6df158669420 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -117,8 +117,7 @@ static int sigmadsp_ctrl_write(struct sigmadsp *sigmadsp,
117 struct sigmadsp_control *ctrl, void *data) 117 struct sigmadsp_control *ctrl, void *data)
118{ 118{
119 /* safeload loads up to 20 bytes in a atomic operation */ 119 /* safeload loads up to 20 bytes in a atomic operation */
120 if (ctrl->num_bytes > 4 && ctrl->num_bytes <= 20 && sigmadsp->ops && 120 if (ctrl->num_bytes <= 20 && sigmadsp->ops && sigmadsp->ops->safeload)
121 sigmadsp->ops->safeload)
122 return sigmadsp->ops->safeload(sigmadsp, ctrl->addr, data, 121 return sigmadsp->ops->safeload(sigmadsp, ctrl->addr, data,
123 ctrl->num_bytes); 122 ctrl->num_bytes);
124 else 123 else
diff --git a/sound/soc/codecs/tas6424.c b/sound/soc/codecs/tas6424.c
index 14999b999fd3..0d6145549a98 100644
--- a/sound/soc/codecs/tas6424.c
+++ b/sound/soc/codecs/tas6424.c
@@ -424,8 +424,10 @@ static void tas6424_fault_check_work(struct work_struct *work)
424 TAS6424_FAULT_PVDD_UV | 424 TAS6424_FAULT_PVDD_UV |
425 TAS6424_FAULT_VBAT_UV; 425 TAS6424_FAULT_VBAT_UV;
426 426
427 if (reg) 427 if (!reg) {
428 tas6424->last_fault1 = reg;
428 goto check_global_fault2_reg; 429 goto check_global_fault2_reg;
430 }
429 431
430 /* 432 /*
431 * Only flag errors once for a given occurrence. This is needed as 433 * Only flag errors once for a given occurrence. This is needed as
@@ -461,8 +463,10 @@ check_global_fault2_reg:
461 TAS6424_FAULT_OTSD_CH3 | 463 TAS6424_FAULT_OTSD_CH3 |
462 TAS6424_FAULT_OTSD_CH4; 464 TAS6424_FAULT_OTSD_CH4;
463 465
464 if (!reg) 466 if (!reg) {
467 tas6424->last_fault2 = reg;
465 goto check_warn_reg; 468 goto check_warn_reg;
469 }
466 470
467 if ((reg & TAS6424_FAULT_OTSD) && !(tas6424->last_fault2 & TAS6424_FAULT_OTSD)) 471 if ((reg & TAS6424_FAULT_OTSD) && !(tas6424->last_fault2 & TAS6424_FAULT_OTSD))
468 dev_crit(dev, "experienced a global overtemp shutdown\n"); 472 dev_crit(dev, "experienced a global overtemp shutdown\n");
@@ -497,8 +501,10 @@ check_warn_reg:
497 TAS6424_WARN_VDD_OTW_CH3 | 501 TAS6424_WARN_VDD_OTW_CH3 |
498 TAS6424_WARN_VDD_OTW_CH4; 502 TAS6424_WARN_VDD_OTW_CH4;
499 503
500 if (!reg) 504 if (!reg) {
505 tas6424->last_warn = reg;
501 goto out; 506 goto out;
507 }
502 508
503 if ((reg & TAS6424_WARN_VDD_UV) && !(tas6424->last_warn & TAS6424_WARN_VDD_UV)) 509 if ((reg & TAS6424_WARN_VDD_UV) && !(tas6424->last_warn & TAS6424_WARN_VDD_UV))
504 dev_warn(dev, "experienced a VDD under voltage condition\n"); 510 dev_warn(dev, "experienced a VDD under voltage condition\n");
diff --git a/sound/soc/codecs/wm8804-i2c.c b/sound/soc/codecs/wm8804-i2c.c
index f27464c2c5ba..79541960f45d 100644
--- a/sound/soc/codecs/wm8804-i2c.c
+++ b/sound/soc/codecs/wm8804-i2c.c
@@ -13,6 +13,7 @@
13#include <linux/init.h> 13#include <linux/init.h>
14#include <linux/module.h> 14#include <linux/module.h>
15#include <linux/i2c.h> 15#include <linux/i2c.h>
16#include <linux/acpi.h>
16 17
17#include "wm8804.h" 18#include "wm8804.h"
18 19
@@ -40,17 +41,29 @@ static const struct i2c_device_id wm8804_i2c_id[] = {
40}; 41};
41MODULE_DEVICE_TABLE(i2c, wm8804_i2c_id); 42MODULE_DEVICE_TABLE(i2c, wm8804_i2c_id);
42 43
44#if defined(CONFIG_OF)
43static const struct of_device_id wm8804_of_match[] = { 45static const struct of_device_id wm8804_of_match[] = {
44 { .compatible = "wlf,wm8804", }, 46 { .compatible = "wlf,wm8804", },
45 { } 47 { }
46}; 48};
47MODULE_DEVICE_TABLE(of, wm8804_of_match); 49MODULE_DEVICE_TABLE(of, wm8804_of_match);
50#endif
51
52#ifdef CONFIG_ACPI
53static const struct acpi_device_id wm8804_acpi_match[] = {
54 { "1AEC8804", 0 }, /* Wolfson PCI ID + part ID */
55 { "10138804", 0 }, /* Cirrus Logic PCI ID + part ID */
56 { },
57};
58MODULE_DEVICE_TABLE(acpi, wm8804_acpi_match);
59#endif
48 60
49static struct i2c_driver wm8804_i2c_driver = { 61static struct i2c_driver wm8804_i2c_driver = {
50 .driver = { 62 .driver = {
51 .name = "wm8804", 63 .name = "wm8804",
52 .pm = &wm8804_pm, 64 .pm = &wm8804_pm,
53 .of_match_table = wm8804_of_match, 65 .of_match_table = of_match_ptr(wm8804_of_match),
66 .acpi_match_table = ACPI_PTR(wm8804_acpi_match),
54 }, 67 },
55 .probe = wm8804_i2c_probe, 68 .probe = wm8804_i2c_probe,
56 .remove = wm8804_i2c_remove, 69 .remove = wm8804_i2c_remove,
diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
index 953d94d50586..ade34c26ad2f 100644
--- a/sound/soc/codecs/wm9712.c
+++ b/sound/soc/codecs/wm9712.c
@@ -719,7 +719,7 @@ static int wm9712_probe(struct platform_device *pdev)
719 719
720static struct platform_driver wm9712_component_driver = { 720static struct platform_driver wm9712_component_driver = {
721 .driver = { 721 .driver = {
722 .name = "wm9712-component", 722 .name = "wm9712-codec",
723 }, 723 },
724 724
725 .probe = wm9712_probe, 725 .probe = wm9712_probe,
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index d32844f94d74..b6dc524830b2 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -575,6 +575,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
575 BYT_RT5640_MONO_SPEAKER | 575 BYT_RT5640_MONO_SPEAKER |
576 BYT_RT5640_MCLK_EN), 576 BYT_RT5640_MCLK_EN),
577 }, 577 },
578 { /* Linx Linx7 tablet */
579 .matches = {
580 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LINX"),
581 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LINX7"),
582 },
583 .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
584 BYT_RT5640_MONO_SPEAKER |
585 BYT_RT5640_JD_NOT_INV |
586 BYT_RT5640_SSP0_AIF1 |
587 BYT_RT5640_MCLK_EN),
588 },
578 { /* MSI S100 tablet */ 589 { /* MSI S100 tablet */
579 .matches = { 590 .matches = {
580 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."), 591 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
@@ -602,6 +613,21 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
602 BYT_RT5640_SSP0_AIF1 | 613 BYT_RT5640_SSP0_AIF1 |
603 BYT_RT5640_MCLK_EN), 614 BYT_RT5640_MCLK_EN),
604 }, 615 },
616 { /* Onda v975w */
617 .matches = {
618 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
619 DMI_EXACT_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
620 /* The above are too generic, also match BIOS info */
621 DMI_EXACT_MATCH(DMI_BIOS_VERSION, "5.6.5"),
622 DMI_EXACT_MATCH(DMI_BIOS_DATE, "07/25/2014"),
623 },
624 .driver_data = (void *)(BYT_RT5640_IN1_MAP |
625 BYT_RT5640_JD_SRC_JD2_IN4N |
626 BYT_RT5640_OVCD_TH_2000UA |
627 BYT_RT5640_OVCD_SF_0P75 |
628 BYT_RT5640_DIFF_MIC |
629 BYT_RT5640_MCLK_EN),
630 },
605 { /* Pipo W4 */ 631 { /* Pipo W4 */
606 .matches = { 632 .matches = {
607 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), 633 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index dce649485649..1d17be0f78a0 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -834,7 +834,7 @@ static int skl_first_init(struct hdac_bus *bus)
834 return -ENXIO; 834 return -ENXIO;
835 } 835 }
836 836
837 skl_init_chip(bus, true); 837 snd_hdac_bus_reset_link(bus, true);
838 838
839 snd_hdac_bus_parse_capabilities(bus); 839 snd_hdac_bus_parse_capabilities(bus);
840 840
diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c
index dc94c5c53788..c6b51571be94 100644
--- a/sound/soc/qcom/qdsp6/q6routing.c
+++ b/sound/soc/qcom/qdsp6/q6routing.c
@@ -960,8 +960,10 @@ static int msm_routing_probe(struct snd_soc_component *c)
960{ 960{
961 int i; 961 int i;
962 962
963 for (i = 0; i < MAX_SESSIONS; i++) 963 for (i = 0; i < MAX_SESSIONS; i++) {
964 routing_data->sessions[i].port_id = -1; 964 routing_data->sessions[i].port_id = -1;
965 routing_data->sessions[i].fedai_id = -1;
966 }
965 967
966 return 0; 968 return 0;
967} 969}
diff --git a/sound/soc/sh/rcar/adg.c b/sound/soc/sh/rcar/adg.c
index 3a3064dda57f..051f96405346 100644
--- a/sound/soc/sh/rcar/adg.c
+++ b/sound/soc/sh/rcar/adg.c
@@ -462,6 +462,11 @@ static void rsnd_adg_get_clkout(struct rsnd_priv *priv,
462 goto rsnd_adg_get_clkout_end; 462 goto rsnd_adg_get_clkout_end;
463 463
464 req_size = prop->length / sizeof(u32); 464 req_size = prop->length / sizeof(u32);
465 if (req_size > REQ_SIZE) {
466 dev_err(dev,
467 "too many clock-frequency, use top %d\n", REQ_SIZE);
468 req_size = REQ_SIZE;
469 }
465 470
466 of_property_read_u32_array(np, "clock-frequency", req_rate, req_size); 471 of_property_read_u32_array(np, "clock-frequency", req_rate, req_size);
467 req_48kHz_rate = 0; 472 req_48kHz_rate = 0;
diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index f8425d8b44d2..d23c2bbff0cf 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -478,7 +478,7 @@ static int rsnd_status_update(u32 *status,
478 (func_call && (mod)->ops->fn) ? #fn : ""); \ 478 (func_call && (mod)->ops->fn) ? #fn : ""); \
479 if (func_call && (mod)->ops->fn) \ 479 if (func_call && (mod)->ops->fn) \
480 tmp = (mod)->ops->fn(mod, io, param); \ 480 tmp = (mod)->ops->fn(mod, io, param); \
481 if (tmp) \ 481 if (tmp && (tmp != -EPROBE_DEFER)) \
482 dev_err(dev, "%s[%d] : %s error %d\n", \ 482 dev_err(dev, "%s[%d] : %s error %d\n", \
483 rsnd_mod_name(mod), rsnd_mod_id(mod), \ 483 rsnd_mod_name(mod), rsnd_mod_id(mod), \
484 #fn, tmp); \ 484 #fn, tmp); \
@@ -958,12 +958,23 @@ static void rsnd_soc_dai_shutdown(struct snd_pcm_substream *substream,
958 rsnd_dai_stream_quit(io); 958 rsnd_dai_stream_quit(io);
959} 959}
960 960
961static int rsnd_soc_dai_prepare(struct snd_pcm_substream *substream,
962 struct snd_soc_dai *dai)
963{
964 struct rsnd_priv *priv = rsnd_dai_to_priv(dai);
965 struct rsnd_dai *rdai = rsnd_dai_to_rdai(dai);
966 struct rsnd_dai_stream *io = rsnd_rdai_to_io(rdai, substream);
967
968 return rsnd_dai_call(prepare, io, priv);
969}
970
961static const struct snd_soc_dai_ops rsnd_soc_dai_ops = { 971static const struct snd_soc_dai_ops rsnd_soc_dai_ops = {
962 .startup = rsnd_soc_dai_startup, 972 .startup = rsnd_soc_dai_startup,
963 .shutdown = rsnd_soc_dai_shutdown, 973 .shutdown = rsnd_soc_dai_shutdown,
964 .trigger = rsnd_soc_dai_trigger, 974 .trigger = rsnd_soc_dai_trigger,
965 .set_fmt = rsnd_soc_dai_set_fmt, 975 .set_fmt = rsnd_soc_dai_set_fmt,
966 .set_tdm_slot = rsnd_soc_set_dai_tdm_slot, 976 .set_tdm_slot = rsnd_soc_set_dai_tdm_slot,
977 .prepare = rsnd_soc_dai_prepare,
967}; 978};
968 979
969void rsnd_parse_connect_common(struct rsnd_dai *rdai, 980void rsnd_parse_connect_common(struct rsnd_dai *rdai,
@@ -1550,6 +1561,14 @@ exit_snd_probe:
1550 rsnd_dai_call(remove, &rdai->capture, priv); 1561 rsnd_dai_call(remove, &rdai->capture, priv);
1551 } 1562 }
1552 1563
1564 /*
1565 * adg is very special mod which can't use rsnd_dai_call(remove),
1566 * and it registers ADG clock on probe.
1567 * It should be unregister if probe failed.
1568 * Mainly it is assuming -EPROBE_DEFER case
1569 */
1570 rsnd_adg_remove(priv);
1571
1553 return ret; 1572 return ret;
1554} 1573}
1555 1574
diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c
index fe63ef8600d0..d65ea7bc4dac 100644
--- a/sound/soc/sh/rcar/dma.c
+++ b/sound/soc/sh/rcar/dma.c
@@ -241,6 +241,10 @@ static int rsnd_dmaen_attach(struct rsnd_dai_stream *io,
241 /* try to get DMAEngine channel */ 241 /* try to get DMAEngine channel */
242 chan = rsnd_dmaen_request_channel(io, mod_from, mod_to); 242 chan = rsnd_dmaen_request_channel(io, mod_from, mod_to);
243 if (IS_ERR_OR_NULL(chan)) { 243 if (IS_ERR_OR_NULL(chan)) {
244 /* Let's follow when -EPROBE_DEFER case */
245 if (PTR_ERR(chan) == -EPROBE_DEFER)
246 return PTR_ERR(chan);
247
244 /* 248 /*
245 * DMA failed. try to PIO mode 249 * DMA failed. try to PIO mode
246 * see 250 * see
diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h
index 96d93330b1e1..8f7a0abfa751 100644
--- a/sound/soc/sh/rcar/rsnd.h
+++ b/sound/soc/sh/rcar/rsnd.h
@@ -280,6 +280,9 @@ struct rsnd_mod_ops {
280 int (*nolock_stop)(struct rsnd_mod *mod, 280 int (*nolock_stop)(struct rsnd_mod *mod,
281 struct rsnd_dai_stream *io, 281 struct rsnd_dai_stream *io,
282 struct rsnd_priv *priv); 282 struct rsnd_priv *priv);
283 int (*prepare)(struct rsnd_mod *mod,
284 struct rsnd_dai_stream *io,
285 struct rsnd_priv *priv);
283}; 286};
284 287
285struct rsnd_dai_stream; 288struct rsnd_dai_stream;
@@ -309,6 +312,7 @@ struct rsnd_mod {
309 * H 0: fallback 312 * H 0: fallback
310 * H 0: hw_params 313 * H 0: hw_params
311 * H 0: pointer 314 * H 0: pointer
315 * H 0: prepare
312 */ 316 */
313#define __rsnd_mod_shift_nolock_start 0 317#define __rsnd_mod_shift_nolock_start 0
314#define __rsnd_mod_shift_nolock_stop 0 318#define __rsnd_mod_shift_nolock_stop 0
@@ -323,6 +327,7 @@ struct rsnd_mod {
323#define __rsnd_mod_shift_fallback 28 /* always called */ 327#define __rsnd_mod_shift_fallback 28 /* always called */
324#define __rsnd_mod_shift_hw_params 28 /* always called */ 328#define __rsnd_mod_shift_hw_params 28 /* always called */
325#define __rsnd_mod_shift_pointer 28 /* always called */ 329#define __rsnd_mod_shift_pointer 28 /* always called */
330#define __rsnd_mod_shift_prepare 28 /* always called */
326 331
327#define __rsnd_mod_add_probe 0 332#define __rsnd_mod_add_probe 0
328#define __rsnd_mod_add_remove 0 333#define __rsnd_mod_add_remove 0
@@ -337,6 +342,7 @@ struct rsnd_mod {
337#define __rsnd_mod_add_fallback 0 342#define __rsnd_mod_add_fallback 0
338#define __rsnd_mod_add_hw_params 0 343#define __rsnd_mod_add_hw_params 0
339#define __rsnd_mod_add_pointer 0 344#define __rsnd_mod_add_pointer 0
345#define __rsnd_mod_add_prepare 0
340 346
341#define __rsnd_mod_call_probe 0 347#define __rsnd_mod_call_probe 0
342#define __rsnd_mod_call_remove 0 348#define __rsnd_mod_call_remove 0
@@ -351,6 +357,7 @@ struct rsnd_mod {
351#define __rsnd_mod_call_pointer 0 357#define __rsnd_mod_call_pointer 0
352#define __rsnd_mod_call_nolock_start 0 358#define __rsnd_mod_call_nolock_start 0
353#define __rsnd_mod_call_nolock_stop 1 359#define __rsnd_mod_call_nolock_stop 1
360#define __rsnd_mod_call_prepare 0
354 361
355#define rsnd_mod_to_priv(mod) ((mod)->priv) 362#define rsnd_mod_to_priv(mod) ((mod)->priv)
356#define rsnd_mod_name(mod) ((mod)->ops->name) 363#define rsnd_mod_name(mod) ((mod)->ops->name)
diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index 8304e4ec9242..3f880ec66459 100644
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -283,7 +283,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
283 if (rsnd_ssi_is_multi_slave(mod, io)) 283 if (rsnd_ssi_is_multi_slave(mod, io))
284 return 0; 284 return 0;
285 285
286 if (ssi->usrcnt > 1) { 286 if (ssi->rate) {
287 if (ssi->rate != rate) { 287 if (ssi->rate != rate) {
288 dev_err(dev, "SSI parent/child should use same rate\n"); 288 dev_err(dev, "SSI parent/child should use same rate\n");
289 return -EINVAL; 289 return -EINVAL;
@@ -434,7 +434,6 @@ static int rsnd_ssi_init(struct rsnd_mod *mod,
434 struct rsnd_priv *priv) 434 struct rsnd_priv *priv)
435{ 435{
436 struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod); 436 struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
437 int ret;
438 437
439 if (!rsnd_ssi_is_run_mods(mod, io)) 438 if (!rsnd_ssi_is_run_mods(mod, io))
440 return 0; 439 return 0;
@@ -443,10 +442,6 @@ static int rsnd_ssi_init(struct rsnd_mod *mod,
443 442
444 rsnd_mod_power_on(mod); 443 rsnd_mod_power_on(mod);
445 444
446 ret = rsnd_ssi_master_clk_start(mod, io);
447 if (ret < 0)
448 return ret;
449
450 rsnd_ssi_config_init(mod, io); 445 rsnd_ssi_config_init(mod, io);
451 446
452 rsnd_ssi_register_setup(mod); 447 rsnd_ssi_register_setup(mod);
@@ -852,6 +847,13 @@ static int rsnd_ssi_pio_pointer(struct rsnd_mod *mod,
852 return 0; 847 return 0;
853} 848}
854 849
850static int rsnd_ssi_prepare(struct rsnd_mod *mod,
851 struct rsnd_dai_stream *io,
852 struct rsnd_priv *priv)
853{
854 return rsnd_ssi_master_clk_start(mod, io);
855}
856
855static struct rsnd_mod_ops rsnd_ssi_pio_ops = { 857static struct rsnd_mod_ops rsnd_ssi_pio_ops = {
856 .name = SSI_NAME, 858 .name = SSI_NAME,
857 .probe = rsnd_ssi_common_probe, 859 .probe = rsnd_ssi_common_probe,
@@ -864,6 +866,7 @@ static struct rsnd_mod_ops rsnd_ssi_pio_ops = {
864 .pointer = rsnd_ssi_pio_pointer, 866 .pointer = rsnd_ssi_pio_pointer,
865 .pcm_new = rsnd_ssi_pcm_new, 867 .pcm_new = rsnd_ssi_pcm_new,
866 .hw_params = rsnd_ssi_hw_params, 868 .hw_params = rsnd_ssi_hw_params,
869 .prepare = rsnd_ssi_prepare,
867}; 870};
868 871
869static int rsnd_ssi_dma_probe(struct rsnd_mod *mod, 872static int rsnd_ssi_dma_probe(struct rsnd_mod *mod,
@@ -940,6 +943,7 @@ static struct rsnd_mod_ops rsnd_ssi_dma_ops = {
940 .pcm_new = rsnd_ssi_pcm_new, 943 .pcm_new = rsnd_ssi_pcm_new,
941 .fallback = rsnd_ssi_fallback, 944 .fallback = rsnd_ssi_fallback,
942 .hw_params = rsnd_ssi_hw_params, 945 .hw_params = rsnd_ssi_hw_params,
946 .prepare = rsnd_ssi_prepare,
943}; 947};
944 948
945int rsnd_ssi_is_dma_mode(struct rsnd_mod *mod) 949int rsnd_ssi_is_dma_mode(struct rsnd_mod *mod)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 9cfe10d8040c..473eefe8658e 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1447,7 +1447,7 @@ static int soc_link_dai_widgets(struct snd_soc_card *card,
1447 sink = codec_dai->playback_widget; 1447 sink = codec_dai->playback_widget;
1448 source = cpu_dai->capture_widget; 1448 source = cpu_dai->capture_widget;
1449 if (sink && source) { 1449 if (sink && source) {
1450 ret = snd_soc_dapm_new_pcm(card, dai_link->params, 1450 ret = snd_soc_dapm_new_pcm(card, rtd, dai_link->params,
1451 dai_link->num_params, 1451 dai_link->num_params,
1452 source, sink); 1452 source, sink);
1453 if (ret != 0) { 1453 if (ret != 0) {
@@ -1460,7 +1460,7 @@ static int soc_link_dai_widgets(struct snd_soc_card *card,
1460 sink = cpu_dai->playback_widget; 1460 sink = cpu_dai->playback_widget;
1461 source = codec_dai->capture_widget; 1461 source = codec_dai->capture_widget;
1462 if (sink && source) { 1462 if (sink && source) {
1463 ret = snd_soc_dapm_new_pcm(card, dai_link->params, 1463 ret = snd_soc_dapm_new_pcm(card, rtd, dai_link->params,
1464 dai_link->num_params, 1464 dai_link->num_params,
1465 source, sink); 1465 source, sink);
1466 if (ret != 0) { 1466 if (ret != 0) {
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 7e96793050c9..461d951917c0 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3652,6 +3652,7 @@ static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
3652{ 3652{
3653 struct snd_soc_dapm_path *source_p, *sink_p; 3653 struct snd_soc_dapm_path *source_p, *sink_p;
3654 struct snd_soc_dai *source, *sink; 3654 struct snd_soc_dai *source, *sink;
3655 struct snd_soc_pcm_runtime *rtd = w->priv;
3655 const struct snd_soc_pcm_stream *config = w->params + w->params_select; 3656 const struct snd_soc_pcm_stream *config = w->params + w->params_select;
3656 struct snd_pcm_substream substream; 3657 struct snd_pcm_substream substream;
3657 struct snd_pcm_hw_params *params = NULL; 3658 struct snd_pcm_hw_params *params = NULL;
@@ -3711,6 +3712,7 @@ static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
3711 goto out; 3712 goto out;
3712 } 3713 }
3713 substream.runtime = runtime; 3714 substream.runtime = runtime;
3715 substream.private_data = rtd;
3714 3716
3715 switch (event) { 3717 switch (event) {
3716 case SND_SOC_DAPM_PRE_PMU: 3718 case SND_SOC_DAPM_PRE_PMU:
@@ -3895,6 +3897,7 @@ outfree_w_param:
3895} 3897}
3896 3898
3897int snd_soc_dapm_new_pcm(struct snd_soc_card *card, 3899int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
3900 struct snd_soc_pcm_runtime *rtd,
3898 const struct snd_soc_pcm_stream *params, 3901 const struct snd_soc_pcm_stream *params,
3899 unsigned int num_params, 3902 unsigned int num_params,
3900 struct snd_soc_dapm_widget *source, 3903 struct snd_soc_dapm_widget *source,
@@ -3963,6 +3966,7 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
3963 3966
3964 w->params = params; 3967 w->params = params;
3965 w->num_params = num_params; 3968 w->num_params = num_params;
3969 w->priv = rtd;
3966 3970
3967 ret = snd_soc_dapm_add_path(&card->dapm, source, w, NULL, NULL); 3971 ret = snd_soc_dapm_add_path(&card->dapm, source, w, NULL, NULL);
3968 if (ret) 3972 if (ret)
diff --git a/tools/arch/arm/include/uapi/asm/kvm.h b/tools/arch/arm/include/uapi/asm/kvm.h
index 16e006f708ca..4602464ebdfb 100644
--- a/tools/arch/arm/include/uapi/asm/kvm.h
+++ b/tools/arch/arm/include/uapi/asm/kvm.h
@@ -27,6 +27,7 @@
27#define __KVM_HAVE_GUEST_DEBUG 27#define __KVM_HAVE_GUEST_DEBUG
28#define __KVM_HAVE_IRQ_LINE 28#define __KVM_HAVE_IRQ_LINE
29#define __KVM_HAVE_READONLY_MEM 29#define __KVM_HAVE_READONLY_MEM
30#define __KVM_HAVE_VCPU_EVENTS
30 31
31#define KVM_COALESCED_MMIO_PAGE_OFFSET 1 32#define KVM_COALESCED_MMIO_PAGE_OFFSET 1
32 33
@@ -125,6 +126,18 @@ struct kvm_sync_regs {
125struct kvm_arch_memory_slot { 126struct kvm_arch_memory_slot {
126}; 127};
127 128
129/* for KVM_GET/SET_VCPU_EVENTS */
130struct kvm_vcpu_events {
131 struct {
132 __u8 serror_pending;
133 __u8 serror_has_esr;
134 /* Align it to 8 bytes */
135 __u8 pad[6];
136 __u64 serror_esr;
137 } exception;
138 __u32 reserved[12];
139};
140
128/* If you need to interpret the index values, here is the key: */ 141/* If you need to interpret the index values, here is the key: */
129#define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 142#define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000
130#define KVM_REG_ARM_COPROC_SHIFT 16 143#define KVM_REG_ARM_COPROC_SHIFT 16
diff --git a/tools/arch/arm64/include/uapi/asm/kvm.h b/tools/arch/arm64/include/uapi/asm/kvm.h
index 4e76630dd655..97c3478ee6e7 100644
--- a/tools/arch/arm64/include/uapi/asm/kvm.h
+++ b/tools/arch/arm64/include/uapi/asm/kvm.h
@@ -39,6 +39,7 @@
39#define __KVM_HAVE_GUEST_DEBUG 39#define __KVM_HAVE_GUEST_DEBUG
40#define __KVM_HAVE_IRQ_LINE 40#define __KVM_HAVE_IRQ_LINE
41#define __KVM_HAVE_READONLY_MEM 41#define __KVM_HAVE_READONLY_MEM
42#define __KVM_HAVE_VCPU_EVENTS
42 43
43#define KVM_COALESCED_MMIO_PAGE_OFFSET 1 44#define KVM_COALESCED_MMIO_PAGE_OFFSET 1
44 45
@@ -154,6 +155,18 @@ struct kvm_sync_regs {
154struct kvm_arch_memory_slot { 155struct kvm_arch_memory_slot {
155}; 156};
156 157
158/* for KVM_GET/SET_VCPU_EVENTS */
159struct kvm_vcpu_events {
160 struct {
161 __u8 serror_pending;
162 __u8 serror_has_esr;
163 /* Align it to 8 bytes */
164 __u8 pad[6];
165 __u64 serror_esr;
166 } exception;
167 __u32 reserved[12];
168};
169
157/* If you need to interpret the index values, here is the key: */ 170/* If you need to interpret the index values, here is the key: */
158#define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 171#define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000
159#define KVM_REG_ARM_COPROC_SHIFT 16 172#define KVM_REG_ARM_COPROC_SHIFT 16
diff --git a/tools/arch/s390/include/uapi/asm/kvm.h b/tools/arch/s390/include/uapi/asm/kvm.h
index 4cdaa55fabfe..9a50f02b9894 100644
--- a/tools/arch/s390/include/uapi/asm/kvm.h
+++ b/tools/arch/s390/include/uapi/asm/kvm.h
@@ -4,7 +4,7 @@
4/* 4/*
5 * KVM s390 specific structures and definitions 5 * KVM s390 specific structures and definitions
6 * 6 *
7 * Copyright IBM Corp. 2008 7 * Copyright IBM Corp. 2008, 2018
8 * 8 *
9 * Author(s): Carsten Otte <cotte@de.ibm.com> 9 * Author(s): Carsten Otte <cotte@de.ibm.com>
10 * Christian Borntraeger <borntraeger@de.ibm.com> 10 * Christian Borntraeger <borntraeger@de.ibm.com>
@@ -225,6 +225,7 @@ struct kvm_guest_debug_arch {
225#define KVM_SYNC_FPRS (1UL << 8) 225#define KVM_SYNC_FPRS (1UL << 8)
226#define KVM_SYNC_GSCB (1UL << 9) 226#define KVM_SYNC_GSCB (1UL << 9)
227#define KVM_SYNC_BPBC (1UL << 10) 227#define KVM_SYNC_BPBC (1UL << 10)
228#define KVM_SYNC_ETOKEN (1UL << 11)
228/* length and alignment of the sdnx as a power of two */ 229/* length and alignment of the sdnx as a power of two */
229#define SDNXC 8 230#define SDNXC 8
230#define SDNXL (1UL << SDNXC) 231#define SDNXL (1UL << SDNXC)
@@ -258,6 +259,8 @@ struct kvm_sync_regs {
258 struct { 259 struct {
259 __u64 reserved1[2]; 260 __u64 reserved1[2];
260 __u64 gscb[4]; 261 __u64 gscb[4];
262 __u64 etoken;
263 __u64 etoken_extension;
261 }; 264 };
262 }; 265 };
263}; 266};
diff --git a/tools/arch/x86/include/uapi/asm/kvm.h b/tools/arch/x86/include/uapi/asm/kvm.h
index c535c2fdea13..86299efa804a 100644
--- a/tools/arch/x86/include/uapi/asm/kvm.h
+++ b/tools/arch/x86/include/uapi/asm/kvm.h
@@ -378,4 +378,41 @@ struct kvm_sync_regs {
378#define KVM_X86_QUIRK_LINT0_REENABLED (1 << 0) 378#define KVM_X86_QUIRK_LINT0_REENABLED (1 << 0)
379#define KVM_X86_QUIRK_CD_NW_CLEARED (1 << 1) 379#define KVM_X86_QUIRK_CD_NW_CLEARED (1 << 1)
380 380
381#define KVM_STATE_NESTED_GUEST_MODE 0x00000001
382#define KVM_STATE_NESTED_RUN_PENDING 0x00000002
383
384#define KVM_STATE_NESTED_SMM_GUEST_MODE 0x00000001
385#define KVM_STATE_NESTED_SMM_VMXON 0x00000002
386
387struct kvm_vmx_nested_state {
388 __u64 vmxon_pa;
389 __u64 vmcs_pa;
390
391 struct {
392 __u16 flags;
393 } smm;
394};
395
396/* for KVM_CAP_NESTED_STATE */
397struct kvm_nested_state {
398 /* KVM_STATE_* flags */
399 __u16 flags;
400
401 /* 0 for VMX, 1 for SVM. */
402 __u16 format;
403
404 /* 128 for SVM, 128 + VMCS size for VMX. */
405 __u32 size;
406
407 union {
408 /* VMXON, VMCS */
409 struct kvm_vmx_nested_state vmx;
410
411 /* Pad the header to 128 bytes. */
412 __u8 pad[120];
413 };
414
415 __u8 data[0];
416};
417
381#endif /* _ASM_X86_KVM_H */ 418#endif /* _ASM_X86_KVM_H */
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
index d78aed86af09..8ff8cb1a11f4 100644
--- a/tools/hv/hv_fcopy_daemon.c
+++ b/tools/hv/hv_fcopy_daemon.c
@@ -234,6 +234,7 @@ int main(int argc, char *argv[])
234 break; 234 break;
235 235
236 default: 236 default:
237 error = HV_E_FAIL;
237 syslog(LOG_ERR, "Unknown operation: %d", 238 syslog(LOG_ERR, "Unknown operation: %d",
238 buffer.hdr.operation); 239 buffer.hdr.operation);
239 240
diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index dbf6e8bd98ba..bbb2a8ef367c 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -286,7 +286,7 @@ static int kvp_key_delete(int pool, const __u8 *key, int key_size)
286 * Found a match; just move the remaining 286 * Found a match; just move the remaining
287 * entries up. 287 * entries up.
288 */ 288 */
289 if (i == num_records) { 289 if (i == (num_records - 1)) {
290 kvp_file_info[pool].num_records--; 290 kvp_file_info[pool].num_records--;
291 kvp_update_file(pool); 291 kvp_update_file(pool);
292 return 0; 292 return 0;
diff --git a/tools/include/linux/lockdep.h b/tools/include/linux/lockdep.h
index 6b0c36a58fcb..e56997288f2b 100644
--- a/tools/include/linux/lockdep.h
+++ b/tools/include/linux/lockdep.h
@@ -30,9 +30,12 @@ struct task_struct {
30 struct held_lock held_locks[MAX_LOCK_DEPTH]; 30 struct held_lock held_locks[MAX_LOCK_DEPTH];
31 gfp_t lockdep_reclaim_gfp; 31 gfp_t lockdep_reclaim_gfp;
32 int pid; 32 int pid;
33 int state;
33 char comm[17]; 34 char comm[17];
34}; 35};
35 36
37#define TASK_RUNNING 0
38
36extern struct task_struct *__curr(void); 39extern struct task_struct *__curr(void);
37 40
38#define current (__curr()) 41#define current (__curr())
diff --git a/tools/include/linux/nmi.h b/tools/include/linux/nmi.h
new file mode 100644
index 000000000000..e69de29bb2d1
--- /dev/null
+++ b/tools/include/linux/nmi.h
diff --git a/tools/include/tools/libc_compat.h b/tools/include/tools/libc_compat.h
index 664ced8cb1b0..e907ba6f15e5 100644
--- a/tools/include/tools/libc_compat.h
+++ b/tools/include/tools/libc_compat.h
@@ -1,4 +1,4 @@
1// SPDX-License-Identifier: GPL-2.0+ 1// SPDX-License-Identifier: (LGPL-2.0+ OR BSD-2-Clause)
2/* Copyright (C) 2018 Netronome Systems, Inc. */ 2/* Copyright (C) 2018 Netronome Systems, Inc. */
3 3
4#ifndef __TOOLS_LIBC_COMPAT_H 4#ifndef __TOOLS_LIBC_COMPAT_H
diff --git a/tools/include/uapi/asm-generic/unistd.h b/tools/include/uapi/asm-generic/unistd.h
index 42990676a55e..df4bedb9b01c 100644
--- a/tools/include/uapi/asm-generic/unistd.h
+++ b/tools/include/uapi/asm-generic/unistd.h
@@ -734,9 +734,11 @@ __SYSCALL(__NR_pkey_free, sys_pkey_free)
734__SYSCALL(__NR_statx, sys_statx) 734__SYSCALL(__NR_statx, sys_statx)
735#define __NR_io_pgetevents 292 735#define __NR_io_pgetevents 292
736__SC_COMP(__NR_io_pgetevents, sys_io_pgetevents, compat_sys_io_pgetevents) 736__SC_COMP(__NR_io_pgetevents, sys_io_pgetevents, compat_sys_io_pgetevents)
737#define __NR_rseq 293
738__SYSCALL(__NR_rseq, sys_rseq)
737 739
738#undef __NR_syscalls 740#undef __NR_syscalls
739#define __NR_syscalls 293 741#define __NR_syscalls 294
740 742
741/* 743/*
742 * 32 bit systems traditionally used different 744 * 32 bit systems traditionally used different
diff --git a/tools/include/uapi/drm/drm.h b/tools/include/uapi/drm/drm.h
index 9c660e1688ab..300f336633f2 100644
--- a/tools/include/uapi/drm/drm.h
+++ b/tools/include/uapi/drm/drm.h
@@ -687,6 +687,15 @@ struct drm_get_cap {
687 */ 687 */
688#define DRM_CLIENT_CAP_ASPECT_RATIO 4 688#define DRM_CLIENT_CAP_ASPECT_RATIO 4
689 689
690/**
691 * DRM_CLIENT_CAP_WRITEBACK_CONNECTORS
692 *
693 * If set to 1, the DRM core will expose special connectors to be used for
694 * writing back to memory the scene setup in the commit. Depends on client
695 * also supporting DRM_CLIENT_CAP_ATOMIC
696 */
697#define DRM_CLIENT_CAP_WRITEBACK_CONNECTORS 5
698
690/** DRM_IOCTL_SET_CLIENT_CAP ioctl argument type */ 699/** DRM_IOCTL_SET_CLIENT_CAP ioctl argument type */
691struct drm_set_client_cap { 700struct drm_set_client_cap {
692 __u64 capability; 701 __u64 capability;
diff --git a/tools/include/uapi/linux/if_link.h b/tools/include/uapi/linux/if_link.h
index cf01b6824244..43391e2d1153 100644
--- a/tools/include/uapi/linux/if_link.h
+++ b/tools/include/uapi/linux/if_link.h
@@ -164,6 +164,8 @@ enum {
164 IFLA_CARRIER_UP_COUNT, 164 IFLA_CARRIER_UP_COUNT,
165 IFLA_CARRIER_DOWN_COUNT, 165 IFLA_CARRIER_DOWN_COUNT,
166 IFLA_NEW_IFINDEX, 166 IFLA_NEW_IFINDEX,
167 IFLA_MIN_MTU,
168 IFLA_MAX_MTU,
167 __IFLA_MAX 169 __IFLA_MAX
168}; 170};
169 171
@@ -334,6 +336,7 @@ enum {
334 IFLA_BRPORT_GROUP_FWD_MASK, 336 IFLA_BRPORT_GROUP_FWD_MASK,
335 IFLA_BRPORT_NEIGH_SUPPRESS, 337 IFLA_BRPORT_NEIGH_SUPPRESS,
336 IFLA_BRPORT_ISOLATED, 338 IFLA_BRPORT_ISOLATED,
339 IFLA_BRPORT_BACKUP_PORT,
337 __IFLA_BRPORT_MAX 340 __IFLA_BRPORT_MAX
338}; 341};
339#define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1) 342#define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1)
@@ -459,6 +462,16 @@ enum {
459 462
460#define IFLA_MACSEC_MAX (__IFLA_MACSEC_MAX - 1) 463#define IFLA_MACSEC_MAX (__IFLA_MACSEC_MAX - 1)
461 464
465/* XFRM section */
466enum {
467 IFLA_XFRM_UNSPEC,
468 IFLA_XFRM_LINK,
469 IFLA_XFRM_IF_ID,
470 __IFLA_XFRM_MAX
471};
472
473#define IFLA_XFRM_MAX (__IFLA_XFRM_MAX - 1)
474
462enum macsec_validation_type { 475enum macsec_validation_type {
463 MACSEC_VALIDATE_DISABLED = 0, 476 MACSEC_VALIDATE_DISABLED = 0,
464 MACSEC_VALIDATE_CHECK = 1, 477 MACSEC_VALIDATE_CHECK = 1,
@@ -920,6 +933,7 @@ enum {
920 XDP_ATTACHED_DRV, 933 XDP_ATTACHED_DRV,
921 XDP_ATTACHED_SKB, 934 XDP_ATTACHED_SKB,
922 XDP_ATTACHED_HW, 935 XDP_ATTACHED_HW,
936 XDP_ATTACHED_MULTI,
923}; 937};
924 938
925enum { 939enum {
@@ -928,6 +942,9 @@ enum {
928 IFLA_XDP_ATTACHED, 942 IFLA_XDP_ATTACHED,
929 IFLA_XDP_FLAGS, 943 IFLA_XDP_FLAGS,
930 IFLA_XDP_PROG_ID, 944 IFLA_XDP_PROG_ID,
945 IFLA_XDP_DRV_PROG_ID,
946 IFLA_XDP_SKB_PROG_ID,
947 IFLA_XDP_HW_PROG_ID,
931 __IFLA_XDP_MAX, 948 __IFLA_XDP_MAX,
932}; 949};
933 950
diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h
index b6270a3b38e9..07548de5c988 100644
--- a/tools/include/uapi/linux/kvm.h
+++ b/tools/include/uapi/linux/kvm.h
@@ -949,6 +949,9 @@ struct kvm_ppc_resize_hpt {
949#define KVM_CAP_GET_MSR_FEATURES 153 949#define KVM_CAP_GET_MSR_FEATURES 153
950#define KVM_CAP_HYPERV_EVENTFD 154 950#define KVM_CAP_HYPERV_EVENTFD 154
951#define KVM_CAP_HYPERV_TLBFLUSH 155 951#define KVM_CAP_HYPERV_TLBFLUSH 155
952#define KVM_CAP_S390_HPAGE_1M 156
953#define KVM_CAP_NESTED_STATE 157
954#define KVM_CAP_ARM_INJECT_SERROR_ESR 158
952 955
953#ifdef KVM_CAP_IRQ_ROUTING 956#ifdef KVM_CAP_IRQ_ROUTING
954 957
@@ -1391,6 +1394,9 @@ struct kvm_enc_region {
1391/* Available with KVM_CAP_HYPERV_EVENTFD */ 1394/* Available with KVM_CAP_HYPERV_EVENTFD */
1392#define KVM_HYPERV_EVENTFD _IOW(KVMIO, 0xbd, struct kvm_hyperv_eventfd) 1395#define KVM_HYPERV_EVENTFD _IOW(KVMIO, 0xbd, struct kvm_hyperv_eventfd)
1393 1396
1397/* Available with KVM_CAP_NESTED_STATE */
1398#define KVM_GET_NESTED_STATE _IOWR(KVMIO, 0xbe, struct kvm_nested_state)
1399#define KVM_SET_NESTED_STATE _IOW(KVMIO, 0xbf, struct kvm_nested_state)
1394 1400
1395/* Secure Encrypted Virtualization command */ 1401/* Secure Encrypted Virtualization command */
1396enum sev_cmd_id { 1402enum sev_cmd_id {
diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
index eeb787b1c53c..f35eb72739c0 100644
--- a/tools/include/uapi/linux/perf_event.h
+++ b/tools/include/uapi/linux/perf_event.h
@@ -144,7 +144,7 @@ enum perf_event_sample_format {
144 144
145 PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */ 145 PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */
146 146
147 __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, 147 __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, /* non-ABI; internal use */
148}; 148};
149 149
150/* 150/*
diff --git a/tools/include/uapi/linux/vhost.h b/tools/include/uapi/linux/vhost.h
index c51f8e5cc608..84c3de89696a 100644
--- a/tools/include/uapi/linux/vhost.h
+++ b/tools/include/uapi/linux/vhost.h
@@ -65,6 +65,7 @@ struct vhost_iotlb_msg {
65}; 65};
66 66
67#define VHOST_IOTLB_MSG 0x1 67#define VHOST_IOTLB_MSG 0x1
68#define VHOST_IOTLB_MSG_V2 0x2
68 69
69struct vhost_msg { 70struct vhost_msg {
70 int type; 71 int type;
@@ -74,6 +75,15 @@ struct vhost_msg {
74 }; 75 };
75}; 76};
76 77
78struct vhost_msg_v2 {
79 __u32 type;
80 __u32 reserved;
81 union {
82 struct vhost_iotlb_msg iotlb;
83 __u8 padding[64];
84 };
85};
86
77struct vhost_memory_region { 87struct vhost_memory_region {
78 __u64 guest_phys_addr; 88 __u64 guest_phys_addr;
79 __u64 memory_size; /* bytes */ 89 __u64 memory_size; /* bytes */
@@ -160,6 +170,14 @@ struct vhost_memory {
160#define VHOST_GET_VRING_BUSYLOOP_TIMEOUT _IOW(VHOST_VIRTIO, 0x24, \ 170#define VHOST_GET_VRING_BUSYLOOP_TIMEOUT _IOW(VHOST_VIRTIO, 0x24, \
161 struct vhost_vring_state) 171 struct vhost_vring_state)
162 172
173/* Set or get vhost backend capability */
174
175/* Use message type V2 */
176#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1
177
178#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64)
179#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)
180
163/* VHOST_NET specific defines */ 181/* VHOST_NET specific defines */
164 182
165/* Attach virtio net ring to a raw socket, or tap device. 183/* Attach virtio net ring to a raw socket, or tap device.
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index 439b8a27488d..195ba486640f 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -1325,7 +1325,7 @@ class Tui(object):
1325 msg = '' 1325 msg = ''
1326 while True: 1326 while True:
1327 self.screen.erase() 1327 self.screen.erase()
1328 self.screen.addstr(0, 0, 'Set update interval (defaults to %fs).' % 1328 self.screen.addstr(0, 0, 'Set update interval (defaults to %.1fs).' %
1329 DELAY_DEFAULT, curses.A_BOLD) 1329 DELAY_DEFAULT, curses.A_BOLD)
1330 self.screen.addstr(4, 0, msg) 1330 self.screen.addstr(4, 0, msg)
1331 self.screen.addstr(2, 0, 'Change delay from %.1fs to ' % 1331 self.screen.addstr(2, 0, 'Change delay from %.1fs to ' %
diff --git a/tools/lib/bpf/Build b/tools/lib/bpf/Build
index 13a861135127..6eb9bacd1948 100644
--- a/tools/lib/bpf/Build
+++ b/tools/lib/bpf/Build
@@ -1 +1 @@
libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o str_error.o
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 2abd0f112627..bdb94939fd60 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -50,6 +50,7 @@
50#include "libbpf.h" 50#include "libbpf.h"
51#include "bpf.h" 51#include "bpf.h"
52#include "btf.h" 52#include "btf.h"
53#include "str_error.h"
53 54
54#ifndef EM_BPF 55#ifndef EM_BPF
55#define EM_BPF 247 56#define EM_BPF 247
@@ -469,7 +470,7 @@ static int bpf_object__elf_init(struct bpf_object *obj)
469 obj->efile.fd = open(obj->path, O_RDONLY); 470 obj->efile.fd = open(obj->path, O_RDONLY);
470 if (obj->efile.fd < 0) { 471 if (obj->efile.fd < 0) {
471 char errmsg[STRERR_BUFSIZE]; 472 char errmsg[STRERR_BUFSIZE];
472 char *cp = strerror_r(errno, errmsg, sizeof(errmsg)); 473 char *cp = str_error(errno, errmsg, sizeof(errmsg));
473 474
474 pr_warning("failed to open %s: %s\n", obj->path, cp); 475 pr_warning("failed to open %s: %s\n", obj->path, cp);
475 return -errno; 476 return -errno;
@@ -810,8 +811,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
810 data->d_size, name, idx); 811 data->d_size, name, idx);
811 if (err) { 812 if (err) {
812 char errmsg[STRERR_BUFSIZE]; 813 char errmsg[STRERR_BUFSIZE];
813 char *cp = strerror_r(-err, errmsg, 814 char *cp = str_error(-err, errmsg, sizeof(errmsg));
814 sizeof(errmsg));
815 815
816 pr_warning("failed to alloc program %s (%s): %s", 816 pr_warning("failed to alloc program %s (%s): %s",
817 name, obj->path, cp); 817 name, obj->path, cp);
@@ -1140,7 +1140,7 @@ bpf_object__create_maps(struct bpf_object *obj)
1140 1140
1141 *pfd = bpf_create_map_xattr(&create_attr); 1141 *pfd = bpf_create_map_xattr(&create_attr);
1142 if (*pfd < 0 && create_attr.btf_key_type_id) { 1142 if (*pfd < 0 && create_attr.btf_key_type_id) {
1143 cp = strerror_r(errno, errmsg, sizeof(errmsg)); 1143 cp = str_error(errno, errmsg, sizeof(errmsg));
1144 pr_warning("Error in bpf_create_map_xattr(%s):%s(%d). Retrying without BTF.\n", 1144 pr_warning("Error in bpf_create_map_xattr(%s):%s(%d). Retrying without BTF.\n",
1145 map->name, cp, errno); 1145 map->name, cp, errno);
1146 create_attr.btf_fd = 0; 1146 create_attr.btf_fd = 0;
@@ -1155,7 +1155,7 @@ bpf_object__create_maps(struct bpf_object *obj)
1155 size_t j; 1155 size_t j;
1156 1156
1157 err = *pfd; 1157 err = *pfd;
1158 cp = strerror_r(errno, errmsg, sizeof(errmsg)); 1158 cp = str_error(errno, errmsg, sizeof(errmsg));
1159 pr_warning("failed to create map (name: '%s'): %s\n", 1159 pr_warning("failed to create map (name: '%s'): %s\n",
1160 map->name, cp); 1160 map->name, cp);
1161 for (j = 0; j < i; j++) 1161 for (j = 0; j < i; j++)
@@ -1339,7 +1339,7 @@ load_program(enum bpf_prog_type type, enum bpf_attach_type expected_attach_type,
1339 } 1339 }
1340 1340
1341 ret = -LIBBPF_ERRNO__LOAD; 1341 ret = -LIBBPF_ERRNO__LOAD;
1342 cp = strerror_r(errno, errmsg, sizeof(errmsg)); 1342 cp = str_error(errno, errmsg, sizeof(errmsg));
1343 pr_warning("load bpf program failed: %s\n", cp); 1343 pr_warning("load bpf program failed: %s\n", cp);
1344 1344
1345 if (log_buf && log_buf[0] != '\0') { 1345 if (log_buf && log_buf[0] != '\0') {
@@ -1654,7 +1654,7 @@ static int check_path(const char *path)
1654 1654
1655 dir = dirname(dname); 1655 dir = dirname(dname);
1656 if (statfs(dir, &st_fs)) { 1656 if (statfs(dir, &st_fs)) {
1657 cp = strerror_r(errno, errmsg, sizeof(errmsg)); 1657 cp = str_error(errno, errmsg, sizeof(errmsg));
1658 pr_warning("failed to statfs %s: %s\n", dir, cp); 1658 pr_warning("failed to statfs %s: %s\n", dir, cp);
1659 err = -errno; 1659 err = -errno;
1660 } 1660 }
@@ -1690,7 +1690,7 @@ int bpf_program__pin_instance(struct bpf_program *prog, const char *path,
1690 } 1690 }
1691 1691
1692 if (bpf_obj_pin(prog->instances.fds[instance], path)) { 1692 if (bpf_obj_pin(prog->instances.fds[instance], path)) {
1693 cp = strerror_r(errno, errmsg, sizeof(errmsg)); 1693 cp = str_error(errno, errmsg, sizeof(errmsg));
1694 pr_warning("failed to pin program: %s\n", cp); 1694 pr_warning("failed to pin program: %s\n", cp);
1695 return -errno; 1695 return -errno;
1696 } 1696 }
@@ -1708,7 +1708,7 @@ static int make_dir(const char *path)
1708 err = -errno; 1708 err = -errno;
1709 1709
1710 if (err) { 1710 if (err) {
1711 cp = strerror_r(-err, errmsg, sizeof(errmsg)); 1711 cp = str_error(-err, errmsg, sizeof(errmsg));
1712 pr_warning("failed to mkdir %s: %s\n", path, cp); 1712 pr_warning("failed to mkdir %s: %s\n", path, cp);
1713 } 1713 }
1714 return err; 1714 return err;
@@ -1770,7 +1770,7 @@ int bpf_map__pin(struct bpf_map *map, const char *path)
1770 } 1770 }
1771 1771
1772 if (bpf_obj_pin(map->fd, path)) { 1772 if (bpf_obj_pin(map->fd, path)) {
1773 cp = strerror_r(errno, errmsg, sizeof(errmsg)); 1773 cp = str_error(errno, errmsg, sizeof(errmsg));
1774 pr_warning("failed to pin map: %s\n", cp); 1774 pr_warning("failed to pin map: %s\n", cp);
1775 return -errno; 1775 return -errno;
1776 } 1776 }
diff --git a/tools/lib/bpf/str_error.c b/tools/lib/bpf/str_error.c
new file mode 100644
index 000000000000..b8798114a357
--- /dev/null
+++ b/tools/lib/bpf/str_error.c
@@ -0,0 +1,18 @@
1// SPDX-License-Identifier: LGPL-2.1
2#undef _GNU_SOURCE
3#include <string.h>
4#include <stdio.h>
5#include "str_error.h"
6
7/*
8 * Wrapper to allow for building in non-GNU systems such as Alpine Linux's musl
9 * libc, while checking strerror_r() return to avoid having to check this in
10 * all places calling it.
11 */
12char *str_error(int err, char *dst, int len)
13{
14 int ret = strerror_r(err, dst, len);
15 if (ret)
16 snprintf(dst, len, "ERROR: strerror_r(%d)=%d", err, ret);
17 return dst;
18}
diff --git a/tools/lib/bpf/str_error.h b/tools/lib/bpf/str_error.h
new file mode 100644
index 000000000000..355b1db571d1
--- /dev/null
+++ b/tools/lib/bpf/str_error.h
@@ -0,0 +1,6 @@
1// SPDX-License-Identifier: LGPL-2.1
2#ifndef BPF_STR_ERROR
3#define BPF_STR_ERROR
4
5char *str_error(int err, char *dst, int len);
6#endif // BPF_STR_ERROR
diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
index 42261a9b280e..ac841bc5c35b 100644
--- a/tools/perf/Documentation/Makefile
+++ b/tools/perf/Documentation/Makefile
@@ -280,7 +280,7 @@ $(MAN_HTML): $(OUTPUT)%.html : %.txt
280 mv $@+ $@ 280 mv $@+ $@
281 281
282ifdef USE_ASCIIDOCTOR 282ifdef USE_ASCIIDOCTOR
283$(OUTPUT)%.1 $(OUTPUT)%.5 $(OUTPUT)%.7 : $(OUTPUT)%.txt 283$(OUTPUT)%.1 $(OUTPUT)%.5 $(OUTPUT)%.7 : %.txt
284 $(QUIET_ASCIIDOC)$(RM) $@+ $@ && \ 284 $(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
285 $(ASCIIDOC) -b manpage -d manpage \ 285 $(ASCIIDOC) -b manpage -d manpage \
286 $(ASCIIDOC_EXTRA) -aperf_version=$(PERF_VERSION) -o $@+ $< && \ 286 $(ASCIIDOC_EXTRA) -aperf_version=$(PERF_VERSION) -o $@+ $< && \
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index b3d1b12a5081..5224ade3d5af 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -777,14 +777,12 @@ endif
777 $(call QUIET_INSTALL, libexec) \ 777 $(call QUIET_INSTALL, libexec) \
778 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)' 778 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)'
779ifndef NO_LIBBPF 779ifndef NO_LIBBPF
780 $(call QUIET_INSTALL, lib) \ 780 $(call QUIET_INSTALL, bpf-headers) \
781 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf' 781 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf'; \
782 $(call QUIET_INSTALL, include/bpf) \ 782 $(INSTALL) include/bpf/*.h -t '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf'
783 $(INSTALL) include/bpf/*.h '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf' 783 $(call QUIET_INSTALL, bpf-examples) \
784 $(call QUIET_INSTALL, lib) \ 784 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'; \
785 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf' 785 $(INSTALL) examples/bpf/*.c -t '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'
786 $(call QUIET_INSTALL, examples/bpf) \
787 $(INSTALL) examples/bpf/*.c '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'
788endif 786endif
789 $(call QUIET_INSTALL, perf-archive) \ 787 $(call QUIET_INSTALL, perf-archive) \
790 $(INSTALL) $(OUTPUT)perf-archive -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)' 788 $(INSTALL) $(OUTPUT)perf-archive -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)'
diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
index f013b115dc86..dbef716a1913 100644
--- a/tools/perf/arch/arm64/Makefile
+++ b/tools/perf/arch/arm64/Makefile
@@ -11,7 +11,8 @@ PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET := 1
11 11
12out := $(OUTPUT)arch/arm64/include/generated/asm 12out := $(OUTPUT)arch/arm64/include/generated/asm
13header := $(out)/syscalls.c 13header := $(out)/syscalls.c
14sysdef := $(srctree)/tools/include/uapi/asm-generic/unistd.h 14incpath := $(srctree)/tools
15sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
15sysprf := $(srctree)/tools/perf/arch/arm64/entry/syscalls/ 16sysprf := $(srctree)/tools/perf/arch/arm64/entry/syscalls/
16systbl := $(sysprf)/mksyscalltbl 17systbl := $(sysprf)/mksyscalltbl
17 18
@@ -19,7 +20,7 @@ systbl := $(sysprf)/mksyscalltbl
19_dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)') 20_dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)')
20 21
21$(header): $(sysdef) $(systbl) 22$(header): $(sysdef) $(systbl)
22 $(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(sysdef) > $@ 23 $(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@
23 24
24clean:: 25clean::
25 $(call QUIET_CLEAN, arm64) $(RM) $(header) 26 $(call QUIET_CLEAN, arm64) $(RM) $(header)
diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 52e197317d3e..2dbb8cade048 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -11,7 +11,8 @@
11 11
12gcc=$1 12gcc=$1
13hostcc=$2 13hostcc=$2
14input=$3 14incpath=$3
15input=$4
15 16
16if ! test -r $input; then 17if ! test -r $input; then
17 echo "Could not read input file" >&2 18 echo "Could not read input file" >&2
@@ -28,7 +29,6 @@ create_table_from_c()
28 29
29 cat <<-_EoHEADER 30 cat <<-_EoHEADER
30 #include <stdio.h> 31 #include <stdio.h>
31 #define __ARCH_WANT_RENAMEAT
32 #include "$input" 32 #include "$input"
33 int main(int argc, char *argv[]) 33 int main(int argc, char *argv[])
34 { 34 {
@@ -42,7 +42,7 @@ create_table_from_c()
42 printf "%s\n" " printf(\"#define SYSCALLTBL_ARM64_MAX_ID %d\\n\", __NR_$last_sc);" 42 printf "%s\n" " printf(\"#define SYSCALLTBL_ARM64_MAX_ID %d\\n\", __NR_$last_sc);"
43 printf "}\n" 43 printf "}\n"
44 44
45 } | $hostcc -o $create_table_exe -x c - 45 } | $hostcc -I $incpath/include/uapi -o $create_table_exe -x c -
46 46
47 $create_table_exe 47 $create_table_exe
48 48
diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c
index 20e7d74d86cd..10a44e946f77 100644
--- a/tools/perf/arch/powerpc/util/sym-handling.c
+++ b/tools/perf/arch/powerpc/util/sym-handling.c
@@ -22,15 +22,16 @@ bool elf__needs_adjust_symbols(GElf_Ehdr ehdr)
22 22
23#endif 23#endif
24 24
25#if !defined(_CALL_ELF) || _CALL_ELF != 2
26int arch__choose_best_symbol(struct symbol *syma, 25int arch__choose_best_symbol(struct symbol *syma,
27 struct symbol *symb __maybe_unused) 26 struct symbol *symb __maybe_unused)
28{ 27{
29 char *sym = syma->name; 28 char *sym = syma->name;
30 29
30#if !defined(_CALL_ELF) || _CALL_ELF != 2
31 /* Skip over any initial dot */ 31 /* Skip over any initial dot */
32 if (*sym == '.') 32 if (*sym == '.')
33 sym++; 33 sym++;
34#endif
34 35
35 /* Avoid "SyS" kernel syscall aliases */ 36 /* Avoid "SyS" kernel syscall aliases */
36 if (strlen(sym) >= 3 && !strncmp(sym, "SyS", 3)) 37 if (strlen(sym) >= 3 && !strncmp(sym, "SyS", 3))
@@ -41,6 +42,7 @@ int arch__choose_best_symbol(struct symbol *syma,
41 return SYMBOL_A; 42 return SYMBOL_A;
42} 43}
43 44
45#if !defined(_CALL_ELF) || _CALL_ELF != 2
44/* Allow matching against dot variants */ 46/* Allow matching against dot variants */
45int arch__compare_symbol_names(const char *namea, const char *nameb) 47int arch__compare_symbol_names(const char *namea, const char *nameb)
46{ 48{
diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h
index c1bd979b957b..613709cfbbd0 100644
--- a/tools/perf/arch/x86/include/arch-tests.h
+++ b/tools/perf/arch/x86/include/arch-tests.h
@@ -9,6 +9,7 @@ struct test;
9int test__rdpmc(struct test *test __maybe_unused, int subtest); 9int test__rdpmc(struct test *test __maybe_unused, int subtest);
10int test__perf_time_to_tsc(struct test *test __maybe_unused, int subtest); 10int test__perf_time_to_tsc(struct test *test __maybe_unused, int subtest);
11int test__insn_x86(struct test *test __maybe_unused, int subtest); 11int test__insn_x86(struct test *test __maybe_unused, int subtest);
12int test__bp_modify(struct test *test, int subtest);
12 13
13#ifdef HAVE_DWARF_UNWIND_SUPPORT 14#ifdef HAVE_DWARF_UNWIND_SUPPORT
14struct thread; 15struct thread;
diff --git a/tools/perf/arch/x86/tests/Build b/tools/perf/arch/x86/tests/Build
index 8e2c5a38c3b9..586849ff83a0 100644
--- a/tools/perf/arch/x86/tests/Build
+++ b/tools/perf/arch/x86/tests/Build
@@ -5,3 +5,4 @@ libperf-y += arch-tests.o
5libperf-y += rdpmc.o 5libperf-y += rdpmc.o
6libperf-y += perf-time-to-tsc.o 6libperf-y += perf-time-to-tsc.o
7libperf-$(CONFIG_AUXTRACE) += insn-x86.o 7libperf-$(CONFIG_AUXTRACE) += insn-x86.o
8libperf-$(CONFIG_X86_64) += bp-modify.o
diff --git a/tools/perf/arch/x86/tests/arch-tests.c b/tools/perf/arch/x86/tests/arch-tests.c
index cc1802ff5410..d47d3f8e3c8e 100644
--- a/tools/perf/arch/x86/tests/arch-tests.c
+++ b/tools/perf/arch/x86/tests/arch-tests.c
@@ -24,6 +24,12 @@ struct test arch_tests[] = {
24 .func = test__insn_x86, 24 .func = test__insn_x86,
25 }, 25 },
26#endif 26#endif
27#if defined(__x86_64__)
28 {
29 .desc = "x86 bp modify",
30 .func = test__bp_modify,
31 },
32#endif
27 { 33 {
28 .func = NULL, 34 .func = NULL,
29 }, 35 },
diff --git a/tools/perf/arch/x86/tests/bp-modify.c b/tools/perf/arch/x86/tests/bp-modify.c
new file mode 100644
index 000000000000..f53e4406709f
--- /dev/null
+++ b/tools/perf/arch/x86/tests/bp-modify.c
@@ -0,0 +1,213 @@
1// SPDX-License-Identifier: GPL-2.0
2#include <linux/compiler.h>
3#include <sys/types.h>
4#include <sys/wait.h>
5#include <sys/user.h>
6#include <syscall.h>
7#include <unistd.h>
8#include <stdio.h>
9#include <stdlib.h>
10#include <sys/ptrace.h>
11#include <asm/ptrace.h>
12#include <errno.h>
13#include "debug.h"
14#include "tests/tests.h"
15#include "arch-tests.h"
16
17static noinline int bp_1(void)
18{
19 pr_debug("in %s\n", __func__);
20 return 0;
21}
22
23static noinline int bp_2(void)
24{
25 pr_debug("in %s\n", __func__);
26 return 0;
27}
28
29static int spawn_child(void)
30{
31 int child = fork();
32
33 if (child == 0) {
34 /*
35 * The child sets itself for as tracee and
36 * waits in signal for parent to trace it,
37 * then it calls bp_1 and quits.
38 */
39 int err = ptrace(PTRACE_TRACEME, 0, NULL, NULL);
40
41 if (err) {
42 pr_debug("failed to PTRACE_TRACEME\n");
43 exit(1);
44 }
45
46 raise(SIGCONT);
47 bp_1();
48 exit(0);
49 }
50
51 return child;
52}
53
54/*
55 * This tests creates HW breakpoint, tries to
56 * change it and checks it was properly changed.
57 */
58static int bp_modify1(void)
59{
60 pid_t child;
61 int status;
62 unsigned long rip = 0, dr7 = 1;
63
64 child = spawn_child();
65
66 waitpid(child, &status, 0);
67 if (WIFEXITED(status)) {
68 pr_debug("tracee exited prematurely 1\n");
69 return TEST_FAIL;
70 }
71
72 /*
73 * The parent does following steps:
74 * - creates a new breakpoint (id 0) for bp_2 function
75 * - changes that breakponit to bp_1 function
76 * - waits for the breakpoint to hit and checks
77 * it has proper rip of bp_1 function
78 * - detaches the child
79 */
80 if (ptrace(PTRACE_POKEUSER, child,
81 offsetof(struct user, u_debugreg[0]), bp_2)) {
82 pr_debug("failed to set breakpoint, 1st time: %s\n",
83 strerror(errno));
84 goto out;
85 }
86
87 if (ptrace(PTRACE_POKEUSER, child,
88 offsetof(struct user, u_debugreg[0]), bp_1)) {
89 pr_debug("failed to set breakpoint, 2nd time: %s\n",
90 strerror(errno));
91 goto out;
92 }
93
94 if (ptrace(PTRACE_POKEUSER, child,
95 offsetof(struct user, u_debugreg[7]), dr7)) {
96 pr_debug("failed to set dr7: %s\n", strerror(errno));
97 goto out;
98 }
99
100 if (ptrace(PTRACE_CONT, child, NULL, NULL)) {
101 pr_debug("failed to PTRACE_CONT: %s\n", strerror(errno));
102 goto out;
103 }
104
105 waitpid(child, &status, 0);
106 if (WIFEXITED(status)) {
107 pr_debug("tracee exited prematurely 2\n");
108 return TEST_FAIL;
109 }
110
111 rip = ptrace(PTRACE_PEEKUSER, child,
112 offsetof(struct user_regs_struct, rip), NULL);
113 if (rip == (unsigned long) -1) {
114 pr_debug("failed to PTRACE_PEEKUSER: %s\n",
115 strerror(errno));
116 goto out;
117 }
118
119 pr_debug("rip %lx, bp_1 %p\n", rip, bp_1);
120
121out:
122 if (ptrace(PTRACE_DETACH, child, NULL, NULL)) {
123 pr_debug("failed to PTRACE_DETACH: %s", strerror(errno));
124 return TEST_FAIL;
125 }
126
127 return rip == (unsigned long) bp_1 ? TEST_OK : TEST_FAIL;
128}
129
130/*
131 * This tests creates HW breakpoint, tries to
132 * change it to bogus value and checks the original
133 * breakpoint is hit.
134 */
135static int bp_modify2(void)
136{
137 pid_t child;
138 int status;
139 unsigned long rip = 0, dr7 = 1;
140
141 child = spawn_child();
142
143 waitpid(child, &status, 0);
144 if (WIFEXITED(status)) {
145 pr_debug("tracee exited prematurely 1\n");
146 return TEST_FAIL;
147 }
148
149 /*
150 * The parent does following steps:
151 * - creates a new breakpoint (id 0) for bp_1 function
152 * - tries to change that breakpoint to (-1) address
153 * - waits for the breakpoint to hit and checks
154 * it has proper rip of bp_1 function
155 * - detaches the child
156 */
157 if (ptrace(PTRACE_POKEUSER, child,
158 offsetof(struct user, u_debugreg[0]), bp_1)) {
159 pr_debug("failed to set breakpoint: %s\n",
160 strerror(errno));
161 goto out;
162 }
163
164 if (ptrace(PTRACE_POKEUSER, child,
165 offsetof(struct user, u_debugreg[7]), dr7)) {
166 pr_debug("failed to set dr7: %s\n", strerror(errno));
167 goto out;
168 }
169
170 if (!ptrace(PTRACE_POKEUSER, child,
171 offsetof(struct user, u_debugreg[0]), (unsigned long) (-1))) {
172 pr_debug("failed, breakpoint set to bogus address\n");
173 goto out;
174 }
175
176 if (ptrace(PTRACE_CONT, child, NULL, NULL)) {
177 pr_debug("failed to PTRACE_CONT: %s\n", strerror(errno));
178 goto out;
179 }
180
181 waitpid(child, &status, 0);
182 if (WIFEXITED(status)) {
183 pr_debug("tracee exited prematurely 2\n");
184 return TEST_FAIL;
185 }
186
187 rip = ptrace(PTRACE_PEEKUSER, child,
188 offsetof(struct user_regs_struct, rip), NULL);
189 if (rip == (unsigned long) -1) {
190 pr_debug("failed to PTRACE_PEEKUSER: %s\n",
191 strerror(errno));
192 goto out;
193 }
194
195 pr_debug("rip %lx, bp_1 %p\n", rip, bp_1);
196
197out:
198 if (ptrace(PTRACE_DETACH, child, NULL, NULL)) {
199 pr_debug("failed to PTRACE_DETACH: %s", strerror(errno));
200 return TEST_FAIL;
201 }
202
203 return rip == (unsigned long) bp_1 ? TEST_OK : TEST_FAIL;
204}
205
206int test__bp_modify(struct test *test __maybe_unused,
207 int subtest __maybe_unused)
208{
209 TEST_ASSERT_VAL("modify test 1 failed\n", !bp_modify1());
210 TEST_ASSERT_VAL("modify test 2 failed\n", !bp_modify2());
211
212 return 0;
213}
diff --git a/tools/perf/scripts/python/export-to-postgresql.py b/tools/perf/scripts/python/export-to-postgresql.py
index efcaf6cac2eb..e46f51b17513 100644
--- a/tools/perf/scripts/python/export-to-postgresql.py
+++ b/tools/perf/scripts/python/export-to-postgresql.py
@@ -204,14 +204,23 @@ from ctypes import *
204libpq = CDLL("libpq.so.5") 204libpq = CDLL("libpq.so.5")
205PQconnectdb = libpq.PQconnectdb 205PQconnectdb = libpq.PQconnectdb
206PQconnectdb.restype = c_void_p 206PQconnectdb.restype = c_void_p
207PQconnectdb.argtypes = [ c_char_p ]
207PQfinish = libpq.PQfinish 208PQfinish = libpq.PQfinish
209PQfinish.argtypes = [ c_void_p ]
208PQstatus = libpq.PQstatus 210PQstatus = libpq.PQstatus
211PQstatus.restype = c_int
212PQstatus.argtypes = [ c_void_p ]
209PQexec = libpq.PQexec 213PQexec = libpq.PQexec
210PQexec.restype = c_void_p 214PQexec.restype = c_void_p
215PQexec.argtypes = [ c_void_p, c_char_p ]
211PQresultStatus = libpq.PQresultStatus 216PQresultStatus = libpq.PQresultStatus
217PQresultStatus.restype = c_int
218PQresultStatus.argtypes = [ c_void_p ]
212PQputCopyData = libpq.PQputCopyData 219PQputCopyData = libpq.PQputCopyData
220PQputCopyData.restype = c_int
213PQputCopyData.argtypes = [ c_void_p, c_void_p, c_int ] 221PQputCopyData.argtypes = [ c_void_p, c_void_p, c_int ]
214PQputCopyEnd = libpq.PQputCopyEnd 222PQputCopyEnd = libpq.PQputCopyEnd
223PQputCopyEnd.restype = c_int
215PQputCopyEnd.argtypes = [ c_void_p, c_void_p ] 224PQputCopyEnd.argtypes = [ c_void_p, c_void_p ]
216 225
217sys.path.append(os.environ['PERF_EXEC_PATH'] + \ 226sys.path.append(os.environ['PERF_EXEC_PATH'] + \
diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
index f827bf77e9d2..e4bb82c8aba9 100644
--- a/tools/perf/scripts/python/export-to-sqlite.py
+++ b/tools/perf/scripts/python/export-to-sqlite.py
@@ -440,7 +440,11 @@ def branch_type_table(*x):
440 440
441def sample_table(*x): 441def sample_table(*x):
442 if branches: 442 if branches:
443 bind_exec(sample_query, 18, x) 443 for xx in x[0:15]:
444 sample_query.addBindValue(str(xx))
445 for xx in x[19:22]:
446 sample_query.addBindValue(str(xx))
447 do_query_(sample_query)
444 else: 448 else:
445 bind_exec(sample_query, 22, x) 449 bind_exec(sample_query, 22, x)
446 450
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 20061cf42288..28cd6a17491b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -246,8 +246,14 @@ find_target:
246 246
247indirect_call: 247indirect_call:
248 tok = strchr(endptr, '*'); 248 tok = strchr(endptr, '*');
249 if (tok != NULL) 249 if (tok != NULL) {
250 ops->target.addr = strtoull(tok + 1, NULL, 16); 250 endptr++;
251
252 /* Indirect call can use a non-rip register and offset: callq *0x8(%rbx).
253 * Do not parse such instruction. */
254 if (strstr(endptr, "(%r") == NULL)
255 ops->target.addr = strtoull(endptr, NULL, 16);
256 }
251 goto find_target; 257 goto find_target;
252} 258}
253 259
@@ -276,7 +282,19 @@ bool ins__is_call(const struct ins *ins)
276 return ins->ops == &call_ops || ins->ops == &s390_call_ops; 282 return ins->ops == &call_ops || ins->ops == &s390_call_ops;
277} 283}
278 284
279static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map_symbol *ms) 285/*
286 * Prevents from matching commas in the comment section, e.g.:
287 * ffff200008446e70: b.cs ffff2000084470f4 <generic_exec_single+0x314> // b.hs, b.nlast
288 */
289static inline const char *validate_comma(const char *c, struct ins_operands *ops)
290{
291 if (ops->raw_comment && c > ops->raw_comment)
292 return NULL;
293
294 return c;
295}
296
297static int jump__parse(struct arch *arch, struct ins_operands *ops, struct map_symbol *ms)
280{ 298{
281 struct map *map = ms->map; 299 struct map *map = ms->map;
282 struct symbol *sym = ms->sym; 300 struct symbol *sym = ms->sym;
@@ -285,6 +303,10 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op
285 }; 303 };
286 const char *c = strchr(ops->raw, ','); 304 const char *c = strchr(ops->raw, ',');
287 u64 start, end; 305 u64 start, end;
306
307 ops->raw_comment = strchr(ops->raw, arch->objdump.comment_char);
308 c = validate_comma(c, ops);
309
288 /* 310 /*
289 * Examples of lines to parse for the _cpp_lex_token@@Base 311 * Examples of lines to parse for the _cpp_lex_token@@Base
290 * function: 312 * function:
@@ -304,6 +326,7 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op
304 ops->target.addr = strtoull(c, NULL, 16); 326 ops->target.addr = strtoull(c, NULL, 16);
305 if (!ops->target.addr) { 327 if (!ops->target.addr) {
306 c = strchr(c, ','); 328 c = strchr(c, ',');
329 c = validate_comma(c, ops);
307 if (c++ != NULL) 330 if (c++ != NULL)
308 ops->target.addr = strtoull(c, NULL, 16); 331 ops->target.addr = strtoull(c, NULL, 16);
309 } 332 }
@@ -361,9 +384,12 @@ static int jump__scnprintf(struct ins *ins, char *bf, size_t size,
361 return scnprintf(bf, size, "%-6s %s", ins->name, ops->target.sym->name); 384 return scnprintf(bf, size, "%-6s %s", ins->name, ops->target.sym->name);
362 385
363 c = strchr(ops->raw, ','); 386 c = strchr(ops->raw, ',');
387 c = validate_comma(c, ops);
388
364 if (c != NULL) { 389 if (c != NULL) {
365 const char *c2 = strchr(c + 1, ','); 390 const char *c2 = strchr(c + 1, ',');
366 391
392 c2 = validate_comma(c2, ops);
367 /* check for 3-op insn */ 393 /* check for 3-op insn */
368 if (c2 != NULL) 394 if (c2 != NULL)
369 c = c2; 395 c = c2;
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 005a5fe8a8c6..5399ba2321bb 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -22,6 +22,7 @@ struct ins {
22 22
23struct ins_operands { 23struct ins_operands {
24 char *raw; 24 char *raw;
25 char *raw_comment;
25 struct { 26 struct {
26 char *raw; 27 char *raw;
27 char *name; 28 char *name;
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index c980bbff6353..1a61628a1c12 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -251,8 +251,9 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx)
251{ 251{
252 struct perf_evsel *evsel = zalloc(perf_evsel__object.size); 252 struct perf_evsel *evsel = zalloc(perf_evsel__object.size);
253 253
254 if (evsel != NULL) 254 if (!evsel)
255 perf_evsel__init(evsel, attr, idx); 255 return NULL;
256 perf_evsel__init(evsel, attr, idx);
256 257
257 if (perf_evsel__is_bpf_output(evsel)) { 258 if (perf_evsel__is_bpf_output(evsel)) {
258 evsel->attr.sample_type |= (PERF_SAMPLE_RAW | PERF_SAMPLE_TIME | 259 evsel->attr.sample_type |= (PERF_SAMPLE_RAW | PERF_SAMPLE_TIME |
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index c4acd2001db0..111ae858cbcb 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -2286,7 +2286,8 @@ static int append_inlines(struct callchain_cursor *cursor,
2286 if (!symbol_conf.inline_name || !map || !sym) 2286 if (!symbol_conf.inline_name || !map || !sym)
2287 return ret; 2287 return ret;
2288 2288
2289 addr = map__rip_2objdump(map, ip); 2289 addr = map__map_ip(map, ip);
2290 addr = map__rip_2objdump(map, addr);
2290 2291
2291 inline_node = inlines__tree_find(&map->dso->inlined_nodes, addr); 2292 inline_node = inlines__tree_find(&map->dso->inlined_nodes, addr);
2292 if (!inline_node) { 2293 if (!inline_node) {
@@ -2312,7 +2313,7 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
2312{ 2313{
2313 struct callchain_cursor *cursor = arg; 2314 struct callchain_cursor *cursor = arg;
2314 const char *srcline = NULL; 2315 const char *srcline = NULL;
2315 u64 addr; 2316 u64 addr = entry->ip;
2316 2317
2317 if (symbol_conf.hide_unresolved && entry->sym == NULL) 2318 if (symbol_conf.hide_unresolved && entry->sym == NULL)
2318 return 0; 2319 return 0;
@@ -2324,7 +2325,8 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
2324 * Convert entry->ip from a virtual address to an offset in 2325 * Convert entry->ip from a virtual address to an offset in
2325 * its corresponding binary. 2326 * its corresponding binary.
2326 */ 2327 */
2327 addr = map__map_ip(entry->map, entry->ip); 2328 if (entry->map)
2329 addr = map__map_ip(entry->map, entry->ip);
2328 2330
2329 srcline = callchain_srcline(entry->map, entry->sym, addr); 2331 srcline = callchain_srcline(entry->map, entry->sym, addr);
2330 return callchain_cursor_append(cursor, entry->ip, 2332 return callchain_cursor_append(cursor, entry->ip,
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 36d0763311ef..6a6929f208b4 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -576,6 +576,13 @@ struct symbol *map_groups__find_symbol(struct map_groups *mg,
576 return NULL; 576 return NULL;
577} 577}
578 578
579static bool map__contains_symbol(struct map *map, struct symbol *sym)
580{
581 u64 ip = map->unmap_ip(map, sym->start);
582
583 return ip >= map->start && ip < map->end;
584}
585
579struct symbol *maps__find_symbol_by_name(struct maps *maps, const char *name, 586struct symbol *maps__find_symbol_by_name(struct maps *maps, const char *name,
580 struct map **mapp) 587 struct map **mapp)
581{ 588{
@@ -591,6 +598,10 @@ struct symbol *maps__find_symbol_by_name(struct maps *maps, const char *name,
591 598
592 if (sym == NULL) 599 if (sym == NULL)
593 continue; 600 continue;
601 if (!map__contains_symbol(pos, sym)) {
602 sym = NULL;
603 continue;
604 }
594 if (mapp != NULL) 605 if (mapp != NULL)
595 *mapp = pos; 606 *mapp = pos;
596 goto out; 607 goto out;
diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
index 97efbcad076e..1942f6dd24f6 100644
--- a/tools/perf/util/setup.py
+++ b/tools/perf/util/setup.py
@@ -35,7 +35,7 @@ class install_lib(_install_lib):
35 35
36cflags = getenv('CFLAGS', '').split() 36cflags = getenv('CFLAGS', '').split()
37# switch off several checks (need to be at the end of cflags list) 37# switch off several checks (need to be at the end of cflags list)
38cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter' ] 38cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls' ]
39if cc != "clang": 39if cc != "clang":
40 cflags += ['-Wno-cast-function-type' ] 40 cflags += ['-Wno-cast-function-type' ]
41 41
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index c85d0d1a65ed..7b0ca7cbb7de 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -377,7 +377,7 @@ out:
377 377
378static int record_saved_cmdline(void) 378static int record_saved_cmdline(void)
379{ 379{
380 unsigned int size; 380 unsigned long long size;
381 char *path; 381 char *path;
382 struct stat st; 382 struct stat st;
383 int ret, err = 0; 383 int ret, err = 0;
diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 920b1d58a068..e76214f8d596 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -164,16 +164,15 @@ void parse_ftrace_printk(struct tep_handle *pevent,
164void parse_saved_cmdline(struct tep_handle *pevent, 164void parse_saved_cmdline(struct tep_handle *pevent,
165 char *file, unsigned int size __maybe_unused) 165 char *file, unsigned int size __maybe_unused)
166{ 166{
167 char *comm; 167 char comm[17]; /* Max comm length in the kernel is 16. */
168 char *line; 168 char *line;
169 char *next = NULL; 169 char *next = NULL;
170 int pid; 170 int pid;
171 171
172 line = strtok_r(file, "\n", &next); 172 line = strtok_r(file, "\n", &next);
173 while (line) { 173 while (line) {
174 sscanf(line, "%d %ms", &pid, &comm); 174 if (sscanf(line, "%d %16s", &pid, comm) == 2)
175 tep_register_comm(pevent, comm, pid); 175 tep_register_comm(pevent, comm, pid);
176 free(comm);
177 line = strtok_r(NULL, "\n", &next); 176 line = strtok_r(NULL, "\n", &next);
178 } 177 }
179} 178}
diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile
index 72c25a3cb658..d9a725478375 100644
--- a/tools/testing/selftests/android/Makefile
+++ b/tools/testing/selftests/android/Makefile
@@ -6,7 +6,7 @@ TEST_PROGS := run.sh
6 6
7include ../lib.mk 7include ../lib.mk
8 8
9all: 9all: khdr
10 @for DIR in $(SUBDIRS); do \ 10 @for DIR in $(SUBDIRS); do \
11 BUILD_TARGET=$(OUTPUT)/$$DIR; \ 11 BUILD_TARGET=$(OUTPUT)/$$DIR; \
12 mkdir $$BUILD_TARGET -p; \ 12 mkdir $$BUILD_TARGET -p; \
diff --git a/tools/testing/selftests/android/ion/config b/tools/testing/selftests/android/config
index b4ad748a9dd9..b4ad748a9dd9 100644
--- a/tools/testing/selftests/android/ion/config
+++ b/tools/testing/selftests/android/config
diff --git a/tools/testing/selftests/android/ion/Makefile b/tools/testing/selftests/android/ion/Makefile
index e03695287f76..88cfe88e466f 100644
--- a/tools/testing/selftests/android/ion/Makefile
+++ b/tools/testing/selftests/android/ion/Makefile
@@ -10,6 +10,8 @@ $(TEST_GEN_FILES): ipcsocket.c ionutils.c
10 10
11TEST_PROGS := ion_test.sh 11TEST_PROGS := ion_test.sh
12 12
13KSFT_KHDR_INSTALL := 1
14top_srcdir = ../../../../..
13include ../../lib.mk 15include ../../lib.mk
14 16
15$(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c 17$(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c
diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index 6f54f84144a0..9b552c0fc47d 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -580,7 +580,11 @@ static void test_sockmap(int tasks, void *data)
580 /* Test update without programs */ 580 /* Test update without programs */
581 for (i = 0; i < 6; i++) { 581 for (i = 0; i < 6; i++) {
582 err = bpf_map_update_elem(fd, &i, &sfd[i], BPF_ANY); 582 err = bpf_map_update_elem(fd, &i, &sfd[i], BPF_ANY);
583 if (err) { 583 if (i < 2 && !err) {
584 printf("Allowed update sockmap '%i:%i' not in ESTABLISHED\n",
585 i, sfd[i]);
586 goto out_sockmap;
587 } else if (i >= 2 && err) {
584 printf("Failed noprog update sockmap '%i:%i'\n", 588 printf("Failed noprog update sockmap '%i:%i'\n",
585 i, sfd[i]); 589 i, sfd[i]);
586 goto out_sockmap; 590 goto out_sockmap;
@@ -741,7 +745,7 @@ static void test_sockmap(int tasks, void *data)
741 } 745 }
742 746
743 /* Test map update elem afterwards fd lives in fd and map_fd */ 747 /* Test map update elem afterwards fd lives in fd and map_fd */
744 for (i = 0; i < 6; i++) { 748 for (i = 2; i < 6; i++) {
745 err = bpf_map_update_elem(map_fd_rx, &i, &sfd[i], BPF_ANY); 749 err = bpf_map_update_elem(map_fd_rx, &i, &sfd[i], BPF_ANY);
746 if (err) { 750 if (err) {
747 printf("Failed map_fd_rx update sockmap %i '%i:%i'\n", 751 printf("Failed map_fd_rx update sockmap %i '%i:%i'\n",
@@ -845,7 +849,7 @@ static void test_sockmap(int tasks, void *data)
845 } 849 }
846 850
847 /* Delete the elems without programs */ 851 /* Delete the elems without programs */
848 for (i = 0; i < 6; i++) { 852 for (i = 2; i < 6; i++) {
849 err = bpf_map_delete_elem(fd, &i); 853 err = bpf_map_delete_elem(fd, &i);
850 if (err) { 854 if (err) {
851 printf("Failed delete sockmap %i '%i:%i'\n", 855 printf("Failed delete sockmap %i '%i:%i'\n",
diff --git a/tools/testing/selftests/cgroup/.gitignore b/tools/testing/selftests/cgroup/.gitignore
index 95eb3a53c381..adacda50a4b2 100644
--- a/tools/testing/selftests/cgroup/.gitignore
+++ b/tools/testing/selftests/cgroup/.gitignore
@@ -1 +1,2 @@
1test_memcontrol 1test_memcontrol
2test_core
diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
index 1c5d2b2a583b..14c9fe284806 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -89,17 +89,28 @@ int cg_read(const char *cgroup, const char *control, char *buf, size_t len)
89int cg_read_strcmp(const char *cgroup, const char *control, 89int cg_read_strcmp(const char *cgroup, const char *control,
90 const char *expected) 90 const char *expected)
91{ 91{
92 size_t size = strlen(expected) + 1; 92 size_t size;
93 char *buf; 93 char *buf;
94 int ret;
95
96 /* Handle the case of comparing against empty string */
97 if (!expected)
98 size = 32;
99 else
100 size = strlen(expected) + 1;
94 101
95 buf = malloc(size); 102 buf = malloc(size);
96 if (!buf) 103 if (!buf)
97 return -1; 104 return -1;
98 105
99 if (cg_read(cgroup, control, buf, size)) 106 if (cg_read(cgroup, control, buf, size)) {
107 free(buf);
100 return -1; 108 return -1;
109 }
101 110
102 return strcmp(expected, buf); 111 ret = strcmp(expected, buf);
112 free(buf);
113 return ret;
103} 114}
104 115
105int cg_read_strstr(const char *cgroup, const char *control, const char *needle) 116int cg_read_strstr(const char *cgroup, const char *control, const char *needle)
@@ -337,3 +348,24 @@ int is_swap_enabled(void)
337 348
338 return cnt > 1; 349 return cnt > 1;
339} 350}
351
352int set_oom_adj_score(int pid, int score)
353{
354 char path[PATH_MAX];
355 int fd, len;
356
357 sprintf(path, "/proc/%d/oom_score_adj", pid);
358
359 fd = open(path, O_WRONLY | O_APPEND);
360 if (fd < 0)
361 return fd;
362
363 len = dprintf(fd, "%d", score);
364 if (len < 0) {
365 close(fd);
366 return len;
367 }
368
369 close(fd);
370 return 0;
371}
diff --git a/tools/testing/selftests/cgroup/cgroup_util.h b/tools/testing/selftests/cgroup/cgroup_util.h
index 1ff6f9f1abdc..9ac8b7958f83 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.h
+++ b/tools/testing/selftests/cgroup/cgroup_util.h
@@ -40,3 +40,4 @@ extern int get_temp_fd(void);
40extern int alloc_pagecache(int fd, size_t size); 40extern int alloc_pagecache(int fd, size_t size);
41extern int alloc_anon(const char *cgroup, void *arg); 41extern int alloc_anon(const char *cgroup, void *arg);
42extern int is_swap_enabled(void); 42extern int is_swap_enabled(void);
43extern int set_oom_adj_score(int pid, int score);
diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c
index cf0bddc9d271..28d321ba311b 100644
--- a/tools/testing/selftests/cgroup/test_memcontrol.c
+++ b/tools/testing/selftests/cgroup/test_memcontrol.c
@@ -2,6 +2,7 @@
2#define _GNU_SOURCE 2#define _GNU_SOURCE
3 3
4#include <linux/limits.h> 4#include <linux/limits.h>
5#include <linux/oom.h>
5#include <fcntl.h> 6#include <fcntl.h>
6#include <stdio.h> 7#include <stdio.h>
7#include <stdlib.h> 8#include <stdlib.h>
@@ -202,6 +203,36 @@ static int alloc_pagecache_50M_noexit(const char *cgroup, void *arg)
202 return 0; 203 return 0;
203} 204}
204 205
206static int alloc_anon_noexit(const char *cgroup, void *arg)
207{
208 int ppid = getppid();
209
210 if (alloc_anon(cgroup, arg))
211 return -1;
212
213 while (getppid() == ppid)
214 sleep(1);
215
216 return 0;
217}
218
219/*
220 * Wait until processes are killed asynchronously by the OOM killer
221 * If we exceed a timeout, fail.
222 */
223static int cg_test_proc_killed(const char *cgroup)
224{
225 int limit;
226
227 for (limit = 10; limit > 0; limit--) {
228 if (cg_read_strcmp(cgroup, "cgroup.procs", "") == 0)
229 return 0;
230
231 usleep(100000);
232 }
233 return -1;
234}
235
205/* 236/*
206 * First, this test creates the following hierarchy: 237 * First, this test creates the following hierarchy:
207 * A memory.min = 50M, memory.max = 200M 238 * A memory.min = 50M, memory.max = 200M
@@ -964,6 +995,177 @@ cleanup:
964 return ret; 995 return ret;
965} 996}
966 997
998/*
999 * This test disables swapping and tries to allocate anonymous memory
1000 * up to OOM with memory.group.oom set. Then it checks that all
1001 * processes in the leaf (but not the parent) were killed.
1002 */
1003static int test_memcg_oom_group_leaf_events(const char *root)
1004{
1005 int ret = KSFT_FAIL;
1006 char *parent, *child;
1007
1008 parent = cg_name(root, "memcg_test_0");
1009 child = cg_name(root, "memcg_test_0/memcg_test_1");
1010
1011 if (!parent || !child)
1012 goto cleanup;
1013
1014 if (cg_create(parent))
1015 goto cleanup;
1016
1017 if (cg_create(child))
1018 goto cleanup;
1019
1020 if (cg_write(parent, "cgroup.subtree_control", "+memory"))
1021 goto cleanup;
1022
1023 if (cg_write(child, "memory.max", "50M"))
1024 goto cleanup;
1025
1026 if (cg_write(child, "memory.swap.max", "0"))
1027 goto cleanup;
1028
1029 if (cg_write(child, "memory.oom.group", "1"))
1030 goto cleanup;
1031
1032 cg_run_nowait(parent, alloc_anon_noexit, (void *) MB(60));
1033 cg_run_nowait(child, alloc_anon_noexit, (void *) MB(1));
1034 cg_run_nowait(child, alloc_anon_noexit, (void *) MB(1));
1035 if (!cg_run(child, alloc_anon, (void *)MB(100)))
1036 goto cleanup;
1037
1038 if (cg_test_proc_killed(child))
1039 goto cleanup;
1040
1041 if (cg_read_key_long(child, "memory.events", "oom_kill ") <= 0)
1042 goto cleanup;
1043
1044 if (cg_read_key_long(parent, "memory.events", "oom_kill ") != 0)
1045 goto cleanup;
1046
1047 ret = KSFT_PASS;
1048
1049cleanup:
1050 if (child)
1051 cg_destroy(child);
1052 if (parent)
1053 cg_destroy(parent);
1054 free(child);
1055 free(parent);
1056
1057 return ret;
1058}
1059
1060/*
1061 * This test disables swapping and tries to allocate anonymous memory
1062 * up to OOM with memory.group.oom set. Then it checks that all
1063 * processes in the parent and leaf were killed.
1064 */
1065static int test_memcg_oom_group_parent_events(const char *root)
1066{
1067 int ret = KSFT_FAIL;
1068 char *parent, *child;
1069
1070 parent = cg_name(root, "memcg_test_0");
1071 child = cg_name(root, "memcg_test_0/memcg_test_1");
1072
1073 if (!parent || !child)
1074 goto cleanup;
1075
1076 if (cg_create(parent))
1077 goto cleanup;
1078
1079 if (cg_create(child))
1080 goto cleanup;
1081
1082 if (cg_write(parent, "memory.max", "80M"))
1083 goto cleanup;
1084
1085 if (cg_write(parent, "memory.swap.max", "0"))
1086 goto cleanup;
1087
1088 if (cg_write(parent, "memory.oom.group", "1"))
1089 goto cleanup;
1090
1091 cg_run_nowait(parent, alloc_anon_noexit, (void *) MB(60));
1092 cg_run_nowait(child, alloc_anon_noexit, (void *) MB(1));
1093 cg_run_nowait(child, alloc_anon_noexit, (void *) MB(1));
1094
1095 if (!cg_run(child, alloc_anon, (void *)MB(100)))
1096 goto cleanup;
1097
1098 if (cg_test_proc_killed(child))
1099 goto cleanup;
1100 if (cg_test_proc_killed(parent))
1101 goto cleanup;
1102
1103 ret = KSFT_PASS;
1104
1105cleanup:
1106 if (child)
1107 cg_destroy(child);
1108 if (parent)
1109 cg_destroy(parent);
1110 free(child);
1111 free(parent);
1112
1113 return ret;
1114}
1115
1116/*
1117 * This test disables swapping and tries to allocate anonymous memory
1118 * up to OOM with memory.group.oom set. Then it checks that all
1119 * processes were killed except those set with OOM_SCORE_ADJ_MIN
1120 */
1121static int test_memcg_oom_group_score_events(const char *root)
1122{
1123 int ret = KSFT_FAIL;
1124 char *memcg;
1125 int safe_pid;
1126
1127 memcg = cg_name(root, "memcg_test_0");
1128
1129 if (!memcg)
1130 goto cleanup;
1131
1132 if (cg_create(memcg))
1133 goto cleanup;
1134
1135 if (cg_write(memcg, "memory.max", "50M"))
1136 goto cleanup;
1137
1138 if (cg_write(memcg, "memory.swap.max", "0"))
1139 goto cleanup;
1140
1141 if (cg_write(memcg, "memory.oom.group", "1"))
1142 goto cleanup;
1143
1144 safe_pid = cg_run_nowait(memcg, alloc_anon_noexit, (void *) MB(1));
1145 if (set_oom_adj_score(safe_pid, OOM_SCORE_ADJ_MIN))
1146 goto cleanup;
1147
1148 cg_run_nowait(memcg, alloc_anon_noexit, (void *) MB(1));
1149 if (!cg_run(memcg, alloc_anon, (void *)MB(100)))
1150 goto cleanup;
1151
1152 if (cg_read_key_long(memcg, "memory.events", "oom_kill ") != 3)
1153 goto cleanup;
1154
1155 if (kill(safe_pid, SIGKILL))
1156 goto cleanup;
1157
1158 ret = KSFT_PASS;
1159
1160cleanup:
1161 if (memcg)
1162 cg_destroy(memcg);
1163 free(memcg);
1164
1165 return ret;
1166}
1167
1168
967#define T(x) { x, #x } 1169#define T(x) { x, #x }
968struct memcg_test { 1170struct memcg_test {
969 int (*fn)(const char *root); 1171 int (*fn)(const char *root);
@@ -978,6 +1180,9 @@ struct memcg_test {
978 T(test_memcg_oom_events), 1180 T(test_memcg_oom_events),
979 T(test_memcg_swap_max), 1181 T(test_memcg_swap_max),
980 T(test_memcg_sock), 1182 T(test_memcg_sock),
1183 T(test_memcg_oom_group_leaf_events),
1184 T(test_memcg_oom_group_parent_events),
1185 T(test_memcg_oom_group_score_events),
981}; 1186};
982#undef T 1187#undef T
983 1188
diff --git a/tools/testing/selftests/efivarfs/config b/tools/testing/selftests/efivarfs/config
new file mode 100644
index 000000000000..4e151f1005b2
--- /dev/null
+++ b/tools/testing/selftests/efivarfs/config
@@ -0,0 +1 @@
CONFIG_EFIVAR_FS=y
diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
index ff8feca49746..ad1eeb14fda7 100644
--- a/tools/testing/selftests/futex/functional/Makefile
+++ b/tools/testing/selftests/futex/functional/Makefile
@@ -18,6 +18,7 @@ TEST_GEN_FILES := \
18 18
19TEST_PROGS := run.sh 19TEST_PROGS := run.sh
20 20
21top_srcdir = ../../../../..
21include ../../lib.mk 22include ../../lib.mk
22 23
23$(TEST_GEN_FILES): $(HEADERS) 24$(TEST_GEN_FILES): $(HEADERS)
diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
index 1bbb47565c55..4665cdbf1a8d 100644
--- a/tools/testing/selftests/gpio/Makefile
+++ b/tools/testing/selftests/gpio/Makefile
@@ -21,11 +21,8 @@ endef
21CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ 21CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/
22LDLIBS += -lmount -I/usr/include/libmount 22LDLIBS += -lmount -I/usr/include/libmount
23 23
24$(BINARIES): ../../../gpio/gpio-utils.o ../../../../usr/include/linux/gpio.h 24$(BINARIES):| khdr
25$(BINARIES): ../../../gpio/gpio-utils.o
25 26
26../../../gpio/gpio-utils.o: 27../../../gpio/gpio-utils.o:
27 make ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C ../../../gpio 28 make ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C ../../../gpio
28
29../../../../usr/include/linux/gpio.h:
30 make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
31
diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 15e6b75fc3a5..a3edb2c8e43d 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -19,7 +19,6 @@
19#define KSFT_FAIL 1 19#define KSFT_FAIL 1
20#define KSFT_XFAIL 2 20#define KSFT_XFAIL 2
21#define KSFT_XPASS 3 21#define KSFT_XPASS 3
22/* Treat skip as pass */
23#define KSFT_SKIP 4 22#define KSFT_SKIP 4
24 23
25/* counters */ 24/* counters */
diff --git a/tools/testing/selftests/kvm/.gitignore b/tools/testing/selftests/kvm/.gitignore
index 4202139d81d9..5c34752e1cff 100644
--- a/tools/testing/selftests/kvm/.gitignore
+++ b/tools/testing/selftests/kvm/.gitignore
@@ -1,4 +1,5 @@
1cr4_cpuid_sync_test 1cr4_cpuid_sync_test
2platform_info_test
2set_sregs_test 3set_sregs_test
3sync_regs_test 4sync_regs_test
4vmx_tsc_adjust_test 5vmx_tsc_adjust_test
diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
index 03b0f551bedf..ec32dad3c3f0 100644
--- a/tools/testing/selftests/kvm/Makefile
+++ b/tools/testing/selftests/kvm/Makefile
@@ -6,7 +6,8 @@ UNAME_M := $(shell uname -m)
6LIBKVM = lib/assert.c lib/elf.c lib/io.c lib/kvm_util.c lib/sparsebit.c 6LIBKVM = lib/assert.c lib/elf.c lib/io.c lib/kvm_util.c lib/sparsebit.c
7LIBKVM_x86_64 = lib/x86.c lib/vmx.c 7LIBKVM_x86_64 = lib/x86.c lib/vmx.c
8 8
9TEST_GEN_PROGS_x86_64 = set_sregs_test 9TEST_GEN_PROGS_x86_64 = platform_info_test
10TEST_GEN_PROGS_x86_64 += set_sregs_test
10TEST_GEN_PROGS_x86_64 += sync_regs_test 11TEST_GEN_PROGS_x86_64 += sync_regs_test
11TEST_GEN_PROGS_x86_64 += vmx_tsc_adjust_test 12TEST_GEN_PROGS_x86_64 += vmx_tsc_adjust_test
12TEST_GEN_PROGS_x86_64 += cr4_cpuid_sync_test 13TEST_GEN_PROGS_x86_64 += cr4_cpuid_sync_test
@@ -20,7 +21,7 @@ INSTALL_HDR_PATH = $(top_srcdir)/usr
20LINUX_HDR_PATH = $(INSTALL_HDR_PATH)/include/ 21LINUX_HDR_PATH = $(INSTALL_HDR_PATH)/include/
21LINUX_TOOL_INCLUDE = $(top_srcdir)tools/include 22LINUX_TOOL_INCLUDE = $(top_srcdir)tools/include
22CFLAGS += -O2 -g -std=gnu99 -I$(LINUX_TOOL_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude -I$(<D) -I.. 23CFLAGS += -O2 -g -std=gnu99 -I$(LINUX_TOOL_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude -I$(<D) -I..
23LDFLAGS += -lpthread 24LDFLAGS += -pthread
24 25
25# After inclusion, $(OUTPUT) is defined and 26# After inclusion, $(OUTPUT) is defined and
26# $(TEST_GEN_PROGS) starts with $(OUTPUT)/ 27# $(TEST_GEN_PROGS) starts with $(OUTPUT)/
@@ -37,9 +38,6 @@ $(LIBKVM_OBJ): $(OUTPUT)/%.o: %.c
37$(OUTPUT)/libkvm.a: $(LIBKVM_OBJ) 38$(OUTPUT)/libkvm.a: $(LIBKVM_OBJ)
38 $(AR) crs $@ $^ 39 $(AR) crs $@ $^
39 40
40$(LINUX_HDR_PATH): 41all: $(STATIC_LIBS)
41 make -C $(top_srcdir) headers_install
42
43all: $(STATIC_LIBS) $(LINUX_HDR_PATH)
44$(TEST_GEN_PROGS): $(STATIC_LIBS) 42$(TEST_GEN_PROGS): $(STATIC_LIBS)
45$(TEST_GEN_PROGS) $(LIBKVM_OBJ): | $(LINUX_HDR_PATH) 43$(STATIC_LIBS):| khdr
diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h
index bb5a25fb82c6..3acf9a91704c 100644
--- a/tools/testing/selftests/kvm/include/kvm_util.h
+++ b/tools/testing/selftests/kvm/include/kvm_util.h
@@ -50,6 +50,7 @@ enum vm_mem_backing_src_type {
50}; 50};
51 51
52int kvm_check_cap(long cap); 52int kvm_check_cap(long cap);
53int vm_enable_cap(struct kvm_vm *vm, struct kvm_enable_cap *cap);
53 54
54struct kvm_vm *vm_create(enum vm_guest_mode mode, uint64_t phy_pages, int perm); 55struct kvm_vm *vm_create(enum vm_guest_mode mode, uint64_t phy_pages, int perm);
55void kvm_vm_free(struct kvm_vm *vmp); 56void kvm_vm_free(struct kvm_vm *vmp);
@@ -108,6 +109,9 @@ void vcpu_events_get(struct kvm_vm *vm, uint32_t vcpuid,
108 struct kvm_vcpu_events *events); 109 struct kvm_vcpu_events *events);
109void vcpu_events_set(struct kvm_vm *vm, uint32_t vcpuid, 110void vcpu_events_set(struct kvm_vm *vm, uint32_t vcpuid,
110 struct kvm_vcpu_events *events); 111 struct kvm_vcpu_events *events);
112uint64_t vcpu_get_msr(struct kvm_vm *vm, uint32_t vcpuid, uint64_t msr_index);
113void vcpu_set_msr(struct kvm_vm *vm, uint32_t vcpuid, uint64_t msr_index,
114 uint64_t msr_value);
111 115
112const char *exit_reason_str(unsigned int exit_reason); 116const char *exit_reason_str(unsigned int exit_reason);
113 117
diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
index e9ba389c48db..6fd8c089cafc 100644
--- a/tools/testing/selftests/kvm/lib/kvm_util.c
+++ b/tools/testing/selftests/kvm/lib/kvm_util.c
@@ -63,6 +63,29 @@ int kvm_check_cap(long cap)
63 return ret; 63 return ret;
64} 64}
65 65
66/* VM Enable Capability
67 *
68 * Input Args:
69 * vm - Virtual Machine
70 * cap - Capability
71 *
72 * Output Args: None
73 *
74 * Return: On success, 0. On failure a TEST_ASSERT failure is produced.
75 *
76 * Enables a capability (KVM_CAP_*) on the VM.
77 */
78int vm_enable_cap(struct kvm_vm *vm, struct kvm_enable_cap *cap)
79{
80 int ret;
81
82 ret = ioctl(vm->fd, KVM_ENABLE_CAP, cap);
83 TEST_ASSERT(ret == 0, "KVM_ENABLE_CAP IOCTL failed,\n"
84 " rc: %i errno: %i", ret, errno);
85
86 return ret;
87}
88
66static void vm_open(struct kvm_vm *vm, int perm) 89static void vm_open(struct kvm_vm *vm, int perm)
67{ 90{
68 vm->kvm_fd = open(KVM_DEV_PATH, perm); 91 vm->kvm_fd = open(KVM_DEV_PATH, perm);
@@ -1220,6 +1243,72 @@ void vcpu_events_set(struct kvm_vm *vm, uint32_t vcpuid,
1220 ret, errno); 1243 ret, errno);
1221} 1244}
1222 1245
1246/* VCPU Get MSR
1247 *
1248 * Input Args:
1249 * vm - Virtual Machine
1250 * vcpuid - VCPU ID
1251 * msr_index - Index of MSR
1252 *
1253 * Output Args: None
1254 *
1255 * Return: On success, value of the MSR. On failure a TEST_ASSERT is produced.
1256 *
1257 * Get value of MSR for VCPU.
1258 */
1259uint64_t vcpu_get_msr(struct kvm_vm *vm, uint32_t vcpuid, uint64_t msr_index)
1260{
1261 struct vcpu *vcpu = vcpu_find(vm, vcpuid);
1262 struct {
1263 struct kvm_msrs header;
1264 struct kvm_msr_entry entry;
1265 } buffer = {};
1266 int r;
1267
1268 TEST_ASSERT(vcpu != NULL, "vcpu not found, vcpuid: %u", vcpuid);
1269 buffer.header.nmsrs = 1;
1270 buffer.entry.index = msr_index;
1271 r = ioctl(vcpu->fd, KVM_GET_MSRS, &buffer.header);
1272 TEST_ASSERT(r == 1, "KVM_GET_MSRS IOCTL failed,\n"
1273 " rc: %i errno: %i", r, errno);
1274
1275 return buffer.entry.data;
1276}
1277
1278/* VCPU Set MSR
1279 *
1280 * Input Args:
1281 * vm - Virtual Machine
1282 * vcpuid - VCPU ID
1283 * msr_index - Index of MSR
1284 * msr_value - New value of MSR
1285 *
1286 * Output Args: None
1287 *
1288 * Return: On success, nothing. On failure a TEST_ASSERT is produced.
1289 *
1290 * Set value of MSR for VCPU.
1291 */
1292void vcpu_set_msr(struct kvm_vm *vm, uint32_t vcpuid, uint64_t msr_index,
1293 uint64_t msr_value)
1294{
1295 struct vcpu *vcpu = vcpu_find(vm, vcpuid);
1296 struct {
1297 struct kvm_msrs header;
1298 struct kvm_msr_entry entry;
1299 } buffer = {};
1300 int r;
1301
1302 TEST_ASSERT(vcpu != NULL, "vcpu not found, vcpuid: %u", vcpuid);
1303 memset(&buffer, 0, sizeof(buffer));
1304 buffer.header.nmsrs = 1;
1305 buffer.entry.index = msr_index;
1306 buffer.entry.data = msr_value;
1307 r = ioctl(vcpu->fd, KVM_SET_MSRS, &buffer.header);
1308 TEST_ASSERT(r == 1, "KVM_SET_MSRS IOCTL failed,\n"
1309 " rc: %i errno: %i", r, errno);
1310}
1311
1223/* VM VCPU Args Set 1312/* VM VCPU Args Set
1224 * 1313 *
1225 * Input Args: 1314 * Input Args:
diff --git a/tools/testing/selftests/kvm/platform_info_test.c b/tools/testing/selftests/kvm/platform_info_test.c
new file mode 100644
index 000000000000..3764e7121265
--- /dev/null
+++ b/tools/testing/selftests/kvm/platform_info_test.c
@@ -0,0 +1,110 @@
1// SPDX-License-Identifier: GPL-2.0
2/*
3 * Test for x86 KVM_CAP_MSR_PLATFORM_INFO
4 *
5 * Copyright (C) 2018, Google LLC.
6 *
7 * This work is licensed under the terms of the GNU GPL, version 2.
8 *
9 * Verifies expected behavior of controlling guest access to
10 * MSR_PLATFORM_INFO.
11 */
12
13#define _GNU_SOURCE /* for program_invocation_short_name */
14#include <fcntl.h>
15#include <stdio.h>
16#include <stdlib.h>
17#include <string.h>
18#include <sys/ioctl.h>
19
20#include "test_util.h"
21#include "kvm_util.h"
22#include "x86.h"
23
24#define VCPU_ID 0
25#define MSR_PLATFORM_INFO_MAX_TURBO_RATIO 0xff00
26
27static void guest_code(void)
28{
29 uint64_t msr_platform_info;
30
31 for (;;) {
32 msr_platform_info = rdmsr(MSR_PLATFORM_INFO);
33 GUEST_SYNC(msr_platform_info);
34 asm volatile ("inc %r11");
35 }
36}
37
38static void set_msr_platform_info_enabled(struct kvm_vm *vm, bool enable)
39{
40 struct kvm_enable_cap cap = {};
41
42 cap.cap = KVM_CAP_MSR_PLATFORM_INFO;
43 cap.flags = 0;
44 cap.args[0] = (int)enable;
45 vm_enable_cap(vm, &cap);
46}
47
48static void test_msr_platform_info_enabled(struct kvm_vm *vm)
49{
50 struct kvm_run *run = vcpu_state(vm, VCPU_ID);
51 struct guest_args args;
52
53 set_msr_platform_info_enabled(vm, true);
54 vcpu_run(vm, VCPU_ID);
55 TEST_ASSERT(run->exit_reason == KVM_EXIT_IO,
56 "Exit_reason other than KVM_EXIT_IO: %u (%s),\n",
57 run->exit_reason,
58 exit_reason_str(run->exit_reason));
59 guest_args_read(vm, VCPU_ID, &args);
60 TEST_ASSERT(args.port == GUEST_PORT_SYNC,
61 "Received IO from port other than PORT_HOST_SYNC: %u\n",
62 run->io.port);
63 TEST_ASSERT((args.arg1 & MSR_PLATFORM_INFO_MAX_TURBO_RATIO) ==
64 MSR_PLATFORM_INFO_MAX_TURBO_RATIO,
65 "Expected MSR_PLATFORM_INFO to have max turbo ratio mask: %i.",
66 MSR_PLATFORM_INFO_MAX_TURBO_RATIO);
67}
68
69static void test_msr_platform_info_disabled(struct kvm_vm *vm)
70{
71 struct kvm_run *run = vcpu_state(vm, VCPU_ID);
72
73 set_msr_platform_info_enabled(vm, false);
74 vcpu_run(vm, VCPU_ID);
75 TEST_ASSERT(run->exit_reason == KVM_EXIT_SHUTDOWN,
76 "Exit_reason other than KVM_EXIT_SHUTDOWN: %u (%s)\n",
77 run->exit_reason,
78 exit_reason_str(run->exit_reason));
79}
80
81int main(int argc, char *argv[])
82{
83 struct kvm_vm *vm;
84 struct kvm_run *state;
85 int rv;
86 uint64_t msr_platform_info;
87
88 /* Tell stdout not to buffer its content */
89 setbuf(stdout, NULL);
90
91 rv = kvm_check_cap(KVM_CAP_MSR_PLATFORM_INFO);
92 if (!rv) {
93 fprintf(stderr,
94 "KVM_CAP_MSR_PLATFORM_INFO not supported, skip test\n");
95 exit(KSFT_SKIP);
96 }
97
98 vm = vm_create_default(VCPU_ID, 0, guest_code);
99
100 msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO);
101 vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO,
102 msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO);
103 test_msr_platform_info_disabled(vm);
104 test_msr_platform_info_enabled(vm);
105 vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info);
106
107 kvm_vm_free(vm);
108
109 return 0;
110}
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 17ab36605a8e..0a8e75886224 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -16,8 +16,20 @@ TEST_GEN_PROGS := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS))
16TEST_GEN_PROGS_EXTENDED := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS_EXTENDED)) 16TEST_GEN_PROGS_EXTENDED := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS_EXTENDED))
17TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES)) 17TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES))
18 18
19top_srcdir ?= ../../../..
20include $(top_srcdir)/scripts/subarch.include
21ARCH ?= $(SUBARCH)
22
19all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) 23all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
20 24
25.PHONY: khdr
26khdr:
27 make ARCH=$(ARCH) -C $(top_srcdir) headers_install
28
29ifdef KSFT_KHDR_INSTALL
30$(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES):| khdr
31endif
32
21.ONESHELL: 33.ONESHELL:
22define RUN_TEST_PRINT_RESULT 34define RUN_TEST_PRINT_RESULT
23 TEST_HDR_MSG="selftests: "`basename $$PWD`:" $$BASENAME_TEST"; \ 35 TEST_HDR_MSG="selftests: "`basename $$PWD`:" $$BASENAME_TEST"; \
diff --git a/tools/testing/selftests/memory-hotplug/config b/tools/testing/selftests/memory-hotplug/config
index 2fde30191a47..a7e8cd5bb265 100644
--- a/tools/testing/selftests/memory-hotplug/config
+++ b/tools/testing/selftests/memory-hotplug/config
@@ -2,3 +2,4 @@ CONFIG_MEMORY_HOTPLUG=y
2CONFIG_MEMORY_HOTPLUG_SPARSE=y 2CONFIG_MEMORY_HOTPLUG_SPARSE=y
3CONFIG_NOTIFIER_ERROR_INJECTION=y 3CONFIG_NOTIFIER_ERROR_INJECTION=y
4CONFIG_MEMORY_NOTIFIER_ERROR_INJECT=m 4CONFIG_MEMORY_NOTIFIER_ERROR_INJECT=m
5CONFIG_MEMORY_HOTREMOVE=y
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 9cca68e440a0..919aa2ac00af 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -15,6 +15,7 @@ TEST_GEN_FILES += udpgso udpgso_bench_tx udpgso_bench_rx
15TEST_GEN_PROGS = reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa 15TEST_GEN_PROGS = reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa
16TEST_GEN_PROGS += reuseport_dualstack reuseaddr_conflict tls 16TEST_GEN_PROGS += reuseport_dualstack reuseaddr_conflict tls
17 17
18KSFT_KHDR_INSTALL := 1
18include ../lib.mk 19include ../lib.mk
19 20
20$(OUTPUT)/reuseport_bpf_numa: LDFLAGS += -lnuma 21$(OUTPUT)/reuseport_bpf_numa: LDFLAGS += -lnuma
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
index 32a194e3e07a..0ab9423d009f 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -178,8 +178,8 @@ setup() {
178 178
179cleanup() { 179cleanup() {
180 [ ${cleanup_done} -eq 1 ] && return 180 [ ${cleanup_done} -eq 1 ] && return
181 ip netns del ${NS_A} 2 > /dev/null 181 ip netns del ${NS_A} 2> /dev/null
182 ip netns del ${NS_B} 2 > /dev/null 182 ip netns del ${NS_B} 2> /dev/null
183 cleanup_done=1 183 cleanup_done=1
184} 184}
185 185
diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 08c341b49760..e101af52d1d6 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -1,4 +1,4 @@
1#!/bin/sh 1#!/bin/bash
2# 2#
3# This test is for checking rtnetlink callpaths, and get as much coverage as possible. 3# This test is for checking rtnetlink callpaths, and get as much coverage as possible.
4# 4#
diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c
index b3ebf2646e52..8fdfeafaf8c0 100644
--- a/tools/testing/selftests/net/tls.c
+++ b/tools/testing/selftests/net/tls.c
@@ -502,6 +502,55 @@ TEST_F(tls, recv_peek_multiple)
502 EXPECT_EQ(memcmp(test_str, buf, send_len), 0); 502 EXPECT_EQ(memcmp(test_str, buf, send_len), 0);
503} 503}
504 504
505TEST_F(tls, recv_peek_multiple_records)
506{
507 char const *test_str = "test_read_peek_mult_recs";
508 char const *test_str_first = "test_read_peek";
509 char const *test_str_second = "_mult_recs";
510 int len;
511 char buf[64];
512
513 len = strlen(test_str_first);
514 EXPECT_EQ(send(self->fd, test_str_first, len, 0), len);
515
516 len = strlen(test_str_second) + 1;
517 EXPECT_EQ(send(self->fd, test_str_second, len, 0), len);
518
519 len = sizeof(buf);
520 memset(buf, 0, len);
521 EXPECT_NE(recv(self->cfd, buf, len, MSG_PEEK), -1);
522
523 /* MSG_PEEK can only peek into the current record. */
524 len = strlen(test_str_first) + 1;
525 EXPECT_EQ(memcmp(test_str_first, buf, len), 0);
526
527 len = sizeof(buf);
528 memset(buf, 0, len);
529 EXPECT_NE(recv(self->cfd, buf, len, 0), -1);
530
531 /* Non-MSG_PEEK will advance strparser (and therefore record)
532 * however.
533 */
534 len = strlen(test_str) + 1;
535 EXPECT_EQ(memcmp(test_str, buf, len), 0);
536
537 /* MSG_MORE will hold current record open, so later MSG_PEEK
538 * will see everything.
539 */
540 len = strlen(test_str_first);
541 EXPECT_EQ(send(self->fd, test_str_first, len, MSG_MORE), len);
542
543 len = strlen(test_str_second) + 1;
544 EXPECT_EQ(send(self->fd, test_str_second, len, 0), len);
545
546 len = sizeof(buf);
547 memset(buf, 0, len);
548 EXPECT_NE(recv(self->cfd, buf, len, MSG_PEEK), -1);
549
550 len = strlen(test_str) + 1;
551 EXPECT_EQ(memcmp(test_str, buf, len), 0);
552}
553
505TEST_F(tls, pollin) 554TEST_F(tls, pollin)
506{ 555{
507 char const *test_str = "test_poll"; 556 char const *test_str = "test_poll";
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 850767befa47..99e537ab5ad9 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -1,4 +1,4 @@
1#!/bin/sh 1#!/bin/bash
2# SPDX-License-Identifier: GPL-2.0 2# SPDX-License-Identifier: GPL-2.0
3# 3#
4# Run a series of udpgso benchmarks 4# Run a series of udpgso benchmarks
diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index a728040edbe1..14cfcf006936 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -5,6 +5,7 @@ TEST_PROGS := hwtstamp_config rxtimestamp timestamping txtimestamp
5 5
6all: $(TEST_PROGS) 6all: $(TEST_PROGS)
7 7
8top_srcdir = ../../../../..
8include ../../lib.mk 9include ../../lib.mk
9 10
10clean: 11clean:
diff --git a/tools/testing/selftests/powerpc/alignment/Makefile b/tools/testing/selftests/powerpc/alignment/Makefile
index 93baacab7693..d056486f49de 100644
--- a/tools/testing/selftests/powerpc/alignment/Makefile
+++ b/tools/testing/selftests/powerpc/alignment/Makefile
@@ -1,5 +1,6 @@
1TEST_GEN_PROGS := copy_first_unaligned alignment_handler 1TEST_GEN_PROGS := copy_first_unaligned alignment_handler
2 2
3top_srcdir = ../../../../..
3include ../../lib.mk 4include ../../lib.mk
4 5
5$(TEST_GEN_PROGS): ../harness.c ../utils.c 6$(TEST_GEN_PROGS): ../harness.c ../utils.c
diff --git a/tools/testing/selftests/powerpc/benchmarks/Makefile b/tools/testing/selftests/powerpc/benchmarks/Makefile
index b4d7432a0ecd..d40300a65b42 100644
--- a/tools/testing/selftests/powerpc/benchmarks/Makefile
+++ b/tools/testing/selftests/powerpc/benchmarks/Makefile
@@ -4,6 +4,7 @@ TEST_GEN_FILES := exec_target
4 4
5CFLAGS += -O2 5CFLAGS += -O2
6 6
7top_srcdir = ../../../../..
7include ../../lib.mk 8include ../../lib.mk
8 9
9$(TEST_GEN_PROGS): ../harness.c 10$(TEST_GEN_PROGS): ../harness.c
diff --git a/tools/testing/selftests/powerpc/cache_shape/Makefile b/tools/testing/selftests/powerpc/cache_shape/Makefile
index 1be547434a49..ede4d3dae750 100644
--- a/tools/testing/selftests/powerpc/cache_shape/Makefile
+++ b/tools/testing/selftests/powerpc/cache_shape/Makefile
@@ -5,6 +5,7 @@ all: $(TEST_PROGS)
5 5
6$(TEST_PROGS): ../harness.c ../utils.c 6$(TEST_PROGS): ../harness.c ../utils.c
7 7
8top_srcdir = ../../../../..
8include ../../lib.mk 9include ../../lib.mk
9 10
10clean: 11clean:
diff --git a/tools/testing/selftests/powerpc/copyloops/Makefile b/tools/testing/selftests/powerpc/copyloops/Makefile
index 1cf89a34d97c..44574f3818b3 100644
--- a/tools/testing/selftests/powerpc/copyloops/Makefile
+++ b/tools/testing/selftests/powerpc/copyloops/Makefile
@@ -17,6 +17,7 @@ TEST_GEN_PROGS := copyuser_64_t0 copyuser_64_t1 copyuser_64_t2 \
17 17
18EXTRA_SOURCES := validate.c ../harness.c stubs.S 18EXTRA_SOURCES := validate.c ../harness.c stubs.S
19 19
20top_srcdir = ../../../../..
20include ../../lib.mk 21include ../../lib.mk
21 22
22$(OUTPUT)/copyuser_64_t%: copyuser_64.S $(EXTRA_SOURCES) 23$(OUTPUT)/copyuser_64_t%: copyuser_64.S $(EXTRA_SOURCES)
diff --git a/tools/testing/selftests/powerpc/dscr/Makefile b/tools/testing/selftests/powerpc/dscr/Makefile
index 55d7db7a616b..5df476364b4d 100644
--- a/tools/testing/selftests/powerpc/dscr/Makefile
+++ b/tools/testing/selftests/powerpc/dscr/Makefile
@@ -3,6 +3,7 @@ TEST_GEN_PROGS := dscr_default_test dscr_explicit_test dscr_user_test \
3 dscr_inherit_test dscr_inherit_exec_test dscr_sysfs_test \ 3 dscr_inherit_test dscr_inherit_exec_test dscr_sysfs_test \
4 dscr_sysfs_thread_test 4 dscr_sysfs_thread_test
5 5
6top_srcdir = ../../../../..
6include ../../lib.mk 7include ../../lib.mk
7 8
8$(OUTPUT)/dscr_default_test: LDLIBS += -lpthread 9$(OUTPUT)/dscr_default_test: LDLIBS += -lpthread
diff --git a/tools/testing/selftests/powerpc/math/Makefile b/tools/testing/selftests/powerpc/math/Makefile
index 0dd3a01fdab9..11a10d7a2bbd 100644
--- a/tools/testing/selftests/powerpc/math/Makefile
+++ b/tools/testing/selftests/powerpc/math/Makefile
@@ -1,6 +1,7 @@
1# SPDX-License-Identifier: GPL-2.0 1# SPDX-License-Identifier: GPL-2.0
2TEST_GEN_PROGS := fpu_syscall fpu_preempt fpu_signal vmx_syscall vmx_preempt vmx_signal vsx_preempt 2TEST_GEN_PROGS := fpu_syscall fpu_preempt fpu_signal vmx_syscall vmx_preempt vmx_signal vsx_preempt
3 3
4top_srcdir = ../../../../..
4include ../../lib.mk 5include ../../lib.mk
5 6
6$(TEST_GEN_PROGS): ../harness.c 7$(TEST_GEN_PROGS): ../harness.c
diff --git a/tools/testing/selftests/powerpc/mm/Makefile b/tools/testing/selftests/powerpc/mm/Makefile
index 8ebbe96d80a8..33ced6e0ad25 100644
--- a/tools/testing/selftests/powerpc/mm/Makefile
+++ b/tools/testing/selftests/powerpc/mm/Makefile
@@ -5,6 +5,7 @@ noarg:
5TEST_GEN_PROGS := hugetlb_vs_thp_test subpage_prot prot_sao segv_errors 5TEST_GEN_PROGS := hugetlb_vs_thp_test subpage_prot prot_sao segv_errors
6TEST_GEN_FILES := tempfile 6TEST_GEN_FILES := tempfile
7 7
8top_srcdir = ../../../../..
8include ../../lib.mk 9include ../../lib.mk
9 10
10$(TEST_GEN_PROGS): ../harness.c 11$(TEST_GEN_PROGS): ../harness.c
diff --git a/tools/testing/selftests/powerpc/pmu/Makefile b/tools/testing/selftests/powerpc/pmu/Makefile
index 6e1629bf5b09..19046db995fe 100644
--- a/tools/testing/selftests/powerpc/pmu/Makefile
+++ b/tools/testing/selftests/powerpc/pmu/Makefile
@@ -5,6 +5,7 @@ noarg:
5TEST_GEN_PROGS := count_instructions l3_bank_test per_event_excludes 5TEST_GEN_PROGS := count_instructions l3_bank_test per_event_excludes
6EXTRA_SOURCES := ../harness.c event.c lib.c ../utils.c 6EXTRA_SOURCES := ../harness.c event.c lib.c ../utils.c
7 7
8top_srcdir = ../../../../..
8include ../../lib.mk 9include ../../lib.mk
9 10
10all: $(TEST_GEN_PROGS) ebb 11all: $(TEST_GEN_PROGS) ebb
diff --git a/tools/testing/selftests/powerpc/pmu/ebb/Makefile b/tools/testing/selftests/powerpc/pmu/ebb/Makefile
index c4e64bc2e265..bd5dfa509272 100644
--- a/tools/testing/selftests/powerpc/pmu/ebb/Makefile
+++ b/tools/testing/selftests/powerpc/pmu/ebb/Makefile
@@ -17,6 +17,7 @@ TEST_GEN_PROGS := reg_access_test event_attributes_test cycles_test \
17 lost_exception_test no_handler_test \ 17 lost_exception_test no_handler_test \
18 cycles_with_mmcr2_test 18 cycles_with_mmcr2_test
19 19
20top_srcdir = ../../../../../..
20include ../../../lib.mk 21include ../../../lib.mk
21 22
22$(TEST_GEN_PROGS): ../../harness.c ../../utils.c ../event.c ../lib.c \ 23$(TEST_GEN_PROGS): ../../harness.c ../../utils.c ../event.c ../lib.c \
diff --git a/tools/testing/selftests/powerpc/primitives/Makefile b/tools/testing/selftests/powerpc/primitives/Makefile
index 175366db7be8..ea2b7bd09e36 100644
--- a/tools/testing/selftests/powerpc/primitives/Makefile
+++ b/tools/testing/selftests/powerpc/primitives/Makefile
@@ -2,6 +2,7 @@ CFLAGS += -I$(CURDIR)
2 2
3TEST_GEN_PROGS := load_unaligned_zeropad 3TEST_GEN_PROGS := load_unaligned_zeropad
4 4
5top_srcdir = ../../../../..
5include ../../lib.mk 6include ../../lib.mk
6 7
7$(TEST_GEN_PROGS): ../harness.c 8$(TEST_GEN_PROGS): ../harness.c
diff --git a/tools/testing/selftests/powerpc/ptrace/Makefile b/tools/testing/selftests/powerpc/ptrace/Makefile
index 28f5b781a553..923d531265f8 100644
--- a/tools/testing/selftests/powerpc/ptrace/Makefile
+++ b/tools/testing/selftests/powerpc/ptrace/Makefile
@@ -4,6 +4,7 @@ TEST_PROGS := ptrace-gpr ptrace-tm-gpr ptrace-tm-spd-gpr \
4 ptrace-tm-spd-vsx ptrace-tm-spr ptrace-hwbreak ptrace-pkey core-pkey \ 4 ptrace-tm-spd-vsx ptrace-tm-spr ptrace-hwbreak ptrace-pkey core-pkey \
5 perf-hwbreak 5 perf-hwbreak
6 6
7top_srcdir = ../../../../..
7include ../../lib.mk 8include ../../lib.mk
8 9
9all: $(TEST_PROGS) 10all: $(TEST_PROGS)
diff --git a/tools/testing/selftests/powerpc/signal/Makefile b/tools/testing/selftests/powerpc/signal/Makefile
index a7cbd5082e27..1fca25c6ace0 100644
--- a/tools/testing/selftests/powerpc/signal/Makefile
+++ b/tools/testing/selftests/powerpc/signal/Makefile
@@ -8,6 +8,7 @@ $(TEST_PROGS): ../harness.c ../utils.c signal.S
8CFLAGS += -maltivec 8CFLAGS += -maltivec
9signal_tm: CFLAGS += -mhtm 9signal_tm: CFLAGS += -mhtm
10 10
11top_srcdir = ../../../../..
11include ../../lib.mk 12include ../../lib.mk
12 13
13clean: 14clean:
diff --git a/tools/testing/selftests/powerpc/stringloops/Makefile b/tools/testing/selftests/powerpc/stringloops/Makefile
index 10b35c87a4f4..7fc0623d85c3 100644
--- a/tools/testing/selftests/powerpc/stringloops/Makefile
+++ b/tools/testing/selftests/powerpc/stringloops/Makefile
@@ -29,6 +29,7 @@ endif
29 29
30ASFLAGS = $(CFLAGS) 30ASFLAGS = $(CFLAGS)
31 31
32top_srcdir = ../../../../..
32include ../../lib.mk 33include ../../lib.mk
33 34
34$(TEST_GEN_PROGS): $(EXTRA_SOURCES) 35$(TEST_GEN_PROGS): $(EXTRA_SOURCES)
diff --git a/tools/testing/selftests/powerpc/switch_endian/Makefile b/tools/testing/selftests/powerpc/switch_endian/Makefile
index 30b8ff8fb82e..fcd2dcb8972b 100644
--- a/tools/testing/selftests/powerpc/switch_endian/Makefile
+++ b/tools/testing/selftests/powerpc/switch_endian/Makefile
@@ -5,6 +5,7 @@ ASFLAGS += -O2 -Wall -g -nostdlib -m64
5 5
6EXTRA_CLEAN = $(OUTPUT)/*.o $(OUTPUT)/check-reversed.S 6EXTRA_CLEAN = $(OUTPUT)/*.o $(OUTPUT)/check-reversed.S
7 7
8top_srcdir = ../../../../..
8include ../../lib.mk 9include ../../lib.mk
9 10
10$(OUTPUT)/switch_endian_test: $(OUTPUT)/check-reversed.S 11$(OUTPUT)/switch_endian_test: $(OUTPUT)/check-reversed.S
diff --git a/tools/testing/selftests/powerpc/syscalls/Makefile b/tools/testing/selftests/powerpc/syscalls/Makefile
index da22ca7c38c1..161b8846336f 100644
--- a/tools/testing/selftests/powerpc/syscalls/Makefile
+++ b/tools/testing/selftests/powerpc/syscalls/Makefile
@@ -2,6 +2,7 @@ TEST_GEN_PROGS := ipc_unmuxed
2 2
3CFLAGS += -I../../../../../usr/include 3CFLAGS += -I../../../../../usr/include
4 4
5top_srcdir = ../../../../..
5include ../../lib.mk 6include ../../lib.mk
6 7
7$(TEST_GEN_PROGS): ../harness.c 8$(TEST_GEN_PROGS): ../harness.c
diff --git a/tools/testing/selftests/powerpc/tm/Makefile b/tools/testing/selftests/powerpc/tm/Makefile
index c0e45d2dde25..9fc2cf6fbc92 100644
--- a/tools/testing/selftests/powerpc/tm/Makefile
+++ b/tools/testing/selftests/powerpc/tm/Makefile
@@ -6,6 +6,7 @@ TEST_GEN_PROGS := tm-resched-dscr tm-syscall tm-signal-msr-resv tm-signal-stack
6 tm-vmxcopy tm-fork tm-tar tm-tmspr tm-vmx-unavail tm-unavailable tm-trap \ 6 tm-vmxcopy tm-fork tm-tar tm-tmspr tm-vmx-unavail tm-unavailable tm-trap \
7 $(SIGNAL_CONTEXT_CHK_TESTS) tm-sigreturn 7 $(SIGNAL_CONTEXT_CHK_TESTS) tm-sigreturn
8 8
9top_srcdir = ../../../../..
9include ../../lib.mk 10include ../../lib.mk
10 11
11$(TEST_GEN_PROGS): ../harness.c ../utils.c 12$(TEST_GEN_PROGS): ../harness.c ../utils.c
diff --git a/tools/testing/selftests/powerpc/vphn/Makefile b/tools/testing/selftests/powerpc/vphn/Makefile
index f8ced26748f8..fb82068c9fda 100644
--- a/tools/testing/selftests/powerpc/vphn/Makefile
+++ b/tools/testing/selftests/powerpc/vphn/Makefile
@@ -2,6 +2,7 @@ TEST_GEN_PROGS := test-vphn
2 2
3CFLAGS += -m64 3CFLAGS += -m64
4 4
5top_srcdir = ../../../../..
5include ../../lib.mk 6include ../../lib.mk
6 7
7$(TEST_GEN_PROGS): ../harness.c 8$(TEST_GEN_PROGS): ../harness.c
diff --git a/tools/testing/selftests/rseq/param_test.c b/tools/testing/selftests/rseq/param_test.c
index 642d4e12abea..eec2663261f2 100644
--- a/tools/testing/selftests/rseq/param_test.c
+++ b/tools/testing/selftests/rseq/param_test.c
@@ -56,15 +56,13 @@ unsigned int yield_mod_cnt, nr_abort;
56 printf(fmt, ## __VA_ARGS__); \ 56 printf(fmt, ## __VA_ARGS__); \
57 } while (0) 57 } while (0)
58 58
59#if defined(__x86_64__) || defined(__i386__) 59#ifdef __i386__
60 60
61#define INJECT_ASM_REG "eax" 61#define INJECT_ASM_REG "eax"
62 62
63#define RSEQ_INJECT_CLOBBER \ 63#define RSEQ_INJECT_CLOBBER \
64 , INJECT_ASM_REG 64 , INJECT_ASM_REG
65 65
66#ifdef __i386__
67
68#define RSEQ_INJECT_ASM(n) \ 66#define RSEQ_INJECT_ASM(n) \
69 "mov asm_loop_cnt_" #n ", %%" INJECT_ASM_REG "\n\t" \ 67 "mov asm_loop_cnt_" #n ", %%" INJECT_ASM_REG "\n\t" \
70 "test %%" INJECT_ASM_REG ",%%" INJECT_ASM_REG "\n\t" \ 68 "test %%" INJECT_ASM_REG ",%%" INJECT_ASM_REG "\n\t" \
@@ -76,9 +74,16 @@ unsigned int yield_mod_cnt, nr_abort;
76 74
77#elif defined(__x86_64__) 75#elif defined(__x86_64__)
78 76
77#define INJECT_ASM_REG_P "rax"
78#define INJECT_ASM_REG "eax"
79
80#define RSEQ_INJECT_CLOBBER \
81 , INJECT_ASM_REG_P \
82 , INJECT_ASM_REG
83
79#define RSEQ_INJECT_ASM(n) \ 84#define RSEQ_INJECT_ASM(n) \
80 "lea asm_loop_cnt_" #n "(%%rip), %%" INJECT_ASM_REG "\n\t" \ 85 "lea asm_loop_cnt_" #n "(%%rip), %%" INJECT_ASM_REG_P "\n\t" \
81 "mov (%%" INJECT_ASM_REG "), %%" INJECT_ASM_REG "\n\t" \ 86 "mov (%%" INJECT_ASM_REG_P "), %%" INJECT_ASM_REG "\n\t" \
82 "test %%" INJECT_ASM_REG ",%%" INJECT_ASM_REG "\n\t" \ 87 "test %%" INJECT_ASM_REG ",%%" INJECT_ASM_REG "\n\t" \
83 "jz 333f\n\t" \ 88 "jz 333f\n\t" \
84 "222:\n\t" \ 89 "222:\n\t" \
@@ -86,10 +91,6 @@ unsigned int yield_mod_cnt, nr_abort;
86 "jnz 222b\n\t" \ 91 "jnz 222b\n\t" \
87 "333:\n\t" 92 "333:\n\t"
88 93
89#else
90#error "Unsupported architecture"
91#endif
92
93#elif defined(__s390__) 94#elif defined(__s390__)
94 95
95#define RSEQ_INJECT_INPUT \ 96#define RSEQ_INJECT_INPUT \
diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
index 9881876d2aa0..e94b7b14bcb2 100644
--- a/tools/testing/selftests/vm/Makefile
+++ b/tools/testing/selftests/vm/Makefile
@@ -26,10 +26,6 @@ TEST_PROGS := run_vmtests
26 26
27include ../lib.mk 27include ../lib.mk
28 28
29$(OUTPUT)/userfaultfd: ../../../../usr/include/linux/kernel.h
30$(OUTPUT)/userfaultfd: LDLIBS += -lpthread 29$(OUTPUT)/userfaultfd: LDLIBS += -lpthread
31 30
32$(OUTPUT)/mlock-random-test: LDLIBS += -lcap 31$(OUTPUT)/mlock-random-test: LDLIBS += -lcap
33
34../../../../usr/include/linux/kernel.h:
35 make -C ../../../.. headers_install
diff --git a/tools/testing/selftests/x86/test_vdso.c b/tools/testing/selftests/x86/test_vdso.c
index 235259011704..35edd61d1663 100644
--- a/tools/testing/selftests/x86/test_vdso.c
+++ b/tools/testing/selftests/x86/test_vdso.c
@@ -17,6 +17,7 @@
17#include <errno.h> 17#include <errno.h>
18#include <sched.h> 18#include <sched.h>
19#include <stdbool.h> 19#include <stdbool.h>
20#include <limits.h>
20 21
21#ifndef SYS_getcpu 22#ifndef SYS_getcpu
22# ifdef __x86_64__ 23# ifdef __x86_64__
@@ -31,6 +32,14 @@
31 32
32int nerrs = 0; 33int nerrs = 0;
33 34
35typedef int (*vgettime_t)(clockid_t, struct timespec *);
36
37vgettime_t vdso_clock_gettime;
38
39typedef long (*vgtod_t)(struct timeval *tv, struct timezone *tz);
40
41vgtod_t vdso_gettimeofday;
42
34typedef long (*getcpu_t)(unsigned *, unsigned *, void *); 43typedef long (*getcpu_t)(unsigned *, unsigned *, void *);
35 44
36getcpu_t vgetcpu; 45getcpu_t vgetcpu;
@@ -95,6 +104,15 @@ static void fill_function_pointers()
95 printf("Warning: failed to find getcpu in vDSO\n"); 104 printf("Warning: failed to find getcpu in vDSO\n");
96 105
97 vgetcpu = (getcpu_t) vsyscall_getcpu(); 106 vgetcpu = (getcpu_t) vsyscall_getcpu();
107
108 vdso_clock_gettime = (vgettime_t)dlsym(vdso, "__vdso_clock_gettime");
109 if (!vdso_clock_gettime)
110 printf("Warning: failed to find clock_gettime in vDSO\n");
111
112 vdso_gettimeofday = (vgtod_t)dlsym(vdso, "__vdso_gettimeofday");
113 if (!vdso_gettimeofday)
114 printf("Warning: failed to find gettimeofday in vDSO\n");
115
98} 116}
99 117
100static long sys_getcpu(unsigned * cpu, unsigned * node, 118static long sys_getcpu(unsigned * cpu, unsigned * node,
@@ -103,6 +121,16 @@ static long sys_getcpu(unsigned * cpu, unsigned * node,
103 return syscall(__NR_getcpu, cpu, node, cache); 121 return syscall(__NR_getcpu, cpu, node, cache);
104} 122}
105 123
124static inline int sys_clock_gettime(clockid_t id, struct timespec *ts)
125{
126 return syscall(__NR_clock_gettime, id, ts);
127}
128
129static inline int sys_gettimeofday(struct timeval *tv, struct timezone *tz)
130{
131 return syscall(__NR_gettimeofday, tv, tz);
132}
133
106static void test_getcpu(void) 134static void test_getcpu(void)
107{ 135{
108 printf("[RUN]\tTesting getcpu...\n"); 136 printf("[RUN]\tTesting getcpu...\n");
@@ -155,10 +183,154 @@ static void test_getcpu(void)
155 } 183 }
156} 184}
157 185
186static bool ts_leq(const struct timespec *a, const struct timespec *b)
187{
188 if (a->tv_sec != b->tv_sec)
189 return a->tv_sec < b->tv_sec;
190 else
191 return a->tv_nsec <= b->tv_nsec;
192}
193
194static bool tv_leq(const struct timeval *a, const struct timeval *b)
195{
196 if (a->tv_sec != b->tv_sec)
197 return a->tv_sec < b->tv_sec;
198 else
199 return a->tv_usec <= b->tv_usec;
200}
201
202static char const * const clocknames[] = {
203 [0] = "CLOCK_REALTIME",
204 [1] = "CLOCK_MONOTONIC",
205 [2] = "CLOCK_PROCESS_CPUTIME_ID",
206 [3] = "CLOCK_THREAD_CPUTIME_ID",
207 [4] = "CLOCK_MONOTONIC_RAW",
208 [5] = "CLOCK_REALTIME_COARSE",
209 [6] = "CLOCK_MONOTONIC_COARSE",
210 [7] = "CLOCK_BOOTTIME",
211 [8] = "CLOCK_REALTIME_ALARM",
212 [9] = "CLOCK_BOOTTIME_ALARM",
213 [10] = "CLOCK_SGI_CYCLE",
214 [11] = "CLOCK_TAI",
215};
216
217static void test_one_clock_gettime(int clock, const char *name)
218{
219 struct timespec start, vdso, end;
220 int vdso_ret, end_ret;
221
222 printf("[RUN]\tTesting clock_gettime for clock %s (%d)...\n", name, clock);
223
224 if (sys_clock_gettime(clock, &start) < 0) {
225 if (errno == EINVAL) {
226 vdso_ret = vdso_clock_gettime(clock, &vdso);
227 if (vdso_ret == -EINVAL) {
228 printf("[OK]\tNo such clock.\n");
229 } else {
230 printf("[FAIL]\tNo such clock, but __vdso_clock_gettime returned %d\n", vdso_ret);
231 nerrs++;
232 }
233 } else {
234 printf("[WARN]\t clock_gettime(%d) syscall returned error %d\n", clock, errno);
235 }
236 return;
237 }
238
239 vdso_ret = vdso_clock_gettime(clock, &vdso);
240 end_ret = sys_clock_gettime(clock, &end);
241
242 if (vdso_ret != 0 || end_ret != 0) {
243 printf("[FAIL]\tvDSO returned %d, syscall errno=%d\n",
244 vdso_ret, errno);
245 nerrs++;
246 return;
247 }
248
249 printf("\t%llu.%09ld %llu.%09ld %llu.%09ld\n",
250 (unsigned long long)start.tv_sec, start.tv_nsec,
251 (unsigned long long)vdso.tv_sec, vdso.tv_nsec,
252 (unsigned long long)end.tv_sec, end.tv_nsec);
253
254 if (!ts_leq(&start, &vdso) || !ts_leq(&vdso, &end)) {
255 printf("[FAIL]\tTimes are out of sequence\n");
256 nerrs++;
257 }
258}
259
260static void test_clock_gettime(void)
261{
262 for (int clock = 0; clock < sizeof(clocknames) / sizeof(clocknames[0]);
263 clock++) {
264 test_one_clock_gettime(clock, clocknames[clock]);
265 }
266
267 /* Also test some invalid clock ids */
268 test_one_clock_gettime(-1, "invalid");
269 test_one_clock_gettime(INT_MIN, "invalid");
270 test_one_clock_gettime(INT_MAX, "invalid");
271}
272
273static void test_gettimeofday(void)
274{
275 struct timeval start, vdso, end;
276 struct timezone sys_tz, vdso_tz;
277 int vdso_ret, end_ret;
278
279 if (!vdso_gettimeofday)
280 return;
281
282 printf("[RUN]\tTesting gettimeofday...\n");
283
284 if (sys_gettimeofday(&start, &sys_tz) < 0) {
285 printf("[FAIL]\tsys_gettimeofday failed (%d)\n", errno);
286 nerrs++;
287 return;
288 }
289
290 vdso_ret = vdso_gettimeofday(&vdso, &vdso_tz);
291 end_ret = sys_gettimeofday(&end, NULL);
292
293 if (vdso_ret != 0 || end_ret != 0) {
294 printf("[FAIL]\tvDSO returned %d, syscall errno=%d\n",
295 vdso_ret, errno);
296 nerrs++;
297 return;
298 }
299
300 printf("\t%llu.%06ld %llu.%06ld %llu.%06ld\n",
301 (unsigned long long)start.tv_sec, start.tv_usec,
302 (unsigned long long)vdso.tv_sec, vdso.tv_usec,
303 (unsigned long long)end.tv_sec, end.tv_usec);
304
305 if (!tv_leq(&start, &vdso) || !tv_leq(&vdso, &end)) {
306 printf("[FAIL]\tTimes are out of sequence\n");
307 nerrs++;
308 }
309
310 if (sys_tz.tz_minuteswest == vdso_tz.tz_minuteswest &&
311 sys_tz.tz_dsttime == vdso_tz.tz_dsttime) {
312 printf("[OK]\ttimezones match: minuteswest=%d, dsttime=%d\n",
313 sys_tz.tz_minuteswest, sys_tz.tz_dsttime);
314 } else {
315 printf("[FAIL]\ttimezones do not match\n");
316 nerrs++;
317 }
318
319 /* And make sure that passing NULL for tz doesn't crash. */
320 vdso_gettimeofday(&vdso, NULL);
321}
322
158int main(int argc, char **argv) 323int main(int argc, char **argv)
159{ 324{
160 fill_function_pointers(); 325 fill_function_pointers();
161 326
327 test_clock_gettime();
328 test_gettimeofday();
329
330 /*
331 * Test getcpu() last so that, if something goes wrong setting affinity,
332 * we still run the other tests.
333 */
162 test_getcpu(); 334 test_getcpu();
163 335
164 return nerrs ? 1 : 0; 336 return nerrs ? 1 : 0;