diff options
author | Andrey Ignatov <rdna@fb.com> | 2018-12-13 16:19:01 -0500 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2018-12-13 17:42:16 -0500 |
commit | 28c1272914613b6c5a0129d6d502c790d4f23d6c (patch) | |
tree | 111a70743c7fff1c8f4a0a1720203818f8d89bc6 /tools | |
parent | 9f8c1c5712954f9d8877ac55b18adbdf03e51e1f (diff) |
selftests/bpf: Fix sk lookup usage in test_sock_addr
Semantic of netns_id argument of bpf_sk_lookup_tcp and bpf_sk_lookup_udp
was changed (fixed) in f71c6143c203. Corresponding changes have to be
applied to all call sites in selftests. The patch fixes corresponding
call sites in test_sock_addr test: pass BPF_F_CURRENT_NETNS instead of 0
in netns_id argument.
Fixes: f71c6143c203 ("bpf: Support sk lookup in netns with id 0")
Reported-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Andrey Ignatov <rdna@fb.com>
Acked-by: Joe Stringer <joe@wand.net.nz>
Tested-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/testing/selftests/bpf/connect4_prog.c | 6 | ||||
-rw-r--r-- | tools/testing/selftests/bpf/connect6_prog.c | 6 |
2 files changed, 8 insertions, 4 deletions
diff --git a/tools/testing/selftests/bpf/connect4_prog.c b/tools/testing/selftests/bpf/connect4_prog.c index b8395f3c43e9..1fd244d35ba9 100644 --- a/tools/testing/selftests/bpf/connect4_prog.c +++ b/tools/testing/selftests/bpf/connect4_prog.c | |||
@@ -35,9 +35,11 @@ int connect_v4_prog(struct bpf_sock_addr *ctx) | |||
35 | if (ctx->type != SOCK_STREAM && ctx->type != SOCK_DGRAM) | 35 | if (ctx->type != SOCK_STREAM && ctx->type != SOCK_DGRAM) |
36 | return 0; | 36 | return 0; |
37 | else if (ctx->type == SOCK_STREAM) | 37 | else if (ctx->type == SOCK_STREAM) |
38 | sk = bpf_sk_lookup_tcp(ctx, &tuple, sizeof(tuple.ipv4), 0, 0); | 38 | sk = bpf_sk_lookup_tcp(ctx, &tuple, sizeof(tuple.ipv4), |
39 | BPF_F_CURRENT_NETNS, 0); | ||
39 | else | 40 | else |
40 | sk = bpf_sk_lookup_udp(ctx, &tuple, sizeof(tuple.ipv4), 0, 0); | 41 | sk = bpf_sk_lookup_udp(ctx, &tuple, sizeof(tuple.ipv4), |
42 | BPF_F_CURRENT_NETNS, 0); | ||
41 | 43 | ||
42 | if (!sk) | 44 | if (!sk) |
43 | return 0; | 45 | return 0; |
diff --git a/tools/testing/selftests/bpf/connect6_prog.c b/tools/testing/selftests/bpf/connect6_prog.c index 25f5dc7b7aa0..26397ab7b3c7 100644 --- a/tools/testing/selftests/bpf/connect6_prog.c +++ b/tools/testing/selftests/bpf/connect6_prog.c | |||
@@ -47,9 +47,11 @@ int connect_v6_prog(struct bpf_sock_addr *ctx) | |||
47 | if (ctx->type != SOCK_STREAM && ctx->type != SOCK_DGRAM) | 47 | if (ctx->type != SOCK_STREAM && ctx->type != SOCK_DGRAM) |
48 | return 0; | 48 | return 0; |
49 | else if (ctx->type == SOCK_STREAM) | 49 | else if (ctx->type == SOCK_STREAM) |
50 | sk = bpf_sk_lookup_tcp(ctx, &tuple, sizeof(tuple.ipv6), 0, 0); | 50 | sk = bpf_sk_lookup_tcp(ctx, &tuple, sizeof(tuple.ipv6), |
51 | BPF_F_CURRENT_NETNS, 0); | ||
51 | else | 52 | else |
52 | sk = bpf_sk_lookup_udp(ctx, &tuple, sizeof(tuple.ipv6), 0, 0); | 53 | sk = bpf_sk_lookup_udp(ctx, &tuple, sizeof(tuple.ipv6), |
54 | BPF_F_CURRENT_NETNS, 0); | ||
53 | 55 | ||
54 | if (!sk) | 56 | if (!sk) |
55 | return 0; | 57 | return 0; |