summaryrefslogtreecommitdiffstats
path: root/tools/perf/perf.c
diff options
context:
space:
mode:
authorTaeung Song <treeze.taeung@gmail.com>2016-06-23 10:14:31 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2016-06-23 16:20:04 -0400
commit8a0a9c7e9146781defc96f6743e7ee14ccc9ab23 (patch)
tree832a6c519cc5b76ff19a491ce9d85795fd4151b3 /tools/perf/perf.c
parente216708d982a1c262f411fee2fcac2bd9ec93a32 (diff)
perf config: Introduce new init() and exit()
Many sub-commands use perf_config() but everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system config '$(sysconfdir)/perfconfig') But it is better to use the config set that already contains all config key-value pairs to avoid this repetitive work reading the config files in perf_config(). (the config set mean a static variable 'config_set') In other words, if new perf_config__init() is called, only first time 'config_set' is initialized collecting all configs from the config files. And then we could use new perf_config() like old perf_config(). When a sub-command finished, free the config set by perf_config__exit() at run_builtin(). If we do, 'config_set' can be reused wherever perf_config() is called and a feature of old perf_config() is the same as new perf_config() work without the repetitive work that read the config files. In summary, in order to use features about configuration, we can call the functions at perf.c and other source files as below. # initialize a config set perf_config__init() # configure actual variables from a config set perf_config() # eliminate allocated config set perf_config__exit() # destroy existing config set and initialize a new config set. perf_config__refresh() Signed-off-by: Taeung Song <treeze.taeung@gmail.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/r/1466691272-24117-3-git-send-email-treeze.taeung@gmail.com [ 'init' counterpart is 'exit', not 'finish' ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/perf.c')
-rw-r--r--tools/perf/perf.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 66772dafa3ec..8f219223f305 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -355,6 +355,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
355 355
356 perf_env__set_cmdline(&perf_env, argc, argv); 356 perf_env__set_cmdline(&perf_env, argc, argv);
357 status = p->fn(argc, argv, prefix); 357 status = p->fn(argc, argv, prefix);
358 perf_config__exit();
358 exit_browser(status); 359 exit_browser(status);
359 perf_env__exit(&perf_env); 360 perf_env__exit(&perf_env);
360 bpf__clear(); 361 bpf__clear();
@@ -522,6 +523,7 @@ int main(int argc, const char **argv)
522 523
523 srandom(time(NULL)); 524 srandom(time(NULL));
524 525
526 perf_config__init();
525 perf_config(perf_default_config, NULL); 527 perf_config(perf_default_config, NULL);
526 set_buildid_dir(NULL); 528 set_buildid_dir(NULL);
527 529