summaryrefslogtreecommitdiffstats
path: root/tools/iio
diff options
context:
space:
mode:
authorHartmut Knaack <knaack.h@gmx.de>2015-05-31 08:40:17 -0400
committerJonathan Cameron <jic23@kernel.org>2015-06-01 03:33:47 -0400
commit0e799878175aa7d08f5882b6a391de4724c52e9e (patch)
tree385a2ad8310cab0879a12a2e111a2c5e576e1231 /tools/iio
parent5dc65d791ddafc9f6d944391e379708b6056fc48 (diff)
tools:iio: return values directly
Return directly, if no common cleanup is required. Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'tools/iio')
-rw-r--r--tools/iio/generic_buffer.c5
-rw-r--r--tools/iio/iio_event_monitor.c5
-rw-r--r--tools/iio/iio_utils.c27
3 files changed, 16 insertions, 21 deletions
diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
index cf9a4120204f..62ec398922a0 100644
--- a/tools/iio/generic_buffer.c
+++ b/tools/iio/generic_buffer.c
@@ -238,8 +238,7 @@ int main(int argc, char **argv)
238 dev_num = find_type_by_name(device_name, "iio:device"); 238 dev_num = find_type_by_name(device_name, "iio:device");
239 if (dev_num < 0) { 239 if (dev_num < 0) {
240 printf("Failed to find the %s\n", device_name); 240 printf("Failed to find the %s\n", device_name);
241 ret = dev_num; 241 return dev_num;
242 goto error_ret;
243 } 242 }
244 printf("iio device number being used is %d\n", dev_num); 243 printf("iio device number being used is %d\n", dev_num);
245 244
@@ -410,6 +409,6 @@ error_free_triggername:
410 free(trigger_name); 409 free(trigger_name);
411error_free_dev_dir_name: 410error_free_dev_dir_name:
412 free(dev_dir_name); 411 free(dev_dir_name);
413error_ret: 412
414 return ret; 413 return ret;
415} 414}
diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
index 1316527f3c3c..7f56238b1d66 100644
--- a/tools/iio/iio_event_monitor.c
+++ b/tools/iio/iio_event_monitor.c
@@ -258,8 +258,7 @@ int main(int argc, char **argv)
258 device_name, dev_num); 258 device_name, dev_num);
259 ret = asprintf(&chrdev_name, "/dev/iio:device%d", dev_num); 259 ret = asprintf(&chrdev_name, "/dev/iio:device%d", dev_num);
260 if (ret < 0) { 260 if (ret < 0) {
261 ret = -ENOMEM; 261 return -ENOMEM;
262 goto error_ret;
263 } 262 }
264 } else { 263 } else {
265 /* If we can't find a IIO device by name assume device_name is a 264 /* If we can't find a IIO device by name assume device_name is a
@@ -312,6 +311,6 @@ int main(int argc, char **argv)
312 311
313error_free_chrdev_name: 312error_free_chrdev_name:
314 free(chrdev_name); 313 free(chrdev_name);
315error_ret: 314
316 return ret; 315 return ret;
317} 316}
diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
index 5d5831d7dfd0..0524725279bb 100644
--- a/tools/iio/iio_utils.c
+++ b/tools/iio/iio_utils.c
@@ -107,10 +107,9 @@ int iioutils_get_type(unsigned *is_signed,
107 const struct dirent *ent; 107 const struct dirent *ent;
108 108
109 ret = asprintf(&scan_el_dir, FORMAT_SCAN_ELEMENTS_DIR, device_dir); 109 ret = asprintf(&scan_el_dir, FORMAT_SCAN_ELEMENTS_DIR, device_dir);
110 if (ret < 0) { 110 if (ret < 0)
111 ret = -ENOMEM; 111 return -ENOMEM;
112 goto error_ret; 112
113 }
114 ret = asprintf(&builtname, FORMAT_TYPE_FILE, name); 113 ret = asprintf(&builtname, FORMAT_TYPE_FILE, name);
115 if (ret < 0) { 114 if (ret < 0) {
116 ret = -ENOMEM; 115 ret = -ENOMEM;
@@ -202,7 +201,7 @@ error_free_builtname:
202 free(builtname); 201 free(builtname);
203error_free_scan_el_dir: 202error_free_scan_el_dir:
204 free(scan_el_dir); 203 free(scan_el_dir);
205error_ret: 204
206 return ret; 205 return ret;
207} 206}
208 207
@@ -230,10 +229,9 @@ int iioutils_get_param_float(float *output,
230 const struct dirent *ent; 229 const struct dirent *ent;
231 230
232 ret = asprintf(&builtname, "%s_%s", name, param_name); 231 ret = asprintf(&builtname, "%s_%s", name, param_name);
233 if (ret < 0) { 232 if (ret < 0)
234 ret = -ENOMEM; 233 return -ENOMEM;
235 goto error_ret; 234
236 }
237 ret = asprintf(&builtname_generic, 235 ret = asprintf(&builtname_generic,
238 "%s_%s", generic_name, param_name); 236 "%s_%s", generic_name, param_name);
239 if (ret < 0) { 237 if (ret < 0) {
@@ -277,7 +275,7 @@ error_free_builtname_generic:
277 free(builtname_generic); 275 free(builtname_generic);
278error_free_builtname: 276error_free_builtname:
279 free(builtname); 277 free(builtname);
280error_ret: 278
281 return ret; 279 return ret;
282} 280}
283 281
@@ -326,10 +324,9 @@ int build_channel_array(const char *device_dir,
326 324
327 *counter = 0; 325 *counter = 0;
328 ret = asprintf(&scan_el_dir, FORMAT_SCAN_ELEMENTS_DIR, device_dir); 326 ret = asprintf(&scan_el_dir, FORMAT_SCAN_ELEMENTS_DIR, device_dir);
329 if (ret < 0) { 327 if (ret < 0)
330 ret = -ENOMEM; 328 return -ENOMEM;
331 goto error_ret; 329
332 }
333 dp = opendir(scan_el_dir); 330 dp = opendir(scan_el_dir);
334 if (dp == NULL) { 331 if (dp == NULL) {
335 ret = -errno; 332 ret = -errno;
@@ -526,7 +523,7 @@ error_close_dir:
526 523
527error_free_name: 524error_free_name:
528 free(scan_el_dir); 525 free(scan_el_dir);
529error_ret: 526
530 return ret; 527 return ret;
531} 528}
532 529