summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2019-06-27 21:49:30 -0400
committerMark Brown <broonie@kernel.org>2019-06-28 10:19:35 -0400
commiteb313e23da8da79cf18dff5ee1dbba3580df83b5 (patch)
treeb1655ebd39031e265588f177a6deac6523f2c1be /sound
parentc5e8c53630a677a347a04e56df2e8c9f43f65c2e (diff)
ASoC: ti: omap-twl4030: consider CPU-Platform possibility
commit bfe1273c65e1 ("ASoC: ti: omap-twl4030: don't select unnecessary Platform") Current ALSA SoC avoid to add duplicate component to rtd, and this driver was selecting CPU component as Platform component. Thus, above patch removed Platform settings from this driver, because it assumed these are same component. But, some CPU driver is using generic DMAEngine, in such case, both CPU component and Platform component will have same of_node/name. In other words, there are some components which are different but have same of_node/name. In such case, Card driver definitely need to select Platform even though it is same as CPU. It is depends on CPU driver, but is difficult to know it from Card driver. This patch reverts above patch. Fixes: commit bfe1273c65e1 ("ASoC: ti: omap-twl4030: don't select unnecessary Platform") Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/ti/omap-twl4030.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/sound/soc/ti/omap-twl4030.c b/sound/soc/ti/omap-twl4030.c
index 34e79e57f039..92dbe2c67290 100644
--- a/sound/soc/ti/omap-twl4030.c
+++ b/sound/soc/ti/omap-twl4030.c
@@ -197,11 +197,13 @@ static int omap_twl4030_init(struct snd_soc_pcm_runtime *rtd)
197/* Digital audio interface glue - connects codec <--> CPU */ 197/* Digital audio interface glue - connects codec <--> CPU */
198SND_SOC_DAILINK_DEFS(hifi, 198SND_SOC_DAILINK_DEFS(hifi,
199 DAILINK_COMP_ARRAY(COMP_CPU("omap-mcbsp.2")), 199 DAILINK_COMP_ARRAY(COMP_CPU("omap-mcbsp.2")),
200 DAILINK_COMP_ARRAY(COMP_CODEC("twl4030-codec", "twl4030-hifi"))); 200 DAILINK_COMP_ARRAY(COMP_CODEC("twl4030-codec", "twl4030-hifi")),
201 DAILINK_COMP_ARRAY(COMP_PLATFORM("omap-mcbsp.2")));
201 202
202SND_SOC_DAILINK_DEFS(voice, 203SND_SOC_DAILINK_DEFS(voice,
203 DAILINK_COMP_ARRAY(COMP_CPU("omap-mcbsp.3")), 204 DAILINK_COMP_ARRAY(COMP_CPU("omap-mcbsp.3")),
204 DAILINK_COMP_ARRAY(COMP_CODEC("twl4030-codec", "twl4030-voice"))); 205 DAILINK_COMP_ARRAY(COMP_CODEC("twl4030-codec", "twl4030-voice")),
206 DAILINK_COMP_ARRAY(COMP_PLATFORM("omap-mcbsp.3")));
205 207
206static struct snd_soc_dai_link omap_twl4030_dai_links[] = { 208static struct snd_soc_dai_link omap_twl4030_dai_links[] = {
207 { 209 {
@@ -263,12 +265,18 @@ static int omap_twl4030_probe(struct platform_device *pdev)
263 omap_twl4030_dai_links[0].cpus->dai_name = NULL; 265 omap_twl4030_dai_links[0].cpus->dai_name = NULL;
264 omap_twl4030_dai_links[0].cpus->of_node = dai_node; 266 omap_twl4030_dai_links[0].cpus->of_node = dai_node;
265 267
268 omap_twl4030_dai_links[0].platforms->name = NULL;
269 omap_twl4030_dai_links[0].platforms->of_node = dai_node;
270
266 dai_node = of_parse_phandle(node, "ti,mcbsp-voice", 0); 271 dai_node = of_parse_phandle(node, "ti,mcbsp-voice", 0);
267 if (!dai_node) { 272 if (!dai_node) {
268 card->num_links = 1; 273 card->num_links = 1;
269 } else { 274 } else {
270 omap_twl4030_dai_links[1].cpus->dai_name = NULL; 275 omap_twl4030_dai_links[1].cpus->dai_name = NULL;
271 omap_twl4030_dai_links[1].cpus->of_node = dai_node; 276 omap_twl4030_dai_links[1].cpus->of_node = dai_node;
277
278 omap_twl4030_dai_links[1].platforms->name = NULL;
279 omap_twl4030_dai_links[1].platforms->of_node = dai_node;
272 } 280 }
273 281
274 priv->jack_detect = of_get_named_gpio(node, 282 priv->jack_detect = of_get_named_gpio(node,