diff options
author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2019-01-21 02:40:59 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2019-01-21 13:14:16 -0500 |
commit | fe7ed4dec2e6289eab81dd18c0d613c0851d85a1 (patch) | |
tree | dbadb6b8354ab66e5cfb4e1f68f78766bf138bb0 /sound/soc/generic | |
parent | 10dff9b0ddf70bebe9523fc311ec77a872ce0a9c (diff) |
ASoC: simple-card: rename to asoc_simple_card_canonicalize_platform()
Current simple-card is using asoc_simple_card_canonicalize_dailink().
Its naming is "dailink", but is for "platform".
We already have asoc_simple_card_canonicalize_cpu() for "cpu",
let's follow same naming rule.
It never return error, so, void function is better idea.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/generic')
-rw-r--r-- | sound/soc/generic/audio-graph-card.c | 11 | ||||
-rw-r--r-- | sound/soc/generic/simple-card-utils.c | 7 | ||||
-rw-r--r-- | sound/soc/generic/simple-card.c | 11 |
3 files changed, 8 insertions, 21 deletions
diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 42b077c6be4c..bb12351330e8 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c | |||
@@ -307,14 +307,12 @@ static int graph_dai_link_of_dpcm(struct graph_priv *priv, | |||
307 | "prefix"); | 307 | "prefix"); |
308 | } | 308 | } |
309 | 309 | ||
310 | asoc_simple_card_canonicalize_platform(dai_link); | ||
311 | |||
310 | ret = asoc_simple_card_of_parse_tdm(ep, dai); | 312 | ret = asoc_simple_card_of_parse_tdm(ep, dai); |
311 | if (ret) | 313 | if (ret) |
312 | return ret; | 314 | return ret; |
313 | 315 | ||
314 | ret = asoc_simple_card_canonicalize_dailink(dai_link); | ||
315 | if (ret < 0) | ||
316 | return ret; | ||
317 | |||
318 | ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep, | 316 | ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep, |
319 | NULL, &dai_link->dai_fmt); | 317 | NULL, &dai_link->dai_fmt); |
320 | if (ret < 0) | 318 | if (ret < 0) |
@@ -405,10 +403,6 @@ static int graph_dai_link_of(struct graph_priv *priv, | |||
405 | if (ret < 0) | 403 | if (ret < 0) |
406 | return ret; | 404 | return ret; |
407 | 405 | ||
408 | ret = asoc_simple_card_canonicalize_dailink(dai_link); | ||
409 | if (ret < 0) | ||
410 | return ret; | ||
411 | |||
412 | ret = asoc_simple_card_set_dailink_name(dev, dai_link, | 406 | ret = asoc_simple_card_set_dailink_name(dev, dai_link, |
413 | "%s-%s", | 407 | "%s-%s", |
414 | dai_link->cpu_dai_name, | 408 | dai_link->cpu_dai_name, |
@@ -419,6 +413,7 @@ static int graph_dai_link_of(struct graph_priv *priv, | |||
419 | dai_link->ops = &graph_ops; | 413 | dai_link->ops = &graph_ops; |
420 | dai_link->init = graph_dai_init; | 414 | dai_link->init = graph_dai_init; |
421 | 415 | ||
416 | asoc_simple_card_canonicalize_platform(dai_link); | ||
422 | asoc_simple_card_canonicalize_cpu(dai_link, | 417 | asoc_simple_card_canonicalize_cpu(dai_link, |
423 | of_graph_get_endpoint_count(dai_link->cpu_of_node) == 1); | 418 | of_graph_get_endpoint_count(dai_link->cpu_of_node) == 1); |
424 | 419 | ||
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index 3c0901df5796..5c1424f03620 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c | |||
@@ -394,16 +394,13 @@ int asoc_simple_card_init_dai(struct snd_soc_dai *dai, | |||
394 | } | 394 | } |
395 | EXPORT_SYMBOL_GPL(asoc_simple_card_init_dai); | 395 | EXPORT_SYMBOL_GPL(asoc_simple_card_init_dai); |
396 | 396 | ||
397 | int asoc_simple_card_canonicalize_dailink(struct snd_soc_dai_link *dai_link) | 397 | void asoc_simple_card_canonicalize_platform(struct snd_soc_dai_link *dai_link) |
398 | { | 398 | { |
399 | /* Assumes platform == cpu */ | 399 | /* Assumes platform == cpu */ |
400 | if (!dai_link->platforms->of_node) | 400 | if (!dai_link->platforms->of_node) |
401 | dai_link->platforms->of_node = dai_link->cpu_of_node; | 401 | dai_link->platforms->of_node = dai_link->cpu_of_node; |
402 | |||
403 | return 0; | ||
404 | |||
405 | } | 402 | } |
406 | EXPORT_SYMBOL_GPL(asoc_simple_card_canonicalize_dailink); | 403 | EXPORT_SYMBOL_GPL(asoc_simple_card_canonicalize_platform); |
407 | 404 | ||
408 | void asoc_simple_card_canonicalize_cpu(struct snd_soc_dai_link *dai_link, | 405 | void asoc_simple_card_canonicalize_cpu(struct snd_soc_dai_link *dai_link, |
409 | int is_single_links) | 406 | int is_single_links) |
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index d8a0d1ec256e..08df261024cf 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c | |||
@@ -297,14 +297,12 @@ static int simple_dai_link_of_dpcm(struct simple_priv *priv, | |||
297 | 297 | ||
298 | simple_get_conversion(dev, np, &dai_props->adata); | 298 | simple_get_conversion(dev, np, &dai_props->adata); |
299 | 299 | ||
300 | asoc_simple_card_canonicalize_platform(dai_link); | ||
301 | |||
300 | ret = asoc_simple_card_of_parse_tdm(np, dai); | 302 | ret = asoc_simple_card_of_parse_tdm(np, dai); |
301 | if (ret) | 303 | if (ret) |
302 | return ret; | 304 | return ret; |
303 | 305 | ||
304 | ret = asoc_simple_card_canonicalize_dailink(dai_link); | ||
305 | if (ret < 0) | ||
306 | return ret; | ||
307 | |||
308 | snprintf(prop, sizeof(prop), "%smclk-fs", prefix); | 306 | snprintf(prop, sizeof(prop), "%smclk-fs", prefix); |
309 | of_property_read_u32(top, PREFIX "mclk-fs", &dai_props->mclk_fs); | 307 | of_property_read_u32(top, PREFIX "mclk-fs", &dai_props->mclk_fs); |
310 | of_property_read_u32(node, prop, &dai_props->mclk_fs); | 308 | of_property_read_u32(node, prop, &dai_props->mclk_fs); |
@@ -409,10 +407,6 @@ static int simple_dai_link_of(struct simple_priv *priv, | |||
409 | if (ret < 0) | 407 | if (ret < 0) |
410 | goto dai_link_of_err; | 408 | goto dai_link_of_err; |
411 | 409 | ||
412 | ret = asoc_simple_card_canonicalize_dailink(dai_link); | ||
413 | if (ret < 0) | ||
414 | goto dai_link_of_err; | ||
415 | |||
416 | ret = asoc_simple_card_set_dailink_name(dev, dai_link, | 410 | ret = asoc_simple_card_set_dailink_name(dev, dai_link, |
417 | "%s-%s", | 411 | "%s-%s", |
418 | dai_link->cpu_dai_name, | 412 | dai_link->cpu_dai_name, |
@@ -424,6 +418,7 @@ static int simple_dai_link_of(struct simple_priv *priv, | |||
424 | dai_link->init = simple_dai_init; | 418 | dai_link->init = simple_dai_init; |
425 | 419 | ||
426 | asoc_simple_card_canonicalize_cpu(dai_link, single_cpu); | 420 | asoc_simple_card_canonicalize_cpu(dai_link, single_cpu); |
421 | asoc_simple_card_canonicalize_platform(dai_link); | ||
427 | 422 | ||
428 | dai_link_of_err: | 423 | dai_link_of_err: |
429 | of_node_put(node); | 424 | of_node_put(node); |