diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2016-09-01 18:13:10 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2016-09-02 05:49:10 -0400 |
commit | 6769e988b0062bf8d63d35b0fdbb47b385dd3252 (patch) | |
tree | a45f07972e30404bb3f489a9631fbe31b8765ac8 /sound/pci/rme96.c | |
parent | 9d5262ae9b52d5dd96a4c5bd1b683570b84a011e (diff) |
ALSA: constify snd_pcm_ops structures
Check for snd_pcm_ops structures that are only stored in the ops field of a
snd_soc_platform_driver structure or passed as the third argument to
snd_pcm_set_ops. The corresponding field or parameter is declared const,
so snd_pcm_ops structures that have this property can be declared as const
also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_pcm_ops i@p = { ... };
@ok1@
identifier r.i;
struct snd_soc_platform_driver e;
position p;
@@
e.ops = &i@p;
@ok2@
identifier r.i;
expression e1, e2;
position p;
@@
snd_pcm_set_ops(e1, e2, &i@p)
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_pcm_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct snd_pcm_ops i = { ... };
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/rme96.c')
-rw-r--r-- | sound/pci/rme96.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sound/pci/rme96.c b/sound/pci/rme96.c index 41c31db65039..05b9da30990d 100644 --- a/sound/pci/rme96.c +++ b/sound/pci/rme96.c | |||
@@ -1505,7 +1505,7 @@ snd_rme96_capture_pointer(struct snd_pcm_substream *substream) | |||
1505 | return snd_rme96_capture_ptr(rme96); | 1505 | return snd_rme96_capture_ptr(rme96); |
1506 | } | 1506 | } |
1507 | 1507 | ||
1508 | static struct snd_pcm_ops snd_rme96_playback_spdif_ops = { | 1508 | static const struct snd_pcm_ops snd_rme96_playback_spdif_ops = { |
1509 | .open = snd_rme96_playback_spdif_open, | 1509 | .open = snd_rme96_playback_spdif_open, |
1510 | .close = snd_rme96_playback_close, | 1510 | .close = snd_rme96_playback_close, |
1511 | .ioctl = snd_pcm_lib_ioctl, | 1511 | .ioctl = snd_pcm_lib_ioctl, |
@@ -1518,7 +1518,7 @@ static struct snd_pcm_ops snd_rme96_playback_spdif_ops = { | |||
1518 | .mmap = snd_pcm_lib_mmap_iomem, | 1518 | .mmap = snd_pcm_lib_mmap_iomem, |
1519 | }; | 1519 | }; |
1520 | 1520 | ||
1521 | static struct snd_pcm_ops snd_rme96_capture_spdif_ops = { | 1521 | static const struct snd_pcm_ops snd_rme96_capture_spdif_ops = { |
1522 | .open = snd_rme96_capture_spdif_open, | 1522 | .open = snd_rme96_capture_spdif_open, |
1523 | .close = snd_rme96_capture_close, | 1523 | .close = snd_rme96_capture_close, |
1524 | .ioctl = snd_pcm_lib_ioctl, | 1524 | .ioctl = snd_pcm_lib_ioctl, |
@@ -1530,7 +1530,7 @@ static struct snd_pcm_ops snd_rme96_capture_spdif_ops = { | |||
1530 | .mmap = snd_pcm_lib_mmap_iomem, | 1530 | .mmap = snd_pcm_lib_mmap_iomem, |
1531 | }; | 1531 | }; |
1532 | 1532 | ||
1533 | static struct snd_pcm_ops snd_rme96_playback_adat_ops = { | 1533 | static const struct snd_pcm_ops snd_rme96_playback_adat_ops = { |
1534 | .open = snd_rme96_playback_adat_open, | 1534 | .open = snd_rme96_playback_adat_open, |
1535 | .close = snd_rme96_playback_close, | 1535 | .close = snd_rme96_playback_close, |
1536 | .ioctl = snd_pcm_lib_ioctl, | 1536 | .ioctl = snd_pcm_lib_ioctl, |
@@ -1543,7 +1543,7 @@ static struct snd_pcm_ops snd_rme96_playback_adat_ops = { | |||
1543 | .mmap = snd_pcm_lib_mmap_iomem, | 1543 | .mmap = snd_pcm_lib_mmap_iomem, |
1544 | }; | 1544 | }; |
1545 | 1545 | ||
1546 | static struct snd_pcm_ops snd_rme96_capture_adat_ops = { | 1546 | static const struct snd_pcm_ops snd_rme96_capture_adat_ops = { |
1547 | .open = snd_rme96_capture_adat_open, | 1547 | .open = snd_rme96_capture_adat_open, |
1548 | .close = snd_rme96_capture_close, | 1548 | .close = snd_rme96_capture_close, |
1549 | .ioctl = snd_pcm_lib_ioctl, | 1549 | .ioctl = snd_pcm_lib_ioctl, |