summaryrefslogtreecommitdiffstats
path: root/security/apparmor
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2019-05-05 12:28:45 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2019-05-05 12:28:45 -0400
commit51987affd626b8e4ce9f4c65e1950cb9159f0f58 (patch)
tree9c10c7f5accd7cf6717597af815d6f80d4efbfd5 /security/apparmor
parent6203838dec05352bc357625b1e9ba0a10d3bca35 (diff)
parent4e9036042fedaffcd868d7f7aa948756c48c637d (diff)
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs fixes from Al Viro: - a couple of ->i_link use-after-free fixes - regression fix for wrong errno on absent device name in mount(2) (this cycle stuff) - ancient UFS braino in large GID handling on Solaris UFS images (bogus cut'n'paste from large UID handling; wrong field checked to decide whether we should look at old (16bit) or new (32bit) field) * 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour Abort file_remove_privs() for non-reg. files [fix] get rid of checking for absent device name in vfs_get_tree() apparmorfs: fix use-after-free on symlink traversal securityfs: fix use-after-free on symlink traversal
Diffstat (limited to 'security/apparmor')
-rw-r--r--security/apparmor/apparmorfs.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
index fefee040bf79..b9298d2e8165 100644
--- a/security/apparmor/apparmorfs.c
+++ b/security/apparmor/apparmorfs.c
@@ -123,17 +123,22 @@ static int aafs_show_path(struct seq_file *seq, struct dentry *dentry)
123 return 0; 123 return 0;
124} 124}
125 125
126static void aafs_evict_inode(struct inode *inode) 126static void aafs_i_callback(struct rcu_head *head)
127{ 127{
128 truncate_inode_pages_final(&inode->i_data); 128 struct inode *inode = container_of(head, struct inode, i_rcu);
129 clear_inode(inode);
130 if (S_ISLNK(inode->i_mode)) 129 if (S_ISLNK(inode->i_mode))
131 kfree(inode->i_link); 130 kfree(inode->i_link);
131 free_inode_nonrcu(inode);
132}
133
134static void aafs_destroy_inode(struct inode *inode)
135{
136 call_rcu(&inode->i_rcu, aafs_i_callback);
132} 137}
133 138
134static const struct super_operations aafs_super_ops = { 139static const struct super_operations aafs_super_ops = {
135 .statfs = simple_statfs, 140 .statfs = simple_statfs,
136 .evict_inode = aafs_evict_inode, 141 .destroy_inode = aafs_destroy_inode,
137 .show_path = aafs_show_path, 142 .show_path = aafs_show_path,
138}; 143};
139 144