diff options
author | Joe Perches <joe@perches.com> | 2015-02-13 17:39:02 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-14 00:21:40 -0500 |
commit | a2fe16b9d878a101b67678872e5cd1410c057ec0 (patch) | |
tree | 393cd83ee3e7ff6a34f26ef40b55aa40cf701784 /scripts | |
parent | 19c146a64c5e14c5dd910e930565edf74637a423 (diff) |
checkpatch: try to avoid poor patch subject lines
Naming the tool that found an issue in the subject line isn't very useful.
Emit a warning when a common tool (currently checkpatch, sparse or
smatch) is in the subject line.
Signed-off-by: Joe Perches <joe@perches.com>
Suggested-by: Al Viro <viro@ZenIV.linux.org.uk>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3642b0d5ad6a..9c720e1261e9 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2170,6 +2170,13 @@ sub process { | |||
2170 | } | 2170 | } |
2171 | } | 2171 | } |
2172 | 2172 | ||
2173 | # Check email subject for common tools that don't need to be mentioned | ||
2174 | if ($in_header_lines && | ||
2175 | $line =~ /^Subject:.*\b(?:checkpatch|sparse|smatch)\b[^:]/i) { | ||
2176 | WARN("EMAIL_SUBJECT", | ||
2177 | "A patch subject line should describe the change not the tool that found it\n" . $herecurr); | ||
2178 | } | ||
2179 | |||
2173 | # Check for old stable address | 2180 | # Check for old stable address |
2174 | if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) { | 2181 | if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) { |
2175 | ERROR("STABLE_ADDRESS", | 2182 | ERROR("STABLE_ADDRESS", |