diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-05-09 03:35:55 -0400 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-05-17 22:49:55 -0400 |
commit | 902a6898bfb4878eb186d9223d12c903a5f60fa5 (patch) | |
tree | 6b4fe1e637ed50168462009b8f3863f1f8046733 /scripts | |
parent | d2f8ae0e4c5c754f1b2a7b8388d19a1a977e698a (diff) |
kbuild: terminate Kconfig when $(CC) or $(LD) is missing
If the compiler specified by $(CC) is not present, the Kconfig stage
sprinkles 'not found' messages, then succeeds.
$ make CROSS_COMPILE=foo defconfig
/bin/sh: 1: foogcc: not found
/bin/sh: 1: foogcc: not found
*** Default configuration is based on 'x86_64_defconfig'
./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found
./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found
./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found
./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found
./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found
./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found
./scripts/clang-version.sh: 11: ./scripts/clang-version.sh: foogcc: not found
./scripts/gcc-plugin.sh: 11: ./scripts/gcc-plugin.sh: foogcc: not found
init/Kconfig:16:warning: 'GCC_VERSION': number is invalid
#
# configuration written to .config
#
Terminate parsing files immediately if $(CC) or $(LD) is not found.
"make *config" will fail more nicely.
$ make CROSS_COMPILE=foo defconfig
*** Default configuration is based on 'x86_64_defconfig'
scripts/Kconfig.include:34: compiler 'foogcc' not found
make[1]: *** [scripts/kconfig/Makefile;82: defconfig] Error 1
make: *** [Makefile;557: defconfig] Error 2
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'scripts')
-rw-r--r-- | scripts/Kconfig.include | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include index 87ff1dcc6bd5..0b267fb27f07 100644 --- a/scripts/Kconfig.include +++ b/scripts/Kconfig.include | |||
@@ -18,6 +18,10 @@ if-success = $(shell,{ $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)") | |||
18 | # Return y if <command> exits with 0, n otherwise | 18 | # Return y if <command> exits with 0, n otherwise |
19 | success = $(if-success,$(1),y,n) | 19 | success = $(if-success,$(1),y,n) |
20 | 20 | ||
21 | # $(failure,<command>) | ||
22 | # Return n if <command> exits with 0, y otherwise | ||
23 | failure = $(if-success,$(1),n,y) | ||
24 | |||
21 | # $(cc-option,<flag>) | 25 | # $(cc-option,<flag>) |
22 | # Return y if the compiler supports <flag>, n otherwise | 26 | # Return y if the compiler supports <flag>, n otherwise |
23 | cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) | 27 | cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) |
@@ -26,5 +30,9 @@ cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) | |||
26 | # Return y if the linker supports <flag>, n otherwise | 30 | # Return y if the linker supports <flag>, n otherwise |
27 | ld-option = $(success,$(LD) -v $(1)) | 31 | ld-option = $(success,$(LD) -v $(1)) |
28 | 32 | ||
33 | # check if $(CC) and $(LD) exist | ||
34 | $(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found) | ||
35 | $(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found) | ||
36 | |||
29 | # gcc version including patch level | 37 | # gcc version including patch level |
30 | gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) | 38 | gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) |