summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorAndrii Nakryiko <andriin@fb.com>2019-04-15 17:58:39 -0400
committerDaniel Borkmann <daniel@iogearbox.net>2019-04-16 03:47:50 -0400
commit68e5ab1fc8bd9c17ed94ac172ffe0b9b7e85a59a (patch)
tree7feb292fb83e6691bd4eac74a285a20370e2121e /scripts
parentc342dc109aa5a4f0bb36335cb441aaafc98b98ef (diff)
kbuild: handle old pahole more gracefully when generating BTF
When CONFIG_DEBUG_INFO_BTF is enabled but available version of pahole is too old to support BTF generation, build script is supposed to emit warning and proceed with the build. Due to using exit instead of return from BASH function, existing handling code prematurely exits exit code 0, not completing some of the build steps. This patch fixes issue by correctly returning just from gen_btf() function only. Fixes: e83b9f55448a ("kbuild: add ability to generate BTF type info for vmlinux") Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@fb.com> Cc: Yonghong Song <yhs@fb.com> Cc: Martin KaFai Lau <kafai@fb.com> Signed-off-by: Andrii Nakryiko <andriin@fb.com> Acked-by: Song Liu <songliubraving@fb.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/link-vmlinux.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index dd2b31ccca6a..6a148d0d51bf 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -99,7 +99,7 @@ gen_btf()
99 pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') 99 pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/')
100 if [ "${pahole_ver}" -lt "113" ]; then 100 if [ "${pahole_ver}" -lt "113" ]; then
101 info "BTF" "${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13" 101 info "BTF" "${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13"
102 exit 0 102 return 0
103 fi 103 fi
104 104
105 info "BTF" ${1} 105 info "BTF" ${1}