networking: make skb_put & friends return void pointers

It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions (skb_put, __skb_put and pskb_put) return void * and remove all the casts across the tree, adding a (u8 *) cast only where the unsigned char pointer was used directly, all done with the following spatch: @@ expression SKB, LEN; typedef u8; identifier fn = { skb_put, __skb_put }; @@ - *(fn(SKB, LEN)) + *(u8 *)fn(SKB, LEN) @@ expression E, SKB, LEN; identifier fn = { skb_put, __skb_put }; type T; @@ - E = ((T *)(fn(SKB, LEN))) + E = fn(SKB, LEN) which actually doesn't cover pskb_put since there are only three users overall. A handful of stragglers were converted manually, notably a macro in drivers/isdn/i4l/isdn_bsdcomp.c and, oddly enough, one of the many instances in net/bluetooth/hci_sock.c. In the former file, I also had to fix one whitespace problem spatch introduced. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
author: Johannes Berg <johannes.berg@intel.com> 2017-06-16 08:29:21 -0400
committer: David S. Miller <davem@davemloft.net> 2017-06-16 11:48:39 -0400
commit: 4df864c1d9afb46e2461a9f808d9f11a42d31bad (patch)
tree: 07e7b3d16b161e0d199c5b8116df277798566e4f /net
parent: 59ae1d127ac0ae404baf414c434ba2651b793f46 (diff)
52 files changed, 199 insertions, 226 deletions
diff --git a/net/802/garp.c b/net/802/garp.c
index b38ee6dcba45..a9a266569293 100644
--- a/net/802/garp.c
+++ b/net/802/garp.c
@@ -221,7 +221,7 @@ static int garp_pdu_init(struct garp_applicant *app)
        skb->protocol = htons(ETH_P_802_2);
        skb_reserve(skb, LL_RESERVED_SPACE(app->dev) + LLC_RESERVE);
-        gp = (struct garp_pdu_hdr *)__skb_put(skb, sizeof(*gp));
+        gp = __skb_put(skb, sizeof(*gp));
        put_unaligned(htons(GARP_PROTOCOL_ID), &gp->protocol);
        app->pdu = skb;
@@ -268,7 +268,7 @@ static int garp_pdu_append_msg(struct garp_applicant *app, u8 attrtype)
        if (skb_tailroom(app->pdu) < sizeof(*gm))
                return -1;
-        gm = (struct garp_msg_hdr *)__skb_put(app->pdu, sizeof(*gm));
+        gm = __skb_put(app->pdu, sizeof(*gm));
        gm->attrtype = attrtype;
        garp_cb(app->pdu)->cur_type = attrtype;
        return 0;
@@ -299,7 +299,7 @@ again:
        len = sizeof(*ga) + attr->dlen;
        if (skb_tailroom(app->pdu) < len)
                goto queue;
-        ga = (struct garp_attr_hdr *)__skb_put(app->pdu, len);
+        ga = __skb_put(app->pdu, len);
        ga->len   = len;
        ga->event = event;
        memcpy(ga->data, attr->data, attr->dlen);
diff --git a/net/802/mrp.c b/net/802/mrp.c
index 72db2785ef2c..be4dd3165347 100644
--- a/net/802/mrp.c
+++ b/net/802/mrp.c
@@ -311,7 +311,7 @@ static int mrp_pdu_init(struct mrp_applicant *app)
        skb_reset_network_header(skb);
        skb_reset_transport_header(skb);
-        ph = (struct mrp_pdu_hdr *)__skb_put(skb, sizeof(*ph));
+        ph = __skb_put(skb, sizeof(*ph));
        ph->version = app->app->version;
        app->pdu = skb;
@@ -324,7 +324,7 @@ static int mrp_pdu_append_end_mark(struct mrp_applicant *app)
        if (skb_tailroom(app->pdu) < sizeof(*endmark))
                return -1;
-        endmark = (__be16 *)__skb_put(app->pdu, sizeof(*endmark));
+        endmark = __skb_put(app->pdu, sizeof(*endmark));
        put_unaligned(MRP_END_MARK, endmark);
        return 0;
 }
@@ -368,7 +368,7 @@ static int mrp_pdu_append_msg_hdr(struct mrp_applicant *app,
        if (skb_tailroom(app->pdu) < sizeof(*mh))
                return -1;
-        mh = (struct mrp_msg_hdr *)__skb_put(app->pdu, sizeof(*mh));
+        mh = __skb_put(app->pdu, sizeof(*mh));
        mh->attrtype = attrtype;
        mh->attrlen = attrlen;
        mrp_cb(app->pdu)->mh = mh;
@@ -382,8 +382,7 @@ static int mrp_pdu_append_vecattr_hdr(struct mrp_applicant *app,
        if (skb_tailroom(app->pdu) < sizeof(*vah) + attrlen)
                return -1;
-        vah = (struct mrp_vecattr_hdr *)__skb_put(app->pdu,
+        vah = __skb_put(app->pdu, sizeof(*vah) + attrlen);
-                                                  sizeof(*vah) + attrlen);
        put_unaligned(0, &vah->lenflags);
        memcpy(vah->firstattrvalue, firstattrvalue, attrlen);
        mrp_cb(app->pdu)->vah = vah;
@@ -435,7 +434,7 @@ again:
        if (!pos) {
                if (skb_tailroom(app->pdu) < sizeof(u8))
                        goto queue;
-                vaevents = (u8 *)__skb_put(app->pdu, sizeof(u8));
+                vaevents = __skb_put(app->pdu, sizeof(u8));
        } else {
                vaevents = (u8 *)(skb_tail_pointer(app->pdu) - sizeof(u8));
        }
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 465cc24b41e5..c7af6dc70fa2 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1647,7 +1647,7 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
        SOCK_DEBUG(sk, "SK %p: Begin build.\n", sk);
-        ddp = (struct ddpehdr *)skb_put(skb, sizeof(struct ddpehdr));
+        ddp = skb_put(skb, sizeof(struct ddpehdr));
        ddp->deh_len_hops  = htons(len + sizeof(*ddp));
        ddp->deh_dnet  = usat->sat_addr.s_net;
        ddp->deh_snet  = at->src_net;
diff --git a/net/atm/clip.c b/net/atm/clip.c
index ec527b62f79d..a7e4018370b4 100644
--- a/net/atm/clip.c
+++ b/net/atm/clip.c
@@ -60,7 +60,7 @@ static int to_atmarpd(enum atmarp_ctrl_type type, int itf, __be32 ip)
        skb = alloc_skb(sizeof(struct atmarp_ctrl), GFP_ATOMIC);
        if (!skb)
                return -ENOMEM;
-        ctrl = (struct atmarp_ctrl *)skb_put(skb, sizeof(struct atmarp_ctrl));
+        ctrl = skb_put(skb, sizeof(struct atmarp_ctrl));
        ctrl->type = type;
        ctrl->itf_num = itf;
        ctrl->ip = ip;
diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c
index 6308c9f0fd96..8ead292886d1 100644
--- a/net/batman-adv/icmp_socket.c
+++ b/net/batman-adv/icmp_socket.c
@@ -207,7 +207,7 @@ static ssize_t batadv_socket_write(struct file *file, const char __user *buff,
        skb->priority = TC_PRIO_CONTROL;
        skb_reserve(skb, ETH_HLEN);
-        icmp_header = (struct batadv_icmp_header *)skb_put(skb, packet_len);
+        icmp_header = skb_put(skb, packet_len);
        if (copy_from_user(icmp_header, buff, packet_len)) {
                len = -EFAULT;
diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c
index e3e2585d0977..bfe8effe9238 100644
--- a/net/batman-adv/tp_meter.c
+++ b/net/batman-adv/tp_meter.c
@@ -595,7 +595,7 @@ static int batadv_tp_send_msg(struct batadv_tp_vars *tp_vars, const u8 *src,
                return BATADV_TP_REASON_MEMORY_ERROR;
        skb_reserve(skb, ETH_HLEN);
-        icmp = (struct batadv_icmp_tp_packet *)skb_put(skb, sizeof(*icmp));
+        icmp = skb_put(skb, sizeof(*icmp));
        /* fill the icmp header */
        ether_addr_copy(icmp->dst, orig_node->orig);
@@ -612,7 +612,7 @@ static int batadv_tp_send_msg(struct batadv_tp_vars *tp_vars, const u8 *src,
        icmp->timestamp = htonl(timestamp);
        data_len = len - sizeof(*icmp);
-        data = (u8 *)skb_put(skb, data_len);
+        data = skb_put(skb, data_len);
        batadv_tp_fill_prerandom(tp_vars, data, data_len);
        r = batadv_send_skb_to_orig(skb, orig_node, NULL);
@@ -1190,7 +1190,7 @@ static int batadv_tp_send_ack(struct batadv_priv *bat_priv, const u8 *dst,
        }
        skb_reserve(skb, ETH_HLEN);
-        icmp = (struct batadv_icmp_tp_packet *)skb_put(skb, sizeof(*icmp));
+        icmp = skb_put(skb, sizeof(*icmp));
        icmp->packet_type = BATADV_ICMP;
        icmp->version = BATADV_COMPAT_VERSION;
        icmp->ttl = BATADV_TTL;
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index 4e4105a932bd..b73ac149de34 100644
--- a/net/bluetooth/hci_request.c
+++ b/net/bluetooth/hci_request.c
@@ -299,7 +299,7 @@ struct sk_buff *hci_prepare_cmd(struct hci_dev *hdev, u16 opcode, u32 plen,
        if (!skb)
                return NULL;
-        hdr = (struct hci_command_hdr *) skb_put(skb, HCI_COMMAND_HDR_SIZE);
+        hdr = skb_put(skb, HCI_COMMAND_HDR_SIZE);
        hdr->opcode = cpu_to_le16(opcode);
        hdr->plen   = plen;
diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 083e87f26a0f..1301a8786d8d 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -410,7 +410,7 @@ static struct sk_buff *create_monitor_event(struct hci_dev *hdev, int event)
                if (!skb)
                        return NULL;
-                ni = (void *)skb_put(skb, HCI_MON_NEW_INDEX_SIZE);
+                ni = skb_put(skb, HCI_MON_NEW_INDEX_SIZE);
                ni->type = hdev->dev_type;
                ni->bus = hdev->bus;
                bacpy(&ni->bdaddr, &hdev->bdaddr);
@@ -438,7 +438,7 @@ static struct sk_buff *create_monitor_event(struct hci_dev *hdev, int event)
                if (!skb)
                        return NULL;
-                ii = (void *)skb_put(skb, HCI_MON_INDEX_INFO_SIZE);
+                ii = skb_put(skb, HCI_MON_INDEX_INFO_SIZE);
                bacpy(&ii->bdaddr, &hdev->bdaddr);
                ii->manufacturer = cpu_to_le16(hdev->manufacturer);
@@ -517,7 +517,7 @@ static struct sk_buff *create_monitor_ctrl_open(struct sock *sk)
        put_unaligned_le16(format, skb_put(skb, 2));
        skb_put_data(skb, ver, sizeof(ver));
        put_unaligned_le32(flags, skb_put(skb, 4));
-        *skb_put(skb, 1) = TASK_COMM_LEN;
+        *(u8 *)skb_put(skb, 1) = TASK_COMM_LEN;
        skb_put_data(skb, hci_pi(sk)->comm, TASK_COMM_LEN);
        __net_timestamp(skb);
@@ -616,7 +616,7 @@ send_monitor_note(struct sock *sk, const char *fmt, ...)
        va_start(args, fmt);
        vsprintf(skb_put(skb, len), fmt, args);
-        *skb_put(skb, 1) = 0;
+        *(u8 *)skb_put(skb, 1) = 0;
        va_end(args);
        __net_timestamp(skb);
@@ -703,11 +703,11 @@ static void hci_si_event(struct hci_dev *hdev, int type, int dlen, void *data)
        if (!skb)
                return;
-        hdr = (void *)skb_put(skb, HCI_EVENT_HDR_SIZE);
+        hdr = skb_put(skb, HCI_EVENT_HDR_SIZE);
        hdr->evt  = HCI_EV_STACK_INTERNAL;
        hdr->plen = sizeof(*ev) + dlen;
-        ev  = (void *)skb_put(skb, sizeof(*ev) + dlen);
+        ev = skb_put(skb, sizeof(*ev) + dlen);
        ev->type = type;
        memcpy(ev->data, data, dlen);
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 9e83713262e8..c0d0832a023d 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -112,7 +112,7 @@ static int hidp_send_message(struct hidp_session *session, struct socket *sock,
                return -ENOMEM;
        }
-        *skb_put(skb, 1) = hdr;
+        *(u8 *)skb_put(skb, 1) = hdr;
        if (data && size > 0)
                skb_put_data(skb, data, size);
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index fe6a5529bdf5..303c779bfe38 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1048,7 +1048,7 @@ static struct sk_buff *l2cap_create_sframe_pdu(struct l2cap_chan *chan,
        if (!skb)
                return ERR_PTR(-ENOMEM);
-        lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
+        lh = skb_put(skb, L2CAP_HDR_SIZE);
        lh->len = cpu_to_le16(hlen - L2CAP_HDR_SIZE);
        lh->cid = cpu_to_le16(chan->dcid);
@@ -2182,7 +2182,7 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan,
                return skb;
        /* Create L2CAP header */
-        lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
+        lh = skb_put(skb, L2CAP_HDR_SIZE);
        lh->cid = cpu_to_le16(chan->dcid);
        lh->len = cpu_to_le16(len + L2CAP_PSMLEN_SIZE);
        put_unaligned(chan->psm, (__le16 *) skb_put(skb, L2CAP_PSMLEN_SIZE));
@@ -2213,7 +2213,7 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan,
                return skb;
        /* Create L2CAP header */
-        lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
+        lh = skb_put(skb, L2CAP_HDR_SIZE);
        lh->cid = cpu_to_le16(chan->dcid);
        lh->len = cpu_to_le16(len);
@@ -2255,7 +2255,7 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan,
                return skb;
        /* Create L2CAP header */
-        lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
+        lh = skb_put(skb, L2CAP_HDR_SIZE);
        lh->cid = cpu_to_le16(chan->dcid);
        lh->len = cpu_to_le16(len + (hlen - L2CAP_HDR_SIZE));
@@ -2373,7 +2373,7 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan,
                return skb;
        /* Create L2CAP header */
-        lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
+        lh = skb_put(skb, L2CAP_HDR_SIZE);
        lh->cid = cpu_to_le16(chan->dcid);
        lh->len = cpu_to_le16(len + (hlen - L2CAP_HDR_SIZE));
@@ -2908,7 +2908,7 @@ static struct sk_buff *l2cap_build_cmd(struct l2cap_conn *conn, u8 code,
        if (!skb)
                return NULL;
-        lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
+        lh = skb_put(skb, L2CAP_HDR_SIZE);
        lh->len = cpu_to_le16(L2CAP_CMD_HDR_SIZE + dlen);
        if (conn->hcon->type == LE_LINK)
@@ -2916,7 +2916,7 @@ static struct sk_buff *l2cap_build_cmd(struct l2cap_conn *conn, u8 code,
        else
                lh->cid = cpu_to_le16(L2CAP_CID_SIGNALING);
-        cmd = (struct l2cap_cmd_hdr *) skb_put(skb, L2CAP_CMD_HDR_SIZE);
+        cmd = skb_put(skb, L2CAP_CMD_HDR_SIZE);
        cmd->code  = code;
        cmd->ident = ident;
        cmd->len   = cpu_to_le16(dlen);
diff --git a/net/bluetooth/mgmt_util.c b/net/bluetooth/mgmt_util.c
index 11d0ca64402b..d057113e0d4b 100644
--- a/net/bluetooth/mgmt_util.c
+++ b/net/bluetooth/mgmt_util.c
@@ -66,7 +66,7 @@ int mgmt_send_event(u16 event, struct hci_dev *hdev, unsigned short channel,
        if (!skb)
                return -ENOMEM;
-        hdr = (void *) skb_put(skb, sizeof(*hdr));
+        hdr = skb_put(skb, sizeof(*hdr));
        hdr->opcode = cpu_to_le16(event);
        if (hdev)
                hdr->index = cpu_to_le16(hdev->id);
@@ -103,13 +103,13 @@ int mgmt_cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status)
        if (!skb)
                return -ENOMEM;
-        hdr = (void *) skb_put(skb, sizeof(*hdr));
+        hdr = skb_put(skb, sizeof(*hdr));
        hdr->opcode = cpu_to_le16(MGMT_EV_CMD_STATUS);
        hdr->index = cpu_to_le16(index);
        hdr->len = cpu_to_le16(sizeof(*ev));
-        ev = (void *) skb_put(skb, sizeof(*ev));
+        ev = skb_put(skb, sizeof(*ev));
        ev->status = status;
        ev->opcode = cpu_to_le16(cmd);
@@ -147,13 +147,13 @@ int mgmt_cmd_complete(struct sock *sk, u16 index, u16 cmd, u8 status,
        if (!skb)
                return -ENOMEM;
-        hdr = (void *) skb_put(skb, sizeof(*hdr));
+        hdr = skb_put(skb, sizeof(*hdr));
        hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);
        hdr->index = cpu_to_le16(index);
        hdr->len = cpu_to_le16(sizeof(*ev) + rp_len);
-        ev = (void *) skb_put(skb, sizeof(*ev) + rp_len);
+        ev = skb_put(skb, sizeof(*ev) + rp_len);
        ev->opcode = cpu_to_le16(cmd);
        ev->status = status;
diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
index 8ebca9033d60..1a9b906c5a35 100644
--- a/net/bluetooth/rfcomm/core.c
+++ b/net/bluetooth/rfcomm/core.c
@@ -863,7 +863,7 @@ static int rfcomm_queue_disc(struct rfcomm_dlc *d)
        if (!skb)
                return -ENOMEM;
-        cmd = (void *) __skb_put(skb, sizeof(*cmd));
+        cmd = __skb_put(skb, sizeof(*cmd));
        cmd->addr = d->addr;
        cmd->ctrl = __ctrl(RFCOMM_DISC, 1);
        cmd->len  = __len8(0);
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 8860ad985d68..b8bcf9021329 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2714,7 +2714,7 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb,
        struct timeval timestamp;
        struct pktgen_hdr *pgh;
-        pgh = (struct pktgen_hdr *)skb_put(skb, sizeof(*pgh));
+        pgh = skb_put(skb, sizeof(*pgh));
        datalen -= sizeof(*pgh);
        if (pkt_dev->nfrags <= 0) {
@@ -2845,33 +2845,34 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
        /*  Reserve for ethernet and IP header  */
        eth = (__u8 *) skb_push(skb, 14);
-        mpls = (__be32 *)skb_put(skb, pkt_dev->nr_labels*sizeof(__u32));
+        mpls = skb_put(skb, pkt_dev->nr_labels * sizeof(__u32));
        if (pkt_dev->nr_labels)
                mpls_push(mpls, pkt_dev);
        if (pkt_dev->vlan_id != 0xffff) {
                if (pkt_dev->svlan_id != 0xffff) {
-                        svlan_tci = (__be16 *)skb_put(skb, sizeof(__be16));
+                        svlan_tci = skb_put(skb, sizeof(__be16));
                        *svlan_tci = build_tci(pkt_dev->svlan_id,
                                               pkt_dev->svlan_cfi,
                                               pkt_dev->svlan_p);
-                        svlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16));
+                        svlan_encapsulated_proto = skb_put(skb,
+                                                           sizeof(__be16));
                        *svlan_encapsulated_proto = htons(ETH_P_8021Q);
                }
-                vlan_tci = (__be16 *)skb_put(skb, sizeof(__be16));
+                vlan_tci = skb_put(skb, sizeof(__be16));
                *vlan_tci = build_tci(pkt_dev->vlan_id,
                                      pkt_dev->vlan_cfi,
                                      pkt_dev->vlan_p);
-                vlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16));
+                vlan_encapsulated_proto = skb_put(skb, sizeof(__be16));
                *vlan_encapsulated_proto = htons(ETH_P_IP);
        }
        skb_reset_mac_header(skb);
        skb_set_network_header(skb, skb->len);
-        iph = (struct iphdr *) skb_put(skb, sizeof(struct iphdr));
+        iph = skb_put(skb, sizeof(struct iphdr));
        skb_set_transport_header(skb, skb->len);
-        udph = (struct udphdr *) skb_put(skb, sizeof(struct udphdr));
+        udph = skb_put(skb, sizeof(struct udphdr));
        skb_set_queue_mapping(skb, queue_map);
        skb->priority = pkt_dev->skb_priority;
@@ -2972,33 +2973,34 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
        /*  Reserve for ethernet and IP header  */
        eth = (__u8 *) skb_push(skb, 14);
-        mpls = (__be32 *)skb_put(skb, pkt_dev->nr_labels*sizeof(__u32));
+        mpls = skb_put(skb, pkt_dev->nr_labels * sizeof(__u32));
        if (pkt_dev->nr_labels)
                mpls_push(mpls, pkt_dev);
        if (pkt_dev->vlan_id != 0xffff) {
                if (pkt_dev->svlan_id != 0xffff) {
-                        svlan_tci = (__be16 *)skb_put(skb, sizeof(__be16));
+                        svlan_tci = skb_put(skb, sizeof(__be16));
                        *svlan_tci = build_tci(pkt_dev->svlan_id,
                                               pkt_dev->svlan_cfi,
                                               pkt_dev->svlan_p);
-                        svlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16));
+                        svlan_encapsulated_proto = skb_put(skb,
+                                                           sizeof(__be16));
                        *svlan_encapsulated_proto = htons(ETH_P_8021Q);
                }
-                vlan_tci = (__be16 *)skb_put(skb, sizeof(__be16));
+                vlan_tci = skb_put(skb, sizeof(__be16));
                *vlan_tci = build_tci(pkt_dev->vlan_id,
                                      pkt_dev->vlan_cfi,
                                      pkt_dev->vlan_p);
-                vlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16));
+                vlan_encapsulated_proto = skb_put(skb, sizeof(__be16));
                *vlan_encapsulated_proto = htons(ETH_P_IPV6);
        }
        skb_reset_mac_header(skb);
        skb_set_network_header(skb, skb->len);
-        iph = (struct ipv6hdr *) skb_put(skb, sizeof(struct ipv6hdr));
+        iph = skb_put(skb, sizeof(struct ipv6hdr));
        skb_set_transport_header(skb, skb->len);
-        udph = (struct udphdr *) skb_put(skb, sizeof(struct udphdr));
+        udph = skb_put(skb, sizeof(struct udphdr));
        skb_set_queue_mapping(skb, queue_map);
        skb->priority = pkt_dev->skb_priority;
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index c4d2c1f824bb..0baa7f2dd8ef 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1421,7 +1421,7 @@ EXPORT_SYMBOL(skb_pad);
 *      returned.
 */
-unsigned char *pskb_put(struct sk_buff *skb, struct sk_buff *tail, int len)
+void *pskb_put(struct sk_buff *skb, struct sk_buff *tail, int len)
 {
        if (tail != skb) {
                skb->data_len += len;
@@ -1440,9 +1440,9 @@ EXPORT_SYMBOL_GPL(pskb_put);
 *      exceed the total buffer size the kernel will panic. A pointer to the
 *      first byte of the extra data is returned.
 */
-unsigned char *skb_put(struct sk_buff *skb, unsigned int len)
+void *skb_put(struct sk_buff *skb, unsigned int len)
 {
-        unsigned char *tmp = skb_tail_pointer(skb);
+        void *tmp = skb_tail_pointer(skb);
        SKB_LINEAR_ASSERT(skb);
        skb->tail += len;
        skb->len  += len;
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index 9017a9a73ab5..1d84f6dae315 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -846,7 +846,7 @@ static void dn_send_endnode_hello(struct net_device *dev, struct dn_ifaddr *ifa)
        skb->dev = dev;
-        msg = (struct endnode_hello_message *)skb_put(skb,sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        msg->msgflg  = 0x0D;
        memcpy(msg->tiver, dn_eco_version, 3);
diff --git a/net/decnet/dn_nsp_out.c b/net/decnet/dn_nsp_out.c
index b8a558715395..7e054b2f270a 100644
--- a/net/decnet/dn_nsp_out.c
+++ b/net/decnet/dn_nsp_out.c
@@ -484,7 +484,7 @@ void dn_send_conn_ack (struct sock *sk)
        if ((skb = dn_alloc_skb(sk, 3, sk->sk_allocation)) == NULL)
                return;
-        msg = (struct nsp_conn_ack_msg *)skb_put(skb, 3);
+        msg = skb_put(skb, 3);
        msg->msgflg = 0x24;
        msg->dstaddr = scp->addrrem;
@@ -522,7 +522,7 @@ void dn_send_conn_conf(struct sock *sk, gfp_t gfp)
        if ((skb = dn_alloc_skb(sk, 50 + len, gfp)) == NULL)
                return;
-        msg = (struct nsp_conn_init_msg *)skb_put(skb, sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        msg->msgflg = 0x28;
        msg->dstaddr = scp->addrrem;
        msg->srcaddr = scp->addrloc;
@@ -530,7 +530,7 @@ void dn_send_conn_conf(struct sock *sk, gfp_t gfp)
        msg->info = scp->info_loc;
        msg->segsize = cpu_to_le16(scp->segsize_loc);
-        *skb_put(skb,1) = len;
+        *(u8 *)skb_put(skb, 1) = len;
        if (len > 0)
                skb_put_data(skb, scp->conndata_out.opt_data, len);
@@ -662,7 +662,7 @@ void dn_nsp_send_conninit(struct sock *sk, unsigned char msgflg)
                return;
        cb  = DN_SKB_CB(skb);
-        msg = (struct nsp_conn_init_msg *)skb_put(skb,sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        msg->msgflg     = msgflg;
        msg->dstaddr    = 0x0000;               /* Remote Node will assign it*/
@@ -686,25 +686,25 @@ void dn_nsp_send_conninit(struct sock *sk, unsigned char msgflg)
        if (scp->peer.sdn_flags & SDF_UICPROXY)
                menuver |= DN_MENUVER_UIC;
-        *skb_put(skb, 1) = menuver;     /* Menu Version         */
+        *(u8 *)skb_put(skb, 1) = menuver;       /* Menu Version         */
        aux = scp->accessdata.acc_userl;
-        *skb_put(skb, 1) = aux;
+        *(u8 *)skb_put(skb, 1) = aux;
        if (aux > 0)
                skb_put_data(skb, scp->accessdata.acc_user, aux);
        aux = scp->accessdata.acc_passl;
-        *skb_put(skb, 1) = aux;
+        *(u8 *)skb_put(skb, 1) = aux;
        if (aux > 0)
                skb_put_data(skb, scp->accessdata.acc_pass, aux);
        aux = scp->accessdata.acc_accl;
-        *skb_put(skb, 1) = aux;
+        *(u8 *)skb_put(skb, 1) = aux;
        if (aux > 0)
                skb_put_data(skb, scp->accessdata.acc_acc, aux);
        aux = (__u8)le16_to_cpu(scp->conndata_out.opt_optl);
-        *skb_put(skb, 1) = aux;
+        *(u8 *)skb_put(skb, 1) = aux;
        if (aux > 0)
                skb_put_data(skb, scp->conndata_out.opt_data, aux);
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index a651c53260ec..8b52179ddc6e 100644
--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c
@@ -539,7 +539,7 @@ struct sk_buff *arp_create(int type, int ptype, __be32 dest_ip,
        skb_reserve(skb, hlen);
        skb_reset_network_header(skb);
-        arp = (struct arphdr *) skb_put(skb, arp_hdr_len(dev));
+        arp = skb_put(skb, arp_hdr_len(dev));
        skb->dev = dev;
        skb->protocol = htons(ETH_P_ARP);
        if (!src_hw)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 8f6b5bbcbf69..2202edf31884 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -414,7 +414,7 @@ static struct sk_buff *add_grhead(struct sk_buff *skb, struct ip_mc_list *pmc,
                skb = igmpv3_newpack(dev, dev->mtu);
        if (!skb)
                return NULL;
-        pgr = (struct igmpv3_grec *)skb_put(skb, sizeof(struct igmpv3_grec));
+        pgr = skb_put(skb, sizeof(struct igmpv3_grec));
        pgr->grec_type = type;
        pgr->grec_auxwords = 0;
        pgr->grec_nsrcs = 0;
@@ -508,7 +508,7 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ip_mc_list *pmc,
                }
                if (!skb)
                        return NULL;
-                psrc = (__be32 *)skb_put(skb, sizeof(__be32));
+                psrc = skb_put(skb, sizeof(__be32));
                *psrc = psf->sf_inaddr;
                scount++; stotal++;
                if ((type == IGMPV3_ALLOW_NEW_SOURCES ||
@@ -742,7 +742,7 @@ static int igmp_send_report(struct in_device *in_dev, struct ip_mc_list *pmc,
        ((u8 *)&iph[1])[2] = 0;
        ((u8 *)&iph[1])[3] = 0;
-        ih = (struct igmphdr *)skb_put(skb, sizeof(struct igmphdr));
+        ih = skb_put(skb, sizeof(struct igmphdr));
        ih->type = type;
        ih->code = 0;
        ih->csum = 0;
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index a1199895b8a6..abbd7c992960 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -1044,7 +1044,7 @@ static int ipmr_cache_report(struct mr_table *mrt,
                msg->im_vif = vifi;
                skb_dst_set(skb, dst_clone(skb_dst(pkt)));
                /* Add our header */
-                igmp = (struct igmphdr *)skb_put(skb, sizeof(struct igmphdr));
+                igmp = skb_put(skb, sizeof(struct igmphdr));
                igmp->type = assert;
                msg->im_msgtype = assert;
                igmp->code = 0;
diff --git a/net/ipv4/netfilter/ipt_SYNPROXY.c b/net/ipv4/netfilter/ipt_SYNPROXY.c
index af2b69b6895f..f1528f7175a8 100644
--- a/net/ipv4/netfilter/ipt_SYNPROXY.c
+++ b/net/ipv4/netfilter/ipt_SYNPROXY.c
@@ -24,7 +24,7 @@ synproxy_build_ip(struct net *net, struct sk_buff *skb, __be32 saddr,
        struct iphdr *iph;
        skb_reset_network_header(skb);
-        iph = (struct iphdr *)skb_put(skb, sizeof(*iph));
+        iph = skb_put(skb, sizeof(*iph));
        iph->version    = 4;
        iph->ihl        = sizeof(*iph) / 4;
        iph->tos        = 0;
@@ -91,7 +91,7 @@ synproxy_send_client_synack(struct net *net,
        niph = synproxy_build_ip(net, nskb, iph->daddr, iph->saddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->dest;
        nth->dest       = th->source;
        nth->seq        = htonl(__cookie_v4_init_sequence(iph, th, &mss));
@@ -133,7 +133,7 @@ synproxy_send_server_syn(struct net *net,
        niph = synproxy_build_ip(net, nskb, iph->saddr, iph->daddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->source;
        nth->dest       = th->dest;
        nth->seq        = htonl(recv_seq - 1);
@@ -178,7 +178,7 @@ synproxy_send_server_ack(struct net *net,
        niph = synproxy_build_ip(net, nskb, iph->daddr, iph->saddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->dest;
        nth->dest       = th->source;
        nth->seq        = htonl(ntohl(th->ack_seq));
@@ -216,7 +216,7 @@ synproxy_send_client_ack(struct net *net,
        niph = synproxy_build_ip(net, nskb, iph->saddr, iph->daddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->source;
        nth->dest       = th->dest;
        nth->seq        = htonl(ntohl(th->seq) + 1);
diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c
index 52b7dcc5aaf3..eeacbdaf7cdf 100644
--- a/net/ipv4/netfilter/nf_reject_ipv4.c
+++ b/net/ipv4/netfilter/nf_reject_ipv4.c
@@ -51,7 +51,7 @@ struct iphdr *nf_reject_iphdr_put(struct sk_buff *nskb,
        struct iphdr *niph, *oiph = ip_hdr(oldskb);
        skb_reset_network_header(nskb);
-        niph = (struct iphdr *)skb_put(nskb, sizeof(struct iphdr));
+        niph = skb_put(nskb, sizeof(struct iphdr));
        niph->version   = 4;
        niph->ihl       = sizeof(struct iphdr) / 4;
        niph->tos       = 0;
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index b64046ccae69..e2221135858b 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -1692,7 +1692,7 @@ static struct sk_buff *add_grhead(struct sk_buff *skb, struct ifmcaddr6 *pmc,
                skb = mld_newpack(pmc->idev, dev->mtu);
        if (!skb)
                return NULL;
-        pgr = (struct mld2_grec *)skb_put(skb, sizeof(struct mld2_grec));
+        pgr = skb_put(skb, sizeof(struct mld2_grec));
        pgr->grec_type = type;
        pgr->grec_auxwords = 0;
        pgr->grec_nsrcs = 0;
@@ -1784,7 +1784,7 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ifmcaddr6 *pmc,
                }
                if (!skb)
                        return NULL;
-                psrc = (struct in6_addr *)skb_put(skb, sizeof(*psrc));
+                psrc = skb_put(skb, sizeof(*psrc));
                *psrc = psf->sf_addr;
                scount++; stotal++;
                if ((type == MLD2_ALLOW_NEW_SOURCES ||
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index d310dc41209a..0327c1f2e6fc 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -528,7 +528,7 @@ void ndisc_send_na(struct net_device *dev, const struct in6_addr *daddr,
        if (!skb)
                return;
-        msg = (struct nd_msg *)skb_put(skb, sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        *msg = (struct nd_msg) {
                .icmph = {
                        .icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT,
@@ -597,7 +597,7 @@ void ndisc_send_ns(struct net_device *dev, const struct in6_addr *solicit,
        if (!skb)
                return;
-        msg = (struct nd_msg *)skb_put(skb, sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        *msg = (struct nd_msg) {
                .icmph = {
                        .icmp6_type = NDISC_NEIGHBOUR_SOLICITATION,
@@ -657,7 +657,7 @@ void ndisc_send_rs(struct net_device *dev, const struct in6_addr *saddr,
        if (!skb)
                return;
-        msg = (struct rs_msg *)skb_put(skb, sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        *msg = (struct rs_msg) {
                .icmph = {
                        .icmp6_type = NDISC_ROUTER_SOLICITATION,
@@ -1633,7 +1633,7 @@ void ndisc_send_redirect(struct sk_buff *skb, const struct in6_addr *target)
        if (!buff)
                goto release;
-        msg = (struct rd_msg *)skb_put(buff, sizeof(*msg));
+        msg = skb_put(buff, sizeof(*msg));
        *msg = (struct rd_msg) {
                .icmph = {
                        .icmp6_type = NDISC_REDIRECT,
diff --git a/net/ipv6/netfilter/ip6t_SYNPROXY.c b/net/ipv6/netfilter/ip6t_SYNPROXY.c
index d3c4daa708b9..ce203dd729e0 100644
--- a/net/ipv6/netfilter/ip6t_SYNPROXY.c
+++ b/net/ipv6/netfilter/ip6t_SYNPROXY.c
@@ -27,7 +27,7 @@ synproxy_build_ip(struct net *net, struct sk_buff *skb,
        struct ipv6hdr *iph;
        skb_reset_network_header(skb);
-        iph = (struct ipv6hdr *)skb_put(skb, sizeof(*iph));
+        iph = skb_put(skb, sizeof(*iph));
        ip6_flow_hdr(iph, 0, 0);
        iph->hop_limit  = net->ipv6.devconf_all->hop_limit;
        iph->nexthdr    = IPPROTO_TCP;
@@ -105,7 +105,7 @@ synproxy_send_client_synack(struct net *net,
        niph = synproxy_build_ip(net, nskb, &iph->daddr, &iph->saddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->dest;
        nth->dest       = th->source;
        nth->seq        = htonl(__cookie_v6_init_sequence(iph, th, &mss));
@@ -147,7 +147,7 @@ synproxy_send_server_syn(struct net *net,
        niph = synproxy_build_ip(net, nskb, &iph->saddr, &iph->daddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->source;
        nth->dest       = th->dest;
        nth->seq        = htonl(recv_seq - 1);
@@ -192,7 +192,7 @@ synproxy_send_server_ack(struct net *net,
        niph = synproxy_build_ip(net, nskb, &iph->daddr, &iph->saddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->dest;
        nth->dest       = th->source;
        nth->seq        = htonl(ntohl(th->ack_seq));
@@ -230,7 +230,7 @@ synproxy_send_client_ack(struct net *net,
        niph = synproxy_build_ip(net, nskb, &iph->saddr, &iph->daddr);
        skb_reset_transport_header(nskb);
-        nth = (struct tcphdr *)skb_put(nskb, tcp_hdr_size);
+        nth = skb_put(nskb, tcp_hdr_size);
        nth->source     = th->source;
        nth->dest       = th->dest;
        nth->seq        = htonl(ntohl(th->seq) + 1);
diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c
index f63b18e05c69..24858402e374 100644
--- a/net/ipv6/netfilter/nf_reject_ipv6.c
+++ b/net/ipv6/netfilter/nf_reject_ipv6.c
@@ -95,7 +95,7 @@ void nf_reject_ip6_tcphdr_put(struct sk_buff *nskb,
        int needs_ack;
        skb_reset_transport_header(nskb);
-        tcph = (struct tcphdr *)skb_put(nskb, sizeof(struct tcphdr));
+        tcph = skb_put(nskb, sizeof(struct tcphdr));
        /* Truncate to length (no data) */
        tcph->doff = sizeof(struct tcphdr)/4;
        tcph->source = oth->dest;
diff --git a/net/irda/irlap_frame.c b/net/irda/irlap_frame.c
index bf56ac7dba96..82e71e5622c2 100644
--- a/net/irda/irlap_frame.c
+++ b/net/irda/irlap_frame.c
@@ -133,7 +133,7 @@ void irlap_send_snrm_frame(struct irlap_cb *self, struct qos_info *qos)
        if (!tx_skb)
                return;
-        frame = (struct snrm_frame *) skb_put(tx_skb, 2);
+        frame = skb_put(tx_skb, 2);
        /* Insert connection address field */
        if (qos)
@@ -228,7 +228,7 @@ void irlap_send_ua_response_frame(struct irlap_cb *self, struct qos_info *qos)
        if (!tx_skb)
                return;
-        frame = (struct ua_frame *) skb_put(tx_skb, 10);
+        frame = skb_put(tx_skb, 10);
        /* Build UA response */
        frame->caddr = self->caddr;
@@ -268,7 +268,7 @@ void irlap_send_dm_frame( struct irlap_cb *self)
        if (!tx_skb)
                return;
-        frame = (struct dm_frame *)skb_put(tx_skb, 2);
+        frame = skb_put(tx_skb, 2);
        if (self->state == LAP_NDM)
                frame->caddr = CBROADCAST;
@@ -298,7 +298,7 @@ void irlap_send_disc_frame(struct irlap_cb *self)
        if (!tx_skb)
                return;
-        frame = (struct disc_frame *)skb_put(tx_skb, 2);
+        frame = skb_put(tx_skb, 2);
        frame->caddr = self->caddr | CMD_FRAME;
        frame->control = DISC_CMD | PF_BIT;
@@ -587,7 +587,7 @@ void irlap_send_rr_frame(struct irlap_cb *self, int command)
        if (!tx_skb)
                return;
-        frame = (struct rr_frame *)skb_put(tx_skb, 2);
+        frame = skb_put(tx_skb, 2);
        frame->caddr = self->caddr;
        frame->caddr |= (command) ? CMD_FRAME : 0;
@@ -612,7 +612,7 @@ void irlap_send_rd_frame(struct irlap_cb *self)
        if (!tx_skb)
                return;
-        frame = (struct rd_frame *)skb_put(tx_skb, 2);
+        frame = skb_put(tx_skb, 2);
        frame->caddr = self->caddr;
        frame->control = RD_RSP | PF_BIT;
@@ -1202,14 +1202,13 @@ void irlap_send_test_frame(struct irlap_cb *self, __u8 caddr, __u32 daddr,
        /* Broadcast frames must include saddr and daddr fields */
        if (caddr == CBROADCAST) {
-                frame = (struct test_frame *)
+                frame = skb_put(tx_skb, sizeof(struct test_frame));
-                        skb_put(tx_skb, sizeof(struct test_frame));
                /* Insert the swapped addresses */
                frame->saddr = cpu_to_le32(self->saddr);
                frame->daddr = cpu_to_le32(daddr);
        } else
-                frame = (struct test_frame *) skb_put(tx_skb, LAP_ADDR_HEADER + LAP_CTRL_HEADER);
+                frame = skb_put(tx_skb, LAP_ADDR_HEADER + LAP_CTRL_HEADER);
        frame->caddr = caddr;
        frame->control = TEST_RSP | PF_BIT;
diff --git a/net/key/af_key.c b/net/key/af_key.c
index 3ebb4268973b..daa4e90dc4db 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -349,7 +349,7 @@ static int pfkey_error(const struct sadb_msg *orig, int err, struct sock *sk)
                err = EINVAL;
        BUG_ON(err <= 0 || err >= 256);
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        pfkey_hdr_dup(hdr, orig);
        hdr->sadb_msg_errno = (uint8_t) err;
        hdr->sadb_msg_len = (sizeof(struct sadb_msg) /
@@ -810,12 +810,12 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
                return ERR_PTR(-ENOBUFS);
        /* call should fill header later */
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        memset(hdr, 0, size);   /* XXX do we need this ? */
        hdr->sadb_msg_len = size / sizeof(uint64_t);
        /* sa */
-        sa = (struct sadb_sa *)  skb_put(skb, sizeof(struct sadb_sa));
+        sa = skb_put(skb, sizeof(struct sadb_sa));
        sa->sadb_sa_len = sizeof(struct sadb_sa)/sizeof(uint64_t);
        sa->sadb_sa_exttype = SADB_EXT_SA;
        sa->sadb_sa_spi = x->id.spi;
@@ -862,8 +862,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        /* hard time */
        if (hsc & 2) {
-                lifetime = (struct sadb_lifetime *)  skb_put(skb,
+                lifetime = skb_put(skb, sizeof(struct sadb_lifetime));
-                                                             sizeof(struct sadb_lifetime));
                lifetime->sadb_lifetime_len =
                        sizeof(struct sadb_lifetime)/sizeof(uint64_t);
                lifetime->sadb_lifetime_exttype = SADB_EXT_LIFETIME_HARD;
@@ -874,8 +873,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        }
        /* soft time */
        if (hsc & 1) {
-                lifetime = (struct sadb_lifetime *)  skb_put(skb,
+                lifetime = skb_put(skb, sizeof(struct sadb_lifetime));
-                                                             sizeof(struct sadb_lifetime));
                lifetime->sadb_lifetime_len =
                        sizeof(struct sadb_lifetime)/sizeof(uint64_t);
                lifetime->sadb_lifetime_exttype = SADB_EXT_LIFETIME_SOFT;
@@ -885,8 +883,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
                lifetime->sadb_lifetime_usetime = x->lft.soft_use_expires_seconds;
        }
        /* current time */
-        lifetime = (struct sadb_lifetime *)  skb_put(skb,
+        lifetime = skb_put(skb, sizeof(struct sadb_lifetime));
-                                                     sizeof(struct sadb_lifetime));
        lifetime->sadb_lifetime_len =
                sizeof(struct sadb_lifetime)/sizeof(uint64_t);
        lifetime->sadb_lifetime_exttype = SADB_EXT_LIFETIME_CURRENT;
@@ -895,8 +892,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        lifetime->sadb_lifetime_addtime = x->curlft.add_time;
        lifetime->sadb_lifetime_usetime = x->curlft.use_time;
        /* src address */
-        addr = (struct sadb_address*) skb_put(skb,
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                                              sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -915,8 +911,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
                BUG();
        /* dst address */
-        addr = (struct sadb_address*) skb_put(skb,
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                                              sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -933,8 +928,8 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        if (!xfrm_addr_equal(&x->sel.saddr, &x->props.saddr,
                             x->props.family)) {
-                addr = (struct sadb_address*) skb_put(skb,
+                addr = skb_put(skb,
-                        sizeof(struct sadb_address)+sockaddr_size);
+                               sizeof(struct sadb_address) + sockaddr_size);
                addr->sadb_address_len =
                        (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -951,8 +946,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        /* auth key */
        if (add_keys && auth_key_size) {
-                key = (struct sadb_key *) skb_put(skb,
+                key = skb_put(skb, sizeof(struct sadb_key) + auth_key_size);
-                                                  sizeof(struct sadb_key)+auth_key_size);
                key->sadb_key_len = (sizeof(struct sadb_key) + auth_key_size) /
                        sizeof(uint64_t);
                key->sadb_key_exttype = SADB_EXT_KEY_AUTH;
@@ -962,8 +956,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        }
        /* encrypt key */
        if (add_keys && encrypt_key_size) {
-                key = (struct sadb_key *) skb_put(skb,
+                key = skb_put(skb, sizeof(struct sadb_key) + encrypt_key_size);
-                                                  sizeof(struct sadb_key)+encrypt_key_size);
                key->sadb_key_len = (sizeof(struct sadb_key) +
                                     encrypt_key_size) / sizeof(uint64_t);
                key->sadb_key_exttype = SADB_EXT_KEY_ENCRYPT;
@@ -974,7 +967,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        }
        /* sa */
-        sa2 = (struct sadb_x_sa2 *)  skb_put(skb, sizeof(struct sadb_x_sa2));
+        sa2 = skb_put(skb, sizeof(struct sadb_x_sa2));
        sa2->sadb_x_sa2_len = sizeof(struct sadb_x_sa2)/sizeof(uint64_t);
        sa2->sadb_x_sa2_exttype = SADB_X_EXT_SA2;
        if ((mode = pfkey_mode_from_xfrm(x->props.mode)) < 0) {
@@ -992,7 +985,7 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
                struct sadb_x_nat_t_port *n_port;
                /* type */
-                n_type = (struct sadb_x_nat_t_type*) skb_put(skb, sizeof(*n_type));
+                n_type = skb_put(skb, sizeof(*n_type));
                n_type->sadb_x_nat_t_type_len = sizeof(*n_type)/sizeof(uint64_t);
                n_type->sadb_x_nat_t_type_exttype = SADB_X_EXT_NAT_T_TYPE;
                n_type->sadb_x_nat_t_type_type = natt->encap_type;
@@ -1001,14 +994,14 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
                n_type->sadb_x_nat_t_type_reserved[2] = 0;
                /* source port */
-                n_port = (struct sadb_x_nat_t_port*) skb_put(skb, sizeof (*n_port));
+                n_port = skb_put(skb, sizeof(*n_port));
                n_port->sadb_x_nat_t_port_len = sizeof(*n_port)/sizeof(uint64_t);
                n_port->sadb_x_nat_t_port_exttype = SADB_X_EXT_NAT_T_SPORT;
                n_port->sadb_x_nat_t_port_port = natt->encap_sport;
                n_port->sadb_x_nat_t_port_reserved = 0;
                /* dest port */
-                n_port = (struct sadb_x_nat_t_port*) skb_put(skb, sizeof (*n_port));
+                n_port = skb_put(skb, sizeof(*n_port));
                n_port->sadb_x_nat_t_port_len = sizeof(*n_port)/sizeof(uint64_t);
                n_port->sadb_x_nat_t_port_exttype = SADB_X_EXT_NAT_T_DPORT;
                n_port->sadb_x_nat_t_port_port = natt->encap_dport;
@@ -1017,8 +1010,8 @@ static struct sk_buff *__pfkey_xfrm_state2msg(const struct xfrm_state *x,
        /* security context */
        if (xfrm_ctx) {
-                sec_ctx = (struct sadb_x_sec_ctx *) skb_put(skb,
+                sec_ctx = skb_put(skb,
-                                sizeof(struct sadb_x_sec_ctx) + ctx_size);
+                                  sizeof(struct sadb_x_sec_ctx) + ctx_size);
                sec_ctx->sadb_x_sec_len =
                  (sizeof(struct sadb_x_sec_ctx) + ctx_size) / sizeof(uint64_t);
                sec_ctx->sadb_x_sec_exttype = SADB_X_EXT_SEC_CTX;
@@ -1617,7 +1610,7 @@ static struct sk_buff *compose_sadb_supported(const struct sadb_msg *orig,
        if (!skb)
                goto out_put_algs;
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(*hdr));
+        hdr = skb_put(skb, sizeof(*hdr));
        pfkey_hdr_dup(hdr, orig);
        hdr->sadb_msg_errno = 0;
        hdr->sadb_msg_len = len / sizeof(uint64_t);
@@ -1626,7 +1619,7 @@ static struct sk_buff *compose_sadb_supported(const struct sadb_msg *orig,
                struct sadb_supported *sp;
                struct sadb_alg *ap;
-                sp = (struct sadb_supported *) skb_put(skb, auth_len);
+                sp = skb_put(skb, auth_len);
                ap = (struct sadb_alg *) (sp + 1);
                sp->sadb_supported_len = auth_len / sizeof(uint64_t);
@@ -1647,7 +1640,7 @@ static struct sk_buff *compose_sadb_supported(const struct sadb_msg *orig,
                struct sadb_supported *sp;
                struct sadb_alg *ap;
-                sp = (struct sadb_supported *) skb_put(skb, enc_len);
+                sp = skb_put(skb, enc_len);
                ap = (struct sadb_alg *) (sp + 1);
                sp->sadb_supported_len = enc_len / sizeof(uint64_t);
@@ -1721,7 +1714,7 @@ static int key_notify_sa_flush(const struct km_event *c)
        skb = alloc_skb(sizeof(struct sadb_msg) + 16, GFP_ATOMIC);
        if (!skb)
                return -ENOBUFS;
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        hdr->sadb_msg_satype = pfkey_proto2satype(c->data.proto);
        hdr->sadb_msg_type = SADB_FLUSH;
        hdr->sadb_msg_seq = c->seq;
@@ -2046,12 +2039,11 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
        size = pfkey_xfrm_policy2msg_size(xp);
        /* call should fill header later */
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        memset(hdr, 0, size);   /* XXX do we need this ? */
        /* src address */
-        addr = (struct sadb_address*) skb_put(skb,
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                                              sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -2066,8 +2058,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
                BUG();
        /* dst address */
-        addr = (struct sadb_address*) skb_put(skb,
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                                              sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -2081,8 +2072,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
                            xp->family);
        /* hard time */
-        lifetime = (struct sadb_lifetime *)  skb_put(skb,
+        lifetime = skb_put(skb, sizeof(struct sadb_lifetime));
-                                                     sizeof(struct sadb_lifetime));
        lifetime->sadb_lifetime_len =
                sizeof(struct sadb_lifetime)/sizeof(uint64_t);
        lifetime->sadb_lifetime_exttype = SADB_EXT_LIFETIME_HARD;
@@ -2091,8 +2081,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
        lifetime->sadb_lifetime_addtime = xp->lft.hard_add_expires_seconds;
        lifetime->sadb_lifetime_usetime = xp->lft.hard_use_expires_seconds;
        /* soft time */
-        lifetime = (struct sadb_lifetime *)  skb_put(skb,
+        lifetime = skb_put(skb, sizeof(struct sadb_lifetime));
-                                                     sizeof(struct sadb_lifetime));
        lifetime->sadb_lifetime_len =
                sizeof(struct sadb_lifetime)/sizeof(uint64_t);
        lifetime->sadb_lifetime_exttype = SADB_EXT_LIFETIME_SOFT;
@@ -2101,8 +2090,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
        lifetime->sadb_lifetime_addtime = xp->lft.soft_add_expires_seconds;
        lifetime->sadb_lifetime_usetime = xp->lft.soft_use_expires_seconds;
        /* current time */
-        lifetime = (struct sadb_lifetime *)  skb_put(skb,
+        lifetime = skb_put(skb, sizeof(struct sadb_lifetime));
-                                                     sizeof(struct sadb_lifetime));
        lifetime->sadb_lifetime_len =
                sizeof(struct sadb_lifetime)/sizeof(uint64_t);
        lifetime->sadb_lifetime_exttype = SADB_EXT_LIFETIME_CURRENT;
@@ -2111,7 +2099,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
        lifetime->sadb_lifetime_addtime = xp->curlft.add_time;
        lifetime->sadb_lifetime_usetime = xp->curlft.use_time;
-        pol = (struct sadb_x_policy *)  skb_put(skb, sizeof(struct sadb_x_policy));
+        pol = skb_put(skb, sizeof(struct sadb_x_policy));
        pol->sadb_x_policy_len = sizeof(struct sadb_x_policy)/sizeof(uint64_t);
        pol->sadb_x_policy_exttype = SADB_X_EXT_POLICY;
        pol->sadb_x_policy_type = IPSEC_POLICY_DISCARD;
@@ -2139,7 +2127,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
                } else {
                        size -= 2*socklen;
                }
-                rq = (void*)skb_put(skb, req_size);
+                rq = skb_put(skb, req_size);
                pol->sadb_x_policy_len += req_size/8;
                memset(rq, 0, sizeof(*rq));
                rq->sadb_x_ipsecrequest_len = req_size;
@@ -2169,7 +2157,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy *
        if ((xfrm_ctx = xp->security)) {
                int ctx_size = pfkey_xfrm_policy2sec_ctx_size(xp);
-                sec_ctx = (struct sadb_x_sec_ctx *) skb_put(skb, ctx_size);
+                sec_ctx = skb_put(skb, ctx_size);
                sec_ctx->sadb_x_sec_len = ctx_size / sizeof(uint64_t);
                sec_ctx->sadb_x_sec_exttype = SADB_X_EXT_SEC_CTX;
                sec_ctx->sadb_x_ctx_doi = xfrm_ctx->ctx_doi;
@@ -2733,7 +2721,7 @@ static int key_notify_policy_flush(const struct km_event *c)
        skb_out = alloc_skb(sizeof(struct sadb_msg) + 16, GFP_ATOMIC);
        if (!skb_out)
                return -ENOBUFS;
-        hdr = (struct sadb_msg *) skb_put(skb_out, sizeof(struct sadb_msg));
+        hdr = skb_put(skb_out, sizeof(struct sadb_msg));
        hdr->sadb_msg_type = SADB_X_SPDFLUSH;
        hdr->sadb_msg_seq = c->seq;
        hdr->sadb_msg_pid = c->portid;
@@ -2917,7 +2905,7 @@ static void dump_ah_combs(struct sk_buff *skb, const struct xfrm_tmpl *t)
        struct sadb_prop *p;
        int i;
-        p = (struct sadb_prop*)skb_put(skb, sizeof(struct sadb_prop));
+        p = skb_put(skb, sizeof(struct sadb_prop));
        p->sadb_prop_len = sizeof(struct sadb_prop)/8;
        p->sadb_prop_exttype = SADB_EXT_PROPOSAL;
        p->sadb_prop_replay = 32;
@@ -2951,7 +2939,7 @@ static void dump_esp_combs(struct sk_buff *skb, const struct xfrm_tmpl *t)
        struct sadb_prop *p;
        int i, k;
-        p = (struct sadb_prop*)skb_put(skb, sizeof(struct sadb_prop));
+        p = skb_put(skb, sizeof(struct sadb_prop));
        p->sadb_prop_len = sizeof(struct sadb_prop)/8;
        p->sadb_prop_exttype = SADB_EXT_PROPOSAL;
        p->sadb_prop_replay = 32;
@@ -2977,7 +2965,7 @@ static void dump_esp_combs(struct sk_buff *skb, const struct xfrm_tmpl *t)
                                continue;
                        if (!(aalg_tmpl_set(t, aalg) && aalg->available))
                                continue;
-                        c = (struct sadb_comb*)skb_put(skb, sizeof(struct sadb_comb));
+                        c = skb_put(skb, sizeof(struct sadb_comb));
                        memset(c, 0, sizeof(*c));
                        p->sadb_prop_len += sizeof(struct sadb_comb)/8;
                        c->sadb_comb_auth = aalg->desc.sadb_alg_id;
@@ -3144,7 +3132,7 @@ static int pfkey_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *t, struct
        if (skb == NULL)
                return -ENOMEM;
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        hdr->sadb_msg_version = PF_KEY_V2;
        hdr->sadb_msg_type = SADB_ACQUIRE;
        hdr->sadb_msg_satype = pfkey_proto2satype(x->id.proto);
@@ -3155,8 +3143,7 @@ static int pfkey_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *t, struct
        hdr->sadb_msg_pid = 0;
        /* src address */
-        addr = (struct sadb_address*) skb_put(skb,
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                                              sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -3171,8 +3158,7 @@ static int pfkey_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *t, struct
                BUG();
        /* dst address */
-        addr = (struct sadb_address*) skb_put(skb,
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                                              sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -3186,7 +3172,7 @@ static int pfkey_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *t, struct
        if (!addr->sadb_address_prefixlen)
                BUG();
-        pol = (struct sadb_x_policy *)  skb_put(skb, sizeof(struct sadb_x_policy));
+        pol = skb_put(skb, sizeof(struct sadb_x_policy));
        pol->sadb_x_policy_len = sizeof(struct sadb_x_policy)/sizeof(uint64_t);
        pol->sadb_x_policy_exttype = SADB_X_EXT_POLICY;
        pol->sadb_x_policy_type = IPSEC_POLICY_IPSEC;
@@ -3203,8 +3189,8 @@ static int pfkey_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *t, struct
        /* security context */
        if (xfrm_ctx) {
-                sec_ctx = (struct sadb_x_sec_ctx *) skb_put(skb,
+                sec_ctx = skb_put(skb,
-                                sizeof(struct sadb_x_sec_ctx) + ctx_size);
+                                  sizeof(struct sadb_x_sec_ctx) + ctx_size);
                sec_ctx->sadb_x_sec_len =
                  (sizeof(struct sadb_x_sec_ctx) + ctx_size) / sizeof(uint64_t);
                sec_ctx->sadb_x_sec_exttype = SADB_X_EXT_SEC_CTX;
@@ -3346,7 +3332,7 @@ static int pfkey_send_new_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr,
        if (skb == NULL)
                return -ENOMEM;
-        hdr = (struct sadb_msg *) skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        hdr->sadb_msg_version = PF_KEY_V2;
        hdr->sadb_msg_type = SADB_X_NAT_T_NEW_MAPPING;
        hdr->sadb_msg_satype = satype;
@@ -3357,7 +3343,7 @@ static int pfkey_send_new_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr,
        hdr->sadb_msg_pid = 0;
        /* SA */
-        sa = (struct sadb_sa *) skb_put(skb, sizeof(struct sadb_sa));
+        sa = skb_put(skb, sizeof(struct sadb_sa));
        sa->sadb_sa_len = sizeof(struct sadb_sa)/sizeof(uint64_t);
        sa->sadb_sa_exttype = SADB_EXT_SA;
        sa->sadb_sa_spi = x->id.spi;
@@ -3368,8 +3354,7 @@ static int pfkey_send_new_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr,
        sa->sadb_sa_flags = 0;
        /* ADDRESS_SRC (old addr) */
-        addr = (struct sadb_address*)
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                skb_put(skb, sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -3384,15 +3369,14 @@ static int pfkey_send_new_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr,
                BUG();
        /* NAT_T_SPORT (old port) */
-        n_port = (struct sadb_x_nat_t_port*) skb_put(skb, sizeof (*n_port));
+        n_port = skb_put(skb, sizeof(*n_port));
        n_port->sadb_x_nat_t_port_len = sizeof(*n_port)/sizeof(uint64_t);
        n_port->sadb_x_nat_t_port_exttype = SADB_X_EXT_NAT_T_SPORT;
        n_port->sadb_x_nat_t_port_port = natt->encap_sport;
        n_port->sadb_x_nat_t_port_reserved = 0;
        /* ADDRESS_DST (new addr) */
-        addr = (struct sadb_address*)
+        addr = skb_put(skb, sizeof(struct sadb_address) + sockaddr_size);
-                skb_put(skb, sizeof(struct sadb_address)+sockaddr_size);
        addr->sadb_address_len =
                (sizeof(struct sadb_address)+sockaddr_size)/
                        sizeof(uint64_t);
@@ -3407,7 +3391,7 @@ static int pfkey_send_new_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr,
                BUG();
        /* NAT_T_DPORT (new port) */
-        n_port = (struct sadb_x_nat_t_port*) skb_put(skb, sizeof (*n_port));
+        n_port = skb_put(skb, sizeof(*n_port));
        n_port->sadb_x_nat_t_port_len = sizeof(*n_port)/sizeof(uint64_t);
        n_port->sadb_x_nat_t_port_exttype = SADB_X_EXT_NAT_T_DPORT;
        n_port->sadb_x_nat_t_port_port = sport;
@@ -3421,7 +3405,7 @@ static int set_sadb_address(struct sk_buff *skb, int sasize, int type,
                            const struct xfrm_selector *sel)
 {
        struct sadb_address *addr;
-        addr = (struct sadb_address *)skb_put(skb, sizeof(struct sadb_address) + sasize);
+        addr = skb_put(skb, sizeof(struct sadb_address) + sasize);
        addr->sadb_address_len = (sizeof(struct sadb_address) + sasize)/8;
        addr->sadb_address_exttype = type;
        addr->sadb_address_proto = sel->proto;
@@ -3553,7 +3537,7 @@ static int pfkey_send_migrate(const struct xfrm_selector *sel, u8 dir, u8 type,
        if (skb == NULL)
                return -ENOMEM;
-        hdr = (struct sadb_msg *)skb_put(skb, sizeof(struct sadb_msg));
+        hdr = skb_put(skb, sizeof(struct sadb_msg));
        hdr->sadb_msg_version = PF_KEY_V2;
        hdr->sadb_msg_type = SADB_X_MIGRATE;
        hdr->sadb_msg_satype = pfkey_proto2satype(m->proto);
@@ -3574,7 +3558,7 @@ static int pfkey_send_migrate(const struct xfrm_selector *sel, u8 dir, u8 type,
        set_sadb_address(skb, sasize_sel, SADB_EXT_ADDRESS_DST, sel);
        /* policy information */
-        pol = (struct sadb_x_policy *)skb_put(skb, sizeof(struct sadb_x_policy));
+        pol = skb_put(skb, sizeof(struct sadb_x_policy));
        pol->sadb_x_policy_len = size_pol / 8;
        pol->sadb_x_policy_exttype = SADB_X_EXT_POLICY;
        pol->sadb_x_policy_type = IPSEC_POLICY_IPSEC;
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index f9eb2486d550..a354f1939e49 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1107,7 +1107,7 @@ static void ieee80211_send_layer2_update(struct sta_info *sta)
        skb = dev_alloc_skb(sizeof(*msg));
        if (!skb)
                return;
-        msg = (struct iapp_layer2_update *)skb_put(skb, sizeof(*msg));
+        msg = skb_put(skb, sizeof(*msg));
        /* 802.2 Type 1 Logical Link Control (LLC) Exchange Identifier (XID)
         * Update response frame; IEEE Std 802.2-1998, 5.4.1.2.1 */
@@ -3414,7 +3414,7 @@ static int ieee80211_probe_client(struct wiphy *wiphy, struct net_device *dev,
        skb_reserve(skb, local->hw.extra_tx_headroom);
-        nullfunc = (void *) skb_put(skb, size);
+        nullfunc = skb_put(skb, size);
        nullfunc->frame_control = fc;
        nullfunc->duration_id = 0;
        memcpy(nullfunc->addr1, sta->sta.addr, ETH_ALEN);
diff --git a/net/mac80211/ht.c b/net/mac80211/ht.c
index 927215d4dd8f..c92df492e898 100644
--- a/net/mac80211/ht.c
+++ b/net/mac80211/ht.c
@@ -459,7 +459,7 @@ int ieee80211_send_smps_action(struct ieee80211_sub_if_data *sdata,
                return -ENOMEM;
        skb_reserve(skb, local->hw.extra_tx_headroom);
-        action_frame = (void *)skb_put(skb, 27);
+        action_frame = skb_put(skb, 27);
        memcpy(action_frame->da, da, ETH_ALEN);
        memcpy(action_frame->sa, sdata->dev->dev_addr, ETH_ALEN);
        memcpy(action_frame->bssid, bssid, ETH_ALEN);
diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
index 861697f2d75b..a550c707cd8a 100644
--- a/net/mac80211/mesh.c
+++ b/net/mac80211/mesh.c
@@ -1265,7 +1265,7 @@ static int mesh_fwd_csa_frame(struct ieee80211_sub_if_data *sdata,
        if (!skb)
                return -ENOMEM;
        skb_reserve(skb, local->tx_headroom);
-        mgmt_fwd = (struct ieee80211_mgmt *) skb_put(skb, len);
+        mgmt_fwd = skb_put(skb, len);
        /* offset_ttl is based on whether the secondary channel
         * offset is available or not. Subtract 1 from the mesh TTL
diff --git a/net/mac80211/mesh_ps.c b/net/mac80211/mesh_ps.c
index 96c987e641b3..d8cd91424175 100644
--- a/net/mac80211/mesh_ps.c
+++ b/net/mac80211/mesh_ps.c
@@ -30,7 +30,7 @@ static struct sk_buff *mps_qos_null_get(struct sta_info *sta)
                return NULL;
        skb_reserve(skb, local->hw.extra_tx_headroom);
-        nullfunc = (struct ieee80211_hdr *) skb_put(skb, size);
+        nullfunc = skb_put(skb, size);
        fc = cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_QOS_NULLFUNC);
        ieee80211_fill_mesh_addresses(nullfunc, &fc, sta->sta.addr,
                                      sdata->vif.addr);
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 46e1809356f6..69615016d5bf 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -1312,7 +1312,7 @@ static void ieee80211_send_null_response(struct sta_info *sta, int tid,
        skb_reserve(skb, local->hw.extra_tx_headroom);
-        nullfunc = (void *) skb_put(skb, size);
+        nullfunc = skb_put(skb, size);
        nullfunc->frame_control = fc;
        nullfunc->duration_id = 0;
        memcpy(nullfunc->addr1, sta->sta.addr, ETH_ALEN);
diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
index 86740670102d..709ef02fe67e 100644
--- a/net/mac80211/tdls.c
+++ b/net/mac80211/tdls.c
@@ -49,7 +49,7 @@ static void ieee80211_tdls_add_ext_capab(struct ieee80211_sub_if_data *sdata,
                          !ifmgd->tdls_wider_bw_prohibited;
        struct ieee80211_supported_band *sband = ieee80211_get_sband(sdata);
        bool vht = sband && sband->vht_cap.vht_supported;
-        u8 *pos = (void *)skb_put(skb, 10);
+        u8 *pos = skb_put(skb, 10);
        *pos++ = WLAN_EID_EXT_CAPABILITY;
        *pos++ = 8; /* len */
@@ -168,7 +168,7 @@ static void ieee80211_tdls_add_oper_classes(struct ieee80211_sub_if_data *sdata,
 static void ieee80211_tdls_add_bss_coex_ie(struct sk_buff *skb)
 {
-        u8 *pos = (void *)skb_put(skb, 3);
+        u8 *pos = skb_put(skb, 3);
        *pos++ = WLAN_EID_BSS_COEX_2040;
        *pos++ = 1; /* len */
@@ -209,7 +209,7 @@ static void ieee80211_tdls_add_link_ie(struct ieee80211_sub_if_data *sdata,
                rsp_addr = sdata->vif.addr;
        }
-        lnkid = (void *)skb_put(skb, sizeof(struct ieee80211_tdls_lnkie));
+        lnkid = skb_put(skb, sizeof(struct ieee80211_tdls_lnkie));
        lnkid->ie_type = WLAN_EID_LINK_ID;
        lnkid->ie_len = sizeof(struct ieee80211_tdls_lnkie) - 2;
@@ -223,7 +223,7 @@ static void
 ieee80211_tdls_add_aid(struct ieee80211_sub_if_data *sdata, struct sk_buff *skb)
 {
        struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
-        u8 *pos = (void *)skb_put(skb, 4);
+        u8 *pos = skb_put(skb, 4);
        *pos++ = WLAN_EID_AID;
        *pos++ = 2; /* len */
@@ -745,7 +745,7 @@ ieee80211_prep_tdls_encap_data(struct wiphy *wiphy, struct net_device *dev,
        struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
        struct ieee80211_tdls_data *tf;
-        tf = (void *)skb_put(skb, offsetof(struct ieee80211_tdls_data, u));
+        tf = skb_put(skb, offsetof(struct ieee80211_tdls_data, u));
        memcpy(tf->da, peer, ETH_ALEN);
        memcpy(tf->sa, sdata->vif.addr, ETH_ALEN);
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 18c5d6e6305d..ec5a9a72797e 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -3874,7 +3874,7 @@ static void __ieee80211_beacon_add_tim(struct ieee80211_sub_if_data *sdata,
                        ps->dtim_count--;
        }
-        tim = pos = (u8 *) skb_put(skb, 6);
+        tim = pos = skb_put(skb, 6);
        *pos++ = WLAN_EID_TIM;
        *pos++ = 4;
        *pos++ = ps->dtim_count;
diff --git a/net/mac80211/wpa.c b/net/mac80211/wpa.c
index cc19614ff4e6..0d722ea98a1b 100644
--- a/net/mac80211/wpa.c
+++ b/net/mac80211/wpa.c
@@ -949,7 +949,7 @@ ieee80211_crypto_aes_cmac_encrypt(struct ieee80211_tx_data *tx)
        if (WARN_ON(skb_tailroom(skb) < sizeof(*mmie)))
                return TX_DROP;
-        mmie = (struct ieee80211_mmie *) skb_put(skb, sizeof(*mmie));
+        mmie = skb_put(skb, sizeof(*mmie));
        mmie->element_id = WLAN_EID_MMIE;
        mmie->length = sizeof(*mmie) - 2;
        mmie->key_id = cpu_to_le16(key->conf.keyidx);
@@ -993,7 +993,7 @@ ieee80211_crypto_aes_cmac_256_encrypt(struct ieee80211_tx_data *tx)
        if (WARN_ON(skb_tailroom(skb) < sizeof(*mmie)))
                return TX_DROP;
-        mmie = (struct ieee80211_mmie_16 *)skb_put(skb, sizeof(*mmie));
+        mmie = skb_put(skb, sizeof(*mmie));
        mmie->element_id = WLAN_EID_MMIE;
        mmie->length = sizeof(*mmie) - 2;
        mmie->key_id = cpu_to_le16(key->conf.keyidx);
@@ -1138,7 +1138,7 @@ ieee80211_crypto_aes_gmac_encrypt(struct ieee80211_tx_data *tx)
        if (WARN_ON(skb_tailroom(skb) < sizeof(*mmie)))
                return TX_DROP;
-        mmie = (struct ieee80211_mmie_16 *)skb_put(skb, sizeof(*mmie));
+        mmie = skb_put(skb, sizeof(*mmie));
        mmie->element_id = WLAN_EID_MMIE;
        mmie->length = sizeof(*mmie) - 2;
        mmie->key_id = cpu_to_le16(key->conf.keyidx);
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index da9704971a83..94ec0d0765a8 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -590,7 +590,7 @@ __build_packet_message(struct nfnl_log_net *log,
                if (skb_tailroom(inst->skb) < nla_total_size(data_len))
                        goto nla_put_failure;
-                nla = (struct nlattr *)skb_put(inst->skb, nla_total_size(data_len));
+                nla = skb_put(inst->skb, nla_total_size(data_len));
                nla->nla_type = NFULA_PAYLOAD;
                nla->nla_len = size;
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index 8a0f218b7938..1b17a1b445a3 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -589,7 +589,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,
                if (skb_tailroom(skb) < sizeof(*nla) + hlen)
                        goto nla_put_failure;
-                nla = (struct nlattr *)skb_put(skb, sizeof(*nla));
+                nla = skb_put(skb, sizeof(*nla));
                nla->nla_type = NFQA_PAYLOAD;
                nla->nla_len = nla_attr_size(data_len);
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index bd24a975fd49..a88745e4b7df 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2104,7 +2104,7 @@ __nlmsg_put(struct sk_buff *skb, u32 portid, u32 seq, int type, int len, int fla
        struct nlmsghdr *nlh;
        int size = nlmsg_msg_size(len);
-        nlh = (struct nlmsghdr *)skb_put(skb, NLMSG_ALIGN(size));
+        nlh = skb_put(skb, NLMSG_ALIGN(size));
        nlh->nlmsg_type = type;
        nlh->nlmsg_len = size;
        nlh->nlmsg_flags = flags;
diff --git a/net/nfc/digital_core.c b/net/nfc/digital_core.c
index 0fd5518bf252..fec47a7d0092 100644
--- a/net/nfc/digital_core.c
+++ b/net/nfc/digital_core.c
@@ -74,8 +74,8 @@ void digital_skb_add_crc(struct sk_buff *skb, crc_func_t crc_func, u16 init,
        if (msb_first)
                crc = __fswab16(crc);
-        *skb_put(skb, 1) = crc & 0xFF;
+        *(u8 *)skb_put(skb, 1) = crc & 0xFF;
-        *skb_put(skb, 1) = (crc >> 8) & 0xFF;
+        *(u8 *)skb_put(skb, 1) = (crc >> 8) & 0xFF;
 }
 int digital_skb_check_crc(struct sk_buff *skb, crc_func_t crc_func,
diff --git a/net/nfc/digital_dep.c b/net/nfc/digital_dep.c
index f44f75a2a4d5..82471af5553e 100644
--- a/net/nfc/digital_dep.c
+++ b/net/nfc/digital_dep.c
@@ -654,7 +654,7 @@ static int digital_in_send_rtox(struct nfc_digital_dev *ddev,
        if (!skb)
                return -ENOMEM;
-        *skb_put(skb, 1) = rtox;
+        *(u8 *)skb_put(skb, 1) = rtox;
        skb_push(skb, sizeof(struct digital_dep_req_res));
diff --git a/net/nfc/digital_technology.c b/net/nfc/digital_technology.c
index d9080dec5d27..fae6d31b377c 100644
--- a/net/nfc/digital_technology.c
+++ b/net/nfc/digital_technology.c
@@ -266,8 +266,8 @@ static int digital_in_send_rats(struct nfc_digital_dev *ddev,
        if (!skb)
                return -ENOMEM;
-        *skb_put(skb, 1) = DIGITAL_RATS_BYTE1;
+        *(u8 *)skb_put(skb, 1) = DIGITAL_RATS_BYTE1;
-        *skb_put(skb, 1) = DIGITAL_RATS_PARAM;
+        *(u8 *)skb_put(skb, 1) = DIGITAL_RATS_PARAM;
        rc = digital_in_send_cmd(ddev, skb, 30, digital_in_recv_ats,
                                 target);
@@ -470,8 +470,8 @@ static int digital_in_send_sdd_req(struct nfc_digital_dev *ddev,
        else
                sel_cmd = DIGITAL_CMD_SEL_REQ_CL3;
-        *skb_put(skb, sizeof(u8)) = sel_cmd;
+        *(u8 *)skb_put(skb, sizeof(u8)) = sel_cmd;
-        *skb_put(skb, sizeof(u8)) = DIGITAL_SDD_REQ_SEL_PAR;
+        *(u8 *)skb_put(skb, sizeof(u8)) = DIGITAL_SDD_REQ_SEL_PAR;
        return digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res,
                                   target);
@@ -541,7 +541,7 @@ int digital_in_send_sens_req(struct nfc_digital_dev *ddev, u8 rf_tech)
        if (!skb)
                return -ENOMEM;
-        *skb_put(skb, sizeof(u8)) = DIGITAL_CMD_SENS_REQ;
+        *(u8 *)skb_put(skb, sizeof(u8)) = DIGITAL_CMD_SENS_REQ;
        rc = digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sens_res, NULL);
        if (rc)
@@ -625,8 +625,7 @@ static int digital_in_send_attrib_req(struct nfc_digital_dev *ddev,
        if (!skb)
                return -ENOMEM;
-        attrib_req = (struct digital_attrib_req *)skb_put(skb,
+        attrib_req = skb_put(skb, sizeof(*attrib_req));
-                                                          sizeof(*attrib_req));
        attrib_req->cmd = DIGITAL_CMD_ATTRIB_REQ;
        memcpy(attrib_req->nfcid0, sensb_res->nfcid0,
@@ -730,8 +729,7 @@ int digital_in_send_sensb_req(struct nfc_digital_dev *ddev, u8 rf_tech)
        if (!skb)
                return -ENOMEM;
-        sensb_req = (struct digital_sensb_req *)skb_put(skb,
+        sensb_req = skb_put(skb, sizeof(*sensb_req));
-                                                        sizeof(*sensb_req));
        sensb_req->cmd = DIGITAL_CMD_SENSB_REQ;
        sensb_req->afi = 0x00; /* All families and sub-families */
@@ -939,7 +937,7 @@ static int digital_tg_send_sel_res(struct nfc_digital_dev *ddev)
        if (!skb)
                return -ENOMEM;
-        *skb_put(skb, 1) = DIGITAL_SEL_RES_NFC_DEP;
+        *(u8 *)skb_put(skb, 1) = DIGITAL_SEL_RES_NFC_DEP;
        if (!DIGITAL_DRV_CAPS_TG_CRC(ddev))
                digital_skb_add_crc_a(skb);
diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c
index 8741ad47a6fb..3a0c94590411 100644
--- a/net/nfc/hci/core.c
+++ b/net/nfc/hci/core.c
@@ -874,7 +874,7 @@ static void nfc_hci_recv_from_llc(struct nfc_hci_dev *hdev, struct sk_buff *skb)
                        return;
                }
-                *skb_put(hcp_skb, NFC_HCI_HCP_PACKET_HEADER_LEN) = pipe;
+                *(u8 *)skb_put(hcp_skb, NFC_HCI_HCP_PACKET_HEADER_LEN) = pipe;
                skb_queue_walk(&hdev->rx_hcp_frags, frag_skb) {
                        msg_len = frag_skb->len - NFC_HCI_HCP_PACKET_HEADER_LEN;
diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c
index 401c7e255273..9ab4a05f086f 100644
--- a/net/nfc/hci/llc_shdlc.c
+++ b/net/nfc/hci/llc_shdlc.c
@@ -382,8 +382,8 @@ static int llc_shdlc_connect_initiate(struct llc_shdlc *shdlc)
        if (skb == NULL)
                return -ENOMEM;
-        *skb_put(skb, 1) = SHDLC_MAX_WINDOW;
+        *(u8 *)skb_put(skb, 1) = SHDLC_MAX_WINDOW;
-        *skb_put(skb, 1) = SHDLC_SREJ_SUPPORT ? 1 : 0;
+        *(u8 *)skb_put(skb, 1) = SHDLC_SREJ_SUPPORT ? 1 : 0;
        return llc_shdlc_send_u_frame(shdlc, skb, U_FRAME_RSET);
 }
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index 17b9f1ce23db..a3dac34cf790 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -1341,7 +1341,7 @@ int nci_send_cmd(struct nci_dev *ndev, __u16 opcode, __u8 plen, void *payload)
                return -ENOMEM;
        }
-        hdr = (struct nci_ctrl_hdr *) skb_put(skb, NCI_CTRL_HDR_SIZE);
+        hdr = skb_put(skb, NCI_CTRL_HDR_SIZE);
        hdr->gid = nci_opcode_gid(opcode);
        hdr->oid = nci_opcode_oid(opcode);
        hdr->plen = plen;
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c
index d4a53ce818c3..d1119bb35f24 100644
--- a/net/nfc/nci/hci.c
+++ b/net/nfc/nci/hci.c
@@ -472,7 +472,7 @@ void nci_hci_data_received_cb(void *context,
                        return;
                }
-                *skb_put(hcp_skb, NCI_HCI_HCP_PACKET_HEADER_LEN) = pipe;
+                *(u8 *)skb_put(hcp_skb, NCI_HCI_HCP_PACKET_HEADER_LEN) = pipe;
                skb_queue_walk(&ndev->hci_dev->rx_hcp_frags, frag_skb) {
                        msg_len = frag_skb->len - NCI_HCI_HCP_PACKET_HEADER_LEN;
diff --git a/net/nfc/nci/spi.c b/net/nfc/nci/spi.c
index d904cd2f1442..a502a334918a 100644
--- a/net/nfc/nci/spi.c
+++ b/net/nfc/nci/spi.c
@@ -86,8 +86,8 @@ int nci_spi_send(struct nci_spi *nspi,
                u16 crc;
                crc = crc_ccitt(CRC_INIT, skb->data, skb->len);
-                *skb_put(skb, 1) = crc >> 8;
+                *(u8 *)skb_put(skb, 1) = crc >> 8;
-                *skb_put(skb, 1) = crc & 0xFF;
+                *(u8 *)skb_put(skb, 1) = crc & 0xFF;
        }
        if (write_handshake_completion) {
@@ -172,8 +172,8 @@ static int send_acknowledge(struct nci_spi *nspi, u8 acknowledge)
        hdr[3] = 0;
        crc = crc_ccitt(CRC_INIT, skb->data, skb->len);
-        *skb_put(skb, 1) = crc >> 8;
+        *(u8 *)skb_put(skb, 1) = crc >> 8;
-        *skb_put(skb, 1) = crc & 0xFF;
+        *(u8 *)skb_put(skb, 1) = crc & 0xFF;
        ret = __nci_spi_send(nspi, skb, 0);
diff --git a/net/nfc/nci/uart.c b/net/nfc/nci/uart.c
index cfa7f352c1c3..442f8eadfc76 100644
--- a/net/nfc/nci/uart.c
+++ b/net/nfc/nci/uart.c
@@ -355,7 +355,7 @@ static int nci_uart_default_recv_buf(struct nci_uart *nu, const u8 *data,
                /* Eat byte after byte till full packet header is received */
                if (nu->rx_skb->len < NCI_CTRL_HDR_SIZE) {
-                        *skb_put(nu->rx_skb, 1) = *data++;
+                        *(u8 *)skb_put(nu->rx_skb, 1) = *data++;
                        --count;
                        continue;
                }
diff --git a/net/psample/psample.c b/net/psample/psample.c
index 8aa58a918783..3a6ad0f438dc 100644
--- a/net/psample/psample.c
+++ b/net/psample/psample.c
@@ -264,7 +264,7 @@ void psample_sample_packet(struct psample_group *group, struct sk_buff *skb,
                int nla_len = nla_total_size(data_len);
                struct nlattr *nla;
-                nla = (struct nlattr *)skb_put(nl_skb, nla_len);
+                nla = skb_put(nl_skb, nla_len);
                nla->nla_type = PSAMPLE_ATTR_DATA;
                nla->nla_len = nla_attr_size(data_len);
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index cff679167bdc..5586609afa27 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -259,7 +259,7 @@ static struct sk_buff *qrtr_alloc_ctrl_packet(u32 type, size_t pkt_len,
                return NULL;
        skb_reset_transport_header(skb);
-        hdr = (struct qrtr_hdr *)skb_put(skb, QRTR_HDR_SIZE);
+        hdr = skb_put(skb, QRTR_HDR_SIZE);
        hdr->version = cpu_to_le32(QRTR_PROTO_VER);
        hdr->type = cpu_to_le32(type);
        hdr->src_node_id = cpu_to_le32(src_node);
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 034e916362cf..2c196b3e9cd3 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -1389,7 +1389,7 @@ static struct sctp_chunk *_sctp_make_chunk(const struct sctp_association *asoc,
                goto nodata;
        /* Make room for the chunk header.  */
-        chunk_hdr = (sctp_chunkhdr_t *)skb_put(skb, sizeof(sctp_chunkhdr_t));
+        chunk_hdr = skb_put(skb, sizeof(sctp_chunkhdr_t));
        chunk_hdr->type   = type;
        chunk_hdr->flags  = flags;
        chunk_hdr->length = htons(sizeof(sctp_chunkhdr_t));
diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c
index ec2b3e013c2f..e361f0b57fb6 100644
--- a/net/sctp/ulpevent.c
+++ b/net/sctp/ulpevent.c
@@ -167,8 +167,7 @@ struct sctp_ulpevent  *sctp_ulpevent_make_assoc_change(
                        goto fail;
                skb = sctp_event2skb(event);
-                sac = (struct sctp_assoc_change *) skb_put(skb,
+                sac = skb_put(skb, sizeof(struct sctp_assoc_change));
-                                        sizeof(struct sctp_assoc_change));
        }
        /* Socket Extensions for SCTP
@@ -270,8 +269,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_peer_addr_change(
                goto fail;
        skb = sctp_event2skb(event);
-        spc = (struct sctp_paddr_change *)
+        spc = skb_put(skb, sizeof(struct sctp_paddr_change));
-                skb_put(skb, sizeof(struct sctp_paddr_change));
        /* Sockets API Extensions for SCTP
         * Section 5.3.1.2 SCTP_PEER_ADDR_CHANGE
@@ -549,8 +547,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_shutdown_event(
                goto fail;
        skb = sctp_event2skb(event);
-        sse = (struct sctp_shutdown_event *)
+        sse = skb_put(skb, sizeof(struct sctp_shutdown_event));
-                skb_put(skb, sizeof(struct sctp_shutdown_event));
        /* Socket Extensions for SCTP
         * 5.3.1.5 SCTP_SHUTDOWN_EVENT
@@ -612,8 +609,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_adaptation_indication(
                goto fail;
        skb = sctp_event2skb(event);
-        sai = (struct sctp_adaptation_event *)
+        sai = skb_put(skb, sizeof(struct sctp_adaptation_event));
-                skb_put(skb, sizeof(struct sctp_adaptation_event));
        sai->sai_type = SCTP_ADAPTATION_INDICATION;
        sai->sai_flags = 0;
@@ -751,8 +747,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_pdapi(
                goto fail;
        skb = sctp_event2skb(event);
-        pd = (struct sctp_pdapi_event *)
+        pd = skb_put(skb, sizeof(struct sctp_pdapi_event));
-                skb_put(skb, sizeof(struct sctp_pdapi_event));
        /* pdapi_type
         *   It should be SCTP_PARTIAL_DELIVERY_EVENT
@@ -803,8 +798,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_authkey(
                goto fail;
        skb = sctp_event2skb(event);
-        ak = (struct sctp_authkey_event *)
+        ak = skb_put(skb, sizeof(struct sctp_authkey_event));
-                skb_put(skb, sizeof(struct sctp_authkey_event));
        ak->auth_type = SCTP_AUTHENTICATION_EVENT;
        ak->auth_flags = 0;
@@ -842,8 +836,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_sender_dry_event(
                return NULL;
        skb = sctp_event2skb(event);
-        sdry = (struct sctp_sender_dry_event *)
+        sdry = skb_put(skb, sizeof(struct sctp_sender_dry_event));
-                skb_put(skb, sizeof(struct sctp_sender_dry_event));
        sdry->sender_dry_type = SCTP_SENDER_DRY_EVENT;
        sdry->sender_dry_flags = 0;
@@ -869,7 +862,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_stream_reset_event(
                return NULL;
        skb = sctp_event2skb(event);
-        sreset = (struct sctp_stream_reset_event *)skb_put(skb, length);
+        sreset = skb_put(skb, length);
        sreset->strreset_type = SCTP_STREAM_RESET_EVENT;
        sreset->strreset_flags = flags;
@@ -897,8 +890,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_assoc_reset_event(
                return NULL;
        skb = sctp_event2skb(event);
-        areset = (struct sctp_assoc_reset_event *)
+        areset = skb_put(skb, sizeof(struct sctp_assoc_reset_event));
-                skb_put(skb, sizeof(struct sctp_assoc_reset_event));
        areset->assocreset_type = SCTP_ASSOC_RESET_EVENT;
        areset->assocreset_flags = flags;
@@ -925,8 +917,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_stream_change_event(
                return NULL;
        skb = sctp_event2skb(event);
-        schange = (struct sctp_stream_change_event *)
+        schange = skb_put(skb, sizeof(struct sctp_stream_change_event));
-                skb_put(skb, sizeof(struct sctp_stream_change_event));
        schange->strchange_type = SCTP_STREAM_CHANGE_EVENT;
        schange->strchange_flags = flags;
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index 24e2054bfbaf..7d6ee03f2762 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -99,7 +99,7 @@ static struct sk_buff *virtio_transport_build_skb(void *opaque)
        if (!skb)
                return NULL;
-        hdr = (struct af_vsockmon_hdr *)skb_put(skb, sizeof(*hdr));
+        hdr = skb_put(skb, sizeof(*hdr));
        /* pkt->hdr is little-endian so no need to byteswap here */
        hdr->src_cid = pkt->hdr.src_cid;
author	Johannes Berg <johannes.berg@intel.com>	2017-06-16 08:29:21 -0400
committer	David S. Miller <davem@davemloft.net>	2017-06-16 11:48:39 -0400
commit	4df864c1d9afb46e2461a9f808d9f11a42d31bad (patch)
tree	07e7b3d16b161e0d199c5b8116df277798566e4f /net
parent	59ae1d127ac0ae404baf414c434ba2651b793f46 (diff)