cfg80211: Authentication offload to user space in AP mode

commit 40cbfa90218b ("cfg80211/nl80211: Optional authentication
offload to userspace")' introduced authentication offload to user
space by the host drivers in station mode. This commit extends
the same for the AP mode too.

Extend NL80211_ATTR_EXTERNAL_AUTH_SUPPORT to also claim the
support of external authentication from the user space in AP mode.
A new flag parameter is introduced in cfg80211_ap_settings to
intend the same while "start ap".

Host driver to use NL80211_CMD_FRAME interface to transmit and
receive the authentication frames to / from the user space.

Host driver to indicate the flag NL80211_RXMGMT_FLAG_EXTERNAL_AUTH
while sending the authentication frame to the user space. This
intends to the user space that the driver wishes it to process
the authentication frame for certain protocols, though it had
initially advertised the support for SME functionality.

User space shall accordingly do the authentication and indicate
its final status through the command NL80211_CMD_EXTERNAL_AUTH.
Allow the command even if userspace doesn't include the attribute
NL80211_ATTR_SSID for AP interface.

Host driver shall continue with the association sequence and
indicate the STA connection status through cfg80211_new_sta.

To facilitate the host drivers in AP mode for matching the pmkid
by the stations during the association, NL80211_CMD_EXTERNAL_AUTH
is also enhanced to include the pmkid to drivers after
the authentication.
This pmkid can also be used in the STA mode to include in the
association request.

Also modify nl80211_external_auth to not mandate SSID in AP mode.

Signed-off-by: Srinivas Dasari <dasaris@codeaurora.org>
[remove useless nla_get_flag() usage]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

1 files changed, 18 insertions, 7 deletions

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index eb4437fa0539..dc96077afe5e 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4550,6 +4550,9 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
 
         nl80211_calculate_ap_params(&params);
 
+        if (info->attrs[NL80211_ATTR_EXTERNAL_AUTH_SUPPORT])
+                params.flags |= AP_SETTINGS_EXTERNAL_AUTH_SUPPORT;
+
         wdev_lock(wdev);
         err = rdev_start_ap(rdev, dev, &params);
         if (!err) {
@@ -13086,7 +13089,9 @@ static int nl80211_external_auth(struct sk_buff *skb, struct genl_info *info)
         if (!rdev->ops->external_auth)
                 return -EOPNOTSUPP;
 
-        if (!info->attrs[NL80211_ATTR_SSID])
+        if (!info->attrs[NL80211_ATTR_SSID] &&
+            dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
+            dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO)
                 return -EINVAL;
 
         if (!info->attrs[NL80211_ATTR_BSSID])
@@ -13097,18 +13102,24 @@ static int nl80211_external_auth(struct sk_buff *skb, struct genl_info *info)
 
         memset(&params, 0, sizeof(params));
 
-        params.ssid.ssid_len = nla_len(info->attrs[NL80211_ATTR_SSID]);
-        if (params.ssid.ssid_len == 0 ||
-            params.ssid.ssid_len > IEEE80211_MAX_SSID_LEN)
-                return -EINVAL;
-        memcpy(params.ssid.ssid, nla_data(info->attrs[NL80211_ATTR_SSID]),
-               params.ssid.ssid_len);
+        if (info->attrs[NL80211_ATTR_SSID]) {
+                params.ssid.ssid_len = nla_len(info->attrs[NL80211_ATTR_SSID]);
+                if (params.ssid.ssid_len == 0 ||
+                    params.ssid.ssid_len > IEEE80211_MAX_SSID_LEN)
+                        return -EINVAL;
+                memcpy(params.ssid.ssid,
+                       nla_data(info->attrs[NL80211_ATTR_SSID]),
+                       params.ssid.ssid_len);
+        }
 
         memcpy(params.bssid, nla_data(info->attrs[NL80211_ATTR_BSSID]),
                ETH_ALEN);
 
         params.status = nla_get_u16(info->attrs[NL80211_ATTR_STATUS_CODE]);
 
+        if (info->attrs[NL80211_ATTR_PMKID])
+                params.pmkid = nla_data(info->attrs[NL80211_ATTR_PMKID]);
+
         return rdev_external_auth(rdev, dev, &params);
 }