nl80211: fix memory leak if validate_pae_over_nl80211() fails

If validate_pae_over_nl80211() were to fail in nl80211_crypto_settings(),
we might leak the 'connkeys' allocation. Fix this.

Fixes: 64bf3d4bc2b0 ("nl80211: Add CONTROL_PORT_OVER_NL80211 attribute")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

1 files changed, 3 insertions, 1 deletions

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 8d763725498c..2317727d6413 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -8930,8 +8930,10 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
         if (info->attrs[NL80211_ATTR_CONTROL_PORT_OVER_NL80211]) {
                 int r = validate_pae_over_nl80211(rdev, info);
 
-                if (r < 0)
+                if (r < 0) {
+                        kzfree(connkeys);
                         return r;
+                }
 
                 ibss.control_port_over_nl80211 = true;
         }