diff options
author | Johannes Berg <johannes.berg@intel.com> | 2019-01-25 04:08:28 -0500 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2019-02-01 05:06:55 -0500 |
commit | 23323289b1543b445d1f10aeab1bcfd84f2ca50a (patch) | |
tree | ebf5858e66a307631968e165bd788a1314991f2b /net/wireless | |
parent | 752cfee90d11e280d727617bf8d6df894141e157 (diff) |
netlink: reduce NLA_POLICY_NESTED{,_ARRAY} arguments
In typical cases, there's no need to pass both the maxattr
and the policy array pointer, as the maxattr should just be
ARRAY_SIZE(policy) - 1. Therefore, to be less error prone,
just remove the maxattr argument from the default macros
and deduce the size accordingly.
Leave the original macros with a leading underscore to use
here and in case somebody needs to pass a policy pointer
where the policy isn't declared in the same place and thus
ARRAY_SIZE() cannot be used.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
-rw-r--r-- | net/wireless/nl80211.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index ed53f8332ec8..a3cc039b9f55 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c | |||
@@ -259,15 +259,13 @@ nl80211_pmsr_ftm_req_attr_policy[NL80211_PMSR_FTM_REQ_ATTR_MAX + 1] = { | |||
259 | static const struct nla_policy | 259 | static const struct nla_policy |
260 | nl80211_pmsr_req_data_policy[NL80211_PMSR_TYPE_MAX + 1] = { | 260 | nl80211_pmsr_req_data_policy[NL80211_PMSR_TYPE_MAX + 1] = { |
261 | [NL80211_PMSR_TYPE_FTM] = | 261 | [NL80211_PMSR_TYPE_FTM] = |
262 | NLA_POLICY_NESTED(NL80211_PMSR_FTM_REQ_ATTR_MAX, | 262 | NLA_POLICY_NESTED(nl80211_pmsr_ftm_req_attr_policy), |
263 | nl80211_pmsr_ftm_req_attr_policy), | ||
264 | }; | 263 | }; |
265 | 264 | ||
266 | static const struct nla_policy | 265 | static const struct nla_policy |
267 | nl80211_pmsr_req_attr_policy[NL80211_PMSR_REQ_ATTR_MAX + 1] = { | 266 | nl80211_pmsr_req_attr_policy[NL80211_PMSR_REQ_ATTR_MAX + 1] = { |
268 | [NL80211_PMSR_REQ_ATTR_DATA] = | 267 | [NL80211_PMSR_REQ_ATTR_DATA] = |
269 | NLA_POLICY_NESTED(NL80211_PMSR_TYPE_MAX, | 268 | NLA_POLICY_NESTED(nl80211_pmsr_req_data_policy), |
270 | nl80211_pmsr_req_data_policy), | ||
271 | [NL80211_PMSR_REQ_ATTR_GET_AP_TSF] = { .type = NLA_FLAG }, | 269 | [NL80211_PMSR_REQ_ATTR_GET_AP_TSF] = { .type = NLA_FLAG }, |
272 | }; | 270 | }; |
273 | 271 | ||
@@ -280,8 +278,7 @@ nl80211_psmr_peer_attr_policy[NL80211_PMSR_PEER_ATTR_MAX + 1] = { | |||
280 | */ | 278 | */ |
281 | [NL80211_PMSR_PEER_ATTR_CHAN] = { .type = NLA_NESTED }, | 279 | [NL80211_PMSR_PEER_ATTR_CHAN] = { .type = NLA_NESTED }, |
282 | [NL80211_PMSR_PEER_ATTR_REQ] = | 280 | [NL80211_PMSR_PEER_ATTR_REQ] = |
283 | NLA_POLICY_NESTED(NL80211_PMSR_REQ_ATTR_MAX, | 281 | NLA_POLICY_NESTED(nl80211_pmsr_req_attr_policy), |
284 | nl80211_pmsr_req_attr_policy), | ||
285 | [NL80211_PMSR_PEER_ATTR_RESP] = { .type = NLA_REJECT }, | 282 | [NL80211_PMSR_PEER_ATTR_RESP] = { .type = NLA_REJECT }, |
286 | }; | 283 | }; |
287 | 284 | ||
@@ -292,8 +289,7 @@ nl80211_pmsr_attr_policy[NL80211_PMSR_ATTR_MAX + 1] = { | |||
292 | [NL80211_PMSR_ATTR_RANDOMIZE_MAC_ADDR] = { .type = NLA_REJECT }, | 289 | [NL80211_PMSR_ATTR_RANDOMIZE_MAC_ADDR] = { .type = NLA_REJECT }, |
293 | [NL80211_PMSR_ATTR_TYPE_CAPA] = { .type = NLA_REJECT }, | 290 | [NL80211_PMSR_ATTR_TYPE_CAPA] = { .type = NLA_REJECT }, |
294 | [NL80211_PMSR_ATTR_PEERS] = | 291 | [NL80211_PMSR_ATTR_PEERS] = |
295 | NLA_POLICY_NESTED_ARRAY(NL80211_PMSR_PEER_ATTR_MAX, | 292 | NLA_POLICY_NESTED_ARRAY(nl80211_psmr_peer_attr_policy), |
296 | nl80211_psmr_peer_attr_policy), | ||
297 | }; | 293 | }; |
298 | 294 | ||
299 | const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { | 295 | const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { |
@@ -555,8 +551,7 @@ const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { | |||
555 | }, | 551 | }, |
556 | [NL80211_ATTR_TIMEOUT] = NLA_POLICY_MIN(NLA_U32, 1), | 552 | [NL80211_ATTR_TIMEOUT] = NLA_POLICY_MIN(NLA_U32, 1), |
557 | [NL80211_ATTR_PEER_MEASUREMENTS] = | 553 | [NL80211_ATTR_PEER_MEASUREMENTS] = |
558 | NLA_POLICY_NESTED(NL80211_PMSR_ATTR_MAX, | 554 | NLA_POLICY_NESTED(nl80211_pmsr_attr_policy), |
559 | nl80211_pmsr_attr_policy), | ||
560 | [NL80211_ATTR_AIRTIME_WEIGHT] = NLA_POLICY_MIN(NLA_U16, 1), | 555 | [NL80211_ATTR_AIRTIME_WEIGHT] = NLA_POLICY_MIN(NLA_U16, 1), |
561 | }; | 556 | }; |
562 | 557 | ||