summaryrefslogtreecommitdiffstats
path: root/net/wimax/stack.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-08-10 06:17:16 -0400
committerDavid S. Miller <davem@davemloft.net>2019-08-10 18:25:47 -0400
commita62052ba2aecb9269a32efeb3e22f96b83a13304 (patch)
tree47b4a528a298070c8bf0a880cf01402dbd99a667 /net/wimax/stack.c
parent38b9e0f6d981daf46a935c8c63a67f3949a15b6a (diff)
wimax: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs wimax files, making all of this much simpler and easier to understand. Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> Cc: linux-wimax@intel.com Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/wimax/stack.c')
-rw-r--r--net/wimax/stack.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/net/wimax/stack.c b/net/wimax/stack.c
index 1ba99d65feca..4b9b1c5e8f3a 100644
--- a/net/wimax/stack.c
+++ b/net/wimax/stack.c
@@ -481,12 +481,7 @@ int wimax_dev_add(struct wimax_dev *wimax_dev, struct net_device *net_dev)
481 /* Set up user-space interaction */ 481 /* Set up user-space interaction */
482 mutex_lock(&wimax_dev->mutex); 482 mutex_lock(&wimax_dev->mutex);
483 wimax_id_table_add(wimax_dev); 483 wimax_id_table_add(wimax_dev);
484 result = wimax_debugfs_add(wimax_dev); 484 wimax_debugfs_add(wimax_dev);
485 if (result < 0) {
486 dev_err(dev, "cannot initialize debugfs: %d\n",
487 result);
488 goto error_debugfs_add;
489 }
490 485
491 __wimax_state_set(wimax_dev, WIMAX_ST_DOWN); 486 __wimax_state_set(wimax_dev, WIMAX_ST_DOWN);
492 mutex_unlock(&wimax_dev->mutex); 487 mutex_unlock(&wimax_dev->mutex);
@@ -498,10 +493,6 @@ int wimax_dev_add(struct wimax_dev *wimax_dev, struct net_device *net_dev)
498 d_fnend(3, dev, "(wimax_dev %p net_dev %p) = 0\n", wimax_dev, net_dev); 493 d_fnend(3, dev, "(wimax_dev %p net_dev %p) = 0\n", wimax_dev, net_dev);
499 return 0; 494 return 0;
500 495
501error_debugfs_add:
502 wimax_id_table_rm(wimax_dev);
503 mutex_unlock(&wimax_dev->mutex);
504 wimax_rfkill_rm(wimax_dev);
505error_rfkill_add: 496error_rfkill_add:
506 d_fnend(3, dev, "(wimax_dev %p net_dev %p) = %d\n", 497 d_fnend(3, dev, "(wimax_dev %p net_dev %p) = %d\n",
507 wimax_dev, net_dev, result); 498 wimax_dev, net_dev, result);