summaryrefslogtreecommitdiffstats
path: root/net/sunrpc/xprtsock.c
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@hammerspace.com>2018-08-13 16:50:49 -0400
committerTrond Myklebust <trond.myklebust@hammerspace.com>2018-09-30 15:35:14 -0400
commite1806c7bfb803408df4dc53dfe502ffab0f46a67 (patch)
tree24cc00d32ad47196207beaf69a4d06419c36fc71 /net/sunrpc/xprtsock.c
parentd1109aa56c71e19fc117e75bff11384fc7279a3b (diff)
SUNRPC: Move reset of TCP state variables into the reconnect code
Rather than resetting state variables in socket state_change() callback, do it in the sunrpc TCP connect function itself. Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'net/sunrpc/xprtsock.c')
-rw-r--r--net/sunrpc/xprtsock.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index cd7d093721ae..ec1e3f93e707 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -1600,13 +1600,6 @@ static void xs_tcp_state_change(struct sock *sk)
1600 case TCP_ESTABLISHED: 1600 case TCP_ESTABLISHED:
1601 spin_lock(&xprt->transport_lock); 1601 spin_lock(&xprt->transport_lock);
1602 if (!xprt_test_and_set_connected(xprt)) { 1602 if (!xprt_test_and_set_connected(xprt)) {
1603
1604 /* Reset TCP record info */
1605 transport->recv.offset = 0;
1606 transport->recv.len = 0;
1607 transport->recv.copied = 0;
1608 transport->recv.flags =
1609 TCP_RCV_COPY_FRAGHDR | TCP_RCV_COPY_XID;
1610 xprt->connect_cookie++; 1603 xprt->connect_cookie++;
1611 clear_bit(XPRT_SOCK_CONNECTING, &transport->sock_state); 1604 clear_bit(XPRT_SOCK_CONNECTING, &transport->sock_state);
1612 xprt_clear_connecting(xprt); 1605 xprt_clear_connecting(xprt);
@@ -2386,6 +2379,12 @@ static int xs_tcp_finish_connecting(struct rpc_xprt *xprt, struct socket *sock)
2386 2379
2387 xs_set_memalloc(xprt); 2380 xs_set_memalloc(xprt);
2388 2381
2382 /* Reset TCP record info */
2383 transport->recv.offset = 0;
2384 transport->recv.len = 0;
2385 transport->recv.copied = 0;
2386 transport->recv.flags = TCP_RCV_COPY_FRAGHDR | TCP_RCV_COPY_XID;
2387
2389 /* Tell the socket layer to start connecting... */ 2388 /* Tell the socket layer to start connecting... */
2390 xprt->stat.connect_count++; 2389 xprt->stat.connect_count++;
2391 xprt->stat.connect_start = jiffies; 2390 xprt->stat.connect_start = jiffies;