diff options
author | Xin Long <lucien.xin@gmail.com> | 2016-12-20 00:49:49 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-12-20 14:15:44 -0500 |
commit | 165f2cf6405a9e2153b69302845c7d5c9f3cb23b (patch) | |
tree | a3825f30ed802dd11acbfd7a18728352bca48b18 /net/sctp/protocol.c | |
parent | 92f95322c65fef330cc0a6bb6ed3e7966f8635d5 (diff) |
sctp: reduce indent level in sctp_copy_local_addr_list
This patch is to reduce indent level by using continue when the addr
is not allowed, and also drop end_copy by using break.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/protocol.c')
-rw-r--r-- | net/sctp/protocol.c | 37 |
1 files changed, 19 insertions, 18 deletions
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 7b523e3f551f..da5d82bec1dc 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c | |||
@@ -205,26 +205,27 @@ int sctp_copy_local_addr_list(struct net *net, struct sctp_bind_addr *bp, | |||
205 | list_for_each_entry_rcu(addr, &net->sctp.local_addr_list, list) { | 205 | list_for_each_entry_rcu(addr, &net->sctp.local_addr_list, list) { |
206 | if (!addr->valid) | 206 | if (!addr->valid) |
207 | continue; | 207 | continue; |
208 | if (sctp_in_scope(net, &addr->a, scope)) { | 208 | if (!sctp_in_scope(net, &addr->a, scope)) |
209 | /* Now that the address is in scope, check to see if | 209 | continue; |
210 | * the address type is really supported by the local | 210 | |
211 | * sock as well as the remote peer. | 211 | /* Now that the address is in scope, check to see if |
212 | */ | 212 | * the address type is really supported by the local |
213 | if ((((AF_INET == addr->a.sa.sa_family) && | 213 | * sock as well as the remote peer. |
214 | (copy_flags & SCTP_ADDR4_PEERSUPP))) || | 214 | */ |
215 | (((AF_INET6 == addr->a.sa.sa_family) && | 215 | if (addr->a.sa.sa_family == AF_INET && |
216 | (copy_flags & SCTP_ADDR6_ALLOWED) && | 216 | !(copy_flags & SCTP_ADDR4_PEERSUPP)) |
217 | (copy_flags & SCTP_ADDR6_PEERSUPP)))) { | 217 | continue; |
218 | error = sctp_add_bind_addr(bp, &addr->a, | 218 | if (addr->a.sa.sa_family == AF_INET6 && |
219 | sizeof(addr->a), | 219 | (!(copy_flags & SCTP_ADDR6_ALLOWED) || |
220 | SCTP_ADDR_SRC, GFP_ATOMIC); | 220 | !(copy_flags & SCTP_ADDR6_PEERSUPP))) |
221 | if (error) | 221 | continue; |
222 | goto end_copy; | 222 | |
223 | } | 223 | error = sctp_add_bind_addr(bp, &addr->a, sizeof(addr->a), |
224 | } | 224 | SCTP_ADDR_SRC, GFP_ATOMIC); |
225 | if (error) | ||
226 | break; | ||
225 | } | 227 | } |
226 | 228 | ||
227 | end_copy: | ||
228 | rcu_read_unlock(); | 229 | rcu_read_unlock(); |
229 | return error; | 230 | return error; |
230 | } | 231 | } |