diff options
author | David Howells <dhowells@redhat.com> | 2018-10-04 04:32:28 -0400 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2018-10-04 04:32:28 -0400 |
commit | 5a790b7375414cffb0f7e8ab0f175d2e02a0af0e (patch) | |
tree | b35687b775f6e05e4034344636e34e0c5e141f8d /net/rxrpc | |
parent | 46894a13599a977ac35411b536fb3e0b2feefa95 (diff) |
rxrpc: Drop the local endpoint arg from rxrpc_extract_addr_from_skb()
rxrpc_extract_addr_from_skb() doesn't use the argument that points to the
local endpoint, so remove the argument.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc')
-rw-r--r-- | net/rxrpc/ar-internal.h | 3 | ||||
-rw-r--r-- | net/rxrpc/call_accept.c | 2 | ||||
-rw-r--r-- | net/rxrpc/conn_object.c | 2 | ||||
-rw-r--r-- | net/rxrpc/local_event.c | 2 | ||||
-rw-r--r-- | net/rxrpc/output.c | 2 | ||||
-rw-r--r-- | net/rxrpc/utils.c | 4 |
6 files changed, 6 insertions, 9 deletions
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index 9ba87e4d15c7..76569c178915 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h | |||
@@ -1111,8 +1111,7 @@ static inline void rxrpc_sysctl_exit(void) {} | |||
1111 | /* | 1111 | /* |
1112 | * utils.c | 1112 | * utils.c |
1113 | */ | 1113 | */ |
1114 | int rxrpc_extract_addr_from_skb(struct rxrpc_local *, struct sockaddr_rxrpc *, | 1114 | int rxrpc_extract_addr_from_skb(struct sockaddr_rxrpc *, struct sk_buff *); |
1115 | struct sk_buff *); | ||
1116 | 1115 | ||
1117 | static inline bool before(u32 seq1, u32 seq2) | 1116 | static inline bool before(u32 seq1, u32 seq2) |
1118 | { | 1117 | { |
diff --git a/net/rxrpc/call_accept.c b/net/rxrpc/call_accept.c index 9c7f26d06a52..8354cadbb839 100644 --- a/net/rxrpc/call_accept.c +++ b/net/rxrpc/call_accept.c | |||
@@ -280,7 +280,7 @@ static struct rxrpc_call *rxrpc_alloc_incoming_call(struct rxrpc_sock *rx, | |||
280 | peer = NULL; | 280 | peer = NULL; |
281 | if (!peer) { | 281 | if (!peer) { |
282 | peer = b->peer_backlog[peer_tail]; | 282 | peer = b->peer_backlog[peer_tail]; |
283 | if (rxrpc_extract_addr_from_skb(local, &peer->srx, skb) < 0) | 283 | if (rxrpc_extract_addr_from_skb(&peer->srx, skb) < 0) |
284 | return NULL; | 284 | return NULL; |
285 | b->peer_backlog[peer_tail] = NULL; | 285 | b->peer_backlog[peer_tail] = NULL; |
286 | smp_store_release(&b->peer_backlog_tail, | 286 | smp_store_release(&b->peer_backlog_tail, |
diff --git a/net/rxrpc/conn_object.c b/net/rxrpc/conn_object.c index fb856a1ccda8..c332722820c2 100644 --- a/net/rxrpc/conn_object.c +++ b/net/rxrpc/conn_object.c | |||
@@ -86,7 +86,7 @@ struct rxrpc_connection *rxrpc_find_connection_rcu(struct rxrpc_local *local, | |||
86 | 86 | ||
87 | _enter(",%x", sp->hdr.cid & RXRPC_CIDMASK); | 87 | _enter(",%x", sp->hdr.cid & RXRPC_CIDMASK); |
88 | 88 | ||
89 | if (rxrpc_extract_addr_from_skb(local, &srx, skb) < 0) | 89 | if (rxrpc_extract_addr_from_skb(&srx, skb) < 0) |
90 | goto not_found; | 90 | goto not_found; |
91 | 91 | ||
92 | if (srx.transport.family != local->srx.transport.family && | 92 | if (srx.transport.family != local->srx.transport.family && |
diff --git a/net/rxrpc/local_event.c b/net/rxrpc/local_event.c index 13bd8a4dfac7..927ead43df42 100644 --- a/net/rxrpc/local_event.c +++ b/net/rxrpc/local_event.c | |||
@@ -39,7 +39,7 @@ static void rxrpc_send_version_request(struct rxrpc_local *local, | |||
39 | 39 | ||
40 | _enter(""); | 40 | _enter(""); |
41 | 41 | ||
42 | if (rxrpc_extract_addr_from_skb(local, &srx, skb) < 0) | 42 | if (rxrpc_extract_addr_from_skb(&srx, skb) < 0) |
43 | return; | 43 | return; |
44 | 44 | ||
45 | msg.msg_name = &srx.transport; | 45 | msg.msg_name = &srx.transport; |
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index 993d4cd247f9..0f0b499d1202 100644 --- a/net/rxrpc/output.c +++ b/net/rxrpc/output.c | |||
@@ -561,7 +561,7 @@ void rxrpc_reject_packets(struct rxrpc_local *local) | |||
561 | continue; | 561 | continue; |
562 | } | 562 | } |
563 | 563 | ||
564 | if (rxrpc_extract_addr_from_skb(local, &srx, skb) == 0) { | 564 | if (rxrpc_extract_addr_from_skb(&srx, skb) == 0) { |
565 | msg.msg_namelen = srx.transport_len; | 565 | msg.msg_namelen = srx.transport_len; |
566 | 566 | ||
567 | whdr.epoch = htonl(sp->hdr.epoch); | 567 | whdr.epoch = htonl(sp->hdr.epoch); |
diff --git a/net/rxrpc/utils.c b/net/rxrpc/utils.c index 017adaa54e90..ff7af71c4b49 100644 --- a/net/rxrpc/utils.c +++ b/net/rxrpc/utils.c | |||
@@ -17,9 +17,7 @@ | |||
17 | /* | 17 | /* |
18 | * Fill out a peer address from a socket buffer containing a packet. | 18 | * Fill out a peer address from a socket buffer containing a packet. |
19 | */ | 19 | */ |
20 | int rxrpc_extract_addr_from_skb(struct rxrpc_local *local, | 20 | int rxrpc_extract_addr_from_skb(struct sockaddr_rxrpc *srx, struct sk_buff *skb) |
21 | struct sockaddr_rxrpc *srx, | ||
22 | struct sk_buff *skb) | ||
23 | { | 21 | { |
24 | memset(srx, 0, sizeof(*srx)); | 22 | memset(srx, 0, sizeof(*srx)); |
25 | 23 | ||