diff options
author | Nicholas Mc Guire <hofrat@osadl.org> | 2019-05-10 20:56:33 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-05-11 12:59:48 -0400 |
commit | 8f5e24514cbd63c352b663636f955fb286f2c3bd (patch) | |
tree | 3a2285b9721a14a46468c31bdb9410297f32a34c /net/qrtr | |
parent | daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5 (diff) |
net: qrtr: use protocol endiannes variable
sparse was unable to verify endiannes correctness due to reassignment
from le32_to_cpu to the same variable - fix this warning up by providing
a proper __le32 type and initializing it. This is not actually fixing
any bug - rather just addressing the sparse warning.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/qrtr')
-rw-r--r-- | net/qrtr/qrtr.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index dd0e97f4f6c0..801872a2e7aa 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c | |||
@@ -728,12 +728,13 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) | |||
728 | DECLARE_SOCKADDR(struct sockaddr_qrtr *, addr, msg->msg_name); | 728 | DECLARE_SOCKADDR(struct sockaddr_qrtr *, addr, msg->msg_name); |
729 | int (*enqueue_fn)(struct qrtr_node *, struct sk_buff *, int, | 729 | int (*enqueue_fn)(struct qrtr_node *, struct sk_buff *, int, |
730 | struct sockaddr_qrtr *, struct sockaddr_qrtr *); | 730 | struct sockaddr_qrtr *, struct sockaddr_qrtr *); |
731 | __le32 qrtr_type = cpu_to_le32(QRTR_TYPE_DATA); | ||
731 | struct qrtr_sock *ipc = qrtr_sk(sock->sk); | 732 | struct qrtr_sock *ipc = qrtr_sk(sock->sk); |
732 | struct sock *sk = sock->sk; | 733 | struct sock *sk = sock->sk; |
733 | struct qrtr_node *node; | 734 | struct qrtr_node *node; |
734 | struct sk_buff *skb; | 735 | struct sk_buff *skb; |
736 | u32 type = 0; | ||
735 | size_t plen; | 737 | size_t plen; |
736 | u32 type = QRTR_TYPE_DATA; | ||
737 | int rc; | 738 | int rc; |
738 | 739 | ||
739 | if (msg->msg_flags & ~(MSG_DONTWAIT)) | 740 | if (msg->msg_flags & ~(MSG_DONTWAIT)) |
@@ -807,8 +808,8 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) | |||
807 | } | 808 | } |
808 | 809 | ||
809 | /* control messages already require the type as 'command' */ | 810 | /* control messages already require the type as 'command' */ |
810 | skb_copy_bits(skb, 0, &type, 4); | 811 | skb_copy_bits(skb, 0, &qrtr_type, 4); |
811 | type = le32_to_cpu(type); | 812 | type = le32_to_cpu(qrtr_type); |
812 | } | 813 | } |
813 | 814 | ||
814 | rc = enqueue_fn(node, skb, type, &ipc->us, addr); | 815 | rc = enqueue_fn(node, skb, type, &ipc->us, addr); |