mac80211: pass bssids to elements parsing function

In multiple BSSID, we have nested IEs inside the multiple
BSSID IE, that override the external ones for that specific
BSS. As preparation for supporting that, pass 2 BSSIDs to the
parse function, the transmitter, and the selected BSSID, so
it can know which IEs to choose. If the selected BSSID is
NULL, the outer ones will be applied.

Change ieee80211_bss_info_update to parse elements itself,
instead of receiving them parsed, so we have the relevant
bss entry in hand.

Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

1 files changed, 26 insertions, 19 deletions

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 687821567287..1f41f760bd22 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2762,7 +2762,8 @@ static void ieee80211_auth_challenge(struct ieee80211_sub_if_data *sdata,
         u32 tx_flags = 0;
 
         pos = mgmt->u.auth.variable;
-        ieee802_11_parse_elems(pos, len - (pos - (u8 *) mgmt), false, &elems);
+        ieee802_11_parse_elems(pos, len - (pos - (u8 *)mgmt), false, &elems,
+                               mgmt->bssid, auth_data->bss->bssid);
         if (!elems.challenge)
                 return;
         auth_data->expected_transaction = 4;
@@ -3130,7 +3131,8 @@ static bool ieee80211_assoc_success(struct ieee80211_sub_if_data *sdata,
         }
 
         pos = mgmt->u.assoc_resp.variable;
-        ieee802_11_parse_elems(pos, len - (pos - (u8 *) mgmt), false, &elems);
+        ieee802_11_parse_elems(pos, len - (pos - (u8 *)mgmt), false, &elems,
+                               mgmt->bssid, assoc_data->bss->bssid);
 
         if (!elems.supp_rates) {
                 sdata_info(sdata, "no SuppRates element in AssocResp\n");
@@ -3167,7 +3169,9 @@ static bool ieee80211_assoc_success(struct ieee80211_sub_if_data *sdata,
                         return false;
 
                 ieee802_11_parse_elems(bss_ies->data, bss_ies->len,
-                                       false, &bss_elems);
+                                       false, &bss_elems,
+                                       mgmt->bssid,
+                                       assoc_data->bss->bssid);
                 if (assoc_data->wmm &&
                     !elems.wmm_param && bss_elems.wmm_param) {
                         elems.wmm_param = bss_elems.wmm_param;
@@ -3464,7 +3468,8 @@ static void ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
                 return;
 
         pos = mgmt->u.assoc_resp.variable;
-        ieee802_11_parse_elems(pos, len - (pos - (u8 *) mgmt), false, &elems);
+        ieee802_11_parse_elems(pos, len - (pos - (u8 *)mgmt), false, &elems,
+                               mgmt->bssid, assoc_data->bss->bssid);
 
         if (status_code == WLAN_STATUS_ASSOC_REJECTED_TEMPORARILY &&
             elems.timeout_int &&
@@ -3521,8 +3526,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
 
 static void ieee80211_rx_bss_info(struct ieee80211_sub_if_data *sdata,
                                   struct ieee80211_mgmt *mgmt, size_t len,
-                                  struct ieee80211_rx_status *rx_status,
-                                  struct ieee802_11_elems *elems)
+                                  struct ieee80211_rx_status *rx_status)
 {
         struct ieee80211_local *local = sdata->local;
         struct ieee80211_bss *bss;
@@ -3534,8 +3538,7 @@ static void ieee80211_rx_bss_info(struct ieee80211_sub_if_data *sdata,
         if (!channel)
                 return;
 
-        bss = ieee80211_bss_info_update(local, rx_status, mgmt, len, elems,
-                                        channel);
+        bss = ieee80211_bss_info_update(local, rx_status, mgmt, len, channel);
         if (bss) {
                 sdata->vif.bss_conf.beacon_rate = bss->beacon_rate;
                 ieee80211_rx_bss_put(local, bss);
@@ -3550,7 +3553,6 @@ static void ieee80211_rx_mgmt_probe_resp(struct ieee80211_sub_if_data *sdata,
         struct ieee80211_if_managed *ifmgd;
         struct ieee80211_rx_status *rx_status = (void *) skb->cb;
         size_t baselen, len = skb->len;
-        struct ieee802_11_elems elems;
 
         ifmgd = &sdata->u.mgd;
 
@@ -3563,10 +3565,7 @@ static void ieee80211_rx_mgmt_probe_resp(struct ieee80211_sub_if_data *sdata,
         if (baselen > len)
                 return;
 
-        ieee802_11_parse_elems(mgmt->u.probe_resp.variable, len - baselen,
-                               false, &elems);
-
-        ieee80211_rx_bss_info(sdata, mgmt, len, rx_status, &elems);
+        ieee80211_rx_bss_info(sdata, mgmt, len, rx_status);
 
         if (ifmgd->associated &&
             ether_addr_equal(mgmt->bssid, ifmgd->associated->bssid))
@@ -3736,9 +3735,11 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
         if (ifmgd->assoc_data && ifmgd->assoc_data->need_beacon &&
             ether_addr_equal(mgmt->bssid, ifmgd->assoc_data->bss->bssid)) {
                 ieee802_11_parse_elems(mgmt->u.beacon.variable,
-                                       len - baselen, false, &elems);
+                                       len - baselen, false, &elems,
+                                       mgmt->bssid,
+                                       ifmgd->assoc_data->bss->bssid);
 
-                ieee80211_rx_bss_info(sdata, mgmt, len, rx_status, &elems);
+                ieee80211_rx_bss_info(sdata, mgmt, len, rx_status);
                 if (elems.tim && !elems.parse_error) {
                         const struct ieee80211_tim_ie *tim_ie = elems.tim;
                         ifmgd->dtim_period = tim_ie->dtim_period;
@@ -3787,7 +3788,8 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
         ncrc = crc32_be(0, (void *)&mgmt->u.beacon.beacon_int, 4);
         ncrc = ieee802_11_parse_elems_crc(mgmt->u.beacon.variable,
                                           len - baselen, false, &elems,
-                                          care_about_ies, ncrc);
+                                          care_about_ies, ncrc,
+                                          mgmt->bssid, bssid);
 
         if (ieee80211_hw_check(&local->hw, PS_NULLFUNC_STACK) &&
             ieee80211_check_tim(elems.tim, elems.tim_len, ifmgd->aid)) {
@@ -3871,7 +3873,7 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
         ifmgd->beacon_crc = ncrc;
         ifmgd->beacon_crc_valid = true;
 
-        ieee80211_rx_bss_info(sdata, mgmt, len, rx_status, &elems);
+        ieee80211_rx_bss_info(sdata, mgmt, len, rx_status);
 
         ieee80211_sta_process_chanswitch(sdata, rx_status->mactime,
                                          rx_status->device_timestamp,
@@ -3992,9 +3994,10 @@ void ieee80211_sta_rx_queued_mgmt(struct ieee80211_sub_if_data *sdata,
                         if (ies_len < 0)
                                 break;
 
+                        /* CSA IE cannot be overridden, no need for BSSID */
                         ieee802_11_parse_elems(
                                 mgmt->u.action.u.chan_switch.variable,
-                                ies_len, true, &elems);
+                                ies_len, true, &elems, mgmt->bssid, NULL);
 
                         if (elems.parse_error)
                                 break;
@@ -4011,9 +4014,13 @@ void ieee80211_sta_rx_queued_mgmt(struct ieee80211_sub_if_data *sdata,
                         if (ies_len < 0)
                                 break;
 
+                        /*
+                         * extended CSA IE can't be overridden, no need for
+                         * BSSID
+                         */
                         ieee802_11_parse_elems(
                                 mgmt->u.action.u.ext_chan_switch.variable,
-                                ies_len, true, &elems);
+                                ies_len, true, &elems, mgmt->bssid, NULL);
 
                         if (elems.parse_error)
                                 break;