diff options
author | Joe Perches <joe@perches.com> | 2014-11-11 17:44:57 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-11-12 13:56:41 -0500 |
commit | 955a9d202f470019f42979f0d1caec98843e39ce (patch) | |
tree | fff6124b339bc33e3b5c67668bfcc13098be865c /net/irda/irqueue.c | |
parent | 8d326d818a2a8fc80c7df85dd88cb214804d1499 (diff) |
irda: Convert IRDA_DEBUG to pr_debug
Use the normal kernel debugging mechanism which also
enables dynamic_debug at the same time.
Other miscellanea:
o Remove sysctl for irda_debug
o Remove function tracing like uses (use ftrace instead)
o Coalesce formats
o Realign arguments
o Remove unnecessary OOM messages
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda/irqueue.c')
-rw-r--r-- | net/irda/irqueue.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/net/irda/irqueue.c b/net/irda/irqueue.c index 7152624ed5f1..acbe61c7e683 100644 --- a/net/irda/irqueue.c +++ b/net/irda/irqueue.c | |||
@@ -233,8 +233,6 @@ static __u32 hash( const char* name) | |||
233 | static void enqueue_first(irda_queue_t **queue, irda_queue_t* element) | 233 | static void enqueue_first(irda_queue_t **queue, irda_queue_t* element) |
234 | { | 234 | { |
235 | 235 | ||
236 | IRDA_DEBUG( 4, "%s()\n", __func__); | ||
237 | |||
238 | /* | 236 | /* |
239 | * Check if queue is empty. | 237 | * Check if queue is empty. |
240 | */ | 238 | */ |
@@ -267,7 +265,7 @@ static irda_queue_t *dequeue_first(irda_queue_t **queue) | |||
267 | { | 265 | { |
268 | irda_queue_t *ret; | 266 | irda_queue_t *ret; |
269 | 267 | ||
270 | IRDA_DEBUG( 4, "dequeue_first()\n"); | 268 | pr_debug("dequeue_first()\n"); |
271 | 269 | ||
272 | /* | 270 | /* |
273 | * Set return value | 271 | * Set return value |
@@ -308,7 +306,7 @@ static irda_queue_t *dequeue_general(irda_queue_t **queue, irda_queue_t* element | |||
308 | { | 306 | { |
309 | irda_queue_t *ret; | 307 | irda_queue_t *ret; |
310 | 308 | ||
311 | IRDA_DEBUG( 4, "dequeue_general()\n"); | 309 | pr_debug("dequeue_general()\n"); |
312 | 310 | ||
313 | /* | 311 | /* |
314 | * Set return value | 312 | * Set return value |
@@ -452,8 +450,6 @@ void hashbin_insert(hashbin_t* hashbin, irda_queue_t* entry, long hashv, | |||
452 | unsigned long flags = 0; | 450 | unsigned long flags = 0; |
453 | int bin; | 451 | int bin; |
454 | 452 | ||
455 | IRDA_DEBUG( 4, "%s()\n", __func__); | ||
456 | |||
457 | IRDA_ASSERT( hashbin != NULL, return;); | 453 | IRDA_ASSERT( hashbin != NULL, return;); |
458 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return;); | 454 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return;); |
459 | 455 | ||
@@ -565,8 +561,6 @@ void* hashbin_remove( hashbin_t* hashbin, long hashv, const char* name) | |||
565 | unsigned long flags = 0; | 561 | unsigned long flags = 0; |
566 | irda_queue_t* entry; | 562 | irda_queue_t* entry; |
567 | 563 | ||
568 | IRDA_DEBUG( 4, "%s()\n", __func__); | ||
569 | |||
570 | IRDA_ASSERT( hashbin != NULL, return NULL;); | 564 | IRDA_ASSERT( hashbin != NULL, return NULL;); |
571 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return NULL;); | 565 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return NULL;); |
572 | 566 | ||
@@ -658,8 +652,6 @@ void* hashbin_remove_this( hashbin_t* hashbin, irda_queue_t* entry) | |||
658 | int bin; | 652 | int bin; |
659 | long hashv; | 653 | long hashv; |
660 | 654 | ||
661 | IRDA_DEBUG( 4, "%s()\n", __func__); | ||
662 | |||
663 | IRDA_ASSERT( hashbin != NULL, return NULL;); | 655 | IRDA_ASSERT( hashbin != NULL, return NULL;); |
664 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return NULL;); | 656 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return NULL;); |
665 | IRDA_ASSERT( entry != NULL, return NULL;); | 657 | IRDA_ASSERT( entry != NULL, return NULL;); |
@@ -719,7 +711,7 @@ void* hashbin_find( hashbin_t* hashbin, long hashv, const char* name ) | |||
719 | int bin; | 711 | int bin; |
720 | irda_queue_t* entry; | 712 | irda_queue_t* entry; |
721 | 713 | ||
722 | IRDA_DEBUG( 4, "hashbin_find()\n"); | 714 | pr_debug("hashbin_find()\n"); |
723 | 715 | ||
724 | IRDA_ASSERT( hashbin != NULL, return NULL;); | 716 | IRDA_ASSERT( hashbin != NULL, return NULL;); |
725 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return NULL;); | 717 | IRDA_ASSERT( hashbin->magic == HB_MAGIC, return NULL;); |