cfg802154: introduce wpan phy flags

This patch introduce a flag property for the wpan phy structure.
The current flag settings in ieee802154_hw are accessable in mac802154
layer only which is okay for flags which indicates MAC handling which
are done by phy. For real PHY layer settings like cca mode, transmit
power, cca energy detection level.

The difference between these flags are that the MAC handling flags are
only handled in mac802154/HardMac layer e.g. on an interface up. The phy
settings are direct netlink calls from nl802154 into the driver layer
and the nl802154 need to have a chance to check if the driver supports
this handling before sending to the next layer.

We also check now on PHY flags while dumping and setting pib attributes.
In comparing with MIB attributes the 802.15.4 gives us an default value
which we assume when a transceiver implement less functionality. In case
of MIB settings the nl802154 layer doesn't need to check on the
ieee802154_hw flags then.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

1 files changed, 17 insertions, 10 deletions

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index fa0c4048b0e8..40fb0be009b2 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -291,19 +291,23 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
                 goto nla_put_failure;
 
         /* cca mode */
-        if (nla_put_u32(msg, NL802154_ATTR_CCA_MODE,
-                        rdev->wpan_phy.cca.mode))
-                goto nla_put_failure;
-
-        if (rdev->wpan_phy.cca.mode == NL802154_CCA_ENERGY_CARRIER) {
-                if (nla_put_u32(msg, NL802154_ATTR_CCA_OPT,
-                                rdev->wpan_phy.cca.opt))
+        if (rdev->wpan_phy.flags & WPAN_PHY_FLAG_CCA_MODE) {
+                if (nla_put_u32(msg, NL802154_ATTR_CCA_MODE,
+                                rdev->wpan_phy.cca.mode))
                         goto nla_put_failure;
+
+                if (rdev->wpan_phy.cca.mode == NL802154_CCA_ENERGY_CARRIER) {
+                        if (nla_put_u32(msg, NL802154_ATTR_CCA_OPT,
+                                        rdev->wpan_phy.cca.opt))
+                                goto nla_put_failure;
+                }
         }
 
-        if (nla_put_s32(msg, NL802154_ATTR_TX_POWER,
-                        rdev->wpan_phy.transmit_power))
-                goto nla_put_failure;
+        if (rdev->wpan_phy.flags & WPAN_PHY_FLAG_TXPOWER) {
+                if (nla_put_s32(msg, NL802154_ATTR_TX_POWER,
+                                rdev->wpan_phy.transmit_power))
+                        goto nla_put_failure;
+        }
 
 finish:
         genlmsg_end(msg, hdr);
@@ -637,6 +641,9 @@ static int nl802154_set_cca_mode(struct sk_buff *skb, struct genl_info *info)
         struct cfg802154_registered_device *rdev = info->user_ptr[0];
         struct wpan_phy_cca cca;
 
+        if (rdev->wpan_phy.flags & WPAN_PHY_FLAG_CCA_MODE)
+                return -EOPNOTSUPP;
+
         if (!info->attrs[NL802154_ATTR_CCA_MODE])
                 return -EINVAL;