ieee802154: use ieee802154_addr instead of *_sa variants

Change all internal uses of ieee802154_addr_sa to ieee802154_addr,
except for those instances that communicate directly with userspace.

Signed-off-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 66 insertions, 48 deletions

diff --git a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c
index 58fa523fb536..bda8dba4f993 100644
--- a/net/ieee802154/nl-mac.c
+++ b/net/ieee802154/nl-mac.c
@@ -39,14 +39,34 @@
 
 #include "ieee802154.h"
 
+static int nla_put_hwaddr(struct sk_buff *msg, int type, __le64 hwaddr)
+{
+        return nla_put_u64(msg, type, swab64((__force u64)hwaddr));
+}
+
+static __le64 nla_get_hwaddr(const struct nlattr *nla)
+{
+        return ieee802154_devaddr_from_raw(nla_data(nla));
+}
+
+static int nla_put_shortaddr(struct sk_buff *msg, int type, __le16 addr)
+{
+        return nla_put_u16(msg, type, le16_to_cpu(addr));
+}
+
+static __le16 nla_get_shortaddr(const struct nlattr *nla)
+{
+        return cpu_to_le16(nla_get_u16(nla));
+}
+
 int ieee802154_nl_assoc_indic(struct net_device *dev,
-                struct ieee802154_addr_sa *addr, u8 cap)
+                struct ieee802154_addr *addr, u8 cap)
 {
         struct sk_buff *msg;
 
         pr_debug("%s\n", __func__);
 
-        if (addr->addr_type != IEEE802154_ADDR_LONG) {
+        if (addr->mode != IEEE802154_ADDR_LONG) {
                 pr_err("%s: received non-long source address!\n", __func__);
                 return -EINVAL;
         }
@@ -59,8 +79,8 @@ int ieee802154_nl_assoc_indic(struct net_device *dev,
             nla_put_u32(msg, IEEE802154_ATTR_DEV_INDEX, dev->ifindex) ||
             nla_put(msg, IEEE802154_ATTR_HW_ADDR, IEEE802154_ADDR_LEN,
                     dev->dev_addr) ||
-            nla_put(msg, IEEE802154_ATTR_SRC_HW_ADDR, IEEE802154_ADDR_LEN,
-                    addr->hwaddr) ||
+            nla_put_hwaddr(msg, IEEE802154_ATTR_SRC_HW_ADDR,
+                           addr->extended_addr) ||
             nla_put_u8(msg, IEEE802154_ATTR_CAPABILITY, cap))
                 goto nla_put_failure;
 
@@ -87,8 +107,7 @@ int ieee802154_nl_assoc_confirm(struct net_device *dev, __le16 short_addr,
             nla_put_u32(msg, IEEE802154_ATTR_DEV_INDEX, dev->ifindex) ||
             nla_put(msg, IEEE802154_ATTR_HW_ADDR, IEEE802154_ADDR_LEN,
                     dev->dev_addr) ||
-            nla_put_u16(msg, IEEE802154_ATTR_SHORT_ADDR,
-                        le16_to_cpu(short_addr)) ||
+            nla_put_shortaddr(msg, IEEE802154_ATTR_SHORT_ADDR, short_addr) ||
             nla_put_u8(msg, IEEE802154_ATTR_STATUS, status))
                 goto nla_put_failure;
         return ieee802154_nl_mcast(msg, IEEE802154_COORD_MCGRP);
@@ -100,7 +119,7 @@ nla_put_failure:
 EXPORT_SYMBOL(ieee802154_nl_assoc_confirm);
 
 int ieee802154_nl_disassoc_indic(struct net_device *dev,
-                struct ieee802154_addr_sa *addr, u8 reason)
+                struct ieee802154_addr *addr, u8 reason)
 {
         struct sk_buff *msg;
 
@@ -115,13 +134,13 @@ int ieee802154_nl_disassoc_indic(struct net_device *dev,
             nla_put(msg, IEEE802154_ATTR_HW_ADDR, IEEE802154_ADDR_LEN,
                     dev->dev_addr))
                 goto nla_put_failure;
-        if (addr->addr_type == IEEE802154_ADDR_LONG) {
-                if (nla_put(msg, IEEE802154_ATTR_SRC_HW_ADDR, IEEE802154_ADDR_LEN,
-                            addr->hwaddr))
+        if (addr->mode == IEEE802154_ADDR_LONG) {
+                if (nla_put_hwaddr(msg, IEEE802154_ATTR_SRC_HW_ADDR,
+                                   addr->extended_addr))
                         goto nla_put_failure;
         } else {
-                if (nla_put_u16(msg, IEEE802154_ATTR_SRC_SHORT_ADDR,
-                                addr->short_addr))
+                if (nla_put_shortaddr(msg, IEEE802154_ATTR_SRC_SHORT_ADDR,
+                                      addr->short_addr))
                         goto nla_put_failure;
         }
         if (nla_put_u8(msg, IEEE802154_ATTR_REASON, reason))
@@ -173,10 +192,9 @@ int ieee802154_nl_beacon_indic(struct net_device *dev, __le16 panid,
             nla_put_u32(msg, IEEE802154_ATTR_DEV_INDEX, dev->ifindex) ||
             nla_put(msg, IEEE802154_ATTR_HW_ADDR, IEEE802154_ADDR_LEN,
                     dev->dev_addr) ||
-            nla_put_u16(msg, IEEE802154_ATTR_COORD_SHORT_ADDR,
-                        le16_to_cpu(coord_addr)) ||
-            nla_put_u16(msg, IEEE802154_ATTR_COORD_PAN_ID,
-                        le16_to_cpu(panid)))
+            nla_put_shortaddr(msg, IEEE802154_ATTR_COORD_SHORT_ADDR,
+                              coord_addr) ||
+            nla_put_shortaddr(msg, IEEE802154_ATTR_COORD_PAN_ID, panid))
                 goto nla_put_failure;
         return ieee802154_nl_mcast(msg, IEEE802154_COORD_MCGRP);
 
@@ -246,7 +264,7 @@ static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
 {
         void *hdr;
         struct wpan_phy *phy;
-        u16 short_addr, pan_id;
+        __le16 short_addr, pan_id;
 
         pr_debug("%s\n", __func__);
 
@@ -258,16 +276,16 @@ static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
         phy = ieee802154_mlme_ops(dev)->get_phy(dev);
         BUG_ON(!phy);
 
-        short_addr = le16_to_cpu(ieee802154_mlme_ops(dev)->get_short_addr(dev));
-        pan_id = le16_to_cpu(ieee802154_mlme_ops(dev)->get_pan_id(dev));
+        short_addr = ieee802154_mlme_ops(dev)->get_short_addr(dev);
+        pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev);
 
         if (nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name) ||
             nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) ||
             nla_put_u32(msg, IEEE802154_ATTR_DEV_INDEX, dev->ifindex) ||
             nla_put(msg, IEEE802154_ATTR_HW_ADDR, IEEE802154_ADDR_LEN,
                     dev->dev_addr) ||
-            nla_put_u16(msg, IEEE802154_ATTR_SHORT_ADDR, short_addr) ||
-            nla_put_u16(msg, IEEE802154_ATTR_PAN_ID, pan_id))
+            nla_put_shortaddr(msg, IEEE802154_ATTR_SHORT_ADDR, short_addr) ||
+            nla_put_shortaddr(msg, IEEE802154_ATTR_PAN_ID, pan_id))
                 goto nla_put_failure;
         wpan_phy_put(phy);
         return genlmsg_end(msg, hdr);
@@ -309,7 +327,7 @@ static struct net_device *ieee802154_nl_get_dev(struct genl_info *info)
 int ieee802154_associate_req(struct sk_buff *skb, struct genl_info *info)
 {
         struct net_device *dev;
-        struct ieee802154_addr_sa addr;
+        struct ieee802154_addr addr;
         u8 page;
         int ret = -EOPNOTSUPP;
 
@@ -327,16 +345,16 @@ int ieee802154_associate_req(struct sk_buff *skb, struct genl_info *info)
                 goto out;
 
         if (info->attrs[IEEE802154_ATTR_COORD_HW_ADDR]) {
-                addr.addr_type = IEEE802154_ADDR_LONG;
-                nla_memcpy(addr.hwaddr,
-                                info->attrs[IEEE802154_ATTR_COORD_HW_ADDR],
-                                IEEE802154_ADDR_LEN);
+                addr.mode = IEEE802154_ADDR_LONG;
+                addr.extended_addr = nla_get_hwaddr(
+                                info->attrs[IEEE802154_ATTR_COORD_HW_ADDR]);
         } else {
-                addr.addr_type = IEEE802154_ADDR_SHORT;
-                addr.short_addr = nla_get_u16(
+                addr.mode = IEEE802154_ADDR_SHORT;
+                addr.short_addr = nla_get_shortaddr(
                                 info->attrs[IEEE802154_ATTR_COORD_SHORT_ADDR]);
         }
-        addr.pan_id = nla_get_u16(info->attrs[IEEE802154_ATTR_COORD_PAN_ID]);
+        addr.pan_id = nla_get_shortaddr(
+                        info->attrs[IEEE802154_ATTR_COORD_PAN_ID]);
 
         if (info->attrs[IEEE802154_ATTR_PAGE])
                 page = nla_get_u8(info->attrs[IEEE802154_ATTR_PAGE]);
@@ -356,7 +374,7 @@ out:
 int ieee802154_associate_resp(struct sk_buff *skb, struct genl_info *info)
 {
         struct net_device *dev;
-        struct ieee802154_addr_sa addr;
+        struct ieee802154_addr addr;
         int ret = -EOPNOTSUPP;
 
         if (!info->attrs[IEEE802154_ATTR_STATUS] ||
@@ -370,13 +388,13 @@ int ieee802154_associate_resp(struct sk_buff *skb, struct genl_info *info)
         if (!ieee802154_mlme_ops(dev)->assoc_resp)
                 goto out;
 
-        addr.addr_type = IEEE802154_ADDR_LONG;
-        nla_memcpy(addr.hwaddr, info->attrs[IEEE802154_ATTR_DEST_HW_ADDR],
-                        IEEE802154_ADDR_LEN);
-        addr.pan_id = le16_to_cpu(ieee802154_mlme_ops(dev)->get_pan_id(dev));
+        addr.mode = IEEE802154_ADDR_LONG;
+        addr.extended_addr = nla_get_hwaddr(
+                        info->attrs[IEEE802154_ATTR_DEST_HW_ADDR]);
+        addr.pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev);
 
         ret = ieee802154_mlme_ops(dev)->assoc_resp(dev, &addr,
-                cpu_to_le16(nla_get_u16(info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR])),
+                nla_get_shortaddr(info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR]),
                 nla_get_u8(info->attrs[IEEE802154_ATTR_STATUS]));
 
 out:
@@ -387,7 +405,7 @@ out:
 int ieee802154_disassociate_req(struct sk_buff *skb, struct genl_info *info)
 {
         struct net_device *dev;
-        struct ieee802154_addr_sa addr;
+        struct ieee802154_addr addr;
         int ret = -EOPNOTSUPP;
 
         if ((!info->attrs[IEEE802154_ATTR_DEST_HW_ADDR] &&
@@ -402,16 +420,15 @@ int ieee802154_disassociate_req(struct sk_buff *skb, struct genl_info *info)
                 goto out;
 
         if (info->attrs[IEEE802154_ATTR_DEST_HW_ADDR]) {
-                addr.addr_type = IEEE802154_ADDR_LONG;
-                nla_memcpy(addr.hwaddr,
-                                info->attrs[IEEE802154_ATTR_DEST_HW_ADDR],
-                                IEEE802154_ADDR_LEN);
+                addr.mode = IEEE802154_ADDR_LONG;
+                addr.extended_addr = nla_get_hwaddr(
+                                info->attrs[IEEE802154_ATTR_DEST_HW_ADDR]);
         } else {
-                addr.addr_type = IEEE802154_ADDR_SHORT;
-                addr.short_addr = nla_get_u16(
+                addr.mode = IEEE802154_ADDR_SHORT;
+                addr.short_addr = nla_get_shortaddr(
                                 info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR]);
         }
-        addr.pan_id = le16_to_cpu(ieee802154_mlme_ops(dev)->get_pan_id(dev));
+        addr.pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev);
 
         ret = ieee802154_mlme_ops(dev)->disassoc_req(dev, &addr,
                         nla_get_u8(info->attrs[IEEE802154_ATTR_REASON]));
@@ -429,7 +446,7 @@ out:
 int ieee802154_start_req(struct sk_buff *skb, struct genl_info *info)
 {
         struct net_device *dev;
-        struct ieee802154_addr_sa addr;
+        struct ieee802154_addr addr;
 
         u8 channel, bcn_ord, sf_ord;
         u8 page;
@@ -453,10 +470,11 @@ int ieee802154_start_req(struct sk_buff *skb, struct genl_info *info)
         if (!ieee802154_mlme_ops(dev)->start_req)
                 goto out;
 
-        addr.addr_type = IEEE802154_ADDR_SHORT;
-        addr.short_addr = nla_get_u16(
+        addr.mode = IEEE802154_ADDR_SHORT;
+        addr.short_addr = nla_get_shortaddr(
                         info->attrs[IEEE802154_ATTR_COORD_SHORT_ADDR]);
-        addr.pan_id = nla_get_u16(info->attrs[IEEE802154_ATTR_COORD_PAN_ID]);
+        addr.pan_id = nla_get_shortaddr(
+                        info->attrs[IEEE802154_ATTR_COORD_PAN_ID]);
 
         channel = nla_get_u8(info->attrs[IEEE802154_ATTR_CHANNEL]);
         bcn_ord = nla_get_u8(info->attrs[IEEE802154_ATTR_BCN_ORD]);
@@ -471,7 +489,7 @@ int ieee802154_start_req(struct sk_buff *skb, struct genl_info *info)
                 page = 0;
 
 
-        if (addr.short_addr == IEEE802154_ADDR_BROADCAST) {
+        if (addr.short_addr == cpu_to_le16(IEEE802154_ADDR_BROADCAST)) {
                 ieee802154_nl_start_confirm(dev, IEEE802154_NO_SHORT_ADDRESS);
                 dev_put(dev);
                 return -EINVAL;