diff options
author | Yan, Zheng <zyan@redhat.com> | 2014-11-04 03:33:37 -0500 |
---|---|---|
committer | Ilya Dryomov <idryomov@redhat.com> | 2014-12-17 12:09:50 -0500 |
commit | 33d07337962c7bbd2fd5cf7f1106735c9507fbe2 (patch) | |
tree | 93a95e7d02db4d7ba7d282483e32fd0627a3c281 /net/ceph/messenger.c | |
parent | ae385eaf24dc39c1703049112e4265b9f93b7d86 (diff) |
libceph: message signature support
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Diffstat (limited to 'net/ceph/messenger.c')
-rw-r--r-- | net/ceph/messenger.c | 32 |
1 files changed, 29 insertions, 3 deletions
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index 863d07ab2129..33a2f201e460 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c | |||
@@ -1196,8 +1196,18 @@ static void prepare_write_message_footer(struct ceph_connection *con) | |||
1196 | dout("prepare_write_message_footer %p\n", con); | 1196 | dout("prepare_write_message_footer %p\n", con); |
1197 | con->out_kvec_is_msg = true; | 1197 | con->out_kvec_is_msg = true; |
1198 | con->out_kvec[v].iov_base = &m->footer; | 1198 | con->out_kvec[v].iov_base = &m->footer; |
1199 | con->out_kvec[v].iov_len = sizeof(m->footer); | 1199 | if (con->peer_features & CEPH_FEATURE_MSG_AUTH) { |
1200 | con->out_kvec_bytes += sizeof(m->footer); | 1200 | if (con->ops->sign_message) |
1201 | con->ops->sign_message(con, m); | ||
1202 | else | ||
1203 | m->footer.sig = 0; | ||
1204 | con->out_kvec[v].iov_len = sizeof(m->footer); | ||
1205 | con->out_kvec_bytes += sizeof(m->footer); | ||
1206 | } else { | ||
1207 | m->old_footer.flags = m->footer.flags; | ||
1208 | con->out_kvec[v].iov_len = sizeof(m->old_footer); | ||
1209 | con->out_kvec_bytes += sizeof(m->old_footer); | ||
1210 | } | ||
1201 | con->out_kvec_left++; | 1211 | con->out_kvec_left++; |
1202 | con->out_more = m->more_to_follow; | 1212 | con->out_more = m->more_to_follow; |
1203 | con->out_msg_done = true; | 1213 | con->out_msg_done = true; |
@@ -2249,6 +2259,7 @@ static int read_partial_message(struct ceph_connection *con) | |||
2249 | int ret; | 2259 | int ret; |
2250 | unsigned int front_len, middle_len, data_len; | 2260 | unsigned int front_len, middle_len, data_len; |
2251 | bool do_datacrc = !con->msgr->nocrc; | 2261 | bool do_datacrc = !con->msgr->nocrc; |
2262 | bool need_sign = (con->peer_features & CEPH_FEATURE_MSG_AUTH); | ||
2252 | u64 seq; | 2263 | u64 seq; |
2253 | u32 crc; | 2264 | u32 crc; |
2254 | 2265 | ||
@@ -2361,12 +2372,21 @@ static int read_partial_message(struct ceph_connection *con) | |||
2361 | } | 2372 | } |
2362 | 2373 | ||
2363 | /* footer */ | 2374 | /* footer */ |
2364 | size = sizeof (m->footer); | 2375 | if (need_sign) |
2376 | size = sizeof(m->footer); | ||
2377 | else | ||
2378 | size = sizeof(m->old_footer); | ||
2379 | |||
2365 | end += size; | 2380 | end += size; |
2366 | ret = read_partial(con, end, size, &m->footer); | 2381 | ret = read_partial(con, end, size, &m->footer); |
2367 | if (ret <= 0) | 2382 | if (ret <= 0) |
2368 | return ret; | 2383 | return ret; |
2369 | 2384 | ||
2385 | if (!need_sign) { | ||
2386 | m->footer.flags = m->old_footer.flags; | ||
2387 | m->footer.sig = 0; | ||
2388 | } | ||
2389 | |||
2370 | dout("read_partial_message got msg %p %d (%u) + %d (%u) + %d (%u)\n", | 2390 | dout("read_partial_message got msg %p %d (%u) + %d (%u) + %d (%u)\n", |
2371 | m, front_len, m->footer.front_crc, middle_len, | 2391 | m, front_len, m->footer.front_crc, middle_len, |
2372 | m->footer.middle_crc, data_len, m->footer.data_crc); | 2392 | m->footer.middle_crc, data_len, m->footer.data_crc); |
@@ -2390,6 +2410,12 @@ static int read_partial_message(struct ceph_connection *con) | |||
2390 | return -EBADMSG; | 2410 | return -EBADMSG; |
2391 | } | 2411 | } |
2392 | 2412 | ||
2413 | if (need_sign && con->ops->check_message_signature && | ||
2414 | con->ops->check_message_signature(con, m)) { | ||
2415 | pr_err("read_partial_message %p signature check failed\n", m); | ||
2416 | return -EBADMSG; | ||
2417 | } | ||
2418 | |||
2393 | return 1; /* done! */ | 2419 | return 1; /* done! */ |
2394 | } | 2420 | } |
2395 | 2421 | ||