diff options
author | Nicolas Dichtel <nicolas.dichtel@6wind.com> | 2019-09-06 05:47:02 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-09-10 04:10:53 -0400 |
commit | 94a72b3f024fc7e9ab640897a1e38583a470659d (patch) | |
tree | 1e4c34b726450eed9c0ff2d450c80aca59239941 /net/bridge | |
parent | c8dc55956b09b53ccffceb6e3146981210e27821 (diff) |
bridge/mdb: remove wrong use of NLM_F_MULTI
NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end.
In fact, NLMSG_DONE is sent only at the end of a dump.
Libraries like libnl will wait forever for NLMSG_DONE.
Fixes: 949f1e39a617 ("bridge: mdb: notify on router port add and del")
CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
-rw-r--r-- | net/bridge/br_mdb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index bf6acd34234d..63f9c08625f0 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c | |||
@@ -437,7 +437,7 @@ static int nlmsg_populate_rtr_fill(struct sk_buff *skb, | |||
437 | struct nlmsghdr *nlh; | 437 | struct nlmsghdr *nlh; |
438 | struct nlattr *nest; | 438 | struct nlattr *nest; |
439 | 439 | ||
440 | nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI); | 440 | nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0); |
441 | if (!nlh) | 441 | if (!nlh) |
442 | return -EMSGSIZE; | 442 | return -EMSGSIZE; |
443 | 443 | ||